{ "test_bleu_4": 0.004091520889980642, "test_exact_match": 0.0, "test_rouge": { "rouge1": 0.09527372102658346, "rouge2": 0.00927058228651916, "rougeL": 0.08024281916578213, "rougeLsum": 0.0801974847606097 }, "test_bertscore": { "precision": 0.8199027331661528, "recall": 0.8291070405472601, "f1": 0.8238324041457546 }, "test_meteor": 0.082289379010626, "raw_data": [ { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "can we also test for `transport=rest`?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug.", "reference": "If record_batch_size is not set in config.ini, this code will trigger a notice about an undefined value. I would suggest either wrapping the setPageSize() call in an `if (!empty(...)) {` check, or else providing a default value in the set call (i.e. `$config->Index->record_batch_size?? 100`)." }, { "prediction": "I don't think this is what you're trying to do, but it's worth noting that this is what you're trying to do.", "reference": "I didn't realize we were hardcoding this, thanks for moving it to an env value." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug. I'm not sure if this is a bug, but I think it's a bug.", "reference": "We are trying to support IE 10-11, so we'll need a polyfill for this one, I think." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "It looks like there's a new `isNavigatingTo( url )` selector for this very purpose so let's use this here instead. This way we just need to use the one selector rather than two. Let's assign that to a similar-named variable here (e.g. `isNavigatingToPostResetURL`) rather than the prop it's used with." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "I think im2col should only accommodate CPUMat." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "alpha sort the imports" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Can you explain why is this necessary? Is `snprintf()` with four integer arguments unsafe?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug. I'm not sure what you're trying to do here, but I'm guessing it's a bug.", "reference": "How likely would it be that the keyboard layout for the NVDA main thread differs from the keyboard layout of the currently focused app?" }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to create a new driver instance. I'm not sure what you're trying to do here, but I'm guessing you're trying to create a new driver instance. I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`)" }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it.", "reference": "Also update line 2205 below" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "n_: It is a good practice to name the variable to indicate what they contain. In this case since `shared` is supposed to have boolean, calling it: `isShared` can help in the readability of the code." }, { "prediction": "The `freezeColumn()` method doesn't re-render the table, so you need to call `render()` method afterward. The `freezeColumn()` method doesn't re-render the table, so you need to call `render()` method afterward. The `freezeColumn()` method doesn't re-render the table, so you need to call `render()` method afterward. The `freezeColumn()` method doesn't re-render the table, so you need to call `render()` method afterward. The `freezeColumn()` method doesn't re-render the table, so you need to call `render()` method afterward. The `freezeColumn()` method doesn't re-render the table, so you need to call `render()` method afterward. The `freezeColumn()` method doesn't re-render the table, so you need to call `render()` method afterward.", "reference": "I suppose it's a false-positive error. Maybe there is a way to configure the `eslint-*` package to accept `i.e..... lower case` syntax" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "this maynot be a perf issue, if ToHexString() is not actually allocating a string, but returns the caches string value. to be confirmed." }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "`zap.String(\"image-provider\", provider.Name())` should be in a same line." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Why this deletion?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's worth noting that this is what you're trying to do.", "reference": "This change looks unrelated to the CL description?" }, { "prediction": "I'm not sure if this is a bug, but I think it should be fixed.", "reference": "I'm not certain that `res`+`utl` isn't a thing." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "This method can cause bugs. Why don't you use list of finalize statuses and then use join by comma and that will give you correct value. Use Apache Commons Lang library List list = Arrays.asList(1,2,3,4,5,6,7); String str = org.apache.commons.lang.StringUtils.join(list, \",\"); You can use it at multiple places shown in this diff." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Merge with next condition" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Maybe add it when it is used." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing you're looking for something like this:", "reference": "More clear naming: NONEXISTENT_ENABLED" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "why is this change necessary?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "make a SchemaTypeNameConverter.getTypeNameForEmptyType() and call that here." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the right way to do it.", "reference": "Use braces on your conditional structures please" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Great God, I have a question. This \".nebula_history\" file is used to save history commands. Is there a file size limit? When the file is large, does it take a long time to start initialization (loadHistory)? How did you think about this? Thx." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Isn't this the same check as two lines above?" }, { "prediction": "I'm not sure what you're trying to do, but I think it's a good idea.", "reference": "Don't redefine, just import the existing one in `cmdline.py`. :)" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "why not call `respond_to?(\"#{name}=\")` from the `if` line?" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "This was properly set above as `.runfiles/` (with a fallback to workspace root dir) but never used past this line." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for.", "reference": "Are all these namespaces required for this attribute?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Given this may be used and printed in other ways, isn't `debug` more appropriate?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Looks like this is unused? Did you mean to call it when clearing the block journal?" }, { "prediction": "I'm not sure if this is the correct way to do this, but I think this is the correct way to do it.", "reference": "why named alters? how about this.alerts = alerts?" }, { "prediction": "I'm not sure if this is a bug, but if it's a bug, it's a bug. If it's a bug, it's a bug. If it's a bug, it's a bug. If it's a bug, it's a bug. If it's a bug, it's a bug.", "reference": "not sure if this has to be here or not tbh" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "There's a better fix for this in #1741, which should replace this." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Use swarm.Address not []byte as type, and construct it from actual byteslice or use swarm.NewAddress if it is constructed from hex-encoded string." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's just a bug, or if it's a bug, I'm not sure.", "reference": "It would be worth factoring this out to a function, but you don't have to do that here." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "There's no need for `final` in interfaces." }, { "prediction": "Is this the case? If so, why not?", "reference": "Isn't this case handled as a custom tag in `Span.SetTag()` below? This switch is only for special tags that actually set `Span` properties." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This shouldn't be changed." }, { "prediction": "This file is part of Invenio. It is part of the GNU General Public License. It is not part of the GNU General Public License. It is part of the GNU General Public License. It is not part of the GNU General Public License. It is part of the GNU General Public License. It is not part of the GNU General Public License. It is part of the GNU General Public License. It is not part of the GNU General Public License. It is part of the GNU General Public License. It is not part of the GNU General Public License. It is part of the GNU General Public License.", "reference": "This one is important `2: I102 copyright year is outdated, expected 2014 but got 2012`" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Are these imports needed (BiConsumer and Consumer)? If they are unused imports, then precommit will fail." }, { "prediction": "I think this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Why are we catching and logging exceptions? By doing that we make it look like the job has succeeded and it will be removed from the queue - if we didn't do that then it would stay queued..." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "If there are `@param` tags in docblock, there should be `@return` tag also. (applies for a whole file)" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Is the concept of validators exclusive to IBFT2? I wonder if this category should be more explicitly linked to IBFT2." }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but I'm sure it's a bug.", "reference": "Spotless is configured to reject star imports. Please replace with explicit imports." }, { "prediction": "I'm not sure if this is the correct way to do it, but if it's the correct way to do it, then it's just a bug.", "reference": "Remind me why you are using CUDA vocabulary when naming these variables." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Please turn the iteration order around (instead of `0...size` to `size...0`). The reason is that this sometimes skips indices when removing an item. You can therefore end up with feeds that have counter 0 and are still displayed." }, { "prediction": "I'm not sure if this is the correct way to do it, but it seems to be the correct way to do it.", "reference": "this is a behavior change. solid_subset=[] represents an empty pipeline where as solid_subset=None is the full pipeline" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "this is a breaking change, any specific reason you want to do this?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Blocking: we still want read write separation. Node functions should absolutely not write to the chain store and the interface should reflect that. Only the syncer should have this capability in production code. It should be no problem to keep casting chainForTest to a read-write interface, or doing other function decomposition and automatic casting tricks." }, { "prediction": "This is not a bug, but it is a bug.", "reference": "The PR description says the lowest on-demand request priority is `2^30`. Why the `-1` here?" }, { "prediction": "Is there a way to remove a creature from the game?", "reference": "checking health again? I think it is not necessary." }, { "prediction": "I'm not sure if this is a bug, but it should be fixed in the latest release.", "reference": "Need an `if err == nil {break}` above this line so that we don't log/sleep if the retry succeeds." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and you're trying to do something like this, which is not what you're trying to do.", "reference": "to reiterate my point above, this class is not the actual provided Promise, but rather something a user can provide a Promise to/with. I think a name like `PromiseProvider` is more appropriate." }, { "prediction": "I don't think it's a bug, but I think it's a bug.", "reference": "I guess we can only call this from a post-build function, but we might need to check that this target is to be built? I guess target A depends on B which has a post build. We `plz build :B` which adds C as a dep of A. Won't we queue C to be built even though it only needs to build if A needs to be built? That's kinda why I approached this the way I did. I trust you've thought about this but would be good to understand this a bit better." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "You should use `isinstance()` instead of comparing the class name to a string." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Why should audio and video elements always return `false` for `isHidden`?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm correct, but I'm not sure if I'm correct, or if I'm wrong.", "reference": "This obviously won't work for all the other platforms." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Isn't he diamond operator Java7+?" }, { "prediction": "public static int positive(String argName, Integer number) { return positive(argName, number, null); } public static int positive(String argName, Integer number, String message) { return positive(argName, number, message); } public static int positive(String argName, Integer number, String message) { return positive(argName, number, null); } public static int positive(String argName, Integer number, String message) { return positive(argName, number, message); } public static int positive(String argName, Integer number, String message) { return positive(argName, number, null); }", "reference": "Prefer adding a second `positive(String, double)` that delegates down to this three-param version. Using `null` in code is generally Not A Great Idea, and it looks ugly." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "This pattern, where we add a new parameter without using it, often indicates to me that we've got a leaky interface or abstraction. I see this pattern _a lot_ in this patch, so wondering you have thoughts about it." }, { "prediction": "I'm not sure if this is the correct way to do it, but if it's the correct way to do it, then it's not the correct way to do it, but it's the correct way to do it.", "reference": "This seems like an improved pattern :)" }, { "prediction": "The OpenID provider reenters here and we need to pass the parameters through to the open_id_authentication function. So we need to pass the parameters through to the open_id_authentication function. So we need to pass the parameters through to the open_id_authentication function. So, we need to pass the parameters through to the open_id_authentication function. So, we need to pass the parameters through to the open_id_authentication function. So, we need to pass the parameters through to the open_id_authentication function. So, we need to pass the parameters through to the open_id_authentication function. So, we need to pass the parameters through to the open_id_authentication function. So, we need to pass the parameters through to the open_id_authentication function. So, we need to pass the parameters through to the open_id_authentication function. So, we need to pass the parameters through to the open_id_authentication function.", "reference": "`open_id_authentication` is no longer the name of the function, and it's not OpenID specific" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "This didn't require corresponding changes to the test case(s)?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "A question! I think `string` totally works, but what do you think of `*string` for consistency?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Should this be: `aws.infrastructure.cluster.sigs.k8s.io` instead?" }, { "prediction": "I think this is a bug in the G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G G", "reference": "Not clear on why this change is correct." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's", "reference": "Hi Simon. Whether this should return true depends on what byte buffers are used? The same applies to ByteBufferIndexInput, actually... I don't think you can generally tell whether the ByteBuffers the input operates on come from a mmap call or from somewhere else (even direct buffers don't have to be a result of mmap)." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "All stories in this file also need to have the default padding." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "I don't think these asserts are necessary, because `subsurface_find_sibling` already searches in the parent. Or am I missing something?" }, { "prediction": "I think you're looking for the `published_on` method. I think you're looking for the `published_on` method. I think you're looking for the `published_on` method, but I'm not sure if that's what you're looking for.", "reference": "Should this be `number` instead of `id`?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm guessing it's what you're trying to do.", "reference": "I have forgotten why we thought this restriction is necessary. A user registers a Hive/HBase table with us but is not able to use the table with the registered name in DML. Will UPDATE STATs will be on the original name too (and update stats code will find out registered name and use it for Table_uid?). This was the registration concept is almost like an internal implementation idea, at some point could even be done by some utility program for all existing Hive/hBase tables, and the user need not be aware of it? I am struggling with a user would want to register a table, if they cannot use it by that name." }, { "prediction": "This is a ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````", "reference": "Should most of these non-globals be static?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Please do not approve PRs without tests!!!!" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "Now that you handle this in `webenginetab.py` you can undo all the changes in this file." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "I think we should log the exception to a log file instead of printing it. The current behavior (not catching the exception) should lead to an automatic print of the exception to the terminal/console." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "These changes to the resource helpers have some more far-reaching implications as they also affect calls made in hive-operator, I believe. It's probably OK still, though. Ideally, the resource helper would not be the one doing the logging, since it cannot know the severity, but that is well beyond something that we should tackle for this PR. I would rather have the hive-operator log warnings than have the syncsetinstance controller log errors." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "do you really want to change the behavior on foreign key?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Looks like my bad. Thanks for fixing!" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "I think \"Don't replace variables...\" would be cleaner." }, { "prediction": "The projection of the plot axis is not supported. The projection of the plot axis is not supported. The projection of the plot axis is not supported. The projection of the plot axis is also supported. The projection of the plot axis is also supported. The projection of the plot axis is also supported. The projection of the plot axis is also supported. The projection of the plot axis is also supported. The projection of the plot axis is also supported. The projection of the plot axis is also supported. The projection of the plot axis is also supported. The projection of the plot axis is also supported. The projection of the plot axis is also supported. The projection of the plot axis is also supported. The projection of the plot axis is also supported.", "reference": "Do you validate the possible strings? I've not read the code below but we should make sure if a string is supplied it is validate..." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug. I'm not sure if this is a bug, but I think it's a bug.", "reference": "I'd recommend using generateDataDiskName here as well -- might as well benefit from the safety that it gives to protect yourself from future changes to w.ID()." }, { "prediction": "I think this is what you're looking for.", "reference": "qq: do we want to include anything in the name to indicate that it is a position in the manifest?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, I'm sure it's a bug.", "reference": "These logs should probably use the `LOGTAG`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "From this, it was clear, that we are using our version of wireguard-go. And now it looks like we are using original packages which is confusing." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Any particular reason for this? This potentially will make harder to investigate users issues" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's", "reference": "Do you also need to check if Blockly.localConnection_ is non-null?" }, { "prediction": "I think this is a bug in RSpec::Core::Hooks. I'm not sure if it's a bug, but it's a bug in RSpec::Core::Hooks. I'm not sure if it's a bug in RSpec::Core::Hooks, but I'm not sure if it's a bug in RSpec::Core::Hooks.", "reference": "Not really a container, and it's not just about non-config data, not sure of a better description, @myronmarston?" }, { "prediction": "I'm not sure if I'm correct, but if I'm correct, I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "The desktop app will load this fine. on iOS I get `TypeError: undefined is not an object (evaluating '_$$_REQUIRE(_dependencyMap[8], \"stream\").Readable.Readable')` if I change it to `const Readable = require('stream').Readable;` or `const { Readable } = require('stream');` I get undefined errors from the stream on iOS: `[TypeError: stream.on is not a function. (In'stream.on(\"data\", function (chunk) { return chunks.push(chunk); })','stream.on' is undefined)]` What am I missing?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "this is needed since the chunk feeder shares memory across calls to the pipeline. this is in order to avoid multiple allocations. this change mimics the behavior of shed and localstore, and copies the data from the call into the in-memory store" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "wut. We can do this at the beginning of tests if we want right? Why are we depending on init?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Same trick here IMO." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Should be `@origin = element || origin || POINTER`" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "this example needs a fix?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Is it safe to assume this surface is a toplevel?" }, { "prediction": "Is this a bug? If so, what is the purpose of this?", "reference": "we don't need that function" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "we'll also have to think about adding \"Windows Server 2014\" or whatever they come up with later." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "curious do we have an API to fetch an inactive flow?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "This branch is not needed anymore because every `vnode` that passes through `h` in compat or core will have the `$$typeof`-property now." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Did you mean to use `hasAttribute`? You shouldn't. This does not improve performance and it messes with the readability." }, { "prediction": "I think this is a bug in qutebrowser.config.py. It should be removed from qutebrowser.config.py. It should be removed from qutebrowser.config.py. It should be removed from qutebrowser.config.py. It should be removed from qutebrowser.config.py. It should be removed from qutebrowser.config.py. It should be removed from qutebrowser.config.py. It should be removed from qutebrowser.config.py. It should be removed from qutebrowser.config.py. It should be removed from qutebrowser.config.py. It should be removed from qutebrowser.config.py.", "reference": "Please import modules and not classes (except for Qt stuff)." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Hm... why do we have a \"DummyJavaNode\" in src/main? Looks like, this should have gone into src/test...." }, { "prediction": "I'm not sure what you're trying to do here, but I think it's a good idea.", "reference": "This seems meaningless. If we cannot add any info let us remove this." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Can you rename `Ports` to `PortsUnsafe`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "This feels like it could be moved out to your first gem!" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "The expected behaviour for `poll` would be to match what `Deque` does, which is: > Retrieves and removes the head of the queue represented by this deque As such, you shouldn't need the `RequestId` here." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "This is super minor, but it'd be nice if this iterated over an arbitrary number of array inputs." }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "What is the problem here? The commit message has strange wording \"readlink is defined with restrict pointers\": do you mean \"restricted\"? Is that a well-defined language term? I'm not sure what it means." }, { "prediction": "The NameFormatter for Ruby is deprecated in favor of the `NameFormatter` for the `NameFormatter` for the `NameFormatter` for the `NameFormatter` for the `NameFormatter` for the `NameFormatter` for the `NameFormatter` for the `NameFormatter` for the `NamePath` for the `NamePath` for the `NamePath` for the `NamePath` for the `NameFormatter` for the `NamePath` for the `NamePath` for the `Name` for the `NameFormatter`.", "reference": "Why are we not wrapping here?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug in Shopsys\\FrameworkBundle\\Model\\Product\\Parameter\\Parameter. I'm not sure if it's a bug, but it's a bug in Shopsys\\FrameworkBundle\\Model\\Product\\Parameter\\Parameter.", "reference": "I though that all data objects are being unified in the fashion where all default values are initialized in constructor, are not they?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug, and it's a bug, so it's a bug.", "reference": "Does this file actually need to be committed to git? Having to run `make generate` is rather tedious on each PR and it conflicts easily." }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if it's the correct way to do it.", "reference": "We don't need this anymore, as Google's library handles various auth mechanisms for us. We'll be less explicit about why we're failing but we gain support for several authentication methods- swings and roundabouts!" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "No need to speficy attribute here. Moreover in yaml it is default to use lowercase names." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm sure it's a bug.", "reference": "In general I'm a trying to understand the reason behind this PR. Looks like if a blob (name) already exists we check if the contents are identical? In what scenarios this is not the case? When we want to publish a package/asset that has changed but still we want to use the same version?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Can rename `req` to be `opener`, since that is the object, and it wraps `req` internally?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for: linePrefix=attrs.get(\"line-prefix\") if linePrefix: textList.append(linePrefix) + breakpoint=attrs.get(\"breakpoint\") + if breakpoint: textList.append(breakpoint) if attrsCache is not None: attrsCache.clear() attrsCache.update(attrs)", "reference": "@MichaelDCurran, thoughts on adding a breakpoint format field attribute? It seems almost app specific, but I guess it does seem odd abusing line-prefix. Is there any more generic concept here?" }, { "prediction": "@property def rect(self): \"\"\"A dictionary with the size and location of the element.\"\"\" return self._execute(Command.GET_ELEMENT_RECT)['value'] + if self._w3c: + return self._execute(Command.GET_ELEMENT_RECT)['value'] + else: + return self.size, self.location @property def screenshot_as_base64(self): \"\"\"A dictionary with the size and location of the element.\"\"\" return self._execute(Command.GET_ELEMENT_RECT)['value'] + if self._w3c: + return self._execute(Command.GET_ELEMENT_RECT)['value'] + else: + return self.size, self.location @property def screenshot_as_base64(self): \"\"\"A dictionary with the size and location of the element.\"\"\" return self._execute(Command.GET_ELEMENT_RECT)['value'] + if self._w3c: + return self._execute(Command.GET_ELEMENT_RECT)['value'] + if self._w3c: + return self._execute(Command.GET_ELEMENT_RECT)['value'] + else: + return self.size, self.location @", "reference": "This would return a tuple of two dictionaries. You need to combine them and return a dictionary" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "What do you think of moving the example to the help text of the prompt? and the prompt itself can be \"What is your application's GitHub repository URL?\"" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure.", "reference": "Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Nice use of std::distance. I'm a bit worried about first += 9 though." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Shouldn't this be `app.kubernetes.io/managed-by` as prometheus-operator manages this resource, but this resource isn't a part of prometheus-operator?" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, then it's worth to check if it's what you're trying to do. If it's what you're trying to do, then it's worth to check if it's what you're trying to do.", "reference": "As long as we're being extra-vigilant about NREs, should we check that `httpMethod` and `requestUri` are not null?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing this is what you're looking for: \"github.com/iotexproject/iotex-core/cli/ioctl/cmd/node\" \"github.com/iotexproject/iotex-core/cli/ioctl/cmd/version\" \"github.com/iotexproject/iotex-core/cli/ioctl/cmd/version\" \"github.com/iotexproject/iotex-core/cli/ioctl/cmd/xrc20\" \"github.com/iotexproject/iotex-core/cli/ioctl/cmd/xrc20\" \"github.com/iotexproject/iotex-core/cli/ioctl/cmd/xrc20\" \"github.com/iotexproject/iotex-core/cli/ioctl/cmd/xrc20\" \"github.com/iotexproject/iotex-core/cli/ioctl/cmd/xrc20\" \"github.com/iotexproject/iotex-core/cli/ioctl/cmd/xrc20\" \"github.com/iotexproject/iotex-core", "reference": "No need to have `xrc20` alias" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this.", "reference": "the naming convention I'm been adopting if `_type` for instances of these classes. So maybe `context_config_type` is a better name for this fn" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Don't call it GPU mining, call it `externalMining`, here and throughout." }, { "prediction": "You can also use the'media' resource to specify the'media' resource. The'media' resource can also be used to specify the'media' resource. The'media' resource can also be used to specify the'media' resource. The'media' resource can also be used to specify the'media' resource.", "reference": "`within this with` typo, should be `within this width`" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "how come this is false?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "How about `Object.prototype.toString`? Or using the `typeof` operator?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "I know @jzila suggested this, but I disagree: you're really not supposed to save a context in a struct. Can you get by with just saving the `Done()` channel instead? The `ctx` should continue to be passed around explicitly." }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if this is the correct way to do it.", "reference": "This check isn't right though." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "maybe `toolkitVersion` instead? It doesn't necessarily have to be called that in the generated code, but in the view model classes, I think it makes it clearer that it is the version of toolkit itself." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "the response data was added intentionally in #612, i think we could keep the `setFileState` stuff here as a special case, at least for now" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "This isn't really easy to read." }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "This line changed due to go formatting. Format was not there earlier." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure if this is what you're trying to do.", "reference": "The name \"Without\" in code is a little nebulous. Maybe something more descriptive like TrimPrefix or StripPrefix or WithoutPathPrefix or something like that. (Thoughts?)" }, { "prediction": "I'm not sure if this is the expected behavior, but I'm not sure if it's the expected behavior.", "reference": "is this test in the move tests? I see what you mean then - it works, but I wonder if we won't lose track that it's being tested here." }, { "prediction": "The tags associated with the instance are not the same as the tags associated with the instance. The tags should be the same as the tags associated with the instance.", "reference": "I'm not sure if this wanted to be `json:\"tags\"` (which I'd set in my PR) or `json:\"tag\"` that someone elses PR had set. Given that the rest of the fields had their JSON field name set to the same as the struct field name, I opted for `tags`." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this should be enough.", "reference": "since the logic here and in `Proposal` is exactly the same, do you think it makes sense for us to include it elsewhere? I am not opposed to duplicated code when it makes sense, but the reason I first identified this was that I was looking for code in NCR::WorkOrder that was not specific to Work Orders. Seems like fiscal year logic might be helpful for reporting for other clients. In that case, we'd want this scope on those client data classes as well. Might be wrong to include this in the FiscalYear mixin, but it does seem like it should be outside of Proposal and WorkOrder. Does that make sense?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "there is no static method as a go between -- how does this work?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to use a stringified symbol as a stringified symbol. If you're using a stringified symbol as a stringified symbol, you'll want to use a stringified symbol as a stringified symbol. If you're using a stringified symbol as a stringified symbol, you'll want to use a stringified symbol as a stringified symbol. If you're using a stringified symbol as a stringified symbol, you'll want to use a stringified symbol as a stringified symbol.", "reference": "Can you please change the name of this class to be something else?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "I think we might prefer generalizing the interface rather than creating an exception. Current design of `h2o_next_token` assumes the input to be a comma-separated list, and allows the caller to specify a different separator when parsing a nested list. As I understand, what we are trying to attain in this PR is to have a way of parsing a flat list of semicolon-separated list. Assuming that is the case, I think it would be better to change the API of the function to accept two separators (i.e. inner and outer), where for our existing use-cases `outer` would be `,`." }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "why not recycling? I Lru cache now recycling?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for. I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for. I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for. If this is what you're looking for, I'm assuming it's what you're looking for.", "reference": "Why it is now called `PaymentVersionV3`?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it should be something like this:", "reference": "changed for debug purpose?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "@cijothomas I needed a way to set the Exporter.ParentProvider when the Processor's gets set. Internal to SDK though." }, { "prediction": "IsRampClass() or IsLinkClass()? I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Talking through this scenario with @srividyacb and she's wondering if there should also be a check of `(from_trunk && node_based_graph.GetEdgeData(eid).flags.road_classification.IsLinkClass())` as highways with trunk classifications can also have this scenario." }, { "prediction": "This will be overridden by other blocks being merged in. This will be overridden by other blocks being merged in. This will be overridden by other blocks being merged in. This will be overridden by other blocks being merged in. This will be overridden by other blocks being merged in. This will be overridden by other blocks being merged in. This will be overridden by other blocks being merged in. This will be overridden by other blocks being merged in. This will be overridden by other blocks being merged in. This will be overridden by other blocks being merged in.", "reference": "where does `master_certname` come from?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "The line breaking is unnecessary." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "why not enable split by space here?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Shouldn't the operator be &&?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be fixed in vagrant-multiprovider-snap.", "reference": "My best guess is that you want to use host.name in these parts to get the name of the host?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, and it's a bug.", "reference": "IMO this edge case handling could remain here, just instead of overwriting the `n.nodeType`, the `makeEdgeType` method of `n` should be called, so `n.nodeType = nodeTypeEdge` -> `n.makeEdge()`" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Just wondering... The two kinds of notifications are now quite different (Channel, text, maybe even icon). Would it make sense to extract the auto download notification to a new class instead of handling everything in the existing `notificationManager`? I have not checked if this will lead to a lot of code duplication, though." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Do we need to put this on the Call? We only need the API communication between the Encoding and the Transports which is currently done through the Transport.Request. The Call is used by users right?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "`ctx` is unused in GenerateAPIKey" }, { "prediction": "I'm not sure if this is a bug, but it seems to be fixed in the latest release.", "reference": "Can you judge the type of error?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Much simpler than a weird and confusing ``convolve`` call!" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and that's what you're trying to do. I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Huh, this seems weird to me... Surely the suspenders render was called again in order to get the new `
Hello second 2
` output... Imma take a peak at these tests to understand what's going on" }, { "prediction": "This is a bug in Rails. It should be fixed in Rails 3.x.", "reference": "Since this is just a helper function to create text, perhaps this could live in a helper? I noticed that we have a few other error/message creators in the application controller as well, but I think this type of function should be re-factored to be part of a helper." }, { "prediction": "This is a python new-style format string. This is a python new-style format string # used to format the message information. See doc for all details -#msg-template= +msg-template=[{msg_id}] {path}:{line:3d}:{column}: {msg} [SPELLING] {msg_id} {path}:{line:3d}:{column}: {msg} [SPELLING] {msg_id} {path}:{line:3d}:{column}: {msg} [SPELLING] {msg_id} {path}:{line:3d}:{column}: {msg} [SPELLING] {msg_id} {path}:{line:3d}:{column}: {msg} [SPELLING] {msg_id} {path}:{line:3d}:{column}: {msg} [SPELLING] {msg_id} {path}:{line:3d}:{column}: {msg} [SPELLING] {msg_id} {path}:{line:3d}:{column}: {msg} [SPELLING] {msg_id} {path}:{line:3d}:{column}: {msg} [", "reference": "Will this mess up parsing the messages by other editors? (vscode, vim...)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Why can the pool be null?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this.", "reference": "It might be good to have a note here: > work-around for issue #7562 allowing us to differentiate presentational lists from interactive lists (such as of size greater 1 and ARIA list boxes). In firefox, this is possible by the presence of a read-only state, even in content editable." }, { "prediction": "I think this is a bug. It's a bug. It's a bug. It's a bug. It's a bug.", "reference": "This set of changes is the one part of this that I'm not completely sure is valid. Can someone look over this to make sure I got the E's right?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do. I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "There doesn't seem to be a reason to copy this here." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "We've avoided including h2o headers in BPF programs because it's a runtime dependency. However, IIRC, this is because h2olog was maintained in the separate repository so that h2olog did not know where h2o was installed. Now h2olog can use `H2O_ROOT`, we should add it to BCC's `cflags` in order to include h2o headers in BPF programs." }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "I think the docstring here should include the CLI arg `--alert.query-url` just to make it clear to users which setting this uses." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a good idea.", "reference": "Same change just above?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's worth noting that this is what you're trying to do. I'm not sure if this is what you're trying to do, but it's worth noting that this is what you're trying to do. I'm not sure if this is what you're trying to do, but it's worth noting that this is what you're trying to do. I'm not sure if this is what you're trying to do, but it's worth noting that this is what you're trying to do. I'm not sure if this is what you're trying to do.", "reference": "Could you check the result content rather than just the number of search results please? For example with this test if the search engine suddenly starts returning \"latin n\" for both queries, we won't know about it." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, and it's a bug.", "reference": "nit: I think that `workloadID` should suffice for this test... that's what we'd be issuing anyways" }, { "prediction": "I'm not sure if you're using rails_helper or rails_helper, but if you're using rails_helper or rails_helper, then you'll need to do this in the rails_helper.rb file. If you're using rails_helper.rb, then you'll need to do this in the rails_helper.rb file. If you're using rails_helper.rb, then you'll need to do this in the rails_helper.rb file. If you're using rails_helper.rb, then you'll need to do this in the rails_helper.rb file. If you're using rails_helper.rb, then you'll need to do this in the rails_helper.rb file. If you're using rails_helper.rb, then you'll need to do this in the rails_helper.rb file. If you're using rails_helper.rb, then you'll need to do this in the rails_helper.rb file. If you're using rails_helper.rb, then you'll need to do this in the rails_helper.rb file. If you're using rails_helper.rb", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "We should have a rule to detect identical catch branches" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this: I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "remove these from the targets file." }, { "prediction": "\"github.com/ethersphere/bee/pkg/p2p\" \"github.com/ethersphere/bee/pkg/p2p/protobuf\" \"github.com/ethersphere/bee/pkg/p2p/protobuf\" \"github.com/ethersphere/bee/pkg/p2p/protobuf\" \"github.com/ethersphere/bee/pkg/p2p/protobuf\" \"github.com/ethersphere/bee/pkg/p2p/protobuf\" \"github.com/ethersphere/bee/pkg/p2p/protobuf\" \"github.com/ethersphere/bee/pkg/p2p/protobuf\" \"github.com/ethersphere/bee/pkg/p2p/protobuf\" \"github.com/ethersphere/bee/pkg/p2p/protobuf\" \"github.com/ethersphere/bee/pkg/p2p/protobuf\" \"github.com/ethersphere/bee/pkg/p2p/protobuf\" \"github.com/eth", "reference": "now that we have the signature in the hive messages, it might be that this must be drastically reduced, since there are limits on the protobuf reader/writers i believe" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems to be a bug.", "reference": "I recommend that we move this to be optional, as other users might not need it. Can you look at `OPTIONAL_PACKAGES` section, around line 68?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "I usually set idea to never use wildcard import such as `import java.util.*;` Now i use setting from javaslang standard." }, { "prediction": "I'm not sure why you're getting this error, but I'm not sure why you're getting this error. I'm not sure why you're getting this error, but I'm not sure why you're getting this error. I'm not sure why you're getting this error, but I'm not sure why you're getting this error.", "reference": "Where is host['ips'] coming from?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "oh! missed a `:` here; let me fix that; also can get rid of the intermediate variable" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Is this necessary?" }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "I'd create a different method for each render section." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Instead of storing the revert flag in the tracer is it possible to use org.hyperledger.besu.ethereum.mainnet.TransactionProcessor.Result#getRevertReason? (via org.hyperledger.besu.ethereum.transaction.TransactionSimulatorResult#getResult)? If a TX reverts without a reason do we get an empty revert reason or a revert reason with zero bytes?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "I think this should test with and without container reuse if that is implemented in this PR. Probably just make this test parameterized." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "These modifications allow BaseFile to translate into a SparkRow with the specID as a column" }, { "prediction": "Why not just return readPreference; instead of return readPreference;? Why not just return readPreference; instead of return typeof readPreference ==='string'? new ReadPreference(readPreference) : readPreference;", "reference": "is this something we've been missing this whole time?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "nit: this is a package-wide constant so better to narrow the scope like `allEventsSign`." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "There seems to be some repetition. Does a local function make this code shorter overall?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Might be cheaper to reuse the `null` assignment of line 313 and set `isHydrating` to null instead WDYT?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Revert this blank line" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "This was introduced recently for the Hadoop 3 upgrade. Copy/paste error but definitely causing some of the new test failures." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I think we should only need to do this for `:approve` since we are using `authenticate_user!` for all other actions and that checks for disabled client" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this: https://docs.djangoproject.com/en/dev/ref/models/querystring-parameters/", "reference": "I wonder if we should create new tests for header checks; here for instance we're mixing querystring and headers. Thoughts?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "We should be able to add sensitive by hard-coding the parameters, same as you put into the metadata in apply_helpers." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Why do you think that it is necessary to create this class?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "replacing the `1` with `io.SeekCurrent` may be good here" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "nit: perhaps this file would be better named `jwks_source.go`?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "It will be helpful to specify the intended priority as well for the properties within this file." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Make this private and update all the public functions to not take this argument. The variable you set below should also be private, then in the tests instead of passing the variable in to the function just update the variable. We don't want to expose the testing implementation in the public api if it can be avoided." }, { "prediction": "I'm not sure if this is the case, but if it's the case, then it's the case.", "reference": "Do you now why is it a specific table name is used as a default?" }, { "prediction": "I'm not sure if this is the case, but if it's the case, I'm not sure if it's the case, but if it's the case, I'm not sure if it's the case, but if it's the case, I'm not sure if it's the case.", "reference": "If all you're doing is checking for the existence of a directory as your \"temp\" directory, why does it matter what OS you're on?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "nit- would be cleaner to import it once" }, { "prediction": "I think this is what you're looking for. I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "Looks like there is a closing parenthesis `)` missing here." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "this one bothers me. There are many places where this one is written to for an error message and just a single callsite is changed." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "You can put this in `kbfsOpsInit()` in you want, so we don't have to call it in every test." }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "`ARM_32` is what clients define as an input to DR, and is not always defined internally: we use just `ARM` to mean AArch32." }, { "prediction": "This is a ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "s/for use/to use for/" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "` $event->getAvatarFilename()` this function return `string` or `null`. In this place ` $event->getAvatarFilename()->getValue()` return `Fatal error `" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm guessing it's a bug.", "reference": "why not creating a new error type for server's own resource limit exceed error and do conversion within rpc interceptor?" }, { "prediction": "I'm not sure if this is the case, but I think this is the case. I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "Could be a timing thing here. When options are created they'll copy the ref for the current default propagator. If user sets through SDK the global propagator after that, it won't be reflected. Could leave it null here and then when it is used in instrumentation do `options.Propagator?? Propagators.DefaultTextMapPropagator`. It would be a slight perf hit but it makes it hot-swappable." }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if this is the correct way to do it.", "reference": "Unrelated file. Please remove from PR." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Careful: you only want two newlines after the final header message. (That indicates the end of headers and the start of data.)" }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "This will not work on Python 3 (to which we are transitioning) because `.content` is bytes, not a str. Can you make the pattern a bytes object as well (like so: `b\"pattern\"`)?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "This was to allow the tests to pass when the order of the required was different. Silly, but we don't have an easy way to check for \"equal but order doesn't matter\" in chai." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm wrong.", "reference": "maybe say \"returns the default cost method that returns an object of cost 1\"." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I believe these rules will be enforced both (1) on egress from a local workload, and (2) on ingress **to** a local workload. Right? I understand that we definitely want (1), but do we really want to enforce (2) as well?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if it's the correct way to do it, so I'm not sure if it's the correct way to do it.", "reference": "Use `response.asJsonObject()` instead. Also, use `put()` instead of `putOpt()`, `null` as a value is fine." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Are you sure? We've changed it during an introduction of the IME support." }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it, so I'm not sure if this is the correct way to do it.", "reference": "I think here we want the use of `empty()` to take care of empty strings. If you put `dql_filter: ''` in your YAML config... this will add `->andWhere('')` and it will fail, right?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "this is golang's named return, err is defined, `return` is equivalent to `return err` the current code has no problem" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I don't think this is right; in Rust terms it's like a `&mut String`, in Java `StringBuilder` - it's not a return value from the function which is what `(out)` is for." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this. I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "If the label is not binary, should we rename this function?" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "This is very-very bad idea because of its performance impact" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "WHY U NOT SORT IMPORTS?" }, { "prediction": "I think this is what you're looking for: https://docs.djangoproject.com/en/dev/ref/contrib/sessions/", "reference": "Put a comma after the last item of a multiline hash." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "How come we need ``Dimensioned`` in the top-level namespace?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "excess whitespace through plugin." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "What is the problem here? I feel we used this in a lot of places." }, { "prediction": "I'm not sure, but I think it's a bug.", "reference": "Update the docstring." }, { "prediction": "I'm not sure if this is what you're looking for, but it looks like you're looking for something like this: https://github.com/golang/mock/gomock/blob/master/github.com/golang/mock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/gomock/g", "reference": "delete the empty line \"github.com/pkg/errors\" should be grouped with other third party packages same for the rest" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Assigning capabilities to the field here is not the best idea. Semantically this field contains the capabilities returned by the browser after session start. So here we sould better amend capabilities and return them from `init` method to pass later to `startSession` method (that will assign the capabilities returned by the browser to the field)." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Is this a breaking change, or is the API private?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I don't think we need this dependency in this project right now" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "I don't think this is necessary since `CommonLabels` is a public func and every component name is also public constant." }, { "prediction": "When a target's name is `localhost`, the ````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````", "reference": "The `_example` field should be updated to include an interpreter with an array value." }, { "prediction": "I'm not sure if this is the case, but it's the case. I'm not sure if this is the case, but it's the case.", "reference": "Put this in the godoc of SupportedProtocols instead. Preferably we would just use one map though. Why not just use this one?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I'd feel a little safer if the first argument were a string, not a *string unless there's a particular reason for making it a pointer." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems to be a bug.", "reference": "You can safely revert changes to this file." }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this.", "reference": "This deletion is unnecessary." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I'm sure it's what you're looking for.", "reference": "I'm not a huge fan of this overloading of the prop; accepting very different types of arguments for props like this can be confusing, and wasn't part of the IB. I understand wanting to import the SVG directly, but the IB suggests using `${global._googlesitekitLegacyData.admin.assetsRoot}${userInputSuccessImage}` as the `src`/`smallImage` value here. It'd be great to refactor this to accept components directly in the future, but let's do that all-at-once rather than this hybrid approach that makes the API less clear." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "I've had this happen recently with IntelliJ, was this intentional?" }, { "prediction": "#include #include #include #include \"vulkan/vulkan.h\" #include \"vk_format_utils.h\" #include \"hash_util.h\" #include \"hash_util.h\" struct VULKAN_FORMAT_INFO { size_t size; }; #include \"vk_format_utils.h\" #include \"hash_util.h\" #include \"hash_util.h\" #include \"hash_util.h\" #include \"hash_util.h\" #include \"hash_util.h\" #include \"hash_util.h\" #include \"hash_util.h\" #include \"hash_util.h\" #include \"hash_util.h\" #include \"hash_util.h\" #include \"hash_util.h\" #include \"hash_util.h\" #include \"hash_util.h\" #include \"hash_util.h\" #include \"hash_util.h\" #include \"hash_util.h\" #include \"hash_util.h\" #include \"hash_util.h\" #include \"hash_", "reference": "Order(1) vs Order(logN) -- not sure it's measurable at the ~200 element size of the table. All of the published comparisons start at ~1000 elements." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this: \"github.com/mysteriumnetwork/node/core/node\" \"github.com/mysteriumnetwork/node/core/node\" \"github.com/mysteriumnetwork/node/core/node\" \"github.com/mysteriumnetwork/node/core/node/core/node\" \"github.com/mysteriumnetwork/node/core/node/core/node\" \"github.com/mysteriumnetwork/node/core/node/core/node\" \"github.com/mysteriumnetwork/node/core/node/core/node\" \"github.com/mysteriumnetwork/node/core/node/core/node\" \"github.com/mysteriumnetwork/node/core/node/core/node\" \"github.com/mysteriumnetwork/node/core/node/core/node\" \"github.com/mysteriumnetwork/node/core/node/core", "reference": "I don't know about this aliasing and 'factory'. Previous version was rather straightforward: `location.CreateLocationResolver`. Perhaps `location.CreateResolver` would be even better? What do we actually gain here from moving DI to a separate sub-package?" }, { "prediction": "should we use `std::string` instead of `std::string`?", "reference": "Use `UpperCamelCase` for function names" }, { "prediction": "I'm not sure if this is the case, but if it's the case, it's the case.", "reference": "I'm not 100% sold on this idea but I like it in general. Nice compromise between using the 'Date' constructor where possible and falling back to the pre #5880 behavior when it makes sense. However, instead of `Number(value) < 0`, let's do `Number(value) < MIN_YEAR` because `new Date('-2017')` is perfectly valid in JS and I don't want to break the date behavior." }, { "prediction": "I don't think this is a bug, but it's a bug, and it's a bug.", "reference": "Remember to close SOLR-11877 after this" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "this change should be reverted" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so it's a bug.", "reference": "This function signature is a bit complicated, some parameters are IN type (stopLoop which is modified from outside), others are OUT (registeredEvent channel which is modified inside function) I suggest the following signature -> SubscribeToRegistrationEvent(identityAddress) returns registeredEvent chan of type (RegisteredEvent not int), Unsubscribe func(), error (in case of any error). That way caller can always cance subscription if needed and check for any errors. Also - unsubscribe function hides any internal details how subscribtion is really implemented" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like'src/**/*.png','src/**/*.gif','src/**/*.svg','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav','src/**/*.wav', '", "reference": "`.wav`?! cannot we use something slightly more modern and compressed instead? :) I dunno, like `.mp3` or `.aac` or `.ogg`..." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug in luaA_class_emit_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_signal_", "reference": "Wouldn't a single signal call be enough? (without the boolean even)" }, { "prediction": "@note_comments.find { |comment| comment.author.nil? } -%> <%= note_comments.find { |comment| comment.author.nil? } %> <% end %>
<%= note_comments.find { |comment| comment.author.nil? } %> <%= note_comments.find { |comment| comment.author.nil? } %> <%= note_comments.find { |comment| comment.author.nil? } %> <%= note_comments.find { |comment| comment.author.nil? } %> <%= note_comments.find { |comment| comment.author.nil? } %> <%= note_comments.find { |comment| comment.author.nil? } %> <%= note_comments.find { |comment| comment.author.nil? } %> <%= note_comments.find { |comment| comment.author.nil? } %> <%= note_comments.find { |comment| comment.author.nil? } %> <%= note_comments.find { |comment| comment.author.nil? } %> <%= note_comments.find { |comment| comment.author.nil? } %> <%", "reference": "I suspect that this whole block, which is going to be repeated a number of times, should probably be in a helper. I guess it would need to be given the object and the title and could probably figure out everything else from that?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Should we expose this attribute in the Asciidoctor.js API?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I think contains on `Multimap` was broken - it should return true if one of the values is associated with the key? It that right" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "delete this line" }, { "prediction": "I think this is what you're looking for.", "reference": "Presumably we no longer need `force: true` here." }, { "prediction": "I don't think this is a bug, but it's a bug, so it's a bug.", "reference": "HIP runtime is compiled using a C++ compiler. So comparison to both NULL as well as 0 does not make sense. Just comparing to NULL is sufficient." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "these urls are still in `a` tags so we should probably include these links separately for a non-HTML version" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, so I'm not sure if it's the case. I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case. I'm not sure if it's the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "That's fine though, meaning that you can send to this channel under the server lock. The internalSendLoop will pick up the change when the server lock is released (if loop is blocked trying to grab the server lock). Even the way you do it here (releasing the lock, sending, then reacquiring) does not guarantee that the internalSendLoop will have time to refresh in that interval." }, { "prediction": "I'm not sure if this is what you're looking for, but it's what we're looking for.", "reference": "The name `enableDownloading` implies this is a boolean capability. How about `downloadDir`?" }, { "prediction": "The ValidatorManager should not have any default validator. It should have a default validator. This is the default validator of the ValidatorManager. This is the default validator of the ValidatorManager. This is the default validator of the ValidatorManager. This is the default validator of the ValidatorManager. This is the default validator of the ValidatorManager. This is the default validator of the ValidatorManager. This is the default validator of the ValidatorManager. This is the default validator of the ValidatorManager. This is the default validator of the ValidatorManager. This is the default validator of the ValidatorManager. This is the default validator of the ValidatorManager. This is the default validator of the ValidatorManager. This is the default validator of the ValidatorManager. This is the default validator of the ValidatorManager. This is the default validator of the ValidatorManager. This is the default validator of the ValidatorManager. This is the default validator of the ValidatorManager. This is the default validator of the ValidatorManager. This is the default validator of the ValidatorManager. This is the default validator of the ValidatorManager. This is the default validator of the ValidatorManager. This is the default validator of the ValidatorManager. This is the default validator of the ValidatorManager. This is the default validator of the Validator", "reference": "Found one internal team is using this method. Will coordinate with them about the migration solution." }, { "prediction": "I'm not sure if this is what you're looking for, but it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting", "reference": "The field `HttpServerErrorCodes` should be called `HttpServerErrorStatuses`" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Can you please make each of these in a separate line. It will be easier to keep them sorted, and add/remove." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "should we error instead of silently ignoring the `cleanup` param? it defaults to `false`, so someone must have explicitly set it to `true`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "There is no specific requirement that the root be called `root`, just that there is a single root directory and that it be the first entry in the zip." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "perhaps we should encapsulate this logic in a helper method w a test?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Now that we're only using this repo as a Gem you shouldn't need to `require` an expanded local file path like below." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "This isn't necessarily a year. It may be months, days, or hours. Can we return `intValue()` directly instead?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure.", "reference": "this is redundant because it gets logged immediately on entering the handleContainerChange function" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "`ds.GenericDeploymentConfig.DeploymentNotification` in L128 is nullable." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "this shouldn't be exposed here - this class isn't a carriage for this - its used internally to determine if/how we can mine." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "It's fine to leave these checks in. It'll make the exception come from `FirefoxDriver`, and that's probably clearer to a user." }, { "prediction": "I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "We don't want to include the `IntegrationSpecHelper` for models...mind moving this line out of the loop to be `config.include EnvironmentSpecHelper, type: :model`?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Please check the return on these." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think you're trying to do something like this:", "reference": "Do we need `==` for true?" }, { "prediction": "The ``````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````", "reference": "Changing the default value may cause BC-breaking. Suggest changing this value in config." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "how does that happen?" }, { "prediction": "I think this is a bug in rdkit.six.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.moves.", "reference": "This is gross/clever. :-)" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to work.", "reference": "Take a look at the name of this file. Definitely copy and" }, { "prediction": "I'm not sure if this is the case, but if it's the case, it's probably the case, but I'm not sure if it's the case.", "reference": "Can you check with @mahebbar how to work this error. Should be different from 404." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Do we still need the upper bound `<3.9`?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Does this mean `vendor/bin/psalm` is not a symlink (or whatever equivalent Windows has for symlinks) on Windows?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "@lpabon having a separate package name `aws_test` allows to test the package as if the tester was an external package. If the test package name is the same as the package being tested, the test package can also use methods and variables not exposed to the eventual user." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "The exporter should still be able to test these histogram instrument kinds, right? Is there another reason to remove these?" }, { "prediction": "This is a specialized operation used by the transaction pool. It is a specialized operation used by the transaction pool. This is a specialized operation used by the transaction pool. It is a specialized operation used by the transaction pool to +// simulate the effect of putting pending transactions in multiple blocks. This is a specialized operation used by the transaction pool to +// simulate the effect of putting pending transactions in multiple blocks. +func (eval *BlockEvaluator) ResetTxnBytes(validateTxnBytes bool) { + eval.totalTxBytes = 0 +} + // Transaction tentatively adds a new transaction as part of this block evaluation. // If the transaction cannot be added to the block without violating some constraints, // an error is returned and the block evaluator state is unchanged.", "reference": "should this increment eval.Round somehow?" }, { "prediction": "I think this is a bug, but it's a bug, and it's a bug.", "reference": "Although this change looks good. Maybe there are other inconsistent cases too?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "This is a way better method name." }, { "prediction": "We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be in touch! We will be", "reference": "Prefer single-quoted strings when you don't need string interpolation or special symbols." }, { "prediction": "I'm not sure what you're trying to do here is what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "I was wondering if this should allow per role specification, instead of (or in addition to) a generic \"allowed everywhere\". So you could do: `{ separator: ['aria-valuenow', 'aria-valuemin', 'aria-valuemax'] }`. You could still allow the array, and you could add a wildcard option for the \"generic\" case you've got now: `{ '*': ['always-allowed'] }`." }, { "prediction": "Is ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "I'm confused by the name. The string was a Hive string but it isn't any longer? Why should we care? (I imagine I'll find the answer later... there is some different semantic that we want downstream...)" }, { "prediction": "I'm not sure this is a bug, but it's a bug, and it's a bug.", "reference": "Could you please leave the explicit imports?" }, { "prediction": "I don't think this is a bug, but it's a bug in github.com/iotexproject/iotex-core/pkg/log. I'm not sure if it's a bug, but it's a bug in github.com/iotexproject/iotex-core/pkg/log. I'm not sure if it's a bug in github.com/iotexproject/iotex-core/pkg/log, but it's a bug in github.com/iotexproject/iotex-core/pkg/log. I'm not sure if it's a bug in github.com/iotexproject/iotex-core/pkg/log, but it's a bug in github.com/iotexproject/iotex-core/pkg/log, but it's a bug in github.com/iotexproject/iotex-core/pkg/log.", "reference": "Why need alias?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Shouldn't this be a `libfs.nullIDGetter` (exported, of course)?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I dislike the messages.go pattern; the strings are only used once and make more sense in context. The other two added reportErrorf() calls in clerk.go have inline strings." }, { "prediction": "I'm not sure if this is a bug, but if it's a bug, it should be fixed.", "reference": "Seems we don't need it anymore." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "This might cause problems with the weird way we publish Guidance and Groups in the UI. We will have to make sure that UAT is thorough." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "this default needs to be on order 1 minute, I'm not sure why we defaulted to 1 hour below..." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "I figure to make `{env.*}` work, right? I can't think of any other placeholder that makes sense here" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "Why change the port from 0 to getAvailablePort()?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "For me would be great don't repeat timeout sending in every get_locator call. Looks like it should be sent into LocatorsManager init. And possibly it should me non mandatory, something like that: `def __init__ (self, locators, timeout=60):`" }, { "prediction": "I'm not sure why you're getting this error, but I'm not sure why you're getting this error, but I'm not sure why you're getting this error.", "reference": "I feel like since now we don't initiate the `opts.projectName` with `opts.ProjectName()`, which means `opts.projectName` and `opts.ProjectName()` they don't necessarily equal to each other, we need to also substitute all usage of `opts.ProjectName()` within `Ask()`, `Validate()`, and `Execute()` to `opts.projectName`. Otherwise if `-p` is set, `opts.ProjectName()` will get expired." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "why do we thinkg that an empty string is ok to return from this method? I think the null should never be passed in here in the first place" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "nit: can remove this `else` since we return from the condition above." }, { "prediction": "CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken is a CancellationToken. CancellationToken", "reference": "You missed `Write(...)`! I'm kidding ofc." }, { "prediction": "I think this is what you're looking for.", "reference": "Was there a customer who had this set to an empty string?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "I know we have the `reporter` spec below, but what about a unit test for this to explain reasoning behind logic? If I were going to update this decorator, I would assume it wasn't covered by tests because there is no unit test." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "it's better to be : void attach(String name, Part part);" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "I didn't see where the IOException can get thrown, is this just to match the V1 reader?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so it's a bug.", "reference": "We normally suppress this warning with `RDUSED_PARAM(forceRDKit)`" }, { "prediction": "I'm not sure if this is the case, but if it is the case, I'm not sure if it's the case, but if it's the case, I'm not sure if it's the case, and if it's the case, I'm not sure if it's the case. If it's the case, I'm not sure if it's the case, but if it's the case, I'm not sure if it's the case, I'm not sure if it's the case.", "reference": "What if `Game::getPlayerByNameWildcard` had not been called before. It would not find a player, wouldn't it?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "Why upper case \"R\"?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Does this need to return an error or could it return `false, nil`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Can you not change those scopes in public API classes? This applies here and in other places -- protected changed to package-scope for source is not really an API-compatible change." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "this parameter is only used in POST, please use `getRequest()->request->get('...');` Thanks" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Problem number 1: Scoped packages would have a `/` character here. Changing this to `validatePackage` resolves the 403." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "I don't quite get why there would be key errors: ``deep_mapped`` is a clone of ``self`` and ``k`` comes from ``self.items()`` so why would the key ever be rejected?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug.", "reference": "this chain ID determines only from which chain to withdraw, therefore your changes do not accomplish what you want them to accomplish. You'll need changes to `func (aps *hermesPromiseSettler) Withdraw(chainID int64, providerID identity.Identity, hermesID, beneficiary common.Address) error`. The method probably has to include two chain ids: to and from. Currently, the method internally uses: `aps.config.L1ChainID` -> the chain to withdraw to `chainID` -> the chainID that was passed as the chain that the withdrawal is originating from." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this.", "reference": "If instead we had `TraceContext.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "here shouldn't we use `depotFreeLimit`?" }, { "prediction": "I think this is a secret token used to encrypt user_id's in the Bookmarks#export callback URL, for example in Refworks export of Bookmarks.", "reference": "Could we use the Rails application's secret token instead? Do we actually need our own here?" }, { "prediction": "We can't use `groupby` as a parameter for `groupby` in `SeriesGroupBy` because `groupby` is a `SeriesGroupBy` and `groupby` is a `SeriesGroupBy` and `groupby` is a `SeriesGroupBy`. So, we can't use `groupby` as a parameter for `groupby` in `SeriesGroupBy`. So, we can't use `groupby` as a parameter for `groupby` in `SeriesGroupBy`. So, we can't use `groupby` as a parameter for `groupby` in `SeriesGroupBy`. So, we can't use `groupby` as a parameter for `groupby` in `SeriesGroupBy`. So, we can't use `groupby` as a parameter for `groupby` in `SeriesGroupBy`. So, we can't use `groupby` as a parameter for `groupby` in `SeriesGroupBy`. Also, we can't use `groupby` as a parameter for `groupby` in `SeriesGroupBy`.", "reference": "so should be fixed here also" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I would just remove this assert as it's going to get un-maintainable with a long list of valid sizes. Ditto below." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "`HostDataDir` is misleading. Can we rename it to something more relevant? The constant should also be moved up and reused as necessary." }, { "prediction": "@ -37,6 +37,9 @ @ const ( defaultMTUGRE = 1462 defaultMTUSTT = 1500 defaultMTU = 1500 + // IPsec ESP can add a maximum of 38 bytes to the packet including the ESP + // header and trailer. + ipsecESPOverhead = 38 ) type Options struct { defaultMTUGRE = 1462 defaultMTUSTT = 1500 defaultMTU = 1500 }", "reference": "I still feel like we are double-counting the outer IP header here (once in `defaultMTUGRE` and once in `ipsecESPOverhead`) but I'm not that familiar with IPsec." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Not sure what benefit we gain by extending BaseProcessor here, as this seems to be defining a new OnEnd method. Could we modify MeasurementItem to have all the things, and then MeasurementProcessor can be simply extending BaseProcessor (not blocking. just noting some observations in the PR :) )" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like \"github.com/drud/ddev/pkg/fileutil\" or \"github.com/drud/ddev/pkg/fileutil\" or \"github.com/drud/ddev/pkg/fileutil\" or \"github.com/drud/ddev/pkg/fileutil\" or \"github.com/drud/ddev/pkg/fileutil\" or \"github.com/drud/ddev/pkg/fileutil\" or \"github.com/drud/ddev/pkg/fileutil\" or \"github.com/drud/ddev/pkg/fileutil\" or \"github.com/drud/ddev/pkg/fileutil\" or \"github.com/drud/ddev/pkg/fileutil\" or \"github.com/drud/ddev/pkg/fileutil\" or \"github.com/drud/ddev/pkg/fileutil\" or \"github.com/drud/ddev/pkg/fileutil\" or \"github.com/drud/ddev/pkg/fileutil\" or \"github.com/", "reference": "This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "This seems like a more appropriate message under `ListenAndServe`. WDYT?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Is this not required?" }, { "prediction": "I'm not sure if this is the correct way to do this, but I think this is the correct way to do it.", "reference": "We should start thinking of an object that encapsulates this information :) we might need more arguments in the future." }, { "prediction": "I don't think it's a bug, but it's a bug.", "reference": "Given that we are (conceptually) searching across multiple self-dependencies, all we can say is that we didn't have a self dependency in which *both* source and dest masks were correct. Since the spec doesn't imagine this case, the valid usage statement assume we can differentiate only wrong source from only wrong dest within a *single* self-dependency -- which we can't across multiple (at least not meaningfully)... so we always return both the source/dest VUID's if we can't find a self-dependency in with *both* are correct." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "rename? MiningCoordinator always exists" }, { "prediction": "I'm not sure if this will work, but I'm not sure if this will work, but I'm sure it will work.", "reference": "Here would be the same case you don't need to call `loadConfigs`, but you would need to reread configs using `getConfig` on each getHost function call, not once per file." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug.", "reference": "Unlocking with defer means that this lock is still held curing the call to forgetNode(), below, which I see attempts to acquire `f.mu`, which looks dangerous to me." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here.", "reference": "Does anyone still use the cst out of this method? If not consider deleting" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Line is too long. [97/80]" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "This seems unused." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "@luguanglong, Thanks for the fix, can you re-phrase it to sound better something like \"This OS version is currently un-supported by keadm\"" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "should probably be called `_DeleteFpInfoAttr` because it removes it. Cleaning gives the impression it is still there. I would also move this to the end of the function `GetAtomicWeightsForFingerprint`." }, { "prediction": "I'm not sure I'm getting this right, but I'm not sure I'm getting this right, but I'm not sure I'm getting this right.", "reference": "nit, can we use `VK_PIPELINE_BIND_POINT_RAY_TRACING_KHR` here (granted it isn't else where, maybe worth fixing here or in separate PR)" }, { "prediction": "I think this is what you're looking for.", "reference": "This will need to be updated in the upcase-exercises repo as well." }, { "prediction": "I think this is what you're looking for.", "reference": "Think it's worth extracting this to `Exercise#complete?`?" }, { "prediction": "public function getReversedExchangeRate() - { return $this->exchangeRate; } - /** * @return string - */ - public function getReversedExchangeRate() - { return $this->exchangeRate; } - /** * @param string $exchangeRate */ - public function getReversedExchangeRate() - { return $this->exchangeRate; } - public function getReversedExchangeRate() - { return $this->exchangeRate; } - public function getReversedExchangeRate() - { return $this->exchangeRate; } - public function getReversedExchangeRate() - { return $this->exchangeRate; } - public function getReversedExchangeRate() - { return $this->exchangeRate; } - public function getReversedExchangeRate() - { return $this->exchangeRate; } - public function getReversedExchangeRate() - { return $this->exchangeRate; } - public function getReversedExchangeRate() - { return $this->exchangeRate; }", "reference": "This is still a potentially useful public method - should we remove such methods?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "I don't understand this change, what is happening here?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I think its worth stating this is `versionMajor`" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "rebuild: say loads and merges" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Why was this removed here (also in the other file)? Shouldn't we import them so that the reference in the docs below is interpreted correctly?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "I'd prefer to have a blank line between the class declaration and its first member. Is it possible?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Is it really LEGACY_HELLO if we are using the most up to date HELLO? Perhaps `MONGOS_HELLO` would work here?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, and it's a bug.", "reference": "I am afraid this is going to cause problems on Windows where it is not uncommon to have injected threads (CTRL_SHUTDOWN, CTRL_LOGOFF, etc.) we have no privileges to suspend -- and thus retrying will just fail again, and with the new \"synchall failure is fatal and should kill the process\" approach it turns what used to work for us on Windows into process death." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "think it should only be in create_dist" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do. I'm not sure what you're trying to do.", "reference": "Do you plan to support Pod spec change? Like hostPort is added/removed later after Pod creation?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "Is this behavior correct? It used to return `true`, which should map to `dokan.ExistingDir`. Was that previously a bug?" }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to use a shared monitor. I'm not sure what you're trying to do here, but it seems like you're trying to use a shared monitor. I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here. I'm not sure what you're trying to do here.", "reference": "What about just printing an empty list in this case? That would make the output more predictable." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think this is what you're trying to do.", "reference": "I looked and couldn't find any usage of `container` in any of the editor component files (js or hbs), so I assume this was used once and didn't get removed?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "I just updated a number of sites using older versions of Roots onto WP 3.6 and this little function change was required. Multiple search bars were displaying when I used the search widget in a widgetized sidebar. Updated the roots_get_search_form as seen in this change resolved it for me!" }, { "prediction": "I'm using Thelia\\Coupon\\Type\\FreeProduct instead of Thelia\\Coupon\\Type\\FreeProduct. I'm using Thelia\\Coupon\\Type\\FreeProduct. I'm using Thelia\\Coupon\\Type\\FreeProduct. I'm using Thelia\\Coupon\\Type\\FreeProduct. I'm using Thelia\\Coupon\\Type\\FreeProduct. I'm using Thelia\\Coupon\\Type\\FreeProduct.", "reference": "Fixes test failed in some cases" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's worth noting that this should be removed from the production environment.", "reference": "what's the prod url for this? just curious. @amirsaber" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Can you please change this to azkaban.jobs.java.opts?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "Here is another concatenation which should be updated. Even though `Source:` and the link are essentially separate, it isn't RTL friendly. This would be another good use for `createInterpolateElement` I think so that we wouldn't need to include all of the classnames in the translation string (or extract them to a placeholder). That would allow us to use the `Link` component as well, rather than using its resulting HTML as a string which will be a pain to maintain if we were to make changes to the base `Link` component." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "I would add an overload `GetCancelledZeroTask()` which calls `GetCancelledZeroTask(CancellationToken.None)`. This is cleaner than requiring the caller to pass `default(CancellationToken)` or `CancellationToken.None`." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "Would it be equivalent to check if `chain!= nullptr` below? Not suggesting a change, just curious." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Should probably do `auto this_l (shared_from_this ());` and pass/use that instead of `this`. Same a few other places. IOW, replace both `shared_from_this()` and `this` with `this_l`" }, { "prediction": "The first word in a function's description should be a third-person verb (eg \"runs\" not \"run\").``````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````", "reference": "And here. Please, use `'` for apostrophes in changed strings in this file." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "assignments should only be cuddled with other assignments (from `wsl`)" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Please move this to `block_types.go`." }, { "prediction": "I'm not sure if this is a bug, but it's a bug in NLog.Layouts.cs. It's a bug in NLog.Layouts.cs. It's a bug in NLog.Layouts.cs. It's a bug in NLog.Layouts.cs. It's a bug in NLog.Layouts.cs. It's a bug in NLog.Layouts.cs. It's a bug in NLog.Layouts.cs. It's a bug in NLog.Layouts.cs. It's a bug in NLog.Layouts.cs. It's a bug in NLog.Layouts.cs. It's a bug in NLog.Layouts.cs. It's a bug in NLog.Layouts.cs. It's a bug in NLog.Layouts.cs.", "reference": "So this is not needed anymore for all attributes?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Happy to get suggestion for better messaging here. Here's what I intended to convey: Something is wrong - the Exception is a hint to what might be the cause The impact of that - tracing wont work." }, { "prediction": "Is there a better way to do this?", "reference": "I think we can remove this function, right? (duplicate with `ses_starter.py`)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "With this fix, I am not even sure we need to overwrite this function." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea to use it.", "reference": "Why not just import this from `data_transfer`? As a rule copying the same code twice is not a good idea. Also: please run `pylint` on all files in this PR." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "You've got an absolute path here referencing your home dir :-)." }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Maybe I should do some sorting so that these properties don't keep moving around..." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Can we keep this test anyway, as it's part of the spec?" }, { "prediction": "I'm not sure if this will work or not, but I'm sure it will work.", "reference": "Can be removed" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're using a Backend, so I'm not sure what you're trying to do. I'm assuming you're using a Backend, so I'm not sure what you're trying to do.", "reference": "It's a minor quibble I know, but I like having the imports ordered by lengt" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "It's better to get the charset from context or other setting to let the user override it." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "this filename as well needs change" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this, but I'm assuming you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "I think we want to remove `omitempty` here" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "You cannot move this here because it breaks detach. Just call `tty.Close()` before returning the error from start" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "I updated only the implicit roles who needed a update for this new rule to validate." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this.", "reference": "> // Code generated by protoc-gen-go. DO NOT EDIT." }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "minor: skipOSConfigMetadata, otherwise, the name sounds like a boolean" }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if it's the correct way to do it, so I'm not sure if it's the correct way to do it.", "reference": "~~I think lines 65-67 should be moved into this else clause after `type =...` Else, it is a bit confusing why we check the enclose type validity a second time~~ Nevermind, will do some refactoring, myself. But thanks for \"fixing\" this!" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "`sessions := endpoints.SessionsDTO{}` and using only `sessions` should be simpler." }, { "prediction": "I'm not sure if this is the case, but I think it's the case, and I'm not sure if it's the case, but I think it's the case.", "reference": "These need to be in the other order to avoid crashing when dcontext == GLOBAL_DCONTEXT (==-1)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "Why not change the other samples?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Indentation is mixed up here due to spaces/tabs, I'm guessing." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's the case, it's a bug.", "reference": "Should we provide a little more context in the error message? Maybe throw in something about what operation was being performed?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Project standard is spaces, not tabs. Please fix and then we can merge this." }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so it's a bug.", "reference": "@hgtw is there anything we're worried about with regards to using this cache? Do we want to do staged testing around expeditions before we merge? Curious your thoughts here" }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "The purpose of this was to allow pushing filters into the manifest files if we ever use a format other than Parquet. I think overall this is a good change because we can add it back later. Just wanted to note why the unused argument was there." }, { "prediction": "I think this is what you're looking for, but I'm not sure if this is what you're looking for, so I'm not sure if this is what you're looking for.", "reference": "I think BSON::Decimal128 should always be serialized as Decimal128 regardless of config option." }, { "prediction": "@@ -1,6 +1,7 @@ # frozen_string_literal: true require 'bolt/application' +require 'bolt/plan_creator' require 'bolt_spec/files' +require 'bolt/plan_creator' +require 'bolt/plan_creator' +require 'bolt/plan_creator' +require 'bolt/plan_creator' +require 'bolt/plan_creator' +require 'bolt/plan_creator' +require 'bolt/plan_creator' +require 'bolt/plan_creator' +require 'bolt/plan_creator' +require 'bolt/plan_creator' +require 'bolt/plan_creator' +require 'bolt/plan_creator' +require 'bolt/plan_creator' +require 'bolt/plan_creator' +require 'bolt/plan_creator' +require 'bolt/plan_creator' +require 'bolt/plan_creator' +require 'bolt/plan_creator' +require 'bolt/plan_creator' +require 'bolt/plan_creator' +require 'bolt/plan_creator' +require", "reference": "We should probably just move the `require 'bolt/plan_creator'` in `Bolt::CLI` to `Bolt::Application` so it will already be loaded." }, { "prediction": "We don't want to do this, but it's a good idea.", "reference": ">20 [](start = 45, length = 2) Can we override this at runtime? Maybe it should be a command line option with default." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "can just remove it?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this.", "reference": "Better call it `CleanUpMirrorInfo`?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if this is a bug or a bug.", "reference": "@shannonwells is there still something missing here?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "This could be more indicative of what it is... e.g... `stresstest_time_limit`" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Shouldn't we do a `reader_payload_pool_.reset()` here?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I'd prefer the nomenclature less tightly coupled to DRAND throughout. I played with renaming the `drand` package to `beacon` but it was too much noise in this change." }, { "prediction": "@property def current_key(self): return getattr(self, '_current_key', None) + '_current_key' + '_current_key' + '_current_key' + '_current_key' + '_current_key' + '_current_key' + '_current_key' + '_current_key' + '_current_key' + '_current_key' + '_current_key' + '_current_key' + '_current_key' + '_current_key' + '_current_key' + '_current_key' + '_current_key' + '_current_key' + '_current_key' + '_current_key'", "reference": "I think I would prefer you declare `self._current_key=None` in the constructor and just return `self._current_key`. That way you can prevent anyone from overwriting `current_key` without needing to use `getattr` here." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "I guess I like the name `mode` okay. I can't think of anything better." }, { "prediction": "The default timeout of the workflow will be set to zero. This is the default timeout of the workflow. The default timeout of the workflow will be set to zero. This is the default timeout of the workflow. The default timeout of the workflow will be set to zero. This is the default timeout of the workflow. The default timeout of the workflow will be set to zero. This is the default timeout of the workflow. The default timeout of the workflow will be set to zero. The default timeout of the workflow will be set to zero. This is the default timeout of the workflow. The default timeout of the workflow will be set to zero. The default timeout of the workflow will be set to zero. This is the default timeout of the workflow. The default timeout of the workflow will be set to zero. The default timeout of the workflow will be set to zero. The default timeout of the workflow will be set to zero. The default timeout of the workflow will be set to zero. The default timeout of the workflow will be set to zero. The default timeout of the workflow will be set to zero. The default timeout of the workflow will be set to zero. The default timeout of the workflow will be set to zero. The defaultTimeout of the workflow will be used", "reference": "I would create a new method (NewStepWithDefaultTimeout?) for this purpose because timeout<=0 looks like a hidden logic" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "Are these limit changes related?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'll try to fix it.", "reference": "Don't you mean `import scapy.consts`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "`ctx` is unused in rollbackPrimary" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this:", "reference": "This is not what title says." }, { "prediction": "I think this is a good idea to use the `````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````", "reference": "a fix applies several fixes? maybe this should simply be `applyToNode`" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "U1000: func `fakeGetOk` is unused (from `unused`)" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Because there is a \"k8s.io/client-go/tools/cache\" below, we can sort out all the \"imports\" here." }, { "prediction": "I'm not sure if this is what you're looking for, but it looks like you're looking for something like this: https://github.com/aws/aws-sdk-go/blob/master/aws-sdk-go/aws-sdk-go/aws-sdk-go/aws-sdk-go/aws-sdk-go/aws-sdk-go/aws-sdk-go/aws-go/aws-sdk-go/aws-go/aws-sdk-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go/aws-go", "reference": "Nit should be using `goimports` to format the import statements with standard libary imports first, new line, followed by non-standard library imports." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's the case, it's a bug.", "reference": "Do we not have tests for pipeline delete" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Good that you mention this constraint in the docstring :)" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this: \"k8s.io/apimachinery/pkg/api/v1alpha1\" \"k8s.io/apimachinery/pkg/api/v1alpha1\" \"k8s.io/apimachinery/pkg/api/v1alpha1\" \"k8s.io/apimachinery/pkg/api/v1alpha1\" \"k8s.io/apimachinery/pkg/api/v1alpha1\" \"k8s.io/apimachinery/pkg/api/v1alpha1\" \"k8s.io/apimachinery/pkg/api/v1alpha1\" \"k8s.io/apimachinery/pkg/api/v1alpha1\" \"k8s.io/apimachinery/pkg/api/v1alpha1\" \"k8s.io/apimachinery/pkg/api/v1alpha1\" \"k8s.io/apimachinery/pkg/api/", "reference": "remove this blank?" }, { "prediction": "I'm not sure if this is the case, but if it's the case, then it's probably the case, but it's the case.", "reference": "Partitions is misspelled 8 times in this commit, might make sense to fix the spelling for all of those." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this from PyQt5.QtCore import (pyqtSlot, pyqtSignal, QObject, QProcess, - QProcessEnvironment, QUrl) -from qutebrowser.utils import message, log +from qutebrowser.utils import message, log, objreg + +from qutebrowser.browser import qutescheme # A mapping of QProcess::ErrorCode's to human-readable strings. # A mapping of QProcess::ErrorCode's to human-readable strings. # A mapping of QProcess::ErrorCode's to human-readable strings. # A mapping of QProcess::ErrorCode's to human-readable strings. # A mapping of QProcess::ErrorCode's to human-readable strings. # A mapping of QProcess::ErrorCode's to human-readable strings. # A mapping of QProcess::ErrorCode's to human-readable strings. # A mapping of QProcess::ErrorCode's to human-readable strings. # A mapping of QProcess::ErrorCode's to human-readable strings. # A mapping of QProcess::ErrorCode's to human-readable strings. #", "reference": "Please remove this blank line - those are only used to group Python/third-party/qutebrowser imports." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "`insecure` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Same as above (HTTP in upper-case)" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to call a method from a class that doesn't have a method that does have a method that returns a reference to that class.", "reference": "This is getting repetitive maybe you could introduce an abstract test case with a `getExpectedUrl($providerReference)` method?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "I do not think returning `Value{}` is correct here. For example, `reflect.MakeFunc(...).Kind()` would return `reflect.Invalid` instead of `reflect.Func`. Therefore, I think this should panic instead." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Does this work for Custom Elements? iirc we're lacking test cases for them. /cc @andrewiggins @developit" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a good idea.", "reference": "Same change just above?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug, and it's a bug.", "reference": "I suppose `apploader.js` isn't used by WebWorkers. So `self` will always be `window` here." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case.", "reference": "Since this var is no longer defined we should remove the `if skip_targets.any?` bit below." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "I think we should `return arn` as a fallback at the end of this function (otherwise the `['Resource']` entry below could become `None`)." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Why session is started at all, if you need to shut it down e.g. DI should launch noopSession" }, { "prediction": "@ -184,7 +184,7 @@ type svcManifestReader interface { } type workspaceDeleter interface { - DeleteAll() error + DeleteWorkspaceFile() error } type svcManifestReader interface { - DeleteWorkspaceFile() error + DeleteWorkspaceFile() error } type svcManifestReader interface { - DeleteWorkspaceFile() error + DeleteWorkspaceFile() error }", "reference": "nit: can we rename the interface to `wsFileDeleter`" }, { "prediction": "It's the struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct used by reconciler. It's a struct", "reference": "Why target cannot be external endpoints?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for the \"followAliases\" option. I'm not sure if this is what you're looking for, but it seems like you're looking for the \"followAliases\" option.", "reference": "We use a suffix \".AUTOCREATED\" for configsets, maybe we can use the same here?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "This one won't be disposed. Should be (something like) `using var openTelemetry = OpenTelemetrySdk.EnableOpenTelemetry(` no?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Why this is in the diff?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "How is status determined? When the user calls CloudBackupCreate( src_volume_id ) they can then call CloudBackupStatus( src_volume_id ) Is there something similar for this new API?" }, { "prediction": "We don't know the old dom, so we don't know the old dom, so we don't know the old dom, so we don't know the old dom, so we don't know the old dom, so we don't know the old dom, so we don't know the old dom, so we don't know the old dom, so we don't know the old dom, so we don't know the old dom, so we don't know the old dom, so we don't know the old dom, so we don't know the old dom, so we don't know the old dom, so we don't know the old dom and insert an additional node instead of replace the prerendered one. (#2539) + if (isHydrating && excessDomChildren!= null) { + for (tmp = excessDomChildren.length; tmp--; ) { + if (excessDomChildren[tmp]!= null) removeNode(excessDomChildren[tmp]); + } + } + newVNode._original = null; options._catchError(e, newVNode, oldVNode); options._catchError(e,", "reference": "We could pass `excessDomChildren` to `options._catchError` and only do this if an error-boundary catches the error. Not entirely sure if that's better." }, { "prediction": "I think this is what you are looking for. I'm not sure if this is what you are looking for, but I think this is what you're looking for.", "reference": "In php8 named parameters were introduced and now it is required to match called method parameter name when setting parameters by array destructing or call_user_func_array() etc." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug. I'm not sure if it's a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "If instead we had `B3.extractSingleHeader` and `B3.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "I think this is more of a semantic difference than a typo - `weiter hinzufgen` is like `continue adding` whereas `weitere hinzufgen` is like `add more`. I think it makes sense to change it though" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "nit: 200 is superfluous" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "This is testing `unreserved keyword`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "paramsNatOrigin doesn't include sUVtoST. I would just remove that definition for now" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed in the latest release.", "reference": "It feels like the test should be waiting for the prefetcher to shut down, but I don't have a great reason why other than that it might be confusing for debugging if there are still goroutines from old prefetchers lying. But I guess since `TogglePrefetcher(false)` doesn't actually set the prefetcher to nil, the queue shutdown method will still end up waiting for the shutdown to finish. If that sounds right, nevermind me." }, { "prediction": "I think this is what you're looking for: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide.html", "reference": "AWS Identity and Access Management (IAM)" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "As a long term thing, would it make sense to move the resource names as keys under the requirements map?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "That doesn't fix the whole problem. The issue lays in this line right here, not the one above. There are two problems with this line: 1. It finds things that aren't cells in the table 2. if it doesn't find anything, it shouldn't return empty here, but continue down to look for row/ column headers." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "I am pretty sure that this is infinite recursion as getAllProjects returns the project itself." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something that's not \"sensing\" or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing\", or \"sensing", "reference": "Something I didn't catch before I merged this PR, is the hyphenated constant a problem? E.g. should \"data-lists\" be \"data_lists\"? @paulkaplan" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "Can you write the test as `if not (conf.use_winpcapy or conf.use_pcap or conf.use_dnet):`" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "we have to include foreign assets on the repository directly because they don't belong to a job? This seems very awkward... Is this a step towards the job-less assets on the repository? Did you consider having `build_asset_job` take in a set of foreign assets instead? I suppose we would then need to subclass it to be a more special `AssetJobDefinition` that can keep track of them." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "`-Wstringop-truncation` is a new kind of error detector introduced in GCC 8. As for this patch, these are two false-positives though." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Can we port this error msg to v2 too? This one is better, as it explicitly states what sources are allowed." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "The convention so far has been to require directly from the defining file (in this case `../../read_preference'). I think the concern has been mostly about the potential for circular dependency cycles" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "I suggest expanding dims here to simplify the formatting." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Why do you need to specify the kinto prefix here?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "The `!r` is unnecessary." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "I didn't see existing tests for this `OpenBucketURL`. Not sure if it's easy to do without mocking these `opener` calls." }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this. I'm not sure what you're trying to do here, but I'm assuming you're trying to do something like this. I'm not sure what you're trying to do here, but I'm assuming you're trying to do something like this.", "reference": "Should we default to `true`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this (which I'm not sure what you're trying to do here)", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to use babel-preset-react, so I'm not sure what you're trying to do. If you're trying to use babel-preset-react, you'll need to use babel-preset-react, but I'm not sure what you're trying to do.", "reference": "Shouldn't these options also include `@babel/preset-env`? Also I see you set `babelrc` to `false`, could we rely on our existing `.babelrc` file? Feels like some duplicate configuration otherwise." }, { "prediction": "I'm not sure if this is the case, but if it is the case, it's probably the case.", "reference": "Nit: We can use `%s` since `disconnectReason` is a string." }, { "prediction": "I think this is a bug in lgbm.LGBMRegressor. I'm not sure if it's a bug in lgbm.LGBMRegressor, but maybe it's a bug in lgbm.LGBMRegressor?", "reference": "I think it's better to create a new example" }, { "prediction": "I don't think it's a bug, but it's a bug.", "reference": "The stages are correct, but the more forgiving `kAttachmentRasterOrder` should be used, based on a review of the spec. That should give the same effect of suppressing the false positive conflict between the DEPTH R/W and resolve. > End-of-subpass multisample resolves are treated as color attachment writes for the purposes of synchronization. This applies to resolve operations for both color and depth/stencil attachments. That is, they are considered to execute in the VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT pipeline stage and their writes are synchronized with VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT. Synchronization between rendering within a subpass and any resolve operations at the end of the subpass occurs automatically, without need for explicit dependencies or pipeline barriers." }, { "prediction": "AcidBasePair(OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO", "reference": "To be consistent, I think it should actually just be a single `-`" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "this seems extraneous." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Ah, I see here that 'LongDomain' is defined as something that contains a subdomain segment that is `maxLengthOfDomainSegment` long (which I think is 63 characters) - I don't think any public ACME servers/Let's Encrypt's staging environment has a restriction on this? if it does, and the 'pebble' based ACME server does not, then Pebble needs modifying to also fail in these cases as it aims to replicate the ACME RFC as closely as possible" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "I think you need `-y` here to prevent a user confirmation prompt" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug, so it's a bug.", "reference": "Repeating: I don't think this should be a core-wide global var. This should be isolated to arch/x86 or at least arch/, maybe inside getter/setters as mentioned above." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "right URL is like in cmdrunner, using search.maven.org" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "The link to valid syntax is not really applicable for NET2_1, right?" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Shouldn't it be more specific, like \"gcppubsub supports all UTF-8 strings\"?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "Everything in this class is SolrCloud-related, not legacy replication" }, { "prediction": "@ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @", "reference": "Could just assign directly and eliminate the `newval` var." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "... with the name of the affected package, or \"all\", followed by a colon,..." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "We'll want to remove this one if we make the assembly version constant." }, { "prediction": "I'm not sure if this is the correct way to do it, but it's the correct way to do it. I'm not sure if this is the correct way to do it, but it's the correct way to do it, so I'm not sure if it's the correct way to do it.", "reference": "Can we have a single function here that uses the same subscribers and just changes meta based on context?" }, { "prediction": "The HIP startup kernel loader logic is the same as the HIP startup kernel loader logic. The HIP startup kernel loader logic is the same as the HIP startup kernel loader logic. The HIP startup kernel loader logic is the same as the HIP startup kernel loader logic. The HIP startup kernel loader logic is the same as the HIP startup kernel loader logic. The HIP startup kernel loader logic is the same as the HIP startup kernel loader logic. When enabled HIP_STARTUP_LOADER, HIP will load the kernels and setup +// the function symbol map on program startup class startup_kernel_loader { private: startup_kernel_loader() { functions(); } public: startup_kernel_loader() { functions(); } public: startup_kernel_loader() { functions(); } public: startup_kernel_loader() { functions(); } public: startup_kernel_loader() { functions(); } public: startup_kernel_loader() { functions(); } public: startup_kernel_loader() { functions(); } public: startup_kernel_loader() { functions(); } public: startup_kernel_loader() { functions(); } public: startup_kernel_loader() { functions(); }", "reference": "where would ` static startup_kernel_loader skl;` be instantiated? if it's not instantiated anywhere should this be removed?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "I think we should move those util functions that work with drag-drop to @uppy/utils, so they can be shared (maybe later) with drag-drop plugin? Otherwise it will continue to depend on drag-drop module." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Migrate the spec.Labels to locator.Labels?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "The test case already existed but it never tested properly because of the conditional in the test." }, { "prediction": "public boolean equals(Object other) { if (this == other) { return true; } return this.name.equals(that.name) && this.transform.equals(that.transform) && this.transform.equals(that.transform) && this.transform.equals(that.transform) && this.transform.equals(that.transform) && this.transform.equals(that.transform) && this.transform.equals(that.transform) && this.transform.equals(that.transform) && this.transform.equals(that.transform) && this.transform.equals(that.transform) && this.transform.equals(that.transform) && this.transform.equals(that.transform) && this.transform.equals(that.transform) && this.transform.equals(that.transform) && this.transform.equals(that.transform) && this.transform.equals(that.transform) && this.transform.equals(that.transform) && this.transform.equals(that.transform) && this.transform.equals(that.transform) && this.transform.equals(that.transform) && this.transform.equals(that.transform) && this.transform.", "reference": "I'm okay with this, but I don't see a lot of benefit to removing unnecessary parens. If extra parens make something more readable (like this) or clarify order of operations even when matching the default, I would say we should keep them." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "@sarowe why was this volatile? It's fishy to see this as the only volatile field." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "template is not correct?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Rename the registies to `BBOX_ASSIGNERS` and `BBOX_SAMPLERS` to avoid ambiguity. There is also a registry for dataset sampler." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if it's what you're trying to do, but I think it's what you're trying to do.", "reference": "This is no longer stubbed on every test. Perhaps it should be, and should be unstubbed in the single case that it matters." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "This seems much simpler! I'm not sure I follow what you mean by the threading part... Also tests are not liking this constant. Might need a require or to fully qualify this." }, { "prediction": "I'm not sure if this is the case, but it seems to be the case.", "reference": "Convention is \"FIXME: i#2144\" or \"XXX: i#2144\"" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "This should probably be a property instead of a method." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "do we need to consider setting the `state` as well? If so, lot of changes might be required, like, setting to 'Reconciling' in upgrade code, setting to 'error' or'reconciled' in volumeReconciler functions." }, { "prediction": "I think this is a bug, but it should be fixed.", "reference": "Line is too long. [82/80]" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Add blank line below license header." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "I'm not clear on whether this really should be the right behavior. Basically we're saying that a replace table will keep the existing location (as opposed to using defaults). I suspect we don't have create or replace with location semantics, but this is making some assumptions that a replacement is somehow the same as the old. If we were to go with id based pathing convention, this wouldn't work. I don't think this is an issue at this point, but it might make sense to push this down to the location provider." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Just run a global replacement for all `executionproto`." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "@AutomatedTester @davehunt thoughts on a new keyword argument?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Should line 47 be OPAE_ERR?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Not necessary, just write `time.Time{}`" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "As these two strings simply get concatenated for the docs, there's a space missing after the dot here." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "What about integrations where we don't plug ourselved on OnMethodBegin?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "shouldn't **call** return a boolean?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "ViewModel classes should not expose any classes from framework.model." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here.", "reference": "how would you feel about keeping these tests to be more explicit and having them `assert not _validate...`? or is your view that that is too duplicative of the tests in `test_evaluator.py`?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to run a command that doesn't have a `filepath` parameter. I'm guessing you're trying to run a command that doesn't have a `filepath` parameter, so I'm guessing you're trying to run a command that doesn't have a `filepath` parameter. I'm guessing you're trying to run a command that doesn't have a `filepath` parameter, so I'm guessing you're trying to run a command that doesn't have a `filepath` parameter, so I'm guessing you're trying to run a command that doesn't have a `filepath` parameter.", "reference": "Why do we use the `winrm_nodes` variable here and not the string `\"winrm_nodes\"` as we were using before?" }, { "prediction": "This source code is licensed under Apache 2.0 License, and is licensed under Apache 2.0 License, and is licensed under Apache 2.0 License, and is licensed under Apache 2.0 License. This source code is licensed under Apache 2.0 License, and is licensed under Apache 2.0 License, and is licensed under the Common Clause Condition 1.0, found in the LICENSES directory. This source code is licensed under Apache 2.0 License, and is licensed under the Common Clause Condition 1.0, found in the LICENSES directory. This source code is licensed under Apache 2.0 License, and is licensed under the Common Clause Condition 1.0, found in the LICENSES directory under the Common Clause Condition 1.0, found in the LICENSES directory under the Common Clause Condition 1.0, found in the LICENSES directory under the Common Clause Condition 1.0, found in the LICENSES directory under the Common Clause Condition 1.0, found in the LICENSES directory under the Common Clause Condition 1.0, found in the LICENSES directory under the Common Clause Condition 1.0, found in the LICENSES directory under the Common Clause Condition 1.0, found in the LICENSES directory under the Common Clause Condition 1.0, found in the LI", "reference": "why update Copyright?" }, { "prediction": "I don't think it's a bug, but it's a bug.", "reference": "Does this mean we cannot update statistics with sampling on a table with LOB columns?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "Look good, but I think a `[flags]` enum would be more future proof? Although i'm not sure if a flags-enum is working from the XML config. What do you think?" }, { "prediction": "I think this is a bug in uiGridTreeBaseService.toggleRowTreeState. I'm not sure if it's a bug, but I think it's a bug in uiGridTreeBaseService.toggleRowTreeState. I'm not sure if it's a bug, but I think it's a bug in uiGridTreeBaseService.toggleRowTreeState. I'm not sure if it's a bug in uiGridTreeBaseService.toggleRowTreeState, but I think it's a bug in uiGridTreeBaseService.toggleRowTreeState. I'm not sure if it's a bug in uiGridTreeBaseService.toggleRowTreeState.", "reference": "Since I believe state will never be anything other than 'expanded' or collapse, you can rewrite this as follows: `return row.treeNode.state === 'expanded'? 'ui-grid-icon-minus-squared' : 'ui-grid-icon-plus-squared'; `" }, { "prediction": "I'm not sure if this is the case, but it's worth noting that we are using LBHttp2SolrClient instead of LBHttp2SolrClient. We are using the LBHttp2SolrClient. We are using the LBHttp2SolrClient to issue requests. * - * This class assumes the id field for your documents is called - * 'id' - if this is not the case, you must set the right name - * with {@link #setIdField(String)}. - * * @lucene.experimental * @since solr 8.0 */", "reference": "the latter part can go but isn't the first part of this still sound -- that we assume \"id\"?" }, { "prediction": "I'm not sure what you're trying to do, but I'm sure you're trying to do something like this.", "reference": "Why is the escaping of @ and $ removed?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Nit: `Http` is redundant in this interface's name." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug.", "reference": "what if I set SynchronizableEntitiesPrefix to \"a/b/c/d\" in config?" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a", "reference": "nit: This error message doesn't mention that the path is a directory, maybe \"Dockerfile path is a directory:%s, please provide path to file.\"" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "This is done automatically, you can skip it next time ;)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This is needed in `set_value` because of `:open-editor` (you could open an editor, close the tab, then close the editor). I don't think it makes any sense to have it here?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Perhaps we can assume that profiling is enabled if ProfilingPort is set? And/or configure a default port and frequency, so we don't have to set three config vars every time?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "This nil check won't correctly handle the case where forward_ssh_agent is set to false - it won't be nil but it should still not be set." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "We could avoid passing proto since threshold isn't needed." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "This route excluding needed for reconnect only when one connection is lost and we trying to establish another. I was thinking to make 2 separate flags for killswitch and reconnect enabling. This way we can keep killswitch working, but we don't need these routes excluded." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "why can this modification avoid crash?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to redirect to a different URL.", "reference": "This looks good -- signing out the user if the current user is disabled" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "The line exceeds 120 characters." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Let's go ahead and change \"Site\" to \"Project\", since that's the path we've chosen. One less thing to alter in the other issue." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this. I'm not sure what you're trying to do, but I think you're looking for something like this. I'm not sure what you're trying to do. I'm guessing you're looking for something like this, but I'm not sure what you're trying to do. I'm guessing you're looking for something like this. I'm guessing you're looking for something like this, but I'm not sure what you're trying to do.", "reference": "I am for this change iff we are sure the information is no longer helpful. I think this could still be valuable for certain scenarios, wbu?" }, { "prediction": "I'm not sure if this is the right way to do it, but I think it's the right way to do it. I'm not sure if this is the right way to do it, but I think it's the right way to do it.", "reference": "I thought we decided on using the latest active version and not the one which is max ramped up." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "can we update this to a `log.Warningf`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to connect a container to a network that it's not connected to. I'm guessing you're trying to connect a container to a network that it's not connected to, but I'm guessing you're trying to connect a container to a network that it's not connected to. I'm guessing you're trying to connect a container to a network that it's not connected to, so I'm guessing you're trying to connect a container to a network that it's not connected to, so I'm guessing you're trying to connect a container to a network that it's not connected to.", "reference": "can we get something emitted in the logs on non-zero exits to trace back to for problems like this failing on the first invocation?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Do we need `schema manager` at here?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "This won't work because of the permissions on the directory when this is included as a library. But, we may be able to do this. The key would be wrapping this command with either a script or a go binary that ensures the current directory is writable. If the current directory is not writable, it would attempt to make it writable so that we could write out the produced binary. But I'm not sure if that will influence the hash that gets produced for `go.sum` since I am not sure how that is calculated. Alternatively, we can choose a place in `/usr/local` or choose a location that is writable in the go cache and use that. I'll give that a try since it might be needed for the ARM builds if we choose to only include `x86_64` precompiled binaries in the module." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Correct me if I'm wrong, but is this necessary? Why not just use the value returned by `interpreter.Eval` and not mess with the scope? `interpreter.Eval` will return any produced side effects. This means TableObjects as well as any value resulting from any expression statements." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "This service is global per namespace, not per Alertmanager/Prometheus/ThanosRuler instance. So this approach won't work. But maybe I missing out something, can you describe your use case here?" }, { "prediction": "I'm not sure if it's a bug, but maybe it's a bug?", "reference": "Do we need this default? Since we aren't using a sql.NullBool or *bool, an unset column will be interpreted as `false` already... We don't set a default on our other bool fields (e.g. entry admin and downstream columns)." }, { "prediction": "I think this is a bug, but it should be fixed in the future.", "reference": "thanks for moving these over. makes more sense for them to be in the exports_helper" }, { "prediction": "I think this is a bug in qutebrowser.config.parsers.py. It should be fixed in qutebrowser.config.parsers.py. It should be fixed in qutebrowser.config.parsers.py.", "reference": "That import now isn't needed anymore" }, { "prediction": "This is not a bug, it is a bug, but a bug.", "reference": "Can you update the `Usage` to be an absolute path as well? Something like `/path/to/firebug.xpi`" }, { "prediction": "I'm not sure if I'm missing something, but I'm not sure if I'm missing something. I'm not sure if I'm missing something, but I'm not sure if I'm missing something.", "reference": "This class is missing the `MvxPlugin` attribute" }, { "prediction": "I think this is a bug in wx.GetApp().SetTopWindow(mainFrame) or wx.GetApp().SetTopWindow(mainFrame) or wx.GetApp().SetTopWindow(mainFrame) or wx.GetApp().SetTopWindow(mainFrame) or wx.GetApp().SetTopWindow(mainFrame) or wx.GetApp().SetTopWindow(mainFrame) or wx.GetApp().SetTopWindow(mainFrame) or wx.GetApp().SetTopWindow(mainFrame) or wx.GetApp().SetTopWindow(mainFrame) or wx.GetApp().SetTopWindow(mainFrame) or wx.GetApp().SetTopWindow(mainFrame) or wx.GetApp().SetTopWindow(mainFrame) or wx.GetApp().SetTopWindow(mainFrame) or wx.GetApp().SetTopWindow(mainFrame) or wx.GetApp().SetTopWindow(mainFrame) or wx.GetApp().SetTopWindow(mainFrame) or wx.GetApp().SetTopWindow(mainFrame) or wx.GetApp().SetTopWindow(mainFrame) or wx.GetApp().SetTopWindow(mainFrame) or wx", "reference": "What if `wxLang` is returned `None` from `getWxLang`" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Please don't do changing like this unless it _**really**_ cares. BTW. Please look around to infer our naming conventions." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "This is in test code: understanding what we're doing is important in this context." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case.", "reference": "prob should still have an example that has multiple option names even if you have to make it up. Or maybe we don't need this method?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I believe respond_to whitelists the formats passed to the block so if we don't want to display html, we can just remove the line format.html..." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "stylistic nitpick: I _feel_ like we've largely shown errors like this as \"error: \" vs. \"error=\". IMO colon/space reads better." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, but it's a bug.", "reference": "We could put this implementation in `RTPSWriter::create_change_pool` and avoid an extra function." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "should this file ends with _test.go?" }, { "prediction": "I'm not sure if this is the case, but if it's the case, it's probably the case.", "reference": "It's because of this change. `ss` was unused and it made sense in the program. However I haven't read the IPv6 RFC so I'm unsure of what it does" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "\"Flatten\" is a verb, so I'd probably go with `flattenedIndex` as a variable name here." }, { "prediction": "This function is called once through the life of the server. This function is called once through the life of the server. This function is called once through the life of the server. This function is called once through the life of the server. This function is called once through the life of the server. This function is called once through the life of the server. This function is called once through the life of the server. This function is called once through the life of the server. This function is called once through the life of the server. This function is called once through the life of the server. This function is called once through the life of the server. This is called once through the life of the server. This is called once through the life of the server. This is called once through the life of the server. This is called once through the life of the server. + * @param {Array} maskables a list of strings to be masked + */ +exports.addMaskables = (maskables) => { + maskables.forEach((i) => { + maskables.forEach((i) => { + valuesToMask.push(i) + }) + }) + } + /** * This function is called once through the life of the", "reference": "If it can only be called once, perhaps a more appropriate name is something like `setMaskables`? `addX` sounds like you can add many `X`es by calling it many times" }, { "prediction": "I'm not sure if I'm missing something here, but I'm not sure if I'm missing something here, so I'm not sure if I'm missing something here.", "reference": "Nodecfg should be downloading from a private bucket -- these shouldn't be for public consumption. In general these should be generic and expect environment to provide appropriate credentials and bucket." }, { "prediction": "I'm not sure if this is a bug, but it's a bug in Microsoft Edge. I'm not sure if it's a bug, but I think it's a bug in Microsoft Edge.", "reference": "Could you please end the file with an empty line?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this: I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "This is an incorrect change. The dialect spoken is an important part of the handshake and should be communicated to users." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Can this be non-exported to avoid direct use? It would be a breaking change but using previous package version would work." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Nit: this is just `return gcerrors.Code(err)`, isn't it?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case. I'm not sure if this is the case, but I'm not sure if it's the case. I'm not sure if it's the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "I don't know where this came from, but it's not a good idea. This is actually timing out after 5 rounds, not 5 blocks. 5 consecutive null blocks won't be that uncommon. Also when testing with a short block time, this is a very short duration that can contribute to flaky tests." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "In Python 3 when pickling or unpickling objects, the file needs to be opened as binary so that no text encoding/decoding takes place. So for any open calls around pickle loads or dumps, the mode for reading must be rb and the mode for writing must be wb." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "did you remove **params.qstring.method** intentionally? if so why?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if it's the correct way to do it, so I'm not sure if it's the correct way to do it.", "reference": "What is the current default? Is that inconsistent across uses and that's why this is null?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this should work.", "reference": "Why did we make this change? How come it wasn't an issue before" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "Can you tighten scope by moving to of these variables? i.e. Move to ~4372?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Nice to see this `dataverse.rserve.password` fix rolled in." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "How about the following faster alternative that doesn't need `strlen()` at all: if (*tmp_optarg == '\\0' || *endptr!= '\\0') { fprintf(...)... This would treat the bus argument as invalid if it's either empty (`tmp_optarg` points to '\\0') or invalid (`endptr` points to something other that a '\\0'). Actually, the existing code would accept an empty argument and set the bus to `0`, so if (*endptr!= '\\0') { fprintf(...)... would be enough. The check for an empty argument doesn't hurt, though." }, { "prediction": "I think this is what you're looking for.", "reference": "I could be missing something here, but the `from` and `cc` are the same. On the test email sent to gatewaycommunicator, these values are different." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "I'm honestly scared because act is now a hard requirement for useEffect which it wasn't before... This could break some tests :(" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Could use election from `info_a.election`, or is this deliberate?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm assuming you're using Symfony 4.2 or above. If you're using Symfony 4.2 or above, you'll want to use the legacy form helper instead. If you're using Symfony 4.2 or above, you'll want to use the legacy form helper instead. If you're using Symfony 4.2 or above, you'll want to use the legacy form helper instead. If you're using Symfony 4.2 or above, you'll want to use the legacy form helper instead. If you're using Symfony 4.2 or above, you'll want to use the legacy form helper instead. If you're using Symfony 4.2 or above, you'll want to use the legacy form helper instead. If you're using Symfony 4.2 or above, you'll want to use the legacy form helper instead.", "reference": "looks like this should be `return array(LegacyFormHelper::getType('form'));`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Maybe it would simpler to ignore opt_port if type!== 'number'?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "Where was `name` being declared before?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "nit: use `corev1.ConditionUnknown`" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "You also need to add a similar check on line 992, there's another place where we check `length === 24`" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "nit: can extract the voteProvider as a local variable" }, { "prediction": "I'm not sure if this is what you're trying to test, but I'm not sure if it's what you're trying to test.", "reference": "[0] Not suggesting you change it here, but....kindof weird that there's just not an `assertFuncNotEquals`" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug, so I'm not sure.", "reference": "why are we passing'registryAddress' here? We probably should construct it together with bc. Registry is not something that change?" }, { "prediction": "It's like this, but I'm not sure if it's like this, or if it's like this, or if it's like this, it's like this, or if it's like this, it's like this, but it's not like this, but it's like this, and it's like this.", "reference": "`.` at the end of the sentence" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "wouldn't it be useful to split this into an error metric for the timing?" }, { "prediction": "I'm not sure if this is what you're looking for, but it should work.", "reference": "Not sure if this is good enough. Each generator will have it's own unit test anyway. Ideally, I think I'd want to test that each generator in the yml is actually a valid generator..." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm not sure.", "reference": "line is 138 characters" }, { "prediction": "This is a bug. It should be fixed in a future release.", "reference": "Nit: I would leave `Wire` out of the description; if you use this without wire you can still use it." }, { "prediction": "It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug.", "reference": "Nit: each field can be on a separate line to make it visually easier to read." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like 'compilation_db.json' instead of 'compilation_db.json'.", "reference": "Do we still have these files? Shouldn't we remove these?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "A lot of things to do with constants seemed to move since the original commit, so I stuck this here, Is there a better place for it?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "is 10 too small compared to 1000? consider sync chan is unicast only (vs block chan is broadcast + unicast), i would say use 200~400 for BlockSyncChanSize my concern is that this would potentially slowdown sync speed of full-node" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "A full parse of the plan here on listing the plans will be expensive from both a computation and IO perspective." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "These constants use the `_PIN` suffix, while the other constants don't use it. I'm not sure what is best, but I would prefer to keep this consistent. Do you have an opinion on which it should be (with or without suffix)?" }, { "prediction": "I don't think it's a bug, but it's a bug in PicoCLI.", "reference": "Hmm... this feels like discovery should come first. perhaps `--discovery-dns-url`? @NicolasMassart any opinions on this or ideas on who it should be run by?" }, { "prediction": "I'm not sure if this will work for you, but it should work for you.", "reference": "why is this needed?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "I wonder if it'd be possible to autogenerate a key from the name within this function if one is not provided explicitly, rather than having all the callsites pass both the name and key (and usually as the same value)? Might give us a good place to implement a `name->key` function that isn't 1:1." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "@adriancole I do not see a change in the thrift file. Are there unit tests verifying that this manual serialization is compatible with the native Thrift serialization done by classes generated from `.thrift` IDL file?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "spelling (variable name, all three changes)" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "I believe you meant \"specify `desiredUID` and `desiredRole`\"?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Please follow the import style, move it to its similar group" }, { "prediction": "IsUnrecognizedEncodingError(err error) bool { + return ok +}", "reference": "Do we really need these? This is expanding on an API that we're about to do work on with the error stuff @kriskowal" }, { "prediction": "I think this is a bug. It's a bug. It's a bug. It's a bug.", "reference": "passwordModificationTime is no longer used - did the change drop a time check that should be restored? Or should the param get dropped from the methods?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Would it break here without trim? If so, can we do trim in Startup.cs so we don't need to add this code to every parser?" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "Since we're using Logrus, probably best to use `Infof` to avoid confusion (Logrus' Printf behaves differently to the built in one)" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Hm, this looks like a change that should go upstream as well." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but I think it's a bug.", "reference": "let's keep ActionByActionHash and delete getActionByActionHash" }, { "prediction": "public function isPricingGroup() { return $this->pricingGroup; } public function isPricingGroup() { return $this->pricingGroup; } public function isPricingGroup() { return $this->pricingGroup == null; } public function isPricingGroup() { return $this->pricingGroup == null; } public function isPricingGroup() { return $this->pricingGroup == null; } public function isPricingGroup() { return $this->pricingGroup == null; } public function isPricingGroup() { return $this->pricingGroup == null; } public function isPricingGroup() { return $this->pricingGroup == null; } public function isPricingGroup() { return $this->pricingGroup == null; } public function isPricingGroup() { return $this->pricingGroup == null; } public function isPricingGroup() { return $this->pricingGroup == null; } public function isPricingGroup() { return $this->pricingGroup == null; } public function isPricingGroup() { return $this->pricingGroup == null; } public function isPricingGroup() { return $this->", "reference": "please use return type" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "This is deliberately at this level." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I'm going to go ahead and undo this change, I don't think it was intentional." }, { "prediction": "The above logic is further specialized, depending on the kind of the current AppDomain and where the app is hosted: ///
///
///
/// The above logic is further specialized, depending on the kind of the current AppDomain and where the app is hosted: ///
///
///
///
/// The above logic is further specialized, depending on the kind of the current AppDomain and where the app is hosted: ///
///
///
/// The above logic is further specialized, depending on the kind of the current AppDomain and where the app is hosted: ///
///
///
///
/// The above logic is further specialized, depending on the kind of the current AppDomain and where the app is hosted: ///
///
///
///
/// The above logic is further specialized, depending on the kind of the current AppDomain and where the app is hosted: ///
///
///
///
/// The above logic is further specialized, depending on the kind of the current AppDomain and where the app is hosted:", "reference": "> specialised This isn't a typo in my neck of the woods" }, { "prediction": "I'm not sure if it's a bug, but it's a bug in Knative-gcp/test/cmd/storageTarget. I'm not sure if it's a bug, but it's a bug in Knative-gcp/test/cmd/storageTarget.", "reference": "will change to `storage_target`" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "This would be better as `cls.securitycenter_client`, to match what is being instantiated." }, { "prediction": "I'm not sure if we have separate system32 directories for 32 and 64-bit processes? If we have separate system32 directories for 32 and 64-bit processes, then we can use the `````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````", "reference": "Could we have this initialization as part of the initialize method?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug.", "reference": "This line should be removed as editController is not used from this context anymore." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm guessing it's what you're trying to do.", "reference": "This is correct in concept but the method signature doesn't really communicate the same thing. In other words, if the function produces an output table where is it? Its not on the function signature. Can you explain where the output table is created?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do. I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "For insurance, it's best not to take it directly" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "change 'value' to keysToSend, here and in other references in this commit. 'value' implies the user is getting the value of the element, rather than just the keys we're sending to it." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "is the plan to fully migrate to boltdb and then remove the state save here?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "This should be `output.colorBright`. Unless I'm missing some reason for adding a new theme variable." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug in the version control system.", "reference": "nit: I wonder if these should be moved down to where version is defined, just to keep them all in the same place." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Is this supported by every implementation of Java (and Android)? Should it be conditional upon `gen_nullable`?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "@briri Thanks! I just caught this too updating my feature branch" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "I think you should move this block (and the `envpw := os.Getenv(\"RCLONE_CONFIG_PASS\")`) right to the start of the function, then we can remove the duplicate code below" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Is this only to set the node to draining? I think we can do that inside `Before` or something?" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "This should have been moved up above this inner `try` because the log message in the `catch` block does not apply to this." }, { "prediction": "I'm not sure why it's not working, but it's worth noting that it's not working, and it's not working, so it's just a bug. It's just a bug. It's just a bug. It's just a bug. It's just a bug. It's just a bug, and it's not a bug.", "reference": "Do we expect people to use PlanResult directly?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "Maybe we should call this something like `errToReturn`?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "should calculate numEpochIn1Year = xxx and <= fairBankEpochNum+numEpochIn1Year a.foundationBonusLastEpoch just happens to be equal to 1 year now, but should not count on that" }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it.", "reference": "I wasn't sure if the content type needed to be removed from both the `default` and `usemap` objects - I'm not sure how usemap is used." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "Duplication of line 28 Please refer your tox -e flake8 It seems that XStrField, XShortField, FieldLenField are not used" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure.", "reference": "I don't really understand the `self._file_model.index(path)` as parent here - you use `self._root_index` for `rowCount` above, so wouldn't the parent here need to be `self._root_index` as well?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea to have a minimum length of a query word to return suggestions.", "reference": "Do we want validation somewhere that max >= min? Or simply treat the max < min case as ignoring max?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": ":+1: that's a easier example :)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "If an external module decorates this interface, such a change will cause it to generate an error" }, { "prediction": "I don't think it's a bug, but it's a bug.", "reference": "Oh ha hah, FNM_PERIOD worked out nicely there. Points for co-opting a file system convention." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this.", "reference": "wrong grouping. As you can tell from the other files, we put system packages in the first group, the 3rd party packages in the second group, and our own packages in the third group." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Is `o.name` always set here?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Can this line be removed, as `SteadyStateDependencies` isn't updated anywhere? Also do we need to check the `TransitionDependencySet` here?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "`plan.present?` and `has_active_subscription?` are equivalent. We can drop this change, while leaving the one on `app/controllers/application_controller.rb`." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "No need for this, as pylint already only turns things off for this function and it's needed for the entire function." }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "L171 needs to be modified too?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do.", "reference": "Why do you compare by nodeid? Simply saying d == e should be enough. Unless we have to objects in memory with the same nodeid. If that is so, something went really wrong." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "configs/pvt/retinanet_pvt_t_fpn_1x_coco.py --> configs/pvt/retinanet_pvt-t_fpn_1x_coco.py" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Nit, this could be json:\",omitempty\"" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to build a docker image from a local Dockerfile. I'm not sure what you're trying to do here, but I'm guessing you're trying to build a docker image from a local Dockerfile. I'm not sure what you're trying to do here, but I'm assuming you're trying to build a docker image from a local Dockerfile, so I'm not sure what you're trying to do here.", "reference": "It's kinda funny to read `s.Image.Image` I wonder why it resulted to this way. What would it take to refactor to just `s.Image`?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "nit: I like the idea! can we instead change the tag to `integration-remote` to be more specific? I feel like it's possible for us to use the `deploy` build tag for possibly another scenario" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "Copy and paste error here. Edit: Also missing commas here and in other Perl croaks between some parameters and not others." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "stateRoot or maybe ParentHeader would make more sense from API point of view?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug in the PlaybackServiceFlavorHelper class. I'm not sure if it's a bug, but it's a bug in the PlaybackServiceFlavorHelper class.", "reference": "Are you sure that this is no longer needed?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug. I'm not sure if this is a bug, but I'm not sure if it's a bug.", "reference": "Would it help to use SCAN_COLUMNS as base to build SCAN_WITH_STATS_COLUMNS e.g like so `SCAN_WITHSTATS_COLUMNS = ImmutableList.builder().addAll(SCAN_COLUMNS).add(\"value_counts\",....).build()`?" }, { "prediction": "This service is deprecated, use ReportPipedMeta instead. This service is deprecated and should be removed in favor of ReportPipedMeta. This service is deprecated, use ReportPipedMeta instead. This service is deprecated, use ReportPipedMeta instead. This service is deprecated, use ReportPipedMeta instead. This service is deprecated, use ReportPipedMeta instead. This service is deprecated, use ReportPipedMeta instead. This service is deprecated, use ReportPipedMeta instead. This service is deprecated, use ReportPipedMeta instead. This service is deprecated, use ReportPipedMeta instead. This service is deprecated, use ReportPipedMeta instead. This service is deprecated, use ReportPipedMeta instead. This service is deprecated, use ReportPipedMeta instead. This service is deprecated, use ReportPipedMeta instead. This service is deprecated, use ReportPipedMeta instead. This service is deprecated, use ReportPipedMeta instead. This service is deprecated, use ReportPipedMeta instead. This service is deprecated, use ReportPipedMeta instead. This service is deprecated, use ReportPipedMeta instead. This service is deprecated, use ReportPipedMeta instead. This service is deprecated, use ReportPipedMeta instead", "reference": "`ctx` is unused in ReportStat" }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include ", "reference": "We don't want to add boost as a dependency when building the Thrift compiler. Sorry." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "It's not printing the range. Also I think it's useful to print a warning above stating that the minimum change is -1000." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "if name is empty will this become enumerate? (and cause the unmarshal to fail?)" }, { "prediction": "I think you'll want to change the link_to to something like this: https://docs.djangoproject.com/en/dev/ref/method-i-link-to-a-link-to-a-link-to-a-link-to-a-link-to-a-link-to-a-link-to-a-link-to-a-link-to-a-link-to-a-to-a-link-to-a-a-link-to-a-to-a-link-to-a-a-link-to-a-to-a-link-to-a-a-to-a-link-to-a-a-link-to-a-a-to-a-link-to-a-a-link-to-a-a-link-to-a-a-link-to-a-a-link-to-a-a-link-to-a-a-link-to-a-a-link-to-a-a-link-to-a-a-link-to-a-a-link-to-a-a-", "reference": "How about including a flash message that explains the exercises are only available to subscribers of X plan?" }, { "prediction": "I'm not sure what you're trying to do here, but I think it's a good idea.", "reference": "You should also call `e.accept()` and `return` so the key press isn't processed further (as we're leaving insert mode anyways)." }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it.", "reference": "Freeze mutable objects assigned to constants." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, but I'm not sure.", "reference": "Hmm, this feels hacky. Maybe good enough if it makes the test more stable, but why is timing even an aspect here, since below it should wait for these two things anyway?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Do we want this on by default, or an opt-in (e.g. via some config while add the instrumentation)? I guess a more general question is - what's the bar for the default vs opt-in tags." }, { "prediction": "I'm not sure if this is the correct way to do it, but it seems to be the correct way to do it.", "reference": "`status` is just one of the features, named as status is not suitable." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "There is an option to hide the subscriptions list from the sidebar. If it is hidden, the filter text should not be displayed." }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "I'd like for all of this to be dynamically configurable at some point, but it doesn't have to be in this PR. Can add it to the future SIP or create a separate JIRA for it, as you think would be appropriate." }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, it's a bug.", "reference": "move the constructor to down the `namespace`" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Nit: ending with a '.' looks consistent with the fields around it." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Audit log will not have a warning about they are using a deprecated path, is it something we must care about?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "I think you also want to update the condition to add ` || impl.Visibility == TypeMemberVisibility.FamilyOrAssembly`." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "`DepositToRewardingFundBaseGas` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "What do you think of \"operations\"?? Also what do these emojis look like on Linux??" }, { "prediction": "@@ -0,0 +1,16 @@ +<% content_for :subject_block do %> +

+ Sign your team up for <%= t('shared.subscription.name') %> today, and give them the finest Ruby on Rails content and the best expert teachers. +

+<% end %> + +

Your team gets all of the great benefits of <%= link_to t('shared.subscription.name'), prime_path %>, with a nice price, and a nice discount off the normal price, and a nice discount off the normal price, and a nice discount off the normal price, and a nice discount off the normal price, and a nice discount off the normal price. New members can be added at any time.

+ +
+ <%= render @plans %> +
+ + + <%= link_to \"View all the features of #{t('shared.subscription.name')}\", prime_path %> + + + <%= link_to \"View all the features of #{t('shared", "reference": "I like the word \"give\" here. Feels like I'm giving a gift to my team." }, { "prediction": "I think this is a bug in sklearn.utils.estimator_checks.py. It should be removed from sklearn.utils.estimator_checks import _yield_all_checks, _yield_all_checks_default_constructible, _yield_all_checks_default_constructible, _yield_all_checks_default_constructible, _yield_all_checks_default_constructible, _yield_all_checks_default_constructible, _yield_all_checks_default_constructible, _yield_all_checks_default_constructible, _yield_all_checks_default_constructible, _yield_all_checks_default_constructible, _yield_all_checks_default_constructible, _yield_all_checks_default_constructible, _yield_all_checks_default_constructible, _yield_all_checks_default_constructible, _yield_all_checks_default_constructible, _yield_all_checks_default_constructible, _yield_all_checks_default_constructible, _yield_all_checks_default_constructible, _yield_all_checks_default_constructible, _yield", "reference": "Is it possible to use `np.random` module instead?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "``default=None`` implies ``allow_None`` so ``allow_None`` is superfluous here. As a special case, if allow_None=True (which is true by default if the parameter has a default of None when declared) then a value of None is also allowed." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "Is there anything in particular that makes setting up the downstream rolebinding(s) to `system:k3s-controller` burdensome or confusing? This changes looks fine to me but it seems a shame to alias an embedded k3s controller. If we are doing this in other places that I am not aware of then we can dismiss this concern out of hand." }, { "prediction": "I'm not sure if it's a bug, but it's a bug in github.com/ncw/rclone/fs/config/configmap. I'm not sure if it's a bug, but it's a bug in github.com/ncw/rclone/fs/config/configmap. It's a bug in github.com/ncw/rclone/fs/config/configmap. It's a bug in github.com/ncw/rclone/fs/config/configmap. It's a bug in github.com/ncw/rclone/fs/config/configmap. It's a bug in github.com/ncw/rclone/fs/config/configmap.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this:", "reference": "nit: all other types in this project have full names, so maybe a better name would be `OperatingSystem`?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm wrong, or if I'm wrong, I'm just guessing that I'm missing something.", "reference": "Why is this needed here?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug. If it's a bug, it's a bug.", "reference": "mmm, why a method declaration should not have the TypeVariableResolutionCapability? Is this ok?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "nit: any reason you swapped the ordering?" }, { "prediction": "I don't think this is a bug, but it's a bug, and it's a bug.", "reference": "can you de-uglify at least this line?.. hard to tell what changed..." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so it's a bug.", "reference": "Please can you merge master in before making these changes. I just reinstated a bunch of BPF UTs. Possible that the UTs use this code." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Do you want to add additional cases for `Bla.__b()` and `self.__c()`? (Just add additional classmethods `__b` and `__c` and the calls to `__init__`)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "the recids is never changed after. So, it should contains the exact shown results, whatever are the rights for the user (admin or simple user, restricted collections...)" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Shouldn't the docstring mention that the MD5 checksum of `p` is computed each time and verified? Also, could there be use cases where a caller might not want such a check to happen because, eg, a blob storage solution doesn't provide MD5 verification or uses another hash algorithm such as SHA256?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "focusRedirect is used in the powerpnt appModule. We might have to make sure that this does not break. Having said that, I really like this being handled on the events level!" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like \"gcp_clients\" or \"gcp_clients\" or \"gcp_clients\" or \"gcp_clients\" or \"gcp_clients\" or \"gcp_clients\" or \"gcp_clients\" or \"gcp_clients\" or \"gcp_clients\" or \"gcp_clients\" or \"gcp_clients\" or \"gcp_clients\" or \"gcp_clients\" or \"gcp_clients\" or \"gcp_clients\" or \"gcp_clients\"", "reference": "You imports are out of order" }, { "prediction": "I'm not sure if it's a bug, but it's a bug, and it's a bug.", "reference": "This should not be called Flow Trigger. FlowTrigger should has its own flowTrigger job name, for instance, \"flowtrigger\"" }, { "prediction": "This source code is not available in the future, and is not available in the future. It is available in the future, and is not available in the future. This source code is available in the future, and is not available in the future. This source code is available in the future, and is not available in the future. This source code is available in the future, and is not available in the future. This source code is available in the future, and is not available in the future.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I'm not sure if this is what you're asking, but I'm not sure if this is what you're trying to do.", "reference": "Why do we need `\\n` if we already use `WriteLine`? (and `\\n` is not cross platform)" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "What is instrumentation name used for? I'm not seeing other classes use it, only a getter, constructor, and builder." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "@kristofgazso could you review these warnings?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "will delete this." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this?", "reference": "~~Indent 2 lines above~~ Disregard. My fault" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm not sure.", "reference": "What was the bug that this is fixing?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "This will always add the authorization header to the request object. Is this the right scope for these two lines? If username/password are not defined, it will encode 'Basic :'" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Is this always how Bazel does paths? Would it be nicer to do `-DBAZEL_TEST_DATA_PATH=../com_github_google_flatbuffers/tests/` so this string is not hardcoded in the the source?" }, { "prediction": "I'm not sure if this is what you want, but I think it's a good idea.", "reference": "Not an expert of ES, so not sure of the impact here." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "Who deletes the memory for the granteeList? (or the roleList for that matter)" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "This loop is missing a lock on subscriptions_mutex." }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "shouldn't clearance be setting these up for us?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Need to update the doc for `TelemetrySDK` and `Host` structs deleting references from removed functions." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, it's a bug, or if it's a bug, it's a bug.", "reference": "I think we should keep that here and add a new method `isSyntacticallyFinal` that returns `super.isFinal()` (and can be used in UnnecessaryModifier). Otherwise the contract of `isFinal` is not respected" }, { "prediction": "I'm not sure if this is the case, but if it's the case, it's the case.", "reference": "Is there a reason why we wouldn't want to check this every time? Why are we only checking for the footer and scroll bar when enableCellEditOnFocus is true?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "You need to create an API for this class. This class should follow roughly the same dependency structure than RemoteAvailableInstallersPlayOnLinuxImplementation / RemoteAvailableInstallers. Maybe we could use a inner class here?" }, { "prediction": "I'm not sure if this is the correct syntax, but it should be ```````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````", "reference": "This should not be a case, right? If `run_id` is the same `workflow_id` can't be changed. Actually surprised that it is not part of a key." }, { "prediction": "I'm not sure if this is the case, but it seems to be the case.", "reference": "How would AQR work for an INSERT/SELECT of one table into another where a LOB column is being copied?" }, { "prediction": "\"github.com/envoyproxy/go-control-plane/envoy/service/secret/v3\" \"github.com/envoyproxy/go-control-plane/envoy/service/secret/v3\" \"github.com/envoyproxy/go-control-plane/envoy/service/secret/v3\" \"github.com/envoyproxy/go-control-plane/envoy/service/secret/v3\" \"github.com/envoyproxy/go-control-plane/envoy/service/secret/v3\" \"github.com/envoyproxy/go-control-plane/envoy/service/secret/v3\" \"github.com/envoyproxy/go-control-plane/envoy/service/secret/v3\" \"github.com/envoyproxy/go-control-plane/envoy/service/secret/v3\" \"github.com/envoyproxy/go-control-plane/envoy/service/secret/v3\" \"github.com/envoyproxy/go-control-plane/envoy/service", "reference": "Since these are ultimately different endpoints, it would be nice if we could move them up one level and nuke the common `sds` directory in order to reduce path stutter" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Please check also whether `null` occurs in the rest of `beforeChangeResult` array." }, { "prediction": "I'm not sure if this is the case, but I think this is the case. I'm not sure if this is the case, but I'm not sure if this is the case.", "reference": "Outdated docs. There is no response, there's an ack." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "I'd rather have the container process remove the FIFO after it unblocks. Then `start` can always `Exec()`, and you can catch the \"FIFO does not exist\" error and translate it to a prettier \"someone must have already started the container\"." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "can you check if there's other similar cases to add nil-check like this?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "`<= 64`? I just picked up what you said in #3981 (\"the CN field is limited to 64 characters\") but maybe there's something I don't know where the 64th character is needed (trailing dot or whatever?) Also this sounds like something that could be beautifully unit tested. Sorry for bugging you :grin:" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "I understand that this grabs a Licenses objects but what is the autocomplete method used for? What does this do in context of the auto_completes controller?" }, { "prediction": "I'm not sure if this is the correct way to do it, but it seems like it should work.", "reference": "I don't really like that way of naming methods based on their arguments. But I can see that the other method names are the same..." }, { "prediction": "I'm not sure if this is a bug, but if it's a bug, it's a bug.", "reference": "@sekmiller This method correctly strips the leading and trailing slashes (and also \".\" and \"-\"); But I thought the plan was also to replace any multiple slashes between nested folders with a single slash. For example, as implemented now, I can enter \"folder1///folder2\", and it gets saved and displayed like this, with the 3 slashes. I thought we wanted to sanitize it as \"folder1/folder2\"." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Looks like the X86 inline assembly is not happy with this type. I will update that" }, { "prediction": "@@ -6,6 +6,12 @@

<%= link_to h(diary_entry.user.display_name), :controller => 'user', :action => 'view', :display_name => diary_entry.user.display_name, :id => diary_entry.id %>

+ <% if @user and diary_entry.user.id!= @user.id %> + <%= link_to new_issue_url(reportable_id: diary_entry.id, reportable_type: diary_entry.class.name, reported_user_id: diary_entry.user.id,referer: request.fullpath), :title => t('diary_entry.diary_entry.report') do %> +  ⚐ + <% end %> + <%= raw(t 'diary_entry.diary_entry.posted_by', :link_user => (link_to h(diary_entry.user.display_name), :controller => 'user', :action => 'view', :display_name => diary_", "reference": "Tabs and a space, again." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "Please just enclose if blocks with brackets; this has created issues in the past so I'd prefer we don't use them" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "`version` isn't need anymore because it's built into `approve_proposal_url`, yes?" }, { "prediction": "I think this is a bug in scapy.contrib.ppi_geotag.", "reference": "Moved to the bottom of the file. `CtrlPDU` sits on `BTLE_DATA` so let's put it after" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this:", "reference": "This ends up requiring the `json` gem, right? Is there any way we can do this to be implementation agnostic (e.g. to let me use `yajl-ruby` for performance reasons (or because my app already brings in a JSON library)" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this. I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this. I'm not sure what you're trying to do here, but I'm assuming you're trying to do something like this.", "reference": "This seems dangerous. What circumstances lead to the need for a retry? Can that happen more than once? I'm concerned that if we hit the pathological state, this could turn into a CPU spinner. I wonder if we could get the same benefit from just \"trying again\" and failing if it fails the second time." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "If there is a reference to other fields or methods, please do the initialization in the constructor." }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "These should be importing from `pill-container`" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Why this change? It will now only show on the bottom of the screen as white text, is it correct behaviour?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Does this need to allocate a string or would a nil value (indicating no header) be a better?" }, { "prediction": "I'm not sure if this is a functional component, but if it is a functional component, it's a functional component. I'm not sure if it's a functional component, but I think it's a functional component.", "reference": "Nit: Past tense of `reset` is also `reset`." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Shouldn't this use `'n'` instead?" }, { "prediction": "I'm not sure if this is the case, but if it's the case, then it's probably the case.", "reference": "revert back to 'TASK_TYPE_ACTIVITY_TIMEOUT'" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Shouldn't we prefer passing a pointer by reference T*&, since these are C++ bindings?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "nit: Personally I feel that it's cleaner to let `toAntreaPeerForCRD` to take `ingressRule` as a param instead of `ingressRule.From`. It can call `processRefCGs` inside the function and do the ipBlock/AG union within the function itself. It might not be worth the refactor though." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Pending has been set only for SPC.. why? for other CRs as well, this need to be done.. right?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "would use an empty string here as default and then check for emptiness in the twig template. I dont like mixing types @core23 what do you think?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "How come we need case manipulation for the nextPageToken and not for pageToken?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "why use these rather than regular named paths?" }, { "prediction": "I'm not sure what you're trying to do, but I think it's a good idea to do this.", "reference": "Hm, I don't think the extra flags are doing any harm here, but it does seem like `--help` is the only flag you could *actually* use with this command. We might eventually want to separate those out." }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "We should make this a docstring, so that editors are able to pick it up." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Put a comma after the last parameter of a multiline method call." }, { "prediction": "I'm not sure if this is the case, but if it's the case, it's the case.", "reference": "App cache size is now managed dynamically by the `WebView`. This statement has no effect in the new framework." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "VirtualNode has a `hasAttr` function, any reason why you're not using it?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems to be a bug. I'm not sure what you're trying to do, but it seems to be a bug.", "reference": "This now throws when running tests (maybe the move to java 11??). Do we want to keep it?" }, { "prediction": "I'm not sure if this is the correct way to do it, but it's the correct way to do it.", "reference": "We can allow 7-char SHA, does not mean we want to show with 7-char in default, please change to `if len() > 10`, then cut." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "this one should also have quotes i guess :)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Using the variable on range scope `mock` in function literal (from `scopelint`)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "does this result in a 200 when the dataset is still inprogress/publishing not yet finalized? Seems like 202 is the right code for that (as it was) and the test should be watching for a 202?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Previously you could only order by the field you were searching by. But for full-text search, you can search across all indexed fields, and it didn't make sense not to have a sorting. For backward compatibility, the javascript code uses indexPath as the orderPath when no orderPath is provided." }, { "prediction": "Is there a way to make a `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode` `vnode`", "reference": "VIM didn't like your whitespace." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm assuming it's what you're looking for.", "reference": "Are you sure the namespace should change?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "@martijn00 I'm not sure why we're keeping the object parameter and return type since this can be done by using MvxApplication with THint set to object" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "why do we create a time type here?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Does this style actually need to get loaded in all of these components?" }, { "prediction": "I'm not sure if this is a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "import but not used so you did not resolve compile warnings?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "This is so much more concise and beautiful than the previous formula" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug or a bug. I'm not sure if it's a bug or a bug. I'm not sure if it's a bug or a bug. I'm not sure if it's a bug, but I'm sure it's a bug. I'm not sure if it's a bug or a bug. I'm not sure if it's a bug, but I'm sure it's a bug. I'm not sure if it's a bug.", "reference": "Is there any reason not to have the `static` modifier for the logger? _(that would be in keeping with the reference being uppercase)_" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "It's not about session creation config. It's about passing consumer config parameters to underlying transport - nothing to do with session itself" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Why is there an \"enable\" in the param name? Couldn't it just be `overrideDebug`? Here are everywhere else." }, { "prediction": "I think this is a bug. It should be a bug in the application.rb file.", "reference": "`published.recently_published_first` reads a little oddly to me. Is this the same thing as `Video.published.ordered`?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Encountered this because I had a stray comma. Figured I'd tweak it a bit." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "qq: Should this include the iptables6-save sim. to the inverse checks above?" }, { "prediction": "I'm not sure what you're trying to do here, but I think it's a good idea.", "reference": "im open to explicitly checking NotSet value here but json logic already handles it so kept it this way." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "The naming of the include file appears to be unlucky." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "Bit worried about this. At minimum you should make a copy of the dict here to avoid modifying a user supplied variable." }, { "prediction": "I'm not sure if it's a bug, but it's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug.", "reference": "Is it better to create one before pruning? In case creation fails we don't want to delete the previous one. We create a new one, it is tagged as latest, so the previous can be deleted. `CreateLaunchTemplateVersion` returns the version created, how about directly trying to delete the previous version? Assuming the numbering is strictly increasing." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Do we require the specific implementation information here?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "How about `exists?(['domain ~*?', domain.downcase])`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Is this getting used in other places? Can we switch all the places to use the new API you added?" }, { "prediction": "I'm not sure what you're trying to do, but if you're trying to do something like curl_easy_setopt(curlEasy, CURLOPT_SSL_VERIFYPEER, FALSE);, you'll need to do something like curl_easy_setopt(curlEasy, CURLOPT_SSL_VERIFYPEER, TRUE);, you'll need to do something like curl_easy_setopt(curlEasy, CURLOPT_USERAGENT, g_user_agent_string);, you'll need to do something like curl_easy_setopt(curlEasy, CURLOPT_USERAGENT, g_user_agent_string);, you'll need to do something like curl_easy_setopt(curlEasy, CURLOPT_USERAGENT, g_user_agent_string);, or something like curl_easy_setopt(curlEasy, CURLOPT_USERAGENT, g_user_agent_string);, you'll need to do something like curl_easy_setopt(curlEasy, CURLOPT_USERAGENT, g_user_agent_string);.", "reference": "This need to be checked with linux. AFAIK, we have this file in our bin directory that is a link to the system file." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "Shouldn't we import `default`? I can't get here to test." }, { "prediction": "I'm not sure if this is a bug or a bug, but it seems to be a bug.", "reference": "!!!!!!!!!!!!! @graingert, does this mean that tests haven't been running???" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "I've already tried the null-coalescing operator here and got a strange error, so did this the old-fashioned way." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "This doesn't follow our spacing convention. It's also a little hard to read. Can you reformat?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "The deploy should come before template? EDIT: I see that in other files, we put a separate line and put deploy at the end. What is the reason for this?" }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "Consider making a constant (e.g. `MetricStreamConfiguration.Drop`)." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "same question: why not just switch this to range too?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "@chuckatkins most places used an empty string for \"no type\", but a few used `\"unknown\"`. I've converted both cases to `Type::None`. Do you know why there was a distinction before?" }, { "prediction": "I don't think it's a bug, but it's a bug.", "reference": "should we assert for the type for `FeatureGroupData`? I think it should be 1-Byte type." }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this.", "reference": "As long as you are sure this is definitely correct now... :-)" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "... so that all action buttons have the same height :-)" }, { "prediction": "I'm not sure if this is what you're looking for, but it's worth noting that this is what you're looking for.", "reference": "Use correct, alpha sorted, include order. Correct order means: 1. Header corresponding to this source (i.e. `\"LatencyTestPublisher.hpp\"`) 2. C system headers 3. C++ system headers 4. Alpha-sorted external libraries headers 5. Alpha-sorted public headers from this project 6. Alpha-sorted private headers" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to make a request to a particular URL. I'm not sure what you're trying to do, but I'm guessing you're trying to make a request to a particular URL. I'm guessing you're trying to make a request to a particular URL, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "I hate this name, open to suggestions." }, { "prediction": "I'm not sure if it's a bug, but it's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug.", "reference": "Does this log line work? We need Warningf or just warning without the format string." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "The pull controller would need similar updates." }, { "prediction": "The OpenZipkin Authors + * Copyright 2015-2018 The OpenZipkin Authors * * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except * in compliance with the License. You may obtain a copy of the License at http://www.openzipkin.org/licenses.html.", "reference": "ignore this.. just didn't want to litter with a commit update to satisfy license plugin" }, { "prediction": "I'm not sure what you're trying to do here, but I'm assuming you're trying to do something like this:", "reference": "Is this definition needed since it doesn't look like it's being used anywhere?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Can this condition be reworded using `if` please?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug.", "reference": "after ||, no need inputs!= nullptr" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Is it just preference or on purpose that using slice of structs instead of slice of pointers?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "This line always confused me anyway. Good catch!" }, { "prediction": "IsUnflushed(ctx context.Context, tlfID tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf.ID, tlf", "reference": "Should we add `ctx` to `BlockServer.Shutdown()` for this purpose? Would be nice, but I don't care too much." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Duration_t at RTPS level must be serialized using fractions." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "\"peer\" has its own meaning within YARPC with its own class of objects. This should probably be \"dispatcher\" too?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "I do not like this line break before `=true`. Maybe starting the list in the next line would help to reduce the indent? This way we could keep this string together." }, { "prediction": "I'm not sure if this is the case, but it's the case. I'm not sure if this is the case, but it's the case. I'm not sure if it's the case, but it's the case. I'm not sure if it's the case.", "reference": "_plugins should be removed too" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "The rule selector will not include `` and `` elements. Why not make this a new, separate rule altogether?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "@The-Compiler Is this style okay or would you prefer a common userscript exception base?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "we'd need to return a MongooseBuffer here instead of the Binary. lets add the subtype option to the buffer schema type as referenced in #1000 instead." }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it, so I'm not sure if this is the correct way to do it.", "reference": "Let's remove this change." }, { "prediction": "I'm not sure if this is what you want, but I'm not sure if this is what you're looking for.", "reference": "Could you split this into multiple lines?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug.", "reference": "This technically works, however it may be safer to use both `getCurrentReferenceURL` and `getCurrentEntityURL` and then make this condition `currentReferenceURL === currentEntityURL`. Currently, this code only works based on the internals of `getCurrentReferenceURL`, so by checking both we would decouple that." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, then you'll need to do something like this: if (resp.Body.Close()) { respMsg = fmt.Sprintf(\"Response code: %d, response body: %s\", resp.StatusCode, string(body)) } else { respMsg = fmt.Sprintf(\"Response code: %d, response body: %s\", resp.StatusCode, string(body)) } if (resp.Body.Close()) { respMsg = fmt.Sprintf(\"Response code: %d, response body: %s\", resp.StatusCode, string(body)) } else { - respMsg = fmt.Sprintf(\"Response code: %d\", resp.StatusCode) + respMsg = fmt.Sprintf(\"Response code: %d\", resp.StatusCode) } resp.Body.Close() if (resp.Body.Close()) { respMsg = fmt.Sprintf(\"Response code: %d, response body: %s\", resp.StatusCode, string(body)) } else { respMsg = fmt.Sprintf(\"Response code: %d, response body: %s\", resp", "reference": "It does not recommend capitalization" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Minor thing, but can you use 1.9 hash syntax for this?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "I tried to follow the code structure already present." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "seems reasonable to also want to include the 'to' location?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Please leave 1 space char between commas here and other places in this PR." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "hm is this really &&? Not ||? Was it initially correct if any of these things are not set that it needs to recreated?" }, { "prediction": "I'm not sure if this is the case, but I think it's the case. I'm not sure if this is the case, but I'm not sure if it's the case.", "reference": "Please don't use C-style array declarations. IMO our pre-commit ought to be enhanced to not allow this" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "@rhc54 This doesn't look like a comprehensive comparison. For `PMIX_STRING` we seem to actually compare the content of the data while here we only compare meta-information which doesn't ensure that values are the same." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I think `bypass_frontier_confirmation` conveys the intention better (default false as well)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "This looks like it goes beyond the scope of removing `BlockHeight()`, in the future please do this in a separate commit at a minimum -- separate PR is fine too." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "You'll also need to adjust `FakeWebTabAudio` in `tests/helpers/stubs.py`." }, { "prediction": "The License is not under the License. It is under the License, Version 2.0 (the \"License\"); -you may not use this file except in compliance with the License. -You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - - Unless you have a specific License, it is not distributed under the License. - Unless you have a specific License, it is not distributed under the License. - Unless you have a specific License, it is not distributed under the License. - Unless you have a specific License, it is not distributed under the License, or if you have a specific License, it is distributed under the License. - Unless you have a specific License, it is distributed under the License, or if you have a specific License, it is distributed under the License, or if you have a specific License, it is distributed under the License, or if you have a specific License, it is distributed under the License, or if you have a specific License, it is distributed under the License, or if you have a specific License, it is distributed under the License, or if you have a specific License, it is distributed under the License, or if you have a specific", "reference": "@csrwng what should we do here? This one is from origin." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Follow alphabetical order." }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "As far as I can tell, these always get and set the context as an `IReadOnlyDictionary`. Can we use that here instead of `object` and get rid of the `as IReadOnlyDictionary`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "As you only have `{}` as the format string (without anything else in it), this is the same as doing `self._doc.setHtml(html.escape(self._opt.text))`" }, { "prediction": "I'm not sure if this is the correct way to do it, but it's the correct way to do it. I'm not sure if this is the correct way to do it, but it's the correct way to do it.", "reference": "Where would this be configured? In azkaban.properties?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "1. Use `const` instead of `var` here. 2. Move the check to after the `if (update == null || typeof update!== 'object')`." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case.", "reference": "Let's assume that on Linux `eventfd` is always available as a wrapper of the eventfd2 system call. It is supported since linux 2.6.27 + glibc 2.9, as well as from the ancient versions of bionic. In other words, it would be fair to argue that the pair would be available on practically all platforms that provide `pipe2`. Therefore switching from using `pipe2` to `eventfd` on linux unconditionally would not cause issues on our users." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "This field could be `final`." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "would be good to have a test for the case when `shutdown!` raises" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if this is the case, so I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "Does upsert pass this check also?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Apologies reviewers, I did end up pushing another change. I was starting to request SRE-P help to get the apiserver configs from some clusters before and after when I realized I can just log the stdout from the patch command to see if anything was changed or not. Much simpler to verify if my work did or did not make changes to the config during the transition. Also got the spacing issue you mentioned @abhinavdahiya Thanks all." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "I'm not sure this naming is a good idea; that's the format for macOS xattr metadata files on unsupported filesystems." }, { "prediction": "I think this is what you're looking for.", "reference": "Metrics/LineLength: Line is too long. [85/80]" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, or if it's a bug.", "reference": "Please remove these imports. The project's style is to use `Assert.assertEquals` and not import static methods in general. This also caused a lot of unnecessary changes." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure.", "reference": "thanks. Note that returning at this point might leak memory from the allocations above, so the PR will need to take care of that too." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "If you really want to rename this, you'll also need to adjust the name in `__init__` and in other places it's used (`browser/commands.py`)." }, { "prediction": "I'm not sure why this doesn't work, but I'm not sure why it doesn't work.", "reference": "As discussed at standup, I gave up on this. Calling `DeleteMapLayerMetadataCommand` felt cleaner anyway because there might be other cleanup that needs to happen. @scolapasta and @matthew-a-dunlap plan to discuss this." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Do we need these changes? If so, can you tidy up the messages? Looks like it might have been your testing/debugging changes" }, { "prediction": "The SecretTargetLogDriver is not a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target. It's a secret target", "reference": "where is the default being set?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "these changes should likely be in the next commit instead" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Since you have defined this struct, I would suggest to replace all exist literal structs by this." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "The field name doesn't really capture what this option does. I think `mConfirmDiscardMessage` would be a better choice." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "what if `$media->getBinaryContent() == Symfony\\Component\\HttpFoundation\\File\\File` does `is_string()` return `true`? ping @greg0ire" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "maybe rather than `bool` make this field a `StructDef *`?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Shall we maybe put this in a `const` like `backgroundTaskTimeout`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "CI is complaining about this." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Let's only change a file if it is really necessary. Such a change does not bring much value and makes it harder to find the original commit in which the method was introduced." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this, and you're trying to do something like this, which is not what you're trying to do.", "reference": "I would prefer to set up space between classes in format pattern, `%s %s` and then use `trim()` to remove unnecessary whitespaces. This will also solve stripping whitespaces from the beginning and end of a string `$attributes['class']`" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I think I'm correct.", "reference": "when Op is illegal should return here?" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "don't we need to remove the project version from installedVersions?" }, { "prediction": "I think this is what you are looking for. It should be something like this: @bridge.send_command(cmd: cmd, params: params) end + def print_page(**options) + options[:page_ranges] &&= Array(options[:page_ranges]) + + bridge.print_page(options) + end + private def debugger_address(options)", "reference": "the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think you're trying to do something like this:", "reference": "This is intended. Pls revert this." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Something wrong with cast to `(Comparator<> & Serializable)`, need to be investigated" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "I think we need this. Not sure, I'll test." }, { "prediction": "I'm not sure if this is a bug or a bug, but it seems to be a bug.", "reference": "I'm going to need to check if google compute requires these steps in this order, or if you can disable iptables after the fact." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to build a package that doesn't have a dependency on a package that doesn't have a dependency on a package that doesn't have a dependency on a package that doesn't have a dependency on a package that doesn't have a dependency on a package that doesn't have a dependency on a package that doesn't have a dependency on a package that doesn't have a dependency on that package.", "reference": "Did go change their tags with the new version?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "I don't recall what we decided here in terms of which source would get priority. As written, the static configuration will overwrite datastore results." }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "I think it should still panic for when there are no outputs; might be nice to special-case that though so the message is more explicit." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "*NULL_DEREFERENCE:* object `null` is dereferenced by call to `meterSupplier(...)` at line 122." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "switch over to.mode" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "I guess your IDE did some auto-fixing here" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "This is an unused import failing recommit still." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "I'm concerned that we're conflating multiple things here. There are 2 things that Beaker should really care about: - Network transport - i.e. `ssh` vs `winrm` - Interpreter - i.e. `bash`, `cmd`, `powershell`, etc The problem is that @cowofevil is running Bitvise SSH, and he assumed we should be setting `is_cygwin: false` in node definitions. But that doesn't really accurately convey what we care about, and since Beaker doesn't appear to track network transport apart from interpreter, we end up in a strange state. `is_cygwin: false` appears to end up setting `is_powershell?` to `true`, which IMHO is not accurate or appropriate. Bitvise templates use `ssh` (like Cygwin), but the interpreter used is `cmd`, not `powershell`." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I think this is ok for now. This ties into the larger issue of the site not having a consistent method for relaying form input errors. Please make sure the focus gets set on the close button when the dialog opens." }, { "prediction": "The plugin uses GhostTable and SamplesGenerator for calculations. * ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Should these link be removed?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Please make this a keyword-only argument by adding a `*` argument before `add_undo`." }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "didn't quite follow what this code block is doing." }, { "prediction": "I'm not sure if this is what you're looking for, but it's what we're looking for.", "reference": "this doesn't sound pretty... I would rather we have a proper navigation for all modes - AFAIK TV remote navigation is very similar to normal keyboard, but maybe it just uses another key codes - those should be extracted in a single file and defined there depending on context then" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "After diffing the children we check whether the value got out of sync, if it did we update it. We also update the `_prevValue` to prepare for the next event hitting our controlled component" }, { "prediction": "This is a BSD-style license that can be found in the LICENSE file.", "reference": "It provides a type called Node which is a fully functional bee client. This package is where the dependencies are injected. It is not just a glue-code, it is concept of node." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "I think this will change `''` to `'%'` unconditionally, i.e. there'll be no way to set `''` anymore. This should really only be used for values which make no sense anymore." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Nit: this table's row key map -> this table's row keys map" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "this change should be reverted" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "I'm a bit confused about the `os.path.dirname(basedir)` here - is this just to get to the parent directory? Either way, I think I'd prefer just having this in `update_version.py` as it's not needed in qutebrowser itself." }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "Revert this change and see below why..." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Should not switch to `lvis_v1_instance` here because that base config uses ClassBalancedDataset to oversample the data." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "This is an informational message that allows someone to read the console output and understand how the grid node is configured. Please leave." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "This doesn't make sense to me. What does RaiseSingleton mean? To me it sounds like a single object is being.. raised? Not sure." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "What's the benefit of having jobExecutorTests as a member variable? What do you think about making the method static? Afterall, it is a stateless method." }, { "prediction": "The possible subcommands are: dump Dump metadata objects + check Check metadata objects and their associated blocks for errors `", "reference": "This looks like it's only downloading things, not really checking their true validity. Especially for the MD object. Should we call `BareRootMetadata.IsValidAndSigned()` in `mdGet`?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "Nikoli, I believe that this addresses your concern. One question for you or Jae-Seung is if any allocation from the clone is properly cleaned up when the vector is destroyed. I believe that it should." }, { "prediction": "I'm not sure what you mean by \"SealedSecret\" but I'm not sure what you mean by \"SealedSecret\" but I'm guessing that you mean \"SealedSecret\" or \"SealedSecret\" or \"SealedSecret\" or \"SealedSecret\"?", "reference": "should be `ECSApp`" }, { "prediction": "@property def rect(self): \"\"\"A dictionary with the size and location of the element.\"\"\" - return self._execute(Command.GET_ELEMENT_RECT)['value'] + if self._w3c: + return self._execute(Command.GET_ELEMENT_RECT)['value'] + else: + rect = self.size.copy() + rect.update(self.location) + return rect + @property def screenshot_as_base64(self): \"\"\"A dictionary with the size and location of the element.\"\"\" - return self._execute(Command.GET_ELEMENT_RECT)['value'] + if self._w3c: + return self._execute(Command.GET_ELEMENT_RECT)['value'] + else: + return self._execute(Command.GET_ELEMENT_RECT)['value'] + else: + rect = self.size.copy() + rect.update(self.location) + return rect + @property def screenshot_as_base64(self): \"\"\"A dictionary with the size and location of the element.\"\"\" - return self._execute(Command.GET_ELEMENT_RECT)['value'] + if self._w3c: + return self._execute(", "reference": "flake8 is going to fail on this having 2 lines" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "should we make a dir named controllers/scheduler/podchaos" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to create a new Provisioner object from a different key node. I'm guessing you're trying to create a new Provisioner object from a different key node. I'm guessing you're trying to create a new Provisioner object from a different key node. I'm guessing you're trying to create a new Provisioner object from a different key node. I'm not sure what you're trying to do, but I'm guessing you're trying to create a new Provisioner object from a different key node.", "reference": "there seems to be one KeyNode in kubernetes.go of PV.. would it make sense to use it?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Im gonna be a little annoying here but did you configure your linter correctly? This empty line should not be here. Maybe go to settings and check if `goimports` is enabled?" }, { "prediction": "I'm not sure if this is the case, but maybe this is the case? If it's the case, then maybe this is the case, then maybe this is the case?", "reference": "Don't think this belongs in this pr" }, { "prediction": "The outbounds is a copy of the map of outbounds for this RPC object. This is a copy of the map of outbounds for this RPC object. This is a copy of the map of outbounds for this RPC object. This is a copy of the map of outbounds for this RPC object. This is a copy of the map of outbounds for this RPC object. This is a copy of the map of outbounds for this RPC object. This is a copy of the map of outbounds for this RPC object. This is a copy of the map of outbounds for this RPC object. This is a copy of the map of outbounds for this `outbounds` object. This is a copy of the `outbounds` object. This is a copy of the `outbounds` object. This is a copy of the `outbounds` object.", "reference": "We can assert on the existence of Outbounds through ClientConfig calls right? Since this is only for tests, do we need this function?" }, { "prediction": "Can we keep the ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `````````````````````````````````````````````````````````````````````", "reference": "@martijn00 so this PR introduces a new ViewModel lifecyle method? It isn't in the PR description/any new docs" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "Are these modification duplicate? Or should we move it into base detector." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Since this is private and single use it should be un-wrapped inside of the two-arg dagSeed method." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "why the order change? Also for the next chunk. (I understand the result will be the same though)" }, { "prediction": "This is not part of the grammar. It is part of the grammar. It is part of the grammar.", "reference": "I wonder if this should just be a single `string`? We don't have any cases where we return different types and it would make the parser simpler to just read a single identifier." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "I don't think this needs to change. Can you go back to the previous implementation?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be fixed in the latest version of molecule.utilities.", "reference": "Bump it 2 lines higher, 'c' > 'u'." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "Please do not add author here" }, { "prediction": "I'm not sure if this is what you're looking for, but it looks like you're looking for something like this:", "reference": "Similarly, we should be able to persist action uniformly" }, { "prediction": "I think this is what you are looking for. I'm assuming you're using Rails 3.x, but I'm assuming you're using Rails 3.x, so you'll need to do this in config/application.rb. If you're using Rails 3.x, then you'll need to do this in config/application.rb. Otherwise, you'll need to do this in config/application.rb.", "reference": "I think i'd prefer this override to be in the test helper instead, if that's possible?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "This would be better with context added via wrapping or fmt.errorf()" }, { "prediction": "You may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 or later. If you do not use this file, you may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 or later, you may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 or later.", "reference": "What's the purpose of this file?" }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it, so I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "@bhariharan Why was passcode length requirement allowed to be lowered?" }, { "prediction": "I'm not sure if I'm missing something, but I'm not sure if I'm missing something.", "reference": "This file needs a license header, too. Sorry I didn't catch that earlier." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "probably don't need `[:]` why not reference into `github.com/algorand/go-algorand/daemon/algod/api/server/lib` here and skip bouncing off daemon/algod/server.go?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Why reference is converted to table?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this, and I'm not sure if this is what you're looking for, but I think you're looking for something like this.", "reference": "should we implement pagination in the fake datastore so the server startup code that paginates entries for trust domain validation can be tested?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "What mechanism will be exposed so the caller knows they're using the vectorized version?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Can we remove respond_to block its not required here" }, { "prediction": "I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "Do not do that even in example, we demonstrate bad practice" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug, but I think it's a bug.", "reference": "Hm, taking a second look over this, this is why we have the object inheritance structure that we do. This could be divided up by having a custom determine_if_x86_64 in the pswindows/exec hosts and then a default method in hosts.rb. That way all the custom ps windows work is in a single location." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "We have to `.Complete` now because of empty/null string test cases." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Is there still a way to specify no recursion?" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "How is this name being URI safe and being used programmatically related?" }, { "prediction": "this.plugin.uppy.info(this.plugin.uppy.info(this.plugin.uppy.info(this.plugin.uppy.info(this.plugin.uppy.info(this.plugin.uppy.info(this.plugin.uppy.info(this.plugin.uppy.info(this.plugin.uppy.info(this.plugin.uppy.info(this.plugin.uppy.info(this.plugin.uppy.info(this.plugin.uppy.info(this.plugin.info(this.plugin.uppy.info(this.plugin.uppy.info(this.plugin.uppy.info(this.plugin.uppy.info(this.plugin.uppy.info(this.plugin.uppy.info(this.plugin.uppy.info(this.this.plugin.uppy.info(this.plugin.uppy.info(this.plugin.uppy.info(this.plugin.uppy.info(this.this.plugin.uppy.info(this.plugin.uppy.info(this.this.plugin.uppy.info(", "reference": "I think we have to keep this as a fallback for now, else it's a small breaking change :(" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "nit: shouldn't be part of this PR." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "this change looks wrong to me. I think the test is trying to signal that something went wrong by throwing the `Error` here, otherwise the `catch` below will swallow it." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "I'm doubting if this should be `if (_layout.IsThreadAgnostic)`, as ThreadAgnostic stuff could be calculated on every thread. (and thus could be lazy). non-ThreadAgnostic should be calculated on the main thread." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Please use only `Logger` instead of `org.slf4j.Logger`" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "Should this be \"no limiter drop\", since this isn't an absolutely essential activity for the stability of the network?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "I updated many of the success messages, because most of these operations don't return data if they succeed. This meant many of the operations would print: `Success null` if the script ran successfully." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Could you simply add it to the previous clause?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "@joshyrobot, I think you can just use localeCompare with only the first argument and leave the other arguments out (here and all the other lines changed). It seems to do the right thing, and then we don't have to worry about these extra options." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "@chengren311 : where does this logic move to?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "Can we have a `nil` exception check at `s.scope.ManagedMachinePool`" }, { "prediction": "I'm not sure what you're trying to do, but I think it's a good idea.", "reference": "Rather than deleting this, should you just reformat it so it's the `*` settings, so if nothing is configured in facets.ini, the existing default behavior continues to work?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "wrap, single line" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "always use brackets for if statements" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so it's a bug.", "reference": "`NUnitIntegration` doesn't need to cache this anymore." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "Why did you change it to `>=` here?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if this is the case, but I'm not sure if this is the case, so I'm not sure if this is the case.", "reference": "Looks like this needs to be updated. There is no need to remove `hadoop.` if Hadoop tables don't use this code path." }, { "prediction": "@ -1,4 +1,5 @@ require 'fileutils' +require 'digest'", "reference": "This require isn't need anymore, right?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, it's a bug.", "reference": "a bit weird to see payments crypto package inside connection manager. There probably will be services not having any relation with payments that will use connection manager. Thats why probably ping-ping by itself can be useful without any relation to payments.." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this: I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I like the overall idea here, but I wonder if it would be more clear to define the property in the trait, and then set it in the constructors of the classes using the trait. Alternatively, at a bare minimum, it may be a good idea to add `?? 'Bibliographic'` here, to account for the possibility of the trait being used in a class that does not define the property at all." }, { "prediction": "I'm not sure if this is what you are looking for, but I think it's a good idea to use a non forward-secure packet size reduction.", "reference": "I would prefer to not have a magic number, but construct this value out of other constants we already have." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "The limitation is if somebody configure another policy with the same name, but it is an edge case we can ignore I guess." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like `gocloud.dev/secrets/gcpkms` or `gocloud.dev/secrets/gcpkms` or `gocloud.dev/secrets/gcpkms` or `gocloud.dev/secrets/gcpkms` or `gocloud.dev/secrets/gcpkms` or `gocloud.dev/secrets/gcpkms` or `gocloud.dev/secrets/gcpkms` or `gocloud.dev/secrets/gcpkms` or `gocloud.dev/secrets/gcpkms` or `gocloud.dev/secrets/gcpkms` or `gocloud.dev/secrets/gcpkms` or `gocloud.dev/secrets/gcpkms` or `gocloud.dev/secrets/gcpkms` or `gocloud.dev/secrets/gcpkms` or `gocloud", "reference": "? The package is named `hashivault`." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "I don't think this should enable xwayland, because it's convenient to toggle xwayland just by setting `xwayland` to `false`" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Remove this line by accident?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Calling `.stream()` on a `DomainObjectCollection` is pretty much always a bug, as it doesn't include objects added later (and encourages people to use afterEvaluate). I wonder if we should make this an error prone check?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "Thanks for paying attention to other places this might happen. This one is particularly important; I probably never should have gotten in the habit of CheckErr(), since it does a log.Panic() explicitly, which looks like something else until you look closely. It's supposed to be used places where \"can't happen\" but Things Can Happen." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case.", "reference": "What is the different between nw_tos and ip_dscp? Only high 6 bits vs low 6 bits and supported version?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "I'm assuming that asSmarts & cxSmiles == asSmarts" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Seems like an oversight but I don't think the super would do anything else in this case unless I'm mistaken." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm correct, but I'm not sure if I'm correct.", "reference": "Curious, do we consider this as pedantic for example code?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Should we convert the entity name to snake case using `Doctrine\\Common\\Inflector\\Inflector::tableize` or similar? Should a `snaked_name` or whatever be part of the entity metadata in order to use it for form names, ids, & other html attributes?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if it's what you're trying to do, but I'm guessing it's what you're trying to do.", "reference": "Should be `client.outboundIp`" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug in NLog.UnitTests.LayoutRenderers. I'm not sure if this is a bug, but it's a bug in NLog.UnitTests.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.Renderers.LayoutRenderers.LayoutRenderers.Renderers.LayoutRenderers.Renderers.LayoutRenderers.Renderers.Renderers.LayoutRenderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Render.ers.Render.ers.Render.ers.Render.ers.Render.ers.Render.ers.Render.ers.Render.ers.Render.", "reference": "Must these `using` statements not go inside the `namespace` block?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Why? I thought the previous way was idiomatic. (Same with the `MetadataVer` stuff above.)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "shouldn't we `reject` here instead?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here. I'm not sure what you're trying to do here.", "reference": "check err or use gasPriceUnitIOTX, _ := if we are sure action.Core.GasPrice is correct" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Just curious, was wait not used at all before?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "nit: can we remove this?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "is it not a problem when one synchronized function is called by other?" }, { "prediction": "I think this is a bug in ActiveAdmin. I'm not sure if it's a bug, but it's a bug in ActiveAdmin. I'm not sure if it's a bug, but it's a bug in ActiveAdmin.", "reference": "We (even as admins) shouldn't override the User Preference settings like `email_master`, `email_posts`, `email_kudos`, `email_new_followers`. These all would be set by the user of their choice. Please do remove these attributes from editing//updating. Thanks!" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "\"Este :attribute j est anexado.\" sounds better." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, then it's a good idea to import it as a module.", "reference": "This line should be repeated for every module that needs testing. One cannot rely on nosetest to automatically discover all the modules. On the bright side, there is no need to change any of the other files." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if this is the case, or if it's the case, but I'm not sure if it's the case.", "reference": "This error was unused" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Personally I wish we didn't have a proto for every single little thing we do. RequestShardAction with an enum for the action type would be a lot cleaner imo, but I'm pretty sure that ship has sailed :) Just kvetching." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Does this make more sense as `trails/_trail` now?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "synced offline. let's move this to `agent_unix.go` to make the IMDS call, since this is not supported in Windows." }, { "prediction": "What is the difference between `py_env` and `py_docs`? What is the difference between `py_env` and `py_docs`? What is the difference between `py_env` and `py_docs`? What is the difference between `py_env` and `py_docs`? What is the difference between `py_docs` and `py_docs`?", "reference": "Too much indentation here. Should match the lines above, which have four spaces." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Same here we still need this test to make sure the fallback works." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "I'm wondering if we can actually base this on a `IMvxPresentationAttribute` instead of the base one." }, { "prediction": "@ -430,7 +430,7 @@ export function unmount(vnode, parentVNode, skipRemove) { if (skipRemove) { vnode._component = null; } else { vnode._component = null; } if (vnode._component!== null) { vnode._component = null; } if (vnode._component!== null) { vnode._component.unmount(vnode, parentVNode, skipRemove); } if (vnode._component!== null) { vnode._component.unmount(vnode, parentVNode, skipRemove); } if (vnode._component!== null) { vnode._component.unmount(vnode, parentVNode, skipRemove); } if (vnode._component!== null) { vnode._component.unmount(vnode, parentVNode, skipRemove); } if (vnode._component!== null) { vnode._component.unmount(vnode, parentVNode, skipRemove); } if (vnode._component!== null) { vnode._component.unmount(vnode, parentVNode, skipRemove); } if (vnode._component!== null) { vnode", "reference": "could we switch to `undefined` here?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "The cleanup call" }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if it's the correct way to do it, but I think it's the correct way to do it.", "reference": "I think \"View artist\" is a bit more standard and expected. Or even \"Go to artist\" to take the Spotify terminology as-is." }, { "prediction": "This works on deeply nested data structures composed of Hashes, Arrays, and # and plain-old data types (int, string, etc). def unwrap_sensitive_args(arguments) + # Skip this if Puppet isn't loaded + return arguments unless defined?(Puppet::Pops::Types::PSensitiveType::Sensitive) + case arguments when defined?(Puppet::Pops::Types::PSensitiveType::Sensitive) + case arguments when defined?(Puppet::Pops::Types::PSensitiveType::Sensitive) + case arguments when defined?(Puppet::Pops::Types::PSensitiveType::Sensitive) + case arguments when defined?(Puppet::Pops::Types::PSensitiveType::Sensitive) + case arguments when defined?(Puppet::Pops::Types::SensitiveType::Sensitive) + case arguments when defined?(Puppet::Pops::Types::SensitiveType::Sensitive) + case arguments when defined?(Puppet::Pops::Types::SensitiveType::Sensitive) + case arguments when defined?(Puppet::Pops::Types::SensitiveType::Sensitive) + case arguments when defined?(Puppet", "reference": "It might make sense to refactor this later so that we use a Bolt-native type to hide sensitive values." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this should work.", "reference": "We were trying to move away from this to force people to always run tests under py.test." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "1 - create browser specific options class: - chromeoptions - firefoxoptions - argsoptions" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "should be a case insensitive match though no? DOCTYPE and doctype are both widely used" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "We must have a `fail ParamNotFound` here for cases where `@account.nil?`." }, { "prediction": "I'm not sure if this is a bug, but maybe it's a bug?", "reference": "How come this change was needed?" }, { "prediction": "@ -25,3 +25,13 @@ const ( UART_TX_PIN = 6 UART_RX_PIN = 8 ) + + ( UART_RX_PIN = 3 UART_RX_PIN = 3 UART_RX_PIN = 3 UART_RX_PIN = 3 UART_RX_PIN = 3 UART_RX_PIN = 3 UART_RX_PIN = 3 UART_RX_PIN = 3 UART_RX_PIN = 3 UART_RX_PIN = 3 UART_RX_PIN = 3 UART_RX_PIN = 3 UART_RX_PIN = 3 UART_RX_PIN = 3 UART_RX_PIN = 3 UART_RX_PIN = 3 UART_RX_PIN = 3 UART_RX_PIN = 3 UART_RX_PIN = 3 UART_RX_PIN = 3 UART_RX_PIN = 3 UART_RX_PIN = 3 U", "reference": "Why are there only 6 pins here, while below it appears to have 8 ADC inputs? Are pin 2 and 5 used for something else on this board?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "I think we need an issue to track that chain sync omits BLS messages, and then to fix and test it!" }, { "prediction": "I'm not sure if this is a bug or a bug, but it seems to be a bug.", "reference": "what is this default about? I am not using ngrok atm so would prefer an env var." }, { "prediction": "It's recommended to set 'runUpdateManagerAfterBackendLogin' to true in production enviroments. It's recommended to set 'runUpdateManagerAfterBackendLogin' to 'false' in production enviroments.", "reference": "@Samuell1 Might be better to say \"Automatically check for plugin updates on login\"." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm assuming it's what you're trying to do.", "reference": "Thanks for the additional Process helper! Can we also cache the first `Process.GetCurrentProcess()` result in a static field so we don't have to repeatedly call it? It means we would also need to dispose it when the static `_runtimeMetricsWriter` instance is disposed" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "just wondering what is the result of breaking the logic we test here? it seems that in that case we will just not return immediately, but i'm not sure whether the test will fail?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "We should fail the test if this returns `err!= nil`." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "What is the drawback of not having this flag as a gating condition to report the metric?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "`getProcessName()` will be less ambiguous, since Caddy has \"apps\" that it runs internally." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this: // DML_TaggedMemory (hardcoded current size to 2 pointer sizes) // DML_TaggedMemory (hardcoded current size to 2 pointer sizes) // DML_TaggedMemory (hardcoded current size to 2 pointer sizes) // DML_TaggedMemory (hardcoded current size to 2 pointer sizes) // DML_TaggedMemory (hardcoded current size to 2 pointer sizes) // DML_TaggedMemory (hardcoded current size to 2 pointer sizes) // DML_TaggedMemory (hardcoded current size to 2 pointer sizes) // DML_TaggedMemory (hardcoded current size to 2 pointer sizes) // DML_TaggedMemory (hardcoded current size to 2 pointer sizes) // DML_TaggedMemory (hardcoded current size to 2 pointer sizes) // DML_TaggedMemory (hardcoded current size to 2 pointer sizes) // DML_TaggedMemory (hardcoded current size to 2 pointer sizes) // DML_TaggedMemory (hardcoded current size to 2 pointer sizes) // DML_TaggedMemory", "reference": "Is there any way to not hardcode this given we know the size in bytes? The public API has the flexibility of being a Span. Should we maybe not do anything printing DML? The runtime allocates the buffer, but it's a \"scratch memory\" area, The delegate gets it passed in and they decide how to use it. Also, how is DML used if the feature is for macOS support?" }, { "prediction": "Is there a way to do this?", "reference": "How about just override the `buildFilter`? Passing another function here is a little weird." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This should just be a `.Bool()` flag I think, we don't encode anything beyond y/n here. See `$(RUN_CHECK)` and `$(STOP_ON_PKG_FAIL)` for examples of how to pass those in." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Is this needed?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "how about moving it under L26" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I think this needs to be tested" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Style/MutableConstant: Freeze mutable objects assigned to constants." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, so I'm not sure if it's a bug, but if it's a bug, it's a bug.", "reference": "Just a thought, really. If it's a bug that can be probed for (and it can be - see Adrian's repro) then it could as well be a static initialization of a supplier of Deflater instances; if we probe for a buggy JVM, we return the wrapper. If we don't we return the Deflater. This way on non-affected JVMs nothing happens and if we do use the wrapper, we know the JVM is broken." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Looks like this should be publicly accessible for tests in any modules?" }, { "prediction": "I'm not sure if this is the correct way to use dotenv, but if it's the correct way to use dotenv, then it's better to use dotenv instead of dotenv. I'm not sure if this is the correct way to use dotenv, but if it's the correct way to use dotenv, then it's better to use dotenv instead of dotenv. If it's the correct way to use dotenv, then it's better to use dotenv instead of dotenv. If it's the correct way to use dotenv, then it's better to use dotenv instead of dotenv.", "reference": "Allow putenv is necessary to be able to get environment variables with `getenv`?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "use function to check it. - don't do everything in main" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "Sorry I'm confused. Why not kwarg this like the others?" }, { "prediction": "I don't think this is a bug, but it's a bug, and we don't know why.", "reference": "First, any changes here should be synchronized with instr_compute_VSIB_index(). Second, the original looks correct to me: the first letter of the opcode name suffix is the index size, while the second is the memory size. So \"vpgatherdq\" is a d-sized index and q-sized memory. The operand size we store for memory accesses is always the memory size, not the address size, and for VSIB we store a single memory element size. It looks like we have no inside-opnd_t storage of the index size: that's done by dispatch on opcode it seems. I have a bunch of notes of discussions on how to handle VSIB: we decided to bail on encoding too much inside the opnd_t I guess." }, { "prediction": "I think this is what you're looking for: https://github.com/luigi/luigi/blob/master/luigi/src/main/luigi/src/main/luigi/src/main/luigi/src/main/luigi/src/main/luigi/src/main/luigi/src/main/luigi/src/main/luigi/src/main/luigi/src/main/luigi/src/main/luigi/src/main/luigi/src/main/luigi/main/luigi/src/main/luigi/luigi/src/main/luigi/luigi/src/main/luigi/luigi/src/main/luigi/luigi/src/main/luigi/luigi/src/main/luigi/luigi/src/main/luigi/luigi/src/main/luigi/luigi/src/main/luigi/luigi/src/main/luigi/luigi/src/main/luigi/luigi/main/luigi/luigi/src/main/luigi/luigi/lu", "reference": "Sorry for going back and forth. Adding docstring here would be very helpful for others to understand the need of this method." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "You introduced a bug here." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Should we log a warning/error if only one is specified and not the other?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if this is a bug, so I'm not sure if it's a bug, but I think it's a bug.", "reference": "`ctx` is unused in GetLatestEvent" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "This looks good to me. Personally, I would have the following for maximum flexibility: * convert peering_port from uint64_t to int. * Set the default value to \"-1\" to specify the value is not set * if the value is -1 then do `config.node.peering_port = network_params.network.default_node_port` That would allow for 0 to mean, select the port number yourself and be more consistent. But I am happy with the change as is, as well." }, { "prediction": "I think this is what you are looking for: https://docs.python.org/2/library/imagetransform.html", "reference": "The blank line between the summary and detailed description is better to be kept." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "Curiously, are these indents intended or should they be aligned?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "What if we changed this to this? roleText=attrs.get('roleText', lambda:getSpeechTextForProperties(reason=reason,role=role)) That will prevent the function from ever needing called in the roletext case, and removes that if." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "This will still result in a safe_read_tls_magic on AMD in tls_thread_preinit()." }, { "prediction": "@ -561,5 +561,4 @@ public class TestJdbcCatalog { String nsString = JdbcUtil.namespaceToString(ns); Assert.assertEquals(ns, JdbcUtil.stringToNamespace(nsString)); }", "reference": "Can you remove this change?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Oh, was that a bug in the validation?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "Please use the Google java code style. Basically, add more space characters like in the statements below. Next to method arguments and curly braces. This is currently not checked on CI because it is too inconsistent in the code base but I would prefer new code to be consistent." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Actually, I don't think we need to create object on heap." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "this is a file we copy from gRPC, sp ideally it be fixed upstream as well.." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "changes like this, just strangle guava usages to be replaced by DelayLimiter into one place" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "PropTypes need to be updated accordingly here. Note that the type also needs updating, not just the case. That is, these should both expect a `PropTypes.elementType` now instead of an `element`." }, { "prediction": "I'm not sure if it's a bug, but it's a bug in Kokkos::Impl::get_ctest_gpu(). I think it's a bug in Kokkos::Impl::get_ctest_gpu(). I'm not sure if it's a bug, but it's a bug in Kokkos::Impl::get_ctest_gpu().", "reference": "maybe extra paren around `strncmp(...)!= 0`" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "We should call `Windows.onResume `: - When the app is launched for the first time - When the app is resumed after being paused (home button and resume or device goes to sleep) - After a permission prompt is displayed" }, { "prediction": "I'm not sure if this is what you are looking for, but I think it's a good idea to use a NavigableSet> instead of a NavigableSet>. I'm not sure if this is what you're looking for, but it's a good idea to use a NavigableSet> instead of a NavigableSet>.", "reference": "Rename to ForksSchedule? Maybe in separate PR." }, { "prediction": "I think this is a bug in kinto.core.storage.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache.cache", "reference": "Why a blank line here?" }, { "prediction": "I think this is what you're looking for.", "reference": "I have a sense that this will actually eventually change to check the actual date so that subscriptions can be deactivated in the future. But I mention that here just to keep you in the loop. We should not make that change now, because it's not needed functionality." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "What is the reasoning for using the negation of `isOption()` instead of simply using `isPositional()` to identify a positional param?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm correct, but I'm not sure if I'm correct, or if I'm wrong, or if I'm wrong, or if I'm wrong, I'm wrong, or if I'm wrong, I'm wrong.", "reference": "Why would you add those if client version min is set to 1100?" }, { "prediction": "@Golang.org/protobuf/reflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect/protoreflect\" protoimpl \"google.golang.org/protobuf/runtime/protoimpl\" emptypb \"google.golang.org/protobuf/runtime/protoimpl\" emptypb \"google.golang.org/protobuf/types/known/emptypb\" - reflect \"reflect\" - sync \"sync", "reference": "You can delete this, it will now need to live in `gointerfaces` package" }, { "prediction": "I think this should be in a partial, but I don't think it should be in a partial, so I'm not sure.", "reference": "Okay, I still don't understand why you have to add `html_safe` here, and it still seems like a very bad idea. It will allow html tags in the title, and keep Rails from escaping literal greater-than or less-than chars not intended as HTML tags. It ought to work to just let Rails do HTML-escaing as normal, without any manual `html_safe` or `strip_tags` or whatever. I am not clear on what problem you are trying to solve, why the straightfoward approach does not work." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "What is is subject when it's not the email subject. Why are we having to do this crap? What's calling this with an empty string?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Could you also remove the `defaultSamplingProbability` constant from `sampling.go`? It seems to became unused with this change." }, { "prediction": "I'm not sure if this is what you're trying to do, but it's probably what you're trying to do. I'm not sure if this is what you're trying to do, but it's probably what you're trying to do.", "reference": "can you delete the `generateDeploymentStrategicPatch` function as well?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "I'd keep this at `info` level..." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Don't use DCHECK to debug your code if it's the regular branch you need to handle." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "You should return null here instead. Null is an acceptable default value for the image attribute." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think this is what you're trying to do.", "reference": "react bails as well?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's a good practice to use a custom role. I'm not sure if this is what you're trying to do, but it's a good practice to use a custom role. I'm not sure if this is what you're trying to do, but it's a good practice to use a custom role. I'm not sure if this is what you're trying to do, but it's a good practice to use a custom role.", "reference": "Can you please tell me why you did this?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "Reading this again it should prob prefer the `videoConstraints.facingMode` value over `facingMode` if the former was already set" }, { "prediction": "I think this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "There's a good bit of class-level stuff that's repeated in our various product types. Think it's worth extracting a...dare I say it...module?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's", "reference": "Please do not modify the `config.Target` field, it should contain exactly what is extracted from the JSON files. Instead, you can either: * Add a getter to the `config` variable (`*compileopts.Config`), so you can simply call `config.WasmAbi()` to get the value. * Use a local variable instead. The getter would be slightly cleaner, as it matches the pattern of other configurations (`CGO_ENABLED`, `GC`, `NeedsStackObjects`, etc)." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this.", "reference": "The nil check is not necessary for these. Append checks both sides for nil." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Shouldn't we instead have the SDK apply these, internally? I.e., I would expect to see the dctx entries included in the span as first-class distributed correlations, not as span attributes." }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "nit: rename this in proto and update impl to `Search` to avoid stutter" }, { "prediction": "I think this is the correct way to do it.", "reference": "is it necessary to order by id as a second ordering? this will take place only when several new slider items are created without reordering (position is then null). Wouldn't be better to recalculate position after creating a new item? (right now items with null in position behave differently in administration and on frontend)" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "`ClaimFromRewardingFundBaseGas` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "How about modifying the NOGIL definition so that it only does anything if the thread safety flag (RDK_BUILD_THREADSAFE_SSS) is set?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "blockheighter would be more clear" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This is so weird as a utility function." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "Why? What would happen if you did not?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Unrelated bugfix for NPE." }, { "prediction": "It's not possible to toggle the value of the boolean property of the entity. It's not possible to toggle the value of the boolean property of the entity. It's not possible to toggle the value of the boolean property of the entity. So it's not possible to toggle the value of the boolean property of the entity. So it's not possible to toggle the value of the boolean property of the entity. So it's not possible to toggle the value of the boolean property of the entity. So it's not possible to toggle the value of the boolean property of the entity.", "reference": "What if some extended the `AdminController` and had a check for the old option name? Could that be a valid use case?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think this should work.", "reference": "This will be only available when data-manager is enabled, is there a fallback in case data manager is disabled?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Do you think we want to move the call to `generateWorkerServiceRecommendedActions` inside `RecommandedActions()`?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug.", "reference": "The VUIDs in this area are not great, but I think `ValidateQueryPoolStride` should probably be skipped if the query pool was created with type `VK_QUERY_TYPE_PERFORMANCE_QUERY`. VUID-02828 might be a better fit, but again, the existing VUIDs step on each other so it requires a bit of interpretation." }, { "prediction": "I don't think this is a bug, but it's a bug. I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "Iguess you should use ToDbKey here" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "x.tbk is the \"index\" below, and is done in Start()" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "Do we already have a convention for this? If not, would we consider \"DataDog.IsAppInsights\". And then use \"DataDog.\" prefix for all this settings, environment variables etc..? Such settings are, essentially, public APIs because they may conflict with customer data. Regardless of that, AppInsights has an s at the end :)" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "this assignment is not necessary if the offsetof() is used in the configmap" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "I'd rather leave a TODO here at least." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Shouldn't this be `resource`?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Why does this become blocking for the CPU path? Shouldn't it remain independent of the GPU path?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Do we need to change occurences where `setup` was called before?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this: I'm not sure what you're trying to do, but I think you're trying to do something like this.", "reference": "Is this TODO still valid? Or are we going to put this somewhere else later?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "We generally don't do parantheses in if conditions in Python. :) this could be better written as `if from_ts is None`" }, { "prediction": "I don't think this is a bug, but it's a bug, and it's a bug.", "reference": "Odd that we'd set just element 299 of a 2000-byte buffer to null. But I see that this is the way it was before." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "ScoreFunc is not used in this PR. Maybe to add it later when needed?" }, { "prediction": "I'm not sure if it's the browser, but if it's the browser, it's probably the browser.", "reference": "super nit: I think this might be easier to read as `requestHeadersFromResponseWriter`" }, { "prediction": "I'm not sure what you're trying to do here, but it seems to be a bug.", "reference": "Need to include \"common/base/Base.h\" in front of this line" }, { "prediction": "I'm not sure if it's possible to import nativeTextMethods from '../standards/get-element-spec'; but if it's possible to import nativeTextMethods from '../standards/get-element-spec'; it's possible to import nativeTextMethods from '../standards/get-element-spec'; from '../standards/get-element-spec'; from '../standards/get-element-spec'; import nativeTextMethods from '../standards/get-element-spec'; import nativeTextMethods from '../standards/get-element-spec'; import nativeTextMethods from '../standards/get-element-spec'; import nativeTextMethods from '../standards/get-element-spec'; import nativeTextMethods from '../standards/get-element-spec'; import nativeTextMethods from '../standards/get-element-spec'; import nativeTextMethods from '../standards/get-element-spec'; import nativeTextMethods from '../standards/get-element-spec'; import nativeTextMethods from '../standards/get-element-spec'; import nativeTextMethods from '../standards/get-element-spec'; import nativeTextMethods from '../standards/get-element-spec';", "reference": "Changes in this file should go into a separate PR." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, then it's probably a bug.", "reference": "Please ensure that this will not start putting single quotes where double quotes are expected." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "`ProvideConfig` was changed, looks like it will not compile for windows, and should be changed too." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this: https://github.com/gogits/go-gogs-client/blob/master/src/github/gogits/go-gogs-client/src/github/gogits/go-gogs-client/src/github/gogits/go-gogs-client/src/github/gogits/go-gogs-client/src/github/go-go-gogs-client/src/github/go-go-gogs-client/src/github/go-go-go-gogs-client/src/github/go-go-go-gogs-client/src/github/go-go-go-gogs-client/src/github/go-go-go-gogs-client/src/github/go-go-go-gogs-client/src/github/go-go-go-go-gogs-client/src/github/go-go-go-go-go-go-client/src/github/go-go-go-go", "reference": "This does not look right, you're listing all private repositories.." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "An OPTIONS request should respond from _any_ path? Seems weird to me..." }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this:", "reference": "you need to add the content type" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm correct, or if I'm correct, but I'm not sure if I'm correct, or if I'm correct, or if I'm wrong, or if I'm wrong, I'm wrong.", "reference": "Do we need to distinguish between these two processes? I'm thinking maybe we can have a list of processes and treat them all equally." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "This is used only for out-of-line -- so yes this seems right to do for x64. Inlined is aligned separately at the end of prepare_for_clean_call(). There the ifdef is x86_64 or MACOS -- no ARM, why not? Also, please add || MACOS here to match the inlined." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this?", "reference": "guess I'm wondering if this needs to be refactored to use Schema.joinCondition() or similar?" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed in the future.", "reference": "Does it make sense to restrict this option to `exec` only? You could add it specific to that subcommand using the `method_option`...method. There's an example of it for hosts in the `init` function." }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "This is very expensive (lots of allocations, lots of data copying). Could we do something like check IndexOf('%') and bypass if no hit?" }, { "prediction": "@PvPUtil public static boolean isAttackable(Client client, Player player) { if (client.getVar(Varbits.IN_WILDERNESS) == 1) { return true; } return false; }", "reference": "This should be `WorldType.isDeadmanWorld(client.getWorldType())` to be inline with the other WorldType calls." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "do we also need to change `mlvl_confid` -> `mlvl_confidences`>" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I feel slightly that InterfaceExclude is not a clear name - bearing in mind that our config names are, to some extent, an external API. From an external point of view, a clearer name might be IPVSInterfaces. Then it would obviously make sense for the value to be something like 'kube-ipvs0', and it would be a matter of Felix's internal implementation that we choose to exclude those interfaces from our monitoring. Alternatively, if we want to keep this at a level that is more general than just IPVS, perhaps 'UnmonitoredInterfaces'? WDYT?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "This should be `re.search` with a `^` anchor added to the regex, as what we want here is really any path starting with something like `E:`." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Since `IsKubernetesBuiltInResource` at L69 returns false due to lack `networking.istio.io/v1alpha3` in `builtInApiVersions` within `pkg/app/piped/cloudprovider/kubernetes/resourcekey.go`, it will never reach this point." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this.", "reference": "Does codecov not run this test? Not sure how else it would not be covered." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "can we add some sample of JSON_DATA format in the usage?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "Using `Tracer.Instance` in here is problematic for testing It will likely cause some other tests to break I think - that's why we started passing in `IScopeManager` EDIT: I see you used `[TracerRestore]` - maybe that'll be enough!" }, { "prediction": "I'm not sure what you're trying to do, but it seems like you're trying to do something like this:", "reference": "make all of these `static final` fields UPPER_SNAKE - they are constants." }, { "prediction": "If this is a DoT, use DoT Shielding instead.", "reference": "No possible chance for weird overflows here, right?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Or we could use a Float object to more clearly show as user-settable via non-null?" }, { "prediction": "I don't think this is a bug, but it's a bug. I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "finalizedHeader should be saved in FinalizationManager when we have FinalizationBlockHash!= Keccak.Zero" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Not using ExactName: true would remove the need for manually adding workflow ID as it would be added automatically by Daisy. E.g. 'disk-importer-2-import-ovf-7mn7h' was created from diskImporterDiskName above even though only 'disk-importer-2' was specified. ExactName: true should be used for resources that shouldn't include any temp prefix/suffix, such as disks that will be permanently attached to a created instance. Scratch disk is not one of them." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "If we support multi-index column later, we need to rename to fit the pandas' requirement." }, { "prediction": "This is not a JSON string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a string. It is a", "reference": "I'm not sure this is really needed. JSONValue type can be used the same as a map as far as operators go, including range. I'd leave this out for now unless there is a strong reason to keep it." }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this:", "reference": "sorry for nitpicking but I would love a new line under this line" }, { "prediction": "@ -21,5 +21,5 @@ package node type OptionsTransactor struct { TransactorEndpointAddress string RegistryAddress string - AccountantID string + ChannelImplementation string }", "reference": "ChannelImplementation field naming is not clear, is it some kind of standard? Maybe it can be named ChannelID?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "Looks like there is a typo: `expireSnapshots` -> `removeFiles` or whatever name we go with." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Thanks for looking into this. I think it looks a bit strange to have this check inside the for loop. Wouldn't it also work to initialize `idxCurrentSort` with 0 instead?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Just a small ordering thing: Could you please bring `IMPORTANCE_HIGH` to the bottom and maybe even have one line between it and the Notification IDs?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "Should this be boost logged?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "What is the reason for doing expunge here? This method is purely for converting the timestamp." }, { "prediction": "I'm not sure if this is the case, but I think it's the case. I'm not sure if this is the case, but I think it's the case.", "reference": "This calls sanitize twice if the name isn't valid." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "Is there an equivalent that'd allow zero or one?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Is it possible to update/re-evaluate entire metatask object for every repeat? If we decide/need to use a repeatWith resources in let us say labelSelector(bad example) then we would have to add another logic to update those properties." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "unnecessary conversion (from `unconvert`)" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "typo in commit message `openening`" }, { "prediction": "I don't think this is a bug, but it's a bug in ADIOS_CPP.h. It's a bug in ADIOS_CPP.h. It's a bug in ADIOS_CPP.h. It's a bug in ADIOS_CPP.h. It's a bug in ADIOS_CPP.h. It's a bug in ADIOS_CPP.h. It's a bug in ADIOS_CPP.h. It's a bug in ADIOS_CPP.h. It's a bug in ADIOS_CPP.h. It's a bug in ADIOS_CPP.h. It's a bug in ADIOS_CPP.h.", "reference": "User-code doesn't see the internal ADIOS headers anymore. This whole include block should just be `#include `" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "nit: I guess we can omit this (unless you had a reason to specify it)" }, { "prediction": "This is a solicited leafnode and is not configured to be treated as a hub. So this is a solicited leafnode and is not configured to be treated as a hub. This is a solicited leafnode and is not configured to be treated as a hub. This is a solicited leafnode and is not configured to be treated as a hub. This is a solicited leafnode and is not configured to be treated as a hub. This is a solicited leafnode and is not configured to be treated as a hub. This is a solicited leafnode and is not configured to be treated as a hub. +func (c *client) isSpokeLeafNode() bool { + return c.kind == LEAF && c.leaf.remote!= nil &&!c.leaf.remote.Hub +} + func (c *client) isUnsolicitedLeafNode() bool { return c.kind == LEAF && c.leaf.remote!= nil &&!c.leaf.remote.Hub +}", "reference": "Why is Hub public?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "why is this deleted?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this?", "reference": "Maybe move that into a partial" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "Error return value of `dao.Stop` is not checked (from `errcheck`)" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "util.Warning()? Easier to say." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "this default is kinda superfluous (although i see it was already there before PR )" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "How is this related?" }, { "prediction": "I think this is what you are looking for.", "reference": "I'm breaking one of the rules here, it feels like the right thing to do. Open to alternative suggestions." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "The use of `#should` was triggering an rspec depracation warning for me, which is why I switched this to the rspec 3 style." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "Why are you setting the CacheChange as REQUESTED when it is not valid (it was erased from history)?" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "`lodash` shouldn't be grouped under WordPress dependencies" }, { "prediction": "I'm not sure if this is the case, but it's the case.", "reference": "This needs to be public so that Avro can call it." }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so I'm not sure if it's a bug, or if it's a bug.", "reference": "`Google*` shouldn't be under External dependencies - seems like ESlint is not properly recognizing that these are aliases to internal dependencies." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "I think he meant the docstring in this constructor. yea we should fix" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "so.. this basically follows the pattern from JapaneseTokenizer, I think... but somehow I don't see where we defined ResourceScheme? We're not referencing the one in kuromoji, right?" }, { "prediction": "I don't think this is a bug, but it's a bug, and it's a bug.", "reference": "It would probably be better to do: const SecurityProtocolType Tls13 = (SecurityProtocolType)12288" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something that's not what you're looking for.", "reference": "Similar to the above, put this setting back but keep the value as `'{}'`" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "As discussed in chat - we should run this function within an app context which means that we'd already have a logger configured, and a connection to timescale set up" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I'm curious about why this needed to be removed." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "why did you remove `zip`? It is used!" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Is there any reason that we don't add a similar condition like `ChannelConditionTopic` to the channel?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug, so I'm not sure if it's a bug.", "reference": "before php8 \"goto\" was a reserved word and was not allowed as part of the namespace. Now test checks for validity of plugin namespace according to PSR-4" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to create a new Outbound for a given address. I'm not sure what you're trying to do here, but I'm guessing you're trying to create a new Outbound for a given address. I'm assuming you're trying to create a new Outbound for a given address, but I'm not sure what you're trying to do here.", "reference": "nit: I'm not sure it can be addressed in this diff, but it seems odd that NewOutbound supports TLS but NewSingleOutbound does not. As a somewhat naive user I would expect the only difference between these two APIs is how peers are chosen." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's the case, then it's probably a bug in the code you're using, or if it's a bug in the code you're using, or if it's a bug in the code you're using, or if it's a bug in the code you're using, then it's a bug in the code you're using.", "reference": "I would advise to enhance the test for the method `CallOneway` - we should have a test very similar to `TestCallSuccess`. We should test: - Success with response (even if it is callOneway) - Success with no response and empty payload - Errors" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "We're already matching +. Not sure why this changed." }, { "prediction": "I think you need to define a category manager for this case. I think you need to define a category manager for this case. If you don't want to define a category manager, you need to define a category manager for this case. If you don't want to define a category manager, you need to define a category manager for this case. If you want to define a category manager you need to implement \\Sonata\\MediaBundle\\Model\\CategoryManagerInterface and set the service name here') + ->defaultValue(null) + ->end() + ->scalarNode('force_disable_category') + ->info('true IF you really want to disable the relation with category') + ->defaultValue(false) + ->end() ->end() + ->scalarNode('force_enable_category') + ->info('false IF you really want to disable the relation with category') + ->defaultValue(false) + ->end() ->end()", "reference": "Please add line breaks, so the line doesn't exceed 80 chars." }, { "prediction": "I'm not sure if this is a bug, but it's a bug in the AspNetCoreInstrumentation class. I'm not sure if it's a bug, but it's a bug in the AspNetCoreInstrumentation class. I'm not sure if it's a bug, but it's a bug in the AspNetCoreInstrumentation class.", "reference": "I initially thought (inccoreclty) this is a breaking change! The public api analyzer is a gift!" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I'm not sure how this one didn't segfault before." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Same points as in other test file." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's probably something you're trying to do. I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's probably something you're trying to do.", "reference": "Did you run gradlew tidy? Wildcard imports shouldn't be there, hence the question." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Put a comma after the last parameter of a multiline method call." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so it's a bug.", "reference": "Is this going to restrict the output to *ONLY* ports that are bound to vfio-pci? That's not what we discussed yesterday." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Intention is to do the lookup here, I believe (where we can cache it). This would make the call non-pure function though. I'll confirm with lotus. ID addresses are the *only* addresses I expect to actually see here." }, { "prediction": "This -can be used to automate ERMFS commands and is an alternative to connecting through SSH to run the commands manually. This -can be used to automate ERMFS commands and is an alternative to connecting through SSH to run the commands manually. This -can be used to automate ERMFS commands and is an alternative to connecting through SSH to run the commands manually.", "reference": "electronic medical record file system (EMRFS)" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Put this higher in the list, like after \"bind\", since I guess we're considering the max request body size to be kind of a native/fundamental feature, built directly into the vhosts." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm wrong, or if I'm wrong, I'm wrong, or if I'm wrong, I'm wrong.", "reference": "oh come on :(" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this: I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "This is an incorrect change. The dialect spoken is an important part of the handshake and should be communicated to users." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Remove as this is not needed anymore." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "This new class is for checking that #4551 works correctly with PlantUML output too." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Will this cause all certificates to be re-issued?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "I think tmp is also leaked at the end of this loop if no error cases are encountered." }, { "prediction": "I'm not sure if this is the case, but if it's the case, it's the case.", "reference": "The previous version didn't use `keyProjection` because the entire key must be projected. If the key is a struct of multiple columns, then projecting a subset of those columns can easily introduce key collisions that aren't in the original data." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug, but I think it's a bug.", "reference": "Why not use StatusOr? We can't ensure spaceId is greater than zero, especially when AdHocSchemaManager is used." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing you're looking for something like \"github.com/chaos-mesh/chaos-mesh/api/v1alpha1\" or \"github.com/chaos-mesh/chaos-mesh/api/v1alpha1\" or \"github.com/chaos-mesh/chaos-mesh/api/v1alpha1\" or \"github.com/chaos-mesh/chaos-mesh/api/v1alpha1\" or \"github.com/chaos-mesh/chaos-mesh/api/v1alpha1\" or \"github.com/chaos-mesh/chaos-mesh/api/v1alpha1\" or \"github.com/chaos-mesh/go-ethereum/go-ethereum/go-ethereum/go-ethereum/go-ethereum/go-ethereum/go-ethereum/go-ethereum/go-ethereum/go-ethereum/go-ethereum/go-ethereum/go-ethereum/go-ethereum/go-", "reference": "Does it seem we only use that as the json-rpc client? Do we have any other choice? It's a little weird." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Could you split this into multiple lines?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I'm sure it's a bug.", "reference": "Doesn't the snapshot ID start off as null? It seems like we don't need to set it here." }, { "prediction": "I'm not sure if this is what you're looking for, but it's probably what you're looking for.", "reference": "I wondered why `buffer` was passed into `LookupPath`. What is happening here? Is `buffer[:0]` equivalent to `[]V4TrieEntry{}`, and hence `buffer` isn't needed any more?" }, { "prediction": "I'm not sure what you're trying to do, but I think it should be something like this:", "reference": "nit: Ideally we would would use this abstraction everywhere we need this translation. I believe it's needed in the mining worker and the storage and market connectors." }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "need to fix the error message here" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug in Microsoft.CodeAnalysis.Sarif.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common", "reference": "Unsure of how to handle this one." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "Will this.flowFinished verify with every finished state stated in Status.isStatusFinished method? If so, no need to verify isKilled." }, { "prediction": "I'm not sure what you mean by \"default retry settings\" but I'm not sure what you mean by \"default retry settings\". I'm not sure what you mean by \"default retry settings\" but I'm not sure what you mean by \"default retry settings\". I'm not sure what you mean by \"default retry settings\" but I'm not sure what you mean by \"default retry settings\".", "reference": "replace \"Child Workflow\" with \"any workflow\"" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Instead of showing the words \"symbolic link\" under the \"Size\" column, how about we introduce new icons for symbolic link to file and symbolic link to directory?" }, { "prediction": "The range filter query string from the query URL is not a valid query string. It should be a valid query string. It should be a valid query string. It should be a valid query string.", "reference": "Please add back the description of the parameter" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Superfluous space inserted." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Didn't fix the problem. `href=\"\"` for SVG will still result in `undefined` getting returned by this function." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "This seems like a strange change... I wouldn't think that a change to access tags in the profiles would result in different bearings in this tests?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "As isCaret is False by default, explicitly specifying isCaret=False here is not needed, and is perhaps a little confusing. I'd prefer that anywhere in the codebase that isCaret is only ever specified if it needs to be set to true. Mirroring that of isFocus for setNavigatorObject." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "We can't freeze this and then add something to it in the next line. The `freeze` on line 43 is sufficient. If Rubocop flags this we need to exclude it." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "Why is this needed?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Why not put two other routes after this line (221)?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug, so I'm not sure.", "reference": "If FLAGS_meta_server_addrs is not empty, in which case \"toHosts\" return empty array?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "There is a function to output a \"JSONBool\" string. That would be a good start for finding uses. But maybe just have a look at where we decide whether it is a numerical or not, thus wrapping quotes around its value. Then you have it all I guess." }, { "prediction": "I think this is a bug in pandas.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.DataFrame.", "reference": "oops, it should be `data._scol` so that it respects the expression stored in Series. Let me fix it quick." }, { "prediction": "I think this is a bug in Rails. You should fix it by adding a commenter to the `administerable` model.", "reference": "Thanks for moving this up with the rest of the variables. Much tidier :)" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a good idea.", "reference": "I think `Rate` is a more precise and concise term for `PaymentPerTime`." }, { "prediction": "I think this is a bug, but it's not a bug.", "reference": "I think this should maybe be: var limit = input.IndexOfAny(new[] { '+', '-', ']' }, **posNext**); You pretty much want to ignore any sign that is before the \"M\". But, if there is a sign somewhere before the M, and also after the M, you'd want to be able to find the sign after the M, right?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "if `checkStockNotEmpty` returns a reponse, you must return it or your script will continue its execution." }, { "prediction": "I'm not sure if it's a bug, but it's a bug in Golang.org/x/sync/errgroup. I'm not sure if it's a bug, but it's a bug in Golang.org/x/sync/errgroup, but it's a bug in Golang.org/x/sync/errgroup. I'm not sure if it's a bug in Golang.org/x/sync/errgroup, but it's a bug in Golang.org/x/sync/errgroup, so I'm not sure if it's a bug in Golang.org/x/sync/errgroup.", "reference": "Any specific reason for this change? klog should work correctly here." }, { "prediction": "I think this is what you are looking for, but I'm not sure what you're looking for.", "reference": "we don't mention `last_modified` here?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "same deal about the global state maybe interfering as in ActionBrowseTagline" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "so sweet to see a test as the first thing" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed in the future.", "reference": "usually when HTTP_PROXY=\"\" (empty), proxy should be disabled. could you set it to NULL when it's empty string?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Can you throw an exception if width or height are both null" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "This is a breaking change. I guess these might have been intentionally exported." }, { "prediction": "I'm not sure if this is the case, but if it's the case, it's probably the case.", "reference": "I don't think this is necessary. When options are used to set the split size in the Spark reader, it uses `TableProperties.SPLIT_SIZE` to pass it here. That should work for metadata tables as well, right? The situation that we need to handle in this PR is setting the default, like you had before. We just want to use a metadata split size so you can set it and not have the same split size used (by default) for both metadata and data scans." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "wait a sec, shouldn't this be `'*'`?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if this is the correct way to do it.", "reference": "It think you'll want the var for GMI import as well: daisy_workflows/ovf_import/create_gmi.wf.json (Unfortunately there's duplication between the two :/ )" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Nit: Group this with the other commands by moving it down one line." }, { "prediction": "I'm not sure if this is the case, but if it's the case, it's the case.", "reference": "I would like to emphasize that a user can use non-vectorized reads to handle this file so maybe something like \"Cannot perform a vectorized read of ParquetV2 File with encoding %s, disable vectorized reading with $param to read this table/file\"" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Maybe add `positional=False`. It does not need it more than the other parameters, but one must start somewhere." }, { "prediction": "I'm not sure if this is the expected behavior, but it seems to be the expected behavior. I'm not sure if this is the expected behavior, but I'm not sure if it's the expected behavior.", "reference": "Since we're here, can we use a template?" }, { "prediction": "This is a brutal hack, but it's not a good idea. It's not a good idea.", "reference": "saw you're also doing this in `test_types.py`: `spark = _spark_context()['test'].resources['spark'].resource_fn(None)` since `_spark_context()` uses `spark_session_local` won't the above break the tests?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "`has(default)` i think is the preferred way of doing this" }, { "prediction": "I don't think this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "always put a space after a comma" }, { "prediction": "I'm not sure if this is the case, but if it's the case, I'm not sure if it's the case, so I'm not sure if it's the case, but if it's the case, I'm not sure if it's the case, so I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "@angmas1 move the else up, next to the closing bracket of the if block. Also, there is no need for the braces as your else statement contains only a single line. Make your if-else block similar to the block in lines 277-280." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "@AutomatedTester @davehunt thoughts on a new keyword argument?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "This change shouldn't be necessary for this PR. Please remove it." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure if you're trying to do something like this, or if you're trying to do something like this, you'll need to do something like this, or if you're just trying to do something like this, you'll need to do something like this, or if you're just trying to do something like this, you'll need to do something like this, or if you're just trying to do something like this, you'll need to do something like this, or if you're just trying to do something like this, you'll need to do something like this, or something like that.", "reference": "This variable is mostly unused, how about we make `NewTestCtx` return a pointer?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this (I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this)", "reference": "What is the basis of this value?" }, { "prediction": "It's not necessary to #include #include #include \"gce_metadata.h\" #include \"gce_metadata.h\" #include \"gce_metadata.h\" #include \"gce_metadata.h\" #include \"gce_metadata.h\" #include \"gce_metadata.h\" #include \"gce_metadata.h\" #include \"gce_metadata.h\" #include \"gce_metadata.h\" #include \"gce_metadata.h\" #include \"gce_metadata.h\" #include \"gce_metadata.h\" #include \"gce_metadata.h\" #include \"gce_metadata.h\" #include \"gce_metadata.h\" #include \"gce_metadata.h\" #include \"gce_metadata.h\" #include \"gce_metadata.h\" #include \"gce_metadata.h\" #include \"gce_metadata.h\" #include \"gce_metadata.h\" #include \"gce_metadata.h\" #include \"gce_metadata.h\" #", "reference": "Nit: was this extra blank line added intentionally?" }, { "prediction": "I'm not sure if this is the case, but it seems to be the case.", "reference": "nit: inconsistent spacing around =" }, { "prediction": "I'm using Sonata\\ClassificationBundle\\Model\\CategoryInterface instead of Sonata\\ClassificationBundle\\Model\\CategoryInterface. I'm using Sonata\\ClassificationBundle\\Model\\CategoryInterface. I'm using Sonata\\ClassificationBundle\\Model\\CategoryInterface. I'm using Sonata\\ClassificationBundle\\Model\\CategoryInterface. I'm using Sonata\\ClassificationBundle\\Model\\CategoryInterface. I'm using Sonata\\ClassificationBundle\\Model\\CategoryInterface. I'm using Sonata\\ClassificationBundle\\Model\\CategoryInterface. I'm using Sonata\\ClassificationBundle\\Model\\CategoryInterface. I'm using Sonata\\ClassificationBundle\\Model\\CategoryInterface. I'm using Sonata\\ClassificationBundle\\Model\\CategoryInterface.", "reference": "We still need this import" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "We are pulling this because we removed \"groupID\" state and put it into the strategy implementations" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Is this file actually related to PCA?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to create a tracking event from a separate file.", "reference": "See above, this should probably remain `isFirstAdmin`." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Why the change to make it public? The expression interface has the `TypeOf` method?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "don't mind the snake cases in the test names. If there are in the test cases, it's fine IMO" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if this is a bug or a bug.", "reference": "`Id` defines REST resource address and should not be in payload" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "We can omit the underscore and just use `classwise`." }, { "prediction": "This should be safe as the root category has to exist for a given context but I do not like this as I do not like it. I do not like this because I do not like it. I do not like this because I do not like it. I do not like this because I do not like it. I do not like this because I do not like it. I do not like this because I do not like it. I do not like this because I do not like it. I do not like this because I do not like it. I do not like this because I do not like it. I do not like this because I do not like it. I do not like this because I do not like it. I do not like this. I do not like this because I do not like it. I do not like this. I do not like this.", "reference": "Why not throw an exception instead then?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Looks like this doesn't need to change. Can you revert this?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "please import it like `from kinto.config import template`" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "There are lots of default value changed, not sure if it break the old behavior." }, { "prediction": "\"github.com/golang/golang\" \"github.com/golang/golang\" \"github.com/golang/golang\" \"github.com/golang/golang\" \"github.com/golang/golang\" \"github.com/golang/golang\" \"github.com/golang/golang\" \"github.com/golang/golang\" \"github.com/golang/golang\" \"github.com/golang/golang\" \"github.com/golang/golang\" \"github.com/golang/golang\" \"github.com/golang/golang\" \"github.com/golang/golang\" \"github.com/golang/golang\" \"github.com/golang/golang\" \"github.com/golang/golang\" \"github.com/golang/golang\" \"github.com/golang/golang\" \"github.com/golang", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's a good idea.", "reference": "parameter should be called removeFromStaticNodes" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "The handler will have an extra property in the marker to signal the implementation is in the provider, for the cases we want to add functionality, for example, custom implementations not in moto." }, { "prediction": "I think this is what you're looking for.", "reference": "Is this method actually being used anywhere? If not, I think we should remove it." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug.", "reference": "Thanks! I somehow lost this between my far too many branchs." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to import FirefoxProfile from selenium.webdriver.firefox.profile import FirefoxProfile from selenium.webdriver.firefox.profile import FirefoxProfile from selenium.webdriver.firefox.profile import FirefoxProfile from selenium.webdriver.firefox.profile import FirefoxProfile from selenium.webdriver.remote.webdriver import WebDriver as RemoteWebDriver from.service import Service -from.options import Options +from.webelement import FirefoxWebElement class WebDriver(RemoteWebDriver):", "reference": "i think this should get put into its own file. This could start to grow :)" }, { "prediction": "I'm not sure if this is the case, but I think this is the case.", "reference": "Can you add a TODO for loading the tarball of the pause image into Docker?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct. I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "Is there any value in setting the process to null like this?" }, { "prediction": "I'm not sure I'm correct, but I'm not sure I'm correct, but I think I'm correct.", "reference": "This could be a good time to add a check that the prediction and target dimensions (except channel) agree?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "The requirement that OP_isb is bb-final needs to be a rule for clients, just like the rule that syscalls and interrupts must be bb-final: i.e., please add it to the dr_register_bb_event() docs." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "The translate library has a method to replace the variables." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if it's what you're trying to do.", "reference": "i don't think this test case is correct. in both cases inpalce=True returns nothing. We need to compare the ks. Also we probably need to make a copy of it. Otherwise you pollute the following \"ks\" because ks has been changed." }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this (assuming you're using the tls.TlsClienthelloHook, tls.TlsStartClientHook, tls.TlsStartServerHook, tls.TlsHandshakeHook, tls.TlsHandshakeHook, tls.TlsStartClientHook, tls.TlsStartServerHook, tls.TlsHandshakeHook, tls.TlsStartClientHook, tls.TlsStartServerHook, tls.TlsHandshakeHook, tls.TlsStartClientHook, tls.TlsStartServerHook, tls.TlsStartClientHook, tls.TlsStartServerHook, tls.TlsStartClientHook, tls.TlsStartServerHook, tls.TlsStartServerHook, tls.TlsStartClientHook, tls.TlsStartServerHook, tls.TlsStartClientHook, tls.TlsStartServerHook, tls.TlsStartServerHook, tls.TlsStartClientHook, tls.TlsStartServerHook, tls.TlsStartServerHook, tls.TlsStartClientHook, tls.TlsStartServerHook, tls", "reference": "Any proposals how to make the naming somehow include the \"completed\" idea of this hook? `TlsHandshakeCompletedHook` or similar? Or using the `...Start/End...` scheme?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's the best way to do it.", "reference": "it introduces a lot of complexity to the state, can we flush straightaway or create a two level flush store where the questions are read form unflushed data?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "There are two calls to getUrlFromRouteCache, but you're only urlencoding one of them. Is that intentional? Would it make more sense to do the url-encoding inside the getUrlFromRouteCache function?" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's a bug.", "reference": "Maybe we can use `this.instance.getCell` with `topMost` flag to get `TD` element?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Change this to Debug Level" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "I refactored the Aggregate, those are hard to read" }, { "prediction": "I'm not sure if this is what you're looking for, but it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting", "reference": "This is now done in the after method, so this test won't pass any more." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "What was the point of creating `user_block` if you're then not going to use it ;-)" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "@ueshin, I thought we can remove this entire file. Does that require some more works?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Just `return tokens.string[1:-1]` is enough" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "1 trailing blank lines detected." }, { "prediction": "I'm not sure if this is the right way to do it, but I think it's the right way to do it.", "reference": "Isn't this the default max width? In any case I would prefer to see these definitions in the css files." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Is this thread-safe? (If not, and if the solution is to introduce locking, let's reconsider how we do the scheme changing instead...)" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's what you're trying to do.", "reference": "Looks like this file has tabs instead of spaces." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "Hmm should we clean up container resources before task resources here? or the order does not really matter here?" }, { "prediction": "@bdd.given(\"I clean old downloads\") def clean_old_downloads(quteproc): quteproc.send_cmd(':download-cancel --all') def clean_old_downloads(quteproc): quteproc.send_cmd(':download-cancel --all') def clean_old_downloads(quteproc): quteproc.send_cmd(':download-cancel --all') def clean_old_downloads(quteproc): quteproc.send_cmd(':download-cancel --all') def clean_old_downloads(quteproc): quteproc.send_cmd(':download-cancel --all') def clean_old_downloads(quteproc): quteproc.send_cmd(':download-cancel --all') def clean_old_downloads(quteproc): quteproc.send_cmd(':download-cancel --all') def clean_old_downloads(quteproc): quteproc.send_cmd(':download-cancel --all') def clean_old_downloads(quteproc): quteproc.send_cmd(':download-cancel --all') def", "reference": "Please undo this :wink:" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "thanks for adding this missing association" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Should I remove this in favor of the HttpsConnectionFilterOptions overload?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "This shode be nullable, there alway sholud be at least one status in system, if not exist that mean data problme" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to add a JS file to unistall-sw.js? If so, you'll need to add a JS file to unistall-sw.js to avoid Cookie Cache Issues when Signin, see github issue: #3707 + $this->addJs('../../../modules/backend/assets/js/auth/unistall-sw.js'); + $this->addJs('../../../modules/backend/assets/js/auth/unistall-sw.js'); + $this->addJs('../../../modules/backend/assets/js/auth/unistall-sw.js'); + $this->addJs('../../../modules/backend/assets/js/auth/unistall-sw.js'); + $this->addJs('../../../modules/backend/assets/js/auth/unistall-sw.js'); + $this->addJs('../../../modules/backend/assets/js/auth/unistall-sw.js'); + $this->addJs('../../../modules/backend/assets/js/auth/un", "reference": "Spaces not tabs" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "To get the files inside a directory, please use `readDirStats()`." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "might be worth to call these `Isolation` instead of containers here and when presented to the user -- docker/rkt, in addition to cgroups and namespaces, also provide image discovery and filesystem preparation; there's also the security context and probably 1-2 other small things" }, { "prediction": "The Swarm Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be found in the LICENSE file.", "reference": "File is empty, consider removing?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "This seems to return the registry_url. The more meaningful URL is the catalog URL, which is the URL the user specifies in `quilt3.login`. The username might also be as useful here if not more useful." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Was the addition of `GasPriceOracleAddress` here erroneous?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "I believe that you are going to have to do some work here to get the env var support for these values to still work correctly, otherwise they will get stored as :department instead of host_tags[:department]." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure.", "reference": "How was this causing the exception?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "I still have issues with it loading Simplified Chinese by default over Japanese, since they also share characters and we're not sure if characters are different or not. As-is, this fixes Traditional Chinese and Simplified Chinese, but we're not sure if it'd still screw up Japanese text or not. I maintain that, in my opinion, Japanese should be the only script of this kind loaded by default (Because of Hiragana and Katakana, that aren't shared with any other script) and either variant of Chinese should be loaded only in their respective case." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Isn't it better to stub AtomatonQuery and yield it here. IIRC it resolves simplest MTQ highlighting cases as nobrainer." }, { "prediction": "You can also use the @discounted_plan.price_in_dollars operator instead of the @discounted_plan.price_in_dollars operator.", "reference": "Line is too long. [96/80]" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "My only concern with changing the node selector here is that someone else _could_ have built their own images for other platforms and set them to be used using the flag override on the controller, which in turn this change would break. Perhaps not changing the selector for acmesolver pods makes most sense, and then working on actually having support for Windows? wdyt?" }, { "prediction": "@ -24,7 +24,7 @ @ import ( \" ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Why do we need interface `InnerObjectWithSelector`, I searched the usage with this field, it seems nowhere use `GetSelectorSpecs()` methods provided by `InnerObjectWithSelector`" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Do we need this `init` here? We have already called the `InitContext` in `StartModule` directly." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "This `if` is not necessary" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "should we add a `mangle.json` mapping for this? We could reuse a property name that's only used on component or vnode objects right now, like `__s` (\"next state\")." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Please update the yard docs to indicate this new option." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Can you provide an example in the godoc section on how to use this? From the implementation it looks like the AvailabilityZone field is required for example, otherwise it can fail / error, is that correct?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "It would be great if this could be captured by a test." }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "1000 -> 100 maybe too much, 200 ish to 500ish maybe a good option" }, { "prediction": "I'm not sure why you're getting this error, but I'm not sure why you're getting this error, but I'm not sure why you're getting this error, so I'm not sure why you're getting this error.", "reference": "Any reason we need to keep this package's `ChecksumAddress` type or can we get rid of it too?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "Above the one that was picked was the Button* prefix, and here it's the Header* prefix. Maybe the Button prefix is more general." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "I might prefer changing: public Block FindPendingBlock() => FindBlock(PendingHash, BlockTreeLookupOptions.None); public BlockHeader FindPendingHeader() => FindHeader(PendingHash, BlockTreeLookupOptions.None); in IBlockFinder, what do you think?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "This is necessary due to a bug in 4.7. Follow HIVE-1561 for getting rid of it." }, { "prediction": "I think this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug in X11/Xlib.h, so I'm not sure if it's a bug or a bug in X11/Xlib.h or a bug in X11/Xlib.h or a bug in X11/Xlib.h or a bug in X11/Xlib.h or a bug in X11/Xlib.h or a bug in X11/Xlib.h or a bug in X11/Xlib.h or a bug in X11/Xlib.h or a bug in X11/Xlib.h or a bug in X11/Xlib.h or a bug in X11/Xlib.h or a bug in X11/Xlib.h or a bug in X11/Xlib.h or a bug in X11/Xlib.h.", "reference": "Some day (tm) I will also get rid of that one. But today is not that day..." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Add a space between if and opening parenthesis please (i.e. `if (`)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "nit: `rename` instead of `alias`?" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "Per AWS docs EC instances have the root mounted at /dev/sda1. This label should be skipped." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "I'm not sure it is a better way to address lose message, if wait here, edge controller cant process message, event from watching api-server will be lost yet, right?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Please keep the correct alignment, it seems broken now (at least in Github). Can you reverse the test (`if p.value_size is None`)? Also, do you want `6` when `p.value_size is None` or `x + 6`? Maybe, in that case, something like `lambda p, x: x + 6 + (0 if p.value_size is None else p.value_size)` would be easier to read. Or even easier: `lambda p, x: x + 6 + (p.value_size or 0)`." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Can we make sure ECS service treats it as int64 as well?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "Please follow the naming convention for variables, i.e. `windowText`." }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "alias can be `cast`" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "Let's use `%zu` instead of casting to `uint64_t` and using `PRIu64`. The alternative is to change the type of `mmap_errors` to `uint64_t`, though I'd prefer not doing that because some 32-bit platforms might not provide atomic operation support for `uint64_t`." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "I recall there being a reason we had this one set only to suggeation. @carterkozak do you remember why? or is my memory getting corrupted?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be fixed.", "reference": "This should now be made into `if (it->second.empty())`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Do we need to worry about a race condition on this decrement (@The-Compiler)? I'm not sure how the python callbacks work, so this might not need to be something to worry about." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Should these assert that the extracted `SpanContext` is remote?" }, { "prediction": "This is a ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "typo: allow low quality matches." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "At some point we need to condense down and refactor our \"configs\" as we have too many in too many places and we're starting to get more illegible code. No change necessary but calling out for future reference." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to work.", "reference": "Can we add the `if label` conditional to this please?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do.", "reference": "@thunterdb, can we increase the minimal version to almost the latest ones? I was thinking people will mostly use the latest version of mlflow" }, { "prediction": "The `beforeAutofill` hook is deprecated. The `afterAutofill` hook is deprecated. The `afterAutofill` hook is deprecated. The `afterAutofill` hook is deprecated. The `beforeAutofill` hook is deprecated. The `afterAutofill` hook is deprecated. The `afterAutofill` hook is deprecated. The `afterAutofill` hook is deprecated. The `afterAutofill` hook is deprecated. The `afterAutofill` hook is deprecated. The `afterAutofill` hook is deprecated. The `afterAutofill` hook is deprecated. The `afterAutofill` hook is deprecated. The `afterAutofill` hook is deprecated. The `afterAutofill` hook is deprecated. The `afterAutofill` hook is deprecated. The `afterAutofill` hook is deprecated. The `afterAutofill` hook is deprecated. The `afterAutofill` hook is deprecated. The `afterAutofill` hook is deprecated. The `afterAutofill` hook is deprecated. The `afterAutofill` hook is deprecated. The `afterAutofill` hook is deprecated. The `", "reference": "If the last argument is going to be removed, why would we add it to the API docs? Shouldn't it be private for internal use?" }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this in the.execution_plan.intermediates_manager import ( SystemPipelineExecutionContext, ) - from.execution_plan.intermediates_manager import ( SystemPipelineExecutionContext, ) - from.execution_plan.intermediates_manager import ( SystemPipelineExecutionContext, ) - from.execution_plan.intermediates_manager import ( SystemPipelineExecutionContext, ) - from.execution_plan.intermediates_manager import ( SystemPipelineExecutionContext, ) - from.execution_plan.intermediates_manager import ( SystemPipelineExecutionContext, ) - from.execution_plan.intermediates_manager import ( IntermediatesManager, ) - from.execution_plan.intermediates_manager import ( IntermediatesManager, ) - from.execution_plan.intermediates_manager import ( IntermediatesManager, ) - from.execution_plan.intermediates_manager import ( IntermediatesManager, ) - from.execution_plan.intermediates_manager import ( IntermediatesManager, ) - from.execution_plan.intermediates_manager import (", "reference": "`Intermediates` or `Intermediate`" }, { "prediction": "Is there a way to check if element.is_displayed() == visibility? I don't think there's a way to check if element.is_displayed() == visibility, but I'm sure there's a way to check if element.is_displayed() == visibility.", "reference": "This is not the right exception class. There is an InvalidSelectorException class that covers bad locators." }, { "prediction": "I'm not sure if this is the case, but I think it's the case. I'm not sure if this is the case, but I think it's the case.", "reference": "If this code isn't needed, it should be removed." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm not sure.", "reference": "Should the `doRequest` func be a method on the `connection` type instead of passing state from the type?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "we'll probably tackle these e2e tests at the end" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "what is this address pointing to? what are we measuring here? I want to have a better understanding." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Would it be better to pass the dependency status as the parameter into the SQL string? In case the enum value is changed in the future, we don't need to change the code here." }, { "prediction": "I'm not sure if this is a BSD license, or if it's a BSD license, or if it's a BSD license, it's just a license that can be found in the LICENSE file. If it's a BSD license, it's a license that can be found in the LICENSE file. If it's a BSD license, it's a license that can be found in the LICENSE file. If it's a BSD license, it's a license that can be found in the LICENSE file, but it's not a license that can be found in the LICENSE file.", "reference": "Hah I had `gorename` failing without this too." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "maybe prefix these with `appsec_` for consistency?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing you're looking for something like \"golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang.org/x/golang", "reference": "nit: this should be down further with the other github imports" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's probably what you're trying to do.", "reference": "Why is this change necessary or related to the rest of the PR?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Hm, I wonder if the `see:` prefix is even necessary?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this. I'm not sure what you're trying to do, but I think you're trying to do something like this. I'm not sure what you're trying to do, but I think you're trying to do something like this. I'm not sure what you're trying to do.", "reference": "This should be translated." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "I originally had this PR only changing the R package, but then ran into this error > Error: [LightGBM] [Fatal] Cannot change metric during training This is thrown even if you aren't actually CHANGING `metric`. I think the change here in `c_api` is closer to the desired behavior, only throwing an error if the parameter is being changed." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "These changes are just to make cli_spec a little more readable for VS Code users, as there's a bug with the Ruby plugin's syntax highlighting when you use multi-line regex literals." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Shouldn't the global pull secret by in the namespace of the hive-operator? It is part of the operand." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "kinesis-mock applies KINESIS_LATENCY to RegisterStreamConsumer actions so I added a sleep here." }, { "prediction": "Can't upgrade meta from V1 to V2 to V3 to V3 to V3 to V2 to V3 to V3 to V3 to V2 to V3 to V3 to V2 to V3 to V3 to V3 to V3 to V2 to V3 to V3 to V3 to V2 to V3 to V3 to V3 to V2 to V3 to V3 to V2 to V3 to V3 to V2 to V3 to V3 to V3 to V2 to V3 to V3 to V2 to V3 to V3 to V2 to V3 to V3 to V3 to V2 to V3 to V3 to V2 to V3 to V3 to V3 to V2 to V3 to V3 to V3 to V2 to V3 to V3 to V2 to V3 to V3 to V3 to V2 to V3 to V3 to V2 to V3 to V3 to V3 to V3 to V3 to V2 to V3 to V3 to V2 to V3 to V3 to V3 to V3 to V2 to V3 to V3 to", "reference": "Only V1 or V3 is return from `getMetaVersionFromKV`. So where do we call `updateMetaV2ToV3`?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for a version that's not compatible with a version that's not compatible with a version that's compatible with a version that's not compatible with a version that's compatible with a version that's not compatible with a version that's compatible with a version that's not compatible with a version that's compatible with a version that's not compatible with a version that's compatible with a version that's not compatible with a version that's compatible with a version that's not compatible with a version that's compatible with a version that's compatible with a version that doesn't support a version that's compatible with a version that's compatible with a version that's compatible with a version that's compatible with a version that's not compatible with a version that's compatible with a version that's compatible with a version that's compatible with a version that's compatible with a version that's compatible with a version that's compatible with a version that's compatible with a version that's compatible with a version that's compatible with a version that's compatible with", "reference": "I think that V0 is missing here, which will prevent plugins that haven't been converted to work." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Should we remove this?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Put on top of the import." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "See above, this shouldn't be added." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing that you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "This'll likely get fixed upstream, we should let them deal with it." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Somehow, this field does not seems useful for the exposed package api, only for the tests. Would you consider having an unexported field in `hostFactory func(context.Context,...libp2p.Option) (host.Host, error)` instead to be set only by a new helper function defined in export_test.go. This is just a suggestion, not a hard requirement for the PR approval." }, { "prediction": "I think this is what you are looking for, but I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "As a first argument to these function, please pass the date that should go forward/backward. Also please clarify what is \"n\" (possible values, unit) and what is timeDuration (possible values, unit, as from your code it seems to be \"day\", \"hours\", etc. but from your example it seems to be milliseconds)." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think this is what you're trying to do.", "reference": "Are you sure you really need this code here? that script will be certainly run in NVDA's main thread, and core would have already called setLanguage." }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "why is this changed?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Should this be \"the new revision value\"?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "You have deleted :attribute" }, { "prediction": "The License is distributed under the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the \"License\"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at + * * Copyright 2017 Huawei Technologies Co., Ltd * - * http://www.apache.org/licenses/LICENSE-2.0 + * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at + * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed under the License at * * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed under the License", "reference": "The license header should be updated to the Apache one." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "@zacharycmontoya Is there any way to distinguish a `SocketHttpHandler` from another `HttpMessageHandler` request?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Not sure about this one -- did you check somehow?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Is there a good reason to keep this at the `pe_ver_win` name now that it's per-host?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this.", "reference": "Not in the order of display : Front, Ingredient, Nutrition here (which is the right thing), Actually displayed: Front, Nutrition, Ingredients" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for.", "reference": "Why delete `StartTime`? This `StartTime` was used to avoid the PID was reused." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "My concern here, is that if the dump_puppet_log also throws then we will lose the data about the teardown_exception." }, { "prediction": "I'm not sure why this is happening, but I'm not sure why it's happening. I'm not sure why it's happening, but I'm not sure why it's happening. I'm not sure why it's happening, but I'm not sure why it's happening, but I'm not sure why it's happening.", "reference": "Should it be `int64_t`?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "is this value related to something?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a good idea.", "reference": "Add names to tuple elements ValueTask<(Keccak? Hash, AddTxResult? AddResult)>, should they both be nullable?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "I think it might make more sense to do this in Name.upperCamel; it is the entry point for upper camel strings." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "Huh? The point is that a cast isn't necessary" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "can we name it like `InstallV1Alpha1CRDs`?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so I'm not sure if it's a bug, or if it's a bug.", "reference": "I need something to match when creating selectorsyncsets so added this label." }, { "prediction": "Why don't you just return nil if line == '-e:1'?", "reference": "Isn't `nil` the default return value from an empty `rescue` clause? If that's correct, then we could just remove the `nil` line entirely as it doesn't serve a purpose." }, { "prediction": "This code example demonstrates how to add a cross-origin resource sharing (CORS) to an Amazon Simple Storage Solution (Amazon S3) bucket. This code example demonstrates how to add a cross-origin resource sharing (CORS) configuration containing a single rule to an Amazon Simple Storage Solution (Amazon S3) bucket. This code example demonstrates how to add a cross-origin resource sharing (CORS) configuration containing a single rule to an Amazon Simple Storage Solution (Amazon S3) bucket. This code example demonstrates how to add a cross-origin resource sharing (CORS) configuration containing a single rule to an Amazon Simple Storage Solution (Amazon S3) bucket. This code example demonstrates how to add a cross-origin resource sharing (CORS) configuration containing a single rule to an Amazon S3 bucket. This code example demonstrates how to add a cross-origin resource sharing (CORS) configuration containing a single rule to an Amazon S3 bucket.", "reference": "Simple Storage **Service**" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems that you're trying to remove obsolete indexes from the cache which doesn't exist in the repo. I'm not sure if this is what you're looking for, but it seems that you're trying to remove obsolete indexes from the cache which doesn't exist in the repo, so I'm not sure if this is what you're looking for.", "reference": "Wouldn't that cause the obsolete indexes to be downloaded over and over again? After all these are still stored in the repository." }, { "prediction": "I think this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "We might want to move this logic to a Plain Old Ruby Object down the road. Not a blocker." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "move `this.toolbox_.position();` to just after line 1477. Context: the if statement on line 1472 checks whether this is a toolbox with categories, and if so it populates the toolbox. Positioning the toolbox is a reasonable followup to that, and means you don't need an extra if. You may also need to call `this.flyout_.position()` after line 1483, which is the equivalent for the non-category toolbox." }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "Should the function above be.FirstOrDefault() instead? Otherwise, why check for null and tell ReSharper to ignore the fact that it can never be null?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Let's not create new connection, but rather user `common.db` one" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "Can this use asset_path rather than defining an image_url helper?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Hindley-Milner signatures don't use literal types. They explusively use types. It's deal with that" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do this in a way that you don't want to do this in a way that you don't want to do it in a way that you don't want to do it in a way that you don't want to do it in a way that you don't want to do it in a way that you don't want to do it in a way that you don't want to do it in a way that you don't want to do it in a way that you don't want to do it in a way that you don't want to do it in a way that you don't want to do it in a way that you don't want to do it in a way that you don't want to do it in a way that you don't want to do it in a way that you don't want it in a way that the openflow module needs to do it in a way that the openflow module needs to do it in a way that the openflow module needs to do it in a way that the openflow module needs to do it in a way that", "reference": "Could we just extend PolicyRule with more fields? It was originally designed as the struct required by openflow client, nested structs seem not helping. And for the name of the fields, initialism should be uppercase, OFID and NPName doesn't look good, then maybe FlowID, PolicyName.." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "I really dislike this alignment approach, as it makes identifying individual functions quite hard, but I kept consistent with the previous style. Since no sorting was evident, I pushed it to the end of the block. Meanwhile, is this supposed to be tested or meaningfully testable somehow?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "Could also consider modifying the ActiveExecution..." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Does it make sense to change that to a custom error instead of `ValueError`?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "I guess this will need to change soon." }, { "prediction": "The header directive goes second so that headers // can be manipulated before doing redirects.", "reference": "Restore this spacing - not sure why it has to be removed?" }, { "prediction": "I'm not sure what you're trying to do, but it's a good idea.", "reference": "These defines cause issues in base.h leading to failing android builds. Locale independency is now set in multiple spots, in cmake and in base.h. The base.h uses feature test macros wrong. Feature test macros can be used to indicate that a feature should be made available. They do not guarantee that it is available. On the cmake side this is done by the check symbol macros (similar to what autoconf does). On the android side not. I would suggest removing this from base.h and define locale independent in gradle. It is available since android 21 I believe. Is there a way in gradle to set locale independent only if android api >= 21?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Why not delete these codes?" }, { "prediction": "I'm not sure if it's a bug, but if it's a bug, it's a bug.", "reference": "If pull message failed after some reties, we should ensure the storaged exit, otherwise it has risk to loss data." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "looks like you don't need to import first and count here anymore" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "FYI, visibility task processing is local only, meaning pushing something to local ES cluster / local archival endpoint" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "This import can be removed." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here. I'm not sure what you're trying to do here.", "reference": "1. Nit: We can have a general helper to identify if a region is pseudo region. We might already have one somewhere. 2. Does any type of ARN support FIPS? If not, we may just move this check in arn package?" }, { "prediction": "This is not a stubber, it is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is a stubber. It is", "reference": "is this phrase completed in a next line? Or forgot to add... what?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "`('train', 5)` and `('train', 1)` are actually the same." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Would it be too complicated to refactor `currLimit` to be an `int64`?" }, { "prediction": "The RSpec::Core::Pending.instance_method(:skip) is not a `skip` method. Instead, it's a `skip` method. It's a `skip` method. It's a `skip` method.", "reference": "Would it be more performant to just `include ::RSpec::Core::Pending` here? /cc @myronmarston" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "Should be podiochaos?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "Is the `codecs.register(lambda name: None)` gracefully handled by codecs? The lambda is expected to return a tuple of functions (encoder, decoder, stream_reader, stream_writer) (or a CodecInfo object), according to the docs. I've only checked python's built-in help, though." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug.", "reference": "in this case, it could be either instrument name or the view name, which could be invalid. might be better if we can offer very specific message. (not blocking this, we can add this as a follow up,if needed)" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "I'd rather just send the parameter twice than break encapsulation here. There's already precedence with webelement IDs" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "You may put 'open-mmlab://res2net101_v1d_26w_4s' here. MMCV will be updated later." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "May be worth making this more specific, to avoid potential conflicts, maybe `pagespeedDashboardWidget`? Or `webVitalsDashboardWidget`?" }, { "prediction": "I'm not sure if this is the correct way to do this, but I think this is the correct way to do it.", "reference": "I guess this assignment is now redundant?" }, { "prediction": "I'm not sure if this is the case, but I think it is the case.", "reference": "See above note re: blockNum synchronization." }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "wonder if we could avoid doing named imports if we type aliased `backoff.Backoff` in the `.../agent/common/backoff` package?" }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this:", "reference": "Or maybe put into alphabetical order with the other #includes." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "This runs the entire duration of the program; this change is not needed." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "I don't feel well about the `ALWAYS_UPDATE` option   sounds like a workaround. I can imagine that some of the plugins want to observe all options. Maybe, in that case, we can reuse the `CONFIG_KEYS` that would return an empty array for observing all settings and `false` for disabling observing at all? I just thinking aloud - Like `CONFIG_KEYS` sounds reasonable. We could support and maintain it in the future, even after implementing the \"observability\" to the MetaManager then `ALWAYS_UPDATE`... I don't know :)" }, { "prediction": "This is not a bug. It is a bug. It is a bug. It is a bug.", "reference": "A \"tab difference\"? As in, there are tab characters somewhere? This disabling of clang-format for all the code here seems like overkill. Are you sure there's not some other solution? I don't really understand the problem though. Do you mean clang-format-diff?" }, { "prediction": "I'm not sure this is a bug, but it's a bug, and it's a bug.", "reference": "Could you please leave the explicit imports?" }, { "prediction": "private static List methodConfigs = new ArrayList<>(); for (MethodConfigProto methodConfigProto : interfaceConfigProto.getMethodsList()) { if (methodConfigMap.get(methodConfigProto.getName()) == null) { + continue; + } methodConfigs.add(methodConfigMap.get(methodConfigProto.getName())); } return methodConfigs; }", "reference": "Can we check for containsKey here?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "Exit successfully. We served the help the user wanted." }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Had to rename this because `InitialPackage()` already existed." }, { "prediction": "I'm not sure what you're trying to do, but I think it's a good idea.", "reference": "Can we put this in a different helper?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "I'm not sure where your 31 comes from? I see 15 here and 2 above for pc and flags, for 17 total beyond the SIMD." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "If you want, you could change this to `allowCors(response` (like in \"version\", above) to allow Cross-Origin Resource Sharing. I'm sort of wondering what's returned if no API terms of use are set." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Why do we need to override this if all we're doing is passing it up?" }, { "prediction": "I don't think this is a bug, but it's a bug in CmpCommon::context()->sqlSession()->getParentQid()", "reference": "Just wondering whether it's safe to send all CQDs to the child compiler. As this missing CQD is causing trouble, maybe some other user CQDs that now get sent could also cause the statement to fail? Also, if I have a table with a nullable unique column, should I have to set this CQD to create another table like it, or should the CREATE TABLE LIKE work without the CQD?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "EARLIEST_TESTED_RELEASE might be slightly more clear" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "I think replacing `.*` with `\\s*` from after the hash makes sense, but not the rest of the changes." }, { "prediction": "I'm not sure if this is the case, but it's the case. I'm not sure if this is the case, but it's the case. I'm not sure if this is the case, but it's the case.", "reference": "interesting.. did not know varint tag covered bool as well" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Could you please elaborate the reason for not using `gkc_summary` like the values above? I ask this, because I assume what we want to collect is a histogram of event loop latency, and we use `gkc_summary` for collecting histograms." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "getHash should be a public and without an `_` if used here." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "Unrelated to these changes -- we will probably want some special handling for genesis block validation." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "This is probably overkill since we don't actually need to pass this specific interface anywhere, but I don't mind it!" }, { "prediction": "I'm not sure if this is a bug, but if it's a bug, it should be fixed.", "reference": "@janos I moved this back here, to avoid having multiple add peer calls being handled. I think it's either this or a global lock across the whole function. I think this is a better approach, especially since `hive.Broadcast` is blocking. We can remove the map entry on errors if needed. LMKWYT?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Minor: can we put the conditional outside of the partial?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to write to a file that doesn't exist in a directory that doesn't exist in a directory that doesn't exist in a directory that doesn't exist in a directory that doesn't exist in a directory that doesn't exist in a directory that doesn't exist in a directory that doesn't exist in a directory that doesn't exist in a directory that doesn't exist in a directory that doesn't exist in a directory that doesn't exist.", "reference": "We need to find something more efficient than this. We can probably just check the first element and assume the type list is consistent.." }, { "prediction": "\" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" is good for jobs which need to run frequently. \"Fixed Schedule\" lets you use a predefined or custom cron schedule and is good for less-frequent jobs or those which require specific execution schedules.", "reference": "How \" via service code in response to event.\"? I don't think we'll get in the no schedule option to the release. We should probably wait for some customer feedback first to make sure we're addressing different event-triggers the best way" }, { "prediction": "@ -65,7 +65,6 @@ PER_YIELD = 1024 def generate_model_handle(): \"\"\"Generate random model handle. - Returns: str: random bytes for handle \"\"\" return generate_model_handle()", "reference": "Please move unrelated formatting changes to their own PR (same with the resources.py file)." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Make this a public attribute (remove the leading `_`) if you want to access it from the outside." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "this conditional is useless now so it should be removed" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "`vecofstructs->size()` already returns a `uoffset_t`. So if you just change the type of `i`, you don't need any casts." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Nit: Maybe merge this with the configProto check on line 208? Don't feel that strongly though, please keep separate if you prefer." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "I know we already did this in 4.0 so carry on, but I'm facepalming here we should've made an overrided setMessageHandler that sets ismaster to true when hello is present. Esp in 4.0 where we already have some overrides written. We can keep going here and maybe open a ticket to some effect of that solution" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I believe we could use `link_to` here (although not super important). Also, we should internationalize this value. I'm not 100% sure what our process is for adding new UI strings these days (e.g. skip the specs that will fail if we add a new key to only one language, use Google Translate to translate the value for us, some other option)." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm guessing it's a bug.", "reference": "This was already in vkGetPhysicalDeviceDisplayProperties2KHR..." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug in the dockerEngineValidator interface.", "reference": "nit: I'd expect a public method called IsDockerEngineRunning to return a boolean yes/no, not the error message. Can we change either the return value or the name? Something like `CallDockerEngine`" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "If i remembered correctly, type_name is '{RESOURCE_TYPE}/{RESOURCE_NAME}', if type_name is 700 max then name cannot exceed that size" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "When calling functions with keyword arguments: please provide the arguments as keyword arguments, not positional arguments." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "We may follow the argument order: conv_cfg, norm_cfg, act_cfg." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "`options['binary'] = WebDriver::Chrome.path` if set?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "folly library should be put on the top." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Do we have to restrict this to SVG elements? I think setting namespaced attributes on normal dom elements (while not as common) is still valid, so perhaps we can save some bytes by removing the `isSvg` check?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Please add it to the `REMOVED_HOOKS` constant." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "This variable needs `.v1` at the end of it, or the tests below need it. There are some test failures as a result" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this: I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "Is this access protected so that only admins can access this route?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug, so it should be fixed.", "reference": "What happens if the minimum x coord is > 0? This will incorrectly set it as zero, right?" }, { "prediction": "I think this is a bug. It should be fixed in the latest release.", "reference": "I think you want to look at current pending + batchSize and if that is > o.maxp no?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Should this be `codes.Error`? `codes.Internal` was an error status before." }, { "prediction": "I think this is what you're looking for.", "reference": "I don't think you need these lines." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here.", "reference": "You didn't mean to export this, right?" }, { "prediction": "The AWS SDK for Ruby is available at https://aws.amazon.com/aws-sdk-for-ruby/", "reference": "Simple Notification **Service** (singular)" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Do we still need this?" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "We do have a disconnect between the privateMarkerTransactionFactory.getSender() call and the createPrivateMarkerTransaction() call. When the plugin receives the call to create the PMT it does not know what the sender was returned by the other call. At a minimum we need to pass in the sender to the second call. I would prefer that the plugin does the locking if that is necessary. If you are using random keys you don't have to lock! Besu could signal to the plugin when a PMT was un- or successfully added to the pool using a callback. Callback could be null if this is not needed. The plugin would have to be able to get the nonce for a certain key from besu. What do you think?" }, { "prediction": "I'm not sure if this is the correct way to do this, but it's the correct way to do it.", "reference": "This is a bit inconsistent with the `ErrorStartHourGreaterThanEnd` in the previous file. Wouldn't `ErrorDefault``fit better here?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "I think it will revert the change @antoninbas did on purpose 05eee251c9c53400277def576f92d614ca234898" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm sure it's a bug.", "reference": "nit: a switch perhaps?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "Would it make sense for `opensearch_description_tag` to have default values for the title and href attributes?" }, { "prediction": "I think this is a bug in the `jirmds` package. It should be fixed in the `jirmds` package. It should be fixed in the `jirmds` package.", "reference": "Just noticed this while debugging -- it's unlikely to be causing issues in practice." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "That seems unrelated - did that fix a random test failure you noticed while working on this issue?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "This kind of concern should be handled in the `TableMetadata` update methods. This is similar to `metadata.rollbackTo`, which not only sets the current version, but also updates the table history. I think that all of those methods should add the current object's `file.location()` to the previous metadata location list, if it is non-null. That way, the caller never needs to remember to update it." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "We need to know why all the tensors are detached in `get_bboxed`." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Unrelated but shouldn't this raise `attribute-defined-outside-init`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "I would rather no have this as a `kwarg` as it encourages \"growth\" which lead to an unweildy constructor in other classes. Let's add a method or property to take care of this instead as I think it's usage is going to be quite low." }, { "prediction": "I think this is a bug in ActiveRecord::Base. It should be fixed in ActiveRecord::Base. I'm not sure if this is a bug, but it should be fixed in ActiveRecord::Base. I'm not sure if this is a bug, but it should be fixed in ActiveRecord::Base or ActiveRecord::Base.", "reference": "You just changed my life :) I grew very attached to this safe nav approach when working with Groovy years ago `obj?.method`. Glad to see its now a part of Ruby!" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "do you mean 'clearfix' class?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "`causalConsistency` is already defined on `SessionOptions`. We do not need to duplicate it here." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so it's a bug.", "reference": "This should not be included since there are no code changes." }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if it's the correct way to do it.", "reference": "If all we need just response 200, then we could use `c.Status(http.StatusOK)` here." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "Should be checking for error here" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "Put a space between `(array)` and `$this` and I'll merge it" }, { "prediction": "This is a stub, not a stub, not a stub.", "reference": "You could add this to stack.go, which has similar functions (to avoid yet another small file). None of these are likely to be implemented considering what TinyGo is designed for." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to create a NotificationHolder, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do. I'm guessing you're trying to create a NotificationHolder, but I'm not sure what you're trying to do.", "reference": "the class names `NotificationHolder` and `NotificationsHolder` are fairly difficult to quickly tell apart, particularly since they are often used close to each other" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Avoid wildcard imports" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Need to do this to unblock mockgen. The interface method needs to be public to be visible in another package. The right fix is to delete this test only interface method" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "same question here as I have on the other file regarding doing this check here vs L112 vs not at all" }, { "prediction": "@ -1,3 +1,5 @@ +// + build!openbsd + package fuse import ('fuse')", "reference": "Adding `// +build!windows` (as a separate line) will do the same for Windows. So while you are at it we might add it as well." }, { "prediction": "I think this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "this is used as important way of mocking for unit tests, FYI" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Sorry, should have been clearer, I meant adding this to the ``Histogram`` options one line above." }, { "prediction": "I'm not sure why you're getting this error, but I'm not sure why you're getting this error. I'm not sure why you're getting this error, but I'm not sure why you're getting this error.", "reference": "Just ignorance on my part, but what is the significance of the change from C23NHe2 to C23NHx2?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "What about tuples or pandas series? Do we want to support lots of different types or force a single type?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it seems to be a bug.", "reference": "Small thing, without the check above this will throw a NoNodeException if the path doesn't exist. Maybe this can be wrapped in a try/catch just for the NoNodeException, so that the more user-friendly message used above can be thrown instead: `throw new KeeperException.NoNodeException(\"No collection found at path: \" + path);` Just a thought, I'm not even sure it's worth it." }, { "prediction": "I think this is what you're looking for, but I'm not sure if this is what you're looking for, so I'm not sure if this is what you're looking for.", "reference": "I don't know why this worked before, but we should be explicit on not verifying that a blank string (allowed as a way to remove a url/download_url) is a valid url as it is not." }, { "prediction": "I think this is a bug in Bolt 3.0 and should be removed in Bolt 3.0. I think this is a bug in Bolt 3.0 and should be removed in Bolt 3.0. I think this is a bug in Bolt 3.0 and should be removed in Bolt 3.0. I think it's a bug in Bolt 3.0 and should be removed in Bolt 3.0.\" - \"support will be removed in Bolt 3.0.\" + msg = \"Detected PowerShell 2 on controller. PowerShell 2 is unsupported.\" Bolt::Logger.deprecation_warning(\"PowerShell 2 controller\", msg) Bolt::Logger.deprecation_warning(\"PowerShell 2 controller\", msg) Bolt::Logger.deprecation_warning(\"PowerShell 2 controller\", msg) Bolt::Logger.deprecation_warning(\"PowerShell 2 controller\", msg) Bolt::Logger.deprecation_warning(\"PowerShell 2 controller\", msg) Bolt::Logger.deprecation_warning(\"PowerShell 2 controller\", msg) Bolt::Logger.deprecation_warning(\"PowerShell 2 controller\", msg) Bolt::Logger.deprecation_warning(\"PowerShell 2 controller\", msg) Bolt::Logger.deprecation_warning(\"PowerShell 2 controller\", msg)", "reference": "Do we want to raise an error here instead of warning? Or would it be better to just see if Bolt happens to succeed, and let it fail on it's own if it fails? I'd lean towards raising an error, but that's different from \"removing support\"." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "This is kind of confusing with the other `filter_options`." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Could the `deleteFromFavorites` happen when `head == nil` because it's not initialized yet somehow but not because TLF doesn't exist? I was concerned if this would make it possible in any way to have favorites seemingly deleted on a device while it's not actually happened on server." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it should be something like this:", "reference": "It doesn't look like this particular \"rowCount\" variable is used anywhere. I suppose we could delete it. The code change is harmless though." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "Hmm, probably we should instead write whatever `status` is returned instead of coding a special case." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Could using the pointer-to-struct approach here cause confusion later? We've had several problems of that kind in the past. What does it mean if the struct is non-nil but its fields are nil? Is that even allowed? (libcalico-go question) Are there any validation requirements for this new rule addition; should it only be allowed if `Protocol == TCP`, for example?" }, { "prediction": "We do not use rolify gem (e.g.) but we do not need to use it. We do not need to use rolify gem (e.g.) but we do not need to use rolify gem (e.g.) for this purpose.", "reference": "why this recursive relationship definition?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "More sentence, less list please. > Encoding of the handler. This field is optional. We don't need to mention exactly what it's used for because that list can expand (as it has already in this change)." }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Not part of this PR, but should the section above say what the name of the metric is for each method?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "there are changes that are upcoming to this section. For now, this works (to demo the usage of Gauge), and the changes to this section are coming as separate PRs." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case.", "reference": "This is equivalent to stdout. Why not just replace stdin with stdout in `IsProcessBackground`?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it should be something like this:", "reference": "Rather than test for nullptr, just treat the pointer as a bool, i.e. `if(p_jmsg[\"compress_method\"])`" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Can we move the remaining code of this method to a new method? I don't like the `return;` here, we could try to replace it with an `if... else...` syntax. What do you think?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug in kinto.readthedocs.io. I'm not sure if it's a bug, but it seems to be a bug in kinto.readthedocs.io, so I'm not sure if it's a bug.", "reference": "nitpick: _and collections_" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "I believe these need to be explicitly initialized in `proxy_send_prepare`" }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this:", "reference": "This is unnecessary. The declaration of `t0` on line 179 is still in scope inside the `except` block." }, { "prediction": "The border color when the client is floating is not supported. This is why the border color is not marked when the client is floating. This is why the border color is not marked when the client is floating. This is why the border color is not marked when the client is floating. This is why the border color is not marked when the client is floating. This is why the border color is not marked when the client is floating. This is why the border color is not marked when the client is floating.", "reference": "The `border_color_`... properties don't support solid colors, not only this one. Maybe `@param solid_color` should be used instead of adding this note to every one of them?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "We don't need this file, we can use the one that is in the grid-ui directory" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "FYI: inlined this method in the internal review." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Werid, the checksum between this file and the one on branch `develop` is the same not sure why it's showing a diff" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to create a new PrometheusMetricBuilder. I'm not sure what you're trying to do, but I'm guessing you're trying to create a new PrometheusMetricBuilder. I'm guessing you're trying to create a new PrometheusMetricBuilder.", "reference": "Prometheus doesn't have concept of Meter (like OTLP does).. Trying to see if this is a good approach to use the meter name as namespace, to avoid name collisions, when same instrument name is used across multiple instruments, from different Meter." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "The formatting of this is a bit strange; I'd suggest collapsing this back to a single line, and moving the `&&` to the beginning of the second line to meet the line length restriction." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "One or the other should be non-NULL. If segments is NULL, the alloc above will have size zero, which we do not allow (there's no header): it should assert in debug build. So there should be asserts that one is non-NULL at the top, and if there really needs to be some kind of defensive check down here, it should cover the alloc too." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "I'm surprised rubocop isn't picking up singe quotes?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "Is this line still needed?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm not sure.", "reference": "Maybe use specific values for all the watt.times fields? Even better, have a const for it at the top of the file?" }, { "prediction": "The braille table file names and information. The table file names and information are located in the `braille-patterns.cti` directory. The file names and information are located in the `braille-patterns.cti` directory. The file names and information are located in the `braille-patterns.cti` directory. The file names and information are located in the `braille-patterns.cti` directory. The file names and information are located in the `braille-patterns.cti` directory. The file names and information are located in the `braille-patterns.cti` directory. The file names and information are located in the `braille-patterns.cti` directory.", "reference": "nit: UNICODE_BRAILLE_TABLE or something might be a better name for this. IMO, braille-patterns.cti is a terrible name. This table allows Unicode braille characters to be used anywhere to produce raw dots." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Why are we removing the option to skip machine pool generation?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "\"Request line\" here too." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure.", "reference": "Please remove this." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "Weird bug. Combining those joins and group calls was triggering AREL to generate the sql cache inside of will_paginate before the final call. This is a harmless workaround, but hints that will_paginate might becoming seriously deprecated." }, { "prediction": "I think this is what you're looking for.", "reference": "This can be simplified as discussed before." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Does `internal` or `test` in the file name actually do anything here? Or is that just to show these functions are only for tests?" }, { "prediction": "I'm not sure if this is what you're looking for, but it should work.", "reference": "does this boolean indicate unsafe serialization?" }, { "prediction": "This is not implemented for node.js. It is not implemented for node.js. It is not implemented for node.js. It is not implemented for node.js. It is not implemented for node.js. It is not implemented for node.js. It is not implemented for node.js. It is not implemented for node.js. It is not implemented for node.js. It is not implemented for node.js. It is not implemented for node.js. It is not implemented for node.js. It is not implemented for node.js. It is not implemented for node.js. It is not implemented for node.js. It is implemented for node.js.", "reference": "Maybe rewrite to `Is only implemented for React Native`? (I assume that is the case)." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "Do we not need this in Java because Java *is* handling map responses?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Maybe \"For configuring which scheduler messages can be received.\"?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "It will stop working with orm, so this is not a good fix, Try using some method in a common interface" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "`s` is not necessarily the same as `sampler` - sampler could be null and this crazy lambda underneath falls back to something. So please use `s`" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "This code is a bit confusing. Should HttpParameterType set to the original one or it is always BODY?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Why did this change?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "nit: `status` collides with imported package named `status`" }, { "prediction": "IsWritingCatchpointFile() returns true when a catchpoint file is being written. If the catchpoint file is being written, it returns false. If the catchpoint file is being written, it returns true. If the catchpoint file is being written, it returns false.", "reference": "\"memory pressure could be decreased\" --> \"to avoid memory pressure\"" }, { "prediction": "I think this is what you are looking for, but it's not what you're looking for. I'm not sure what you're looking for, but it's what you're looking for.", "reference": "I think it would make sense to fetch the cache values after deleting the listens and making sure they are what we expect." }, { "prediction": "I'm not sure if this is a bug, but if it's a bug, it's a bug.", "reference": "I'm thinking about covering this change with the test. Can you do that?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug in the NATPinger library.", "reference": "Not sure if it's a good idea to remove stop channel. If user cancels connection how will you stop pinger?" }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it, so I'm not sure if it's the correct way to do it. I'm not sure if this is the correct way to do it, but I'm not sure if it's the correct way to do it.", "reference": "Could you please add a `TODO` here that we won't need `docker.AuthConfiguration` anymore when we migrate to SDK's pull image?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like it's a bug. I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Is there a scenario were we want to get an arbitrary set of blobs that don't share a common root?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "Can you leave a note about why we are skipping regex tests?" }, { "prediction": "The only error that you can return is that the repo has already been closed. I'm not sure what you're trying to return is that the repo has already been closed, but I'm not sure what you're trying to return is that the repo has already been closed. I'm not sure what you're trying to return is that the repo has already been closed, so I'm not sure what you're trying to return is that the repo has already been closed. I'm not sure what you're trying to return is that the repo has already been closed, but I'm not sure what you're trying to return is that the repo has already been closed, so I'm not sure what you're trying to return is that the repo has already been closed.", "reference": "This was the only caller of CreateRepo, so I inlined it." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "As this is already a child of `auth`, I think we can shorten this to `path`" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case.", "reference": "This call should use element, not 0 I think." }, { "prediction": "I'm not sure if this will work for you, but it should work for you.", "reference": "This is missing the definition of `fetch_until_empty_page` - it needs to go in the config section above." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I don't think this one needs to be changed since the only previous path is already an absolute one." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Since we kept the original constructor we might not need this change now." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "There is already a log in `BaseMetastoreTableOperations` for this. It has the location, but not the table name. Maybe just add table name to that one." }, { "prediction": "I'm not sure if it's a bug, but it's a bug in github.com/dgrijalva/github.com/dgrijalva/github.com/dgrijalva/github.com/dgrijalva/github.com/dgrijalva/github.com/dgrijalva/github.com/dgrijalva/github.com/dgrijalva/github.com/dgrijalva/github.com/dgrijalva/github.com/dgrijalva/github.com/dgrijalva/github.com/dgrijalva/github.com/dgrijalva/github.com/dgrijalva/github.com/dgrijalva/github.com/dgrijalva/github.com/dgrijalva/github.com/dgrijalva/github.com/dgrijalva/github.com/dgrijalva/github.com/dgrijalva/github.com/dgrijalva/github.com/dgri", "reference": "This should be in the last group." }, { "prediction": "I'm not sure if this is a bug or a bug, but it seems to be a bug.", "reference": "I believe you should either remove this or rename the PR. You can't change the behavior of the tracer (even to fix a bug) in a PR named \"unit test improvements\"" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for: https://github.com/munnerz/cert-manager/pkg/apis/certmanager.k8s.io/pkg/apis/certmanager.k8s.io/pkg/apis/certmanager.k8s.io/pkg/apis/certmanager.k8s.io/pkg/apis/certmanager.k8s.io/pkg/apis/certmanager.k8s.io/pkg/apis/certmanager.k8s.io/pkg/apis/certmanager.k8s.io/pkg/apis/certmanager.k8s.io/pkg/apis/certmanager.k8s.io/pkg/apis/certmanager.k8s.io/pkg/apis/certmanager.k8s.io/pkg/apis/certmanager.k8s.io/pkg/apis/certmanager.k8s.io/pkg/apis/certmanager.k8s.io/pkg/apis/certmanager.k8s.io/pkg/apis/cert", "reference": "I've gone with this group name, however I'm open to suggestions on alternatives!" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "should this be GOQUORUM" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "I think checkCoinbase is not skipping checking coinbase. Instead, true-> checking num(coinbase tx) = 1, false -> checking num(coinbase tx) = 0." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "same here, move it out" }, { "prediction": "I'm not sure if it's a bug, but it's a bug in Kokkos. I'm not sure if it's a bug, but it's a bug in Kokkos.", "reference": "Can you elaborate on why you need different behavior depending on Tools being built independently or not?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "because of the above if statement will requires both ex_save and guid_save to be true, this code will always return 'example answer'. This should be revised with `example_answer.present?` and `guidance.present?`" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for \"github.com/stretchr/testify/assert\" + \"golang.org/x/net/context\" \"github.com/sonm-io/core/insonmnia/structs\" \"github.com/sonm-io/core/proto\" \"github.com/sonm-io/core/proto\" \"github.com/sonm-io/core/proto\" \"github.com/sonm-io/core/proto\" \"github.com/sonm-io/core/proto\" \"github.com/sonm-io/core/proto\" \"github.com/sonm-io/core/proto\" \"github.com/sonm-io/core/proto\" \"github.com/sonm-io/core/proto\" \"github.com/sonm-io/core/proto\" \"github.com/sonm-io/core/proto\" \"github.com/sonm-io/core/proto\" \"github.com/sonm-io/core/proto\" \"", "reference": "why not context from stdlib?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Just saw this and wasn't able to hold myself from renaming :-)." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Can we keep the other assertion too? I think it's helpful to ensure that the uninstall function was called too" }, { "prediction": "I think this is a bug in the RSpec.warn_with function.", "reference": "`warn_with` prefixes the message with `WARNING:`, right? So this will put `WARNING:` twice. It would be good to verify all the warnings look good after this change, given how easy it is to make a simple mistake like this :(." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, and it's a bug.", "reference": "FYI In the message queue I use the term \"stamp\" to refer to the time-like mark associated with each message. It's opaque to the queue/pool and should make no difference if the stamps and age limit were converted to seconds. So this could then become `Stamper` with `CurrentStamp()` method, no reference to \"blocks\" or height etc. The wrapper struct could be `StampedMessage. The interpretation as block height is deferred to the user/constructor that hooks things up, the \"business logic\". This is just an observation, take or ignore as you wish." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Can we remove the `TODO` statement here? (as this is actually fixed in this PR)" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "m prefix no longer in code style" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "need to filter the entities in buffer as well" }, { "prediction": "I think this is a bug. It should be fixed in a future release.", "reference": "Please add spaces before and after the equals sign" }, { "prediction": "#include \"common/evl_sqlog_eventnum.h\" #include \"common/evl_sqlog_eventnum.h\" #include \"common/evl_sqlog_eventnum.h\" #include \"common/evl_sqlog_eventnum.h\" #include \"common/evl_sqlog_eventnum.h\" #include \"common/evl_sqlog_eventnum.h\" #include \"common/evl_sqlog_eventnum.h\" #include \"common/evl_sqlog_eventnum.h\" #include \"common/evl_sqlog_eventnum.h\" #include \"common/evl_sqlog_eventnum.h\" #include \"common/evl_sqlog_eventnum.h\" #include \"common/evl_sqlog_eventnum.h\" #include \"common/evl_sqlog_eventnum.h\" #include \"common/evl_sqlog_eventnum.h\" #include \"common/evl_sqlog_eventnum.h\" #include \"common/evl_sqlog_eventnum.h", "reference": "This file could also be cleaned up/deleted. But lets do this separately after ensuring all the event logging has been ported to the current logmxevent_traf.cpp file completely." }, { "prediction": "@RSpec::Core::Formatters it 'produces the expected full output' do output = run_example_specs_with_formatter('failures') expect(output).to eq(<<-EOS.gsub(/^\\s+\\|/, '')) - |./spec/rspec/core/resources/formatter_specs.rb:4:is marked as pending but passes - |./spec/rspec/core/resources/formatter_specs.rb:36:fails - |./spec/rspec/core/resources/formatter_specs.rb:40:fails twice - |./spec/rspec/core/resources/formatter_specs.rb:47:fails with a backtrace that has no file - |./spec/rspec/core/resources/formatter_specs.rb:53:fails with a backtrace containing an erb file - |./spec/rspec/core/resources/formatter_specs.rb:71:raises + |./spec/rspec/core/resources/formatter_specs.rb:4:Expected example to fail since it is pending, but it passed. + |/home/roadster/dev/oss/rspec-core/spec/rspec/core/", "reference": ":thinking:, the line number here is the line of the example (`example.location`), that's probably why I finally chose to display the example title because it's what can be found on this line, and saying that the error is from there is confusing. But presenting the actual failures is indeed better, so maybe we can get the failure actual line number from the exception backtrace and then output two distinct lines for failures like this one?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "We shouldn't add this as a new `kwarg` here. This should all be done on the options class" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Should this be `OS_VOLUME_SUPPORT` to match the symbol key names?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "In C, file scope variables are already initialized to 0 so the \"= NULL\" is redundant. Not a big deal." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure.", "reference": "on line 40, the `relevantNode` can change and therefore the `doc` might change too for the lookup on line 43. I think this code should be moved to where the `doc` is actually being used" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "nit: just to be similar to others, can you change to interpolation?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "Would this make more sense as an option on an Issuer resource (specifically on the CA issuer) rather than as a flag? It's not ideal that we have a flag that _looks_ like it could be 'global' but is actually not IMO. Also, if Istio is reading the CSR object, is it possible for it to read the CA from the CSR itself too and append the two instead? Not sure if we ever decided whether to use annotations for this purpose @JoshVanL?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Because this acts as a coordination point between client and server, it should go in core.py instead of const.py (so eventually the server could use it to guarantee that it delivers dates in the expected format)." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "expected statement, found 'else' (and 1 more errors)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to create a fake TLF ID from a given byte. I'm not sure what you're trying to do here, but I'm guessing you're trying to create a fake TLF ID from a given byte. I'm guessing you're trying to create a fake TLF ID from a given byte, but I'm not sure what you're trying to do here. I'm guessing you're trying to create a fake TLF ID from a byte, but I'm not sure what you're trying to do here. I'm guessing you're trying to create a fake TLF ID from a byte, but I'm not sure what you're trying to do here. I'm guessing you're trying to create a fake TLF ID from a byte, but I'm not sure what you're trying to do here. I'm guessing you're trying to create a fake TLF ID from a byte, but I'm not sure what you're trying to do here.", "reference": "IMO this doesn't need to be in the `kbfs` repo. And I don't like setting the byte. We can always compare with the randomly generated `TlfID`." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this: https://github.com/edgecontroller/edgecontroller/blob/master/src/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller/edgecontroller", "reference": "What's the difference from ModuleName in `pkg/apis/meta/v1alpha1/types.go`?" }, { "prediction": "I'm not sure if I'm using System.Linq, but if I'm using System.Linq, I'm not sure if I'm using System.Linq, or if I'm using System.Linq, or if I'm using System.Linq, or if I'm using System.Linq, or if I'm using System.Linq, I'm using System.Linq, or if I'm using System.Linq, I'm using System.Linq, or if I'm using System.Linq, I'm using System.Linq.Linq, or if I'm using System.Linq, I'm using System.Linq.Linq.Linq, or if I'm using System.Linq, I'm using System.Linq.Linq.Linq.Linq.Linq.Linq.Linq.Linq.Linq.Linq.Linq.Linq.Linq.Linq.L", "reference": "We shouldn't be changing this task as we are trying to break our dependency on it and switch to using the shipped version." }, { "prediction": "This should probably be in arch-specific clean_call_opt.c. If it's in arch-specific clean_call_opt.c, then it should probably be in arch-specific clean_call_opt.c. If it's in arch-specific clean_call_opt.c, then it should probably be in arch-specific clean_call_opt.c. If it's in arch-specific clean_call_opt.c, then it should probably be in arch-specific clean_call_opt.c. If it's in arch-specific clean_call_opt.c, then it should probably be in arch-specific clean_call_opt.c.", "reference": "Shouldn't we have a low bar for generating out-of-line context switch, i.e., if we need save more than n (3?) simd or m (4) gprs we should go out-of-line? And it should be || instead &&. It seems the bar is still very high after this change." }, { "prediction": "This file contains the forwarding implementation of metric.Provider, which is the default implementation of metric.Provider, which is the default implementation of metric.Provider.", "reference": "Should the API have a dependency on the SDK?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this: https://docs.aws.amazon.com/aws/latest/devguide/piping-of-change-streams.html#piping-of-change-streams-when-a-resumable-error-is encountered", "reference": "Is this a sometimes leaky test?" }, { "prediction": "I'm not sure what you're trying to do here, but I think it's a good idea.", "reference": "It should be possible to create a test case that enter the loop. That would be a good enough test case for me. Have a look at the extern type inference test cases that already exist. Since you can just pick the type variables the extern type use, you should be able to create a conflict that requires this loop to fix." }, { "prediction": "I think this is a bug, and it is a bug, and we should fix it.", "reference": "It might make sense to log this." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, and it's a bug.", "reference": "Line is too long. [84/80]" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like \"goog:chromeOptions\" instead of \"goog:chromeOptions\"", "reference": "nice touch since Google likes to change things every now and then." }, { "prediction": "This is a helper utility for loading branding configs. It can be used to load branding configs from a YAML file.", "reference": "Thank you this is so much nicer than the old `Rails.configuration.branding['blah']['blah']['blah']` :)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "nit: Would you mind alpha-sorting this?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this, and I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "For my understanding, the DATA manifest & DELETE manifest could share the same read / write path so I think we could use the common reader+writer. Is there any other reason that we need to make them separate paths?" }, { "prediction": "I think this is a bug in Rails. I'm not sure if it's a bug in Rails, but it's a bug in Rails. I'm not sure if it's a bug in Rails. I think it's a bug in Rails. I'm guessing it's a bug in Rails. I'm not sure if it's a bug in Rails.", "reference": "that change should be sufficient for avoiding the override of contact_us_url helper. The one defined at the.yml it is within a hash so no problem should arise." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "We actually had a discussion about this exactly in #3470, some languages seem to go for one, some for the other" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "Is PHP the first dynamic MVVM language with grpc streaming support?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "the `if` isn't necessary here; it's safe to call `delete` on `nullptr`" }, { "prediction": "I think this is a bug. It should be fixed in the future.", "reference": "Change if the method's name finally changes to `clear_history` as proposed elsewhere" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "can this one also be moved to the top of the file?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "So if I understand this correctly the externalEntities should be computed and stored in GroupMember, while current code usage of GroupMemberPod will be migrated to GroupMember later?" }, { "prediction": "I'm not sure if I'm missing something, but I'm not sure if I'm missing something.", "reference": "Don't we have tests to change after this breaking change? probably we're not using hard coded strings in our tests when we create a `Span`?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "will this fail if the env variable doesn't exist? Is this the preferred behaviour?" }, { "prediction": "This is a tiny random tie breaker. This is used to determine winning # columns where the overlaps are identical. - self._tieBreaker = 0.01*numpy.array([self._random.getReal64() for i in - xrange(self._numColumns)]) + self._tieBreaker = numpy.array([0.01 * self._random.getReal64() for i in + xrange(self._numColumns)], + dtype=realDType) #'self._connectedSynapses' is a similar matrix to'self._permanences' # (rows represent cortical columns, columns represent input bits) # (rows represent input bits, columns represent output bits)", "reference": "bad line wrap" }, { "prediction": "I'm not sure if this is a bug, but I think it should be fixed.", "reference": "What does the `8` here represent? Can you give it a name?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "`MPRester(os.environ[\"MP_API_KEY\"])` can be left simply as `MPRester()` and it will pick up the API key from the environment. What is the purpose of this file otherwise? Is it better suited for `dev_scripts`, or a test?" }, { "prediction": "It's strongly recommended to check this file into your version control system. -ActiveRecord::Schema.define(:version => 20121114193521) do create_table \"announcements\", :force => true do create_table \"announcements\", :force => true do create_table \"announcements\", :force => true do create_table \"announcements\", :force => true do create_table \"announcements\", :force => true do create_table \"announcements\", :force => true do create_table \"announcements\", :force => true do create_table \"announcements\", :force => true do create_table \"announcements\", :force => true do create_table \"announcements\", :force => true do create_table \"announcements\", :force => true do create_table \"announcements\", :force => true do create_table \"announcements\", :force => true do create_table \"announcements\", :force => true do create_table \"announcements\", :force => true do create_table \"announcements\", :force => true do create_table \"announcements\", :force => true do create", "reference": "Looks like there may be more changes to this file than intended?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "when message type is not expected, contine to next loop instead of return to finish infinite loop" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing you're looking for something like \"fileutil\" or \"fileutil/fileutil\" or \"fileutil/fileutil/fileutil\" or \"fileutil/fileutil/fileutil\" or \"fileutil/fileutil/fileutil\" or \"fileutil/fileutil\" or \"fileutil/fileutil/fileutil\" or \"fileutil/fileutil/fileutil\" or \"fileutil/fileutil\" or \"fileutil/fileutil\" or \"fileutil/fileutil\"", "reference": "This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "instanceID should stay the same for a AWSMachine?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Since this is a dict don't you want `False` or do we clean that up elsewhere?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "what's the reason you had to add the `host` argument to all `get_work` calls?" }, { "prediction": "I'm not sure if this will work, but I'm not sure if it will.", "reference": "This will never be a dataset so we can simplify the code here" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "This should be moved into the PrivacyBlockProcessor instead of adding the constructor here." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for \"github.com/pipe-cd/pipe/pkg/insight\" instead of \"github.com/pipe-cd/pipe/pkg/insight/insightstore\" \"github.com/pipe-cd/pipe/pkg/insight/insightstore\" \"github.com/pipe-cd/pipe/pkg/insight/insightstore\" \"github.com/pipe-cd/pipe/pkg/insight/insightstore\" \"github.com/pipe-cd/pipe/pkg/insight/insightstore\" \"github.com/pipe-cd/pipe/pkg/insight/insightstore\" \"github.com/pipe-cd/pipe/pkg/insight/insightstore\" \"github.com/pipe-cd/pipe/pkg/insight/insightstore\" \"github.com/pipe-cd/pipe/pkg/insight/insightstore\" \"github.com/pipe-cd/pipe/pkg/insight/insightstore\" \"github.com/pipe-cd/pipe/pkg/", "reference": "nit: Remove \"insightfilestore\". I think \"insightstore\" is good enough and as I see we are using that name at other places too." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "It looks like you've removed `bisect_round_finished` but kept `bisect_round_started`. Seems a little odd that they aren't paired. Not sure if there's anything to do about that though..." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "I'm not sure how to fix the lint and mypy warnings on this line. I could just ignore them, but I feel like the linter should know this exists." }, { "prediction": "@ -1,7 +1,7 @@ 'use strict'; const Aspect = { - SKIP_SESSION: Symbol('SKIP_SESSION') + SKIP_SESSION: 'SKIP_SESSION' };", "reference": "why remove `Symbol`?" }, { "prediction": "I'm not sure what you're trying to do, but it seems to be a bug.", "reference": "Why are currency signs considered punctuation? They technically fall under the BMP range for Currency Symbols `\\u20A0-\\u20CF` (covered in `getUnicodeNonBmpRegExp`, which is itself a misnomer)" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "You have forgotten a coma `,`" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "For different datasets, we may want to save the images differently. Sometimes the datasets are categorized into several subfolders, and we want to keep it when saving visualization results, and sometimes we just want to save all images in `out_dir`. An argument may be added to control the behavior." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "if `other` could have a guaranteed `0` byte in it, this whole `if` could be removed, and above you could just add `|| c2 == '\\0'` to get the same effect?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "nit: can this be a primitive value?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure.", "reference": "This maybe not what we want. If `rewrite` occurred before, `r.URL.Path` contains the result and we should use it. Otherwise `rewrite` middleware will disfunction when combining with `browser`." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Why change this?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "_nitpick_ Isn't it now actually NotLogFakeHttpExceptions**Error**Listener?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Why not just look for the \"type\" property instead of creating a ResourceType property?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug.", "reference": "should use `bc.config.Blockchain.ChainID`" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "this doesn't need to know about NativeClient" }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this:", "reference": "I know we discussed if we should add in the resource_name to the hash, and I actually don't think it's required. The violation hash was recently updated (not released) to include the violated rule, so when the next release goes out, user's findings will get updated. The resource name doesn't hurt to have here, but not required." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "The variable name is also misleading imo. The width from the buffer comes from `wl_shm_buffer_get_width` (or a similar EGL thing), which is what gets encoded into `surface->texture->width`." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Why are you using these tags to carry these msids?" }, { "prediction": "I think this is a bug in flb_sds_init.", "reference": "flb_strdup() should do the work here. note: use Fluent Bit memory wrappers" }, { "prediction": "I think this is a bug in the Gogo/protobuf/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/go/", "reference": "This line should be separated from the package declaration by one line as it is not the package description." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this.", "reference": "shadow: declaration of \"err\" shadows declaration at line 410 (from `govet`)" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "Maybe next time better to make separate PR?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if it's what you're trying to do, but I think it's what you're trying to do.", "reference": "line 316 also handles this case, need to simplify the logic." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this.", "reference": "We used to have a simple check for bucket and object names, we then decided to remove it and rely on the backend service to check for the name. Is there any reason to add an empty name check now?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this. I'm not sure what you're trying to do, but I think you're trying to do something like this.", "reference": "Line too long" }, { "prediction": "I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "This isn't aligned though." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "it is mean -> it means PAAHead does not support test-time augmentation." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "@lnielsen-cern thanks. I missed it :(" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "@tofumatt, has it been changed intentionally? It doesn't seem to be required in IB, plus we haven't had `content-drilldown` before... If it has been changed intentionally, then should we update the `AnalyticsDashboardWidget` component to be use `content-drilldown` instead of `content-pages` as well?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be fixed in the latest version.", "reference": "nit: don't think an extra line is needed here; as retrying is an installed library and should be grouped with the rest of the installed library." }, { "prediction": "I think this is a bug in Prometheus.io/docs/prometheus/latest/querying/api/#tsdb-admin-apis. This should be fixed in Prometheus.io/docs/prometheus/latest/querying/api/#tsdb-admin-apis. This should be fixed in Prometheus.io/docs/prometheus/latest/querying/api/#tsdb-admin-apis. This should be fixed in Prometheus.io/docs/prometheus/latest/querying/api/#tsdb-admin-apis. This should be fixed in Prometheus.io/docs/prometheus/latest/querying/api/#tsdb-admin-apis. This should be fixed in Prometheus.io/docs/prometheus/latest/querying/api/#tsdb-admin-apis. This should be fixed in Prometheus.io/docs/prometheus/latest/querying/api/#tsdb-admin-apis. This should be fixed in Prometheus.io/docs/prometheus/latest/querying/api/#tsdb-admin-apis. This should be fixed in Prometheus.io/docs/prometheus/latest/querying/api", "reference": "This should be a bool" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "`if (llvm::dyn_cast_or_null(GetSwiftType(compiler_type).getPointer())`?" }, { "prediction": "I'm not sure this is a bug, but it's fixed in the latest release.", "reference": "The `generateVariantWorkloadManifests` function below relies on the config manifests specified in Git, but it was passed with the newly created canary's manifests where their name was updated." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "are this docs neccesary?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "This change suppose to resolve issue #2968. `loss_weight` should be of length 2, the second entry is ignored." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Is there an easy way to check for conflict suffix to avoid false positives here?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "`apply_prep.run_task` also seems like it can just use `@context.run_task`" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "do you have any idea on how to fix it?" }, { "prediction": "@GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCSBaseTestCase, @GCS", "reference": "You don't need to fix this (you've done so many iterations). But for next time, you can make this into a docstring so it'll have a nicer descriptive name when the tests are running." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "When does 'expiresAt' change? Do you need this?" }, { "prediction": "Is there a way to get outfitByLookType(uint16_t lookType) in this case? I'm not sure if there is a way to get outfitByLookType(uint16_t lookType) in this case.", "reference": "There are enums for genders + `PLAYERSEX_LAST`." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "Should this use the constants as well? Or intentionally covering the fact that the constants may change" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for the __len__ method. If you're looking for the __len__ method, you'll need to return self.extras.len() + len(self.best) + len(self.extras) + len(self.extras) + len(self.best) + len(self.extras) + len(self.best) + len(self.extras) + len(self.best) + len(self.extras) + len(self.extras) + len(self.best) + len(self.extras) + len(self.best) + len(self.extras) + len(self.best) + len(self.extras) + len(self.best) + len(self.extras) + len(self.best) + len(self.extras) + len(self.best) + len(self.extras) + len(self.best) + len(self.extras) + len(self.best) + len(self.extras) + len(self.best) + len(self.extras) + len(self.", "reference": "The case of a negative size (= keep all elements) was not handled in this function." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "I think we should keep this dynamic config knob for operations purpose." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "Was this intentional? Perhaps this could be replaced with another way to check the offsets?" }, { "prediction": "I'm not sure if this is the case, but if it's the case, then it's probably the case, but I'm not sure.", "reference": "the buckets are created via the stackset, customers don't need to provide them" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "This doesn't have the same behavior as before. Maybe you want `reverse_merge` (and it either just works or we implement it on `Blacklight::Solr::Request`)" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "This should be ` /$(ghc_find #{config[:ghc]})/ ` instead of ` /#{ghc_version}/ `, I think." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "We should deprecate this at some point." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's the case, it might be better to use the `conv_cfg` argument instead of `conv_cfg` (or `conv_cfg` if you want to use `conv_cfg` instead of `conv_cfg` (or `conv_cfg` if you want to use `conv_cfg` instead of `conv_cfg`), or `conv_cfg` if you want to use `conv_cfg` instead of `conv_cfg` (or `conv_cfg` if you want to use `conv_cfg` instead of `conv_cfg`), or `conv_cfg` if you want to use `conv_cfg` instead of `conv_cfg` (or `conv_cfg` instead of `conv_cfg`), or `conv_cfg` instead of `conv_cfg` (or `conv_cfg` if you want to use `conv_cfg` instead of `conv_cfg` instead of `conv_cfg`), or `conv_cfg` instead of `conv_cfg` (or `conv_cfg` instead of `conv_cfg` and `conv_", "reference": "Move these two arguments before `loss_cls`." }, { "prediction": "I'm not sure why you're getting this error, but I'm not sure why you're getting this error, but I'm not sure why you're getting this error, so I'm not sure why you're getting this error.", "reference": "[Super NIT]: i := serialNumber if i == 0 { i = mathrand.Int63n(...) }" }, { "prediction": "The tool format of the input file is not supported by the Sarif compiler. It should be supported by the Sarif compiler. See https://docs.microsoft.com/en-us/sarif/sarif/sarif/sarif_tool_format_for_the_tool_format_for_the_tool_format_of_the_input_file.", "reference": "-f short form here collided with --force. :)" }, { "prediction": "I'm not sure what you're trying to do here, but it should work.", "reference": "I think it is better to describe in the release note that `rerender()` was removed." }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "We could also test this easily with `runpy.run_module`, what do you think?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Is it OK to fall through if it's not assignable? I was kind of surprised when the tests passed. Maybe one of the options below ends up working? For the new tests, this panics because `**not assignable uuid.UUID to []uint8**`. `uuid.UUID` is an array, not a slice." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I know this is after the fact but imo blockAPI should be blockMiningAPI." }, { "prediction": "I'm not sure what you're trying to do here, but I'm assuming you're trying to do something like this, and I'm not sure what you're trying to do here, so I'm assuming you're trying to do something like this, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "it's just a pattern as it was. SystemAttributeCode should have it's own definition and validate by it" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Similar to the code block when we use prefix, maybe we can unify them to base?" }, { "prediction": "I think this is a bug in the PodChaos scheduler. It should be fixed in the spec.Scheduler.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.Cron.", "reference": "I think `Duration` is useful for this action and we shouldn't ignore it." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Everything below here can be replaced with `return s.err, len(p) - len(s.dataForWriting)`." }, { "prediction": "I don't think it's a bug, but it's a bug.", "reference": "Again, we can also guard `g_host_hip_lock_arrays.atomic`, can't we?" }, { "prediction": "I'm not sure if this is what you're looking for, but if it's what you're looking for, you can do something like this: $this->commandBus->dispatch(new ImportProductAttributesValueCommand( $command->getId(), $command->getImportId(), $attributesToRedispatch, $command->getSku() - $this->getSku() - $this->getSku() - $this->getSku() )); + ); + $this->commandBus->dispatch($ImportProductAttributesValueCommand, true); } $this->repository->markLineAsSuccess($command->getId(), $product->getId());", "reference": "Variable name should start from lowercase latter" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'll try to fix it.", "reference": "Why has this timeout doubled?" }, { "prediction": "IptablesRefreshInterval time.Duration `config:\"seconds;30\"` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `` `` `` `` `` `` ````````````````````````````````````````````", "reference": "Should IptablesPostWriteCheckIntervalSecs be set back to its previous smaller value, if use of the iptables lock is disabled?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "You're missing a `return` here, but I'll add it :smile:" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's what you're trying to do. I'm not sure if this is what you're trying to do, but it's what you're trying to do.", "reference": "Can you try adding back this assertion? I'd like to assert that the texture has been created in the same context as the renderer." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "This won't work with Python 3 because it will already be a string. In that case we need to use `decode_header` from utils." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Why is the respond_to check here?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "@orklah are you sure it's the same as `$chars[$i]`? It looks like `$i` is changed above, after `$char` assignment." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "I have a question? How do I construct a indexManager for testcase?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "These checks aren't needed. See pluginmgr.c : opae_plugin_mgr_load_dflt_plugins( )." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Please take a care about prefixing." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "this line doesn't match what the rest says" }, { "prediction": "The \"MysteriumNetwork/node\" Authors are not the same as the \"MysteriumNetwork/node\" Authors. The \"MysteriumNetwork/node\" Authors are the same as the \"MysteriumNetwork/node\" Authors. The \"MysteriumNetwork/node\" Authors are the same as the \"MysteriumNetwork/node\" Authors. The \"MysteriumNetwork/node\" Authors are the same as the \"MysteriumNetwork/node\" Authors.", "reference": "Since it's not working for linux, maybe leave the!linux in there as well?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Should we remove the key-value pair entirely? Same for workflows in general. We have a \"sourceExists\" method that checks if a key is there if I remember correctly." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "Unrelated bug fix" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "We probably want to let the translation library handle the string replacement for these as well." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "should combine these 2 list (list_gossip and list_db) into just one list command, and show the discrepancy between the 2 if any." }, { "prediction": "@proposal.approved? end + def approve_reject? + actionable_approvers = @proposal.currently_awaiting_approvers + actionable_approvers.include? @user + end + def edit? self.test_all(:edit?) end", "reference": "What do you think about prefixing the Policy method names with `can_`?" }, { "prediction": "#include #include #define ECS_CREDENTIALS_HOST \"169.254.170.2\" #define ECS_CREDENTIALS_HOST_LEN 13 #define ECS_CREDENTIALS_HOST \"169.254.170.2\" #define ECS_CREDENTIALS_HOST_LEN 13 #define ECS_CREDENTIALS_HOST \"169.254.170.2\" #define ECS_CREDENTIALS_HOST \"169.254.170.2\" #define ECS_CREDENTIALS_HOST \"169.254.170.2\" #define ECS_CREDENTIALS_HOST_LEN 13 #define ECS_CREDENTIALS_HOST \"169.254.170.2\" #define ECS_CREDENTIALS_HOST \"169.254.170.2\" #define ECS_CREDENTIALS_HOST \"169.254.170.2\" #define ECS_CREDENTIALS_HOST_LEN 13 #define ECS_CREDENTIALS_HOST \"169.254.170.2\" #define ECS_CREDENTIALS_HOST \"169.254.170.2\" #define ECS_CREDENTIALS_HOST \"169.254.170.2\" #define", "reference": "Based on the docs, credential process can return a key `SessionToken`" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "I think this if should be removed (see issue)" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for \"github.com/sirupsen/logrus\" + \"github.com/projectcalico/libcalico-go/lib/set\" \"github.com/projectcalico/libcalico-go/lib/set\" \"github.com/projectcalico/libcalico-go/lib/set\" \"github.com/projectcalico/libcalico-go/lib/set\" \"github.com/projectcalico/libcalico-go/lib/set\" \"github.com/projectcalico/libcalico-go/lib/set\" \"github.com/projectcalico/libcalico-go/lib/set\" \"github.com/projectcalico/libcalico-go/lib/set\" \"github.com/projectcalico/libcalico-go/lib/set\" \"github.com/projectcalico/libcalico-go/lib/set\" \"github.com/projectcalico/libcalico-go/lib/set\" \"github.com/projectcal", "reference": "I would avoid importing `felix/ipsets` package because this package is the windows equivalent and should be at the same level of `felix/ipsets`. We could add linux specific dependencies into `felix/ipsets` later and it will break Windows build." }, { "prediction": "If you want to do this, see and and .", "reference": "nitpick: Please move this down to the other imports, as it's a Python stdlib import." }, { "prediction": "It's not a \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \"", "reference": "\"for getting started guides\" reads a bit weird, like it's missing punctuation. Maybe just \"for a tutorial\"?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "This looks like a dead parameter -- maybe a copy and paste error. If it's truly unused, maybe you can open a separate PR to simply delete it, and then it's one less detail to worry about here." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Nit: Should we add support for `int` and `uint` in the `values.New()` function? That would allow us to to handle all of these types in one case. Maybe there's a good reason why we don't do that already, but I'm not sure what it is." }, { "prediction": "I think this is a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug.", "reference": "if you are not dealing with cache now, please revert these changes. On their own they make little sense" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Wearing my extra-douche-bag hat I would say not spaces on a blank line. Maybe at some point we could have some automated process remove these things. For now I would not bother changing it." }, { "prediction": "I'm not sure if this is what you are looking for, but it seems like you're looking for something like this:", "reference": "I think it would be better to use an `ItemUpdatedEvent` like for the \"prefer streaming\" preference. We already have a ton of events that need to be handled in all list fragments that just do the same everywhere. I think we could even remove some of the existing events in the future." }, { "prediction": "I think this is what you're looking for.", "reference": "I think we have to manually write a down for this migration." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "I don't think we still need this check, but I'd leave it as an assertion for now." }, { "prediction": "I think this is what you're looking for. I'm not sure if this is what you're looking for, but it might be useful to you.", "reference": "Since this may be the case, wondering if we should call the param `updated_at_i` or something so that we don't run into a problem distinguishing them down the road?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "wondering why we need to join the paths here; seems evt.commandLine only takes whatever appExe is" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "1.not format code 2.failed but still continue? 3.\"UTF-8\" can changed to java.nio.charset.StandardCharsets.UTF_8.name()" }, { "prediction": "I'm not sure if it's a bug, but it's a bug in pylint.checkers.utils.py. It's a bug in pylint.checkers.utils.py. It's a bug in pylint.checkers.utils.py. It's a bug in pylint.checkers.utils.py. It's a bug in pylint.checkers.utils.py. It's a bug in pylint.checkers.utils.py. It's a bug in pylint.checkers.utils.py. It's a bug in pylint.checkers.utils.py. It's a bug in pylint.checkers.utils.py. It's a bug in pylint.checkers.utils.py. It's a bug in pylint.checkers.utils.py. It's a bug in pylint.checkers.utils.py. It's a bug in pylint.checkers.utils.py. It's a bug in pylint.checkers.utils.py. It's a bug in pylint.checkers.utils.py. It's a bug in pylint.checkers.utils.py.", "reference": "I'm wondering if we should add this to a `utils` module in `astroid`. Porting the util to `pylint` doesn't make sense as we would need to duplicate the globals that are being used in the function, but importing from `brain` also feels weird. @Pierre-Sassoulas Do you have an opinion?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "This seems different than what we do for corrupted request headers. I would like to determine the correct behavior and consolidate this logic." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Please make the change in the CAI inventory, rather than changing the scanner." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug. I'm not sure if it's a bug, but I'm sure it's a bug.", "reference": "adding this `abstract` is a breaking API change. Even though I agree it makes perfect sense to have it, we can't break this API until PMD 7.0.0. We should revert this particular change. We could make a reminder ticket like we did with #463 for 6.0.0" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "This is following the existing convention, but I'm not sure the convention is a good one. I think it would be better to have one shared example group: - It means we don't need to add new example groups twice every time. - If the shared example group looks large, that makes it more obvious that our team models have too much shared behavior. I don't want to do anything about this right now (I'm pretty sure I can wipe out this shared example group when I change team plans), but it's good to keep in mind." }, { "prediction": "I don't think it's a bug, but it's a bug.", "reference": "I do not think we need to do a source code change to handle this. We could set the subnetwork to default to /32 (/128 for ipv6 ipv4-mapped)" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "It looks good overall! The only issue I have is that the description string is now duplicated twice right? Once in the struct and once in the parameter string? Maybe let's pass the struct to the command so that `ostree_option_context_parse` can set it as the summary? Similar to what we do in rpm-ostree." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "This states very clearly that this is a derivative of Chrome and not Chromium. Do we need to extract an abstract `ChromiumCommandExecutor` and have both Edge and Chrome derive from that?" }, { "prediction": "I'm not sure if it's an enum or an explicit enum. I'm not sure if it's an enum or an explicit enum. I'm not sure if it's an enum or an explicit enum. I'm not sure if it's an enum or an explicit enum. I'm not sure if it's an enum or an explicit enum. I'm not sure if it's an enum or an explicit enum. I'm not sure if it's an enum or an explicit enum. I'm not sure if it's an enum or an explicit enum. I'm not sure if it's an enum or an explicit enum. If it's an enum, I'm not sure if it's an enum, but I'm not sure if it's an enum or an explicit enum.", "reference": "it seems to me, the issue lies on `isEnum()` itself, returning false for something that is an enum. I'd rather change it there than here." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Please use `{}` instead of `dict()`" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, and it's fixed in the latest version.", "reference": "I have concerns about using this in more places before #3278 - I'll take a look at that again shortly." }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "new field needs to be asserted" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems to be a bug.", "reference": "when send log failed, why update the last sent log id?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "what was the problem with the previous order? `prepend` comes conceptually before `append`, i.e. `insert before` should be before `insert after`, I think" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "Why is this necessary? Could you provide some context?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Is there a recommended quote style for attributes? I see single and double here, double further down." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Please use an atomic bool." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "Consider naming this class `SpanExtensions` to follow C# conventions." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "FYI @lucaspimentel and @colin-higgins since you have already approved, I wanted to point out this required change. By fixing `FrameworkDescription` to use the correct logger, it created a cycle between these two static constructors, so I'm removing this log line and delaying it to when it's actually constructed later in the Tracer. Let me know if you find that acceptable or have any suggestions." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if this is a bug or a bug, but I'm guessing it's a bug.", "reference": "Ah, so we are going to need to update node/host files for this to work?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I'm sure it's what you're looking for.", "reference": "This code is new and not tested well. While we may drop the log level before we ship 4.0, right now this is extremely helpful to users." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "used named path (`proposals_path`) instead?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "Am I misreading something, or is there a mismatched parenthesis here? Please let me know whether or not this is cause for concern -- just wanted to be totally sure before merging, since I can't test this from here. Thanks!" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "Might we want a hook to allow emitting metrics or logs in the case of a permitted empty service header response (or similar UpdateSpanWithErr on empty service header in response if strict enforcement is desired by the caller)?" }, { "prediction": "I'm not sure if this is the correct way to do it, but it's the correct way to do it.", "reference": "if using dict.get, this could just be `kwargs.get('protocol', 'https')`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Add docs to the new methods here" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "what does it mean enabled?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Getting an error when calling with db.execSQL (in sqlcipher 4.3.0, pragma returns ok)." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "Maybe we could remove `\" \" + ctx.Tr(\"dashboard\")` completely?" }, { "prediction": "I think this is what you are looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Simple Storage **Service**" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this.", "reference": "Let's add some assertions here to ensure we don't panic. Length of results. Conditionally cast second result to error." }, { "prediction": "The TimeSpan.FromSeconds(30) is the default value of the TimeSpan.FromSeconds(30). This is the default value of the TimeSpan.FromSeconds(30).", "reference": "Where did we take this default from?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Let's move these down to be after all required arguments rather than in between." }, { "prediction": "I'm not sure what you're trying to do here, but I think it's a good idea to use a shared string map. I'm not sure if this is what you're trying to do here, but it's a good idea to use a shared string map. I'm not sure if this is what you're trying to do here, but it's a good idea to use a shared string map.", "reference": "Should we just null the Map and let the GC handle the memory? Clearing just removes items, but not capacity, so this would leave some memory on the table." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "did you mean to delete this line?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if it's the correct way to do it, so I'm not sure if it's the correct way to do it.", "reference": "Should we use logger instead?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here.", "reference": "I think it would be preferred to do `expect(helper).to be_analytics`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Actually, I think it's okay to just change to `if isinstance(key, (str)) or is_list_like(key):` and `key = list(key) if is_list_like(key) else key` for simplicity for now." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this should work.", "reference": "If there any other tests, I would make it optional there also." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This can be removed too, right?" }, { "prediction": "I'm not sure if this is the right way to do it, but I think it's the right way to do it.", "reference": "If you're going to allow people to specify multiple SMTP servers, you should also properly export/import them." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm correct, or if I'm correct, I'm wrong.", "reference": "nit: Can we prefix these variables with `AspNetCore`?" }, { "prediction": "I'm not sure if it's the same, but I'm not sure if it's the same, but I'm not sure if it's the same, so I'm not sure if it's the same, but I'm not sure if it's the same, so I'm not sure if it's the same, but I'm not sure if it's the same.", "reference": "Can this also include a quick test for transpiling by name?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "This TODO can be removed" }, { "prediction": "I'm not sure if I'm missing something, but I'm not sure if I'm missing something, but I'm not sure if I'm missing something.", "reference": "can we make tabAccessibilityIdentifier = null as default?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "Should we print this error?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "For which reason do we need to convert this to int here?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "FWIW, wondering if the error is interesting here (I actually arrived at this code initially to change `supportsFreezer()` to return a `bool`" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Does this still need to be a partial? is the intention down the line to move back towards a conditionally different title?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "seems like `RegistryURL` is missing? Same for a few other places that create `archer.Environment` below." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Are these imports needed?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "I think you can remove the `(isIE11? it.skip : it)(` above, if you're going to skip the test this way." }, { "prediction": "I'm not sure if this is the case, but I think it's the case, but I think it's the case.", "reference": "IMO we should instead fix the above call to do `long actualChecksumIn = Long.reverseBytes(in.readLong());` to get the actual checksum value? This way the below error message would also be correct?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure.", "reference": "I think we also need something similar for `rebuild-index`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but it's what you're looking for.", "reference": "I think convention is snake case for import naming?" }, { "prediction": "I'm not sure if this is the case, but if it's the case, it's the case, it's the case.", "reference": "i think haspk is false?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "you should add this to the cover command too (but let's have a more general convo about whether it's a flag or config option)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "instead of passing in pointer to empty struct, we should make it optional and support passing nil and use default cfg if it is nil." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "A fair bit faster, although still not great, hence also adding a hashkey." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "If we're going to leave this in here, how about we at least pull it into partial?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "This `context` is used correctly, there is nothing left TO DO." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "If `docs` is an empty array there will be an error" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "Is it really necessary to have the user specify this, or can the reverse proxy infer QUIC from the upstream's Alt-Svc headers?" }, { "prediction": "TheoryData is an array of strings. You can use this array to skip the tests.", "reference": "just remove the entire variable." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Maybe we should put that in the option description?" }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it, so I'm not sure if this is the correct way to do it, but I'm sure it's the correct way to do it.", "reference": "Why do we need to make this optional? Isn't the idea of the builder that if you don't need this value you just don't call the `keyFilePath ` method?" }, { "prediction": "I think this is a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug.", "reference": "Shall we do the same for ORC and Avro?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Should be a space between line" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "if not behind interface then equally we can use SecureRandom.GetBytes directly, otherwise let us push it behind ISecureRandom so we can test with this class wherever used" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Probably will undo this change for now, as I'm just targeting Weekly Iteration in this PR." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Unused parameter warning? How comes we did not catch that before? In any case please open another PR for this." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "I recommend move all openimage related logic to a new function" }, { "prediction": "I'm not sure if this is an externally passed cgroup or a parent cgroup or a parent cgroup. I'm not sure if this is an externally passed cgroup or a parent cgroup, but I'm not sure if this is an externally passed cgroup or a parent cgroup or a parent cgroup or a parent cgroup.", "reference": "We shouldn't have a bool for this. If there is a path passed, then we use it. Resource may or may not be empty." }, { "prediction": "@section_teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.teacher.", "reference": "I like how you used the count on the translate call to handle this." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Do we need to do this from the outside, or is there a spot in the handler code where we can do this automatically? (I haven't studied it closely yet... just wondering if you've already thought it through or if it's worth taking a closer look)." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "[Checkstyle] INFO: Using the '._' form of import should be avoided - java.util._." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "So, why everything is in memory but the permission backend?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Are you sure it should be null and not an empty List?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it is a bug.", "reference": "Unfortunately I think the assumption of \"empty\" means the default dependency section is not correct. For a project.json file the default dependencies section is a shared section between all the different target frameworks and our TargetGroup being empty may map to many different target frameworks so they aren't really equated." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "This test was verifying the wrong thing." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "pls pr a name change fro muon here too separately." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "nit: we can use `defer opts.spinner.Stop(\"Error!\")` after l.180 to make it slightly neater" }, { "prediction": "I'm not sure if this is the case, but it's the case, but it's the case.", "reference": "This is declared in the wrong block" }, { "prediction": "I think this is a bug, but it's a bug.", "reference": "In fact it would be useful for debug, i prefer combine them into one debug level log." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "We would need to localize them eventually too, just FYI" }, { "prediction": "I don't think this is a bug, but it should be fixed.", "reference": "It looks like the proto code needs to change the function name from set_name to set_type to be consistent." }, { "prediction": "You may not use this file except in compliance with the Apache License, Version 2.0 (the \"License\"). You may or may not use this file except in compliance with the License. A copy of the License is located at +// +// http://aws.amazon.com/apache2.0/ +// or in the \"license\" file accompanying this file.", "reference": "I think we can avoid using this pattern for this use case." }, { "prediction": "#include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include slot.getSession() == null && slot.isSupporting(caps)); } public boolean hasCapacity(Capabilities caps) { return slots.stream().anyMatch(slot -> slot.getSession() == null && slot.isSupporting(caps)); } public boolean hasCapacity(Capabilities caps) { return slots.stream().anyMatch(slot -> slot.getSession() == null && slot.isSupporting(caps)); } public boolean hasCapacity(Capabilities caps) { return slots.stream().anyMatch(slot -> slot.getSession() == null && slot.isSupporting(caps)); } public boolean hasCapacity(Capabilities caps) { return slots.stream().filter(slot -> slot.getSession()!= null).count() < maxSessionCount + 1 && slots.stream().anyMatch(slot -> slot.getSession() == null && slot.isSupporting(caps)); }", "reference": "Nit: put the `&&` on the previous line so that a reader knows that there's more to the statement at a casual glance." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Technically the \"right\" variables to use would be the ones in `libgit/autogit_node_wrappers.go\", which define how the tlf types map to subdirs for autogit specifically. (They would have to be exported.) But this is fine too I guess, just a little dirtier." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Should there be a template or something associated with this email? Right now it's identical to `notification_for_approver`" }, { "prediction": "Doctrine\\ORM\\EntityManager::createQueryBuilder() ->select('s') ->from(SliderItem::class,'s') ->where('s.domainId = :selectedDomainId') ->where('s.domainId = :selectedDomainId') ->where('s.domainId = :selectedDomainId') ->createQueryBuilder() ->select('s') ->from(SliderItem::class,'s') ->where('s.domainId = :selectedDomainId') ->where('s.domainId = :selectedDomainId') ->where('s.domainId = :selectedDomainId') ->where('s.domainId = :selectedDomainId') ->where('s.domainId = :selectedDomainId') ->where('s.domainId = :selectedDomainId') ->where('s.domainId = :selectedDomainId') ->where('s.domainId = :selectedDomainId') ->where('s.domainId = :selectedDomainId') ->where('s.domainId = :selectedDomainId') ->where('s.domainId = :selectedDomainId') ->where('s.domainId = :selectedDomainId') ->where('s.domainId = :selectedDomainId')", "reference": "i hope there is some extension in phpstan for this" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's a good idea to check if it's", "reference": "We don't store empty dictionary entries anymore: they bring no benefits, only trouble." }, { "prediction": "IsEnum(Type& type) const? If so, is it possible to avoid this? If so, is it possible to avoid this? If so, how?", "reference": "Optional: This function is C++ specific and could be declared as `static`." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "we can't remove functions as that would introduce backward compatibility issues in our java client. So we should also have a function with the original arguments: ` public Roles getRoles(String domainName, Boolean members) { return getRoles(domainName, members, null, null); } ` For the Go client we don't have a wrapper so no option but to update your client code as necessary, but for java we have the wrapper thus we always maintain backward compatibility" }, { "prediction": "I think this is a bug in the RSpec.configuration.deprecation_io.puts method. It should be removed from the `RSpec.configuration.deprecation_io.puts` method.", "reference": "I'd recommend keeping this in `warn_deprecation` and not adding an override of `warn`." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to run `node_modules` in the same directory as `node_modules` and `node_modules` in the same directory as `node_modules` and `node_modules` in the same directory as `node_modules` and `node_modules` in the same directory as `node_modules` and `node_modules` in the same directory as `node_modules` and `node_modules` in the same directory as `node_modules` and `node_modules` in the same directory as `node_modules` and `node_modules` in the same directory as `node_modules`", "reference": "I think we should use a `blitz` bin instead" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Why not make the ``derived_vdims`` flag (or similar, ``validate_vdims`` maybe?) an explicit argument to ``validate``?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "was it not possible to do this at the filter or porx driver layer? We typically try to avoid driver-specific things in the SDK layer" }, { "prediction": "You may not have a copy of this file except in compliance with the License. You may not have a copy of this file except in compliance with the License. You may obtain a copy of the License at + * * http://www.apache.org/licenses/LICENSE-2.0 + * * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.", "reference": "please update the year. it can be setup in intellij template." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this.", "reference": "what's the use-case for this?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "nit: `as_index must be an boolean` -> `as_index must be a boolean`" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "What is the goal of that method? And what are `$currentVersion` and `$newVersion`? Are they Thelia or Module version? :)" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "Is there an advantage to this vs setting `this.version` in the constructor? Cleaner this way, at the top?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "Fix for URISyntaxException." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "Would be good to UT this case" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for 'no-extraneous-dependencies': 'off', 'no-extraneous-dependencies': 'off', 'no-extraneous-dependencies': 'off', 'no-extraneous-dependencies': 'off', 'no-extraneous-dependencies': 'off', 'no-extraneous-dependencies': 'off', 'no-extraneous-dependencies': 'off', 'no-extraneous-dependencies': 'off', 'no-extraneous-dependencies': 'off', 'no-extraneous-dependencies': 'off', 'no-extraneous-dependencies': 'off', 'no-extraneous-dependencies': 'off', 'no-extraneous-dependencies': 'off', 'no-extraneous-dependencies': 'off', 'no-extraneous-dependencies': 'off', 'no-extraneous-dependencies': 'off', 'no-extraneous-dependencies': 'off', 'no-extraneous-dependencies': 'off', 'no-extraneous-dependencies': 'off', 'no-", "reference": "Why we need to add this?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "This is ok to change since I believe that these were added just in main and not in public release." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Not needed in this PR, just want to make sure people think about this (maybe make an issue)? This is a lot of strings in a row. It will be hard/impossible for someone reading the code to see that everything is in the correct position. I recommend creating a struct instead of passing seven strings in a row. A similar problem exists on most of the `MakeFoo(...)` style methods in this change." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for, so I'm not sure if this is what you're looking for.", "reference": "_jaw drops_ I would have sworn I wrote those lines. Good catch." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "This needs to be tested." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "I believe you're missing the comparison after 'be'" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "move 103~105 to in front of 97?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Lots of unnecessary imports left in this file." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Does this actually produce different code?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "This should account for whitespace. Simply putting `.trim()` on the attribute value should do." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "I don't think we need these. Simpler just to put `routetable.TargetType...` inline below." }, { "prediction": "This is an S3 PUT bucket object request with URL path `//object` + # assume that this is an S3 PUT bucket object request with URL path `//object` + # assume that this is an S3 PUT bucket object request with URL path `//object` + # assume that this is an S3 PUT bucket object request with URL path `//object` + return config.PORT_S3 + # assume that this is an S3 PUT bucket object request with URL path `//object` + return config.PORT_S3 + # detect S3 requests sent from aws-cli using --no-sign-request option if 'aws-cli/' in headers.get('User-Agent', ''): return config.PORT_S3 + # assume that this is an S3 PUT bucket object request with URL `aws-cli/aws-cli/aws-cli/aws-cli/aws-cli/aws-cli/aws-cli/aws-cli/aws-cli/aws-cli/aws-cli/aws-cli/aws-cli/aws-cli/aws-cli/aws-cli/aws-cli/aws-cli/aws-", "reference": "Nested if statement. You can merge both statements nested together to create one" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Nitpick: add a space after the comma. Also, we should consider that the format of the version could change in the future so we could get something that is not a parsable integer." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "For your reference in future, I sugguest to use the `ASSERT_*` family." }, { "prediction": "#include \"modify.h\" #include \"universe.h\" #include \"variable.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h\" #include \"fmt/format.h", "reference": "no need to import `fmt/format.h` here since the `KimInit` class is derived from `Pointers`. Any class derived from `Pointers` can assumed that `lmptype.h`, `mpi.h`, `cstddef`, `cstdio`, `string`, `utils.h` and `fmt/format.h` are already included through `pointers.h`." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Can we have prefix of `OPENEBS_IO` e.g.: `OPENEBS_IO_INSTANCE_NAME`" }, { "prediction": "I think this is a bug. It should be fixed in the future.", "reference": "Might as well fix these bare returns by making them `return errors.New(...` directly." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "we can use import here" }, { "prediction": "I'm not sure if this will work, but I think it's a bug.", "reference": "thx for removing these" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "I snuck this one in as well as checkstyle crashing (on files from resources) caused an unfinished xml to be written, and it wasn't obvious where that XML was" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "How is this different than \"good case\"?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "the last parameter name should be `serviceName` as is in the implementation" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "@ftomassetti - okay, this is a little meh." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "Note, changed initial capitalisation of this for consistency. Can do it the other way around too if that'd be better. :wink:" }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it, so I'm not sure if this is the correct way to do it, but if it's the correct way to do it, I'm not sure if this is the correct way to do it.", "reference": "hey, aren't we supposed to be passing in two parameters here?" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're using a bitcore library, so I'm assuming you're using a bitcore library. I'm assuming you're using a bitcore library, so I'm assuming you're using a bitcore library. I'm assuming you're using a bitcore library, so I'm assuming you're using a bitcore library. I'm assuming you're using a bitcore library, so I'm assuming you're using a bitcore library. I'm assuming you're using a bitcore library.", "reference": "please keep alphabetical ordering :)" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's probably what you're trying to do.", "reference": "Selenium must compile against Java 6. Revert this line." }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug. I'm not sure if it's a bug or a bug, but it's a bug. If it's a bug, it's a bug. If it's a bug, it's a bug. If it's a bug, it's a bug.", "reference": "what is that `\"\"`, the adapterType? can you add `\"\" /* adapterType */`... in other places as well... might be cleaner if it's a pointer or some varargs at the end but don't have any strong preference.." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think this is what you're trying to do.", "reference": "This check is a little odd, and will still mess up with empty strings `''` because empty string is falsy. Can we change this to `|| _this.getValue(path) == null`?" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Just a minor suggestion: If you `parseInt` when you access the attribute then you shouldn't have to do it twice in the ternary." }, { "prediction": "I think this is a bug in BoltServer::TransportApp: https://github.com/bolt/bolt-server/issues/241 https://github.com/bolt/bolt-server/issues/241 https://github.com/bolt/bolt-server/issues/241", "reference": "This change in particular is strange. I'm not sure why it would now be necessary. The previous default would've been true, and the default behavior without a new net-ssh version should be unchanged." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "Why is that? Should be redundant as the default value exists." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Are all fields beginning with \"Debug\" automatically `;local`? (I guess so, but just checking.)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to update the name mapping of a table. I'm not sure what you're trying to do here, but I'm guessing you're trying to update the name mapping of a table. I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "While I think it makes sense to update the mapping programmatically, I don't see much value in exposing it as part of the table API. We want to keep the Table API small, so if we can handle this by using a separate API that consumes and produces JSON, then that is preferred. Also, we may have more than one mapping in the future, so keeping this decoupled also helps out for those use cases. For now, let's build a utility class to perform these updates. We can always add this to the public API later if we choose to." }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "We would want ssmp to wake up every 3 seconds if there are no other requests to it and do some cleanup tasks. So, it is not clear why do you want to set this to 0." }, { "prediction": "I'm not sure if this will work, but I'm not sure if this will work.", "reference": "Is this really necessary? I would expect these types to be included with the loop below." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "You could do span and it's magic of typecast to int for better efficiency" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Looks like you've covered `-webkit-transform`, but what about `-ms-transform`?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug, but I think it's a bug.", "reference": "Is there something missing from the message here?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "Hmm, what does this syntax mean?" }, { "prediction": "I'm not sure if this is the correct way to do this, but I think it's the correct way to do it.", "reference": "should this be callerTypeTask?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Currently update is set as @plan.editable_by?(@user.id) Which one is the correct behavior? I can see a case for only owners/co-owners to be able to set visibility, test status, and other plan details" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to create a new LruCache(CacheSize), but you're trying to create a new LruCache(CacheSize), which is not what you're trying to do.", "reference": "Maybe make it configurable? Or store the actual level index in DB, making this binary search obsolete?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "Nit: this file doesn't need to change. Can you revert this to avoid git conflicts?" }, { "prediction": "@ -66,7 +66,7 @@ function HelpMenu( { children } ) { const handleMenuSelected = useCallback( () => { toggleMenu( false ); - } ); return (
to` anywhere in the string? This would update something like 'Finna (VuFind 7.1.0)' as well. Just a thought, please disregard if you'd like to keep it as is." }, { "prediction": "I'm not sure if this is the case, but I think it's the case. I'm not sure if this is the case, but I'm not sure if it's the case.", "reference": "BTW for brevity, you can remove `getZkStateReader().` here and elsewhere since ZkController has a convenience method for the cluster state." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "If there are no manifests, then entries should be `CloseableIterable.empty()`, not the manifest iterable. That doesn't need to be closeable." }, { "prediction": "I think this is what you are looking for.", "reference": "this class should be named `ArrayInitializationVerbosenessTest` to work" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "Do we want to allow users to disable `console` as well? The schema currently says that it only permits a hash for `console`." }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "It would be very helpful to describe succinctly either inline or by linking to an issue going into depth why each test is not working. If we merge like this your knowledge of what is going on is lost and other people in the code need to do a ton of reading before understanding when/how/if we should unskip." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "As this is a `useEffect` this could be a cause for concern! Note that `useEffect` re-runs when a dependency changes **not** when a dependency is truthy (the previous code does look a bit like it's expecting that)" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Should we be doing this with `make_unique` or something?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "we don't want to set default values for this. Since it is the actual email, we want to make sure we are always passing in the `user` and `proposal`. we have a default value of `nil` for modifier because sometimes will update a proposal via `rails console` in which case there will be no recorded modifier." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Yes this import was in the wrong place, but should ideally be in the first list of imports (among `go/build`, `go/token`, etc.). You may move it there, or just revert this change as it's actually unrelated." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "It's unnecessary to duplicate the `name`." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems to be a bug.", "reference": "this was a mistake when adding phpstan strict plugin" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Nit: I think it should be `to handle` here." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Please don't make unrelated changes or let your tools make unrelated changes." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "`numAccounts` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Is the ID correctly normalized at this point?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "if 0 is a special constant meaning \"no limit\" let's make it a constant and name it correctly :)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Curious about the reason behind this change" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the right way to do it.", "reference": "wait, i thought the cborstore was for state tree?" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "This logic is now duplicated here and in `_delete_temporary_files`... Maybe do it all at once - find temp files, delete them, and fix the logical keys?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "How about name it with NullResponseTypeProcessor" }, { "prediction": "I don't think it's a bug, but it's a bug.", "reference": "Maybe `Log::Fatal` here? `[LightGBM] [Fatal] Check failed: feat_is_unconstrained at...` (and kernel death in case of Jupyter Notebook) seems to be not so informative and user-friendly." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "Not sure I like the name ``_apply``. Even though ``_process`` is supposed to process elements already, how about ``_process_element`` which processes elements, *excluding* Overlays/NdOverlays." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this. I'm not sure what you're trying to do, but I think you're trying to do something like this.", "reference": "Let's use this constant when ASG is created as well (currently hardcoded)." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Oh is `bucket` actually higher cardinality than `eventname`?" }, { "prediction": "I think this is a bug in PyQt5.QtWebEngineWidgets, but it's fixed in PyQt5.QtWebEngineWidgets.", "reference": "You can't rely on QtWebEngine being available - but why do you need to import this here at all?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's worth mentioning that this is what you're looking for.", "reference": "How did you determine these - and how can we be confident that nothing is missing?" }, { "prediction": "I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "What is this page going to do that is different than the products index we already have?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this should work.", "reference": "Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Is this intended to be here? Seems it belongs to a different PR." }, { "prediction": "I'm not sure if you're using the latest version of Xunit, but if you're using the latest version of Xunit, you can use the latest version of Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit.Xunit", "reference": "These changes, while harmless, were no longer needed with newer versions of System.Console thanks to @ianhays" }, { "prediction": "I'm not sure if you're using boto3 or not, but I'm not sure if you're using boto3 or not. If you're using boto3 or not, you'll need to import boto3 or not. If you're using boto3 or not, you'll need to import boto3 or not. If you're using boto3 or not, you'll need to import boto3 or not. If you're using boto3 or not, you'll need to import boto3 or not. If you're using boto3 or not, you'll need to import boto3 or not. If you're using boto3 or not, you'll need to import boto3 or not, you'll need to import boto3 again.", "reference": "Umm... this isn't relevant to this PR" }, { "prediction": "@ -24,6 +24,7 @@ namespace Xunit Netcoreapp = 0x1000, Uap = 0x2000, UapAot = 0x4000, - NetcoreCoreRT = 0x8000 + NetcoreCoreRT = 0x8000, + All = ~0 } }", "reference": "While All make some sense here it doesn't make a lot of sense in the SkipOnFramework context. I wonder if we really need to expose anything more here. You can just blindly use 0." }, { "prediction": "The Swarm Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be found in the LICENSE file. +// Package main provides the bee binary viper-cobra +// command definitions. +package main provides the bee binary viper-cobra +// command definitions. +package main provides the bee binary viper-cobra +// command definitions. +package main provides the bee binary viper-cobra +// command definitions. +package main provides the bee binary viper-cobra +// command definitions. +package main provides the bee binary viper-cobra +// command definitions. +package main provides the bee binary viper-cobra +// command definitions. +package main provides the bee binary viper-cobra +// command definitions. +package main provides the bee binary viper-cobra +// command definitions. +package main provides the bee binary viper-cobra +// command definitions. +package main provides the bee binary viper-cobra +// command definitions.", "reference": "Actually, this is not correct. Package `cmd/bee` doe snot have any notion of commands or even libraries used for them. It is as simple as possible, just calling the function from `cmd/bee/cmd` which actually implements commands." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "This change is causing tests to fail because users sits at `/app/users`, not `/app/admin/users`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Could you provide more information on what exactly each of those three options do?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "Why this line break?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "We're importing this twice with different aliases." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, then it's a good idea to use the \"pylint==2.6.0\", \"pytest-cov==2.10.1\", \"pylint==2.6.0\", \"pytest-cov==2.10.1\", \"pylint==2.6.0\", \"pytest-cov==2.10.1\", \"pylint==2.6.0\", \"pylint==2.6.0\", \"pytest-cov==2.10.1\", \"pylint==2.6.0\", \"pylint==2.6.0\", \"pytest-cov==2.10.1\", \"pylint==2.6.0\", \"pytest-cov==2.10.1\", \"pylint==2.6.0\", \"pytest-cov==2.10.1\", \"pylint==2.6.0\", \"pytest-cov==2.10.1\", \"pylint==2.6.0\", \"pytest-cov==2.10.1\", \"pylint==2.6.0\", \"pytest-cov==2.10.1\", \"pylint==2.6.0\", \"pylint==2.6.0\", \"pytest-cov==2.10.1\", \"pylint==2.6.0\", \"pylint==2.6.0\", \"pytest-cov==2.10.1\", \"pylint==2.6.0\", \"", "reference": "We should avoid adding a pandera dependency to Dagster itself." }, { "prediction": "I'm not sure if this is correct, but I'm not sure if it's correct, but I think it's correct.", "reference": "Can be replaced with `org.jkiss.utils.ArrayUtils#add`." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if it's what you're trying to do, but I think it's what you're trying to do.", "reference": "While we're here, this line (and a few others) should be `customThreadPool.submit(() -> IOUtils.closeQuietly(overseer);` I have no idea why we're creating a collection and a stream for a single object." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Should these restrictions also be reflected in the API docs?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "What about the request headers if someone uses `request_header`? :thinking:" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "Verify that external-dns allows setting this parameter multiple times (that it's not \"last one wins\")." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Maybe 2 host/ip values could be used in the example?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do.", "reference": "We're only testing `RateLimiter.Allowed(Span)`, so I think we can use a mock `ITraceContext` instead of a real `Tracer` or `TraceContext`." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "IMO, this is the wrong way to associate a model with a trainer... Why the string when you actually have a trainer object?" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Wondering if we can directly put types here & for other similar ledger_processor items like rai::block_type::state" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "As `DeleteFiles` is not only used for prune this function deserves its own file. Maybe something like `delete_files.go` or `parallel.go`?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "It should be simplified character. `` -> ``" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "I am pretty sure it breaks the visitor pattern, visitor should have no knowledge about the structure of what it is visiting or control over visiting mechanism" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "'A' instead of 'An' here" }, { "prediction": "This is the default timeout used to make calls - DefaultTimeout = 10 * time.Second + DefaultTimeout = time.Second * 10 // DefaultLongPollTimeout is the long poll default timeout used to make calls DefaultLongPollTimeout = time.Minute * 3 )", "reference": "Can you flip it back (here and in other places)? It is more natural to represent \"10 seconds\" as `10 * time.Second`." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Why was this necessary? You should just use the `dask_classifier` defined below this. With this change, you'd only be doing the local predict on arrays each time, but we want to test on all of DataFrame, Array, and sparse matrix." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "To me, this is sort of weird to have a completely separate page for this. Can we extract the different stuff (github, videos, downloads) presentation from the top of `app/views/purchases/show.html.erb` and reuse it on this page. I worry that we'll change things with fulfillment or copy and have to change it in multiple places." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Please revert the lines above. Not touching unrelated code keeps the git history clean." }, { "prediction": "I think this is a bug in MMLab. It should be fixed in the latest version of MMLab.", "reference": "`short_version` and `version_info`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "This is supposed to be `status`. Why did you change this?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "I will change all of these at some point next week." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "I made this change because, while trying to debug, in Visual Studio, the `IntegrationSignatureTests`, this property getter was hit and interfered with my ability to complete the debugging." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "nit: `\"Unexpected error while calculating: unable to convert %T to %T: %v\"`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "I'd actually recommend not putting this in the `SampleConfig`, it's intended more for properties that are inherent of the discovery format. Add a method `getSampleAppName(String apiTypeName)` to `SampleNamer` and override it in the language specific `SampleNamer`s if needed. Then assign it in the transformer." }, { "prediction": "I think this is what you are looking for: https://github.com/angular/blob/master/src/main/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components/components", "reference": "Do we need to export these new functions? I thought the plan going forward was to keep util imports separated to make circular imports less likely and possibly do better chunk splitting. Since only new code references these files, we can scope the import to the specific files." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like it's a bug.", "reference": "Rails will autorequire `acts_as_editable` once it encounters the constant `ActsAsEditable`. Thus if we move `ActiveRecord::Base.send :include, ActsAsEditable` from _acts_as_editable.rb_ to this file, the require line will not be needed anymore. Instead of requiring the file ourselves, we will let Rails do it for us. This fix will also remove the need to explicitly require `acts_as_editable` in _mock_active_record_base.rb_." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "I think we should name this `grpcMethodName` or similar. That is what this refers to, right? The fact that it is upper camel is an implementation." }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "What if.. appears, but not as the first character, eg \"errors/../../../../../../../../../../../\"?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm assuming that you're trying to create a guidance that is owned by a particular user, and that you're using a guidance that is not owned by a particular user, and that you're using a guidance that is not owned by a particular user, and that you're using a guidance that is not owned by a particular user. I'm assuming that you're trying to create a guidance that is owned by a particular user, and that you're using a guidance that is not owned by a particular user, and that you're using a guidance that is not owned by a particular user, and that you're using a guidance that is not owned by a particular user, but a guidance that is owned by a particular user.", "reference": "Thanks, this should make things a bit easier for people who pick up the codebase but aren't a `curation center`" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "why not removing it?" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "same nit here: maybe word as - \"disables validation of the temporal cluster's server certificate\"" }, { "prediction": "@Test public void testDefaultDatabase() { sql(\"USE CATALOG %s\", catalogName); sql(\"show tables\"); Assert.assertEquals(\"Should use the current catalog\", getTableEnv().getCurrentCatalog(), catalogName); Assert.assertEquals(\"Should use the configured default namespace\", getTableEnv().getDefaultNamespace(), catalogName); Assert.assertEquals(\"Should use the configured default namespace\", getTableEnv().getDefaultNamespace(), catalogName); Assert.assertEquals(\"Should use the configured default namespace\", getTableEnv().getDefaultNamespace(), catalogName); Assert.assertEquals(\"Should use the configured default namespace\", getTableEnv().getDefaultNamespace(), catalogName); Assert.assertEquals(\"Should use the configured default namespace\", getTableEnv().getDefaultNamespace(), catalogName); Assert.assertEquals(\"Should use the configured default namespace\", getTableEnv().getDefaultNamespace(), catalogName); Assert.assertEquals(\"Should use the configured default namespace\", getTableEnv().getDefaultNamespace(), catalogName); Assert.assertEquals(\"Should use the configured default namespace\", getTableEnv().getDefaultNamespace(), catalogName); Assert.assertEquals(\"Should use the configured default namespace\", getTableEnv().getDefaultNamespace(), catalogName); Assert.assertEquals(\"Should use the configured default namespace\", getTableEnv().getDefaultNamespace(), catalogName); Assert.assert", "reference": "Nit: other statements use all caps for SQL reserved words. Should this be `SHOW TABLES`?" }, { "prediction": "static bool is_a_code_line (const char *line, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel, const char *end_sentinel,", "reference": "Do we need this? isLuaIdentifier() is used not only in extract_next_token() but also in extract_prev_toke(). I wonder whether the change for isLuaIdentifier() has an impact on extract_prev_toke() or not. If you are not sure, keep isLuaIdentifier() as is. If you are sure, could you write your conviction to the commit log." }, { "prediction": "The default MTU on Azure is 1500, but the underlying network stack will fragment packets at 1400 bytes, so we need to change the default MTU on Azure to 1500 bytes.", "reference": "This line should actually be: `if c.KubernetesProvider == config.ProviderAKS && c.Wireguard.EncryptHostTraffic {` because we only need to tweak the MTU like this on AKS." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for.", "reference": "Do we need to change this flag as well?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this should work.", "reference": "Including the source twice here makes the filesize jump to 432kb. Is there any way to minimize repeating it?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings." }, { "prediction": "It's critical that the order of plan vars is not changed, as Puppet + # will deserialize the variables in the order they appear in a plan. If + # these variables are moved before the variable they reference, Puppet will + # be unable to deserialize the data and raise an error. + topscope_vars = target_vars.reject { |k, _v| plan_vars.key?(k) }.merge(plan_vars) + env_conf = { modulepath: request['modulepath'], facts: target['facts'], variables: topscope_vars } This is not critical, but it's critical that the order of plan vars is not changed, as Puppet + # will deserialize the variables in the order they appear. It's critical that the order of plan vars is not changed, as Puppet + # will deserialize the variables in the order they appear in a plan. If + # these variables are moved before the variable they reference, Puppet will + # be unable to deserialize the data and raise an error. + topscope_vars = target_vars.reject { |k, _v| plan_vars.key?(k", "reference": "Only one line of code? What a simple issue!" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Conceptual question: why do history and matching need throttler at all? Shouldn't throttling to be handled on FE only?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Would this be possible: `addCNP` has already processed the CNP to an internalNP, just hasn't added this internalNP to the `internalNetworkPolicyStore`. In this case, `reprocessCNP` will skip processing this CNP and `addCNP` will just add the \"old\" internalNP to `internalNetworkPolicyStore`." }, { "prediction": "Is there a way to make this work?", "reference": "Minor: you can access `current_user` in here directly - don't need to pass it in. Unless you prefer passing it explicitly?" }, { "prediction": "I think this is what you're looking for.", "reference": "What is the purpose of `&` on this line?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea to check if the web data stream ID is valid or not. I'm not sure if this is what you're looking for, but it's a good idea to check if the web data stream ID is valid or not. I'm not sure if this is what you're looking for, but it's a good idea to check if the web data stream ID is valid or not. I'm not sure if this is what you're looking for.", "reference": "See above, the `isValidWebDataStreamID` implementation from before is actually correct. What we need here instead is a new `isValidMeasurementID` function." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "Should be an error... it is important for the admin of the server attempting to create the leafnode connection to see the error asap." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Could you split these conditions up over multiple lines please." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here.", "reference": "I think we can just change this to `Split` instead of `SplitN`. I don't think we need to limit the number of parts in the tag." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "So this is actually a mistake that I introduced without realizing it, and have known would need to be fixed when we get here. The format of the ports directive is \"host:container\". We only want the host port to change, not the internal container ports. The ports variable probably needs to be a map which maps external -> internal ports." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here.", "reference": "An alternate approach would be to always initialize shardInfo with a dummy (non-nil) value, which could protect against other uses before it's initialized (I couldn't find any though). But I can change it to do it that way instead." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Maybe we can just put the entire `DirEntry` in here? I can imagine it might be useful for debugging to get the block ID/refnonce, encrypted size, key gen, data version, etc. What do you think?" }, { "prediction": "I don't think it's a bug, but it's a bug.", "reference": "For the commit message: The paragraphs seem to be out of order? The `Would not work because` refers to the stuff before, but there is a `This may seem pointless, but` in-between." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "Why did you remove these packages from the prelude, will your new functions not work without this change?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I think I'm correct.", "reference": "We'd better reserve enough space before using kvKeys to avoid extra malloc." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for, so I'm not sure if this is what you're looking for.", "reference": "would it make sense to return empty or error if label doesn't exists?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Don't penalize everyone with 250ms delay b/c some machines have problems." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this.", "reference": "Probably want a space after the second %s?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "This seems like an internal error still?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "Line is too long. [94/80]" }, { "prediction": "I'm not sure if this will work, but I'm not sure if this will work.", "reference": "out of curiosity, why creating another struct to wrap it?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure.", "reference": "discipline vs. Discipline? Not sure of which is correct. Also not sure if there is already an existing string const." }, { "prediction": "I'm not sure if this is the case, but if it's the case, then it's the case.", "reference": "I believe this will break common resources, as they are defined in a common file, but must generate classes in service-specific namespace, so using protoFile to determine package of the generated class would not work, because common_resources namespace does not match service namespace." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "How about `SPARK_DEFAULT_SERIES_NAME`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "The other properties are in `commit.status-check`, not `commit.status-checks`. Could you remove the extra `s`?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Side note: I'd love to see more of these fields exposed on configuration." }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "In the case of accounts generated by API clients, what name gets put for the `inviter_name` or `invited_by` record?" }, { "prediction": "I don't think I need to do this, but I'm not sure if I need to do this, or if I need to do it this way, I'm not sure if I need to do it this way, or if I need to do it this way, I'm just not sure if I need to do it this way, or if I need to do it this way, I'm just not sure if I need to do it this way, or if I need to do it this way, or if I need to do it this way, I'm just going to do it this way.", "reference": "I think this class is only relevant for updating the QbftConfigOptions based on the transitions config, so probably not." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug in Nethermind.", "reference": "what is the number thrown by Geth?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "This would still crash on malformed database connection string like \"test\"" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "it is not an interface, maybe we can move to another package?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "Same here. Can we use `this.instance.getSettings()` to get `tableMeta`?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "Not sure whether this validation is useful." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Various things to note here: - Why would `question` ever be falsey (or `None`) here, i.e. why the `if question`? - Why would `question` ever not have that attribute? You set it in `Question.__init__`, so that check does nothing at all (and generally, `hasattr()` should be avoided if possible). - Why do you want to yank `None` (what does that do?) rather than e.g. show an error if there's nothing to yank?" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, then it's a good idea to check if it's what you're trying to do.", "reference": "If this is needed for testing, you should use `pytest --log-cli-level=INFO` instead." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm guessing it's a bug.", "reference": "We should drop ipify in all places i guess" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Add explanations around these variables - what do they mean, how they should be configured, etc." }, { "prediction": "I think this should be called on app init, but I don't think it should be called on app init, so I don't think it should be called on app init.", "reference": "One thing tho - I would really appreciate any advice on where to move this to, so that it's called on initialisation of the website." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "To much tabs here (1 tab)" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "This is not maintaining retention time for logs as we are deleting only 1000 entries and we might end up with huge number of rows spanning over multiple months over a period of time if the cluster generates more rows as we are restricting ourselves to delete only 24k rows/day. Like I pointed out earlier a better would be to probably run this clean up every hour with some batch_size in a loop while there are records to be deleted(i.e older than 12 weeks) and committing each batch." }, { "prediction": "I think you need to override the workflow retry policy. I'm not sure if this is what you're looking for, but I think it's a good idea to override the workflow retry policy.", "reference": "I don't like this helper func :-). Yeah, definitely don't like." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Same here. This should remain unchanged. Please, add it back." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think this is what you're trying to do.", "reference": "@kvwalker should this method have `ignoreUndefined` supported as an `option`?" }, { "prediction": "I don't think this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "we dont use a `sugaredlogger` anywhere else in clutch, just curious why were using it here?" }, { "prediction": "I'm not sure if this is what you're looking for, but if it's the case, it's probably the case.", "reference": "Not evident from looking at this diff but the queue is already being cleared four lines below." }, { "prediction": "I'm not sure if this is the case, but I think it's the case, but I'm not sure if it's the case.", "reference": "Why is this a 'transaction' and not in the block header?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "This doesn't fit the abstraction level. Should we have a property bag for extra stuff?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure.", "reference": "Looks like it is pretty easy to miss it when adding new files under `ci`. Hopefully, this doesn't happen too often." }, { "prediction": "I'm not sure if this is a bug, but if it's a bug, it's a bug.", "reference": "do we really need the `Ready` call if startup fails midway?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "You can avoid changing the code if there are parameter defaults. right?" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `` `` `` ````````````````````````````", "reference": "I wonder why the newline disappeared here? I guess we'll merge and see how SauceLabs fares across the supported browsers." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "I know this is legal, but I prefer we put brackets on our calls" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to delete an AWS Identity and Access Management (IAM) server certificate. I'm assuming you're trying to delete an AWS Identity and Access Management (IAM) server certificate. I'm assuming you're trying to delete an AWS Identity and Access Management (IAM) server certificate. I'm assuming you're trying to delete an AWS Identity and Access Management (IAM) server certificate. I'm assuming you're trying to delete an AWS Identity and Access Management (IAM) server certificate.", "reference": "AWS Identity and Access Management (IAM)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "We keep who wrote the code anonymous." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Two things to make the code more error-proof and simplify it: 1. To be safe, this should be: `! isUndefined( decimal ) &&! isUndefined( decimal.value )` 2. The other clause that you changed below can be combined with that since `decimal` isn't used anywhere else, and so there's no point to re-check whether it's not undefined. In other words, this should become: `! isUndefined( decimal ) &&! isUndefined( decimal.value ) && 1000 > number`, and then you can remove the `decimal = decimal.value` assignment and replace it with line 146 (assignment of `readableNumber`)." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Wouldn't composite outbounds compose the transport, such that it would still be represented as a single transport?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "nit: there is no need for a new line here, usually we tend to put an object creation and its deferred deletion next to each other. It helps not forgetting about the cleanup." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Feel free to use the full notation with my email address: `Maxime Steinhausser ` :smile:" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but it's the case.", "reference": "This was unused across the codebase" }, { "prediction": "I'm not sure if this is a bug, but it seems to be fixed in the latest release.", "reference": "Should we put in which account we were trying to look up?" }, { "prediction": "IAM_POLICY = 'iam_policy' GCS_POLICY = 'gcs_policy' IAM_POLICY = 'iam_policy' GCS_POLICY = 'gcs_policy' IAM_POLICY = 'iam_policy' GCS_POLICY = 'gcs_policy' IAM_POLICY = 'iam_policy' GCS_POLICY = 'gcs_policy' IAM_POLICY = 'iam_policy' GCS_POLICY = 'iam_policy' IAM_POLICY = 'iam_policy' GCS_POLICY = 'iam_policy' IAM_POLICY = 'iam_policy' GCS_POLICY = 'iam_policy' IAM_POLICY = 'iam_policy' GCS_POLICY = 'iam_policy' IAM_POLICY = 'iam_policy' GCS_POLICY = 'iam_policy' IAM_POLICY = 'iam_policy' GCS_POLICY = 'iam_policy' IAM_POLICY = 'iam_policy' GCS_POLICY = 'iam_policy' IAM_POLICY = 'iam_policy' GCS_POLICY = 'iam_policy' IAM_POLICY = 'iam_policy' G", "reference": "either SUPPORTED_TYPECLASS or supported_typeclass. Camelcase only for class names." }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this:", "reference": "This is not going to work. You need to add a migration to the database." }, { "prediction": "I'm not sure if this is what you're trying to do, but it's not clear what you're trying to do. If you're trying to do something like this, it's not clear what you're trying to do. If you're trying to do something like this, it's not clear what you're trying to do. If you're trying to do something like this, it's not clear what you're trying to do. If you're trying to do something like this, it's not clear what you're trying to do. If you're trying to do something like this, it's not clear what you're trying to do. If you're trying to do something like this, it's not clear what you're trying to do, it's not clear what you're trying to do.", "reference": "Should these methods be renamed in this PR?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm not sure.", "reference": "we need to include the `metricStreamName` which is invalid, so users know whats causing the issue." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Please run Platform tests `DiaSessionTests`." }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm guessing it's a bug.", "reference": "This is debug-build-only: we want a release-build notice. SYSLOG takes the name w/o the MSG and no _STRING. Args are via events.mc specifiers." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "is it possible to have both forms here? I was hoping we wouldn't be introducing more cases where we had to check the upper and lowercase version of URI options." }, { "prediction": "I'm not sure what you're trying to do, but I think it's a bug.", "reference": "Does the name suffix hardcode something? Not clear how changing the name fixes this." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Is undispatched same as queued? getQueuedFlows?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "See above, same for all similar cases below." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm not sure.", "reference": "Why is this done twice?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "This sync can ensure that the condition of the child node is consistent with the parent node, but I still don't understand when the child will be overwritten, and this behavior is not what we expected?" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "This was renamed to avoid any confusion with the more general case of debugging via `plz debug`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here. I'm not sure what you're trying to do here is what you're trying to do here, but I'm guessing you're trying to do here, so I'm not sure what you're trying to do here is what you're trying to do here. I'm guessing you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here. I'm guessing you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "String valStr = (String)val; valStr.substring(0, Math.min(valStr.length(), prefixLength)) Make it clean." }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "Sorry, this still makes no sense.. the value of any union or enum is simply a name integer constant, it has nothing to do with the `BASE_TYPE_` enum. This value should be `0`. In particular: `Every union has the NONE field, which always has value 0`." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Looks like getAzkabanURL() is added after concrete Alerter (Emailer)::getAzkabanURL(), so that Override annotation is needed." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "The above 3 lines can be written as: `mask = segms[i].astype(bool)`" }, { "prediction": "I'm not sure if this is a bug, but it seems to be fixed in the future.", "reference": "File is not `gofmt`-ed with `-s` (from `gofmt`)" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Thought it's good to have this logged down so that we can check the used value in the logs." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "I don't think you can call this optional unless it's a pointer - remove this?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "@naofum please use `isEmpty`method instead" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "i think this is unrelated and needs to be reverted. need to discuss at sync." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Are we eventually moving those type interfaces from plugin project to datatype project? If not, then we'd have a dependency from core onto plugins, which seems a little counter-intuitive to me." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Love how we can finally use async/await in the codebase." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Very minor: this line could be moved to a more narrow scope, inside `if (!representative.decode_account (representative_text))` Other than that, LGTM" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "when is this consumed? I'm probably missing it but I can't find it right now" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems to be a bug.", "reference": "I think we also need to add the rollupGroupExprList() to the cache key. If we rebuild the list above from a ValueIdSet on line 418 above, it is probably going to be in the same order, regardless whether it was ROLLUP(a,b) or ROLLUP(b,a)." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "can use `getParamTypeName` instead" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Why send the parameters? They're accessible directly from `$this->request` so there's no need to inject them in the method" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Tiny nit: I would prefer `not selected_file` or `len(selected_file) == 0`, as if choose_file starts returning, for example, tuples instead of lists, this won't break." }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "How will this code behave with hostnames that contain hyphens?" }, { "prediction": "I'm not sure I'm getting this right, but I'm not sure if I'm getting this right, so I'm not sure if I'm getting this right, but I'm not sure if I'm getting this right, so I'm not sure if I'm getting it right, but I'm not sure if I'm getting it right.", "reference": "I think this is redundant since \"NullForEmpty\" already calls \"Trim()\"." }, { "prediction": "This is not a CloudBackupGroupCreateResponse, it is a CloudBackupGroupCreateResponse, but a CloudBackupGroupCreateResponse.", "reference": "Change this to IDs too?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "private static final, and it should be located in raidsoverlay, as it's not needed in the plugin. also the name could be a bit better, DC_SCOUT_RAIDS or similiar." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug, so I'm not sure if it's a bug, or if it's a bug.", "reference": "attr_value is 128 bytes?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "if it's unpredictable - why uppercase it at all?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Please remove all these debug prints. It doesn't look good." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to create a new actor.", "reference": "Consumers of this interface should not be required to provide `sampleHeight`. This should be an expected consensus parameter." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "I don't believe this is the right fix. If startTime comes after closeTime, then it means some other event triggered invocation of this code path like workflow timeout. In this case we should still try to fire the cron on previous value so we should just return start the delta between startTime and closeTime immediately." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm assuming you're looking for CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType, CloudBackupStatusType,", "reference": "Not sure if we need tag here, it is an implementation detail in portworx that isn't exposed in openstorage" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "I wonder if it would be cleaner to refactor all of this similar to the SolrMarc driver, so we have a property with Summon field names associated with types, and we iterate through it in a loop... that way we don't have to repeat the loop code four times with different variable names." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Need the `solrClientCache.close();` further down in the method be removed since a shared cache is now used?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing it's a ClusterMembershipRow.", "reference": "according to the PR (schema changes?) these 2 field should be removed?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "Panic here if `exp.Target.StressChaos.CintainerName` is nil." }, { "prediction": "The DocIdSetIterator is not the same as the DocIdSetIterator. The DocIdSetIterator is the same as the DocIdSetIterator. The DocIdSetIterator is the same as the DocIdSetIterator. The DocIdSetIterator is the same as the DocIdSetIterator. The DocIdSetIterator is the same as the DocIdSetIterator. The DocIdSetIterator is the same as the DocIdSetIterator. The DocIdSetIterator is the same as the DocIdSetIterator. The DocIdSetIterator is the same as the DocIdSetIterator. The DocIdSetIterator is the same as the DocIdSetIterator. The DocIdSetIterator is the same as the DocIdSetIterator. The DocIdSetIterator is the same as the DocIdSetIterator. The DocIdSetIterator is the same as the DocIdSetIterator. The DocIdSetIterator is the same as the DocIdSetIterator. The DocIdSetIterator is the same as the DocIdSetIterator. The DocIdSetIterator is the same as the DocIdSetIterator. The DocIdSetIterator is the same as the DocIdSetIterator. The DocIdSetIterator is the same as the DocIdSetIterator", "reference": "This allows for some hacks like returning an iterator that matches more docs than the scorer. I liked the previous approach that returned an iterator better." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Aren't there already logs for this from the underlying file system implementation?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something that's not what you're looking for, so I'm not sure if this is what you're looking for.", "reference": "It would be good to have a test in here that demonstrates the new munge functionality; I can help set that up if you're not sure how." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "`retrials` isn't the word you intend. I think you mean `retries` and to that end, can the var name just be `max_retries`?" }, { "prediction": "I'm not sure what you're trying to do, but I think it should be something like this:", "reference": "Value in product should contain 255 characters or less." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "line is 133 characters (from `lll`)" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "since we're calling the file.rspec-local, I think we should rename local_options to project_options and use local_options for.rspec-local - WDYT?" }, { "prediction": "I think this is a bug, but it should be fixed.", "reference": "Will we want to refactor this when we drop rsolr 1.x support?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "should this really be multiple IPs?" }, { "prediction": "@@ -0,0 +1 @@ +<%= render partial: \"proposal\", locals: { proposal: @proposal} %> @@ -0,0 +1 @@ +<%= render partial: \"proposal\", locals: { proposal: @proposal} %> @@ -0,0 +1 @@ +<%= render partial: \"proposal\", locals: { proposal: @proposal} %> @@ -0,0 +1 @@ +<%= render partial: \"proposal\", locals: { proposal: @proposal} %> @@ -0,0 +1 @@ +<%= render partial: \"proposal\", locals: { proposal: @proposal} %> @@ -0,0 +1 @@ +<%= render partial: \"proposal\", locals: { proposal: @proposal} %> @@ -0,0 +1 @@ +<%= render partial: \"proposal\", locals: { proposal: @proposal} %> @@ -0,0 +1 @@ +<%= render partial: \"proposal\", locals: { proposal: @proposal} %> @@ -0,0 +1 @@ +<%= render partial: \"proposal\", locals: { proposal: @proposal} %> @@ -0,0 +1 @@ +<%= render partial", "reference": "Hmm, is that partial used in multiple places? Maybe we can just move that file in here." }, { "prediction": "You may not use this file except in compliance with the License. This file is distributed under the Apache License, Version 2.0 (the \"License\"). You may not use this file except in compliance with the License. A copy of the License is located at +// +// http://aws.amazon.com/apache2.0/ +// or in the \"license\" file accompanying this file. This file is distributed under the License, Version 2.0 (the \"License\"). You may not use this file except in compliance with the License.", "reference": "Should be 2014-2016" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Looks like my fault for sure in trying to handle international inputs regardless of locale. I think the correct fix is actually to get rid of TrySplitColumns and use ParseDsvFields instead. It is what gets used in the end, and it already has logic for dealing with quoted fields." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "similarly here, are the these cursors not being closed when the client is closed?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Or maybe `func(args...string) Policy` to make it dynamic in case of any future policy that may require more than one args." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Should this happen even if the above failed?" }, { "prediction": "The OpenEBS Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the Apache", "reference": "Please dont change this." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "There is a strange $b that looks wrong." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for. I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for.", "reference": "Is it still important to have `speakEntry` here? It is checked before this value `containerContainsText` is used in the \"General\" section." }, { "prediction": "I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "It is `$JAVA_HOME/bin`, not `$JAVA_HOME`, which should be added." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Should move this to within the `#else` block as it's only used there." }, { "prediction": "I think this is a bug in the code you posted. It should be a bug in the code you posted. It should be a bug in the code you posted.", "reference": "is this a common rule to wait one extra second after ajax? I'm thinking about moving this extra wait into waitForAjax method." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Maybe you can correct the typo \"if\" too :)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "I'd prefer a name less chat-specific, since later on we could have other app types that want the same behavior. Maybe `IdentifyAndAllowTrackBreaks`?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "I think I was involved in writing that caster, but I never fully understood the `import_mpi4py` thing. Why is importing mpi4py still necessary at that point? I would think if the user is passing a communicator from python code, they must already have imported mpi4py themselves, or does that not propagate through into the wrapping layer?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug.", "reference": "This seems like a more interesting change. Maybe we should re-name the PR" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm guessing it's a bug.", "reference": "Nit: implement the methods for these interfaces explicitly in this file for consistency. It can be passthrough." }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "Not directly related to your PR, but I think here we should create a Type enum (MAP, ARRAY, PRIMITIVE) instead of having 3 flags." }, { "prediction": "I don't think it's a bug, but it's a bug.", "reference": "Do you want this to be a stack variable? The work method might return at any time (example: when the parent queue fills up) and then get called again, which would cause this variable to become false again. I'm wondering if this variable should be a member instead?" }, { "prediction": "I'm not sure if this is a bug, but if it's a bug, it's a bug.", "reference": "You could reserve a const space to save the extra computation." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Did you consider adding rooted paths like `C:\\ProgramData` and paths with flipped separators?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "does this line cause a panic if it is above the if condition?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Maybe `LibraryDetailsPanelType` would be clearer." }, { "prediction": "I don't see a reason for this, but I'm guessing it's a bug, so I'm guessing it's a bug, so I'm guessing it's a bug, but I'm guessing it's a bug.", "reference": "minor nit - add \"persist-filesystem\" and \"persist-directory\" into commit message, as its something people may search on (maybe applies to a few other commit messages)" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "I verified offline with @jeremyg-lunarg this should be removed." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This should be removed? If not, typo in incldued_wf" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Sorry for the delay on this! It looks like Circle CI isn't running tests on some of the PRs, but this doesn't look like it would work I might be missing something, but are the tests all passing locally?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to split the path in two different ways. I'm guessing you're trying to split the path in two different ways, but I'm not sure what you're trying to do. I'm guessing you're trying to split the path in two different ways, but I'm not sure what you're trying to do.", "reference": "Do you think the godoc should mention that all delimiters will be suffixed with `/`?" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, then it's a bug.", "reference": "what if I want to load my own, a different, data URI in Private Browsing mode? I do this often on desktop (e.g., `data:text/html,×`). admittedly, I wouldn't expect this to be done by a non-developer, but this will certainly cause a minor bug." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "I remember the sequence number 0 is kept for the data files for iceberg v1, so in theory the sequence number from delete files should start from 1. So setting it to 0 as the default value sounds correct." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug, but I think it's a bug.", "reference": "For all these MYSQL queries unsigned is required. I have tested again and without unsigned these queries are failing." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Are there tests for this? What happens when you get to limit?" }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this:", "reference": "Whole thing could be collapsed to `data['config']['transport'] ||= 'local' if target.name == 'localhost'`." }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if this is the correct way to do it.", "reference": "maybe throw in `&& mServiceConnection.isBound()`, there are cases where the connection might die" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug in Nethermind.Core.Specs.Forks. IsEip1283Enabled => true; public bool IsEip1283Enabled => false; public bool IsEip1234Enabled => true; public bool IsEip1344Enabled => false; public bool IsEip1344Enabled => false;", "reference": "Can we add Istanbul with this first EIP please? (or as a separate issue)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "I don't understand this change" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "Let's allow translators for this string to be translated: `self.show_warning(_('Invalid Public key'))`" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "This needs to work with `role=form` too." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "This should be before the if on line 1028, which should turn into an else if" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Not really introduced by this PR, but I don't recall why these have to be pointers, while `PodSelector` / `NSSelector` do not. Do you know the reason?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Is there a reason why we are ignoring the ackDelay if it would result in a value smaller than the min? Why not `max(sample - ackDelay, minRTT)`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Here's an example of how the files in the `NotYetGenerated` directory drifted out of sync from the generated files. When we made the equality comparers internal, we neglected to fix this one." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "nice. we should do this elsewhere too. We have a lot of repeated stuff in the policies" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Small formatting thing, but can you remove the space before the semicolon?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "Not new, but nit: _writeLeng*th*." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Our habit is to go ahead and put a description line (or more) in front of every function, not just non-test or exported functions." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Remove this file from the PR" }, { "prediction": "I'm not sure if this is the correct way to do this, but I think it should be something like this:", "reference": "I think that for cloud variables, the default value in the prompt should be the variable name without the cloud prefix; this is slightly different from the scratch 2.0 behavior, but I think would ultimately lead to less confusion. Proposing code changes below:" }, { "prediction": "Is this a bug? Is it a bug? If so, is it a bug? If so, is it a bug?", "reference": "I think I would rather fish this interface through than use it as the basis for heuristics." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm guessing it's what you're trying to do.", "reference": "Probably not worth making this line-ending change, since it is the only change to this file." }, { "prediction": "private static bool opnd_create_base_disp(uint enc, int opcode, byte *pc, opnd_t opnd, OUT uint *enc_out) { if (opnd_size_in_bytes(opnd_size_in_bytes(opnd_size_in_bytes(opnd_size_in_bytes(opnd_size_in_bytes(opnd_size_in_bytes(opnd_size_in_bytes(opnd_size_in_bytes(opnd_size_in_bytes(opnd_size_in_bytes(opnd_size_in_bytes(opnd_size_in_bytes(opnd_size_in_bytes(opnd_size_in_bytes(opnd_size_in_bytes(opnd_size_in_bytes(opnd_size_in_bytes(opnd_size_in_bytes(opnd_size_in_bytes(opnd_size_in_bytes(opnd_size_in_bytes(opnd_size_in_bytes(opnd_size_in_bytes(opnd_size_in_bytes", "reference": "Is this the correct place for this assert? Does this routine rely on it being 64, or was this only for testing?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing this is what you're looking for.", "reference": "No pb please" }, { "prediction": "I think this is what you're looking for.", "reference": "We need to add indexes here on both `subscriber_id` and `changeset_id` or things will quickly collapse as we build up subscribers ;-) What I would suggest is a unique index on `[:subscriber_id, :changeset_id]` which will also make duplicate entries impossible, and an ordinary index on `[:changeset_id]` for finding the subscribers to a changeset." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "use the context versions of everything, e.g. `PostMessageContext` and thread it through the functions. will save you a bunch of refactoring trouble later on." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "\"not to be used elsewhere other than\"" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "Thanks for the contribution, @coolderli! I also think the newPosDeleteWriter need the properties setting..." }, { "prediction": "I think this is what you're looking for.", "reference": "These additions seem unrelated to this change?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Could we move this to a class for Hadoop configuration properties, like `org.apache.iceberg.hadoop.ConfigProperties`?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm sure it's a bug.", "reference": "The related statements should also be deleted." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Shouldn't this line be removed?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to use a blacklisted name, so I'm not sure what you're trying to do.", "reference": "Just move this into `const.py`. It already has similar stuff. Also, make it uppercase since it's a const." }, { "prediction": "I'm not sure if this is the case, but if it is the case, it's the case.", "reference": "Issue is that `currentMode = newMode;` is called at the end of the method. Passcode screen will come up, but since the activity thinks current mode is biometric check we don't check passcode when submitted." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Need change it back?" }, { "prediction": "This is a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a secret key. It's a", "reference": "Didn't we delete this file a while back because it isn't used but people think that it's a security vulnerability that it's checked in?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "nit: Looks like this can be removed now" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Can probably remove the lines above it too (L60-62), since ProvisionDefaultCA() makes sure the map isn't nil." }, { "prediction": "I don't think this is a bug, but it's a bug, and it's fixed.", "reference": "Do you think it's worth erroring out? It's likely that this is a configuration error that the user might want to know about?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I think the functional test should not change here, this is probably a test in itself :)" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Why this to be a public function?" }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "I think we can remove the timing for export env vars" }, { "prediction": "I think this is a bug. It is fixed in the latest release.", "reference": "wrong import grouping" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "There is a doubled semicolon ;)" }, { "prediction": "I'm not sure what you're trying to do, but it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it", "reference": "I'm wondering why this isn't . Seems like one would have to copy the md5.h file into the source tree somewhere for this to compile cleanly. Maybe you meant to use angle brackets instead of quotes?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "shouldn't **call** return a boolean?" }, { "prediction": "I'm not sure this is a bug, but it's a bug, and it's a bug.", "reference": "We don't need to cast to client here. (well, from spell gem not AA etc) We should also make sure the charm is a casted spell before calling SendSpellBarEnable." }, { "prediction": "I think this is a bug in Postgresql.", "reference": "This is not an `id`. This should either be `invocation_time` or `invocated_at` to be consistent with what we are using elsewhere, and also to better rerflect the column's DateTime type. Also, within the context of this table, there is no idea of what `invocation` is. I know that `scanner` may not be future-proof, but we need to find something more descriptive. Perhaps one possibility is to call this `audit_time`." }, { "prediction": "This function is to be used to calculate the fee for a transaction. If the transaction has no receiver, it returns the empty address. This function is to be used to calculate the fee for a transaction. This function is to be used to calculate the fee for a transaction. This function is to be used to calculate the fee for a transaction. This function is to be used to calculate the fee for a transaction. This function is to be used to calculate the fee for a transaction. This function is to be used to calculate the fee for a transaction. This function is to be used to calculate the fee for a transaction. This function is to be used to calculate the fee for a transaction. This function is to be used to calculate the fee for a transaction. This function is to be used to calculate the fee for a transaction. This function is to be used to calculate the fee for a transaction.", "reference": "should the 'Receiver' be the clawback address in case of clawback transaction?" }, { "prediction": "I'm not sure if this will help you, but I'm not sure if this will help you, but it might help you.", "reference": "@ashishranjan738 -- Where are these consts used? in which pkg?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "The only change I would suggest is moving these lines back below the `templates_path` variable to keep the diffs smaller." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Having it above kept the block info in the cached changes, which could end up confusing things quite a bit." }, { "prediction": "I think you need to do this in the `run_task` function.", "reference": "If the execute_task returns an `ExecutionResult`, the passing of a block would be unnecessary. Instead, the `ExecutionResult` could be presented to the user in some standardized way (iterating over the result of each node, etc.)." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Not sure why we make a new channel here. If we don't use this channel, how about creating it inside the `Connect`?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "There are two question here: 1. If you only modify lastLogId, but the `iter` is not modified, I really don't know whether we can succeed. 2. We will check the if the term has changed in `replicateLogs` (if rollback really happen, the term must have been updated), so I really doubt whether the problem should be fixed in this way. Or you could describe it in more details." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Hello @jDolba, I have reviewed your PR and I found one problem. `$step->getFormType()` can return `FormTypeInterface`. You cannot use interface as key for an array. Can you find some better way to fix this? Thank you." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "i was confused by keyword \"inventory\" here. my understanding is this starts the osconfig-agent which covers inventory lookup and package-management(correct me if i am wrong)." }, { "prediction": "I'm not sure if this is what you're looking for, but it's what we're looking for.", "reference": "These are really meant to be the keys in the capabilities, not the keys of values within the capabilities" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to import a function as h, render } from 'preact'; import { useEffect, useState } from 'preact/hooks'; +import sinon from'sinon'; import { setupScratch, teardown } from '../../../test/_util/helpers'; import { act } from '../../src'; import { setupScratch, teardown } from '../../../test/_util/helpers'; import { setupScratch, teardown } from '../../../test/_util/helpers'; import { setupScratch, teardown } from '../../../test/_util/helpers'; import { setupScratch, teardown } from '../../../test/_util/helpers'; import { setupScratch, teardown } from '../../../test/_util/helpers'; import { setupScratch, teardown } from '../../../test/_util/helpers'; import { setupScratch, teardown } from '../../../test/_util/helpers'; import { setupScratch, teardown } from '../../../test/_util/helpers'; import { setupScratch, teardown } from '../../../test/_util/helpers'; import { setupScratch, teardown } from '../../../test/_util/helpers'; import", "reference": "This breaks tests on IE because this will import an `esm` bundle. For that reason `sinon` is available as a global in our test suite and never imported. The global is aliased to the proper `es5` file." }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "Maybe move all the Loss Recovery constants to a separate file." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "this field is added so that we can find disk name by device name from attachments" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Unnecessary new line" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "First determine if the namespace already exists, so it's clearer that it's handling namespaces that aren't included in the `c.config.Namespaces`" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to render the download_type_key: \"OriginalFile\", download_type: \"original\", size_display: \"Original (720p)\", clip: clip %> - <%= render \"videos/download_link\", download_type_key: \"IphoneVideoFile\", download_type: \"iphone\", size_display: \"iPhone\", clip: clip %> - <%= render \"videos/download_link\", download_type_key: \"HdMp4VideoFile\", download_type: \"hd_mp4\", size_display: \"HD MP4\", clip: clip %> - <%= render \"videos/download_link\", download_type_key: \"HdMp4VideoFile\", download_type: \"hd_mp4\", size_display: \"HD MP4\", clip: clip %> - <%= render \"videos/download_link\", download_type_key: \"HdMp4VideoFile\", download_type: \"hd_mp4\", size_display: \"HD MP4\", clip: clip %> - <%= render \"videos/download_link\", download_type_key: \"H", "reference": "What changed in the styles that means we don't need this?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This pattern should be applied to the other instance where NewtonsoftEscapeJProperty is used and you can remove the NewtonsoftEscapeJProperty method." }, { "prediction": "I think this is a bug in holoviews 2.0. It should be fixed in holoviews 2.0.", "reference": "Something to mention in the next changelog/release notes. It will be good to get histogram working consistently with everything else." }, { "prediction": "I'm not sure if this is a bug or a bug, but it seems to be a bug.", "reference": "What does this contain? Is it PVC namespace or is it openebs?" }, { "prediction": "I'm not sure if this is a bug or a bug. I'm not sure if this is a bug, but I'm not sure if it's a bug or a bug.", "reference": "Design note: Using local concrete data types on a feature abstraction makes it hard to generalize / replace. This is tolerable so long as this remains a kestrel exclusive feature, but we'd need a different design if this were ever moved to HttpAbstractions." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "this will break R package, you should update the R files accordingly. BTW, the call state should be in the last argument." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "Shouldn't we throw an exception if the context is null instead?" }, { "prediction": "This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make.", "reference": "These should both be const, not var right?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this, and I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Rename the directory, match_costers -> match_costs" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "I don't think this should go in the model tests, since it is done in the resource. `PaginatedDeleteTest` seems more appropriate" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "It would be better to just change RWD to throw IllegalStateException if you attempt to execute a command after quit (unless it's a second call to quit())" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Could we move this to an example test to allow the compiler to help us ensure it stays up-to-date in the future?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Maybe we could update these to use $future and then check on stderr? that way when we deprecate stdout we can not have to delete tests." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Remove this since it always has to be set afterwards." }, { "prediction": "I'm not sure if this is what you're trying to do, but it should work.", "reference": "These two tests were causing us to use too many goroutines with `-race` using the default block change size, I think due to prefetching." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this.", "reference": "Is that `try..except` block really needed? I mean, when it could fail?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "If you only want to run a specific group of tests you can always use `.only` like `it.only()` or `describe.only()`. It may not speed up the globbing process as much as this change here :)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "nit: I'd probably rename this to `BATCH_SIZE_RANGES`, to use a slightly more descriptive name." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this. I'm guessing you're trying to do something like this. I'm guessing you're trying to do something like this. I'm guessing you're trying to do something like this. I'm guessing you're trying to do something like this. I'm guessing you're trying to do something like this. I'm guessing you're trying to do something like this. I'm guessing you're trying to do something like this.", "reference": "aren't these the wrong way around?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm sure it's a bug.", "reference": "Lets call this getConfigSetService and maybe rename the field now (or later)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're looking for something like \"k8s.io/klog/klogr\" or \"k8s.io/klog/v2/klogr\" or \"k8s.io/klog/v2/klogr\" or \"k8s.io/klog/v2/klogr\" (or \"k8s.io/klog/v2/klogr\" or \"k8s.io/klog/v2/klogr\" or \"k8s.io/klog/v2/klogr\" or \"k8s.io/klog/v2/klogr\" or \"k8s.io/klog/v2/klogr\" or \"k8s.io/klog/v2/klogr\" or \"k8s.io/klog/v2/klogr\" or \"k8s.io/klog/v2/klogr\" or \"k8s.io/klog/v2/klogr\" or \"k8s.io/klog", "reference": "Could / should we make these constants and give them a type?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "lets stick with lowercase for consistency." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "ordering of imports went wrong" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "I think these can all be.name() to get the value we are looking for" }, { "prediction": "I'm not sure if this is what you're looking for, but it's worth noting that this is what you're trying to do.", "reference": "Is this a good place for these test cases?" }, { "prediction": "I think this is what you're looking for. I'm not sure what you're looking for, but I'm not sure what you're looking for.", "reference": "Did you mean to leave the print statement?" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "I would do `new BN(Interpreter.LOCKTIME_THRESHOLD)`" }, { "prediction": "I think this is a bug. It's a bug. It's a bug. It's a bug. It's a bug.", "reference": "@ftomassetti I turned the tree walking algorithms into iterators so you don't have to visit every node when you only wanted a few, like for a `findFirst`." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "Need to add type name here to be compatible with proto string representation." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "This is to let people know that the tooling is doing something during a build. Please leave." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Why is the principal changing here?" }, { "prediction": "The AZURE_BLOB_DOMAIN can be used to provide a blob storage domain to use. If you don't specify the AZURE_BLOB_DOMAIN, you'll need to provide a blob storage domain. If you don't specify the AZURE_BLOB_DOMAIN, you'll need to provide a blob storage domain. If you don't specify the AZURE_BLOB_DOMAIN, you'll need to provide a blob storage domain. If you don't specify the AZURE_BLOB_DOMAIN, you'll need to provide a blob storage domain. If you don't specify the AZURE_BLOB_DOMAIN, you'll need to provide a blob storage domain. If you don't specify the AZURE_BLOB_DOMAIN, you'll need to provide a blob storage domain. If you don't specify the AZURE_BLOB_DOMAIN, you'll need to provide a blob storage domain. If you don't specify the AZURE_BLOB_DOMAIN, you'll need to provide a blob storage domain. If you don't specify the AZURE_BLOB_DOMAIN, you'", "reference": "Naming nit: let's use `AZURE_STORAGE_` prefix for consistency with the other ones." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "I'm a bit confused. We have an actual `ProgressBar` Uppy React wrapper component that we are testing. Why do we need a mock for it?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "can we use `github.com/pkg/errors`?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this. I'm not sure what you're trying to do here, but I think you're trying to do something like this. I'm not sure what you're trying to do here, but I'm assuming you're trying to do something like this. I'm not sure what you're trying to do here, but I'm assuming that you're trying to do something like this. I'm not sure what you're trying to do here, but I'm assuming that you're trying to do something like this. I'm not sure what you're trying to do here, but I'm assuming that you're trying to do something like this. I'm not sure what you're trying to do here, but I'm assuming that you're trying to do something like this. I'm not sure what you're trying to do here, but I'm assuming that you're trying to do something like this. I'm not sure what you're trying to do here, but I'm assuming you're", "reference": "I changed the name of the arguments here just to help make the code clearer." }, { "prediction": "I'm not sure what you're trying to do here, but I think it's a good idea to use a Callable instead of a DynamicMap. It makes it possible to wrap DynamicMaps with streams and makes it possible to traverse the graph of operations applied - to a DynamicMap. It makes it possible to wrap a DynamicMap with streams and makes it possible to traverse the graph of operations applied - to a DynamicMap. Additionally a Callable will memoize the last + returned value based on the arguments to the function and the + state of all streams on its inputs, avoiding calling the function + unncessarily.", "reference": "I think either 'avoiding calls to the function' or 'to avoid calling the function...' would be read better." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "@sfricke-samsung -- thanks. saves a few atomic ops which is always good :) The TODO is there to track that this object is storing *both* vectors of shared_ptr and plain pointers to the same data. The shared are to ensure scope, and the plain are for backwards compatibility with existing code that consumed a plain pointer vector (and some code that still does). That should be cleaned up." }, { "prediction": "The Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Nethermind Neth", "reference": "minor: typo (knowMetricsTypes -> knownMetricsTypes)" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "This adds a case-insensitive flag to the type in the RangeSpec, but I don't think RangeSpecs are written to handle case-insensitive comparisons. Take a look at the methods that deal with comparisons when building RangeSpecs, in file Range.cpp. So, I think you would have to do one of two things: a) disable the RangeSpec transformation for case-insensitive comparison operators (the easy way) or b) change the RangeSpec methods to handle case-insensitive comparisons." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "I would throw an exception if the type is not solved" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "if remove `dt.skipLoad` - then this tests will run. You probably mean opposite?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I feel like we do this in a lot of places should we move that out into its own PR?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Already asked you in Matrix, but I'll do it here again so it can be discussed publicly. Why?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "I think here should be a comma before remove, in all the cases" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here. I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Single quote is used by default in this project." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "S1023: redundant `return` statement (from `gosimple`)" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "`ctx` is unused in Close" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "I'm confused. This exception is thrown when `HeurekaCategory` is not found in database. But this exception extends Http exception. Why? What has database search common with http? If the only reason is that it is the same in the whole project, then fine. But then we have even bigger problem - we don't know how to use exceptions." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Is it necessary to add the suffix `on_head`, because it belongs to` bbox_head`?" }, { "prediction": "If we have a GRUB version newer than 2.02 (default: no), then ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Hmm, I wonder if this should just be e.g. `--with-grub-2.02` instead. (Not sure Autoconf supports periods in these switches.) Today's modern GRUB is tomorrow's ancient GRUB. :) Or maybe we should be specific about the feature this is enabling, which might be safer given that each distro carries so many patches. E.g. `--without-grub-efi-16-suffixes`?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Add a GetSerialPortOutput method to Instance that way you don't need to access the client, also it makes the call cleaner as you don't have the odd i.Client and path.Base(i.Project), path.Base(i.Zone)" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to redirect to a different URL. I'm not sure what you're trying to do, but I'm guessing you're trying to redirect to a different URL. I'm guessing you're trying to redirect to a different URL, but I'm not sure what you're trying to do.", "reference": "Line is too long. [104/80]" }, { "prediction": "I'm not sure if this is what you're trying to do, but it should work.", "reference": "Since CD updates (assignment & power state) are now done in this controller..." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Hmm I'd rather not support this option going forward - it seems like a one-off just to work around this particular issue. Would it be fine to just remove the `deepStackTrace` option? The rest of the PR looks great - I love the idea of switching to sets." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "on the one hand I like how little this is doing. On the other hand, `inbound_mail_parser` is doing most of the work here so maybe it's not as helpful as I originally thought" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "This line is too long" }, { "prediction": "I think this is what you are looking for, but I'm not sure if this is what you're looking for.", "reference": "This isn't a fatal error, we don't want to crash just because we can't set configs, we have sane defaults set" }, { "prediction": "I'm not sure if this is what you're looking for, but it's probably what you're looking for.", "reference": "I wondered why `buffer` was passed into `LookupPath`. What is happening here? Is `buffer[:0]` equivalent to `[]V4TrieEntry{}`, and hence `buffer` isn't needed any more?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for, but I think it's what you're looking for.", "reference": "I don't really like the name of this file, especially the encoding of an implementation detail (the fact that it's a table) in the name. Can we just use `_message_body.html.erb` instead maybe?" }, { "prediction": "I'm not sure if this is the case, but I think it's the case. I'm not sure if this is the case, but I think it's the case.", "reference": "Feel better not to expose our internal implementation in API/CRD, so no need to mention agent here. Consider: EnableLogging indicates whether or not to generate logs when rules are matched. Default to false." }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "use `NebulaKeyUtilsV3::dataVersionValue()` to replace the literal value?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here. I'm not sure what you're trying to do here.", "reference": "No need for the `\\` here, inside parentheses whitespace is ignored by Python." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "This doesn't seem like the right expected result... it should be the same as the `clientCert` var defined above." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "need to rename this now." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, and it's a bug.", "reference": "NIT: This shouldn't be a TODO. It is just a note isn't it?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I changed this to an error, that seems more appropriate than a warning here." }, { "prediction": "I think this is what you are looking for. I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "This change could mute unit test failure, but it is better to update unit tests" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "All other places that access `notificationIdsInUse` are in methods with descriptive names. We should do the same here. Maybe `markNotificationIdAsFree()`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "keep as `ErrNotFound`, it is the same convention as in other packages" }, { "prediction": "I'm not sure if this will work, but I'm not sure if this will work, so I'm not sure if this will work.", "reference": "Same here, we need to call `callback` in else branch" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I'm not sure if it's the correct way to do it.", "reference": "At this point we already check that the record is valid and so it could never be nulll" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Would it not be more sensible just to move setting of the title to later in the method rather than duplicating it here?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like it's a bug.", "reference": "why not do it in `reclaimExpiredSessions`? and `pushSessionToCache` can delete" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "out_channels/num_outs/type are unnecessary" }, { "prediction": "I think this is a bug, but it's a bug, and it's a bug, so it's a bug.", "reference": "You can create an issue for it and put it on the backlog so we don't forget it." }, { "prediction": "Weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave CIDR, weave C", "reference": "So now we are checking twice, both here and in `weaveCIDRsFromConfig`. Not great. I suggest changing the `ok` return of `weaveCIDRsFromConfig` to a messsage (or error?) instead, which we can then log." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think you're trying to do something like this.", "reference": "An alternative to setting format to the default in Package.__init__ would be to set it in create_package. I think we can assume all packages are created by create_package, but not necessarily by build_package." }, { "prediction": "I think we are proposing in case we are proposing during proof-of-stake and we are supplied with header fields already +type PresetHeaderFields struct { + Timestamp uint64 + Random common.Hash +} + type MiningState struct { MiningConfig *params.MiningConfig PendingResultCh chan *types.Block MiningResultCh chan *types.Block MiningResultCh chan *types.Block MiningResultCh chan *types.Block MiningResultCh chan *types.Block MiningResultCh chan *types.Block MiningResultCh chan *types.Block MiningResultCh chan *types.Block MiningResultCh chan *types.Block MiningResultCh chan *types.Block MiningResultCh chan *types.Block MiningResultCh chan *types.Block MiningResultCh chan *types.Block MiningResultCh chan *types.Block MiningResultCh chan *types.Block MiningResultCh chan *types.Block MiningResultCh chan *types.Block MiningResultCh chan *types.Block MiningResultCh chan *types.Block MiningResultCh chan *types.Block MiningResultCh chan *types.Block MiningBlock *Mining", "reference": "Let's add fee recipient as well." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this: # pylint: disable=super-init-not-called def suggested_filename(self): return os.path.basename(self.filename) # pylint: enable=super-init-not-called def suggested_filename(self): return os.path.basename(self.filename) # pylint: disable=super-init-not-called def suggested_filename(self): return os.path.basename(self.filename) # pylint: enable=super-init-not-called def suggested_filename(self): return os.path.basename(self.filename) # pylint: disable=super-init-not-called def suggested_filename(self): return os.path.basename(self.filename) # pylint: disable=super-init-not-called def suggested_filename(self): return os.path.basename(self.filename) # pylint: disable=super-init-not-called def suggested_filename(self): return os.path.basename(self.filename) # pylint: disable=super-init-not-called def suggested_filename(self):", "reference": "No need for those with `super-init-not-called`, as pylint already only turns things off for this function and it's needed for the entire function." }, { "prediction": "I'm not sure if this is the correct way to do it.", "reference": "I think there's another spot for this in DefaultCapabilityMatcher" }, { "prediction": "I18n.t(\"decorators.steps.approval.status.waiting\") + I18n.t(\"decorators.steps.approval.status.waiting\") + I18n.t(\"decorators.steps.approval.status.waiting\") + I18n.t(\"decorators.steps.approval.status.waiting\") + I18n.t(\"decorators.steps.approval.status.waiting\") + I18n.t(\"decorators.steps.approval.status.waiting\") + I18n.t(\"decorators.steps.approval.status.waiting\") + I18n.t(\"decorators.steps.approval.status.waiting\") + I18n.t(\"decorators.steps.approval.status.waiting\") + I18n.t(\"decorators.steps.approval.status.waiting\") + I18n.t(\"decorators.steps.approval.status.waiting\") + I18n.t(\"decorators.steps.approval.status.waiting\") + I18n.t(\"decorators.steps.approval.status.waiting\") + I18n.t(\"decorators", "reference": "this name seems pretty vague -- thoughts on a more descriptive method name?" }, { "prediction": "The OpenTelemetry Authors License is not licensed under the Apache License, Version 2.0 (the \"License\") and will be removed in future versions of the OpenTelemetry Authors.", "reference": "what changed in this line?" }, { "prediction": "I'm not sure if this is a bug, but I think it is a bug.", "reference": "Instead of doing this let's add another function similar to `hasZeroData` for selecting the `reportArgs` since this is all sourced from selected values. Then `hasZeroData` can use this internally, as well as the component itself. Since this function would be internal just for the purpose of avoiding duplication, we don't need to expose it on the component the same way though." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "This line was useful for auto-completion, I think it should be re-added with specifying the var name (`$exception`) and simplifying the FQCN." }, { "prediction": "I'm not sure if this is the case, but if it's the case, it's probably the case.", "reference": "This looks like you're not collecting everything from the error channel." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "This currently violates the Law of Demeter. Using `checkout.plan_name` is the quick resolution." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "is there any scenario when `$temporaryFilename` can be null?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "this is for the `boolean isRoot = root == rowType` check, which seems to be on purpose, but maybe you could double check whether using ref. equality here is still wanted? Same for `SparkTypeToType`" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "No need to damage after `roots_drag_icon_update_position`, this is already done in `roots_drag_icon_update_position`" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Have you tested exporting to ONNX with `device=cuda`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "Do we also need to validate `envName` flag then? `appName` and `envName` are used in `initLogsSvc` which are called by `svc logs` from within `Execute()`" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this: I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "@LukeTowers I think I would prefer that we don't force it, on the basis that: a) some people would be opting to configure their web server to protect against this kind of attack and would disable this feature in October CMS to get a small performance increase. b) it might be a bit misleading to say that `app.trustedHosts` set to `false` disables the feature entirely, just to have it be overridden here regardless." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case.", "reference": "i like that you are trying to correct the naming, but its making the PR longer :( i guess in future we can do such changes in separate PRs" }, { "prediction": "This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything This is a label of everything", "reference": "Are we marking what the browser's accessibility tree says or what screen readers with those browsers say?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "This method should behave as intended, to block until it reads an EOF from the other side." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "I prefer starts with `Failed to xxx`, how about `Failed to perform health check on xxx`?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but if I'm correct, I'm not sure if I'm correct, I'm assuming I'm correct.", "reference": "All these calls make me think we should refactor how traces are started and allow \"source tags\" that we initialize a trace with. I'd like to do this in a follow up." }, { "prediction": "This file is autogenerated via the builtin command.", "reference": "This file shouldn't be in this PR" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "This now causes `LessSpecificReturnStatement - src/somefile.php:9:32 - The type 'non-empty-list<5|string>' is more general than the declared return type 'non-empty-list' for takesList`, which seems correct to me. The type `non-empty-list<5|string>` contains the type `non-empty-list`. Thoughts?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Are you going to change that back?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "we have a standard format for putting these together elsewhere, it does the filter check first and errors out and then sets based on the value. i think this should be adjusted to do that. there's no logical change, just an approach change." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Note this should be `delay` instead of `scale` here. I'll fix this in my branch." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'll try to fix it.", "reference": "`on` likely still needs a bind, similar to `this.resetProgress = this.resetProgress.bind(this)` correct?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Considering the trade-off between training speed and accuracy, multi-scale training is temporarily kept. More elegant implementation will be adopted in the future." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Can you move this up along with the other builtin libraries?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I actually think it makes sense to reposition this checkbox after the notifyForPendingUpdateCheckBox. The current order of check boxes is a bit arbitrary now." }, { "prediction": "` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Why do we have both `before` and `after`? Naively I would expect this to work as follows: `plz query changed` with no arguments compares the current working directory state to the last commit (i.e. HEAD, i.e. a noop when directly on a git commit). `plz query changed --since [reflike]` compare the current working directory state to the given reflike. So for CI I would expect to run something like `plz query changed --since @{upstream} (or origin/master I guess)`. And on merge I'd either run everything or just `plz query changed --since HEAD^` (given our workflow) - I don't think I'd ever want to do anything else. Either way I think before and after are slightly confusing terms here." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for, so I'm not sure what you're looking for.", "reference": "Is there a reason why we can't use `~dst`? It feels like that could be good enough.I would like to avoid extending the filter syntax unless there's an urgent need. :)" }, { "prediction": "I'm not sure if this is the correct way to do it, but it's the correct way to do it. I'm not sure if this is the correct way to do it, but it's the correct way to do it.", "reference": "Why local and not UTC?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "2012 is a retryable error. Will avoiding rgenerating it here cause a difference in behavior in createServer()?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "move to line 14 below" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but I think it's what you're looking for.", "reference": "the method name should match teh docs" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "Won't this happen automatically when we flip the default version in the config?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "This would also change back to /var/www/html/docroot if we go that way." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, I'm guessing it's a bug.", "reference": "This still needs to use the new option. We'll need tests for it too." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "We are no longer including file name in the source files." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "no need for this. Devise provides us with `current_user` and `user_signed_in?` helpers." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I'm sure it's what you're looking for.", "reference": "Would `Object.equals(capability.getName(), NAME)` would be safer, as you wouldn't have to do null checks?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "Hmm, I wonder if we should revert #1862 instead? BTW, what failure do you get w/o this line?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "since there are several places where we do 1) get secret key ref and 2) validate URL, maybe it's worth having a common method? it could also trim spaces as done here (but not at the other places currently)." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "TestNormalize... I would also split them" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "All changes to this file are going to conflict with #7599. Please revert these as well. They will be addressed during the Python 3 transition." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Just thought, using spinlock (busy wait with compare and swap) that generates 2 random numbers inside rlock. We know that collisions are rare and we don't need that \"large\" write lock really but lock namely for \"rand\". Or least use a separate Lock (Mutex), namely for \"rand\" (wrap it into method). Mutex will use some sort of spinlock as well but it may use some linked list to make it more fair." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "Can we grab it directly from `__pkginfo__` as that is the source of truth for the version?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "We can revert this to reduce the diff of the PR." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "This looks weird. `isCloud` should define if it is a cloud or no. Here it does it partially, and it can be overriden by protoPkg value (which also an argument to this function). Please make sure that isCloud completely defines the cloud thing. (i.e. it an be as straightforward as moving `protoPkg.contains(\"cloud\")` from here to the place where `assembleGoImportPath` is called." }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "Declaring fileflags to be of type LobTgtFileFlags would eliminate the need for all this casting. And would be safer. (Not a show-stopper though.)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "This change prevents a user understanding how their server is configured. Best to leave at `info` level." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Typically we would add something to the build system environment to differentiate this; also is there an alternative that can be used with older OpenSSL? Other folks who are committers will need to decide if it is worth supporting an older and likely quite vulnerable (to hacks) OpenSSL library." }, { "prediction": "@ -367,7 +367,7 +367,7 +367,7 +367,7 +367,7 +367,7 +367,7 +367,7 +367,7 +367,7 +367,7 +367,7 +367,7", "reference": "`readActiveBlockProducersByHeightTests` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Falls back on `Constants.ID` if there's no custom field set." }, { "prediction": "We don't care what the error is, but we don't care what the error is, so we don't care what the error is.", "reference": "I believe this is what we want to rearrange: this in.skip() should not be happening here, in the open method, but in the setOffset() method itself. Because we want to be able to change that offset after the initial open. The setOffset() method will need to throw an IOException, if it's called while the InputStream is still null; or if the skip() call itself results in an IOException()" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, it's a bug.", "reference": "In case the method is `void`, there won't be any children and `getChild(0)` throws. We'll need to check with `isVoid()` for that case. I'll update this when I merge." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "If the yarpc.Interceptors wrapper will be added to any user interceptor, why not do it transitively. Can save one step for users. Same apply to filter." }, { "prediction": "I'm not sure if this is the correct way to do it, but it's the correct way to do it. I'm not sure if this is the correct way to do it, but it's the correct way to do it, so I'm not sure if it's the correct way to do it.", "reference": "Is there anything we should do in the event we're unable to renaming the directory?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's not a bug. It's a bug. It's a bug. It's not a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug.", "reference": "How is this env var populated? Can this be retrieved from cluster metadata?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Should probably skip the success event here, since it could be a noop." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "I added this here because people cards (which depends on cardBuilder) had this added in blurhash. Not sure when this is used though cc @JustAMan" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Let's keep this line in the docstring, to let end users know they shouldn't be using this directly." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "can do the same for other validateXXX()" }, { "prediction": "Is there a way to return a value from `get_participant()`?", "reference": "Why is this necessary?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Please move this import upper to other similar imports" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, so I'm not sure if it's the case. I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case. I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case. I'm not sure if it's the case, but I think it's the case.", "reference": "Include the key word \"translated\". Otherwise the reader will find this confusing." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "why. is this called per request? if so this also adds a lock internally. can we not add this at the moment until analyzed as this assumption isnt carried to the several other impls. the only other consumer of this is the http api and that isnt hit often enough for specializations." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "I believe this means dependent checks can no longer operate on virtual nodes, which is something we've been pushing for lately. We may need to find a different way to solve this issue, as I don't think we want to cause a regression while fixing a bug." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "ditto about use of `abspath`" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "this reduces the runtime by 50 times" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "Probably best not to have an empty test...." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do.", "reference": "direct `newInstance` call is also deprecated now" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing you're looking for something like \"k8s.io/client-go/kubernetes\" or \"k8s.io/client-go/rest\" or \"k8s.io/client-go/tools/cache\" or \"k8s.io/client-go/tools/cache\" or \"k8s.io/client-go/tools/cache\" (or \"k8s.io/client-go/tools/cache\" or \"k8s.io/client-go/tools/cache\" or \"k8s.io/client-go/tools/cache\" or \"k8s.io/client-go/tools/cache\" or \"k8s.io/client-go/tools/cache\" or \"k8s.io/client-go/tools/cache\" or \"k8s.io/client-go/tools/cache\" or \"k8s.io/client-go/tools/cache\" or \"k8s.io/client-go/tools/cache\" or \"k8s.io", "reference": "We have a bit of a convention where imports are split into three blocks: first Go standard library, then imports from outside the repo, then imports from inside the repo." }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "Why was this change needed?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, so I'm not sure if it's the case, but if it's the case, it's the case.", "reference": "can you use this opportunity to remove `.readlines()` useless list creation? (`addresses = [l for l in fd if l.find(\"netmask\") >= 0]`)" }, { "prediction": "The plan was expected to mention the host #{node.hostname} with _output but did not\" assert_match(/#{node.hostname}\",\"status\":\"success\"/, result.stdout, message) assert_match(/#{node.hostname}\",\"status\":\"failed\"/, result.stdout, message) assert_match(/#{node.hostname}\",\"status\":\"failed\"/, result.stdout, message) assert_match(/#{node.hostname}\",\"status\":\"failed\"/, result.stdout, message) assert_match(/#{node.hostname}\",\"status\":\"failed\"/, result.stdout, message) assert_match(/#{node.hostname}\",\"status\":\"failed\"/, result.stdout, message) assert_match(/#{node.hostname}\",\"status\":\"failed\"/, result.stdout, message) assert_match(/#{node.hostname}\",\"status\":\"failed\"/, result.stdout, message) assert_match(/#{node.hostname}\",\"status\":\"failed\"/, result.stdout, message) assert_match(/#{node.hostname}\",\"status\":\"failed\"/, result.stdout, message) assert_match(/#{node.hostname}\",\"status\":\"failed\"", "reference": "Why does this check differ from `plan_ssh.rb`?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "It was @lodejard who initially suggested this pattern. I think that it had something to do about prioritizing future writes even if there was a pending write operation ready to handle the newly requested write. I'm not sure I fully understood the explanation for having up to 3 pending write requests, because only having one queued write at a time still makes sense to me. I'll talk to him about it." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this: (debug_bootstrap_generate, \"Generate bootstrap sequence of blocks\") (debug_bootstrap_generate, \"Generate bootstrap sequence of blocks\") (debug_bootstrap_generate, \"Generate bootstrap sequence of blocks\") (debug_bootstrap_generate, \"Generate bootstrap sequence of blocks\") (debug_bootstrap_generate, \"Generate bootstrap sequence of blocks\") (\"debug_clear_online_weight\", \"Clear online weights table\") (debug_dump_online_weight\", \"Dump online weights table\") (\"debug_dump_representatives\", \"List representatives and weights\") (\"debug_account_count\", \"Display the number of accounts\") (\"debug_mass_activity\", \"Generates fake debug activity\") (\"debug_account_count\", \"Display the number of accounts\") (\"debug_account_count\", \"Display the number of accounts\") (\"debug_account_count\", \"Display the number of accounts\") (\"debug_account_count\", \"Display the number of accounts\") (\"debug_account_count\", \"Display the number of accounts\") (\"debug_account_count\", \"Display the number of accounts\")", "reference": "We have cli --online_weight_clear in cli.cpp" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "So the request.Headers is a map of []string. Are you sure that the HTTP library doesn't already do this split for us?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "How is this message used? Can we remove the \"crashed executor/container\" part which is an implementation detail?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Instead of building in routing for a browser-specific command, could you refactor the HttpCommandExecutor to allow arbitrary commands to be registered?" }, { "prediction": "@purchaseable.video_available_on(@video) is not available yet. It will be available in the future.", "reference": "Space after `=`." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "if just need to do something after createInvocation just override and call super first is enough?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "By the way, I fixed `announce` method (missing `super` call to announce JDK version)" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug.", "reference": "I'm not sure about that... This line can produce ClassCastException if Comparator do not check this." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "There wasn't any special reason for this to return a pointer, right?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Why the need for a `ConcurrentHashMap`?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this. I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "New code should use strict equality `===`" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "`expect(resources['Notify[local pid]']['events'][0]['desired_value']).to match(/(\\d+)/)` seems clearer." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's worth it.", "reference": "Removed now-unneeded param." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "(NON-blocking, this can be tracked in follow up issue) @anorth @mishmosh is the toplevel getting too crowded? Should we have a `network` grandparent command, or maybe a `stats` command?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but I think it's what you're looking for.", "reference": "The `_x` function needs to be imported at the top of the file (in addition to `__`)" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "This is functionally equivalent to the code it replaces." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "can you change the field name here to \"InterfaceAssociationProtocol\"? same for the Config struct in agent/ecscni/types.go. i think it's better to keep the field name consistent between agent and acs payload" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "See above, same for the other cases." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Shouldn't line 313 be public \\ SettableGauge\\ **settable**Gauge(String name) {? It would also be good to call it a few times and with differnet types (Long, Integer, String) in the test as well." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "I would prefer to just fix the occurences of this new check rather than disable them" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug or a bug.", "reference": "The tests should be fixed in #4841, so this is no longer needed" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "I think it should been in `SharedKernel` module." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to override NginxIngressWhitelistAnnotation, but you're trying to override NginxIngressWhitelistAnnotation, which is not what you're trying to do. I'm guessing you're trying to override NginxIngressWhitelistAnnotation, which is not what you're trying to do here.", "reference": "Can we add some description for this field?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do.", "reference": "Should its name be Time or Duration? I can see them both." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "Is this used anywhere?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "I believe that you can use `assert` instead of `require` here and in the following lines" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "In `storagemarket.go` you used `nil` for an unwanted out parameter. Do something consistent (nil seems fine if supported)." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing it's just a typo, but I'm not sure if this is what you're looking for.", "reference": "is this a new pattern we use in bee? interesting" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "If you think this PR works, i'll clean this up before resubmitting." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "are you sure you can read version by this artifactid?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "We can get rid of this import then." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Should we do our own vtable?" }, { "prediction": "I think this is a bug in Rails. I'm not sure if it's a bug, but it's a bug in Rails. I'm not sure if it's a bug, but it's a bug in Rails. I'm not sure if it's a bug in Rails.", "reference": "This is the actual fix." }, { "prediction": "I think this is what you are looking for.", "reference": "If sync has really a negative impact, this is just moving the issue from 10sec to 60sec. Wonder if you should not expose the (auto)sync params so users can decide." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this.", "reference": "should be called => will be called" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "not sure whether we should do this. It may cause problem that delegates upgrade their nodes at different time, that they will have different \"last block time\", some use \"commit time\", some use \"block time\". Potential solution: Only use block time after berling, and then delete it in the next version after berling. Open to discussion." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "So one question I have is why is the error coming back from `buildReplicaPositions` not an `Assign.AssignmentException`? Is it because it is wrapped in a `SolrException` from the remote node?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "`dt` won't work for some reason?" }, { "prediction": "I'm not sure what you're trying to do here, but I think this should be enough.", "reference": "Is this because \"KOALAS_USAGE_LOGGER\" can be `None`??" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "I like it but maybe the better name will be EthGasPriceConstants or EthGasPriceEstimatorConstants? but Constants not Config" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I would inline the constructor as well" }, { "prediction": "I'm not sure I'm getting this right, but I'm not sure I'm getting it right, so I'm not sure if I'm getting it right, but I'm not sure if I'm getting it right, so I'm not sure if I'm getting it right, so I'm not sure if I'm getting it right.", "reference": "I'm not confident about this..." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "There is also `v1alpha1.CertificateRequestKind` I think?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "Can we rename it to make it less confusing? Instead of \"sender-gcpbroker\", maybe name it to \"retryable-sender\"" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "So looking at the definition of the `literal()` function in this class, it seems it's possible for it to return null. I guess it's not a concern as we would get NPE on the above call at line 136 when trying to call `.to` if `literal()` returned `null` before even getting to this part that calls `literal().value()`, but something I thought I'd bring up. Perhaps something we might follow up on in another issue or possibly I just missed the workflow that makes `literal()`'s result non-null by the time this `bindLiteralOperration` is called." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, so I'm not sure if this is what you're looking for.", "reference": "Why did you break the line? It looks like it is under 80 characters without the break and it is inside parens so no need for backslash anyway" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "@guolinke Don't you mind to rename this variable to `DATATABLE_INSTALLED`, for the consistency with other variables (for example, there are `PANDAS_INSTALLED` but not `PD_INSTALLED`). Also, `DT` is a little bit confusing: sometimes `dt` is used for `datetime`." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "We're fine with double quotes here. Just for future reference." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "can we keep this around? We should make sure we can distinguish between properly wrapped errors and \"unwrapped\" errors" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "`RecordPipelineShaderStage()` might change `topology_at_rasterizer `, according to shader code, so we should check `pInputAssemblyState `first." }, { "prediction": "I'm not sure what you're trying to do, but it seems like you're trying to do something like this: I'm not sure what you're trying to do here, but it seems like you're trying to do something like this:", "reference": "Should we just inline the assets here? I can't think of an advantage to having them in a separate file." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "detectStaleEndpoints to be more specific?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Please create a new issue for addressing this (if there isn't one already), so it doesn't get lost." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Nothing was ever coming out of this channel because its already being consumed. Create a new channel here and feed it in HandleNewHead method." }, { "prediction": "I think this is what you're looking for: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/GetPolicy.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/GetPolicy.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/GetPolicy.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/GetPolicy.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/GetPolicy.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/GetPolicy.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/GetPolicy.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/GetPolicy.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/GetPolicy.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/GetPolicy.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/GetPolicy.html https://", "reference": "AWS Identity and Access Management (IAM)" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "This is deliberately at this level." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "payload entered on command line is in hex-encoded format should use same processing as in ioctl/cmd/action/actiontransfer.go" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "should this be kept in the `else` branch?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Why not put this below \"strings\"?" }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "Make it `internal` if it's just for testing." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "What is triggering this message in this file?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Are you sure this should be removed?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're trying to create a new instance of the DefaultTrustedSocketFactory class. If this is what you're trying to do, then you'll need to create a new instance of the DefaultTrustedSocketFactory class.", "reference": "What's that good for? The field is initialized in the constructor." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're trying to close the connection, so I'm not sure if this is what you're looking for.", "reference": "This shouldn't be necessary (same below). Do you have a traceback for me?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "No newline needed here." }, { "prediction": "I'm not sure if this is what you're looking for, but it looks like you're looking for something like this:", "reference": "Why a separate block?" }, { "prediction": "@ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @", "reference": "Probably better to ask @AssadHashmi or another AArch64 expert for a review rather than me -- @AssadHashmi if you could confirm that these status registers are 64-bit despite having only a few fields?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "`purpose` and `coin_type` and `account` would mimic the BIP-0044 wording, but it's up to you." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I'm sure it's what you're looking for.", "reference": "Is this the critical change? It does seem wrong to use Select() instead of Checked = true. Not sure why that would pass sometimes and not others, though." }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "Seems a little low, but is this an installer default?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "Maybe we could provide our own `configure` function that includes `logger._logger = None` because I don't see a use case in kinto for using `reset_logger` besides configuring the logger." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "This will cause the same breakage that was caused when we added Proof to Block. Be sure to let people (infra?) know ahead of time" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Fixed the test; @strib want to validate that this is okay? Seems to be consistent new GC behavior." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Afaict, nothing cares" }, { "prediction": "I'm not sure if it's needed, but I think it's a bug.", "reference": "I must be missing something, but why does not having a node cache imply not neededing to re-embed the block changes, in particular? Isn't it just the fact that we don't do any writes?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Are these changes from `class` to `struct` breaking if called from an older version of `Datadog.Trace.ClrProfiler.Managed`?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "These are just aliases now" }, { "prediction": "@@ -1,4 +1,4 @@ -<% content_for :page_title, @video.title.html_safe %> <% content_for :landing_page_back_link do %> <%= link_to '← All Videos'.html_safe, '/the-weekly-iteration' %> <%= link_to '← All Videos'.html_safe, '/the-weekly-iteration' %> <%= link_to '← All Videos'.html_safe, '/the-weekly-iteration' %> <%= link_to '← All Videos'.html_safe, '/the-weekly-iteration' %> <%= link_to '← All Videos'.html_safe, '/the-weekly-iteration' %> <%= link_to '← All Videos'.html_safe, '/the-weekly-iteration' %> <%= link_to '← All Videos'.html_safe, '/the-weekly-iteration' %> <%= link_to '← All Videos'.html_safe, '/the-weekly-iteration' %> <%= link_to '← All Videos", "reference": "Does this mean we can remove `raw` from `_head_contents` partial?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "`isDestroyed` is a function, not a property. This condition will always return false." }, { "prediction": "This is not a bug, but it is a bug.", "reference": "Why are we adding these versions?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "fyi, you can do this by doing `.info(\"string %s %s\", formatparam, formatparam2)` instead of doing a string format with `\"str\" % (params)` the idea is that it'll only do the string interpolation if logging is enabled for this level, which theoretically is an optimisation, but in this case probably isn't important" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Would this work, as a one liner? `setTimeout(window.location.reload, 5000);`" }, { "prediction": "I'm not sure if I'm missing something, but I'm not sure if I'm missing something.", "reference": "Can you move `crypto/tls` into the block at the top with all the other stdlib imports?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "What is the motivation for this change?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "OK, so the concrete implementation will loop? But then it's important that this method waits for a while before it returns no messages. To be specific, a GCP implementation that set `ReturnImmediately` to true or false would both satisfy this requirement, but the first would cause busy-waiting." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "The data structure of `MatchClauseContext` may need to be redesigned." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "You say on the issue that something has to be receiving while the messages are being published. But here it's possible that the publish goroutine starts, and maybe even completes, before Receive is ever called." }, { "prediction": "I think this is a bug in ProposalsController. It should be fixed in ProposalsController.rb.", "reference": "how do we know that the step in question is an approval type step?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug, so I'm not sure if it's a bug.", "reference": "JMX offers normal APIs for this. I don't think you want the glassfish one." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, then it's a good idea to use a library like io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vavr.io.vav", "reference": "Is this still Java 8 compatible? @danieldietrich do we need a separate, modularized Java 9 release also?" }, { "prediction": "I don't see the hsa_ext_image_create_with_layout() in the hsa_ext_image_create_with_layout() function. I'm not sure if it's the hsa_ext_image_create_with_layout() function. I'm not sure if it's the hsa_ext_image_create_with_layout() function. If it's the hsa_ext_image_create_with_layout() function, I'm not sure if it's the hsa_ext_image_create_with_layout() function. If it's the hsa_ext_image_create_with_layout() function, I'm not sure if it's the hsa_ext_image_create_with_layout() function. If it's the hsa_ext_image_create_with_layout() function, I'm not sure if it's the hsa_ext_image_create_with_layout() function. If it's the hsa_ext_image_create_with_layout() function, I'm not sure if it's the hsa_ext", "reference": "Should update the user input address and filter modes and pass those in fillSamplerDescriptor?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "This object should be in `lib/music/show.rb` and you should also wrap this object in the `Faker::Music::Show`." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I think logic will have to move to bolt since the vague discussions around bolt run plan --noop is that it would just skip any tasks that don't support_noop rather than error. This is fine until we actually elaborate that though." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "File is not `goimports`-ed" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this.", "reference": "why should unknown raise a 403?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "The true clause of your condition, can't this just be c._nextState since `assign({}, c._nextState)` is equal to returning c._nextState, or am I misunderstanding something here?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm guessing you're looking for the max_admin_api_calls_per_day parameter? If so, you're looking for the max_results_admin_api_calls_per_day parameter? If so, you're looking for the max_results_admin_api_calls_per_day parameter? If so, you're looking for the max_results_admin_api_calls_per_day parameter? If so, you're looking for the max_results_admin_api_calls_per_day parameter? If so, you're looking for the max_results_admin_api_calls_per_day parameter? If so, you're looking for the max_results_admin_api_calls_per_day parameter? If so, you're looking for the max_results_admin_api_calls_per_day parameter.", "reference": "nit: align the leftmost quotes" }, { "prediction": "This is the port used by the antrea-agent APIServer to serve on. This is the port used by the antrea-agent APIServer to serve on. This is the port used by the antrea-agent APIServer to serve on. This is the port used by the antrea-agent APIServer to serve on. This is the port used by the antrea-agent to run a gossip-based cluster membership protocol. Currently it's used only when the Egress feature is enabled. This is the port used by the antrea-agent APIServer to serve on. This is the port used by the cluster membership protocol. This is the port used by the cluster membership protocol. This is the port used by the cluster membership protocol. It's used only when the Egress feature is enabled. It's used only when the Egress feature is enabled. This is the port used by the cluster membership protocol. This is the port used by the cluster membership protocol. It's used only when the cluster membership protocol is enabled. It's used only when the cluster membership protocol is enabled. It's used only when the cluster membership protocol is enabled. It's used only when the cluster membership protocol is enabled.", "reference": "Probably \"server port\" -> \"TCP port\"" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "can you use FilterCodec instead?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "I know there's only two values but I find it a bit confusing that it's true/false. Could you change it to a string enum with values \"portrait\" and \"landscape\"? Then when calling printToPdf you can just do `landscape: Setting.value('export.pdfPageOrientation') === 'landscape'`" }, { "prediction": "This migration is no-op, but it forces the migration mechanism to apply it and thus write the DB schema version info.", "reference": "I think this migration should fail for MDBX if it uses old table names" }, { "prediction": "I'm not sure if this will work, but I think it's a good idea to use the HostsFileParser. I'm not sure if it's a good idea to use the HostsFileParser, but if it's a good idea to use the HostsFileParser, it's a good idea to use the HostsFileParser.parse_hosts_file method. I'm not sure if it's a good idea to use the HostsFileParser.parse_hosts_file method, but if it's a good idea to use the HostsFileParser.parse_hosts_file method, it's a good idea to use the HostsFileParser.parse_hosts_file method instead, it's a good idea to use the HostsFileParser.parse_hosts_file method.", "reference": "Should this be negated? `!@options[:hosts_file].nil?` Otherwise it'll enter the `if` statement and `nil` will be passed to `HostsFileParser.parse_hosts_file`, which I'm assuming is bad." }, { "prediction": "I'm not sure if this is the correct way to do this, but I think this is the correct way to do it.", "reference": "I'm doubting if adding a bool here is a good idea. Maybe it should be an option object? Otherwise it's hard to extend. But an option object is a bit strange in a fluent API? What do you think @snakefoot?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "This is used in o.a.l.sandbox.search.PhraseWildcardQuery." }, { "prediction": "@ -42,6 +42,7 @@ type stateDB struct { // the underlying DB for account/contract storage timerFactory *prometheustimer.TimerFactory workingsets *lru.Cache // lru cache for workingsets + protocolView protocol.Dock } // StateDBOption sets stateDB construction parameter to `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `stateDB` `", "reference": "view should be loaded on start for both statedb and factory" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Why rename? Just curious..." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Is this needed? I think it calls the super function that already does that." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "This might slow down the inference time, are we sure we need to do that?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "This would read better if you add \"Skip code/lines\" or (exclude/hide code if you follow my earlier suggestion\")" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Looks like glassfish went a bit nuts doing a refactor" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "nit: allocate the list using the number of processors." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Was this change triggered by baseline?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "This code was doing nothing as far as I can tell and was making the SQL find nothing with the new version of Rails. Remove it unless someone can explain why it is there." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case.", "reference": "Setting browser based login as the default for `RestAPIExplorer`." }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "maybe we can do this in Init function?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "How about if request ID not set, service should generate a random uuid?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "minor: this is an opportunity for you to split these long lines into multiple lines :)" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "It would be nice to have exception dumped somewhere (debug logs, info logs)." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "So I don't think this is right, as discussed on #657." }, { "prediction": "I think this is the correct syntax for this query. It should be like this: SELECT group_id, member_role, member_type, member_id, member_email - FROM group_members_{0} - WHERE group_id = {0} AND member_status = 'ACTIVE' AND member_type = 'USER' AND member_status = 'ACTIVE' AND member_type = 'USER' AND member_status = 'ACTIVE' AND member_status = 'ACTIVE' AND member_type = 'USER' AND member_status = 'ACTIVE' AND member_type = 'USER' AND member_status = 'ACTIVE' AND member_type = 'USER' AND member_status = 'ACTIVE' AND member_status = 'ACTIVE' AND member_type = 'USER' AND member_status = 'ACTIVE' AND member_type = 'USER' AND member_status = 'ACTIVE' AND member_type = 'USER' AND member_status = 'ACTIVE' AND member_type = 'USER' AND member_status = 'ACTIVE' AND member_type = 'USER' AND member_status = 'ACTIVE' AND member_type = 'USER' AND member_status = 'ACTIVE' AND member", "reference": "should the group_id = \"{0}\" be group_id = %s You'd still keep the {} for the group_members_{} for the tablename but make the filter clause parameterized." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think you're trying to do something like this:", "reference": "Path can contain variable pattern in the middle. Also, `$` is not enough to tell if this is JMeter variable. We have correct variable detecting somewhere in our code." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for staticMethodOptions() instead of staticMethodOptions(). I'm not sure if this is what you're looking for, but it seems like you're looking for staticMethodOptions() instead of staticMethodOptions().", "reference": "@bennothommo can you revert this section? It shouldn't be required." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Minor: maybe move the above to a `#fiscal_year` method?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "You should use the current directory instead - it's a temporary directory that will get removed when the test is done." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "I think we don't need synchronization here." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "I don't think this should be changed since on the reactive side we don't support anonymous users." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Maybe this `if` should be on line 118?" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming that you're trying to sum the number of buckets for the pre-determined boundaries. I'm assuming that you're trying to sum the number of buckets for the pre-determined boundaries. I'm assuming that you're trying to sum the number of buckets for the pre-determined boundaries. I'm assuming that you're trying to sum the number of buckets for the pre-determined boundaries. I'm assuming that you're trying to sum the number of buckets for the pre-determined boundaries, but I'm not sure what you're trying to sum the number of buckets for the pre-determined boundaries. I'm assuming that you're trying to sum the number of buckets for the pre-determined boundaries, but I'm not sure what you're trying to sum the number of buckets for the pre-determined boundaries. I'm assuming that you're trying to sum the number of buckets for the pre-determined boundaries.", "reference": "Cool. (I thought I had fixed this already in #812.)" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I intend to do this as soon as I have tests passing." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm guessing it's a bug.", "reference": "Please remove the `test_*` from the filename - otherwise pytest will try to collect tests from it." }, { "prediction": "I think this is a bug in libudev-devd. It should be fixed in libudev-devd. I'm not sure if this is a bug in libudev-devd, but it should be fixed in libudev-devd.", "reference": "Did you file a bug to follow up on this?" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "Looks like these 4 lines didn't actually change. Can you revert the whitespace changes here?" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're using RSpec::Support.require_rspec_core, so I'm assuming you're using RSpec::Support.require_rspec_core, so I'm assuming you're using RSpec::Support.require_rspec_core, so I'm assuming you're using RSpec::Support.require_rspec_core, so I'm assuming you're using RSpec::Support.require_rspec_core, so I'm assuming you're using RSpec::Support.require_rspec_core, so I'm assuming you're using RSpec::Support.require_rspec_core, so I'm assuming you're using RSpec::Support.require_rspec_core, so I'm assuming you're using RSpec::Support.require_rspec_core, so I'm assuming you're using RSpec::Support.require_rspec_core, so I'm assuming you're using RSpec::Support.require_rspec_core.", "reference": "This can't be merged with any usage of `require 'pathname'` in lib, it's not always available and we don't want false positives for people (where they don't realise they needed to requite it). Its also unnecessary, no other formatter uses it to look up failure locations. See the exception presenter etc for how we format lines." }, { "prediction": "This should fail, because we are attempting to create a new ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "It would be nice to fix the indentation above." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "`short_names` is still optional, so `=` that indicates it has to stay there." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "missing calling of this method" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this.", "reference": "We could get rid of this dependency being forced on clients by changing the `StackConfiguration` interface abstraction to deal with strings instead of `cloudformation.Parameters` and `cloudformation.Tags`, and internally to the `cloudformation` package translate the input strings into the `service/cloudformation` package specific values hiding that from consumers. I don't think that should be taken on as part of this PR, but I think we should consider doing it at some point." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "`StressChaos` does not contains a field.spec.action" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Non-int literal strings are no longer coercible to int, I think this is an improvement. Without this change it now reports `InvalidArgument`." }, { "prediction": "I think this is a bug. It should be fixed in the future.", "reference": "I this used anyplace?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to use a TThreadPoolServer instead of a TThreadPoolServer. I'm not sure what you're trying to do here, but I'm guessing you're trying to use a TThreadPoolServer.", "reference": "Why was this change required?" }, { "prediction": "I'm not sure if this is what you are trying to do, but I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "I like that we have this attribute here. However, I think the way we use it right now might be confusing in the future. For example, when only camunda admin is checked, this exception will be instantiated with a message and `missingAdminRole` is `false`. I think that is counter-intuitive. I would expect this exception to have `missingAdminRole` set to `true`. With this explicit information, the exception message could now be generated inside this exception class with the text block that is currently used in the authorization manager. We could maybe generally reuse that text block then also for the case where a user is no admin and also has none of the required permissions. I haven't tried it myself but I think it would be great if we could streamline those things a bit more if we're working on it now. Let me know what you think." }, { "prediction": "public static Monster getRootAsMonster(ByteBuffer _bb) { return getRootAsMonster(_bb, new Monster()); } + public static Monster getRootAsMonster(ByteBuffer _bb, Monster obj) { _bb.order(ByteOrder.LITTLE_ENDIAN); return (obj.__assign(_bb.getInt(_bb.position()) + _bb.position(), _bb)); } + public static Monster getSizePrefixedRootAsMonster(ByteBuffer _psbb) { return getSizePrefixedRootAsMonster(_psbb, new Monster()); } + public static Monster getSizePrefixedRootAsMonster(ByteBuffer _psbb, Monster obj) { ByteBuffer _bb = _psbb.slice(); _bb.position(4); return getRootAsMonster(_bb, obj); } + public static int getSizePrefix(ByteBuffer _bb) { _bb.order(ByteOrder.LITTLE_ENDIAN); return _bb.getInt(_bb.position()); } public static boolean MonsterBufferHasIdentifier(ByteBuffer _bb) { return __has_identifier(_bb, \"MONS\"); } public void __init(int _i, ByteBuffer _bb) { bb_pos = _i; bb =", "reference": "Not sure why we're creating a new `ByteBuffer` here, ideally this refers to the existing one?" }, { "prediction": "I'm not sure I'm getting this right, but I'm not sure if I'm getting this right, so I'm not sure if I'm getting it right, so I'm not sure if I'm getting it right, but I'm not sure if I'm getting it right, so I'm not sure if I'm getting it right.", "reference": "Same here re: `STORE_NAME` to `MODULES_SEARCH_CONSOLE`." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "I could've sworn I got a `403` myself when I got that response locally. Is `200` what the API would send back for a `permission: false` tag?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "This attribute was intentionally private. - lets force usage of factory `NewIdentityManager()` - lets ramake to `NewIdentityManager(keydir string)` -> `NewIdentityManager(keystore keystoreManager)`" }, { "prediction": "I'm not sure if this will work, but I'm not sure if this will work.", "reference": "Is this too frequent?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "will this not make it possible to use a zip file, e.g. on other importers who do not have to support it?" }, { "prediction": "@ -34,6 +34,7 @@ from.http import UpstreamConnectLayer from.http1 import Http1Layer from.http2 import Http2Layer from.rawtcp import RawTCPLayer +from.socks_client import SocksClientLayer __all__ = [ \"Layer\", \"ServerConnectionMixin\", \"Kill\", \"ServerConnectionMixin\", \"Kill\", \"ServerConnectionMixin\", \"Kill\", \"ServerConnectionMixin\", \"Kill\", \"ServerConnectionMixin\", \"Kill\", \"ServerConnectionMixin\", \"Kill\", \"ServerConnectionMixin\", \"Kill\", \"ServerConnectionMixin\", \"Kill\", \"ServerConnectionMixin\", \"Kill\", \"ServerConnectionMixin\", \"Kill\", \"ServerConnectionMixin\", \"Kill\", \"ServerConnectionMixin\", \"Kill\", \"ServerConnectionMixin\", \"Kill\", \"ServerConnectionMixin\", \"Kill\", \"ServerConnectionMixin\", \"Kill\", \"ServerConnectionMixin\", \"Kill\", \"ServerConnectionMixin\", \"Kill\", \"ServerConnectionMixin\", \"Kill\", \"ServerConnectionMixin\", \"Kill\", \"ServerConnectionMixin\", \"Kill\", \"ServerConnectionMixin\", \"Kill\", \"ServerConnectionMixin\", \"Kill\", \"Kill\", \"ServerConnectionMixin\", \"Kill\", \"ServerConnectionMixin\", \"Kill\",", "reference": "Needs to be mentioned in `__all__` below." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "What if the app's signal handler, executed at pre-syscall for epoll_pwait, executes its own epoll_pwait? For that matter: what happens natively if that happens? I would not expect the kernel to keep a stack -- does that clobber the kernel's stored pre-syscall mask?" }, { "prediction": "I think this is what you are looking for. If you are looking for a list of offsets for blocks of a file, it is important that this information is used for planning scan tasks whose boundaries are determined by these offsets. If you are looking for a list of offsets for blocks of a file, it is important that this information is used for planning scan tasks whose boundaries are determined by these offsets. If you are looking for a list of offsets for blocks of a file, it is important that this information is used for planning scan tasks whose boundaries + * are determined by these offsets. It is important that this information is used for planning scan tasks whose boundaries are determined by these offsets. It is important that the returned list is sorted + * in ascending order.", "reference": "Nit: missing a space. I think we should phrase the new content a little differently. \"It is important\" isn't very clear. I think it should be \"offsets will be returned in sorted order.\"" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Can you remove this blank line and put the added import in sorted order (likely your editor will do this)" }, { "prediction": "I'm not sure if this is the case, but it seems to be the case.", "reference": "Even if `pthread_create()` for `ocsp_updater_thread()` fails, `h2o` can continue to serve. But I'm a little worried whether `h2o` should continue to serve in this case. How about you?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "I like introduction of these constants for account/container creation, but the `ACCOUNT_CHOOSE` one isn't needed I think. This should instead be an \"empty\" value (either `''` or `0`), to indicate more clearly that this field is not filled. It should be the same for choosing a container." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "I noticed that passing in `[]` for the locales argument instead of 'undefined' seems to have the same effect. I think that's preferred over passing in `undefined` as a value, and unfortunately passing in `null` seems to throw an error." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "1. `0` is redundant. 2. We should save result of `strings.LastIndex(DbCfg.Host, \":\")` to a variable and reuse." }, { "prediction": "` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `` `` `` `` `` `` ``", "reference": "Do you envision \"new\" servers not supporting header, or is it more a way to test mix of old and new? If so, we could make it a \"private\" (non exported) option." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "For future reference. Try not to do refactoring in the same PR which solves some bug or implements some feature. Not to clutter reading. Do it in separate PR." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I'm not sure about changing the flag name. unit is more accurate, but for I think for most people asset is also a fine name to use." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Which windows gets activated? A random other window?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Just to make sure, this is totally lossless? If I put a v2 there, then it gets upgraded to v3, but my function expects v2, then this is fine and nothing is lost?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's probably what you're trying to do.", "reference": "In the past, we have 3 Flink streaming jobs (1 for each AWS region) writing to the same table. We need to write to 3 different watermark table properties (1 for each region). Watermark consumer then use the min value to determine the overall table watermark. A provider pattern similar to `WRITE_LOCATION_PROVIDER_IMPL` can work. A default impl could be a single property name. not sure if there is a simpler way to achieve this." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Can you change this to `ResolvedUsersMap` and build a new map with both readers/writers? That way, we get the nice side effect of not exposing the internal map of the handle, and simplifying the callers a bit." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug. I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug.", "reference": "I typically try to avoid nested ternary expressions. Can we rewrite this as if statements? Worst case, can we break it out into its own function?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Do we still support handshakes without SNI present?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "Maybe it's because I work too much on a centralized logging system but it could be great to add a \"category\" like \"attribute\", \"substitution\", \"include directive\", \"macro\", \"extension\"..." }, { "prediction": "This function removes the white spaces in the name, and also - remove the pointer declaration \"*\" (it have no sense in python) \"\"\" + remove the pointer declaration \"*\" (it have no sense in python)\"\"\" name = name.replace(\" \", \"\") name = name.replace(\"*\", \"\")", "reference": "it have no sense in python -> it makes no sense in python" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "maybe just do a separate implementation of the pool for openvpn case? It's a bit confusing having two methods here." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "how is it possible to have a `topology` that is falsey when we had to call `topology.connect` in order to get here?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Do we need this expectation? If we don't call this method on `PlanFinder` there's no way for the `10` to be returned. Seems somewhat redundant. What do you think?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "We need to do the same for edgecore" }, { "prediction": "I'm not sure this is a bug, but it's a bug, so it's a bug.", "reference": "This fix has nothing to do with the product change. Just a fix I am making for the test issue." }, { "prediction": "I'm not sure if this is the correct way to do it, but it's the correct way to do it.", "reference": "Don't know what should be the default. Lets keep BatchingProcessor for now. And revisit the area after beta." }, { "prediction": "I think this is a bug in RSpec::Support.require_rspec_support.", "reference": "Ah that's how it's happening, it's probably using the `require_relative` in the optimised one and that counts as a different require to the bare one." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "What happens if there is no NIB/XIB with that name?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "this is not necessary?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "typo: `asmsecrets \"github...`" }, { "prediction": "public static function sanitize_meta_ordering( $value ) { if (! in_array( $value, $allowed, true ) ) { return $allowed; } if (! in_array( $value, $allowed, true ) ) { return $allowed; } if (! in_array( $value, $allowed, true ) ) { return $allowed; } if (! in_array( $value, $allowed, true ) ) { return $allowed; } if (! in_array( $value, $allowed, true ) ) { return $allowed; } if (! in_array( $value, $allowed, true ) ) { return $allowed; } if (! in_array( $value, $allowed, true ) ) { return $allowed; } if (! in_array( $value, $allowed, true ) ) { return $allowed; } if (! in_array( $value, $allowed, true ) ) { return $allowed; } if (! in_array( $value, $allowed, true ) ) { return $allowed; } if (! in_array( $value, $allowed, true ) ) { return $allowed; }", "reference": "I think that the JSON encoding should be handled by the control itself, not the sanitization function. This should only confirm that the input is correct, not reformat it" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "Should we put a TODO here to route the http.Transport through here?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Sorry, could you explain more about the issue? Doesn't ComputerName already default to local computer? > -ComputerName Specifies one or more Hyper-V hosts on which the virtual switch is to be configured. NetBIOS names, IP addresses, and fully qualified domain names are allowable. The default is the local computer. Use localhost or a dot (.) to specify the local computer explicitly." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this. I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "`allowError` is a big vague. Does this mean the test case is asserting that an error should occur? If it means \"maybe an error can occur, and that's okay\" -- what's an example of this?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "return statements should not be cuddled if block has more than two lines (from `wsl`)" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Why does VirtualMachineMetrics have to implement Metric?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do. I'm not sure what you're trying to do, but I'm guessing it's what you're trying to do.", "reference": "line is 121 characters" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "How's that linked esbench looking with slice?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this.", "reference": "The split and join was probably done to ensure that this still works on Windows because os.path.dirname works differently depending on the os you're running under :(. It would probably be a little better to do `dirname, _, fn = path.rpartition('/')` if you want something cleaner than the split/join." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here, so I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "This is not the right approach. The `Distributor` maintains a model of the current state of the Grid. That model already contains the information about every active session. We don't need to modify `SessionMap` to expose it further." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Can you make this a member var as all the other deadlines? Then you can drop the param to resetTimer() and simplify some of the code below iiuc." }, { "prediction": "I'm not sure if I'm correct, but if I'm correct, I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "I don't understand the reason for the changes from unique_ptr to ROMOL_SPTR that you made in this file. The pointers aren't being shared or used elsewhere so I don't think there's any reason to make them shared. Did I miss something?" }, { "prediction": "I'm not sure if this is a bug, but I think it is a bug.", "reference": "why change the variable name at all?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this should work.", "reference": "Since I'm still trying to keep these straight in my head, can you elaborate on what problem this solves?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Prefer TextUtils.isEmpty() which handles getReportSpamRecipient() being null" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this should work.", "reference": "Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Do we actually use Include anywhere yet or is this just for completion?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "It still bugs me this was misspelled in the standard and now the wrong spelling is the commonly used one :wink:" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "seems we missed de-uglifying this one" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "i guess these types & cron / retry specific belong to a dedicated util / struct" }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it.", "reference": "Also update line 2205 below" }, { "prediction": "I'm not sure if this is the correct way to do it, but it's the correct way to do it.", "reference": "`direction` is referenced nowhere. Do I miss something?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but it's the correct way to do it.", "reference": "The two places this was used have been removed so we can fully remove this dependency." }, { "prediction": "I'm not sure what you're trying to do, but I think it's a good idea.", "reference": "This is a duplicate generation of the same file as below." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "We may deprecate `gpus` if `gpu_ids` is specified." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but it should work.", "reference": "Right now this is experimental and deeply flaky. We left this at `info` to make debugging user reports a lot easier." }, { "prediction": "I'm not sure if this is a bug, but if it's a bug, it should be fixed.", "reference": "unnecessary spaces here are doubling the size of this otherwise extremely useful addition" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "I think we should use `FileExistsPolicy.Overwrite` instead. Files _should_ always be newer, but in the unlikely case they wouldn't be, I'm afraid some files would be overwritten and other not, leading to inconsistencies that will be hard to figure out." }, { "prediction": "I'm not sure if this will work, but it should work.", "reference": "this should probably be removed" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Nit: I would actually prefer that pretty JSON is the default, with a flag for compressed JSON. Can we acheive that easily?" }, { "prediction": "This is an optional map for the security group role to a set of additional ingress rules for that role.", "reference": "Will need to think about this one. `additionalIngressRules` feels a bit opaque in terms of eventual outcome." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Can we avoid making this public with the other updates?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Why did you change this equal instead of less or equal?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "missing final for the blockHash field" }, { "prediction": "I'm not sure why you're getting this error, but I'm not sure why you're getting this error. I'm not sure why you're getting this error, but I'm not sure why you're getting this error, but I'm not sure why you're getting this error.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "`x_float` instead of `float_x`." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "Is this for `No Babel config...` from ESLint? If so, it will be fixed in my ES6 PR." }, { "prediction": "I'm not sure if this is a bug, but it should be fixed in the latest release.", "reference": "Not important, but the code used to keep checking other cases even after one of them failed, and now it's not. Fine either way for me, just noticing." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "I think I saw this line in last PR, you can update your base branch and rebase to avoid this. And it would be awesome if you can rebase instead of merge each time you push PR to the `moby` branch, that will make the commits history clearer." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, so I'm not sure if it's the case. I'm not sure if it's the case, but I think it's the case.", "reference": "If this can change the PC of this thread, it requires handling: we can't blindly execute the syscall and lose control of the thread when the flags include CONTEXT_CONTROL. (Note that most docs imply that setting your own context this way is not supported or has undefined or unpredictable results: any idea how often that's the case, or does it generally work?) We need to handle in a similar fashion to NtContinue or setting another thread's context to ensure we retain control." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "@huzaifaiftikhar Changed the endpoint as suggested by Stephane in the latest commit." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing that you're trying to do something like this:", "reference": "There's no core.Number yet. ;)" }, { "prediction": "I think this is a bug. I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "...,...will be posted." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I'm not sure if it's the correct way to do it.", "reference": "Can you update this function to be `ShowHeader`? There is only one use of it at the moment in `tools/fast/series/get_head_block_height.go`." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "@akarve, this disables `tqdm` by default, is it intended? Also name `QUILT_USE_TQDM` might be too specific, IMHO `QUILT_INTERACTIVE` or `QUILT_PROGRESS_BARS` or something might be better." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "unrelated but just changing for consistency with code below it" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "This will call `componentWillUpdate()` for mounts because the else clause is removed. It should only be called for updates." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "We should add write inheritance too." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Please rename this to `LAMBDA_JAVA_OPTS`, and add a short description to the README." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for \"github.com/pipe-cd/pipe/pkg/app/api/analysisresultstore\" \"github.com/pipe-cd/pipe/pkg/app/api/commandstore\" \"github.com/pipe-cd/pipe/pkg/app/api/commandstore\" \"github.com/pipe-cd/pipe/pkg/app/api/commandstore\" \"github.com/pipe-cd/pipe/pkg/app/api/commandstore\" \"github.com/pipe-cd/pipe/pkg/app/api/commandstore\" \"github.com/pipe-cd/pipe/pkg/app/api/commandstore\" \"github.com/pipe-cd/pipe/pkg/app/api/commandstore\" \"github.com/pipe-cd/pipe/pkg/app/api/commandstore\" \"github.com/pipe-cd/pipe/pkg/app/api/commandstore\" \"github.com/pipe-cd/pipe/pkg/app/api/commandstore\" \"github.com/pipe-cd/pipe", "reference": "Should be in the same import group." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Operator precedence is very confusing here. Care to add parentheses? ` ((version or 0x0303) >= 0x0200)` Same below." }, { "prediction": "I think this is a bug. It's a bug. It's a bug. It's a bug. It's fixed.", "reference": "javaparser-core has no dependencies and it should stay that way. So no log4j. And even then there would have been a preference for slf4j." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Why not just retest all? it's not expensive (I think)." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "ecr and ecr0 aren't deterministically named here. This change will just cause confusion in the git history. Could you either: a) fix this and make it deterministic b) regenerate the mock until it doesn't flip definitions for ecr and ecr0" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "This looks like bash... does this work in ruby? Or is the idea to inject the entire script into the subsequent commands?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this. I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this. I'm guessing you're trying to do something like this. I'm guessing you're trying to do something like this. I'm guessing you're trying to do something like this. I'm guessing you're trying to do something like this. I'm guessing you're trying to do something like this. I'm guessing you're trying to do something like this. I'm guessing you're trying to do something like this. I'm guessing you're trying to do something like this.", "reference": "I don't understand why this change is in this PR?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "It's a little hard to tell from the diff, but as a result of this PR, the only non-deprecated helpers are: - `has_facet_values?` (probably not long for this world) - `render_facet_partials` (perhaps part of a future component) - `render_facet_limit` (possibly obsolete once components get traction) - `facet_field_in_params` (a little tricky to deprecate at the moment) - `facet_field_presenter`" }, { "prediction": "I don't understand why this is not working. It's just not working. It's just not working. It's just not working. It's just not working.", "reference": "The right-hand part shouldn't use `__proto__`. Should be just `PersonObject.__proto__ = Realm.Object`." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "the == case might be legit, or not? If there is no task written since last read, but we trigger a new read, would the min == max? Or should the upper layer handle that case?" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's a bug.", "reference": "Good catch! But is it guaranteed that `old_size < new_size` here? If not, wouldn't we want to take `min(old_size, new_size)` as the copy length?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This is the only one that worries me a bit. It would be good if Brendan signed off on it." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "`LongRunningOperationDetailView` already has `isEmptyOperation`." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "This will always add the authorization header to the request object. Is this the right scope for these two lines? If username/password are not defined, it will encode 'Basic :'" }, { "prediction": "What do they do? What do they do? what do they do? what do they do? what do they do? what do they do? what do they do? what do they do? what do they do? what do they do? what do they do? what do they do? do they do it efficiently, and do we need them?", "reference": "Don't think a scope adds much value for us here. Also, for future reference, you don't need to use the `self.all` it is implied. Could just be: `scope :updated_at_desc, -> { order(updated_at: :desc) }` No need to change this one now though, it works." }, { "prediction": "@@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,7 @@ -10,7 +10,", "reference": "I believe `Base.` is unnecessary in this case, as the class already extends `Base`." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Couldn't this result in images being scaled too small when the width is less than the height assuming the width is still what is being passed here?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Here also, let's not cache value on top of file, but use `plugins.getConfig(\"api\").offline_mode` directly where it is needed" }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if this is the correct way to do it.", "reference": "You can combine the two checks into a single `!empty()` check." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Should we add a warning for anything over say 8M? Just suggesting that is not recommended?" }, { "prediction": "I don't think this is a bug, but it should be fixed.", "reference": "Looks like there are no callers left of this function." }, { "prediction": "I'm not sure if this is the case, but if it is the case, it will be a context.DeadlineExceeded error. If showOutput is true then output will be printed to stderr as well as any error that occurred. If showOutput is false then output will be printed to stdout as well as any error that occurred. If showOutput is true then output will be printed to stdout as well as any error that occurred. If showOutput is false then output will be printed to stdout and stderr and any error that occurred. -func ExecWithTimeout(target *BuildTarget, dir string, env []string, timeout time.Duration, defaultTimeout cli.Duration, showOutput bool, argv []string) ([]byte, []byte, error) { +func ExecWithTimeout(target *BuildTarget, dir string, env []string, timeout time.Duration, defaultTimeout cli.Duration, showOutput, attachStdin bool, argv []string) ([]byte, []byte, error) { +func ExecWithTimeout(target *BuildTarget, dir string, env []string, timeout time.Duration, defaultTimeout cli.Duration, showOutput, attachStdin bool, argv []string) ([]byte, []byte,", "reference": "Should there still be a ` bool` trailing `showOutput`?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug", "reference": "Did we can change to v1" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Can you please double check that this won't break anything?" }, { "prediction": "I don't think this is what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "optionals, shouldn't need to be stated explicitly" }, { "prediction": "This is a version number as defined in the wiki: https://github.com/quicwg/base-drafts/wiki/QUIC-Versions.html", "reference": "That seems quite low - why not just 0x5130ffff?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "Why is this needed?" }, { "prediction": "I think this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "`Bolt::Config.user_path` returns `nil` if there's no homedir, so this will still error in that case." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea to check if a.Tag == protocol.ProposalPayloadTag { return fmt.Sprintf(\"%v: %2v: %5v\", a.t().String(), a.Tag, a.CompoundMessage.Proposal.value()) + } if a.Tag == protocol.ProposalPayloadTag { return fmt.Sprintf(\"%v: %2v: %5v\", a.t().String(), a.Tag, a.CompoundMessage.Proposal.value()) + } if a.Tag == protocol.ProposalPayloadTag { return fmt.Sprintf(\"%v: %2v: %5v\", a.t().String(), a.Tag, a.CompoundMessage.Proposal.value()) + } if a.Tag == protocol.ProposalPayloadTag { return fmt.Sprintf(\"%v: %2v: %5v\", a.t().String(), a.Tag, a.CompoundMessage.Proposal.value()) + } if a.Tag == protocol.ProposalPayloadTag { return fmt.Sprintf(\"%v: %2v: %5v\", a.Tag, a.CompoundMessage.Proposal", "reference": "nit: use %s for strings and %v for objects." }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this:", "reference": "Same as before, the properties already exists in parent" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "This fix is not quite correct. The `%s` should be replaced with `version` and the `%d` on line 39 should be replaced with `datetime.datetime.now().year`." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Maybe we should only set active = false if `strcmp(type, \"pause\") == 0`?" }, { "prediction": "This is not a bug, it's a bug. It's a bug, but it's a bug.", "reference": "Same here. and all others." }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "Intentionally committed? I'm not against it, we already have a way to get goroutines without killing the process: `/keybase/.kbfs_profiles/goroutine`." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "I think this blank line may be removed" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "I think this should be a keyword-only argument, i.e. do `def add(self, url, title, *, toggle=False):` and adjust the caller to do `toggle=toggle`." }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ``````````", "reference": "@aimanrosli23 Judging from the commit description, I do not know why this file got changed so much. Could you help to double confirm if you do not revert the changes brought by commits: SHA-1: 643623147a1feaddd734ddd84604e1d8e9dcebee * MdeModulePkg/SdMmcPciHcDxe: Send SEND_STATUS at lower frequency SHA-1: 49accdedf956f175041040e677163b7cbb746283 * MdeModulePkg/SdMmcPciHcDxe: Hook SwitchClockFreq after SD clock start" }, { "prediction": "I think this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "How about YAML.load_file()" }, { "prediction": "I'm not sure if this is the case, but I think this is the case, so I'm not sure if this is the case, but I'm not sure if this is the case, so I'm not sure if this is the case, but I'm not sure if this is the case, so I'm not sure if this is the case.", "reference": "Maybe make this `volatile` or atomic as this can be set/read from different threads? Also, separately you may want to check if some of the methods here need to be `synchronized`." }, { "prediction": "@ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @", "reference": "Check the return value of the drmgr ones." }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "This should be `'cache'`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to make a new repo with read/write permissions. If you're trying to make a new repo with read/write permissions, you'll need to make a new repo with read/write permissions. If you're trying to make a new repo with read/write permissions, you'll need to make a new repo with read/write permissions - MakeNewRepo() (*os.File, error) + MakeNewRepo() error // GetOldRepoPath returns the full path of the old repo GetOldRepoPath() string // GetNewRepoPath returns the full path of the old repo GetNewRepoPath() string // MakeNewRepoPath returns the full path of the new repo GetNewRepoPath() string // MakeNewRepoPath returns the full path of the new repo GetNewRepoPath() string // MakeNewRepoPath returns the full path of the old repo GetNewRepoPath() string // MakeNewRepoPath returns the full path of the new repo GetNewRepoPath() string // MakeNewRepoPath returns the full path of the new repo GetNewRepoPath() string // MakeNewRepoPath returns the full path", "reference": "The name \"old\" might cause confusion here. After installation, the \"old\" repo is at an archived path, and the new migrated repo is at the old path. Maybe something like \"target\" or \"canonical\"?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this should work:", "reference": "I think this is somewhat definitive proof that this error exists in `core` rather than `native`. We are correctly resolving the `readPreference` in the previous line, but you are able to identify that eventually the command generated in `core` is not decorated with the passed `readPreference`. Did you try to solve this there already?" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug. If it's a bug, I'm not sure if it's a bug. If it's a bug, I'm not sure if it's a bug.", "reference": "During genesis sync it can unwind 5M blocks?" }, { "prediction": "We don't have to wait too long for a long poll expiration, so we don't have to wait too long for a long poll expiration. Instead, we have to wait too long for a long poll expiration.", "reference": "was it caused by the removal of removeTaskQueueManager() from this test?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Wouldn't it just be easier to force search_session to return `with_indifferent_access`? Since you've done the hard work already, I don't think there's a problem doing it this way, but.." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "So, such tasks that could possibly not meet the deadline will never have a chance to run? I think this is not nice behavior, especially for those projects who has sometimes some very small tasks after the big one." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "You should add the check above this line instead. If string is empty, don't even call the function." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "If clientCert attribute doesn't exist for some reason I set it to false." }, { "prediction": "I'm not sure if this is the issue, but I'm not sure if it's the issue, but I'm not sure if it's the issue.", "reference": "Do we need `app_host_flags` variable? We can directly concat with `flags`. `sh.cmd curl_cmd(unless Travis::Build.config&.ssl&.verify? flags +'-k' : flags, location, static_file_location), cmd_opts` right?" }, { "prediction": "I'm not sure if this is the correct way to do this, but it should work.", "reference": "Walk should actually be completed (`onWalkCompleted`) after the event is stopped. This also makes it possible for monster to walk by smaller paths." }, { "prediction": "I'm not sure if this is a bug, but it should be fixed in the future.", "reference": "typo in `weather` (should be `whether`)" }, { "prediction": "This flag overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides the default API endpoint setting. This setting overrides", "reference": "Thoughts on having the URI as the param, instead of a boolean? The default value would be the normal prod image, and then your test would override with the staging image." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I'm surprised this is needed, but we should probably assert num_scan == 1 at least, otherwise I expect the file is pretty broken." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Could we set a default value for `partitions` and `{0, network::NetworkUtils::getAvailablePort()}`?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm correct, or if I'm wrong, or if I'm wrong, I'm sorry.", "reference": "Needs xml docs. The API names alone don't provide enough explanation about what these mean and how to set them. Also, we should provide some validation of inputs, such as MaxTime must be > MinTime, MinimumRate must be >= 0, etc. Consider making the properties readonly and adding a constructor that does these validations." }, { "prediction": "I think this is what you are looking for, but I'm not sure if this is what you are looking for.", "reference": "Would it make sense to create an empty file here, perhaps in a tmp dir, instead of checking empty files into Git?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "This change is due to `clang_format` and is not related to this PR." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Why did you not add the signals to the call of block_all_signals_except() and instead baked them into the function? Ok, if you had a good reason for it, otherwise I would add it to the except list of the function call, since that's what it was meant for." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "Could this be done by mocking objects instead? I feel like this is changing too much of the actual logic just for the tests." }, { "prediction": "I'm not sure if this is the case, but if it's the case, then it's just the case, so I'm not sure if it's the case.", "reference": "why not just use `ManifestContent` instead of `Integer`?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "can we do that in TxValidator?" }, { "prediction": "@ -66,6 +66,7 @ @ type OnewayOutbound interface { // Outbounds encapsulates outbound types for a service type Outbounds struct { - Unary UnaryOutbound - Oneway OnewayOutbound + ServiceName string + Unary UnaryOutbound + Oneway OnewayOutbound } }", "reference": "We definitely want some detailed and thoughtful docs being added to this type." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure.", "reference": "We would like this code to run, even when `config.XDPEnabled` is false, so that Felix can clean up its own XDP state after a restart." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "If the status is `ERR_SPACE_NOT_FOUND` why return `SUCCEEDED`?" }, { "prediction": "I'm not sure if this is the case, but it seems to be the case.", "reference": "It is is more appropriate to use `downsample_first`. If `downsample_first=True`, the downsample block is the first block and it is used for ResNet. If `downsample_first=False`, the downsample block is the last block, which is used by Hourglass network." }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to create a new driver instance. I'm not sure what you're trying to do here, but I'm guessing you're trying to create a new driver instance. I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "I don't know if there are strict conventions about this, but I think the name of the warning should be the diagnosis, not the suggested course of action. In this case, that would mean changing the name of the warning to `interactive-exit` or something like that." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "If `crt.Spec.CommonName` is not set, and `cert.Subject.CommonName` *is* set, we are not correctly handling it here." }, { "prediction": "I think this is a bug in qutebrowser.utils import usertypes, objreg. I'm not sure if it's a bug, but it's a bug in qutebrowser.utils import usertypes, objreg. I'm not sure if it's a bug in qutebrowser.utils import usertypes, objreg. I'm not sure if it's a bug in qutebrowser.utils import usertypes, objreg. I'm not sure if it's a bug in qutebrowser.utils import usertypes, objreg. I'm not sure if it's a bug in qutebrowser.utils import usertypes, objreg.", "reference": "This isn't a test, so it shouldn't be named `test_init`. You could name it `cmdhistory_init` or so." }, { "prediction": "@property def pickle_protocol(self): \"\"\" Called by the pyspark_runner with a SparkConf instance that will be used to instantiate the SparkContext. \"\"\" return self.conf.getint(self.spark_version, \"pickle-protocol\", pickle.DEFAULT_PROTOCOL) + self.conf.getint(self.spark_version, \"pickle-protocol\", pickle.DEFAULT_PROTOCOL) + self.conf.getint(self.spark_version, \"pickle-protocol\", pickle.DEFAULT_PROTOCOL) + self.conf.getint(self.spark_version, \"pickle-protocol\", pickle.DEFAULT_PROTOCOL) + self.conf.getint(self.spark_version, \"pickle-protocol\", pickle.DEFAULT_PROTOCOL) + self.conf.getint(self.spark_version, \"pickle-protocol\", pickle.DEFAULT_PROTOCOL) + self.conf.getint(self.spark_version, \"pickle-protocol\", pickle.DEFAULT_PROTOCOL) + self.conf.getint(self.spark_version, \"pickle-protocol\", pickle.DEFAULT_PROTOCOL) + self.conf.getint(self.spark_version, \"pickle-protocol\", pickle.DEFAULT_", "reference": "why is this pulling from `self.spark_version` config section rather than the `spark` config section (`py-packages` appears to pull from a config section called `spark`)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "nit: Think it can be one line.." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's probably something you're trying to do.", "reference": "please inline imports" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "This check is still correct in some cases, but I guess erroring out is acceptable if someone explicitly asked for an impossible cgroup configuration (now that we could in principle nest things). I would like to see a test for this though." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "Should we update integral to operate on a single column as well?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "Doesn't belong to this PR" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Just for my own understanding, does aws ecs API take this token as a new input attribute? Which version of the aws sdk? I did not find it in the official aws sdk doc." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Could we shorten this constant to maybe `FEATURE_USER_AUTH`?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this, and it seems like you're trying to do something like this, and it seems like you're trying to do something like this, and it seems like you're trying to do something like this, and it seems like you're trying to do something like this, and it's not a good idea to do something like this, but it's a good idea to do something like this.", "reference": "Any particular reason for 8? I feel like we could probably handle more..." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Try to use factory association declaration for default values, so it could minimal the line length. You may write in fetch_job factory like association :repository, factory: :repository." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Should the \"cancelled\" class be added regardless of the proposal's state?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "nit: random whitespace change, let's try to keep these out of commits unless there are other useful changes." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Seems kinda dangerous - what if models length is different from paths length?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "set real one plz (get it from DB)." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm guessing it's what you're trying to do.", "reference": "Should this be initialized to zeroes?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here.", "reference": "The query is already built at this point, so I don't think this particular change actually helps wrt SOLR-10732? (and the `base.size()==0` case is already trivially optimized in `SolrIndexSearcher.numDocs(Query, DocSet)`)" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "re-add the type in the annotation here" }, { "prediction": "I'm not sure if it's the latest release version, but if it's the latest release version, then it's the latest release version.", "reference": "Could we simpify it as `cmd.Stderr = &bytes.Buffer{}`?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "there's enough \"nots\" in here that while it's correct by my review, I'd like to see a small unit test (just passing in an expired and non-expired cert)" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if this is a bug or a bug.", "reference": "The config option should probably have a more specific name. Also it's not for all gridded data but specifically for Images (and its subclasses)." }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "Be careful. This is not a preference but an option in a dialog." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "this will modify the incoming object, which may not be desirable in some cases. i think we should stick with the local var, override it with deployment.ClusterName if deployment.ClusterName not empty" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Is this not required?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "You're using scare quotes on these terms instead of defining them." }, { "prediction": "This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make. This is overridden by make.", "reference": "These should both be const, not var right?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "Can you catch a more specific exception here? Thanks :-)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "This is a bug during handling the recover logic in `common chaos` controller, I fixed in this request when I found it." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for a single_gpu_test.", "reference": "During testing, we adopt the score threshold specified in the config file. Here the threshold is only used for visualization, and the variable name `score_thr` can be misleading. Renaming it to `show_score_thr` would be better." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "can you make this `nav-primary` please? i'd like to roll with this since the `
    ` class is `nav`, and primary is the name of the navigation menu" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm not sure.", "reference": "@georgehrke Just out of curiosity. Couldn't you combine at least the combine the regex for '-' and '' with groups?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "I think this is objectively better than looking up the object by name. As a follow-up, I'm going to see whether we do this name-based lookup somewhere else and switch to your method." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "Why are you dividing by scale in the LTR case but not the RTL case?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "Update after command rename" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like `googlesitekit.TagManagerModuleSettings`, `googlesitekit.TagManagerModuleSettings`, `googlesitekit.TagManagerModuleSettings`, `googlesitekit.TagManagerModuleSettings`, `googlesitekit.TagManagerModuleSettings`, `googlesitekit.TagManagerModuleSettings`, `googlesitekit.TagManagerModuleSettings`, `googlesitekit.TagManagerModuleSettings`, `googlesitekit.TagManagerModuleSettings`, `googlesitekit.TagManagerModuleSettings`, `googlesitekit.TagManagerModuleSettings`, `googlesitekit.TagManagerModuleSettings`, `googlesitekit.TagManagerModuleSettings`, `googlesitekit.TagManagerModuleSettings`, `googlesitekit.TagManagerModuleSettings`, `googlesitekit.TagManagerModuleSettings`, `googlesitekit.TagManagerModuleSettings`, `googlesitekit.TagManagerModuleSettings`, `googlesitekit.TagManagerModuleSettings`, `", "reference": "I added this change to fix a bug with the legacy settings wrapper which was preventing it from working properly with the other modules" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug, so it's a bug.", "reference": "isn't AZKABAN_FLOW_VERSION_2_0 more explicit?" }, { "prediction": "I'm not sure if this is the case, but if it is the case, then it's a bug.", "reference": "Please don't leave an empty default" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "This isn't directly related, but the `import React from'react';` below should be removed. We never import this directly and any modules from it we need are imported through `@wordpress/element`. This was probably added automatically at some point, but we also provide this automatically via `ProvidePlugin`." }, { "prediction": "We don't want to install the latest CRAN binary for OS X, but we don't want to install the latest CRAN binary for OS X, so we don't want to install the latest CRAN binary for OS X, so we don't want to install the latest CRAN binary for OS X. So, we want to install the latest CRAN binary for OS X, but we don't want to install the latest CRAN binary for OS X, so we don't want to install the latest CRAN binary for OS X. So, we don't want to install the latest CRAN binary for OS X, but we don't want to install the latest CRAN binary for OS X. We want to install the latest CRAN binary for OS X, so we don't want to install the latest CRAN binary for OS X.", "reference": "You can also use `echo: false` instead. Either is fine; I'm just pointing it out." }, { "prediction": "I'm not sure if this is a bug, but it's a bug in the NLog.Layouts.cs file.", "reference": "what's the reason for this moved line?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "I don't really follow what is happening here, but it looks like this _could_ conflict with the logic on the lines above... should this be an `else if`?" }, { "prediction": "I'm not sure if this is what you're looking for, but if it's what you're looking for, it's probably what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "`s => s.IsHidden == false` What's the purpose of adding this?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "I would name this `clef-ethereum-address`. We already have a bunch of addresses in Bee, and people might wrongly think that this is yet another address" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "you can just remove this" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "I think we should avoid creating a dummy CR in the case of SPC. Please see if we can avoid this since we will not be patching anything in this CR." }, { "prediction": "I think this is what you're looking for.", "reference": "Honestly not sure myself, but do you think it makes sense to move this conditional into the partial?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "As discussed in IRC (just so it doesn't get lost): This probably should be `-basedir-`, not `-prefix-`" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "basepath can be absoluta path and this needs to be supported" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Didn't get to the commit message" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "What about raising `ActionView::MissingTemplate` instead? That's what HighVoltage does." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Is it kept for compatibility?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "I would find it pretty reasonable to add a MinerSigner method on the state view that puts these together." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "It's stored in `PodDBAdapter.VERSION`. I usually use the expected release version code for that change. As this will be released in AntennaPod 2.2.0, the code would be `2020000`." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "What about method name itself? Do we run this for SQL too?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "`instanceUrl` should be `cs1.salesforce.com`. `communityUrl` would be `mobilesdk.cs1.my.salesforce.com`." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "Let's use `if(name!= nullptr)` to remove ambiguity" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "I wonder if it would make sense to have a separate namer for metadata? Metadata files tend to be expressed in a different language from the repo language, and have mutually exclusive concepts. So, `PackageMetadataNamer`." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if this is a bug or a bug.", "reference": "This rule is quite specific to qbft and so I don't think it should be part of the common rules. Would rather the common bft code didn't know anything about contract based voting/validator governance." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "This makes our life harder than it needs to be. A Set is unordered by definition. Please remove this method from Set and add it to SortedSet, but with no default implementation. We need to duplicate it then to LinkedHashSet but that's ok, it is the best we can do. Could you please add it also to SortedMap and LinkedHashMap? We are then able to close the original issue." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "we can replace `for` with `params.update(response_headers)`" }, { "prediction": "I don't think it's a bug, but it's a bug in Microsoft.AspNetCore.Server.Kestrel.Https.", "reference": "Any chance this is available in.NET Core 2.0 now?" }, { "prediction": "\"github.com/iotexproject/iotex-core\" \"github.com/iotexproject/iotex-core\" \"github.com/iotexproject/iotex-core\" \"github.com/iotexproject/iotex-core\" \"github.com/iotexproject/iotex-core\" \"github.com/iotexproject/iotex-core/p2p\" \"github.com/iotexproject/iotex-core/p2p\" \"github.com/iotexproject/iotex-core/p2p/node\" \"github.com/iotexproject/iotex-core/p2p/node\" \"github.com/iotexproject/iotex-core/p2p/node\" \"github.com/iotexproject/iotex-core/p2p/node\" \"github.com/iotexproject/iotex-core/p2p/node\" \"github.com/iotexproject/iotex-core/p2p/node\" \"github.com/iotexproject/iotex-core/p2p/node\" \"github.com/iotexproject/", "reference": "I wonder if it's necessary to let app pass in the context. What app level context should be sent? If no, is it enough for p2p agent to compose a context with network info there?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Why do we need both includes here?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for, so I'm not sure if this is what you're looking for.", "reference": "SmartStoreInspectorTest expected results in a certain order" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug.", "reference": "I think that you need something like `m_using_random_node.emplace(m_io_thread_pool->get_local_thread_id());`" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "I don't think we need to maintain a separate set. The problem here is that the \"assignment\" that is killed for this variable is not really an assignment. If we just don't `assign` the variable with the non-existent value, it will not be reported. I pushed a fix." }, { "prediction": "I'm not sure if this is the case, but it's the case, so it's not the case.", "reference": "Let me know if this is too pervasive. It is currently a private method in `BaseTableScan`. It seems both `SparkBatchQueryScan` and `SparkMergeScan` need to know the scan-specific split size when planning tasks. Therefore, I made it open. Another approach is to move all the `planTasks` logic to scan implementations, but for the combine tasks by partition feature, it requires grouping scan tasks by partition first, instead of returning them in an iterator fashion. I'm not sure if this is OK. `SparkMergeScan` also seems to re-implemented its own plan tasks logic." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Not sure what is this change doing?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this.", "reference": "this is funky. either don't take` minutes` as keyword arg or take both `minutes` and `days` and pass all of them on to `timedelta`. i'm guessing you're aiming for backwards compatibility, but i don't think it's worth it given how confusing this is. atlernatively, make `mins=60*24*30` the default. and that brings me to another issue, `mins=None` is not a very useful default." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Please use a tab for indentation instead of spaces." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "I can't believe we didn't see this typo before :))" }, { "prediction": "I think this is what you are looking for: https://docs.google.com/cloud/forseti/services/inventory/base?hl=en", "reference": "If the logger isn't used, it probably doesn't need to be added." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "These files should in `/javascript/brython`" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "minor, you can squash these into one `if`" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "Used regexes to do most of this, hence different methods of string creation of UUIDs. I plan to follow up with an additional change to remove direct references to google/pborman UUID so `uuid.New()` and `uuid.NewRandom()` will instead use our `primitives.UUID`." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug.", "reference": "Add a TODO here to revisit if this was problematic." }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Note generally it -> It" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "Is this relevant to this PR?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "Can we instead ensure that `opts[:run_in_parellel]` will always be a boolean? Otherwise we'll have to account for the case when it's a non-boolean value in multiple places, such as any/every other `if` statement." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea to use the `NetAttributesFromHTTPRequest` function.", "reference": "Is this just moved out of the other files? It doesn't seem like this was generated like the other files." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "I started out doing everything `async`, but it was getting in the way of debugging, so I switched back to all synchronous until I got things working. We should probably move everything back to `async` and remove the synchronous versions." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "this looks already too complicated..." }, { "prediction": "I'm not sure if this is a bug, but it should be a bug.", "reference": "As for the testings, we better to verify the actual effects of the compaction. Of course, you could do it in future." }, { "prediction": "public static List getTiTableInfo(TiDBInfo db) { if (tableMap == null) { tableMap = loadTables(db); } return tableMap.values(); } public static List loadTables(TiDBInfo db) { if (tableMap == null) { tableMap = loadTables(db); } return ImmutableList.copyOf(tableMap.values()); } public static List loadTables(TiDBInfo db) { return tableMap.values(); } public static List loadTables(TiDBInfo db) { return tableMap.values(); } public static List loadTables(TiDBInfo db) { return tableMap.values(); }", "reference": "should we add a TODO here?" }, { "prediction": "I'm not sure if this is the issue, but I'm not sure if it's the issue, but I'm not sure if it's the issue.", "reference": "This can be inlined below as `GoogleSitekitDashboardDetails` is an unnecessary wrapper now." }, { "prediction": "I think this is a bug in the versionhistory package. It should be fixed in versionhistory.New([]byte(\"branch token\"), []*historyspb.VersionHistoryItem{ {EventId: lastWorkflowTaskStartedEventID, Version: lastWorkflowTaskStartedVersion}, }) - histories := versionhistory.NewVHS(versionHistory) + histories := versionhistory.NewVHS(versionHistory) + histories := versionhistory.NewVHS(versionHistory) + histories := versionhistory.NewVHS(versionHistory) + histories := versionhistory.NewVHS(versionHistory)", "reference": "NewVHS -> NewVersionHistories this one looks better" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Is this `@missing_text`?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Minor suggestion, but wouldn't it be cleaner to simply replace PACKAGE_NAME_FORMAT to all the optional path, then check that the path is empty in validate_package_name? We might also want a helper function to pull out the package name and sub-package path." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "we should have a way to insert components into a i18n string. so that we could define a translation string like `'%{filename} is being edited'`, and inject the filename `` at the right place. I imagine there must be a language where the `Editing` text should come after the file name. we can think about that later tho." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Probably want break instead of continue." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "This was on purpose that I would set logging (NoLog=false) and a dummy logger below. The idea is to have better code coverage and test of debug/trace statements. Any reason you have removed this?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "does adding a `Stream.empty()` help here?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing you're looking for something like this:", "reference": "This is not being used anymore, so can be removed." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this.", "reference": "Is it called some where?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Please remove this extra blank line." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "this is really the key, if you don't set this then gradle doesn't wire up the tasks that produce various files inside these configurations as inputs... I think we were just getting lucky before." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Sorry if I'm missing something here, but shouldn't this message be about failing to match with an *empty* selector, and/or perhaps even an empty *tag* instead of selector? The message seems a bit disconnected from what we're testing?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I'm sure it's a bug.", "reference": "nit: please move these inside namespace." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "may users try to abuse it?" }, { "prediction": "I'm not sure if this will work, but I think it's a bug.", "reference": "why is this space removed?" }, { "prediction": "I'm not sure if this is a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug.", "reference": "Can we remove this other line now then?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for 'qutebrowser/misc/checkpyver.py', 'qutebrowser/misc/guiprocess.py', 'qutebrowser/misc/editor.py', 'qutebrowser/misc/cmdhistory.py', 'qutebrowser/mainwindow/statusbar/keystring.py', 'qutebrowser/mainwindow/statusbar/percentage.py', 'qutebrowser/mainwindow/statusbar/percentage.py', 'qutebrowser/mainwindow/statusbar/percentage.py', 'qutebrowser/mainwindow/statusbar/percentage.py', 'qutebrowser/mainwindow/statusbar/percentage.py', 'qutebrowser/mainwindow/statusbar/percentage.py', 'qutebrowser/mainwindow/statusbar/percentage.py', 'qutebrowser/mainwindow/statusbar/percentage.py', 'qutebrowser/mainwindow/statusbar/percentage.py', 'qutebrowser/mainwindow/statusbar/percentage.py', '", "reference": "There's a comma missing here at the end :wink:" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "Why is this not required any longer?" }, { "prediction": "I'm not sure if this is what you're looking for, but it looks like you're looking for \"github.com/gogits/gogs/models\" \"github.com/gogits/gogs/modules/base\" \"github.com/gogits/gogs/modules/log\" \"github.com/gogits/gogs/modules/middleware\" \"github.com/gogits/gogs/modules/setting\" \"github.com/gogits/gogs/modules/setting\" \"github.com/gogits/gogs/modules/setting\" \"github.com/gogits/gogs/modules/setting\" \"github.com/gogits/gogs/modules/setting\" \"github.com/gogits/gogs/modules/setting\" \"github.com/gogits/gogs/modules/setting\" \"github.com/gogits/gogs/modules/setting\" \"github.com/gogits/gogs/modules/setting\" \"github.com/gogits/gogs/modules/setting\" \"github.com/gogits/", "reference": "Indentation seems a bit fucked up here. Run `go fmt`." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "any chance in == nil? same below" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "We would change the source code of h2o so that certain syscalls will be invoked through the `h2o_sysfn` macro." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "the name kTimelineCannotBeSignalled is confusing. It's not that a TimelineSemphore cannot be signaled... it's the \"VK_KHR_timeline_semaphore is enabled *variant* of the \"binary cannot be signaled\" message. We should probably have a consistent naming scheme to clarify. kBinaryCannotBeSignalledAltTimeline or hide the complexity in Get*VUID functions as needed somehow (pass in the extension structure?)" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Could you add a type hint? `percentiles: Optional[List[float]] = None`" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Maybe putting ones they've used before first would be good, but this is fine for now." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "I don't think we need these. Simpler just to put `routetable.TargetType...` inline below." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Why this instead of the old way?" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "Just combining the inner if/else blocks like this is what I originally meant (I didn't mean replacing all the invisible checks in the outer if, I realize that would have been a functionality change regarding the rule) This should now be equivalent to `if (RuleB(Pets, LivelikeBreakCharmOnInvis) || IsInvisible(formerpet))` (the second check for the rule being false after the `||` would be implied, anything after the `||` would only be evaluated if the rule was false)" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "We don't want to write this back to the definition do we? Probably just want to create a local variable for it." }, { "prediction": "I think this is a bug in PlaybackServiceCompat. It should be fixed in PlaybackServiceCompat. It should be fixed in PlaybackServiceCompat. It should be fixed in PlaybackServiceCompat.", "reference": "Good catch! Could you please move this to `PlaybackService.this.onPlaybackEnded`? I think it's more clean if everything is in one single place." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "We're trying to avoid X.org specific code. So I'm not a fan of this. Can't this be achieved in display server agnostic way?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "This class can be removed?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug in golang.org/golang.org/golang/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/protobuf/proto/protobuf/protobuf/protobuf/protobuf/proto/proto/protobuf/protobuf/proto/proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.proto.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "To minimize the possibility of regret, perhaps we name this `ZapLogger`." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "This looks a little weird, but it's a feature of the gem we're using. You can give it a symbol representing the method you want called on current_user." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'll report it here.", "reference": "`Anomaly` imported here, but not used. Please run the changed files through pylint with nupic pylint config and fix pylint findings related to your changes." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case.", "reference": "We needed this testutils file after all" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this.", "reference": "line is 161 characters (from `lll`)" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Please re-format/groupimport this line. You might need a little manual work." }, { "prediction": "I'm not sure if this is the case, but I think it's the case, so I'm not sure if it's the case, but I think it's the case.", "reference": "minor, you can just use `wf` instead of `worker.wf`" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if it's what you're trying to do. I'm not sure if this is what you're trying to do, but I'm sure it's what you're trying to do.", "reference": "I would suggest putting this in the resources directory with the same package as of this test class. Then you can utilize the method azkaban.utils.TestUtils#readResource to read it as string." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for \"k8s.io/apimachinery/pkg/apis/meta/v1\" or \"k8s.io/apimachinery/pkg/apis/meta/v1\" or \"k8s.io/apimachinery/pkg/apis/meta/v1\" or \"k8s.io/apimachinery/pkg/apis/meta/v1\" or \"k8s.io/apimachinery/pkg/apis/meta/v1\" or \"k8s.io/apimachinery/pkg/apis/meta/v1\" or \"k8s.io/apimachinery/pkg/apis/meta/v1\" or \"k8s.io/apimachinery/pkg/apis/meta/v1\" or \"k8s.io/apimachinery/pkg/apis/meta/v1\" or \"k8s.io/apimachinery/pkg/apis/v1\" or \"k8s.io/apimachinery/", "reference": "could not import github.com/openebs/maya/pkg/upgrade/templates (invalid package name: \"\") (from `typecheck`)" }, { "prediction": "I'm not sure if this is the issue, but if it's the case, then it's a bug.", "reference": "a official -> an official" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "I only want the proxy request for this to run for kinesalite." }, { "prediction": "I think this is a bug in React.js. I'm not sure if this is a bug, but I'm not sure if it's a bug.", "reference": "White space boya?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to create a new CloudFormation stack. I'm not sure what you're trying to do here, but I'm guessing you're trying to create a new CloudFormation stack. I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Maybe ditch these since `StackSummary` is not used anymore." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "suggest to indicate the value range & meaning in docstring" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "not sure if it works with prometheus by default, otherwise we will have to add this into prometheus config also" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "The rule renderer isn't meant to be stateful so probably best to move this out of here" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "passing in a `nil` here just so that the tests can pass in an alternative implementation seems weird, but I don't know what the convention is for doing something like this - @briandowns?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "IMO `dot` should be preferred. Remember `aXe`?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's a good idea to see what you're trying to do.", "reference": "Not a huge deal but this will block tests, also, don't they stay open by default now?" }, { "prediction": "I'm not sure what you're trying to do here, but I think it's a good idea to use a log buffer. I'm not sure what you're trying to do here, but I think it's a good idea to use a log buffer. I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Could you make it a local constant for now?" }, { "prediction": "I'm not sure what you're trying to do here, but I think it should be something like this:", "reference": "What is this `collection_id` field here?" }, { "prediction": "I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "Is there a reason why we don't use logging for this?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do.", "reference": "Exceptions should be placed in application layer -> infrastructure is aware of application - not the other way around" }, { "prediction": "I'm not sure what you're trying to do, but it seems like you're trying to do something like this:", "reference": "IIRC issue mentioned reporting _symbolic message_ - so in this case it would be `line-too-long`." }, { "prediction": "if ( ( ( ( ( ( ( ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Is this intended to be `spells[spell_id].reflectable` here? Edit: Should be `spells[spell_id].feedbackable`, right?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to add a column to a table that doesn't have a column called max_users. I'm guessing you're trying to add a column to a table that doesn't have a column called max_users. I'm guessing you're trying to add a column to a table that doesn't have a column called max_users. I'm guessing you're trying to add a column to a table that doesn't have a column called max_users, but I'm not sure what you're trying to do here.", "reference": "How should we set this for existing teams?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "It would be nice if we could verify that this is in fact the error we expected. But that's a latent issue, something for the backlog." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "I hate then some internal process specific middleware leaks into connection manager :( todo later." }, { "prediction": "I'll be refactoring a lot + # of this for https://github.com/numenta/nupic/issues/408, so this will be + # changing soon. -- Matt package_data = { + \"nupic.support.configuration_base\": [\"nupic-default.xml\"], + \"nupic.support.__init__\": [\"nupic-logging.conf\"], + \"nupic.support.__init__\": [\"nupic-logging.conf\"], \"nupic\": [\"README.md\", \"LICENSE.txt\", \"CMakeLists.txt\", \"CMakeLists.txt\", \"*.so\", \"*.dll\", \"*.dylib\"], \"nupic.bindings\": [\"_*.so\", \"_*.dll\"], \"nupic.bindings\": [\"_*.so\", \"_*.dylib\"], \"nupic.bindings\": [\"_*.so\", \"_*.dll\"], \"nupic.bindings\": [\"_*.so\", \"_*.dylib\"], \"nupic.bindings\": [\"_*.so\", \"_*.dll\"], \"nupic.bindings\": [\"_*.so\", \"_*.dylib\"], \"nupic.", "reference": "Reflects where these files were moved for `pkg_resources`." }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it.", "reference": "This should be computed('i18n.locale'...." }, { "prediction": "We need to override this for the test and we don't need to override it for the test, so we don't need to override it for the test, so we don't need to override it for the test, so we don't need to override it for the test, so we don't need to override it for the test, so we don't need to override it for the test, so we don't need to override it for the test, so we don't need to override it for the test, so we don't need to override it for the test, so we don't need to override it for the test, so we don't need to override it for the test, so we don't need to override it for the test, so we don't need to override it for the test, so we don't need to override it for the test, so we don't need to override it for the test, so we don't need to override it for the test, so we don't need to override it for the test, so we don't need to override it for the test.", "reference": "Can you explain to me what goes wrong here? Can the test be adjusted to set up working routing instead?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "We can get rid of this import then." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this.", "reference": "Not sure how useful is unlock event." }, { "prediction": "This code is copied from memdocstore/codec.go, with some changes: // `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `encodeDoc` `", "reference": "Consider make the second argument a `encoderOptions` which includes the `lowercaseFields` just like opening a collection." }, { "prediction": "I'm not sure if this is a bug, but I think it is a bug.", "reference": "What is the value of renaming this to `ctx`? We generally prefer the longer names because they are easier to read and to type." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do. I'm assuming you're trying to do something like this, but I'm not sure what you're trying to do. I'm assuming you're trying to do something like this, but I'm not sure what you're trying to do. I'm assuming you're trying to do something like this, but I'm not sure what you're trying to do. I'm assuming you're trying to do something like this, but I'm not sure what you're trying to do. I'm assuming you're trying to do something like this, but I'm not sure what you're trying to do. I'm assuming you're trying to do something like this, but I'm not sure what you're trying to do. I'm assuming you're trying to do something like this, but I'm not sure what you're trying to do. I'm assuming you're trying to do something like this. I'm", "reference": "Hm. This could be a case of left-sided driving, having u-turn lanes on the right side. Good catch, but looks good to me." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "There was a [JsonPropertyName(\"success\")] here it did serialize fine for me, so I am not sure what was the matter? Also maybe uppercase?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "we can just use read env here, pretty sure" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "Could you replace local hook with global hook `afterModifyTransformStart`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "You seem to be basing your PRs off an commit, which keeps reintroducing these changes, which makes it harder to review your PRs." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Maybe it would simpler to ignore opt_port if type!== 'number'?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea to use a Dictionary instead of an IEnumerable>. It's a good idea to use a Dictionary instead of an IEnumerable>. It's a good idea to use a Dictionary instead of an IEnumerable instead of an IEnumerable>. It's a good idea to use a Dictionary instead of an IEnumerable instead of an IEnumerable> instead of an IEnumerable>.", "reference": "As far as I can tell, `IDictionary` implements `IEnumerable>` so we are just making it more generic. From the issue, I understood that we want to maintain sequence/order. I believe `IEnumerable<>` won't fix the issue." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "This change prevents a user understanding how their server is configured. Best to leave at `info` level." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "I will add the following to the list: - api.SpecScale - api.SpecSticky" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so it's a bug.", "reference": "As defaultSendPort is being removed, and I don't like TODOs on examples, please remove the whole line" }, { "prediction": "I'm not sure if this is what you're looking for, but it's worth noting that this is what you're looking for.", "reference": "since we are now no longer expecting an input of float to return an empty string, i have removed this test case." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "It would be cleaner if you were to pack the name&desc in a `MetricName` and pass it to `MakeCounter`" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Do you know why do we need this?" }, { "prediction": "I'm using MvvmCross.Platform.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Presenters.Ios.Present", "reference": "I guess this using is what causes the build to fail" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "I like the explicit unregister approach." }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "We should able to use 0x30 as summary, and make 0x80 reserved for future." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "This allows strategic exclusion of http spans." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "why not just `string[]` instead of nullable" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "How does this work? Why isn't each tag after the first picked up as a new arg/flag?" }, { "prediction": "The resource id of the site instance in azure app services where the traced application is running. The resource id of the site instance in azure app services where the traced application is running. The resource id of the site instance in azure app services where the traced application is running. The resource id of the site instance in azure app services where the traced application is running. The resource id of the site instance in azure app services where the traced application is running. /// + public const string AzureAppServicesResourceId = \"Datadog-AzureAppServices-Resource-ID\";", "reference": "This key is actually yet to be determined. Meeting with the backend team and Garner to discuss." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "Why remove the crash protection? We're just going to get a bug filed on it." }, { "prediction": "I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "Maybe be consistent and name it `FRAME_OPTIONS`." }, { "prediction": "I'm not sure if this is the case, but if it's the case, then it's the case.", "reference": "This check/exception is a guard for the next few lines of code. It shouldn't be necessary now. In fact, I don't think you need the if (parentConnection.type == Blockly.INPUT_VALUE) branch at all." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "Could probably move these constants too?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm wrong.", "reference": "Maybe 'failed' instead of'missing'. Also do we really need to write ticket numbers here?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Test used to use old bouncycastle dependency which isn't needed anymore from Hadoop. Switched to use builtin Java split." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "nit: I think this would be more readable as \"Some language names contain Unicode characters\"." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Thanks for adding the header, but I don't think 2017 is a very accurate guess here. Could you do a quick search with git blame and change this accordingly?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Oh interesting - does web-test-runner not resolve package.json files?" }, { "prediction": "I'm not sure what you're trying to do here, but maybe you're looking for something like this?", "reference": "Is there a way to derive this value from the locale itself? I feel hardcoding the prefix in the props isn't the right approach, but I'm not sure what the locale file contains exactly." }, { "prediction": "I'm not sure if this is a bug, but if it's a bug, it's a bug.", "reference": "I'd much rather see these warnings in our devtools (`debug/index.js`). Strings contribute quite a bit to our file size and moving them there would prevent bloating core." }, { "prediction": "I'm not sure if this is the correct way to do it, but it's the correct way to do it.", "reference": "Use `String.format(Locale.US,...) to avoid the `Lint` warning." }, { "prediction": "The namespace of this Pod. The namespace of this Pod. The namespace of this Pod. The namespace of this Pod. The namespace of this Pod. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of this Service. The namespace of", "reference": "nit: ServiceReference represents a reference to a v1.Service." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "since it changes to the array, how about change the name to `DeviceNames`" }, { "prediction": "This is a top level property supported by CAS template engine. The top level property is a top level property supported by CAS template engine // // The policy specific properties are placed with RuntimeTLP as the top level property in the template engine // // The policy specific properties are placed with RuntimeTLP as the top level property in the template engine // // The policy specific properties are placed with VolumeTLP as the top level property in the template engine // // // The policy specific properties are placed with VolumeTLP as the top level property in the template engine // // // The policy specific properties are placed with VolumeTLP as the top level property in the template engine // // The template engine // // The policy specific properties are placed with VolumeTLP as the top level property in the template engine // // // The policy specific properties are placed with VolumeTLP as the top level property in the template engine // // // The policy specific properties are placed with VolumeTLP as the top level property in the template engine // // // The policy specific properties are placed with VolumeTLP as the top level property in the template engine // // // The template engine // // The policy specific properties are placed with VolumeTLP as the top level property in the template engine //", "reference": "Can we avoid this. upgrade engine code should take care of this." }, { "prediction": "I think this is a bug. It should be fixed in the next release.", "reference": "should also be alphabetized or at least grouped and alphabetized within group" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug in the _handle_ssl_support function. I'm not sure if this is what you're looking for, but it seems to be a bug in the _handle_ssl_support function.", "reference": "No need for this, as pylint already only turns things off for this function and it's needed for the entire function." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "nit: can we remove \"can't\" from the error message?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "instead of modifying 'Status' which impacts the state diagram, how about using some annotations on CVR? This can probably help for our upgrade as well. Is this possible? cc: @AmitKumarDas" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "Rename this as KubernetesGPGURL - >KubernetesUbuntuGPGURL, Modify it where ever it is used." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "I'm not totally sure I like the idea of putting a default fee here, but I guess so long as we make sure to track the default fee of bitcoin core, we're good. We should really also take a look at the byte size of the transaction, and use that to determine what the fee should be. But that could also be a different PR." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "oh yeah, `tail`, `update`, `prepend`, `append`, `subSequence`, `trim` just became effectively constant (without memory leak) :)" }, { "prediction": "I'm not sure if this is the correct way to do this, but I think it's the correct way to do it.", "reference": "Can you add back a deprecated `destroyLinks` method for backward compatibility? It can simply proxy `destroyResourceLinks`, and we can remove it in the next major release." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "A reminder that we should discuss whether to rename this to \"sockets\" or \"listeners\"." }, { "prediction": "I'm using eprosima::fastrtps::rtps::rtps::RTPSParticipantAttributes instead of eprosima::fastrtps::rtps::RTPSParticipantAttributes. I'm using eprosima::fastrtps::rtps::RTPSParticipantAttributes instead of eprosima::fastrtps::rtps::RTPSParticipantAttributes. I'm using eprosima::fastrtps::rtps::RTPSParticipantAttributes instead of eprosima::fastrtps::RTPSParticipantAttributes.", "reference": "Why do you need to include this using declaration?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "@halter73 where is this file generated from?" }, { "prediction": "This is an auto-generated file.", "reference": "What do these `#if TRUE` accomplish?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Probably a good optimization to have this, but I don't think it's strictly required. For \"legacy\" Activity flows we pass them through an ActivitySource for sampling. So the logic below should also catch these?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "@jessieay Intentionally moving away from passing a param?" }, { "prediction": "I think you need to do something like this: $firstname = $nameArr[0]; $lastname = $nameArr[0]; $firstname = $nameArr[0]; $lastname = $nameArr[0]; $firstname = $nameArr[0]; $lastname = $nameArr[0]; $firstname = $nameArr[0]; $lastname = array_shift($nameArr); $firstname = ''; $lastname = array_pop($nameArr); foreach ($nameArr as $value) { - $lastname.=''. $value; + $firstname.=''. $value; } - $lastname = trim($lastname); + $firstname = trim($firstname); $lastname = trim($lastname); $firstname = trim($firstname);", "reference": "I think you could condense this code considerably by getting rid of the initialization and foreach loop and simply saying: `$firstname = trim(implode(' ', $nameArr));` What do you think?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "hmm, we actually should _add_ `'use strict'` everywhere" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "it's not just fetching override properties here, right?" }, { "prediction": "I'm not sure if this is the case, but if it's the case, it's the case.", "reference": "Is it worth logging the error?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "What's the point of this class?" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this:", "reference": "I'm being picky here, but I think I would prefer `toggle` to be kept here and just change the condition to `contentType!=='movies' && contentType!=='mixed'` or `!['movies','mixed'].includes(contentType)`." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing you're looking for something like this:", "reference": "Please put this down with the other \"github.com\" imports." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do.", "reference": "Minor but probably want `push_front_preference` to have a trailing `_a` to be consistent with the other parameter" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "Nit: the formatting is a bit off. I would expect this to be 2 indentations from `this.expr =...` but this is 8 spaces, not 4. Also, most places leave the `);` on the last line of the method arguments." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Ack, @chrisdunelm snuck this class extension past me. This is not a pattern I want to have used..." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "nitpick: I wonder if we should name it `flush` only (?)" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Why gauges, not counters?" }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "Just making a note here that this may break pre GWs between pre 2.2.0 and 2.2.0 servers. Not sure, will have to experiment/dig a bit more." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Shall we rename this status to CONTAINER_FAILED? ^^ cc: @sshardool" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Thinking out loud here: I believe the only reason we need `peer.ID` as a parameter to this method is because we are not persisting blocks from pubsub (instead we are refetching them). If nodes persist the blocks they received over pubsub then I think we can guarantee peers we share a connection with (i.e. that are in the peer tracker) will always have the blocks we are fetching (else how would have we gotten the pubsub message). I imagine the concept of an `initialPeer` can go away once #2962 lands since the peers in the tracker will have the block. Although I don't think that covers the case of fetching blocks our peers have deemed semantically invalid and thus not stored..." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "I know it has no effect but my eyes can't help. Is that line not too long?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this.", "reference": "Does that mean we disable service loop prevention for packet generated by local host?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "It seems a little odd to have both `host.is_cygwin?` *and* `host.cygwin_installed?` defined (with a possibility of having `is_cygwin?` be `true`, but `cygwin_installed?` returning `false`). Do the docs clearly explain the difference?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Does this mean manifests will be written with the v2 schema (i.e. with sequence numbers) even though `TableMetadata` is v1 and the manifest list is written with v1? And this should work because we do a projection on read and sequence number is optional?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "Should we be sharing this property key with the read? Maybe it should be belong to the file-scan-task object itself?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Nice! Good idea to move these out of the main struct." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "Thanks for paying attention to other places this might happen. This one is particularly important; I probably never should have gotten in the habit of CheckErr(), since it does a log.Panic() explicitly, which looks like something else until you look closely. It's supposed to be used places where \"can't happen\" but Things Can Happen." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Converting this to an enum makes it obvious that I combined things that don't really belong together. It would probably be better to create two enums `StoreType` and `TransportType` (in more appropriate locations). That also makes it necessary to have (at least) two `ServerSettings` classes. `IncomingServerSettings` and `OutgoingServerSettings`. Also, the naming is inconsistent. Maybe it would be better to make the string that is used for import/export explicit, e.g. WEBDAV(\"WebDAV\")." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "It's out of scope for this PR, but I don't find this utility's name to be particularly intuitive. It speaks to nothing of what it does. Does it create a token list? Process one? Get one? `tokenListToArray` would be nice." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "The message for this check used the existence of a label to determine the output, which doesn't work with the current schema. So I updated it since the data only needed to know a label was present and not what it was." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think you're trying to do something like this:", "reference": "nit: \"The current project does not have requested application\"" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Extend Unit test for this class" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's what you're trying to do. I'm not sure if this is what you're trying to do, but it's what you're trying to do, but it's what you're trying to do.", "reference": "This is this a copy / paste error from above." }, { "prediction": "You can use the ```````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````", "reference": "this package has to be renamed to `typeinference`" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "This cancels the above null-check I guess." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "change to timerIntervalInMillis" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "`any rules` should be `any roles`" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's probably something you're trying to do. I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's probably something you're trying to do. I'm not sure if this is what you're trying to do. If it's what you're trying to do, it's probably something you're trying to do. If it's what you're trying to do, it's probably something you're trying to do. If it's something else, it's probably something you're trying to do.", "reference": "Why does the method need to be renamed? I would just keep the old name and update the other uses (which are only tests). That way, we can reduce code duplication." }, { "prediction": "I think this is a bug in the keyconf.py file. It should be fixed in the latest version of the keyconf.py file.", "reference": "I'm not sure if this is going to work - I think it's fine to keep them hardcoded here, as the statusbar can still show `:`, `/` and `?` even if the key is rebound." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "@tmetzke shouldn't we replace this library with the `2.12.1` instead of removing it?" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this:", "reference": "uint64 seems excessive here. Should we reduce to a uint32 @whyrusleeping?" }, { "prediction": "I'm not sure if it's a bug, but maybe it's a bug?", "reference": "Hmm, I thought this was getting used. These are used elsewhere as a cached value (in `svc deploy` it's `o.targetApp`) but I guess since storage doesn't actually need to validate that the app exists, just that there are local services, we never used it." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "To keep it simple, how would you feel about just using r.RemoteAddr? Since every request comes through here I want it to be as lean as possible. Frankly I'm OK with the port showing up in the log; maybe it'd even be useful to someone." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "grant bonus depends on both `admin{}` stored in statedb, and `P2Start/End` in local struct, which is kind of weird at Kamchatka height, we add the bonus Start/End epoch into `admin{}`, so it solely depends on `admin{}` stored in statedb" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Use single quote to wrap the str." }, { "prediction": "The permissioning whitelist configuration file is out of sync. Please review the current state of the whitelisting configuration file.", "reference": "Is the plan to rename this later?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Is there a reason why we need a special case for Email at this point? Is the idea that other methods can turn into Email even if it's not configured as a top-level option?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "This wording is a bit ambiguos, I first thought it meant the directory has no entries in it. maybe \"dir\" -> \"dir string\"?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "Why do we need both `HPX::m_hpx_initialized` and `HPX:: m_was_initialized`?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "also check RPCName?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Remove unused import" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "I assume there will never be a scenario where justValidate is expected to be true on a restart" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Report listeners are synchronized, even 'though the cache is thread-safe... I've not profiled it, but it may be a cause of contingency. Any better way around this? Also, do listeners **really** need to be synchronized? Can't we just make them thread-safe?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I don't think this is correct. When `compiler` is not given in `.travis.yml`, the announcement will be `--version`, which results in \"`command not found`\" (though not critical), and the cache slug will lack this information (also not critical)." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Why do this rather than `args = []` in the function signature?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "I think we probably *should* do validation of whether there is a suitable implementation if local-validation is true. I'm not sure how useful that actually is though" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "@StrikerRUS here may need to concat two data by col." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Why the space?" }, { "prediction": "@Zalcano is the default name of the Zalcano config. It's not the default name of the Zalcano config. It's the default name of the Zalcano config.", "reference": "please resolve the extra indentation" }, { "prediction": "IsNotLoadedExplained(SrmDocument document, SrmDocument previous) { return!ReferenceEquals(document.Settings.PeptideSettings.Libraries, previous.Settings.PeptideSettings.Libraries) &&!ReferenceEquals(document.Settings.MeasuredResults, previous.Settings.MeasuredResults) &&!ReferenceEquals(document.Settings.MeasuredResults, previous.Settings.MeasuredResults) &&!ReferenceEquals(document.Settings.MeasuredResults, previous.Settings.MeasuredResults) &&!ReferenceEquals(document.Settings.MeasuredResults, previous.Settings.MeasuredResults) &&!ReferenceEquals(document.Settings.MeasuredResults, previous.Settings.MeasuredResults) &&!ReferenceEquals(document.Settings.MeasuredResults, previous.Settings.MeasuredResults) &&!ReferenceEquals(document.Settings.MeasuredResults, previous.Settings.MeasuredResults) &&!ReferenceEquals(document.Settings.MeasuredResults, previous.Settings.MeasuredResults) &&!ReferenceEquals(document.Settings.MeasuredResults, previous.Settings.MeasuredResults) &&!ReferenceEquals(document.Settings.MeasuredResults, previous.Settings.Measured", "reference": "More proof that this check is needed always." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "`m_al_comms` now contains smart pointers." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Did you do a test run with the compare script? I'm nervous about what happens on all the generators..." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "For a client, we store host, as string c.host. That is what we use for monitoring and statsz. Not sure if its useful here or not. Looks like probably not." }, { "prediction": "I'm not sure if this is the case, but if it's the case, then it's the case.", "reference": "This change is suspicious. Why did the number of partitions increase?" }, { "prediction": "You can use `can_create!` instead of `can_create!`", "reference": "I'm still new to this area, so please forgive what may be a stupid question: When would this be false? And do we have a test for that situation?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Should there be any changes to this file at all?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "The only field being used is the KeyType; Instead, we can probably just make a `keyType` variable here." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This should be done by code-gen change happening in the hydra repo. I am tweaking it just to get CI into a 'passing' state" }, { "prediction": "The `registry` is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `registry` object. It is a `", "reference": "Cleaned up when I originally added support for passing `screenContext` here (and later `viewContext`) but that was removed." }, { "prediction": "I'm not sure if this is a C++ mangled name, but if it's a C++ mangled name, then it's a C++ mangled name. If it's a C++ mangled name, then it's a C++ mangled name, so it's a C++ mangled name. If it's a C++ mangled name, then it's a C++ mangled name, so it's a C++ mangled name. If it's a C++ mangled name, then it's a C++ mangled name, so it's a C++ mangled name. If it's a C++ mangled name, then it's a C++ mangled name. If it's a C++ mangled name, then it's a C++ mangled name, so it's a C++ mangled name. If it's a C++ mangled name, then it's a C++ mangled name, so it's a C++ mangled name.", "reference": "This looks like a bunch of whitespace fixing that's unrelated. Can you revert?" }, { "prediction": "DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\DoctrineBundle\\", "reference": "should be removed instead" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug.", "reference": "should use randomization?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "returning nil because we want to mayactl to exit with 0 status code." }, { "prediction": "h2o_status_collector_t *collector = (h2o_iovec_t) (h2o_iovec_t) (h2o_iovec_t) (h2o_iovec_t) (h2o_iovec_t) (h2o_iovec_t) (h2o_iovec_t) (h2o_iovec_t) (h2o_iovec_t) (h2o_iovec_t) (h2o_iovec_t) (h2o_iovec_t) (h2o_iovec_t) (h2o_iovec_t) (h2o_iovec_t) (h2o_iovec_t) (h2o_iovec_t) (h2o_iovec_t) (h2o_iovec_t) (h2o_iovec_t) (h2o_iovec_t) (h2o_iovec_t) (", "reference": "Is this change relevant to the PR? (and I believe we should use `text/plain` considering the fact that it can be displayed using web browsers...)" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug in Microsoft.Json.Schema.ToDotNet. It's a bug in Microsoft.Json.Schema.ToDotNet. It's a bug in Microsoft.Json.Schema.ToDotNet. It's a bug in Microsoft.Json.Schema.ToDotNet. It's a bug in Microsoft.Json.Schema.ToDotNet. It's a bug in Microsoft.Json.Schema.ToDotNet. It's a bug in Microsoft.Json.Schema.ToDotNet. It's a bug in Microsoft.Json.Schema.ToDotNet. It's a bug in Microsoft.Json.Schema.ToDotNet. It's a bug in Microsoft.Json.Schema.ToDotNet. It's a bug in Microsoft.Json.Schema.ToDotNet. It's a bug in Microsoft.Json.Schema.ToDotNet. It's a bug in Microsoft.Json.Schema.ToDotNet. It's a bug in Microsoft.Json.Schema.ToDotNet. It's a bug in Microsoft.Json.Schema.ToDot", "reference": "`[Flags]` is now auto-generated by an argument to the `EnumHint`. (The attributes happen to come out in this order. I don't think it's worth controlling the order.) #Resolved" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "I think same here - in general we don't need to use Setters / Getters since configParams isn't a public API." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Why using `fmt.Sprintf` where `fmt.Sprint` would do the work (notice no `f` in function name)?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "Extraneous blank line." }, { "prediction": "I'm not sure why you're getting this error, but I'm not sure why you're getting this error, but I'm not sure why you're getting this error, so I'm not sure why you're getting this error.", "reference": "nit: syntax : neither -> nor" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Is it safe to assume that these two keys are always present? `this[string]` will throw a `KeyNotFoundException` if they are not." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if this is the case, but I'm not sure if this is the case, so I'm not sure if this is the case.", "reference": "Is the `flowDefinitionId` sufficient to uniquely identify the flow or does it need to be the tuple ``?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Shouldn't it be in the reverse order? `DateTime::createFromInterface()` returns `self` and accepts `DateTimeInterface`." }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if this is the correct way to do it.", "reference": "this check is now redundant. The rest of the function downwards basically does the same thing but with safer checks." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Please could you remove the useless space." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug.", "reference": "What's the point of this block (and isn't it effectively dead code)?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Put a comma after the last parameter of a multiline method call." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Newline at end of file plz" }, { "prediction": "I'm not sure what you're trying to do, but it seems like you're trying to do something like this:", "reference": "Can this be refactored to avoid including the aws sdk in the types that we expose? I know it's not being exposed directly through the types we expose, but I do worry that it might make it easier to accidentally do that in the future and not realize it as easily." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "Hi thomas, i would propose to indicate in the name, that only the indextime is updated, otherwise somebody might think the whole items is getting updated. I would propose something like \"updateIndexTimeByItem(Item $item)\"" }, { "prediction": "Is there a way to check if element.is_displayed() == visibility? I don't think there's a way to check if element.is_displayed() == visibility, but I'm sure there's a way to check if element.is_displayed() == visibility.", "reference": "This is not the right exception class. There is an InvalidSelectorException class that covers bad locators." }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this:", "reference": "I assume this came from format?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be the same as what you're trying to do.", "reference": "I'd suggest a default value of `false` just to make sure existing tasks are ok when they get deserialized after an update to a version containing this code." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Do we really need this? Seems like it would pollute the logs pretty badly." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea to use a MemoryPoolBlock2 instead of a MemoryPoolBlock2.", "reference": "`Vector.Count` should Jit to const when intrinsic; not sure when `Vector.IsHardwareAccelerated == false` ; however we know `readonly static int` does Jit to const." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "Can we use a skipIf decorator instead?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "Missing version tags" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "I think this should also filter out `validate_resolve_reference` hooks." }, { "prediction": "I'm using OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation instead of using OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation. I'm using OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation instead of OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation. I'm using OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation instead of OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation.", "reference": "unrelated, but required fix as metrics branch got broken with the latest main->metrics merge and conflict resolution." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for, but it's what you're looking for.", "reference": "Feel free to remove this line" }, { "prediction": "I18n.t(\"shared.subscriptions.single_user\") is the same as `shared.subscriptions.single_user` and `shared.subscriptions.single_user` is the same as `shared.subscriptions.single_user`", "reference": "~~Should this match the key updated above?~~ :+1:" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug.", "reference": "`gofmt` allows a more compact form `defer func() { _ = f.Close() }()` or just add `// nolint:errcheck` before `defer`." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "collateral is in FIL" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "We should not create channel of node which are not connected." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to authenticate against a different database. I'm not sure what you're trying to do, but I'm guessing you're trying to authenticate against a different database.", "reference": "I think the docstring should say something like \"Alias for the `source` option\" or something similar." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Please use properties without suffix `_fr` so they can work across different languages as @teolemon mentioned" }, { "prediction": "I'm not sure if this is the case, but if it's the case, then it's the case, but it's the case.", "reference": "Declaration here is `static` but the definition at the bottom is non-static?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Hi @myml, thanks for the contribution! `blob` and `blob/driver` are both in the same module, so you shouldn't need to split this change up into multiple Pull Requests. Also, I'd like to see it working, including the implementation for `s3blob` and `gcsblob` (these should be easy, just pass-through to the provider) and `fileblob` (might be trickier...), and a test in `drivertest/drivertest.go`." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but if it's the case, it's the case.", "reference": "Was it a bug?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "You're accessing private variables here - `last_hovered_link` should be public in `TabData`. As for `tabbed_browser._now_focused`, I think you can use `tabbed_browser.widget.currentWidget()` instead." }, { "prediction": "I think this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do this in a different way. I'm not sure what you're trying to do here, but I'm guessing you're trying to do this in a different way, but I'm not sure what you're trying to do here.", "reference": "We should file a bug for this - we don't need the extensions class if there are no operations on the client" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "Is it possible to import from k8s instead of copy in? :)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "`@param float` can be dropped here." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "maybe we can leave this change un-reverted." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "I wouldn't make MethodDeclarator an AccessNode, nor an Annotatable. It's the MethodDeclaration that can be annotated, and has info about the modifiers, and is already an AccessNode" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "delete this class" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Replacing `+` (1 or more) with `*` (0 or more) would've also done the trick." }, { "prediction": "@TDTWriter::TDTWriter(std::ostream *outStream, bool takeOwnership) { if (takeOwnership) { this->writeNames = true; } else { this->writeNames = false; } }", "reference": "I've been meaning to fix this for a while. Thanks." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "This is adding multiple processor pipelines. I guess you wanted to add multiple processors to the same, single pipeline?" }, { "prediction": "I'm not sure what you're trying to do here, but I think it's a good idea.", "reference": "If you need str(x[0]) here, you'll probably need str(x) the line after that I suppose. Also, shouldn't we use `raw()` here instead of `str()`?" }, { "prediction": "I'm not sure if this is the case, but if it's the case, then it's the case.", "reference": "3.6 seconds? what does it stand for?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "If the command fails, is stdout nil or \"\"?" }, { "prediction": "I'm not sure if this is a valid API, but it's a valid API. I'm not sure if it's a valid API, but it's a valid API. I'm not sure if it's a valid API. I'm not sure if it's a valid API, but it's a valid API. I'm not sure if it's a valid API, but it's a valid API. I'm not sure if it's a valid API. I'm not sure if it's a valid API, but it's a valid API. I'm not sure if it's a valid API, but it's a valid API. I'm not sure if it's a valid API. I'm not sure if it's a valid API, but it's a valid API. I'm not sure if it's a valid API. I'm not sure if it's a valid API, but it's a valid API.", "reference": "Why is api-version now removed in the generated code?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for the 'optimizer' keyword.", "reference": "We may register all built-in optimizers of PyTorch here to simplify the builder." }, { "prediction": "private static const std::string GetName(const std::string &name, const std::string &qualifying_start_, const std::string &qualifying_separator_, const std::string &qualifying_separator_, const std::string &qualifying_separator_, const std::string &qualifying_separator_, const std::string &qualifying_separator_, const std::string &qualifying_separator_, const std::string &qualifying_separator_, const std::string &qualifying_separator_, const std::string &qualifying_separator_, const std::string &qualifying_separator_, const std::string &qualifying_separator_, const std::string &qualifying_separator_, const std::string &qualifying_separator_, const std::string &qualifying_separator_, const std::string &qualifying_separator_, const std::string &qualifying_separator_, const std::string &qualifying_separator_, const std::string &qualifying_separator_, const std::string &qualifying_separator_, const std::string &qualifying_separator_, const std::string &qualifying_separator_, const std::string &qualifying_separator_, const std::string &qualifying_separator", "reference": "No need for this new variable." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "doesn't this enqueue a double render or is that safeguarded somehow" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "But now you may get DATA RACE reports because c.acc is sometimes changed. I wonder if we should not rework that whole sending subs through route." }, { "prediction": "I don't know if this is a bug, but if it's a bug, it's a bug.", "reference": "Use `ADIADIOS2_HAVE_HDF5`, not `ADIOS_HAVE_PHDF5`" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Would be nice to put this in a separate context named `\"with a string and a non-string\"` (since that's what it is -- it's definitely not a non-string and a string!)." }, { "prediction": "I'm not sure what you're trying to do, but I think it should be something like this:", "reference": "Should MAX_PERTABLE_ENTRY here be 10?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's probably what you're trying to do.", "reference": "Should move these out of frame into a static class? Similar to reason phrases?" }, { "prediction": "We can use `` instead of `` instead of ``", "reference": "That means we still create `UseLane` instructions but threat them like `Suppressed`? Can we maybe change this in the pre-processing so that we will just emit `Suppress` instructions in these cases?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "no need to move here, iotex-proto is outside of iotex-core and considered same as iotex-address, go-pkgs" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Looks like a clang-format style violation: should turn Travis red." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I think we need some YARD docs here, particularly to list all the color symbols that are valid. Otherwise users will have to look at the source to discover that." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Not sure if this needs a doc block or not since it's completely internal, but for cleaning this up. (@felixarntz docs?)" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "The change here is to address what exactly?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do this from a shared access signature, but I'm not sure what you're trying to do here. I'm guessing you're trying to do this from a shared access signature, but I'm not sure what you're trying to do here. If you're using a shared access signature, you're going to need to do this from a shared access signature, but I'm not sure what you're trying to do here. If you're using a shared access signature, you're going to need to do this from a shared access signature, but you're going to need to do this from a shared access signature, so you're going to need to do it from a shared access signature, and you're going to need to do it from a shared access signature, so you're going to need to do it from a shared access signature, but you're going to need to do it from a shared access signature, so you're going to need to do it from a shared access signature.", "reference": "Is this really an Option? IIUC, you compute it automatically for the URLOpener case, why would we require a user to fill it in when using the constructor? I.e., can't we drop this and use `adal.MSIAvailable` instead? If that call is expensive, cache it on `bucket`, not `Options`." }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "Was this done automatically or by hand?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This looks like it will only work for the first child, since after that we've overridden `desired_group`. Should we have a separate variable for this?" }, { "prediction": "I'm not sure if I'm correct, but if I'm correct, I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "Should this be a constant somewhere?" }, { "prediction": "AssemblyInfo.PublicKey is not a public key. It's a public key. It's a public key. It's a public key.", "reference": "nit: sort alphabetically." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug. I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Now, It's redundant, I suppose." }, { "prediction": "I'm not sure if this is the case, but it seems to be the case.", "reference": "nit: The format recognized by tooling is `// Deprecated: [..]` so you likely want this to be, // Deprecated: Use \"go.uber.org/yarpc/peer/peerlist/v2\".Implementation instead." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "nit: 1. when formatting input strings, make sure to place them in quotes so we could identify white space issues. i.e. '%s' 2. If there is untyped, non-nil error, you want to log the error string as well." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "I believe this can be fixed with the original code if you just omit the \".dll\" file extension so it reads `[DllImport(\"Datadog.Trace.ClrProfiler.Native\")]`. On Windows it would look for `Datadog.Trace.ClrProfiler.Native.dll` and Linux/Mac it would look for `Datadog.Trace.ClrProfiler.Native.so`." }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug.", "reference": "couldn't we just read the boolean as a string (I would assume that this return \"true\" or \"false\"), migrate if to its new value and keep using the same pref key?" }, { "prediction": "static int skip_file_check = 0; static int cache_mode = 1; static int json_input = 0; static int jx_input = 0; static char *jx_context = NULL; static char *jx_context = NULL; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx_input = 0; static int jx", "reference": "If these variables are only used in main function, move these to the beginning of that function. If there is a foreseeable reason to have them as global statics just let me know." }, { "prediction": "private void setServiceProvider (ServiceProvider serviceProvider) { if (serviceProvider == null) { throw new ArgumentNullException(\"serviceProvider\"); + throw new ArgumentNullException(nameof(serviceProvider)); } if (region == null) { - throw new ArgumentNullException(\"region\"); + throw new ArgumentNullException(nameof(region)); } m_serviceProvider = serviceProvider; }", "reference": "This one was wrong." }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "What happens if nodes throughout a hierarchy are modified (as they would be)? It looks like we're going to `Reset` once for each `NodeID` affected." }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this:", "reference": "> Note that allocation of vmheap fails upon initializing dynamoRIO 64 on WoW64 processes. Thus, we need to pass -reachable_heap to avoid having to make this allocation. This should be solved by changing the default `vmheap_size` to be much smaller than 8GB for x64 DR inside WOW64." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "Is it really worth expanding our public API for this? After all, isn't calling this the same as calling `notification.fully_formatted(...).lines`? If so, I'd rather not widen our API (and thus, increase our maintenance burden) when it's so simple to get all the lines already." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Is it necessary to keep this class around just to define this constant? Or can we place it somewhere else?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Question - do we cache NetworkPolicy itself? If so, here we can point to NetworkPolicy?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but it seems like you're looking for \"k8s.io/client-go/util/workqueue\" \"k8s.io/client-go/util/workqueue\" \"k8s.io/client-go/util/workqueue\" \"k8s.io/client-go/util/workqueue\" \"k8s.io/client-go/util/workqueue\" \"k8s.io/client-go/util/workqueue\" \"k8s.io/client-go/util/workqueue\" \"k8s.io/client-go/util/workqueue\" \"k8s.io/client-go/util/workqueue\" \"k8s.io/client-go/util/workqueue\" \"k8s.io/client-go/util/workqueue\" \"k8s.io/client-go/util/workqueue\" \"k8s.io/client-go/util/workqueue\" \"k8s.io", "reference": "For my view, `Register` means the process of **insert node resource to etcd through api-server**, which is called by upstream rather than here, how about changing the func name to `OnConnected`?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "I would prefer an active verb for this property, e.g. `initializeTelemetry`. The reason is that this property refers to something the engine does once on startup. Other properties that use passive voice (e.g. `authorizationEnabled`) refer to a state of the engine during its lifetime." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "please use new line to maintain reasonable line width" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "I would skip this check or add an internal server error response." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "missing `{` here (and then `}` after `notary_password = config.notary_password`); it's only going to do the first one" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "This is odd because it's actually in our generated SiteSettingsPath, not in the SiteLocalSettingsPath (wp-config-ddev.php). Are these two files swapped somehow? I'd expect SiteSettingsPath to be wp-config.php and SiteLocalSettingsPath to be wp-config-ddev.php. BTW, I'm *way* ok with renaming that to SiteDdevSettingsPath." }, { "prediction": "The name of the `kythe-extraction-config` is \"kythe-extraction-config_go_proto\" and \"kythe-extraction-config_go_proto\" is \"kythe-extraction-config_go_proto\". The name of the `kythe-extraction-config` is \"kythe-extraction-config_go_proto\". The name of the `kythe-extraction-config` is \"kythe-extraction-config_go_proto\". The name of the `kythe-extraction-config` is \"kythe-extraction-config_go_proto\". The name of the `kythe-extraction-config` is \"kythe-extraction-config_go_proto\". The name of the `kythe-extraction-config` is \"kythe-extraction-config_go_proto\". The name of the `kythe-extraction-config` is \"kythe-extraction-config_go_proto\". The name of the `kythe-extraction-config` is \"kythe-extraction", "reference": "It seems like this must necessarily be a stopgap. Can you please add a TODO(#xyz) to point to the appropriate issue?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "Is the return signature necessary since we never actually return if there is a problem (I'm referring to the call to `logrus.Fatalf`). Let's pick a pattern and stick with it." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think this is what you're trying to do.", "reference": "@btecu why is this override needed here? I'm not seeing a `new` being used here." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "Should it not be more something like: `MaxAccountConnectionsExceeded` here?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "minor: use a non-default CE service account for testing (since default is handled in a specific way in the code)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "This is how I ran the 512MiB test. It's probably too much data for a fixture, and makes for longer functional tests (although still less than a minute on my laptop)." }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "So we weren't able to hide the fact that the file wasn't pre-generated and had to introduce this \"option\" to detect that?" }, { "prediction": "Should we expose the ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ``````````````````", "reference": "Agree that exporting these maps is the best tradeoff, just registering my ongoing discontent with the lack of `const` collections." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug.", "reference": "This could probably use `const` as well?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to create a backup copy of the original file. I'm guessing you're trying to create a backup copy of the original file, but I'm not sure what you're trying to do here. I'm guessing you're trying to create a backup copy of the original file, but I'm not sure what you're trying to do here. I'm guessing you're trying to create a backup copy of the original file, but I'm not sure what you're trying to do here.", "reference": "it doesn't look like these need to be exported?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for \"bytes\" instead of \"bytes\" (or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"bytes\" or \"", "reference": "I think you should remove \"fmt\" here. And change `fmt.Errorf` to `errors.Errorf`." }, { "prediction": "I think this is what you're looking for.", "reference": "Here's the `resources` attribute @jferris. I'm not against renaming `Product` to `Resource`, and this one... something else." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "If the context is unused, this is equivalent to `var wg errgroup.Group`." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "very minor: I'd prefer these two added rows are switched so that fragsizeIsMinimum directly follows fragsize" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Given that 115 returns `True`, why would this be `False` here?" }, { "prediction": "@Test public void oauth2LoginWithOneClientConfiguredAndRequestFaviconNotAuthenticatedThenRedirectDefaultLoginPage() throws Exception { assertThat(this.response.getRedirectedUrl()).matches(\"http://localhost/oauth2/authorization/google\"); } + // gh-5347 @Test public void oauth2LoginWithOneClientConfiguredAndFormLoginThenRedirectDefaultLoginPage() throws Exception { assertThat(this.response.getRedirectedUrl()).matches(\"http://localhost/oauth2/authorization/google\"); } + // gh-5347 @Test public void oauth2LoginWithOneClientConfiguredAndRequestFaviconNotAuthenticatedThenRedirectDefaultLoginPage() throws Exception { assertThat(this.response.getRedirectedUrl()).matches(\"http://localhost/oauth2/authorization/google\"); } + // gh-5347 @Test public void oauth2LoginWithOneClientConfiguredAndRequestFaviconNotAuthenticatedThenRedirectDefaultLoginPage() throws Exception { assertThat(this.response.getRedirectedUrl()).matches(\"http://localhost/oauth2/authorization/google\"); }", "reference": "Please move this test method just below `oauth2LoginWithOneClientConfiguredThenRedirectForAuthorization()`" }, { "prediction": "I don't think it's a bug, but I think it's a bug.", "reference": "Why this new configuration?" }, { "prediction": "@ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @", "reference": "I don't think that we need to check `hasArray` here. I think the reason why this didn't previously check `hasArray` is that the array passed to `DataByteArray` must start at offset 0 and be valid through the array length, so a copy was needed in almost every case. It may be simpler to change this to use `ByteBuffers.toByteArray` and pass the result to create `DataByteArray`." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "`spanReference` -> `baggage`" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "Why the `/-/verdaccio/`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Has been waiting for a million years" }, { "prediction": "This is not a valid value for path `{PATH}`. It is a valid value for path `{PATH}`. It is not a valid value for path `{PATH}`. It is a valid value for path `{PATH}`. It is a valid value for path `{PATH}`.", "reference": "Minor grammar detail: the 'than' is unnecessary" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I think you can just simply fix this line to `self[:2].to_pandas()`" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "if we are returning the `ws` here when passing in `se:cdp` we can just return it straight or do we have to make a request to get the `ws` address?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, and it's a bug.", "reference": "I could add a resolver for this (like above) but it seems more sensible to just change the one reference!" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "not sure \"actual\" adds value - secondsSinceParent is probably closer." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Line is too long. [94/80]" }, { "prediction": "I think you should change the'repeater' to'repeater.min_items_error' => 'You cannot delete any item. You should modify the'repeater.min_items_error' => 'You cannot delete any item. You should modify the'repeater.min_items_error' => 'You cannot delete any item. You should modify the'repeater.min_items_error' => 'You cannot delete any item. You should modify the'repeater.min_items_error' => 'You cannot delete any item. You should modify the'repeater.min_items_error' => 'You cannot delete any item. You should modify the'repeater.min_items_error' => 'You cannot delete any item. You should modify the'repeater.min_items_error' => 'You cannot delete any item. You should modify the'repeater.min_items_error' => 'You cannot delete any item. You should modify the'repeater.min_items_error' => 'You cannot delete any item. You should modify the'repeater.min_items_error' => '", "reference": "The error should be `At least :number items are required`" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "singleCaseSwitch: should rewrite switch statement to if statement (from `gocritic`)" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Could combine this with `encryptionKeyGetter` to have a single `keyGetter` interface. I'm not sure which way is better." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Is there any security issue here? If we integrate with Hive security (and I don't know if we have or not) is there some notion of re-authentication at connection time?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're trying to do something like this:", "reference": "Does this mean we do not support writeConcern on `createCollection`?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I guess `sid` was for `sessionID`, but now it looks strange: `sid.ID`." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug.", "reference": "We'll need `infrav1.SecurityGroupBastion` as well" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure.", "reference": "This `fileName` should probably be `remote` and be relative to the Fs root as per normal rclone usage." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing that you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do, but I'm guessing that you're trying to do something like this, and I'm not sure what you're trying to do.", "reference": "That way we are back to having just one index on k_0 So we can really compare the execution times with and without re-indexing" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Expression that uses a negation pattern to exclude all characters that aren't in the expression." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Similar to my suggestion for HTTP, let's remove this and use `ServiceHeader` instead." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "The serviceDirOnHost[0:1] was completely wrong. It wasn't just Windows, glad you got this fixed!" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "Would membership take 10+ seconds to detect the failed node?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "hmm, in this case perhaps the whole try-except could be removed altogether? because if the file does not exist, it's already returning `None`. In any other case it should actually probably fail with the exception, no?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "This function does not need to be public" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but I think it's what you're looking for.", "reference": "Any chance we can get a CSS class for this? I know it's just in one place but feels like a dangerous precedent to set." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "> && this.Extensions.ContainsKey(\"nextMethodName\") [](start = 96, length = 48) From line 124, looks like we don't need `&& this.Extensions.ContainsKey(\"nextMethodName\")` condition or we don't need line 124 #Closed" }, { "prediction": "I'm not sure if this will work, but I'm not sure if this will work, or if it's not, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Moving this code from compat to core shaves 47 bytes out of compat and only adds 6 bytes to core so I thought it was worth it." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Please use \".NET Core 3\" - i'm trying hard to use one form, and this is the one MS advices" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Unrelated to this change, but this is a fix for when TestDoStartCgroupInitHappyPath has a failure after the test goroutine has already exited." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Hmm, I'd really expect this to work, and yet it doesn't. I'll investigate later, though it might get Monday until I get the time." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Does this changes affect process building dynamic libraries anyhow?" }, { "prediction": "import time from scapy.packet import * -from scapy.contrib.ppi import PPIGenericFldHdr, addPPIType +from scapy.layers.dot11 import * from scapy.error import warning import scapy.modules.six as six from scapy.modules.six.moves import range from scapy.modules.six.moves import range from scapy.modules.six.moves import range from scapy.modules.six.moves import range from scapy.modules.six.moves import range from scapy.modules.six.moves import range from scapy.modules.six.moves import range from scapy.modules.six.moves import range from scapy.modules.six.moves import range from scapy.modules.six.moves import range from scapy.modules.six.moves import range from scapy.modules.six.moves import range from scapy.modules.six.moves import range from scapy.modules.six.moves import range from scapy.modules.six.moves import range from scapy.modules.six.moves import range from scapy.modules.six.moves import range from scapy.modules.six.moves import", "reference": "Could you limit what is imported here?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "just to clarify - on line 1074 we update `zip_file_content` for non-local lambdas, but never store it, which means lambda never picks it up" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "Golang naming convention is to use camel case `icmpPktWithTypeCode` Often the linter will complain" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "We can do away with assigning the response here too." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Bumping the newViewportHeight" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Is this change correct? Looks like a typo and not sure this should be changed?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "I checked the tests coverage and strangely it look like those three lines are not covered (?!). Do you have the same result on your side?" }, { "prediction": "I'm not sure if you're using System.MathBenchmarks or if you're using System.MathBenchmarks or if you're using System.MathBenchmarks or if you're using System.MathBenchmarks or if you're using System.MathBenchmarks or if you're using System.MathBenchmarks or if you're using System.MathBenchmarks or if you're using System.MathBenchmarks or if you're using System.MathBenchmarks or if you're using System.MathBenchmarks or if you're using System.MathBenchmarks or if you're using System.MathBenchmarks or if you're using System.MathBenchmarks or if you're using System.MathBenchmarks or if you're using System.MathBenchmarks.", "reference": "nit: please try to avoid changing end of the file (it adds a noise to the code review, but does not provide too much value)" }, { "prediction": "public static IEnumerable pathObj.Where` and lines won't be that long." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "It seems like most of these will never be nil, are they optional just in case?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "`.addColumn(\"c1\", IntegerType.INT, true)` means `PkHandle=true`, maybe should add `.setPkHandle(true)` in line 31" }, { "prediction": "@ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @", "reference": "how about `Cannot encode row key with non-integer type` directly?" }, { "prediction": "I'm not sure if this is the case, but if it's the case, it's the case, it's the case.", "reference": "The method names `fetchUnfinishedExecutions` and `fetchUnfinishedFlows` are too similar to each other. Would it be better to use the name `fetchUnfinishedFlowsMetadata` since you are only fetching metadata info about the flow?" }, { "prediction": "We are setting up the debug environment. This may take a while. We are setting up the debug environment. This may take a while. We are setting up the debug environment. This may take a while. We are setting up the debug environment. This may take a while. We are setting up the debug environment. This may take a while. We are setting up the debug environment. This may take a while. We are setting up the debug environment. This may take a while. We are setting up the debug environment. This may take a while. We are setting up the debug environment. This may take a while. We are setting up the debug environment. This may take a while. We are setting up the debug environment. This may take a while. We are setting up the debug environment. This may take a while. We are setting up the debug environment. This may take a while. We are setting up the debug environment. This may take a while. We are setting up the debug environment. This may take a while. We are setting up the debug environment. This may take a while. We are setting up the debug environment. This may take a while...\" sh.cmd \"brew update &> /dev/null\", echo: false", "reference": "Note that `sudo` is not available by default on BSDs; there are a few places in the codebase here where that's explicitly worked around by using `su`." }, { "prediction": "I think this is the answer to your question. It's not the answer to the question, it's the answer to the question itself. It's the answer to the question itself, it's the answer to the question itself, it's the answer to the question itself, it's the answer to the question itself, it's the answer to the question itself, it's the answer to the question itself, it's the answer to the question itself, it's the answer to the question itself, it's the answer to the question itself, it's the answer to the question itself, it's the answer to the question itself, it's the answer to the question itself, it's the answer to the question itself, it's the answer to the question itself, it's the answer to the question itself, it's the answer to the question itself, it's the answer to the question itself, it's the answer to the question itself, it's the answer to the question itself, it's the answer to the question itself, it's the answer to the question itself, it's the answer to the question itself, it's the answer", "reference": "ultra nit: missing Oxford comma :P" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "This is not supported in Spark 3.0.0-rc2 yet. I'd skip this for now." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "BLOCKING: Why does `Query` return an `*exec.FunctionSignature`?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "please move this down to immediately above the assignment to `c.dirtyBcache`" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "Don't need the `, err` part since you've already handled it." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug, so I'm not sure if it's a bug or a bug. I'm not sure if it's a bug or a bug, but I'm sure it's a bug.", "reference": "Please add two additional SECTIONs that show that this also works if the dative bond is in the reactant (reaction SMARTS `[O:1]->[H+]>>[O:1].[H+]`) or in the agents (reaction SMARTS `[O:1][H]>N->[Cu]>[O:1].[H]`)" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "What happens if the certificate rotation fails and we are prematurely removing this file?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "does this change belong here?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "This returns an error" }, { "prediction": "I think this is a bug in the libcalico-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go-go", "reference": "If we think we might someday write a native nftables backend, do you think it would make sense to just use generic dataplane configuration? e.g, `dataplane = iptables | ebpf | nftables`, but for now selecting `nftables` uses iptables in nft compat mode?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here.", "reference": "Looks like that helper function is general enough that it should reside in testhelpers" }, { "prediction": "I'm not sure if this will work on Drupal 6 or Drupal 7 or Drupal 7 or Drupal 8 or Drupal 8 or Drupal 7?", "reference": "This isn't incorrect IMO, but I think it would be better to fix this in drupal7PostStartAction and also in drupal6PostStartAction. It seems to me like those were both somehow neglected on this. Use drupal8PostStartAction as example. Congrats on your first golang PR! Please make sure to test it manually." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do. I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "I'd like to ensure that the error message at least has some reference to the flag that is not allowed. Something like `/ERROR(.+)--hosts/` would work." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "Should we say \"specifying two public subnets\"?" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "Issue number? When? Why?" }, { "prediction": "@ -35,6 +35,7 @@ from._sapi4 import ( VOICECHARSET ) import config +import speech import nvwave import weakref", "reference": "You should not rely on `PitchCommand` being imported into speech. Please import it from `speech.commands`." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct. I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "Is this a constant used in the Nessie project itself? If so, perhaps you might consider a follow up for adding `NessieCatalogProperties` class at some point, to help make them more clear to users looking to adopt Nessie coming from the Iceberg repo itself" }, { "prediction": "I'm not sure if this is what you're trying to do, but it should be something like this:", "reference": "maybe we should rename: MinTaskID -> MinTaskIDExclusive, MaxTaskID -> MaxTaskIDInclusive," }, { "prediction": "@ -70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,70,7", "reference": "You may need to make this configurable if we expect people to be able to use the normal Nvidia runtime on other Linux distributions like Ubuntu or Debian." }, { "prediction": "I'm not sure if this is what you're looking for, but it's probably what you're looking for. I'm not sure if this is what you're looking for, but it's probably what you're looking for.", "reference": "Originally the DenyExport was a subscribe permission because it meant that if on this LN connection, if we deny export of \"foo\" it means that it would reject a subscription (hence subscribe permission) on \"foo\" from the other side. Now you are changing to simply not allowing this server to publish on \"foo\". I am not saying this is wrong, but we completely flip the meaning." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "> k1 src0 src2 -> dst s/src2/src1/ nit: k1 is actually src0 according to instr_get_src(instr, 0) which makes this a little confusing" }, { "prediction": "I'm not sure if it's a bug, but if it's a bug, it's a bug. If it's a bug, it's a bug. If it's a bug, it's a bug. If it's a bug, it's a bug. If it's a bug, it's a bug. If it's a bug, it's a bug. If it's a bug, it's a bug. If it's a bug, it's a bug.", "reference": "I believe that you meant to have the following on the second one, right? `dataDirStat.Mode()^0077`" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "The reason a `ByteCount` is used here, is that the H2 mapping in gQUIC requires this layer violation, which is why `CloseRemote` is not part of the public API. This layer violation will be resolved in IETF QUIC" }, { "prediction": "IsInvisSpell(uint16 spell_id) { return!IsInvisSpell(spell_id) &&!IsInvisSpell(spell_id, SE_InvisVsUndead) &&!IsInvisSpell(spell_id, SE_InvisVsUndead2) &&!IsInvisSpell(spell_id, SE_InvisVsAnimals) &&!IsInvisSpell(spell_id, SE_InvisVsAnimals) &&!IsInvisSpell(spell_id, SE_InvisVsAnimals) &&!IsInvisSpell(spell_id, SE_InvisVsAnimals) &&!IsInvisSpell(spell_id, SE_InvisVsAnimals) &&!IsInvisSpell(spell_id, SE_InvisVsAnimals) &&!IsInvisSpell(spell_id, SE_InvisVsAnimals) &&!IsInvisSpell(spell_id, SE_InvisVsAnimals) &&!IsInvisSpell(spell_id, SE_InvisVsAnimals) &&!IsInvisSpell(spell_id", "reference": "I dig the helper function!" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for a package that contains sample programs using the pubsub API. I'm not sure if this is what you're looking for, but it seems like you're looking for a package that contains sample programs using the pubsub API. I'm not sure if this is what you're looking for, but it seems like you're looking for a package that contains sample programs using the pubsub API. I'm not sure if this is what you're looking for.", "reference": "Please add the Copyright header." }, { "prediction": "I think this is a bug in luigi-interface. It should be fixed in the latest version of luigi-interface.", "reference": "Is this the best way to import `FileSystemTarget`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here.", "reference": "Wait -- os_local_state_t.tid is thread_id_t though, so we need to read a pointer-sized value via READ_TLS_SLOT_IMM, rather than changing these locals to ints. Maybe have a READ_TLS_TIDSZ_SLOT_IMM or sthg." }, { "prediction": "The ICorDebug interface cannot be constructed.", "reference": "Don't use! in the messages because it isn't used on xplat. There is a SOSPrefix define that can be used (blank on xplat and! on Windows). Do we really need 3 newlines?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "print out what we got here in the error" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Does this need to be global?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "Yep, could be simplified. Now looks like other *Map.values() impls" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This method will be for debug?" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "// Key returns the private key for a specified name that was encrypted with the // provided password. If the private key does not exists it creates a new one // with a name and the password, and returns with `created` set to true." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Adding the type hints revealed that it was necessary to distinguish between a ``PackageEntity`` and a ``ClassEntity``, because the ``ClassEntity`` has additional attributes that were dynamically added in the previous code, which confused ``mypy``." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "These two functions should be available now." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "`fi` is what the result of Stat is called elsewhere in this file not `finfo`" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I'm confused; are we just dropping these methods without deprecation?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "can we use PC's time to version in Distributed Systems?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "is this \"unless\" actually needed?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here, so I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "We don't accept empty words for lookup anymore, again" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "We'll have to account for CI installations being faster than local ones. Do y'all think we should leave it at < 30 green / < 50 orange | >= 50 red or lower our thresholds?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "No need for this to be `W3C_` since there is no JWP equivalent" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a good idea to use `RSpec::Core::Backports::Random` instead of `RSpec::Core::Backports::Random`", "reference": "As far as I can tell, there's nothing that creates an instance of `Random` or that calls `rand` or `seed`. Am I missing it? If not, let's remove the `Random` class since we don't really need it and we can move the definitions of `shuffle` into `RSpec::Core::Ordering`. One less type :)." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Is this ever actually used?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "this section of the codebase should be noted as a candidate for caching, and as a place where multiple tipsets is making things extra tricky" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, and it should be fixed.", "reference": "Do we need to save the existing value of the stolen reg somehow?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "maxResults should come from FLAGS once #244 is submitted." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "is this wanted?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like get_linode_executable() instead of get_lxc_executable(). I'm guessing you're trying to do something like get_linode_executable() instead of get_lxc_executable() but I'm not sure what you're trying to do here, so I'm guessing you're trying to do something like get_linode_executable() instead of get_lxc_executable().", "reference": "What exception is actually happening here? AFAIK `pytest.importorskip` with just return `None` if there's nothing to import. Which means that this check'd always return `True`. `pytest.importorskip` is specifically designed to trigger skipping the current test anyway so I don't know why you would wrap it like this." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Does it send requests with urlencoded bodies anywhere? I thought it sends only json. Maybe content-type should be `application/json` by default?" }, { "prediction": "This flag is deprecated and will be removed in the future.", "reference": "I'm not sure about adding more flags here when we're trying to simplify things, I thought we were going to check for patches changes to decide if we needed to update or not?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "`testExecutionPb` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for the $this->getProviderReference() method. If you're looking for the $this->getProviderReference() method, you'll need to use the $this->getProviderReference() method. If you're looking for the $this->getProviderReference() method, you'll need to use the $this->getProviderReference() method.", "reference": "~Method is public and removing it would be a BC Break, you can deprecate it if you want.~" }, { "prediction": "I'm not sure if there was an error in the code, but I'm not sure if there was an error in the code or if there was an error in the code or if there was an error in the code or if there was an error in the code, so I'm not sure if there was an error in the code or if there was an error in the code or if there was an error in the code or if there was an error in the code or if there was an error in the code or if there was an error in the code or if there was an error in the code or if there was an error in the code.", "reference": "this got me a little confused when reading `build.log`. The err is printed with a log.Error later on but that ends up after the stack trace." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Can we make these more explicitly for Rust only? It seems like JS and Go use flags with their name in them." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Should unsupported query parameters just be ignored? I think that's more common than error out." }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Actually can we avoid mentioning `Register._UNSET_NAMESPACE`. I thought of it as an implementation detail of the simpler concept of \"being unset\". Perhaps the docs become more natural if we remove the \"If called without arguments or with...\" part and just say \"you have to call this function without arguments at the end of any file it has been used. That is to ensure blah blah\". Something like that. Just a suggestion." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I assume it raises COMError? If so perhaps best to just catch that specifically, so as to not hide other more critical errors." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for \"minify\", \"log\", \"gzip\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors\", \"errors", "reference": "Since minify can generate errors, it should at least go after the errors middleware. And you definitely don't want to be minifying after the gzip writer has closed." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to create a SpanRecorder. I'm not sure what you're trying to do, but I'm guessing you're trying to create a SpanRecorder. I'm not sure what you're trying to do, but I'm guessing you're trying to create a SpanRecorder. I'm not sure what you're trying to do, but I'm guessing you're trying to create a SpanRecorder. I'm not sure what you're trying to do, but I'm guessing you're trying to create a SpanRecorder.", "reference": "nit: we could remove the `config` field as it is a duplicate of the `provider.config` field." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're trying to create a firewall rule to open only port tcp:50051 # within the internal network (ip-ranges - 10.128.0.0/9) gcloud.create_firewall_rule( - self.format_firewall_rule_name('forseti-server-allow-grpc'), + self.format_firewall_rule_name( + 'forseti-server-allow-grpc-internal'), [self.gcp_service_account], [self.gcp_service_account], [self.gcp_service_account], [self.gcp_service_account], [self.gcp_service_account], [self.gcp_service_account], [self.gcp_service_account], [self.gcp_service_account], [self.gcp_service_account], [self.gcp_service_account], [self.gcp_service_account], [self.gcp_service_account], [self.gcp_service_account], [self.gcp_service_account], [self.gcp_service_account],", "reference": "Nit: from the Internet." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "this is internal package, move to bottom and run'make fmt'" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm wrong, or if I'm wrong, or if I'm wrong, I'm wrong.", "reference": "Why is this better than ApplicationStopping?" }, { "prediction": "This is a ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Maybe worth expanding that these 2 are supported by cert-manager but other values exist" }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to call a function from a template that doesn't exist. I'm not sure what you're trying to do here, but it seems like you're trying to call a function from a template that doesn't exist.", "reference": "Why was this merged? It should have raised some questions IMO @core23 @OskarStark. It's already in 3 releases now, so we can't revert it can we? How can we fix this? Please have a look at #1065" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct. I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "What if `node.jsonRpcConfiguration().getAuthenticationPublicKeyFile()` is empty string, would that cause a problem here?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "The `omitempty` struct tag does not do anything for non-pointer structs. I think we may need to consider making both of these fields pointers, so that they are excluded from output when not set, and also to make it easier to compare to the zero value. That said, I'm happy to merge this now and open an issue to verify the behaviour is as we want ahead of cutting v0.6.0." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "I think this is should absolutely be `==`, as the interface cannot control the implementation of equals (and it's part of the contract of the enclosing function). Can we add this interface to the exceptions of the rule?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "It looks like the UID is the only other thing that we use from `namespace`, so I suggest to copy that out and lose `namespace`, so we don't have to worry about setting it to nil." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I'm assuming it's what you're looking for.", "reference": "Can we define this constant in the`deploy` pkg instead? this would allow us to keep it private" }, { "prediction": "@pytest.fixture def init_linter(linter: PyLinter) -> PyLinter: linter.open() - linter.set_current_module(\"toto\") + linter.set_current_module(\"toto\", \"mydir/toto\") linter.set_current_module(\"toto\", \"mydir/toto\") linter.set_current_module(\"toto\", \"mydir/toto\") linter.set_current_module(\"toto\", \"mydir/toto\") linter.set_current_module(\"toto\", \"mydir/toto\") linter.set_current_module(\"toto\", \"mydir/toto\") linter.set_current_module(\"toto\", \"mydir/toto\") linter.set_current_module(\"toto\", \"mydir/toto\") linter.set_current_module(\"toto\", \"mydir/toto\") linter.set_current_module(\"toto\", \"mydir/toto\") linter.set_current_module(\"toto\", \"mydir/toto\") linter.set_", "reference": "I don't like this fixture name, should be a noun like `initialized_linter`? But it's outside of the scope of this MR." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Could we keep this as a static reference (JsonPrinter.jsonAsDatasetDto(releasedVersion); and perhaps change the constructor line to just be a static set method and use that here instead? (I suspect it was the warning that'static methods should be accessed in a static manner' from my IDE that caused me to make this change in the first place...) (I can make a PR to your branch if you want.)" }, { "prediction": "The modifier key is never released implicitly. The key is sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or ", "reference": "Keys.COMMAND seems to be an alias to Keys.META. That isn't mentioned?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "This should go in `ConfigLocal` (and then re-generate the mocks)." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Nitty but entry.get for the same thing" }, { "prediction": "This is the golang entry point for `nsexec` (see https://github.com/sirupsen/logrus/nsexec.git)", "reference": "Might not hurt to mention the function never returns (since this all ends in `execve`) so `main` never actually runs." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, it's a bug.", "reference": "nit: add new line after this block" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "I believe there is some javascript that also uses this 60px number for calculations. I think I'd rather keep the number in px instead of rem to make that correspondence easier to see. If 3.25rem!= 60px, can you also change the other place where `60` is used to in the JS?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "retrying is an installed 3rd party library just like jinja and sendgrid; perhaps try grouping all of them together?" }, { "prediction": "@ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @", "reference": "you could always use List.listIterator with previous() and hasPrevious() to traverse all kinds of j.u.List backwards. No need for special cases for ArrayList and Vector." }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if it's the correct way to do it.", "reference": "remove the bitmap of index 1 from the list not the 0th one. because when we keep on undoing, it would be better if we end up with the original image rather than some randomly edited image. I am not sure whether only just removing bitmap from the list would clear memory. I think you should call bitmap.recycle before removing that bitmap from the list." }, { "prediction": "You may not use this file except in compliance with the License. You may not use this file except in compliance with the License. You may not use this file except in compliance with the License. You may not use this file except in compliance with the License.", "reference": "this is a existing file so let's keep 2019" }, { "prediction": "@ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @", "reference": "can you change this instead to just `type.toString()` and then you wouldn't have to expose the getBitMask in the enum. (Alternatively you could have used `type.hashCode()` but that doesn't feel as nice)" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "AsReadOnly() would be better here" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "I suggest that we use `query_based_sync` instead of `partial_sync`." }, { "prediction": "This is a ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "How does the user use this? By converting the type using `As` function and add the header? Maybe add an example on how." }, { "prediction": "I'm not sure if this is the correct way to do this, but I think it's the correct way to do it.", "reference": "I'm trying to understand the effects of this change. Is setting this to something other than the old default (that is, `initCodeTransformer = new InitCodeTransformer()`) generally necessary, or are we doing this only to support Python?" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "\"Constructor\" isn't a standard term in Go or this project, although we use it informally amongst ourselves. And I think it will confuse people coming from languages like Java. So can we leave this as it was?" }, { "prediction": "I'm not sure if this is the case, but it seems to be the case.", "reference": "Why do we have to change the test dir?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "This should test the flattened tree instead. details > summary works across shadow tree boundaries." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "Not sure I am a big fan of these duplicated Log classes." }, { "prediction": "@ -39,6 +39,10 @@ import ( const ( reasonDomainVerified = \"DomainVerified\" + CleanUpError = \"CleanUpError\" + PresentError = \"PresentError\" + Presented = \"Presented\" + Failed = \"Failed\" ) )", "reference": "It's long-winded, but the convention is to give constants a common prefix which, see `reasonDomainVerified`." }, { "prediction": "I'm going to assume that this is the case, and that this is the case, and that this is the case, and that this is the case, and that this is the case, and that we're not going to use this, and we're not going to use it, so we're going to use it.", "reference": "Using lanes later down, this threshold could be reduced for similar effects. Otherwise we look a bit to far." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Let's get more verbose about names. struct `wq_conda_environment`: if it can really only be used for conda. struct `wq_software_environment`: if it has potential use outside of conda." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Should we set this back to `false` inside each `t.Run`? so that we can have more than one testcase that can have paginated responses" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, then you'll need to change it to something like this:", "reference": "What about using `dataManifests == null || deleteManifests == null`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "The `HitsThresholdChecker` should be created once and shared within the collectors? We also don't need to use the `GlobalHitsThresholdChecker` if the executor is null or if there is a single slice." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're looking for something like \"k8s.io/apimachinery/pkg/util/intstr\" or \"k8s.io/apimachinery/pkg/util/intstr\" or \"k8s.io/apimachinery/pkg/util/intstr\" or \"k8s.io/apimachinery/pkg/util/intstr\" or \"k8s.io/apimachinery/pkg/util/intstr\" or \"k8s.io/apimachinery/pkg/util/intstr\" or \"k8s.io/apimachinery/pkg/util/intstr\" or \"k8s.io/apimachinery/pkg/util/intstr\" or \"k8s.io/apimachinery/pkg/util/intstr\" or \"k8s.io/apimachinery/pkg/util/intstr\" or \"k8s.io/apimachinery/pkg/util/intstr", "reference": "move this to below `antrea.io` import section" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, and it's a bug.", "reference": "Seems likely to confuse people. What if we moved it into ActivitySourceAdapter and made it private?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "gas price don't need to be a multiple cuz we support allll gas prices now" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's a good idea.", "reference": "We are exposing implementation details in the interface. What if there is no processes involved in an implementation of `ITestRequestSender`?" }, { "prediction": "I'm not sure if it's a bug, but if it's a bug, it's a bug.", "reference": "It would be awesome not to handle the broad exception here. Instead, raise a custom exception, something like `ModelNotSetException`, from the `require_model()`, and then handle it here with a nicer message to tell the user to set the model first." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This already exists under the `theme` lang key, please remove this." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Let's add a simple inline HOC around the default export below to provide the value as a prop (no need to introduce a reusable function for this yet)." }, { "prediction": "I'm not sure why you're getting this error, but I'm not sure why you're getting this error. I'm not sure why you're getting this error, but I'm not sure why you're getting this error. I'm not sure why you're getting this error, but I'm not sure why you're getting this error.", "reference": "I believe that you end up printing out the result of the assignment here instead of the netmask." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "We have to update the filename here." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "The `--cpp-field-case` looks like `--cpp-field-style` instead of `-case`. - 'unchanged' - leave unchanged (default); - 'upper_camel' -upper camel case; - 'lower_camel' - lower camel case." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "I haven't thought about this a lot yet, but if we were to try this change, we'd still need to keep the code to delete it from the `.origin` file for backcompat." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "In my opinion I think it is possible to add `private final` here" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Feel like \"exit\" doesn't convey that the packet will be dropped. \"drop-and-exit\" or \"error-exit\" maybe?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "How do you feel about \"The Main actor\" instead of \"A Main actor\", while we're already here changing the message?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "I cannot see that this new permission is used anywhere? And if the new zk handler is covered by `zk-read`, should not also existing `ZookeeperInfoHandler` handler implement PermissionNameProvider and declare the same permission, for consistency?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here.", "reference": "Is this reasonable?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "We may move this TODO to Line15." }, { "prediction": "I'm not sure if this is the correct way to do it, but it should be something like this:", "reference": "You have to verify the return type. If it's a reponse, return it. Otherwise do nothing." }, { "prediction": "I don't think this is a bug, but it should be fixed.", "reference": "No. Keep the header include and do `extern template...` to skip the instantiation from that compile unit. (I pushed a fix directly to your branch)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "these tests are currently somewhat nonsensical. This code expands to `a, b = {}.keys` when it really should be expanding to `a, b = {}.keys()` -- though fixing this causes the test to fail so I suspect something worse is going on here that I don't quite understand?" }, { "prediction": "I think this is a bug, but it should be fixed in the next release.", "reference": "Why did this need to change?" }, { "prediction": "This is an alpha (internal) release and is not suitable for production.", "reference": "/go/pkg/mod/golang.org/x/xerrors@v0.0.0-20190410155217-1f06c39b4373/adaptor_go1_13.go:16:21: Frame not declared by package errors (from `typecheck`)" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Probably doesn't go here because I think it's specific to the HTTP API layer. This class is too internal to declare such a name." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "in preparation of directly writing the /health endpoint one day.. we should have content checks." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "question (non-blocking): Is there a benefit from using `%q` instead of `%s`?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "I would suggest to keep two empty lines between functions in cpp files" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and you're trying to do something like this, and you're trying to do something like this, and you're trying to do something like this, but you're doing something like this, and you're not doing something like this, so I'm not sure what you're trying to do.", "reference": "This change causes the test to fail on both rocm-1.9.x and rocm-head." }, { "prediction": "This is not a bug, it is a bug, and it is a bug.", "reference": "I'd consider moving all fix related stuff to a distinct package to avoid contaminating the base package" }, { "prediction": "I'm not sure if this is the case, but if it is the case, I'm not sure if it's the case, but I think it's the case.", "reference": "Use `os.path.join` for path concatenation." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Use upper case: YOLACTHead, YOLACTProtonet, YOLACTSegmHead" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "The driver tests should be updated to use the concrete type instead of the driver directly; right now your test coverage of the concrete type is 0%." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I would prefer the message to be more actionable. Like 'There should be no space between & and the variable name' or something similar." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "The image attribute is not supposed to be the text of the node. I'd rather keep it separate (the previous `@Text` attribute was fine). A practical reason for that is in the future, other languages may have a way to get the text of their node, in which case that wouldn't be fetched with `getImage`, for compatibility, but probably with a `getText` method, or `getSourceCode` like in #1728. Also we *may* deprecate or otherwise put `getImage` out of use as soon as 7.0, given its contract is super loose." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "The `[] +` seems weird to me. Why is it there?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Not sure if this constant is defined at the right place style-wise. Maybe move it up to before 'belongs_to' like DISCOUNT_TYPES in coupon.rb?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "What about a line with just spaces/tabs? Or a line with a couple spaces followed by a `#`?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "if funder_is is not blank (L375) there is not need to check if org_id is not blank (L379) since you will never enter in the if (L374)." }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "Don't need this-> here." }, { "prediction": "The metadata server is only accessible on GCE.", "reference": "I'm a little concerned about relying on a private module, as they could change the implementation at some point, I'd like to have some test to validate this is working as intended." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "There might other values that we don't support here (eg. `[]`). So it might be safer to check for the supported types instead (string or number)." }, { "prediction": "I'm not sure if this is a bug, but if it's a bug, it should be fixed.", "reference": "FYI, It won't have any benefit to move from trivial types." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "i missed these discussions- but ` \"secrets-ssm-environment-variables\"` is what was agreed upon with cp?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "whats the difference between this package and `github.com/golang/protobuf`? or did vscode just decided this was the package it wanted to used?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think this is what you're trying to do.", "reference": "Just asking: What does this line do? Does it add the stylesheet from the parent to the dialog?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Including the scikit-learn dependency here would pull in scikit-learn for everyone who depends on Dagster. If you put it in the setup.py under docs_snippets, we'd avoid that problem (although I think it's already there)." }, { "prediction": "I'm not sure what you're trying to do, but it seems like you're trying to do something like this:", "reference": "Why remove this?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug. I'm not sure if it's a bug or a bug, but it's a bug.", "reference": "Why remove this? It seems like we should keep this around as a regression test, unless we can guarantee this will never be called without a model set (does your new code guarantee that?)" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "Because this defaults to `{}` if `global._googlesitekitUserData?.permissions` is `false`-y, the checks below around `state.capabilities` always result in the `!! capabilities === true` path. This shouldn't have a default value of `{}` if there's the possibility that `global._googlesitekitUserData?.permissions` can be `undefined`/`false`/`null` legitimately." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "Please add a space after the comma here (generally, with arguments there's always a space after commas)." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "From the context, should it say \"Flags defined in this class must be used with caution...\"?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "We don't need this file, we can use the one that is in the grid-ui directory" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to create a new account. I'm guessing you're trying to create a new one. I'm not sure what you're trying to do, but I'm guessing you're trying to create a new one.", "reference": "\"Exported key for account\"?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's probably what you're trying to do.", "reference": "Normally we use Environment.NewLine unless you really want it to always be \\r\\n" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "why did you remove `verifyHeaders`?" }, { "prediction": "I think this is a bug in Devise. I'm not sure if this is a bug or a bug in Devise, but I'm not sure if this is a bug or a bug in Devise.", "reference": "Thanks for cleaning up these deprecated calls" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "@akarve this breaks error catching logic on the front end, I'll fix this. That's why I prefer to use some machine-friendly error codes that won't change frequently." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "We support process remoteQuery for Service. Why are we removing it?" }, { "prediction": "This disables Sinatra's error page generation.", "reference": "This is specifically for testing?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "I think this is related to the social stats and probably does not need to be removed." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "Yep, jsdoc again.. It seems that when the plugin description is wrapped within `eslint-disable/enable` expression it's not generated at all. After adding the `@class AutoColumnSize` tag right after the `@plugin` tag the plugin appears in the docs. Please review the other plugins." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "This usage of the result doesn't look quite right. I would not expect the first page of values to be empty if there were multiple pages of results. This also obscures the error case when no values are returned (handled in the next `if` block) by returning a more generic error from the Azure SDK from `result.NextWithContext()`." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "unknown field AddressDetails in struct literal (from `typecheck`)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Just noticed, are we specifically missing the addition of `SharedConfigState: session.SharedConfigEnable`?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "Not sure what this is. Bad merge?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug. I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "I think this may be a RW lock." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Perhaps we should tuck this away into a dedicated subdir and name it `config` or something similar? Or maybe it would be happy living in `common`?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Doing a select query inside of a loop like this is not ideal. We should fetch recipes once and then loop through it in memory to perform this check" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "too long here. (104 > 100)" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "Use TryGetValue instead of catching exception" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I think this method should be either: - a static method of `RTPSWriter` to avoid a StatelessWriter redefinition of the function. - a setter in the `CacheChange_t` struct." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm assuming it's what you're trying to do.", "reference": "You add a stream back reference for trailers, and all of the sudden we have tight coupling!" }, { "prediction": "I'm not sure if this is a bug or a bug, but it seems to be a bug.", "reference": "I don't think we use `AspNetAmbientContext` anymore since. We can probably delete this file." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Please avoid committing build artifacts, as they produce unnecessary conflicts and noise." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "this is vendored code so i would hesitate to make random changes to it" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "We are using a different style for JSON tags. `ethAddress` - camalCase `referral_code` - snake_case" }, { "prediction": "I'm not sure if this is what you're looking for, but it's worth noting that I'm not sure if this is what you're looking for, but I'm sure it's what you're looking for.", "reference": "Should this be `\"Microsoft.AspNetCore.Http.DefaultHttpContext\"`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "removed asserts from `Vector` as it's stable enough and it may hinder inlining, even if turned off :/" }, { "prediction": "I think this is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug.", "reference": "Do we want to raise on the function or on the decorator?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "How complex is to to replace `album_*` with `release_*` everywhere in the `Listen` class and places that use it?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "You haven't changed any of the callers of `.Add` to check the return value, so we're now ignoring duplicates. Please fix that." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "@straker should this not push to `vnode._cache.isHiddenWithCSS`?" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this, and I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this, and I'm assuming you're trying to do something like this, and I'm not sure what you're trying to do.", "reference": "\"an interface\" in conceptual sense vs \"interfaces\" or \"set of interfaces\", referring to the Go interfaces - database/sql uses the latter, should we?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "This now checks nearly all errors that can occur. How about explicitly listing cases where we want it to retry? I think there are not many cases where we want that, as the many added conditions in the last years show :)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "Can you make this accept an action instead?" }, { "prediction": "I don't think this is what you're looking for. I'm not sure what you're looking for, but I think you're looking for something like this:", "reference": "Tab inconsistency here (3 spaces instead of 2 spaces)" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug.", "reference": "these change means we are changing epoch to 1 hour?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Why this is defined in the middle of imports?" }, { "prediction": "I think this is a bug in the latest version of matplotlib. It's fixed in the latest version of matplotlib. See https://github.com/matplotlib/blob/master/packages/matplotlib/matplotlib.py.", "reference": "Could you move this to the original position?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "Is there a test that'd have caught this?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this should work.", "reference": "ListWorkflowExecutionsRequest <- this can be nil?" }, { "prediction": "This wraps the method `stub_hosts_on` and makes the stub specific to # the forge api v1 canonical source is forge.puppetlabs.com + # forge api v3 canonical source is forgeapi.puppetlabs.com + # # @param machine [String] the host to perform the stub on def stub_forge_on(machine) @forge_ip ||= Resolv.getaddress(forge) stub_hosts_on(machine, 'forge.puppetlabs.com' => @forge_ip) + stub_hosts_on(machine, 'forgeapi.puppetlabs.com' => @forge_ip) end # This wraps the method `stub_hosts` and makes the stub specific to `forgeapi.puppetlabs.com` and makes the stub specific to `forgeapi.puppetlabs.com` and makes the stub specific to `forgeapi.puppetlabs.com`.", "reference": "Do we need to continue to support the old link, or is it dead dead dead?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Do we need `ConcurrentDictionary`? `Dictionary` can be safely read from multiple threads. See `GlobalTags`." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should work.", "reference": "this seems like more of a Debugf statement" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "We're capturing cb_state non-const, but the function is const so, safe enough, but after going to reader/writer locks we're all going to have to key a careful eye on anything in this pattern." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Probably want to wrap the endpoint discovery work that follows in this `if` statement instead of returning early. This will make it easier to add additional request code generation logic in the future. e.g. if we add any code generation after the endpoint discovery block this check will cause it to be skipped." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "This test was giving a false positive because my change caused it to throw a different error that contained `createElement` when it should've been throwing this error. Caught this by looking at the code coverage and noticing that the line under the condition I changed was no longer covered lol." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "I think this is added to wrong file. You wanted to add to cmd/agent/, right?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Each `ExpectedCondition` implements `java.util.Function` These are expected to be stateless. This condition will leak previous `elementText` on the second usage, which doesn't seem ideal." }, { "prediction": "IPAMConfig```````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````", "reference": "Could we consider a more explicit name, like `devicePciAddress`?" }, { "prediction": "We should be careful, in case Windows has ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~", "reference": "Why change this from a foreach? I can't see it gaining anything here and code styles shouldn't change just for the sake of it." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Is this supposed to be part of this PR?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "DRY, worth extracting this method to axe.utils" }, { "prediction": "I'm not sure if this is the correct way to do it.", "reference": "I think there's another spot for this in DefaultCapabilityMatcher" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug, so I'm not sure if it's a bug or a bug.", "reference": "`QtOSError` inherits `OSError`, so I don't think it's needed to list them both here." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "Instead of patching vendor, let's update the version of sdk-go to a more recent one that doesn't have this line." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Don't think this should be here. The default is set somewhere else." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea to check if self._last_status is None or not self._last_status[\"progress\"] >= 100 or not self._last_status[\"progress\"] >= 100 or not self._last_status[\"progress\"] >= 100 or not self._last_status[\"progress\"] >= 100 or not self._last_status[\"progress\"] >= 100 or not self._last_status[\"progress\"] >= 100 or not self._last_status[\"progress\"] >= 100 or not self._last_status[\"progress\"] >= 100 or self._last_status[\"progress\"] >= 100 or self._last_status[\"progress\"] >= 100 or self._last_status[\"progress\"] >= 100 or self._last_status[\"progress\"] >= 100 or self._last_status[\"progress\"] >= 100 or self._last_status[\"progress\"] >= 100 or self._last_status[\"progress\"] >= 100 or self._last_status[\"progress\"] >= 100 or self._last_status[\"progress\"] >= 100 or self._last_status[\"progress\"] >= 100 or self._last_status[\"progress\"] >= 100 or self._last", "reference": "Not really important in this PR, but does BlazeMeter describe \"progress\" values anywhere? It might be nice to have a set of constants like `PROGRESS_DOWNLOADING_IMAGE`, `PROGRESS_BOOTING`, `PROGRESS_RUNNING_TEST`, etc in our BZA client." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do.", "reference": "nit: `

    ` after the line" }, { "prediction": "I'm not sure what you're trying to do here, but it should be something like this:", "reference": "Should we include the files with otf extension here, too? If not, I wonder why we do allow them in the source but we don't include them as per the setup" }, { "prediction": "I'm not sure if this is what you're looking for, but if it's the case, it's probably the case.", "reference": "i think it's OK to leave this?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Does this need to be public? The only reference to `FlinkTypeVisitor` that I see in this PR is here, so I'm not sure why this is needed." }, { "prediction": "I think this is a bug in the NVDA driver. You can fix it by changing the NVDA driver to use the NVDA driver to use the NVDA driver to use the NVDA driver to use the NVDA driver to use the NVDA driver to use the NVDA driver to use the NVDA driver to use the NVDA driver to use the NVDA \" \"key. Press NVDA plus n at any time to activate the NVDA menu. From this menu, you can configure \" - \"NVDA, get help and access other NVDA functions.\\n\" - \"Options grouping\\n\" + \"NVDA, get help and access other NVDA functions. \\n\" + \"Options grouping \\n\" \"Keyboard layout: combo box desktop collapsed Alt plus k\" ) QUIT_DIALOG_TEXT = ( - \"Exit NVDA dialog\\n\" + \"Exit NVDA dialog \\n\" \"What would you like to do? \" ) QUIT_DIALOG_TEXT = ( - \"Exit NVDA dialog\\n\" + \"Exit NVDA dialog \\n\" \"What would you like to do? \" ) QUIT_DIALOG_TEXT = ( - \"Exit NVDA dialog\\n\" +", "reference": "No line at end of file warning" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "This looks unused, shouldn't it point to inner processor in any way?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "There may be a few isolated cases where the FirstN node is added during preCodeGen. Please see GenPreCode.cpp RelRoot::preCodeGen(). The example given there about Order by where sort is added in optimizer, or a FirstN where the N value is to be specified with a param seem to be cases where we would add the FirstN later. Will current change cause such views to marked as updateable? This is minor and could be resolved later, if any change is necessary." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "I think you should compose the %sClient part using the Name class, and then do the remaining composition with plain concatenation. Side question: why does the return type name look like it is a client type name?" }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "All stories in this file also need the default padding." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug. I'm not sure if this is a bug, but I'm sure it's a bug.", "reference": "Curious - what would be the actual value?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Is it necessary to record the palette in the checkpoint? Any reason?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "Not sure how to best do this without creating a new connection to the server everytime. Do this in another thread?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "should we have a similar test for gsa18f procurements?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "change `v.recipient` to address.Address, so can use `AccountState(v,recipient)`" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Open to doing away with this altogether and maybe injecting this logic somehow into `requires_approval_notice?` in LinearDispatcher." }, { "prediction": "I think this is what you are looking for. If you are looking for something like 10.0.0.4 or 192.168.0.1, you should be able to use this instead. If you are looking for something like 10.0.0.4 or 192.168.0.1, you should be able to use this instead.", "reference": "remove this and always enable tracer, just set the default timeout to something higher (20 seconds)" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "Can we give this field a more descriptive name? When I use a variable named `icon` I normally expect an `Image` object." }, { "prediction": "` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "can't these just use the global `include` and `exclude` flags?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Is this still necessary?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "Interesting! Happen to catch an exception message or anything I can look into?" }, { "prediction": "I'm not sure if this is the correct way to do this, but I think this is the correct way to do it.", "reference": "did this get moved to mpromise? I don't recall if it's in that lib or not." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "json objects should be `camelCase`" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming that you're trying to write to a sector, and that you're trying to write to a sector, and that you're trying to write to a sector, and that you're trying to write to a sector, so you're trying to write to a sector that's larger than the number of bytes in the sector. I'm assuming that you're trying to write to a sector that's larger than the number of bytes in the sector, and that you're trying to write to a sector that's larger than the number of bytes in the sector. I'm assuming that you're trying to write to a sector that's larger than the number of bytes in the sector, but I'm not sure what you're trying to write to a sector that's larger than the number of bytes in the sector, so I'm assuming that you're trying to write to a sector that's larger than the number of bytes in the sector.", "reference": "QuarterGiBSectorSize? SectorSize265MiB? Spelling out 256 seems overly verbose." }, { "prediction": "I'm using OpenTelemetry.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs.Tests.Logs", "reference": "Maybe with this change we can remove `using OpenTelemetry.Logs`." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Fix this name too." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "why this is an issue?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "The condition should be inverse?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug.", "reference": "this seems to be a property key name, so should it be a inside configurationkey.java?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "G204: Subprocess launching should be audited (from `gosec`)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Please add docs here. And also warn users that this mode should be avoided whenever possible, because any blocking IO will make the keep-alive-thread not run." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "We shouldn't require dimension values to be a string. They just need to be scalar values (probably we could check whether it's either a string or a number). Something more important to cover in the validation here though is to ensure that a map of `dimensionName => dimensionValue` is passed. The keys here actually need to be strings. For example someone shouldn't be able to pass an array of values." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "let's do a pointer cast of nil, similar to the `MapRouter` above" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "action should use a prefix of `hfg` rather than `neve` as we plan to bootstrap this as a standalone library. Moreover, previously filter/actions used in this library was using the same pattern." }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "I'm halfway tempted to disable this for all https connections. Do you know of any clients that actually renegotiate for any reason?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "shouldn't **call** return a boolean?" }, { "prediction": "This example is used in https://gocloud.dev/howto/docstore#dynamodb-ctor.", "reference": "I don't think you need the blank import here. This one uses awsdynamodb directly." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case.", "reference": "I think this should be initialized to `null` instead of a predicate. There is no need to run an extra predicate (with an extra method dispatch for each row in a data file. That's a tight loop so we should do more work here to avoid it. Instead of using `isDeleted.or`, this should test whether `isDeleted` is `null` and either initialize `isDeleted` or call `isDeleted.or`." }, { "prediction": "I'm not sure if this is what you want, but I think it's a good idea.", "reference": "What is this and the next entry in config_handler used for?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "will your editor integrate `gofmt`, `goimports`, etc...?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "looks like the code is not properly formatted. for example here are some missing spaces in **if** command. please take care and reformat the code using default android formatting." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "Please add some valid examples to help message like `\"4:10\"`, `\"4:\"`, `\":10\"`" }, { "prediction": "I'm not sure what you're trying to do here, but I think it's a good idea.", "reference": "Is it only Symbols we're worried about converting? Is it not safe to just call `to_s` anyway?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Note for those who come across this later: It was moved to `testhelpers.mining.go` so that `testhelpers.NewDaemon` and the `mining/worker_test.go` can share it." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "What about `sort_by(&:in_progress?)`? Maybe with a `.reverse` thrown in?" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug.", "reference": "Flag is removed because it is only gRPC now." }, { "prediction": "This is similar to an + ``ansible-galaxy init`` skeleton. Please refer to the ``ansible-galaxy init`` skeleton in order to make sure that `ansible-galaxy init`` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Might be better to rephrase to: Please refer to the ``init scenario`` command in order to generate a custom ``molecule`` scenario. Since you aren't customizing the default scenario since it already exists, right?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Shall we merge these `if` for `path lib` and then do the `attrname` one. I'm trying to count `if`-calls and its getting late but I think we can reduce the number checks needed to get into L648 from 3 to 2 if you understand what I mean" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like \"github.com/ethersphere/bee/pkg/recovery\" \"github.com/ethersphere/bee/pkg/storage\" \"github.com/ethersphere/bee/pkg/swarm\" \"github.com/ethersphere/bee/pkg/tags\" \"github.com/ethersphere/bee/pkg/swarm\" \"github.com/ethersphere/bee/pkg/swarm\" \"github.com/ethersphere/bee/pkg/swarm\" \"github.com/ethersphere/bee/pkg/swarm\" \"github.com/ethersphere/bee/pkg/swarm\" \"github.com/ethersphere/bee/pkg/swarm\" \"github.com/ethersphere/bee/pkg/swarm\" \"github.com/ethersphere/bee/pkg/swarm\" \"github.com/ethersphere/bee/pkg/swarm\" \"github.com/ethersphere/be", "reference": "why depend on recovery???" }, { "prediction": "I'm not sure what you're trying to do, but it seems like you're trying to do something like this:", "reference": "the done channel only aims to be closed, so `chan struct{}` is better then `chan interface{}`" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Do you mean to have gas_oracle changes in this PR?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Is this effectively requiring browsers support javascript?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "Lowercase `boolean` - use the primitive type." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, then it's probably a bug.", "reference": "This isn't the correct logic. if allowOverride == true and!blobExists then upload. Just don't do the exist check if allowOverride is set to true." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "Can you replace these by `else if` please?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "Would be nice if the field had a unique class name that could be used to target it, instead of `fromRange` But doesn't seem to be a common thing in the code base." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "Does this code fit on one line under 80 characters? It would be more consistent with our existing style." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Not a requirement here. But i see a change in naming convention. We can rename the function to `CstorSparsePoolArtifactsFor070`." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this (I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this)", "reference": "Why do you configure the UART like this? It's already configured by default." }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this:", "reference": "Wow. Good catch. \"This `#include` was brought to you by the department of redundancy department.\" ;)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Well it's actually calling `AuthorizeOrder` and this seems like a DebugLevel message to me, maybe it should be dropped entirely." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "Should this be using the `CUDA_SAFE_CALL` macro here?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "What cases do you see as being valid for not having any tests to run? If a test project doesn't have any tests to run we should avoid running it at the project level." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "and is it possible that mset.mirror.msgs be nil? because if so, then you would get a panic also because of that." }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "`next->opaque` should not be cleared." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "already what? I know what, but seems like smth. is missing in this sentence" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Can you put spaces after the `{`and before the `}`" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "We said we would put `[ ]` around the version. `[forseti-security] [v2.3.0]`" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Seems len(cnb[0]) will be the length after the write since of the *v thing we saw no?" }, { "prediction": "I'm not sure what you're trying to do here, but here's an example of what I'm trying to do:", "reference": "can we make use of storagepoolclaim type rather than the generic interface{} type?" }, { "prediction": "I'm not sure if this is a bug, but if it's a bug, it should be fixed.", "reference": "this should happen before the `go k.manage()`, otherwise the node will always try the bootnodes first" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Is this actually a lint related change?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "what does this do that str_param does not?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do. I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "For GCP we included the API name (see below) so you can distinguish between uses other than `blob` once they exist, WDYT?" }, { "prediction": "I'm not sure if it's possible to import boto3 in the same way, but it's possible to import boto3 in the same way as import boto3 in the same way.", "reference": "what would you think about doing this include on-demand within S3ObjectStore methods and then failing in a loud way?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "May be better make `stopped` atomic, then it can be just `for (auto i (node.store.latest_begin (transaction_a, next_frontier_account)), n (node.store.latest_end ()); i!= n && &&!stopped && elections_count < max_elections; ++i)`" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "In `src/storage/InternalStorageServiceHandler.h ` file, the client in `client->future_chainAddEdges ` should be InterStorageServiceAsyncClient?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like \"github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1\" or \"github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1\" or \"github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1\" or \"github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1\" or \"github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1\" or \"github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1\" or \"github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1\" or \"github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1\" or \"github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1\" or \"github.com", "reference": "`go.sum` needs to be updated for this. Please run `go mod tidy`" }, { "prediction": "The Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets Manager Secrets", "reference": "Not sure if this was discussed previously, but is there a specific use case in mind for having this as an API field rather than a configuration option on the controller manager? Is there a specific use case in mind where one would want to choose different backends for individual Clusters/Machines vs having it a global configuration for an instance of the infrastructure provider?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm sure it's what you're trying to do.", "reference": "Same thing with the OtlpExporter" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing it's just a typo.", "reference": "Should not be removed." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this: I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Not a blocker for anything, but should this be moved to beaker-pe? Is that ticketed anywhere?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "this shouldn't be beforeClickOn, but rather beforeSubmit? and added to WebDriverEventListener. Since submit does not synthesize the 'click' events, this isn't accurate." }, { "prediction": "I think this is what you're looking for.", "reference": "this ternary operator is hiding an `if/else` within an `if/else` - any chance we could move the logic ELSEwhere? (see what I did there --?? :100: )" }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this:", "reference": "Is this really internal? Or will the API be different in PMD 7.0.0? Well, the interface doesn't offer much functionality anyway..." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Does it have to be arrays? Isn't it ragged 'data' (i.e multiple elements of different lengths)?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Per my understanding, this flag only impacts \"NoCleanup\" disk. If so, we may name it more clear. The reason of this ask is because I plan to add some other flag to force cleanup for other non-NoCleanup disks." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug, so I'm not sure if it's a bug, but I'm sure it's a bug.", "reference": "In my changes for `RequiresDistributionAndOrdering`, this class went away and is replaced by an inner class. I think that pattern worked well. Maybe we could do that before this one to reduce the number of changes here." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be what you're looking for, so I'm not sure if this is what you're looking for.", "reference": "Shouldn't this be called `hp` instead of `life`?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Because the default value of allowedOrigins is * (all origins), so it isn't necessary to set again at all." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Undo this modification" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Please check my thoughts here... I changed the test to not `ToString()` attribute values. This was important to test things when `net.peer.port` was both an int or a string, but I was unsure if Zipkin supported non-string attributes." }, { "prediction": "I'm not sure if this is the case, but if it's the case, I'm not sure if it's the case, but if it's the case, I'm not sure if it's the case, I'm not sure if it's the case, but if it's the case, I'm not sure if it's the case, I'm not sure if it's the case, but if it's the case, I'm not sure if it's the case, I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "Looks like you made changes on `CameraResultType` class, but didn't commit them. And you also have to do the changes on the types in @capacitor/core" }, { "prediction": "I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "Can you explain the history of the bug a bit, and why this fixes it?" }, { "prediction": "I18n.t('dashboard.show.contact_your_mentor', mentor.email, mentor.first_name, mentor.last_name, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email, mentor.email", "reference": "What do you think about `mentor_mail_to` or `mentor_mail_to_link` in order to match Rails' `mail_to` method, which is what this calls? I'm not sure about this suggestion..." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Looks like this will make the check in every loop. Consider extracting the null check." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Maybe `it \"can safely be reset when there are not yet any shared example groups\"`? That's the edge case that wasn't working, right?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "naming: please use `asmfactory`" }, { "prediction": "I'm not sure if this will work, but I'm not sure if this will work, but I'm not sure if this will work, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "FYI you could use a raw string for this which removes the need for escaping the inner quotes." }, { "prediction": "@parametrize('keystr, expected') def test_is_special_key(keystr, expected): + assert utils.is_special_key(keystr) == expected + assert utils.is_special_key(keystr) == expected + assert utils.is_special_key(keystr, expected) == expected + assert utils.is_special_key(keystr, expected) == expected + assert utils.is_special_key(keystr, expected) == expected + assert utils.is_special_key(keystr, expected) == expected + assert utils.is_special_key(keystr, expected) == expected + assert utils.is_special_key(keystr, expected) == expected + assert utils.is_special_key(keystr, expected) == expected + assert utils.is_special_key(keystr, expected) == expected + assert utils.is_special_key(keystr, expected) == expected + assert utils.is_special_key(keystr, expected) == expected + assert utils.is_special_key(keystr, expected) == expected + assert utils.is_special_key(keystr, expected", "reference": "2 blank lines here (between functions)" }, { "prediction": "I'm not sure if this will work, but it should work.", "reference": "Nit: we try to avoid whitespace changes because they can easily cause unnecessary commit conflicts." }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this.", "reference": "As mentioned below, I'm not sure why this is only allowing refs that are tagged with `*` at the start!" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "Don't forget the {} symbols, and please use EqualsBuilder and HashcodeBuilder as possible" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "Allocate buffer once outside loop." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "It would be better to check that system.nodes[1]->network.port is somewhere in the target without specifying its exact position. But it is a very minor point and I have no string opinion on it just thought I'd mention it because our tests in general have too implementation detail." }, { "prediction": "It's strange to have these \"startsWith\" conditionals here. They both come from Access.java. It's strange to have these \"startsWith\" conditionals here. They both come from Access.java. if (ex.getMessage()+\"\").toLowerCase().startsWith(\"tabular data required\")) { jrb.message(BundleUtil.getStringFromBundle(\"access.api.exception.metadata.not.available.for.nontabular.file\")); + } else if ((ex.getMessage() + \"\").toLowerCase().startsWith(\"no permission to download file\")) { + jrb.message(\"You do not have permission to download this file.\"); } else { jrb.message(\"Bad Request. The API request cannot be completed with the parameters supplied. Please check your code for typos, or consult our API guide at http://guides.dataverse.org.\"); }", "reference": "Should this be in a bundle?" }, { "prediction": "We could be executing on a different thread now so we can check if the activity is null or not. If we are executing on a different thread, we could check if the activity is null or not. If we are executing on a different thread, we could check if the activity is null or not. If we are executing on a different thread, we could check if the activity is null or not. If we are executing on a different thread, we could check if the activity is null or not. If we are executing on a different thread, we could check if the activity is null or not, we could check if the activity is not null. If we are executing on a different thread, we could check if the activity is null or not, we could check if the activity is not null.", "reference": "When Activity is lost (more precisely, ExecutionContext is lost) in the HttpModule we restore the root (HttpIn) Activity. That makes this assert invalid. I tried to fix the HttpModule so that it restores the Activity that was last running, but it is impossible to retrieve do to the way ExecutionContext works. It isn't an issue to remove the assert, but it is unnerving. Any instrumentation running in IIS reliant on Activity.Current could run into trouble." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure.", "reference": "what was the point in moving handlers registration into a separate method?" }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it, so I'm not sure if this is the correct way to do it.", "reference": "At this point we probably want to ensure there's a store command set." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here is what you're trying to do.", "reference": "This code is way too complicated for what it does. I don't want to be a PITA, but what can you consider rewriting it in a simpler way? I'm talking about the whole `_getDerivationIndexes` function" }, { "prediction": "public static Result Sign(string vaultId, string keyId, string message) { if (message.StartsWith(\"0x\")) { throw new Exception($\"Vault message should not be in hex; message: {message}\"); + } string result = await _vaultService.Sign(Guid.Parse(vaultId), Guid.Parse(keyId), message); return ResultWrapper.Success(result); }", "reference": "Don't throw base exception, specify more precise type" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to convert a Tensor to a Tensor. I'm not sure what you're trying to do here, but I think you're trying to convert a Tensor to a Tensor. I'm guessing you're trying to convert a Tensor in inputs from src_type to dst_type. + + Args: + inputs: Inputs that to be casted. + src_type (torch.dtype): Source type.. + dst_type (torch.dtype): Destination type. + + Returns: + The same type with inputs, but all contained Tensors have been cast. + \"\"\" if isinstance(inputs, torch.Tensor): return inputs.to(dst_type) elif isinstance(inputs, str): return inputs.to(src_type) elif isinstance(inputs, str): return inputs.to(src_type) elif isinstance(inputs, str): return inputs.to(dst_type) elif isinstance(inputs, str): return inputs.to(src_type) else: return inputs.to(src_type)", "reference": "Recursive -> Recursively converted -> convert" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "why is this object API only? I think the reason why we didn't do this before was because this code was shared with Java which doesn't have value structs." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "just to confirm, so backend will deal with both old format and new format?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug.", "reference": "huh, look at that, I wasn't aware you could constrain a type by Enum" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for.", "reference": "Even though the debug parameter is effectively ignored, should this default to `false` instead of `true`?" }, { "prediction": "I'm not sure if this is a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's just a bug, or if it's a bug, it's a bug.", "reference": "What is the purpose of this interface? Unlike ParamDocView, it doesn't seem to be used anywhere to enable polymorphism" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "We added a library to generate a UUID for the request_id directive \"github.com/nu7hatch/gouuid\" can we uses the same one for what you want rather than add another dependency? Or if the google one is better can we remove the nu7hatch library?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "Shouldn't this be `i * Interval`? You're multiplying nanos with a Duration, I'm not sure what's the result :)" }, { "prediction": "I'm not sure if this is the case, but if it is the case, then we just mark it as inaccessible. If it is the case, then we just mark it as inaccessible.", "reference": "I guess it's not no-access to match Windows where guard pages are readable." }, { "prediction": "I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Not a blocker, but would probably be useful to have a `scope :non_pending_approvers` on the `Proposal` model." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Add trailing comma" }, { "prediction": "I'm not sure what you're trying to do here, but here's what I'm going to do:", "reference": "I see someone say SIGKILL can not be caught by process. The original code here about `SIGKILL` is useless?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "As it is a mobile only theme, please make sure the option appears only on mobile" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Would like a docstring and type annotations here" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "This is an API change. Why was it made?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Please move using inside namespace." }, { "prediction": "I'm not sure if this is what you are looking for.", "reference": "shall we create some enum flags for setasmain shouldprocess and pos?" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Should this `PUPPET_AGENT_STARTUP_MODE` have a corresponding yardoc change?" }, { "prediction": "You should have received a copy of the GNU General Public License # along with qutebrowser. If not, see .", "reference": "Why not simply remove the `pytest` import now that it's not needed anymore? :wink:" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Yeah, not filled in yet." }, { "prediction": "I think this is what you're looking for.", "reference": "don't use style. Use a class instead. reducing `col-xs-12` down to 8 or 6 or whatever should do the trick" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "should we also do `reloadCache` when database is null?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "Why not just return QueryMol directly? Why require the copy?" }, { "prediction": "I'm not sure what you're trying to do, but I think this should work:", "reference": "Could you add a docstring?" }, { "prediction": "I think this is what you're looking for.", "reference": "looks like you added newlines after blocks in a few files - I generally like newlines before/after multi-line blocks _except_ when the end the block is directly nested inside another block (eg: two `end`s next to each other) what do you think?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "@jlerbsc's fix in #2918 in action - thanks! :smiling_face_with_three_hearts:" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "nitpick: Please lower-case `Zero_count` (as it's a literal argument name) and `Argument` here." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "change the name of the function to match its functionality? account IsIssuing?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "for later: add docstring (can just copy paste Pandas')" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "nit: @sonofachamp pointed out to me that the idiomatic way is \"archermocks\" (lowercase for package names)" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems to be a bug. I'm not sure what you're trying to do, but it seems to be a bug.", "reference": "Ugh I'm stupid, can you change this to `yarpc.InternalErrorf`?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "We instantiate some metadata tables in tests so I kept the old constructor too. Won't harm if someone is using it directly too." }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it, so I'm not sure if it's the correct way to do it, but I think it's the correct way to do it.", "reference": "I think the better place to put this might be `lib/options/PopulateOptions.js`. That should make it easier - checking options in `populate()` can get confusing." }, { "prediction": "I'm not sure if this is a bug, but it's a bug in the NATProviderPinger interface.", "reference": "Lets have simple function arguments here, because now struct `traversal.Params` started to have 2 purposes: 1. used as contract in DTO between consumer-provider 2. as function parameters for internal code calls" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "Probably best not to have an empty test...." }, { "prediction": "I was able to get this to work, but I was not able to get it to work.", "reference": "`image_tag` in the `testimonials` files?" }, { "prediction": "I'm not sure if this will work, but I'm not sure if this will work.", "reference": "I believe flow.toObject() method is throwing NPE if SLA option list (i.e. this.executionOptions.getSlaOptions()) is null or one of the value in the list (i.e. this.executionOptions.getSlaOptions()) is null. If that is the case we could fix root cause of NPE in the ExecutableFlow.toObject() method. The corresponding code to populate SLA options can be modified as follows. final List> slaOptions = Optional.ofNullable(this.executionOptions.getSlaOptions()).orElse(Collections.emptyList()).stream().filter(Objects::nonNull).map(slaOption -> slaOption.toObject()).collect(Collectors.toList());" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for this.get('model.icon') or this.get('model.icon') or this.get('model.icon') or this.get('model.icon') or this.get('model.icon') or this.get('model.icon') or this.get('model.icon') or this.get('model.icon') or this.get('model.icon') or this.get('model.icon') or this.get('model.icon') or this.get('model.icon') or this.get('model.icon') or this.get('model.icon') or this.get('model.icon') or this.get('model.icon') or this.get('model.icon') or this.get('model.icon') or this.get('model.icon') or this.get('model.icon') or this.get('model.icon') or this.get('model.icon') or this.get('model.icon') or this.get('model.icon') or this.get('model.icon') || '/favicon.ico';", "reference": "So I haven't tested this - but since the icon location is just directly dumped into the img _src_ attribute, won't this cause issues with Ghost blogs in a subdirectory? If I'm misunderstanding what the purpose of the default is then let me know" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do. I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Why swallow the exception here rather than propagate it?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "How about `column_index_names`? `column_names` sounds ambiguous." }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "+1 on this. Do we want to have it as `WRITE_METRICS_MODE_COLUMN_CONF_PREFIX` to be consistent with defaults? Is there a possibility we will have `READ_METRICS_MODE_COLUMN_CONF_PREFIX`? Not sure." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this.", "reference": "Shall we use different inputs for `PySpark < 2.4` where `transpose` won't work with different data types." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "we should sort the headers like in spark: public packages, then pyspark, then internal" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "looks like we should drop this var from the transport options struct" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Ah, yeah, this is the test for the validation that I mentioned in a remark above about relaxing the validation." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "For tensors, it is better to illustrate the shape." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "This was removed in a recent PR for the admin bar, but should have been kept. It's been restored in the other admin bar PR but I've added it here to for completeness." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug. I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "nit: probably swap the if condition and `if/else` and check `NETCOREAPP2_1` which looks more natural." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "for the tag, should it be `requestor_rtt` since the other is `responder_rtt`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "The one sad part of this is that is will generate a lot of overhead if you loop through a vector, since it obtains the vector every time. But with the current API there is no alternative I guess, and it is better to have the option than not." }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "nit: there should be a newline between `types` and `go-ipfs-files`." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here.", "reference": "would be nice to have this as a parameter (Options), re: technical debt discussions" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "complete ignorance here but is it ok to import this from `com.sun`? can it break under non-oracle JREs?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Is this some way of saying that the span is going to be sampled? I'm basing this question on the condition I saw for the `OnEnd` to be called - `mustExport := s.spanContext.IsSampled() && )`. Shouldn't the condition be `s.spanContext.IsSampled()` to match the condition for calling the `OnEnd`?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "just calling UpdateSnapshotInfo() should be fine" }, { "prediction": "We don't want to rate limit messages by default when in debug mode - return GlobalSettings.Source.DebugEnabled? 0 : DefaultLogMessageRateLimit; + // By default, we don't rate limit log messages; + return 0; } private static string GetLogDirectory() { return GlobalSettings.Source.DebugEnabled? GetLogDirectory() : GetLogDirectory() + GetLogDirectory() + GetLogDirectory() + GetLogDirectory() + GetLogDirectory() + GetLogDirectory() + GetLogDirectory() + GetLogDirectory() + GetLogDirectory() + GetLogDirectory() + GetLogDirectory() + GetLogDirectory() + GetLogDirectory()", "reference": "Was `DefaultLogMessageRateLimit` not configurable anywhere?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here. I'm not sure what you're trying to do here.", "reference": "Please use the `assert` instead. Same below." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this?", "reference": "Owww, I think I found a typo. `suche`" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "This can happen because we could get `PhantomNodes` that are not admissible as source/target right?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Should we add a note here to file a bug if this ever happens?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "overflow is still possible, isn't it?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This seems more like a personal preference, so maybe this should be in your `~/.rspec`?" }, { "prediction": "I'm not sure if this is a bug or a bug, but if it's a bug, it should be fixed.", "reference": "To avoid a circular import between pcapdnet and automaton" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Please remove this blank line." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "it feels that the WorkloadIdentityCondition should be added to this Status... And if you have workload identity enabled, but not working, then you can mark that condition failed, and also Mark the ready false... not entirely sure though" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "I think these got refactored to `LvlFindInChain` to better conform with the coding guidelines. I think MarkL left these in for backwards compatibility." }, { "prediction": "This is not a bug, it's a bug. It's a bug.", "reference": "It's fine for this PR, but in the future try to minimize unrelated changes." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "The library -> modules and filters -> filter path changes are breaking changes or?" }, { "prediction": "import logging +import os from typing import TYPE_CHECKING +import boto3 +import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore.config import botocore", "reference": "Can we encapsulate this check (`os.environ.get(\"TEST_TARGET\") == \"AWS_CLOUD\"`) into a small config/util function? (and also use it in `integration/conftest.py`) (I'd generally try to avoid accessing `os.environ` directly across the codebase. I'm aware that we're already doing this in a few places, but maybe we can start pulling things out - this will also help us create more systematic config/environment abstractions as we go...)" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "An `if` statement would be better here. Functions, concat and reverse are all very expensive." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "`Log here: connect to default factory for goerli network

    `" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "nits, should add `break` to avoid redundant iterations." }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "I think we want an exception here, there should never be a transfer to a nonexisting account." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I'm sure it's what you're looking for.", "reference": "This code is new and not tested well. While we may drop the log level before we ship 4.0, right now this is extremely helpful to users." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Can we make these asserts more strict/precise? I remember this test helped to spot the issue of inconsistent results on different platforms due to using `sort` instead of `stable_sort`." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I thought about adjusting for case here as well? For example `.rb,rb,.RB,.rb` would all map to ruby interpreter specified? Is that too much \"magic\"? Is there a sane workflow that someone would choose to map `.rb` to one interpreter and `.RB` to another?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "In this and the one below, should we assert `self!= NULL` first?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here. I'm assuming you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "Why this is needed?" }, { "prediction": "I think this is what you want. I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "we already have.meta() so I don't think we want get_meta() for PackageEntry" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "question: can we always get the startts from dagrequest?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "Nit-picking, but this can be simplified to reference `properties[ 0 ]` since that is already retrieved 2 lines above." }, { "prediction": "@unresolved_targets[t_name] = { 'name' => target.name } @unresolved_targets[t_name] = { 'name' => target.name } @unresolved_targets[t_name] = { 'name' => target.name } @unresolved_targets[t_name] = { 'name' => target.name } @unresolved_targets[t_name] = { 'name' => target.name } @unresolved_targets[t_name] = { 'name' => target.name } @unresolved_targets[t_name] = { 'name' => target.name } @unresolved_targets[t_name] = { 'name' => target.name } @unresolved_targets[t_name] = { 'name' => target.name } @unresolved_targets[t_name] = { 'name' => target.name } @unresolved_targets[t_name] = { 'name' => target.name } @unresolved_targets[t_name] = { 'name' => target.name } @unresolved_targets[t_name] = { 'name'", "reference": "This technically works because we call `get_targets` before we remove the target, so it's bound to have been resolved. But I'm not sure I would like to rely on that assumption. Should we also remove it from `@unresolved_targets` to be safe?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "So what happens if I try to get code on a EOA?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "Can't we return an empty list and then just compare the lengths? Thereby removing this `if`." }, { "prediction": "I'm not sure if this will work, but I think it will.", "reference": "Mb change it to 'doesPassRestrictions()'? Doesn't sound enough like a boolean-returning method to me." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "TODO: in fact At when used with noncurrent time should not return a next index. only latest should.." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "There are scenario's where we skip an update with a placeholder, in this case tmp returns null with render, this is not an array so we `[null]` it" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "@danieldietrich, this wasn't tested so I presumed it wasn't working before either :p" }, { "prediction": "This copyright notice MUST APPEAR in all copies of the script! ***********************************************/ use TYPO3\\CMS\\Core\\Utility\\GeneralUtility; use TYPO3\\CMS\\Core\\Utility\\GeneralUtility; use TYPO3\\CMS\\Core\\Utility\\GeneralUtility; use TYPO3\\CMS\\Core\\Utility\\GeneralUtility; use TYPO3\\CMS\\Core\\Utility\\GeneralUtility; use TYPO3\\CMS\\Core\\Utility\\GeneralUtility; use TYPO3\\CMS\\Core\\Utility\\GeneralUtility; use TYPO3\\CMS\\Core\\Utility\\GeneralUtility; use TYPO3\\CMS\\Core\\Utility\\GeneralUtility; use TYPO3\\CMS\\Core\\Utility\\GeneralUtility; use TYPO3\\CMS\\Core\\Utility\\GeneralUtility; use TYPO3\\CMS\\Core\\Utility\\GeneralUtility; use TYPO3\\CMS\\Core\\Utility\\GeneralUtility; use TYPO3\\CMS\\Core\\Utility\\GeneralUtility; use TYPO3\\CMS\\Core\\Utility\\GeneralUtility; use TYPO3\\CMS\\Core\\", "reference": "Please leave two empty lines after the `use` statement" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Please move this import in the 3rd group which is for external dependencies" }, { "prediction": "def _is_internal_node(node): return isinstance(node.get(RESERVED['file']), str) and not isinstance(node.get(RESERVED['file']), str) and not isinstance(node.get(RESERVED['file']), str) and not isinstance(node.get(RESERVED['file']), str) and not isinstance(node.get(RESERVED['file']), str) and not isinstance(node.get(RESERVED['file']), str) and not isinstance(node.get(RESERVED['file']), str) and not isinstance(node.get(RESERVED['file']), str) and not isinstance(node.get(RESERVED['file'], str) and not node.get(RESERVED['file']) and not node.get(RESERVED['file']) and not node.get(RESERVED['file']) and not node.get(RESERVED['file']) and not node.get(RESERVED['file']) and not node.get(RESERVED['file']) and not node.get(RESERVED['file']) and not node.get(RESERVED['file']) and not node.get(", "reference": "So what exactly is this fixing? The unit test is passing with or without this change." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug. I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm guessing it's a bug.", "reference": "auto targetFile = fs::FileUtils::joinPath(newPath, folly::stringPrintf(\"%019ld.wal\", it->first));" }, { "prediction": "I think this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I don't see any place that checks whether the from snapshot is an ancestor of the to snapshot. That seems like a requirement for this to work correctly to me." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Other calls to getHelpText() are wrapped in an `isset()` check. Would it make sense to be consistent, and either restore that here or remove it elsewhere?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Why the change? If `output_stream` is set to something non-nil, it seems odd (and potentially wrong) to overwrite it...." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "Thinking this should have an underscore." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for.", "reference": "To accommodate the change to the method being private." }, { "prediction": "I think this is what you're looking for.", "reference": "Shouldn't we traverse all definitions and apply this rule over all model definitions in the doc" }, { "prediction": "I think this is what you are looking for.", "reference": "Please rename this class that it ends with the suffix \"Test\" - otherwise the tests won't be executed." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "As a JS file, this should also receive our standard file header." }, { "prediction": "I don't think it's a bug, but I think it's a bug.", "reference": "I take it memQuotaRatio is an \"out\" parameter at line 1810? Also, why use MIN_QUOTA in both the cases of memQuota being too low and too high? Contrast this code with RelRoot::codeGen where we set MIN_QUOTA only in the too low case." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "It looks like for newpullsubscription, we have two functions. One for pullsubscription with default, one for pullsubscription without default. If you remove setdefault here, then there is no differences between these two functions." }, { "prediction": "I'm not sure if this is the correct way to do this, but I think it's the correct way to do it.", "reference": "not dramatic, but why 32bits if we allow a range that is smaller than 8?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "- Use type from `service_discovery/dto/price.go` - Rename `Price` -> `Money`" }, { "prediction": "The new left type of the resulting Either is a Left type of the resulting Either. The new left type of the resulting Either is a Right type of the resulting Either. The new right type of the resulting Either is a Right type of the resulting Either. The new left type of the resulting Either is a Right type of the resulting Either. The new right type of the resulting Either is a Left type of the resulting Either. The new left type of the resulting Either is a Right type of the resulting Either. The new right type of the resulting Either is a Right type of the resulting Either. The new left type of the resulting Either is a Left type of the resulting Either. The new right type of the resulting Either is a Right type of the resulting Either. The new left type of the resulting Either is a Left type of the resulting Either. The new right type of the resulting Either is a Right type of the resulting Either. The new left type of the resulting Either is a Left type of the resulting Either. The new right type of the resulting Either is a Right type of the resulting Either is a Left type of the resulting Either.", "reference": "one space missing at the beginning" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "I worry that having `Platform` as `string` instead of `*string` would result in it getting overriden with `\"\"` if the environment manifest config doesn't specify `platform`. If it gets overridden as `\"\"`, that could be a problem for users that are not using `linux/amd64` right? If this indeed is a potential impact, could we double check in `ApplyEnv`'s unit test? Same with the `Platform` in `TaskConfig`. Sorry for not seeing this in my previous review!!!" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "I like the new directory `/api`, what is the thinking behind `/external`?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "staticcheck flags this: replace with `for k :=..`" }, { "prediction": "I'm not sure if this is what you want, but if it's what you want, it's probably what you're trying to do.", "reference": "There's already a sleep right above" }, { "prediction": "if ($assertion->var_id) { $if_types[$assertion->rule[0][0]] = [[$assertion->rule[0][0]]]; } elseif ($assertion->var_id) { $if_types[$assertion->rule[0][0]] = [[$assertion->rule[0][0]]]; } elseif ($assertion->var_id) { $if_types[$assertion->rule[0][0]] = [[$assertion->rule[0][0]]]; } elseif ($assertion->var_id) { $if_types[$assertion->rule[0][0]] = [[$assertion->rule[0][0]]]; } elseif ($assertion->var_id) { $if_types[$assertion->rule[0][0]] = [[$assertion->rule[0][0]]]; } elseif ($assertion->var_id) { $if_types[$assertion->rule[0][0]] = [[$assertion->rule[0][0]]]; } else { $if_types[$assertion->rule[0][0]] = [[$assertion->rule[0][0]]]; }", "reference": "This feels hacky, is there a better way?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug, and it's fixed in the future.", "reference": "Can we move this logic into the `boto.compat` module? Then it's just `from boto.compat import OrderedDict` instead. Also, this is introducing a new dependency. What about users on 2.6.x that don't have the OrderedDict module installed? We may need to fall back to an ordinary `dict` so that existing code in the wild does not break." }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "\"Gets the JSON serialization settings.\" would be better?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "The endpoint should be in plural `/files`." }, { "prediction": "is there any reason to not just use `` instead of ``?", "reference": "??? Why do we need to have a different API in Python? Oh, wait, I see what you did. It's to fake the namespaces. Given that I don't think the namespaces are necessary, and that less of these should be exposed anyway, I think these should go." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "I think this line is gofmt issue? @daixiang0" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "probably better to assert the values directly; technically you could pass this test with an implementation that always returned \"\" for the subrepo for example." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this.", "reference": "line is 161 characters (from `lll`)" }, { "prediction": "I'm not sure if this is what you are looking for, but I think it's what you're looking for.", "reference": "Are these changes needed?" }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it, so I'm not sure if this is the correct way to do it.", "reference": "It seems like reducing the sensitivity would make the test failure less likely to occur, but not fix the issue?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "missing use statement for importing the full namespace" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "Generally error messages in Go shouldn't start with capital letter. I see this rule is broken in many places here. Why?" }, { "prediction": "I'm not sure what you're trying to do here, but it should work.", "reference": "These test checks if selection coordinates don't return negative values in that edge cases. Please revert the changes and set `autoWrapCol` and `autoWrapRow` to `false` to the Handsontable instance. This change applies to the entire Core_selection.spec.js file." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "I would prefer flag SkipGasPricingValidation" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this.", "reference": "could be `const &`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this should be enough.", "reference": "The docs should also be updated with the new option." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to send an email to the configured error-email. I'm guessing you're trying to send an email to the configured error-email. I'm guessing you're trying to send an email to the configured error-email. I'm guessing you're trying to send an email to the configured error-email. I'm guessing you're trying to send an email to the configured error-email. I'm guessing you're trying to send an email to the configured error-email. I'm guessing you're trying to send an email to the configured error-email. I'm guessing you're trying to send an email to the configured error-email. I'm guessing you're trying to send an email to the configured error-email. I'm guessing you're trying to send an email to the configured error-email. I'm guessing you're trying to send an email to the configured error-email. I'm guessing you're trying to send an email to the configured error-email. I'm guessing you're trying to send an email", "reference": "Name is _way_ to generic for this patch to be accepted I think. Can you rename it to maybe `send_sns_notification` or something else you find suitable?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure.", "reference": "Out of the scope." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "I think we need an if block to check that if this API is really missing. We wouldn't want to override the browser's implementation." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I was wondering, things like EDITOR_TYPE, VALIDATOR_TYPE, RENDERER_TYPE are not obligatory. Therefore if the custom editor will be registered with this method, `name` will be set to `undefined`. Should we handle this scenario?" }, { "prediction": "The Swarm Authors is governed by a BSD-style license that can be found in the LICENSE file.", "reference": "This line should not be removed, as it is not the description of the package, but a copyright header." }, { "prediction": "I'm not sure if this is what you're looking for, but it's a good idea.", "reference": "Wouldn't it be more space efficient to make this a `byte` enum or bitfield?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Flake8 doesn't like the assignment, but non-use of `e` here. I think we can just remove the try/except here for `cursor.execute(sql)`." }, { "prediction": "I think this is a bug. It should be fixed in the future.", "reference": "Maybe add short example list:.... type body declarations, such as AnnotationMembers, Methods, Fields" }, { "prediction": "I'm not sure if this is what you're looking for, but it's what we're looking for.", "reference": "These are really meant to be the keys in the capabilities, not the keys of values within the capabilities" }, { "prediction": "I think this is a bug. It should be fixed in the future.", "reference": "It is debatable whether we have to default this. I did this to avoid breaking custom implementations." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for \"github.com/aws/amazon-ecs-cli-v2/internal/pkg/addon\" or \"github.com/aws/amazon-ecs-cli-v2/internal/pkg/addon\" or \"github.com/aws/amazon-ecs-cli-v2/internal/pkg/addon\" or \"github.com/aws/amazon-ecs-cli-v2/internal/pkg/addon\" or \"github.com/aws/amazon-ecs-cli-v2/internal/pkg/addon\" or \"github.com/aws/amazon-ecs-cli-v2/internal/pkg/addon\" or \"github.com/aws/amazon-ecs-cli-v2/internal/pkg/addon\" or \"github.com/aws/amazon-ecs-cli-v2/internal/pkg/addon\" or \"github.com/aws/amazon-ecs-cli-v2/internal/pkg/addon\" or \"github.com/aws/aws/amazon-ecs-cli-v2/internal/pkg/addon\"", "reference": "we shouldn't need the \"addon\" rename" }, { "prediction": "I think this is what you're looking for.", "reference": "These are covered by routing constraints." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Could we use just a normal string here?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "`isFunction(Symbol)` triggers a `ReferenceError` if Symbol is undefined. Using `typeof Symbol === 'function'` is OK however." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems to be a bug.", "reference": "Is there an else clause (with a lock.unlock ()) missing here as well? If we think we do not need an else clause then lets add an else clause containing assert zero." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "do we foresee `32` ever changing? (as well as its use in error checking in `clerk.go`) if \"no\" this is fine, if \"yes\" it's probably still fine" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I'm sure it's a bug.", "reference": "you don't need to create a enum for this, java allows you to switch on a string ;) (since java 7?)" }, { "prediction": "I think this is a bug in the API.", "reference": "This should be `modelPromises.roles = this.get('store').query('role',...` and the promise body should just `return roles;`. This is because the `model()` hook will pause for the returned promises to be resolved before continuing so when returning `RSVP.hash` you end up with a hash containing the values returned from the promises so the controller and everything else relying on the `model` object doesn't need to worry about things being async." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This is basically a repeat of `main-is-top-level.js`. I suggest having these 3 checks point to the same evaluate file. You can change what element they test through the rule selector as well as the check.json options property. So you would have `main-is-top-level.json`, `banner-is-top-level.json` and `contentinfo-is-top-level.json` each point to `landmark-is-top-level.js`, and pass in a different `options` object which tells it what element you're trying to test." }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Why do we need this check? setCore already handles nulls." }, { "prediction": "I think this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "good catch, thanks. This is going to make the user experience much better." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to import a component from another component, so I'm not sure what you're trying to do.", "reference": "TODO: remove this unused import" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Hmm leaking the library name out in the Workload API doesn't seem great. Do we want to catch these errors and return a canned \"could not parse token\" or something instead?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this.", "reference": "I think `-f gradlew` is better for code unity" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Is there precedent for this config key? What other keys are similar? The others in this file start with `table.exec.iceberg`. Is there a reason for not continuing with that convention?" }, { "prediction": "I'm using System.Linq.Expressions; and I'm using System.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Linq.Expressions.Lin", "reference": "Can we avoid no-change changes being committed - they make it harder to distinguish actual changes from code editor changes" }, { "prediction": "I think this is what you're looking for: https://docs.aws.amazon.com/AWSEC/latest/UserGuide/aws-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-iam-", "reference": "AWS Identity and Access Management (IAM)" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's just a bug, or if it's a bug, I'm not sure.", "reference": "You dont use this dependency anymore" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "Here is the test that checks that the sqlcipher in use was compiled with the right flags" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Turns out that if the hosts are not in an `array`, an `Exception` is not thrown anymore :-( It simply returns `null`. So, we need to attempt to parse a `string` outside the `catch` block for it to work." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "this test only covers the happy path. what about no acceptable rest template found?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "Since this is in a test, I imagine that the choice of `info` level was deliberate." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "this should probably be named somewhere if you want to reuse it." }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to use the ` ` ` ` ` ` instead of the ` ` ` ` ` ` `", "reference": "needs a rename to not include AWS" }, { "prediction": "I'm not sure if it's a bug, but it's a bug, and it's a bug.", "reference": "Isn't sigma have `double` type?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "May be better use nano::keypair that generates ramdom value?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm assuming you're trying to do something like this:", "reference": "I think the more complete solution will save off a `ignoreUndefined` in the base class for the bulk operation (with a default of `false`), and use that for calculations. Was there a reason you didn't want to support the option from the operation level?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug, but I think it's a bug.", "reference": "The catch (Exception e) block that follows does an updateSync, which will get a SmartStore instance (while logging out is taking place) - and then terrible things will happen - a database gets created for the outgoing user that won't be openable by the returning user causing the app to crash at logout. This is a somewhat superficial fix - SmartStore should not return an instance for an outgoing user." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "huh does this work without a `Return`?" }, { "prediction": "I think this is a bug in RSpec. It should be fixed in the latest version of RSpec.", "reference": "Don't think we want this line, right? (Plus \"failing\" is spelled wrong)." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "I think it would be more clear to have local-feed-hiding all in one place (bottom of this method?). Further up the method, there already is some code that hides the website icon, for example." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Why remove this one? It doesn't work yet, but we'll add it sooner or later." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Why did you remove the struct tags?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Let's be neutral with tag names. Let's just have \"ReportURL\"" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "Use an explicit time to ensure conversion is not copy-paste and wrong." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's a bug.", "reference": "The logic now is to look for ``. This `` output is also not consistent with the other two functions you mentioned. Do the other two RPCs not report an error?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for the show_id in the show.friendly.find(params[:show_id]) instead of the show.friendly.find(params[:show_id]) in the show.friendly.find(params[:show_id]) in the show.friendly.find(params[:show_id]) in the show.friendly.friendly.find(params[:show_id]) in the show.friendly.friendly.find(params[:show_id]) in the show.friendly.friendly.find(params[:show_id]) in the show.friendly.friendly.find(params[:show_id]) in the show.friendly.friendly.find(params[:show_id]) in the show.friendly.friendly.find(params[:show_id]) in the show.friendly.friendly.find(params[:show_id]) in the show.friendly.friendly.find(params[:show_id]) in the show.friendly.friendly.find(params[:show_id]) in the show.friendly.friendly.find(params[:show_id]) in the show.friendly.friendly.find(", "reference": "Use nested module/class definitions instead of compact style." }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "Do you think we need to keep this in, or is it just leftover personal debugging? Seems like it wouldn't be too useful most of the time, but I don't care too much if you want to keep it." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "showNPCs is not needed" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Docstring for public function pls" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if", "reference": "This should use `t.Errorf` instead. You want the second part of the test to run even when the first part fails." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Should this if block better be changed to `#if H2O_USE_LIBUV \\n #else... #endif`? The reason I wonder is because that's the way the QUIC context is being initilaized at the beginning of this function. Though I would not expect practical difference between the two approaches, because ATM the only case where we create QUIC connections is when the protocol selector is set to non-zero, and because when it is set to non-zero `h2o_quiy_close_all_connections` becomes a no-op." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "`Object.is` is an ES6 feature of JS so I don't think we can use it here (or we have to change our browser support matrix or specify that an Object.is polyfill is pre-req of `preact/hooks`). Should we just do an `===` check in `preact/hooks` and provide a `Object.is` polyfill and version of `useReducer` in `preact/compat`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "This was a bug I picked up by using the TS interface as a guide, this seems like it was / is the intention, also is a bug in master (needs port)" }, { "prediction": "The `withCollection` flag is not used in the `withCollection` flag. It is used in the `withCollection` flag. The `withCollection` flag is used in the `withCollection` flag. The `withCollection` flag is used in the `withCollection` flag. The `withCollection` flag is used in the `withCollection` flag. The `withCollection` flag is used in the `withCollection` flag. The `withCollection` flag is used in the `withCollection` flag. The `withCollection` flag is used in the `withCollection` flag. The `withCollection` flag is used in the `withCollection` flag. The `withCollection` flag is used in the `withCollection` flag. The `withCollection` flag is used in the `withCollection` flag. The `withCollection` flag is used in the `withCollection` flag. The `withCollection` flag is used in the `withCollection` flag. The `withCollection` flag is used in the `withCollection` flag. The `withCollection` flag is used in the `withCollection` flag. The `withCollection` flag is used in the `withCollection` flag. The `with", "reference": "It would be helpful to explicit here what this really means and assumes." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "`ExpectedBalances` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm assuming it's what you're looking for.", "reference": "This is another place where I'd feel more comfortable with declaring the class private. We can always make it public in the future if someone makes a case for that, but I prefer to err on the side of privateness for things like this that 99% of RSpec users won't have a reason to use." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's the case, it's a bug.", "reference": "Feels like this should be left as is and add a new createClientWithIssuers or something like that. Avoid all the \"\"" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug, so I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Minor unrelated bug in the IDP flow where the error wasn't getting displayed as a `Toast`." }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this, so I'm not sure what you're trying to do, so I'm assuming you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "I thought we got rid of this thing?" }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this:", "reference": "Please convert int params as well." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Fixed bug in implementation. Now I can run the validator from the VS Tools menu, double-click on an output line, and navigate to the site of the issue." }, { "prediction": "I'm not sure if this is what you're looking for, but it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting", "reference": "Can we rename this field to `HttpServerErrorCodes` or `HttpServerErrorStatuses`? It will contain a list of status _codes_, not a list of _errors_. (Personally I prefer \"codes\" over \"statuses\", but we can't change `DD_HTTP_SERVER_ERROR_CODES`.)" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for. I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for.", "reference": "would you please use: flb_utils_bool(...) here?, that function wraps the on/off/true/false stuff." }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "`invocationInfoTokensToRedact: null` (I really like the convention of using a named parameter whenever the value doesn't communicate the meaning, such as for literal values.)" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "maybe renamed to `async_simple_test` if we consider supporting aug test later on?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "So where is default_attributes now? Is it used anywhere else still? If not, can it be removed along with any tests of it?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "We could move this to the base class and remove all these changes. What do you think?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "While we're doing some translation work, could you extract this button text and the other static text from the view?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Nit: Please fix indentation (note: Azkaban uses 2 spaces and not tabs)." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "This change is necessary because the schema version is ignored unless a schema is specified. I think that has always been the intent." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "The api/docs/release.dox changelog message is missing: maybe you planned to add it once NtAllocateVirtualMemoryEx and NtMapViewOfSectionEx support is in? I would say, add it here in the same diff that raises max_supported_os_version." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "Just do: `return node.hasAttribute('aria-hidden')`" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Do we need `_processDataPoisoned`? Can the name or the id of the current process ever change? Or the machine name?" }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it, so I'm not sure if it's the correct way to do it, but I think it's the correct way to do it.", "reference": "Did it not work out to wait until after containerd and kubelet are started?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "variable names suggestions from me: - damageboost, ITEM_PARSE_DAMAGEBOOST, \"damage boost +x%\" - healingboost, ITEM_PARSE_HEALINGBOOST, \"healing power +y%\" - managainboost, ITEM_PARSE_MANAGAINBOOST, \"mana restoration +z%\" alternatively the other names can stay, because \"increase\" convention isn't that bad, just change mana values to: - \"increasemanarestored\", ITEM_PARSE_INCREASEMANARESTORED, \"mana restoration +z%\"" }, { "prediction": "`complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_time` datetime DEFAULT NULL, `complete_", "reference": "Why can't this be determined by 'PARTIAL_SUCCESS' in the `status` field?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Does it make sense to generate a Exception here? Maybe yes, because it wouldn't make sense to generate a path without the id of the media right?" }, { "prediction": "I'm not sure if this is the same, but I'm not sure if it's the same, but I'm not sure if it's the same, so I'm not sure if it's the same, but I'm not sure if it's the same, so I'm not sure if it's the same, but I'm not sure if it's the same.", "reference": "This should be made private." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "perhaps this is better modeled as a pkg-level var?" }, { "prediction": "#define MAX_NODE_NAME 9 +#define MAX_PRECISION_ALLOWED 18 +#define HIVE_MAX_PRECISION_ALLOWED 38 +#define MAX_SCALE_ALLOWED 6 +#define MAX_NUM_LEN 16 #include \"SqlParserGlobals.h\"", "reference": "I don't think there is a maximum scale, neither for Hive nor for Trafodion. The only condition right now is that the scale can't exceed the precision. Example of a valid scale: DECIMAL(18,18). The maximum of 6 digits applies only to TIMESTAMP columns, where we don't support resolution below microseconds." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems to be a bug.", "reference": "`ctx` is unused in UpdateProjectStaticUser" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Why is this not the default, and why only for JS?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "A repository has many badges so we should also add type column in scope." }, { "prediction": "I'm not sure if this is what you're trying to do, but it should work.", "reference": "Now a hash set, so can't index into it." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "@jpogran Does this seem like a reasonable way to know if we're in powershell vs. CMD or *sh?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if this is the case, but I'm not sure if this is the case, so I'm not sure if this is the case.", "reference": "1.toLowerCase(Locale.US)? 2.where is accept bug fix?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "We should still be providing something to the user in the case of a `KeyError` instead of a stack trace!?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "check Lukasz's fix with NonceReserving - is that not better?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Would you explain why here please? E.g. from the PR description > the renderer expects to be able to use the secondary color as the fill for a shadow." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Lock needs to go to `RecoverFromDb` instead. Here it may cause deadlocks. My convention was that un-exported functions do not lock, only exported ones (with name starting with a capital letter)" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "German keyboard would also be used in Austria and Switzerland, so this should have included `.at` and `.ch`." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're trying to create a new Indexer.Factory. I'm not sure if this is what you're looking for, but it seems like you're trying to create a new Indexer.Factory. I'm not sure if this is what you're looking for, but it seems like you're trying to create a new Indexer.Factory. I'm not sure if this is what you're looking for.", "reference": "since this makes the indexer thing really only used for a single table, now, you can put in a TODO for me to cleanup and simplify this" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Should we have this path passed from the Azkaban properties? If this is the standard path for nscd even outside LinkedIn, then we can keep it." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, and it's a bug. I'm not sure if it's a bug, but it's a bug, so it's a bug.", "reference": "Could be a non-public field. `allowNoSubject`" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Don't think this is quite right - think the build one also needs an `IsOriginalTarget` (c.f. code in `src/build`)" }, { "prediction": "I think this is what you are looking for, but I'm not sure if this is what you are looking for, so I'm not sure if this is what you are looking for.", "reference": "what about adding typehints instead? I don't think we need to add docblocks for every private methods." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this. I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "Is it fine to pass the \"-o compression=on\" in the middle instead of at the end?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "Probably make them all keyword arguments." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Why not just check the backdrop setting here as well for the time being? We can combine the code later but at least then it would be configurable if people like the backgrounds." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "why are we turning this one into a Warning?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Wouldn't it be better to use double quotes for the opening parenthesis?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Remove the cast" }, { "prediction": "I'm not sure if this is a bug or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug.", "reference": "What criteria do we use to bump the copyright years? An update to the module?" }, { "prediction": "I think this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "should we rm line 269?" }, { "prediction": "I think this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Perhaps the code at `source/core.py:564: postNvdaStartup.notify()` should be queued instead? If we are saying the loop must have started before NVDA's startup is complete, then the `postNvdaStartup` action is incorrect." }, { "prediction": "I think this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Needed this for testing locally with mail view but not used for any tests. Might be nice to have some seed scripts at some point." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "wait, if we only do this for successful status codes won't we miss a whole slew of responses? We should be checking this for all codes right?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Adding in the service yaml `library.yaml` here." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Why is this dereference needed?" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Might want to add that this only happens if you have write permissions to the folder." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "Adding a small blurb about why someone would want to enable this flag would help clarify what it is for. Such as something about when providing a custom retry handler and how`ShouldRetry` will be handled with and without the flag enabled." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "assume the user will be able to register for a custom service name in future?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "The extra two empty lines seem unnecessary. Please review your diffs more carefully." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "What the reason to embed the Oracle?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "Shouldn't this happen automatically with High Voltage?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case.", "reference": "This is changed because we need `projectId` to be printed as `$projectId` in PHP." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "This title change seems more accurate to me however not sure if this will confuse users." }, { "prediction": "I don't know what you're trying to do, but I'm guessing you're looking for something like https://en.wikipedia.org/wiki/Full%20URL or https://en.wikipedia.org/wiki/Full%20URL.", "reference": "Here (and on line 158 as well), would it be more efficient to use the String end_with() method? Not tested" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "Why are you creating a new (second) `RAMHandler` here? Is this just an oversight from deleting the previous code?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "Move the line 27 to line 31 is better?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I'm not sure if this is the correct way to do it.", "reference": "In slack I mentioned we should only do this if the update is from some other device, to make sure our own updates don't cause issues. Maybe the revision check above is good enough to prevent this, but I just want to make sure you thought about it." }, { "prediction": "The `--seed` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "I would instead explain that random is the default, but you can switch back to defined, or another ordering scheme." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Is there a reason you left this at 0?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "The value of `key` will never be `null` at this point, because `getKey()` will generate a value if it is `null`." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "NIT: You should first check if AdoNetExcludedTypes.Count is greater than 0 before calling Contains (fast-path)" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "should rearrange so as to follow import ordering." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "what is the use case for create workflow with completed state?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "Probably best not to have an empty test...." }, { "prediction": "@@ -0,0 +1,15 @@ +#include + +int main(int argc, char* argv[]) { + Kokkos::Tools::initialize(argc, argv); + Kokkos::Tools::pushRegion( + \"The unanimous declaration of the thirteen united States of America, \" + \"When in the Course of human events, it becomes necessary for one people \" + \"to dissolve the political bands which have connected them with another, \" + \"and to assume among the powers of the earth, the separate and equal \" + \"station to which the Laws of Nature and of Nature's God entitle them, a \" + \"decent respect to the opinions of mankind requires that they should \" + \"declare the \" + \"decent respect to the opinions of mankind, which impel them to the separation.\"); + Kokkos::Tools::popRegion(); + Kokkos::Tools::finalize(); + Kokkos::Tools::popRegion(); + Kokkos::Tools::finalize(); + Kokkos", "reference": "Missing the license" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug.", "reference": "Looks like this was previously guarded by `EnableCleanupReplicationTask` flag. Now looks like this is always needed. Just want to confirm the intention is if `GlobalNamespace` is enabled then we want run cleanupReplicationTasks in all cases?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Potentially it'll be good to remove all of them excluding \"tbb/tbb.h\" But let's do it next time" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "I would just mention which tolerance - namely as reported by ``sys.float_info``" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this.", "reference": ":+1: Ideally this'll become something you could pass in to the config" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Should using `thenValue` to replace `then`?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "This follows the convention of each callback starting with the `IsIntegrationEnabled` check." }, { "prediction": "public void SumMetricLong(string name, string description, string unit, Meter meter, DateTimeOffset startTimeExclusive, KeyValuePair[] attributes, bool isDeltaValue, bool isMonotonicValue) { this.sumMetricLong = new SumMetricLong(name, description, unit, meter, startTimeExclusive, attributes); this.isDeltaValue = isDeltaValue; this.isMonotonicValue = isMonotonicValue; } public void SumMetricLong(string name, string description, string unit, Meter meter, DateTimeOffset startTimeExclusive, KeyValuePair[] attributes, bool isDeltaValue, bool isMonotonicValue) { this.sumMetricLong = new SumMetricLong(name, description, unit, meter, startTimeExclusive, attributes); this.isDeltaValue = isDeltaValue; this.isMonotonicValue = isMonotonicValue; } public void SumMetricLong(string name, string description, string unit, Meter meter, DateTimeOffset startTimeExclusive, KeyValuePair[] attributes, bool isDeltaValue, bool isMonotonicValue) { this.sumMetricLong = new SumMetricLong(name, description, unit, meter, startTimeExclusive, attributes); this.", "reference": "this is not required to be part of this PR right? (With UpDownCounter being absent in.NET, we can make this hardcoded for now, i think)" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm correct, but I'm not sure if I'm correct, or if I'm correct, or if I'm wrong, I'm just assuming I'm correct.", "reference": "Add the PipeFactory here" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "please add `var _ impltypes.ChaosImpl = (*Delegate)(nil)`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm assuming you're trying to do something like this, and I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here, but I'm assuming you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "nit: is this added deliberately?" }, { "prediction": "I'm not sure what you're trying to do, but I think it's a bug.", "reference": "Given the number of tests which need this (I think I counted seven) should we maybe just install this one globally? Is there even a place to do that? Something in `test_helper` maybe?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "we don't use this anymore, so we can delete it." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "nit: change to \"Telemetry configuration loaded from '%s'\"" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Why did this value change?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this. (I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.)", "reference": "maybe `duckpubsubv1alpha1`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this should work.", "reference": "The id is not mandatory for web extensions. Could you update this to support a web extension without an id?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "I actually prefer them to be defined here. Client who calls `lib` should define the args, not `lib` itself." }, { "prediction": "I'm not sure if this is the case, but if it is the case, it's probably the case.", "reference": "I think this should've been done with the `defer`-named-return trick. I'll submit a PR for it." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "The bind address should be configurable." }, { "prediction": "@Override + public void delete() { // nothing to do here. } + @Override + public List fetchCategories(File[] categoryDirectories) { final List results = new ArrayList<>(); for (File file : categoryDirectories) { results.add(new CategoryDTO(file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file.getName(), file", "reference": "Maybe the empty `delete()` should be implemented as default in the interface." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "How to ensure CMAKE_SOURCE_DIR is set correctly?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "safer to make a copy of incoming *big.Int" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to set the timeout for the ListContainers API. I'm not sure what you're trying to do here, but I'm guessing you're trying to set the timeout for the ListImages API. I'm not sure what you're trying to do here, but I'm guessing you're trying to set the timeout for the LoadImage API. I'm not sure what you're trying to do here.", "reference": "how did we choose this value? does this hold good for Windows too?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "To follow the other build tags, maybe we can call it `criu`?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Should we load this from the config file too?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it should be fixed.", "reference": "Can you file an issue for this?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "@nbbeeken what were the cases where `!!this[kIsMaster]` was yielding an incorrect value? we should try to cover them in the tests" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this. I'm not sure what you're trying to do, but I think you're trying to do something like this.", "reference": "This whole function feels messy. I don't have a better idea at the moment though." }, { "prediction": "@ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @", "reference": "should use Number instead of Long" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Can you rename this and the file `InfluxDBProvider` and `influxdb_provider.go` respectively?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something that's not what you're looking for.", "reference": "This is the real culprit, as now vlen will always be a Number (and known to the compiler as such). You could probably go one step further and avoid the ToBoolean on `vchildren` as well by writing something like `vlen = (vchildren!== undefined)? vchildren.length : 0` if that matches the contract." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "missing space before `TextView`" }, { "prediction": "I'm not sure if this is the case, but if it's the case, then it's probably the case.", "reference": "so this attribute is used as u8 in code, but saves as int32? Why?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's what you're trying to do.", "reference": "can RDSE be added to the list? It has its capnp files." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this. I'm not sure what you're trying to do here, but I'm guessing you're looking for something like this. I'm not sure what you're trying to do here, but I'm guessing you're looking for something like this.", "reference": "These functions only ever read from the API and should always be reading from a cache, so I have made that explicit by expecting a Reader here and supplying a `cache.Cache` as the client." }, { "prediction": "I'm not sure if this is the case, but if it's the case, then it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case, but if it's the case, then it's the case.", "reference": "No, we can't skip any of the mangling after the suspend point: this should follow the other mangling and undo its push." }, { "prediction": "I think this is a bug. It should be fixed in the future.", "reference": "this is generated code.. these changes will need to be made in the code generator to have them stick." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Should we abstract this into a reusable utility so it doesn't have to get repeated in every test file needing Shadow DOM support?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Maybe we rename this to `command_monitoring.test.js` to match the directory name change? Or would you rather do that as part of the greater test cleanup? I'm fine either way." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Why is this change necessary? `handleSingle()` will cast it to a string, no?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to create a new table, but you're trying to create a new one. I'm not sure what you're trying to do here, but I'm guessing you're trying to create a new table, but I'm not sure what you're trying to do here.", "reference": "This newly added method should be well defined, should it return `TableIdentifier` or just `String`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "have a relation with a product" }, { "prediction": "It is possible to delete a local pod if node is gone. But it is not possible to delete a local pod if node is gone. So we need to delete a local pod if node is gone. So we need to delete a local pod if node is gone. So we need to delete a local pod if node is gone. So we need to delete a local pod if node is gone. So we need to delete a local pod if node is gone. So we need to delete a local pod if node is gone. So we need to delete a local pod if node is gone. So we need to delete a local pod if node is gone. So we need to delete a local pod if node is gone.", "reference": "I guess that there is still a window here, because the GC could happen between the `PodExist` and `Delete` calls. Would it be better instead to check `err` and allow it if it says \"pod has already been deleted\"?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "SQLAlchemy's session management does magic to make sure that if the rollback fails you still get the original exception that caused the rollback. Also it looks nicer." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This switch statement can be removed. Just return q.items[act.Nonce]!= nil" }, { "prediction": "I think this is a bug in the Java compiler. It's not a bug in the Java compiler, but it's a bug in the Java compiler.", "reference": "I think `==` for nodes is more readable than equals. An equals calls looks like it could be recursing, because intuitively two nodes are equal if their subtree are the equal. But everywhere you replaced, we don't want to test whether the subtrees are structurally equal, we want to know whether they're the same. Only `==` captures this intent, using equals obscures this. Not to mention that equals may NPE and is in that sense less ergonomic. I think we should enhance the rule with a list of types for which `==` is correct. Edit: in the meantime i think we could suppress those new violations..." }, { "prediction": "IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable IEnumerable", "reference": "What's the scenario for passing multiple filters?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "move to after check log.empty()" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "This line needs to be removed" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Can we delete such const like `CloudBuildSourceEvent` and `CloudBuildSourceBuildId` since all those are contained under schemas/v1?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "This is unused." }, { "prediction": "I don't think this is a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug.", "reference": "Any reason not to put `using System.Collections.Generic` (guess there shouldn't be naming conflicts)?" }, { "prediction": "I think this is what you're looking for.", "reference": "Could the name of this controller just be shortened to `TwitterCardsController`? Is the `Player` there adding information?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Backends with hostnames that depend on the request are always up?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "I'd rather catch those to `utils.py` and raise a simple ValueError from them. From the resource point of view, these are details of implementation" }, { "prediction": "@@ -11,10 +11,6 @@ module Travis module Build class Script class Julia < Script - DEFAULTS = { - julia:'release', - julia:'release', - julia:'release', - julia:'release', - }", "reference": "make this 1.0? I don't think all that many people do `language: julia` without any `julia:` specifiers, but may as well keep that possible?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "nit: `AZURE_KEYVAULT_AUTH_VIA_CLI` is defined by us, so it might be helpful to differentiate it from azure's env names. Maybe starts with `GOCDK`." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "Depend on interfaces not on structures" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "This fix looks good. My concern, don't forget to fix metad too!" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Just noticed this nil context. Perhaps plumb through ctx too, or change to `Debug`?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Does it send requests with urlencoded bodies anywhere? I thought it sends only json. Maybe content-type should be `application/json` by default?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Again use of `constexpr` is recomended." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Minor point but I would call this ``redim_graph`` instead." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "As I was trying to figure out how the error messages are written out, since they are returned from `getOrCreate` and `reconcile`, it looks like we are using plain `klog` to write them out instead of using the logger from the scope above" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Now it's double logging, is not it? Because `service.ipForward.Enable()` logs extra `warning`" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Whatever the decision is about the request type to use, this should only match what is needed and not the other one." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "...and in turn, this should probably be var updatePreviews = true; if (!(localConnection && localConnection.type == Blockly.OUTPUT_VALUE) && (Blockly.localConnection_ && Blockly.highlightedConnection_)) { since the first clause is a no-op. If you want to leave it this way for clarity, that's fine too." }, { "prediction": "I think this is a bug in BigqueryRulesEngine. It should be fixed in the BigqueryRulesEngine.yaml file.", "reference": "Please remove this TODO, since they will not apply anymore after you are done. :) Can you please remove this everywhere else in this PR?" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's not what you're trying to do, then it's a bug.", "reference": "This seems like an incomplete schema definition. will that have any effect on the tests?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "The testing cases are failing because `SetHeader` does not only handle cases where input are from files. It also reads categorical feature indices from the config parameters (see the part outside the `if (filename!= nullptr) {... }`). Skipping `SetHeader` directly here will cause errors when we load data from numpy or pandas arrays (where `filename == nullptr`) and use categorical features. So I think we should move the the check `filename!= nullptr && CheckCanLoadFromBin(filename) == \"\"` into `SetHeader`. That is, we change `if (filename!= nullptr) {... }` into `if (filename!= nullptr && CheckCanLoadFromBin(filename) == \"\") {... }`" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug.", "reference": "I think we should change the variable name of `err` in `if err, ok := err.(*exec.ExitError); ok `, this re-assignment of `err` still affects the next `else` branch" }, { "prediction": "I'm not sure I'm getting this right, but I'm not sure if I'm getting this right, so I'm not sure if I'm getting it right, so I'm not sure if I'm getting it right, so I'm not sure if I'm getting it right.", "reference": "`Status` has identical semantics with `StatusOr`." }, { "prediction": "@@ -75,6 +75,7 @@ -75,6 +75,7 @@ -75,6 +75,7 @@ -75,6 +75,7 @@ -75,6 +75,7 @@ -75,6 +75,7 @@ -75,6 +75,7 @@ -75,6 +75,7 @@ -75,6 +75,7 @@ -75,6 +75,7 @@ -75,6 +75,7 @@ -75,6 +75,7 @@ -75,6 +75,7 @@ -75,6 +75,7 @@ -75,6 +75,7 @@ -75,6 +75,7 @@ -75,7 @@ -75,7 @@ -75,6 +75,7 @@ -75,6 +75,7 @@ -75,7 @@ -75,75,7 @@ -75,75,7 @@ -75,75,7 @@ -75,75,7 @@ -75,75,7 @@ -75,75,7 @@ -75,75,7 @@ -75,7 @@ -75,75,7 @@ -75,", "reference": "why is this named in a different style from other paths?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug, so I'm not sure what you're trying to do. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Swapped these to ensure that we aren't passing a nil cluster in to util.IsPaused" }, { "prediction": "I'm not sure if this is the case, but I think this is the case. I'm not sure if this is the case, but I'm not sure if this is the case, but I'm not sure if this is the case.", "reference": "I don't see pkgManager used anywhere, is there a reason we need this?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure.", "reference": "A bit late, but I don't think this is necessary, as all callers will send absolute paths. And if you ever get a relative path, resolving it with `toAbsolutePath()` leads to it being relative to whatever CWD the app is started with, while the typical resolving of relative `instanceDir` is to resolve it relative to CoreContainer#coreRootDirectory." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "There's an awful lot of test failures here because `localFieldPathType.schema` may not contain a `getters` array." }, { "prediction": "We have to come up with a better way to do this. I'm not sure if this is the best way to do it, but it's the best way to do it. I'm not sure if it's the best way to do it, but it's the best way to do it. I'm not sure if it's the best way to do it, but I'm sure it's the best way to do it. I'm not sure if it's the best way to do it, but it's the best way to do it. I'm not sure if it's the best way to do it, but I think it's the best way to do it. I'm not sure if it's the best way to do it, but I'm sure it's the best way to do it. I'm not sure if it's the best way to do it, but I'm sure it's the best way to do it.", "reference": "Mysql allows for `||` concatenation (e.g. `firstname||' '||surname`) if you enable it: `set sql_mode=PIPES_AS_CONCAT;`. I think this check is safer though" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "NOTE: this is the default ENS registry address. If the ENS suite is deployed from the current builds to any chain, it will always be found at this address." }, { "prediction": "I think this is a bug in Upcase::Application.routes.draw. I'm not sure if it's a bug, but it's a bug in Upcase::Application.routes.draw.draw.", "reference": "I'm curious why you are using `draw` in this route file?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "Those variables are only been used once, I think we don't need to create them at all, just pass values to the `GetRawDiff` directly." }, { "prediction": "This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.", "reference": "I like the idea of replacing all the `#if NET461` with `#if NETFRAMEWORK`... is that worth doing now? Means fewer changes if we go to 4.7.2 at some point" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to use a different provider. I'm assuming you're using a different provider. I'm assuming you're using a different provider. I'm assuming you're using a different provider. I'm assuming you're using a different provider. I'm assuming you're using a different provider. I'm assuming you're using a different provider. I'm assuming you're using a different provider. I'm assuming you're using a different provider. I'm assuming you're using a different provider. I'm assuming you're using a different provider. I'm assuming you're using a different provider. I'm assuming you're using a different provider. I'm assuming you're using a different provider. I'm assuming you're using a different provider. I'm assuming you're using a different provider. I'm assuming you're using a different provider. I'm assuming you're using a different provider. I'm assuming you're using a different provider. I'm assuming you're using a different", "reference": "to fix the docs build failure, make this const var named without the suffix `Name`" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "This bugfix also included, in case a subjectAlternativeName was present in the cert, then URIs (e.g SVID SPIFFE auth) would not have been attempted." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Same here. Feels like the wrong location." }, { "prediction": "I think this is a bug in qutebrowser.utils.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.usertypes.us", "reference": "Please make `_path_suggestion` public (i.e. remove the `_`) in `downloads.py`." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Woah, these flag names gotta get shorter. (Edit: I'll try to suggest some if needed, will think on it.)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "Is this the code that's supposed to use the Rails app's only when in Rails4? What's the point of the first `if app.respond_to?(:secrets)`, both the `if` and the `elsif` have the same body, is only the second one needed? If `app.config` has a `secret_key_base`, then use it, the end. Is there a need for first checking if `app.respond_to?(:secrets)`?" }, { "prediction": "I don't think it's a bug, but I think it's a bug.", "reference": "Does this not apply to C enums on Linux?" }, { "prediction": "I'm not sure if this is the case, but I think it's the case. I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "Should this check if the error is `RetryableWriteError` before adding the label?" }, { "prediction": "I'm using rollup-plugin-commonjs. I'm not sure if it's using rollup-plugin-commonjs or rollup-plugin-commonjs, but I'm not sure if it's using rollup-plugin-commonjs or rollup-plugin-commonjs. I'm not sure if it's using rollup-plugin-commonjs or rollup-plugin-commonjs, but I'm not sure if it's using rollup-plugin-commonjs or rollup-plugin-commonjs. I'm not sure if it's using rollup-plugin-commonjs or rollup-plugin-commonjs.", "reference": "Oh wow, that's one complicated require :)" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "do you mean how to \"use\"" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "We can't really test this anymore since ref and props.ref are at the backing node level now" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "Did you intend to set this in the constructor?" }, { "prediction": "I'm not sure if this is the correct way to do this. I'm not sure if this is the correct way to do it, but I'm not sure if it's the correct way to do it.", "reference": "This looks fine as a first approach, and can we put a TODO here about ubuntu 18.04 being hardcoded?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "This isn't strictly needed since lmdb / leveldb data that is unencoded does not require OpenCV IO. I think `DataLayer` should only require lmdb / leveldb. If one tries to use encoded data without OpenCV the `DataTransformer` guards will report the dependency failure." }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "Should we take out this change? This was only in there to try to brute force the start of the apiserver yesterday." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "I worry that this association name is a bit confusing. Yoz was asking me about the concept of completion yesterday, which is why I think of it. It wasn't clear to him exactly what it was. what about calling this a `step_completer`? we know that a proposal has many steps, so I think that might be clearer. in the future, we also might want the rename the `approver` relation because a step is not always an approval these days." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea to use the ````````````.````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````", "reference": "Just add a to-do saying we need to add api-version in the check some time in the future when we enable the single-swagger spec mode for validation." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "@lunika Please see this. It allows us to do `Propel::getConnection()` easily, as we have only one database." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Not related to this particular cast but I wonder if we shouldn't have a cast helper that would log if null to gain visibility." }, { "prediction": "@ts-ignore const purest = require('purest')({ request })", "reference": "why do we need to explicitly declare these fields?" }, { "prediction": "I'm not sure if this is the correct way to do this, but I think it's the correct way to do it.", "reference": "Note that there are multiple OAI servers -- that's why `$serverClass` is a variable here. You'll want to fetch `$serverClass` from the service manager rather than a hard-coded value, and also set up a module.config.php for the authority record version, `VuFind\\OAI\\Server\\Auth`. Should be easy enough since it can share the same factory." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if it's what you're trying to do.", "reference": "This is no longer needed and should be removed." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "could use named return params here to avoid declaring the opts, and using naked returns instead." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "this is an unrelated fix. I noticed when an instagram carousel post is mixed with images and videos, the videos don't come with thumbnails, so I am adding a fallback thumbnail for this case." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug. I'm not sure what you're trying to do, but I think it's a bug.", "reference": "\"... after protocol version 1\"?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "Is there a unit test that covers this regexp? I am afraid that changing it might break things =/" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "This change is okay IMO because an `@` variable in Ruby is not a reference -- `@` variables are instance variables. Also, it's never used by the Ruby transformers." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "Why this change was needed? Because in `po` files it's with curly braces?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug", "reference": "Wait -- where did this change come from? This seems unrelated to trace building and seems like it could affect basic execution, unlike the rest of this PR which is all under the off-by-default trace option. Please separate this into its own PR and probably ask @AssadHashmi to review." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for babel-preset.", "reference": "seems to be redundant (mention `docusaurus` )" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Can we combine this with the Rollback API? We could still support the `rollback` method here, but combine `Rollback` and `CherryPick` into something like `ManageSnapshots`. Then we could reuse logic for enforcing checks of the current snapshot. What do you think?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Maybe just `env_prefix`, I don't think this is referring to the WQ manager." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Unrelated line change :)" }, { "prediction": "I think this is what you are looking for: https://github.com/sirupsen/k8s.io/apimachinery/pkg/util/wait", "reference": "I raised an eyebrow at making `net` depend on `k8s.io`, but it seems we're already doing that." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "I think ticket meant, not applying replacement in this method, but rather applying encodeSomeHtml to each and every localization string" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "ticket for the 4.0 epic?" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "`cfg.model.get('neck')` will return None if neck does not exist, thus we can omit the default value." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Trailing whitespace detected." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I don't see why a `cxxflags` key is necessary? C flags are important in the target file because they define things like the float ABI. But these flags are also used for C++. I can't think of a reason why you would want to configure C++ flags in a target file." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure what you're trying to do.", "reference": "Update year range in Copyright notice, and elsewhere too." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Can we update this PR to not be a breaking change? i.e. if a user specifies `accessKeyID`, it is still used. But if a user specifies `accessKeyIDSecretRef`, it takes precedence?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if this is the correct way to do it.", "reference": "You don't actually need both tests here as \"truthiness\" means that `\"0\"` is false and hence the first test will be true..." }, { "prediction": "I18n.t('subscriptions.cancellation_scheduled_on', date: 'February 19, 2013' + ) I18n.t('subscriptions.cancellation_scheduled_on', date: 'February 19, 2013' + ) I18n.t('subscriptions.cancellation_scheduled_on', date: 'February 19, 2013' + ) I18n.t('subscriptions.cancellation_scheduled_on', date: 'February 19, 2013' + ) I18n.t('subscriptions.cancellation_scheduled_on', date: 'February 19, 2013' + ) I18n.t('subscriptions.cancellation_scheduled_on', date: 'February 19, 2013' + ) I18n.t('subscriptions.cancellation_scheduled_on', date: 'February 19, 2013' + ) I18n.t('subscriptions.cancellation_scheduled_on', date: 'February 19, 2013' + ) I18n.t('subscriptions.cancellation_scheduled_on', date: 'February 19, 2013' + ) I18n.t('subscriptions.cancellation_scheduled_on', date: 'February", "reference": "Everything else in here is using `I18n`. Should we do that here to be consistent?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "What do you think about changing the ordering to be `::`? I think it matches the most with what we previously had so that it doesn't change too much for our users." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do.", "reference": "I'm fairly sure this precondition is always true due to the mod (%)" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "I love seeing diffs like this one, adding a `String` message to an otherwise cryptic `assert`! It makes me realize you must have had a hellacious debugging session!" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "1. No logger exists to produce a message 2. Can't assume the latest version because missed version means 0." }, { "prediction": "It's not clear what you're trying to do here, but it's possible that you're trying to create a new config object from an XML string, so it's not possible to create a new config object from an XML string. It's possible to create a new config object from an XML string, but it's not possible to create a new config object from an XML string, so it's not possible to create a new config object from an XML string, so it's not possible to create a new config object from an XML string, so it's not possible to create a new config object from an XML string.", "reference": "I saw a wrong reuse of the cache between a partial analysis of a single file and a full run where errors due to lack of context on the first partial run was reported on the full run. Shouldn't we use a hash that is composer.lock + psalm.xml + command line to be safe?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Could you also update it in `at_time`?" }, { "prediction": "I'm not sure if this is the case, but if it's the case, it's the case, it's the case.", "reference": "Because schema is non-final we can't just switch this to a lambda" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "proposal: **always** add the exception to the end of the message. So no need to to pass exception twice (implicit and explicit). Need a lot of changes." }, { "prediction": "I'm not sure if this is the case, but if it is the case, I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "why? event.getInvocationType is not you want?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "nit: how about `GitSHA`?" }, { "prediction": "It's a bug. It's a bug. It's a bug. It's a bug.", "reference": "If you move the other functions, this should also be moved to `makeflow_gc.h`." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "This whole block bugs me. Expire_time to me suggest that an absolute time of when something happens and duration is an interval of time. While the code looks correct, it feels awkward to read." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Can we add `_dom` as an argument to createVNode here? I think it might be shorter (could totally be wrong!)" }, { "prediction": "In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In", "reference": "I think that the iret handling is not yet good." }, { "prediction": "@ -78,7 +78,7 @@ const DeviceSizeTabBar = ( { { icon } ); - }", "reference": "Huh, that's kinda weird. I get it, but it's unexpected to me..." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I think you're trying to do something like this.", "reference": "why is this removed? it is important when you upload from stream of unknown size" }, { "prediction": "I think this is a bug in ActiveRecord::Base. I'm not sure if it's a bug, but it's a bug in ActiveRecord::Base.", "reference": "Out of curiosity, why is this needed? Does it enforce what class can be assigned?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "non-blocking: Now that we have a handful of statements which deal with creating a listener, it may make sense to introduce a `createListener` method or something similar" }, { "prediction": "I'm not sure if I'm missing something, but I'm not sure if I'm missing something, but I'm not sure if I'm missing something.", "reference": "factory should be stateless if possible, looks like much complexity added" }, { "prediction": "@property def project_id(self): \"\"\"Project ID on which to run the BigQuery Job. \"\"\" return self.output().table.project_id + \"\"\"Project ID on which to run the BigQuery Job. \"\"\" return self.output().table.project_id + \"\"\"Project ID on which to run the BigQuery Job. \"\"\" return self.output().table.project_id + \"\"\"Project ID on which to run the BigQuery Job. \"\"\" return self.output().table.project_id + \"\"\"Project ID on which to run the BigQuery Job. \"\"\" return self.output().table.project_id + def run(self): output = self.output() assert isinstance(output, BigQueryTarget), 'Output must be a BigQueryTarget, not %s' % (output) return self.output().table.project_id + \"\"\"Project ID on which to run the BigQuery Job. \"\"\" return self.output().table.project_id + \"\"\"Project ID on which to run the BigQuery Job. \"\"\" return self.output().table.project_id + \"\"\"Project ID on which to run the BigQuery Job. \"\"\" return self.output().table.project_id + \"\"\"Project ID on which to run the BigQuery Job. \"\"\" return self.output", "reference": "Could you please add short description for the default value as well?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug, so I'm not sure if it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug. If it's a bug, I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Leave a TODO message to say we will fix the log level in the future, once committing the block and the state become a transaction" }, { "prediction": "I'm not sure I'm getting this right, but I'm not sure I'm getting this right. I'm not sure if I'm getting this right, but I'm not sure if I'm getting it right.", "reference": "this can be integer" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to change the color of the color of the color of the color of the color of the color of the color of the color of the color of the color of the color of the color of the color of the color of the color of the color of the color of the color of the color of the color of the color of the color of the color of the color of the color of the color of the color of the color of the color of the color of the color.", "reference": "nitpick: Please remove the blank line here" }, { "prediction": "I think this is a bug in ActiveRecord::Base. It should be fixed in ActiveRecord::Base. It should be fixed in ActiveRecord::Base. I'm not sure if this is a bug, but it should be fixed in ActiveRecord::Base.", "reference": "What is this for? The only methods I can see by that name in the rails doc are generating a foreign key name from a model class name but you seem to be giving a key name as argument?" }, { "prediction": "private static void checkForDuplicateCoreNames(List cds) { checkForDuplicateCoreNames(cds); } private static void checkForDuplicateCoreNames(List cds) { checkForDuplicateCoreNames(cds); } private static void checkForDuplicateCoreNames(List cds) { checkForDuplicateCoreNames(cds); } private static void checkForDuplicateCoreNames(List cds) { checkForDuplicateCoreNames(cds); } private static void checkForDuplicateCoreNames(List cds) { checkForDuplicateCoreNames(cds); } private static void checkForDuplicateCoreNames(List cds) { checkForDuplicateCoreNames(cds); } private static void checkForDuplicateCoreNames(List cds) { checkForDuplicateCoreNames(cds); } private static void checkForDuplicateCoreNames(List cds) { checkForDuplicateCoreNames(cds); } private static void checkForDuplicateCoreNames(List cds) { checkForDuplicateCoreNames(cds); } private static void checkForDuplicateCoreNames(List cds) { if (cds", "reference": "Is this second check necessary? we know that just after the plugin was created its metricRegistry is null, it's set only after `initializeMetrics` has been called." }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but if it's a bug, I'm not sure if it's a bug, or if it's a bug, or if it's a bug, I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug,", "reference": "shouldn't this be `return TALKACTION_BREAK;` as the player does not meet the required group access?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "does this still work if minerNode1 has already proposed a block before 2 & 3 are stopped?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "I am wondering if we can either make this a feature or have a way to turn it off in production. My concern is that we might be adding more of these kind of code in the future." }, { "prediction": "I don't think this is a bug, but it is a bug in the pandas API. I think it is a bug in the pandas API.", "reference": "We can just use `.stack()` here? Then I guess we can reuse when supporting multi-index columns." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "What are the possibilities here? Since we plan on supporting.net standard 2.0 from day 1, we might as well tackle that now." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "should the parameters be called reference or context?" }, { "prediction": "I'm not sure if this is what you're looking for, but if it's the case, then it's a good idea to use the `write_nonblock` operator.", "reference": "Do we need to also change `length` here (and below) to `bytesize`? Perhaps we ought to make a copy of `in_buffer` encoded as binary and then the existing algorithm should work." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "This should be `toDisplayString()` to not contain e.g. passwords." }, { "prediction": "I think this is a bug in Rails. It's a bug in Rails.", "reference": "Can we just say that having a non-nil `autocomplete_path` implies that autocomplete is enabled?" }, { "prediction": "I'm not sure if this is what you're looking for, but it looks like you're looking for \"github.com/caddyserver/caddy/v2\" \"github.com/gogo/protobuf/proto\" \"github.com/golang/protobuf/proto\" \"github.com/golang/protobuf/ptypes/timestamp\" \"github.com/google/cel-go/cel\" \"github.com/google/cel-go/checker/decls\" \"github.com/google/cel-go/checker/decls\" \"github.com/google/cel-go/checker/decls\" \"github.com/google/cel-go/checker/decls\" \"github.com/google/cel-go/checker/decls\" \"github.com/google/cel-go/checker/decls\" \"github.com/google/cel-go/checker/decls\" \"github.com/google/cel-go/checker/decls\" \"github.com/google/cel-go/checker/decls\" \"github.com/google/cel-go/checker/", "reference": "Note that the package github.com/golang/protobuf/proto is deprecated. We're instructed to use the \"google.golang.org/protobuf/proto\" package instead. I didn't want to change it now to avoid intrusive changes whose consequences are, currently, unknown." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this, and that's what you're trying to do.", "reference": "Are these gone routes? Do we need to 301 them?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for.", "reference": "move them to internal group of imports" }, { "prediction": "I'm not sure if this is the correct way to handle this, but I think it's the correct way to handle it.", "reference": "can we rewrite this as: `ignored event '%s' for cstor pool '%s'`" }, { "prediction": "I think this is what you're looking for.", "reference": "not all client data types have an approving official (eg: 18F does not). do we still want to include the relation here?" }, { "prediction": "@see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.", "reference": "This change should also probably go into the corresponding method of the abstract By class?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "why this remove?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "As the test failures indicate, making this change is going to mean changing everything which currently implements this interface." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Do we want to redirect this to the forum or something in case people have it linked/bookmarked?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "@peterzimon came up with this 'NM' piece as a placeholder for New Member initials, without this the screen looks broken. It changes to normal initials calculation once email or name is entered. Lmk if you'd like to put something different here ;)" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "@kevinansfield Would be cool if you can take a if this is the best way to add `subscriptions` info on member model. This uses the transform + separate model definition way which seemed to be the right way from other references in Admin" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to import matplotlib.cm as cm, and that you're trying to import matplotlib.cm as cm, and that you're trying to import matplotlib.cm.cm as cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm.cm", "reference": "This is the common way of dealing with optional dependencies" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "nit: we can replace all `kr` in this file with like `src`." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "same concern here as above" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Thank you for this, I gather this repairs failures that I've seen in another PR." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "This place probably makes sense to me. We can consider exposing an argument to make the dedup step optional (I am not sure it is a good idea but I want to think this through together). The dedup step we are adding is going to trigger a shuffle. Technically, we are fine in the existing expire snapshots action as it does the dedup in `except`. The question is what kind of performance impact deduplicating here will have. We only have duplicates if multiple manifests reference the same files. In `rewrite_manifests` procedure, we rewrite all manifests, meaning we produce a snapshot with new manifests where entries are old data files. Also, there are updates and deletes that may rewrite manifests. I think deduplicating here makes sense to me in all cases. Thoughts, @rdblue @flyrain @RussellSpitzer @karuppayya?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "can we move the code before deleteNodeFromDB? this way even if the node crashes after remove config we can still re-run decommission again?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Seems the default value of `melt`'s `var_name` at namespace.py should be changed as well." }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "I think botocore's serializer should already create the correct headers. However, they are currently not used in `_botocore_parser_integration_test`(line #217). Maybe we could remove the headers here and just use a fallback in the `_botocore_parser_integration_test` (i.e. use the given headers if they are set, otherwise use the headers generated by botocore's serializer)?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "in case you want to rename one of the plugins when instantiating, from options?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea to add a `clang-func-mapping` command to the `clang-func-mapping` command. I'm not sure if this is what you're looking for, but I think it's a good idea to add a `clang-func-mapping` command to the `clang-func-mapping` command to the `clang-func-mapping` command. I'm not sure if this is what you're looking for, but it's a good idea to add a `clang-func-mapping` command to the `clang-func-mapping` command.", "reference": "This default variable should be moved into a config variable, created by `package_context`, and read from `config\\package_layout.json`." }, { "prediction": "I'm not sure if this is what you're trying to do, but it should work.", "reference": "Can I ask you to add a new line after `const` assignment? I believe that this increases the code readability by encapsulating assignment and logic (expecting) blocks." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "So the intention is you configure with `-CMAKE_CXX_FLAGS=\"-D KOKKOS_IMPL_TURN_OFF_CUDA_HOST_INIT_CHECK\"`?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "This was a bug." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "Is OK that we don't have some placeholder?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Sectorbuilder behaves differently depending on whether it's given 1 or more threads. It won't seal if only given 1." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Sort of believe We should put MetricManager in constructor parameter given this case." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Do we need to check `fieldId` is larger than 1000?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "I think this should be called after the if below (the one for disable positive acks)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "I'd like to avoid changing this method since it is public and using a URI will probably change behavior for users passing strings (String -> URI -> Path instead of String -> Path)." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Should these restore the stashed env after the test runs?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "We're calculating the full list of kwargs here (even if the first element of the list would return True) so we could improve performance by using a generator line 408 in ``for default_node in all_defaults:``." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Can ndelta differ depending on when the deltas are compacted? That is, when intermediate updates are dropped?" }, { "prediction": "I'm not sure I'm getting this right, but I'm not sure I'm getting it right. I'm not sure if I'm getting it right, but I'm not sure if I'm getting it right, so I'm not sure if I'm getting it right. I'm not sure if I'm getting it right, but I'm not sure if I'm getting it right.", "reference": "Our checkstyle config likes it better when the `

    ` is before the first word of the next paragraph, and not on a blank line" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure.", "reference": "This looks to be the only place where we return early before the close below, so if the \"double close\" is bothering people, closing manually here (and removing the `defer`) could be an option" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "This task can probably be deleted since we don't need gulp to run Jest." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to connect to a socket that doesn't exist. I'm guessing you're trying to connect to a socket that doesn't exist, so I'm guessing you're trying to connect to a socket that doesn't exist.", "reference": "Doesn't this need to include `Errno::ECONNRESET` to fix the issue?" }, { "prediction": "@faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next + # @faker.version next +", "reference": "never heard of a qirector... what's their role again? (also should be 'for a movie')" }, { "prediction": "I'm not sure if this is the case, but if it's the case, I'm not sure if it's the case, but if it's the case, I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "Implement the \"collect all props for one vertex\" logic inside QueryVertexPropsProcessor" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "This is to prevent parsing things like \"1.1\" as \"1\" until we implement it properly." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug in nupic.frameworks.opf.experiment_runner. I'm not sure if this is a bug, but it seems to be a bug in nupic.frameworks.opf.experiment_runner. I'm not sure if this is a bug, but it seems to be a bug in nupic.frameworks.opf.experiment_runner. I'm not sure if this is a bug in nupic.frameworks.opf.experiment_runner, but it seems to be a bug in nupic.frameworks.opf.experiment_runner. I'm not sure if it's a bug in nupic.frameworks.opf.experiment_runner, but it's a bug in nupic.frameworks.opf.experiment_runner.", "reference": "Can we change `_getCheckpointParentDir` to be a public function explicitly? It seems like something that clients of experiment runner may wish to use." }, { "prediction": "This is the label for a group of advanced options in the # Advanced settings panel. This is the label for a group of advanced options in the # Advanced settings panel. + label = _(\"Use UI Automation to access the Windows Console (restart NVDA for changes to take effect)\") + self.ConsoleUIACheckBox=UIAGroup.addItem(wx.CheckBox(self, label=label)) + self.ConsoleUIACheckBox.SetValue(config.conf[\"UIA\"][\"consoleUIA\"]) + self.ConsoleUIACheckBox.defaultValue = self._getDefaultValue([\"UIA\", \"consoleUIA\"]) + # Translators: This is the label for a group of advanced options in the # Advanced settings panel label = _(\"Browse mode\") + self.ConsoleUIACheckBox=UIAGroup.addItem(wx.CheckBox(self, label=label)) + self.ConsoleUIACheckBox.SetValue(config.conf[\"UIA\"][\"consoleUIA\"]) + self.ConsoleUIACheckBox.defaultValue = self._getDefaultValue([\"UIA\", \"consoleUIA\"]) + # Translators: This is the label for a group of advanced options in the # Advanced settings panel label = _", "reference": "Why is a restart necessary?" }, { "prediction": "I'm not sure if this is the correct way to do this, but I think it's the correct way to do it.", "reference": "Should setting the task runtime also go under the above if condition?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "SPIRE uses the leadingLowerCase convention for unexported constants" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm wrong, or if I'm wrong, or if I'm wrong, I'm wrong, or if I'm wrong, or if I'm wrong, I'm wrong, or if I'm wrong, I'm wrong.", "reference": "The newest JSchema code generator orders `System` usings first." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but if it's the case, it's the case. I'm not sure if it's the case, but if it's the case, it's the case. I'm not sure if it's the case, but I'm not sure if it's the case. I'm not sure if it's the case, but I'm not sure if it's the case. I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case. I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "I understand that we want to have a possibility to configure the IcebergInputFormat to be case sensitive or case insensitive since it can be used by other MR jobs as well. Do we want to allow the users of Hive to shot themselves on the foot and enable case sensitivity? My first guess would be that we should not use the configuration here, just go with `false`, but if you have some specific use-case in your mind I can be easily convinced" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "Will the above call to cStorPoolAddEventHandler() get executed in the same thread as this line?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "I don't think alloca instructions are always at the start of the entry block. I think it would be safer to check the entire entry block for alloca instructions, just in case some are not the first instruction. (Technically they can be anywhere in the function but we check in other places that this isn't possible)." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm not sure.", "reference": "Why isn't this 4789 (which I think is the Felix default)?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Can this be `Import operations failure`? In addition, is this the right time to change the variable names? e.g. `ReasonImportOperationsFailure`, `ReasonImportFailure`, `ReasonImportSuccessful`, `ReasonCreateResourceFailure`, `ReasonImportResourceSuccessful` Naming convention that i have assumed here is as follows: `Reason`" }, { "prediction": "@ -457,4 +457,5 @@ void Init_binary_protocol_accelerated() { rb_define_method(bpa_class, \"read_set_end\", rb_thrift_binary_proto_read_set_end, 0); rbuf_ivar_id = rb_intern(\"@rbuf\"); + rb_global_variable(&rbuf_ivar_id); rb_global_variable(&rbuf_ivar_id); rb_global_variable(&rbuf_ivar_id); rb_global_variable(&rbuf_ivar_id); rb_global_variable(&rbuf_ivar_id); rb_global_variable(&rbuf_ivar_id); rb_global_variable(&rbuf_ivar_id); rb_global_variable(&rbuf_ivar_id); rb_global_variable(&rbuf_ivar_id); rb_global_variable(&rbuf_ivar_id); rb_global_variable(&rbuf_ivar_id); rb_global_variable(&rbuf_ivar_id); rb_global_variable(&rbuf_ivar_id); rb_", "reference": "I suspect this isn't needed because I think `rb_intern` gets marked already." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're using a WebDriver-backed Selenium. I'm not sure what you're trying to do here, but I'm guessing you're using a WebDriver-backed Selenium. I'm guessing you're using a WebDriver-backed Selenium, but I'm not sure what you're trying to do here.", "reference": "This change is incorrect: the current log level is correct." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Can you add a space before the equal sign? There are a couple other places where spaces are missing in this PR." }, { "prediction": "I'm not sure if this will work or not, but I think it will work.", "reference": "Please follow the todo naming convention." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, and it should be fixed.", "reference": "These are no longer used and changes should instead be made directly to the files in `deploy/chart/crds` /assign @JoshVanL /unassign" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Is this really necessary to work around this way? The old version works fine with me when converting to ONNX." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Same as above: don't start error strings with a capital letter, and don't fix unneeded things in an unrelated commit ;)" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Is this a testing debug statement?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "you'll need to wrap the _whole thing_ within this async call (or refactor it so everything below is in a new temporary function). The code below this section depends on a value for `object` after the parsing occurs, but what you're doing here is kicking off a race condition where `object` is null, but _might_ parse quickly enough to assign it the parsed parts. Instead, you need to do everything that depends on the parsed object in the callback of `parse`." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This is now going to be protecting `stopped` when it doesn't need to. If you are going to do this then can you make `stopped` non-atomic and protect it in `stop`. It's cheap to make a `unique_lock` fyi, it's just a pointer to a mutex and a `bool`. The `lk.lock ()` in the loop is superfluous so probably shouldn't have been there to begin with." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Lets not give packages names if we dont have to. If a package requires a rename, we should change the actual name while/if we can." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do. I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Not sure I see where this is coming from. This is a bug fix? Should be mentioned in the commit message? Same below." }, { "prediction": "I think this is a bug, but it should be fixed.", "reference": "I reverted this change in the last commit, I think we should revert it here. I know this leads to confusing test output for skipped tests, but I would prefer to tackle that in a separate PR specifically focused on that problem. In fact, I think the issue might really be with the leak checker, and not how this test runner is defined. Please make a ticket for this (if it doesn't already exist) and revert this change" }, { "prediction": "` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Can this part be done in `dataset.get_ann_info`? Just like CocoDataset converts xywh to xyxy in `_parse_ann_info`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "Should we change the name of this test struct to be `testTracerProvider` as well?" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "\"google.golang.org/grpc\" should be together with \"go.uber.org/zap\" all \"\"github.com/iotexproject/iotex-core/*\" stay together" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "No need for a separate variable here - just call `utils.read_file` directly below." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug, but I think it's a bug.", "reference": "Thanks for the fixing, small question, Here the message just be written to the channel, will it be blocked?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if this is the case.", "reference": "maybe we will have something like `Bodies []byte(\"bodies\")` instead of them being a number? with numbers we are making it harder to insert stages mid-process." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do, but I'm assuming it's what you're trying to do.", "reference": "out of curiosity, why making this change? If no real reason, could you restore to avoid unnecessary changes of several generated files?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Could we public events if `manager.serStatus()`?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if this is the case.", "reference": "could be misread as ``, maybe something redundant but very clear like \"before the closing `` tag\"?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do. I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's a good idea.", "reference": "This test is specifically checking behavior on sync I/O (note there are tests with Write in the name, and other tests with WriteAsync). Enable sync I/O here." }, { "prediction": "I think this is what you're looking for.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "The CstorVolumeClaim is a CstorVolumeClaim. The CstorVolumeClaim is a CstorVolumeRef. The CstorVolumeRef is a CstorVolumeRef. The CstorVolumeRef is a CstorVolumeRef. The CstorVolumeRef is a CstorVolumeRef. The CstorVolumeRef is a CstorVolumeRef. The CstorVolumeRef is a CstorVolumeRef. The CstorVolumeRef is a CstorVolumeRef. The CstorVolumeRef is a CstorVolumeRef. The CstorVolumeRef is a CstorVolumeRef. The CstorVolumeRef is a CstorVolumeRef. The CstorVolumeRef is a CstorVolumeRef. The CstorVolumeRef is a CstorVolumeRef. The CstorVolumeRef is a CstorVolumeRef. The CstorVolumeRef is a CstorVolumeRef. The CstorVolumeRef is a CstorVolumeRef. The CstorVolumeRef is a CstorVolumeRef. The CstorVolumeRef is a CstorVolumeRef. The Cst", "reference": "nit: Should we have something like `volumeName@snapShotname` and this will be filled only if it is a clone creation" }, { "prediction": "I'm not sure if this is the correct way to do it, but if it's the correct way to do it, then it's not the correct way to do it, but it's the correct way to do it.", "reference": "This seems like an improved pattern :)" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "I think it would be better to have a separate configuration option for specifying which HDFS interaction layer to use instead of using the existing hadoop version option. I think there are still cases where things might have to rely on Hadoop version for other things, and overwriting that information with \"snakebite\" would make that difficult. The existing hadoop version option could still be used to distinguish the different HDFS CLI flavours." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this should work.", "reference": "Why are we filtering content twice? It seems like just filtering it in PAL should work." }, { "prediction": "I'm not sure if this is the case, but it's the case, so it's not the case, so it's not the case.", "reference": "These should probably move to `constants.js`" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Again, you don't want to depend on glassfish." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "it should be `Faker::Space.launch_vehicle`, otherwise it will crash" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Isn't it quite expensive to check whether the file exists on every write?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Please hide this behind a flag and add a setter function to the builder." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this, and that's what you're trying to do. I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do. I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do. I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "old api should be deprecated if we don't intend on using it anymore. Again this should happen through swagger api and then removed from next release. We should also release not this as a breaking change. (same with all the other cloudsnap api renames." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think this is what you're trying to do.", "reference": "so strange...... canTcpListen is to detect, if this transport can init when customers deployed vertx and servlet rest transport, we must detect which one will be used only both of them refused to init is a problem. we have already print that......" }, { "prediction": "We need to use the `SELECT` keyword in the QuerySpec class.", "reference": "Did you mean for this to be `FORM`, instead of `FROM`?" }, { "prediction": "I'm not sure if this is the case, but I think this is the case.", "reference": "What are your thoughts on the long term solution for the naming of this variable? Do you think we should revert the logic when we are ready to make the next set of breaking API changes?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "There's a syntax error on this line." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "You lose the value of `result` when you `goto out`" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Just a style thing, why not `this.ratio_ || 0`?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "I think the stdlib's `net.IP` has a `Mask()` method, does that do what we need?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Why does substitute need to be public? Are we allowing/encouraging variable usage when using Daisy as a library?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "We should probably use ctrl-enter if `tab` is given, just like in `follow_selected`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This file looks like anti pattern `ServiceLocator` and lucky it's not used anywhere. Can I remove it? (in separate PR)." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "we can just have this method call the next, passing in the file metadatas (deduplication of logic)" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "What happens here if you send the `wheelEvent` directly to the `tabbed_browser` and let it take care of propagating it to its children (i.e. the focused tab)? If that works, I guess that'd be cleaner." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like _log_callback.", "reference": "it seems python 2 don't support `end=''`. @StrikerRUS @henry0312 any better solution? or we drop the support of python 2?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so it's a bug.", "reference": "This test already exists in the object_tracker layer." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Same here, can we presume if `privacyParameters` is set we need goQuorum handling? Or is there a goQuorum sub option in `privacyParametes`?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "The addition of delete files in `newManifests` far above the addition of data files threw me a bit. Is it intentional to ensure the delete files are at the front of the list?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Interesting. The call to `Array(groups)` below this would seem to indicate this doesn't _have_ to be an array. I think the problem is actually that passing a hash to `Array()` actually converts the hash to an array of key/value pairs rather than wrapping it in an array. So maybe `Array(groups)` should be `groups = [groups] unless groups.is_a?(Array)`." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "This is not a particularly good default but we need it to keep the old behavior." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "We have other tests to assert all properties of a condition are valid. It's enough to assert the condition is not nil here." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "shouldn't the import be renamed `crdv1alpha1` by convention? It seems that you took care of renaming everywhere else..." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "nit: Can Linux-specific paths be moved to a conditionally-compiled file for Linux?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here, so I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "This is not the right approach. The `Distributor` maintains a model of the current state of the Grid. That model already contains the information about every active session. We don't need to modify `SessionMap` to expose it further." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure.", "reference": "Git doc seems to suggest `for-push` is a optimization. Do we have a plan/ticket for treating them differently?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "This not necessary since you moved the layers to `contrib/`." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I think this also needs to be removed from `resources/bolt_bash_completion.sh`, `rakelib/pwsh.rake`, `lib/bolt_spec/plans.rb`, and `lib/bolt/config/options.rb`." }, { "prediction": "I18n.t('password_resets.create.success') I18n.t('password_resets.create.success') I18n.t('password_resets.create.success') I18n.t('password_resets.create.success') I18n.t('password_resets.create.success') I18n.t('password_resets.create.success') I18n.t('password_resets.create.success') I18n.t('password_resets.create.success') I18n.t('password_resets.create.success') I18n.t('password_resets.create.success') I18n.t('password_resets.create.success') I18n.t('password_resets.create.success') I18n.t('password_resets.create.success') I18n.t('password_resets.create.success') I18n.t('password_resets.create.success') I18n.t('password_resets.create.success') I18n.t('password_resets.create.success')", "reference": "I fixed this today with a direct push to master. My build was failing otherwise." }, { "prediction": "I think this is a bug, but it's not a bug.", "reference": "not sure why this is in a \"rule\" child package from the interface..." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Not needed, please remove." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "Shouldn't the logic be: * the result is a mismatch if either is a unix path but the other is not * if both are unix paths, then perform case-sensitive comparison * if both are not unix paths, then perform case-insensitive comparison" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do. I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "This is just rearranging it alphabetically" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "I think this disables it for the rest of the file - you should be able to use it inside of the function instead." }, { "prediction": "@ -61,9 +61,9 @ @ final class MediaExtension extends AbstractExtension { /** * @param MediaInterface $media - * @param string $format - * @param array $options + * @param MediaInterface|int|string $media + * @param string $format + * @param array $options * * @return string */ }", "reference": "this could receive the MediaInterface directly or an identifier, it is correct to type it with int|string? or just use mixed?" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug.", "reference": "Why not return `Object[]`?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Looks like we are trying to match the new ordering of fields in `ManifestFile`. Earlier, we co-located `...FilesCount` with `...RowsCount` to match the ordering of methods in `ManifestFile` and args in constructors. Is this change intentional?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug. I'm not sure if this is a bug, but I'm not sure if it's a bug.", "reference": "You're already setting drop loot to false just above." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "`once` is very generic and doesn't specify it's purpose - `closeOnce`?" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Why did this need to change from `private`? Oh for the test below. And this is only a test class too." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Should test the `has?` method here" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "I think you want to be asserting/clicking $saveLink, not $link." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "We don't have `target_name` on `@sensor` - why introduce it for `@asset_sensor`? If we do want to introduce it everywhere, can we just call it `job_name` to avoid introducing a new term?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "Missing copyright header (+other new files)." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "Could we do the flag check here as well to check whether or not we have enabled the \"Handle without timezone\" flag here as well? We may be using this not on the read path (like in the migrate/snapshot code) and it would be good to catch it here as well and make sure users know what is happening." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "why is the file named `pipeline_definition_definition_sensor`?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "None not needed, can just be `return`. not important for this release" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I think it's missing closing `

    ` tags in line 108 and 109 unless they don't matter..." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but it's what we're looking for.", "reference": "So it seems that loading a script file from the classpath needs to be enabled explicitly now since this is `false` by default. Is it possible to enable this via the YAML config file in a Camunda Platform Run distribution?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "can we delete any code in the provider implementation? i imagine the entire thing is unused now?" }, { "prediction": "This function is not used anymore. Instead, it should be used instead.", "reference": "I suggest we remove all these unused functions. I don't expect any external projects to be importing packages from `cert-manager/test/...`" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "Looks like the template argument doesn't resolve by default so you need `std::lock_guard lck`" }, { "prediction": "@Generated(\"com.github.javaparser.generator.core.node.GetNodeListsGenerator\") public List> getNodeLists() { return Arrays.asList(getAnnotations()); } - @Generated(\"com.github.javaparser.generator.core.node.GetNodeListsGenerator\") public List> getNodeLists() { return Arrays.asList(getAnnotations()); } - @Generated(\"com.github.javaparser.generator.core.node.RemoveMethodGenerator\") public ArrayCreationLevel removeDimension() { return setDimension((Expression) null); }", "reference": "Are we removing this public method? Could it be useful to someone? Maybe we could implement it once in Node using the metamodel" }, { "prediction": "I think this is what you're looking for.", "reference": "I think this method is unused now?" }, { "prediction": "I'm not sure if this is a bug, but I think it should be fixed.", "reference": "I know we discussed this before and decided to reuse the AntreaPolicy gate. But do you think realization status will introduce much overhead or not?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so it's a bug.", "reference": "please add a blank line at the end of this file. Applicable to similar cases below" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "This is not really needed, the line added in `GridNodeConfiguration.java` is what really fixes the `remoteHost` regression." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "filterCache can be null" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "If strstr returns NULL, the check on 378 won't fire, because param_name will be at least SET_PARAM_CMD_LEN." }, { "prediction": "I'm not sure if this is a bug, but if it is, it should be a bug, and if it's a bug, it should be a bug.", "reference": "Does this change affect the performance of other algorithms, except KMeans?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "What do these changes have to do with the request ID?" }, { "prediction": "I'm not sure if I'm correct, but if I'm correct, I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "I'm kind of surprised this doesn't require `typename`?" }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do this from a different package. I'm not sure what you're trying to do here, but it seems like you're trying to do this from a different package. I'm not sure what you're trying to do here, but it seems like you're trying to do this from a different package. I'm not sure what you're trying to do here.", "reference": "nit: move this one down." }, { "prediction": "The BoxWhisker is a box whisker. The box whiskers follow the box whiskers. The box whiskers follow the box whiskers. The box whiskers follow the box whiskers. The box whiskers follow the box whiskers. The box whiskers follow the box whiskers. The box whiskers follow the box whiskers. The box whiskers follow the box whiskers. The box whiskers follow the box whiskers. The box whiskers follow the box whiskers. The box whiskers follow the box whiskers. The box whiskers follow the box whiskers. The box whiskers follow the box whiskers. The box whiskers follow the box whiskers. The box whiskers follow the Tukey boxplot definition + representing the lowest datum still within 1.5 IQR of the lower + quartile, and the highest datum still within 1.5 IQR of the upper + quartile. Any points falling outside this range are shown as + distinct outlier points. The box whiskers follow the box whiskers. The box whiskers follow the box whiskers.", "reference": "maybe'standard Tukey boxplot definition' if it is standard? Otherwise sounds like it is just *a* definition for boxplots..." }, { "prediction": "I'm not sure if it's a bug, but it's a bug in the git-scm.com repo. I'm not sure if it's a bug, but it's a bug in the git-scm.com repo. I'm not sure if it's a bug, but it's a bug in the git-scm.com repo, so I'm not sure if it's a bug.", "reference": "I feel we should not fix this." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm wrong, or if I'm wrong, or if I'm wrong, I'm wrong.", "reference": "I think these are not necessary" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Please update the user guide too." }, { "prediction": "I'm not sure if this is what you're looking for, but if it's what you're looking for, it's probably what you're looking for.", "reference": "If you use `compact('name', 'code')` here, you'll get an associative array, which might make the rest of the code more readable (instead of using hard-coded 0/1 indexes)." }, { "prediction": "I'm not sure if this is the intended behavior, but I'm not sure if this is the intended behavior. I'm not sure if this is the intended behavior, but I'm not sure if it's the intended behavior.", "reference": "Should it be 2011-14 instead ;-)" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "I want to write some type of test for this but there are not Getter methods to assert this value. I tried to extract the value via the stats that are exposed without luck." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This needs to take the group id, not the gsuite id." }, { "prediction": "I'm not sure if this is what you're trying to do, but it's worth noting that this is what you're trying to do.", "reference": "These should use the constants defined in JsonTests.cs" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Kind of unrelated to this PR, but let's update this to `getDataErrorComponent('search-console', error.message, false, false, false, error )` so that everything is passed as expected." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": ":obj:\\`dataset\\` cannot be correctly rendered" }, { "prediction": "I'm not sure what you're trying to do here, but I think it's a good idea to use a user-displayable login/identifier for the user account. I'm not sure what you're trying to do here, but I think it's a good idea to use a user-displayable login/identifier for the user account. I'm not sure what you're trying to do here.", "reference": "I think `email` is something we get from devise, and I think the goal of putting it in the generator was not to tie others to that particular implementation?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "If the span producers pushing to the queue do so faster than the this can drain, it will cause this to hang. I'm guessing we can update the `enqueue` method to check if the `stopCh` is closed and not send any more spans while this flushes what has already been pushed." }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to add a gallery item to a collection. I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here, but it seems like you're trying to add a gallery item to a collection. I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Not sure about that, an array is iterable right? But if I pass array, that clear method wont work" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "make sure the config changes stuck. are there any invalid config values? maybe write tests around empty `trust_domain`, negative/missing `ttl`, invalid `key_size`, etc..." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "Why are you changing this?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "@phirefly Can we look at a list of RWAs, or ask someone to double-check that this format is correct? Otherwise :shipit:" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug.", "reference": "Still request a local sort for bin-packing based on the defined table sort order." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "As with the other PR, user name is better." }, { "prediction": "Is there a better way to do this?", "reference": "a peer's accounting lock is held during `Pay`. we should avoid adding additional blockchain calls here if possible." }, { "prediction": "I'm not sure if this is the correct way to do this, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Maybe wording could be improved. Is this \"not enabled\" or it is \"not available\". Not sure about that." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug. I'm not sure if this is a bug, but I think it's a bug.", "reference": "I looked at the new `conditionalBranchesEvaluated` function and it looks like the part added is a duplicate of the line above?" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "can you put this flag in `blockRefInfo` instead? It would be a shame to add one more file per block, especially since we've run into inode limits. I guess `blockRefInfo` should maybe then be renamed to `blockInfo` or something. But we're stuck with the filename." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Shouldn't we keep other parameters if only IP is empty? Or maybe return an error if it's a mandatory argument?" }, { "prediction": "I think this is what you're looking for. I'm not sure what you're looking for, but I think you're looking for something like this.", "reference": "Was this just wrong before? The names indicated types but type wasn't specified. I guess the tests passed as comparison worked with ``type=None``?" }, { "prediction": "I'm not sure if this is the case, but if it's the case, then it's the case.", "reference": "icebergCol.name() is the unqualified column name" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "It's generally a bad idea to use mutable types like lists as default values for parameters. Lots of strange, difficult to debug side effects can occur. I see that there was already one example of this prior to this commit which probably explains why it seemed innocuous to add more but I'm going to rework this before committing to master." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "We run prettier as an eslint plugin, so this harmful" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Check if the TypeDescriptor and MemberDescriptor includes are necessary" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for \"k8s.io/apimachinery/pkg/api/errors\" or \"k8s.io/apimachinery/pkg/api/core/v1\" or \"k8s.io/apimachinery/pkg/api/core/v1\" or \"k8s.io/apimachinery/pkg/api/core/v1\" or \"k8s.io/apimachinery/pkg/api/core/v1\" or \"k8s.io/apimachinery/pkg/api/core/v1\" or \"k8s.io/apimachinery/pkg/api/core/v1\" or \"k8s.io/apimachinery/pkg/api/core/v1\" or \"k8s.io/apimachinery/pkg/api/core/v1\" or \"k8s.io/apimachinery/pkg/api/core/v1\" or \"k8s.io/apimachinery/", "reference": "delete the empty line here." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Line is too long. [89/80]" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "You don't need to expose this method to do what you want. There are already public addNewGetMapping, addNewPostMapping, and addNewDeleteMapping methods." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "This test passes in `dev`. Why wouldn't this work?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "ARN -> Amazon Resource Number (ARN)" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Why not use the overload that takes an instance?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be fixed in the future.", "reference": "`Blockchian` is a misspelling of `Blockchain` (from `misspell`)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "`agent/gpu/nvidia_gpu_manager_unix.go:47: struct field lock has json tag but is not exported`" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "nit: better rename to `TEST_QUEUE_ARN` or `TEST_EVENT_SOURCE_ARN`" }, { "prediction": "I'm not sure if this is the case, but I think it's the case. I'm not sure if this is the case, but I'm not sure if it's the case.", "reference": "Would this mean that podMonitorSelectors suffer from the same issue if they are the only configuration set?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "`ctx` is unused in GetEnvironment" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like it's a bug.", "reference": "We usually use OkDialog()" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "could we please change that to something that indicates that this feature is not \"production\" ready!" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "swim -> swin. Other configs and file names also should be modified." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "nit: arg description for \"key\"?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug.", "reference": "If we don't have a `dir` yet, we wouldn't need to do a sync right? If so, perhaps we can just `getStoredDir()` like `Attr()`?" }, { "prediction": "should be ET_DYN instead of ET_DYN.", "reference": "I still don't seem to fully understand this. Why are we testing the host if DR_HOST_NOT_TARGET is not set?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "in the current implementation, both schemes are supported (you can call either `/bzz` or `/v1/bzz`). i would suggest to keep it this way" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "hmm, I think we can just do `new Error(assembly.error)` and that should set `error.message` correctly too. I don't know why it was done this way with a separate `.message` assignment before :sweat_smile: Should we do `error.assembly = assembly` so the template editor can access it that way, rather than parsing `error.details`?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "This should never be empty. The access field always needs a value of at least `c:0` or `r:0`" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Another question is, do we want to call `os.Getenv()` every time we parse a file? That seems a lot." }, { "prediction": "I'm not sure this is a bug, but it's a bug, so it's a bug.", "reference": "minor: please rename all occurrences of `A` to `T`. please also rename `v` to `value`." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it, so I'm not sure if this is the correct way to do it.", "reference": "Do we want it to be so dynamic? My first idea was to base it on SyncConfig.BeamSync." }, { "prediction": "@ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @", "reference": "can you change this instead to just `type.toString()` and then you wouldn't have to expose the getBitMask in the enum. (Alternatively you could have used `type.hashCode()` but that doesn't feel as nice)" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug. I'm not sure if this is a bug, but I'm not sure if it's a bug.", "reference": "I'm confused by these tests. Shouldn't the template string `@importance_type@` have been replaced with the actual value of `importance_type`?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Let's keep using NewKeeper so that it got covered by tests." }, { "prediction": "I'm not sure if this is a bug, or if it's a bug, or if it's a bug, or if it's a bug, we'll need to fix it.", "reference": "I only see new imports. Is there any functional change in this file?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "ineffectual assignment to `err` (from `ineffassign`)" }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to create a new driver instance. I'm not sure what you're trying to do here, but I'm guessing you're trying to create a new driver instance. I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`)" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed in the future.", "reference": "Make sure the old logging functions still work, but add deprecation warnings (unfortunately Python suppresses deprecation warnings by default, so I'm not sure if anyone'll notice)." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Not directly related to the topic of this ticket: I think this API design is a bit confusing. To disable delemetry, I would write `managementService.enableTelemetry(false)` which is not intuitive to read. Maybe `toggleTelemetry` instead of `enableTelemetry` is more clear." }, { "prediction": "I don't think it's a bug, but I think it's a bug.", "reference": "Again I suggest returning `AnnotatedCodeLocation[][]`." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "We should probably require an increased verbosity to output for anything below the cluster itself to avoid spamming the logs. It would also be good to give additional context as to what we are attempting to reconcile since the controller has multiple workers." }, { "prediction": "@ -32,5 +32,7 @@ type OptionsNetwork struct { EtherClientRPC string EtherPaymentsAddress string + EnableDNS bool + QualityOracle string }", "reference": "Not needed anymore" }, { "prediction": "I'm not sure if this is what you are looking for, but I think it should be something like this:", "reference": "Am I right in thinking this completely avoids the situation where `enable_calltarget_state_by_ref` is `true`, but the managed integrations don't expect a by ref argument? For example, if there's an exception here, that seems like a fatal problem, as we would have a mismatch for jit rewriting? We should disable instrumentation entirely in that case shouldn't we? i.e. if this (or the existing `EnableByRefInstrumentation`) calls fail, should we bail out of this method entirely as we can't safely instrument?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "nit: spaces seem off" }, { "prediction": "I don't think it's a bug, but it's a bug.", "reference": "shouldn't the em parameter be called ec?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Please change this to use o.DidSign(o) as implements this logic without performing any of these checks that duplicate something that JWT can do correctly. If the JWT deserialized properly, and DidSign returns true, the JWT was signed by one of the listed operator keys." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Talking about style, IMO extracting either `getComponent()` or `getPubDate()` to variables would make this line easier to read." }, { "prediction": "This file is distributed under the Apache License, Version 2.0 (the \"License\"). You may or may not use this file except in compliance with the License. A copy of the License is located at +// +// http://aws.amazon.com/apache2.0/ +// or in the \"license\" file accompanying this file. This file is distributed under the License, Version 2.0 (the \"License\"). You may not use this file except in compliance with the License. A copy of the License is located at +// +// http://aws.amazon.com/apache2.0/ +// or in the \"license\" file accompanying this file. This file is distributed under the License, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either +// or implied. See the License for the specific language governing +// permissions and limitations under the License.", "reference": "package header missing" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Just a thought (doesn't change the output or anything) - do you think we'll ever want to access the other properties of `oldVNode` from within `_childDidSuspend`? If so we could pass `oldVNode` here and then check these properties in the _childDidSuspend implementation. I don't have strong feelings either way, just occurred to me." }, { "prediction": "Doctrine\\ODM\\PHPCR\\Id\\RepositoryIdInterface is deprecated and will be removed in future versions of Doctrine\\ODM\\PHPCR\\Id\\RepositoryIdInterface.", "reference": "We should be configuring the base paths somewhere.." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do this in the same way as you're trying to do it in the first place.", "reference": "May also need to test the normal functionality with min/max_sizes" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "We can remove this one. It's just a random one I got for free for testing." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "(maybe this should be MyDevice or just removed entirely?)" }, { "prediction": "I think this is a bug. It should be fixed in the future.", "reference": "Can you do a nil check here, as the task isn't always nil here?" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "`lodash` shouldn't be grouped under WordPress dependencies" }, { "prediction": "@ -76,7 +76,11 @@ public class DiscoveryConfiguration { \"enode://011f758e6552d105183b1761c5e2dea0111bc20fd5f6422bc7f91e0fabbec9a6595caf6239b37feb773dddd3f87240d99d859431891e4a642cf2a0a9e6cbb98a@51.141.78.53:30303\", \"enode://176b9417f511d05b6b2cf3e34b756cf0a7096b3094572a8f6ef4cdcb9d1f9d00683bf0f83347eebdf3b81c3521c2332086d9592802230bf528eaf606a1d9677b@13.93.54.137:30303\", \"enode://46add44b9f13965f7b9875ac6b85f016f341012d84f975377573800a863526f4da19ae2c6", "reference": "Does order matter? Should we sort by enode key to make duplication checking easier?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Can you explain this too? This seems to go beyond linting." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "I just moved this into the render.js UT file since this test doesn't actually use an components" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "We do have to capture and check the err here right? I don't think we need to capture the location of the file though for this context." }, { "prediction": "import time import sys import logging from logging.handlers import RotatingFileHandler -import os from listenbrainz.listenstore import InfluxListenStore", "reference": "an unused import" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "If this value doesn't exist (do an `, ok :=...` check), we should initialize and store it" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Would use parenthesis to explicitly state the associations of operands ```js const MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER || (-(2 ** 53) - 1)" }, { "prediction": "We don't want to use a timeout here, but we don't want to use a timeout here, so we don't want to use a timeout here.", "reference": "This handle is now private to pyserial, but if there is no public function to retrieve it I guess this is the best we can do." }, { "prediction": "I'm not sure, but I'm not sure, but it seems to be a bug, so I'm not sure.", "reference": "This function is what **the compositor** calls when it wants to fullscreen a client, not what the client calls." }, { "prediction": "I'm not sure if this is a bug, but it's not a bug, but it's a bug.", "reference": "s/not existed Pod/non-existing Pod" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Why did we not leave this as just `svcDescriber`?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "nit: I think we've been (in)consistent in leaving a blank line here." }, { "prediction": "I think this is a bug. It should be fixed in the future.", "reference": "Maybe we can change it to a more generic name like source_id." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "What's the theory on why this could fix the hang? It seems like the call to `GetRootNodeForTest` will always need to call into the crypto object before returning an error, and so it should block on that `c` receive, after which the test immediately drains `errCh`. So I don't quite see how buffering would help..." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "Maybe add an assert in arch_init or somewhere?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "I wonder what does this `// nolint` ignore? And what are the standards that you choose which error to fix and which to ignore?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "what about the line below, forceUpdateCollection?" }, { "prediction": "I'm not sure if this will work, but I'm not sure if this will work, but I'm not sure if this will work.", "reference": "Doesn't this go in the opposite direction of #1051 / #1062 by putting platform-specific logic back into this module?" }, { "prediction": "We should really be using state management instead of state management.", "reference": "I think this is the only line in JS legacy code that should be updated based on the renaming. `global.googlesitekit.setup.isAuthenticated = response.authenticated;` would be sufficient to keep the old name for the legacy JS data (which will be phased out in the long term) while supporting the new name in the API route. All updates to the JS components above wouldn't be necessary." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Technically, this would allow `pingWaitTime` to be `false`. I don't know if it matters here." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if it's what you're trying to do. I'm not sure if it's what you're trying to do, but I'm guessing it's what you're trying to do.", "reference": "I only want the proxy request for this to run for kinesalite. So this just returns true if the KINESIS_PROVIDER is kinesis-mock" }, { "prediction": "This file is not part of the GNU General Public License, but it is part of the GNU General Public License.", "reference": "Please add your name to the list of copyright holders." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "Maybe maxRetryTimes should be bigger than 2. Return Max(maxRestryTime, 2)?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Call `userName` is good enough, `signedUserName` is narrowing the actual usage of this method." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "How would you feel about a static method to express intent?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Do we know for sure that no other code changed its value? (Maybe some weird testing use case or something) Why not just use the actual value instead of risk lying?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "the partInstall.go isn't an auto-generated file, and the part.sql doesn't exists either." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "`k` is unused in PutHash" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Use IOUtils instead" }, { "prediction": "I'm not sure what you're trying to do here, but I'm going to assume that you're trying to create a fake identity manager for testing purposes. I'm going to assume that you're trying to create a fake identity manager for testing purposes, so I'm going to assume that you're trying to create a fake identity manager for testing purposes, so I'm going to assume that you're trying to create a fake identity manager for testing purposes.", "reference": "It's not related to the line of code, but I don't know how to write it in a more proper place. Looks like `e2e/myst-provider/db/myst.db` should be in `.gitignore` file and should not be commited." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like \"goog:chromeOptions\" instead of \"goog:chromeOptions\"", "reference": "nice touch since Google likes to change things every now and then." }, { "prediction": "@ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @", "reference": "Make `CircuitBreakerManager` implement `PluginInfoInitialized`" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to convert a uint32 to a uint32? If so, you'll need to convert it to a uint32.", "reference": "This is extra awkward, QVariant.convert() takes a QMetaType which takes the value of a QMetaType.Type." }, { "prediction": "I think this is a bug in the driver.Writer. We need to make sure that the context is not set to nil before we create the writer.", "reference": "Nit: finished -> finish, \"done passing it\" -> \"passed it\"." }, { "prediction": "I think this is a bug in Paperclip's S3 API. I'm not sure if it's a bug, but I think it's a bug in Paperclip's S3 API.", "reference": "Maybe mention that it will be saved to the filesystem otherwise?" }, { "prediction": "I'm not sure if this is what you're looking for, but if it's what you're looking for, it's probably a bug.", "reference": "Probably cleaner and more general to do this: string,Format(\"Column {0}\", i+1) That way if the local language has a convention like \"3 column, this is\" it still works." }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "This can be uniformed too" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "It looks to me that this does not have to be exported." }, { "prediction": "I'm not sure if this is what you're trying to do, but it's what you're trying to do.", "reference": "It looks like this is only used in order to extract the snippet file names from GapicProviderFactory. I wonder if it would be better expose the snippet file names directly, without exposing a test-only function in non-test code." }, { "prediction": "public void toggleInputLevel(Long mdbId, long dsftId) { if (mdbId == null) { return; } if (dsftId == null) { return; } if (dsftId == null) { return; } if (dsftId.equals(dsftId)) { return; } if (dsftId.equals(dsftId)) { return; } if (dsftId.equals(dsftId)) { return; } if (dsftId.equals(dsftId)) { return; } if (dsftId.equals(dsftId)) { - for (DatasetFieldType dsftTest : mdb.getDatasetFieldTypes()) { - if (dsftTest.getId().equals(dsftId)) { - dsftTest.setRequiredDV(!dsftTest.isRequiredDV()); - } - } - } - } - } public void updateInclude(Long mdbId, long dsftId) { List childDSFT = new ArrayList<>(); for (DatasetFieldType dsftTest : mdb.getDatasetFieldTypes()) { if (dsftTest.getId().equals(dsftId) { childDS", "reference": "Another question: this is being removed, but I don't see a corresponding removal if it being called? Was it never used (or am I just missing it)? (is it related to what was in the onclick that got removed, i.e. was that supposed to call this and not something in the backing bean?)" }, { "prediction": "I'm not sure if this is what you're trying to do, but it should be something like this:", "reference": "Suggestion: `.. does not have an Approved condition set to true`" }, { "prediction": "I think this is what you are looking for, but I'm not sure what you're trying to do here.", "reference": "I would say that client class should have default of False and Cloud prov should enable deleting." }, { "prediction": "I'm not sure if this is the issue, but I'm not sure if this is the issue, but I'm not sure if it's the issue.", "reference": "Did this remove the BOM or something?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're trying to add a rule to a block header validation rule. I'm not sure if this is what you're looking for, but it seems like you're trying to add a rule to a block header validation rule. I'm not sure if this is what you're looking for, but it seems like you're trying to add a rule to a block header validation rule. I'm not sure if this is what you're looking for, but it seems like you're trying to add a rule to a block header validation rule.", "reference": "This makes the BlockHeaderValidator mutable, and IMHO should not be done. Note we have a builder that has the exact same method, so instead of mutating a produced BlockHeaderValidator we should hook into wherever the builder is being created." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to play a wave file from a different thread, so I'm guessing you're trying to play a wave file from a different thread. I'm guessing you're trying to play a wave file from a different thread, so I'm guessing you're trying to play a wave file from a different thread.", "reference": "May be add information about parameters to the doc string while at it?" }, { "prediction": "@ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @", "reference": "Naming of this sounds a bit awkward. Perhaps priv_legacy_getTransactionCount or priv_legacyGetTransactionCount?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "This one should probably be added to the list in #24. It's possibly indicative of an issue, but there isn't a VUID for it." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do this in the wrong way.", "reference": "Why this indentation change? Seems the original indentation would be fine, and leaves more room." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Would be nice to know what the `update` argument does in the docstring." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a good idea.", "reference": "I think we can just use `io.BytesIO` here." }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "This ensures that the User-Agent header matches during replay." }, { "prediction": "I'm not sure if this is the case, but if it's the case, then it's the case.", "reference": "What units are used for this default?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "I am wondering if it makes sense to make this a flag to `flatc` rather than a preprocessor flag, since this is generated code, it would make more sense to simply omit this code completely if the flag is not specified" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Doesn't this change the behavior (edit: oh, I see, never mind)." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "I think you need a `do` at the end of this line." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Not passing in a `:params` key here." }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "Feels like this should be an option and not the default. Leaving them running would give you immediate response to claims, which might be what some people would want. Hibernation is AWS only right now and probably other clouds will just disregard the setting but arguably validation should be rejecting attempts to create / update powerstate on gcp/azure/etc. I'd pitch we put this onto the pool spec and make you opt in." }, { "prediction": "It seems like _OR_GREATER is not supported yet in all environments.", "reference": "I think I saw somewhere that it has been fixed and that you can use #NETCOREAPP3_0_OR_GREATER but I may be wrong." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if this is the case, but if it is the case, it is the case, and if it is the case, it is the case, and if it is the case, it is the case, and if it is the case, it is the case, it is the case.", "reference": "what's the second part for?" }, { "prediction": "@Test public void testOnlyMorePopularWithExtendedResults() throws Exception { assertQ(req(\"q\", \"teststop:fox\", \"qt\", \"/spellCheckCompRH\", SpellCheckComponent.COMPONENT_NAME, \"true\", SpellingParams.SPELLCHECK_DICT, \"direct\", SpellingParams.SPELLCHECK_EXTENDED_RESULTS, \"true\", SpellingParams.SPELLCHECK_ONLY_MORE_POPULAR, \"true\", SpellingParams.SPELLCHECK_ONLY_MORE_POPULAR, \"true\", SpellingParams.SPELLCHECK_ONLY_MORE_POPULAR, \"true\", SpellingParams.SPELLCHECK_ONLY_MORE_POPULAR, \"true\", SpellingParams.SPELLCHECK_ONLY_MORE_POPULAR, \"true\", SpellingParams.SPELLCHECK_ONLY_MORE_POPULAR, \"true\", SpellingParams.SPELLCHECK_ONLY_MORE_POPULAR, \"true\", SpellingParams.SPELLCHECK_ONLY_MORE_POPULAR, \"true\", SpellingParams.SPELLCHECK_ONLY_MORE_POPULAR, \"true\", SpellingParams.SPELLCHECK_ONLY_MORE", "reference": "It's not clear to me what the \"super\" test above is for. As far as I can see, the test runs a spellcheck for \"super\" but then uses \"fob\" as the index into suggestions, which will never find an entry." }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I'm sure it's a bug.", "reference": "revert this file change" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "I think this is the most elegant way to allow us to still fail on `I`." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Wouldn't it be better to use a sql `IN ( :exact_value )`?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "So far this is not working as expected... working to further investigate WinRM protocol and the gems behavior." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "So now there're two ways to get requests: `ScenarioExecutor.get_requests()` and `Scenario.get_requests()`. To avoid confusion we should probably make `Scenario.get_requests()` method private, or hide it in some other way." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "This existed already, but seeing as you are changing the variable to have an explicit type it could be made a const reference to remove a copy." }, { "prediction": "I think this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "I don't think this code is being tested; this method can be removed without the test failing" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea to use AsyncTask instead of AsyncTask because AsyncTask doesn't have an AsyncTask in the AsyncTask constructor.", "reference": "@codepoet2017390 You have already initialized this ArrayList in the onPreExecute method then why do it here too?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "This covers the `RESTRICT_ACCESS=true` x non-gsa pair, but we probably want to test the three other permutations: (`RA=true`, gsa), (`RA=false`, non-gsa), (`RA=false`, gsa)" }, { "prediction": "I'm not sure if this is the correct way to do it, but it seems to be the correct way to do it.", "reference": "Please don't do this - if you want to disable code permanently delete the code, if you need to disable it to test don't commit. Such sections are very poorly highlighted during review and can cause unspotted issues slipping through the process..." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it is the correct way to do it.", "reference": "I'm starting too feel we have too much abstraction and too many interfaces here. But this method is definitely the most confusing IMO. For one, it's called \"Get*\" but it does not return anything... I don't have a good understanding of what's going on anymore, so it's hard for me to suggest an alternative, but it's pretty clear to me that this interface needs to be rethought. An interface where all the parameters are themselves arbitrary objects (`interface{}`), whose actual type depends on the specific interface implementation, is not a helpful abstraction" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "It fills me with endless sadness that we can't use Selenium's own `SessionId` here." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Interesting. So you've found that it's faster to request only the \"Stat\" without the data so long as this is the typical path?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Is this a future fix? I thought the local identifier scope and the package issue were the same one." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Not super important, but this line could be split up." }, { "prediction": "I don't think it's a bug, but I think it's a bug.", "reference": "Maybe we should better call the dispose function without checking the value of `item.data` (since the dispose function is setup before `data` is set up)." }, { "prediction": "I'm not sure if this is the case, but I think it's the case, so I'm not sure if it's the case, so I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "Why set to GPU, is it CPU?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if this is the correct way to do it.", "reference": "This should be `computed('i18n.locale'....`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "can we not expose the channel directly? or at least expose it as a read only channel?" }, { "prediction": "I think this is a bug, but it should be fixed.", "reference": "Can we add a `--with-bashcompdir` here to override this? I'd like to be able to do unprivileged builds." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug.", "reference": "We will be removing this maya/volume package completely. Do not use this." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here.", "reference": "Why you think that `model_ptr` will be `nullptr` when memory allocation is failed? I think `new daal_knn::Model(column_count)` would throw `std::bad_alloc` if `operator new` is not overloaded. Is it overloaded by DAAL in the way it simply returns `nullptr` in case of bad allocation?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do. I'm assuming you're trying to create a new file miner with sectors and sectors. I'm not sure what you're trying to do, so I'm not sure what you're trying to do. I'm assuming you're trying to create a new file miner with sectors and sectors. I'm assuming you're trying to create a new file miner with sectors and sectors. I'm assuming you're trying to create a new file miner with sectors and sectors. I'm assuming you're trying to create a new file miner with sectors and sectors. I'm not sure what you're trying to do here, so I'm not sure what you're trying to do", "reference": "Where does this 0.001 come from? Is this from the network collateral cost function, which happens to be hardcoded right now? I think it's going to rot very quickly: it depends on sector size and (probably) block height." }, { "prediction": "The CodeChecker Infrastructure +# This file is distributed under the University of Illinois Open Source License. See LICENSE.TXT for details.", "reference": "Please update the license header in each source file. For more information see: #2697" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "!numbers -> numbers" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "so we don't have universal rules afterwards? In that case I'd remove this entirely (and maybe some places where it's used get cleaner) since we shouldn't ever add a universal rule. Not only because it's way simpler in TS, I'm also just super skeptical about \"universal\". In case of this rule, even control characters may have their place in Swaggers, e.g. in `examples` sections where you can have raw response bodies where control characters are perfectly valid." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think this is what you're trying to do.", "reference": "You're welcome to surface this option through the API, but I'm not going to make this the default behavior." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Just a thought that any further extensions of `buildBinaryFor` signature could be done as `buildBinaryFor(..., opts... BuildOptions)` for better readability." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "I'll fix the InMemoryExporter right after this PR lands" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm guessing it's a bug.", "reference": "Good call, none of these are technically invalid" }, { "prediction": "If we're building for x64, then we're building for x86 too, so we're building for x64 too, so we're building for x64 too. We're building for x64 too, so we're building for x64 too. We're building for x64 too, so we're building for x64 too, so we're building for x64 too. We're building for x64 too. We're building for x64 too, so we're building for x64 too. We're building for x64 too. We're building for x64 too. We're building for x64 too. We're building for x64 too. We're building for x64 too. We're building for x64 too. We're building for x64 too. We're building for x64 too.", "reference": "this one should be updated too" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "maybe need to add microserviceId too." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, but I'm guessing you're looking for missing-param-doc and missing-type-doc for Numpy style docstrings +with accept-no-param-doc = no +\"\"\" +# pylint: disable=invalid-name, unused-argument, undefined-variable +# pylint: disable=line-too-long, too-few-public-methods, missing-class-docstring +# pylint: disable=missing-function-docstring, function-redefined, inconsistent-return-statements +# pylint: disable=missing-function-docstring, function-redefined, inconsistent-return-statements +# pylint: disable=missing-function-docstring, function-redefined, inconsistent-return-statements +# pylint: disable=missing-function-docstring, function-redefined, inconsistent-return-statements +# pylint: disable=function-redefined, inconsistent-return-statements +# pylint: disable=function-redefined, inconsistent-return-statements +# pylint: disable=function-redefined, inconsistent-return-statements +# pylint: disable=function-redefined", "reference": "I'm curious, do you create this commit at the very end by rebasing and taking the value you had after moving everything?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "It's no longer possible to use `modifyRow` to trim rows and that's ok to use TrimRows instead. But I think we should move this test to TrimRows plugin tests as `trimRows` setting is not a part of the `core`." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug.", "reference": "The function seems to either return \"default\" or return the extension stripping the preceding dot. Does the fact mean that we can no longer register `.default` as an extension?" }, { "prediction": "This is the command to run in the container which is specified in the task definition Command []string // CPU is the cpu limitation of the container which is specified in the task definition Command []string // CPU is the cpu limitation of the container which is specified in the task definition Command []string // CPU is the cpu limitation of the container which is specified in the task definition Command []string // CPU is the cpu limitation of the container which is specified in the task definition Command []string // CPU is the cpu limitation of the container which is specified in the task definition Command []string // CPU is the cpu limitation of the container which is specified in the task definition Command []string // CPU is the cpu limitation of the container which is specified in the task definition Command []string // CPU is the cpu limitation of the container which is specified in the task definition Command []string // CPU is the cpu limitation of the container which is specified in the task definition Command []string // CPU is the cpu limitation of the container which is specified in the task definition Command []string // CPU is the cpu limitation of the container which is specified in the task definition Command []string // CPU is the cpu limitation of the container which is specified in the task definition Command []string // CPU is the cpu limitation of the", "reference": "this may require a statefile version update" }, { "prediction": "This is deprecated and will be removed in the next major. Use SplFileObject::fgetcsv() instead. This is deprecated and will be removed in the next major. Use SplFileObject::fgetcsv() instead.", "reference": "I like when `@deprecated` contains how to resolve it - eg. \"use `SplFileObject::fgetcsv()` instead\". The information in upgrade notes is usefull only during upgrade." }, { "prediction": "@golang.org/api/compute/v1\" - v1 \"google.golang.org/api/compute/v1\" - v10 \"google.golang.org/api/dns/v1\" - v10 \"google.golang.org/api/compute/v1\" - v10 \"google.golang.org/api/dns/v1\" - v10 \"google.golang.org/api/compute/v1\" - v10 \"google.golang.org/api/dns/v1\" - v10 \"google.golang.org/api/compute/v1\" - v10 \"google.golang.org/api/dns/v1\" - v10 \"google.golang.org/api/compute/v1\" - v10 \"google.golang.org/api/dns/v1\" - v10 \"google.golang.org/api/compute/v1\" - v10 \"google.golang.org/api/dns/v1\" - v10 \"google.golang.org/api/compute/v1\" - v10 \"google.gol", "reference": "Nice to see that your local environment is up-to-date now for these changes." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug, but I think it's a bug.", "reference": "Instead of setting it to null, i think lets set it to {}" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "We should bump this before releasing and remove all legacy fields that are safe to do so. Since we cannot have multiple versions anyway there's little value in walking around with the \"alpha\" stamp." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "I might suggest a different name for the `DEEPBIND` config.h macro. Perhaps `FLUX_DEEPBIND` to give a hint in the code that we're using a locally provided define." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for, so I'm not sure if this is what you're looking for.", "reference": "Code generated by protoc-gen-go. **DO NOT EDIT.**. The correct way to fix `deprecated` in this file may be updating the protoc / protobuf / grpc and regenerate this file." }, { "prediction": "I'm not sure if this is what you want, but it's a good idea to have a class that extends AbstractNumericPropertyDescriptorTester { private static final int MIN = 1; public IntegerPropertyTest() { super(IntegerPropertyTest.class); this.MIN = MIN; } }", "reference": "We should make sure that we cover the testcases in a new unit test class." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Is this only used in test code? Is there future utility in it for production code? If not, it would be nice if this could be moved into a test package. I'm not sure how hard that would be. CC @laser" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "Super curious how you noticed this, as SPIRE itself currently only configures once...?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "This `startsWith` seems a bit brittle because in the code base we'll occasionally spell it \"DataFile\"." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "if it keeps reconnecting for too long, how should we get alerted?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "it's better to use single name style in one name." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so it's a bug.", "reference": "As defaultSendPort is being removed, and I don't like TODOs on examples, please remove the whole line" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Should we return `nil` when `err == errChangeSetEmpty` instead of calling l.103 `WaitUntilStackUpdateCompleteWithContext`?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm guessing it's what you're trying to do.", "reference": "Hmmm I thought spotless would wrap this line, but it doesn't seem to complain about it" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "I think this will require updating the api version. we are planning to do this anyways, so perhaps we can lump this in so we don't have to update too many times?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "revert this for parity" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for.", "reference": "INCR_BATCH and DECR_BATCH could be exposed as tuneable command line options but that might be too low level to expose. I think keeping private for now where \"in the know\" folks could use to try and tune makes sense. These values were choosen mostly \"at random\" and have worked out for us thus far." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Currently this isn't very clean because we have to re-use some of the predefined parser types - the demo uses WRITER_U_CTAGS but there should be some support for custom writer type." }, { "prediction": "I think this is a bug. It should be fixed in the future.", "reference": "I think this was left it accidentally :)" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but I think it's what you're looking for.", "reference": "Can you finish re-ordering this list to match the one that was deleted?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "Do we need to check if `exp.Target.StressChaos` is `nil`?" }, { "prediction": "I think this is what you're looking for: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/CreateAccessKey.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/CreateAccessKey.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/CreateAccessKey.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/CreateAccessKey.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/CreateAccessKey.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/CreateAccessKey.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/CreateAccessKey.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/CreateAccessKey.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/CreateAccessKey.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/CreateAccessKey.html https://docs.aws.amazon.com/AWSEC2/latest", "reference": "AWS Identity and Access Management (IAM)" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "not calling this is going to impact current functionality which depends on PVC.. let us still call this and set the values to default as 'none' (or empty) by handling the error from 'get' operation" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "`!=` is no the same as `<`" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for, but I'm guessing it's what you're looking for.", "reference": "No need to create a dir for transformer. Simply move transformer.py into mmdet/models/utils/" }, { "prediction": "I'm not sure if this is the correct way to handle the intent, but if it is the correct way to handle the intent, I'm not sure if it's the correct way to handle the intent, but if it's the correct way to handle the intent, I'm not sure if it's the correct way to handle the intent, so I'm not sure if it's the correct way to handle it.", "reference": "Can't you just add `SelectSubscriptionActivity` directly to the manifest instead of opening `MainActivity` that then starts it?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Maybe say \"the spec's %check section\" so it's clearer what we mean." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I think after change this check `rowInMapper === null` is always false, so it's useless." }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "ClockIpLpi2c4.Enable() is required. The same change is required for enablePeripheralClocks()." }, { "prediction": "` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "nit: this should be `SHA` since it is an acronym for `Secure Hash Algorithm`, no?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "Not sure if Intl can be defined but not `Intl.DateTimeFormat`. Both seem to have the same percentage on CanIUse." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug.", "reference": "PTAL, looks like the order of PVC & PV is reversed for different storage-engine types, for Jiva/CStor the args sent to sendEventOrIgnore are `PV, PVCName`." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "Remove the trailing white space" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "No need to modify this." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "would be nice at some point to clean this signature up... not relevant for this PR" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Here, is it `null` because it is `null` in `$fieldConfiguration`, or because it has been set to `null` above in the `array_replace`? If it doesn't exists at all in `$fieldConfiguration`, I think you should add `type => 'text'` above in the `array_replace`." }, { "prediction": "It's not possible to find a type in a class that has a name. It's not possible to find a type in a class that does not have a name.", "reference": "I was thinking about this for #2928 too, which also uses `endsWith`... Presumably `SomeOtherObject` would match `endsWith(\"Object\")`, meaning that something more sophisticated like splitting it then iterating right to left would be needed in order to do this robustly?" }, { "prediction": "I'm not sure if this is what you're trying to do, but if this is what you're trying to do, then you'll need to change it to something that's not what you're trying to do.", "reference": "I think this name is a bit confusing because if you asked someone what type of exporter they were using they would probably say Zipkin or Jaeger, etc. How about `ProcessorType` with `Simple` and `Batch` definitions?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "`req` is unused in RecreatePipedKey" }, { "prediction": "I'm not sure what you\u2019re trying to do here, but I'm not sure what you\u2019re trying to do here.", "reference": "The \"Adsense\" term needs to be capitalized - I just noticed this was wrong through ACs and IB, so not a problem of the PR itself really. I'll quickly fix it." }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "do which methods need to be registered? is it basically just the ones that are directly referenced in ParDo calls? (The Beam GoDoc doesn't say anything about it. :/ )" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "@bmckinney does this mean that the bibtex citation will be available via API?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for the 'cliquet[postgresql]>=2.14,<3' + 'cliquet[postgresql]>=2.15,<3' part. If you're looking for the 'cliquet[monitoring]>=2.14,<3' + 'cliquet[monitoring]>=2.15,<3' part, you'll need to add the 'cliquet[monitoring]>=2.14,<3' + 'cliquet[monitoring]>=2.15,<3' part to the 'cliquet[monitoring]>=2.15,<3' part of the 'cliquet[monitoring]>=2.15,<3' part of the 'cliquet[monitoring]>=2.15,<3' part of the 'cliquet[monitoring]>=2.15,<3' part of the 'cliquet[monitoring]>=2.15,<3' part of the 'cliquet[monitoring]>=2.15,<3' part of the 'cliquet[monitoring]>=2.15,<3' part of the 'cliquet[monitoring]>=2.15,<3' part of the 'cliquet[monitoring]>=2.15,<3' part of the 'cli", "reference": "We should probably tag the cliquet-fxa version as well." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here. I'm not sure what you're trying to do here.", "reference": "IIRC we need to use memset, because an empty brace is not C99 comformant, and because we cannot use `{0}` because how the struct is organized is not defined in POSIX (the initializer cannot be `{0}` if the first property of the struct is a struct)." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "Will we be adding this to `AppliedTo` as well? If not, any reason why not?" }, { "prediction": "Is there a way to force this to take focus? I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case.", "reference": "Just a note that this feels weird being on the base NVDAObject rather than IAccessible, but right now, I understand that's how it has to be because we fire MSAA caret events on the focus object regardless of whether it's IAccessible. I think we should consider restricting these caret events to focus objects that are IAccessible subclasses in future, but that change is probably too risky for this PR. CC @MichaelDCurran for his thoughts." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "This change and other similar ones should not be part of this commit. This commit is about adding a ImageUploadType not fixing controllers and stuff." }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "I am a bit confused about PING here. Ping is implied and it overlaps with \"$SYS.REQ.ACCOUNT.%s.%s\" where the last token is what is requested (CONNZ) and the one before is the requested account id." }, { "prediction": "I'm not sure if this is the case, but if it is the case, it's probably the case.", "reference": "nit: use the OptSubFolder constants. Also in the client you are using \"maxdepth\" but in the server the constant for \"depth\" is being used." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I also moved this to `/verdaccio/storage` since it's written in runtime, and the approach here is to make the configuration by default read-only." }, { "prediction": "I'm not sure if this is the case, but if it's the case, it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "nit: s/has cancel method/has a cancel method" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Useless assignment to variable - `second_quiz`. Use `_` or `_second_quiz` as a variable name to indicate that it won't be used." }, { "prediction": "I'm not sure what you're trying to do here, but I'm assuming you're using a gzip writer, and that you're using a gzip writer, so I'm not sure what you're trying to do here. I'm assuming you're using a gzip writer, so I'm not sure what you're trying to do here. I'm assuming you're using a gzip writer, but I'm not sure what you're trying to do here. I'm assuming you're using a gzip writer, so I'm not sure what you're trying to do here. I'm assuming you're using a gzip writer, so I'm not sure what you're trying to do here.", "reference": "Is this still needed since there's the `GzipPrecompressed` type?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "this is spelled wrong and also not used so remove it" }, { "prediction": "This is not a bug, it's a bug, but it's a bug.", "reference": "It might be right here that's the issue ^" }, { "prediction": "This map's key-comparator is deprecated. It's now deprecated. It's now deprecated. It's now deprecated. It's now deprecated. It's now deprecated. It's now deprecated. It's now deprecated. It's now deprecated. It's now deprecated. It's now deprecated. It's now deprecated. It's now deprecated. It's now deprecated. It's now deprecated. It's now deprecated. It's now deprecated. It's now deprecated.", "reference": "@danieldietrich let's leave existing extension. Here we just mark `keyComparator()` with `@Deprecated` annotation" }, { "prediction": "I'm not sure what you're trying to do here, but I'm assuming you're trying to do something like this:", "reference": "This breaks CI. I am not sure why you need to include io.h in this file especially on linux." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "this seems equivalent" }, { "prediction": "I think this is a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's fixed.", "reference": "change size to 50MB criticial, 10MB warn... change count to 50k critical, 5k warn..." }, { "prediction": "I'm not sure if this is what you're looking for, but if it's what you're looking for, then it's probably a bug.", "reference": "This has nothing to do with master/slave replication. Is this something we want to change too? If so, I guess this is an aggregation?" }, { "prediction": "We don't need to use ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Maybe it makes sense to mention that those zombies are not forever, but only up to the moment when the parent process exits? Is that correct according to your observations, @benoittgt? Please disregard this note if zombies remain after." }, { "prediction": "I think this is a bug, but it is a bug, and it is a bug.", "reference": "moto mock setup needs to happen before boto usage." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "`hasattr(cb, 'first_metric_only') and cb.first_metric_only` -> `getattr(cb, 'first_metric_only', False)`" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "no newline for function" }, { "prediction": "I'm not sure if this is a bug or a bug, but it seems to be a bug.", "reference": "This makes me feel icky. We could also go the route of making `wlr_output.scale` a double instead of a float, but that would be a more widely reaching change." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Again, would be awesome if you could remove the tabs in these 3-4 lines as well." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "You're moving multiple times from `step.name`; you're not allowed to do that. Instead you have to copy the `step.name` string and (if you want to) move once at the very last." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if it's what you're trying to do, so I'm not sure if it's what you're trying to do.", "reference": "What about `may not end`? @jancborchardt" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "If you think about it, the status should be PermissionDenied?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Calculation looks good but don't know what format etc grafana expects this to be in." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think you're trying to run a container with a different name, so I'm not sure if this is what you're trying to do. If you're trying to run a container with a different name, you'll want to run a container with a different name, so I'm not sure if this is what you're trying to do. If you're trying to run a container with a different name, you'll want to run a container with a different name, so I'm not sure if this is what you're trying to do.", "reference": "nit: We could use the `to_str(..)` util here. (let's not bother changing for this PR.. )" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Can you rename alias to `executiongenpb`. The rule is package+\"pb\" for `temporal-proto` and package+\"genpb\" for server protos." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Any noticeable performance hit? Any other way to avoid the allocation and copy even of the array?" }, { "prediction": "I don't know if this is a bug, but it's a bug.", "reference": "What if you remove this line entirely from here?" }, { "prediction": "I'm not sure why you're getting this error, but I'm not sure why you're getting this error, but I'm not sure why you're getting this error, but I'm not sure why you're getting this error, so I'm not sure why you're getting this error, but I'm not sure why you're getting this error.", "reference": "`on_lateral` can also be implemented" }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "Please add a space between `if` and `(`." }, { "prediction": "I'm not sure if this is what you're looking for, but it's probably what you're looking for. I'm not sure if this is what you're looking for, but it's probably what you're looking for.", "reference": "This statuses might have been better off with some custom status type. However, good for now." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or", "reference": "Thanks for catching the bug. Here your change lets `v4IPNet` and `v6IPNet` take the first IPv4/IPv6 address in `addrList`. Maybe choose the last one also works and makes code simpler? What's your idea? @tnqn" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do, so I'm not sure if it's what you're trying to do.", "reference": "nitpick: you can name this variable just `details`" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "The character class in the regex should probably be \"[a-zA-Z0-9_]\"." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Please also increment `Settings.VERSION` and update `AccountSettings`." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "I think this should just say \"build \". And when builddate wasn't set, e.g. somebody built weave with 'go build' or some other way, this should return \"unknown\"." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Can we move this into a separate var and call it `desc` like below?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "why RpcSchema need this annotations?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Not sure it makes sense to send the reply if we did not delete from the map, but I guess it does not hurt.." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Most of these variables can be moved after `return` or to the body of `if` statement." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, or if it's the case, or if it's the case, or if it's the case, it's the case, or if it's the case, or if it's the case, or if it's the case, it's the case.", "reference": "nit: Is this actually just a http \"unauthorised\" response? Or is that too vague? If this is the right way to go... is \"token\" the right word\" Or do we want to say something else?" }, { "prediction": "I don't think this is a bug, but it's a bug in Bolt::PuppetDB::Config.load_config(nil, config.puppetdb, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.path, config.boltdir.", "reference": "We check for `$future` in PuppetDB::Config, so this won't change behavior if you don't have `future` set." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I think you should remove `if isinstance(by, str):`,. We also should fix the error message `raise ValueError('Not a valid index: TODO')` to match with pandas'" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case.", "reference": "Curious - do we want this to be `OTel.GrpcHandler.Request`? For example, if someone is debugging a crash dump, they would get some hint that it was added by OpenTelemetry." }, { "prediction": "This is important because it is important to ensure that the commit is successful to avoid overwriting updates. It is important to ensure that the commit is successful to avoid overwriting updates. It is also important to ensure that the commit is successful to avoid overwriting updates. It is important to ensure that the commit is successful to avoid overwriting updates. It is also important to ensure that the commit is successful to avoid overwriting updates.", "reference": "nit: unnecessary `

    `" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Should just be `#ifdef ADIOS2_HAVE_HDF5`" }, { "prediction": "I'm not sure if you're using a lambda function or a lambda function. If you're using a lambda function, you'll want to use a lambda function instead. If you're using a lambda function, you'll want to use a lambda function instead.", "reference": "FYI: I deployed a stack with multiple lengths for the stack name and resource id to cloudformation, to see how it truncates the parts for the final FunctionName" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Did we not use this field @_@" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "shouldn't this be `android_keystore_name`?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if", "reference": "Double check the issuers package too :)" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "This is out of date right? Now that `_is_first_level_self_reference` uses it as well? Perhaps we should make the docstring more general and not refer to method names that could change." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "This test alone takes around 10-12 minutes to run. It has 20 subtests each of which takes around one minute. We should see if we there are redundant subtests that we can remove, or look for a way to optimize them." }, { "prediction": "I think this is a bug, but I'm not sure if it's a bug, so I'm not sure.", "reference": "Good call, we need to keep that check :+1:" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Should the interface have 2 `ParseHeaders` methods?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case.", "reference": "Nit: Does this make more sense as `iceberg.hive.metadata...`? The rest of the configs seem to start with `iceberg.hive`." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I'm not sure if it's the correct way to do it. I'm not sure if it's the correct way to do it, but I'm not sure if it's the correct way to do it. I'm not sure if it's the correct way to do it, but I'm not sure if it's the correct way to do it. I'm not sure if it's the correct way to do it, but I'm not sure if it's the correct way to do it. I'm not sure if it's the correct way to do it, but I'm not sure if it's the correct way to do it. I'm not sure if it's the correct way to do it. I'm not sure if it's the correct way to do it, but I'm not sure if it's the correct way to do it. I'm not sure if it's the correct way to do", "reference": "Is `baseURL` not required?" }, { "prediction": "I'm not sure what you want to do here, but I think you want something like this:", "reference": "Just delete it, `embedding_rpn_head` is not a `Detector` which should have `show_result`." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "Where do we _get_ tag values? edit: I mean, where are these `GetFoo()` methods called from? It just seems weird to me that we are getting tag values from spans. I thought we only ever _set_ tags on spans." }, { "prediction": "Why not just use `Reader` instead of `Reader`? Why not just use `Reader` instead of `Reader`?", "reference": "This seems like log spam. Maybe expose the encoding as a method and log at the point of interest?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "I looked up that one, and it seems correct: Authentification is French, Authentication seems to be correct" }, { "prediction": "I'm not sure if this is a bug, but it's a bug in nupic, so I'm not sure if it's a bug in nupic, but it's a bug in nupic, so I'm not sure if it's a bug in nupic, or if it's a bug in nupic, or if it's a bug in nupic, or if it's a bug in nupic, or if it's a bug in nupic, or if it's a bug in nupic, or if it's a bug in nupic, or if it's a bug in nupic, or if it's a bug in nupic, or if it's a bug in nupic, or if it's a bug in nupic, or if it's a bug in nupic, or if it's a bug in nupic, or if it's a bug in nupic, or if it's a bug in nupic, or if it's a bug in nupic, it's a bug in nup", "reference": "Can we print a more human-friendly warning here, saying that plotting won't work or something along those lines?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do this in a different way. I'm guessing you're trying to do this in a different way, but I'm guessing you're trying to do this in a different way.", "reference": "@mhils didn't we try to get rid of these (now empty) wrapper classes?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for \"github.com/sirupsen/logrus\" + \"github.com/projectcalico/libcalico-go/lib/set\" \"github.com/projectcalico/libcalico-go/lib/set\" \"github.com/projectcalico/libcalico-go/lib/set\" \"github.com/projectcalico/libcalico-go/lib/set\" \"github.com/projectcalico/libcalico-go/lib/set\" \"github.com/projectcalico/libcalico-go/lib/set\" \"github.com/projectcalico/libcalico-go/lib/set\" \"github.com/projectcalico/libcalico-go/lib/set\" \"github.com/projectcalico/libcalico-go/lib/set\" \"github.com/projectcalico/libcalico-go/lib/set\" \"github.com/projectcalico/libcalico-go/lib/set\" \"github.com/projectcal", "reference": "I would avoid importing `felix/ipsets` package because this package is the windows equivalent and should be at the same level of `felix/ipsets`. We could add linux specific dependencies into `felix/ipsets` later and it will break Windows build." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Maybe, `import` would be a better name." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "Wouldn't we want `PARAMETER_MAX_RESULTS` in here as well? (I might be miunderstanding how this is used)" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "We can re-use the config in our tests." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "Wouldn't we have the same issue with the internal libevent? IIRC, the integration is pretty close to an exact duplicate. Or does the libevent m4 code already take that into account when setting this variable? PMIx _requires_ libevent, so it isn't like pmix_libevent_support can be anything other than 1. I'm okay with leaving this question for separate resolution - just wondering why we don't have the same issue here." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "The actual User-Agent string uses \"CriOS\" not \"CRiOS\"" }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if it's the correct way to do it, but I think it's the correct way to do it.", "reference": "Unused code deletion. Is that a desired thing? No implementation of this actually used this indexer, so removing it seemed reasonable (and was suggested by the compiler). Maybe this had an indexer so plugins could use it? This change is definitely pushing the limits of what is appropriate in a \"cleanup\" as it is changing public API surface area." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "We'd lose the data here from the original teardown_exception and only get the dump_exception - I fear that that could make the actual error difficult to track if it cascades." }, { "prediction": "I think this is a bug, but it should be fixed in the future.", "reference": "At this point in `diff()` we should know if we're dealing with a `component` or a native `html` element. We can reuse that information in this if-statement here :+1:" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, it's a bug.", "reference": "somewhere in reward protocol, we need to do if epoch is Fairbank { a.foundationBonusP2StartEpoch = genesis.xxx a.foundationBonusP2EndEpoch = genesis.yyy p.state(sm, adminKey, &a) } that is to write the 2 new values at Fairbank height then this logic can follow" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this.", "reference": "Dropping and recreating would delete all t he previous records, are they any important?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "While it is technically OK to use `m.GetPaths()` here, and it's a mock code so it doesn't really matter, I'd still like to have `m.Path(\"devices\")` used here, because since commit 714c91e9f73a1512808476eb532b4aa36bbb7530 we're not supposed to use GetPaths() for anything other than state save/restore." }, { "prediction": "We will need the veritysetup package (and its dependencies) to manage the verity disk. We will need to add it to the systemConfig.HidepidDisable. We will also need to add it to the systemConfig.ReadOnlyVerityRoot.Enable. We will also need to add it to the systemConfig.ReadOnlyVerityRoot.Enable. We will need to add it to the systemConfig.ReadOnlyVerityRoot.Disable.Enable. We will need to add it to the systemConfig.ReadOnlyVerityRoot.Enable.Enable. We will need to add it to the systemConfig.ReadOnlyVerityRoot.Enable.Enable. We will need to add it to the systemConfig.ReadOnlyVerityRoot.Enable.Enable. We will need to add it to the systemConfig.ReadOnlyVerityRoot.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.Enable.", "reference": "Let's be consistent everywhere: either \"Disable\"/\"Enable\" or \"Disabled\"/\"Enabled\". I'm voting for the latter.:)" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug, so I'm not sure if it's a bug.", "reference": "this works and is the smallest possible change but we could definitely fail earlier" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Should not have snuck in here right? This is a golang 1.17 feature, wii definitely want to update these" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Could you explain the logic with prevFolderId?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Please add license header" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "It bothers me that the user calls `initialize` without also calling `finalize`. It seems to me that we're essentially making `lbann_comm` a singleton object. Going further down this path, we would put `initialize` inside `lbann_comm`'s constructor and `finalize` in the destructor. This has it's own weirdness - the user must make sure it's lifespan matches the beginning and end of the program. We may also run into the case where someone might want multiple instances of `lbann_comm`, but this is not too important." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "We should probably make a unique_ptr typedef in ROMol.h and start using that liberally." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "Can you add missing asterisk?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "late to the party, but I bet it meant to be `capitalizeLettersAfterNumbers` :)" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "The Activity is recreated on configuration changes and the value of the field is lost. So, e.g. pressing'send' once will display the error message. If you rotate the device and press'send' again, the message will show another time. Use `onSaveInstanceState()` and `onRetainInstanceState()` to save and restore the value of the field." }, { "prediction": "I'm not sure if this is what you are looking for, but I think it's what you're looking for.", "reference": "Looks like a \"find and replace\" unintended change here" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this. I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this. I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here. I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "haven't we got rid off `randomSP` recently? (I think `not learn` implied that)" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Why we need use `in.GetStatus()` function here? Can we use `in.Status.xxxx` directly?" }, { "prediction": "This is not a bug, but it is a bug. It is a bug.", "reference": "@cretz Just a thought: what if another renewal process updates the certificate between the beginning of this for loop (above on line 67) and actually calling RenewCert? Even though we have a read lock on the certCache, something else could have renewed it by now, and finished, which would cause this certificate to be renewed twice. Could you double-check my thinking here and see if that's a plausible 'race' condition? I wonder if the lock needs to be put over this whole function. (It's still early here; I could be wrong...)" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "We don't need this for the PInvoke?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "nits, I think add a log (using s.logger) to show why does this return with no error is better." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do. I'm not sure if this is what you're trying to do, but I think it's what you're trying to do. I'm not sure if this is what you're trying to do. I'm not sure if this is what you're trying to do, but I think it's what you're trying to do. I'm not sure if this is what you're trying to do, but I think it's what you're trying to do. I'm not sure if this is what you're trying to do, but I'm assuming it's what you're trying to do.", "reference": "Btw, It would be nice if we have some tests for those validation functions." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like it's a bug in AutoValue_PathTemplateCheckView. It's a bug in AutoValue_PathTemplateCheckView. It's a bug in AutoValue_PathTemplateCheckView. It's a bug in AutoValue_PathTemplateCheckView. It's a bug in AutoValue_PathTemplateCheckView. It's a bug in AutoValue_PathTemplateCheckView. It's a bug in AutoValue_PathTemplateCheckView. It's a bug in AutoValue_PathTemplateCheckView. It's a bug in AutoValue_PathTemplateCheckView. It's a bug in AutoValue_PathTemplateCheckView. It's a bug in AutoValue_PathTemplateCheckView. It's a bug in AutoValue_PathTemplateCheckView. It's a bug in AutoValue_PathTemplateCheckView. It's a bug in AutoValue_PathTemplateCheckView. It's a bug in AutoValue_PathTemplateCheckView. It's a bug in AutoValue_PathTemplateCheckView. It's a bug in AutoValue_PathTemplate", "reference": "Should this be called something that indicates its function, rather than its content? validationMessagePrefix, or similar?" }, { "prediction": "This file is covered by the GNU General Public License. #See the file COPYING for more details. -#Copyright (C) 2010-2015 NV Access Limited, Mesar Hameed +#Copyright (C) 2010-2019 NV Access Limited, Mesar Hameed, Takuya Nishimoto +#Copyright (C) 2018-2019 Takuya Nishimoto \"\"\"", "reference": "Please remove this line" }, { "prediction": "I don't think this is a bug in XCode 4.2 or newer, but I'm sure it's a bug in XCode 4.2 or newer.", "reference": "You could change the name of the command line switch too. Short options are typically one character after hyphen. wxWidgets' command line parser seems to handle `-nd` without confusing it with `-n` or `-d` but I'm not sure if that's by design or by accident. I'd remove the short option. `--no-daemon` is with hyphen but the rest of Manager and client uses underscore. Please change that." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, or if it's the case, or if it's the case, or if it's the case, it's the case, or if it's the case, or if it's the case, it's the case.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but I think it's what you're looking for.", "reference": "Why are we mentioning toybox in this message? AND it still says \"tdnf error\". What's the actual error? Should it be resolved instead of flagged?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "You can remove these if they've been resolved in NODE-3405 and this isn't depending on it" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "don't need the class here if its empty" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "This should be computed('i18n.locale'...." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think you're trying to do something like this:", "reference": "Please add return and return type description to docstring of this method." }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "What does 1 << 32 do? In irb typing this yields 4294967296. I didn't find the append operator in Numeric or Integer." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea to use `attr_accessor` instead of `attr_reader`.", "reference": "We generally use metadata for this sort of thing, indeed there is a `metadata[:execution_result]`." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "This was very confusing until I realized this might refer to the *bokeh* use of the word'streaming'." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea to use a `map` instead of a `map` here.", "reference": "Can you rename this as `tasksToContainerStates`? If you do that, you can rename the lock as well" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Fixing `lint` warnings that have existed for a while." }, { "prediction": "@param n The number of elements, where each element is the given {@code element}. + */ + static Iterator fill(int n, T element) { return io.vavr.collection.Collections.fill(n, element); } + /** * Returns a Iterator containing {@code n} times the given {@code element} + * + * @param Component type of the Iterator + * @param n The number of elements + * @param element The element + * @return An iterator of {@code n} sequence elements, where each element is the given {@code element}. + */ + static Iterator fill(int n, T element) { + return io.vavr.collection.Collections.fillObject(n, element); + } + /** * Creates an Iterator of characters starting from {@code from}, extending to {@code to {@code to}. */", "reference": "An iterator **of {\\@code n} sequential elements,** where each element ~are~ **is the** given {\\@code element}." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm sure it's what you're looking for.", "reference": "If all of the `SqlCommandIntegrationName` values are the same, can we just remove it from `IAdoNetClientData` entirely and put the constant there?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Maybe regroup this import with the other cert-manager packages." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm wrong.", "reference": "There are spaces missing ;) Just have a look at the code style of the `if` statement above" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "We should pass the size limit as a parameter to Drain so that we don't take messages out of the pool and then drop them. It's ok to merge as is, I will file an issue." }, { "prediction": "I don't know why this is the case, but it's the case, so it's the case.", "reference": "Patch lists are used in many places so this is going to break other updates. This should just be a local change in emit_special_ibl_xfer() to pass the second-to-last instruction instead of the last instruction." }, { "prediction": "@ -38,7 +38,7 @ @ char const * test_genesis_data = { \"source\": \"B0311EA55708D6A53C75CDBF88300259C6D018522FE3D4D0A242E431F9E8B6D0\", \"representative\": \"xrb_3e3j5tkog48pnny9dmfzj1r16pg8t1e76dz5tmac6iq689wyjfpiij4txtdo\", \"account\": \"xrb_3e3j5tkog48pnny9dmfzj1r16pg8t1e76dz5tmac6iq689wyjfpiij4txtdo\", \"signature\": \"ECDA914373A2F0CA1296475BAEE40500A7F0A7AD72A5A80C81D7FAB7F6C802B2CC7DB50F5DD0FB25B2EF11761FA7344A158DD5A700B21BD47DE5BD0F63", "reference": "@argakiig previous work was above live threshold, causing the high difficulty to bleed into other blocks when genesis open was processed in tests." }, { "prediction": "I think this is a bug in ActiveRecord::Migration. RemoveDiscountPercentageAndDiscountTitleFromProducts should be removed from ActiveRecord::Migration. RemoveDiscountPercentageAndDiscountTitleFromProducts should be removed from ActiveRecord::Migration. RemoveDiscountPercentageAndDiscountTitleFromProducts should be removed from ActiveRecord::Migration. RemoveDiscountPercentageAndDiscountTitleFromProducts should be removed from ActiveRecord::Migration. RemoveDiscountPercentageAndDiscountTitleFromProducts should be removed from ActiveRecord::Migration. RemoveDiscountPercentageAndDiscountTitleFromProducts should be removed from ActiveRecord::Migration. RemoveDiscountPercentageAndDiscountTitleFromProducts should be removed from ActiveRecord::Migration. RemoveDiscountPercentageAndDiscountTitleFromProducts should be removed from ActiveRecord::Migration. RemoveDiscountPercentageAndDiscountTitleFromProducts should be removed from ActiveRecord::Migration.", "reference": "Metrics/LineLength: Line is too long. [89/80]" }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "Please also extend the config tests now to include the new field." }, { "prediction": "I'm not sure if this is what you're looking for, but it's worth noting that this.RenderEmptyLiteral = true; should be used to avoid this.RenderEmptyLiteral = true;", "reference": "I think it's wise to keep the behavior backwards-compatible (so `false` as default)" }, { "prediction": "I think this should be enough.", "reference": "We don't need this line, do we?" }, { "prediction": "I don't think this is a bug. It's a bug in the German backlinks service. It's a bug in the German backlinks service. It's a bug in the German backlinks service. It's a bug in the German backlinks service. It's a bug in the German backlinks service. It's a bug in the German backlinks service. It's a bug in the German backlinks service. It's a bug in the German backlinks service. It's a bug in the German backlinks service. It's a bug in the German backlinks service. It's a bug in the German backlinks service.", "reference": "I don't know if we've actually had this problem on Upcase. I'd lean towards having a blank file unless (like on robots) we see multiple errors per week from this crawler." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "I'm not good at picking colors, if anyone else has a preference." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this should work.", "reference": "Note that even if you cancel the timer, the refreshFolders function might still be running since it's async. Could that be a problem for the test units? One big issue I had with tests is they sometimes would work and sometimes fail randomly, and that's because there are still code running in the background. One example was the ItemChange class, which saves data asynchronously. So I've implemented a waitForAllSaved(), which can be used for test units, to make sure nothing is running once the test ends. So just wondering if we might end up with this issue here." }, { "prediction": "I'm not sure if this is the expected behavior, but I'm not sure if this is the expected behavior, but I'm not sure if this is the expected behavior, so I'm not sure if this is the expected behavior.", "reference": "can we make this something more descriptive? like... types should compile? I'm still not sure exactly what this is testing... this says \"Exported types\" - but what does tsd actually look at?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug.", "reference": "this method is need for full screen video button to appear in players" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Why is this a pointer?" }, { "prediction": "I'm not sure I'm getting this right, but I'm not sure if I'm getting this right, but I'm not sure if I'm getting it right.", "reference": "nit: Space after comma" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "A similar field is already define in `scapy/layers/bluetooth.py`. Can you merge both definitions?" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's the case, it's a bug.", "reference": "`std::strtok` isn't necessary. The `std::string::find_first_of` is better C++ alternative to `std::strtok`. For example, see `CheckedError Parser::ParseEnumFromString` method." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "This property is already declared in a parent with the same visibility/type/value. This one is redundant." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "This is required, otherwise multiprocessing will (for some reason) crash" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for \"io/ioutil\" instead of \"io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io/io", "reference": "Please put in a separate line-separated block" }, { "prediction": "I'm not sure if this is a bug, but if it's a bug, it's a bug.", "reference": "Should error be eaten? If so, not clear why" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "This attribute is not defined if the condition is not met. Instead, you could define another RouteFactory (e.g. `BucketRouteFactory` with a class attribute like `allow_empty_list`)" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "Can we use the existing `InstalledTimestamp` function?" }, { "prediction": "I'm not sure if this is the case, but if it is the case, then I'm not sure if this is the case, but I'm not sure if this is the case, so I'm not sure if this is the case, so I'm not sure if this is the case. I'm not sure if this is the case, but I'm not sure if this is the case, so I'm not sure if this is the case. I'm not sure if this is the case, but I'm not sure if this is the case, so I'm not sure if this is the case, but I'm not sure if this is the case.", "reference": "weird naming: `is` but `fields` (plural or singular?). If the method checks if the fragment has an invalid value, then \"hasInvalidValue\" or \"containsInvalidValue\" is fine no?" }, { "prediction": "I'm not sure if this is the correct way to do it, but it should work.", "reference": "Does this mean that `listenbrainz.org/user/iliekcomputers` will start getting 404s?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Line is too long. [82/80]" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "That's a strange name =)" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Thoughts on this? I'm not crazy about the brittleness of this but haven't found a good way to test more generically that a specific (custom) template has been rendered." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for 'isValid', 'indexOf','min','max','min','max','min','max','min','max','min','max','min','max','min','min','max','min','max','min','min','max','min','min','max','min','min','max','min','min','max','min','min','max','min','min','min','max','min','min','max','min','min','min','max','min','min','max','min','min','min','max','min','min','max','min','min','min','max','min','min','max','min','min','min','max','min','min','max','min','min','min','max','min','min','min','max", "reference": "Have we reached binding-level agreement on the `subscribe` terminology? My only concern is that it doesn't seem descriptive enough and may be confused with subscribing for notifications." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "would it not be safer to move this condition to the `addLink` method?" }, { "prediction": "I'm not sure if this is the case, but I think it's the case. I'm not sure if it's the case, but I think it's the case.", "reference": "I think this might read better: > some apps need the response headers before starting to stream content with http2, so it's important to explicitly flush the headers to the client before streaming the data." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "What does this return if there is no partition? I think that we should consider adding a struct type that describes this tuple. That way, we can use an empty struct for unpartitioned and a non-empty struct for tasks that are combined by partition. We could also support more combinations, like combining across day partitions by not across bucket partitions or similar." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Also, it might be worth returning this for the above lookup on `kbfsRepoDir` as well, which could happen if someone tries to delete a repo in a TLF that has never had any repos at all." }, { "prediction": "I'm not sure if this will work or not, but it should work.", "reference": "Can this be `Hidden: true` as we already have a bunch of flags that are printed on `--help` and this seems like an average person should not care about it." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Wouldn't this set $strictVariables = true when Config::get returns false?" }, { "prediction": "I'm not sure if it's a bug, but it seems to be a bug. I'm not sure if it's a bug, but I'm sure it's a bug.", "reference": "was this meant to be checked in?" }, { "prediction": "The default is to report every attempt to reconnect a route, gateway or leaf node connection. The default is to report every attempt to reconnect a route, gateway or leaf node connection. The default is to report every attempt to reconnect a route, gateway or leaf node connection. The default is to report every attempt to reconnect a route, gateway or leaf node connection. The default is to report every attempt to reconnect a route, gateway or leaf node connection.", "reference": "check spaces after const name..." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm not sure.", "reference": "If the GPU setting is enabled, resourceFields.NvidiaGPUManager will be nil, right?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to run a script that doesn't exist?", "reference": "We should probably verify that it's readable too" }, { "prediction": "I'm not sure if this is a bug or a bug, or if it's a bug, or if it's a bug, it's a bug. If it's a bug, it's a bug, or it's a bug, it's a bug.", "reference": "See, here's an example where you removed the variable but kept the call, which makes sense." }, { "prediction": "I'm not sure if this is the correct way to do it, but if it is the correct way to do it, I'm not sure if this is the correct way to do it.", "reference": "Please use `request.getTitle()` instead of `feed.getHumanReadableIdentifier()`: In this case, `feed` does not have a human readable title yet" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "I think the wording on the left is better" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Please update the method described to point out that it maintains a chain of interceptors and they will be called in the same order passed in the options." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Is this case purely hypothetical or did it solve an issue that occurred in your testing? I'm trying to understand this change a little better" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Use instead `convert.Int32ToString` that was added in #762 for this purpose." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "If key is present, tree.put(k,v) needs to return a new instance for Maps and the same instance for Sets. Therefore we currently perform an additional 'contains' check for Sets. A future optimization may add an additional flag `replace` to the backing HAMT.put() / RedBlackTree.insert() methods. Sets set it to replace=false, Maps set it to replace=true. But for now this solution is working for us." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug, so I'm not sure what you're looking for.", "reference": "This is a regression test for code I found while working on this." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I'm wondering if we need to delete jsonStr and jsonAttr after the json_extract_path_text call to avoid unnecessary heap pressure. Though if json_extract_path_text itself does new's on the same heap, we'd get heap fragmentation. Another approach would be to allocate these on the stack instead, avoiding both concerns: char jsonStr[len1+1]; char jsonAttr[len2+1];..." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure.", "reference": "Does it come as `str`?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "This should actually read as the following `for (int i = 0; i < allergens.size(); i++)`" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "This is so useful and safety, I want to propose making AppendBool, AppendInt, etc. all private functions, and forcing us to use AppendValue(j, values.New(false)), etc." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Really, really small nit I believe there's 3x tabs in here? And should it be just 2x?" }, { "prediction": "I'm not sure if this will work, but I'm not sure if this will work, so I'm not sure if this will work.", "reference": "Perhaps note that rclone can't do this yet?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "You probably don't need to set an empty config here." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "I think you are missing `cftime.DatetimeAllLeap` here. That said, all of these are subclasses of `cftime.datetime`, so I think you could get away with just using `cftime.datetime` here, rather than enumerating all of the different subclasses (since `cftime_types` is only used for instance checks)." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing you're looking for something like this: // CStorPoolClusterCPK is the CStorPoolcluster label CStorPoolClusterCPK CasPoolKey = \"openebs.io/cstor-pool-cluster\" + // CStorPoolInstanceCPK is the CStorPoolInstance label + CStorPoolInstanceCPK CasPoolKey = \"openebs.io/cstor-pool-instance\" + // PredecessorBlockDeviceCPK is the node-disk-manager block device type e.g.'sparse' or 'blockdevice' NdmDiskTypeCPK CasPoolKey = \"ndm.io/disk-type\" // NdmBlockDeviceTypeCPK is the node-disk-manager block device type e.g.'sparse' or 'blockdevice' NdmBlockDeviceTypeCPK CasPoolKey = \"ndm.io/bd-predecessor\" // NdmDiskTypeCPK is the node-disk-manager disk type e.g.'sparse' or 'disk' NdmDiskTypeCP", "reference": "don't we need to set this label on pool pods? I don't see them being set" }, { "prediction": "Is this a bug? If so, what's the purpose of this error? If so, what's the purpose of this error?", "reference": "can remove, it isn't reachable." }, { "prediction": "Cancellation.new(subscription, plan: subscribed_plan) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new(subscription) Cancellation.new", "reference": "`expect(cancellation).to be_can_downgrade_instead` would be preferred :rainbow: :rainbow:" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Gross. The OS should timeout writes for completely unresponsive clients to begin with. Long term, the better solution is to enforce a minimum minimum data rate for responses. This might require a way to cancel LibuvAwaitables, but it definitely not OK to immediately kill the socket and any ongoing writes just because the request processing loop completed. You could consider doing that after some kind of timeout, but at that point you might as well just enforce a minimum rate." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "If this is not used, we should just delete the line." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Are there other callers to this function. How will they be impacted." }, { "prediction": "I'm not sure what you're trying to do, but I think it's a good idea.", "reference": "Let's be consistent. The majority of boto code does not use relative imports. Let's just stick to the existing standard of \"from boto.package.subpackage import Thing\"." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but I think it's what you're looking for.", "reference": "Suggestion: specify `arity` for this option." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This is a parameter available for the matplotlib backend IIRC. In which case, it is good to see this support added to the Bokeh backend." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "trim has performance impact and this is the lowest level library... seems the trim if occurs should happen in the UI or Query controller instead.." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "Probably also needed for the `http.client.FOUND` below?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Can you also add this to Compiler.md?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "!numbers -> numbers" }, { "prediction": "We will need to adjust this if in the future there are libraries that do not - * follow the package name format assumed here. We will need to adjust this if in the future there are libraries that do not - * follow the package name format assumed here. This + * works for both existing libraries and the baseline test. We will need to adjust this if in the + * future there are libraries that do not - * follow the package name format assumed here. */ @Override public String getExamplePackageName() { return \"com.google.cloud.examples.library.v1.snippets\"; }", "reference": "This description doesn't seem quite right for the longrunning case - `longrunning` isn't an orgname." }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this:", "reference": "maybe give it a more descriptive name, e.g. `competitiveFilter`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "This occurrence of \"master\" is unrelated to master/slave replication. Maybe simply remove the word \"master\" or replace it with \"reference\" but \"primary\" doesn't really make sense." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this: \"github.com/filecoin-project/go-filecoin\" \"github.com/filecoin-project/go-filecoin/proofs\" \"github.com/filecoin-project/go-filecoin/proofs\" \"github.com/filecoin-project/go-filecoin/proofs\" \"github.com/filecoin-project/go-filecoin/proofs\" \"github.com/filecoin-project/go-filecoin/proofs\" \"github.com/filecoin-project/go-filecoin/proofs\" \"github.com/filecoin-project/go-filecoin/proofs\" \"github.com/filecoin-project/go-filecoin/proofs\" \"github.com/filecoin-project/go-filecoin/proofs\" \"github.com/filecoin-project/go-filecoin/proofs\" \"github.com/filecoin-project/go-filecoin/proofs\" \"github.com/filecoin-project/go-file", "reference": "BLOCKING: This is a problem. We shouldn't be introducing new dependencies on proofs into actors. The miner has some dependencies that should be removed (#2555). This could be accomplished either by moving `proofs.Mode` to `types.ProofsMode` or by forgoing a new type altogether and replacing it with a boolean. The later would have the additional advantage of reducing the number of types we have to export through ABI. I get why `proofs.Mode` has value as a type over a boolean, but I'm not sure it's worth it here." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "We probably want to log the fact that a `MessageId` was not present in the response. In addition the `RequestID` from `request.Request` should be included in the message so that the user is aware of the issue." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure.", "reference": "It feels a bit strange to re-assign that here, as that line itself has no context on why it's reassigned. I'd prefer if we could pass `{ propertyID: webPropertyId }` below instead (that's how we do that elsewhere too). This also applies to other similar re-assignments below - let's rather pass the values within the objects as applicable, since then there is more clear context on why this \"rename\" / \"reassignment\" is necessary (because of an object expecting specific properties)." }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "remove this in the new pr aswell when moving compare to plugins as discussed." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "check varHolder is nullptr is redundant, ExecutionContext ensure" }, { "prediction": "@unsubscribe_token_verifier should be replaced with `unsubscribe_token_verifier` instead of `unsubscribe_token_verifier`", "reference": "Make these frozen constants?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug. I'm not sure if this is a bug, but I think it's a bug.", "reference": "Please use something like html.escape() to ensure that the text is totally safe to include within html. < is not enough." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "why is a buffered channel larger than 1 needed here? the separate goroutines can just try to write to the channel with a select-default block, and then it is not needed. i find the current implementation a bit convoluted, maybe we could simplify it a bit? not sure why it is needed for example to communicate an empty result. these patterns can be simplified using waitgroups" }, { "prediction": "It's strongly recommended that you check this file into your version control system.", "reference": "There seem to be more changes in here than I'd expect (mostly `limit: 255` additions)." }, { "prediction": "I'm not sure I'm getting this right, but I'm not sure I'm getting this right, so I'm not sure I'm getting it right. I'm not sure if I'm getting it right, but I'm sure I'm getting it right. I'm not sure if I'm getting it right, but I'm sure I'm getting it right.", "reference": "I'm not sure, but I think it's `Tenant`" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Not sure if it's an issue, but this is a breaking change in a public API. Maybe we should add as an overload without optional parameter instead and delegate the existing call to this one?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "as opposed to exposing the chooser function and increasing our API exposure for the purpose of tests, can we move the HTTP transport config test into this package?" }, { "prediction": "I'm not sure I'm getting this right, but I'm not sure if I'm getting this right, so I'm not sure if I'm getting this right, so I'm not sure if I'm getting it right.", "reference": "This is using the legacy DRM interface. DPMS levels have been removed from the atomic interface IIRC. Should we handle DPMS levels at all?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I think this was correct before. The nonce passed in here is the nonce at a block (which is the next nonce not yet used, e.g. 0 if the account was never used, 1 if only the tx with nonce 0 has been sent). So if the in-block nonce is 12, then a transaction with nonce 12 cannot have been included yet." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Please name the file ShareExtension.js, as you import it under this name (also could you convert it to TypeScript please?)" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this: ```````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````", "reference": "Not sure if we need it, but if we set it, be sure to add `,omitempty`." }, { "prediction": "The PublicHeader of a QUIC packet is not the same as the PublicHeader of a QUIC packet. It should be the same as the PublicHeader of a QUIC packet.", "reference": "It's the whole `PublicHeader` that will change soon, and we should state that here, not in the member functions. If Jana's proposal for a new header is accepted, we might also want to rename the fields here. For example, there won't be a dedicated version flag anymore, so a more appropriate name might be `ContainsVersion` instead of `VersionFlag`." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "I think `element` can stay of type `Character` because `Character` is a final class. The we do not need the cast in the line below." }, { "prediction": "This is an {@link #isInterface()} annotation type declaration. It's not an {@link #isRegularInterface()} annotation type declaration. It's a {@link #isRegularInterface()} annotation type declaration. It's a {@link #isRegularInterface()} annotation type declaration. It's a {@link #isRegularInterface()} annotation type declaration. It's a {@link #isRegularInterface()} annotation type declaration. It's a {@link #isRegularInterface()} annotation type declaration. It's a {@link #isRegularInterface()} annotation type declaration. It's a {@link #isRegularInterface()} annotation type declaration. It's a {@link #isRegularInterface()} annotation type declaration. It's a {@link #isRegularInterface()} annotation type declaration. It's a {@link #isRegularInterface()} annotation type declaration. It's a {@link #isRegularInterface()} annotation type declaration.", "reference": "Not sure, if we should do it the other way round. If you ask be in the middle of the night, whether Interface should return true as \"isInterface\" and what Annotation would return. I'd tell you, Annotations should return false.... I want to say, on first glance, I'd say, it's easier to have \"isInterface\" and \"isAnnotation\" rather than \"isInterface\", \"isAnnotation\" and \"isRegularInterface\"... But I see, we also have \"isRegularClass\".... We still have the possibility to change the semantics of those APIs in PMD 7 *Update:* Or in other words: What is less surprising? That isInterface returns true for annotations or that it returns false?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This will potentially skip package results. Do we really want that?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Please remove `HIP_UNSUPPORTED`" }, { "prediction": "This is the response to CreateWorkflowExecutionRequest CreateWorkflowExecutionResponse struct { - HistorySize int64 + NewMutableStateStats MutableStateStatus } // GetWorkflowExecutionRequest is used to retrieve the info of a workflow execution", "reference": "if this is a \"Status\" type then the variable name \"Stats\" (which implies \"statistics\") seems wrong (or at least confusing to me)" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "maybe will be better to put it into the default worker's config rather than hardcoding the address?" }, { "prediction": "I'm not sure what you're trying to do here, but I think this should work.", "reference": "It seems like this is not meant to test the option failure, but rather that `raw` can be set. This may be a superfluous test now, and we might want to delete it." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "This is already done by `view_set_fullscreen`" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "mmm I followed the convention of this collection. It has Add, Remove, RemoveAll, so All sounds reasonable. Else It would likely be AddPeer, RemovePeer, RemovePeers and Peers." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're trying to return an instance of a class that doesn't have a method that returns an instance of a class that doesn't have a method that returns an instance of a class that does have a method that returns an instance of a class that does have a method that returns an instance of a class that does have a method that returns an instance of that class. I'm not sure if this is what you're looking for, but it seems like you're trying to return an instance of a class that doesn't have a method that returns an instance of a class that doesn't have a method that returns an instance of that class.", "reference": "_nitpick_ I'm thinking about whether this method should be in the previous commit or not. I know it's not yet used there, but in theory, neither do UUID itself." }, { "prediction": "I'm not sure what you're trying to do, but I think it should be something like this:", "reference": "\"break\" is right? You skip the line 768." }, { "prediction": "I think this is a bug in RailsAdmin. See https://github.com/sferik/rails_admin for more information.", "reference": "Can this use the route helper instead?" }, { "prediction": "The zero value is a server with the default options.", "reference": "Why is this field exported and others aren't?" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this:", "reference": "should we rename this like `mongodb_srv_tests.js`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "This should still have a value when there is no page title, e.g. just `__( 'Search Traffic Summary', 'google-site-kit' )`." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Oops.. meant to link to SplitOp here. I'll clean up in my next commit" }, { "prediction": "This is a ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `` ``", "reference": "Remove these unnecessary imports that you've added." }, { "prediction": "I think this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "That space shouldn't be here :wink: This lead to an exception whenever a page with an error was loaded, e.g. an inexistent host - I just fixed that :smile:" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "It seems this is not the way to fix issue #505." }, { "prediction": "I think this is a bug in the loss function. If you want to use the loss function, you can use the weight_reduce_loss function instead. If you want to use the loss function, you can use the weight_reduce_loss function instead. If you want to use the weight_reduce_loss, you can use the weight_reduce_loss function instead. If you want to use the weight_reduce_loss, you can use the weight_reduce_loss function instead. If you want to use the weight_reduce_loss, you can use the weight_reduce_loss function instead.", "reference": "Please take a look at the docstring of `F.binary_cross_entropy_with_logits`. `weight` should be a tensor that matches the input tensor shape. It is Not the class-aware weight. `pos_weight` should be a vector with a length equal to the number of classes." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "Same here, merge with an existing test." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "@aimanrosli23 Could you help to confirm if you do not revert the change in below commit: SHA-1: 643623147a1feaddd734ddd84604e1d8e9dcebee * MdeModulePkg/SdMmcPciHcDxe: Send SEND_STATUS at lower frequency" }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "Can we do this without a breaking API change? What about adding a different name to convert directly to a Schema?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Why do we need to pull bluebird in here?" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "If *two* threads successfully download the same project into two different temp dirs, and one of them successfully renames one to its final destination, the `if`on line 102 will be false _in the other thread_, and it would leave its temp dir behind." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "I would appreciate it if you could rename `link` to `all_link` so that the roles of the two links (the other is `target_link`) become clearer." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "Is there a reason not to use `smi.create_expectedIndex` here (and in other places)? The `smi.create_expectedIndex` function will also check to make sure that you don't accidentally skip or duplicate any indexes. With the goal of avoiding errors in the test. It does mean that you have to be diligent with how the expected indexes are created, which can be annoying too. My logic was that it is better to be annoyed by constraints during development time than to find out some time later that the test didn't do what I thought." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Put a comma after the last parameter of a multiline method call." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "I don't know if we even need this parameter." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "What is the new result of this file if we keep it the same than before? It's just to picture easily what changed in this MR :) (thinking is hard)" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if it's what you're trying to do.", "reference": "This needs to be synchronous for the timeout to work." }, { "prediction": "We will be in touch with us at learn@thoughtbot.com should you have any questions or concerns. <% if purchaseable.city.present? %><%= purchaseable.city %>, <% end %><%= purchaseable.state %> <%= purchaseable.zip %> <% end -%> -We will be in touch before <%= purchaseable.starts_on.to_s(:simple) %> with a reminder and any further instructions. However, please don't hesitate to get in touch with us at learn@thoughtbot.com should you have any questions or concerns. <% if purchaseable.workshop.announcement.present? -%> <%= purchaseable.workshop.announcement.message %> <% end -%> -We will be in touch before <%= purchaseable.starts_on.to_s(:simple) %> with a reminder and any further instructions. However, please don't hesitate to get in touch with us at learn@thoughtbot.com should you have any questions or concerns. <% if purchaseable.workshop.announcement.present? -%> <%= purchaseable.workshop.announcement.message %> <% end -%> -We will be in touch", "reference": "Can you break this onto multiple lines?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm guessing it's a bug.", "reference": "OK, it looks like all children have bit 4 set, but it doesn't really matter at this split point: just informative, nothing reads it." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Sorry for the very basic question but why do we still have a DNSZone CRD in light of the DNSEndpoint, I don't fully understand the differences." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Looks like loop with overhead. You can: - create SID - test private function `sessionIsUnique()`" }, { "prediction": "I think this is the correct way to go about it.", "reference": "In my opinion, it would be better to have two separate settings. One that stores if sorting is enabled and one that stores the order. That allows to toggle automatic sort without having to re-select the order." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this: https://github.com/spiffe/sri/control_plane_cli/blob/master/src/control_plane_cli.c", "reference": "/me can't wait to rename this repo :)" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "nit: maybe call these `loadCollection()/loadDb()`" }, { "prediction": "I think this is what you want to do, but it's not what you're trying to do.", "reference": "Did you consider just do `return Task is an external data dependency and data does not exist (yet?).'`? Less `None`'s and `ifs`." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Some day, we really need to make these toolbars pluggable.." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "This should be `pygment=False` like in `browsertab.py`" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Should this be moved down (or up) to under the client lock instead of server lock?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug, so I'm not sure if it's a bug or a bug.", "reference": "Why are we removing this?" }, { "prediction": "This is pretty ugly, but it's pretty ugly. It's pretty ugly, but it's pretty ugly.", "reference": "What do you think about using `self.id`?" }, { "prediction": "I'm not sure if this is the case, but I think it's the case. I'm not sure if this is the case, but I'm not sure if it's the case.", "reference": "Please log once here at Error level \"Failed to connect to Typha, will retry...\"" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Can you revert this change? The `VERSION` value will be updated after maintainer determines the version at release." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "It could be better if we use the up case letter to specify the constant string name. Such as QUALIFIED_SERVICE_NAME_KEY can let the user know it's a constant string." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "This should be `@configuration.failure_exit_code`, we don't want to hard code 1." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Changed per review in Blockly." }, { "prediction": "I'm not sure if this is the case, but it's the case. I'm not sure if this is the case, but it's the case. I'm not sure if it's the case, but it's the case.", "reference": "Hi @wenyingd. so what's the original dst MAC of the reply packet from kube-proxy?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Note: I wasn't sure what the right wording would be for this, so I used existing language from elsewhere in the codebase." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Docstring for `platform`." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "This should be called before any `os.Exit` otherwise it could still mess up things." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "shouldn't this be `short`?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Can you please paste the output of `volume list` command which will show capacity of a openebs volume." }, { "prediction": "@param the type of the metric to be used as the name of the metric variable to be used as the type of the metric variable to be used as the type of the metric variable to be used as the name of the metric variable to be used as the type of the metric variable to be used as the type of the metric variable to be used as the type of the metric variable to be used as the type of the metric variable to be used as the type of the metric variable to be used as the name of the metric variable. */ @SuppressWarnings(\"unchecked\") public T register(String name, T metric) throws IllegalArgumentException { + + if (metric == null) { + throw new IllegalArgumentException(\"metric variable must not be null!!!\"); + } + if (metric instanceof MetricRegistry) { final MetricRegistry childRegistry = (MetricRegistry)metric; final String childName = name; return childRegistry.register(name, metric); } return metric; }", "reference": "I'd make this a `throw new NullPointerException(\"metric == null\");` instead" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Include should be order lexicographically." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "We need to pass in the Activity context here, so that LoginActivity is used, and so that LoginActivity can get onActivityResult from the PasscodeActivity. Without this, the application context is used, and we don't get a callback when the passcode is done." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Can you move these to the top please, for consistency with other models - normally we put scopes immediately after the associations at the top of the model. As to names I agree with @gravitystorm that these names may be confusing but I'm not sure the ones I suggested are perfect either so I'm not really sure what's best. The goal of my names was just to separate point which could be ordered (as `ordered`) from those which can't (as `unordered`) but I realise that may not be very clear from the names." }, { "prediction": "I'm not sure if we're not keeping track of the item, but if we're keeping track of the item, we're not sure if we're keeping track of the item, so we're not sure if we're keeping track of the item, so we don't know if we're keeping track of it.", "reference": "Looks like the episode should also not be deleted when repeating" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like \"net/http\" or \"net/httpserver\" or \"net/httpserver\" or \"net/httpserver\" or \"net/httpserver\" or \"net/httpserver\" or \"net/httpserver\" or \"net/httpserver\" or \"net/httpserver\" or \"net/httpserver\" or \"net/httpserver\" or \"net/httpserver\" or \"net/httpserver\" or \"net/httpserver\" or \"net/httpserver\" or \"net/http\" or \"net/httpserver\" or \"net/http\" or \"net/http\" or \"net/http\" or \"net/http\" or \"net/http\" or \"net/http\" or \"net/http\" or \"net/http\" or \"net/http\" or \"net/http\" or \"net/http\" or \"net/http\" or \"net/http\" or \"net/http\" or \"net/http\" or \"net/http\" or \"net/http\" or \"net/http\" or \"net/http", "reference": "I feel like goimports would move this import line by the other non-std packages... can you double-check that? Run goimports or set up your editor to run it on save. :+1:" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "`options['binary'] = WebDriver::Chrome.path` if set?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "Nit: Supported -> Enabled." }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this:", "reference": "Yay! I was too lazy to fix this." }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but I'm guessing it's a bug.", "reference": "other declaration of errors (from `typecheck`)" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "nit: error starts with capital letter" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "the original code ignores \\Draft and \\Recent, whereas your change will not. what this matters, i'm not sure." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Why was this necessary?" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to run multiple tests, so I'm assuming that you're using a single test target, so I'm assuming that you're using a single test target, so I'm assuming that you're using a single test target, so I'm assuming that you're using a single test target, so I'm assuming that you're using a single test target, so I'm assuming that you're using a single test target, so I'm assuming that you're using a single test target.", "reference": "Can you also do this for Cover?" }, { "prediction": "I don't think it's a bug, but it's a bug. I'm not sure it's a bug, but it's a bug. I'm not sure it's a bug, but it's a bug.", "reference": "So I tried adding this VU a long time ago, thought it would be this simple of a check, but turns out there were other validation in the way for getting here in `ValidateImageAspectMask` I assume that is what is failing CI here, realized it would require some more refactoring" }, { "prediction": "I think this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "This method is not needed for postgresql, by default sum function omits null values so we can remove this file" }, { "prediction": "We have separate checks for libsystemd and the unit dir for historical reaso PKG_CHECK_MODULES([LIBSYSTEMD], [libsystemd], [have_libsystemd=yes], [have_libsystemd=no]) AM_CONDITIONAL(BUILDOPT_LIBSYSTEMD, test x$have_libsystemd = xyes) AM_CONDITIONAL(BUILDOPT_LIBSYSTEMD, test x$have_libsystemd = xyes) AM_COND_IF(BUILDOPT_LIBSYSTEMD, - AC_DEFINE([HAVE_LIBSYSTEMD], 1, [Define if we have libsystemd])) AM_COND_IF(BUILDOPT_LIBSYSTEMD, - AC_DEFINE([HAVE_LIBSYSTEMD], 1, [Define if we have libsystemd]) AM_COND_IF(BUILDOPT_LIBSYSTEMD, - AC_DEFINE([HAVE_LIBSYSTEMD], 1, [Define if we have libsystemd]) AM_COND_IF(BUILDOPT_LIBSY", "reference": "Can you provide a `--with-systemdsystemgeneratordir` option here? So that I can do unprivileged installs without completely turning off systemd. I can add it as a follow-up PR too." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "`classification` is misspelled" }, { "prediction": "We don't want to use the method initCode, since we don't want to use the method initCode, we don't want to use the method initCode, we just want to use the method initCode. We don't want to use the method initCode, we just want to use the method initCode. We don't want to use the method initCode, we just want to use the method initCode. We don't want to use the method initCode, we just want to use the method initCode. We don't want to use the method initCode, we just want to use the method initCode. We don't want to use the method initCode, we just want to use the method initCode.", "reference": "Can you change this to `sampleInitCode`?" }, { "prediction": "public String toString() { StringBuilder sb = new StringBuilder(); sb.append(\"[\").append(limit).append(\"]\"); sb.append(\"[\").append(startTs.getVersion()).append(\"]\"); sb.append(\"[\").append(startTs.getVersion()).append(\"]\"); sb.append(\"[\").append(startTs.getVersion()).append(\"]\"); sb.append(\"[\").append(startTs.getVersion()).append(\"]\"); sb.append(\"[\").append(startTs.getVersion()).append(\"]\"); sb.append(\"[\").append(startTs.getVersion()).append(\"]\"); sb.append(\"[\").append(startTs.getVersion()).append(\"]\"); return sb.toString(); }", "reference": "I added a startTs information in `TiDagRequest` output. Not really sure if it is useful? @zhexuany" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "This prevents margin/border/padding CSS from affecting the width/height (otherwise in Chrome a width and height of 1 would result in a rect size of 5x5)." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "prefer to just add this to the `verify_authorized` exception list above since we're already making exceptions." }, { "prediction": "I'm not sure if this is what you're looking for, but if it's what you're looking for, you can do something like this: if (!strpos($fq_classlike_name_lc, '\\\\') &&!strpos($fq_classlike_name_lc, '\\\\') &&!strpos($fq_classlike_name_lc, '\\\\') &&!strpos($fq_classlike_name_lc, '\\\\') &&!strpos($fq_classlike_name_lc, '\\\\') &&!strpos($fq_classlike_name_lc, '\\\\') &&!strpos($fq_classlike_name_lc, '\\\\') &&!strpos($fq_classlike_name_lc, '\\\\') &&!strpos($fq_classlike_name_lc, '\\\\') &&!strpos($fq_classlike_name_lc, '\\\\') &&!strpos($fq_classlike_name_lc, '\\\\') &&!strpos($fq_classlike_name_lc, '\\\\') &&!strpos($fq_classlike_name_lc, '\\\\')", "reference": "was there a reason to not loop over parent classes here?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "@billybonks Why move `import Ember from 'ember';` to the top?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Everything's so simple (a `ThreeStateWorkflow`) until it isn't :smirk:" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "I don't quite understand where the NaNs come from..." }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "File is not `goimports`-ed" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "I wonder if we should look at moving the Python stuff to a plugin and doing this there rather than adding to core plz at this point?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "This is the actual bug fix. I prob should have broken this out into two PRs." }, { "prediction": "IsEip3198Enabled { get; } + /// + /// Difficulty Bomb Delay to Q2/2022 + /// + bool IsEip3238Enabled { get; } + + /// + /// Reduction in refunds + /// + bool IsEip3529Enabled { get; } + /// /// Should transactions be validated against chainId. /// ", "reference": "I am not sure if we need this, we already have DifficultyBombDelays" }, { "prediction": "I'm not sure if this is a bug, but it's a bug in Nethermind.Blockchain.Synchronization.", "reference": "move to finally - I can see at least one return that would omit it, also any exception and so on" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug", "reference": "remove `genesisConfig.GravityChainStartHeight == 0`" }, { "prediction": "Doctrine\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common\\Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common.Common", "reference": "this might kill whole application if `var-dumper` will not be installed. What about two separate file_exists conditions (monorepo/project)?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Hrm. Maybe this isn't the correct spot to run this? Because it errors if the app type doesn't support settings. But we want to check that before running it." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Why are you changing this name?" }, { "prediction": "is it enough to remove this line? If it is not enough, can we remove it?", "reference": "as we discussed, maybe it would be better to - [ ] set OVERRIDE_IN_DOCKER=1 in the Dockerfile - [ ] replace the if statement with `os.path.exists(\"/run/.containerenv\")` as @dfangl suggested" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "I like this style of doing things better than having super big conditional without explanation. Even though I know this won't be re-used it's nice to have a function if only for clarity." }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this:", "reference": "Our preference here is to either have inline statements e.g. `@group_level -= 1 if @group_level > 0` but stylistically here I think `return @group_level if @group_level == 0` might be nicer. As it stands however our rubocop is picking this up as a fail :(" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Spark3 Is supported in OSS Iceberg, Do you mean this particular function is not supported in Spark3? If so I think we should have a more clear reason why" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "something about the arbitrary file access part here makes me nervous. Can we keep the `if not path.endswith(\".ipynb\")` check from before here as well? Just imagining a weird attack scenario where somebody somehow uses this to get access to confidental files or something" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I wonder if we should push this and the search_params_logic into the blacklight config." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "don't need this line, since it is not tested here?" }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "I wonder if adding this new param in the middle of the param list might screw up some existing code that is depending on the old parameter order. Might be better to add it to the end of the parameter list?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "I wonder if this absolute path is gonna affect the build-cache relocatability of these compile tasks??" }, { "prediction": "I think this is a bug. It should be a bug. It should be a bug. It should be a bug.", "reference": "possible bug if `fullResponse` is false" }, { "prediction": "I'm not sure what you're trying to do, but I think it's a good idea.", "reference": "nitpick: Please only `import string` here and use `string.ascii_lowercase` - I really like to see what module stuff is coming from without looking at the imports." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "nitpick: the only reason we have a catch for every one of these promises is because the test isn't properly chaining promises (returning them within each `then`). We could reduce the `catch` with `console.dir` to a single instance if that was done" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "why do this?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to use SystemMediaLibrary instead of SystemMediaLibrary::class. I'm guessing you're trying to use SystemMediaLibrary::class instead of SystemMediaLibrary::class. I'm guessing you're trying to use SystemMediaLibrary::class instead of SystemMediaLibrary::class, so I'm guessing you're trying to use SystemMediaLibrary::class instead of SystemMediaLibrary::class.", "reference": "For consistency, would it not be best to also replace the first class name? `traceLog('Class '. static::class.'has been deprecated, use '. SystemMediaLibrary::class.'instead.')`" }, { "prediction": "The Prometheus API will be available to all Prometheus instances. This means that all Prometheus instances will be available to all Prometheus instances. This means that all Prometheus instances will be available to all Prometheus instances. This means that all Prometheus instances will be available to all Prometheus instances. This means that all Prometheus instances will be available to all Prometheus instances. This means that all Prometheus instances will be available to all Prometheus instances. This means that all Prometheus instances will be available to all Prometheus instances. This means that all Prometheus instances will be available to all Prometheus instances. This means that all Prometheus instances will be available to all Prometheus instances. This means that all Prometheus instances will be available to all Prometheus instances. This means that all Prometheus instances will be available to all Prometheus instances.", "reference": "this should be `EnabledAdminAPI` and the json string should then be `enableAdminAPI`" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a good idea.", "reference": "Noticed some missing imports in manage.py so thought I'd add them" }, { "prediction": "I'm not sure if this is the right way to do it, but I think it's the right way to do it.", "reference": "as a future improvement, maybe we should just change `ForAllFlowRecordsDo` so that `updateOrSendFlowRecord` uses a flow record pointer instead of a copy of stored flow record. This whole code is executed with the lock any way." }, { "prediction": "@ -37,6 +37,7 @@ import java.util.function.Consumer; * A literal string. *
    \"Hello World!\" *
    \"\\\"\\n\" *
    \"TM\" *
    \"TM\" *
    \"TM\" *
    \"TM\" *
    \"TM\" *
    \"TM\" *
    \"TM\" *
    \"TM\" *
    \"TM\" *
    \"TM\" *
    \"TM\" *
    \"TM\" *
    \"TM\" *
    \"TM\" *
    \"TM\" *
    \"TM\" *
    \"TM\" *
    \"TM\" *
    \"TM\"<%= document_heading(document) %> + <% if document.respond_to?(:export_as_preferred_citation_txt) %>

    <%= t('blacklight.citation.preferred') %>

    <%= document.send(:export_as_preferred_citation_txt).html_safe %>

    + <% end %> + <% if document.respond_to?(:export_as_mla_citation_txt) %>

    <%= t('blacklight.citation.mla') %>

    <%= document.send(:export_as_mla_citation_txt).html_safe %>

    + <% end %> + <% if document.respond_to?(:export_as_preferred_citation_txt) %>

    <%= t('blacklight.citation.preferred') %>

    <%= document.send(:export_as_preferred_citation_txt).html_safe %>

    + <% end %> + <% if document.respond_to?(:export_", "reference": "why is the `send` needed?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "Is this necessary? If so, we need to update the docstring." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "Checking for actionable here instead of grabbing the first pending approval. I tested this with proposal ID 265 on staging." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea to check if self._result is self.UNSET or self._assert_result(self._result, expected) or self._assert_result(self._result, expected) or self._assert_result(self._result, expected) or self._assert_result(self._result, expected) or self._assert_result(self._result, expected) or self._assert_result(self._result, expected) or self._assert_result(self._result, expected) or self._assert_result(self._result, expected) or self._assert_result(self._result, expected) or self._assert_result(self._result, expected) or self._assert_result(self._result, expected) or self._assert_result(self._result, expected) or self._assert_result(self._result, expected) or self._assert_result(self._result, expected) or self._assert_result(self._result, expected) or self._assert_result(self._result, expected) or self._assert_result(self._result, expected", "reference": "I made this change because I wasn't getting printouts of the'result' value when the assert was inlined for some reason. I think it's related to creating new CallbackCheckers maybe?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm sure it's what you're looking for.", "reference": "nit: the correct name is \"request line\", so let's use the right one here :)" }, { "prediction": "I'm not sure if this is the case, but I think it's the case. I'm not sure if this is the case, but I think it's the case.", "reference": "This should now use `[]`, so it crashes if the var is missing" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so it should be fixed.", "reference": "you could use `bpf_map_update_elem` with `BPF_EXIST`" }, { "prediction": "I'm not sure if I'm missing something here, but I'm not sure if I'm missing something here, so I'm not sure if I'm missing something here, but I'm not sure if I'm missing something here.", "reference": "thanks for noticing this! But I think we should not have it in this PR." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug.", "reference": "A few things: - This may not serialize because I think the property for the sequence number on an input is `.sequenceNumber`. - There should be tests to cover these statements - Indentation is incorrect (should be two spaces, as similar to the statements above)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "If this is a base method that could be used by others, should you hardcode 'GCS uploader' here?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "just a little thing: let's introduce a `final int bound = length - back.length();` that saves us calculating the bound each time checking the loop condition." }, { "prediction": "I'm not sure if this is the case, but it's the case, so it's the case.", "reference": "I think that this should be a POST method, as it changes the state. Get requests should not change the state. With different method, I would suggest to have the handler under `\"/settlements/{peer}\"` path." }, { "prediction": "I'm not sure if this is the case, but I think it is the case.", "reference": "This is the default value?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "The spaces are actually legitimate here: in python, you: - first import standard library modules (hint: time is one) - then import 3rd party library modules - then import the modules from you project (here kinto). Between each block you need an empty line." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Haha, whoa, I'm not sure how I let that one go by. :)" }, { "prediction": "I'm not sure if this is a bug, but it's a bug in MimeTypeDetectionByFileExtension. I'm not sure if it's a bug, but it's a bug in MimeTypeDetectionByFileExtension. It's a bug in MimeTypeDetectionByFileExtension. It's a bug in MimeTypeDetectionByFileExtension. It's a bug in MimeTypeDetectionByFileExtension. It's a bug in MimeTypeDetectionByFileExtension. It's a bug in MimeTypeDetectionByFileExtension. It's a bug in MimeTypeDetectionByFileExtension. It's a bug in MimeTypeDetectionByFileExtension.", "reference": "FWIW: We have FileUtil.generateOriginalExtension for tabular files but it uses a hardcoded list rather than the properties file." }, { "prediction": "I'm not sure if this is the case, but if it's the case, it's the case. I'm not sure if this is the case, but it's the case. I'm not sure if this is the case, but it's the case. I'm not sure if it's the case, but it's the case.", "reference": "I would consider extracting this logic in to a helper function to make it a bit more readable, but that's just my opinion." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Are all fields beginning with \"Debug\" automatically `;local`? (I guess so, but just checking.)" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "We should let this module inherits from the EvalHook supported in MMCV, and only override the `__init__` function by adding the warnings. The other functions can use those in MMCV." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug.", "reference": "Let's use prepared statements here instead" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Just leaving this in one place but thanks so much for re-organising all these imports." }, { "prediction": "I think this is what you want.", "reference": "Ditto, here and below" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Let's move the check outside the `for`-loop so that we don't have to do it for every prop. If we change it to check for `vnode.type ==='string'` we can automatically skip checking text nodes which don't have props" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Seems like the docstring here should simply be \"Deprecated; use `hooks` instead.\"." }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if it's the correct way to do it, so I'm not sure if it's the correct way to do it.", "reference": "It would be nice to have an `attr` in `styles.xml` for this, so we don't need the same `if` statement in multiple places" }, { "prediction": "I think this is what you're looking for.", "reference": "How about `null: false` on these two lines? Also `t.timestamps null: false`?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug, so I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "This recommendation isn't very helpful because it isn't clear what \"the metastore\" is. How about this instead: \"To fix this, use an alternative metastore\"." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "The `SymbolTable` deals only with symbols, I think we can just call this `isUsed` here." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Please hide this behind a flag and add a setter function to the builder." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Just a side-node, no need to change it here: The term \"recent\" might be confusing at a later point in time." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, then you'll need to change your code to something like this:", "reference": "When can it be undefined? Wouldn't that be a bug?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug, so I'm not sure if it's a bug.", "reference": "JMX offers normal APIs for this. I don't think you want the glassfish one." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Could you remove `,' at the end?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Maybe it would simpler to ignore opt_port if type!== 'number'?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "do you want to rename the codec tag here too?" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, then it's a good idea to use the \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \"", "reference": "These command names are specific to Chromium-based browsers. Please move to `ChromiumDriverCommand`" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Hm.. should we auto-patch? I am less sure on this yet as `percentile_approx` seems a Spark function and auto-patching it in Koalas seems a bit counterintuitive." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "I found domain use in `AllFeedsTest::getAllFeedExportCreationData` and class AllFeedsTest is descendant of `FunctionalTestCase`. I think so we can rewrite this too.." }, { "prediction": "I think this is a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug.", "reference": "I am wondering if it is better to consolidate all committer checkpoint states into a single structure, e.g. Pojo class or Avro record which are Flink supported state types for schema evolution." }, { "prediction": "I think this is a bug. It should be fixed in the future.", "reference": "I assume this is a performance optimization to only check this once when creating the signal filter? While you're at it, maybe make `BLACKLIST` a set instead?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Please use async/await and try/catch" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "Like I said, this code looks incorrect. Why is it still looking up the attribute? Why is it getting the type from `nested->type.struct_def` instead of `field.nested_flatbuffer`? Are you running `generate_code.sh`, because I think `nested->type.struct_def` would be null?" }, { "prediction": "I'm not sure if this is a bug, but if it's a bug, it's a bug.", "reference": "Actually, I'm not sure why lines 1663-1668 are here. Looks like Push descriptors aren't used in the test at all. @ziga-lunarg?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Don't we still want to check it it's a keyword?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "this can just me `link_text` :tomato:" }, { "prediction": "I think this is a bug, but it should be fixed in the future.", "reference": "What if the Series contains null values?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Every place you see a change like this, it's because `PhysicalLocation` is now its own object, not an array of `PhysicalLocationComponent` objects. The `Uri` is the key into the `FileInfo` dictionary." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this: I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this: import sklearn.mixture as skm from mmdet.core.bbox import ATSSHead -eps = 1e-12 +EPS = 1e-12 try: import sklearn.mixture as skm except ImportError: import sklearn.mixture as skm from mmdet.core.bbox import ATSSHead -eps = 1e-12 +EPS = 1e-12 except ImportError: import sklearn.mixture as skm from mmdet.core.bbox import ATSSHead -eps = 1e-12 +EPS = 1e-12 try: import sklearn.mixture as skm from mmdet.core.bbox import ATSSHead -eps = 1e-12 +EPS = 1e-12 except ImportError: import sklearn.mixture as skm from mmdet.core.bbox import ATSSHead -eps = 1e-12 +EPS = 1e-12 try: import sklearn.mixture as sk", "reference": "Like in atss_head" }, { "prediction": "I'm not sure if this is a bug, but it's a bug in the golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang golang gol", "reference": "nit : I think it would be better to have the multiplier being calculated along with `pool.numPendingWholeBlocks`, so that we could always multiply the feePerByte with that multiplier. Not only that it would be faster, but it would also have constant time. btw - Correct me if I'm wrong, but with this change, you're practically rolling back your previous change while making it `pool.expFeeFactor` adjustable, right?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Is there a reason we _wouldn't_ want to do this? A bit of a security hole :grimacing:" }, { "prediction": "I'm not sure if I'm missing something, but I'm not sure if I'm missing something, or if I'm missing something, or if I'm missing something, or if I'm missing something, I'm not sure.", "reference": "Please add a copyright notice to all new files. Is there a tool to check and auto update copyright notices?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "A new translation dump should be made after this change (removing the \"Email\" message)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "CI is failing saying `expected [TypeError: null is not an object (evaluating 'implicitNodes(role).map')] to equal null`." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "@JoviDeCroock I replaced the refs here with simple assignments." }, { "prediction": "The Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive Hive", "reference": "nit: Could we use VisibleForTesting annotation here?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Can we create some post records to assert sort_by" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "is this necessary?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "What is the purpose of this? It seems like it is used to indicate whether there is a filter on a span. But what filter? Could there eventually be multiple filters per span? Just not understanding." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "using a certain type instead of using string directly." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "fix trailing," }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I've fixed it for this change but for future reference there's no point doing string substitution for a single value like that - it will just slow things down. Just use `:mlat => trace.latitude` etc instead." }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "The form no logger needs validation?" }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it, so I'm not sure if this is the correct way to do it.", "reference": "there'd be more changes in the area, when we implement \"clean-up\" of aggregators if no new updates. (i think we currently send metricitem to exporters with zero as value)" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this.", "reference": "Usually we only keep the assertions that are relevant to the specification (ie. the test title). For example, the test on the values of id and details is not properly relevant for the spec _collections are isolated by bucket_. I suggest that you only keep the assertions regarding `details` in dedicated tests similar to `test_unknown_collection_raises_404` from `test_views_records.py`, but for each of bucket, group, collection and record in the other `test_views_` files." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "The test sources are ok though, you don't need to remove those changes" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here.", "reference": "`maxWidth: width * 2,` Potentially, this will be the same as `getImageUrl`: 80px or 500px. I can't verify this - need for normal LiveTV tuner." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "Not really related to this issue but should we use fuzzy search here as well (like for apps)?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "isn't the usual capitalization for subcommands force-qr? (don't care too much about it)" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Do you know how many repos have hit this?" }, { "prediction": "I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I'm assuming it's what you're looking for.", "reference": "I'll be interested to see if our gettext rake tasks will pick up on this text to translate" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I think you need to change line 928 value from 6 to 7 too, since now table will have 7 values" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this. I'm not sure what you're trying to do here, but it seems like you're trying to do something like this.", "reference": "Does `f0[::-1, :]` mean all the rows taken in a reverse order?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Looks like there are strange characters here." }, { "prediction": "I'm not sure if this is a bug, but if it's a bug, it's a bug.", "reference": "It is better to have a check to ensure the format is valid." }, { "prediction": "I think this is a bug. It should be fixed in the latest release.", "reference": "How about `nextAlreadyDefined` variable name in method signature?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "In older SDK versions the data converter was called 3 times but now it is 2. This is because logic was changed deep in the interceptor chains on when values are serialized and encoded and such. Previously we invoked the data converter on results _even if there was an error_ (and most of the time they were nil). Now we don't do such a thing, resulting in fewer calls." }, { "prediction": "I'm not sure if this is the correct way to do this, but it seems to work.", "reference": "formatting... can this import go next to the other sources ones?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this? If so, then you're trying to do something like this? If so, then you're going to need to do something like this?", "reference": "I don't understand why anyone would pass 0? If you don't want to attach to an existing process you just wouldn't pass -attach. I would remove that sentence and make 0 an invalid argument." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "This change is responsible for #2775" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Should we add this to the other \"never\" verification in lines 71-73 above, too?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Fixed this since it no longer needed to be switched from a generator to a list, this was missed when I cleaned up the dataset code in an earlier PR." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "This is an informational message that allows someone to read the console output and understand how the grid node is configured. Please leave." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this. I'm not sure what you're trying to do here, but I think you're looking for something like this.", "reference": "Can we convert this to an arel as below ContributorFact.joins(:project).where(projects: { id: project_id}).where('name_id =? or name_id in (?)', name_id, AnalysisAlias.select(:preferred_name_id).joins(:project).where(commit_name_id: name_id) )" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "Does this cause issues if you have lots of load on the machine? Having a global variable for this seems like a bad idea IMO." }, { "prediction": "I'm not sure if this is the correct way to do this, but I think it's the correct way to do it.", "reference": "We probably don't need to print the msg with e.getMessage(). It will be printed by the logger since we are passing the exception as a parameter." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but I think it's what you're looking for.", "reference": "Can we get a test with multiple directories as per the initial example?" }, { "prediction": "We may have landed in a child of the status bar, so we may have landed in a child of the status bar, so we may have landed in a child of the status bar.", "reference": "I assume this is because you were seeing cases where left was a negative number? When?" }, { "prediction": "I'm not sure what you're trying to do here, but I think it's a good idea to include a header file in the top-level LAMMPS directory. I'm not sure what you're trying to do here, but it's a good idea to include a header file in the top-level LAMMPS directory. ------------------------------------------------------------------------- */ -#include \"fix_deposit.h\" -#include #include +#include #include +#include \"fix_deposit.h\" #include \"atom.h\" #include \"atom_vec.h\" #include \"molecule.h\" #include \"molecule_vec.h\" #include \"molecule_vec.h\" #include \"molecule_vec.h\" #include \"molecule_vec.h\" #include \"molecule_vec.h\" #include \"molecule_vec.h\" #include \"molecule_vec.h\" #include \"molecule_vec.h\" #include \"molecule_vec.h\" #include \"molecule_vec", "reference": "this is undoing recent changes for increased consistency of include file statements. please restore to the original." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "If these are applied in order, should `LambdaMethoReference` come after `OptionalOrElseMethodInvocation`" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Why this rename?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Why do we do this check here? `sys.version_info` cannot be less than 3.3 as pylint does not support older versions. I think we should avoid popping `__main__` altogether." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug in the codechecker_cfg.get('pg_db_config') function.", "reference": "This can be removed too." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "I'm a little worried about the new extra calls to `MakeMdId`, since in most local-server KBFS profiles, hashing is the biggest CPU user, and not re-using the value calculated by the client will result in even more hashing. That said, I understand why you did it this way, and I don't have a concrete suggestion on how to make it better. Just something to keep in mind; plus it might be worth comparing the test speed before and after this change to make sure it didn't slow things down too much." }, { "prediction": "I'm not sure if this is the issue, but I'm not sure if it's the issue, but I'm not sure if it's the issue.", "reference": "`lodash` shouldn't be grouped under WordPress dependencies" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Just curious, but how did you work out that Aleksey Sadovoy, Peter Vgner and Joseph Lee contributed to this file? Did you look at the repository history?" }, { "prediction": "We don't need to do this in the event loop because we call ReadStop on 2 places: // 1. On the event loop, we don't need to call ReadStop on 2 places: // 2. On the event loop, we don't need to call ReadStop on 2 places: // 1. On the event loop, we don't need to call ReadStop on 2 places: // 2. On the event loop, we don't need to call ReadStop on 2 places: // 1. On the event loop, we don't need to call ReadStop on 2 places: // 2. On the event loop, we don't need to call ReadStop on 2 places: // 1. On the event loop, we don't need to call ReadStop on 2 places: // 2. On the event loop, we don't need to call ReadStop on 2 places: // 2. On the event loop, we don't need to call ReadStop on 2 places: // 2. On the event loop, we don't need to call ReadStop on 2 places: // 3. On the event loop, we don't need to call ReadStop on 2 places: // 3. On the event loop, we don't need to call", "reference": "You could call OnStopRude() directly here to do the same thing." }, { "prediction": "I'm not sure if this is the case, but it could be the case that you're using a Piped, but it could be the case that you're using a Piped, so it could be the case that you're using a Piped, so it could be the case that you're using a Piped, but it could be the case that you're using a Piped, so it could be the case that multiple Pipeds watches the same repo, so it could be the case that one Piped report App-1 as an unregistered app even though another Piped register that app. sort.Slice(allApps, func(i, j int) bool { return allApps[i].Path < allApps[j].Path })", "reference": "This TODO and this `sort` depend on how the UI looks like. So I think we should fix the UI before continuing on updating this web API. For example, in case the UI flow is as below, this API will receive a Piped ID and then return just ones belonging to that Piped. - User picks where they want to deploy first (select one Piped and one cloud provider) - Then API will be called to show the list of suggested apps for that Piped and cloud provider - User picks app they want to create" }, { "prediction": "I'm not sure if this will help you, but I think it will help you.", "reference": "This command rolls back the volume data to the specified snapshot. Once the roll back to snapshot is successful, all the data changes made after the snapshot was taken will be post. This command should be used cautiously and only when there is an issue with the current state of the data." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "should this be a separate/new functional test?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Can these also assert at least the length of arrays returned and ideally contents?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "`hasattr(task, 'param_visibilities')` is more concise with the same effect, but either one works." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "I would hedge this a little, maybe `Positional arguments appear to be out of order`. After all, it's just a guess." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "you can directly call show() method from **SnackBarHandler.show(coordinatorLayout, getString(no_account_signed_in)).show();** no need to create an extra object and then call the show method." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm sure it's a bug.", "reference": "concatHosts may be a better func name to explain this?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "A function that returns empty string." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "If it's not the root package, or if it is the root package but we don't add the psudo :pleasings rule there, print an error." }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "can delete this line" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug.", "reference": "Will it still be an issue if all the models use the same data set?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "How does this controller_name method work? Does this method grab the context of the url request? Wouldn't this always result in 'widget'?" }, { "prediction": "@ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @", "reference": "Let's get rid of these for the final version and if you get rid of the macro I left last time I'd be more than grateful." }, { "prediction": "I'm not sure if this is the case, but I think it is the case.", "reference": "Instead of `DELETE_MARK`, how about `IS_DELETED`? I don't think that \"mark\" is clear enough to describe what this is. Similarly, I think the docs should be \"Whether the row has been deleted\". There's no need to include \"delete mark\" because that's identifying something that is not defined (this column is _deleted and \"mark\" is not introduced), and \"or not\" is unnecessary because it is implied by \"whether\"." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Does it make sense to have this very thin wrapper that only calls `create_dependencies`? And maybe having `create_dependencies` return a set would be better than convert here?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "How about renaming `escape` to `use_path_normalized` or something to better indicate that it is a selection between `path` and `path_normalized`?" }, { "prediction": "I'm not sure if this is what you're looking for, but it's worth noting that it's a good idea to always return 0 when you don't want to return 0 when you don't want to return 0 when you don't want to return 0 when you don't want to return 0 when you don't want to return 0", "reference": "Interface members are always `static final` right?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "It seems to me that this could be in the runtime_nintendoswitch.go file, or is there a reason to keep it separate?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct. I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "I was actually looking at this code over the weekend and wondering whether we were trying to link here. I assume it's been cargo culted from something else in the compiler." }, { "prediction": "@@ -0,0 +1,14 @@ +
    + <%= f.label _('Name'), for: :name, class: \"control-label\" %> + <%= f.text_field :name, as: :string, class: \"form-control\", 'data-toggle': 'tooltip', title: _('Add an appropriate name for your guidance group. This name will be used to tell the end user where the guidance has come from. It will be appended to text identifying the theme e.g. \"[guidance group name]: guidance on data sharing\" so we suggest you just use the guidance group name instead of the guidance group name.'), 'aria-required': true %> +
    + +
    + <%= f.label :published, raw(\"#{f.check_box :published, 'data-toggle': 'tooltip', title: _('Check this box when you are ready for guidance associated with this group to appear on user\\'s plans.')} #{_('Published')}\") %> +
    + +
    + <%= f.label :optional_subset, raw(\"#{f.check_box :", "reference": "nice extraction of the form for being used at new/edit. We should have more of these" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Are the coefficients the actual bug fix?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Why are the error code options in a list and not a tuple?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Need alignment with the preceding line." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "Changing from a static method to a constant is inessential to Type Transactions and has a long reach, adding many unneeded files and diff lines." }, { "prediction": "@SuppressWarnings(\"unchecked\") public static TreeSet ofAll(java.lang.Iterable values) { Objects.requireNonNull(comparator, \"comparator is null\"); Objects.requireNonNull(values, \"values is null\"); return new TreeSet<>(RedBlackTree.ofAll(comparator, values)); } @SuppressWarnings(\"unchecked\") public static TreeSet ofAll(java.lang.Iterable values) { Objects.requireNonNull(comparator, \"comparator is null\"); Objects.requireNonNull(values, \"values is null\"); return new TreeSet<>(RedBlackTree.ofAll(comparator, values)); } @SuppressWarnings(\"unchecked\") public static TreeSet ofAll(java.lang.Iterable values) { Objects.requireNonNull(comparator, \"comparator is null\"); Objects.requireNonNull(values, \"values is null\"); return new TreeSet<>(RedBlackTree.ofAll(comparator, values)); } @SuppressWarnings(\"unchecked\") public static TreeSet ofAll(java.lang.Iterable values) { Objects.requireNonNull(comparator, \"comparator is null", "reference": "There is one caveat: javaslang.collection.Iterator is Iterable. With Iterator it does not work. Let's revert this line. Does this happen elsewhere, too? I will double-check the code..." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "Why change the default value of `is_diff`?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "I think tacking on `,<7` would be a wise precaution in case of future incompatible changes in tenacity." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "I don't think is necessary to remove the return type" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Also added this check, since client secret is not used except in the IP bypass scenario." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "That's unrelated, but shouldn't there also be a call to `setInternalWebPropertyID`, making it empty, for this case? Otherwise, when selecting to create a new property, any previous internal web property ID will still be in state, potentially causing problems." }, { "prediction": "I'm not sure if this is what you're trying to do, but it should work.", "reference": "I wonder if we should trigger a PHP error and ensure it ends up in the log?" }, { "prediction": "This test is off, verify the behavior. This test is off, verify the behavior. This test is off, verify the behavior. This test is off, verify the behavior. This test is off, verify the behavior. This test is off, verify the behavior. This test is off, verify the behavior. This test is off, verify the behavior. This test is off, verify the behavior. This test is off, verify the behavior. This test is off, verify the behavior. This test is off, verify the behavior. This test is off, verify the behavior. This test is off, verify the behavior. This test is off, verify the behavior. This test is off, verify the behavior. This test is off, verify the behavior. This test is off, verify the behavior. This test is off, verify the behavior. This test is off, verify the behavior. This test is off, verify the behavior. This test is off, verify the behavior.", "reference": "The `move_topic` action be a `post` request since it changes the state of the object." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Should we just return a non-nil metadata from `Test`?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it seems to be a bug.", "reference": "Noticing this is really just the same as cart_notification_email. Would be nice to be able to view custom templates. I may update this with some set up that will make viewing specific custom emails easily." }, { "prediction": "I think this is a bug. It is a bug. It is a bug. It should be fixed.", "reference": "please don't use wildcard imports" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "Should we even fix this test? IMO it should be refactored to check that values are recalculated after `setSourceDataAtCell` and `setSourceDataAtRowProp` calls. This will be the correct way to alter the data since now and we're not testing this use case." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to recalculate the last used directory -last_used_directory = None - - # All REFRESH_INTERVAL milliseconds, speeds will be recalculated and downloads will be # redrawn. _REFRESH_INTERVAL = 500 - - # All REFRESH_INTERVAL milliseconds, speeds will be recalculated and downloads will be # redrawn. _REFRESH_INTERVAL = 500 - - # All REFRESH_INTERVAL milliseconds, speeds will be recalculated and downloads will be # redrawn. _REFRESH_INTERVAL = 500 - - # All REFRESH_INTERVAL milliseconds, speeds will be recalculated and downloads will be # redrawn. _REFRESH_INTERVAL = 500 - - # All REFRESH_INTERVAL milliseconds, speeds will be recalculated and downloads will be # redrawn. _REFRESH_INTERVAL = 500 - - # All REFRESH_INTERVAL milliseconds, speeds will be recalculated and downloads will be # redrawn. _REFRESH_INTERVAL = 500 - - # All REFRESH_INTERVAL milliseconds, speeds will be recalculated and downloads will be # redrawn. _", "reference": "I'm not sure if this is standard practice, but I would prefer to leave this initialization here, if only to show that such a variable exists in this file (instead of inferring it from the globals). It can also cause weird issues if, for example, `init` isn't run before other methods." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "This isn't how you throw an exception in C++. I'd suggest you take a look elsewhere in the RDKit C++ codebase and see how ValueError exceptions are thrown. Hint: there's a function called `throw_value_error()` that you may find useful." }, { "prediction": "I'm not sure if this is the expected behavior, but it seems to be the expected behavior.", "reference": "Was changing this to a write transaction required?" }, { "prediction": "The `json:\"params\"` is the `json:\"params\"` parameter. The `json:\"params\"` parameter is the `json:\"params\"` parameter. The `json:\"params\"` parameter is the `json:\"params\"` parameter. The `json:\"params\"` parameter is the `json:\"params\"` parameter. The `json:\"params\"` parameter is the `json:\"params\"` parameter. The `json:\"params\"` parameter is the `json:\"params\"` parameter. The `json:\"params\"` parameter is the `json:\"params\"` parameter. The `json:\"params\"` parameter is the `json:\"params\"` parameter. The `json:\"params\"` parameter is the `json:\"params\"` parameter. The `json:\"params\"` parameter is the `json:\"params\"` parameter. The `json:\"params\"` parameter is the `json:\"params\"` parameter. The `json:\"params\"` parameter is the `json:\"params\"` parameter. The `json:\"params\"` parameter is the `json:\"params\"` parameter. The `json:\"params\"` parameter is the `json:\"params\"` parameter. The `json:\"", "reference": "nit: I think \"They\"?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "is it a result of some multiplication or some other meaningful number? would be nice to display as a power of something or the mult" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "I think this class is a good example of where Payload could significantly improve things. I'm okay with this class as it stands. If you merge this in, I'd like to have a go at refactoring it after introducing Payload." }, { "prediction": "@ -2,6 +2,7 @@ from __future__ import unicode_literals import unittest import os +import pytest import colander import mock", "reference": "Just a small tip: I think you don't need to include pytest here. You can run tests using: - `pytest tests/path/to/my/test` under the virtualenv to run a single test. - `pytest tests/` under the virtualenv to run all the tests. - `make tests` to run all the tests for all python versions, like travis do. Hope this helps! :)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Might be worth sorting the replacement items so this is deterministic." }, { "prediction": "I'm not sure if this will work, but I'm not sure if it will work.", "reference": "Should we set the default `TargetNamespace ` to `chaos-testing`? I noticed that the installation script defaults to chaos-testing." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Why was this `Task.Yield` removed? It was added in purpose." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure what's causing it.", "reference": "You'll also want to do this below, for the `optionalFieldConfigs`. See `GapicMethodConfig.java:180`." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug in ectx()->rctx()->session()->space() and not a bug in ectx()->rctx()->session()->space() and not a bug in ectx()->rctx()->session()->space()", "reference": "We'd better use \"spaceId\" as variable name here. Because i can't figure out the really type for \"space\" at the first glimpse due to \"auto\" used." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, or if it's the case, or if it's the case, but I'm not sure.", "reference": "I assume we have a package reference somewhere that pulls down the nuget package?" }, { "prediction": "This is for remote updates for connection accounting. It is not a good idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do this. It is a bad idea to do it. It is", "reference": "But why introduce publish on `accConnsEventSubjNew` subject if we never subscribe on that subject. What is the plan then? Replace subscription on \"old\" with \"new\" at one point? Not sure about all that.." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "can we use `nullptr` for consistency?" }, { "prediction": "I'm not sure if this is what you are looking for, but it seems to be a bug.", "reference": "strange, for templating\\EngineBundle it was `\\Symfony\\Bundle\\FrameworkBundle\\`" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "But if we're on the merge deployment, and the next one is the booted deployment, we'll still be inserting between the merge and booted deployment, right? It seems like we would need e.g. `met_merge` and `met_booted` vars to keep track." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Can you put the output of this into data, and list which roles are invalid? Same thing with abstract role. I know that's not strictly part of this PR, but it'd make the messaging about this a bunch better." }, { "prediction": "I'm not sure I'm getting this right, but I'm not sure I'm getting it right, so I'm not sure if I'm getting it right. I'm not sure if I'm getting it right, but I'm not sure if I'm getting it right, so I'm not sure if I'm getting it right, but I'm not sure if I'm getting it right.", "reference": "rename ibftTwo arg to bft" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Should we go ahead and push `agent_is_crawler?` into the `skip_session_tracking?` method?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "How about we raise a warning here and simply change to use self.data_infos = self.load_annotations(self.ann_file)" }, { "prediction": "This file is covered by the GNU General Public License. This file is covered by the GNU General Public License. This file is covered by the GNU General Public License. This file is covered by the GNU General Public License. This file is covered by the GNU General Public License. This file is covered by the GNU General Public License. This file is covered by the GNU General Public License. This file is covered by the GNU General Public License. This file is covered by the GNU General Public License. This file is covered by the GNU General Public License. This file is covered by the GNU General Public License. This file is covered by the GNU General Public License. This file is covered by the GNU General Public License. This file is covered by the GNU General Public License. This file is covered by the GNU General Public License. This file is covered by the GNU General Public License. This file is covered by the GNU General Public License. This file is covered by the GNU General Public License. This file is covered by the GNU General Public License. This file is covered by the GNU General Public License. This file is covered by the GNU General Public License. This file is covered by the GNU General Public License. This file is covered by the GNU General Public License. This file", "reference": "Please remove this line to comply with the standard for copyright headers." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "seems incorrect - for 5 validators it will tell that 3 is enough to seal and you need 4 2/3 * 5 is 3.3" }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so it's a bug.", "reference": "Nit: please remove unnecessary whitespace changes." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "Is this captured in a test?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "This is used in o.a.l.sandbox.search.LargeNumHitsTopDocsCollector." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this: https://docs.scipy.org/doc/scipy/optimize.html", "reference": "We may also do the same for `schedule_2x.py` and `schedule_20e.py`." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Should foreign key here be something like `diary_entry_id`? Or above, in `diary_entry.rb`, it should be `diary_entry_id`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "session is a new term. Should we call more like currentCommandBatch or something else?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "Will go fmt before squash." }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "Setting this to `true` means that it will always get merged in. The way merging is done here is that if a value is its zero value (`false` for `bool`), the value is considered unchanged. In order for this to work, you'll need to change this to be a `*bool` type instead." }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this, and that you're using the `json:\"json:\"json:\"json:\"json:\"json\"` `json:\"json:\"json\"` `json:\"json:\"json\"` `json:\"json:\"json\"` `json:\"json:\"json\"` `json:\"json:\"json\"` `json:\"json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json:\"json\"` `json", "reference": "It was decided that blockSignerAddress is not only redundant (use the miner owner public key instead which is already stored), but does not belong in config." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do.", "reference": "are we not asking for trouble here by not pinning this? or does 3.* imply all of the draft versions we'd try to validate?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "No, we want to compare `tm_py` and `tm_cpp` in this test." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "Let me know if we'd rather have this as an env variable." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "question: what is happening here?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "\\[Checkstyle\\] ERROR: 'protected' modifier out of order with the JLS suggestions\\." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "Can we use EJSON from bson here? and in doing so avoid bringing in the deprecated `mongodb-extjson` lib `const { EJSON } = require('bson')`" }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "So this parameter is now deprecated?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug in rseq_shared_fragment_flushtime_update() or rseq_shared_fragment_flushtime_update() or rseq_shared_fragment_flushtime_update() or rseq_shared_fragment_flushtime_update() or rseq_shared_fragment_flushtime_update() or rseq_shared_fragment_flushtime_update() or rseq_shared_fragment_flushtime_update() or rseq_shared_fragment_flushtime_update()", "reference": "Actually, it looks like HAVE_RSEQ is only used to determine whether the rseq.h header is around, which then only determines whether the regression test is built: it does not affect whether the core handles an application using rseq. The core rseq mangling code and all the code in rseq_linux.c is always enabled. I believe the idea is that we want DR built on one machine to work on as many others as possible, rather than requiring a custom build for every variant of kernel feature or whatnot. What is the top-level problem being solved here? If it requires disabling or enabling the core handling rseq, probably a separate option should be put in place and maybe HAVE_RSEQ renamed to make it clearer what its consequences are." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "I don't see a corresponding call to freeSelectorSet... am I missing something?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Is this part of spec?" }, { "prediction": "I'm not sure if this is a bug, but it is a bug, and it is a bug.", "reference": "Hmm, do we need to do this for Windows too? It won't have this private loader TLS issue but it will run DR code in a separate thread before DR init is fully done which I think violates some assumptions. For Windows we would move this wait from win32/os.c to win32/callback.s intercept_new_thread where it checks whether it's a client thread right before calling dynamo_thread_init. If you do not want to deal with Windows you could bail on my suggestion and leave the issue open (or maybe file a new issue) for Windows, or if you want to put the suggested core/win32/ change in place and your new test passes on Appveyor we could then claim to have fully solved this related issue too for all platforms." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like get_lambda_name_from_arn(arn) instead of get_lambda_name_from_arn(arn). I'm not sure if this is what you're looking for, but it seems like you're looking for something like get_lambda_name_from_arn(arn) instead of get_lambda_name_from_arn(arn).", "reference": "We can remove this function and use `lambda_function_name(..)` in this file instead." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to create a new NoopTransport. I'm not sure what you're trying to do, but I'm guessing you're trying to create a new NoopTransport.", "reference": "nitpick: `ApplicationVersion` could be `AppVersion`. It's smaller but gives the same understanding for purposes of the field." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "nit: maybe prefer `resp = &workflowservice.PollWorkflowTaskQueueResponse{}` over adding another function exit points especially for non-error cases?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "Do we specifically need to keep the read preference as a symbol for use elsewhere? If not, I think it would be cleaner to just modify the options before caching them in the `client_options` method so that we don't do this check every time. If we do need it a a symbol elsewhere, I'd suggest either putting `return @client if @client` at the top of the method (and changing the assignment below from `||=` to `=`) or moving this within the parenthetical block in the last assignment so that we don't repeat this work." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "Since this is for video only, should it be called `preferredVideoMimeType`? If we add it for pictures later, it will likely need to be a different option." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "That doesn't make sense. LayoutEntry doesn't match the generator concept." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I think the customer visible strings should be \"Service\" instead of \"Svc\" to make it obvious to them" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "Explain why this property is necessary?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "It should accept executions as the input" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it should be something like this:", "reference": "Is this limitation necessary?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": ":question: Should there be validation to ensure that only one of these attributes is used?" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "I would recommend using Psr\\Container\\ContainerInterface here instead of Interop\\Container\\ContainerInterface; both currently work, but the Interop version is deprecated and will eventually be removed, so using the Psr version will save us time in the future." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "This would also change back to /var/www/html/docroot if we go that way." }, { "prediction": "I think this is a bug. It should be fixed in the latest release.", "reference": "Does this need to be public? Can't one of the helper functions below pass the data? If it really needs to be public, could it be write-protected?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "Thanks. Now that you've improved this we should just init and expose the StorageAPI on the node, like the other.s" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "it will be better if you can provide some examples" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "\"return type\" and \"response type\" have never really been contrasted before, and it's unclear what their meaning is here. Could you clarify?" }, { "prediction": "This is a cross-subpackage import.", "reference": "Import order has been violated here." }, { "prediction": "I'm not sure if this is a bug or a bug, but it is a bug. I'm not sure if this is a bug, but it is a bug. I'm not sure if this is a bug, but it is a bug. I'm not sure if this is a bug, but it is a bug. I'm not sure if it is a bug. I'm not sure if this is a bug, but it is a bug. I'm not sure if this is a bug, but I'm not sure if it's a bug.", "reference": "Are you suggesting deleting the concept of message querying from plumbing (sounds like more trouble than its worth) or suggesting deleting the snapshot based implementation?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "I recommend using StringSliceVarP to resolve the label flag, like `-l key1=value1,key2=value2`. What do you think?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "@Samuell1 Will assigning the same icons array to all the tabs result in, for example, a primary tab called \"Colours\" and secondary tab called \"Colours\" having the same icon?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "A docstring for this function please." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but I'm sure it's what you're looking for.", "reference": "heads up @JunTaoLuo" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm correct, or if I'm correct, I'm wrong.", "reference": ".GetMethod() cannot return null now, correct?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Same thing here, I think the proper fix is elsewhere." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "errno is a global variable that might be set by any system library call. It is dangerous to rely on it except right after the system call where it is set. But in this code, it looks like the library call is buried inside ExpLOBInterfaceSelectCursor. It would be safer if the latter function saved errno after whatever system library call it calls, and returns that as an \"out\" parameter, which this code could then check." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "`hasattr` is kinda terrible; just append extra info in the subclass." }, { "prediction": "This is not a valid date format. It is a valid date format. It is a valid date format. It is a valid date format. It is not a valid date format. It is a valid date format.", "reference": "Fair warning, the way that exception block is written won't work in python3 Python 3.2.3 (default, Jun 8 2012, 05:36:09) [GCC 4.7.0 20120507 (Red Hat 4.7.0-5)] on linux2 Type \"help\", \"copyright\", \"credits\" or \"license\" for more information. > > > try: > > >... raise ValueError(\"foo\") > > >... except ValueError,e: > > > File \"\", line 3 > > > except ValueError, e: > > > ^ > > > SyntaxError: invalid syntax" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "This only updates the metadata and not the actual thing you are trying to solve for the docker hypervisor." }, { "prediction": "The OpenTelemetry Authors +// +// Licensed under the License, Version 2.0 (the \"License\"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an \"AS IS\" BASIS, or \"AS IS\" BASIS, or \"AS IS\" BASIS, or \"AS IS\" BASIS, or \"AS IS\" BASIS, or \"AS IS\" BASIS, or \"AS IS\" BASIS, or \"AS IS\" BASIS, or \"AS IS\" BASIS, or \"AS IS\" BASIS, or \"AS IS\" BASIS, or \"AS IS\" BASIS, or \"AS IS\" BASIS, or \"AS IS\" BASIS, or \"AS IS\" BASIS, or \"AS IS\" BASIS, or \"AS IS\" BASIS, or \"AS IS\" BASIS, or \"AS IS\" BASIS, or \"AS IS\"", "reference": "should this package be internal? don't we want to use it e.g. in go-contrib?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Just curious, why did you make this change?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Can you handle error cases such as `pd.get_dummies(pdf, prefix={\"A\": \"foo\"})`?" }, { "prediction": "I'm not sure if this is the correct way to do this, but I think it's the correct way to do it.", "reference": "Where is this environment variable being set?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "`module_class ` is already a class and `type(module_class)` always returns ``" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if it's what you're trying to do. I'm not sure if it's what you're trying to do, but I think it's what you're trying to do.", "reference": "Nit: The lambda can be replaced with a method reference: `SparkOrcWriter::new` I think." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "It would be nice to have a docstring that says what range of integer-like objects will be accepted, as well as what the int_like argument is meant for." }, { "prediction": "I think this is what you're looking for.", "reference": "How do we manage updates to this view down the road?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "We can revert this to reduce the diff of the PR." }, { "prediction": "I'm not sure if this is the expected behavior, but I'm not sure if it's the expected behavior.", "reference": "I think we should refactor or drop this test, as it is not testing the points format now, but IndexingChain/FieldsInfos' logic. Maybe we could rename the test `testMergeMissing` and configure the first segment to not have the `id` field at all." }, { "prediction": "I'm not sure what you're trying to do here, but I think it's a good idea to use a `bisect_` prefix to avoid naming collisions. I'm not sure what you're trying to do here, but it's a good idea to use a `bisect_` prefix to prevent naming collisions.", "reference": "not sure I follow why all this goes away?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "Is this `{clipboard}` or `{primary}`, as the deprecation message for `:paste-primary` says?" }, { "prediction": "I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "Human unreadable. IMHO user should input MYST value: 0.0006 @chompomonim, opinions?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this. I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this. I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "May be you could elaborate on why you removed this? I see some of this logic has been moved to ia2Web, but couldn't there be cases outside ia2Web (i.e. UIA) in which case ROLE_TABLEROW and ROLE_TABLECOLUMN are mapped to objects, in which case these objects will be of presentation type content erroneously?" }, { "prediction": "I don't think it's a bug, but I think it's a bug.", "reference": "This is not consistent. Either rename the first to `tradePlayerItem` (which is ugly) or the second to `partnerTradeItem` (:+1:)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "is there a reason we don't want to gx this dependency?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I'd suggest to add \"ATI \" and \"Intel(R) \" to this list" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "This is using a different lang key, we should switch it to using the new key and remove the old key if it is no longer used." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do. I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do. I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do. I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do. I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do. I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do. I'm guessing you're trying to do something like this, but I'm assuming you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "shouldn't this work? nodesRegex = regexp.MustCompile(api.SpecNodes + \"=(('[0-9A-Za-z,_-]+')|([0-9A-Za-z_-]+)),?\")" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "You mentioned this change was prompted because the `before_create` action was actually a defect. This will be done only for a new record; why is `before_validation`, which will be called repeatedly as accounts get updated and saved, correct whereas `before_create` is not? It looks like one would want to assign and activation code, etc., only once." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug, so I'm not sure if it's a bug or a bug.", "reference": "What's the rationale for a default setting to not use a GlobalSamplingRate of 1? I don't know much about the sampling rate stuff" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I'm guessing it's a bug, but I'm guessing it's a bug.", "reference": "Don't we know if it's 64 by this point? Do we have to test for the directory on every call, or can't we just split the value based on the platform?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "It's not async" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if this is the case, or if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "Maybe we could add some use of `exporterOptions` in this example, otherwise the proper code would replace this variable name with an underscore?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do. I'm assuming you're trying to do something like this, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Maybe would be better to rename it to \"onEveryKey\" or \"fireOnEveryKey\"." }, { "prediction": "public boolean isPreviewAllowed(FileMetadata fileMetadata) { if (fileMetadata == null) { return false; } else if (fileMetadata.isPreviewAllowed(fileDownloadHelper.fileMetadata)) { return true; } else { return fileDownloadHelper.isPreviewAllowed(fileMetadata); } } public boolean isPreviewAllowed(FileMetadata fileMetadata) { if (fileMetadata.isPreviewAllowed(fileDownloadHelper.fileMetadata) && fileDownloadHelper.isPreviewAllowed(fileDownloadHelper.fileMetadata) && fileDownloadHelper.isPreviewAllowed(fileMetadata) && fileDownloadHelper.isPreviewAllowed(fileMetadata) && fileDownloadHelper.isPreviewAllowed(fileMetadata) && fileDownloadHelper.isPreviewAllowed(fileMetadata) && fileDownloadHelper.isPreviewAllowed(fileMetadata) && fileDownloadHelper.isPreviewAllowed(fileMetadata) && fileDownloadHelper.isPreviewAllowed(fileMetadata) && fileDownloadHelper.isPreviewAllowed(fileMetadata) && fileDownloadHelper.isPreviewAllowed(fileMetadata) && fileDownloadHelper.isPreviewAllowed(fileMetadata) && fileDownloadHelper.isPreviewAllowed(fileMetadata) && fileDownloadHelper.isPreviewAllowed(fileMetadata) && fileDownloadHelper.", "reference": "if we're switching to calling FileDownloadHelper, we can just call that directly from the xhtml (see line 357 for example) and then remove this method completely. This is because the other thing it does is check PrivateURLUser, but the FileDownloadHelper method already does that. (and while we're at it, we can remove the method from FileUtil as this is the only place that method is called)" }, { "prediction": "@ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @", "reference": "is `fullName` still required as a parameter?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "This informational message is important to users. Please leave." }, { "prediction": "How do I configure this?", "reference": "Why do we want to remove this one? Are we planning to substitute it?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, and it's fixed.", "reference": "We may create an issue to track this so we don't forget?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "This file has the executable bit set." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "Improve the formatting of the message `.Infof(\"setting db capacity to: %v\", db.capacity)` There is a space before `:` and this way it is easier to see the formatting." }, { "prediction": "public static RTPSDomainImpl::find_local_reader( const GUID_t& reader_guid) { return RTPSDomainImpl::find_local_reader(reader_guid); }", "reference": "This lock cannot be released here, as it is protecting m_RTPSParticipants and the participant reference." }, { "prediction": "I'm not sure if this is the correct way to do this, but I think it's the correct way to do it.", "reference": "we'll need this in `_findAndModify` too" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, or if it's a bug.", "reference": "This is the fix for the crash. The function to create the intent to launch this activity requires `dbName`, so it has to be set to `null`. In such cases, the value for `dbName` will be set to `null` and cause issues throughout this activity. This adds a default value if the explicitly assigned value in `null`." }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it is a bug.", "reference": "Shouldn't we also trigger vision update here, so that if someone has caret highlighting enabled the correct character is highlighted?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug. I'm not sure if this is a bug, but I'm not sure if it's a bug.", "reference": "Woah, how does this change, which includes semicolons, result in the baseline change? Are the semicolon chars just part of the internal representation of the import type?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Can't you just use runnvda.bat here?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing it's a bug.", "reference": "these definitions of UNUSED aren't the same as the one you imported, so callers should be fixed (if any)" }, { "prediction": "IPAMNetworkConfig is a string. IPAMNetworkConfig is a string. IPAMNetworkConfig is a string. IPAMNetworkConfig. IPAMNetworkConfig is a string. IPAMNetworkConfig. IPAMNetworkConfig is a string. IPAMNetworkConfig. IPAMNetworkConfig is a string. IPAMNetworkConfig. IPAMNetworkConfig is a string. IPAMNetworkConfig. IPAMNetworkConfig. IPAMNetworkConfig is a string. IPAMNetworkConfig. IPAMNetworkConfig. IPAMNetworkConfig is a string. IPAMNetworkConfig. IPAMNetworkConfig. IPAMNetworkConfig is a string. IPAMNetworkConfig. IPAMNetworkConfig. IPAMNetworkConfig. IPAMNetworkConfig is a string. IPAMNetworkConfig. IPAMNetworkConfig. IPAMNetworkConfig. IPAMNetworkConfig is a string. IPAMNetworkConfig. IPAMNetworkConfig. IPAMNetworkConfig is a string. IPAMNetworkConfig. IPAMNetworkConfig. IPAMNetworkConfig is a string. IPAMNetworkConfig. IPAM", "reference": "is type a free string too?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "here input could be a normal function or an instance of torch.nn.Module." }, { "prediction": "I'm not sure if this is a bug or a bug, but it seems to be a bug.", "reference": "Example output: \"19.03.git.a7f4a860d0c\" At some point `nixpkgsVersion` was renamed to `version` since someone may use an old channel we fallback to `nixpkgsVersion` for backwards compatibility." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Class import is therefore redundant I guess :)" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "If parsing fails, don't act as no IP specified. Error out." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "... here the semicolon wanted to run away from the enum ;)" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case.", "reference": "Note that this is in the context of SolrCloud, so \"secondary\" doesn't apply and should be instead follower" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing that you're trying to get changesets by closed-ness and user, so I'm guessing that you're trying to get changesets by closed-ness and user, so I'm guessing that you're trying to get changesets by closed-ness and user, so I'm guessing that you're trying to get changesets by closed-ness and user, so I'm guessing that you're trying to get changesets by closed-ness and user, so I'm guessing that you're trying to get changesets by closed-ness and user, so I'm guessing that you're trying to get changesets by closed-ness and user, so I'm guessing that you're trying to get changesets by closed-ness and user, so I'm guessing that you're trying to get changesets by closed-ness and user, so I'm guessing that you're trying to get changesets by closed-ness and user, so I'm guessing that you're trying to get changesets by closed-ness and user.", "reference": "This one is a query parameter and probably really should be ID and in fact I'm mystified as to how this is working because the controller code definitely wants a number for that parameter so the test framework must be converting it back to an ID as best I can tell." }, { "prediction": "I'm not sure if this is the case, but if it is the case, I'm not sure if it's the case, but if it's the case, I'm not sure if it's the case, then I'm going to assume it's the case.", "reference": "Need to ensure this is set to TRU for LOB datatype access too not just for hive." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "You're using the Sphinx docstring style here (maybe because it's the default in PyCharm?). Instead, you should use the NumPy style (that you've also used in other places) to be more consistent with the rest of the project." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Don't really need this since the rest of the method will no-op but it's also safe to return early." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "Don't use relative paths. src directory is already on the include search path" }, { "prediction": "The.NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information.", "reference": "this file can be removed" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for, so I'm not sure if this is what you're looking for.", "reference": "Do we have test cases that name is null?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "in a separate PR, I'll check for a table that is empty/all-null and skip this function call completely." }, { "prediction": "I'm not sure if this is a bug or a bug, but it seems to be a bug.", "reference": "We really, really want to catch _everything_ here. It is safe to leave `azkabanEventReporter` set to null." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Can't we add the check here?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think you're trying to do something like this. I'm not sure if this is what you're trying to do, but I think you're trying to do something like this.", "reference": "body is being used here for the first time without every being populated. This will error. To run tests do `./go clean test_py` and that will run the Firefox tests" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Tell me if you have a better field name for this." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "FYI, I have a branch I started to improve this. Nuke can read the target frameworks from the project files, so we don't have to do this mess. Ran into some other issues so it didn't take priority" }, { "prediction": "I think it's a bug, but it's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug.", "reference": "This is just `mol->atomNeightors()`, is it?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do. I'm guessing you're trying to do something like this, but I'm not sure if this is what you're trying to do.", "reference": "This alias is just for a single occurrence. Maybe it ins't necessary?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so it's a bug.", "reference": "You can delete this `NONE` case." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm guessing it's a bug.", "reference": "@cnorthrop -- here is a test with a name change. Is this going to affect your internal CI?" }, { "prediction": "@ -24,4 +24,7 @ @ final class ChromeDriverCommand { private ChromeDriverCommand() {} static final String LAUNCH_APP = \"launchApp\"; + static final String SEND_COMMANDS_FOR_DOWNLOAD_CHROME_HEAD_LESS = \"sendCommandForDownloadChromeHeadLess\"; + static final String SEND_COMMANDS_FOR_DOWNLOAD_CHROME_HEAD_LESS = \"sendCommandForDownloadChromeHeadLess\"; + }", "reference": "Nit: `Headless` is one word, not two, and so doesn't need camelcasing in this way." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "I think this will cause a warning, can you set the default to zero (`0`)?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "confusing naming. Identity from \"id\" package :/ why we need alias here? (and in other imports)" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "It'd be nice to fix up existing configs with the change - that'd mean adding the option to `RENAMED_OPTIONS` in `config.py` and adding something like `_get_value_transformer({'true': '', 'false': '*'})` to `CHANGED_OPTIONS`. I think I never tried adding an option to both, but it should work." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "Perhaps use the new `.keys()` method here instead?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "We don't need this option because plan-preview is comparing between 2 commits, not using the live state." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I'm not sure about putting this in the options. I would see it living in an object and then being queried on through a class - a more object oriented, ruby solution." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm wrong, or if I'm wrong, or if I'm wrong, I'm not sure if I'm wrong, or if I'm wrong, or if I'm wrong, I'm wrong, or if I'm wrong, I'm wrong, or if I'm wrong, I'm wrong.", "reference": "So `Status` returns metrics?" }, { "prediction": "I think this is what you're looking for: https://github.com/rails/railscasts/blob/master/src/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/railscasts/rail", "reference": "Can we make a generic method say, `set_infographic_view` and in that method we can check the 4 values (outside_committers, portfolio_projects, outside_projects, affiliated_committers) and check against params[:action] and params[:view] and then trigger the respective method dynamically as it takes the standard argument(s) for all the four methods. What do you think?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Why would this be called to copy a non-Date object?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "This alignment issue had not appear because no multiple `Boolmsg`s had been serialized at once." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Why are we not implementing a BooleanDefaultFalse struct and replacing all of these config vars that default to false with that? Are \"default false\" config vars not affected by this bug?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Replaced this method with a ruby idiomatic setter." }, { "prediction": "The Forgotten Server - a free and open-source MMORPG server.", "reference": "wrong place hehe" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Can this be `test -e /var/run/mysqld/mysqld.sock` instead of `ls`? Using `ls` for noninteractive stuff is a recipe for sadness, IMHO. /cc @tianon" }, { "prediction": "The following list also lists all the `observers` associations for `observers` and `observers` associations for `observers`, `observers`, `observers` and `observers` associations for `observers`, `observers` and `observers`, `observers`, `client_data`, `client_data`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `requester`, `", "reference": "Are these `dependent: destroy` attributes intended to implement cascading deletes? I had assumed they were added because of the `paranoia` gem, but since that is no longer part of this PR, are they here as a best practice?" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed in the meantime.", "reference": "This approach would work only if there's a guarantee that the stream does not get freed before `establish_tunnel` is called, even though it _may_ enter CLOSE_WAIT state (at which point `stream->tunnel` is set to NULL). I do not think that assumption holds. Hence the alternate approach." }, { "prediction": "I don't think this is a bug, but it's a bug in the Nano PoW Server.", "reference": "Did you mean to remove the periods here while newly adding to other locations?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "the check can now be `if newLen < 0`" }, { "prediction": "\"k8s.io/kube-aggregator/pkg/apis/apiregistration/v1\" \"k8s.io/kube-aggregator/pkg/apis/apiregistration/v1\" \"k8s.io/kube-aggregator/pkg/apis/apiregistration/v1\" \"k8s.io/kube-aggregator/pkg/apis/apiregistration/v1\" \"k8s.io/kube-aggregator/pkg/apis/apiregistration/v1\" \"k8s.io/kube-aggregator/pkg/apis/apiregistration/v1\" \"k8s.io/kube-aggregator/pkg/apis/apiregistration/v1\" \"k8s.io/kube-aggregator/pkg/apis/apiregistration/v1\" \"k8s.io/kube-aggregator/pkg/apis/apiregistration/v1\" \"k8s.io/kube-aggregator/pkg/apis/apiregistration/v1\" \"k8s.io/kube-aggregator/pkg/", "reference": "If we're going to clean up this package, can we also remove those two `_` imports that appear to serve no purpose? (FWIW, they're also in the manager package too...)" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case.", "reference": "Won't this leak like a sieve? The caller can't delete this as one is a unique_ptr and one is not." }, { "prediction": "I think this is a bug in verdaccio. It should be fixed in verdaccio.js, but it should be fixed in verdaccio.js.", "reference": "form => from" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea to use a regular expression instead of a regular expression.", "reference": "Ok, we can't switch it now, because the properties are a field of the interface Rule - which makes it public API. Maybe we should remove it here in the (Java) API in 7.0.0? The only API left would be, when using a rule and setting the properties in the ruleset xml. There the type doesn't matter - since the String is then automatically converted into a Pattern." }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure.", "reference": "Pass in null here, instead of a value? Maaaaybe we should add an overload for `GapicProductConfig.create` that matches the original signature and passes through null? I don't feel strongly about that though, so happy to leave asis if you prefer." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Include all compounds parts from the very beginning for the case check to work later" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's the case, then it's a bug.", "reference": "if the user specifies a url scheme on the cli this is going to cause problems, no?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "How about that `scaleFactor`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "`assert(is_int($result));` would be preferable I think, even if we know it can't ever be false" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "I'm unfortunately unable to review whether you've changed everything that used to use cartIds" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Please don't touch unrelated files to keep the git history clean" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Per our style guide, I don't think we indent `private` keyword. Would you mind fixing that?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Will this change the input `heatmap`? Is this behavior expected or not?" }, { "prediction": "I don't think there's a way to do this. I don't think there's a way to do this. I don't think there's a way to do it. I don't think there's a way to do it. I don't think there's a way to do it. I don't think there's a way to do it. I don't think there's a way to do it. I don't think there's a way to do it. I don't think there's a way to do it. I don't think there's a way to do it. I don't think there's a way to do it. I don't think there's a way to do it. I don't think there's a way to do it.", "reference": "If I'm reading this right, this changes the parameter name so it'd constitute a breaking change :cold_sweat: Are we missing a test that should have been failing up until now?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Need copyright/license info." }, { "prediction": "I'm not sure if it's a bug, but it's a bug in k8s.io/api/admission/v1beta1 and k8s.io/apimachinery/pkg/apis/meta/v1beta1 and k8s.io/apimachinery/pkg/apis/rules/v1beta1 are the same. I'm not sure if it's a bug in k8s.io/apimachinery/pkg/apis/meta/v1beta1beta1 or a bug in k8s.io/apimachinery/pkg/apis/meta/v1beta1beta1 or a bug in k8s.io/apimachinery/pkg/apis/rules/v1beta1beta1 or a bug in k8s.io/apimachinery/pkg/apis/meta/v1beta1beta1 or a bug in k8s.io/apimachinery/pkg/apis/meta/v1beta1beta1 or a bug in k8s.io/apimachinery/pkg/apis/rules/v", "reference": "Is this `info log` necessary? If it is not useful, can you consider deleting it?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Unrelated change, but seems to be the correct purpose of the test." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "Should it be `'uppy-input-`?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "what's the reasoning to keep these always true or dead-code blocks?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "It would be a good practice to do `.off('click', '.tab-buttons > div').on('click', '.tab-buttons > div', function() {`" }, { "prediction": "should this be automatically enabled or disabled based on discovering the gateway + // api or a flag?", "reference": "I suggest that we rely on `--controllers='*,gateway-shim'` for now, and we can then move from `--controllers='*,gateway-shim'` to automatically enabling the Gateway API support on startup using the discovery API in 1.6 or 1.7, what do you think? Note that the logic I wrote in e5436df521015057e77de3fe02c174ea8a863b93 should also use this `GatewaySolverEnabled` flag I think." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing that you're trying to create a new instance of the BesuCommand class. I'm not sure what you're trying to do, but I'm guessing that you're trying to create a new instance of the BesuCommand class. I'm not sure what you're trying to do.", "reference": "I moved the instantiation of the signature algorithm here, to execute it before the native libraries are configured. Otherwise the wrong signature algorithm could be configured in a future release when more than one is supported in Besu." }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "Why remove this?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "`this.ieService_` should be initialized to null in the constructor." }, { "prediction": "I'm not sure if this is what you're trying to do, but it should be something like this:", "reference": "Why not `ebpf::BPF bpf;`? Assuming that the instance is not huge, I do not think there is a good reason to use a pointer when it can be retained as a value." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but it seems like you're looking for \"k8s.io/apimachinery/pkg/apis/meta/v1\" or \"k8s.io/apimachinery/pkg/apis/meta/v1\" or \"k8s.io/apimachinery/pkg/apis/meta/v1\" or \"k8s.io/apimachinery/pkg/apis/meta/v1\" or \"k8s.io/apimachinery/pkg/apis/meta/v1\" or \"k8s.io/apimachinery/pkg/apis/meta/v1\" or \"k8s.io/apimachinery/pkg/apis/meta/v1\" or \"k8s.io/apimachinery/pkg/apis/meta/v1\" or \"k8s.io/apimachinery/pkg/apis/meta/v1\" or \"k8s.io/apimachinery/pkg/apis", "reference": "nit: move to last block" }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to use the \"github.com/spiffe/spire/pkg/common/logger\" package in your code. I'm not sure what you're trying to do here, but it looks like you're trying to use the \"github.com/spiffe/spire/pkg/common/logger\" package in your code.", "reference": "nit: I'm under the impression that `log` is the convention for golang, and that the `er` suffix is usually reserved for interfaces" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Why is IsolationLevel fully qualified? System.Data is already in scope? What do I miss?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "do we still need SanityCheck()? seems they all return nil now" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "What I am missing in this PR, and I think we discussed that on the weekly meeting, is that all the code snippets that advise using `loadData` should be changed to one of the two new methods. Otherwise we send confusing mixed signals by promoting `loadData` everywhere in the guides. `loadData` is not deprecated, but is legacy." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Line is too long. [100/80]" }, { "prediction": "I'm not sure if this will work, but I'm not sure if this will work, but I'm not sure if this will work.", "reference": "I suggest \"no parent snapshot found, will read all data\\n\"." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but I think it's what you're looking for.", "reference": "`LogManager.ThrowExceptions = true` has very special meaning when unit-testing. Why the change to `LogFactory.ThrowExceptions = true` and enabling after the config-load?" }, { "prediction": "I'm not sure what you're trying to do, but I'm sure you're trying to do something like this.", "reference": "It should be return \"''\"; I will fix it" }, { "prediction": "I'm not sure I'm getting this right, but I'm not sure I'm getting it right. I'm not sure if I'm getting it right, but I'm not sure if I'm getting it right.", "reference": "This is wrong, should be `entry.getValue()`" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "nit: why can't we combine the two add operations into one so that we add `{\"nameCertificates\": []}` to `/spec/servingCerts`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm assuming you're trying to do something like this:", "reference": "These whitespace only changes make it very difficult to review this change. Is there any way you could separate just the code changes into one PR and the whitespace only fixes into another? Or are they sufficiently merged together at this point? Chrome is having a real tough time rendering these large diffs." }, { "prediction": "TheatreConfig is not a member of the Client class. It's a member of the Client class. It's a member of the TheatreConfig class.", "reference": "why does this suddenly need a config ref" }, { "prediction": "We can't load this up front because it's ES2015 and we don't need it. We can't load this up front because it's ES2015 and we need it only for certain tests that run under those conditions. We also can't load this up front because it's ES2015 and we need it only for certain tests that run under those conditions. We also can't load + // it via CDN because { included: false } won't work. + { pattern: 'custom-elements-es5-adapter.js', included: false }, { pattern: 'polyfills.js', watched: false }, { pattern: 'polyfills.js', watched: false }, { pattern: 'polyfills.js', watched: false }, { pattern: 'polyfills.js', watched: false }, { pattern: 'polyfills.js', watched: false }, { pattern: 'polyfills.js', watched: false }, { pattern: 'polyfills.js', watched: false }, { pattern: 'polyfills.js', watched: false }, { pattern: 'polyfills.js', watched: false }, { pattern: 'polyfills.js", "reference": "Unfortunately, I couldn't find a way to get karma to conditionally load stuff from a CDN, so I had to include it." }, { "prediction": "I'm not sure what you're trying to do, but it seems like you're trying to do something like this:", "reference": "Those functions are not currently wrapped, so I don't think it is necessary to exclude them (at least for now)." }, { "prediction": "This little bit of wrapping needs to be done because go doesn't do // covariance, but it does make it easier to write it out like so. So we need to move the *time.Timer into stoppable implicitly if we // write it out like so. -var afterFunc = func(c clock.Clock, d time.Duration, f func()) stoppable { +func afterFunc(c clock.Clock, d time.Duration, f func()) stoppable { t := c.NewTimer(d) } }", "reference": "Nit: since this is now a private function rather than a variable, would it make sense to move it after the public functions in this file for readability?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "I'm assuming that MolDraw2Qt drops the alpha channel?" }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "the code looks good to me, but I just wonder if it is a real use case: (de)serializing a single integer." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like \"Y3N@C80\". I think you're looking for something like \"Y3N@C80\". I think you're looking for something like \"Y3N@C80\". I think you're looking for something like \"Y3N@C80\". I think you're looking for something like \"Y3N@C80\". I think you're looking for something like \"Y3N@C80\". I think you're looking for something like \"Y3N@C80\". I think you're looking for something like \"Y3N@C80\".", "reference": "Pls remove the print statements. Also, you do not need the if statement." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to replace a string with a string. I'm not sure what you're trying to do, but I'm guessing you're trying to replace a string with a string. I'm not sure what you're trying to do.", "reference": "Thanks for this fix @eltone! Wondering if we should make this a bit more resilient to upstream changes, e.g., via a regex replacement. Not critical, though - we can pick that up in a follow-up PR.. Thanks" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Should this be instead a configurable option?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "unit test needs an update?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "I realised that this is not used anywhere" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "why add the default branch? this may cause there exist multiple configWatchers that notify the eventsCh at the same time?" }, { "prediction": "I'm not sure if this is the case, but if it is the case, it's probably the case.", "reference": "This line appears to have caused the regression. What is it supposed to be doing?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "@alanwest I noticed this while changing the code. I think we _might_ run into some race condition - if a scraper happens to hit the HTTP server before we could add the reader, what would happen (I guess we will hit exception, which turns into HTTP 500)? I haven't looked into the HTTP server logic. I think it _might_ be OKAY. A better version could be - we only start the HTTP server once the exporter/reader are fully ready and both are hooked up to the provider." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "As for Owin, I think we should exclude this URL in `IsNotServerLifeCheck` too?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Does it make sense to just fold these options back into the exporter options? My thinking is that this option is unlike the processor/metric reader options in that it actually is about the exporter itself." }, { "prediction": "@ -12,6 +12,6 @@ return [ 'failed' => '\u06cc\u06c1 \u062a\u0641\u0635\u06cc\u0644\u0627\u062a \u06c1\u0645\u0627\u0631\u06d2 \u0631\u06cc\u06a9\u0627\u0631\u0688 \u0633\u06d2 \u0645\u0637\u0627\u0628\u0642\u062a \u0646\u06c1\u06cc\u06ba \u0631\u06a9\u06be\u062a\u06cc\u06ba\u06d4', - 'throttle' => '\u0644\u0627\u06af \u0627\u0650\u0646 \u06a9\u0631\u0646\u06d2 \u06a9\u06cc \u0628\u06c1\u062a \u0632\u06cc\u0627\u062f\u06c1 \u06a9\u0648\u0634\u0634\u06cc\u06ba\u06d4 \u0628\u0631\u0627\u06c1\u0650 \u0645\u06c1\u0631\u0628\u0627\u0646\u06cc \u06a9\u0686\u06be \u0633\u06cc\u06a9\u0646\u0688 \u0645\u06cc\u06ba \u062f\u0648\u0628\u0627\u0631\u06c1 \u06a9\u0648\u0634\u0634 \u06a9\u0631\u06cc\u06ba\u06d4', ];", "reference": "here is `:seconds` missing" }, { "prediction": "I'm not sure what you're trying to do, but if you're trying to do something like this, you'll want to do something like this:", "reference": "change of name is not needed" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something that's not what you're looking for. I'm not sure if this is what you're looking for, but it seems like you're looking for something that's not what you're looking for.", "reference": "Hm.. so this case doesn't work anymore?" }, { "prediction": "I think this is a bug in qutebrowser.config.py. It should be fixed in qutebrowser.config.py.", "reference": "Please indent this so it lines up with the `(`" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "We should still register the script. Just not enqueue it." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "I think this can stay as a method. And we can write our own attribute_change(name) as required." }, { "prediction": "public override void OnBindViewHolder(AndroidX.RecyclerView.Widget.RecyclerView.ViewHolder holder, int position) { } public override void OnBindViewHolder(AndroidX.RecyclerView.Widget.RecyclerView.ViewHolder holder, int position) { } public override void OnBindViewHolder(AndroidX.RecyclerView.Widget.RecyclerView.ViewHolder holder, int position) { } public override void OnBindViewHolder(AndroidX.RecyclerView.Widget.RecyclerView.ViewHolder holder, int position) { } public override void OnBindViewHolder(AndroidX.RecyclerView.Widget.RecyclerView.ViewHolder holder, int position) { } public override void OnBindViewHolder(AndroidX.RecyclerView.Widget.RecyclerView.ViewHolder holder, int position) { } public override void OnBindViewHolder(AndroidX.RecyclerView.Widget.RecyclerView.ViewHolder holder, int position) { } public override void OnBindViewHolder(AndroidX.RecyclerView.Widget.RecyclerView.ViewHolder holder, int position) { } public override void OnBindViewHolder(AndroidX.RecyclerView.Widget.RecyclerView.ViewHolder holder, int position) { } public override void OnBindViewHolder(AndroidX.RecyclerView.Widget.RecyclerView.ViewHolder holder, int position) { } public override void OnBindViewHolder(AndroidX.RecyclerView.Widget.RecyclerView", "reference": "@alexshikov @Cheesebaron I might be missing something but isn't the viewType parameter here the actual layout resource id? Why would the GetItemLayoutId method need to be called again? On line 127, the exact same method is called except this time passing in the index of the object in the backing data source, which makes sense - the template selector can return the layout id based on the index of the item in the list." }, { "prediction": "I think this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Can you change this to use `.format()`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Maybe the parameter should be consulted higher up the stack so that we only set dropEncap if we're rendering a workload egress chain and the flag is set?" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "new casing is less ELiTE" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "This leaks EGL/GL implementation details into the generic renderer interface." }, { "prediction": "The `deploy.on` should be a hash with key `deploy.on` and an array as a value.", "reference": "Maybe add *key* i.e. `\"The \\\\`deploy.on\\\\` key should be a hash (dictionary).`" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "its be good also change $code na $id, actual name is misleading and that was probably actual error generator" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this.", "reference": "I changed the name of the key, to make deployment easier." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug.", "reference": "isn't this going to be true by default? if yes, then let's have the env var named `ECS_DISABLE_SPOT_INSTANCE_DRAINING` and have default as false." }, { "prediction": "It's not necessary to use the `__future__` for this. It's necessary to use `__future__` for this. It's not necessary to use `__future__` for this. It's necessary to use `__future__` for this. It's not necessary to use `__future__` for this. It's necessary to use `__future__` if you want to use `__future__`, `__future__`, `__future__`, `__future__`, `__future__`, `__future__`, or `__future__` if you want to use `__future__`, `__future__`, or `__future__`, or `__future__` if you want to use `__future__`, or `__future__`, or `__future__`, or `__future__` if you want to use `__future__`, or `__future__`, or `__future__`, or `__future__`, or `__future__`, or `__future__`, or `__future__`, or `__future__`, or `__future__` if you want to use `__future__`, or `__future__`,", "reference": "Do you think we might need this anywhere else in HoloViews?" }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it, so I'm not sure if this is the correct way to do it.", "reference": "@MrTimscampi don't we want to remove this term entirely? Might as well do it now if that's the case." }, { "prediction": "You can use the ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "I have followed the convention of `cp`" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems to be a bug.", "reference": "The docs say it's `false|null`" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Thinking on it more, I actually really like your idea to rename `type` to `factor`." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "This error message is redundant. All of this information is included in the stack trace. In general it's a good idea to avoid using method names in error messages. Chances are the method will be renamed at some point, but the string won't be updated accordingly. Then you'll end up with a very confusing error message. I suggest changing the message to: \"Failed to unblock network loads. Missing INTERNET permission?\"" }, { "prediction": "This file is not part of the GNU General Public License. It is a part of the GNU General Public License. It is a part of the GNU General Public License. It is a part of the GNU General Public License. It is a part of the GNU General Public License. It is a part of the GNU General Public License. It is a part of the GNU General Public License. It is a part of the GNU General Public License. It is a part of the GNU General Public License. It is a part of the GNU General Public License. It is a part of the GNU General Public License. It is a part of the GNU General Public License. It is a part of the GNU General Public License. It is a part of the GNU General Public License. It is a part of the GNU General Public License.", "reference": "Feel free to add your own name while at it." }, { "prediction": "@ -30,11 +30,11 @@ import ( ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "`signer` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do this in the wrong way.", "reference": "shouldn't this be `&& opts[:localize]` (i.e. both nil and false skip localization?)" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to import a range_func from a range_func, so you'll need to import a range_func from a range_func import range_func from a range_func import range_func from a range_func import range_func from a range_func import range_func from a range_func import range_func import range_func from a range_func import range_func from a range_func import range_func import range_func from a range_func import range_func import range_func from a range_func import range_func import range_func from a range_func import range_func import range_func from a range_func import range_func import range_func from a range_func import range_func import range_func from a range_func import range_func import range_func from a range_func import range_func import range_func from a range_func import range_func import range_func from a range_func import range_func import range_func from a range_func import range_func import range_func from a range_func import range", "reference": "This can also be removed." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Not critical but \"common\" is not that helpful in the commit title. Maybe go with \"libkvs/txn:\" for this one?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "It's been a while, but I just noticed this was wrong: It migrated `True` to `when-searching` (so people with `scrolling.bar = True` suddenly didn't have scrollbars anymore) and `False` to never. Instead, it should migrate `True` to `always` (no behavior change) and `False` to `when-searching` (so people notice the new feature). I fixed this in cc0f5fc6d400e12833ba729049e31d16cf836d53." }, { "prediction": "I'm not sure if this is what you're looking for, but if it's what you're looking for, it's probably what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": ".decode(sys.getfilesystemencoding()) will be better. Although I think rrdtool should accept bytes.." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but I think it's what you're looking for.", "reference": "An interface call per header might be more expensive than we want to pay. Do we really need this to be abstracted? I think a parser abstraction makes sense, but it seems to me like a separate abstraction for handling headers (one by one) might be an overkill." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Resharper annotations, always +1" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "same here, CryptoSm2 won't be changed once command is compiled" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Loading the login page after the certificate has been loaded. Views can only be loaded from UI thread." }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this:", "reference": "Technically it doesn't belong here; let me remove it." }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "remember to update the hash once the upstream PR is merged" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "Sends the incoming message to the decryptor, which will then forward it to the interface once processing is complete." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "FYI This will go the other way, with nil being the correct value for \"no params\"" }, { "prediction": "I'm not sure if this is the case, but if it's the case, it's the case.", "reference": "Is this necessary? Are there duplicates in your LibKeyIndex?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "Why will the gomock files be regenerated? It seems to be irrelevant" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "I'm very curious about why using buffered-channel. Is there something wrong to use an unbuffered channel with zero capacity?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, and it's fixed in the latest version of Luigi.", "reference": "It seems like you accidentally pulled some unrelated changes to util_test into this." }, { "prediction": "If you are using Nethermind.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.Blockchain.", "reference": "do not toucm NDM please - there will be lots of conflicts" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "This looks legitimate - Would cause a classCastException. But have we ever seen it in the wild?" }, { "prediction": "I think this is a bug in the testinfra package. It should be fixed in the testinfra package.", "reference": "This looks out of scope for this particular PR." }, { "prediction": "I'm not sure if this will work, but I'm not sure if this will work.", "reference": "Don't need () if only one." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Why not have mailPort as int since your are already parsing while calling t.connect?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like 'tornado' or 'python-daemon<3.0' or 'python-daemon<3.0' if os.environ.get('READTHEDOCS', None) == 'True': install_requires = [ 'tornado', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0', 'python-daemon<3.0", "reference": "In the future, do not remove these trailing commas as they have the purpose of making append-diffs easier to read. :)" }, { "prediction": "I think this is what you're looking for.", "reference": "Was this added by accident? It doesn't seem related to Syndetics, and I don't think it should be necessary in core VuFind (but maybe it's related to one of your local customizations)." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "i know the ergonomics are a little nicer with map[string]bool, but I prefer map[string]struct{} for sets for a few reasons: 1 - optimized storage (not very relevant here) 2 - don't have to think about the conditions where the key exists in the map or if the value could somehow be false" }, { "prediction": "@ -69,6 +69,7 @@ const ( History Matching Worker + Server NumServices )", "reference": "This is very unclear what Server means. We need a better name, maybe ServerExtension?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it should work.", "reference": "I wonder if we should trigger a PHP error and ensure it ends up in the log?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Hmmm not sure about this. Is it fine @ar2rsawseen?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Why do you prefer `go` over `run`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this should be enough.", "reference": "Unintentional, please remove" }, { "prediction": "I think this is what you're looking for.", "reference": "What was the reason behind moving this?" }, { "prediction": "@trace_tags.map { tag.tag.rstrip.join(\" \") } %> <% if @trace_tags.length > 0 %> - <%= t \"user_mailer.gpx_notification.and_no_tags\" %> - <%= @trace_tags.map { tag.tag.rstrip.join(\" \") } %> <% else %> - <%= t \"user_mailer.gpx_notification.and_no_tags\" %> - <%= @trace_tags.map { tag.tag.rstrip.join(\" \") } %> <% end %> <% else %> - <%= t \"user_mailer.gpx_notification.and_no_tags\" %> - <%= @trace_tags.map { tag.tag.rstrip.join(\" \") } %> <% end %> <% end %> <% else %> - <%= t \"user_mailer.gpx_notification.and_no_tags\" %> - <%= @trace_tags.map { tag.tag.rstrip.join(\" \") } %> <% end %> <% end %>", "reference": "Did you mean to put that `join` after the `map` rather than inside it? Also should it be `safe_join` or is interpolating it into an `_html` resource going to have much the same effect>" }, { "prediction": "I'm not sure if this is a synced Realm or a synced Realm, but I'm not sure if this is a synced Realm or a synced Realm. I'm not sure if this is a synced Realm or a synced Realm, but I'm not sure if this is a synced Realm or a synced Realm. I'm not sure if this is a synced Realm or a synced Realm, but I'm not sure if this is a synced Realm.", "reference": "`Indicates if this Realm has been closed.`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "how is this change adding corr to Series? Do all the methods that are added to Frame automatically get added to Series?" }, { "prediction": "I'm not sure if this is a bug, but if it's a bug, it should be fixed.", "reference": "Just a heads up for anyone else reviewing this, this logic and all the repetitions of it should be greatly simplified by subsequent work relating to issue #2552." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "@billwert I have kept the `1000` InvocationsPerIteration, but do note this is very small for the small types." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "Unrelated whitespace change." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "Slight formatting issue here. There should be a space after the asterisk." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Slight preference for declaring variables inline rather than at the top of the function. That way you can use const for both of these." }, { "prediction": "I think this is a bug, but it's a bug, and it's fixed in the latest release.", "reference": "this is a duplicate file of the one in demo-schema. please remove this file." }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "Nit: unified names between geth and contracts" }, { "prediction": "This is a bit awkward, but it's a bit awkward. It's a bit awkward, but it's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awkward. It's a bit awk", "reference": "Necessary? Could you just use DefaultBuildState here?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "linked hashmap retains order" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "And the old names for these variables made more sense imo." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Are you sure this change is correct?" }, { "prediction": "I'm not sure if this is a bug, but if it's a bug, it's a bug.", "reference": "The previously linked bug does not apply anymore? If so, this is LGTM!" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Why are we renaming all of the tests?" }, { "prediction": "I think this is a bug in the RFC2136 provider. It should be fixed in the RFC2136 provider. It should be fixed in the RFC2136 provider. It should be fixed in the RFC2136 provider.", "reference": "Instead of having this logic, would it make sense to require *users* to encompass the specified IPv6 address within `[` and `]`? Why the magic handling here?" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, so I'm not sure if it's a bug.", "reference": "Why not also replace this one with calls to `GetProp`?" }, { "prediction": "I'm not sure if this is what you're looking for, but if it's what you're looking for, you can do something like this:", "reference": "Still need to remove trailing spaces on this line" }, { "prediction": "This is not a bug. It is a bug. It is a bug. It is a bug. It is a bug.", "reference": "Please use the `@Experimental` annotation on this" }, { "prediction": "I think this is a bug. It should be fixed in a future release.", "reference": "I found ~10 more instances of this typo. we can fix those in subsequent PRs." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "How about making metricNamespace an option, and by default it's the same as `component`? e.g.m Init(component, WithMetricNamespace(\"trigger\"))" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Just checking: no need for case manipulation?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Same as above, not that descriptive" }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so it's a bug.", "reference": "> i#4670 signl-interrupted special ibl xfer frag: Unlink if signal pending nit: This looks like one of many commits with the text before the colon. nit: On the long side: 56 or 60 chars is what some views show Spelling error." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, or if it's a bug.", "reference": "Should we need to invoke pthread_cancel?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "this is auto generated file so no changes are allowed here" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "All buttons are submit buttons, except if they are `type=reset` or `type=button`. I suggest you do an exclude of those, rather than only include `button[type=submit]`." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "can you please make this multi line, this version is hard to read." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "For consistency, it's best to either always use strict equality (`===`) or loose equality (`==`) in `typeof` checks, and to not mix them." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Work Orders would never have only one approver, right?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "`code` is written to the message as a `byte`, so I think it's better to declare it in the enum as `byte` as well to avoid a narrowing primitive conversion from `int` to `byte` in runtime." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "This is the only \"extra\" change here." }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to create a new default validator for outbound messages. I'm assuming you're trying to create a new default validator for outbound messages. I'm assuming you're trying to create a new default validator for outbound messages. I'm assuming you're trying to create a new default validator for outbound messages. I'm assuming you're trying to create a new default validator for outbound messages. I'm assuming you're trying to create a new default validator for outbound messages. I'm assuming you're trying to create a new default validator for outbound messages. I'm assuming you're trying to create a new default validator for outbound messages. I'm assuming you're trying to create a new default validator for outbound messages. I'm assuming you're trying to create a new default validator for outbound messages. I'm assuming you're trying to create a new default validator for outbound messages.", "reference": "Please TODO and link to an issue for changing this." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Can we make the script output trailing commas?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "This file should get a file header" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "maybe we need process the os error more safely and friendly when open file failed, because this error is very common when cpu has a high pressure, crash directly is danger." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "we need to pay attention not to use this flag everywhere." }, { "prediction": "@ -22,7 +22,6 @@ import ( ) type Protocol string -type TableIDType uint8 type GroupIDType uint32 type MeterIDType uint32", "reference": "curious about this change, since it is not mentioned in the commit message and now we have `uint8` all over the place" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "wait, are we not mising `WithStamp` here?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems to be a bug.", "reference": "oh. didn't know we store this stage progress." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for, so I'm not sure if this is what you're looking for.", "reference": "Going with definition from here: > Does Unicode have private-use characters? > A: Yes. There are three ranges of private-use characters in the standard. The main range in the BMP is U+E000..U+F8FF, containing 6,400 private-use characters. That range is often referred to as the Private Use Area (PUA). But there are also two large ranges of supplementary private-use characters, consisting of most of the code points on Planes 15 and 16: U+F0000..U+FFFFD and U+100000..U+10FFFD. Together those ranges allocate another 131,068 private-use characters. Altogether, then, there are 137,468 private-use characters in Unicode. It looks like we are only ignoring ones in BMP and not the supplementary private-use characters. Shouldn't we consider the supplementary ones too?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to create a new Type\\Atomic\\TLiteralInt. I'm guessing you're trying to create a new Type\\Atomic\\TLiteralInt. I'm guessing you're trying to create a new Type\\Atomic\\TLiteralInt. I'm guessing you're trying to create a new Type\\Atomic\\TLiteralInt. I'm guessing you're trying to create a new Type\\Atomic\\TLiteralInt. I'm guessing you're trying to create a new Type\\Atomic\\TLiteralInt. I'm guessing you're trying to create a new Type\\Atomic\\TLiteralInt. I'm guessing you're trying to create a new Type\\Atomic\\TLiteralInt.", "reference": "This change is un-tested and requires testing" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case.", "reference": "Should the docstring mention the vscode option?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "ISTM that since `artman` know the \"real\" value of the GAPIC config name, it should pass that value to toolkit, rather than toolkit guessing the name based on a heuristic. Then again, I don't know what this value actually does for Java codegen..." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but it seems like you're looking for \"github.com/sirupsen/logrus\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcal", "reference": "Please back out the import changes in files you haven't touched. I think these happen if you run goimports without having the vendor directory populated" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems to be a bug.", "reference": "Should this be `ISocketOutput where T : struct`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "In which case will this actually return 0? If there is no snapshot, then there is no `Snapshot` object, right?" }, { "prediction": "The `num_classes` `should be a tuple of str``````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````", "reference": "This part of code is valuable and necessary. Can we move it to another place for a more clear logic and only check it once? For example, move it to line 133 before delving into each module." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Are we at all worried that changing pins will cause release hiccups? I think we've decided that relaxing pins should be safe but adding pins has caused us build issues in the past - so I think we're fine?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "could you please explain a bit where these numbers come from? for example: why is there no `swarm.EncryptedSectionSize`?" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "s/object content/blob object/ (for consistency with the `Size` docs)" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug.", "reference": "Rather than deleting this entirely, could we just emit it as a `warn` or `info` log line?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Is there a chance of this being a BC break of somekind? I.e. what if an old instance of Caddy is running in a cluster with a newer one?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Thanks for this... is this the only place where the rollback is needed? Are there others?" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "Should this also be a pointer? What happens if there are no BLS messages? I guess that's what this test is exercising, and Lotus also uses a non-pointer here." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this.", "reference": "This was definitely a subtle bug right here." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "If this method gets all the emails, it should be named appropriately. **all_emails** or just **emails**." }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "Can we still random, but if we randomly get a port is used before, we randomly pick again?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "I would rather no have this as a `kwarg` as it encourages \"growth\" which lead to an unweildy constructor in other classes. Let's add a method or property to take care of this instead as I think it's usage is going to be quite low." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "what if a purchaser is also an approver? or would that not happen?" }, { "prediction": "I'm not sure if this is the case, but if it's the case, it's the case.", "reference": "Not sure why this change. You forgot to handle the case where the user has dynamic fees disabled and there are no fee estimates available. He should be able to sweep none-the-less (as he is using static fees anyway). The line with `config.fee_per_kb()` below, that you have deleted, handled that." }, { "prediction": "IsHappy() returns true if the resource is ready overall. IsHappy() returns true if the resource is ready overall. IsHappy() returns true if the resource is ready overall. IsHappy() returns true if the resource is ready overall. IsHappy() returns true if the resource is ready overall. IsHappy() returns true if the resource is ready overall. IsHappy() returns true if the resource is ready overall. IsHappy() returns true if the resource is ready overall. IsHappy() returns true if the resource is ready overall. IsHappy() returns true if the resource is ready overall. IsHappy() returns true if the resource is ready overall.", "reference": "sorry, I wasn't familiar with this TopLevelCondition... What it would be in this case? The AuditsLogReady condition?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "Where does the `alloc` field get set?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "looks expensive to do it on each query" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "@rhyolight -- but weren't we supposed to be standardizing on using underscores in file names (versus camelcase)?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Can this simply call `in_memory.empty?`?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if this is the case, but I'm not sure if it's the case.", "reference": "The styling/wording here probably needs some thought. It's more of a placeholder." }, { "prediction": "I think this is what you are looking for: https://docs.djangoproject.com/en/dev/ref/models/password_resets/", "reference": "Using a plural route helps in detecting the path automatically for `= form_for @password_reset`." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug.", "reference": "Is `metadata` required on all tests? I actually just removed the metadata field entirely from a few tests in my PR." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "seems reasonable to also want to include the 'to' location?" }, { "prediction": "public boolean deleteBaseDir() { return deleteBaseDir(); } public boolean deleteBaseDir() { return deleteBaseDir(); } public boolean deleteBaseDir() { return deleteBaseDir(); } public boolean deleteBaseDir() { return deleteBaseDir(); } public boolean deleteBaseDir() { return deleteBaseDir(); } public boolean deleteBaseDir() { return deleteBaseDir(); } public boolean deleteBaseDir() { return deleteBaseDir(); } public boolean deleteBaseDir() { return deleteBaseDir(); } public boolean deleteBaseDir() { return deleteBaseDir(); }", "reference": "I don't think we need to necessarily check if that returned true or not, we should just remove the shutdown hook. Since nothing would check or do anything with this flag anyways." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug. I'm not sure if this is a bug, but I think it's a bug.", "reference": "Better to push getting policy details into a func we can reuse later." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "optional: while there's nothing to do, a good way to catch bugs (where we use an outbound without calling `Start`) might be to have this outbound verify that `Start` is called before `Call` or `Stop`" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but it's what you're looking for.", "reference": "Not a blocker by any means, but I think there is value in keeping the local imports in a separate group." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "nit - I would test the error message as well. For panic, you might need to see if the stack contains the error message, instead of equaling." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "Didn't we have specific logic for handling slices vs structs?" }, { "prediction": "I don't think this is a bug, but I think it's a bug.", "reference": "`c_str()` is not needed." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "The handler will be installed twice if you don't remove the below one." }, { "prediction": "I'm not sure if this is what you're looking for, but it's what you're looking for. I'm not sure if this is what you're looking for, but it's what you're looking for. I'm not sure if this is what you're looking for.", "reference": "How about putting `epochLength` (or something like that) in place of `a` just to make it easier to read" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Wouldn't this still fire afterwards if you created one called `pleasings`? or am I missing something?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, and it's a bug.", "reference": "I don't love this syntax; it doesn't match anything we're currently doing and it's not obvious. Why isn't this `/keybase/private/jzila,kb_bot/.kbfs_autogit/public/jzila/kbp.git`?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's what you're trying to do, so it's probably not what you're trying to do.", "reference": "Does a type-hint work instead of casting? `return ofAll(toList(). zipWith(that, mapper));` (Probably not, just a question.)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Are these required?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "This is consistent for all clients that we will check yes? Seems like we should just use the singleton, maybe pass it to the parse function or since clients have a server pointer set it at server start and just access that way without locks?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or a bug", "reference": "Note that this is a bug, that should be fixed on master. `DECIMAL_LITERAL` cannot match any token, because it's declared with a `#`." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "Don't need extra line here." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "For the first look, this change is strange. Were we passing these tests before?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "On Windows, doesn't `os.Args[0]` include the `.exe`? What if you run the program like `caddy.exe`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "I don't see anywhere where `ServiceConfiguration` interface implementation would return any kind of error. Not sure if its needed, but we could ALWAYS return a valid 'pseudo' configuration without possibility of error." }, { "prediction": "We don't care which form of line break is used. So we don't care which form of line break is used. So we don't care which form of line break is used. So we don't care which form of line break is used. So we don't care which form of line break is used. So we don't care which form of line break is used. So we don't care which form of line break is used. So we don't care which form of line break is used. So we don't care which form of line break is used. So we don't care which form of line break is used. So we don't care which form of line break is used.", "reference": "Do we actually want to split on `\\r`? I thought that the \"newline sequence\" was only `\\r\\n` on windows." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but if I'm correct, I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "Nit: these lines are duplicated from above. They can be refactored by setting etype in a conditional and putting 282 and 283 below that." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "I would do an s.Notice(\"Initiating Shutdown...\") then after Shutdown() do the original Server Exiting." }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if it's the correct way to do it.", "reference": "Not sure with how many seconds on average are we dealing with but maybe it's better to have hh:mm:ss format in logs - you can make it with `TimeSpan.FromSeconds(seconds).ToString()`" }, { "prediction": "I'm not sure if this is the correct way to do it, but it should work.", "reference": "Why is this required? The user should be able to omit it and use the defaults." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "I don't think the naming of this setting conveys what it does. Maybe something like \"Ignore mouse movement triggered by other applications\"" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "Didn't went with backwards compatibility since it's still in beta" }, { "prediction": "I'm not sure if I'm correct, but if I'm correct, I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "Perhaps bondsToCut must be None or non empty." }, { "prediction": "I think this is what you are looking for: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String/String", "reference": "See above, we could avoid adding that (same applies below)." }, { "prediction": "@ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @", "reference": "should use Number instead of Long" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Should the rest of the file be updated to use `expect` or should this test use the same format as the rest of the tests?" }, { "prediction": "I'm not sure if this is the correct way to do it, but it should work.", "reference": "How would you feel about a different approach where the `DeleteAWSRecordSets` gets passed the zone ID and zone name rather than the `DNSZone`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "it seems `random.uniform(0, 1)` similar to `random.randint(2)`, all have 1/2 probabilities." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Added to support EBS volume creation, used like this: blockDeviceMap = [] blockDeviceMap.append( {'DeviceName':'/dev/sdc', 'VirtualName' : 'ephemeral0'}) blockDeviceMap.append( {'DeviceName':'/dev/sdh', 'Ebs': {'VolumeSize' : '100'} })" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "We shouldn't depend that url is `mysterium` - it can be just `testRequestURL`. Also, `URL` has to be upper-case." }, { "prediction": "Is this a ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````", "reference": "We could delay this look-up now and only do it in the non-skip case. I suspect this is true for (almost) all of the top-level refactored functions." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "Typically, to be simple, we could reserve a const length space." }, { "prediction": "@ -0,0 +1,2 @@ +from.reader import * +from.builder import *", "reference": "Need to add a license and copyright header to each file." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "If I'm not mistaken, this line is now outside of the `if signed_out?` block, right? Any concerns about that? Seems odd that we wouldn't accept coupons for signed in users, but I want to make sure we understand the ramifications of this change." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Please remove the unused import of DBPDataSource." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "I think you should add some extra message here saying it was originally sent as an error, for diagnosability." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do. I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do. I'm assuming you're trying to do something like this, so I'm not sure what you're doing. I'm assuming you're trying to do something like this, but I'm not sure what you're doing. I'm assuming you're trying to do something like this, but I'm not sure what you're doing. I'm assuming you're trying to do something like this, so I'm not sure what you're trying to do. I'm assuming you're trying to do something like this, but I'm not sure what you're trying to do. I'm assuming you're trying to do something like this, so I'm not sure what you're doing. I'm assuming you're doing something like this", "reference": "I believe that all the changes in this file are not valid for v1.2 of the Avalon toolkit." }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "we cannot change the behavior of the processRole - that method is used in lots of places. this call must be done only in the method where templates are being handled." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "I think we probably want to follow the same naming convention that we do with `execAgentConfigFileNameTemplate` (using the SHA in the name of the file). This file might be confgurable in the future and when that happens we will be ready. Plus it's pretty much the same code that we already use for the config file." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it should be something like this:", "reference": "If following above, this would be: end_time = time(0) + manual_wall_time_option, which is simpler. Also, make the check manual_wall_time_option > 0, otherwise negative times would terminate the worker right away." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "If we aren't using `errors.Is` we don't need the `Unwrap` as we have `Cause` which is what pkg/errors uses." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "redundant empty line" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "The config.lua.dist still shows `houseAccountOwner`" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm wrong, or if I'm wrong, I'm wrong, or if I'm wrong, I'm wrong.", "reference": "I think we can leave this import and use non FQNs in the code." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "I'd rather just send the parameter twice than break encapsulation here. There's already precedence with webelement IDs" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "We should probably exit early if there are no items in the list." }, { "prediction": "This is a test docstring without params.", "reference": "As we can't use old names we should warn in whats new for 2.12 that this can happen." }, { "prediction": "I think this is what you are looking for, but I'm not sure if this is what you are looking for.", "reference": "good job finding this package, I hope it's actively maintained" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "same changes as in hipEnvVar.cpp" }, { "prediction": "#include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include Detected-Locale}`, why make another way to do it?" }, { "prediction": "I'm not sure if this is what you're looking for, but if it's what you're looking for, it's probably a bug.", "reference": "These changes just match the logic update in the next method that was done previously - to assure the whole set of files is valid rather than that there is at least one that would be changed." }, { "prediction": "I'm not sure if this is a bug, but it should be fixed in the future.", "reference": "Why setting the status to Continue as at the end it is written OK? Status should be written only once." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Howdy! You'll want to do this same thing (replace `hydrateParamCache` with `proofs/bin/paramcache` and then do the copy) in `smartdeps`, too." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to create a volume snapshot, so I'm not sure what you're trying to do. I'm guessing you're trying to create a volume snapshot, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do. I'm guessing you're trying to create a volume snapshot, but I'm not sure what you're trying to do.", "reference": "nit : Remove the extra lines" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Instead of adding a new option, I wonder if we could decide on a port that would disable listening. For instance, port set to 0 means that we use default port 4222. Setting to -1 means that we let OS pick a random free port. We could say anything negative lower than -1 (say -2) means disabled? You don't have to update the PR for that, just wondering if that would be better or not and let's see what others think." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Should we add some default case if non of the above return some analyzer name? Something like `unknown analyzer`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Nvm. The original version is best... *hides from the angry rubocop*" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "we can drop this and use the returned body above, right?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do.", "reference": "Is echoing enabled on purpose here or it's a remainder of your tests?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "I think this should just be worked into the next message and follow the verbosity of it." }, { "prediction": "@since 1.14.0 * * @param {Object} urlParams URL parameters to be passed to the query. * @return {(string|undefined)} AdSense account site overview URL (or `undefined` if not loaded). */ getServiceAccountSiteURL: createRegistrySelector( ( select ) => () => { return `https://accounts.google.com/o/adsense/account/site-overview/${select}`; }", "reference": "This also needs to be reverted." }, { "prediction": "TLFJournalBackgroundWorkEnabled is a boolean. If you want to change this to a boolean, you'll need to change it to a boolean.", "reference": "`FromCommand` seems to fit better, since with my suggestion below, all pauses will raise a signal on `needPause`. Also maybe the format `journalPauseConflict` and `journalPauseCommand` is better, since the journal isn't necessarily paused yet once we raise a pause signal." }, { "prediction": "I'm not sure if this is a retryable error, but it's a retryable error, so I'm not sure if it's a retryable error. I'm not sure if this is a retryable error, but if it's a retryable error, then it's a retryable error. I'm not sure if it's a retryable error, but it's a retryable error.", "reference": "This is fix from another PR #120." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "I *think* it makes sense to try the more general dictionary (i.e standard python literals) format first. Might be other implications I haven't figured out yet. Then again, ``MultiInterface`` is pretty new so it probably doesn't matter wrt backwards compatibility." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure.", "reference": "lol that variable name" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Upper case is reserved for our versions of top-level chains i.e. the `FORWARD` chain jumps to `cali-FORWARD`." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "json_handler::receive () has already started a read tx that can be used here right?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if it's what you're trying to do.", "reference": "We should add the definition to `.storybook/config.js` as well." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "I don't believe this is correct. Consider the query, \"select a from t1x where not(b = 0 and c = 0)\". When B and C are both null, both equal predicates evaluate to null, and the AND evaluates to null. The NOT then also evaluates to null. The WHERE clause should treat the result of the NOT as false. But with this fix, the result of the AND will be false, making the NOT true. There needs to be three cases here for ITM_AND: If the first operand is false, then the AND is false. If the first operand is true, then the result is the second operand. If the first operand is null, then if the second operand is false, the result is false otherwise the result is null. Similar logic needs to be added to the ITM_OR case." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "`bound/2` is generally the previous bound that we tested, except when `bound` is equal to 1. It won't break in that case since callers are not supposed to call advance on a target that is lte the current doc ID, but this might still make room for bugs?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "Can we remove `raw`, `fullResult`, and `serializeFunctions`?" }, { "prediction": "This is the default configuration for the Temporal server. This is the default configuration for the Temporal server. This is the default configuration for the Temporal server. This is the default configuration for the Temporal server. This is the default configuration for the Temporal server. This is the default configuration for the Temporal server. This is the default configuration for the Temporal server. This is the default configuration for the Temporal server. This is the default configuration for the Temporal server. This is the default configuration for the Temporal server. This is the default configuration for the Temporal server. This is the default configuration for the Temporal server. This is the default configuration for the Temporal server.", "reference": "[Nit] I don't have a proposed suggestion, but security seems too generic of a name here." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "do we need to force a buildConfig here? I know it's in muon, but that might actually be making things harder for people" }, { "prediction": "I'm not sure if this is the right way to do it, but I think it's the right way to do it. I'm not sure if this is the right way to do it, but I think it's the right way to do it.", "reference": "Shouldn't need this-> here." }, { "prediction": "I think this is a bug in OpenMMLab. It should be fixed in OpenMMLab.", "reference": "Why delete this?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "This line is here to be compatible with the current way `refs` work, right?" }, { "prediction": "I think this is what you're looking for.", "reference": "Hmm, I wonder if we can safely assume all decimals should be displayed as $$...ok for now I suppose." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Good spec :). Very clear and easy to see what it's doing." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Shouldn't we need to sanitize the `params[:filter]` from a defined expected values?" }, { "prediction": "The ECS API is eventually consistent with the API. The API is consistent with the API. The API is eventually consistent with the API. The API is consistent with the API. The API is eventually consistent with the API. The API is eventually consistent with the API. The API is eventually consistent with the API. The API is eventually consistent with the API. The API is eventually consistent with the API. The API is eventually consistent: +# https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_RunTask.html +# https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_RunTask.html +# https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_RunTask.html +# https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_RunTask.html +# https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_RunTask.html +# https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_RunTask.html +# https://docs.", "reference": "Should we bite the bullet and poll for the full 5 minutes that AWS recommends? If we do that, we'll probably want to leave some kind of breadcrumb in the event log to let users know why it's taking so long to launch." }, { "prediction": "I'm not sure if it's a bug, but it's definitely a bug.", "reference": "Guava changed `Objects` -> `MoreObjects`" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "All these hand generated mocks can be deleted. I think we already moved everything to gomocks." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's the same as this.get('_id').equals(doc.get('_id'));", "reference": "what about string/number etc _ids? this will fail." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, you might want to look at it.", "reference": "Looks like the test had a bug prior to this." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Should start with joplin://x-callback-url/. Also maybe create a helper function to check if a url is valid?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "PR works great. Just out of curiosity: why all the id changes?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "config map first value is wrong, it aims to define the \"value type\", that value will lead to an undefined behavior." }, { "prediction": "I'm not sure what you're trying to do here, but I'm assuming you're trying to do something like this:", "reference": "This doesn't make sense. The thing being constructed is a blob.Bucket. \"Constructing\" the pointer is trivial." }, { "prediction": "I think this is a bug in PyLinter. See https://github.com/PyCQA/pylint/issues/252 for details.", "reference": "Outch. A configuration/parsing refactor is on the radar but this seems more pressing." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Unfortunately this won't work when the \"All time\" range is chosen because `memberStats.days` will be `\"all-time\"` and not a number. What you could do instead is to use `memberStats.stats` as the dependent key and use `Object.keys(memberStats.stats.total_on_date)[0]` to grab the first date in the range and build the label from there." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "We need this left in as `axe.configure` is for the top-level page `axe` and we still need to configure the axe script inside the iframe as well (so both have to be configured)," }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "is this rule serviceimpacting? I'm thinking it's mostly around the modeling of pageable in the swagger, thoughts?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "same here, replace `ks` and `kc` to something more related to Source." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm guessing it's a bug.", "reference": "We should probably ask here if `dict` contains a key with the appropiate value, and leave a trace in case it doesn't, to make it easier to debug for developers." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "this should only be indented 2 spaces" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Nit, these Err not nils should be `t.Fatalf` not error. We want to the test to stop if this error occurs." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug.", "reference": "shouldn't every `Boolean` in this pr be `boolean`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "This `if` is not necessary" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's worth noting that this is what you're trying to do.", "reference": "Are you using this anywhere? (I couldn't find it.)" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Can be inlined" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "import json import warnings import colander import json import warnings import colander import colander import colander import warnings import colander import colander import colander import colander import colander import colander import colander import colander import colander import warnings import colander import colander import colander import colander import colander import colander import colander import warnings import colander import colander import colander import colander import colander import colander import colander import warnings import colander import colander import colander import colander import colander import colander import warnings import colander import colander import colander import colander import colander import colander import colander import colander import colander import colander import colander import colander import colander import colander import colander import warnings import colander import colander import colander import colander import colander import colander import colander import colander import colander import colander import colander import colander import colander import colander import colander import colander import warnings import colander import colander import colander import colander import colander import colander import colander import colander import colander import warnings import colander import colander import colander import colander", "reference": "Please use `kinto.core.utils.json`" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but I think it's a bug.", "reference": "Since we're returning the error with the same content, we don't need to log it here; it will get bubbled up and emitted that way." }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "What happens if someone import `typing` and thus uses `@typing.final` instead?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for.", "reference": "Better remove this dependency altogether" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Could you please move the declaration to httpclient.h? I think we have a consistent pattern in declaring global variables in header files." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "We will also need to add this to the spec." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "In startEvaluator, we have the paysetHint; we should use it to preinitialize the state delta allocation. The number of transactions and the deltas are typically growing in a linear fashion, so preallocating twice as much in the array initializer would be a good idea." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "we shouldn't add a bunch of static initializers 'everywhere' in the code. Probably just one would be good, during the construction of the 'RemoteWebDriver' class." }, { "prediction": "I'm not sure if this is what you're trying to do, but it's worth noting that this is what you're trying to do. I'm not sure if this is what you're trying to do, but it's worth noting that this is what you're trying to do. I'm not sure if this is what you're trying to do, but it's worth noting that this is what you're trying to do.", "reference": "Would it be possible to move the creation of the `new { Prop = (object)_value }` out of the benchmark? In the current version, the benchmark includes the cost of creating and serializing the object, while if possible it should be the cost of serialization only." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for a Symfony\\WebpackEncoreBundle\\WebpackEncoreBundle::class => ['all' => true], but you're looking for a Symfony\\WebpackEncoreBundle\\WebpackEncoreBundle::class => ['all' => true], and you're looking for a Symfony\\WebpackEncoreBundle\\WebpackEncoreBundle\\WebpackEncoreBundle::class => ['all' => true], but you're looking for a Symfony\\WebpackEncoreBundle\\WebpackEncoreBundle\\WebpackEncoreBundle::class => ['all' => true], and you're looking for a Symfony\\WebpackEncoreBundle\\WebpackEncoreBundle\\WebpackEncoreBundle::class => ['all' => true], and you're looking for a Symfony\\WebpackEncoreBundle\\WebpackEncoreBundle\\WebpackEncoreBundle::class => ['all' => true], and you're looking for a Symfony\\WebpackEncoreBundle\\WebpackEncoreBundle\\WebpackEncore", "reference": "only dev and local" }, { "prediction": "I think you need to drop the index on the table. I'm not sure if that's what you're looking for, but it's a good idea to drop the index on the table.", "reference": "This should not be nullable, instead it should be `->default(0);`" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "What about `selectedColumns`? I believe it is frequently used throughout the project." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "I thought we switched the approach from a payload to boost attribute? Besides; it's not clear we need this toggle at all since the user could arrange for this behavior simply by having the new DelimitedBoost filter thing in the chain." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "the previous code used 'export' when platform is cisco-5, presumably because 'env' cannot be used to load variables? I have no idea if that's the case but this env vs export logic is not here" }, { "prediction": "This is not a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is a secret name. It is", "reference": "I'm wondering if we need to add some type of validation here that the SecretCount!= 0... Or do we think it would be valid to have a SecretCount of 0?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "This test is being skipped. I unskipped it, and it failed in the same way for both `slaveOk: false` and `secondaryOk: false`. I'm not sure how else to test this broken test." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "I don't believe that we need a pointer to an interface for the `to` side of this since we're just assigning a value to the to field." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "No blank line after the docstring." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "nit: move this to the group below." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "This is fine, but maybe we should change the variable name to \"bufferSize_as_uint\"? Or \"...uint32\"?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Use snake_case for variable names." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Obviously, don't merge this to master." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Nearly there! This should assert on the output, take the result of \"start\" and \"finish\" as an example :)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "This loop is going to burn CPU if len(s.q) == 0. Maybe a small sleep?" }, { "prediction": "I'm not sure if this is a bug, or if it's a bug, or if it's a bug, please report it to a bug.", "reference": "can you give a reason why session should be contained in RegionManager?" }, { "prediction": "@MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpnSessionId:Boop! @MystVpn", "reference": "You are comparing two signerIDs here, error message should be \"Signers should match\"" }, { "prediction": "IAMRoleCredentials struct { ARN string IAMRoleCredentials IAMRoleCredentials + lock sync.RWMutex +} + +// GetIAMRoleCredentials returns the IAM role credentials in the task IAM role struct + func (role *TaskIAMRoleCredentials) GetIAMRoleCredentials() IAMRoleCredentials { + role.lock.RLock() + defer role.lock.RUnlock() + + return role.IAMRoleCredentials }", "reference": "Who's acquiring this lock for writes?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "This throws a linter error, don't use object creation for side effects. I feel like it's kinda messed up that the errors are thrown by the constructor and not that the constructor will throw them" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Should there be a `trail.topic_name` method so we don't annoy Demeter?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "instead of passing \"None\" it would be more readable to create a constant e.g. TEAM_PUBLIC = None and then call build_package(TEAM_PUBLIC,...)" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Would it make sense to include this file via composer files-autoloading instead?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Each `ExpectedCondition` implements `java.util.Function` These are expected to be stateless. This condition will leak previous `elementText` on the second usage, which doesn't seem ideal." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Extra newline here. Thanks for moving it under the `testing` import though. This just needs to be grouped with the other imports below it." }, { "prediction": "I'm not sure if this is the case, but I think it's the case, so I'm not sure if it's the case, but I think it's the case.", "reference": "Should we ignore case when doing the comparison?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug in WLR_HAS_X11_BACKEND. I'm not sure if it's a bug, but it's a bug in WLR_HAS_X11_BACKEND.", "reference": "The same `ifdef` should apply to `#include ` line 14" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, we'll report it here.", "reference": "We're instrumenting a static method, so there's no instance in this case. `diagnosticSource` is the first argument." }, { "prediction": "private boolean isHighPriority = false; private boolean isLowPriority = false; private boolean isHighPriority = false; private boolean isHighPriority = false; private TextView chooseIdentityButton; private EditText subjectView; private boolean isLowPriority = false; private boolean isHighPriority = false;", "reference": "I feel like this belongs in `RecipientPresenter` (which should really be `MetadataPresenter`), but I suppose having it next to requestReadReceipt makes sense as well. feel free to leave as is." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm assuming you're looking for something like this:", "reference": "Let's go back to 1.4.0 until the release is being prepared." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "I would avoid the term \"errno\" as it implies the glibc variable. Use error_code or status or something." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "@abhinav @kriskowal what do you think about putting the handler on `d`?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Why `restic.TagLists` and no `restic.TagList`? Because I'm using `restic.TagList` here and using `restic.TagLists` is a lot of changes" }, { "prediction": "I'm not sure if this is what you're trying to do, but it should be something like this:", "reference": "An hour seems a significant amount of time to wait for within a test, does it need to be that long?" }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "Nit: (newish to golang, don't hesitate to tell me I'm wrong here, but...) I'd have written this code, just for readability: keepAlive := false return d.dial(hostName, tlsClientConfig, keepAlive)... or even return d.dial(hostName, tlsClientConfig, false) // keepAlive=false Personally I think Golang should have included named args; I think it's one of the things python got right." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "I don't think it would cause any version conflict, but I'd feel safer if you declared it last, so that the numerical id of the existing integrations don't change" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Can we provide some more useful actionable info here? `fmt.Sprintf(\"The certificate request could not be completed due to invalid request options: %s\", req.Status.Conditions[InvalidRequestCondition].Message)`" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming that you're using a different port, and that you're using a different port, so I'm not sure what you're trying to do.", "reference": "yeah, can change to 8545" }, { "prediction": "I'm not sure if I'm using Ergonode\\Core\\Application\\Security\\User\\CachedUser or I'm using Ergonode\\Core\\Application\\Security\\User\\CachedUser in my project. I'm not sure if I'm using Ergonode\\Core\\Application\\Security\\User\\CachedUser or I'm using Ergonode\\Core\\Application\\Security\\User\\CachedUser in my project. I'm not sure if I'm using Ergonode\\Core\\Application\\Security\\User\\CachedUser or I'm using Ergonode\\Core\\Application\\Security\\User\\CachedUser in my project. I'm not sure if I'm using Ergonode\\Core\\Application\\Security\\User\\CachedUser or I'm using Ergonode\\Core\\Application\\Security\\User\\CachedUser in my project.", "reference": "As far as I can see you're not rollbacking transaction anywhere. This could potentially cause further issues(and very hard to debug ones) with not synchronized transactions between message handling. Is the transaction required in this place anyway? You seem only to be fetching data here. ack method is performing some updates so it makes sense" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug.", "reference": "What's the meaning of null URIEndpointObject?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug in kinto.config.py, so I'm not sure if it's a bug, but it's a bug in kinto.config.py, so I'm guessing it's a bug in kinto.config.py, so I'm guessing it's a bug in kinto.config.py, so I'm guessing it's a bug in kinto.config.py, so I'm guessing it's a bug in kinto.config.py, so I'm guessing it's a bug in kinto.config.py, so I'm guessing it's a bug in kinto.config.py, so I'm guessing it's a bug in kinto.config.py, so I'm guessing it's a bug in kinto.config.py.", "reference": "Why did you remove the time? It can be useful if some actions are ran in jobs?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "What the reason to change imports?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if it's what you're trying to do, but I'm not sure if it's what you're trying to do.", "reference": "Nit: continuation indents are 2 indents / 4 spaces." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "You can use `netloc.rsplit(\":\")` for that." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "nits, I don't get the point of this change" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "`warningPrefix` looks the same on both platforms, we could move it up to `log.go`." }, { "prediction": "I think this is what you're looking for.", "reference": "What's the motivation behind switching to plural here? I think we want singular cc @abhinav" }, { "prediction": "The Code should never be CodeOK, if it is, this will return nil. The code should never be CodeOK, if it is, this will return nil. The code should never be CodeOK, if it is, this will return nil. The code should never be CodeOK, if it is, this will return nil. The code should never be CodeOK, if it is, this will return nil. The code should never be CodeOK, if it is, this will return nil. The code should never be CodeOK, if it is, this will return nil. The code should never be CodeOK, if it is, this will return nil. The code should never be CodeOK, if it is, this will return nil. The code should never be CodeOK, if it is, this will return nil.", "reference": "What do you think about renaming this method `FromErrorAndCode(code Code, err error) *Status`? One of the benefits is that it will be consistent with the naming of `func FromError(err error) *Status {` which does something almost similar." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "we cannot state that by default the same value is used if we stopped using null - it would suggest that when you change JSON RPC and leave WS port default then they would be same." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "I'm still not convinced dropping Chrome logs is the right thing to do, but if you insist" }, { "prediction": "I'm not sure if this is a bug or a bug, but it seems to be a bug.", "reference": "It would be helpful to include some reasoning here. With the reflection model, it is often the case that names are not available." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Instead of setting this here, why not have the flag call in the init function set `caddy.LogDestination` directly, and switch on that?" }, { "prediction": "I'm not sure why you're getting this error, but I'm not sure why you're getting this error, but I'm not sure why you're getting this error because you're using the JS Internationalization Number Format API.", "reference": "This belongs under \"WordPress dependencies\"." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm assuming it's what you're trying to do.", "reference": "Was there an issue on `net452`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Another option is to always write it without quotes. I always have to use SR. And why not?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug in lodash/merge. I'm not sure if it's a bug, but it seems to be a bug in lodash/merge. I'm not sure if it's a bug, but it seems to be a bug in lodash/merge, so I'm not sure if it's a bug in lodash/merge.", "reference": "This should use the `merge` function added in #473 instead of introducing a new dependency" }, { "prediction": "I don't know if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug. If it's a bug, it's a bug. If it's a bug, it's a bug. If it's a bug, it's a bug. If it's a bug, it's a bug. If it's a bug, it's a bug. If it's a bug, it's a bug, it's a bug. If it's a bug, it's a bug. If it's a bug, it's a bug, it's a bug. If it's a bug, it's a bug, it's a bug. If it's a bug, it's a bug, it's a bug. If it's a bug, it's a bug. If it's a bug, it's a bug, it's a bug.", "reference": "Shouldn't this say \"a binding with descriptor type VK_DESCRIPTOR_TYPE_MUTABLE_VALVE\"" }, { "prediction": "I'm not sure if it's a bug, but it's a bug in wlr_tablet_tool_v2_grab_interface. I'm not sure if it's a bug, but it's a bug in wlr_tablet_tool_v2_grab_interface, so it's a bug in wlr_tablet_tool_v2_grab_interface, so it's a bug in wlr_tablet_tool_v2_grab_interface. I'm not sure if it's a bug in wlr_tablet_tool_v2_grab_interface, but it's a bug in wlr_tablet_tool_v2_grab_interface.", "reference": "This variable name should probably contain `grab`" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `` `` `` `` `` `` `` `` `` `` ````````````````````````````````````````````````````", "reference": "Which initializer should we be using for open_aire? The one in `external_apis` or this one in `initializers`?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like \"gx/ipfs/QmNgLg1NTw37iWbYPKcyK85YJ9Whs1MkPtJwhfqbNYAyKg/go-libp2p-net\" pstore \"gx/ipfs/QmPiemjiKBC9VA7vZF82m4x1oygtg2c2YVqag8PX7dN1BD/go-libp2p-peerstore\" + routing \"gx/ipfs/QmTiRqrF5zkdZyrdsL5qndG1UbeWi8k8N2pYxCtXWrahR2/go-libp2p-routing\" peer \"gx/ipfs/QmY5Grm8pJdiSSVsYxx4uNRgweY72EmYwuSDbRnbFok3iY/go-libp2p-peer\" host \"gx/ipfs/Qmao", "reference": "remove todo on line 28?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "clean unnecessary arguments." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Could the name of the status be confusing to users? It says the execution stopped but is it a temporary stop? Will it continue to run at some point? To me the name does not suggest a final status but a transition one. WDYT @sshardool @jakhani @djaiswal83 @aditya1105" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Since we created a Provisioners directory, can we do the same with the tests, and follow the same structure as the code?" }, { "prediction": "@ -16,11 +16,12 @@ import ( ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "We don't need that one anymore?" }, { "prediction": "I think this is what you are looking for. I'm not sure if this is what you are looking for, but it's what you're looking for.", "reference": "Since we're determining the local node's host info in the `Store()` init, we need to import the `STORE` object here. Is this OK, or should I be determining the host info earlier. (When parsing settings?)" }, { "prediction": "I'm not sure if this is an empty declaration, but if it's an empty declaration, then it's just an empty declaration. If it's an empty declaration, then it's just an empty declaration. If it's an empty declaration, then it's just an empty declaration. If it's an empty declaration, then it's just an empty declaration. If it's an empty declaration, then it's just an empty declaration. If it's an empty declaration, then it's just an empty declaration. If it's an empty declaration, then it's just an empty declaration. If it's an empty declaration, then it's just an empty declaration. If it's an empty declaration, then it's just an empty declaration. If it's an empty declaration, then it's just an empty declaration. If it's an empty declaration, then it's just an empty declaration. If it's an empty declaration, then it's just an empty declaration. If it's an empty declaration, then it's just an empty declaration. If it's an empty declaration, then it's just an empty declaration.", "reference": "I think, there is no `#getKind()` method anymore, is it? The approach would now be testing with instanceof. Or could we return a more specific type than JavaNode now?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "can we localise these? not sure if we have easy access to a translator instance from `generic-provider-views`" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this (which I'm not sure what you're trying to do)", "reference": "This is the VID from Adafruit. Doesn't Particle have a different VID? (CC @suda)." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "The function is only used once, and this body is now only 1 call with the same args (e.g. basically an alias for `vStringTruncate`), it could probably be simply removed. But if you wanna keep the naming for clarity, it also sounds reasonable." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "please change to `could not connect to peer: %s`. it is not relevant to say \"from kademlia\" in a warning" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug, but it's a bug.", "reference": "Why need to remove this? Datetime has microseconds in fact." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "What's up with this, isn't it nil? Why not use the real T value from the test function? @elcore @wmark" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "this feels weird" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "I don't think this is the type of network we should be putting in our named networks." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "debug? I suspect this will be removed before merge?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "should this be here twice?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "`generate_special` - a meaningless name for me. Can we provide more detailed naming?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "This isn't something you introduced in your changes, but the change makes more obvious to me that this test would be better as a unit test of some kind (probably a controller test). Testing a 404 is an edge case that probably doesn't need to be tested with all components in integration." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "We chose `info` in the test code for obvious reasons. Changing to `finest` makes debugging harder and noisier." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "any reason you're assigning to the local variable 'id' too?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "Need to fix this import :)" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "sorry these tests suck so much we are working to kill them" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Why not adjust `currentTime` to be in ms directly?" }, { "prediction": "We do not want to count an mcontext base load as a reg spill/restore. Instead, we want to check if the mcontext base load is a reg spill/restore. So, we do this: if (reg_spill_tls_offs(*reg)!= -1 && reg_spill_tls_offs(*reg)!= -1 && reg_spill_tls_offs(*reg)!= -1 && reg_spill_tls_offs(*reg)!= -1 && reg_spill_tls_offs(*reg)!= -1 && reg_spill_tls_offs(*reg)!= -1 && reg_spill_tls_offs(*reg)!= -1 && reg_spill_tls_offs(*reg)!= -1 && reg_spill_tls_offs(*reg)!= -1 && reg_spill_tls_offs(*reg)!= -1 && reg_spill_tls_offs(*reg)!= -1 && reg_spill_tls_offs(*reg)!= -1 && reg_spill_tls_offs(*reg)!= -1 && reg_spill_tls_offs(*reg)!=", "reference": "> restore, we find the matching spill for that restore which uses the same slot nit: Two separate sentences: separate with `.` or something besides `,`." }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "this flag not used" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "I don't think `?? null` works here... that's to ensure PHP doesn't throw an \"undefined\" error about `$profile->expirationDate`, but now the code is assuming that `$profile->expirationDate` will be set. Might be cleaner to do:
     $expiration = isset($profile->expirationDate)? $this->dateConverter->convertToDisplayDate(\"Y-m-d H:i\", $profile->expirationDate) : null; 
    And then assigning the `$expiration` value in the return array..." }, { "prediction": "I think this is what you're looking for: https://vuejs.org/v2/guide/production-tips.html", "reference": "An ENV should be used? Are you sure that the Vue examples are built in the production mode?" }, { "prediction": "The ` ` ` ` `` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Nit: this should actually always be float since we convert it before we construct the namedtuple." }, { "prediction": "I'm not sure if this is the case, but if it's the case, it's the case.", "reference": "The result of `FileUtils::fileType` could be saved, instead of calling twice." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here, so I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Can you log the exception?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "since this debug message is inside a plugin code, it should use flb_plg_debug(ctx->ins, \"...\"), on this case don't need the component prefix since the API will put it there automatically" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "I also took advantage of the changes to change the Timestamps used in this notification from \"java.sql.Timestamp\" to \"com.yahoo.rdl.Timestamp\"." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "It would be nice all these tweaks to be configurable from cmd line, with sensible defaults" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's the case, it's a bug.", "reference": "Why do we need this `check_same_thead` to be false? I feel a bit uncomfortable about this." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing that you're trying to create a new object, and that you're trying to create a new object, but you're trying to create a new object. I'm not sure what you're trying to do, but I'm guessing that you're trying to create a new object, but I'm not sure what you're trying to do.", "reference": "We should probably test with constructors which aren't in the schema, and functions which aren't constructors." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "this call doesn't work doesn't? I mean there doesn't seem to be an 2 argument allocate overload. Maybe arg_logical_size should just be defaulted to the arg_alloc_size thing. Or we should just report out physical allocation size instead of logical." }, { "prediction": "I'm not sure if it's a 'puppet' or a 'puppet' or a 'puppet' or a 'puppet' or a 'puppet' or a 'puppet' or 'puppetlabs' or 'puppetlabs' or 'puppetlabs' or 'puppetlabs' or 'puppetlabs' or 'puppetlabs' or 'puppetlabs' or 'puppetlabs' or 'puppetlabs' or 'puppetlabs' or 'puppetlabs' or 'puppetlabs' or 'puppetlabs/puppet/sbin', or 'puppetlabs' or 'puppetlabs/puppet/sbin', or 'puppetlabs' or 'puppetlabs/puppet/sbin', or 'puppetlabs/puppetlabs/puppet/sbin', or 'puppetlabs/puppet/sbin', or 'puppetlabs/puppet/", "reference": "This winds up flipping the desired values. Looks like I gave you a bum steer @kevpl" }, { "prediction": "I'm not sure if this is a bug, but it seems to be fixed in the latest release.", "reference": "nit: let's call our address ioAddr from now on" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "You're killing this \"else\" case here which currently flags an error when maxBoundDescriptorSets == 0." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Nitpick: I'd append `_cb` to the function name here to mark it as a callback. Otherwise it looks a bit like this will do the entire job of removing null checksum refs from a hash table." }, { "prediction": "public static List> loadTables(TiDBInfo db) { if (tableMap.values().stream().filter(TiTableInfo::isView)!= null) { return ImmutableList.copyOf(tableMap.values().stream().filter(TiTableInfo::isView).collect(Collectors.toList()); } return tableMap.values().stream().filter(TiTableInfo::isNotView).collect(Collectors.toList()); } public static List loadTables(TiDBInfo db) { if (tableMap.values().stream().filter(TiTableInfo::isView)!= null) { return ImmutableList.copyOf(tableMap.values().stream().filter(TiTableInfo::isView).collect(Collectors.toList()); } return tableMap.values().stream().filter(TiTableInfo::isNotView).collect(Collectors.toList()); } public static List loadTables(TiDBInfo db) { if (tableMap.values().stream().filter(TiTableInfo::isView)!= null) { return ImmutableList.copyOf(tableMap.values().stream().filter(Ti", "reference": "or you can use `filter(x =>!x.isView)`" }, { "prediction": "I think this is a bug, but it should be fixed in a future release.", "reference": "Instead of NewBuffer on the line above, do NewReader to avoid having to wrap later." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "No need for this, as pylint already only turns things off for this function and it's needed for the entire function." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "extra brownie points ( overall solution ): we've currently triple-encoding the payset - 1. we encode it to calculate the block size. 2. we encode it to calculate the commit hash ( either via flat, or as Merkle tree ). 3. we encode it as a whole for the purpose of preparing the proposal ( I know that this isn't always the case, but this case happens to be on the critical path ). Caching the encoded data of the *first* block could help us repeating the process." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "This assertion should use the actual expanded string, so that it is clear what the message produced looks like. Right now one has to run the code to determine what the message is." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "similar here for imports, these should be consolidated (and also consolidated with the grouping below)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Maybe there is no need to modify it. Because if you don't use the mask, it won't be initialized." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Is there a reason we wouldn't want the trailing `%`? I'm guessing that without the trailing `%` it will just do a strict match vs a partial prefix right?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug in fpga_dma_test.c. It's a bug in fpga_dma_test.c. It's a bug in fpga_dma_test.c. It's a bug in fpga_dma_test.c. It's a bug in fpga_dma_test.c. It's a bug in fpga_dma_test.c. It's a bug in fpga_dma_test.c. It's a bug in fpga_dma_test.c. It's a bug in fpga_dma_test.c. It's a bug in fpga_dma_test.c.", "reference": "Please update the DMA test app in AFU repo once this gets approved." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "There should be a migration for that as well to reflect the change on in-production instances" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Why does it have to be `\"\"` instead of an empty string" }, { "prediction": "I'm not sure if this is a bug, but it's a bug in RSpec.", "reference": "This is very strongly opinionated so feel free to disagree with me better, but as conditionals get more complex I like turn them into ifs instead of unlesses. What do you think?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Will this obey the seed set on Kernel?" }, { "prediction": "@Puppet::Functions.create_function(:add_facts) do.from_issue_and_stack(Bolt::PAL::Issues::PLAN_OPERATION_NOT_SUPPORTED_WHEN_COMPILING, action: 'add_facts') end - inventory = Puppet.lookup(:bolt_inventory) { nil } - - unless inventory - raise Puppet::ParseErrorWithIssue.from_issue_and_stack( - Puppet::Pops::Issues::TASK_MISSING_BOLT, action: _('add facts') - ) - end - - executor = Puppet.lookup(:bolt_executor) { nil } - executor&.report_function_call('add_facts') + inventory = Puppet.lookup(:bolt_inventory) + executor = Puppet.lookup(:bolt_executor) + executor.report_function_call('add_facts') inventory.add_facts(target, facts) end", "reference": "We shouldn't use the `&.` syntax here, since we expect that `executor` will never be `nil`. For the functions that _can_ be called from apply / without an executor, `&.` is still appropriate." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Why the switch from period to colon?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Can you just fix the warning instead? It's actually important for this to have a default of `\"\"` as the subsequent merges with `DefaultConfig()` and `fileConfig()` need to work. If you make this not `\"\"`, you break the assumptions of `Merge()`." }, { "prediction": "I'm not sure if this is what you're looking for, but if it's what you're looking for, then it's a good idea to change the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value of the default value", "reference": "let us not add this" }, { "prediction": "This is a bug in the cgroup manager. It should be fixed in the cgroup manager, but it should be fixed in the cgroup manager.", "reference": "Is there a need for group as well? crun sets both." }, { "prediction": "I think this is a bug in OpenTelemetry.Instrumentation.Dependencies.Tests. I'm not sure if it's a bug, but I think it's a bug in OpenTelemetry.Instrumentation.Dependencies.Tests.", "reference": "@cijothomas This build-up pattern was really confusing. It looks like internally ActivityProcessor is intended to be chained but there is nothing in the abstract class that enforces it. We never set a \"Next\" or make sure that the chain is called. Probably need to do some more work in this area?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "`this.getFilter()` won't work on `pre('save')`. Perhaps make this `toySchema.pre(['updateOne', 'findOneAndUpdate'])`?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure.", "reference": "Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm wrong, or if I'm wrong, or if I'm wrong, I'm wrong.", "reference": "I think this is the only place where we use `UvShutdownReq`. Can we remove the type altogether? Or do you prefer to keep it around?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "I think we can get this to work by passing in the root ca cert fixture that upstream ca is using" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, and it's a bug, and it's a bug.", "reference": "Just occurred to me to ask: is the condor log date in localtime or UTC?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Can you remove the sculliscep varbits from here too?" }, { "prediction": "I'm not sure if you need to do this, but I think you need to do it manually.", "reference": "I understand that it is a common practice in this script to add indexes this way but why don't we check index existence before adding it? I'm not very familiar with MySql but it's can be done easily in MSSQL and I'm pretty sure that there is a way to do the same here." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "we should probably deprecate (and display a warning) the misspelled keyword arg here rather than removing it... and then add the new one. This changes a public API and will break any code that is currently using the misspelled version." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Should we do something like `h2o__fatal(file, line, \"fatal error: %s, %s\\n\", mess, RSTRING_PTR(...))` here?" }, { "prediction": "I'm not sure what you're trying to do, but I think it should be something like this:", "reference": "is this one all platforms?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea to use `jsonhttptest` instead of `jsonhttptest`", "reference": "why capitals grr?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Surely all the above should go into `common`." }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "This is an unrelated change, but was failing CI... probably introduced in master." }, { "prediction": "We have to figure out the mapping between the two molecols, so we have to figure out the mapping between the two molecols.", "reference": "This piece isn't backwards compatible, but it's enough of an edge case that I think it's unlikely to be a problem." }, { "prediction": "The PubSub service limits the number of messages in a single Publish RPC - MaxHandlers: 2, + MaxBatchByteSize: 10 * 1000 * 1000, // The PubSub service limits the size of request body in a single Publish RPC } var defaultRecvBatcherOpts = &batcher.Options{ - MaxBatchSize: 1000, // The PubSub service limits the number of messages in a single Publish RPC - MaxHandlers: 2, + MaxBatchSize: 1000, // The PubSub service limits the number of messages in a single Publish RPC + MaxHandlers: 2, + MaxBatchByteSize: 10 * 1000 * 1000, // The PubSub service limits the size of request body in a single Publish RPC } var defaultRecvBatcherOpts = &batcher.Options{ - MaxBatchSize: 1000, // The PubSub service limits the number of messages in a single Publish RPC - MaxHandlers: 2, + MaxBatchByteSize: 10 * 1000 * 1000, // The PubSub service limits the size of request body in a single Publish RPC }", "reference": "MB is presumably 1024 * 1024." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "Didn't we extract this logic to a `react-features` helper?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "But But, overlapping async writes will get corrupted" }, { "prediction": "I'm not sure if this is what you're looking for, but it looks like you're looking for \"github.com/filecoin-project/go-filecoin/config\" \"github.com/filecoin-project/go-filecoin/metrics\" \"github.com/filecoin-project/go-filecoin/types\" \"github.com/filecoin-project/go-filecoin/types\" \"github.com/filecoin-project/go-filecoin/types\" \"github.com/filecoin-project/go-filecoin/types\" \"github.com/filecoin-project/go-filecoin/types\" \"github.com/filecoin-project/go-filecoin/types\" \"github.com/filecoin-project/go-filecoin/types\" \"github.com/filecoin-project/go-filecoin/types\" \"github.com/filecoin-project/go-filecoin/types\" \"github.com/filecoin-project/go-filecoin/types\" \"github.com/filecoin-project/go-filecoin/types\" \"github.com/filecoin-project/", "reference": "Not your immediate problem, but having everything depend on a package that has the config for everything else is ick. Can you move the MessagePoolConfig here and reverse the dependency?" }, { "prediction": "I'm not sure if this is the issue, but I'm not sure if it's the case.", "reference": "recently, IME_ACTION_GO action can trigger key_down and key_up event successfully, so we don't need to send enter key separately as before, otherwise will trigger it twice and cause to enter empty passcode, which cause test failed." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "It seems that you only need to do this `checkExprDepth()` inside `deduceExprType()`. So you don't have to add this check everywhere." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to create an error email from a unit test, so I'm not sure what you're trying to do.", "reference": "why split into two lines?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do.", "reference": "Does this need to be public or can it be package-private?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Questionable way of looping through editors and calling `canEditFile` to show the edit button. Is there a better way?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "`that is null` doesn't sound very useful to me. Could we rename `that` to `target` or something less context dependent :)?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Just to be consistent, can we use the print function `print()` instead of the keyword. Same goes for line 437." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Having to pass in `price` and `limit` is pretty common. Do we want to have this be another argument, maybe a combined structure that can be used for every action that requires it?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "Could you move it after `stop`?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case.", "reference": "The variable `method` seems not used. Maybe we can remove the parameter `bodyParamName` and generate it by invoking `ParamUtils.generateBodyParameterName(method)`?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "I don't think this should be here?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "Either I'm missing something or specs actors should remove this call cc @anorth" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Please undo all these changes as they are white-space only." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "You forgot an optimization? `$countries = CountryField::FORMAT_ISO_3166_ALPHA3 === $countryCodeFormat? Countries::getAlpha3Names() : $countriesAlpha2;`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Shouldn't this also return the current value specified by the user? At least that's what the docstring says and what the previous version did." }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "> the time range the listen search the time range of the listen search?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "This snprintf, etc. needs to all be inside the DO_ONCE: all this overhead happening on every single decode is likely a huge performance hit." }, { "prediction": "You can use --cluster Cluster URL for solicit and connect --no_advertise Advertise known cluster IPs to clients + --conn_retries For implicit routes, number of connect retries will be increased.", "reference": "would call it connect_retries" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but if it's what you're looking for, it should work.", "reference": "Why are we using `repr`?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "I use the same zms instance to check authentication in swagger endpoints. Same thing in ZTS." }, { "prediction": "We don't need to do this in a unit test. Instead, we need to do this in a unit test.", "reference": "Consider consolidating the common code in a common setup method in tests?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "q: do you need to run the annotation processor over EthProtocolConfiguration prior to writing this file? (i.e.to ensure ImmutableEthProtcolConfiguration exists)? Does Auto-import etc. still work in the IDE?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "What is the motivation for switching from `Schema` to `DiscoveryField` everywhere?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "What happens when ECS Init/whatever's starting the Agent mounts some other directory as Agent's data directory (`-v /tmp:/data`) sets `ECS_HOST_DATA_DIR` to `\"/var/lib/ecs\"` It doesn't seem like a strong enough abstraction to be dependent on Agent configuration options to expect `ECS_HOST_DATA_DIR` to be the same as whatever's being mounted as `/data` on the host. My main concern is the late-binding/asynchronous failures this could lead to if the wrong host mount was specified. Wondering if there are better alternatives here. Can we at the very least inspect the Agent container and check if `ECS_HOST_DATA_DIR` is mounted? If the answer is that we'll revisit the validation here at some latter stage, that's fine too. But, I want us to be aware of potential failures here." }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "btw that's obviously out of scope of this PR but since i noticed this line here it reminded me a thing: on some systems i've noticed the font didn't had those characters, so it was just a square or empty space and sometimes they're just a bit shifted in position (if font doesn't have them and using from fallback font which have incompatible dimensions of characters) how do you think is it worth creating an issue to discuss/address it or it could just waste time on bikeshedding?" }, { "prediction": "I'm not sure what you're trying to do, but it seems like you're trying to do something like this:", "reference": "alias is not needed" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case, so I'm not sure if it's the case.", "reference": "Do we need to include the path?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "During our zoom and working on this, I said that I believe it was set to 64MB, not 32MB, but the diff shows that I was wrong. So we could change it back to 32MB." }, { "prediction": "I'm not sure if this will work for you, but it should work for you. I'm not sure if this will work for you, but it should work for you.", "reference": "Here I thought you always insisted on ` log \"github.com/Sirupsen/logrus\" ` :) I might do a PR that just globally switches that out wherever we have log." }, { "prediction": "The TLF is public, or if the TLF is not public, the TLF is not public, or if the TLF is not public, the TLF is not public, or if the TLF is not public, the TLF is not public, or if the TLF is not public, the TLF is not public, or if the TLF is not public, the TLF is not public, or if the TLF is not public, the TLF is not public, or if the TLF is not public, the TLF is invalid. - HasKeyForUser(keyGen KeyGen, user keybase1.UID) bool + // keys for at least one device. Returns an error if the TLF + // is public. + HasKeyForUser(user keybase1.UID) (bool, error) // GetTLFCryptKeyParams returns all the necessary info to // make sure that the TLF is public. + HasKeyForUser(keyGen KeyGen, user keybase1.UID) (bool, error) // GetTLFCryptKeyParams returns all the necessary info to // make sure that the TLF is public. + HasKeyForUser(user keybase1.UID) (bool, error) //", "reference": "We maintain that each (logical) key generation has the same set of device keys, so no need to plumb through `keyGen`." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this?", "reference": "Please use `from unittest import mock` instead of this package." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Should be `if (this.options && this.options.cursor) {`. Options may be undefined. Also, going forward, mongoose will always use curly braces around if blocks." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "This should remain as mailrelay.blackducksoftware.com for staging. Not sure this will be valid, but it shouldn't go through the production mail server." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Maybe we should have a Debug.Assert for when `Slab!= null` to ensure that we are always returning the block (in our tests at least)." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Okay sorry about this I was really confused on how to support uncontrolled in this case, so what we want to do is apply `defaultValue` when `props.value` is falsy but not undefined, right? In the case of us seeing it is controlled (value & onChange present) we apply defaultValue to `props.value` (and delete props.defaultValue) In the case of uncontrolled we shouldn't enter this branch at all and go for full native dom behavior" }, { "prediction": "I'm not sure if this is the issue, but I'm not sure if it's the issue, but I'm not sure if it's the issue.", "reference": "`lodash` shouldn't be grouped under WordPress dependencies" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "The latest yaml in openebs/master has changed to name=admission-webhook. cc: @prateekpandey14" }, { "prediction": "The AWS SDK for Ruby (v3) is deprecated. Please use the AWS SDK for Ruby (v3). The AWS SDK for Ruby (v3) is deprecated and will be removed in the future.", "reference": "using **an** Amazon Simple... Simple Notification **Service** (singular)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Probably don't intend for this `1 ||` to still be here" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "Looks like this is failing to compile on Windows (VS 2015 I think)." }, { "prediction": "The `BeforeQuery` is a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It's a `BeforeQuery` function. It'", "reference": "nit: call the arg something simple like `f` to avoid repeating \"beforeQuery\"." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "do you think this should be `osd/auth` as a pkg to make it more unique and void conflicts with other `auth` packages?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "Why are you passing out the Message?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Yikes, this was a bug :grimacing:" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure.", "reference": "I am not sure which one of these is considered idiomatic go... maybe @azdagron has an opinion here? /me prefers the verb since it's shorter. I guess I don't care _too_ much, but it would be good to get some general agreement so we are all following the same conventions" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "Please check this for error and emit appropriate debugging information. I know this was pre-existing code, but we just have to fix things like this as we go." }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "This seems unrelated, should be a separate PR." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Never use relative includes, prefer full path" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "This should fit on the line above without going over the 79-char limit, no?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this, and I'm not sure what you're trying to do.", "reference": "Is this related to the other contents of this pull request?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing you're looking for something like this.", "reference": "Should this be `*string`?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "In the old code here there was no Source Selector, but CreateDefaultProfile will specify a Source Selector of `\"\"`. Is that equivalent?" }, { "prediction": "I think this is a bug in the RSpec.configuration.reporter.deprecation module RSpec.configuration.reporter.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation.deprecation", "reference": "We should pick this across for all our deprecation specs" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Longer term, I think it could be valuable to move this to cluster-api, and then other repos could take advantage of this as well." }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "Is this a related change?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Given that this is repeated, can we do it outside here and the Create call, what do you think about moving it outside?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Changing `prop`=>`col` by reference? I think you can prepare map `prop`=>`col` in L51." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I hate to ask, but can we make this flag shorter so it lines up? :(" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Note to reviewers: latent, dedup import" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "Seems this func is no more needed after your refactoring." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for.", "reference": "already added (see several rows below)" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm sure it's a bug.", "reference": "nit: a switch perhaps?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure.", "reference": "Great you caught this. Super critical to not retry these errors." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "Just a little change to make the var effectively final, which is clearer." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Using `\"{}\".format(...)` is a bit beside the point..." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I think these should remain as they are." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Let's just call this PERF_PACKAGES and have them in the same format as WINDOWS/SLES/DEBIAN_PACKAGES constants - since it is only a single package and, as written, you'd have to update the code to add more package names anyway. Might as well be consistent with the rest of the code." }, { "prediction": "I think it's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug.", "reference": "We don't have a `getPluginIDfromTaskIndex` function? I think it should be implemented in Globals/Plugins.h /.cpp" }, { "prediction": "I'm not sure if this is the case, but if this is the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's the case, it's", "reference": "@shalinmangar If lazy field loading isn't enabled, I don't think this actually changes the behavior of `SolrIndexSearcher`, since it was previously ignoring the fields list anyway. What it _should_ do is allow certain distributed queries, like the ones in `DistribJoinFromCollectionTest`, to co-exist with `SolrIndexSearcher#doc()` respecting the `fields` set instead of just discarding it." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Should we be using version 3 now?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Would be better to throw a more specific exception, but for now it will do." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "We should not replace Wei with a type that is shared across multiple units. We need this as `Wei` for type and unit safety." }, { "prediction": "I'm not sure if this will work, but I think it's a good idea to check if the file exists. If it doesn't, it's better to check if the file doesn't exist. If it doesn't, it's better to check if the file exists.", "reference": "I'm pretty sure this should emit a util.Warning*(), since we're skipping by here and never hitting anything that will give them a warning about what's happened." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This function isn't useful? it's just a clone of GetParserWithBuiltins?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case.", "reference": "I'm not sure if the boolean flags should always contain `is`, also I generally hate too long names... ;) we already know this is a section for circuit breakers, so the name doesn't have to repeat all of it. How about `cpuBreakerEnabled`, `memoryBreakerEnabled` etc?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Before we start the replacing equality deletes with position deletes, I think we need to refactor the RewriteFiles API to adjust more cases: 1. Rewrite data files and remove all the delete rows. The files to delete will be a set of data files and a set of delete files, and the files to add will be a set of data files. 2. Replace equality deletes with position deletes, the files to delete will be a set of equality delete files (we will need to ensure that all delete files are equality delete files? ), the files to add will be a set of position delete files. 3. Merging small delete files into a bigger delete files. The files to delete will be a set of equality/position delete files, the files to add will be a set of equality/position delete files." }, { "prediction": "It's important that we don't use the default locale in this case. It's important that we don't use the default locale in this case, because we don't use the default locale in this case. So we don't need to use the default locale in this case.", "reference": "Layout/TrailingWhitespace: Trailing whitespace detected." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Is it possible that the shortcuts list is empty?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "This just changes the error message from `unable to save snapshot: [...] context canceled` to `canceled`." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "maybe it's better to remove HttpHeaders.CONTENT_LENGTH after the loop" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Very cool. We are now collecting the fruits after your length implementation!" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "Is this the same copy of the rules file from above? If so, can just use the copy from above, and this can be dropped." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Please break this into multiple lines." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Shouldn't this new line replace the few lines above?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this: https://github.com/influxdata/flux/blob/master/src/com/influxdata/flux/functions/transformations/transformations.ts", "reference": "Perhaps this belongs in universe?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's what you're trying to do. I'm not sure if this is what you're trying to do, but it's what you're trying to do.", "reference": "there is a `kEpsilon` you can use directly." }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "This should be grouped with the below imports, and the two separate groups of imports below should likely also be grouped together" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "It looks like this error_code field is used to return a string to the caller, not just a const input string to be consumed as in the rest of this PR? If so, my personal preference would be to leave it as a std::string* instead of a reference; I don't know offhand what the VL coding style dictates." }, { "prediction": "I'm not sure if this is the case, but if it is the case, then I'm not sure if it's the case, but it's the case.", "reference": "If return by value, then why bother to make it `static`?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "You'll need to add docs for the argument, see e.g. the `debug_log_filter` docstring above." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "`sdktrace` or `tracesdk`, pick one." }, { "prediction": "@ -200,11 +200,7 @@ trait ContentMagicTrait { } - return [ - 'filename' => '', - 'alt' => '', - 'path' => '', - ]; + return []; }", "reference": "can we return null instead?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "You mean XXX and \"we should\" or \"NYI\" or sthg. Maybe put it on the ifdef line." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "minor: can be in-lined in return" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "why the additional \"\\n\"?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "This seems to be a big omission. If the first buffer reports an error, stream seems to just discard it." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Maybe move this one down too?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm assuming you're looking for something like AsyncLocalScopeManager, so I'm not sure if this is what you're looking for. I'm not sure if this is what you're looking for, but I'm assuming you're looking for something like AsyncLocalScopeManager, so I'm not sure if this is what you're looking for.", "reference": "We do this in lots of places I'm starting to notice...typically you'd avoid taking concrete dependencies, but we also avoid package dependencies as well which makes sense (i.e. not using an IoC, etc.). Any reason we don't implement some form of poor-man's DI and/or a simple factory instead of new-ing things up everywhere. This may be a simple example (as I'm guessing this is likely the only place this is ever or ever will be used), but separating them doesn't take any more time/effort either really." }, { "prediction": "I'm not sure what you're trying to do here, but I think it's a good idea to wrap an error as a DError. I'm not sure what you're trying to do here, but it's a good idea to wrap an error as a DError. I'm not sure what you're trying to do here, but it's a good idea to wrap an error as a DError. I'm not sure what you're trying to do here, but it's a good idea to wrap an error as a DError. I'm not sure what you're trying to do here, but it's a good idea to wrap an error as a DError. I'm not sure what you're trying to do here.", "reference": "What if formatPrefix doesn't include a space? Will the resulting error have e.Error() stuck at the end without any space?" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to use the pushsync protocol, and that you're trying to use the pushsync protocol, and that you're trying to use the pushsync protocol, but you're not using the pushsync protocol, so I'm not sure what you're trying to do.", "reference": "that doesn't say a lot to me. Can you please be more specific on the function of pushsync?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, so I'm not sure if it's a bug, or if it's a bug.", "reference": "> subpass uses a depth/stencil attachment in renderPass with a read-only layout for the depth aspect Assume - VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_STENCIL_ATTACHMENT_OPTIMAL - VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_OPTIMAL count as well seems there is a `NormalizeDepthImageLayout` for this" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This shouldn't be altered, you probably meant to update `AREA_PAGE_DASHBOARD_ALL_TRAFFIC` further below :)" }, { "prediction": "I'm not sure if this is what you're looking for, but if it's what you're looking for, it's probably better to use a list comprehension instead.", "reference": "what does this change do exactly?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "What's the purpose of this `backgroundCtx` field?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "non contract incarnation" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "I would recommend to leave out `None` because None is already the default." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure.", "reference": "Should the \"bad hello message\" case above also disconnect?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Shouldn't this be in the child and not in the base plugin? Wouldn't having it here enable all derived plugins at once?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Should probably say REGEX or PATTERN rather than string." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "I felt we don't need to set it that strict, like if somehow pubsub happens to allow extra 20 bytes for metadata, this test won't work. We would suggest to use 11MB instead." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here, so I'm assuming you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "In theory `isset($metadata['associationType'])` is `false` if the linked field is not an association field, isn't?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "@tute the only thing I needed to enable this like as `password` is not in default flow anymore I think." }, { "prediction": "IamPolicyMember is a member of IamPolicyMember. IamPolicyMember is a member of IamPolicyMember. IamPolicyMember is a member of IamPolicyMember. IamPolicyMember. IamPolicyMember is a member of IamPolicyMember. IamPolicyMember. IamPolicyMember is a member of IamPolicyMember. IamPolicyMember. IamPolicyMember is a member of IamPolicyMember. IamPolicyMember. IamPolicyMember is a member of IamPolicyMember. IamPolicyMember. IamPolicyMember is a member of IamPolicyMember. IamPolicyMember. IamPolicyMember is a member of IamPolicyMember. IamPolicyMember. IamPolicyMember is a member of IamPolicyMember.", "reference": "nit: to be consistent with `self.members`, please move this up one line, so that it's closer to `allUsers`? You will need to update your test reference." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "we might as well just access `config.gClientVerbose` directly here. If any other options are passed to `gclientSync` or `gclientRunhooks` then the verbose option will be lost the way it's used now" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Change the key to `default_tab` instead and I'll merge this" }, { "prediction": "If the funder was specified OR the funder_id is not specified, then the funder_id is not specified, so the funder_id is not specified.", "reference": "we still can end up passing a blank org_id to the scope method if for any reason the params is not present..." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I think yes, this makes sense to expose this. +1" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to create a new volume with a different name, so I'm guessing you're trying to create a new volume with a different name.", "reference": "let us put the sample yaml snippet i.e. maya api server deployment that makes use of this env & value" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug. I'm not sure if this is a bug, but it seems to be a bug.", "reference": "What changed to cause this?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Repeating big interface in many places shows smtg is wrong with design" }, { "prediction": "I think this is what you are looking for: https://github.com/rails/blob/master/src/rails/views/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers/controllers", "reference": "Inheriting from `AccountsController` to get access to the `redirect_if_disabled` filter." }, { "prediction": "I think this is a bug. It should be fixed in the future.", "reference": "Simple Storage **Service**" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Enter at the end of the file! :-D (and at the end of lines ;-) )" }, { "prediction": "I think this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Put a comma after the last parameter of a multiline method call." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Don't you want to place this check before you add `succ` to `newSucc`?" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's probably what you're trying to do. I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's probably what you're trying to do. If it's what you're trying to do, it's probably what you're trying to do. If it's what you're trying to do, it's probably what you're trying to do. If it's what you're trying to do, it's probably what you're trying to do. If it's what you're trying to do, it's probably what you're trying to do.", "reference": "Commit 676eeeab10884456a5f70ce708a8aa5116ecbaf7 contains a lot of unrelated code style changes. Please get rid of these." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "Well this sucks, I wish you'd mentioned you were using a private API, perhaps we could have made a public one with better guarantees before `0.12.6` was released." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Consider instead moving this into an _test file so it's public but only usable in tests." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Any reason why we want to remove this code? It helps debugging AWS ebs attach issues. Ideally yes a library should have minimal logging, but there is no way we can track long running AWS attach calls." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it should be something like this:", "reference": "nit: indentation doesn't match (unfortunately i don't know of a way to automatically lint these sql statements with how we're using them currently)" }, { "prediction": "@@ -231,6 +231,7 @@ module RSpec::Core return if @setup @setup_default.call + setup_profiler @setup_default.call + setup_profiler @setup_default.call + setup_profiler @setup_default.call + setup_profiler @setup_default.call + setup_profiler @setup_default.call + setup_profiler @setup_default.call + setup_profiler @setup_default.call + setup_profiler @setup_default.call + setup_profiler @setup_default.call + setup_profiler @setup_default.call + setup_profiler @setup_default.call + setup_profiler @setup_default.call + setup_profiler @setup_default.call + setup_profiler @setup_default.call + setup_profiler @setup_default.call + setup_profiler @setup_default.call + setup_profiler @setup_default.call + setup_profiler @setup_default.call + setup_profiler @setup_default.call + setup_profiler @setup_default.call + setup_profiler @setup_", "reference": "Should we remove the other `setup_profiler` call site and just let this be the one call site for it, since, AFAIK, the other one is no longer necessary with this? Also, can we make `setup_profiler` private?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Are there any other templates where this command needs to be added, or were those issues specific to storage requiring us to enable a new command group?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "perhaps file can be removed altogether (trying to avoid an empty package for these build tags)" }, { "prediction": "I'm not sure what you're trying to do here, but it's possible that you're trying to do something like this:", "reference": "NULL change, could you move that out too?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do this in the wrong way. I'm not sure what you're trying to do here, but I'm guessing you're trying to do this in the wrong way, so I'm not sure what you're trying to do here.", "reference": "A brief explanation about this func is required." }, { "prediction": "The merged cell was not added to the table, please fix your setup.", "reference": "Could you add description for below static function?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Since this is only counting the failed attempts, can you call it failedAttemptsCount or retryCount instead of attemptsCount?" }, { "prediction": "I think you need to import os.path.join(os.path.dirname(__file__), \"OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO", "reference": "I don't think this will work." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm sure it's what you're looking for.", "reference": "Since http2 is coming do we want to call this something more specific?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I don't think we want to revert the accessibility issues the tool caught, do we?" }, { "prediction": "I'm not sure if this is a bug, but it's fixed in the latest release.", "reference": "I prefer naming this rateLimitedRemoteHost This can be local host but reads remote Host Is Non Local." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "Hmm I think I might've messed up this condition here... Need to look more at it" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "This also makes the exception to be raised on non-dict falsy values which I think was expected." }, { "prediction": "I'm not sure what you're trying to do here, but I think it's a good idea to use the `auto_indexable_1d` attribute.", "reference": "Is this correct? The auto indexing behavior caused problems fixed in a recently merged PR..." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "Hmm, didn't we just find out that 1.6 *does NOT* work? We should bump the minimum as well." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Will calling `abort()` cause problems for our test suite?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "for my own edificaton, what's this?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug, but I think it's a bug.", "reference": "make it harmless to commit ws == nil" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Hmmmm, I'm not sure I like these becoming a replacement any build rule has access to. It seems like if it were used in an actual build rule it would only be doing bad things. Can we just use `filepath.Abs` on the returned path in run_step.go?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "That's actually not as bad as I thought it was going to be." }, { "prediction": "I'm not sure if this is the correct way to do it, but it should work.", "reference": "Hmm, I'm surprised if we don't already have a \"find all unpublished datasets\" method but I don't really know. Maybe @scolapasta knows." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "The checks in this file are disabled by default since they are meant for Python 3 porting, and this one does not have to do with Python 3 porting at all." }, { "prediction": "I don't think this is a bug, but it's a bug in Microsoft.AspNetCore.Server.Kestrel.Core.Features.MinDataRateFeature. It's a bug in Microsoft.AspNetCore.Server.Kestrel.Core.Features.MinDataRateFeature. It's a bug in Microsoft.AspNetCore.Server.Kestrel.Core.Features.MinDataRateFeature. It's a bug in Microsoft.AspNetCore.Server.Kestrel.Core.Features.MinDataRateFeature. It's a bug in Microsoft.AspNetCore.Server.Kestrel.Core.Features.MinDataRateFeature. It's a bug in Microsoft.AspNetCore.Server.Kestrel.Core.Features.MinDataRateFeature. It's a bug in Microsoft.AspNetCore.Server.Kestrel.Core.Features.MinDataRateFeature. It's a bug in Microsoft.AspNetCore.Server.Kestrel.Core.Features.MinDataRateFeature.", "reference": "I would change \"should be sent\" to \"must be received\"." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Please put it in following way : `// DeleteStoragePool receives StoragePoolClaim delete event and calls the required handlers to delete other pool related resources.`" }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if it's the correct way to do it, so I'm not sure if it's the correct way to do it.", "reference": "It's better to use servicecomb now." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "Make the flag derived default available in the readiness controller" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "Confirmed this test fails when the fix is reverted" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "This method is still possible insecure as it may archive not only logs files. I suggest to filter file names to ensure that they start with `.mysterium-log*`." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "DCN should not be able to use `init_cfg`." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "It is a bit weird to see a message like \"something must be valid\"." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Again. This is part of the start up of the server, and the diagnostics are helpful." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "I think you need a `,` at the end of the line?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I'm sure it's a bug.", "reference": "Please avoid wildcard imports." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Did we consider making the timeout an argument to the build task? Would amke it easer to configure in the future: change a build property vs. rebuilding the DLL." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug.", "reference": "dumb question: the commit message talks about dual-stack support but it seems that in a dual-stack cluster, Egress will only support the IPv4 address family?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "Do you want to cherry-pick these separately and get them merged already or keep it in here? Both is fine with me!" }, { "prediction": "@Test public void en() throws Exception { - checkAnalysisPerformance(\"en\", 1_000_000); + checkAnalysisPerformance(\"en\", 1_200_000); } @Test public void en_suggest() throws Exception { - checkSuggestionPerformance(\"en\", 1_000_000); + checkSuggestionPerformance(\"en\", 1_200_000); } @Test public void en_suggest_suggest() throws Exception { - checkSuggestionPerformance(\"en\", 1_200); + checkSuggestionPerformance(\"en\", 3_000); } @Test public void en_suggest_suggest_suggest() throws Exception { - checkSuggestionPerformance(\"en\", 1_200); + checkSuggestionPerformance(\"en\", 3_000); }", "reference": "Hmm what are these magical constant numbers? And why does this change mean they should increase?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "This change shouldn't be included with this push. Shouldn't push version changes with a pull-request." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "nit: let's move this right under where we create the `responseWriter`, before `h.callHandler`" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "The way it was implemented, needed to pass the template values. Please check whether we want this." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "Just FYI we need this to align with `builtin.EpochDurationSeconds` from specs-actors or the state machine computations will be off. We'll need to turn this into a config option and follow the same monkey patching paths as the min miner size, seal proof types etc. The EpochDurationSeconds is currently a `const` so can't do it yet tho." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure if this is what you're trying to do.", "reference": "Is this import needed?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug. I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "Dashboard stories also need to have the default padding." }, { "prediction": "I'm not sure if this is what you're looking for, but it's what you're looking for. I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "Is there a reason why we wouldn't use this as the default?" }, { "prediction": "I'm not sure if this is the case, but if it is the case, then it's the case.", "reference": "if there is an tag of the same name?" }, { "prediction": "I'm not sure if this will work for you, but it should work for you.", "reference": "I'd add `// +build go1.10` to prevent from accidentally compiling with older Go." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "Not sure how this import relates to the PR but seems like a good idea anyway..." }, { "prediction": "I'm not sure if I'm missing something, but I'm not sure if I'm missing something.", "reference": "Hmm this is strange, why should the SettingsStruct import something from `WebServer`? If that's really needed, then we must move stuff as it makes no sense to have some code related to viewing things included in a settings struct. It should be the other way around." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "nit: Space between these lines." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for a better way to do this.", "reference": "Why aggregator should have this translator? It's Selenium specifics for now..." }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "I don't understand why this function is needed? Can't you just pass the information when the `DocComparator` is created in the SortField?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "This rescue is repeated exactly in `app/jobs/mailchimp_removal_job.rb`. Could we extract a method and pull it up into `MailChimpJob` for reuse?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "It's not directly related to this PR, but it would be nice to flow the original error as we're going to print that if the promise is rejected and it'll be more informative than the vague `Network request failed`. Also, I'm not a js dev, so maybe I'm wrong, but throwing a TypeError feels a bit odd." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, so I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "Can we print a debug message when this is used? Since it's a debugging variable, I wouldn't want users to have issues because of a left-over env." }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Should we have an avatar, truncate, etc examples, too?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "could you add this to `docs/source/reference/indexing.rst`?" }, { "prediction": "I think this is a bug in rdkit.VLib.Node, but it's a bug in rdkit.VLib.Node, so it's not a bug in rdkit.VLib.Node, so it's a bug in rdkit.VLib.Node, but it's a bug in rdkit.VLib.Node, so it's a bug in rdkit.VLib.Node, so it's not a bug in rdkit.VLib.Node, so it's a bug in rdkit.VLib.Node.", "reference": "Why the change from rdkit.six to six?" }, { "prediction": "I think this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Looking good, let's just move this inside the `if` to avoid doing the extra work if we don't need it." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I think we should change this to an instanceOf check for MongoBatchReExecutionError" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Required by the libcalico-go changes" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Explain why we don't reuse the corresponding server error locally?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug.", "reference": "@JayanthyChengan This change is still missing (and should be last one!): change this line to call getDateToDisplayOnCard(), that way the logic is in only one place (that method)." }, { "prediction": "I'm not sure if this is the case, but if it is the case, then it's probably the case, but I'm not sure.", "reference": "What was wrong with more concrete error?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "can you replace the tabs with 2 spaces please to match the rest of the project?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Why are we adding it to the integral function?" }, { "prediction": "I don't think it's a bug, but it's a bug.", "reference": "Same for this file" }, { "prediction": "I'm not sure if this is the issue, but I think this is the issue.", "reference": "Looks good! But why it's still a out parameter? We can refactor the whole tree because it's internal?" }, { "prediction": "We want to unconditionally send keyboard input to the view we are focusing here, so we don't need to do this in the view_activate function.", "reference": "probably better to use `wlr_seat_keyboard_end_grab()`." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug.", "reference": "Such a large test impact for such a little 3 line change ;)" }, { "prediction": "@ORM\\ManyToMany(targetEntity=\"Shopsys\\FrameworkBundle\\Model\\Transport\\Transport\", inversedBy=\"payments\", cascade={\"persist\"}) * @ORM\\JoinTable(name=\"payments_transports\") * @ORM\\ManyToMany(targetEntity=\"Shopsys\\FrameworkBundle\\Model\\Transport\\Transport\", inversedBy=\"payments\", cascade={\"persist\"}) * @ORM\\ManyToMany(targetEntity=\"Shopsys\\FrameworkBundle\\Model\\Transport\\Transport\", inversedBy=\"payments\", cascade={\"persist\"}) * @ORM\\JoinTable(name=\"payments_transports\") * @ORM\\ManyToMany(targetEntity=\"Shopsys\\FrameworkBundle\\Model\\Transport\\Transport\", inversedBy=\"payments\", cascade={\"persist\"}) * @ORM\\ManyToMany(targetEntity=\"Shopsys\\FrameworkBundle\\Model\\Transport\\Transport\", inversedBy=\"payments\", cascade={\"persist\"}) * @ORM\\ManyToMany(targetEntity=\"Shopsys\\FrameworkBundle\\Model\\Transport\\Transport\", inversedBy=\"payments\", cascade={\"persist\"}) * @ORM\\ManyToMany(targetEntity=\"Shopsys\\FrameworkBundle\\Model\\Transport\\Transport\", inversedBy=\"payments", "reference": "Is the `cascade` necessary? It should work also without the casdade, because Payments are always already persisted when use cases with them. If it doesn't work, please tell me the reason. It is as same in Transport." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug in Psalm\\Issue.php.", "reference": "This is not very short. I'm not sure sure if there's a system for assigning shortcodes to issues." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're trying to use the ingress-annotation instead of the ingress-annotation. I'm not sure if this is what you're looking for, but it seems like you're trying to use the ingress-annotation instead of the ingress-annotation. I'm not sure if this is what you're looking for, but it seems like you're trying to use the ingress-annotation instead of the // ingress on the created Certificate resource + editInPlaceAnnotation = \"certmanager.k8s.io/edit-in-place\" // issuerNameAnnotation can be used to override the issuer specified on the // created Certificate resource. issuerNameAnnotation = \"certmanager.k8s.io/issuer\"", "reference": "We should probably prefix this with `acme-http01` to bring it in-line with other annotations, e.g. `certmanager.k8s.io/acme-http01-edit-in-place`. It's quite wordy, but it *is* more specific (and I'd hope more obvious to the user what it is for?)" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug. I'm not sure if this is a bug, but I'm not sure if it's a bug.", "reference": "No need to add this file change for this PR. Please remove it." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "this extra dot at the end is causing a couple tests to fail on Travis" }, { "prediction": "This should be a nonlocal variable, using a mutable object for Python 2 compatibility.", "reference": "Did you try using `global` with a regular integer?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "windows size might be off" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "This should still be guarded with an `#ifdef` since the DataMan code will only be supported for shared lib builds." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "thanks for cleaning up these old length checks" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "What will be logged when the `Input.Namespace` was not specified?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "I wouldn't expose this until the feature is ready. We are most likely to cut releases while still in development" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here.", "reference": "I don't think we should pull aria-query into axe-core at this point. There's a much simpler fix for this. Please don't overthink it." }, { "prediction": "public static int Get() { return this.incrementIfTriggered(); } - public static int IncrementIfTriggered() { return this.incrementIfTriggered(); } - public static int IncrementIfTriggered() { return this.incrementIfTriggered(); } - public static int IncrementIfTriggered() { return this.incrementIfTriggered(); } - public static int IncrementIfTriggered() { return this.incrementIfTriggered(); } - public static int IncrementIfTriggered() { return this.incrementIfTriggered(); } - public static int IncrementIfTriggered() { return this.incrementIfTriggered(); } - public static int IncrementIfTriggered() { return this.incrementIfTriggered(); } - public static int IncrementIfTriggered() { return this.incrementIfTriggered(); }", "reference": "@ejsmith What if instead of making these two methods public we made it a partial class and moved them to a separate file so that file could be part of the include list? I bring it up just because I don't think it is a very nice API that was ever intended to be public? I think they are only called by a couple of other very internal-y spots. /cc @reyang" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "would be good to turn these into constants." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Seems like it should be `generated by Wire` here and in the SUT?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "I know the main cases show up in the daemon test already but a little bit more unit test coverage would be nice and probably not too annoying to set up. Ideas: 1. Verify that the string \"no duplicates\" is in the LastDuplicate field when we propose a new deal. 2. Verify that proposing a duplicate deal fails when the duplicates boolean is set false. 3. Start out in a state with more than 1 duplicates. Verify that the LastDuplicate field is set to the last duplicate when we propose with a true duplicates bool." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if it's what you're trying to do.", "reference": "`Timeout.Infinite` is actually `-1`. Here the correct message can be taken from Line:67." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I'm sure it's what you're looking for.", "reference": "I think we need `#if!SILVERLIGHT` here and at the test." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, or if it's a bug.", "reference": "Can you change this import to the apache dependency? I didn't even know that jgit contains such a method..." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Four strings in a row makes me nervous, can we use an arguments struct instead? Or reuse the struct I recommend in the reconciler." }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "should work with no options, if my suggestion is accepted. JSON is the one that gets weird since a JSON object appended to a JSON object isn't valid JSON." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm not sure.", "reference": "I presume this isn't some special term..." }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it, so I'm not sure if this is the correct way to do it.", "reference": "Did you mean to return here? ;) You'll also need to add an `incomplete` message to the rule metadata." }, { "prediction": "This is replaced at runtime JivaClusterIPHolder JivaAnnotations = \"__CLUSTER_IP__\" + // JivaCloneIPHolder is used as a placeholder for sync controller IP address + // which will be used as cloneIP + // // NOTE: + // This is replaced at runtime + JivaCloneIPHolder JivaAnnotations = \"__CLONE_IP__\" + + JivaReplicaTypeHolder JivaAnnotations = \"clone\" // JivaStorageSizeHolder is used as a placeholder for persistent volume's // storage capacity // which will be used as a placeholder for persistent volume's // storage size // which will be used as a placeholder for persistent volume's // storage size // which will be used as a placeholder for persistent volume's // storage size // which will be used as a placeholder for persistent volume's // storage size // which will be used as a placeholder for persistent volume's // storage size // which will be used as a placeholder for persistent volume's // storage size // which will be used as a placeholder for persistent volume's // storage size // which will be used as a placeholder for persistent volume's // storage size // which will be used as a placeholder for persistent", "reference": "Why are we calling these as annotations? I guess this is an old type that we are re-using. But lets make it a point to avoid once we feel that this design/code is not good." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "`invocation.getInvocationStageTrace().startSend()` is inside `RestClientSender.send`" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "use \"actionHash\" to be consistent with other places" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `` `` `` `` `` `` ````````````````````````````````````````````````````````````", "reference": "Can we derive `Class` by looking at one of the label choices, if at least one is always provided? Given these are immutable, a real-world case for an empty enumerations eludes me." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "I am now confused here, the spec says > If format is VK_FORMAT_UNDEFINED, all members of samplerYcbcrConversionComponents must be the identity swizzle. The spec also says > samplerYcbcrConversionComponents is the component swizzle that **should** be used in VkSamplerYcbcrConversionCreateInfo. so you are allowed to set the swizzle to anything I want, so I guess this is valid usage here... but now I am more curious if I have an external format does it not have to follow any component swizzle rules and can be anything regardless of the `ycbcrModel`? (I guess really a question for @critsec and is not a blocking concern for the scope of this PR)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here.", "reference": "I'd say the error should be an error, not instructions to the user. So error would be something like \"site should be running and is not\"" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Thanks for this PR @pinzon! Rather than resetting the `sms_messages` list, can we fix the assertion in line 902 - rather than asserting `len` equality, we should assert that all expected messages are contained in the list. (In this case the phone numbers should be reasonably random, and ideally we should not have duplicates across different tests). We're planning to introduce test parallelization in the near future, and this will help us avoiding undesired side-effects. Thanks" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Some weird blocks formation again." }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "This is worrisome." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for: // AutoFilesystemTrimStatus returns the status of auto fs trim // operations on locally mounted volumes + AutoFilesystemTrimStatus(request *api.SdkAutoFSTrimStatusRequest) (*api.SdkAutoFSTrimStatusResponse, error) + // AutoFilesystemTrimUsage returns the usage of auto fs trim // operations on locally mounted volumes + AutoFilesystemTrimUsage(request *api.SdkAutoFSTrimUsageRequest) (*api.SdkAutoFSTrimUsageResponse, error) // FilesystemTrimStop stops a filesystem trim background operation on // a specified volume, if any FilesystemTrimStop(request *api.SdkFilesystemTrimStopRequest) (*api.SdkFilesystemTrimStopResponse, error)", "reference": "nit try rephrasing to something like \" AutoFilesystemTrimUsage returns the volume usage and trimmable space of locally mounted pxd volumes\"" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this: h['puppetserver-confdir'] = '/etc/puppetlabs/puppetserver/conf.d' h['puppetbindir'] = '/opt/puppetlabs/agent/bin:/opt/puppetlabs/bin' h['puppetbindir'] = '/opt/puppetlabs/agent/bin:/opt/puppetlabs/bin' h['puppetbindir'] = '/opt/puppetlabs/agent/bin:/opt/puppetlabs/bin' h['puppetbindir'] = '/opt/puppetlabs/agent/bin:/opt/puppetlabs/bin' h['puppetbindir'] = '/opt/puppetlabs/agent/bin:/opt/puppetlabs/bin' h['puppetbindir'] = '/opt/puppetlabs/agent/bin:/opt/puppetlabs/bin' h['puppetbindir']", "reference": "currently the puppet-agent package doesn't symlink files into /opt/puppetlabs/bin. Also many puppet acceptance tests that execute on Unix assume puppetbindir is a single directory (windows doesn't have this issue). So I think if we want to unblock testing, this should just be changed to `h['puppetbindir'] = '/opt/puppetlabs/puppet/bin`" }, { "prediction": "I'm not sure if this is the correct way to do this, but I think it's the correct way to do it.", "reference": "any point in keeping this here?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "I don't think we need this check. Instead `Entries.merge` should check that its argument is correctly sorted (in addition to the existing pre/post check on the method receiver)." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "This is not really good to mix different code bases. @TheMarex I understand the point about placing code into cpp file, but we still need to move templated version into an impl header, remove references to offline code here and keep template instantiations in a cpp file to avoid rebuild. So offline code could instantiate own implementations using private impl headers. Otherwise we again make wrong dependencies into OSRM code and block changes in separate projects." }, { "prediction": "I'm not sure if this is what you're trying to do, but it should be something like this:", "reference": "Then, where is it removed?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm assuming you're trying to do this in a test case. I'm assuming you're trying to do this in a test case, so I'm not sure what you're trying to do here.", "reference": "The tests are not run concurrently? (I don't know. Better check.)" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Regardless of scale?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Nit: should not we hide them from printing out?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "What is the reason to modify those things? I noticed it breaks the examples using `asyncio`" }, { "prediction": "I'm not sure if this is the case, but maybe it's the case?", "reference": "WHOOOOOOOPS! so this is a wire protocol breaking change. I deployed a dev version of yarpc 1.9 to demo-yarpc-go and it caused bad request errors because it couldn't determine the procedure anymore. (in coordination with yarpc-prober)" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "if we keep this, can we stick to our convention of using UPPER_CASE for constants? Otherwise this looks like a floating variable to me." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "You probably don't want to assume that `self.underlayer` has a `seq` attribute." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "This apparently breaks the language selection." }, { "prediction": "This migration comes from acts_as_taggable_on_engine (originally 5) +# This migration is added to circumvent issue #623 and have special characters +# work properly +class ChangeCollationForTagNames < ActiveRecord::Migration + def up + if ActsAsTaggableOn::Utils.using_mysql? + execute(\"ALTER TABLE tags MODIFY name varchar(255) CHARACTER SET utf8 COLLATE utf8_bin;\") + else execute(\"ALTER TABLE tags MODIFY name varchar(255) CHARACTER SET utf8 COLLATE utf8_bin;\") + end + end", "reference": "since we're not using mysql, do we need this migration?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "i'm not sure about htis naming here. both the word partition and adjustment are very ambiguous and it's not clear what it does. i would maybe go for something less generic and more concrete like `GOV_CLOUD_SUPPORT`" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do. I'm not sure if this is what you're trying to do, but I'm sure it's what you're trying to do.", "reference": "unfinishedFlows might not be the same as activeFlows. Will it cause confusion here?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "Same, remove the error handling." }, { "prediction": "I'm not sure if I'm missing something, but I'm not sure if I'm missing something. I'm not sure if I'm missing something, but I'm not sure if I'm missing something.", "reference": "We should not change this at this time." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "We may also update the docstring in the AnchorGenerator's arguments at around line 15." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure.", "reference": "FormatHandle isn't current typesafe w.r.t. requiring *VULKAN* handles... so this slipped through." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for \"github.com/mysteriumnetwork/node/identity\" \"github.com/stretchr/testify/assert\" \"github.com/stretchr/testify/assert\" \"github.com/stretchr/testify/assert\" \"github.com/stretchr/testify/assert\" \"github.com/stretchr/testify/assert\" \"github.com/stretchr/testify/assert\" \"github.com/stretchr/testify/assert\" \"github.com/stretchr/testify/assert\" \"github.com/stretchr/testify/assert\" \"github.com/stretchr/testify/assert\" \"github.com/stretchr/testify/assert\" \"github.com/stretchr/testify/assert\" \"github.com/stretchr/testify/assert\" \"github.com/stretchr/testify/assert\" \"github.com/stretchr/testify/assert\" \"github.com/", "reference": "What kind of dependency is here, I think we have own implementation of event wo external dependencies" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's a bug.", "reference": "Throw an exception instead" }, { "prediction": "I think this is what you are looking for: https://github.com/rspec/rspec/blob/master/src/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec/rspec", "reference": "we shouldn't need the `FactoryBot.` in these. Ok to leave for now since all of these specs have them. Can clean up later" }, { "prediction": "I think it's better to just return Url::asset($uploadsPath). '/protected'; instead of return Url::asset($uploadsPath). '/protected';", "reference": "Isn't the better option to actually do `$this->getDisk()->url($uploadsPath)` without changing the filesystems config? Not sure why you think that change is required but it's definitely not getting merged." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "Not sure if we need this. It's not tested because it only guards against a new conditional definition of a dunder method in a built-in package. I am fine with leaving it out." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Is this the only task in this library? If so this is good, if not then we should do it for each task." }, { "prediction": "I think this is what you're looking for.", "reference": "I am not sure what is 120 and what is 10. Hence unable to review." }, { "prediction": "@ -47,8 +47,9 @ @ type Options { Location OptionsLocation Transactor OptionsTransactor - Openvpn Openvpn - Firewall OptionsFirewall + EnableDNS bool + Openvpn Openvpn + Firewall OptionsFirewall }", "reference": "Not needed anymore" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "Please not abbreviations" }, { "prediction": "We don't want to do this. Instead, we want to do something like this. We don't want to do this, but we want to do something like this.", "reference": "This shouldn't get stomped over on line 207" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "are they not 1-indexed?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug", "reference": "I know that previously this check was here but @ralph-pichler replaced it with the `CheckTimestamp` field stating that checking against `Timestamp` was incorrect. @ralph-pichler can you elaborate?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "`short_version = __version__`" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to update the status of an access key for an AWS Identity and Access Management (IAM) user. I'm assuming you're trying to update the status of an access key for an AWS Identity and Access Management (IAM) user. I'm not sure what you're trying to do, but I'm assuming you're trying to update the status of an access key for an AWS Identity and Access Management (AWS IAM) user.", "reference": "AWS Identity and Access Management (IAM)" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Required for the SparkDataFile SerDe" }, { "prediction": "I think this is a bug. It is a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug.", "reference": "Do you want to make this an assertion instead?" }, { "prediction": "This file is not part of the GNU General Public License. It is part of the GNU General Public License. It is not part of the GNU General Public License.", "reference": "When updating the copyright, we tend to cover previous years, not just the current. So, if we started the file in 2015, we'd update to say 2015-2016. I'm not sure if there's a legal requirement surrounding this, but it's the convention we and many others have adopted for code." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "Wait, so it looks like this function is called _every_ time we fetch the root node, i.e. we do an MD head fetch every time we fetch the root node? Not for this PR, but it seems like we should make that unnecessary, since this function only ever does anything when head is `nil`, i.e. the first time. Maybe add a TODO?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Why are you changing this?" }, { "prediction": "I'm not sure why we are getting this error, but I'm not sure how to handle it, but I'm not sure why we are getting this error, so I'm not sure how to handle it. I'm not sure why we are getting this error, but I'm not sure how to handle it, so I'm not sure how to handle it.", "reference": "`json.RawMessage` is a `[]byte`, which is already a pointer. Why do we need to have pointer here if we just reading this value?" }, { "prediction": "I'm not sure if I'm correct, but I think I'm missing something here.", "reference": "should we actually switch to `All` or just add `0.4.0` explicitly to the list of supported CNI versions? What is a new CNI version is released?" }, { "prediction": "I think this is a bug in google.cloud.security.common.data_access.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners.scanners", "reference": "pylint might complain that this isn't alphasorted?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "It seems that NetworkService is behind a feature flag because it's still experimental. If we see new issues, we should look at flipping this back off." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I think it makes more sense to have this be a method on TaskStatus. Also, nit, Backend, not BackEnd." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Could you please elaborate on why you need all this magic here? In which cases do you want the same id to be returned? Does this work the same way for all backends?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "nit: `PluginConfigs` feels a little better" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "think we need to find out the root-cause and fix, instead of just removing `NoError`? it erred b/c `context canceled`, so call this before context cancelled is the right fix" }, { "prediction": "The `Get` method is deprecated. It should be replaced with `Get` and `Get` and `Get` instead of `Get` and `Get`.", "reference": "Please expand \"later behavior\". Presumably something to do with the prefetch logic?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "The `response` variable is not used, it can be removed, also the fmt.Errorf." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Do you find this really easier to read?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug. I'm not sure what you're trying to do, but it's a bug.", "reference": "A small nit: This variable should start with a lower case letter." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Where is this used for Node?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Is `` really easier to understand than `` for CLI user? For me, `identity` seems like a concept we use publicly, and `id` is just an internal shortcut for it." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "nit.. `if`.. `else` for logging probably can be avoided.. maybe only log that an internal group was created for cluster group" }, { "prediction": "I'm not sure if this is what you're looking for, but it looks like you're looking for \"github.com/aws/amazon-ecs-agent/agent/engine/dockerstate/mocks\" \"github.com/aws/amazon-ecs-agent/agent/engine/dockerstate/mocks\" \"github.com/aws/amazon-ecs-agent/agent/engine/dockerstate/mocks\" \"github.com/aws/amazon-ecs-agent/agent/engine/dockerstate/mocks\" \"github.com/aws/amazon-ecs-agent/agent/engine/dockerstate/mocks\" \"github.com/aws/amazon-ecs-agent/agent/engine/dockerstate/mocks\" \"github.com/aws/amazon-ecs-agent/agent/engine/dockerstate/mocks\" \"github.com/aws/amazon-ecs-agent/agent/engine/dockerstate/mocks\" \"github.com/aws/amazon-ecs-agent/agent/engine/dockerstate/mocks\" \"github.com/aws/amazon-ecs-agent/agent", "reference": "There's a lot of changed tests -- but no new tests. You need unit and integration tests for this." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but if it's a bug, I'm sure it's a bug.", "reference": "WithMessage what gas limit is?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "Why are these skipped?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for.", "reference": "We'd better add the `json:\"metaServer,omitempty\"` here" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "So... when we want to install mitmproxy with pinned dependencies, we first install all pinned dependencies, and then in a second step install mitmproxy as editable, making sure that no additional dependencies are sneaking in." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "not sure how this got in master, but the linter is unhappy about it so I fixed it here" }, { "prediction": "I'm not sure if this is the right way to do it, but I think it's the right way to do it.", "reference": "No need for this TODO anymore, right?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "I would assign the key you're looking for into a variable first, and then use it in the comparisons." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's a good idea to just delete the plugin from our internal container + unset($this->plugins[ $this->normalizeIdentifier($id) ]); if ($this->plugins[ $this->normalizeIdentifier($id) ]) { $this->plugins[ $this->normalizeIdentifier($id) ] = $this->normalizeIdentifier($id); } else { $this->plugins[ $this->normalizeIdentifier($id) ] = $this->normalizeIdentifier($id); } if ($this->plugins[ $this->normalizeIdentifier($id) ]) { $this->plugins[ $this->normalizeIdentifier($id) ] = $this->normalizeIdentifier($id); } else { $this->plugins[ $this->normalizeIdentifier($id) ] = $this->normalizeIdentifier($id); } if ($this->plugins[ $this->normalizeIdentifier($id) ]) { $this->plugins[ $this->normalizeIdentifier($id) ] = $this->normalizeIdentifier($id); } else { $this->plugins[ $this->normalizeIdentifier($id) ] = $this->normalizeIdentifier($", "reference": "Would be better to normalize it at the start of the method to pass through to all the other calls" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "This can't exist here either because the code editor can be used on other models than CMS templates. You could probably implement this as a `hint` property (so `hint: cms::lang.cms_object.safe_mode_enabled`) on the codeeditor formwidget instead though and I'd be fine with that." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "This line is unnecessary." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "How did this compile in the first place? Is there a matching declaration in a header that should be removed too?" }, { "prediction": "private static void h2o_mruby_new_str(mrb_state *mrb, const char *s, size_t len) { if (mrb->exc!= NULL) h2o_mruby__abort_exc(mrb, \"h2o_mruby_new_str:failed to create string:\", file, line); if (mrb->exc!= NULL) h2o_mruby__abort_exc(mrb, \"h2o_mruby_new_str:precondition failure\", file, line); mrb_value ret = mrb_str_new(mrb, s, len); - h2o_mruby_assert(mrb); + if (mrb->exc!= NULL) + h2o_mruby__abort_exc(mrb, \"h2o_mruby_new_str:failed to create string:\", file, line); return ret; }", "reference": "Please remove the colon at the end, and merge the PR once the CI succeeds. Thank you for the PR." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "whoops. this should be protoc-gen-doc, since that is the only bit left that is built out-of-tree (everything else is either downloaded or built via modules already depended on by spire's go.mod)" }, { "prediction": "The AzkabanEventReporter interface is deprecated. It is now deprecated. The AzkabanEventReporter interface is now deprecated. The AzkabanEventReporter interface is now deprecated. The AzkabanEventReporter interface is now deprecated. The `AzkabanEventReporter` interface is now deprecated. The `AzkabanEventReporter` interface is now deprecated. The `AzkabanEventReporter` interface is now deprecated. The `AzkabanEventReporter` interface is now deprecated. The `AzkabanEventReporter` interface is now deprecated. The `AzkabanEventReporter` interface is now deprecated. The `AzkabanEventReporter` interface is now deprecated. The `AzkabanEventReporter` interface is now deprecated. The `AzkabanEventReporter` interface is now deprecated. The `AzkabanEventReporter` interface is now deprecated. The `AzkabanEventReporter` interface is now deprecated. The `AzkabanEventReporter` interface is now deprecated. The `AzkabanEventReporter` interface is now deprecated. The `AzkabanEventReporter` interface is now deprecated. The `AzkabanEvent", "reference": "The convention is to use

    see the google style guide and use checkstyle to check. You can change it later." }, { "prediction": "I think this is what you're looking for, but I'm not sure what you're looking for.", "reference": "Using non-keyword args after the keyword arg (parent-self) will cause a SyntaxError." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "I think you'll want to add some YARD docs to this method to get the PR approved" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure.", "reference": "Hmm, AFAICT `*out_variant` isn't explicitly set to `NULL` in the `ENOENT` case." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Nit: \"Failed to configure TLS for SDK client\"?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "please update your branch to the latest `master`. This change was already made in #4359" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "This line should be formatted" }, { "prediction": "I think this is what you are looking for: https://github.com/boost/blob/master/boost/program_options.txt", "reference": "\"default 65536\" Not sure if it's important to state, but block_processor_full_size has a different default for fast_bootstrap." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, then it's probably a good idea to use a cache.", "reference": "remove unnecessary whitespace changes" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Are these conditions covered elsewhere?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "the above check (by transitivity) checked for `in_data.name_id == out_data.name_id && in_data.name_id!= EMPTY_NAME_ID && out_data.name_id!= EMPTY_NAME_ID`. The final check of `out_data.name_id!= EMPTY_NAME_ID` is missing now." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "The event handle is being passed by reference, so the dereference on 591 is actually correct. To follow the convention that variables be declared before executable statements, please change the code to the following: struct _fpga_event_handle *_eh; fpga_result result = FPGA_OK; int err = 0; if (!event_handle) { return FPGA_INVALID_PARAM; } _eh = (struct _fpga_event_handle *) *event_handle;" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "reorder includes to be alphabetically ordered" }, { "prediction": "I think this is a bug. It should be fixed in the future, but it should be fixed in the future.", "reference": "Rename `need_unmap` to `unmap`." }, { "prediction": "\"github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/common\" \"github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/debug/iochaos\" \"github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/debug/networkchaos\" \"github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/debug/stresschaos\" \"github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/debug/networkchaos\" \"github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/debug/networkchaos\" \"github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/debug/stresschaos\" \"github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/debug/networkchaos\" \"github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/debug/networkchaos\" \"github.com/chaos-mesh/chaos-mesh", "reference": "In line 28, it has been declared twice, so removing `cm` should not impact, can you explain me little bit? :)" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "i don't think these unexported functions belong on the public interface, they can exist solely on the struct." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I'm not entirely clear on why this is necessary?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "Why do we need to cast to `str` here?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug. I'm not sure if this is a bug, but I'm not sure if it's a bug.", "reference": "The ignore import above should be unused now and can be removed." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "redundant null check?" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, then you'll need to change your code so that it's easier to understand what you're trying to do.", "reference": "initialization of available ram is here" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if this is the case, or if it's the case, or if it's the case, but I'm not sure if it's the case.", "reference": "Can have negative numbers with the '-' on the right (`10-`) by just using line 610." }, { "prediction": "This is only possible for users with no associated resources.", "reference": "AWS Identity and Access Management (IAM)" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Shouldn't we use store a message which indicates that there was no available checker command? By the way how is it possible that metadata.json doesn't contain the checker command? Maybe this was the case in the earlier versions?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Given that this is a boolean predicate, maybe it should be `full_backtrace?`." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Just curious why the blank line here?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to import a module that doesn't exist in the current version of mitmproxy, so I'm guessing you're trying to import a module that doesn't exist in the current version of mitmproxy. I'm guessing you're trying to import a module that doesn't exist in the current version of mitmproxy, so I'm guessing you're trying to import a module that doesn't exist in the current version of mitmproxy, so I'm guessing you're trying to import a module that doesn't exist in the current version of mitmproxy. I'm guessing you're trying to import a module that doesn't exist in the current version of mitmproxy, so I'm guessing you're trying to import a module that doesn't exist in the current version of mitmproxy, so I'm guessing you're trying to import a module that doesn't exist in the current version of mitmproxy.", "reference": "I like the idea, but we don't want a dependency on mitmproxy in pathod." }, { "prediction": "I'm not sure if this is what you're trying to do, but it's worth noting that this is what you're trying to do.", "reference": "Why not adding this to the interface and keep passing the interface (as the interface is internal I don't get why you're not adding it there)" }, { "prediction": "I think this is a bug in pylint.checkers.utils.py. It should be fixed in pylint.checkers.utils.py. It should be fixed in pylint.checkers.utils.py. It should be fixed in pylint.checkers.utils.py. It should be fixed in pylint.checkers.utils.py. It should be fixed in pylint.checkers.utils.py. It should be fixed in pylint.checkers.utils.py. It should be fixed in pylint.checkers.utils.py.", "reference": "`PY310` should probably be imported from `pylint.const`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Can we propagate this error up the stack?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Why reference is converted to table?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "You shouldn't use assert for runtime errors." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Does this really belong in the vendor directory if you wrote it? At very least, should it get its own repo somewhere in addition to being dropped here?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "I think it would be better to place the rule name before the message. Messages are of varying lengths and the rule names will end up misaligned" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Can we remove the argument from this message? A message will include a line number already that points to the place in the code that has the problem. I think we can remove it." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "This whole class is now a mix of virtual and non-virtual. I tried to see what would happen if I made everything non-virtual in dev, and the build still passes. It turns out that none of the other methods actually need to be virtual. Can you make *all* the logging methods either virtual or not for consistency? Thanks." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "This looks a bit cryptic to me, and also it contains a dash. How about `mymysterium.url`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "You did notice the no newline at the end of this file, right?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug. I'm not sure if this is a bug, but it's a bug. I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "Here's the object model change. `CodeFlows` is a set of objects of type `CodeFlow`, rather than a list of list of `AnnotatedCodeLocation`. Exactly parallel with `Stacks`." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this, and it's not clear what you're trying to do here.", "reference": "Sorry, one more thing... You should use `app.config` instead of importing it directly. See the code below." }, { "prediction": "I'm not sure if this is what you're looking for, but it's worth noting that this should be done in a separate file.", "reference": "This was correct before; \"setup\" is a noun and \"set up\" is the verb form." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "What's the reason for this change here? I didn't see it mentioned in the PR and it's a bit of a confusing param name" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "I wonder why ~ and not a wildcard instead?" }, { "prediction": "I think this is a bug. It should be a bug. It should be a bug.", "reference": "when will this happened? if happened, just ignore it Silently?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "3x the smaller size would be around 17k, and we need it to be at least about 13k, which is 2x the larger size. I'd probably set this to 15k to split the difference and hopefully avoid needing to update this again as tests change. This is minor, though." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "@scottpurdy, strictly speaking, should this scenario raise a ValueError exception instead of AssertionError?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Can you please add open source disclaimer?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "I dont want to do composite keys on purpose to verify at compile time if the message is completely filled out appropriately @sectioneight" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "don't need this line, since it is not tested in api_test?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "Does this mean the list operation is done for all the namespaces? How to list the volume replicas per namespace?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "I suggest adding `class_agnostic` as an argument of `batched_nms()`, with the default value False." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "@rdblue, did we not add the name on purpose?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Why is this now public?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "I guess we should backport some deprecation for this?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "Moving this code inside the last case statement doesn't seem right. Why are we defining `name` and `is_relative` variables there if we aren't using them anywhere?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "I would say just change REGARG: no need for a separate thing." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "we can remove this template, it is no longer in use" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "This doesn't look like it has as much coverage of the recursive code as it once did." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for.", "reference": "Do we actually expect users to provide more information here than possibly a SecurityGroup ID? If not, then this should probably use a new type, otherwise users might be confused by what options would be respected/ignored when used in this context." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "This seems like a new dependency on rometools. Do we need it?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Waiting for the pull takes a long time. This message informs the user that at least one of the images being pulled is available. Please leave." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I can not think in a good use for it, but may we allow a way to setup a fake with a hook for logs? this fake is special, and we may need access to some of thoe logs, at the same time it may be an overkill because we dont want to test \"sql\" implementation but results.. but we can create some tests with end to end logs in some scenaries, What do you think about it?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "I don't think you should be changing the dag unilaterally at parse time. If cores isn't specified, then it isn't specified." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm assuming it's what you're trying to do, and that you're trying to do, and that you're trying to do, and that you're trying to do, and that you're trying to do, and that you're trying to do, and that you're trying to do, and that you're trying to do, and that you're trying to do, and that you're trying to do, and that you're trying to do, and that you're trying to do, and that you're trying to do, and that you're trying to do, and that you're trying to do, and that you're trying to do, and that you're trying to do, and that you're trying to do, and that you're trying to do, and that you're trying to do, and that you're trying to do, and that you're trying to do, and that you're trying to do, and that's what you're trying to do, and that's what you're trying to do.", "reference": "Instead of just \"See SubscriberOptions....\", say something like \"Use... to choose between the two.\"" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Use with statement for `f`" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "It's a small style point, but could you remove the \"extra\" space before the colon that precedes the return type? This would make it more closely match the prevailing style in these tests and in the standard libraries." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "seems clunky to me to have an `MDOps` interface method that some implementations don't implement. Perhaps define a separate interface, like, `BranchResolver`, and then callers that have an `MDOps` object can check via type assertion?" }, { "prediction": "@see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.", "reference": "This change should also probably go into the corresponding method of the abstract By class?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "File is not `gofmt`-ed with `-s` (from `gofmt`)" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "This is likely to return an error value if the client fails to read the response we write, which is why I chose to ignore this error." }, { "prediction": "I don't think this is a bug, but I think it's a bug.", "reference": "this method is not used" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "Right now it's a bit unclear that this needs to be called explicitly by the implementing class. If, for example, there's another backend, it won't get this update unless we add the same function as webkit. Could you either add a note to this docstring explaining that this needs to be called, or find some way to automatically trigger this so the webkit override isn't needed (and some override passed on webengine)." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Why this change (test name still says \"must pass with metadata\")?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Another nitpick: parens around the arg pretty please" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like it's a bug. I'm not sure what you're trying to do, but it seems like it's a bug.", "reference": "This spec can be modified, giving you extra strength (Check this fetch key doesn't work and therefore returns `nil`)" }, { "prediction": "You can use the context key to access the original request URI that accompanied the // server request. The value will be of type string. const URLPathCtxKey CtxKey = \"url_path\" + +// URIxRewriteCtxKey is a context key used to store original unrewritten +// URI in context.WithValue +const URIxRewriteCtxKey CtxKey = \"caddy_rewrite_original_uri\"", "reference": "Oh, I guess I mentioned/pressed this point in the other issue, that this should probably go into the httpserver package. In fact, so should the const above this (URLPathCtxKey). These are specific to the HTTP server." }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Not added by you, but we don't really need the '5' here.." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "The vendor prefix is still being used on Chromium based browsers like Edge Chromium and Chrome. Did you mean to remove this?" }, { "prediction": "I don't think it's possible to do this.", "reference": "I don't think this is needed anymore?" }, { "prediction": "should this be a helper function? Or should this be a helper function? Or should this be a helper function?", "reference": "This is the only occurrence I see in the code where we now need to convert from a boolean protobuf wrapper to a boolean pointer. This felt a little cumbersome here; should we consider moving it somewhere else as a helper function?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "Need you to delete the `version_` from `HostInfo` struct?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, depending on what you're trying to do, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, like this, or something like this, or something like this, or something like this, like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or something like this, or", "reference": "This could be the cleanest looking check we've got. Great job Jey." }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if this is the correct way to do it.", "reference": "Who invited yoda? In all seriousness though, wouldn't an `if (empty())` be better here?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "You can use `appRouter.goHome` to do this (It's defined in site.js), it's less hacky than overriding the href." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "When could this happen?" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's probably something you're trying to do.", "reference": "I assume this was removed because it was redundant? and conflicted with the now dynamic contentType? Edit: Oh I see it being set was moved to the `PostSegmentAsync` call." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Here is a newline missing" }, { "prediction": "The latest release is the only one available in /bin/macosx elsif r_version == 'devel' - r_url = \"https://mac.r-project.org/el-capitan/R-devel/R-devel-el-capitan.pkg\" + r_url = \"http://mac.r-project.org/high-sierra/R-4.0-branch/R-4.0-branch.pkg\" # The latest release is the only one available in /bin/macosx elsif r_version == 'devel' - r_url = \"http://mac.r-project.org/high-sierra/R-4.0-branch/R-4.0-branch.pkg\" + r_url = \"http://mac.r-project.org/high-sierra/R-4.0-branch/R-4.0-branch.pkg\" + r_url = \"http://mac.r-project.org/high-sierra/R-4.0-branch/R-4.0-branch.pkg\" + r_url = \"http://mac.r-project.org/high-sierra/R-4.0-branch/R-4.0-", "reference": "Did you mean to make this http rather than https?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "The updated copyright header should be: # Copyright (C) 2006-2018 NV Access Limited, yourname" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "wow :+1:, i do not even know how this test works." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "File should be renamed `PlugIn` -> `Plugin`" }, { "prediction": "I'm not sure if this will work for you, but it should work for you.", "reference": "I scanned the new test cases quickly. Do we have one for an egressIPPool with multiple different IP ranges?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "you can use a different name, like `maybe_activate` or `is_active` without `component` in the method name as this is used in the class name. E.g: `$component->should_component_be_active` is using twice the `component` word" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "I think this might not be a complete enough check: what if `options` is `null`/`undefined`?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Useless assignment to variable - `user`." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "I think we would want to keep `-O` instead. I wonder how this worked before, though." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "another alternate option which doesn't have the risk of too many entries (when user keeps providing keys in different order) Have the dictionary as before If tagKeys lookup fail, sort and lookup again. If fails, insert both original tagKeys and its sorted one to the dictionary. So that we only store atmost 2 entries per key set. And we only do a single lookup in hotpath, as opposed to 2 look ups." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's probably what you're trying to do.", "reference": "if (out!= nullptr)" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "In the listenstore you catch the exception and then pass it on via Raise. However, here you do not catch the exception. You should catch the exception, but since this is a minor aspect of this page, perhaps show an error message when the count cannot be loaded in time. Then the rest of the page can still be rendered, rather than failing the whole page." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "wouldn't it be simpler to just add `or transfer` here? That way the more complicated set of conditionals down below don't have to get more clauses." }, { "prediction": "I'm not sure if this is a bug or a bug, but it seems to be fixed in the future.", "reference": "ditto; please fix everywhere" }, { "prediction": "I think this is what you are looking for.", "reference": "Can you break this line into two parts - the first line makes the option help text for `--sftp-server` and its too long! `Specifies the path or command to run a sftp server on the remote host. The subsystem option is ignored when sftp_server is defined.`" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "I reverted that one in a previous PR because of a CI failure but it was actually unrelated" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this: ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "The for loop is useless here, since any error will make the function return." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Fix file endings here and elsewhere." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "I'd better increase `buf` length to MAXPATHLEN and not cut p->get_project_name() output twice" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case.", "reference": "Please remove the prints, even though this code will be trashed." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Not sure if you added deliberately but I've seen these popping up; is goimports adding them?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'll try to fix it.", "reference": "I think we might need some special handling for `Spec.ControlPlaneLoadBalancer.SecurityGroups`, it looks like we are currently only handling the case that `Spec.ControlPlaneLoadBalancer` is nil." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Is this from a third-party library?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "Please put the `el.tabIndex > -1` in the first part of the expression. The matcher will run on every node on the page, so we should put the fastest part first." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "`identity` is unused now, is it for future usage?" }, { "prediction": "The prompt to display. # @param options A hash of additional options. # @option options [Boolean] sensitive `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `Sensitive` `", "reference": "This would have assisted me a lot! I am on the \"functions\" page more than any other page in the docs" }, { "prediction": "I'm not sure what you're trying to do, but if you're trying to do this, you can do this:", "reference": "I think it's better we keep `(` and encode with default encoding (utf-8)." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug in SpotlessPlugin.", "reference": "this is gonna be different in an IDE vs from gradlew??" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Do we not already have something for isolating syntax?" }, { "prediction": "This file is part of Invenio. It is part of the GNU General Public License. It is not part of the GNU General Public License. It is part of the GNU General Public License. It is not part of the GNU General Public License. It is part of the GNU General Public License. It is not part of the GNU General Public License. It is part of the GNU General Public License. It is not part of the GNU General Public License.", "reference": "1: D100 Docstring missing 4: I102 copyright year is outdated, expected 2014 but got 2012 158: D103 Docstring missing 168: D101 Docstring missing 170: D102 Docstring missing 180: D102 Docstring missing 187: D102 Docstring missing" }, { "prediction": "The Amazon S3 bucket has been removed from the S3 bucket. The S3 bucket has been removed from the S3 bucket. The S3 bucket has been removed from the S3 bucket. The S3 bucket has been removed from the S3 bucket. The S3 bucket has been removed from the S3 bucket. The S3 bucket has been removed from the S3 bucket. The S3 bucket has been removed from the S3 bucket. The S3 bucket has been removed from the S3 bucket. The S3 bucket has been removed from the S3 bucket. The S3 bucket has been removed from the S3 bucket. The S3 bucket has been removed from the S3 bucket. The S3 bucket has been removed from the S3 bucket.", "reference": "how **to** deny" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm correct, but I'm not sure if I'm correct, or if I'm wrong, or if I'm wrong, I'm wrong.", "reference": "The only beef I have with this is that it's app domain global." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure.", "reference": "Can you link to the GitHub issue and/or PR so that it is easy for future readers to find out more about this?" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "Typical to report the value found as well as the valid bounds." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "maybe we want 0 as a default value?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "can we get height from sf at very beginning of the function and use that as height of the block?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like Microsoft.AspNet.Server.Kestrel.StandardsPolice.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.StandardsPoliceCompileModule.Standards", "reference": "Does this have to be public and in the primary namespace?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case, but I think it's the case.", "reference": "I'm a bit confused. Doesn't `mdWriterLock` already synchronizes calls to this function?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Does it make sense to generate a dailyMotion url without the video reference? It does not to me, but can we throw an exception here?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this.", "reference": "Why the separation of imports here?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "Random extra newline." }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if it's the correct way to do it, but I think it's the correct way to do it.", "reference": "No need for this variable." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Why not use `msg` directly below?" }, { "prediction": "I'm not sure if this is a bug, but it's definitely a bug.", "reference": "I think other places changed to use `Deque` instead of suppressing the warning." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this. I'm not sure what you're trying to do, but I think you're trying to do something like this. I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this. I'm assuming you're doing something like this, but I'm not sure what you're trying to do.", "reference": "missing: utility, cstddef also: vector is already included in the header (interface requires vectors as in/out types)" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "I'm not sure this is necessary in the config here, as Jest would be setting the global `fetchMock = ''`. See below." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "Can `mFolder == null` happen during regular operations? Or is it only so we can be lazy in tests?" }, { "prediction": "I think this is what you're looking for.", "reference": "I'd suggest using the actual MIME types here - so `text/plain` and `multipart/alternative` or does that cause problems with what postgres allows for enumeration names? If so then maybe just replace the slash with an underscore?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. If it's a bug, it's a bug.", "reference": "Ohh. `TeamName` is actually a \"friendly\" name displayed in the Catalog - not the name used in the CLI. So I guess we'll need a new variable here. (That is, this is going to be mainly a `quilt.yaml` change. You won't need the `.lower()`, though.)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Nit: Don't move it between `require_dummy_response` definition and usage, this can live above or below :)" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do this with a block service that doesn't have an archiver. I'm guessing you're trying to do this with a block service that doesn't have an archiver, and you're trying to do this with a block service that doesn't have an archiver, and you're trying to do this with a block service that doesn't have an archiver. If you're using a block service that doesn't have an archiver, it will return StatusNotFound (404). If you're using a block service that doesn't have an archiver, it will return StatusNotFound (404). If you're using a block service that doesn't have an archiver, it will return StatusNotFound (404). If you're using a block service that doesn't have an archiver, it will return StatusNotFound (404). If you're using a block service that doesn't have an archiver, it will return StatusNotFound (404). If you're using a block service that doesn't have an archiver, it will return StatusNotFound (404) when", "reference": "With the current code, it not work if `EnableCatchupFromArchiveServers` is disabled. to fix it: in getDNSAddrs, change the predicate to `if wn.config.EnableCatchupFromArchiveServers || wn.config. EnableCatchupFromArchiveServers {` and in the catchup/service.go and catchup/catchpointService.go, use the `PeersPhonebookArchivers` only when `wn.config.EnableCatchupFromArchiveServers` is enabled." }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so I'm not sure if it's a bug, or if it's a bug.", "reference": "Why not make `SearchForNodes` do a `GetOrCreate` for the root node? (Not advocating for it, but just wondering if there's another reason than avoiding having to pass in the path.)" }, { "prediction": "I'm not sure if it's a bug, but maybe it's a bug?", "reference": ":+1: amazing that this has been missing since it was originally implemented" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Just want to note here that although we do check `length` while writing to choose whether to close and start a new file, that doesn't happen for ORC already so it is fine to use a FS call in this method." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "nit: I feel multiple `if (...) { return... }` is more readable than `if... else...`." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "This is needed for us to work in IDE UTs" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this, and I'm not sure what you're trying to do.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's worth noting that this is what you're trying to do. I'm not sure if this is what you're trying to do, but it's worth noting that this is what you're trying to do. I'm not sure if this is what you're trying to do, but it's worth noting that this is what you're trying to do. I'm not sure if this is what you're trying to do, but it's worth noting that this is what you're trying to do. I'm not sure if this is what you're trying to do. If this is what you're trying to do, it's worth noting that this is what you're trying to do. I'm not sure if this is what you're trying to do, but it's worth noting that this is what you're trying to do.", "reference": "this `label=` is docker specific, while here in libcontainer there shouldn't be any mention to docker. `DisableSecOpt` and `DupSecOpt` should just deal with `disable,role,type,level`. Both CRI-O and docker should just pass `disable,role,type.level` stuff and not `label=...`." }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if this is the correct way to do it.", "reference": "You need to declare variable `recurse` above, same place as `localTime`." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Why does `clone` not already copy `xdensity` and `ydensity` from what it is cloning?" }, { "prediction": "I'm not sure if this is what you're looking for, but it's worth noting that this is what you're trying to do.", "reference": "Curious - do we do the same for traces (when no ActivitySource / legacy source are added)? (and why we want to do it for metrics?)" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "@aimanrosli23 For the changes in file SdMmcPciHci.c, please make sure that you do not revert the changes made by the below commits: SHA-1: 49accdedf956f175041040e677163b7cbb746283 * MdeModulePkg/SdMmcPciHcDxe: Hook SwitchClockFreq after SD clock start SHA-1: c67617f3c677c342efde780e229f841f4e0f6c7e * MdeModulePkg/SdMmcPciHcDxe: Add retries for sync commands SHA-1: 6d387610855ee27b49cb720de29ed809ea59dadc * MdeModulePkg/SdMmcPciHcDxe: Read response on command completion SHA-1: 63fd7f389874081ea37452b1f79ac013d52755e3 * MdeModulePkg/SdMmcPciHcDxe: Do not map memory for non DMA transfer" }, { "prediction": "I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "You'll also need to add `webelem.Group.all` everywhere as that matches as well" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Does this need to be an ERB template?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "do we want to register this in the mock server for testing?" }, { "prediction": "I think this is what you're trying to do. I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "shouldnt this be `0:996` (+4) so the 1000s below fit?" }, { "prediction": "I think this is what you are looking for, but it's not what you're looking for.", "reference": "The docstring of this context_manager should be updated. As now ``sort=False`` is valid, it should just say it disables sorting regardless of whether the NdMapping has ``sort=True`` or ``sort=False``. I also think the line 'Should only be used if values are guaranteed to be sorted before or after the operation is performed.' should just say something else - maybe just that the initial ordering (whatever it is) should be preserved?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "This tests failed unless I swapped the order here. Perhaps some new class transform broke the old form?" }, { "prediction": "@classmethod def get_java_opts(cls): opts = opts.replace('_debug_port_', ('%s' % cls.debug_java_port)) return opts @classmethod def get_free_tcp_port(cls): opts = opts.replace('_debug_port_', ('%s' % cls.debug_java_port)) return opts @classmethod def get_free_tcp_port(cls): opts = opts.replace('_debug_java_port_', ('%s' % cls.debug_java_port)) return opts @classmethod def get_free_tcp_port(cls): opts = opts.replace('_debug_java_port_', ('%s' % cls.debug_java_port)) return opts @classmethod def get_free_tcp_port(cls): opts = opts.replace('_debug_java_port_', ('%s' % cls.debug_java_port)) return opts @classmethod def get_free_tcp_port(cls): opts = opts.replace('_debug_java_port_', ('%s' % cls.debug_java_port) return opts.replace('", "reference": "extract the port and set to `debug_java_port`" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "When the argument list is `[\"one\", \"two three\"]` then you concatenate it as you do it here, you won't be able to get the original list back with split. You need to annotate the list items better. (Or if you won't do the split by yourself, the called shell will do it. So you need shell escaping. How portable is that?) The main driver to change this in `intercept-build` was to get rid of these concatenation and splitting errors. The current compilation database parser in Clang understands the `arguments` filed... So the question, why don't you pass the command around as a list instead of a string?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "`ctx` is unused in EnablePiped" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Why do we have both a list of valid sessions and an instance variable if a session is destroyed?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "nit : I think that it would be \"cleaner\" to set the `flushcount` to nil in case of an error nice catch ;-)" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "You may want to use assertNull" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure.", "reference": "Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Why did you remove this?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Why we need another error printouts? We already have it inside addMapping.." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "This LGTM, but I'm curious if this fixed a specific error you were hitting?" }, { "prediction": "I think this is a bug in your code. It should be fixed in this case.", "reference": "Actually we rely on this functionality in cgroup v2, where the subsystem is empty." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "suggestion: use `core` package name" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's possible that you're trying to do something like this.", "reference": "I think we can entirely remove this `limit` parameter for now to be consistent with other APIs." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to start a resource group from a different port. I'm guessing you're trying to start a resource group from a different port, so I'm guessing you're trying to start a resource group from a different port. I'm guessing you're trying to start a resource group from a different port, so I'm guessing you're trying to start a resource group from a different port.", "reference": "nit: `Resource Groups Tagging API` -> `Resource Groups API`" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "This type of list + delete always make me a bit uneasy but guess there's no atomic way to do this...... Could you put a todo to retry the \"ClearRepository + delete repo\" flow a few times? Basically, imagine a new image is added right after we call `ListImages`, then `DeleteImages` will not delete that newly added image. Then the delete repo call will fail" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do.", "reference": "You can remove this since ES6 modules are strict by default. And thanks for contributing to the Jellyfin Project." }, { "prediction": "@ -32,7 +32,7 @ @ public class TransactionRLPDecoderTest { private static final String FRONTIER_TX_RLP = \"0xf901fc8032830138808080b901ae60056013565b6101918061001d6000396000f35b3360008190555056006001600060e060020a6000350480630a874df61461003a57806341c0e1b514610058578063a02b161e14610066578063dbbdf0831461007757005b610045600435610149565b80600160a060020a031660005260206000f35b610060610161565b60006000f35b6100716004356100d4565b60006000f35b61008560043560243561008b565b60006000f35b600054600160a060020a031632600160a060020a031614156100ac576", "reference": "Why did eip1559 go from a list (0xf9020280.....) to a wrapped string (0xb902060ff9020280...) and not just concatenation (0x0ff9020280...)? implementation detail or is this how it sits on the wire now?" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed in the latest release.", "reference": "@wallyqs Since on Windows it would be `\\` instead of `/` I just look at the suffix past `configs/`. Let me know if that's ok or not." }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "nit: Remove this assignment because it is not necessary." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This seems like a common enough pattern to offer an equivalent wrapper in `ot-fs-util.c`, no?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Wouldn't this crash the app if the user is currently listening to a stream?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "This looks like an unrelated change? What is it for?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Wait, what is this doing? Is this a way to create methods that are only accessible from tests?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "Is it more reasonable to return some errors here, such as returning error codes (403 and so on?)?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Thinking out loud... would `_nextDom` be a better name for this?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Turns out the unittests also had a false positive." }, { "prediction": "I think this is a bug. It should be fixed in the latest version of OpenTelemetry.", "reference": "I think these method names would be clearer if written as \"Create a {type} counter|gauge|measure with given name\". eg \"Create a int64 counter with given name\" \"Create a double gauge with given name\"" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "it pushes a boolean, so it has to be explicitly casted to boolean with!= nullptr, same with all other similar stuff" }, { "prediction": "I'm not sure if this is the correct way to do this, but it's the correct way to do it. I'm not sure if this is the correct way to do it, but it's the correct way to do it.", "reference": "It would be nice to have an equivalent of this call on `DataWriterImpl::enable`" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Isn't this PENDING?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "minor detail, why aim to sanitize title if tile is empty (in some cases)? worth adding an && to check for that." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Code shared by ParentChildrenSyncDownTarget and ParentChildrenSyncUpTarget moved to ParentChildrenSyncTargetHelper" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "The bug is not about the priority, But we use 2 config items CAPACITY and SEQUENTIAL to control 1 action: thoughput. If'sequential' is given to 'False' as default in configfile and then I use 'capacity' to 10 in my test.yml, the 'capacity''s priority should be higher than default'sequential'. So, I suggest we use only one 'capacity', it is enough. '1' is sequential, more than 1 is capacity, None is sys.maxsize." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "I don't know if I'd call any of these FAST tests integration tests. They are unit tests for FAST. They use a mock plugin which doesn't actually start any external processes, etc." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Can you provide corresponding UT for this." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "nit: this should be below the yarpc group" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "singleCaseSwitch: should rewrite switch statement to if statement (from `gocritic`)" }, { "prediction": "I'm not sure if this is the case, but I think it's the case. I'm not sure if this is the case, but I'm not sure if it's the case.", "reference": "Please log once here at Error level \"Failed to connect to Typha, will retry...\"" }, { "prediction": "I'm not sure if this is a bug, but I think it should be fixed.", "reference": "Do we need the forXDP parameter in runBpfUnitTest? If not, I think better to revert in order to save a few changes." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "So we fix it only for kinto and not for all cliquet resources?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "No empty line between" }, { "prediction": "I'm not sure if it's a bug, but if it's a bug, it's a bug.", "reference": "We have `ResolveRootfs` in `libcontainer/utils` so maybe use that one here?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "Just curious, do we have positive test covered somewhere?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Style error, put a space between `if` and `(`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do this in a way that doesn't support the modeled host prefix pattern. I'm not sure what you're trying to do here, but I'm guessing you're trying to do this in a way that doesn't support the modeled host prefix pattern. I'm guessing you're trying to do this in a way that doesn't support the modeled host prefix pattern. I'm not sure what you're trying to do here, but I'm guessing you're trying to do this in a way that doesn't support the modeled host prefix pattern.", "reference": "It's a bit odd to have a \"disable\" boolean, though it looks like you already do that for a few other flags." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "Why did you pick two hours for this?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "What about \"enter new password\"? That would be a bit more consistent to the `ReadPasswordTwice` usage in cmd_init." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if it's what you're trying to do. I'm not sure if it's what you're trying to do.", "reference": "Another redundant import" }, { "prediction": "should we try to create a new stream? If we try to create a new stream, we will get an error. If we try to create a new stream, we will get an error. If we try to create a new stream, we will get an error. If we try to create a new stream, we will get an error. If we try to create a new stream, we will get an error.", "reference": "What kind of errors might cause us to reach this point? Could any of them be recoverable i.e. might work if we asked the same server again? Similar question for below, but perhaps with a slightly different answer" }, { "prediction": "I'm not sure this is a bug, but it's a bug, and it's a bug.", "reference": "What is the difference between GraphType and graph_type. Naming should be more accurate." }, { "prediction": "Doctrine\\ORM\\EntityRepository is deprecated. Doctrine\\ORM\\EntityRepository is deprecated. Doctrine\\ORM\\EntityRepository is deprecated. Doctrine\\ORM\\EntityRepository is deprecated. Doctrine\\ORM\\EntityRepository is deprecated. Doctrine\\ORM\\EntityRepository is deprecated. Doctrine\\ORM\\EntityRepository is deprecated. Doctrine\\ORM\\EntityRepository is deprecated. Doctrine\\ORM\\EntityRepository is deprecated. Doctrine\\ORM\\EntityRepository is deprecated. Doctrine\\ORM\\EntityRepository is deprecated. Doctrine\\ORM\\EntityRepository is deprecated. Doctrine\\ORM\\EntityRepository is deprecated. Doctrine\\ORM\\EntityRepository is deprecated. Doctrine\\ORM\\EntityRepository is deprecated. Doctrine\\ORM\\EntityRepository is deprecated. Doctrine\\ORM\\EntityRepository is deprecated. Doctrine\\ORM\\EntityRepository is deprecated. Doctrine\\ORM\\EntityRepository is deprecated. Doctrine\\ORM\\EntityRepository is deprecated. Doctrine\\ORM\\EntityRepository is deprecated. Doctrine\\ORM\\EntityRepository is deprecated. Doctrine\\ORM\\EntityRepository is deprecated. Doctr", "reference": "hmmm in docblock of contructor it is EntityManagerInterface....maybe it should be that way.... :confused:" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I'm curious why you went the route of adding a new method name for this. Given that you it would be possible to just have an an overload of `GetPos()`, and that this change breaks existing code, I wonder why you chose to go this way." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Does this need to change `'active'` to `'Active'` and that? Or is that done in CSS or something?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Why are these constants public? They should also be listed above members." }, { "prediction": "I think this is a bug. We have to fix it. We have to fix it. We have to fix it. We have to fix it.", "reference": "This TODO isn't related to this change. We should remove it." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "`FieldMetrics` is parameterized, but this is a bare reference. Could you update it? I think it should be `FieldMetrics` since the metrics are not necessarily for the written value type, `D`." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm guessing it's what you're trying to do. I'm not sure if this is what you're trying to do, but I'm guessing it's what you're trying to do. I'm not sure if this is what you're trying to do, but I'm guessing it's what you're trying to do.", "reference": "@cijothomas do we want this to be `Set` or `Add`?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "Why are we dropping GasCap?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "should we end the text with a.?" }, { "prediction": "I don't think it's a bug, but it's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug.", "reference": "Could this instead keep the `go_native` and add to it \"or the last exit was the special reset exit\"?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Oh, I missed this one: The other instances of `this` you've added as lambda contexts aren't really needed, although they're harmless. However, in the above connection, the missing context is `panel`, not `this`. Please correct it! Clazy may show warnings about lambda contexts (I don't use Clazy) but, if so, that's a problem in clazy: it isn't smart enough to know about them." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "can we add a try / except around this to make it more stable? I like the idea of any mistakenly un-quit drivers closing down after the process is quit (the java server does this... also i forget to do driver.quit often when i use the command line repl :) )" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "when would this happen? backward compatibility?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to get the tagName of an element that is not a HTMLElement. I'm not sure what you're trying to do here, but I'm guessing you're trying to get the tagName of an element that isn't a HTMLElement. I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "I'm not sure what the value of this is. So far we've solved this by always doing `tagName.toUpperCase()` for everything. I think we should stick with this." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should work.", "reference": "This command displays available snapshots on a volume." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "`spb` is the standard package name we use for this proto." }, { "prediction": "I'm not sure if this is the case, but I think this is what you're looking for.", "reference": "/javascript/firefox-driver is the Selenium implementation of a WebDriver for Firefox. Since it generally isn't W3C compatible, it shouldn't change. We can just drop this change." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "is this pr support parallelly process application?" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "Based on the assumption that when `EnablePulls` is `true`, `CanEnablePulls` must be `true` as well, then this `if` check is redundant. Actually... we have `AllowsPulls` now... why not use that?" }, { "prediction": "I'm not sure if this is the correct way to do it, but if it is the correct way to do it, then it's probably the correct way to do it. I'm not sure if this is the correct way to do it, but I'm not sure if it's the correct way to do it, so I'm not sure if it's the correct way to do it, but I'm not sure if it's the correct way to do it.", "reference": "I am not sure why the API requires both project name and project ID as inputs. Wouldn't it introduce more opportunities for clients to make mistakes?" }, { "prediction": "I think this is a bug, but it should be fixed in the latest release.", "reference": "I believe this was happening for several different flash messages - should we add `now` to all flash messages? (there might be a downside to doing that, but I am not sure what it would be)" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "There is no docblock on the parent method. Also, not related, but I forgot to typehint the `$templating` constructor argument above." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Silly me. This shouldn't be done in the tests, but instead in the actual definition of ValidPHPVersions on arm64. Same with Mysql and MariaDB." }, { "prediction": "@ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @", "reference": "Shouldn't this work as well for Disjoint?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, we'll report a bug.", "reference": "You've not updated the `o.Status.Reason = fmt.Sprintf(\"Failed to retrieve Order resource: %v\", err)` line below here when you changed this, so here we are checking `errUpdate` but will print the contents of `err` instead." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to connect to a socket that doesn't exist. I'm guessing you're trying to connect to a socket that doesn't exist, so I'm guessing you're trying to connect to a socket that doesn't exist.", "reference": "Doesn't this need to include `Errno::ECONNRESET` to fix the issue?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Please consider keeping the config key in one line as it will help in case someone is looking at how this config is used. public static final String PROJECT_CACHE_THROTTLE_PERCENTAGE = \"azkaban.project_cache_throttle_percentage\";" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "This is a hard one, naming-wise... `ListPowerSelectorEntries` is logical given `ListSelectorEntries`. Another option could be `ListMatchingEntries` or even `FindMatchingEntries`. :shrug:" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "This should be called `Uint` or `Uint32` or simply using our `Uint64` type instead. All of our numbers have varint encoding. It's not inherently a varint." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "No need for this when you don't need to customize anything about the argument." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're going to need to do something like this:", "reference": "We're now going to have 3 `#sections_accordion` will need to see how JS behaves. We should probably switch to a class selector instead" }, { "prediction": "I think this is what you're looking for.", "reference": "did you mean to leave this in here?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I think I'm correct.", "reference": "Mention that it only applies to Windows. This is kind of implied, but better to be explicit." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "again: it is a bad practice to have some global parameters with such common names for unit test purpose." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Should we use `\\DateTimeInterface` or `DateTimeInterface` and declaration of `DateTimeInterface` in `use`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "What do you think of moving this stack related constant to the `stack` pkg?" }, { "prediction": "I'm not sure if this is a bug, but I think it should be fixed in the future.", "reference": "Hm, I guess that you're doing this here since `WellFormed` is on a `transactions.Transaction` and not a `transactions.SignedTxn`, but quickly grepping through our code, it looks like we always a `SignedTxn` around when calling `WellFormed` (except maybe some tests?)... this doesn't have to happen here, but maybe we should update that in a separate PR since this really feels like a `WellFormed` check." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this: ( ); ( ); ( ); ( ); ( ); ( ); ( ); ( ); ( ); ( const ( Kill Action = iota Errno Trap Allow Trace )

    "
        },
        {
          "prediction": "I think this is a bug in NLog.Internal.FileAppenders. I'm not sure if it's a bug, but it's a bug in NLog.Internal.FileAppenders.",
          "reference": "lock(this) is a bad practise, since you lock the entire instance. cosider: var appenderCache = xxxx. lock(appenderCache) { Thread.Sleep(TimeSpan.FromHours(5)); } while inside AppenderCache instance lock(this) { is blocked 5 hours. } Its always better to make a class private lock objects."
        },
        {
          "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.",
          "reference": "should we use the constant above?"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.",
          "reference": "I think something like `size_res` would be more descriptive."
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:",
          "reference": "Oh lol so this was...really more of a bug?"
        },
        {
          "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if it's what you're trying to do.",
          "reference": "Well, it is providing a platform neutral way of calling Task or TaskEx. We could just call it PlatformTask."
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:",
          "reference": "Typo: this should free `xwayland` instead"
        },
        {
          "prediction": "I'm not sure if this is a bug, but it seems to be a bug.",
          "reference": "Is it ok to use \"math/rand\" instead of \"crypto/rand\" here? Do we need to protect this ID somehow?"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.",
          "reference": "Why did we have `logxi` in the first place? Maybe it makes sense to remove it from `glide.lock? It will safe us in the future from using logger which is not working."
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.",
          "reference": "Is there a reason to use `getUNF()` and `UNF` in the same block?"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.",
          "reference": "Again this seems odd that megacheck cares"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:",
          "reference": "I assume this will resolve to nil if this isn't in the config?"
        },
        {
          "prediction": "I think this is what you're looking for. I'm not sure if this is what you're looking for, but it's what you're looking for.",
          "reference": "I looks like we can make `allowOptionalMappings` non-optional since we have another overload without it. (I thought this generated a compiler warning, but maybe it's just R#)"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.",
          "reference": "` per scale.` -> ` per scale.` need to clean the unnecessary blank space"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.",
          "reference": "there's no import for Export"
        },
        {
          "prediction": "I'm not sure if this is a bug, but I think it should be fixed.",
          "reference": "i don't think we want/need to make the node API available over UDS"
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this:",
          "reference": "How about to skip if and returning null and return a result of `ArticleFacade::findById` directly?"
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but it's worth noting that we're using `Array.prototype.map` instead of `Array.prototype.map.apply(this,arguments)`, so we don't need to use `Array.prototype.map.apply(this,arguments)`",
          "reference": "I think this change is currently unnecessary. I like the idea of `map()`, `filter()`, etc. returning vanilla JavaScript arrays rather than mongoose arrays, but I think that's a bit too heavy of a change for a patch release. I think that all we need for this release is the `if (!parent || parent.$__.populated == null) return;` change."
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.",
          "reference": "how about \"unknown\" instead of \"fafafaf\"?"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.",
          "reference": "nit: do we gain anything from naming the output error `err` in this definition?"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:",
          "reference": "This can happen with any dialog. Maybe the best place to add this change would be the dialog component instead."
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this. I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this. I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.",
          "reference": "Should this be `TearDown` since it now calls this method? Something I would like to see is, on test failure don't teardown completely instead leave the FAST repo in place with the stderr and stdout files and direct the user to that location. What do you think?"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but if you're trying to do something like this, you might want to use a different metric type. If you're trying to do something like this, you'll want to use a different metric type. If you're trying to do something like this, you'll want to use a different metric type.",
          "reference": "There's not particular reason to use a short name. Can we use a more descriptive name for the metric? Perhaps \"negativeLogLikelihood\"?"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm guessing that you're trying to read a token that doesn't have a `` `` `` `` `` `` `` `` `` `` `` `` `` ``` ``` ```` ````` `````` ```````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````",
          "reference": "not handling in case of `repr` makes the behavior probably a little too unpredictable. Is there a reason not to, apart missing stuff in the `repr`? Does it lead to some problem?"
        },
        {
          "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but it's a bug.",
          "reference": "Remove the finally?"
        },
        {
          "prediction": "I'm not sure if this is the case, but I think it's the case.",
          "reference": "Build on AArch64 fails because WCHAR is not defined."
        },
        {
          "prediction": "I'm not sure if it's a bug, but it's a bug.",
          "reference": "Do we use this const?"
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.",
          "reference": "I think this may need to be `SetCertificateRequestAnnotations` as it returns a `CertificateRequestModifier`"
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:",
          "reference": "it would likely be better to do this in the Identifier.by_scheme_name method itself."
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.",
          "reference": "@janette looking at this test code, I'm pretty sure that it's going to give a false positive. Where is it actually checking the contents of the first four datasets against expected values? All the assertion at the end of the test seems to check is that at least four datasets exist."
        },
        {
          "prediction": "I'm not sure if this will work, but it should work.",
          "reference": "Would this break things if Ghost is run in a subdirectory or no?"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:",
          "reference": "maybe switch the order in order to make this a positive assertion instead of a negative one? i.e. `if key =~ /id/` first."
        },
        {
          "prediction": "Canned \"Expected Conditions\" which are generally useful within selenium.common.exceptions import NoSuchFrameException from selenium.common.exceptions import WebDriverException from selenium.common.exceptions import NoSuchAlertPresentException from selenium.common.exceptions import WebDriverException from selenium.common.exceptions import NoSuchAlertPresentException from selenium.common.exceptions import WebDriverException from selenium.common.exceptions import WebDriverException from selenium.common.exceptions import NoSuchAlertPresentException from selenium.common.exceptions import WebDriverException from selenium.common.exceptions import WebDriverException from selenium.common.exceptions import WebDriverException from selenium.common.exceptions import WebDriverException from selenium.common.exceptions import WebDriverException from selenium.common.exceptions import WebDriverException from selenium.common.exceptions import WebDriverException from selenium.common.exceptions import WebDriverException from selenium.common.exceptions import WebDriverException from selenium.common.exceptions import WebDriverException from selenium.common.exceptions import WebDriverException from selenium.common.exceptions import WebDriverException from selenium.common.exceptions import WebDriverException from selenium.common.exceptions import WebDriverException from selenium.common.exceptions import WebDriverException from selenium.common.exceptions import WebDriverException from selenium.common.exceptions import WebDriverException from selenium.common.exceptions import WebDriverException from selenium.",
          "reference": "Is this an oversight for some code in the body?"
        },
        {
          "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.",
          "reference": "Reason for adding this? I couldn't find where you are retrieving it back."
        },
        {
          "prediction": "h2o_mruby_to_str(mrb_state *mrb, mrb_value v) { return `h2o_mruby_to_str(mrb_state *mrb, mrb_value v)`; } h2o_mruby_to_str(mrb_state *mrb, mrb_value v) { return `h2o_mruby_to_str(mrb_state *mrb, mrb_value v)`; } h2o_mruby_to_str(mrb_state *mrb, mrb_value v) { return `h2o_mruby_to_str(mrb_state *mrb, mrb_value v)`; } h2o_mruby_to_str(mrb_state *mrb, mrb_value v) { return `h2o_mruby_to_str(mrb_state *mrb, `h2o_mruby_to_str(mrb_state *mrb, `h2o_mruby_to_str(mrb_state *mrb, `h2",
          "reference": "Can we expect adequate information emitted to the log in case either requiring preloads.rb or doing the requires in preloads.rb fails? If the answer is yes, I think we can merge this PR right away."
        },
        {
          "prediction": "@ -1,2 +1,3 @@ -class PagesController < ApplicationController -end +class PagesController < HighVoltage::PagesController + layout false +end",
          "reference": "How about a `app/views/layouts/pages.html.erb` layout that contains the HTML head, body, wrappers and yield's the `new-topics` template into it? I think we might be able to delete the `app/controllers/pages_controller.rb` file at that point."
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.",
          "reference": "This is a coarse solution. This check is helpful, but you should also add a check in `$__version()` to avoid calling `isSelected()` if `key === false`"
        },
        {
          "prediction": "I'm not sure if it's a bug, but it's a bug.",
          "reference": "Passing only needed data to make it can be reused by `planpreview` package where there is no deployment data."
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.",
          "reference": "Could we rename those to `CustomClientAuthentication` (same for Router) to remove ambiguity between Authentication and Authorization (permissions)?"
        },
        {
          "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.",
          "reference": "Is the name \"IMvxFormsViewPresenter\" too close to \"IMvxFormsPagePresenter\"? Perhaps something like \"IMvxFormsNativeViewPresenter\" or \"IMvxFormsPlatformViewPresenter\" or inline with Forms naming \"IMvxFormsOnPlatformViewPresenter\""
        },
        {
          "prediction": "I'm not sure if this is the correct way to do it, but it's the correct way to do it.",
          "reference": "`typeof child!= 'boolean'` maybe?"
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.",
          "reference": "Why && changed to ||?"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this.",
          "reference": "nit: not a big deal right now but spec assigns ID 0 to InitAddress"
        },
        {
          "prediction": "I'm not sure if this is the case, but I think this is what you're looking for.",
          "reference": "/javascript/firefox-driver is the Selenium implementation of a WebDriver for Firefox. Since it generally isn't W3C compatible, it shouldn't change. We can just drop this change."
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.",
          "reference": "There are various places where `setZoomFactor` is used but `fuzzyval` isn't set: - `__init__` and `on_config_changed` (should be okay as `init_neighborlist` gets called which essentially does the same) - `zoom` (calls `zoom_perc` with `fuzzyval=False`), which is used by `:zoom-in` and `:zoom-out`. Are you sure this won't break those calls? (Yes, I know there should be tests for this - I'm working on that.) Other existing places probably should get simplified."
        },
        {
          "prediction": "I'm not sure if this is a bug, but it's a bug, but it's a bug.",
          "reference": "Is there a benefit to keeping this in RefinementSettings? Or could we move it into its own class in TestUtil?"
        },
        {
          "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `",
          "reference": "I would have expected the Ready method to need to change to be a `<-chan Result` instead of a `<-chan map[string]Result`. The difference being that now the Ready channel can produce more than one set of results. In fact the name Ready is inaccurate now since its not about the query being ready but just a mechanism to deliver results. If this should be a follow up PR that is fine, lets create an issue for it."
        },
        {
          "prediction": "I'm not sure if this is the case, but I think it's the case.",
          "reference": "why? what if we want to access those methods outside of azkaban-common?"
        },
        {
          "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm sure it's a bug.",
          "reference": "Rename file too"
        },
        {
          "prediction": "I'm not sure if this is what you're trying to do, but if it's the case, then it's probably a bug in the code you're using.",
          "reference": "Need to populate the `RequestID` field for these errors. This can be obtained from r.RequestID i think, but need to make sure. The `r.RequestID` should of been populated from the `UnmarshalMeta` handler list."
        },
        {
          "prediction": "I'm not sure if this is the expected behavior, but I'm not sure if this is the expected behavior, but I'm not sure if this is the expected behavior, so I'm not sure if this is the expected behavior, so I'm not sure if this is the expected behavior.",
          "reference": "Why is the `final` being removed here?"
        },
        {
          "prediction": "I'm not sure if this is a bug, but it's a bug, and it's fixed in the future.",
          "reference": "Maybe let's take this opportunity to change easylogging to a git submodule?"
        },
        {
          "prediction": "I'm not sure if it's a bug, but it's a bug.",
          "reference": "Should we just be generous and elide all extra whitespace? `strings.TrimSpace`"
        },
        {
          "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.",
          "reference": "This is an inaccurate API that has outlived it's purpose. We can't make the determination of phone (vs) tablet, with a 7\" screen in the mix. Also, with the advent of fragments, this API means very little now. It's not being used anywhere, since we switched to `ActionBar`."
        },
        {
          "prediction": "I'm not sure if this is a bug, but it seems to be a bug.",
          "reference": "This change means that users can't easily see which version of the selenium server they're using. This is `info` level information."
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.",
          "reference": "You should just use `with patch(...):`, so it unpatches it automatically. Also, much simpler."
        },
        {
          "prediction": "public IMvxViewDispatcher ViewDispatcher { if (_viewDispatcher == null) _viewDispatcher = Mvx.Resolve(); return _viewDispatcher; } public IMvxViewDispatcher ViewDispatcher { get => _viewDispatcher?? (IMvxViewDispatcher)MvxMainThreadDispatcher.Instance; + get => _viewDispatcher?? (_viewDispatcher = Mvx.Resolve()); set => _viewDispatcher = value; } private IMvxViewsContainer _viewsContainer; protected IMvxViewsContainer ViewsContainer { get { + get { if (_viewsContainer == null) _viewsContainer = Mvx.Resolve(); return _viewsContainer; } } }",
          "reference": "This didn't use to work for me. Are you sure that returns the correct instance from startup?"
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.",
          "reference": "Looks good. Eventually we could remove some of these constructors, but for now adding these two seems the way to go"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:",
          "reference": "@jalavik should be have somewhere enum/list/registry of possible tags?"
        },
        {
          "prediction": "I think this is a bug in CSCC. It's a bug in CSCC. It's a bug in CSCC. It's a bug in CSCC.",
          "reference": "why is this pylint disable needed?"
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for a \"git clone {src_path}.git\". I'm guessing you're looking for a \"git clone {src_path}.git\".format(src_path = src_path) or a \"git clone {src_path}.git\".format(src_path = src_path) or a \"git clone {src_path}.git\".format(src_path = src_path) or a \"git clone {src_path}.git\".format(src_path = src_path) or \"git clone {src_path}.git\".format(src_path = src_path) or \"git clone {src_path}.git\".format(src_path = src_path) or \"git clone {src_path}.git\".format(src_path = src_path) or \"git clone {src_path}.git\".format(src_path = src_path) or \"git clone {src_path}.git\".format(src_path = src_path) or \"git clone {src_path}.git\".format(src_path = src_",
          "reference": "The new sync feature is only being supported from within Terraform. Installations using the deprecated method will have this feature disabled."
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:",
          "reference": "This type of return (f'xxx') is not recommended, it is recommended to return 'xxx'"
        },
        {
          "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug.",
          "reference": "I would make this level 1 or 2."
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.",
          "reference": "Is that path in a variable anyway? Not a big fan of hard coding it here."
        },
        {
          "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.",
          "reference": "nit: Move `IdentityTemplateLabel` to be under `IdentityTemplate` to match the struct in config_crd.go"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.",
          "reference": "Not necessarily related to this PR, but don't you think having a centralized place for all interactions with analytics might make this into a very big class? Is that something that you don't worry about until it happens?"
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.",
          "reference": "it seems that my terminal is dead when I press ctrl+c during running daisy cli today, is this PR fixing that?"
        },
        {
          "prediction": "I'm not sure if this is the case, but I think it's the case.",
          "reference": "If we are going to add config to specify the maximum message pool size, we should probably also add a parameter for the maximum nonce gap and pass it into the `IngestionValidator`. This could be done in this PR or added as an issue."
        },
        {
          "prediction": "I'm not sure if this is what you're trying to do, but it seems to be something you're trying to do. I'm not sure if this is what you're trying to do, but it seems to be something you're trying to do.",
          "reference": "please inline imports"
        },
        {
          "prediction": "IptablesRefreshInterval time.Duration `config:\"seconds;30\"` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `` `` `` `` `` `` ````````````````````````````````````````````",
          "reference": "Should IptablesPostWriteCheckIntervalSecs be set back to its previous smaller value, if use of the iptables lock is disabled?"
        },
        {
          "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case, but I'm not sure if it's the case.",
          "reference": "Please use packageInfo here instead. As it is used in `app.js`."
        },
        {
          "prediction": "I'm not sure if this is the case, but maybe it's the case? If it's the case, it's the case, it's the case that it's the case.",
          "reference": "this seems unrelated to the rest of the PR, although related to the original report"
        },
        {
          "prediction": "I'm not sure if this is a bug, but it should be fixed.",
          "reference": "Would a check for added columns with non-null default be sufficient for aligned format?"
        },
        {
          "prediction": "This flag should be used if auto-generated or build ID provided by Cloud Build is not appropriate. For example, if running multiple imports in parallel in a single Cloud Build run, sharing build ID could cause premature temporary resource clean-up resulting in import failures. This flag should be used if auto-generated or build ID provided by Cloud Build is not appropriate. This flag should be used if auto-generated or build ID provided by Cloud Build is not appropriate. This flag should be used if auto-generated or build ID provided by Cloud Build is not appropriate. For example, if running multiple imports in parallel in a single Cloud Build run, sharing build ID could cause premature temporary resource clean-up resulting in import failures. This flag should be used if auto-generated or build ID provided by Cloud Build is not appropriate.",
          "reference": "Is this PR implementing compute service account for OVF import as well? I thought it's only image/one-step import? Btw, OVF importer uses \"-\" instead of \"_\" in flags (should be `compute-service-account`)."
        },
        {
          "prediction": "@Route(name=\"ergonode_product_collection_element_delete\", * methods={\"DELETE\"}, * requirements={ * \"collection\"=\"[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}\", * requirements={ * \"element\"=\"[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}\", * requirements={ * \"element\"=\"[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}\", * requirements={ * \"element\"=\"[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}\", * requirements={ * \"element\"=\"[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}\", * requirements={ * \"element\"=\"[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f",
          "reference": "Why change to element?? in whole application use plural convention??"
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but it's what you're looking for.",
          "reference": "Tiniest nit but this can be `tabindex={-1}`, `width={11}`, `height={11}`"
        },
        {
          "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case, but I think it's the case.",
          "reference": "Unrelated to this PR, we should remove this exception. We now require `numpy`."
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.",
          "reference": "Is the loop over vars and adding them to the subworkflow below in this file needed, since it's already done by NewSubWorkflowFromFile?"
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:",
          "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping."
        },
        {
          "prediction": "@import dagster.pandas_kernel as dagster_pd + +def simple_csv_input(name): + return dagster_pd.dataframe_input(name, sources=[dagster_pd.csv_dataframe_source()])",
          "reference": "Having to write this util makes me think that maybe we should have kept the csv_input stuff. I don't know."
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:",
          "reference": "Passing in and saving a reference to the `BlockCache` at init time is going to break if something calls `config.ResetCaches()`, because it replaces the `BlockCache` instance completely. This happens on user logout or by a manual write to `.kbfs_reset_caches`. So you probably want to give it the whole `config`, or maybe just the `config.BlockCache` function pointer."
        },
        {
          "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.",
          "reference": "I am not sure this could happen. st should be nil if the error happens. If it does happen, we could also do st.Reset(), since it is an erroureous state so it closes both sides of the stream."
        },
        {
          "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.",
          "reference": "I'm guessing this was just added for debugging? Should probably remove it so we aren't modifying 3rd party libs."
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:",
          "reference": "This seems reversed... if `success?` is true, wouldn't we use `success`?"
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:",
          "reference": "This seemed like the easiest way to allow log level checks, it will require an update to the vendors tool, to ignore that file on update."
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:",
          "reference": "Should we disallow entry authors to unsubscribe to their entries?"
        },
        {
          "prediction": "This file is part of the GNU General Public License. #Copyright (C) 2006-2016 NV Access Limited, Aleksey Sadovoy, Christopher Toth, Joseph Lee, Peter V\u00e1gner #Copyright (C) 2006-2016 NV Access Limited, Aleksey Sadovoy, Christopher Toth, Joseph Lee, Peter V\u00e1gner, Derek Riemer #This file is covered by the GNU General Public License. #Copyright (C) 2006-2016 NV Access Limited, Aleksey Sadovoy, Christopher Toth, Joseph Lee, Peter V\u00e1gner, Derek Riemer #This file is covered by the GNU General Public License. #Copyright (C) 2006-2016 NV Access Limited, Aleksey Sadovoy, Christopher Toth, Joseph Lee, Peter V\u00e1gner, Derek Riemer #This file is covered by the GNU General Public License. #Copyright (C) 2006-2016 NV Access Limited, Ale",
          "reference": "2016 should be 2017."
        },
        {
          "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.",
          "reference": "boolean exists = (existSchema!= null) && (existSchema.getSummary()!= null);"
        },
        {
          "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.",
          "reference": "It does not look idiomatic."
        },
        {
          "prediction": "We need to import the builtins for the tests to work. \"github.com/influxdata/flux/dependencies/dependenciestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestestest",
          "reference": "Generally, we do not use newlines between project imports, we only separate them from the stdlib imports"
        },
        {
          "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.",
          "reference": "can this long line be wrapped?"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.",
          "reference": "I'd use the same message that I suggested in the release changelog."
        },
        {
          "prediction": "This schema type's name, to defend against minifiers that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that mangle that m",
          "reference": "Keep semi-colons at end of function defs please"
        },
        {
          "prediction": "I'm not sure this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.",
          "reference": "A little skeptical of `explain` being here. Why is this now a property of all commands?"
        },
        {
          "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm correct, or if I'm correct, or if I'm correct, I'm wrong.",
          "reference": "License copied two times!!"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:",
          "reference": "... their **superclass**"
        },
        {
          "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.",
          "reference": "I'm not sure if this is the right thing to be doing here. It seems like there should be a more systemic fix instead of this patch."
        },
        {
          "prediction": "I'm not sure if this is what you're looking for.",
          "reference": "Not sure why these are up here can we move these down to be part of the `@return` tag instead? This is what we usually do (e.g. `getCurrentEntityURL`)"
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I think it's a good idea to use Hash.new instead of Hash.new to avoid # unintentionally erasing values provided by other extensions. I'm not sure what you're trying to do here, but I think it's a good idea to use Hash.new instead of Hash.new to avoid # unintentionally erasing values provided by other extensions. I'm not sure what you're trying to do here, but I think it's a good idea to use Hash.new instead of Hash.new to avoid # unintentionally erasing values provided by other extensions. I'm not sure what you're trying to do here, but it's a good idea to use Hash.new instead of Hash.new.",
          "reference": "Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning."
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.",
          "reference": "We keep who wrote the code anonymous."
        },
        {
          "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.",
          "reference": "Mention something in logs, that fake registration was used e.g. `Fake identity registered`"
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.",
          "reference": "I think it would make sense to also set `internalWebPropertyID` to `''` here. Otherwise, it might keep its previous value (let's say a property was selected before, but then the user chooses \"Create new property\"), but since it always should depend on `propertyID`, that would be incorrect."
        },
        {
          "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.",
          "reference": "It might be reasonable to add a check that sanitization still fails here."
        },
        {
          "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.",
          "reference": "Why not use attemptNo instead of another call to getAttempt? Even better, consider using a private method to calculate this string. This logic is in two places."
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.",
          "reference": "Yuck. Rails bug."
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:",
          "reference": "It's useally a common practice to not use `l` as a variable (we have disabled this test in scapy because our code has tons, but it would have PEP8 failed otherwise), but it would be better not to create any. In general, single letter variables are not liked that much. Especially with windows where the fonts make 1=l How about `lay`?"
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.",
          "reference": "DRY these 5 lines into a function call, no?"
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.",
          "reference": "should we be trying to close here? or just return directly @fabxc? same goes for `stopc`..."
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.",
          "reference": "just re-ordered for clarity"
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but if it's the case, it's probably the case.",
          "reference": "Can you fix this also to print what is the IP address used to connect. Rename --> \"M_API server\" to maya apiservice"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.",
          "reference": "This fails on Go 1.11 because `indexByte` is already defined in strings_go111.go. I would suggest simply renaming one of the two, for example you could rename the other one to `strings_indexByte` (that will be one of the things we'll drop when we drop Go 1.11 support so it's better to make that one look ugly instead of the function that we will likely keep for a longer time)."
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.",
          "reference": "Now `dbType=' MockDbType.int32 '` is correctly interpreted and the value is rendered as an integer instead of a string; hence no more double quotes."
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.",
          "reference": "typo in `$contend`"
        },
        {
          "prediction": "I'm not sure if it's a bug, but it's a bug.",
          "reference": "Nit: empty line"
        },
        {
          "prediction": "I'm not sure if this is a bug, but it's a bug.",
          "reference": "I figured this was more fool-proof than trying to plumb the error up from everywhere."
        },
        {
          "prediction": "This is a scratch buffer used for processMsg() // This is a scratch buffer used for processMsg() // This is a scratch buffer used for processMsg() // This is a scratch buffer used for processMsg() // This is a scratch buffer used for processMsg() // This is a scratch buffer used for processMsg() // This is a scratch buffer used for processMsg() // This is a scratch buffer used for processMsg() // This is a scratch buffer used for processMsg() // This is a scratch buffer used for processMsg() // This is a scratch buffer used for processMsg() // This is a scratch buffer used for processMsg() // This is a scratch buffer used for processMsg() // This is a scratch buffer used for processMsg() // This is a scratch buffer used for processMsg() // This is a scratch buffer used for processMsg() // This is a scratch buffer used for processMsg() // This is a scratch buffer used for processMsg() // This is a scratch buffer used for processMsg() // This is a scratch buffer used for processMsg() // This is a scratch buffer used for processMsg() // This is a scratch buffer used for processMsg() // This is a scratch buffer used for processMsg() // This is",
          "reference": "We know debug and trace as globals exist and are defaulted to 0. In this instance we need to know that c is non- nil, srv is non-nil and logging is non-nil before we can trust this statement not to panic."
        },
        {
          "prediction": "I'm not sure if it's a bug, but it's a bug.",
          "reference": "Good removal here for two reasons: we're redeclaring `app.ConfigPath` immediately below without having used the initial value, and `app.GetConfigPath()` will build the value using the same process as in this line anyway."
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.",
          "reference": "Should BuildBase be removed?"
        },
        {
          "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug.",
          "reference": "this was a bad Goland auto-import that I missed in the previous PR. Thanks to @rkowalick and @acruikshank for catching it"
        },
        {
          "prediction": "I'm not sure if it's a bug, but if it's a bug, it's a bug.",
          "reference": "Good catch here. Reading the code, it actually seems kind of dumb that `replaceAtom` needs to copy the atom it's passed. Ah well, we're more or less stuck with that."
        },
        {
          "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but it's a bug.",
          "reference": "What's the reason for adding the output pointer here? I'd expect it to be derivable from the actual handler that's called."
        },
        {
          "prediction": "@@ -82,6 +82,10 @@ class Plan < ActiveRecord::Base annual_plan.price end + def annualized_savings + annualized_payment - discounted_annual_payment + end + def annual_plan_sku annual_plan.sku end",
          "reference": "I don't see tests for this (or the similar method on `Team`)."
        },
        {
          "prediction": "@ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @",
          "reference": "should use Number instead of Long"
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.",
          "reference": "We had the checks for those two errors for a reason, why do we not need them anymore?"
        },
        {
          "prediction": "I think this is a bug in rdkit.Chem.PeriodicTable import numTable from rdkit.Chem import Crippen from rdkit.Chem import rdPartialCharges, rdMolDescriptors +from rdkit.six.moves import xrange import numpy import bisect radCol = 5",
          "reference": "Why didn't you just switch to `range` here too?"
        },
        {
          "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.",
          "reference": "I don't even think `nil` should be allowed, since it uses global state to get the client."
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.",
          "reference": "You somehow got a change from `master` into your branch again, in e6d2167085688264e5ee6a81cfd2a7a8f10ded13. While it's not something terribly bad (as it will be fine after merging), it's kind of confusing, and I have no idea how it happens :laughing: Are you trying to update changes from `master` while working on your branch somehow? How do you do that?"
        },
        {
          "prediction": "This is similar to the below, except we might do a scratch delta first. If the current ref is different from the target, then this is similar to the below, except we *might* use the previous commit, or we might do a scratch delta first. If the current ref is different from the target, then this is similar + * to the below, except we *might* use the previous commit, or we might do + * a scratch delta first. */ - initiate_delta_request (pull_data, delta_from_revision?: NULL, to_revision, ref); + if (!(delta_from_revision && g_str_equal (delta_from_revision, to_revision))) + queue_scan_one_metadata_object (pull_data, to_revision, OSTREE_OBJECT_TYPE_COMMIT, NULL, 0, ref); + if (!(delta_from_revision && g_str_equal (delta_from_revision, to_revision))) + queue_scan_one_metadata_object (pull_data, to_revision, OSTREE_OBJECT_TYPE_COMMIT, NULL, 0, ref); + if (!(delta_from_revision && g_",
          "reference": "Minor, can we drop the leading `!` and just swap the if and the else blocks?"
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for.",
          "reference": "`bbox_feats.shape[0] > 0` requires the number of proposal is not 0."
        },
        {
          "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm not sure.",
          "reference": "Just FYI, I had to remove this unused import because Travis/`npm run lint` were complaining."
        },
        {
          "prediction": "I'm not sure if this is a bug or a bug, but it's a bug in LAMMPS_NS.h. If it's a bug, it should be fixed in LAMMPS_NS.h. If it's a bug, it should be fixed in LAMMPS_NS.h. If it's a bug, it should be fixed in LAMMPS_NS.h. If it's a bug, it should be fixed in LAMMPS_NS.h. If it's a bug, it should be fixed in LAMMPS_NS.h, it should be fixed in LAMMPS_NS.h. If it's a bug, it should be fixed in LAMMPS_NS.h, it should be fixed in LAMMPS_NS.h. If it's a bug, it should be fixed in LAMMPS_NS.h, it should be fixed in LAMMPS_NS.h.",
          "reference": "format.h is not a system header but bundled with LAMMPS. This should be `#include \"fmt/format.h\"`"
        },
        {
          "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.",
          "reference": "could we always call visitDocValuesWithCardinality? It seems to include the version check already?"
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.",
          "reference": "I think if they _don't_ specify a port, we should assume grid default (which is 4444)"
        },
        {
          "prediction": "I don't think it's a bug, but I think it's a bug, and it's a bug.",
          "reference": "This looks to be a breaking change. I know it will affect some of my code that uses the Tautomer enumerator."
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:",
          "reference": "Perhaps remove this line"
        },
        {
          "prediction": "I'm not sure if this is a bug, but I think it's a bug.",
          "reference": "Ah, missed this one. Sorry: you don't need to test the atomic number here. that's taken care of above on line 683."
        },
        {
          "prediction": "I'm not sure if this is the case, but if it is the case, it might be a bug.",
          "reference": "roundInfo() is called by couple of places in consensus for safety, better test/verify the delay of return err due to this Sleep() would not affect the normal functionality, like consensus can still be reached, full-node can correctly sync"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.",
          "reference": "This 32 could go away too."
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:",
          "reference": "These props should be less specifically named since the component is generic, for example `anchorLink`, `anchorLinkLabel`."
        },
        {
          "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.",
          "reference": "In the future, it'd be great if we can separate commits or PRs that aren't in the same scope"
        },
        {
          "prediction": "I'm not sure if this is what you're trying to do, but I think you're trying to create a copy of the __gestures dictionary. If you're trying to create a copy of the __gestures dictionary, you'll need to create a copy of the __gestures dictionary. If you're trying to create a copy of the __gestures dictionary, you'll need to create a copy of the __gestures dictionary. If you're trying to create a copy of the __gestures dictionary, you'll need to create a copy of the __gestures dictionary. If you're trying to create a copy of the __gestures dictionary, you'll need to create a copy of the __gestures dictionary. If you're trying to create a copy of the __gestures dictionary, you'll need to create a copy of the __gestures dictionary. If you're trying to create a copy of the __gestures dictionary, you'll need to create a copy of the __gestures dictionary. If you're trying to create a copy of the __gestures dictionary, you'll need to",
          "reference": "can you define the string format on a different line, so it can be named, and so that it does not have to be constructed twice?"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.",
          "reference": "Can we write a unit test for this."
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:",
          "reference": "Same as above, use `.delete('_autosave')`, not the command handler."
        },
        {
          "prediction": "I'm not sure if this is the case, but I think it's the case.",
          "reference": "It isn't necessary to check whether there are projected ID columns. The code is shorter if the values are available by default, even if they aren't used. This fixes the problem where there are constants to add (like `_file`) but no identity partition values are projected."
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:",
          "reference": "Update after command rename"
        },
        {
          "prediction": "I'm not sure if it's a bug, but it's a bug.",
          "reference": "@KroArtem This is the Checkstyle violation. This import should be grouped with other `net.sourceforge.pmd` imports below, in alphabetical order"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but it seems like you're trying to do something like this: https://github.com/ncw/rclone/blob/master/src/github.com/ncw/rclone/fs/fs.js",
          "reference": "File is not `goimports`-ed (from `goimports`)"
        },
        {
          "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug.",
          "reference": "This change seems unrelated to copying email addresses to the clipboard. Please limit the scope of pull requests as much as possible."
        },
        {
          "prediction": "I'm not sure if it's a bug, but it's a bug.",
          "reference": "I'm assuming that there isn't a way for us to skip sending an fd here (-1?), and that we're allocating this fd just to send a legal but useless value across?"
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:",
          "reference": "might be good for the units (bytes?) to be in the variable name."
        },
        {
          "prediction": "I think this is a bug in Rails. There are several rewrite rules defined in # config/initializers/rack_rewrite.rb which run before these routes.",
          "reference": "Metrics/BlockLength: Block has too many lines. [166/25]"
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this.",
          "reference": "I'd end the sentence after `special indicator (line 3)`. And then start a new sentence: `The special field can indicate that the field specifies a reset, is a sequence ID, or is a timestamp for the record.`"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to convert a list of bboxes to roi format. I'm not sure what you're trying to do, but I'm guessing you're trying to convert a list of bboxes to roi format.",
          "reference": "These empty lines can be kept."
        },
        {
          "prediction": "I'm not sure if this is a bug, but it seems to be a bug.",
          "reference": "For some reason these tests started failing due to an extra `NEWLINE` returned from `h.query()`. Have not tried to check whether this may be a problem for real templates or not, just fixed the failing tests. Anyone with an opinion here?"
        },
        {
          "prediction": "I think this is a bug. It should be fixed.",
          "reference": "It is better to have a method than a var."
        },
        {
          "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.",
          "reference": "concurrent poller won't be larger than concurrent execution. Jump from 2 -> 16 seems aggressive. I suggest to use 8. Ideally, this should be dynamic config. :)"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:",
          "reference": "List is redundant."
        },
        {
          "prediction": "I'm not sure if this is the right way to do it, but I think it's the right way to do it.",
          "reference": "Please use a string resource here rather than the hardcoded string \"user\". This allows the app to be multilingual."
        },
        {
          "prediction": "I'm not sure if it's a bug, but it's a bug.",
          "reference": "@aswathkk Why did we remove this import? I guess we are using it."
        },
        {
          "prediction": "I think this is a bug in GracefulStop. It should be fixed in GracefulStop. It should be fixed in GracefulStop.",
          "reference": "Why? I thought this is for graceful shutdown."
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.",
          "reference": "Can `result.stdout` or `result.stderr` be nil?"
        },
        {
          "prediction": "I'm not sure if this is a bug, but it seems to be a bug in the PyIssueParserProvider.",
          "reference": "@mprobst Looks like the `isStdLib` function has been removed in the latest Python plugin. Any thoughts on how to handle this? The new version doesn't seem to have any relevant alternatives."
        },
        {
          "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.",
          "reference": "How can there be a configured max ipset size? Surely we need to write ipsets with however many members are implied by the Calico datastore?"
        },
        {
          "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:",
          "reference": "This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted."
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.",
          "reference": "why not be consistent with `isNull` and `notNull` and return null?"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.",
          "reference": "Did we forget to remove this field?"
        },
        {
          "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it, so I'm not sure if it's the correct way to do it.",
          "reference": "What if there is no element?"
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.",
          "reference": "I think you need to be careful to honour isTest and stamp here."
        },
        {
          "prediction": "I'm not sure if it's a bug, but it's a bug.",
          "reference": "why zero value for `arrayType` for the default value of the optional args?"
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.",
          "reference": "@robinbonnes ~~Would you mind putting the array key and value on a new line - it makes it more readable as an array.~~ Never mind, see discussion below."
        },
        {
          "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.",
          "reference": "I've never seen us do this anywhere else - why here? Why not `address, meshAddress string`?"
        },
        {
          "prediction": "I'm not sure if it's a bug, but I think it's a bug, so I'm not sure if it's a bug, but I think it's a bug.",
          "reference": "I think it's necessary only for the earlier \"dynamic\" approach. I suppose it's not necessary in the eager one."
        },
        {
          "prediction": "DoctrineTypeToFormTypeMap is deprecated. DoctrineTypeToFormTypeMap is deprecated and should be replaced with $this->doctrineTypeToFormTypeMap[$doctrineType]? $this->doctrineTypeToFormTypeMap[$doctrineType] : $doctrineType; instead of $this->doctrineTypeToFormTypeMap[$doctrineType]? $this->doctrineTypeToFormTypeMap[$doctrineType] : $doctrineType;? $this->doctrineTypeToFormTypeMap[$doctrineType] : $doctrineType;? $this->doctrineTypeToFormTypeMap[$doctrineType] : $doctrineType;? $this->doctrineTypeToFormTypeMap[$doctrineType] : $doctrineType;? $this->doctrineTypeToFormTypeMap[$doctrineType] : $doctrineType;? $this->doctrineTypeToFormTypeMap[$doctrineType] : $doctrineType;? $this->doctrineTypeToFormTypeMap[$doctrineType]",
          "reference": "Same here than [there](#r26168925)"
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:",
          "reference": "Again we should think about moving this pattern to a static final field"
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:",
          "reference": "haven't been implemented the `__constructor` for `NormalizerConfigPass`?"
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:",
          "reference": "Docstring is missing."
        },
        {
          "prediction": "I'm not sure if this is a bug, but it seems to be a bug.",
          "reference": "I don't see the reason of this return as it will stop loading in half because an error, thats bad imo. Or you load it all and report errors or you load nothing and terminate, the first is as it always was so I wouldn't change that."
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.",
          "reference": "change from AddPeer to AddPeers added a space in some occurrences"
        },
        {
          "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.",
          "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC."
        },
        {
          "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.",
          "reference": "Do you remove \"s\" from \"iptables\" to IPTable\" on purpose? I feel it should be \"IPTablesRules\"."
        },
        {
          "prediction": "This is a ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `",
          "reference": "nit: not your problem - but I wonder if this should have been a \"ConstantResponseRpc\" - which takes a name and a value.... maybe a more reusable concept."
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this.",
          "reference": "These changes have been resolved upstream. We can revert changes to this file when synced."
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:",
          "reference": "The description predates this diff but I think we can come up with something more grounded."
        },
        {
          "prediction": "This is not a valid ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `",
          "reference": "Let the Kind, APIVersion & Metadata follow the rules followed by Volume. What is the reason for a change for snapshot struct?"
        },
        {
          "prediction": "I'm not sure if it's a bug, but it's a bug.",
          "reference": "seems that we did not strong depend servo no need to keep it? change to another one?"
        },
        {
          "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.",
          "reference": "Looks like this used to be UB before with an empty blocks and then calling `.second` on the `.front()`. Did it ever crash though?"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:",
          "reference": "Sorry about the code churn here, reworking this use normal loops and async await made debugging far more straight forward. For example, if configuring the fail point fails you find out when stepping over that line vs having to look for the ultimate catch clause that handled it."
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this. I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.",
          "reference": "this is wrong and should be reverted"
        },
        {
          "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.",
          "reference": "I think you'll need to add an import for runtime, before you can merge this PR. (Presumably it was already there for something else when you were working on this, but has since disappeared.)"
        },
        {
          "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.",
          "reference": "Unrelated typo fix."
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:",
          "reference": "I don't think we need an empty value here; any middleware that wants a default value for empty placeholders will pass in what that value should be."
        },
        {
          "prediction": "This will be passed through with the `backstop` command run with docker. if ( process.argv.includes( '--docker' ) ) { const hostname = require( './detect-storybook-host' ); if ( `--storybook-host=${ hostname }` ) { process.argv.push( `--storybook-host=http://${ hostname }:9001/` ); } else { process.argv.push( `--storybook-host=http://${ hostname }:9001/` ); } if ( `--storybook-host=${ `--storybook-host=${ `--storybook-host` }` ) { process.argv.push( `--storybook-host=${ `--storybook-host=${ `--storybook-host` }:9001/` ); }",
          "reference": "Why was this changed?"
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.",
          "reference": "Compared to using traditional enums, I suggest to use `Status` or `StatusOr`, since they are more expressive and informative. Besides, isolating the definitions of error code of individual modules from the ones of the RPC interface is a good practice, isn't it?"
        },
        {
          "prediction": "I think this is a bug, but it should be fixed in the future.",
          "reference": "Use the return of the conditional for variable assignment and comparison."
        },
        {
          "prediction": "I'm not sure if it's a bug, but it's a bug.",
          "reference": "just realised... This breaks things since there is not selenium types module, is there a PR for this?"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:",
          "reference": "move to line 23 below"
        },
        {
          "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug, but it's a bug.",
          "reference": "the first problem i found in the passcode change flow is that these two lines were happening in 'lock()' but not in'showLockActivity' which is what the passcode change flow calls. I've just moved them to happen in that method."
        },
        {
          "prediction": "@property def run_config(self) -> dict: - raise DagsterInvalidPropertyError(_property_msg(\"run_config\", \"property\")) + run_config = {} + if self._solid_config: + run_config[\"solids\"] = {self._solid_def.name: self._solid_config} + if self.resources: + run_config[\"resources\"] = self.resources._asdict() # type: ignore[attr-defined] + return run_config @property def pipeline_def(self) -> dict: - raise DagsterInvalidPropertyError(_property_msg(\"pipeline_def\", \"pipeline_def\")) + run_config = {self._solid_def.name: self._solid_def.name, self._solid_def.name: self._solid_config} + if self.resources: + run_config[\"resources\"] = self.resources._asdict() # type: ignore[attr-defined] + return run_config @property def pipeline_def(self) -> dict: - raise DagsterInvalidPropertyError(_property_msg(\"pipeline_def\", \"pipeline_def\") + run_config = {self._solid_def",
          "reference": "Doing this adds the actual resources themselves to the dictionary. I think for now, there's no way to know what the resource config provided may be, as we don't permit resource config on `build_solid_context`, so this part can be omitted."
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:",
          "reference": "1 trailing blank lines detected."
        },
        {
          "prediction": "I'm not sure if this will work, but it should work.",
          "reference": "I would personally prefer a filename without an abbreviation, a newcomer to the project wouldn't be able to translate \"pv\" to \"partition-value\"."
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:",
          "reference": "This check looks odd to me. I can't quite grok it. Why is it needed now? What's changed?"
        },
        {
          "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.",
          "reference": "This change is needed because otherwise the path was being changed from `path/store/jetstream` to `path/store/` and files stored differently after re-enabling."
        },
        {
          "prediction": "I'm not sure if this is the correct way to do this, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I'm not sure if this is the correct way to do it.",
          "reference": "is this necessary? doesn't `client.close()` imply all sessions will be ended?"
        },
        {
          "prediction": "I'm not sure if this will work for you, but it should work for you.",
          "reference": "Extra line, it's not needed here."
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.",
          "reference": "Is this OK to add in the spec helper? I need to call `Bolt::PAL.load_puppet` so that I can use the new `Bolt::PAL::Issues` module when verifying that plans forbid functions."
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.",
          "reference": "or is it `i < length - back.length()`? `\"12345\".padTo(10, 'a')` should be `12345aaaaa`"
        },
        {
          "prediction": "I'm not sure if it's a bug, but I think it's a bug.",
          "reference": "custom_imports -> custom_hooks"
        },
        {
          "prediction": "What's wrong with this? I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.",
          "reference": "I don't get why are we baking new hash structures to represent phases, sections, questions. We are not only loosing the references defined in models but also we have to figure out keys and values for this newly structures."
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.",
          "reference": "It's somewhat confusing that the `preload` parameter shadows the instance variable; maybe rename the instance variable to `globalPreload` or `preloadDefault` or so to prevent future confusion?"
        },
        {
          "prediction": "@ -36,6 +36,7 @@ type ScheduledJobConfig struct { // ScheduledJobConfig holds the configuration for a scheduled job type ScheduledJobConfig struct { + name string ImageConfig ImageWithHealthcheck `yaml:\"image,flow\"` ImageOverride `yaml:\",inline\"` TaskConfig `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `yaml:\",inline\"` `",
          "reference": "Are we setting these values anywhere?"
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but it's worth noting that we're using the same base/MurmurHash2.h file as the base/MurmurHash2.h file. I'm not sure what you're trying to do here, but it's worth noting that we're using the same base/MurmurHash2.h file as the base/MurmurHash2.h file.",
          "reference": "This has to be in front of all other includes"
        },
        {
          "prediction": "I'm not sure if I'm correct, but if I'm correct, I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.",
          "reference": "These changes make sense to me. @ricrogz : you wrote (I think ) the original version of this as part of #2553 Do you see any reason to not make the change?"
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:",
          "reference": "`window.self === window`"
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.",
          "reference": "maybe we should keep one test case for ErrFileNotExists and update only one file for ErrWorkspaceNotFound?"
        },
        {
          "prediction": "I'm not sure if this is a bug, but it's a bug.",
          "reference": "Please add `ConsigureAwait(false)` here and on `ShutdownAsync` below."
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:",
          "reference": "Isn't this a false positive? Why are we reporting `unused-variable` on a `del` operation with a `undefined-variable`."
        },
        {
          "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug, but it's a bug.",
          "reference": "Is it correct that `SessionDto` should be here?"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.",
          "reference": "sorry I missed this earlier. We no longer use ovs-ofctl for flow programming AFAIK, why not add this support to ofnet / libOpenflow?"
        },
        {
          "prediction": "I'm not sure if this is a bug, but it's a bug.",
          "reference": "Make this consistent with the other definition please `'false'` vs `false`"
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.",
          "reference": "I think this is a good way to do it. :+1:"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this (I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this)",
          "reference": "Why this is needed?"
        },
        {
          "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case.",
          "reference": "Can we define this directly in the function `NewConnTrackOvsAppCtl` instead of passing this as an argument?"
        },
        {
          "prediction": "I'm not sure if this is what you're trying to do, but I think it should be something like this:",
          "reference": "False positives are annoying..."
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:",
          "reference": "Is the infrastructure layer an appropriate one? I don't think so tbh, more like an application, or even a domain one."
        },
        {
          "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.",
          "reference": "Why is this required to turn the static readonlies into jitted const? Is this a bug in the jitter?"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:",
          "reference": "feel free to make this a \"typed\" named tuple (overriding __new__) if you are feeling frisky"
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.",
          "reference": "Would use parenthesis to explicitly state the associations of operands ```js const MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER || ((2 ** 53) - 1)"
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:",
          "reference": "The bug was caused by this order change in the last refactoring."
        },
        {
          "prediction": "I'm not sure if this is a bug, but it's a bug.",
          "reference": "This is already imported as docker. You're safe to simply use `docker.utils.kwargs_from_env()` below."
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.",
          "reference": "No need to add this fun. Using RunnableActionsBuilder#AddActions instead"
        },
        {
          "prediction": "should we use ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `",
          "reference": "I don't think it's possible to do this for hooks"
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.",
          "reference": "wait(1ms) when sec=0. wait(0ms) waits forever so that's why this is better."
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.",
          "reference": "Do we need `domain` and `so_reuseport` now that we open new sockets immediately after calling `add_listener`?"
        },
        {
          "prediction": "I'm not sure if this is what you're trying to do, but it's what you're trying to do.",
          "reference": "The formatting seems different from the rest of the code"
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.",
          "reference": "What about calling this package \"parameters\"? utils\\parameters are utils related to parameters."
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:",
          "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping."
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.",
          "reference": "what is the actual difference here?"
        },
        {
          "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.",
          "reference": "Parsing URLs is hard. Any fixes should avoid manually parsing the URL."
        },
        {
          "prediction": "I think this is a bug in RSpec. It should be fixed in RSpec.",
          "reference": "This is a private api, it doesn't need to return anything so `@group_level -= 1 if @group_level > 0` is preferred."
        },
        {
          "prediction": "I'm not sure if this is the case, but I'm not sure if this is the case, but I'm not sure if this is the case, so I'm not sure if this is the case, but if it's the case, then I'm not sure if it's the case, so I'm not sure if it's the case.",
          "reference": ".GetValueOr(0)... but really, shouldn't m_value_strife also be optional?"
        },
        {
          "prediction": "I'm not sure if this is a bug, but it seems to be a bug.",
          "reference": "Working around a possible limitation in the JSDoc plugin's typescript syntax checking. This means the same thing"
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.",
          "reference": "Should be readonly"
        },
        {
          "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.",
          "reference": "I'm not going to stop accepting the PR, but I really hate these artifacts getting dropped in the Python code just to stop things like coverage checkers and linters from complaining."
        },
        {
          "prediction": "The Kythe Authors. All rights reserved. * * Licensed under the Apache License, Version 2.0 (the \"License\"); * you may not use this file except in compliance with the License. * * Licensed under the Apache License, Version 2.0 (the \"License\"); * you may not use this file except in compliance with the License. * * Licensed under the Apache License, Version 2.0 (the \"License\"); * you may not use this file except in compliance with the License. * * Licensed under the Apache License, Version 2.0 (the \"License\"); * you may not use this file except in compliance with the License. * * Licensed under the Apache License, Version 2.0 (the \"License\"); * you may not use this file except in compliance with the License.",
          "reference": "FYI modifying an existing file generally doesn't invalidate the copyright date. The date here is when the copy right _begins_, so moving it later is arguably misleading-it still applies. Not a big deal, just something I've seen a few times in passing."
        },
        {
          "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:",
          "reference": "Because the default value of allowedOrigins is * (all origins), so it isn't necessary to set again at all."
        },
        {
          "prediction": "I'm not sure if it's a bug, but it's a bug.",
          "reference": "Style: indentation should be 4 spaces (2 indents) from the start of `Preconditions`."
        },
        {
          "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:",
          "reference": "I don't know why I suggested a html attribute at first (my bad), or maybe you think it makes sense. Otherwise, what about a simple class?"
        },
        {
          "prediction": "The default visibility setting for new plans is set to \"publicly_visibile\" instead of \"publicly_visibile\".",
          "reference": "Probably want something more generic here like 'DMPRoadmap' so that other installations aren't using UoE by default."
        },
        {
          "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.",
          "reference": "Must this not change to `MustBeRethrownImmediately`?"
        },
        {
          "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.",
          "reference": "Can it be pointer?"
        },
        {
          "prediction": "I'm not sure this is a bug, but it's a bug, and it's a bug.",
          "reference": "Not related to this issue but this condition seems weak."
        },
        {
          "prediction": "I'm not sure if we are dealing with MARCXML, but if we are dealing with MARCXML, then we can check if we are dealing with MARCXML, and if we are dealing with MARCXML, we can check if we are dealing with MARCXML, and if we are dealing with MARCXML, we can check if we are dealing with MARCXML, and if we are dealing with MARCXML, we can check if we are dealing with MARCXML, and if we are dealing with MARCXML, we can check if we are dealing with MARCXML, and if we are dealing with MARCXML, we can check if we are dealing with MARCXML, and if we are dealing with MARCXML, we can check if we are dealing with MARCXML, we can check if we are dealing with MARCXML, and if we are dealing with MARCXML, we can check if we are dealing with MARCXML, and if we are dealing with MARCXML, we can check if we are dealing with MARCXML, and if we are dealing with MARCXML, we can check if we are dealing with MARCXML, and if we are dealing with MARC",
          "reference": "I think this might be a little more readable in two lines as: 
     $preferredMarcField = $this->mainConfig->Record->preferredMarcField?? 'fullrecord'; $marc = trim($this->fields[$preferredMarcField]?? $this->fields['fullrecord']); 
    " }, { "prediction": "I think this is a bug. It should be fixed in the future, but it should be fixed in the future.", "reference": "does this still allow this file to be used with Python installations that don't have numpy?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "what about 0? Version probably can' start with 0, but v10 is theoretically possible." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Usually we consider APIs that have filesystem interactions to be part of IFileHelper, this would allow us to inject a testable implementation easily. `Path.IsRootedPath` doesn't access the file system. It is string comparison I believe." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Do we need to use quote? Why not `status: Init`" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "Nice catch! I don't think I would have caught that, did you search the whole code base for pre-existing functions?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug.", "reference": "Remove this line." }, { "prediction": "I'm not sure if this is a bug, but it's not a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug.", "reference": "This is no longer called in any of our unit tests, right?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do this in the wrong way.", "reference": "I think typically K8s APIs will use `int32` and not `uint32`. I think we should keep it consistent with the rule `Priority` above. I believe that the rationale for using `int32` in general is: * some programming languages don't have native support for unsigned integers * it's easier to catch sign errors with signed integers, depending on the programming language (it it's negative, it's clearly an error but if it's a very large number, it could be normal or it could be a negative number overflow)" }, { "prediction": "I think this is what you're looking for.", "reference": "If you end up changing grant to an association, this may need to change to a reference to enforce the foreign_key `add_reference :plans, :grant`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure if this is what you're trying to do.", "reference": "This won't work because `notification` comes from an API response here. I think this would be the same as the change to `Alert` where it would get `SmallSunSVG`." }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "This is not checked below?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug. I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "Will this ever return a \"Stack does not exist\" error? Should we handle it silently here rather than making higher level packages do error checking?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this, which is not what you're trying to do. I'm guessing you're trying to do something like this, but I'm not sure if this is what you're trying to do.", "reference": "minor: at this scale, one import per line reads better" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Should remove the default templates as well." }, { "prediction": "I'm not sure if you're using webpack, but if you're using webpack, you can do this:", "reference": "Why not `let`?" }, { "prediction": "I'm not sure if this is what you are looking for, but it's worth noting that this is what you're looking for.", "reference": "ns -> DNS My first reading was this is referring to System.nanoTime and thought hrm?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "is there a reason not to remove the param now? I think the serdes will still work?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think this should work.", "reference": "`places=2` seems to be very poor comparison. Do you have any thoughts why is it fail with more strict checks?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "should we make level debug? Also just FYI, with debug level, we can add more detailed logging for better debuggability without concerning overwhelming logging message" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it is a bug.", "reference": "I needed to add this import for Sphinx to inspect C++ runtime objects properly. This should be the only code change in this PR." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm guessing it's a bug.", "reference": "Changes in this file aren't related to the PR, are they? You took the opportunity to change the group deletion to using the subscriber too?" }, { "prediction": "It's not possible to change the default mode of `MetricsModes` to `MetricsModes`. It's possible to change the default mode of `MetricsModes` to `MetricsModes`. I'm not sure if it's possible to change the default mode of `MetricsModes` to `MetricsModes` or `MetricsModes`. I'm not sure if it's possible to change the default mode of `MetricsModes` to `MetricsModes` or `MetricsModes`. I'm not sure if it's possible to change the default mode of `MetricsModes` to `MetricsModes` or `MetricsModes`. I'm not sure if it's possible to change the default mode of `MetricsModes` to `MetricsModes` or `MetricsModes`. I'm not sure if it's possible to change the default mode of `MetricsModes` to `MetricsModes` or `MetricsModes`. I'm not sure if it's possible to change the default mode of `MetricsModes` to `MetricsModes` or `MetricsModes`. I'm not sure if it's possible to change the default mode of `MetricsModes` to `MetricsModes` or `MetricsModes`. I'm not sure if", "reference": "I'd probably move this into `MetricsConfig` as a private method. Seems like we only use it there." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Not clear here what you mean with this list" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Curious, is there a way we can get around this without suppressing?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "I don't think we this field in session, it's a serial number for proposal but not unique index itself" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm guessing it's a bug.", "reference": "Can't have two benchmarks with `Baseline = true`" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Same here: Empty line before and no `Internal dependencies` docblock (mandatory anyway once #217 lands)." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "sorry, the default value for this field is no longer allowed?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Why does this work? I'd've expected that an admin could create a file anywhere." }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "falling back to `x64` seems like a really bad idea given that the VS templates default to x86 these days." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Bit surprised by this. I would have thought either you want to set it for both mpl and bokeh...or alternatively it was only ever meant for bokeh and was always wrong?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "Check modname instead, but only if it's a ImportFrom." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "How about `write.metadata.previous-versions-max`? No need to refer to these as a log." }, { "prediction": "I think this is what you're looking for: https://rspec-mocks.readthedocs.io/en/latest/rspec-mocks.html#filter_run_excluding_windows", "reference": "We generally do this via tags in the Rakefile, not separate environment variables." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "Update after command rename" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "`if X not in Y:`" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Do we know why the pool is exhausted? In the past, we had a few leaks in the Spark catalog code which led to this. It can be also a valid use case too if we simply need a larger pool." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "Logging in Bolt still seems to be a little messy. I think this is more correct than what I had before, but made sure I wouldn't overwrite an existing level. And if console logging gets more options, both debug and verbose need to be fixed here." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "This could be simplified (if including is fine): `auto address_string = boost::algorithm::erase_first_copy (address.to_string (), \"::ffff:\");`" }, { "prediction": "I'm not sure if this is a bug or a bug, but it seems to be a bug.", "reference": "This is wildly unhelpful to users --- they need to know when a proxy has been registered." }, { "prediction": "I think this is a bug in Rails. It's a bug in Rails.", "reference": "Why do we need `do_not_validate_attachment_file_type` is we're doing it in the previous line?" }, { "prediction": "I'm not sure if this is the case, but if it's the case, it's the case, it's the case.", "reference": "Loading login page right away only for the regular use case." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to re-render a component and it's children. I'm guessing you're trying to re-render a component and it's children, but I'm not sure what you're trying to do, so I'm guessing you're trying to re-render a component and it's children. I'm guessing you're trying to re-render a component and it's children, but I'm not sure what you're trying to do.", "reference": "IIRC this flag disables re-rendering entirely (`s/recursively //`)" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Did you test this redirect? @thornbill mentioned it might need `web` at the front, but if this works fine I'd rather leave it this way." }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "FYI, this returned `StringValues` which is a value type (aka can never be null)." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Oh no, that's a bug." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "Let's leave a note in CHANGES to replace this with an error metadata struct or interface, unless it would be less effort overall to take a run at it in this change." }, { "prediction": "The ``````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````", "reference": "The changelog entry does a better job of explaining how this is used than this description. In particular, this says that you need to set `mapTo` if the underlying name is different, but not that `mapTo` *is* the underlying name." }, { "prediction": "I'm not sure what you're trying to do, but it seems like you're trying to do something like this:", "reference": "These imports will probably need to be refactored so they aren't here. That applies for all of the database drivers. The reason for this is because we sometimes want a driver to be available and sometimes we don't. When we include this library in our cloud offering, the sqlite3 connector needs to be gone because it's a security vulnerability and there's no use case for it in a cloud environment. But for flux itself, I can see how sqlite3 would be really useful and so I like this change. But this import needs to only exist within the tests and within the `cmd/flux` package. It cannot be here." }, { "prediction": "I think this is a bug. It should be a bug.", "reference": "We can use `getQualifiedKeyName` here instead. I will update." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I'm not sure if this is the correct way to do it.", "reference": "Could you clarifty why some of those are removed?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "`ctx` is unused in ListDeploymentConfigTemplates" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "nice to see the usage of block for a more readable link name" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Can these use `static_cast` instead? Other than that, it's fine." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "This output is only present when `DEBUG=True`. Does it really bother so much?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "I think it should pass wallet transaction as well, otherwise there will be 2 wallet read transactions in 1 threads (next in scan_receivable)" }, { "prediction": "I'm not sure if I'm correct, but if I'm correct, I'm not sure if I'm correct, or if I'm wrong, I'm not sure if I'm correct.", "reference": "RDKit::Utils is now in the namespace for localeswitcer... We could change it to something else." }, { "prediction": "We need to flatten the tuple, e.g. ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "@itholic, can we fix it in `_normalize_keyword_aggregation`?" }, { "prediction": "This class represents a user's subscription to Learn content class Subscription < ActiveRecord::Base MAILING_LIST = 'Active Subscribers' + DOWNGRADED_PLAN = 'prime-maintain' belongs_to :user belongs_to :mentor, class_name: User belongs_to :mentor, class_name: User belongs_to :mentor, class_name: User belongs_to :mentor, class_name: User belongs_to :mentor, class_name: User belongs_to :mentor, class_name: User belongs_to :mentor, class_name: User belongs_to :mentor, class_name: User belongs_to :mentor, class_name: User belongs_to :mentor, class_name: User belongs_to :mentor, class_name: User belongs_to :mentor, class_name: User belongs_to :mentor, class_name: User belongs_to :mentor, class_name: User belongs_to :mentor, class_name: User belongs_to :mentor, class_name: User belongs_to :mentor, class_name: User", "reference": "It seems like we have the main plan in the database but the downgrade plan in the code. Probably okay for now, but as our thinking of how downgrades/plans develops we may want to consolidate." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "we shouldn't add a bunch of static initializers 'everywhere' in the code. Probably just one would be good, during the construction of the 'RemoteWebDriver' class." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "do we need both flags? maybe infer that `clef-signer-enabled` whenever `clef-signer-endpoint` is defined?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Do we need this? I didn't see css files (only scss)." }, { "prediction": "I think this is what you are looking for, but I'm not sure if this is what you're looking for, so I'm not sure if this is what you're looking for.", "reference": "This feels like a weird `if not... or not` to me. Can you talk out the intent here?" }, { "prediction": "I think you'll want to do this in the controller itself.", "reference": "Align the parameters of a method call if they span more than one line." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "`@package *` can be removed as well." }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "@ScottGarman is there a reason that `redhat_fips` needs to be a beaker platform? Why can't it be another platform that beaker just understands as `redhat`?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Where is the other place?" }, { "prediction": "I'm not sure if this is what you are looking for, but I think this is what you're looking for.", "reference": "Are you subclassing from `UserList` instead of `list` to satisfy some constraint of Jython? My main concern here is that this is a subtle breaking change to the API because `UserList` is not a subclass of `list`. This has the unfortunate side effect of breaking any user that is using `isinstance` checks to see if a `ResultSet` is a `list`." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "We can DRY the above three functions" }, { "prediction": "It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function. It's just a convenience function", "reference": "Only no good is good code. Nice that you were able to remove all this duplicate stuff!" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Looking at the code, it seems very odd that this method even exists in the SurfaceNamer, since it is only implemented and used in the PhpSurfaceNamer, and in fact the RetrySettings class name is hardcoded elsewhere. WDYT of just removing this method from SurfaceNamer and PhpSurfaceNamer?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "these interfaces are defined twice. we should use only one and have it in `storage` package maybe" }, { "prediction": "This is the base class that all OPF Model implementations should use. It's not the base class, it's the base class that all OPF Model implementations should use. It's the base class that all OPF Model implementations should use. It's the base class that all OPF Model implementations should use. It's the base class that all OPF Model implementations should use. It's the base class that all OPF Model implementations should use. It's the base class that all OPF Model implementations should use. It's the base class that all OPF Model implementations should use.", "reference": "This is the wrong context for usage of `global` keyword. It need only be used inside functions." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "this change should be described in the changelog. I'll update it when merging if nothing else arises." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to create a dispatcher that knows how to transport requests. I'm not sure what you're trying to do, but I'm guessing you're trying to create a dispatcher that knows how to transport requests. I'm not sure what you're trying to do, but I'm guessing you're trying to create a dispatcher that knows how to transport requests. I'm guessing you're trying to create a dispatcher that knows how to transport requests.", "reference": "Just to stay consistent with naming let's call it CreateGRPCDispatcherForOutbound. Also rename 'CreateDispatcherForOutbound' to 'CreateTChannelDispatcherForOutbound'" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "This will always need to be displayed to users." }, { "prediction": "I'm not sure what you're trying to do, but I think this should work:", "reference": "This looks very much like `repr` now (we miss 127 though) - maybe just do `repr(x)` + strip outer parantheses?" }, { "prediction": "I'm not sure if this is what you're looking for, but maybe this is what you're looking for?", "reference": "I don't see this field is set in task_generator.go. worth to double check if we put the timestamp when creating replication tasks." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "nit: I prefer the space before and after this check to make it very easy to scan when reading through code" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "should users also do a triple-flush?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's worth noting that this is what you're trying to do.", "reference": "What is the implication of removing these from the test? I thought the idea was to have all types supported by `docstore` here, and do things in the drivers to make them support them (e.g., list of size 2 for complex). If you're removing them because firestore doesn't have native support, then we're going to end up only testing the intersection of all types supported by all drivers; we need a better way." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do is what you're trying to do.", "reference": "Let's also adjust the somewhat weird type signature here as well. This probably should be `typing.Any` instead of `str` in the last line if we intend to support ints." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "The body can just be `os.RemoveAll(dir)`" }, { "prediction": "I'm not sure if this is the case, but if it's the case, then I'm not sure if it's the case, but if it's the case, then I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case. If it's the case, then I'm not sure if it's the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "Is this covered by regression tests? Also you might make a patch onto refactor branch." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "This is maybe more of an admin request? WDYT?" }, { "prediction": "This is not a Map, it's a Map. It's a Map.Entry. It's a Map.Entry. It's a Map.Entry. It's a Map.Entry. It's a Map.Entry. It's a Map.Entry. It's a Map.Entry. It's a Map.Entry. It's a Map.Entry. It's a Map.Entry. It's a Map.Entry. It's a Map.Entry. It's a Map.Entry. It's a Map.Entry. It's a Map.Entry. It's a Map.Entry. It's a Map.Entry. It's a Map.Entry. It's a Map.Entry. It's a Map.Entry. It's a Map.Entry with a changed role\"" }, { "prediction": "This is kind of pointless as we don't need to change the config.serve_static_assets = true, but it's a good idea to change the config.serve_static_assets = false, so we don't need to change the config.serve_static_assets = true, so we don't need to change the config.serve_static_assets = true, but it's a good idea to change the config.serve_static_assets = false, so we don't need to change the config.serve_static_assets = true, so we don't need to change the config.serve_static_assets = true, so we don't need to change the config.serve_static_assets = true, so we don't need to change the config.serve_static_assets = true, so we don't need to change the config.serve_static_assets = true, so we don't need to change the config.serve_static_assets = true, so we don't need to change the config.serve_static_assets = true, so we don't need to change the config.serve_static_assets = true,", "reference": "Just to be clear: 1. This is required for compression, right? 2. This won't actually result in our dynos serving the assets, since they'll be served via the CDN, correct?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "not sure about removing this ping @Soullivaneuh" }, { "prediction": "I think this is what you're looking for.", "reference": "Put a comma after the last parameter of a multiline method call." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "If instance could not be found when the provider id is set, `findInstance()` returns `ErrInstanceNotFoundByID` error. So that during reconcileNormal(), we don't create a new instance. In `reconcileDelete()`, when ErrInstanceNotFoundByID is seen, deletion continues to clean up even if the instance is gone (may be manually deleted)." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "I would recommend making this a Tuple<ReplicateValue, IColllection<object>> You only need to convert things to strings if you need to persist them in Settings or something. If they only need to live for the life of dialog, you can keep everything as objects. You can use \"null\" for the ReplicateValue for when they have not chosen a property." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "I think there is no point providing action key here, as it will be called specifically, rather than randomly" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "`XUnitIntegration` doesn't need to cache this anymore." }, { "prediction": "This file itself files[\".luacheckrc\"].ignore = {\"111\", \"112\", \"131\"} +-- Theme files, ignore max line length +files[\"themes/*\"].ignore = {\"631\"} + -- Global objects defined by the C code read_globals = { \"awesome\", \"button\", - \"client\", \"dbus\", \"drawable\", \"drawin\", \"drawable\", \"drawin\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"drawable\", \"", "reference": "Can we have something line `# noqa` there instead? I think it's fine like this though." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "this variable is used in both branches so I've decided to declare it above" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "`setFlags()` overwrites the previous flag, we should be using `addFlags()` to append flags." }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Need `return` after this." }, { "prediction": "I think this is a bug, but it should be fixed in a future release.", "reference": "I would say we should not use the `CacheableResponseTrait` within the `JsonResponseTrait`. Traits within traits tend to lead to a bad developer experience as it can be really hard to find the actual method you're seeing in the implementing class, and in this case it looks like we're using _both_ the cacheable and the JSON traits in the same controller, so it's redundant anyway. I'd recommend just removing that use statement from `JsonResponseTrait` and make sure `ChaceableResponseTrait` is included everywhere it's needed specifically." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think you're trying to do something like this:", "reference": "This change is unhelpful: it precludes users from knowing which ports are being used for what purpose within the system." }, { "prediction": "I think this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Whoa, we weren't doing this before?? Derp." }, { "prediction": "I think this is a bug. It should be fixed in a future release.", "reference": "I'm surprised we didn't go with something like `flow := f.Flow.Copy()` to take care of all the fields at once, but as long as it works it's good enough for me" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure.", "reference": "We would like this code to run, even when `config.XDPEnabled` is false, so that Felix can clean up its own XDP state after a restart." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "I'd declare this field `qualifiedName` private to hide it. Unless it really needs to be modified from somewhere else... (e.g. unit tests..), but then, we should find a solution, where this field can stay private." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "is this exhaustive? or rather, any psudo header started with `:` is un-parsable/invalid in HTTP/1 right?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "Is this change implying something or just seems fit b/c regardless of outcome the sessions should still be length 1?" }, { "prediction": "I don't think this is a bug, but it's a bug, and it's a bug.", "reference": "Maybe throw an exception if there is more than one, so that discovering the lack of support is easier when someone tries to use it down the road." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Prefer single-quoted strings when you don't need string interpolation or special symbols." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "I feel the name of this function could be better, conveying it's a predicate. Something like `HasDockerTestEnvironment` or `CanRunLocalServerTests`, etc." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "This seems unrelated to your PR, how did this end up in here?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Is `username` expected to be case insensitive?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "File is not `gofmt`-ed with `-s` (from `gofmt`)" }, { "prediction": "I think this is a bug in the latest version of PMD. It should be fixed in the latest version of PMD.", "reference": "Is there any point to the deprecation? If someone was using these APIs, can they continue to do so in any meaningful fashion now that you've disconnected them from the PMD internals? Normally \"compiles but doesn't work\" is considered a bug." }, { "prediction": "I'm not sure what you're trying to do, but I think it's a bug.", "reference": "You can remove the `QItemSelection` import in this file now." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, so I'm not sure if it's the case, but if it's the case, it's the case.", "reference": "Use `std::shared_lock` and `std::try_to_lock_t`. BTW. Why we fail on contention?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this should work for you.", "reference": "Not sure what this actually does, but do you need to add `\"\"` here? Or does `[\".jsx\", \".js\"]` work too?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "let's group imports in the order: std third party first party" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "So the tests run only when the db exists? Else everything passes?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "`Remove` is unclear. It seems the point is to allow the `FifoByteSink` to delete the underlying file. There seems to be an implicit contract that consumers of this interface call `Remove` after `Close` without necessarily understanding what `Remove` does. I get that it's a little awkward to have `FifoByteSink` delete the file in `Close`. It would probably be best to just remove this from the interface, since `AddSink` is working with an actual `FifoByteSink`. I would rename it in `FifoByteSync` to `DeleteFile` or `Cleanup` or something that's makes it more clear what's being removed." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing it's a bug.", "reference": "Mentioned elsewhere but repeating again: would be nice to have units (ideally `Size *Bytes`)." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I think a test in `spec/integration` might help keep this file a bit more manageable, especially since we're just checking file contents and errors. But basically the same idea!" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like it's a bug. I'm not sure what you're trying to do, but it seems like it's a bug.", "reference": "This spec can be modified, giving you extra strength (Check this fetch key doesn't work and therefore returns `nil`)" }, { "prediction": "Instr_label_callback(instr_t *instr, instr_label_callback_t cb) { if (instr->label_cb == cb) { CLIENT_ASSERT(instr->label_cb == NULL, \"label callback function is already set\"); } else { CLIENT_ASSERT(instr->label_cb == cb, \"label callback function is already set\"); } } Instr_label_callback_t cb = NULL; if (instr->label_cb == cb) { CLIENT_ASSERT(instr->label_cb == NULL, \"label callback function is already set\"); } else { CLIENT_ASSERT(instr->label_cb == cb, \"label callback function is already set\"); }", "reference": "So this means that we can remove a callback via instr_set_label_callback(). Maybe consider adding another API function for removal, and add a new assert here such that cb!= NULL?" }, { "prediction": "I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "why are we using an instance variable instead of accessing the visibility method?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Ok. Can we just disable this linter?" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "this is `test_data` and all other instances are `testdata` - does this change affect any test files, or are there actually no directories called `test_data` in the repo? (I just checked, it seems like there aren't...)" }, { "prediction": "public static String getBasePath() { return getBasePath() + \"/chatter/\"; } - public static String getBaseConnectPath() { return getBasePath() + \"/connect/\"; } - public static String getBaseSObjectPath() { return getBasePath() + \"/sobjects/\"; }", "reference": "Fixing `lint` warnings that have existed for a while." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Better to rename this to CASDefaultCstorSparsePool." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if this is a bug or a bug, so I'm not sure if it's a bug or a bug.", "reference": "Since we'e not 100% sure if `close` will be called more than once, should we set `client` to `null` or add an `AtomicBoolean closed` that will then handle the idempotency issue?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "And here - what happens if name id is invalid" }, { "prediction": "I'm not sure if this will work for you, but it should work for you.", "reference": "__toString() is not a part of QueryInterface" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this.", "reference": "nit: Could you add an empty line between `import datetime` (built-in library block) and `import numpy as np` (third-party library block)?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Please remove `HIP_UNSUPPORTED`" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "Having boolean parameters to change function behavior is not a good practice because it violates the principle of functions being responsible for a single task, so the need for this indicates we need to split something out of here instead. We can introduce a function like `getCurrentDateRangeDayCount` or similar, which does this." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Is this not required?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "savedStates is for confirmed states, not needed in working set" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to register a service definition that is not \"wireguard\" or \"wireguard\" or \"wireguard\" or \"wireguard\" or \"wireguard\" service type. I'm not sure what you're trying to do here, but I'm assuming you're trying to register a service definition that is not \"wireguard\" or \"wireguard\" or \"wireguard\" or \"wireguard\" or \"wireguard\" or \"wireguard\" or \"wireguard\" or \"wireguard\" or \"wireguard\" or \"wireguard\" or \"wireguard\" or \"wireguard\" or \"wireguard\" or \"wireguard\" service type.", "reference": "Why should we move it into `bootstrap.go` file?" }, { "prediction": "I'm not sure if this is what you're looking for, but it's worth noting that it's not a good idea to have a `breakpoints` array, but rather a `breakpoints` array, so it's a good idea to have a `breakpoints` array, so it's not a good idea to have a `breakpoints` array, but rather a `breakpoints` array.", "reference": "In the next major version, I plan on changing the em-unit breakpoints to be pixel values to keep everything consistent. Would be great to handle this with pixels as well, but still allow em-units to be defined with a string" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "I don't think this will actually align the indexes, if you have > 100 tabs, the tabs over 100 will be misaligned. In addition with less than 10 tabs, there will be a pointless space." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "hrm, unsigned headers now won't be included." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "what if `$value ='' `?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "What about using `!files.hasNext` instead? I'm not sure we want to assume that the iterable can be consumed multiple times. Plus there's no need to consume the entire iterable just to check whether it is empty." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "I think we could add bool addArticle here defaulted to false like its done in item class so std::string Container::getName(bool addArticle /* = false*/) const { and pass that variable to getNameDescription call" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "What if a library function on the outside still calls the old method? It is then no longer blocked properly. Have you tested the change?" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "@i110 Do you have an idea on how we should propagate errors that occur in this block? The error condition happens when i) `h2o_buffer_reserve` fails to allocate space (happens in master as well), or ii) `fill_cb` returns an error (unique to this PR)." }, { "prediction": "I think this is what you're looking for.", "reference": "Does this mean the times will show up in emails as UTC?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "What's the motivation for having one of these be a cycle and the other be a fixed color?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "What will be an empty entry now?" }, { "prediction": "I'm not sure if this is the right way to do it, but I'm not sure if it's the right way to do it.", "reference": "Can I ask you to add jsdoc tag that would mark the prop as `@private`?" }, { "prediction": "IsDir() returns true if the path is a directory. If it is a directory, it will return false. If it is a directory, it will return true. If it is a directory, it will return true. If it is a directory, it will return false. If it is a directory, it will return true. If it is a directory, it will return false. If it is a directory, it will return true.", "reference": "Do you need this? Don't think you use it?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "`this.` seems unnecessary" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "nit: can be removed before merging..." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for this.$container = $(`
    `).appendTo('body'); and this.$container = $(`
    `).appendTo('body');", "reference": "Maybe a single quote would be compatible with airbnb style." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here, so I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "This is not the right approach. The `Distributor` maintains a model of the current state of the Grid. That model already contains the information about every active session. We don't need to modify `SessionMap` to expose it further." }, { "prediction": "I'm not sure what you're trying to do, but I think this should work.", "reference": "@Marwes @wolffcm This is the file where I made a change the the expected output. Its a little bit weird, but I think that the final output makes sense for the most part." }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if this is a bug, but it's a bug. I'm not sure if this is a bug, but I think it's a bug.", "reference": "I think we probably need a util.Warning() here." }, { "prediction": "I think this is a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug. It's a bug.", "reference": "Let's make have a signature that's consistent with `PhysicalKey.from_path`. Users should also have access to PhysicalKey since that class is part of the API (e.g., `Package.resolve_hash`)." }, { "prediction": "I'm not sure if this is what you're trying to do, but it's a good idea.", "reference": "What is this directive for?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "I'd rephrase it as `Simplify chained comparison between the operands`." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "so in the performance data fixtures, there will be references for the second domain only?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it seems to be a bug.", "reference": "This is wildly unhelpful to users --- they need to know when a proxy has been registered." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "If there is no authority header (i.e. someone intentionally deleted it), I would argue we probably don't want a Host header in the replay either. How about we only add it if it exists, and do nothing otherwise?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "is there any unit test that can be updated to verify this?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, so I'm not sure if it's a bug, but it's a bug, so I'm not sure if it's a bug.", "reference": "exiting at this point is leaking memory, take a look at the valgrind output. the sbuffer must be destroyed." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "i think you want a different flag and help like `--ffmpeg` or something; and you need to mark any tests you want skipped" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "this needed to change? or it was just some formatting thing?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "What's the advantage of doing it this way over, say, changing the `.circleci/config.yaml` to have `TRACE` as the `root.log.level`?" }, { "prediction": "I think this is what you are looking for. I think this is what you're looking for.", "reference": "typo: if -> of" }, { "prediction": "I'm not sure what you're trying to do, but I think it's a good idea.", "reference": "It'll be interesting to see who or what this breaks..." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're using a WebDriver-backed Selenium. I'm not sure what you're trying to do here, but I'm guessing you're using a WebDriver-backed Selenium. I'm guessing you're using a WebDriver-backed Selenium, but I'm not sure what you're trying to do here.", "reference": "This change is incorrect: the current log level is correct." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to create a new ClientFactory, but I'm not sure what you're trying to do here.", "reference": "There are few cases like this where default logger is used from CLI/db tools. I would copy `NewTestLogger` to `NewCLILogger` and use it everywhere in CLI. In future these two might be different." }, { "prediction": "private static String nullSafeValue(Object value) { return nullSafeValue(value); } private static String nullSafeValue(String value) { return nullSafeValue(value); } private static String nullSafeValue(String value) { return nullSafeValue(value); } private static String nullSafeValue(String value) { return nullSafeValue(value); } private static String nullSafeValue(String key) { return nullSafeValue(key); } private static String nullSafeValue(String key) { return nullSafeValue(key); } private static String nullSafeValue(String key) { return nullSafeValue(key); } private static String nullSafeValue(String key) { return nullSafeValue(key); } private static String nullSafeValue(String key) { return nullSafeValue(key); } private static String nullSafeValue(String key) { return nullSafeValue(key); } private static String nullSafeValue(String key) { return nullSafeValue(key); } private static String nullSafeValue(String key) { return nullSafeValue(key); } private static String nullSafeValue(String key) { return nullSafeValue(key); } private static String nullSafeValue(String", "reference": "While it provides re-use, this method does not make sense in `AbstractAuthenticationToken` because it knows nothing of a hash key. Instead, we should move this to a private method within each subclass." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "index by memory address? I realize I don't understand why we don't just build a list :)" }, { "prediction": "@user_bp.route(\"/lastfmscraper/.js\") @user_bp.route(\"/lastfmscraper/.js\") @user_bp.route(\"/lastfmscraper/.js\") @user_bp.route(\"/lastfmscraper/.js\") @user_bp.route(\"/lastfmscraper/.js\") @user_bp.route(\"/lastfmscraper/.js\") @user_bp.route(\"/lastfmscraper/.js\") @user_bp.route(\"/lastfmscraper/.js\") @user_bp.route(\"/lastfmscraper/.js\") @user_bp.route(\"/lastfmscraper/.js\") @user_bp.route(\"/lastfmscraper/.js\") @user_bp.route(\"/lastfmscraper/.js\") @user_bp.route(\"/lastfmscraper/.js\") @user_bp.route(\"/lastfmscraper/.js\") @user_", "reference": "Not part of this commit, but we thought that this may not be a good place for this url, as it is in the `/user/` namespace (effectively preventing us having a user called `lastfmscraper`, however rare it may be)" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Does not appear to be used." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do, so I'm not sure if this is what you're trying to do.", "reference": "I think this starts a new `powershell.exe` interpreter each time, which is pretty slow to run a single command. Can we just do `on(bolt, \"cmd /c #{bolt_command}\")`? /cc @Iristyle" }, { "prediction": "@purchaseable.collection? %> <% if @video_page.purchaseable.collection? %>
  • <%= link_to 'All Videos', @purchase %>
  • <% else %>
  • <%= link_to 'All Videos', @video_page.purchase %>
  • <% end %> <% end %> <% content_for :subject_block do %> -

    <%= @purchaseable.name %>

    +

    <%= @video_page.purchaseable.name %>

    - <% if @purchaseable.collection? %> - <%= @purchaseable.name %> - <%= @purchaseable.name %> - <% if @video_page.purchaseable.collection? %> - <%= @video_page.purchaseable.name %> - <% if @video_page.purchaseable.collection? %> - <%= @video_page.purchaseable.name %> - <% if @video_page.purchaseable.collection? %> - <%= @video_page.purchaseable.name %> - <% if @video_page.purchaseable.collection? %> - <%= @video_page", "reference": "Can we add a `collection?` method to the `VideoPage` so we don't violate Law of Demeter here?" }, { "prediction": "I'm not sure if it's a bug, but if it's a bug, it's a bug.", "reference": "Deleting unused code." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "`PseudoSampler` can also be imported from `..bbox`" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Could you move this import to where the other `github.com/algorand/go-algorand` imports are?" }, { "prediction": "I'm not sure this is a bug, but it's a bug, and it should be fixed.", "reference": "I'd rather not activate this protocol by default for now, unless there is a good reason for that." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "Remove these 2 blank lines." }, { "prediction": "I'm not sure if this is a bug, but it should be fixed in the future.", "reference": "Want to remove this?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this (I'm not sure what you're trying to do)", "reference": "is this a golint requirement? huh. mixed feelings :)" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Generally with these tests please split up these tests so that there is a different test for each method" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "Should something use the lock passed in?" }, { "prediction": "The ``````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````", "reference": "Is this dependant on some version of Docker? Do we need to include both or `volumes` is deprecated (or just wrong!?)?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "I know this is not new code, but should we change `leader.getState() == State.ACTIVE` to `leader.isActive(liveNodes)`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Why not use ASTAnyTypeDeclaration? AbstractAnyTypeDeclaration is deprecated" }, { "prediction": "I'm not sure what you're trying to do, but I think it's a bug.", "reference": "A blank line at the very end of each file should eliminate the \"No EOF\" warning we see above" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "These would both be more robust with `errors.As` so that we could safely chain errors." }, { "prediction": "We have to keep the old mangled name since the Objc->Swift bindings // that are in Foundation don't get the new mangling. - if (valobj_typename.startswith(SwiftLanguageRuntime::GetCurrentMangledName(\"_TtCs23_ContiguousArrayStorage\")) || valobj_typename.startswith(\"_TtCs23_ContiguousArrayStorage\") || valobj_typename.startswith(\"Swift._ContiguousArrayStorage\") || valobj_typename.startswith(\"Swift._ContiguousArrayStorage\") || valobj_typename.startswith(\"Swift._ContiguousArrayStorage\") || valobj_typename.startswith(\"Swift._ContiguousArrayStorage\") || valobj_typename.startswith(\"Swift._ContiguousArrayStorage\") || valobj_typename.startswith(\"Swift._ContiguousArrayStorage\") || valobj_typename.startswith(\"Swift._ContiguousArrayStorage\") || valobj_typename.startswith(\"Swift._ContiguousArrayStorage\") || valobj_typename.startswith(\"Swift._ContiguousArrayStorage\") || valobj_typename.startswith(\"Swift._ContiguousArrayStorage\") ||", "reference": "This is checking the same condition twice?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "Aren't we able to handle the case where we have MPI-CUDA without NCCL, even if it's suboptimal?" }, { "prediction": "I think it's a bad idea to put these into the database, but it's a bad idea to put them into the database, so it's a bad idea to put them into the database.", "reference": "Wouldn't we want to namespace this `AA` or something similar" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "This probably should look beyond envConfig, and include `aws.Config.Credentials` as well." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "How does this filter differ from TooExpensiveTxFilter?" }, { "prediction": "I'm not sure if this is the correct way to do this, but I think it's the correct way to do it.", "reference": "Use \" List\" instead of ArrayList in declaration." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "we might consider hard throwing when name is None since that is explicitly not working right now and then linking to issue in the exception error message" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Just noticed this - why \"like\" and not straight \"=\"" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "is this a new test? if yes, isn't it better to check for each env var is present, and the value, instead of a count?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "when will lost exception? by my test, never happened." }, { "prediction": "I'm not sure if this is what you're looking for, but if it's what you're looking for, it's probably a typo.", "reference": "You should re-stringify it here with `QUrl.FullyEncoded`." }, { "prediction": "I'm not sure why you're getting this error, but I'm not sure why you're getting this error, but I'm not sure why you're getting this error, but I'm not sure why you're getting this error. I'm guessing you're getting this error because you're using a private key, but you're using a private key, but you're using a private key, and you're using a private key, so you're not using a private key. I'm guessing you're using a private key, but you're using a private key, but you're using a private key. I'm guessing you're using a private key, so I'm guessing you're using a private key, but you're using a private key. I'm guessing you're using a private key, so I'm guessing you're using a private key. I'm guessing you're using a private key, so I'm guessing you're using a private key. I'm guessing you're using a private key. I'm guessing you're using a private key, but you're using a", "reference": "i'm not sure why the quit channel is needed in this context" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "When `args.MemoryLimit` is empty, will `MustParse` panic?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "How soon after this will Apply() be called? It would be a shame if there was still a significant delay before a missing or superfluous route was corrected." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "I add a `idx` property, and it is only use for benchmark `heap.Remove`, is it acceptable?" }, { "prediction": "This file is part of the GNU General Public License. #Copyright (C) 2006-2019tNV Access Limited, Babbage B.V., Davy Kager, Derek Riemer #Copyright (C) 2006-2019tNV Access Limited, Babbage B.V., Davy Kager, Derek Riemer #This file is covered by the GNU General Public License. #Copyright (C) 2006-2019tNV Access Limited, Babbage B.V., Davy Kager, Derek Riemer #This file is covered by the GNU General Public License. #See the file COPYING for more details. #Copyright (C) 2006-2019tNV Access Limited, Babbage B.V., Davy Kager, Derek Riemer #This file is covered by the GNU General Public License. #Copyright (C) 2006-2019tNV Access Limited, Babbage B.V., Davy Kager, Derek Riemer #This file is covered by the GNU General Public License. #Copyright (C) 2006-2019tNV", "reference": "daemonic t got inserted." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "This edit is non-essential." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Might be safer to ponyfill this?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "why was this join not necessary before?" }, { "prediction": "I'm not sure if this is the expected behavior, but I'm not sure if it's the expected behavior, but I think it's the expected behavior.", "reference": "Here we compare to the expected call count 3. Because 3 TermsEnum are created: it is a PrefixQuery and there is one TermsEnum created for AutomatonQuery.intersect() (the next call timeout check is skipped once), then 2 TermsEnum created for the 2 matching terms \"one\" and \"ones\"). Would it be clearer to have a separate test method? We could index more docs, for example 50 with a prefix-generated term (e.g. \"term\"+increment). There would be a PrefixQuery for \"term\", the same test code, and we would test the TIMEOUT_CHECK_SAMPLING: - 1 TermsEnum for Automaton.intersect(), and the next calls would be sampled (50/TIMEOUT_CHECK_SAMPLING=3) => call count +4 - 1 TermsEnum for each enumerated term => call count +50 We could verify call count = 54 (instead of 101 without sampling)" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Add `--format` as an option. Does it make sense to have all display options available? Also need to add `--inventoryfile` and possibly the global_config_options." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Any thoughts on making this false by default? My suggestion is make this opt-in. Storing exception is somewhat expensive, so lets do this only if users opt-in" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "usually I do either ` IOException|RuntimeException` or if doing Throwable, use propagateIfFatal" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here.", "reference": "Wondering whether it should be `self.clone`, or `other.clone` or maybe a new `DynamicMap` declaration entirely. I see this is in the condition where `other` is a `DynamicMap`but is this definitely right in terms of `kdims`? I need to think about it more..." }, { "prediction": "I'm not sure if this is what you are looking for, but I think this is what you're looking for.", "reference": "I chose a new category because over time I'd like to add metrics also for Authorization plugins and Auditlog plugins (all components registered in security.json). An alternative could have been `CONTAINER` I guess?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "IoAddrLen Golang prefers short variable names" }, { "prediction": "I think this is what you are looking for, but I'm not sure if this is what you are looking for.", "reference": "PHPCR-ODM does not allow blank aliases.." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "This seems trivial to forge. Can we tie this into the authentication code paths somehow so that we can really trust that the request is coming from a server instead of just some application claiming to be a server?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug in KokkosCore_Config_DeclareBackend.hpp. It's a bug in KokkosCore_Config_DeclareBackend.hpp. It's a bug in KokkosCore_Config_DeclareBackend.hpp. It's a bug in KokkosCore_Config_DeclareBackend.hpp. It's a bug in KokkosCore_Config_DeclareBackend.hpp.", "reference": "Why are you including ``?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "So previously health check was consuming from the normal metrics queue, now we duplicate the data to a new queue? I feel like there should be more changes to ensure the health check handler reads from the new queue? @DrewZhang13" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Yep, looks right; your new selector _should_ disqualify the rule from being XDP accelerated." }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "cc @anurse This exists now. Kestrel currently passes the current time to all callbacks as an optimization. Just an FYI." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "remove 3.8+ f-string format to allow use in google colab" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Should we assert that xstate is aligned here?" }, { "prediction": "@LuceneTestCase.SuppressCodecs({\"Lucene3x\",\"Lucene40\",\"Lucene41\",\"FST50\",\"Direct\",\"Lucene42\",\"Lucene45\",\"Appending\",\"BlockTreeOrds\",\"FSTOrd50\"}) +public class TestJsonFacets extends SolrTestCaseHS { private static SolrInstances servers; // for distributed testing private static int origTableSize; // for distributed testing private static int origTableSize; // for distributed testing private static int origTableSize; // for distributed testing private static int origTableSize; // for distributed testing private static int origTableSize; // for distributed testing private static int origTableSize; // for distributed testing private static int origTableSize; // for distributed testing private static int origTableSize; // for distributed testing private static int origTableSize; // for distributed testing private static int origTableSize; // for distributed testing private static int origTableSize; // for distributed testing private static int origTableSize; // for distributed testing private static int origTableSize; // for distributed testing private static int origTableSize; // for distributed testing private static int origTableSize; // for distributed testing private static int origTableSize; // for distributed testing private static int origTableSize; //", "reference": "any particular reason for suppressing this change?" }, { "prediction": "public static DifficultyCalculator DIFFICULTY_BOMB_REMOVED = (time, parent, protocolContext) -> calculateByzantiumDifficulty(time, parent, DIFFICULTY_BOMB_REMOVED, DIFFICULTY_BOMB_REMOVED, DIFFICULTY_BOMB_REMOVED, DIFFICULTY_BOMB_REMOVED, DIFFICULTY_BOMB_REMOVED, DIFFICULTY_BOMB_REMOVED, DIFFICULTY_BOMB_REMOVED, DIFFICULTY_BOMB_REMOVED, DIFFICULTY_BOMB_REMOVED, DIFFICULTY_BOMB_REMOVED, DIFFICULTY_BOMB_REMOVED, DIFFICULTY_BOMB_REMOVED, DIFFICULTY_BOMB_REMOVED, DIFFICULTY_BOMB_REMOVED, DIFFICULTY_BOMB_REMOVED, DIF", "reference": "Hot take: could this instead become `NO_DIFFICULTY_BOMB` and have` HOMESTEAD` wrap it? So this comes first then homestad with the bomb adjustment, making no difficulty the base case?" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "I suggest to use a scheme like \"blobvar\". \"blob\" would potentially collide if we have another API that use the blob package as a driver." }, { "prediction": "I think this is a bug in the latest_listen.ts_since_epoch. I'm not sure if it's a bug, but it's a bug in the latest_listen.ts_since_epoch. I'm not sure if it's a bug, but it's a bug in the latest_listen.ts_since_epoch.", "reference": "This assumes that the user has at least one listen, it should have a guard around it, because this won't always be the case" }, { "prediction": "I'm not sure if I'm missing something, but I'm not sure if I'm missing something, but I'm not sure if I'm missing something, so I'm not sure if I'm missing something.", "reference": "Seems like a lot of unintended changes. Are your line break settings causing these?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "@StrikerRUS what if we just removed build numbers and did `r-pkgdown=1.3.0`? Won't we have to fix this again if the RTD build machines change?" }, { "prediction": "This file is not part of the RDKit. It is part of the RDKit. It is not part of the RDKit. It is part of the RDKit. It is part of the RDKit.", "reference": "I'm not arguing with it, but how did you decide to make this change?" }, { "prediction": "This file is part of Invenio. It is part of the GNU General Public License. It is not part of the GNU General Public License. It is part of the GNU General Public License. It is not part of the GNU General Public License. It is part of the GNU General Public License. It is not part of the GNU General Public License. It is part of the GNU General Public License. It is not part of the GNU General Public License. It is part of the GNU General Public License.", "reference": "1: D400 First line should end with '.', not 'd' 4: I102 copyright year is outdated, expected 2014 but got 2012 25:29: E126 continuation line over-indented for hanging indent 31: D103 Docstring missing 40: D103 Docstring missing 57: D103 Docstring missing 68: D103 Docstring missing 101: D103 Docstring missing 115: D401 First line should be imperative: 'Call', not 'Calls' 115: D400 First line should end with '.', not 't' 134: D400 First line should end with '.', not 'e' 134: D205 Blank line missing between one-line summary and description" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this: You're trying to do something like this: // `json:\"preferredChain\"` // `json:\"preferredChain\"` // `json:\"preferredChain\"` // `json:\"preferredChain\"` // `json:\"preferredChain\"` // `json:\"preferredChain\"` // `json:\"preferredChain\"` // `json:\"preferredChain\"` // `json:\"preferredChain\"` // `json:\"preferredChain\"` // `json:\"preferredChain\"` // `json:\"preferredChain\"` // `json:\"preferredChain\"` // `json:\"preferredChain\"` is `json:\"preferredChain\"` // `json:\"preferredChain\"` is `json:\"preferredChain\"` // `json:\"preferredChain\"` is `json:\"preferredChain\"` `json:\"preferredChain\"` `json:\"preferredChain\"` `json:\"preferredChain\"` `json:\"preferredChain\"` `json:\"preferredChain\"` `json:\"preferredChain\"` `json:\"preferredChain\"` `json:\"preferredChain\"` `json:\"preferredChain\"` `json", "reference": "Explain that this must match the `CommonName` of the first (or is it last?) certificate in the chain, where the first certificate is the chain root CA and the last certificate is the leaf certificate." }, { "prediction": "I'm not sure if this is what you're trying to do.", "reference": "do we really need this behavour to be configurable?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, but I'm assuming you're trying to do something like MongooseArray = require('./array') -, ObjectId = require('../drivers/node-mongodb-native/objectid') +, ObjectId = require('./objectid'), ObjectIdSchema = require('../schema/objectid'), utils = require('../utils'), util = require('util')", "reference": "Hmm interesting. Do the tests check out on this?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "For another PR, another `--X` candidate." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this: (GettingStarted = \"Getting Started \u2728\" Develop = \"Develop \" Settings = \"Settings\" -) + Release = \"Release\" + (GettingStarted = \"Getting Started \u2728\" Develop = \"Develop \" Settings = \"Settings\" -) + (GettingStarted = \"Getting Started \u2728\" Develop = \"Develop \" Settings = \"Settings\" -) + (GettingStarted = \"Getting Started \u2728\" Develop = \"Develop \" Settings = \"Settings\" -) + (GettingStarted = \"Getting Started \u2728\" Develop = \"Develop \" Settings = \"Settings\" -) + (GettingStarted = \"Getting Started \u2728\" Develop = \"Develop \" Settings = \"Settings\" -) + (GettingStarted = \"Getting Started \u2728\" Develop = \"Develop \" Settings = \"Settings\" -) + (GettingStarted = \"Getting Started \u2728\" Develop = \"Develop \" Settings = \"Settings\" -) + (GettingStarted =", "reference": "Do we need to add this constant for `group_windows.go`? Otherwise, I believe the build will fail on windows. Also what do you think of adding the emoji at the end? The windows one could be plain." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "this is a junit 3 import, not a junit 4" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure.", "reference": "shouldn't there be a reque expected here?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "I prefer to make it `protected set`. What do you think?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Maybe rename this to JetStreamStoreDir?" }, { "prediction": "I'm not sure why this call is failing, but I'm not sure why it's failing.", "reference": "You can start by logging out the error" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "In general, what is the reason for the fallback price to be public? If it is public, why does it take baseFeePerGas instead of a block header?" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed in the future.", "reference": "follow-up of #2002" }, { "prediction": "I'm not sure if this is the case, but I think it's the case. I'm not sure if this is the case, but I'm not sure if it's the case, so I'm not sure if it's the case. I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case. I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "could you give some explanations of what problem do you want to solve by this change, and how/why it works?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "LongLivedMarshalByRefObject exists in both the netstandard and netfx xunit?" }, { "prediction": "I think this is what you are looking for. It should be something like this: @bridge.send_command(cmd: cmd, params: params) end + def print_page(**options) + options[:page_ranges] &&= Array(options[:page_ranges]) + + bridge.print_page(options) + end + private def debugger_address(options)", "reference": "the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "Testing on linux with this change, containerd no longer stops when k3s stops." }, { "prediction": "I think you're looking for something like this. I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for.", "reference": "Maybe [u]int64 to be consistent with other byte-valued vars in this struct?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This brings up the question... do we need to start assigning users to the different use cases in some way? We don't want this link to show up for Ric, for example." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it might be a bug.", "reference": "Unless I'm misunderstanding something, this should just be `prefetch_(param.data_param().prefetch())`, no? That should just use the default value if there's no explicit `data_param` or `data_param.prefetch` set, removing the need to also duplicate and hardcode `PREFETCH_COUNT`." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "nit : move this into a default clause in the previous switch statement." }, { "prediction": "I'm not sure what you're trying to do, but I'm sure you're trying to do something like this.", "reference": "It should be return \"''\"; I will fix it" }, { "prediction": "I'm not sure if this is the case, but I think it is the case.", "reference": "Go standard linter hates `Id`s and likes `ID`s, please do not resist." }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but I'm guessing it's a bug.", "reference": "I don't think retrying here is as useful, since `git-checkout` doesn't access the network AFAIK, and if it fails once it's probably going to fail all three times." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Fixing this typo caused a build failure in `cmd/ctl/pkg/status/certificate/certificate_test.go:238` Could you also update it there?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "Please note that adding this will import `extension_condition` in the entire scapy (as you are located in a layer). You might want to move this inside the RTP class? Would be better i think" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "This will need updating, as I'm not sure we'll want to turn on random ordering if they've specified a seed for programmatic use." }, { "prediction": "I don't know what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Are you sure these are all client libs? This seems fragile: if we later load sthg else early this will break. Seems best to have some kind of sanity check: at least add an assert in the current location where this is set." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "Picking nits here, but as a Dictionary already is a collection of KeyValuePairs there's undoubtably a way to code this that doesn't involve constructing any new ones." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug. I'm not sure if this is a bug, but I'm sure it's a bug.", "reference": "As Miklas stated, please avoid wildcard imports." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Maybe change it to `module.exports = server`? Becase there's nothing else to export here" }, { "prediction": "\"google.golang.org/grpc\" \"google.golang.org/grpc\" \"google.golang.org/grpc\" \"google.golang.org/grpc/codes\" \"google.golang.org/grpc/codes\" \"google.golang.org/grpc/codes\" \"google.golang.org/grpc/codes\" \"google.golang.org/grpc/codes\" \"google.golang.org/grpc/codes\" \"google.golang.org/grpc/codes\" \"google.golang.org/grpc/codes\" \"google.golang.org/grpc/codes\" \"google.golang.org/grpc/codes\" \"google.golang.org/grpc/codes\" \"google.golang.org/grpc/codes\" \"google.golang.org/grpc/codes\" \"google.golang.org/grpc/codes\" \"google.golang.org/grpc/codes\" \"google.golang.org/grpc/codes\" \"google.golang.org/grpc/codes\" \"", "reference": "This may be an automated change, but the import seems to fit better where it was previously." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Might we want to separate including this snippet and sending the data for signed in users into different partials?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "closest to the address" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "It should be much more clear for end-user" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do this in a single-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-quoted-", "reference": "Isn't this an example that this will be prone to false positives? We had nothing to fix in the codebase (And I think there is dict that could be named tuple in the MessageStore/MessageIdStore), but we have a false positives on our checkers." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'll report it here.", "reference": "We control `octest`, so it shouldn't be necessary to provide struct literal keys. This is a case of vet being too picky." }, { "prediction": "This is not advisable because it is not advisable to change the default plan visibility. It is not advisable to change the default plan visibility. You can change the default plan visibility by changing the default plan visibility in the config.rb file to something like this: config.default_plan_visibility = 'privately_visible' + + # The percentage of answered questions needed to enable the plan visibility section of the Share plan page + config.default_plan_percentage_answered = 50.00 end end", "reference": "I would put that constant under config/initializers/constant.rb and I would leave application.rb for rails specific." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Is there a reason not to do something like `if _, ok := doNotUnref[ptr.ID]; ok { return ops }` here?" }, { "prediction": "@property def rect(self): \"\"\"A dictionary with the size and location of the element.\"\"\" return self._execute(Command.GET_ELEMENT_RECT)['value'] + if self._w3c: + return self._execute(Command.GET_ELEMENT_RECT)['value'] + else: + return self.size, self.location @property def screenshot_as_base64(self): \"\"\"A dictionary with the size and location of the element.\"\"\" return self._execute(Command.GET_ELEMENT_RECT)['value'] + if self._w3c: + return self._execute(Command.GET_ELEMENT_RECT)['value'] + else: + return self.size, self.location @property def screenshot_as_base64(self): \"\"\"A dictionary with the size and location of the element.\"\"\" return self._execute(Command.GET_ELEMENT_RECT)['value'] + if self._w3c: + return self._execute(Command.GET_ELEMENT_RECT)['value'] + if self._w3c: + return self._execute(Command.GET_ELEMENT_RECT)['value'] + else: + return self.size, self.location @", "reference": "This would return a tuple of two dictionaries. You need to combine them and return a dictionary" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for.", "reference": "Why not always forward it to `_data`?" }, { "prediction": "@profile_bp.route('/refresh-spotify-token', methods=['GET']) @profile_bp.route('/refresh-spotify-token', methods=['POST']) @profile_bp.route('/refresh-spotify-token', methods=['GET']) @profile_bp.route('/refresh-spotify-token', methods=['POST']) @profile_bp.route('/refresh-spotify-token', methods=['POST']) @api_login_required def refresh_spotify_token():", "reference": "there are tests that use `client.get` which will fail now" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "Whoa, TIL about this syntax." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "This is a smell. When is this valid? Perhaps this should be `nil, nil, ErrNoResponse` or some such. While it is usually invalid to have neither a return value or error, we rarely check for the case in other idiomatic Go. Nothing wrong with extra defenses here, but think about it." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "This URL is outdated, add a `TODO` to fix it." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "`ChainID()` is a getter method, move up to `Nonce()`" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "If this condition is not met, shall we just throw the exception rather than logging it? @li-ygerchikov Your thoughts?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "nit: alpha-sort `ruamel.yaml` in this list please" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "Remove this because we already added it in another pr" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Can we maybe move the `File` creation to a new method? I mean both changes look equal to me with the difference of two parts, which could be specified using two input parameters." }, { "prediction": "I think this is what you're looking for.", "reference": "I think we want to require the association with the user...?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think this is the correct way to do it.", "reference": "I am unsure the below implementation is correct, but need this method to not panic else it borks the chain-validation tests." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "nit: no need this change anymore." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "This isn't really that closely related to everything else in this PR, but I'm pretty sure it's a correct change. I'm not familiar enough with the taint feature to know how to test it, but I worry that without this change some of the taint stuff might mess up the `parent_nodes` for a reference." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "[Checkstyle] ERROR: Unused import - javaslang.collection.Stream." }, { "prediction": "I'm not sure if it's a typo, but it's a typo.", "reference": "The numbers were changed since now _root_ is also added to the doc, increasing the field count by 1." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "TTemplateParamClass is handled above with the same content in the conditional" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Do we need to add `theme` here?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "i think you have to regen the api stuff, `make generate`" }, { "prediction": "We don't need the ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "DataHash shouldn't be needed here" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "`info` was chosen deliberately to mirror the old behaviour that users expected." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "For some reason, Safari handles ember arrays differently than Chrome/Firefox. To get around that, we cast the ember array to a regular array to verify the deep equal. (Note: I tried wrapping the expected value in an emberA - which would look like `expect(someEmberArray).to.deep.equal(emberA(['a', 'b']));` but that didn't work either)" }, { "prediction": "I'm not sure if this is the case, but maybe it's the case?", "reference": "`icebergType` indicates the corresponding iceberg type of the `FieldVector` `originalIcebergType` indicates what the real type we will read from the `FieldVector`. For example, the parquet int backed decimal, the `icebergType` should be integer, `originalIcebergType` is decimal. I intend to only keep the `originalIcebergType`, but listening to your ideas." }, { "prediction": "I'm not sure if this is what you're trying to do, but it's a good idea.", "reference": "The double (and thus triple as seen below) pointer gives me pause. I could imagine providing some larger API surface to smooth it out, but it's likely not worth it." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "The test name as written was grammatically correct, but now it isn't. Both 'MongooseError' and 'instance' should be both singular or both plural." }, { "prediction": "I'm not sure if this is the correct way to do this, but I think it's the correct way to do it.", "reference": "SmartStoreInspectorTest was throwing a NPE here" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "We prefer line wrapping that keeps arguments to the same method aligned rather than aligning arguments to different levels. Here, the lambda to create an `InternalRecordWrapper` is an argument to `transform`, but it is aligned with `deleteSchema.asStruct()` that is an argument to the outer `toEqualitySet` call. Instead, can you add a newline for each argument to `toEqualitySet`? If the line with the lambda is too long, then you can also add a newline for it that it indented from the start of the line with `transform`, so it is clear that it is an argument to `transform` and not `toEqualitySet`." }, { "prediction": "I'm not sure if this is the issue, but if it's the case, then it's probably the issue.", "reference": "I think it would be a good idea to wrap this in an if like the stats above, just in case." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "@angmas1 just make one more change here too. Move the else line to the line above it, where the if block ends and remove the braces like in line 280." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Looks like the actual rename is missing in this commit edit: Arf, nevermind, I was at the wrong commit" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug.", "reference": "I'm a little stuck understanding, how would this result in an error when `this.opts.params` is not set? It will just not do `AssemblyOptions.validateParams(this.opts.params)`" }, { "prediction": "I think this is a bug. It should be fixed in the latest release.", "reference": "networkVarPattern (etc) then?" }, { "prediction": "We don't need to clone the example group because the new example # must belong to the same example group (not a clone). So we don't need to clone the example group.", "reference": "I think it makes sense to do `metadata[:block].clone`, as thats what `new_metadata` is, but somehow it's missing the block from its clone." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Just realized this should be fixed instead of changing here. Concatenating int should still result in lowercase string." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this should work.", "reference": "For Se 3.x we shouldn't need to specify `marionette: true`? I'll see if I can figure out where this is getting used that it might be necessary here." }, { "prediction": "I'm not sure this is a bug, but it should be fixed. I'm not sure if this is a bug, but it should be fixed.", "reference": "This should be renamed to `chain.Store`. It was named `DefaultStore` as an alternative to `StoreImpl`, which is the (bad) Java convention." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "ad.Source is disk name? Shouldn't the order of initialization be reversed here then? First set ad.DeviceName, if it's empty, set ad.Source? Or this is a different use case? This is the third place where this device/disk default logic is implemented, so another reason to move it to regAttach, if it's possible to be generalized." }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "typo: \"be hold\" -> \"be held\"" }, { "prediction": "I'm not sure if this is the correct way to do it, but if it's the correct way to do it, then it's a good idea.", "reference": "I do not think we should have any logic inside the null storage. 1 has a very specific magical meaning. We should either return null here or long.maxValue." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Why did this change?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Removed this method. Doesn't seem to be used in the code, and the variable set here doesn't seem to be used in the views." }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "Remove the initializers (\"`= null`\") from both parameters. Remember that that's why we added the overloads: to ensure that all languages could have the convenience of the abbreviated argument lists (not all languages understand default parameters)." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I think you can just remove most of these attributes outside of `ElementType()`. Instead, this should expose the arrow array. We're not going to use these methods anyway." }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Thinking this should be `removeNode()` exported from `dom/index.js`. Thoughts?" }, { "prediction": "I'm not sure what you're trying to do, but here's what I'm going to do:", "reference": "Does this need to be saved in the state file? Or are we recomputing when the task is read from the state file?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "Looks like `s.inserts` and `s.removes` are updated under sublist's lock, so I don't think you need atomic for those 2." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "@TD-er use bitRead/bitWrite macros, do you use here inversed logic?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "The previous `fetch` mock was exposed globally before - can we do the same with `fetchMock` so we don't need to import it in every file?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Is ExpectData still used anywhere?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Do you want to allow the character `.` or any character? Because inside a regex `.` means any character, if you want to authorize `.` then you need to add `\\.`." }, { "prediction": "I'm not sure what you're trying to do here, but it should be something like this:", "reference": "`eachAsync()` should pass a doc, not an array of docs, to the callback. This would be a massive breaking change." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "please start log with caps letters" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're using the wrong layout.", "reference": "Is this where we want it in relation to the other scripts?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Please wrap this variable within a self invoking anonymous function. (function(){ FEATURE_NAME = \"reports\"; //and rest of the js goes here. })();" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "Haven't tried, but what happens currently if `-f` is used and it's not running? (thinking: `-f` should ignore the case and just proceed?) I see we have a special case for `all`" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "no need for custom errors in tests unless the tests are intended to mock a specific sort of error" }, { "prediction": "@NvidiaGPUStatusAnnotationKey = \"huawei.com/gpu-status\" // NvidiaGPUScalarResourceName is the device plugin resource name used for special handling NvidiaGPUScalarResourceName = \"nvidia.com/gpu\" + + EdgeNodeRoleLabelKey = \"node-role.kubernetes.io/edge\" )", "reference": "This const has already existed in the code, no need to define a new one" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Would Errorf be better than Warnf?" }, { "prediction": "public static String getCordovaPluginJS(Context context) { return getFilesContent(context, \"public/plugins\", \"\"); } public static String getFilesContent(Context context, String path, String currentContent) { return getFilesContent(context, path, currentContent); } public static String getFilesContent(Context context, String path, String currentContent) { return getFilesContent(context, path, currentContent); } public static String getFilesContent(Context context, String path, String currentContent) { return getFilesContent(context, path, currentContent); } public static String getFilesContent(Context context, String path, String currentContent) { return getFilesContent(context, path, currentContent); } public static String getFilesContent(Context context, String path, String currentContent) { return getFilesContent(context, path, currentContent); } public static String getFilesContent(Context context, String path, String currentContent) { return getFilesContent(context, path, currentContent); } public static String getFilesContent(Context context, String path, String currentContent) { return getFilesContent(context, path, currentContent); } public static String getFilesContent(Context context, String path, String currentContent) { return getFilesContent(context, path, currentContent", "reference": "A good candidate for StringBuilder? Also make sure to add white space around the operators (`path + \"/\" + file`)" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Can we have the same argument order as `getUploadedFlowFile`?" }, { "prediction": "I think it's a bug. It's a bug. It's a bug.", "reference": "this dynamic config should still be valid, i.e. operator should have the ability to control each individual task queue just in case" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "Should these cases be logged? `if not obj` used to be" }, { "prediction": "I'm not sure if this will work for you, but I'm not sure if this will work for you.", "reference": "Is it OK to assume that keys.gnupg.net has the new key?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug, and it's a bug.", "reference": "A note for however is curious. I think these two notes add negative value only. In general we want people to implement this method (in particular after this patch). If we leave these old (and currently mis-rendered) notes, file system implementors might not implement this method referring to this." }, { "prediction": "I'm not sure this is a bug, but it's a bug, and it's a bug.", "reference": "Comparators (or functions in general) cannot be compared for equality. Therefore `PriorityQueue.of(comparator,...)` always has to return a new instance." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "It's a little surprising that CachedThreadPool overrides the max_threads argument. This makes sense as a solution though." }, { "prediction": "If you want to reduce the loss, you can use the `reduce_loss` function instead: def reduce_loss(loss, reduction=None): if reduction is None: return loss else if reduction =='mean': return loss else if reduction == 'none': return loss else if reduction == 'none': return loss else: raise ValueError('avg_factor can not be used with reduction=\"none\"') return loss else: raise ValueError('avg_factor can not be used with reduction=\"none\"') return loss else: raise ValueError('avg_factor can not be used with reduction=\"none\"') return loss else: raise ValueError('avg_factor can not be used with reduction=\"none\"') return loss + # if avg_factor is specified, reduce the loss sum by avg factor + elif reduction =='mean': loss = loss.sum() / avg_factor + elif reduction == 'none': + loss = loss.sum() / avg_factor + elif reduction == 'none': + loss = loss.sum() / avg_factor + elif reduction == 'none': + loss = loss.sum() / avg_factor + elif reduction == 'none': + raise ValueError('avg_factor can not be used with reduction=\"none\"", "reference": "```python # if avg_factor is not specified, just reduce the loss if avg_factor is None: loss = reduce_loss(loss, reduction) else: # if reduction is mean, then average the loss by avg_factor if reduction =='mean': loss = loss.sum() / avg_factor # if reduction is 'none', then do nothing, otherwise raise an error elif reduction!= 'none': raise ValueError('avg_factor can not be used with reduction=\"sum\"')" }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this. I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "`padding` should be 0 instead. Actually you can just remove padding and dilation to use default values." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "$balance is initialized to 0 above in line 1428 and then assigned in line 1437. If we're no longer manipulating that value, is there a reason to use a variable at all? It might make the overall code less confusing to make some changes there." }, { "prediction": "I think this is what you are looking for. I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "Why do we need to explicitly use keyword arguments?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Might still want to log this as `TargetBuilding` but with a slightly different message?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "ref. above, this also can be omitted in case `txt = std::move(other.txt);` could work (or copy), consider `std::array;`? or a custom object implementing `Object& operator=(Object&&) noexcept;'" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Well done, we forget that one apparentely." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Guess it isn't used. The dask thing was just a prototype so removing it is probably the right thing to do." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "This code is correct, but it's a bit confusing to see how (e.g., without the if startswith(\".') the or below would break.) I think it will be clearer for the long run if you refactor this just a bit. CONTENT_INDEX_EXTS (all caps) looks like a constant, but is now being set by the environment. Instead, replace the reference to CONTENT_INDEX_EXTS in index.py with a simple call to a method \"get_content_index_exts\" (or similar). Then you can write all the logic into one clean function." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "please update the zms conf file to have a small description of these options since by default feature is off and must be enabled" }, { "prediction": "The `lazy` and `waitForThumbnailsBeforeUpload` options are mutually exclusive. Please ensure that `lazy` and `waitForThumbnailsBeforeUpload` are set to `true`. If `lazy` and `waitForThumbnailsBeforeUpload` are set to `false`, `waitForThumbnailsBeforeUpload` will be set to `false`. If `waitForThumbnailsBeforeUpload` is set to `false`, `waitForThumbnailsBeforeUpload` will be set to `false`. If `waitForThumbnailsBeforeUpload` is set to `false`, `waitForThumbnailsBeforeUpload` will be set to `false`. If `waitForThumbnailsBeforeUpload` is set to `false`, `waitForThumbnailsBeforeUpload` will be set to `false`. If `waitForThumbnailsBeforeUpload` is set to `false`, `waitForThumbnailsBeforeUpload` will be set to `false`. If `waitForThumbnailsBeforeUpload` is set to `false`, `waitForThumbnailsBeforeUpload` will be set to `false`. If `waitForThumbnailsBeforeUpload` is set to `false`, `waitForThumbnailsBeforeUpload` will be set to `false`.", "reference": "Should be `this.opts` instead of `defaultOptions`" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "You can reuse `USERS` above as well." }, { "prediction": "I'm not sure if this is the case, but if it's the case, then it's the case.", "reference": "Whoa, was this opto breaking something? I guess if this final path is filtered out, we still need the queue? Have you run the suggest benchmarks to see if removing this opto hurt performance?" }, { "prediction": "I'm not sure if this is a Seq or a Seq or a Seq or a Seq but I'm not sure if it's a Seq or a Seq or a Seq or a Seq or a Seq or a Seq or a Seq or a Seq or a Seq or a Seq or a Seq or a Seq or a Seq or a Seq or a Seq or a Seq is a Seq or a Seq or a Seq is a Seq or a Seq or a Seq or a Seq is a Seq or a Seq or a Seq is a Seq or a Seq or a Seq is a Seq or a Seq or a Seq is a Seq or a Seq or a Seq is a Seq or a Seq", "reference": "I'm not sure about this, please check the usages. It's only used currently to reverse it, maybe we should eliminate this method completely instead." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "Since this is only used in the MyResearchController, does it need to be placed at the AbstractBase level?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "why `PhaseSelector`?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Does` AllowlistedModules` have the same meaning of `WhitelistedModules`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I missed the $preserve_keys=true case when adding this to Phan. For psalm, two separate signatures may make sense" }, { "prediction": "I'm not sure if this is the issue, but I'm not sure if it's the issue, but I'm not sure if it's the issue, but I'm not sure if it's the issue.", "reference": "TcpServer will be created for each HighwayServerVerticle instance so the counter number in server is not correct." }, { "prediction": "We should be careful, in case Windows has ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~", "reference": "Why change this from a foreach? I can't see it gaining anything here and code styles shouldn't change just for the sake of it." }, { "prediction": "I think this is a bug. It should be fixed in the latest release.", "reference": "I'd say \"cgroup2 hybrid path\" instead." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I dont see a reason to print URI for `Target`. we do not expose that in inventory v1" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Do we still need this?" }, { "prediction": "I think this is what you are looking for: https://developers.google.com/analytics/devguides/collection/protocol/v1/parameters#ds https://developers.google.com/analytics/devguides/collection/protocol/v1/parameters#ds https://developers.google.com/analytics/devguides/collection/protocol/v1/parameters#ds https://developers.google.com/analytics/devguides/collection/protocol/v1/parameters#ds https://developers.google.com/analytics/devguides/collection/protocol/v1/parameters#ds https://developers.google.com/analytics/devguides/collection/protocol/v1/parameters#ds https://developers.google.com/analytics/devguides/collection/protocol/v1/parameters#ds https://developers.google.com/analytics/devguides/collection/protocol/v1/parameters#ds https://developers.google.com/analytics/devguides/collection/protocol/v1/parameters#ds https://developers.google.com/analytics/devguides/collection/protocol/v1/parameters#ds https://developers.google.com/analytics/devguides/collection/protocol/v1/parameters#ds https://developers", "reference": "`campaignSource` is unused (from `structcheck`)" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "we should discuss how to not hard-code this version" }, { "prediction": "I'm not sure if this is a ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````", "reference": "do we have a doclet for this event?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Why don't we want to catch segfaults by default?" }, { "prediction": "CancellationToken cancellationToken = new CancellationToken() { CancellationToken = new CancellationToken() { CancellationToken = new CancellationToken() }; };", "reference": "You could probably dispose request & content if you `await` the SendAsync." }, { "prediction": "This should pass to_clipboard, but it doesn't.", "reference": "why is this test case here? this file is for testing functionalities in utils.py" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this.", "reference": "why do we have an env var for this? not sure why we'd want to suppress welcome emails but not any others" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "drop the todo?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Maybe use { } here like we are most other places now." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "I want to get PartitionData field type, I don't know how to get it in other way." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I think that a single `Get` method would be preferable, that would have the following parameters: Get(addr basics.Address, withPendingRewards bool, cidx basics.CreatableIndex, ctype basics.CreatableType) where we ignore cidx of -1, and adding support for ctype of \"AssetParams\" or something like that. (i.e. so that this Get call would be good for asset holding/asset params and applications )" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "This can handle the '\\\\' problem, but if (not possible) the user define '\\\\' as null, this logic will break. So here, it should be to compare the whole HIVE_DEFAULT_NULL_STRING, and make sure length is equal, as I understand. \\N is NULL, but \\NA is not NULL, what will happen if there is \\NAA?" }, { "prediction": "I think this is what you're looking for.", "reference": "Hmm, I would think that anyone who can edit the request should be able to delete the observation, in case they accidentally add the wrong person or something." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I know we are doing this other places already. It would be good to refactor this and the paginable publicly_visible so that we are DRY. Can wait until after MVP though when we do general cleanup" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "I think this should read \"is always observed before\" or \"is never observed after\"." }, { "prediction": "You may not use this file except in compliance with the License. You may not use this file except in compliance with the License. You may not use this file except in compliance with the License. You may not use this file except in compliance with the License.", "reference": "You might consider adding yourself as an author of the class." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "If this fails, then'stderr' is not a valid file handler anymore, and then any further 'write' operations will fail. Maybe some handling of such situation should be added here?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure.", "reference": "Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "I think your indentation is wrong here." }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "UT spotted that we weren't marking routes dirty when they targeted at Node and that node's IP changed. e.g., the case where a WEP appears in the syncer before the corresponding node does, so we don't know the node's IP. I added a new map to track the CIDRs for each node so that when the node IP changes we can mark those CIDRs dirty. Right now it's only used for the \"WorkloadIPs\" scenario. Need to decide if the same issue applies in the \"CalicoIPAM' case. I suspect it might. It looks like we have some logic present to detect when our own node IP changes, but we don't seem to handle when a remote node's IP changes." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Given this will 'pause' bolt for a few seconds on older rubies, perhaps emit a debug message saying \"Warming up OpenSSL\" or something to that effect" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "Initializing _format to None, but asserting that it's not None later, seems unnecessarily fragile. We shouldn't architect the package class to rely on classes or methods that use it (e.g., build). Let's at least set the format to the default in case we don't create all packages through build.py." }, { "prediction": "@see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.WebDriver.Timeouts */ @see org.openqa.selenium.", "reference": "This change should also probably go into the corresponding method of the abstract By class?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Should this be set to something else?" }, { "prediction": "@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @@ -0,0 +1 @", "reference": "Whats up with this? It looks like this is rendered on purchases/new for subscribers, so it would result in a dead end?" }, { "prediction": "The set_ids method requires a `backend` argument. The `backend` argument can be omitted if the `backend` argument is omitted.", "reference": "Glad to see this generalized to support the backend argument." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "`ctx` is unused in ListDeploymentChains" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "I'd say the format like `\"xxx: %w\"` is more convention when wrapping an error basically. You refered to anything like this?" }, { "prediction": "I'm not sure if this is intentionally short, but I'm not sure if it's intentionally short, or if it's intentionally short, but I'm not sure if it's intentionally short, or if it's intentionally long enough, or if it's intentionally long enough, I'm just guessing that it's intentionally long enough.", "reference": "This seems relatively high, is it the recommended value from the etcd folks? Or is this debugging cruft?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "This requires updating the name in the `endpoints` tests, please run `make test`." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "LOG(FATAL) means coredump, LOG(ERROR) is better here." }, { "prediction": "I'm not sure if this is the case, but I think this is what you're looking for.", "reference": "/javascript/firefox-driver is the Selenium implementation of a WebDriver for Firefox. Since it generally isn't W3C compatible, it shouldn't change. We can just drop this change." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "It's a bit weird to have `svc.go` to include a `ScheduledJobType`...should we rename this file?" }, { "prediction": "The MIT License (MIT) should be removed.", "reference": "For some reason `protoc` doesn't copy license header from `proto` files to generated code. But this code will never be checked in, so it is ok." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "I don't know what the implications of this change are for pumps other than the insight but i would add `|| trList2.get(0).pumpId == temporaryBasal.pumpId` in case we see the same pump event again, in order to not duplicate it in the database." }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if it's the correct way to do it, but it's the correct way to do it.", "reference": "is there anything still referencing `checksumAddress` or can we just delete it?" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "The reason I didn't suggest it before is because I didn't want alerts for every tried - but not updated provision, but I can see a value in it from OSD perspective" }, { "prediction": "I'm not sure if this will work, but I'm not sure if this will work.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "I believe Key is not necessarily nil, it could be empty string. Probably better check a.Kind == Create" }, { "prediction": "CancellationToken cancellationToken = new CancellationToken(CancellationToken.CancellationTokenKind.None, CancellationToken.CancellationTokenKind.None, CancellationToken.CancellationTokenKind.None, CancellationToken.CancellationTokenKind.None, CancellationToken.CancellationTokenKind.None, CancellationToken.CancellationTokenKind.None, CancellationToken.CancellationTokenKind.None, CancellationToken.CancellationTokenKind.None, CancellationToken.CancellationTokenKind.None, CancellationToken.CancellationTokenKind.None, CancellationToken.CancellationTokenKind.None, CancellationToken.CancellationTokenKind.None, CancellationToken.CancellationTokenKind.None, CancellationToken.CancellationTokenKind.None, CancellationToken.CancellationTokenKind.None, CancellationToken.CancellationTokenKind.None, CancellationToken.CancellationTokenKind.None, CancellationToken.CancellationTokenKind.None, CancellationToken.CancellationTokenKind.None, CancellationToken.CancellationTokenKind.None, CancellationToken.CancellationTokenKind.None, CancellationToken.CancellationTokenKind.None, Can", "reference": "This is only used for headers and therefore isn't used." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Wouldn't it make sense to add a files_import_command and a db_import_command, which could be empty? I guess that leads to potential backward-compatibility problems, but it's worth thinking about. Perhaps add an import-api version to solve that? Overall, I think the actual db import logic and files import logic should be moved into the yaml file. What you you think of that?" }, { "prediction": "This file is autogenerated via the builtin command.", "reference": "Why do we have this here? I'm not concerned about it really, just curious." }, { "prediction": "I'm not sure if this is what you're trying to do, but it's worth noting that you're trying to change the value of a TEAL byte slice to a Uint, so it's not possible to change the value of a TEAL byte slice to a Uint, so it's not possible to change the value of a TEAL byte slice to a Uint, but it's possible to change the value of a TEAL byte slice to a Uint, so it's not possible to change the value of a TEAL byte slice to a Uint.", "reference": "@justicz Why are these switched here?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Maybe verify that an anchor was created -- that the markdown was processed?" }, { "prediction": "I'm not sure if it's a bug, but if it's a bug, it's a bug.", "reference": "Is this just a minor improvement or is it necessary? If just some minor improvement, I recommend you don't touch Lucene in a Solr PR." }, { "prediction": "I'm not sure if this is the correct way to do it, but it's the correct way to do it, and it's the correct way to do it.", "reference": "why delete this method?" }, { "prediction": "This is a ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Does this transform only the `MethodContext`, or also the `OutputContext`? (Looking at the other files, I gather it's the latter.) Might be helpful to mention that here." }, { "prediction": "I think this is what you're looking for: https://www.gnu.org/licenses/gpl-2.0.html # Copyright (C) 2009-2018 NV Access Limited, Aleksey Sadovoy, James Teh, Joseph Lee, Tuukka Ojala # Copyright (C) 2009-2020 NV Access Limited, Aleksey Sadovoy, James Teh, Joseph Lee, Tuukka Ojala # This file may be used under the terms of the GNU General Public License, version 2 or later. # For more details see: https://www.gnu.org/licenses/gpl-2.0.html", "reference": "Could you please clean-up this line while at it?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "no need to use a pointer. Just string and check for!= \"\"" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "this means h2 mode? but how h2c can work?" }, { "prediction": "I think this is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is a bug. It is fixed.", "reference": "This line should not be there" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "why do we need lock here? if needed, then we also need to lock in Start()?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "this should be on default-switch, uhm? else you will handle twice (c++ and lua). I'm just saying..." }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "unrelated minor fix" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure.", "reference": "can you add `, echo: false` to the end of this as well. I don't think we need to echo this to the log. You might need to update the spec as well." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "This test does not really verify that we're doing the correct thing now, is it? It seems to pass with and without the patch." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "should just be able to defer the call directly here too" }, { "prediction": "I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "Is this a magic number? I assume this makes it look better." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Would welcome a stringification method on big.Int in specs-actors" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "PersistBlockLevelInfo -> UpdateBlockLevelInfo" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Type is redundant since it is inherited." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "better use `!isView()` so that we don't need to modify multiple lines in future." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "I know you don't usually open up the singleton class, but I was getting a `private method called` error when trying to use `self.attr_writer` - any idea?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if", "reference": "There's no need to create a new variable here, the other checks just use the item type directly." }, { "prediction": "I think this is what you're looking for.", "reference": "Any other possible names? Feels like going with \"workshop\" for this product_type could increase the confusion between course/workshop in the codebase." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug. I'm not sure what you're trying to do, but I think it's a bug.", "reference": "@eugene-manuilov Isn't this already taken care of by `fetchGetURLChannels` via `createFetchStore`? Why is the extra `receiveError` call needed here? (This was already in the IB, but just struck me while reviewing here.)" }, { "prediction": "I'm not sure if this is a bug, but it seems to be fixed in the future.", "reference": "nit: should go before `grpc`?" }, { "prediction": "@@ -71,7 +71,7 @@ func testWorkflow() *Workflow { - ctx, cancel := context.WithCancel(context.Background()) - ctx, cancel := context.WithCancel(context.Background()) - ctx, cancel := context.WithCancel(context.Background()) - ctx, cancel := context.WithCancel(context.Background()) - ctx, cancel := context.WithCancel(context.Background()) - ctx, cancel := context.WithCancel(context.Background()) - ctx, cancel := context.WithCancel(context.Background()) - ctx, cancel := context.WithCancel(context.Background()) - ctx, cancel := context.WithCancel(context.Background()) - ctx, cancel := context.WithCancel(context.Background()) - ctx, cancel := context.WithCancel(context.Background()) - ctx, cancel := context.WithCancel(context.Background()) - ctx, cancel := context.WithCancel(context.Background()) - ctx, cancel := context.WithCancel(context.Background()) - ctx, cancel := context.WithCancel(context.Background()) - ctx, cancel := context.WithCancel(context.Background()) - ctx, cancel := context.WithCancel(context.", "reference": "Why not using the Cancel? I thought cancelling a \"parent\" context would cascade to \"children\" contexts, cancelling them as well. In short, how does cancel work?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case. I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "Could you explain why we default to binary now? It seems it's safer to default to text to avoid stuff getting executed or parsed by browsers accidentally. If we need to add support for particular types, we can add them explicitly right?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Bit worried about the prefix since this seem to be being used for non-Openstack data too (host endpoints). Should we just leave host endpoint status at the old path (or remove it since AIFAIK, it's not used anywhere)?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This might be a silly question, but what happens to files with durations > 24 hours?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to use a TracerProviderBuilder instead of a TracerProviderBuilder. I'm not sure what you're trying to do here, but I'm guessing you're trying to use a TracerProviderBuilder instead of a TracerProviderBuilder. I'm guessing you're trying to use a TracerProviderBuilder.AddDiagnosticSourceInstrumentation(this TracerProviderBuilder tracerProviderBuilder, - Func instrumentationFactory) + Func instrumentationFactory) where TInstrumentation : class { if (instrumentationFactory == null) { instrumentationFactory = new ActivitySourceAdapter(this); } return instrumentationFactory.AddDiagnosticSourceInstrumentation(this, instrumentationFactory); }", "reference": "`AddDiagnosticSourceInstrumentation` method can now be eliminated and simply use `AddInstrumentation`" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "I think we also need to add `name:` to the bolt-project.yaml files in `spec/fixtures/projects`." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "worth mentioning the same warning here as in `md_util.go`, I think." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "Do we need both the checks, for `Items` not nil and `len(Items)`" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Do you know what this is coming from? It keeps getting deleted/created @nickbristow" }, { "prediction": "ICEBERG_CATALOG_TYPE_HADOOP = \"hadoop\"; ICEBERG_CATALOG_TYPE_HIVE = \"hive\"; ICEBERG_CATALOG_TYPE_HIVE = \"hive\"; ICEBERG_CATALOG_TYPE_HIVE = \"hive\"; - public static final String HIVE_URI = \"uri\"; - public static final String HIVE_CLIENT_POOL_SIZE = \"clients\"; public static final String HIVE_CONF_DIR = \"hive-conf-dir\"; - public static final String WAREHOUSE_LOCATION = \"warehouse\"; - public static final String DEFAULT_DATABASE = \"default-database\"; ICEBERG_CATALOG_TYPE_HADOOP = \"hadoop\"; ICEBERG_CATALOG_TYPE_HIVE = \"hadoop\"; ICEBERG_CATALOG_TYPE_HIVE = \"hive\"; ICEBERG_CATALOG_TYPE_HIVE = \"hive\"; ICEBERG_CATALOG_TYPE_HIVE = \"hive\"; ICEBERG_CATALOG_TYPE_HIVE = \"hive\"; ICEBERG_CATALOG", "reference": "Nit: leaving these in place would have reduce the number of files that this needed to touch, and avoided a possible problem removing public fields. I don't think it's worth blocking for this change, but we like to keep patches as small as possible by not breaking references like these." }, { "prediction": "I think this is a bug in E_USER_DEPRECATED. It should be fixed in E_USER_DEPRECATED. See https://github.com/E_USER_DEPRECATED/blob/master/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED/E_USER_DEPRECATED.", "reference": "`The %s is deprecated...` -> `The %s method is deprecated...`" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "No, it wouldn't go there because that code won't reference or enforce it. Here is ok for now." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "How will we show that test run aborted (because of a crash) if we don't set aborted to true?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug.", "reference": "Nit: Might as well make this same change to AdaptedPipeline." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'll report it here.", "reference": "Just to clarify: I see that only the hive2 withZone object inspector is changed. Does that mean that the predicate pushdown problem only occurred on hive2?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Based on username requirements for forge.puppet.com - only letters and digits permitted." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here.", "reference": "Was this removed to ignore the extra columns coming from the file projection?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Please can you pull out the shared function into a shared file? I think that'd be pretty easy to do for this module. I think you could: - pull out a function `configureSyslog` that is implemented on Linux, but stubbed on Windows - pull out a function `openLogFile` that is implemented differently on each - share everything else" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Instead of hardcoding the AWSEmailProvider here, it should come from properties, so that it can be replaced with another EmailProvider for ZMS vs ZTS" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to create a new account, so I'm not sure what you're trying to do here. I'm guessing you're trying to create a new account, but I'm not sure what you're trying to do here.", "reference": "+1 for creating this script to help people get boot strapped" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Do you need the prefix?" }, { "prediction": "I'm not sure what you're trying to do, but it seems like you're trying to do something like deleteFromTextTable(&cliInterface, + objUID, + ComTextType::COM_OBJECT_COMMENT_TEXT, + 0); I'm not sure what you're trying to do, but it seems like you're trying to do something like deleteFromTextTable(&cliInterface, + objUID, + ComTextType::COM_OBJECT_COMMENT_TEXT, + 0);", "reference": "if retcode is < 0, it should return -1 indicating an error." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, and it's a bug.", "reference": "Are those necessary? I feel like `useless-suppression` could be avoided here?" }, { "prediction": "I'm not sure if this will work, but I'm not sure if this will work, but I'm not sure if this will work, so I'm not sure if this will work.", "reference": "Is this equivalent in JavaScript?" }, { "prediction": "I'm not sure if this is the case, but it seems to be the case, so I'm not sure if this is the case, but I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "get/list operation is not schema change, it is supposed to use VLOG" }, { "prediction": "I'm not sure if this is what you're looking for, but if it's what you're looking for, it's a good idea to use a ReadOnlySpan> instead of a ReadOnlySpan>. I'm not sure if this is what you're looking for, but it's a good idea to use a ReadOnlySpan> instead of a ReadOnlySpan> instead of a ReadOnlySpan> instead of a ReadOnlySpan>.", "reference": "we'll need to delete this whole file, right?" }, { "prediction": "The IsolationLevel of a Transaction is the default value of the IsolationLevel of a Transaction. The IsolationLevel of a Transaction is the default value of the IsolationLevel of a Transaction. The IsolationLevel of a Transaction is the default value of the IsolationLevel of a Transaction. The IsolationLevel of a Transaction is the default value of the IsolationLevel of a Transaction. The IsolationLevel of a Transaction is the default value of the IsolationLevel of a Transaction. The IsolationLevel of a Transaction is the default value of the IsolationLevel of a Transaction. The IsolationLevel of a Transaction is the default value of the IsolationLevel of a Transaction. This means that if we are in a context of a context of {@code READ_COMMITTED}, this refresh will update to the latest state + * of the table. However, in the case of {@code SERIALIZABLE} where this table hasn't mutated + * within this transaction, calling refresh will have no impact as the IsolationLevel of a Transaction is the default value of the IsolationLevel of a Transaction. The IsolationLevel of a Transaction is the default value of the IsolationLevel of a Transaction.", "reference": "\"this table hasn't mutated within this transaction\" may sound like implying that if this transaction contains table mutation changes, `refresh` may have impact, which I think is not true? I guess what you were saying was if other transactions committed to this table successfully when this transaction is half way through, refresh in this transaction will still return the same state as when this transaction begins." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Can we move these into some kind of experimental API group? I don't think we want to call them `v1` just yet :)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I think this makes a lot of sense but we may want to highlight the change for people doing UAT in case the ordering of sections is off anywhere when customizing or using the drag-drop feature" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "These files should in `/javascript/brython`" }, { "prediction": "This is a bit unclean, but works properly, since the packet always // begins with the public header and we never copy it.", "reference": "I'm not sure this is the right fix - I'd be more happy with a `continue`. That way, we don't enter the code at the bottom of the run loop (e.g. sending packets). Keep in mind that this error here may be triggered by a peer doing something security-relevant, so I don't think we should do much more work other than sending the close frame." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm sure it's what you're trying to do.", "reference": "Can we fix this, or is it going to stay broken." }, { "prediction": "I think this is a bug in Postgresql. See https://github.com/postgres/postgres/issues/497", "reference": "Is there a reason to remove this attr?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "log message should be started with upper-case word." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "I guess this is not needed anymore now?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I think I would prefer retaining the argument. It's true that we are not using it now, but it's harmless, it's good to have a constructor function that accepts all the field values as arguments. Performance-wise, it does not matter." }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "Is this a different fix?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "Why not add a `EnterNS` filed instead of `WithoutNS`?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Same points as in other test file." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "I have a PR pending, can you change this bit index to `16`?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug.", "reference": "we should probably have some utility class for this sort of things" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Curious that I'm not seeing any occurrence of the new error check in this file. Why was it disabled?" }, { "prediction": "This is only implemented for React Native. It is only implemented for React Native. It is only implemented for React Native.", "reference": "does it return something?" }, { "prediction": "// If we have an error, display the NoDataComponent. if ( error ) { return ('string'!== typeof error )? error : getDataErrorComponent( moduleName, error, layoutOptions.inGrid, layoutOptions.fullWidth, layoutOptions.createGrid, data ); } // If we have an error, display the NoDataComponent. if ( error ) { return ('string'!== typeof error )? error : getDataErrorComponent( moduleName, error, layoutOptions.inGrid, layoutOptions.fullWidth, layoutOptions.createGrid, data ); } // If we have zeroData, display the NoDataComponent. return ('string'!== typeof error )? error : getDataErrorComponent( moduleName, error, layoutOptions.inGrid, layoutOptions.fullWidth, layoutOptions.createGrid, data ); }", "reference": "This function is also called in various Site Kit module components, where the error object (here `data`) also needs to be passed, otherwise the link to fix the issue won't appear." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "super nit: `revision string` (the passed value might not be a SHA hash)." }, { "prediction": "Is this layout thread-agnostic? Is this layout thread-agnostic? If so, is this layout thread-agnostic? If so, is this layout thread-agnostic? If so, is it thread-agnostic? If so, is it thread-agnostic? If so, is it thread-agnostic? If so, is it thread-agnostic? If so, is it thread-agnostic? If so, is it thread-agnostic? If so, is it thread-agnostic? If so, is it thread-agnostic? If so, is it thread-agnostic?", "reference": "@snakefoot why is internal needed?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Why were we disabling health checks before?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "did `conftest.py` actually show up for you? `test_files` should never contain it..." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Should this be a! on line 565? I would have expected the condition to be similar to line 564. If I am wrong please excuse my mistake." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "Please change to `1070400`. I promise to look into this PR in more detail before the 1.7.4 release ;)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Can we change to use `LogicalType.getChildren`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "I'm confused as to how these are both passing." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Prefer single-quoted strings when you don't need string interpolation or special symbols." }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to create a new class for each category, so it's not a good idea to create a new class for each category. I'm not sure what you're trying to do here, but it seems like you're trying to create a new class for each category, so it's not a good idea to create a new class for each category, so it's not a good idea to create a new class for each category, so it's not a good idea to create a new class for each category, so it's not a good idea to create a new class for each category.", "reference": "there is `\"` sign in commit message and colon. can you rename also `descrition` to plural `descriptions` and add there `$`?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "timerNoUserLatency is not being used?" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to parse a date, so I'm not sure what you're trying to do. I'm assuming you're trying to parse a date, so I'm not sure what you're trying to do. I'm assuming you're trying to parse a date, but I'm not sure what you're trying to do.", "reference": "@lmazuel - I've made a couple of minor changes to serialization.py, if you could do a quick review :) They should not be breaking, and I doubt are used by the existing clients so may not need a new release yet. Effectively it's a change to support default/constant date and datetime values by allowing strings to passed in instead of date or datetime objects. The strings would need to already be in the correct ISO formatting that the request will serialize to. Let me know if you think this is okay." }, { "prediction": "I'm not sure if this is the correct syntax, but I'm not sure if it's the correct syntax, but I'm not sure if it's the correct syntax.", "reference": "Why change the name in the XML?" }, { "prediction": "I'm not sure what you're trying to do here, but I think it's a good idea to have a `before_update` or `after_update` method.", "reference": "This is much cleaner. makes it easier to tell what happens on a save." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Could you add return error unsupported operator here" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "(Mhh, we seem to use different formatters - we should unify them. I like the wildcards)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Should `kind` be a command line parameter also?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "can we have it inside FromAccessList?" }, { "prediction": "This error is generated when we use the ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Why not embed filterASCII in this function?" }, { "prediction": "I'm not sure if this is the correct way to do this, but it should be something like this:", "reference": "I am curious, shouldn't \"currentContinuousFlowProcessed++;\" be added right after line 1873? otherwise we will count 1 extra when a exflow wakes up from the sleep section,.even though it hasn't been assigned" }, { "prediction": "I'm not sure what you're trying to do here, but I think it's a good idea to check if the type is a string, and not a string.", "reference": "You can probably move this up after the `._Numeric` line." }, { "prediction": "I don't think this is a bug, but it's a bug in the SGEJobTask class. I'm not sure if it's a bug, but it's a bug in the SGEJobTask class.", "reference": "@Tarrasch this is another change you need to pay attention, it seems `SGEJobTask` is not calling `super.__init__` which break the test case some how." }, { "prediction": "I think this is what you're looking for.", "reference": "Do we need indices for this table?" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "what about making this function static inline to avoid the extra declaration?" }, { "prediction": "@ -21,6 +21,7 @@ import ( type protocol = string type TableIDType uint8 +type GroupIDType = uint32 const LastTableID TableIDType = 0xff )", "reference": "I forget the difference between type definition with \"=\" and without \"=\" again, but can we unify the style? I believe the difference doesn't apply to TableIDType and GroupIDType whatever it is?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "would be `DEPRECATED Percentage of the graph (in vertices) to contract [0..1]` better?" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, then it's a good idea to use the \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \" \"", "reference": "These command names are specific to Chromium-based browsers. Please move to `ChromiumDriverCommand`" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "if we won't use, should we remove this?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "Having 2 items with the same key (Mvx) won't work in a dictionary" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "@cpytel how does the flow work right now? I expect to go to the sign up as customer page after putting in my code, but it goes to the longer landing page?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "`event_msg` has the same size (1024) as a `message`. Maybe should be increased to 2048 instead? Then this `\"[error] %.512s\", message` could be changed to this: `\"[error] %.*s\", sizeof(message), message`" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Nit: unnecessary whitespace change." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Hit a flake here where I think there may have been some output to stderr that got mixed in with the output from Stdout. Hence switching to `Output()`, which does also capture stderr as `err.Stderr`" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "I would use static_cast(0) and static_cast(m_num_labels) just in case." }, { "prediction": "public static String lowerDomainInResource(String resource) { if (resource == null) { return null; } if (resource.indexOf(\"\") == -1) { return resource; } if (resource.indexOf(\"\") == -1) { return resource; } if (resource.indexOf(\"\") == -1) { return resource; } if (resource.indexOf(\"\") == -1) { return resource; } if (resource.indexOf(\"\") == -1) { return resource; } if (resource.indexOf(\"\") == -1) { return resource; } if (resource.indexOf(\"\") == -1) { + return resource; + } + + String lowerCasedDomain = resource.substring(0, delimiterIndex).toLowerCase(); + return lowerCasedDomain + resource.substring(delimiterIndex); + }", "reference": "Even if we want to keep in original case - domain will be lower-cased." }, { "prediction": "I think this is what you're looking for.", "reference": "Based on discussion with Chad it feels like trail_map_json could be a good column name." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This array should be logic-less, just the language string (without `Lang::get()`) should appear. Then `trans()` is [or should be] used when the balloon selector renders the values." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "This looks like it runs both pre 3.0 rake tasks and 3 rake tasks, and since pre 3.0 we didn't use bundler, my guess is it will fail then." }, { "prediction": "We can't use the systemd device support because of two missing things: ```````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````", "reference": "I'm not sure the replacement is a good idea, and as I said in #336, this \"parent-name.scope\" is not a good idea in the first place, specially when we support assigning a slice as the parent, so we should change this, WDYT?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if it's the correct way to do it, but it's the correct way to do it.", "reference": "sloppyReassign: re-assignment to `err` can be replaced with `err := kv.WriteBatch(batchForBlock)` (from `gocritic`)" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "using factory method. return CompletableFuture.completedFuture" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for, so I'm not sure if this is what you're looking for.", "reference": "The `_x` function needs to be imported at the top of the file (in addition to `__`)" }, { "prediction": "The Flow.Table field can be updated by Reset(), which can be called by // ReplayFlows() when replaying the Flow to OVS. For thread safety, any access // to Flow.Table should hold the replayMutex read lock. - ofctrl.Flow + *ofctrl.Flow // matchers is string slice, it is used to generate a readable match string of the Flow. matchers []string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string `string", "reference": "this looks like the only controversial change potentially. @MatthewHinton56 Could let us know why you made this change (which `go vet` warning was triggered)? @wenyingd could you take a look and let us know if you're okay with this change?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This seems like left-over debugging code. I think I fixed this to no longer be necessary, switching to UserControl for the designer." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think this is what you're trying to do.", "reference": "As we're currently not applying any logic in the proxy listener, I guess we can simply remove this file (and remove the `listener` argument from the `register_plugin(..)` call above)." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug. I'm not sure what you're trying to do, but it's a bug.", "reference": "Isn't the point of the clock module to encapsulate access to `time.Now()`? Coming later?" }, { "prediction": "I think it's a bug in the code you're using. It's a bug in the code you're using.", "reference": "as before - if you've set this, you should be able to get rid of the `os.Setenv(\"ALGOSMALLLAMBDAMSEC\", \"500\")`. make sure that the various tests still takes have the same execution time." }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to install a MacTeX binary package, and you're trying to install a MacTeX binary package, so I'm not sure what you're trying to do. If you're trying to install a MacTeX binary package, you'll need to install a MacTeX binary package first. If you're trying to install a MacTeX binary package, you'll need to install a MacTeX binary package first. - sh.cmd 'wget http://mirror.ctan.org/systems/mac/mactex/'\\ - \"#{mactex} -O \\\"/tmp/#{mactex}\\\"\" + sh.cmd 'curl -fLo \\\"/tmp/#{mactex}\\\" --retry 3 http://mirror.ctan.org/systems/mac/mactex/'\\ + '#{mactex}' sh.echo 'Installing OS X binary package for MacTeX' sh.cmd \"sudo installer -pkg \\\"/tmp/#{mactex}\\\" -target /\" + sh.cmd 'wget http://mirror.ctan.org/", "reference": "Pretty sure the single quotes here should be double quotes, single quotes are not expanded by the shell." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "these are not really constants, right?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "import below copyright statement" }, { "prediction": "I think this is what you're looking for.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "`if (is_string($value) && $this->getDefinition()->get('allow_html')) {`" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "I think we have the same problem here - if folks called the `public void Add` with a `null` key, we need to use `Guard`." }, { "prediction": "This is not part of the RDKit source tree. It is part of the RDKit source tree. It is not part of the RDKit source tree. It is not part of the RDKit source tree. It is part of the RDKit source tree.", "reference": "I thought that the main was in catch_qt.cpp?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "I would rename the field to IMAGE_TYPES and make it an array. I don't think we need list operations. Also, if possible, I would move the field to the ApiFields class. What do you think?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here, but I'm guessing you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "I'd prefer to timeout on this, but I know it's not a pattern that is being followed" }, { "prediction": "I'm not sure this is a bug, but it's a bug. It's a bug.", "reference": "hmm let's not use * imports please" }, { "prediction": "I'm not sure if I'm missing something, but I'm not sure if I'm missing something.", "reference": "is this configuration key already exist in prometheus?" }, { "prediction": "I think this is what you're looking for.", "reference": "As @gravitystorm said new tests need to be using factories, not fixtures." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure what you're trying to do.", "reference": "You can replace IP by hostname." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case.", "reference": "This should say \"why\" NVDA should do things in this order." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "nit these will get changed back during next release." }, { "prediction": "The Swarm Authors is governed by a BSD-style license that can be found in the LICENSE file.", "reference": "it is actually not needed to make the member public. the build tags can also set a package scoped variable." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "We already have a method for it 'icon' => $content->getIcon()" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Instead of importing `golang.org/x/net/context` The SDK should use `aws.BackgroundContext()` instead of `context.Background()`" }, { "prediction": "I think this is a bug. It should be fixed in the latest version.", "reference": "I think this is an agnostic change for the ORM right? Why was it doing this? - this does not work on PHPCR-ODM as the `id` is not a field - although I guess it could be mapped as such." }, { "prediction": "I think this is what you are looking for, but it's not what you're looking for.", "reference": "I'm not 100% sure, but I think this should be `explorable`. If not, I think `explorable` can be removed entirely." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to write to a file that doesn't exist.", "reference": "Note to self: Why was this not originally not using `stderrbytes`?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "Is betterLOG_IF(ERROR, status!= 0)?" }, { "prediction": "I think this is what you're looking for. I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "I wouldn't call it default too." }, { "prediction": "This will be removed soon by a Vue component.", "reference": "Why disable the rule for this file?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this: I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "Thanks for adding this :+1:. Could you please move it to go after the `ctaLink` prop?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "The other way around Current can be null." }, { "prediction": "I think this is what you are looking for.", "reference": "why does it have to be here? Due to breadcrumb navigation?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "I fear moving this to some common func. We are swallowing the error here. This might be ok in UT but not in actual source code." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here. I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here. I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here. I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here. I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "Please don't use \\ as a line continuation. Do an implicit string join instead with parens: ``` (\"Message...\" \"and...\")" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed in the future.", "reference": "there needs to be a change here. setting up the batchstore with localstore.Unreserve hook" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "I think if we can provide a more convenient method to add configs. e.g. public static void addConfig(String k, Object v)" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "line is 165 characters" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Please add a copyright notice. Also, could you tell me please why do we need this empty provider here?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if maybePrivacyGroup.get().getMembers().contains(enclavePublicKey) is true, so I'm not sure if maybePrivacyGroup.get().getMembers().contains(enclavePublicKey) is true, so I'm not sure if maybePrivacyGroup.get().getMembers().contains(enclavePublicKey) is true or maybePrivacyGroup.get().getMembers().contains(enclavePublicKey) is true, so I'm not sure if maybePrivacyGroup.get().getMembers().contains(enclavePublicKey) is true or maybePrivacyGroup.get().getMembers().contains(enclavePublicKey) is true, so I'm not sure if maybePrivacyGroup.get().getMembers().contains(enclavePublicKey) is true or maybePrivacyGroup.get().getMembers().contains(enclavePublicKey) is true, but maybePrivacyGroup.get().getMembers().contains(enclavePublicKey).getMembers().contains(enclavePublicKey).getMembers().contains(enclavePublicKey).getMembers().contains(enclavePublicKey).getMembers().contains(enclavePublicKey).getMembers().contains", "reference": "I feel like this would be easier to read if we join the two if's together: `if (maybePrivacyGroup.isEmpty() &&!privacyController.isGroupAdditionTransaction(privateTransaction))`" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Tests are failing because the exception type is NullPointException here if the soupBlob is deleted (so instead of a mal-format json, it's a null)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Glad we fixed this as well. Blockly is going to be left as-is for this case, right?" }, { "prediction": "This class represents a typical Salesforce object. * * @author bhariharan - * @deprecated Will be removed in Mobile SDK 7.0. */ -@Deprecated public class SalesforceObject { protected String objectType; }", "reference": "I had accidentally deprecated this class. This is meant to stick around. Only `SalesforceObjectType` goes away." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "`hex(i)[2:]` is trying to do the same thing above. what is `i` in your malformed case?" }, { "prediction": "I'm not sure if this is what you're looking for, but if you're looking for something like this, you're probably looking for something like this:", "reference": "I think this change is redundant; see the previously defined method \"writeUnescapedXML\"." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for.", "reference": "Ah now I have at least some idea what these are for." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "I believe in previous PRs @mccheah frequently used `fileSchema` -> `newFileSchema` type of renames to avoid hiding fields in builders. Would it make sense to make it consistent?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug. I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Do we really need separate error in manager if utils.ErrRequestCancelled is the only error which indicates cancelation?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if this is the case, but I'm not sure if it's the case.", "reference": "Leave as `cpp` since that still gives better results." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "temp change so the predicate can be used by the `exp` package" }, { "prediction": "I'm not sure if this is a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug,", "reference": "Just as a tiny clarification, this isn't affected in any way by \"speak typed characters\". That is, \"caps lock on\", etc. is always spoken, even if speak typed characters is off." }, { "prediction": "This should be pipelined somehow. It should be pipelined somehow. It should be pipelined somehow. \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service.yaml\", \"config/manager/service", "reference": "@dgoodwin Will it cause an issue when the issue get fixed in OLM?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "This option is now unnecessary" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here.", "reference": "Don't jump down to the unexported interface: just set the content type to `\"application/octet-stream\"` explicitly when creating the `Writer`." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Instead of counting this here on clear, can we use a second counter for the deleteTerms next to `bytesUsed`? This would be great. It doesn't need to be thread safe IMO" }, { "prediction": "I think this is what you are looking for.", "reference": "@daftspunk @bennothommo I wonder if we need to go as deep as detecting what the default varchar length is with a special character to be parsed by the validation trait since we've introduced the config for it." }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it.", "reference": "Also update line 2205 below" }, { "prediction": "private static final String STATE_KEY_NUM_ATTACHMENTS_LOADING = \"numAttachmentsLoading\"; private static final String STATE_KEY_NUM_ATTACHMENTS_LOADING = \"numAttachmentsLoading\"; private static final String STATE_KEY_WAITING_FOR_ATTACHMENTS = \"waitingForAttachments\"; - + private static final String STATE_FIRST_TIME_EMPTY_SUBJECT = \"firstTimeEmpySubject\"; private static final String LOADER_ARG_ATTACHMENT = \"attachment\"; private static final String FRAGMENT_WAITING_FOR_ATTACHMENT = \"waitingForAttachment\";", "reference": "Typo, should read `firstTimeEmptySubject`" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "The more I see this the more I think the transport layer _should_ actually refer to this as `UnaryHandler`." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "The `warn` message here seems to indicate that the forced closure of the SSH connection should raise an error; is that getting swallowed up somewhere and not raising?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I wonder if this is a fitting name. Why \"expands user\"? Wouldn't be `user_expanded` or so be more fitting?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "I see what you are doing here, but to stay with the `getter/setter` pattern, should we introduce `set isHidden(value)` & `get isHidden()` which them maintains `_isHidden` with in `vNodeCache`. This will avoid what looks like accessing an internal property like `_isHidden` from `axe.utils.isHidden` & keeps things neat." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "nit: for consistency, have this line and the previous formatted similarly" }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "As before, shouldn't mention these as being orion options I don't think. Perhaps just enclaveKeyStoreFile etc." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "What's the thinking here? Only logging when the test has not ended yet?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "@HyukjinKwon @ueshin (cc @itholic @charlesdong1991 ) Not sure if this is the right implementation..." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Do we want to add any specific error on how the url is malformed?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems to be a bug.", "reference": "why NOT self->lastLogIdSent_ = self->logIdToSend_" }, { "prediction": "I'm not sure if this is the case, but it's the case. I'm not sure if it's the case, but it's the case.", "reference": "Shouldn't this be in the above `if` block where we are setting the installedtimestamp to ensure this only happens for already installed (and/or adopted) clusters?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "This seems like another unrelated change I've done in `master`." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Would be good to have another context `\"when a duplicate formatter exists for a different output target\"` that shows that it keeps both. As this stands, the specs could pass w/o the `formatter.output == new_formatter.output` check." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug in Kokkos, so I'm not sure if it's a bug, but it's a bug in Kokkos, so I'm not sure if it's a bug in Kokkos, but it's a bug in Kokkos, so I'm not sure if it's a bug in Kokkos.", "reference": "Why not just remove? The CUDA one has been around for while. This one has not been part of any release (?)" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "nit: `Contentful` is the word used in the GV API, without the uppercase in F" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "It just does the check, maybe we can name it as checkOperations." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "We no longer have karma output in the test file so these selectors were now unique and the target didn't need a child selector. Updated to force non-unique nodes" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "This moved from a partial to not being in a partial. How about cleaning this view up further by moving it back into a partial?" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "add some form of docs in docstring or on :74 for what the effect is" }, { "prediction": "I'm not sure if it's a bug, but it's a bug in kinto.core.utils.find_nested_value. I'm guessing it's a bug in kinto.core.utils.find_nested_value. I'm guessing it's a bug in kinto.core.utils.find_nested_value. I'm guessing it's a bug in kinto.core.utils.find_nested_value.", "reference": "Couldn't you import `json` from `kinto.core.utils` here too?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to run `rspec/rails` in a production environment. I'm guessing you're trying to run `rspec/rails` in a production environment, but I'm not sure what you're trying to do here.", "reference": "Minor: Hmmm...is it worth setting this explicitly for the tests that it affects?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "This was added to fix a race condition and you are reverting it here, right?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Could you add some extra text here, so that it reads \"eth_coinbase function is not available, please use --private.api.addr option instead of --chaindata option\", so that it is clear that the function can work, but different options" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "`new_ncr_work_order_path`? (I've been slowly moving specs over to that way of calling paths)" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "Should flash be included in the patterns too? It currently isn't." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "I suspect I will have to keep looking whether Left/Right refers to contract/Implementation while working on the rules code." }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "(ignore this. testing a codeflow bug)" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "[Nit] can you change the Usage wording to indicate that the flag is used to opt-out of server certificate verification? (e.g. \"disables validation of the Cassandra cluster's server certificate.\")" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Sorry :) Would be really helpful to integrate something like Eclipse Code Formatter, so it will fail if the code style is broken (the same as eslint fails on the frontend) I use IntelliJ IDEA and their vision of imports is a bit different :)" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "this will still fail on systemd" }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "The convention in most of the codebase is to use `if isinstance(body, bytes):` instead." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "I think this would be better as: `label = comp.rsplit('.', 1)[-1]`" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's not what you're trying to do. I'm not sure if this is what you're trying to do, but it's what you're trying to do.", "reference": "We have been creating a language-level context interface for each language instead of parameterizing the generate function." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Same thing about context here." }, { "prediction": "I'm not sure if this is the case, but I think it's the case. I'm not sure if this is the case, but I'm not sure if it's the case.", "reference": "there is a function to get namespace entry from mutable state directly" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "The `Transport::Config` objects don't serialize properly. We probably want to just turn them into hashes at this point." }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Sorry, typo s/unusuable/unusable/" }, { "prediction": "I'm not sure if this is a SparkSessionCatalog or a SparkSessionCatalog, but I'm not sure if this is a SparkSessionCatalog or a SparkSessionCatalog. I'm not sure if this is a SparkSessionCatalog, but I'm not sure if this is a SparkSessionCatalog or a SparkSessionCatalog. I'm not sure if this is a SparkSessionCatalog, but I'm not sure if it's a SparkSessionCatalog or a SparkSessionCatalog. I'm not sure if it's a SparkSessionCatalog, but I'm not sure if it's a SparkSessionCatalog or a SparkSessionCatalog. I'm not sure if it's a SparkSessionCatalog or a SparkSessionCatalog. I'm not sure if it's a SparkSessionCatalog or a SparkSessionCatalog. I'm not sure if it's a SparkSessionCatalog or a SparkSessionCatalog. I'm not sure if it's a SparkSessionCatalog or a SparkSessionCatalog.", "reference": "If this is needed, should we check that the configured `uri` isn't already equal to the value of the metastore URI configured via `spark.hadoop.hive.metastore.uris` or any of the other ways of setting it. This would be a breaking change for people who have `uri` configured on the SparkSessionCatalog and have it correctly set (which I believe should be everybody as `uri` is currently required if I'm not mistaken)." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "see above - this is only used to select the correct view, we don't need to handle the boundary information here." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "These tests use a self-signed cert so the CA *is* the cert. I considered making a proper chain to use in the tests, but wasn't sure it was necessary to test here, since we test it in the E2E tests anyway." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "We could, maybe, just directly do `excessDomChildren[excessDomChildren.indexOf(dom)] = null;`. Would this improve the size in any way? This will end-up with a property on the `excessDomChildren[\"-1\"]` but maybe we could live with that?" }, { "prediction": "I think this is what you are looking for, but I'm not sure if this is what you're looking for.", "reference": "this looks like it may be something that needs additional refactoring" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "Nit: Remove whitespace (and below)" }, { "prediction": "I'm not sure what you're trying to do here, but I think it should be something like this:", "reference": "\"Failed opening\" or \"Failed to open\"." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do.", "reference": "and -> or" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Add a `yield User.init()` here to wait for all indexes to finish building" }, { "prediction": "I'm not sure what you're trying to do here, but I'm assuming you're using a different version of nebula, so I'm assuming you're using a different version of nebula.", "reference": "I don't think this belongs here. If the application can take a local_ip as input, the application should take care of it, not in this common library" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "@DanHarrin please add a `return true` at the bottom of this method, as the docblock indicates a boolean return value." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "This is used in o.a.l.sandbox.search.BM25FQuery." }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "Shouldn't this work as well for Disjoint?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Same here. This was included to quiet the test for the 3D descriptors. As we removed them, this exception handling is no longer required" }, { "prediction": "I'm not sure if this is a bug, but it seems to be fixed.", "reference": "Why do you need to load a specific data reader in lbann_library?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "why not ValueTask?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure.", "reference": "I'm nervous about this line, I don't want to go regenerate a bunch of imageset jobs for clusters that are old, already installed, but don't have a CLIImage set (which they wouldn't because they're old) Adding the Installed guard is meant to address this. Otherwise this *should* recreate the imageset job due to the code in this function that deletes the job if it's finished. (but we don't have our images set due to this clause)" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to create a new table. I'm not sure what you're trying to do, but I think you're trying to create a new table. I'm assuming you're trying to create a new table. I'm not sure what you're trying to do.", "reference": "Is it necessary to change this file? Doesn't `tableMetadata` call `newTableMetadata`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "I think that I have a better proposal for this test - improve it so that it would know how to read the list of SupportedProtocolVersions and dynamically use these. The motivation here is that I expect to have another network version soon, and this test seems to be a good test case for that." }, { "prediction": "I'm not sure if this is the case, but if it's the case, then it's probably the case.", "reference": "What is the purpose of this debug message? I'm not sure how it would help." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Is there a corresponding BUILD dependency to prune?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug.", "reference": "The \"good\" and \"bad\" descriptions confused me a bit. Maybe `allowedContentType` and `disallowedContentType`? Not sure if that's better." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "It would be better to just change RWD to throw IllegalStateException if you attempt to execute a command after quit (unless it's a second call to quit())" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "You may want to have a look at `func checkClusterFormed(t *testing.T, servers...*Server)` in this file that I created some time ago. It will timeout at 5 seconds, but will return as soon as cluster is ready." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case, so I'm not sure if it's the case, so I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "I see a few places where this blob of code is required due to the removal of `errnum` parameter from `flux_respond` -- trading 2 lines of code for 8. The improvement to the function seems like a good idea, but I wonder if we need a convenience macro or function to do it the old way? You went through and made all the changes, was it overall a net win?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "I know it's not related to your change, but it's a bit odd that this import uses a relative path rather than the ones setup by webpack. Might be nice to change this one in case we refactor those paths in the future; this one wouldn't get caught in any kind of find+replace." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Good catch, and if we don't declare the newSchedule here, will the last schedule be executed in multi goroutine?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "`project` should never be null here, unless we have projects that aren't in the solution? Which we shouldn't have" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems to be a bug.", "reference": "Simple `for` loop instead of `for_each` would help here by making it more readable." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Looks like this falls through, should break." }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Let's default manifest lists and manifests to overwrite. These use UUID-based file names and should never conflict." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Please rename [speechView] to [speechViewer]." }, { "prediction": "I'm not sure if this is what you're trying to do, but it's what you're trying to do.", "reference": "I would use shorter yet still descriptive names, e.g. `KernelPerCpu` and `UserPerCpu`." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "if we are seeking for the content of only one field from metadata, no need to check whether a user could edit record or not" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Should this be camelCase to match the above commands? I am not the expert here so maybe Lucas or David can chime in." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This is also missing in CreateScopeFromExecuteAsync. Can you add that there too?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug, and it's a bug.", "reference": "I hope that this does not break anything... Probably needs detailed beta tests." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "@JonRowe in what scenario do you see this being manually set?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "I think the work \"trigger\" makes more sense than \"check\" because this is taking an action based on status." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "add a configuration, default put public key in Microservice, if the configuration is set, then put in Instance." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "WDYT about the idea above of making these all verbs that correspond to the input spec?" }, { "prediction": "I don't know if this is a bug, but it's a bug.", "reference": "With the introduction of the enum(s) the constants in the store classes should be removed." }, { "prediction": "I'm not sure if this is the case, but it's the case. I'm not sure if this is the case, but it's the case. I'm not sure if this is the case, but it's the case.", "reference": "I would say `!= 5`; A packet with <5 would be malformed." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "I think you missed removing `Stateful` from `push/config.go`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "why would you make it internal? if so then at least protected internal" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "We should check if the response (`d`) contains bar as response, screw the log. :smile:" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug.", "reference": "@Laurae2 good call. This is the only one I found (with `git grep transfered`)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "I don't understand how this work, could you explain?" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "The abbreviation for \"context\" used extensively inside DR is \"cxt\", not \"ctx\", so s/MCTX/MCXT/." }, { "prediction": "@ -13,5 +13,5 @@ return [ */ 'failed' => '\u06cc\u06c1 \u062a\u0641\u0635\u06cc\u0644\u0627\u062a \u06c1\u0645\u0627\u0631\u06d2 \u0631\u06cc\u06a9\u0627\u0631\u0688 \u0633\u06d2 \u0645\u0637\u0627\u0628\u0642\u062a \u0646\u06c1\u06cc\u06ba \u0631\u06a9\u06be\u062a\u06cc\u06ba\u06d4', - 'throttle' => '\u0644\u0627\u06af \u0627\u0650\u0646 \u06a9\u0631\u0646\u06d2 \u06a9\u06cc \u0628\u06c1\u062a \u0632\u06cc\u0627\u062f\u06c1 \u06a9\u0648\u0634\u0634\u06cc\u06ba\u06d4 \u0628\u0631\u0627\u06c1\u0650 \u0645\u06c1\u0631\u0628\u0627\u0646\u06cc \u06a9\u0686\u06be \u0633\u06cc\u06a9\u0646\u0688 \u0645\u06cc\u06ba \u062f\u0648\u0628\u0627\u0631\u06c1 \u06a9\u0648\u0634\u0634 \u06a9\u0631\u06cc\u06ba\u06d4', ];", "reference": "here is `:seconds` missing again" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "initializing to null makes me uncomfortable. let's have a default value" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "This is the `GET % HTTP/1.1` scenario right?" }, { "prediction": "I'm not sure if this is the case, but I think it's the case, so I'm not sure if it's the case, but I think it's the case.", "reference": "No need to use the fully qualified path the BackendAuth facade, just `use BackendAuth` is fine." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Because it's similar for send/open/change/receive types, then probably it can be just common `nano::epoch nano::block::epoch () const` with override for state_block (like nano::block::link (), account (), representative ())" }, { "prediction": "This is the API that JS files loaded from the webview can see const webviewApiPromises_ = {}; +let cb_ = () => {}; // eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-vars const webviewApi = { // eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-vars, // eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-vars, // eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-vars, // eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-vars, // eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-vars, // eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-vars, // eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-", "reference": "Please give a more descriptive name and add a command to explain what it does." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "we can never get rid of this..." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "what is the effect of changing these buckets in existing data that is available in the monitoring system? if there are any existing dashboards that use previous histogram buckets they are probably going to be wrong ot invalid? also any reason why we chose these specific values?" }, { "prediction": "The `sanitize-tchannel` flag is removed from the `tchannel.ContextWithHeaders` flag. It is removed from the `tchannel.ContextWithHeaders` flag in the `tchannel.ContextWithHeaders` flag. The `sanitize-tchannel` flag is removed from the `tchannel.ContextWithHeaders` flag in the `tchannel.ContextWithHeaders` flag in the `tchannel.ContextWithHeaders` flag in the `tchannel.ContextWithHeaders` flag in the `tchannel.ContextWithHeaders` flag in the `tchannel.ContextWithHeaders` flag in the `tchannel.ContextWithHeaders` flag in the `tchannel.ContextWithHeaders` flag in the `tchannel.ContextWithHeaders` flag in the `tchannel.ContextWithHeaders` flag in the `tchannel.ContextWithHeaders` flag in the `tchannel.ContextWithHeaders` flag in the `tchannel.ContextWithHeaders` flag in the `tchannel.ContextWithHeaders` flag in the `tchannel.ContextWithHeaders` flag in the `tchannel.ContextWithHeaders` flag in the `tchannel.ContextWithHeaders` flag in `tchannel.ContextWithHeaders", "reference": "This won't work. For the flag to be passed to the plugin, it should be passed as part of the --plugin argument. --plugin \"yarpc --sanitize-tchannel\"" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "@shiyu1994 @StrikerRUS what do you think about this addition to `c_api.cpp`? I think it's a really useful addition to be able to get this type of information from the `Booster`, but I want more opinions since `c_api` is the main public API for the library." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "rename Round -> requestedRound and DbRound -> dbRound. we don't need to export the fields here, only the error struct." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug.", "reference": "This expected value should probably be what you literally expect, otherwise there's a chance getClusterRegion is doing something wrong and the test wouldn't catch it because it's being run for both expected and actual." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "TODO: update unit tests to exercise base64-inline path" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "this method knows too much - it is kind of a strange side effect I'd prefer if we had separate method for acknowledging that the onboarding was done and should not be shown again" }, { "prediction": "I'm not sure if it's a bug, but if it's a bug, it's a bug.", "reference": "Do we need to increase the DB version? Also, should probably be a constant, no?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "We could utilize the new isZero method in this if-statement, right?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this.", "reference": "should probably have config have a `t` or a `logger.NewTestLogger(t)`, and return the latter" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Does this not do the same thing as `copy`? I thought that `copy` just did an elementwise assignment, but maybe I was wrong." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Here we are merging the configs from proto annotations and gapic config. But in other places in this PR we are using the new enum to pick one or the other, right? Or is that not the correct way to think about this?" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "not related to this change?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if this is the correct way to do it.", "reference": "Why is this needed?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "This one could be replaced with a `std::max`, no?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this should work.", "reference": "Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Please use strict type comparisons (`===`), not loose type comparisons." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "The filter parameters are a bit confusing. I understand that one of them has to be set, but what takes precedence if a from/to is set and the hash as well? Should that fail?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Is that necessary?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "yess so much easier to read in order like this!" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "question: would this convention automatically and always apply to all classes derived from `LuceneTestCase` including any non-`org.apache` name spaces or would it be possible to opt-out (without an exclusion list) somehow for custom code that might perhaps have chosen a different convention?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Also found this bug, where we were setting the min passcode length to 6, but the min length for a connected app is 4. This can cause problems when the app is force closed or the shared pref is removed." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "Why was this change necessary?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "I kind of did this deliberately, so everything from the distributor appears in the same set of logs." }, { "prediction": "I think this is a bug in the TCPSession class. If it's a bug in the TCPSession class, it should be fixed in the TCPSession class. If it's a bug in the TCPSession class, it should be fixed in the TCPSession class. If it's a bug in the TCPSession class, it should be fixed in the TCPSession class. If it's a bug in the TCPSession class, it should be fixed in the TCPSession class. If it's a bug, it should be fixed in the TCPSession class.", "reference": "We already have a `seq = pkt[TCP].seq` so you can just re-use it." }, { "prediction": "I'm not sure if this is a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "We avoid wildcard imports because it isn't clear where symbols are coming from and there is potential for collision. Could you roll back this change? (As well as the additional newline, we don't use breaks in imports either.)" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm guessing it's what you're trying to do. I'm not sure if this is what you're trying to do, but I'm guessing it's what you're trying to do.", "reference": "Why are these variables renamed? Is there a conflict with some Windows specific variable?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug in BoincDb.", "reference": "Do you test for file existence simply to reduce the warning message that may occur using the include? Also - I think the practice used in BOINC is to go ahead and use include_once even though it isn't strictly necessary in this case." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug in the timechaos API.", "reference": "`TimeChaos` does not contains a field.spec.action" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug, so I'm not sure if it's a bug, but it seems to be a bug.", "reference": "You need to override where possible in rs-api" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this. I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this. I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this. I'm not sure if this is what you're trying to do.", "reference": "Should this have an add/update/etc pattern? What happens if I need to change some set of data? May be better to just let the callsite manipulate the dictionary." }, { "prediction": "This method is not overridden by the region subclass. It should be overridden by the region subclass. It should be overridden by the region subclass.", "reference": "I don't think this should be added to PyRegion. Adding it here requires that every region have an \"algorithm\" which may not always make sense and the return value type will be different in every case. But fine to use the same name in the regions where we choose to implement it as a convention if that makes the API more discoverable." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Returning here bypasses all the health check and load balancing features." }, { "prediction": "I'm not sure if this is a bug or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug, or a bug.", "reference": "Should revert this copyright change, when the file isn't changing in any other way." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Interesting that filepath.Dir(\"thing\") returns \".\" whereas this returns \"\"" }, { "prediction": "I'm not sure what you're trying to do here is what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Nice, I did not know about that" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Since the lock is have moved outside of this function, I think it would be simpler and efficient to just return a ref to the std::vector? That way, we don't need to make a new copy on read and we won't actually need a write operation." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug.", "reference": "also fetch block hash of this height and return hash" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Why do we need this in this sample app and not the others?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "We don't need this additional method." }, { "prediction": "I'm not sure if this will work for you, but it should work for you.", "reference": "Shouldn't this return code conditionally? The above line seems like an error occurred." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "What is the need to use string as key? Can we use the apis type as the key?" }, { "prediction": "I'm not sure what you're trying to do here, but I think this should work.", "reference": "how about a default parameter instead?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if this is the case. I'm not sure if this is the case, but I'm not sure if it's the case. I'm not sure if this is the case, but I'm not sure if it's the case.", "reference": "i don't think we need to add duplicate check for clusterinstallref here, the function already assumes that it was invoked for clusterprovision" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "\\`bbox_feats.shape[0] > 0\\` requires the number of proposal is not 0." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Same here. Any way to fit on one line?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea to use std::stoi instead of std::stoi. I'm not sure if this is what you're looking for, but I think it's a good idea to use std::stoi instead of std::stoi.", "reference": "using folly::to is better?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "I'm guessing this is unintended?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if this is the case, but I'm not sure if this is the case, so I'm not sure if this is the case, so I'm not sure if this is the case.", "reference": "This looks a little suspicious to me, can you explain what's going on here?" }, { "prediction": "I think this is a bug in Rails. I'm not sure if it's a bug, but I think it's a bug in Rails.", "reference": "Can you talk about this? I'm not sure I follow why this is necessary." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, then you'll need to change it to something else.", "reference": "Is there really a need for this'simple' layout? Is there a reason you can't use 'lightbox'? The only difference seems to be that the lightbox layout includes Piwik/Google Analytics tracking and simple does not. If tracking needs to be disabled for some reason, perhaps there is a way to do that without creating a whole new layout." }, { "prediction": "I'm not sure if this is the case, but it's worth noting that we're using the default MergePolicy, which is the default one. The default one is to use the default one. The default one is to use the default one. The default one is to use the default one. The default one is to use the default one. The default one is to use the default one. The default one is to use the default one. The default one is to use the default one. The default one is to use the default one. The default one is to use the default one. The default one is to use the default one. The default one is to use the default one. The default one is to use the default one. The default one is to use the default one. This is to determine which segments are currently registered to merge. The default one is to use the default one. The default one is to use the default one. The default one is to use the default one. The default one is to use the default one. The default one is to use the default one. The default one is to use the default one. The default one is to use the default one. The default one is to use the default one.", "reference": "Can you say what exception will be thrown in that case (or add an `@throws`, below)?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Is this meant to be \"2.7\" or \"2.6\". The two lines in this commit don't agree with one another. Looks like everything else in this PR is \"2.6\" and that seems sensible." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug in nupic.data.generators.pattern_machine.", "reference": "Should we put these tests in a `generators` directory?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "I think that it makes more sense to keep these with the standard definition of non-zero is true and zero is false." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "Any idea why you want to change the behavior here? Is there a security risk not to have the prefix in the principal here." }, { "prediction": "@ -47,6 +47,7 @ @ type ConfigMock struct { }", "reference": "this reads like \"mock database cache\", maybe a clearer name" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "Nit: move this with the other CM imports." }, { "prediction": "I'm not sure if I'm correct, but if I'm correct, I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "This change should be mentioned in the CM" }, { "prediction": "I think this is a bug. It should be fixed in the class. It should be fixed in the class. It should be fixed in the class. It should be fixed in the class. It should be fixed in the class. It should be fixed in the class. It should be fixed in the class. It should be fixed in the class. It should be fixed in the class. It should be fixed in the class. It should be fixed in the class. It should be fixed in the class. It should be fixed in the class.", "reference": "Do we really want a new type, or can we just use `SpanContext`? The `ISpanContext` interface is read-only, but there's nothing stopping users from casting this to `SpanContext` and modifying it." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, or if it's the case, or if it's the case, or if it's the case, or if it's the case, or if it's the case, it's the case.", "reference": "Should we define a const like NETFRAMEWORK or NETFULL which will be set for NET452 NET461 and anything like NET47 etc in future?" }, { "prediction": "I'm not sure if this is a bug, but I think it is a bug.", "reference": "maybe start an issue to capture params that we need final values for and link to it here?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Can we instead do the check in find_instance_group_by_url()? if we return None when group is not found, it will hit the next if statement (if not instance_group) and continue as expected, in this case we don't need to add 3 separate if statements" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "on my android \".a.m\" and \".p.m\" is used add `||` here to support both variants" }, { "prediction": "I don't think it's a bug, but it's a bug.", "reference": "`!FormatIsMultiplane(image_format)` will always be true at this point due to the test on line 4639." }, { "prediction": "I'm not sure if this is a bug, but it should be fixed in the future.", "reference": "Maybe inline the CachedAccessor code? Is it similar to our lazy property? If yes, can we reconcile the two?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm assuming you're trying to attach the smoke test cases to the API model. I'm not sure what you're trying to do here, but I'm assuming you're trying to attach the smoke test cases to the API model. I'm not sure what you're trying to do here.", "reference": "Nit this file has unintended changes." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Potential NPE? `hasMedia && selectedItem...`" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "PEP-8/consistency with the rest of the code." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "nit: Would you mind moving the `ParameterTypeNames` assignment into each of the method-specific attributes? That could reduce confusion if we later decided to instrument other methods in MongoDb" }, { "prediction": "I'm not sure if I'm missing something, but I'm not sure if I'm missing something, but I'm not sure if I'm missing something.", "reference": "Is exposing SpecProvider needed here?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "So this will only be executed when it is true. I'm not sure that makes it always usable. Why not make the afterAction, `Action` and always call it, with the result as parameter." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "Tim, please add { } to this 'if'." }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "Suggest moving to `enable.go` since thats only place used." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "This changed when I rebuilt my docker container. Not quite sure why, but might have to do with what my host network configuration looks like when it's rebuilt." }, { "prediction": "I'm not sure if this will work for you, but it might work for you. I'm not sure if this will work for you, but it might work for you.", "reference": "Local cache of what? What's stored in it?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "If the copied `DataFile` returns null, shouldn't the copy also return null? Why not make the builder use `Integer` instead of a primitive here?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think you're looking for something like this:", "reference": "You could just do this test in the `save_html` function above, and then the users of the save html function don't have to worry about it." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "I think I'd prefer not using the formatted string when it comes to unit test, since we don't pass in any string variable as params." }, { "prediction": "@@ -1,4 +1,4 @@ -// +build avr esp nrf sam sifive stm32 k210 nxp +// +build avr esp nrf sam sifive stm32 k210 nxp,!mimxrt1062 package machine", "reference": "Maybe it would be better to explicitly include devices instead of explicitly excluding devices?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "This could be `for (auto bond: bonds()){`, right?" }, { "prediction": "I think this is what you're looking for:", "reference": "Is $config no longer being used? Can we remove this line?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "can you revert changes to this file." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think you're trying to do something like this:", "reference": "I don't believe the change is sufficient to correctly handle variable substitutions in the name. As part of the process command we pass the original role object that was retreived without taking into account the substitution. So while the first template apply command will work fine because the original role does not exist thus it's a new add operation, if you try to re-apply the same template again, we'll pick up and process a wrong original name thus we'll try to execute an add operation again instead of modify. So we need to take into account the substituted name when we retrieve the original role as well. Same change should be applied to both policy and service blocks as well." }, { "prediction": "I'm not sure if this is what you're trying to do, but it's a good idea.", "reference": "Please add this to IMvxMainThreadDispatcher as well" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "Is it possible for opt not to be a string? I couldn't tell if this was a typo or if there is actually a case where it is not a string." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "Let's move this up next to the `id` as we usually have `className` as one of the first props." }, { "prediction": "The `quilt` PyPi package allows you to build, push, and pull data packages in Quilt using Python. The `quilt3` PyPi package allows you to build, push, and pull data packages in Quilt using Python. The `quilt3` PyPi package allows you to build, push, and pull data packages in Quilt using Python. The `quilt3` PyPi package allows you to build, push, and pull data packages in Quilt using Python. The `quilt3` PyPi package allows you to build, push, and pull data packages in Quilt using Python. The `quilt2` PyPi package allows you to build, push, and pull data packages in Quilt using Python. The `quilt3` PyPi package allows you to build, push, and pull data packages in Quilt using Python. The `quilt3` PyPi package allows you to build, push, and pull data packages in Quilt using Python.", "reference": "While you're in here, \"build, push and install\"?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "Unit never made it to spec...so removing." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "We have RequestStart which seems redundant a bit to this one, WDYT?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "I think we can remove this corresponding export from `preact` now! Double check no other s using though lol" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I'm not sure why this would be in here. Were you working off a branch based off of master? These lines were removed in a previous commit because the table is actually called 'cart_item_traits'." }, { "prediction": "I'm not sure if this is a bug or a bug, but it seems to be a bug.", "reference": "Maybe `DEFAULT_GITHUB_API_ENDPOINT` would be a better name, since we refer to this as an API endpoint elsewhere?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this: https://docs.aws.amazon.com/ecs/latest/reference/ecs.capability.html#ecs.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.capability.cap", "reference": "If/when you rebase from `dev`, this is going to cause a merge conflict. I'd suggest that soon after merging this PR as the capabilities code has been moved to \"agent/app/agent_capabilities.go\"" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "What is the test case here?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "You could try moving this closer to the call, where we request label info. We might be doing the check very early.. all the resources may not be present with the informer at this point." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Can we add these up by the data files counts?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Most of the time assigning won't save bytes unless used 3+ times (var adds 3bytes)" }, { "prediction": "I'm not sure what you're trying to do here, but I think it should be something like this: if (navigator.mediaSession) { navigator.mediaSession.metadata = new MediaMetadata({ - title: title, - artist: artist, + title: artist, + artist: title, album: album, artwork: getImageUrls(item), albumArtist: albumArtist, artwork: getImageUrls(item), albumArtistArtist: albumArtist, artwork: getImageUrls(item), albumArtist: albumArtist, artwork: getImageUrls(item), albumArtist: albumArtist, artwork: getImageUrls(item), albumArtist: albumArtist, artwork: getImageUrls(item), albumArtist: albumArtist, artwork: getImageUrls(item), albumArtist: albumArtist, artwork: getImageUrls(item), albumArtist: albumArtist, artwork: getImageUrls(item), albumArtist: albumArtist, artwork: getImageUrls(item), albumArtist: albumArtist, artwork: getImageUrls(item), albumArtist: albumArtist, artwork: getImageUrls(item), artwork: getImageUrls(item), albumArtist: albumArtist, artwork: getImageUrls(item), artwork:", "reference": "I would rather find the code that inverts the logic and remove that." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to set a timeout on a class that doesn't have a timeout attribute. I'm guessing you're trying to set a timeout on a class that doesn't have a timeout attribute, so I'm guessing you're trying to set a timeout on a class that doesn't have a timeout attribute, so I'm guessing you're trying to set a timeout on a class that doesn't have a timeout attribute, so I'm guessing you're trying to set a timeout on a class that doesn't have a timeout attribute.", "reference": "The else doesn't return anything?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "assignments should only be cuddled with other assignments (from `wsl`)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "why not simply `paths = search_path_opts.LibrarySearchPaths`?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Are we sure this should be translated by the web client? It was unclear in chat exactly what's getting translated here." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "same oneof issue." }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "If we resolve here, isn't the whole `module_install` config setting or any subkeys also pluggable? I think that's totally fine, just want to make sure that that's known, and we should also update the data in `options.rb` for those options" }, { "prediction": "I don't think this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "it would be better to change `kds` into a `std::vector` then we don't need to explicitly free it" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this. I'm not sure what you're trying to do here, but I think you're looking for something like this.", "reference": "Looks like you're also changing logic and not only tests." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Is it possible that test failures here are real and that we should improve the rate limiting logic? Or are we ok with rate limits to be exceeded by 15%?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Shouldn't there be some kind of validation somewhere? IMO there should be an exception if `$options['lazy']` is not a boolean." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "nit: please move it inside namespace." }, { "prediction": "@@ -15,7 +15,7 @@ module Bolt shell-command ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````", "reference": "The inventory schema needs to be regenerated to include these options. Looks like the CI job didn't get triggered since the paths don't include `lib/bolt/transport/**`." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "This might break if a user runs the system tests with a system language other than English, in which the user default language differs." }, { "prediction": "This should be a bug in Rspec/expectations, but it should be fixed in Rspec/expectations.", "reference": "This was raising intermittent errors, since Lorem ipsum contains the word \"error\"" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Shouldn't we then add `mp_impl = nullptr` to the destructor of `RTPSParticipant`" }, { "prediction": "@patch('mmdet.datasets.CocoDataset.load_annotations', MagicMock) -@patch('mmdet.datasets.CustomDataset.load_annotations', MagicMock) -@patch('mmdet.datasets.XMLDataset.load_annotations', MagicMock) -@patch('mmdet.datasets.CityscapesDataset.load_annotations', MagicMock) @patch('mmdet.datasets.CocoDataset._filter_imgs', MagicMock) @patch('mmdet.datasets.CustomDataset._filter_imgs', MagicMock) @patch('mmdet.datasets.XMLDataset._filter_imgs', MagicMock) @patch('mmdet.datasets.CityscapesDataset._filter_imgs', MagicMock) @patch('mmdet.datasets.XMLDataset._filter_imgs', MagicMock) @patch('mmdet.datasets.CityscapesDataset._filter_imgs', MagicMock) @patch('mmdet.datasets.CocoDataset._filter_imgs', MagicMock) @patch('mmdet.datasets.CustomDataset._filter_imgs', MagicMock) @patch('mmdet.datasets.XMLDataset._filter_imgs', MagicMock)", "reference": "Are the additional brackets necessary?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "consumerMeta only belongs to this invoker instance only relate to this one consumerIntf class seems no need to build a complex key?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "this one is unrelated right? (Don't mind including it, just making sure I understand)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "8, 11 actually achieves similar performance, we should use our default config if [9,11] is unnecessary." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "For a separate PR: Can we make this a JSON/Thrift procedure instead? It could accept the amount of time it needs to sleep as an argument." }, { "prediction": "I'm not sure what you're trying to do here, but I think it's a bug.", "reference": "Please remove this blank line." }, { "prediction": "I'm using Thelia\\Core\\Event\\Cart\\CartEvent instead of Thelia\\Core\\Event\\Cart\\CartEvent. I'm using Thelia\\Core\\Event\\Cart\\Cart\\CartEvent. I'm using Thelia\\Core\\Event\\Cart\\Cart\\CartEvent. I'm using Thelia\\Core\\Event\\Cart\\Cart\\CartEvent. I'm using Thelia\\Core\\Event\\Cart\\Cart\\CartEvent. I'm using Thelia\\Core\\Event\\Cart\\Cart\\CartEvent. I'm using Thelia\\Core\\Event\\Cart\\Cart\\CartEvent. I'm using Thelia\\Core\\Event\\Cart\\Cart\\Cart\\CartEvent. I'm using Thelia\\Core\\Event\\Cart\\Cart\\Cart\\CartEvent. I'm using Thelia\\Core\\Event\\Cart\\Cart\\Cart\\CartEvent. I'm using Thelia\\Core\\Event\\Cart\\Cart\\CartEvent. I'm using Thelia\\Core\\Event\\Cart\\Cart\\Cart\\CartEvent. I'm using Thelia", "reference": "the cartTrait is not used anymore" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Cn you please make the message more human friendly." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "Please do `import enum` instead, then use `enum.Enum` and `enum.unique` - we do this everywhere to see where things are coming from, except for Qt (everything begins with a `Q` anyways) and typing (mostly used in type annotations, so it's clear without the namespacing)." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing that you're trying to do something like this:", "reference": "Isn't ENCFAIL used in codec.c below? Wouldn't this make it no longer compile?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "this looks very weird" }, { "prediction": "This class will be removed in 7.0.0, but it will be removed in 7.0.0.", "reference": "So, the culprit was actually this class \"ConsoleLogHandler\", correct? Because it simply wrote to stdout..." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to call LogFactory.Configuration.Reload() instead of LogFactory.Configuration.Reload() so it's not calling LogFactory.Configuration.Reload() so it's not calling LogFactory.Configuration.Reload() which should call LogFactory.Configuration.Reload() which should call LogFactory.Configuration.Reload() which should call LogFactory.Configuration.Reload() which should call LogFactory.Configuration.Reload() which should call LogFactory.Configuration.Reload() which should call LogFactory.Configuration.Reload() which should call LogFactory.Configuration.Reload() which should call LogFactory.Configuration.Reload() which should call LogFactory.Configuration.Reload() which should call LogFactory.Configuration.Reload() which should call LogFactory.Configuration.Reload() which should call LogFactory.Configuration.Reload() which should call LogFactory.Configuration.Reload() which should call LogFactory.Configuration.Reload() which should call LogFactory.Configuration.Reload() which should call LogFactory.Configuration.Reload() which should call LogFactory.Configuration.Reload() which should call LogFactory.Configuration.Reload() which should call LogFactory.Configuration.", "reference": "Still curious why you need to modify this method? Why not in the future just have a method called `LogFactory.ReloadConfiguration()` instead of the config assigning itself?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Should this say \"lint, cleanup, destroy, dependency, syntax, create, prepare, converge, idempotence, side_effect, verify, cleanup, destroy\"?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I am not sure why these log messages are changed." }, { "prediction": "I'm not sure what you're trying to do here, but it's possible that you're trying to do something like this, and it's possible that you're trying to do something like this, but it's not possible to do something like this, and it's possible that you're trying to do something like this, and it's not possible to do something like this, but it's possible that you're trying to do something like this, and it's possible that you're trying to do something like this, and it's not possible to do something like this, but it's possible to do something like this, and it's possible that you're trying to do something like this, but it's possible to do something like this, and it's not possible to do something like this, but it's possible to do something like this, and it's possible to do something like this, but it's possible to do something like this, and it's not possible to do something like this, but it's possible to do something like this, and it's possible to do something like this, but it's possible to do something", "reference": "This panic is incorrect - this is a full implementation of a slice equality check. This should be something more like `type x is not comparable` maybe?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "See below: let's use the existing convention _tcsnlen." }, { "prediction": "I'm not sure what you're trying to do, but I think it's a good idea to do this.", "reference": "Why don't we need this any more?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "clean unnecessary comma" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "This is the default value for enumerable." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Just above, you have `const auto` for a `RDKit::MOL_SPTR_VECT::const_iterator`, here it is only `auto`. Why is this?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "@djarek just a quick question, wouldn't be `ptr.reset()` here better as it does not memory leak if we do not call delete on the raw pointer aswell? it maybe makes sense to use `ptr.release` if the event is guaranteed to be loaded again but on a reload it would memory leak if for example I removed that script from my files before reloading or not?" }, { "prediction": "I'm not sure if this is the case, but it's the case. I'm not sure if this is the case, but it's the case. I'm not sure if this is the case, but I think it's the case.", "reference": "Why to `Get()` value twice, while u have it 2 lines before" }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if it's the correct way to do it.", "reference": "There is a typo here, this needs to state `october.fresh`" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do. I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Metadata tables loaded through `HadoopTables` will have their names as location.type (which is weird as we normally use location#type). I am not sure whether it is a big deal or not." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Can you explain why you went from a positive value (metrics.viewTop) to a negative value?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this.", "reference": "Let's use a dedicated DTO instead of `List` to remain consistent with all other existing REST API endpoints: * Introduce a new DTO class (e. g. `ExternalTaskTopicNameDto`) located under `org.camunda.bpm.engine.rest.dto.externaltask` * The class should have the attribute `topicName` of type `String` * Introduce a getter & setter for the attribute * Convert the list of strings to a list of `ExternalTaskTopicNameDto`s * Change the method signature to return `List`" }, { "prediction": "This method returns the {@link org.phoenicis.repository.dto.ScriptDTO} with the given ID + * + * @param id The script ID + * @return The found ScriptDTO + */ + ScriptDTO getScript(String id); + /** * This method moves the repository, belonging to the given repository url, to the given index. * This is done by swapping the current content at the given index with the new index of the given repository url. * This is done by swapping the current content at the given index with the new index of the given repository url. * This is done by swapping the current content at the given index with the new index of the given repository url. * This is done by swapping the current content at the given index with the new index of the given repository url.", "reference": "Do you plan to remove the `ScriptDTO getScript(List path);` method long-term?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's the same as this.allTypes.filter(function(item) { return this.enabledTypes.some(function(enabledItem) { return enabledItem === item.value; }); });", "reference": "@itsiprikshit I used a custom v-model to app count component because the sourceapps component was not reacting to user app count selection, e.g. whenever user changed app count selection, the source apps selection multiplicity remained the same. As a matter of fact, user was able to select one application only. Please let me know if you have any thoughts on this." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're trying to import a module from a different package.", "reference": "Similarly, we think we may keep `fused_semantic_head.py` unchanged. Then, we could add a new mask head for the desired function." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm sure it's a bug.", "reference": "Why implement this? It duplicates the value in FeatureConfig." }, { "prediction": "I'm not sure if this is a spark streaming microbatch scan, but if it's a spark streaming microbatch scan, then it's not a spark streaming microbatch scan. If it's a spark streaming microbatch scan, then it's a spark streaming microbatch scan. If it's a spark streaming microbatch scan, then it's a spark streaming microbatch scan. If it's a spark streaming microbatch scan, then it's not a spark streaming microbatch scan, so it's a spark streaming microbatch scan. If it's a spark streaming microbatch scan, then it's not a spark streaming microbatch scan, so it's a spark streaming microbatch scan. If it's a spark streaming microbatch scan, then it's not a spark streaming microbatch scan, so it's a spark streaming microbatch scan. If it's a spark streaming microbatch scan, then it's not a spark streaming microbatch scan, so it's not a spark streaming microbatch scan. It's a spark streaming microbatch scan. It's a spark streaming microbatch scan. It's a spark streaming microbatch scan. So it's a", "reference": "@aokolnychyi / @RussellSpitzer / @holdenk Spark3 gives ScanBuilder - abstraction - to define all types of Scans (Batch, MicroBatch & Continuous). But, the current implementation / class modelling - has SparkBatchScan as the Scan implementation. Looking at some of the concerns of BatchScan - all the way from the State maintenance of a single SnapshotId to read from, the asOfTimeStamp & features like VectorizedReads - all of these don't seem relevant to Streaming Scans. So, I feel that we need to divide out Streaming Scans into a different class. Does this thought process - make sense? If we go by this route - do you folks know - how to pass different Scan objects to Spark based on Batch vs Streaming?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Will you please update these files to use a copyright end date of 2021?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Adding fixture to the body as we don't have the `runner.tmpl` anymore" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "nit: just for consistency we can move this import block down. Right above openshift/hive imports" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Perhaps clean up the commit history and don't squash?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Just `writeBytes(content.array())` Back to my original, somewhat broken version ;)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I couldn't tell from reading the test - do we every criss-cross transports in the same test? I want to make sure we aren't breaking the chain..." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this.", "reference": "File is not `goimports`-ed" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "do we want to still validate that the context had a nonzero TTL? i suppose it's fine to let clients determine whether or not their streams will timeout (though we still don't have the means to cancel them from the server other than EOF), and they can still cancel their own contexts - so maybe not a huge deal, but thought it was worth bringing up." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Go ahead and provide the same implementation for all of the languages - I'm not sure there's a reason for it to be different." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "We should also test type confusion here (e.g. `{\"anticache\": \"foo\"}`)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "I'd love to trim the content of `unformatted` too. Any ideas?" }, { "prediction": "This is mostly focused on python3. \"\"\" + import typing from inspect import getfullargspec from functools import wraps", "reference": "can you remove this unrelated change?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Would using `HintLabel` here instead (without `setObjectName`) work?" }, { "prediction": "It is useful for mocking out a given provider since an alternate set of // constructors may be set. type dnsProviderConstructors struct { - cloudDNS func(project string, serviceAccountFile string, serviceAccount []byte, dns01Nameservers []string, ambient bool) - azureDNS func(project string, serviceAccountFile string, serviceAccount []byte, dns01Nameservers []string, ambient bool) - azureDNS func(project string, serviceAccountFile string, serviceAccount []byte, dns01Nameservers []string, ambient bool) (*clouddns.DNSProvider, error) cloudFlare func(email, apikey string, dns01Nameservers []string) (*cloudflare.DNSProvider, error) route53 func(accessKey, secretKey, hostedZoneID, region string, ambient bool, dns01Nameservers []string) (*route53.DNSProvider, error) azureDNS func(clientID, clientSecret, subscriptionID, tenentID, resourceGroupName, hostedZoneName string, dns01Nameservers []string, ambient bool) (*azuredns.DNSProvider, error) cloudFlare func(email, apikey string, dns01Nameservers []string) (*", "reference": "From what I can tell, the `serviceAccountFile` is never set to anything except \"\"? It'd be best to remove this altogether, so we don't mislead future developers" }, { "prediction": "I'm not sure if this is what you're looking for, but it's a good idea.", "reference": "Why do we remove the Sign in link?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "holy crap, were we really missing a 'break' statement here?" }, { "prediction": "I'm not sure if this is a bug, but if it's a bug, then it should be fixed.", "reference": "This doesn't seem to be used anywhere, probably doesn't need to be a new interface." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "This is a good start, but what do you think about just using `libkbfs.GetCurrentSessionIfPossible()` to avoid calling this altogether if there's no session? That way we can avoid continuous RTTs to the server when logged out." }, { "prediction": "I think this is what you're looking for, but I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "This `aria-labelledby` stuff is all new to me, but my reading of the spec is that the value should be a list of element id values, and `dLabel` doesn't seem to be the id of any element?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this.", "reference": "Does this fail validation if you now use the `upload` key instead of `source`?" }, { "prediction": "CmpStoredProc::ProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProcProc", "reference": "Can we use GetCliGlobals(false)->exCollHeap() here instead" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "I suggest you move the waitUntilAllElected into init::KV() method." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "no need of pub;lic." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Do you think we can name this variable in a less...negative.. language? maybe `ProposalTieBreakerEqualizer`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Can you add back these newlines? We try to avoid non-functional changes like this because they can cause commit conflicts." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Why not just `if (!searches.includes(action.search)) searches.push(action.search)`? That way you don't need to remove then add the element." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "@demiankatz I'm not sure that this is very useful. I just did it to get started. If we had a small handful of predetermined prefixes that were randomly chosen, it would be easier to distinguish them from the rest of the call number. Would that be preferable?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, and it's a bug.", "reference": "Why is this deleted too?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a good idea.", "reference": "Given that IApiResponse is already made disposable, this is not necessary." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "client.getSelectedSpellName() can be used for this" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Please alpha sort these filenames." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "is this already called by actPool.validate()?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm not sure.", "reference": "It is relatively cheap to tell whether a bond is a ring bond, we don't have to perform an SSSR." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Maybe we should add flag aliases for service as well." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this: `json:\"ePoStInfo\"```````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````", "reference": "This LGTM but don't we need a winning PoSts field to fully implement the protocol? No need to add here as I'm working on this in another PR, but curious how we can interop with lotus blocks without post proofs." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this, but it's not what you're trying to do.", "reference": "can you move the [] into pubSub? so Blockchain just contains a pubSub, not []" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "I don't think 100 is a safe default here, since later we check that the value is between 50-95." }, { "prediction": "I'm not sure if this is a bug, but it's a bug in NLog.Layouts.Layouts.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.Renderers.", "reference": "I would be nice if we could describe this without the word \"agnostic\"" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case.", "reference": "Pick more specific exception types for these cases. Not sure what would be best for this one (`ValueError`?) but the next one could be `IndexError`." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea to use `jest.config` instead of `jest.config`.", "reference": "This seemed like the easiest solution We need to include this path in `testMatch` to run the test AFAIK *BUT* we don't want this test ran when running them all normally I'm sure there are other ways to do this!" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Most of the following test changes can be avoided if need be." }, { "prediction": "I'm not sure if this is the case, but if it is the case, then it's the case.", "reference": "Eventually we might want to move this back as generating this data structure takes some time (for large datasets) and we don't want it in the hot-path of `osrm-customize` runs. Thinking long-term making `osrm-customize` eventually digest `.osrm.cells` will will enable only updating cells selectively and using an earlier customization for the rest." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "You're not really using named result variable - you can just leave `error`." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "It wasn't possible to call this method with `PartitionSpec.unpartitioned()` as the schema in the spec was empty." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "this namespace is never used" }, { "prediction": "I'm not sure if this is a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Well, if you call `Nack`, it _will_ be redelivered. So maybe reword." }, { "prediction": "I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Why did we make this a static string?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Please re-run PYTHONPATH=. python tests/services/inventory/update_cai_dumps.py following the instructions at the top of this file to ensure the test files have the correct CAI asset type." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug. I'm not sure if this is a bug, but I'm not sure if it's a bug.", "reference": "`stateDB := NewStateDBAdapter(sm, 0, hash.ZeroHash256, NotFixTopicCopyBugOption())`" }, { "prediction": "I'm not sure what you're trying to do here, but I think it's a good idea.", "reference": "There are unneeded parens here, but I'll fix it up when merging." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Just one more thing... How about doing all of the following? 1. renaming h2o.rb to bootstrap.rb 2. require and include the acl code _from_ bootstrap.rb" }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Commit message: \"remove\" is misspelled." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "This is a pretty idiosyncratic method - I'd move it into the JSON-RPC package rather than adding it to `BytesValue`." }, { "prediction": "I don't think it's a bug, but I think it's a bug.", "reference": "Is there a way to deduplicate this somehow? Could we roll it into `RSpec.configuration` with a bit of memoization or is there a chicken and egg problem." }, { "prediction": "I'm not sure if this is what you are looking for, but I think it's what you're looking for.", "reference": "Generally, I wouldn't say I like the idea of providing properties that return negative/inverted values. It would be more convenient to return whether the update is **in** progress or not." }, { "prediction": "I'm not sure if this will work or not, but I'm not sure if this will work or not.", "reference": "Converting playbackManager to operate in ms (preferred solution, imo) would allow us to completely drop this function." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do.", "reference": "The default value should be a bigger one, I'd like it is the maximum of int32. That means we will not cut-off anything by default. And users would config it with an appropriate value in config-file, such as 1000 or 5000, etc." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Probably missing return here as well" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "On second thought... this affects how often the function specified by the `load` property is run. So I wonder if, for consistency, we should call this `LoadInterval` instead. Does that make sense?" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Now you don't need the localization module here then :)" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "This should not convert each value to a literal on every invocation. Instead, this PR can add a `literals` method to `BoundSetPredicate` to access the values as literals. That way, the conversion happens once and can be lazy." }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "I think we still need this exception if doesn't have LIGHTGBM_BUILD_DOC" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "Does this make it easier to read? Previously this would have run `kubectl describe certificate` right? In which case it would have included events related to the cert. Will we miss that? Would the old `kubectl describe` output have gone to stderr?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it, so I'm not sure if it's the correct way to do it, but it's the correct way to do it.", "reference": "Just an understanding question: do we need a map here, would a list/set of Strings be sufficient? we are not adding entries with `false` here, are we? Being in the list already means it's used, right?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Ah, so the change is that you want the `prune()` side effect before doing the `task.id not in necessary_tasks` membership check? Stupid non-Haskell programming languages :p" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing you're looking for something like \"fileutil\" or \"fileutil/fileutil\" or \"fileutil/fileutil/fileutil\" or \"fileutil/fileutil/fileutil\" or \"fileutil/fileutil/fileutil\" or \"fileutil/fileutil\" or \"fileutil/fileutil/fileutil\" or \"fileutil/fileutil/fileutil\" or \"fileutil/fileutil\" or \"fileutil/fileutil\" or \"fileutil/fileutil\"", "reference": "This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this. I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "Do we normally force ReadPreference primary on other write operations? Or is it just that we normally ignore it?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Instead of returning null here and discarding nulls automatically, I think this should return null (or some other signaling value) and fix the part that consumes the output of the visitor." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Really, we want to be setting the validatorsForPreviousBlock against the yet to be created block, so it might make sense to update the cache once the block is created/imported instead." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "It seems to me that the original implementation was correct. Can you share what the scanner was pointing out?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like 'googlesitekit-modules-search-console.js', 'googlesitekit-modules-subscribe-with-google': './assets/js/googlesitekit-modules-subscribe-with-google.js', + 'googlesitekit-modules-subscribe-with-google-bulk-edit': './assets/js/modules/subscribe-with-google/bulk-edit.js', 'googlesitekit-modules-tagmanager': './assets/js/googlesitekit-modules-tagmanager.js', 'googlesitekit-user-input': './assets/js/googlesitekit-user-input.js', 'googlesitekit-user-input-search-console': './assets/js/googlesitekit-user-input-search-console.js', 'googlesitekit-user-input-search-console': './assets/js/googlesitekit-user-input-search-console.js', 'googlesitekit-user-", "reference": "Instead of doing that, please create an `assets/js/googlesitekit-subscribe-with-google-bulk-edit.js` file as entry point - all our entry points should be located in `assets/js`." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This is not valid, a `div` shouldn't be in a `span`. You could apply the `className` attribute to the `span` tag." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Would it be possible to reuse RcJobExpireDuration and RcJobExpireInterval and auto delete them when job is deleted?" }, { "prediction": "I'm not sure if this is what you are looking for, but I think this is what you're looking for.", "reference": "Python wants **future** imports to come first." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Better to call this before EXITING_DR which is supposed to be last." }, { "prediction": "I'm not sure if this is the case, but if it's the case, then it's probably the case.", "reference": "Does this work at runtime?" }, { "prediction": "I think this is a bug in the SDK. It should be fixed in the latest version of the SDK.", "reference": "Hmm why do we need to make this change? Like which one requires this change?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "why remove this and other piece?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Yikes... That was probably me." }, { "prediction": "I think this is what you are looking for: https://github.com/NAV_GO/blob/master/src/main/index.js", "reference": "It would be better to move the... outside of the l8n block. This way it won't need to be translated for each language twice." }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this:", "reference": "That's a huge load of new dependencies. I think it's better to create a reload function on ScriptManager and control with enum instead." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "`NewUpgradeTaskJob` -> `NewUpgradeResource`" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like luaA_sys_get_meminfo(lua_State *L) or luaA_sys_get_meminfo(lua_State *L) or luaA_sys_get_meminfo(lua_State *L) or luaA_sys_get_meminfo(lua_State *L) or luaA_sys_get_meminfo(lua_State *L) or luaA_sys_get_meminfo(lua_State *L) or luaA_sys_get_meminfo(lua_State *L) or luaA_sys_get_meminfo(lua_State *L) or luaA_sys_get_meminfo(lua_State *L) or luaA_sys_get_meminfo(lua_State *L) or luaA_sys_get_meminfo(lua_State *L) or luaA_sys_get_meminfo(lua_State *L)", "reference": "Is that the memory usage of the system or the process / awesome?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "\"change\" *and* \"schema\" events (A bunch of these; not marking them all)." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I think there is probably a shorter, more descriptive name for this. Something like `commitAtSequenceNumber`?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "The `url_name` should definitely be more than just 1 character long at the shortest. How about 3 or 4 characters?" }, { "prediction": "I'm not sure if this is the case, but it's the case, so it's not the case.", "reference": "Please revert this change" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Nice. I hadn't even heard of presenters in Rails before (learn something new every day) :)" }, { "prediction": "I'm not sure if this is what you're looking for, but it's a good idea to have a separate class for each of your services, so we don't need to have a separate class for each of them.", "reference": "`string[]`? not sure, can you verify this @core23? Thank you" }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so I'm not sure if it's a bug, or if it's a bug.", "reference": "are we aware that this breaks older browsers like WebOS? :) they don't handle `let`" }, { "prediction": "We can't use touch here because we need to update the TTL value in the object. We can't use touch here because we need to update the TTL value in the object. We can't use touch here because we need to update the TTL value in the object. We can't use touch here because we need to update the TTL value in the object. We can't use touch here because we need to update the TTL value in the object. value = self.get(key) self.set(key, value, ttl) self.set(key, value, ttl)", "reference": "This isn't really a Kinto record but a Memcached record. I could kind of go either way on this." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but it's the correct way to do it.", "reference": "Kick off the download after login." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "I don't think you need to change this, `array` should be accepted whenever `string[]` is expected. (`string[]` is an alias of `array` itself an alias of `array` which is a parent type of `array`" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "TODO: fix this, probably in another PR" }, { "prediction": "It's possible that you're not using the tabbed-browser, but it's possible that you're using the tabbed-browser as the tabbed-browser. If you're using the tabbed-browser as the tabbed-browser, it's possible that you're using the tabbed-browser as the tabbed-browser. If you're using the tabbed-browser as the tabbed-browser, it's possible that you're using the tabbed-browser as the tabbed-browser, and that you're using the tabbed-browser as the tabbed-browser. If you're using the tabbed-browser as the tabbed-browser, it's possible that you're using the tabbed-browser as the tabbed-browser, but you're not using the tabbed-browser as the tabbed-browser, so it's not possible that you're using the tabbed-browser as the tabbed-browser.", "reference": "Is there any case that tab is None?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "pls use `err` instead of `e`" }, { "prediction": "I think this is a bug, but it should be fixed in the latest version.", "reference": "`attachGamepadScript` above can also be placed inside." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "when we use RegisterWriteCommand,this func should be exported,so we can use this to get signer at the outside action package" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Dead code - we should remove it or use `log.Trace` for lower logging level. Same applies for change at line 138." }, { "prediction": "This is a bug in boost::numeric::bad_numeric_cast. It should be fixed in boost::numeric::bad_numeric_cast, but it should be fixed in boost::numeric::bad_numeric_cast.", "reference": "How does this make sure invalid coordinates making the parser fail? Relying on the Coordinate type's boost numeric_cast calls in the ctor? Shouldn't we rely on a coordinate's `.IsValid()` member function instead?" }, { "prediction": "I think this is what you are looking for: https://docs.aws.amazon.com/ruby/latest/docs/ruby-example-upload-item-to-folder.html", "reference": "Simple Storage **Service**" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Does this line (and the corresponding one in the test bootstrap) actually do anything? I don't see where CACHE_ENABLED is used as a global constant." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "has this changed? are we testing \"all possible situations\" now?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "ZK is properly spelled 'ZooKeeper' (capital 'K')." }, { "prediction": "I'm not sure if this is the case, but it seems to be the case.", "reference": "Guessing this locates the key you get when you run `gcloud auth application-default login`? What was the previous behavior/the behavior for the manual Veneer creds?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "looks good to me, but it would be better if you assigned `this.countRows()` into a variable, so it doesn't trigger twice in the return statement" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do this in a function, so I'm assuming you're trying to do this in a function.", "reference": "For now, don't add \"use strict\" to any existing files. That's a separate project that we'll do later. (New files can use \"use strict\".)" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "I was confused by this env name variable, assuming it was the value, not the name. Silly nit, but maybe name it noninteractiveEnv?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "`sys.platform` could be equal to `darwin` which is posix. Use `not startswith('win')`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "let's move this into `slack_helper.go`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "I doubt it will work, but without space between -o and ControlPath it should. Lets see. What I do not understand is why we did not see a failure on CI related to this?" }, { "prediction": "private static double shifted_bearing (double bearing) { if (shifted_bearing < 360.) return bearing; if (shifted_bearing > 360.) return bearing; return bearing; }", "reference": "this is the reason we might be seeing 360 as discrete bearing" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "`FULL_VERSION` is available at module level for others to use, but it won't have `%(prog)s` substituted with pylint. Will that be a problem. Also put it here instead of __pkginfo__ with other versions because it isn't pkginfo related." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Is this needed? I don't see any uses." }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "Shouldn't this be V1beta1?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "I think there's an `approval_for`" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Here we should use List in generic" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure.", "reference": "The `JavaCompile#getToolChain` method got removed and I am not sure what a good replacement is. I replaced it with `targetCompat` for now but they are not equivalent. Maybe we can use `JavaVersion#current` here?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "The method name is incorrect. It does not check the existence of the file. I'd suggest deprecating both methods `fileExists` and `findIdByHash` and use findIdByFilename instead of fileExits" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "We have `stdbool` imported, might as well use that for clarity." }, { "prediction": "@ -0,0 +1 @@ +package batchstore", "reference": "File is empty, consider removing?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "`writeConcernMax` was changed to return a `writeConcern` formatted the new way-- `writeConcern: {w:1,...}`. Bulk execute takes an actual `WriteConcern` object as its first parameter (this was changed in master), so we have to un-wrap the `writeConcernMax` result here." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "How about passing this through the `config`?" }, { "prediction": "@pytest.fixture +def only_localstack(): + if os.environ.get(\"TEST_TARGET\") == \"AWS_CLOUD\": + pytest.skip(\"test only applicable if run against localstack\") @pytest.fixture +def only_localstack(): + if os.environ.get(\"TEST_TARGET\") == \"AWS_CLOUD\": + pytest.skip(\"test only applicable if run against localstack\") @pytest.fixture +def only_localstack(): + if os.environ.get(\"TEST_TARGET\") == \"AWS_CLOUD\": + pytest.skip(\"test only applicable if run against localstack\") @pytest.fixture +def only_localstack(): + if os.environ.get(\"TEST_TARGET\") == \"AWS_CLOUD\": + pytest.skip(\"test only applicable if run against localstack\") @pytest.fixture +def only_localstack(): + if os.environ.get(\"TEST_TARGET\") == \"AWS_CLOUD\": + pytest.skip(\"test only applicable if run against localstack\") @pytest.fixture +def only_localstack(): + if os.environ.get(\"TEST_TARGET\") == \"AWS_CLOUD\": + pytest.skip(\"", "reference": "Out of curiosity - did we make this change to allow dynamically assigning a value to `os.environ[\"TEST_TARGET\"]` during test execution? I kind of liked the decorator style `@only_localstack` - makes the condition a bit more explicit. Looks like `skipif` also allows to specify a condition string, e.g. `pytest.mark.skipif('os.environ.get(\"TEST_TARGET\") == \"AWS_CLOUD\"')` - could that be an option? (not sure if that gets lazily evaluated at runtime right before the execution of the annotated test method starts, though..)" }, { "prediction": "I think this is a bug. It should be a bug. It should be a bug.", "reference": "I noticed (SonarCloud noticed actually) that the implementation of `::edit` method is the same as `__construct` is. Does it make sense to call the `edit` method from the constructor?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "would you please rename the message prefix to: [in_syslog]...\"" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "The pointer to a pointer is kind of gross. How about either taking the `ROMOL_SPTR` directly or, preferably, returning an `std::pair`?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "the name confusing, please rename to `pendingCountNoLock` or similar" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do.", "reference": "line is 175 characters" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "@ivanbogdanov Does this fix the first time load gray screen issue that @wmathurin noticed?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Is `2.3.0` version OK?" }, { "prediction": "should be_kind_of(WebDriver::Element) + driver.find_element(:id, 'iframe_page_heading').should be_kind_of(WebDriver::Element) + driver.find_element(:id, 'iframe_page_heading').should be_kind_of(WebDriver::Element) + driver.find_element(:id, 'iframe_page_heading').should be_kind_of(WebDriver::Element) + driver.find_element(:id, 'iframe_page_heading').should be_kind_of(WebDriver::Element) + driver.find_element(:id, 'iframe_page_heading').should be_kind_of(WebDriver::Element) + driver.find_element(:id, 'iframe_page_heading').should be_kind_of(WebDriver::Element) + driver.find_element(:id, 'iframe_page_heading').should be_kind_of(WebDriver::Element) + driver.find_element(:id, 'iframe_page_heading').should be_kind_of(WebDriver::Element) + driver.find_element(:id, 'iframe_page_heading').should be_kind_of(WebDriver::Element) +", "reference": "I tested it only in Firefox (`./go //rb:firefox-test`)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "separate third party and builtin" }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "@smcnulty-sfdc We do want to finish the hybrid activity in our hybrid apps though. Could the caller not pass in `frontActivity` instead? Or start it up again post-logout?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "isn't this going to return a timeout error if the context is canceled?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this: I'm not sure what you're trying to do, but I think you're trying to do something like this: if (argNameVal.length == 1) { + parsedArgs.put(argNameVal[0], \"true\"); + continue; + } if (argNameVal.length!= 2) { System.out.println(\"WARNING: Ignoring unrecognized argument: \" + arg); continue; }", "reference": "`argNameVal.length` will still be!=2, so line 22 will give true and then continue on line 24" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, so I'm not sure if this is what you're looking for.", "reference": "It was `$chars[$i]` I believe." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "This has the likely potential to break existing tests that are relying on the old beaker behavior. If we are going to release this in beaker 3.x, then we need to preserve the old behavior as well (so set both the `upcase` and original values). On Windows, they env variables will overwrite each other, with the same value, so not an issue. On *nix, there will be two env variables, but they will have the same value, so again no issue." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Thanks for fixing this! I probably didn't test the playground when making changes here for cloud variables." }, { "prediction": "I'm not sure if this is the case, but maybe this is the case?", "reference": "I will also check if `nameMapping` needs a precondition null check." }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if this is the correct way to do it.", "reference": "Since RuntimeIOException is deprecated and you are touching this code, why not replace it?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this should work.", "reference": "You should also have a test that calls it with tm_cpp and make sure it returns the correct JSON file." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "One more minor change, the string `ForAdditionalLiveTvOptions` is probably also unused." }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "How to distinguish between warning and error?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Perhaps you want to check if UIAHandler.handler is not None. The current check will break NVDA if you call UIAHandler.terminate() for some reason." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this?", "reference": "can we make `replace-partitions` property a static variable in `SnaphotSummary.java`?" }, { "prediction": "@see Selenium::WebDriver::IE::Bridge # @see Selenium::WebDriver::IE::Bridge # @see Selenium::WebDriver::IE::Bridge # @see Selenium::WebDriver::IE::Bridge # @see Selenium::WebDriver::IE::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver", "reference": "Maybe call it `WireBridge`?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Should really be `one()`, not `one_or_none()`" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Should we use strings.Split and strings.Join instead of manual concatenation?" }, { "prediction": "@staticmethod + def from_definition(input_def: InputDefinition): + return In( + dagster_type=input_def.dagster_type, + description=input_def.description, + default_value=input_def._default_value, # pylint: disable=protected-access + root_manager_key=input_def.root_manager_key, + metadata=input_def.metadata, + asset_key=input_def._asset_key, # pylint: disable=protected-access + asset_partitions=input_def._asset_partitions_fn, # pylint: disable=protected-access + ) + def to_definition(self, name: str) -> InputDefinition: dagster_type = self.dagster_type if self.dagster_type is not NoValueSentinel else None return InputDefinition( dagster_type=self.dagster_type, description=self.description, default_value=self.default_value, default_value=self.default_value, default_value=self.default_value, default_value=self.default_value, default_value=self.default_value, default_value=", "reference": "rough that this needs to exist, but it is what it is" }, { "prediction": "I don't think this is a bug, but it seems to be a bug, so I'm not sure why it's failing.", "reference": "FYI, I pulled your branch and hacked a little on your test case. This passes for me (you may want to tweak further):
     it('should not set empty string for null props in custom elements', () => { customElements.define('x-bar', class extends HTMLElement { val; }); // @ts-ignore render(<x-bar val={null} />, scratch); expect(scratch.childNodes).to.have.length(1); expect(scratch.firstChild).to.have.property('nodeName', 'X-BAR'); expect(scratch.firstChild.attributes.length).to.equal(0); expect(scratch.firstChild.val).to.equal(null); }); 
    " }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "It is the maximum value that the configured emulator can support." }, { "prediction": "The name of the session to load, or None to read the state file. The name of the session to load, or None to read the state file. The name of the session to load, or None to read the state file.", "reference": "Here, I've been giving priority to the session saved by the user. This means, that if the user quits with `:wq`, then restarts `qutebrowser`, and then `qutebrowser` crashes for some reason, next time `qutebrowser` is restarted, the session saved lastly with `wq` will be restored, and not the one autosaved. What do you think?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "this line got me confused for few seconds, as the `AccountData` is both the name of the data structure as well as the function name. I think that `GetAccountData` is a better choice for a name. ( note that the same applies for the previous `BalanceRecord` function name )" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "I think this mutex is only used here. Remove it." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "so this is now init to 1?" }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "For future note; not prefixing the table in a join can throw an error in the query parser depending on how the query is built I am making an assumption this was tested" }, { "prediction": "I'm not sure if this is the expected behavior, but I think it's the expected behavior. I'm not sure if this is the expected behavior, but I'm not sure if it's the expected behavior.", "reference": "Had to bring this up, will abandon this style of testing based on Joel's work soon." }, { "prediction": "I'm not sure if this is a bug, but if it's a bug, it's a bug.", "reference": "What does our source validation complain about here? Many of the logok/nowarn places look fine to me at a glance but I'm no match for the logging policeman ;-)" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "It feels like this dependency should not be here. Some deep internal openvpn package (middleware) knows about one of possible stats consumers. Maybe as an alternative, statistics and state callbacks can be extracted as separate interfaces in top openvpn package and reused by both sides" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "Can you please remove `codec` from the parameters too? I think it's unused now." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug, so I'm guessing it's a bug.", "reference": "mocks needed this change so that it returns the \"right\" thing" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "I don't think the getters for this are needed, but looks good other than that" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": ":+1: to inlining this." }, { "prediction": "I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "Does psalm support the same logic internally for object-like arrays? Just want to be certain I can indicate this is a contextual return item `crypto?:mixed`." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "I can't recall if there was a fix specific to this in the past?" }, { "prediction": "I'm not sure if this is the correct way to do this, but I think this is the correct way to do it.", "reference": "Not sure what the todo is here? Is it to support some kind of defaulting based off of that?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Not sure about this name. I think \"explicit\" is also a bit difficult here (I think it should be implicit then) Proposal: FlushOnEvents. Or, It would be cool if we could split into 2 options, FlushOnShutdown and FlushOnReload, but I expect that's far more difficult to implement?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "I don't think that works - you can't mark a fixture." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "We should not include this path." }, { "prediction": "I think this is a bug in slack_webhook.SlackWebhook, but I'm not sure if it's a bug in slack_webhook.SlackWebhook, so I'm not sure if it's a bug in slack_webhook.SlackWebhook, but I'm not sure if it's a bug in slack_webhook.SlackWebhook, so I'm not sure if it's a bug in slack_webhook.SlackWebhook.SlackWebhook, so I'm not sure if it's a bug in slack_webhook.SlackWebhook.SlackWebhook.", "reference": "Add newline at end of file" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "This should be done when updating to the next release (2.5). You currently only perform the upgrade when users go from 1.4 to 1.5, so it will lead to crashes for existing users." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for the \"HIVE_FEATURE_GATES_ENABLED\" environment variable. If you're looking for the \"HIVE_FEATURE_GATES_ENABLED\" environment variable, you'll need to add it to the \"HIVE_FEATURE_GATES_ENABLED\" environment variable to the \"HIVE_FEATURE_GATES_ENABLED\" environment variable.", "reference": "suggest hive.openshift.io/cluster-machine-management or something to make it more obvious what it is." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this, and I'm not sure if this is what you're trying to do.", "reference": "We explicitly don't want to do that. This was a complaint from users before." }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this:", "reference": "Hello, The PHPDoc is `string[]` not `int[]`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Same issues with parameters order in `ipset_server.go`" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Wow, did it literally mean the retention days is a huge number?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "you probably didn't intend to touch those files in `scripts/`" }, { "prediction": "I'm not sure what you're trying to do, but it seems like you're trying to evaluate mAP of a dataset. I'm guessing you're trying to evaluate mAP of a dataset, but I'm not sure what you're trying to do.", "reference": "Similar to `collate_fn`, we may rename it to `tpfp_fn`." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this. I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this. I'm not sure if this is what you're trying to do.", "reference": "Awesome! We may also use negative rule `never` to fix new lines after `return`: `{ blankLine: \"never\", prev: \"return\", next: \"*\" }`" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "Why can't this be a function on the `Config` interface like all the others?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "If the feed is null, the menu items should still be setup. Just the feed title can be left out. That prevents possible flickering when menu items are displayed/hidden for some feeds." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "I'm not sure that this should call `allowIncompatibleChanges()` because adding a required column when there are no existing values will break reading the new column in any table with data in it. The only time it is safe to add a required column is if there is no data in the table. What about throwing an exception here instead? I agree that the column should not be optional if NOT NULL was specified. Another alternative is to check whether the table has data and allow the incompatible change if it doesn't have any rows." }, { "prediction": "I think this is what you are looking for. It should be something like this:", "reference": "Early translation, should be logic-less" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I don't understand why these functions return a request/response, respectively. In all implementations we actually _modify_ the request/response given as a parameter. Do you envisage situations where we'd want to construct completely fresh request/response objects? Even if we do, it's not something needed atm, so I'd favour in keeping the API minimal. Also, the fact that these functions _may_ mutate the request/response should be noted." }, { "prediction": "I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "Wasn't there a subsequent reason why we had to keep the `/p/project_graph` route? Outside references or is the proposed solution to the original proposal we us `/p/g` as the `compares#project_graph` route?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do.", "reference": "Any suggestions on how I would even _approach_ writing tests for arbitrary values...." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Scope declarations for class constants was not added until 7.1, this will not be accepted." }, { "prediction": "I'm not sure if this is the case, but if it is the case, then I'm not sure if it's the case, but I think it's the case.", "reference": "The assertion here is that find should never return end() because this is the only mechanism that reaps items from the activeClientMap. If it == end something went horribly wrong." }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "The `unless the collection...` part reads a little bit hard, maybe separate into its own sentence and explain what it means by `cannot generate a fresh key`?" }, { "prediction": "This is not a bug. It is a bug. It is a bug.", "reference": "Doesn't `gcerr_string.go` need to be updated for this?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Both cases allowed by the Go spec are now supported, so it's a bug in the compiler if we get here. You can replace the `todo:` error with a panic. (Note: getting here would be a bug because when we get to SSA level the code has long been type checked and has already been verified as being valid Go)." }, { "prediction": "@pyqtSlot(int) def on_current_changed(self, idx): \"\"\"Set last-focused-tab and leave hinting mode when focus changed.\"\"\" return self.widget(idx) + self.history.load_items(tab.history_prepared) + self.history.load_prepared_history(tab.history_prepared) + self.history.load_prepared_history(tab.history_prepared) + self.history.load_prepared_history(tab.history_prepared) + self.history.load_prepared_history(tab.history_prepared) + tab.history_prepared = [] + #end if + #end def load_prepared_history(self, idx): \"\"\"Set last-focused-tab and leave hinting mode when focus changed.\"\"\" return self.widget(idx) + self.history.load_items(tab.history_prepared) + self.history.load_prepared_history(tab.history_prepared) + self.history.load_prepared_history(tab.history_prepared) + self.history.load_prepared_history(tab", "reference": "You can simply do `if tab.history_prepared:` here as empty lists are falsey." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Remove this whitespace" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "`show_img` is not normalized while `one_img` is normalized. And line 139 pass `show_img` for pytorch2onnx function. Is this expected behavior?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Why is this bounded between -30 and 30?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I think even you can exclude to run it on nvcc" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "G104: Errors unhandled. (from `gosec`)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "will `failure` always include `arn` and `reason` in its dictionary? If so, :+1:" }, { "prediction": "I think this is a bug in Bolt, but I'm not sure if it's a bug in Bolt, but I'm not sure if it's a bug in Bolt.", "reference": "Should this be optional, or default to 'action' as well?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this: \"sigs.k8s.io/controller-runtime\" + \"github.com/chaos-mesh/chaos-mesh/controllers/config\" + \"google.golang.org/grpc\" + \"google.golang.org/grpc\" + \"google.golang.org/grpc\" + \"google.golang.org/grpc\" + \"google.golang.org/grpc\" + \"google.golang.org/grpc\" + \"google.golang.org/grpc\" + \"google.golang.org/grpc\" + \"google.golang.org/grpc\" + \"google.golang.org/grpc\" + \"google.golang.org/grpc\" + \"google.golang.org/grpc\" + \"google.golang.org/grpc\" + \"google.golang.org/grpc\" + \"google.golang.org/grpc\" + \"google.golang.org/grpc\"", "reference": "how about formating this import?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "Comma police. :) Also, the docstring needs updating." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Implement an in-memory implementation of this in the fake driver." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Same question as the other view spec regarding not actually saving records." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Rethrow for `MustBeRethrown()`-exceptions?" }, { "prediction": "I'm not sure if this is a torch.Tensor or a torch.Tensor, but if it's a torch.Tensor, it's a torch.Tensor, and it's a torch.Tensor, so it's a torch.Tensor, so it's a torch.Tensor, so it's a torch.Tensor.", "reference": "May clean the unnecessary modification." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Should this line set the value to `x` since that is checked below?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "I don't particularly love the terminology here. Why not simply add `copy(boolean stats)` or a copy with an enum to indicate what portions of the datafile to include? At some point we may want just some of the values (e.g. CBO may want counts, but not lower/upper bounds). Just a thought." }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if it's the correct way to do it, so I'm not sure if it's the correct way to do it.", "reference": "you could probably remove keyValue and just compare idx vs ann.length (ex I think the goal here is to ensure it works with a value like `foo=`" }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if this is the correct way to do it, so I'm not sure if this is the correct way to do it.", "reference": "we do this to differentiate between the multiple cc files for when the recording is stopped / restarted multiple times within a single meeting" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "You've deleted this code but not added it anywhere else. Should this be used as my proposed example in the.ini file? Do we need a mechanism for configuring a global fallback string independent of the numeric codes?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "nit: strip away those imports? seems not used in the new code." }, { "prediction": "I'm not sure if this is a bug, but it seems to be fixed in the future.", "reference": "redundant whitespace :octocat:" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "I don't believe that the `assertDictEqual` call can pass without `api_response` being a `dict`, so this second check isn't needed!" }, { "prediction": "I don't think it's a bug, but it's a bug in h2o_hpack_decode_huffman.h2o_hpack_decode_huffman.h2o_hpack_decode_huffman.h2o_hpack_decode_huffman.h2o_hpack_decode_huffman.h2o_hpack_decode_huffman.h2o_hpack_decode_huffman.h2o_hpack_decode_huffman.h2o_hpack_decode_huffman.h2o_hpack_decode_huffman.h2o_hpack_decode_huffman.h2o_hpack_decode_huffman.h2o_hpack_decode_huffman.h2o_hpack_decode_huffman.h2o_hpack_decode_huffman.h2o_hpack_decode_huffman.h2o_hpack_decode_huffman.h2o_hpack_decode_huffman.h2o", "reference": "Fuzzer did not like this change. Looks like I misunderstood how the pool works... if allocated from a pool we should never free it manually, right? I think I'll need to drop this patch." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Wouldn't it make sense to already have title, owner etc in this class?" }, { "prediction": "@faker.version 1.8.5 + def quote + fetch('aqua_teen_hunger_force.quote') + end + # @faker.version 1.8.5 + def quote + fetch('aqua_teen_hunger_force.quote') + end + # @faker.version 1.8.5 + def quote + fetch('aqua_teen_hunger_force.quote') + end + # @faker.version 1.8.5 + def quote + fetch('aqua_teen_hunger_force.quote') + end + # @faker.version 1.8.5 + def quote + fetch('aqua_teen_hunger_force.quote') + end + # @faker.version 1.8.5 + def quote + fetch('aqua_teen_hunger_force.quote') + end + # @faker.version 1.8.5 + def quote + fetch('aqua_teen_hunger_force.quote') + end + # @faker.version 1.8.5 + def quote + fetch('aqua_teen_hunger_force.quote') + end", "reference": "New generators should have version `next`" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Wrap these two lines inside an `if (node.isMetricsEnabled() || metricsConfiguration.isPushEnabled()) {... }`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "if end_level == -1 or end_level == (self.num_ins - 1): for end_level is the Index of the end input backbone level." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "No CLR overhead?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "Consider faking the TestClient's GetProject/GetZone/GetMachine methods." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here. I'm not sure what you're trying to do here, but I'm assuming that you're trying to do something like this. I'm not sure what you're trying to do here. I'm assuming that you're trying to do something like this. I'm not sure what you're trying to do here, but I'm assuming that you're trying to do something like this. I'm not sure what you're trying to do here. I'm assuming that you're trying to do something like this, but I'm not sure what you're trying to do here. I'm assuming that you're trying to do something like this, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm assuming that you're trying to do something like this, but I'm not sure what you're trying to do here. I'm assuming", "reference": "Returning a private type as part of the public API? Isn't this impossible for users to implement?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "prefer common_properties::_canonicalRankingNumber if possible, should be quicker in general." }, { "prediction": "I'm not sure what you're trying to do here, but maybe you're trying to do something like this?", "reference": "The meaning of `loss_normalizer` and `loss_normalizer_momentum` should be reflected in docstring." }, { "prediction": "I'm not sure if this is the case, but if it's the case, it's probably the case, but it's not the case.", "reference": "Call to `cloexec_pipe` (or an equivalent function) is missing. I presume that this is the reason why you are seeing timeout errors." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "There are no changes in this file. Please reset." }, { "prediction": "This is the Q-function: the tail probability of the normal distribution. This is the Q-function: the tail probability of the normal distribution. This is the Q-function: the tail probability of the normal distribution. This is the Q-function: the tail probability of the normal distribution. This is the Q-function: the tail probability of the normal distribution. This is the Q-function: the tail probability of the normal distribution. This is the Q-function: the tail probability of the normal distribution. This is the Q-function: the tail probability of the normal distribution. This is the Q-function: the tail probability of the normal distribution. This is the Q-function: the tail probability of the normal distribution. This is the Q-function: the tail probability of the normal distribution. This is the Q-function: the tail probability of the normal distribution. This is the Q-function: the tail probability of the normal distribution. This is the Q-function: the tail probability of the normal distribution. This is the Q-function: the tail probability of the normal distribution. This is the Q-function: the tail probability of the normal distribution. This is the Q-function: the tail probability of the normal distribution.", "reference": "Should we rename this to tailProbability?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Add the issue number too i#4400" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here, so I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Why make this modifiable?" }, { "prediction": "This is a simple erc721 token bin - Erc721Binary=\"60806040523480156200001157600080fd5b5060408051808201825260068082527f4e667469657300000000000000000000000000000000000060208084019190915283518085019094529083527f4e465449455300000000000000000000000000000000000000000000000000009083015290620000af7f01ffc9a70000000000000000000000000000000000000000640100000000620001b3810204565b620000e37f80ac58cd00000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b620001177f4f558e7900000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b81516200012c90600590602085019062000220565b5080516200014290600690602084019062000220565b50620001777f780e9d6300000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b620001ab7f5b5e139f00000000000000000000000000000000", "reference": "Why this file is changed?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this.", "reference": "I'm not sure that we need this" }, { "prediction": "If (package.Value is JValue) { - dependencyVersion = package.Value[\"version\"].Value(); } else if ( (package.Value is JValue) { - dependencyVersion = package.Value[\"version\"].Value(); } else if (package.Value is JValue) { - dependencyVersion = package.Value[\"version\"].Value(); } else if (package.Value is JValue) { - dependencyVersion = package.Value[\"version\"].Value(); }", "reference": "Is this going to cause issues in any other places were someone forgets the version? Should we consider also checking for type=project?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do. I'm assuming you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Does this have retries? Is there a possibility that customer would hit throttle errors here?" }, { "prediction": "#if defined(PLATFORM_IS_FREEBSD) || defined(PLATFORM_IS_BSD) #include #endif #if defined(PLATFORM_IS_FREEBSD) #include #endif #if defined(PLATFORM_IS_BSD) #include #endif #if defined(PLATFORM_IS_FREEBSD) #include #endif #if defined(PLATFORM_IS_BSD) #include #endif #if defined(PLATFORM_IS_FREEBSD) #include #endif #if defined(PLATFORM_IS_FREEBSD) #include #endif #if defined(PLATFORM_IS_BSD) #include #endif #if defined(PLATFORM_IS_FREEBSD) #include #endif #if defined(PLATFORM_IS_BSD) #include \">

    <%= current_user.can_super_admin?? _('%{org_name} Templates') % { org_name: current_user.org.name } : _('Own Templates') %>

    ", "reference": "We definitely need to address this duplication after MVP" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This will always generate a label for the first keyword, which means this will be a label linked to no element after the first keyword is entered. This label should be generated inside the `values.map` next to the `` it is for, because the ID changes based on the index. Also, we have a `VisuallyHidden` component I'd prefer we use over the CSS class. Building as many things out of components is more React-y. Admittedly it's sort of a preference, but it's why we have the `VisuallyHidden` component. So let's use that instead" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Does it make sense for this to be fatal? Could there be an embedded application that does not have xcursor themes at all? For instance, compositors without a pointer (like a touch-screen kiosk) will never show a cursor. I think I'm ok with this assumption since it simplifies the code and rootston is assumed to have desktop features, but we should always make sure xcursor is not required to be used in the library." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if it's what you're trying to do, but I'm guessing it's what you're trying to do.", "reference": "would rename to TopicsFilter and original one to SequenceTopicsFilter" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Is the idea that ``self.keys[0]`` here normally matches ``init_key``?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, and it's a bug.", "reference": "Can this be clarified to \"Exit early when hwnd is the windows desktop handle, UiaHasServerSideProvider would return false anyway.\"?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I'm okay with leaving VCPULimit and MemoryLimit on our internal model" }, { "prediction": "@ -73,6 +73,10 @ @ const ( defaultWorkers = 4 // Default rule priority for K8s NetworkPolicy rules. defaultRulePriority = -1 + // TierIndex is used to index ClusterNetworkPolicies by Tier names. + TierIndex = \"tier\" + // maxSupportedTiers is the maximum number of supported Tiers. + maxSupportedTiers = 10 )", "reference": "5 or 10?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Should we explain more here?" }, { "prediction": "I'm not sure if this is the correct way to do this, but if it is the correct way to do it, then it should work.", "reference": "I've been struggling with this on my cloud-init integration work as well. In addition to info that is currently stored in the cluster providerstatus, we also need some of the info that is available within the base cluster object as well. I think it would make sense to unify the machine and cluster info needed into a consolidated struct rather than continuing to add additional disparate structs." }, { "prediction": "I'm not sure if this will work without the package prefixes. * * @author Brian Remedios + * @deprecated Is internal API deprecated? * * @author Brian Remedios + * @deprecated Is internal API deprecated? * * @author Brian Remedios + * @deprecated Is internal API deprecated?", "reference": "Why not `@InternalApi`?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "FYI: `GenericMeta` is renamed to `_GenericAlias` in Python3.7." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "So this hides the link to re-order sections on Historic Templates? Good catch, Just checked on DMPonline and hitting that throws a 404" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Is `Reporter#reset` no longer used? If so, can we remove it?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm sure it's a bug.", "reference": "same concern here about difference in the write scalar implementation. I am not sure if this could present a consensus problem or not" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm assuming it's what you're trying to do.", "reference": "Can we remove this file?" }, { "prediction": "I think it's a bug, but I think it's a bug, so it's a bug.", "reference": "Why listing only first error reason (`ErrStatus.Details.Causes[0].Message`)?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to use the same sequence number as the one you're using in your code. I'm guessing you're using the same sequence number as the one you're using in your code, but I'm guessing you're using the same sequence number as the one you're using in your code, so I'm guessing you're using the same sequence number as the one you're using in your code.", "reference": "Now that this is true, do we have to ignore it with V1 Tables?" }, { "prediction": "I'm not sure if this is the case, but I think it's the case. I'm not sure if this is the case, but I think it's the case.", "reference": "prefer if (condition) { stuff; } to if!(condition) { continue; } stuff" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Should this section not be converted to a secondary action list?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "This askes a blocking question, which means a local Qt eventloop will be running. While this is unavoidable sometimes, the async functions should be used whenever possible (`message.confirm_async` in this case). This means: - Split everything after this question in a separate private method (you can probably just call it `_tab_close`) - If the tab is not pinned, just call `_tab_close` directly - If it is pinned, call `message.confirm_async` with `yes_action=self._tab_close`" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but if it's the case, it's the case.", "reference": "Can we deuglify this?" }, { "prediction": "I'm not sure what you're trying to do here, but I think it's a good idea.", "reference": "@skestle Just recognized that the `::apply` is not necessary. Does it compile if you leave it away? Could you please check that, I'm on vacation and have no IDE at hand... Thx!" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to build a new spec using the table's schema, which uses fresh IDs. I'm guessing you're trying to build a new spec using the table's schema, which uses fresh IDs, but you're trying to build a new spec using the table's schema, which uses fresh IDs + // build the new spec using the table's sche + // ma, which uses fresh IDs PartitionSpec newSpec = PartitionSpec.builderFor(base.schema()).bucket(\"data\", 16).bucket(\"id\", 4).bucket(\"id\", 4).bucket(\"id\", 4).bucket(\"id\", 4).bucket(\"id\", 4).bucket(\"id\", 4).bucket(\"id\", 4).bucket(\"id\", 4).bucket(\"id\", 4).bucket(\"id\", 4).bucket(\"id\", 4).bucket(\"id\", 4).bucket(\"id\", 4).bucket(\"id\", 4).bucket(\"id\", 4).bucket(\"id\", 4).bucket(\"id\", 4).bucket(\"id\", 4).bucket(\"id\", 4).bucket(\"id\", 4).bucket(\"id\", 4).bucket", "reference": "Looks like this is an unnecessary change." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like 'instancegroupmanager' or 'instancegroupmanager' or 'instancegroupmanager' or 'instancegroupmanager' or 'instancegroupmanager' or 'instancegroupmanager' or 'instancegroupmanager'", "reference": "This one won't change as the resource is not included in the project getting tested with the composite root." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "We have `stdbool` imported, might as well use that for clarity." }, { "prediction": "I'm not sure if this is what you're looking for, but it should be something like this:", "reference": "Why do we not also have integration tests for postgres?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like it should work.", "reference": "I think its safe to remove this if we're removing `reIndex` outright. The description shows us that the test is \"An example showing how to force a reindex of a collection\"" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Can you make this hexadecimal to match the other constants?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Can this get moved to `Bolt::Project#validate`?" }, { "prediction": "@ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ @", "reference": "I'm pretty sure it doesn't harm, but don't we have a second pass here with the reverse() operation?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "This is not a standard capability and should be hidden behind a vendor prefix: -chromium-takesHeapSnapshot" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but if I'm correct, I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "This shouldn't work with pointers -- prefer references unless you can meaningfully pass `nullptr`. The address-of operator here is clunky at best." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Sidenote: some day we'll drop the avr-gcc and avr-libc dependencies so that this case becomes supported." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "do we still need this method?" }, { "prediction": "I'm not sure if this is the case, but I think it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "It's better to not leave this old code here... it just clutters things up and makes reading the code more confusing. We can always recover the old code from the repository if needed." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Again, you don't want to depend on glassfish." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "This shouldn't be required. What was going on here?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but if it's the case, it's probably the case.", "reference": "Why add this here?" }, { "prediction": "I'm not sure if this is what you're looking for, but if it's what you're looking for, it's probably what you're looking for.", "reference": "nullability does not apply to headers type (that is always an object)" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Do we also need to add the iova, or is that done somewhere else?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "why change this?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "If there is no guarantee that tv_sec is of type `time_t`, IMO you should copy the value instead of enforcing a pointer typecast." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, then it's a bug.", "reference": "Should we validate the suffix before going to the filesystem?" }, { "prediction": "I'm not sure what you mean by \"ddev_default\", but I think you mean \"ddev_default\" instead of \"ddev_default\". I think you mean \"ddev_default\" instead of \"ddev_default\". I think you mean \"ddev_default\" instead of \"ddev_default\". I think you mean \"ddev_default\" instead of \"ddev_default\". I think you mean \"ddev_default\" instead of \"ddev_default\". I think you mean \"ddev_default\" instead of \"ddev_default\".", "reference": "It feels like we should be working to reduce/eliminate our global vars. I'm not sure it adds much here. Any objection to just removing it?" }, { "prediction": "I think this is what you're looking for.", "reference": "did you consider using AR enums for this? would give us all the boolean methods (`weekly?` etc) for free" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "This may change \"\" into None. Better return filename." }, { "prediction": "I'm not sure if this will work for you, but it should work for you.", "reference": ":+1: That does resolve my security concerns about this feature." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Could you add a docstring?" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Shouldn't this still be `Region()`?" }, { "prediction": "The-Compiler/qutebrowser/issues/117", "reference": "This shouldn't be here but `self.connected = None` in `__init__` instead, otherwise that'd be an attribute which is set this way in _every_ instance of that class (i.e. a class rather than an instance variable). I'd also say let's make it \"private\" (i.e. `_connected`) and please add a quick note about what it is to the docstring of the class." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "This would be better served as a method/property that is set when people don't want to a window." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "I was dubious about putting getNonStreamingMethods in the context, but after some thought, I have decided to embrace the approach. In this particular case, the loop is supposed to be over page streaming methods. So, could you add a getPageStreamingMethods() method in the context, use it here, and remove the isPageStreaming() check below?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "LooseVersion class can help here" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, then it's a bug.", "reference": "`const Dims zeros(shape.size(), 0);`" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "Would be good for this not to say `10` anymore..." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do, so I'm not sure if this is what you're trying to do.", "reference": "See above, we don't need to pass the module name here." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "This is random line :-) overridden String type by custom trimmed - please change that commit message to something like \"introduced custom String type with automatic trimming\"" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so it's a bug.", "reference": "My personal taste: \"depreciated\" -> \"deprecated\"" }, { "prediction": "@@ -58,6 +58,8 @@ var ( \"destinationPodName\", \"destinationPodNamespace\", \"destinationNodeName\", \"destinationClusterIP\", \"destinationServiceName\", \"destinationClusterIP\", \"destinationServiceName\", \"destinationClusterIP\", \"destinationServiceName\", \"destinationClusterIP\", \"destinationServiceName\", \"destinationClusterIP\", \"destinationServiceName\", \"destinationClusterIP\", \"destinationServiceName\", \"destinationClusterIP\", \"destinationServiceName\", \"destinationServiceName\", \"destinationClusterIP\", \"destinationServiceName\", \"destinationClusterIP\", \"destinationServiceName\", \"destinationServiceName\", \"destinationClusterIP\", \"destinationServiceName\", \"destinationClusterIP\", \"destinationServiceName\", \"destinationClusterIP\", \"destinationServiceName\", \"destinationServiceName\", \"destinationClusterIP\", \"destinationServiceName\", \"destinationClusterIP\", \"destinationServiceName\", \"destinationClusterIP\", \"destinationServiceName\", \"destinationServiceName\", \"destinationClusterIP\", \"destinationServiceName\", \"destinationClusterIP\", \"destinationServiceName\", \"destinationServiceName\", \"destinationClusterIP\", \"destinationServiceName\", \"destinationServiceName\", \"destinationClusterIP\", \"destinationServiceName\", \"destinationServiceName\", \"destinationClusterIP\", \"destinationServiceName\", \"destinationClusterIP\", \"destinationServiceName\", \"destinationServiceName\", \"destinationClusterIP\", \"destination", "reference": "this includes the port as well right? should the name be `destinationServicePortName`?" }, { "prediction": "I'm not sure if this is a bug, but it's probably a bug.", "reference": "We can import all of them in one line." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "this was wrong, the rest were just inconsistent :)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I gave them the EXACT SAME NAMES in my branch :)" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug, but I think it's a bug.", "reference": "What would you think stat'ing the directory first before doing the log+mkdirall and only proceeding if the directory does not exist? The logging might be less confusing (I'd be wondering why it was logging that it was creating the directory when I knew it already existed)." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Sorry about the confusion, I'm trying to address that in the PR follow-up. If we ever have `Span` objects, then accessing their properties is going to be safe. The only question remaining is \"What is the runtime type for Scope.Span?\" and we just have to account for it when it is `Datadog.Trace.Span` and when it is not" }, { "prediction": "I'm not sure if it's a bug, but it's definitely a bug.", "reference": "I was using this imports for writing the results to file to more easily check that it was valid JSON. You can probably remove these `java.io` imports." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "You should probably include a `json:...` annotation here." }, { "prediction": "@ -38,6 +38,7 @ @ import ( const ( ecsMaxReasonLength = 255 + ecsMaxRuntimeIDLength = 255 pollEndpointCacheSize = 1 pollEndpointCacheTTL = 20 * time.Minute roundtripTimeout = 5 * time.Second ) )", "reference": "can container ID > 255 chars? why are we doing this check?" }, { "prediction": "The value of this field must match the one from :other.','size' => [ 'numeric' => 'The value of this field must be :size.', 'numeric' => 'The value of this field must be :size.', 'numeric' => 'The value of this field must be :numeric.', 'numeric' => 'The value of this field must be :numeric.', 'numeric' => 'The value of this field must be :numeric.', 'numeric' => 'The value of this field must be :numeric.', 'numeric' => 'The value of this field must be :numeric.', 'numeric' => 'The value of this field must be :numeric.', 'numeric' => 'The value of this field must be :numeric.', 'numeric' => 'The value of this field must be :numeric.', 'numeric' => 'The value of this field must be :numeric.', 'numeric' => 'The value of this field must be :numeric.', 'numeric' => 'The value of this field must be :numeric.', 'numeric' => 'The value of this field must be :numeric.', 'numeric' => 'The value of this field must be :numeric.', 'numeric' => 'The value of this field must be", "reference": "*\"This **field field** prohibits :other from being present.\"*, **field** word repeated is right?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "nit: no need to add an alias for this case." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Or `QUIC_LOG_LEVEL`. Which one do you prefer?" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, then it's a bug.", "reference": "Minor: you can set it to byte here and only set it to *virtualDiscDesc.CapacityAllocationUnits if that's not nil/\"\". Saves two lines" }, { "prediction": "I think this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "While reading this I found that it makes actually little sense for \"beers\" to have a \"fingerprint\". We might want to do another pass on the examples here to use something that actually makes more sense to the reader. This could be done in another issue." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do.", "reference": "Thank you! That's better, especially the conversion test should not test the mkString method :)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "You're basically converting client to screen coordinates here, doing it manually. Is there a specific reason why you aren't using clientToScreen here? Does it fail?" }, { "prediction": "I'm not sure if this is the case, but if it's the case, it's the case. If it's the case, it's the case.", "reference": "This needs to be done for server-side copies too, earlier in the function." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Do we want to add in `profile` here as well so we request access to the end user's default profile claims like name?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I am not sure what the difference between approving and full approving is..." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but it seems like you're looking for \"github.com/sirupsen/logrus\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcalico/felix/iptables\" or \"github.com/projectcal", "reference": "Please back out the import changes in files you haven't touched. I think these happen if you run goimports without having the vendor directory populated" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "Many tests in this class seem to have just been fortunate that `SolrIndexSearcher` ignored `fl` and retrieved all fields when not using lazy loading." }, { "prediction": "I think you should have received a copy of the GNU General Public License # along with Scapy. If not, see . -# scapy.contrib.description = GENEVE +# flake8: noqa: noqa: E501 + +# scapy.contrib.description = Generic Network Virtualization Encapsulation (GENEVE) # scapy.contrib.status = # scapy.contrib.status = # scapy.contrib.status = # scapy.contrib.status = # scapy.contrib.status = # scapy.contrib.status = # scapy.contrib.status = # scapy.contrib.status = # scapy.contrib.status = # scapy.contrib.status = # scapy.contrib.status = # scapy.contrib.status = # scapy.contrib.status = # scapy.contrib.status = # scapy.contrib.status = # scapy.contrib.status = # scapy.contrib.status = # scapy.contrib.status = # scapy.contrib.status = # scapy.contrib.status = # scapy.contrib.status = # sc", "reference": "Is this really needed?" }, { "prediction": "Is there a way to do this? If not, is there a way to do this?", "reference": "Is this necessary with line 38?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're trying to install pytest-cov, pytest-benchmark, pytest-cov, pytest-cov, pytest-benchmark, pytest-cov, pytest-benchmark. I'm not sure if this is what you're looking for, but it seems like you're trying to install pytest-cov, pytest-cov, pytest-benchmark, pytest-cov, pytest-benchmark, pytest-cov, pytest-cov, pytest-benchmark, pytest-cov, pytest-cov, pytest-benchmark, pytest-cov, pytest-cov, pytest-cov, pytest-benchmark, pytest-cov, pytest-cov, pytest-cov, pytest-benchmark, pytest-cov, pytest-cov, pytest-benchmark, pytest-cov, pytest-cov, pytest-cov, pytest-benchmark, pytest-cov, pytest-cov, pytest-benchmark, pytest-cov, pytest-cov, pytest-cov, pytest-benchmark, pytest-cov, pytest-cov, pytest-cov, pytest-benchmark, pytest-cov, pytest-cov, pytest-benchmark, pytest-cov, pytest-cov, pytest-cov, pytest-cov, pytest", "reference": "DO we want to have >= here? Or ==" }, { "prediction": "The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service. The version of the profiled service", "reference": "Can you also add this `\"version\"` tag to the CoreTags? Now that we're targeting the service/env/version trio" }, { "prediction": "I think this should work, but I'm not sure why it's not working, so I'm not sure why it's failing, but I'm not sure why it's failing, so I'm not sure why it's failing.", "reference": "This entry will be incompatible with the currently implemented formatting rules. Maximum 120 characters per line." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but I think it's what you're looking for.", "reference": "Let's call this color_host_output or some such - preserve_host_output makes it sound like you won't get any output without this being set." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this: I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "suggestion: if we perhaps make `attributes` a getter in `virtualNode`, it does look seamless to access the property, same as what we have done for `isFocusable` or `tabbableElements`. `node.attributes` can become `virtualNode.attributes`" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "I think a float value fits better." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "This should be (POST,DELETE) `/pss/subscribe/{topic}` for subscriptions and there should be `/pss/send/{topic}` for sending." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "Closing over the closure arguments is a neat trick :+1: Love it :100:" }, { "prediction": "@Test public void testCaseSensitiveNot() { this.assertThrows( \"X!= x when case sensitivity is on\", - ValidationException.class, - \"Cannot find field 'X' in struct\", - () -> { new Evaluator(STRUCT, not(equal(\"X\", 7)), true); } - ); this.assertThrows( \"X!= x when case sensitivity is on\", + ValidationException.class, + \"Cannot find field 'X' in struct\", + () -> { + new Evaluator(STRUCT, not(equal(\"X\", 7)), true); + }); this.assertThrows( \"X!= x when case sensitivity is on\", + ValidationException.class, + \"Cannot find field 'X' in struct\", + () -> { + new Evaluator(STRUCT, not(equal(\"X\", 7)), true); + }); } @Test public void testCaseSensitiveNot() { this.assertThrows( \"X!= x when case sensitivity is on\", - ValidationException.class, - \"Cannot find field 'X' in struct\", - ValidationException.class, - \"Cannot find field 'X' in struct\", - ValidationException.class, - \"Cannot find field 'X' in struct\", -", "reference": "Does this need to be a block or can it be an expression?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if this is the correct way to do it.", "reference": "req.getQueryString()!= null is not necessary since same check is already done in allowedPostRequest" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "As per go/actools-regapic-design, in the final product, generated GAPICs must be able to support multiple transports if supported by the API. For Java, we'll support this in the microgenerator; the monolith generates single-transport GAPICs. For PHP, the situation is likely similar, though on a longer timescale. All this to say that I would appreciate structuring the code in terms of \"supports REST\" rather than \"REST only\", but only where this doesn't require undue work. For everything else, please add a TODO to the effect of \"we're generating single-transport GAPICs for now, though in the fullness of time we'll generate multi-transport GAPICs.\"" }, { "prediction": "@ -13,5 +13,5 @@ return [ */ 'failed' => '\u06cc\u06c1 \u062a\u0641\u0635\u06cc\u0644\u0627\u062a \u06c1\u0645\u0627\u0631\u06d2 \u0631\u06cc\u06a9\u0627\u0631\u0688 \u0633\u06d2 \u0645\u0637\u0627\u0628\u0642\u062a \u0646\u06c1\u06cc\u06ba \u0631\u06a9\u06be\u062a\u06cc\u06ba\u06d4', - 'throttle' => '\u0644\u0627\u06af \u0627\u0650\u0646 \u06a9\u0631\u0646\u06d2 \u06a9\u06cc \u0628\u06c1\u062a \u0632\u06cc\u0627\u062f\u06c1 \u06a9\u0648\u0634\u0634\u06cc\u06ba\u06d4 \u0628\u0631\u0627\u06c1\u0650 \u0645\u06c1\u0631\u0628\u0627\u0646\u06cc \u06a9\u0686\u06be \u0633\u06cc\u06a9\u0646\u0688\u0632 \u0645\u06cc\u06ba \u062f\u0648\u0628\u0627\u0631\u06c1 \u06a9\u0648\u0634\u0634 \u06a9\u0631\u06cc\u06ba\u06d4', ];", "reference": "here is `:seconds` missing again" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to stub a method that doesn't have a method_name. I'm guessing you're trying to stub a method that doesn't have a method_name, so I'm guessing you're trying to stub a method that doesn't have a method_name, so I'm guessing you're trying to stub a method that doesn't have a method_name, so I'm guessing you're trying to stub a method that doesn't have a method_name, so I'm guessing you're trying to stub a method that doesn't have a method_name, so I'm guessing you're trying to stub a method that doesn't have a method_name, so I'm guessing you're trying to stub a method that doesn't have a method_name, so I'm guessing you're trying to stub a method that doesn't have a method_name.", "reference": "Changed this helper to also get class name." }, { "prediction": "I'm not sure if this is the correct way to do it.", "reference": "I think there's another spot for this in DefaultCapabilityMatcher" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Why the rename from PONY_SCHED_BATCH? ACTOR_DEFAULT_BATCH is less meaningful to me than SCHED_BATCH." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Let's be sure we have an issue that tracks this, filed against testnet." }, { "prediction": "I'm not sure if this is what you're trying to do, but if this is what you're trying to do, then you'll need to change it to this.encodings['binary'].converters = this.encodings['binary'].converters = this.encodings['binary'].converters = this.encodings['binary'].converters + this.encodings['binary'].converters = this.encodings['binary'].converters + this.encodings['binary'].converters = this.encodings['binary'].converters + this.encodings['binary'].converters = this.encodings['binary'].converters + this.encodings['binary'].converters + this.encodings['binary'].converters = this.encodings['binary'].converters + this.encodings['binary'].converters + this.encodings['binary'].converters = this.encodings['binary'].converters + this.encodings['binary'].converters + this.encodings['binary'].converters + this.encodings['binary'].converters = this.encodings['binary'].converters + this.encodings['binary'].converters + this.encodings['binary'].converters + this.encodings['binary'].converters = this.encodings['binary'].converters + this.", "reference": "There should be no space before!Buffer" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:

; + }, { + padding: 0, }, { + padding: 0, }, { + padding: 0, }, { + padding: 0, }, { + padding: 0, }, { + padding: 0, }, { + padding: 0, }, { + padding: 0, }, { + padding: 0, }, { + padding: 0, }, { + padding: 0, }, { + padding: 0, }, { + padding: 0, }, { + padding: 0, }, { + padding: 0, }, { + padding: 0, }, { + padding: 0, } );", "reference": "Same here, we need the default padding for this story." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "I think this should go away, its noise in the grand scheme of things." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Maybe just call `ioutil.WriteFile` with 0 bytes? And Make an error log `log.Error` if any error occurs." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "`this.ieService_` should be initialized to null in the constructor." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I just noticed that we use Return here, when we have logically allowed a packet, whereas in the forward chain we use AcceptAction. Do you know why that is?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "This is public method, we need to deprecated this method first and add new updated method for it." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "I think that you don't want to have these workarounds; you want to make sure that the relayTemplates is configured correctly. If not, we need to fix it there." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "This field is not needed." }, { "prediction": "CancellationsController.rb: def create_cancellation(cancellation_params) if cancellation_params[:reason] is not None then redirect_to(cancellation_params[:reason]) else redirect_to(cancellation_params[:reason]) end end end", "reference": "Put a comma after the last parameter of a multiline method call." }, { "prediction": "I'm not sure if this is a bug, but it seems to be fixed in the future.", "reference": "move to line 18 below" }, { "prediction": "I think this is what you are looking for: https://github.com/aws/aws-sdk-s3/blob/master/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk-s3/src/aws-sdk", "reference": "Simple Storage **Service**" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "Thats odd, I'd actually not expect this output at all..." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "As a side note, I get why this is up here (sort order), but it'd be easier to not forget to update it if it were down next to `1.x` -- would it be acceptable to make that change the next time I make this sort of PR? :smile: :innocent: (don't want to hold this one up since folks are blocked on getting this one in, it's a pretty superficial change, and I probably won't have cycles again for a few days to update the PR with the change :sweat_smile:)" }, { "prediction": "I'm not sure if this is the expected behavior, but I'm not sure if this is the expected behavior, so I'm not sure if this is the expected behavior.", "reference": "this class is permissioning so let's keep \"Onchain\" here" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for.", "reference": "we can be more specific to call out the it is \"AutoRest C# code generator\"?" }, { "prediction": "I'm not sure if this is what you're looking for, but it's probably what you're looking for. I'm not sure if this is what you're looking for, but it's probably what you're looking for.", "reference": "Ditto for not adding this to the axe namespace." }, { "prediction": "@ -0,0 +1 @@ +package registration", "reference": "Should we just remove this file? Having it present but empty feels misleading" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Would it make sense to include an `Untrust` as well? If I were playing around with this on the CLI I wouldn't want to make a change I couldn't undo." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing it's a bug.", "reference": "It might be better to call this `$createRecordMethod` since it's not a full PHP callback, just a method name for the plugin manager." }, { "prediction": "I'm not sure if it's a bug, but it seems to be a bug.", "reference": "remove this line" }, { "prediction": "I'm not sure if this is what you are looking for, but it seems like you're looking for something like this:", "reference": "I've never seen this syntax before, it's still just an array, the difference is that it's an array of MainMenuItems instead of an array of arrays." }, { "prediction": "We've seen many different GDI---------------------------------------------------------------------------------------------------------------------------------------------", "reference": "nit: to match the others: s/private/Private/" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "Maybe just IEnumerable? Not sure myself." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to create a table from a table that doesn't exist in a table that doesn't exist in a table that doesn't exist in a table that doesn't exist in a table that doesn't exist in a table that doesn't exist in a table that doesn't exist in a table that doesn't exist in a table that doesn't exist in a table that doesn't exist in a table that doesn't exist in a table that doesn't exist in a table that doesn't exist in a table that doesn't exist in a table that doesn't exist in a table that doesn't exist in a table that doesn't exist in a table that doesn't exist in a table that doesn't exist in a table that doesn't exist in a table that doesn't exist in a table that doesn't exist yet.", "reference": "do we need this change?" }, { "prediction": "We need to do this in a loop, so that we don't need to do this in a loop.", "reference": "Would want @matthiashanel to have a look since if I recall he had to add the shallowCopy() to fix some bugs during reload. That being said, since I believe the $G account cannot referenced in configurations, this should not be a problem, but Matthias has looked at this in more details in the past." }, { "prediction": "I'm not sure if this is the case, but if it's the case, then it's the case.", "reference": "The descriptions are incorrect" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "if we are returning the `ws` here when passing in `se:cdp` we can just return it straight or do we have to make a request to get the `ws` address?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Please only indent this by four spaces." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "What's the reason behind these characters?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Minor: The name of this specs seems a little off now" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "I'd suggest using `ast_error_continue` here to get the `apply` message in the `Info` part of the error report." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "If we decide to change the name of the.ini setting, we might also want to review the naming of this property and related code. Maybe a simple `getOptions` or `getSettings` would be more concise than `getTabDetailConfig`. At very least, I don't think we need Tab in the method name since the method belongs to a helper with \"Tabs\" in the name." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Use const for \"user\", same as below" }, { "prediction": "I think this is a bug, but it should be fixed in the latest version.", "reference": "->setUnsubscribed(false) would be better :)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I now think singular `Sport` is better, but I will wait for the first round of feedback before updating." }, { "prediction": "I'm not sure if this is what you want, but I think it's a good idea.", "reference": "Don't you need = something?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "Looks like this could be `const` (I realize it wasn't like that before)?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Maybe just `FAILED`. We can't be sure loading was the thing that failed." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do, but if it's what you're trying to do, I'm guessing you're trying to do, and if it's what you're trying to do, I'm assuming it's what you're trying to do. If it's what you're trying to do, I'm assuming it's what you're trying to do. If it's what you're trying to do, I'm assuming it's what you're trying to do. If it's what you're trying to do, I'm assuming it's what you're trying to do. If it's what you're trying to do, I'm assuming it's what you're trying to do. If it's what you're trying to do, I'm assuming it's what you're trying to do. If it's what you're trying to do, I'm assuming it's what you're trying to do. If it's what you're", "reference": "You have replaced single quotes with double ones, this fails linting and our current coding style. Please fix this, otherwise it's a whopping of 1200 LoC while in reality it should be rather small." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "@danieloeh @TomHennen. Some of these files are using spaces, the others use tabs. Is there a project wide preference? I personally like spaces, because they are consistent across editors" }, { "prediction": "I'm not sure if this is what you are looking for, but I think this is what you're looking for.", "reference": "I guess this is ok for backwards-compatibility? Maybe it'd be better to check arity in the helpers? Or just call it out in the release notes, because there are at least a couple projects on github that overrode `initialize`.." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "At some point, we would like to get rid of these custom injections as well. Looks Ok for now." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "nit: Not a fan of \"fix\" in the name, but don't have a better suggestion" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Since we're calling `self.tab_url(idx)` a third time here already, can you please add a `url = self.tab_url(idx)` somewhere above (e.g. after all the `fields[...] =...` assignments) and change the calls here to `url.host()` etc.?" }, { "prediction": "ForsetiInstaller is a package that can be imported from the Forseti CLI installer. ForsetiInstaller is a package that can be imported from the Forseti CLI installer. ForsetiInstaller is a package that can be imported from the Forseti CLI installer. ForsetiClientInstaller is a package that can be imported from the Forseti CLI installer. ForsetiClientInstaller is a package that can be imported from the Forseti CLI installer. ForsetiClientInstaller is a package that can be imported from the Forseti CLI installer. ForsetiClientInstaller is a package that can be imported from the Forseti CLI installer. ForsetiClientInstaller is a package that can be imported from the Forseti CLI installer. ForsetiClientInstaller is a package that can be imported from the Forseti CLI installer. ForsetiClientInstaller is a package that can be imported from the Forseti CLI installer. ForsetiClientInstaller is a package that can be imported from the Forseti CLI installer. ForsetiClientInstaller is a package that can be imported from the Forseti CLI installer. ForsetiClientInstaller is a package that can be imported from the Forseti CLI", "reference": "alphasort this import" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "remove this file!" }, { "prediction": "I'm not sure if this is what you're looking for, but if it's the case, then it's probably the case.", "reference": "You don't need to say `rune(' ')` - `' '` is already a `rune`." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "We can't freeze this and then add something to it in the next line. The `freeze` on line 43 is sufficient. If Rubocop flags this we need to exclude it." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "We call it Kind2 and move out of the `javaslang/control` package into the `javaslang`package. Maybe I will later generate Kind1..Kindn but that's another story." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "i think it might be nicer to have a message like: `database capacity: %d chunks (%d bytes, %d megabytes)`. counting in bytes is so 90s :)" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug, but it's a bug.", "reference": "The '.' in the key names are used to separate namespaces, NOT to separate words. How about azkaban.external_resources.resource_manager? ---- Why is it better than using the full name in the variable name e.g. RESOURCE_MANAGER_LINK?" }, { "prediction": "I'm using OpenTelemetry.Trace.Samplers instead of OpenTelemetry.Trace.Samplers. I'm using OpenTelemetry.Trace.Samplers instead of OpenTelemetry.Trace.Samplers. I'm using OpenTelemetry.Trace.Samplers. I'm using OpenTelemetry.Trace.Samplers. I'm using OpenTelemetry.Trace.Samplers. I'm using OpenTelemetry.Trace.Samplers. I'm using OpenTelemetry.Trace.Samplers. I'm using OpenTelemetry.Trace.Samplers. I'm using OpenTelemetry.Trace.Samplers. I'm using OpenTelemetry.Trace.Samplers. I'm using OpenTelemetry.Trace.Samplers. I'm using OpenTelemetry.Trace.Samplers. I'm using OpenTelemetry.Trace.Samplers. I'm using OpenTelemetry.Trace.Samplers. I'm using OpenTelemetry.Trace.Samplers. I'm using OpenTelemetry.Trace.Samplers. I'm using OpenTelemetry.Trace", "reference": "This seems to be duplicated with line 19?" }, { "prediction": "#if!(defined(_WIN32) || (defined(__WXMAC__) && (MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_4))) -#include +#include #endif #include \"stdwx.h\" #endif", "reference": "This is wrong. xlocale.h is needed on OSX and maybe elsewhere too. This needs a test in configure to see if xlocale.h and uselocale() are available and an #if test here. Also, the NO_PER_THREAD_LOCALE stuff in configure.ac needs to be updated to include test for uselocale()." }, { "prediction": "I think this is what you're looking for: https://docs.aws.amazon.com/aws-access-management/latest/reference/aws-access-management.html#aws-access-management", "reference": "AWS Identity and Access Management (IAM)" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Why did you have multiple function calls here instead of having one long array of supported mimeTypes? In line with your PR here, I think we might eventually see inline videos or inline pdf. It would be great to generalize this a bit." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "nit: shall we keep alphabetical order?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "We could just move the check for function into `typeForConstruction` to make this a one liner every time we need to do this." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "A correct by unrelated change. We'll slide this one in without another word ;)" }, { "prediction": "I don't think you'll be able to do this, but I think you'll be able to do something like this.", "reference": "I feel that a slightly safer way is to do if (param_.has_device_id()) { Caffe::SetDevice(param_.device_id()); } just in case a user has hard-coded a device id outside the solver and does not specify the device id in the solver param. Currently, if nothing is set, the solver will always use the 0th device, which might not be desired." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "let's replace this example with something that won't fail in Python. Like \"for+if+print\"" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Please remove the brackets and use `string_type` from `compat.py` module instead of `str` in `isinstance()`." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "line is 143 characters (from `lll`)" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "It should follow a `continue`." }, { "prediction": "I'm not sure if it's a bug, but it's a bug in mariadb-database.", "reference": "Should this be DBWorkingDir?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug.", "reference": "I think you can remove the whole line." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Not a big deal, but what is the value of adding this status condition for a failure to delete a client? It has some value for a dataverse admin, to know that the last attempt to harvest from a certain server resulted in a failure. Is it really useful to know that an attempt to delete a client failed? - should the startup check simply remove the \"delete in progress\" flag quietly instead? After all, seeing how the client is still there makes it somewhat clear that the attempt to get rid of it didn't work out, so they should try again? I may be missing some situation where it could actually be useful - so I'm open to hearing it." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "Can we also update the equality delete branch below?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This doesn't solve the entire problem we talked abut yesterday, right? Because it's possible that the step itself didn't skip, but rather that it chose not to yield the output in question?" }, { "prediction": "import base64 +from datetime import datetime from hashlib import sha256 import json import os os.environ['DJANGO_SETTINGS_MODULE'] = 'base64' os.environ['DJANGO_SETTINGS_MODULE'] = 'base64' os.environ['DJANGO_SETTINGS_MODULE'] = 'base64' os.environ['DJANGO_SETTINGS_MODULE'] = 'base64' os.environ['DJANGO_SETTINGS_MODULE'] = 'base64' os.environ['DJANGO_SETTINGS_MODULE'] = 'base64' os.environ['DJANGO_SETTINGS_MODULE'] = 'base64' os.environ['DJANGO_SETTINGS_MODULE'] = 'base64' os.environ['DJANGO_SETTINGS_MODULE'] = 'base64' os.environ['DJANGO_SETTINGS_MODULE'] = 'base64' os.environ['DJANGO_SETTINGS_MODULE'] = 'base64' os.environ['DJANGO_SETTINGS_MODULE'] = 'base64' os.environ['DJANGO_SETTINGS_MODULE'] = 'base64' os.environ['DJANGO_SETTINGS_MODULE'] = 'base64' os.environ['DJANGO_SETTINGS_MODULE'] = 'base", "reference": "I also do not see any usages of this import. Is this a fix for a crash?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Feels like this needs to be invoked in `PostUnmarshalTask` since that's where most of the task setup happens." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "I wonder what would happen if the granteeName becomes DB__ROOT but the granteeID is not DB__ROOT ID (33333) but something else." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Feel like this should probably come into this tool as a flag rather than it just grabbing an env var internally?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings." }, { "prediction": "I18n.t( - 'dashboards.show.contact_your_mentor', +'shared.header.contact_your_mentor','shared.header.contact_your_mentor','shared.header.contact_your_mentor','shared.header.contact_your_mentor','shared.header.contact_your_mentor','shared.header.contact_your_mentor','shared.header.contact_your_mentor','shared.header.contact_your_mentor','shared.header.contact_your_mentor','shared.header.contact_your_mentor','shared.header.contact_your_mentor','shared.header.contact_your_mentor','shared.header.contact_your_mentor','shared.header.contact_your_mentor','shared.header.contact_your_mentor','shared.header.contact_your_mentor','shared.header.contact_your_mentor','shared.header.contact_your_mentor','shared.header.contact_your_mentor','shared.header.contact", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "nit: folders are always a numeric ID, projects as given by CAI use project number for ancestry" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a good idea to use `p2p.Service` instead of `p2p.Service`", "reference": "is this used anywhere?" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "change pkg_errors to errors. Keep it consistent across all the files." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "I don't see any test cases which would test that fix dates are set properly on review status changes / storage events. For this reason please create some more test cases and also check my scenarios above." }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "This belongs to SwaggerModeler.cs `public override ServiceClient Build()`" }, { "prediction": "I think this is what you are looking for.", "reference": "We could go further and directly give the tips of the `columns` property for someone (like me) who would like to specify some column width and let the others be autosized." }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "I think a `std::copy` with `std::back_inserter` will get this done in one call." }, { "prediction": "We don't support this in QUIC 36, so we don't support it in QUIC 36, so we don't support it in QUIC 36, so we don't support it in QUIC 36, so we don't support it in QUIC 36, so we don't support it in QUIC 36, so we don't support it in QUIC 36, so we don't support it in QUIC 36, so we don't support it in QUIC 36, so we don't support it in QUIC 36, so we don't support it in QUIC 36, so we don't support it in QUIC 36, so we don't support it in QUIC 36, so we don't support it in QUIC 36, so we don't support it in QUIC 36.", "reference": "In the future: s/QUIC 36/Version36/ to make grepping easier" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "This is an example of why I prefer a flexible custom `render()` solution 'on'/'off' may not be the right value for every application. You have to make a lot of decisions even for very simple form fields :(" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "we should also skip the e2e flow aggregator tests if the Flow Exporter feature is disabled." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "We should initialize the observation in the constructor of the Script class - otherwise, we don't have this feature for mitmdump." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "I would remove this line. Otherwise looks fine cc @ueshin" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Would it be better to remove that line alltogether if it not directly relevant?" }, { "prediction": "I think this is a bug in the kernel-based kernel-based kernel-based kernel-based kernel-based kernel-based mitigation. The kernel-based mitigation was to change the kernel-based kernel-based kernel-based kernel-based kernel-based mitigation to some extent until the * app uses fpu/xmm but we live with it. The kernel-based mitigation was to change the kernel-based kernel-based kernel-based kernel-based mitigation to avoid this. The kernel-based mitigation was to change the kernel-based kernel-based kernel-based kernel-based mitigation. The kernel-based mitigation was to change the kernel-based kernel-based kernel-based kernel-based kernel-based mitigation. The kernel-based mitigation was to change the kernel-based kernel-based kernel-based kernel-based mitigation.", "reference": "Does \"FPU\" here include XMM/YMM/ZMM SIMD and not just x87 FPU/MMX?" }, { "prediction": "TokValueFile(s) is a file generator, so it's not a file generator. It's a file generator, so it's not a file generator. It's a file generator, so it's not a file generator.", "reference": "I'm not sure if we need to store path as bytes, and then decode/escape it when printing or just store it as a unicode string (as done here.)" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this: https://docs.ansible.com/ansible_runner/ansible_runner.html#ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible_runner.ansible", "reference": "Why is this flipped? Looks unrelated and our pattern is `expected == returned`." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "Can the `h5` tags be pulled outside of the `if` block?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I think I'm correct.", "reference": "From @PetrHeinz review: this should be also aliased (`ImageDirectoryStructureCreator`)" }, { "prediction": "I'm not sure if this is what you're looking for, but it's worth noting that we're using the same APIServerPort as the APIServerPort. I'm not sure if this is what you're looking for, but it's worth noting that we're using the same APIServerPort as the APIServerPort. I'm not sure if this is what you're looking for, but it's worth noting that we're using the same APIServerPort as the APIServerPort. I'm not sure if this is what you're looking for.", "reference": "Isn't AdditionalTags already of `Tags` type? If not, we should make it so, if it's not a breaking change" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Add blank line below license header." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Perhaps this could be moved into `InitPWM`? I suspect not initializing the clocks will reduce power consumption." }, { "prediction": "I think this is what you're looking for, but I'm not sure what you're looking for.", "reference": "I believe this `order` isn't tested." }, { "prediction": "What's this for? What's it for? What's it for?", "reference": "No idea why it ended up in the code. You can remove the entire line." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "\"i\" and \"From\" is a bit duplicate, and should it be singular given the method name? I mean \"fromPeer\" or just \"from\"?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Did you verify this isn't going to break any existing test assumptions? We probably shouldn't modify this as we don't know what impact this is having on existing tests. It may invalidate a test that has different expectations of the scopes." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "technically not necessary since reading from a nil dictionary will always return found = false, so this should already be handled" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "This can return bool. RelaxedReclaimPurge(nodeID string) (bool, error)" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "Is there something we can do to make this automatic? At the very least, can we add Shanghai, Cancun, etc. here now so that we don't forget them?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "For boolean values, I'd rather have `argparse.SUPPRESS` as default value. No need to have a `(default: False)` in the help if it's a toggle." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "The genesis block needs to exist in the store the fetcher pulls from, this is because the fetcher will stop fetching when it finds a block it has seen before and this can sometimes be the genesis block." }, { "prediction": "I don't think this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "should we do the same for os.Mkdir(criuOpts.WorkDirectory, 0755)?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "@bbondy Two messages because the label and description differ very slightly in their wording..." }, { "prediction": "I'm not sure if this is the case, but I think it's the case, so I'm not sure if it's the case, but I think it's the case.", "reference": "\"currently\" implies it should and will be changed: so TODO i#?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "This should be `computed('i18n.locale'....`" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Wait, does this not work if we do `btl.reload`? That seems odd that we have to have the object in the same state." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "I seem to recall this being the cause of a bug at some point." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Can you remove it from the menu instead of setting it hidden? Or are there any other trouble?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "And for \"execution \"." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "Do agents usually download these from puppetserver when applying a catalog?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "This should be `return (ev->flags == ASIO_DISPOSABLE);` because `ASIO_DISPOSABLE` has a value of `0` as defined in the enum in `asio.h` and because when `ev->flags` is assigned `ASIO_DISPOSABLE` it is assigned as `ev->flags = ASIO_DISPOSABLE` unsetting any other flags previously assigned." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "this is not required, right? its the default already..." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "\"contingent to\" -> \"contingent on\"" }, { "prediction": "I think this is a bug in SparkPandasIndexingError. It should be fixed in SparkPandasIndexingError.", "reference": "Does pandas throw an exception like this?" }, { "prediction": "I'm not sure if this is the case, but if it's the case, then it's the case, but it's the case.", "reference": "The point of the exercise has been to eliminate CoreChecks as an object dependency for DescriptorSet et. al." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug. I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Why do we need to make so much more of this ScanContext public?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "is choice_name not needed anymore?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Is this the right place to do the validation? If a user adds a bad property or performs some schema update that causes a validation error, that would break all writes to the table. To me, it doesn't seem like we are catching the problem early enough and possibly allowing a typo to break scheduled jobs. What do you think about adding this validation when altering the table? `UpdateProperties` could check whether any properties starting with `write.metadata.metrics` were modified and run this. Similarly, `UpdateSchema` could run this as well, although I think that we should probably modify `UpdateSchema` to simply update the properties for column renames (if that's easily done)." }, { "prediction": "I think this is a bug in hiphcc.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.hpp.", "reference": "Why is this necessary? Just in order to get an indexed loop?" }, { "prediction": "I'm not sure if this is what you are looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "instead of using `prometheus.Gauge`, using `promethus.Counter` will be better." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "maybe we should have a unit test for this and then just test one case in `spec/services/ncr/approval_manager_spec.rb`?" }, { "prediction": "I think this is a bug, but it should be fixed.", "reference": "Why is this necessary?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Minor: If this is going to be public, we should fix the name. `get` doesn't add any value. How about `distributionModeFor` instead?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "This needs a more self-explaining name. Maybe `.is_focused`?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "minor: I'd add a space between `,` & `'paginggroup'`." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "\"Re-upload all fragments (even if fragment is already in registry)\"" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "I don't see us ignoring the field. Are we sure Prometheus wouldn't refuse to load the rules?" }, { "prediction": "I'm not sure if this is a bug, but if it's a bug, it's a bug.", "reference": "I wonder if we can just check if the mSession is active and then only call `setActive(true)` and `callSurfaceChanged()` if it isn't?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "A default value of 100 MB maybe too small. I understand that this is good for mixed workloads, but do consider than plans with Unpack, especially when used for insert/upsert are simple. Unpack is always serial and part of master exe. Often there is only one in a query. The cost of having a low value here seems to be that queue length from unpack could be limited by this when we are loading a table with wide rows (even if actual data in row is not wide). We know from performance runs that queue length is critical to upsert load performance. This is a hunch on my part and could be misguided. It will be good to performance test for upsert of table with wide rows, if you think that is worthwhile." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm wrong, or if I'm wrong, I'm not sure if I'm correct.", "reference": "think we should pass in ctx, and use ctx.GreenlandHeight inside bucketPool to determine if create or not" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "A correct by unrelated change. We'll slide this one in without another word ;)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Why remove this?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm wrong, or if I'm wrong, I'm not sure if I'm correct.", "reference": "I still see some usages of not namespaced variants (look for Twig_ in project, about 42 matches). Is it intentional?" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "Is this a new dependency? Does this require a dep update?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "> opts.generate_hexfloat_in_json && **IsFloat**(type.base_type)" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this:", "reference": "As an alternative to this, we could also create a new method, like `Common() *AppManifest` This way we don't have to add a new method to the interface everytime we add a new field to the `AppManifest`. This is a nit though so it's up to you." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "As long as we have this feature as an inline script, I'm inclined to remove the dependency here. I'd suggest that we just try to import harparser and pytz and throw an error instructing the user to install the dependencies (catch for `ImportError`). In the long term, we probably want to include that in the mitmproxy core, but we first want to introduce a clean extension interface before that's going to happen. As soon as said interface is there, porting the inline script and adding the dependency again should be a breeze." }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this:", "reference": "makes it work nice with vscode. all logic is now in `.gulp/*.iced` files" }, { "prediction": "@see org.openqa.selenium.By, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa.selenium.WebElement, @see org.openqa", "reference": "should a similar change be done for findElement?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "`+` -> ` + ` I guess. Same below" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "`typeof` is not a function - its an operator, and the standard way to use it is as `typeof foo!==...` (i.e. no parenthesis). Also, I would personally use `opts.fee!= null` instead (with a non-strict comparison, which also identifies `undefined` values because `null == undefined`)." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "Is there a reason why you're not using Rspec `skip`? It allows to specify message and makes it clearly visible in test results which tests were skipped." }, { "prediction": "I think you are looking for the `firstSyncSetsSuccessTime` attribute.", "reference": "how about \"all matching SyncSets and SelectorSyncSets\"" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "What is the logic behind `ReadVectorSize` reading `CountElement64`, then skipping `T` (in this case `unsigned`)? Naming doesn't cover what's actually happening here. Ideally I'd also take this through a `files` layer, any input as to how?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "This looks like an unused import to me?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "`RW` means read/write. Why do we have it here, as part of a func name?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "I'd keep this at `info` level..." }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug.", "reference": "I think you missed this." }, { "prediction": "CancellationToken cancellationToken = default; is it possible to change this to a CancellationToken?", "reference": "List all of the current TFMs so we know if this gets outdated. E.g. this breaks if we add 2.2." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "here, you want to use req.GetXattrOpt() referring to the in line 514 of api.proto. This will be nil if not provided. See the example above on line 801 on this file" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "I think this should be done outside LocalPSMP, but in `getNextInQueue`. The reason is that I want to reduce the dependence of the media players on the preferences and database. Also, it will then probably work on Chromecast." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for, so I'm not sure if this is what you're looking for.", "reference": "Please remove it or remove all `std::` namespace prefixes." }, { "prediction": "You should have received a copy of the GNU Affero General Public License. If you don't, you should have received a copy of the GNU Affero General Public License. If you do, you should have received a copy of the GNU Affero General Public License. If you do, you should have received a copy of the GNU Affero General Public License. If you do, you should have received a copy of the GNU Affero General Public License. If you do, you should have received a copy of the GNU Affero General Public License. If you do, you should have received a copy of the GNU Affero General Public License. If you do, you should have received a copy of the GNU Affero General Public License. If you do, you should have received a copy of the GNU Affero General Public License. If you do, you should have received a copy of the GNU Affero General Public License. If you do, you should have received a copy of the GNU Affero General Public License. If not, see .", "reference": "wait! I'm confused - is that an empty file?!" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "These should all call `findUpVirtual`." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for mimetypes.guess_type(file_dict[\"mime-type\"]) or mimetypes.guess_type(file_dict[\"mime-type\"]) or mimetypes.guess_type(file_dict[\"mime-type\"]) or mimetypes.guess_type(file_dict[\"mime-type\"]) or mimetypes.guess_type(file_dict[\"mime-type\"]) or mimetypes.guess_type(file_dict[\"mime-type\"]) or mimetypes.guess_type(file_dict[\"mime-type\"]) or mimetypes.guess_type(file_dict[\"mime-type\"]) or mimetypes.guess_type(file_dict[\"mime-type\"]) or mimetypes.guess_type(file_dict[\"mime-type\"]) or mimetypes.guess_type(file_dict[\"mime-type\"]) or mimetypes.guess_type(file_dict[\"mime-type\"]) or mimetypes.guess_type(file_dict[\"mime-type\"]) or mimetypes.guess_type(file_dict[\"mime-type\"]) or mimetypes.guess_type(file_dict[\"mime-type\"]) or mimetypes.guess_type(", "reference": "This changes the behavior. Original behavior was \"set if not set\", while new is \"just set\"." }, { "prediction": "I'm not sure if it's a bug, but it's a bug in BearerTokenResolver.", "reference": "Let's keep using the regular expression to make sure that the token is well-formed. I think the regular expression should be altered instead of doing a substring." }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this, and that you're doing something like this, and that you're doing something like this, and that's what you're trying to do.", "reference": "All the operations are delegated to this entity, hence the rename. `back` can have too many meanings." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "@trevor-vaughan it looks like the spec failures are caused by the fact that although it was a great idea to put the guard clause here first & get the error case out of the way, the main code path has been erased when I assume it should be just below the guard clause." }, { "prediction": "I'm not sure what you're trying to do, but it seems like you're trying to do something like this:", "reference": "Could you delete this constant?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug. I'm not sure if it's a bug, but I'm sure it's a bug.", "reference": "looks like this snuck in from your other change?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "These env vars are not set in any CF environment, on purpose, because we are moving away from using env vars to store role-based information and instead using the database. So in a CF environment, the wrong emails get used (the defaults, rather than what is in the db)." }, { "prediction": "This partial creates a form for each type of question. The local variables are: plan, answer, question, readonly, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking, locking", "reference": "this partial is used also for previewing a template, did you test if still works?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "Would it be better to put like `Which Dockerfile would you like to use for %s?`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "You mistakenly removed `/docs` here, please add it" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "I missed this earlier, but why does this say \"file blocks\"? This should probably be \"recommended split locations\"." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Please change this to non-exported." }, { "prediction": "We need to remove this assert when we add more fields. We need to remove this assert when we add more fields. We need to remove this assert when we add more fields. We need to remove this assert when we add more fields. We need to remove this assert when we add more fields. We need to remove this assert when we add more fields. We need to remove this assert when we add more fields. - */ - CLIENT_ASSERT(drstats->size >= sizeof(dr_stats_t), \"Invalid drstats->size value.\"); drstats->basic_block_count = GLOBAL_STAT(num_bbs); + drstats->peak_num_threads = GLOBAL_STAT(peak_num_threads); return true; }", "reference": "This is ignoring compatibility: it needs to check the size to ensure this field exists in the client." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Do all the prepare authors also need to be unique? Or is it enough the we have minimumPrepareMessages. I guess I'm wondering if need a hasDuplicateAuthors check like in the RoundChangeCertificateValidator." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "we had some situations where we merged some promql bits then took them out. i'm not sure what's going on here, but unless your code actually needs promql (probably not?) let's remove this line." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do, but I'm guessing you're trying to do.", "reference": "Annotations in this hunk should follow PhpDoc style (above the occurrence, type first)" }, { "prediction": "I'm not sure if this is the case, but if it is the case, then it's probably the case, but I'm not sure if it's the case.", "reference": "This is an improvement - thanks! Could we rephrase slightly to not use the phrase \"is not supported\" -- instead stating _WHAT_ isn't valid please? e.g. maybe `String.format(\"Unsupported BoundType provided: %s\" type)` or something like that." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "nit: `procfd` seems more appropriate now?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "Let's not call it django. Maybe `auth_provider_headers`? `auth_headers`?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this.", "reference": "Should we mention TLS map here?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "remove this empty line pl0x" }, { "prediction": "I think this is what you're looking for.", "reference": "Why not have this in the `Dispatcher`? Doesn't seem like NCR-specific functionality." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do this in a unit test, so I'm not sure what you're trying to do here. I'm guessing you're trying to do this in a unit test, but I'm not sure what you're trying to do here.", "reference": "If you need only test db, use `memdb.NewTestDB(t)`" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "I'm not sure I like setting the IsEmpty property true for upgraded connections since it feels a middle misleading. Maybe we can leave the ForUpgrade class as is and change this condition to `if (!messageBody.IsEmpty &&!messageBody.RequestUpgrade)` to make things more explicit." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "git checkout since this is unrelated to this PR? (running migrations also changes this for me -- not sure why it keeps going back and forth" }, { "prediction": "I'm not sure what you're trying to do here, but I think it should be something like this: `SigAndHashAlgField(\"sig_alg\", 0x0401, _tls_hash_sig), `SigLenField(\"sig_len\", None, fmt=\"!H\", length_of=\"sig_val\"), `SigValField(\"sig_val\", None, fmt=\"!H\", length_of=\"sig_val\"), `SigValField(\"sig_val\", None, fmt=\"!H\", length_of=\"sig_val\"), `SigValField(\"sig_val\", None, fmt=\"!H\", length_of=\"sig_val\"), `SigValField(\"sig_val\", None, fmt=\"!H\", length_of=\"sig_val\"), `SigValField(\"sig_val\", None, fmt=\"!H\", length_of=\"sig_val\"), `SigValField(\"sig_val\", None, fmt=\"!H\", length_of=\"sig_val\"), `SigValField(\"sig_val\", None, fmt=\"!H\", length_of=\"sig_val\"), `SigValField(\"sig_val\", None, fmt=\"!H\", length", "reference": "Is this change needed?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Isn't the % 128 redundant here?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's probably what you're trying to do.", "reference": "Are you testing that the values are always false? I think you should test for setting values to true or false, right? Who is going to take action with these values?" }, { "prediction": "The Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch Batch", "reference": "Please change MPI to CCTOOLS_WITH_MPI" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Why you can't use function here?" }, { "prediction": "You may not use this file except in compliance with the License. This file is distributed under the Apache License, Version 2.0 (the \"License\"). You may or may not use this file except in compliance with the License. A copy of the License is located at +// +// http://aws.amazon.com/apache2.0/ +// or in the \"license\" file accompanying this file.", "reference": "We should scope this down to only the methods we use." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Oh, thanks for catching - I thought I've catched all after changing `mkString(infix, prefix, suffix)` to `mkString(prefix, infix, suffix)`." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this, and that you're trying to do something like this, and that you're trying to do something like this, and that you're trying to do something like this, but that's not what you're trying to do.", "reference": "Suggestion: `.. the CertificateRequest is ready for signing` - could we perhaps word this differently? I understand that in this case it will be the associated X.509 certificate that can now be signed, so maybe `the certificate is ready for signing`? (Same with `CertificateRequestReasonDenied`)." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "We should use `! isValidAccountID( accountID )` for the `accountID` checks." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "That alternative does seem better. Did you want to try to do it in this PR? It makes sense to me that the inventory would always be available before creating the executor." }, { "prediction": "# # # # # # # # # # # ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Missing the `-y` argument which all other `apt-get install` commands have." }, { "prediction": "I don't think this is a bug, but it's a bug. I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug. If it's a bug, it's a bug. I'm not sure if it's a bug, but it's a bug. If it's a bug, it's a bug.", "reference": "So I think we are going to settle on the \"concise and elegant\" `PRI` macros as they are the safest option for now. Even though they make my eyes bleed a little..." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Interesting, was this needed for a test case to pass? I figured if there is no opening brace, there is definitely no placeholder -- we don't even have to check for a closing one." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "I think we want to provide getAction API instead" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but I'm guessing it's what you're looking for.", "reference": "There is also `winVersion.isWin10`. I think this should be converted to use the helper function. The helper has a note that it doesn't work in source copies, but looking at the implementation it looks equivalent to what you have here." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a good idea.", "reference": "This doesn't seem like it should be part of this pull request." }, { "prediction": "I think this is what you are looking for.", "reference": "Is the idea that `@product` (and `@workshop` for `workshops_controller`) would eventually go away here?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing you're looking for something like this:", "reference": "We should add those only once we have successfully synced to the BSC main net, we have a utility to generate those. Please remove for now" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "And how is that related?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "this should be required" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "This appears to be unused" }, { "prediction": "This is not a snapshot, it's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's a snapshot. It's", "reference": "I think that \"table's state\" isn't clear enough. How about \"history of the table's current snapshot\" like the one below?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "This looks like a bug: pretty sure there are scatter-gather instructions on AArch64. Ditto below." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "No need to change this: id love if we changed as a team to unkeyed fields, it ends up catching a lot more at compile time, at minimal cost" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this.", "reference": "Should this be in the parent struct? `AppManifest` since it's embedded to `LBFargateManifest` it'll get the method as well." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but it's what you're looking for.", "reference": "\"Openvpn check\" we could move this to separate prefix." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think you're trying to do something like this. I'm not sure if this is what you're trying to do, but I think you're trying to do something like this.", "reference": "body is being used here for the first time without every being populated. This will error. To run tests do `./go clean test_py` and that will run the Firefox tests" }, { "prediction": "It's a bug, but it's fixed.", "reference": "We don't return now?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "This might end up not doing exactly what we want (the retry only picks up the `go get`, not the `go build`, due to the `&&`)." }, { "prediction": "The OpenTelemetry Authors License is available at http://www.microsoft.com/en-us/download/details.aspx?id=1", "reference": "Is there a BOM change?" }, { "prediction": "I'm not sure if this is the correct way to do this, but I'm not sure if this is the correct way to do it.", "reference": "It's not a good practise to delete the public static constant." }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "I deleted this because `WellFormed` is immediately called by `verify.TxnPool` below. Can someone please double check this for me since it's... pretty important" }, { "prediction": "@@ -70,6 +70,7 @@ setup( \"kaitaistruct>=0.7,<0.9\", \"ldap3>=2.5,<2.6\", \"passlib>=1.6.5, <1.8\", + \"ply>=3.4, <3.12\", \"pyasn1>=0.3.1,<0.5\", \"pyopenssl>=17.5,<18.1\", \"pyparsing>=2.1.3, <2.3\", \"pyparsing>=2.1.3, <2.3\", \"pyparsing>=2.1.3, <2.3\", \"pyparsing>=2.1.3, <2.3\", \"pyparsing>=2.1.3, <2.3\", \"pyparsing>=2.1.3, <2.3\", \"pyparsing>=2.1.3, <2.3\", \"pyparsing>=2.1.3, <2.3\", \"pyparsing>=2.1.3, <2.3\", \"pyparsing>=2.1.3, <2.3\", \"pyparsing>=2.1.3, <2.3\", \"pyparsing>=2.1.3, <2.3\", \"pyparsing>=2.1.3, <2.3\", \"pyparsing>=2.1.3, <2.3\", \"pyparsing>=2.1.3, <2.3\", \"pyparsing>=2.1.3, <2.3\", \"pyparsing>=2.1.3, <2.3\", \"pyparsing>=2.1.3, <2.3\", \"pyparsing>=2.1.3, <2.3\", \"pyparsing>=2.1.3,", "reference": "Did you actually test this with ply 3.4? That release is pretty old (2011), so I think we can bump this to at least 3.6 (2015) or even 3.10 (2017)..." }, { "prediction": "I'm not sure if this is a bug, but it should be fixed in the latest release.", "reference": "This can be simplified somewhat to `pointer.Int32Ptr(0)`. But it is not necessary." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "Clever but perhaps confusing." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think you're trying to do something like this. I'm not sure if this is what you're trying to do, but I'm not sure if it's what you're trying to do. I'm not sure if this is what you're trying to do. I'm not sure if this is what you're trying to do. I'm assuming it's what you're trying to do, but I'm not sure if this is what you're trying to do. I'm not sure if this is what you're trying to do. I'm assuming it's what you're trying to do. I'm assuming you're trying to do something like this, but I'm not sure if this is what you're trying to do. I'm not sure if this is what you're trying to do. I'm not sure if this is what you're trying to do. I'm assuming you're trying to do something like this, but I'm not sure if this is what you're trying to do. I'm", "reference": "@abutcher Is it a safe assumption that secrets are the only objects that need to get attached to syncsets?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Should you capture o.asflr before releasing consumer's lock?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Just asking: Should this happen, that null is passed? If this is the case I think we should think about passing an `Optional` object to the method." }, { "prediction": "I think this should work.", "reference": "what about making a `ProfilesController` or `UserProfilesController` and having this be a `show` action instead? That would be more Railsy (although that can be considered a compliment or a dis, depending on who you are :hamburger: )" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "I'd move the empty assignment and non-null case into the if check directly above (adding an else clause as needed)" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Please remove this extra line of whitespace" }, { "prediction": "@param int $domainId * @param string $locale * @param int $startFrom * @param int $lastProcessedId * @param int $batchSize * @return array */ - public function getProductsData(int $domainId, string $locale, int $startFrom, int $batchSize): array + public function getProductsData(int $domainId, string $locale, int $lastProcessedId, int $batchSize): array", "reference": "maybe it's time to rename `ProductSearchExportWithFilter` to something better, what do you think?" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "Instead of adding new code here - can you move these methods to agent_capability.go, so the same is used for unix and windows as well. this will need removal of these methods from agent_capability_unix.go as well." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Make it the last parameter, just in case someone uses the API with non-keyword args." }, { "prediction": "I think this is a bug in github_client.remove_collaborator. It should be fixed in github_client.remove_collaborator.", "reference": "Don't extend an instance initialized by `Struct.new`." }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "Just wondering - would it make more sense to simply replace `PMIX_DESTRUCT(&t->nslist)` with `PMIX_LIST_DESTRUCT(&t->nslist)` here, and then add `PMIX_RELEASE(p->jobbkt)` to the `pmix_nspace_caddy_t` destructor on line 154 of src/include/pmix_globals.c? Seems to me like we always want to have these things removed/destructed." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "I think, we should fix/improve AbstractRuleSetFactoryTest. I guess, both apex and visualforce rules are now tested, which is unnecessary." }, { "prediction": "I think this is what you are looking for, but I'm not sure if this is what you're looking for.", "reference": "In php8 named parameters were introduced and now it is required to match called method parameter name when setting parameters by array destructing or `call_user_func_array()` etc." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "easily possible to get that information without exposing internal information" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "Why do we need tristate logic (pe, foss, nil)?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a bug.", "reference": "this change needs to be reverted to what is on `master`" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Do you still need to call the superclass `createVariable` if you've already determined that the variable exists?" }, { "prediction": "This is a ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Ignoring the pack entry from an existing entry but using the new entry from a non-finalized index, is subtle enough that it needs explaining." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "This is a revert, is it really an issue?" }, { "prediction": "I'm using OpenTelemetry.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace.Trace", "reference": "can we delete this file altogether?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it should work.", "reference": "Suggestion: log some additional info here so we know where we are i.e 'Failed to prepare coverage framework..'" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "There didn't seem to be any good place to put constants that are.NET Tracer-specific, so I created this internal static class. If there's a better place, let me know." }, { "prediction": "I think this is a bug. It should be fixed in the latest release.", "reference": "Log message should be started with upper-case word." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "changes for example usage in this class" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for.", "reference": "I know frameworks that support current directory when loading dependencies, is this a limitation of the requirejs loader or can we fix it somehow?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "`ctx` is unused in EnableApplication" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "@jemc, this is one change needed in `generate_multi_dot_name`. I believe this * will do no harm to working pony code: The new code was added in a place where it is throwing an assert. So no working code will get affected. * is in sync with the rest of the method: if the parent ast node has null `data`, we are supposed to return empty string. That is possible when we have expressions wrapped in braces." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Should not be a static import." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "should we be using `aws.String` here? it seems there are a few other spots we could use `aws.String` in the `if change.Attachment!= nil {...` block." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "We can't pass raw dates like this because they need to be formatted as `YYYYMMDD` as noted in the IB. We added the `generateDateRangeArgs` utilities to handle this for us, as well as abstracting the relationship between arg name and specific dates which is not obvious just by looking at it. Let's update it to use `generateDateRangeArgs( { startDate, endDate } )` instead Use care to make sure we're sourcing the utility from Analytics utils though since AdSense has its own version by the same name, which is different." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this: I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "`default=True` shouldn't be used for BoolParameters iirc." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "It would be better to use `return refStr[12:]`. or `11`... I have problem with counting.." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Pretty sure these should only contribute to the runtime hash." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for
idToPos = new TreeMap<>(String.CASE_INSENSITIVE_ORDER);` could work I think" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "I think this should be a throw. Or the method should be TryGetSlot?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "We don't usually put spaces between ( and [, and I think `path` should be passed by reference." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Make sure to `snake_case` locally scoped variable names in the future" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this: I'm not sure what you're trying to do, but I think you're trying to do something like this.", "reference": "Maybe we should use underscores like `health_check` - what do you think?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here.", "reference": "Do a TrimSpace before setting." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Are the fields in this struct grouped by IP address family or by function? There are separate fields for IPv4Addresses and IPv6Addresses, but a single field for DomainNameServers. Should this new field be named SubnetGatewayAddress with type array consisting of both IPv4 and IPv6 gateways?" }, { "prediction": "I think this is what you're looking for.", "reference": ".find(id) is being deprecated to Rails 5." }, { "prediction": "I think this is what you are looking for. I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "Will be good to have the iris interface moved to geoviews. Could this be done for 1.10.6?" }, { "prediction": "I'm not sure if this is the case, but if it's the case, it's probably the case.", "reference": "does this get wrapped in the calling method?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to test case-insensivity.", "reference": "Do we still need this test case? If your new test cases test this, then we can remove it." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "If you want to express \"any role that is not creator\" you could use the following statement: Role.where(plan: self).where(Role.not_creator_condition).any? which would be less verbose and a bit more efficient if it is used for Yes/No shared?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here. I'm not sure what you're trying to do here, but here's what I think you're trying to do here.", "reference": "Do we need any update on the test side?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's probably what you're trying to do.", "reference": "There's a few `return nil` cases above this -- we should probably move this above the big switch." }, { "prediction": "I'm not sure if this is the case, but I think this is the case.", "reference": "`lile *LeaseInLedgerError` to reduce copying?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "should it be `newsessionqueue` or `newsessionqueuer`? In case we'd like to be consistent" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "We don't have a requirement anywhere in Test Platform for GetStream() with write access. It is ok to directly change `return new FileStream(filePath, mode, FileAccess.Read)`." }, { "prediction": "I think this is a bug in qutebrowser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser.browser", "reference": "FWIW `from qutebrowser.browser import hints` is okay - it's just things like `from qutebrowser.browser.hints import HintManager` I try to avoid." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "@preda-bogdan let's use a filter for the header classes, something like, hfg_header_classes where we hook this logic, in neve pro" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Out of curiosity.. is there a rule to determine the package name as prevDirectory+currentDirectory." }, { "prediction": "I don't think it's a bug, but it's a bug.", "reference": "It seems this needs to check the lazy cxt switching flag. It is used on the initial thread for early injection and in other places where the lazy switch should apply." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to parse a property ID into an object of its components. I'm not sure what you're trying to do here, but I'm guessing you're trying to parse a property ID into an object of its components.", "reference": "Why not use the JSdoc annotation as it did before?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if it's the correct way to do it, so I'm not sure if it's the correct way to do it.", "reference": "Why don't we drop the packageImplementationVersion in general? That way the version will be fetch all that time only from the properties file and it will be consistent." }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this. I'm not sure what you're trying to do here, but it seems like you're trying to do something like this.", "reference": "Please use the style of the rest of the code, a space between the type and `*`" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "nit: remove extra blank lines." }, { "prediction": "@ -39,6 +39,7 @@ const ( appEnvOptionNone = \"None (run in default VPC)\" defaultDockerfilePath = \"Dockerfile\" imageTagLatest = \"latest\" + taskGroupNameDefault = \"copilot-task\" ) const ( appEnvOptionNone = \"None (run in default VPC)\" defaultDockerfilePath = \"Dockerfile\" imageTagLatest = \"latest\" + taskGroupNameDefault = \"copilot-task\" ) const ( appEnvOptionNone = \"None (run in default VPC)\" defaultDockerfilePath = \"Dockerfile\" imageTagLatest = \"latest\" ) const ( appEnvOptionNone = \"None (run in default VPC)\" defaultDockerfilePath = \"Dockerfile\" imageTagLatest = \"latest\" + taskGroupNameDefault = \"copilot-task\" ) const ( appEnvOptionNone = \"None (run in default VPC)\" defaultDockerfilePath = \"Dockerfile\" imageTagLatest = \"latest\" + taskGroupNameDefault = \"copilot-task\" )", "reference": "nit: What do you think of `copilot-task-group`?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "We should check whether or not the input node has a value since we can just have an onChange on an uncontrolled component as well." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "I think there should be some reasoning below this line about the version updating." }, { "prediction": "public static h2o_http1client_body_cb on_head(h2o_http1client_t *client, const char *errstr, int minor_version, int status, h2o_iovec_t msg, h2o_http1client_header_t *headers, size_t num_headers) { return H2O_COMPRESS_HINT_DISABLE; } public static h2o_http1client_body_cb on_head(h2o_http1client_t *client, const char *errstr, int minor_version, int status, h2o_iovec_t msg, h2o_http1client_header_t *headers, size_t num_headers) { return H2O_COMPRESS_HINT_AUTO; } public static h2o_http1client_body_cb on_head(h2o_http1client_t *client, const char *errstr, int minor_version, int status, h2o_iovec_t msg, h2o_http1client_header_t *headers, size_t num_headers", "reference": "Please use `h2o_lcstris` instead of `strncasecmp` so that the comparison would be a complete match (instead of a prefix match; current code would yield true if [val,len] is [\"O\", 1]) and that it would be locale-independent." }, { "prediction": "I'm not sure what you're trying to do here, but I'm assuming that you're trying to create a new folderBranchOps object, so I'm not sure what you're trying to do here.", "reference": "I prefer if possible for `if`/`else` statements to have the positive case first." }, { "prediction": "I'm not sure if this is a bug, but it's a bug. It's a bug.", "reference": "Docstring would be nice" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like it's what you're looking for.", "reference": "Low risk to fix this by default because existing baseline consumers pass this check. We don't attempt to fix checks that have been opted out of." }, { "prediction": "I'm not sure if this is a bug, but it seems to be fixed in the OpenMPTargetInternal.h file. I'm not sure if this is a bug, but it seems to be fixed in the OpenMPTargetInternal.h file. I'm not sure if this is a bug, but it seems to be fixed in the OpenMPTargetInternal.h file.", "reference": "What about `VOLTA72`, `TURING75`, `AMPERE80` and `AMPERE86`? We only want to set the number of teams for these two architectures or for all the architectures newer than Maxwell?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Since we have specified `load_from`, `pretrained` can be left None." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "I prefer to translate these `else if` into `switch` for more readability." }, { "prediction": "I think this is a bug in the API itself. It should be fixed in the API itself.", "reference": "This can also be a local variable in `create`." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm not sure.", "reference": "Why not use `path.Join`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, so I'm not sure if this is what you're looking for.", "reference": "Why not `export default API` instead? This ensures we export the same that we export on the global." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea to use itk.ImageIOFactory.CreateImageIO(io_filename, itk.ImageIOFactory.FileModeType_ReadMode) instead of itk.ImageIOFactory.CreateImageIO(io_filename, itk.ImageIOFactory.FileModeType_ReadMode) if not imageIO: imageIO = itk.ImageIOFactory.CreateImageIO(io_filename, itk.ImageIOFactory.FileModeType_ReadMode) if not imageIO: raise RuntimeError(\"No ImageIO is registered to handle the given file.\") imageIO = itk.ImageIOFactory.CreateImageIO(io_filename, itk.ImageIOFactory.FileModeType_ReadMode) if not imageIO: raise RuntimeError(\"No ImageIO is registered to handle the given file.\") imageIO = itk.ImageIOFactory.CreateImageIO(io_filename, itk.ImageIOFactory.FileModeType_ReadMode) imageIO = itk.ImageIOFactory.CreateImageIO(io_filename, itk.ImageIOFactory.FileModeType_ReadMode)", "reference": "This is a good change I think. It greatly helps reduce name conflicts." }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "cluster not having omitempty, does this imply that cluster is required? seems empty is valid so just checking" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "@aws/aws-ecs-agent, @yumex93: how concerned should we be about user provided envvar names clobbering existing envvars? i'm not convinced we should be doing additional validation here." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "nit: aspects are defined in `OperationBase`, should `defineAspects` live there as well?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Why the `os.path.abspath`? `os.path.dirname` should always give a valid directory path." }, { "prediction": "I'm not sure if this is the correct way to do it, but it's the correct way to do it. I'm not sure if this is the correct way to do it, but it's the correct way to do it.", "reference": "I think we should not consider special engine types on this level. I would prefer to build the specific engine path based on `application.user.engines` later on." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "Is `rbegin` correct? We can't make sure that the last index column is the `rbegin` of `scanItems`." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "check it is!= 0, just like `EVMNetworkID` above" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "if you just do \"this.GetType().Name\" and \"this.exporter.GetType().Name\", we get what we need." }, { "prediction": "This is where all the API version info lives. This allows us to change one * line here and affect all our api calls.", "reference": "That's the code that would prevent any SalesforceSDKTest from running. At class loading time, SalesforceSDKManager.getInstance() would throw a RuntimeException because init() had never been called." }, { "prediction": "@ -34,4 +34,6 @@ public interface DefinitionConst { String VERSION_RULE_LATEST = \"latest\"; String VERSION_RULE_ALL = \"0.0.0+\"; + + String DEFAULT_REVISION = \"0\"; }", "reference": "there is no \"DEFAULT_REVISION\" logic, no need to define this." }, { "prediction": "I'm not sure if this is the correct way to do it, but if it's the correct way to do it, then it's the correct way to do it, so it's the correct way to do it.", "reference": "so this is to fix a scenario where the app is first launched normally, then background and foreground through the link, we are not updating loginOption" }, { "prediction": "I'm not sure if this is what you are looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "It doesn't seem like the right way to implement this, because you add a new element that doesn't really exist (noteTextViewer). Instead you should modify the command handler `if (command.name === 'focusElement' && command.target === 'noteBody') {` in NoteText.jsx. Then focus either the editor or the viewer depending on what's currently visible." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "We don't add blank lines in imports." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "Please add your name to the copyright list." }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "You can elide the `if` check for empty string, because if it's not a value that is set, the string will be empty anyway." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Different i18n keys. By mistake or on purpose?" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "Given the description for this is `// Describes how the ACME challenge self check behaves when it fails.`, perhaps `RetryForever` is better terminology here as when the check fails, we don't just wait, we retry periodically." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so it should be fixed.", "reference": "Nit: let's add a more descriptive prefix in line with the other ones? E.g. `Unable to import key`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "This looks like it will pass an array as `:key` in the default case. That doesn't reflect how this will actually work in practice." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but I think it's what you're looking for.", "reference": "Do we need this?" }, { "prediction": "I'm not sure if this is the case, but if it's the case, then it's the case.", "reference": "I am a bit confused about this function. If it is used to set priority, we actually use function \"Table.BuildFlow(priority uint16)\" to set the value. If it is used to parse the priority value, I think adding a property(if you don't want to consume Match.Priority directly) to cache it and consume that property should be simpler than using string regex." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think you're trying to add an unresolved package to a package that doesn't exist in a package that doesn't exist in a package that doesn't exist in a package that doesn't exist in a package that doesn't exist in a package that doesn't exist in a package that doesn't exist in a package that doesn't exist in a package that doesn't exist in a package that doesn't exist in a package that doesn't exist in a package that doesn't exist in a package that doesn't exist in a package that doesn't exist in a package that doesn't exist in a package that doesn't exist in a package.", "reference": "In this case we probably meant \"package\"." }, { "prediction": "I'm not sure if this will work or not, but I'm not sure if this will work or not. I'm not sure if this will work or not, but I'm sure it will.", "reference": "Just export `createFile` directly." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This probably needs to get shipped with plz; you shouldn't have to redefine it within the user's repo. It should use `defaultPath` like the other things up the top of the file." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, I'm guessing it's a bug.", "reference": "interface for bitcoin should not change if possible. i.e: networks.testnet should return networks['btc'].testnet" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this.", "reference": "File is not `gofmt`-ed with `-s` (from `gofmt`)" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here, so I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "We have this functions in a couple of places. It should probably live in util or something." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "maybe this should be inside the destroy?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Do not import torch in the test function because it will import torch every test iteration and will slow down the testing speed." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for, but I think it's what you're looking for.", "reference": "I think we want to return an error here, not nil." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here, so I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "Nitpicking, but I think it would be more accurate to use an actually supported value, i.e. `completed`." }, { "prediction": "I think this is a bug in Rails. It's a bug in Rails, but it's fixed in Rails 3.", "reference": "How about renaming the `ApiJob` class to `JobApi`. As per rails convention, get method is to get a single object, not a collection, can we change that to `fetch`/`where`. It would be great if we can move the `get` method to a class method." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this.", "reference": "assignments should only be cuddled with other assignments (from `wsl`)" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "`k` is unused in PutHash" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case.", "reference": "None of the child return null here, plus it was creating an incoherence between interfaces." }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "Should we remove this entirely now then?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "That is way too generic a name." }, { "prediction": "I'm not sure what you're trying to do, but I think this should work.", "reference": "This might be overkill for test code...but as stewards of accessibility it would be appropriate to have a label in the fixture." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so it's a bug.", "reference": "Are these allocations necessary, or can these be instantiated normally (i.e., `VkCommandBufferObj secondary_full_clear(...)`). If the allocations _are_ necessar, I'd vote for using something like `std::unique_ptr` and then remove the associated `delete`s." }, { "prediction": "I'm not sure if this is what you're looking for, but it's worth noting that we're using `asyncSpanConsumer` in order to prevent tests breaking, so we're using `asyncSpanConsumer` in order to prevent tests breaking. We're using `asyncSpanConsumer` in order to prevent tests breaking, so we're using `asyncSpanConsumer` in order to prevent tests breaking. We're using `asyncSpanConsumer` in order to prevent tests breaking, so we're using `asyncSpanConsumer` in order to prevent tests breaking, so we're using `asyncSpanConsumer` in `asyncSpanConsumer` in order to prevent tests breaking.", "reference": "es.clear should call this" }, { "prediction": "I'm not sure what you're trying to do here, but I think this should work.", "reference": "please remove. this is true by the definition of the Python language" }, { "prediction": "I think this is what you're looking for.", "reference": "Hmm, I wonder if binding `` is a good idea... this means it wouldn't be passed to webpages anymore, which makes me wonder how many people rely on that... I guess trying it is the only way to find out :wink:" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "Golang naming convention is to use camel case `icmpPktWithTypeCode` Often the linter will complain" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "nit: Probably should renamed to `InitializeBody`" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "is `settings.icon` always null/undefined when there's no icon or does is it get set to a blank string? It might be worth wrapping it in an `isBlank()` anyway" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "put invoke to the end of the list, and other module at beginning of the list (line 86)" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a good idea to use the ```````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````", "reference": "I think that bytes is too precise. Can we just calculate the approximate value in appropriate units? Something like MB, GB depending on the value, `db capacity: 5000000 chunks (approximately 20GB)`." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do here.", "reference": "This check shouldn't look at the content, you're already doing this with `none-empty-text`. I also think this check should be renamed to `none-empty-alt` or something like it. There is nothing specific to applets in this check to warrant putting `applet` in the check ID." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this, and you're trying to do something like this, which is not what you're trying to do.", "reference": "Why did you change the signature of this method? You can break BC doing that" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "can you catch the error here please and return err if it can't read the template" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Is this method called at another location too? I'm just asking because you didn't remove another call to `updateLibrary`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "Not necessary but you should be able to add a `?` on `is_default?` and `published?`" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "here is us decoding directly the bytebuffer in benchmarks" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm correct, but I'm not sure if I'm correct, or if I'm wrong, but I'm not sure if I'm correct, or if I'm wrong, so I'm not sure if I'm correct.", "reference": "When the Tracer is first created AND `DD_LOGS_INJECTION=true`, this is invoked and causes the issues described." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "NIT: If we are renaming the JsonRpcError, should we also rename this enum value to be consistent?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "This could be made into a function expression, yes?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "Oops, I missed this initially." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this.", "reference": "Can we add an assertion here the policy actually contains both statements created above?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug, and it's a bug.", "reference": "a space after comma?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "nit formatting here and below" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for.", "reference": "I think that there is a general consensus of trying to avoid this kind of mocks in the new tests that we write. I would suggest to have tests using fake service implementations. In this case, we can have a fake entry service. Examples of how tests have been written this way are the tests for the `spire-server agent` and `spire-server bundle` commands. It would be great if we can have that kind of testing here also. What do you think?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "`ctx` is unused in RunQuery" }, { "prediction": "This can be used to filter deduplications of multiple reports.", "reference": "Couldn't we use type hints to express this?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "why you do `.classList.add()` here but `.replace()` in other places?" }, { "prediction": "I see that one of the teachers is \"$teacher_name\"' do |teacher_name| + sleep 10 page.should have_css(\".teachers\", text: teacher_name) end +Then 'I should see that \"$teacher_name\" is teaching both sections' do |teacher_name| + sleep 10 page.should have_css(\".teachers\", text: teacher_name) end +Then 'I should see that \"$teacher_name\" is teaching both sections' do |teacher_name| + page.should have_selector('h4', text: \"Joe Teacher\", count: 1) +end + Then %{I see \"$teacher_name\"'s avatar} do |teacher_name| teacher = Teacher.find_by_name!(teacher_name) page.should have_css(\"img[src^='https://secure.gravatar.com/avatar/#{teacher.gravatar_hash}']\", \"img[src^='https://secure.gravatar.com/avatar/#{teacher.gravatar_hash}']\",", "reference": "What is this sleep here for?" }, { "prediction": "I'm not sure what you're trying to do here, but it should work.", "reference": "I think that this test doesn't cover this bug correctly. When I attached the older version of the handsontable to this test it passes, should fail. Can you check that?" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Maybe this should just be passed in on construction time" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "We should create the monitor after the `if (!primary_drm)` check." }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "Can be removed now that slots are used" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "The description should match the test" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "rootston needs to unset this now" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "why do you rename this function?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this. I'm not sure what you're trying to do here, but I think you're looking for something like this.", "reference": "since we are no longer using these numbered icons can we remove them from source control?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "both edge and normal need to set this, so set it to be default action?" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, then it's a good idea to use a File.WriteAllText(projectJsonPath, projectJson) instead of a File.WriteAllText(projectJsonPath, projectJson) instead of a File.WriteAllText(projectJsonPath, projectJson) instead of a File.WriteAllText(projectJsonPath, projectJson) instead of a File.WriteAllText(projectJsonPath, projectJson) instead of a File.WriteAllText(projectJsonPath, projectJson) instead of a File.WriteAllText(projectJsonPath, projectJson) instead of a File.WriteAllText(projectJsonPath, projectJson) instead of a File.WriteAllText(projectJsonPath, projectJson) instead of a File.WriteAllText(projectJsonPath, projectJson) instead of a File.WriteAllText(projectJsonPath, projectJson) instead of a File.WriteAllText(projectJsonPath, projectJson) instead of a File.WriteAllText(projectJsonPath, projectJson).", "reference": "Is doing a straight string compare of the files the right way to determine this? I guess if you expect to be the only one writing this file it could work but it does seem like it might be a large string compare and if we are doing this hundreds of times that might cause some memory issues." }, { "prediction": "I'm not sure if this is a bug, but it's a bug, and it's a bug.", "reference": "What's the purpose of this change? It basically changes nothing until we want to put smth between curly braces" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this.", "reference": "Hmm, why is this needed? `wlr_input_device_destroy` should destroy the tablet tool." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "I think it's better to throw `UnsupportedOperationException`" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "`props.children` is not always guaranteed to be an array. When only one child is passed this will break. We can use `toChildArray()` to turn it into an array :tada:" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "Please just remove this line. We have the git history if we want the old version." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug.", "reference": "Can we put some of the code on a new line to make it more readable. The max line length was 120 now, right?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Remove the handling here as well." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Do we want to make this configurable?" }, { "prediction": "public static int positive(String argName, Integer number) { return positive(argName, number, null); } public static int positive(String argName, Integer number, String message) { return positive(argName, number, message); } public static int positive(String argName, Integer number, String message) { return positive(argName, number, null); } public static int positive(String argName, Integer number, String message) { return positive(argName, number, message); } public static int positive(String argName, Integer number, String message) { return positive(argName, number, null); }", "reference": "Prefer adding a second `positive(String, double)` that delegates down to this three-param version. Using `null` in code is generally Not A Great Idea, and it looks ugly." }, { "prediction": "I think this is a bug in ActiveAdmin. I'm not sure if this is a bug or a bug in ActiveAdmin, but I'm not sure if it's a bug or a bug in ActiveAdmin.", "reference": "Is this going to break things for 18F proposals, or will these fields just be ignored?" }, { "prediction": "The modifier key is never released implicitly. The key is sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or sendKeys(Keys.NULL) or ", "reference": "Keys.COMMAND seems to be an alias to Keys.META. That isn't mentioned?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "What's the reason for moving this to config from status?" }, { "prediction": "Is there a better way to do this?", "reference": "Shouldn't we re validate/update the in memory suppress data here?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "curious why the renumbering is required here and elsewhere?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "s/must specify secrets/must specify secrets or Role info/" }, { "prediction": "I'm not sure what you're trying to do here, but I think it's a good idea.", "reference": "let's leave this as a dev-only feature, and copy prod db to local env when needed. that keeps blazer security issues to a minimum." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing it's what you're looking for.", "reference": "We'll be renaming ActivitySampler to Sampler anyway, so this change will be non-required. Prefer to avoid changes here to avoid merge conflict with my PR doing the rename." }, { "prediction": "I'm not sure if this is what you're looking for, but if it's what you're looking for, it's probably a good idea to use a regex instead of a regex.", "reference": "This applies only in the \"set\" headers case, but what about \"adding\" a header (field prefixed with `+`)?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "I'm not sure we should deprecate this. I kinda like the idea, that we would provide all exceptions (if we throw any) with a common super type. Of course, the exception should be not a checked exception like this one, but rather a runtime exception. We maybe need additionally an internal exception that we would convert into such a public API exception. But that's out of scope of this PR - that's the question of exception handling." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "You'll need to adjust the docstring :wink:" }, { "prediction": "I don't think it's a bug, but I think it's a bug in the reader_attributes.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQos.m_expectsInlineQ", "reference": "Add a TODO explaining why this is being done" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for a variable map. I'm not sure if this is what you're looking for, but it seems like you're looking for a variable map. I'm not sure if this is what you're looking for.", "reference": "This file still uses Blockly.VariableModel..." }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to do something like this:", "reference": "Small nit, in the PR description its `publicAccess` but here its `public`. Guessing the preferred naming is public?" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Maybe `driver.Watcher` -> provider (2x)? This is the concrete type, this user doesn't really know anything about the driver." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "can we remove this since `getDocValues` already returns an iterator? (we might need to do `T extends DocIdSetIterator` above)" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this:", "reference": "Don't check this in. This is already implemented in core_extensions/ruby/string.rb" }, { "prediction": "The big endian hash buffer of the header is the same as the big endian hash buffer of the header. So it's not the same as the big endian hash buffer of the header, but it's the same as the big endian hash buffer of the header.", "reference": "This is used for both `id`, and `hash` we may not want these both to be enumerable." }, { "prediction": "The `FormatterLoader` for introspection is not a duplicate of the `FormatterLoader` for introspection. The `FormatterLoader` for introspection is a duplicate of the `FormatterLoader` for introspection. The `FormatterLoader` for introspection is a duplicate of the `FormatterLoader` for introspection. The `FormatterLoader` for introspection is a duplicate of the `FormatterLoader` for introspection. + # + # Note as this is a duplicate, any mutations will be disregarded. + # + # @return [Array] the formatters currently loaded def formatters - formatter_loader.formatters + formatter_loader.formatters.dup end # @return [Array] the formatters currently loaded def formatters - formatter_loader.formatters + formatter_loader.formatters.dup end # @return [Array] the formatters currently loaded def formatters - formatter_loader.formatters + formatter_loader.formatters.dup end # @return [Array] the formatters currently loaded def formatters - formatter_loader.formatters + formatter_loader.formatters.dup end # @return [Array] the formatters currently loaded def formatters - formatter_loader.formatters + formatter_loader.formatters.dup end", "reference": "Is this necessary? I would expect YARD to treat it as public anyway... (Don't hold off merging on this...I'm mostly just curious)." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "@wxing1292 to double check this is the right version to use?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Shouldn't there be another case for when both min and max are specified?" }, { "prediction": "This file is part of Invenio. It is not part of Invenio. It is part of Invenio. It is part of Invenio. It is part of Invenio. It is part of Invenio. It is part of Invenio. It is part of Invenio. It is part of Invenio. It is part of Invenio. It is part of Invenio. It is part of Invenio. It is part of Invenio. It is part of Invenio. It is part of Invenio.", "reference": "Don't miss this one `2: I102 copyright year is outdated, expected 2014 but got 2013`. Thanks" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "the tail_ maybe nullptr?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I think it's a bug.", "reference": "The PR description mentions that `The controller code is extended to react to \"add\" events`, but I don't see any additional cases added here beyond the existing Create and Delete... is there something I'm missing?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "Does it matter that #include changed to #include?? I think the change makes sense since it aligns with the method name on Hash but unsure if anything called #include that would break with the change." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "LGTM, curious though why exactly this is in place, and are there any possible issues from not waiting long enough?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "?: is unnecessary because we already force preserve_hosts to be a string with to_s." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "should it be `newsessionqueue` or `newsessionqueuer`? In case we'd like to be consistent" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Since lazy is re-rendered when mounting the fallback, these checks get triggered an additional time." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "There is a `is_content_editable()` method just above this, what's the difference?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if this is the case, but I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "Hmm, I'm not sure this is exactly what we want to get across. The behavior of leaving both values unset allowing the entire config to be managed is what is indeed deprecated. It's just that not the entire field is deprecated, just that one behavior." }, { "prediction": "I don't think this is a bug, but it's a bug, and it's fixed.", "reference": "Given the slightly vague discussion in basename(3) about POSIX basename (modifies arg) vs GNU (doesn't), I always assumed it was advisable to pass a string copy However, I guess you'd get a \"discarding const\" warning promoted to error by our build system here if you were getting the POSIX implementation. Hah! Cool, I probably can go remove some memory copies in other parts of the code where those conditions exist." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug.", "reference": "Do you know somehow that this was the culprit? Even 1 minute is a lot, so I would expect the bug to lie somewhere else." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "what to do if some failed? just logging?" }, { "prediction": "@faker.version next + def deep_thoughts + fetch('quote.deep_thoughts') + end + ## # Produces a quote from Deep Thoughts by Jack Handey. + # + # @return [String] + # + # @example + # Faker::Quote.deep_thoughts # => \"I hope life isn't a big joke, because I don't get it.\" + # + # @faker.version next + def deep_thoughts + fetch('quote.deep_thoughts') + end + ## # Produces a quote from Deep Thoughts by Jack Handey.", "reference": "since these thoughts are all Jack Handey's the generator should probably be called `jack_handey` to reflect that." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "this file is autogenerated. you should edit `model/api/api-2.json` and then go generate this file. otherwise the next people generating api.go will remove the changes you added here" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "Extra empty line detected at class body beginning." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "This is smart but hacky! I would probably prefer an alternate solution that would be more obvious to read/understand." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think you're trying to do something like this.", "reference": "i would not return a pointer for status here which is an int" }, { "prediction": "I'm not sure what you're trying to do, but it seems like you're trying to do something like this:", "reference": "Those functions are not currently wrapped, so I don't think it is necessary to exclude them (at least for now)." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do.", "reference": "Should we specify the name of the folder?" }, { "prediction": "I think this is a bug in rdkit.Chem.rdDepictor.rdDepictor.rdDepictor.rdkit.Chem.rdDepictor.rdkit.Chem.rdDepictor.rdkit.Chem.rdDepictor.rdkit.Chem.rdDepictor.rdkit.Chem.rdDepictor.rdkit.Chem.rdDepictor.rdkit.Chem.rdDepictor.rdkit.Chem.rdDepictor.rdkit.Chem.rdDepictor.rdkit.Chem.rdDepictor.rdkit.Chem.rdDepictor.rdkit.Chem.rdDepictor.rdkit.Chem.rdDepictor.rdkit.Chem.rdDepictor.rdkit.Chem.rdDepictor.rdkit.Chem.rdDepictor.rdkit.Chem.rdDepictor.rdDepictor.rdkit.Chem.rdDepictor.rdDepictor.rdkit.Chem.rdDepictor.rdDepictor.rdkit.Chem.rd", "reference": "it's not wrong, but you don't technical need `rdmolops` here since it's imported as part of `Chem`" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "I think the absence of this might have been the cause of the dump file corruption. We didn't wait for the pxz command to exit, leading to a race condition between the cp and this, leading to corrupted files in some places. I came across this because the hashes created and printed were different from the hashes of the actual files in dev also." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Out of the scope." }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Maybe `sortByColumnHeader` would be more precise? The plugin has a method with the same name and it could be confusing." }, { "prediction": "This is a shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow shallow", "reference": "@developit I vaguely remember you mentioning something about some JS engines having an escape analysis feature that makes objects (and arrays?) locally declared that never leave the function essentially free from a GC perspective or something. Do you think we could benefit from that here? Or should we leave this as it is?" }, { "prediction": "I'm not sure why you're getting this error, but I'm not sure why you're getting this error, but I'm not sure why you're getting this error, so I'm not sure why you're getting this error.", "reference": "Remind me why this is needed?" }, { "prediction": "We can use the `BooleanClause.Occur.FILTER` instead of `BooleanClause.Occur.FILTER` so that the `BooleanClause.Occur.FILTER` can be used in conjunction with `BooleanClause.Occur.FILTER` instead of `BooleanClause.Occur.FILTER` so that the `BooleanClause.Occur.FILTER` can be used in conjunction with `BooleanClause.Occur.FILTER` instead of `BooleanClause.Occur.FILTER`", "reference": "same as above, can this be null now?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but I think it's a bug.", "reference": "This doesn't make sense to me. Should `cv.lengths` be an integer array instead of longs? It looks like they should always be integers since the values are assigned from `ArrayData#numElements()`. That's very likely an int." }, { "prediction": "I'm not sure if it's a typo, but I'm not sure if it's a typo, but I'm not sure if it's a typo.", "reference": "str.Substring(3).Split(' ')[0] would also work and is more concise." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Did you mean to negate the not_a_peer check?" }, { "prediction": "You may not use this file except in compliance with the Apache License. You may not use this file except in compliance with the Apache License. You may not use this file except in compliance with the Apache License. You may not use this file except in compliance with the Apache License. You may not use this file except in compliance with the Apache License. You may not use this file except in compliance with the Apache License.", "reference": "Copyright (C) 2010-2021 DBeaver Corp and others" }, { "prediction": "We use this to be able to highlight parts of the text.", "reference": "This seems like an unrelated change" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "Just to double-check -- are you sure this needs to be done *before* we create a new session? (Is `SetKeyLabel` setting what the label will be for all future keys or the label for the current key?)" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm assuming it's something you're trying to do, so I'm assuming it's something you're trying to do.", "reference": "I thought we were removing the FAIL policy altogether...." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Could you elaborate on why you made this change?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's what you're trying to do.", "reference": "before the fix, does this sentence make service crash? My point is can you re-produce the problem. I'm not sure the bug is due to non-asiic code" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I think it's a bug.", "reference": "This comparison looks a bit strange, we should first check existence of key \"IsApiToken\" and then check if it is equal to true. ~~Besdies, s/IsApiToken/IsAuthedByToken/~~" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "This might be working as is, but I'm a bit thrown by the || and then && and how things get evaluated. Testing real quick on the go playground, true || false && false seems to either evaluate the && first, or start on the right side. Anyhow could you group with braces, it looks to me like it should be ( a || b) && c in this case?" }, { "prediction": "This is an alpha (internal) release and is not suitable for production.", "reference": "add an entry in makefile to generate binary with diff name?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "hmm so we didn't validate the HTTP config for all receivers?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "ITextFormatActivity had this, can I add to have the same effect?" }, { "prediction": "\"github.com/aws/amazon-ecs-agent/agent/containerresource\" \"github.com/aws/amazon-ecs-agent/agent/containerstatus\" \"github.com/aws/amazon-ecs-agent/agent/containerstatus\" \"github.com/aws/amazon-ecs-agent/agent/containerstatus\" \"github.com/aws/amazon-ecs-agent/agent/api/status\" \"github.com/aws/amazon-ecs-agent/agent/apierrors\" \"github.com/aws/amazon-ecs-agent/agent/apierrors\" \"github.com/aws/amazon-ecs-agent/agent/apierrors\" \"github.com/aws/amazon-ecs-agent/agent/apierrors\" \"github.com/aws/amazon-ecs-agent/agent/apierrors\" \"github.com/aws/amazon-ecs-agent/agent/apierrors\" \"github.com/aws/amazon-ecs-agent/agent/apierrors\" \"github.com/aws/amazon-ecs-agent/agent/apierrors\" \"github.com/aws/", "reference": "not blocking: can we remove extra lines here?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "This just feels weird... can we use some kind of constant here? something like: `if (_.isUndefined(data) || data === PrivateKey.Random)`" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "if does not have a class I guess the exception should be thrown because we cannot recognize the type based on it?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this, and that's what you're trying to do.", "reference": "LOL: use your GitHub username?" }, { "prediction": "I think this is a bug. It should be fixed in the nextPrefix() method.", "reference": "any tests for nextPrefix()?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "In general I'm saying \"if there is no common type I'm just going to skip some stuff and fail silently.\"" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "did we move the eventing logging here? Probably the eventing logging was removing and they are now using the pkg logging in eventing. If that is the case, we should do the same here" }, { "prediction": "I'm not sure what you're trying to do here, but I'm assuming you're trying to do something like this:", "reference": "I think that `Handler` should preserve the `operation` member and the span formatter should receive the operation name string as a parameter too, otherwise the `operation` parameter in the `NewHandler` function becomes useless if we pass a custom span formatter. Also, shouldn't it be called `spanNameFormatter`?" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "Can you merge #466? That would make the current `None` default value working and more relevant that `\"127.0.0.1\"`." }, { "prediction": "I'm not sure what you're trying to do here, but I think it's a good idea.", "reference": "is reserved filed name the only possible reason this could fail?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this should work.", "reference": "Would a KBFS_DISABLE_JOURNAL make more sense?" }, { "prediction": "I don't think there is a way to do this, but I think it's a good idea.", "reference": "BTW. What's the message meaning?..." }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "this should say false" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "for my understanding - are this line and the next line both necessary? they seem to contain duplicate information. same for the other test files" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "No need for the `.keys()`, iterating over a dictionary gives you its keys (and thus you can also do `key in some_dict`). With that, it also fits on one line :wink:" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "If we want to avoid the user calling constructor and destructor, we should add `= delete` to their declarations. If we just want to avoid writing the default behavior, we should add `= default` to the declarations. I'm more in favor of the second option to avoid an API break." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems to be a bug.", "reference": "My preference here is to keep a stricter hierarchy. We should have a mixin or something that is an AssetEvent that Observation and Materialization can both inherit from. That way we can check the type in the frontend if we need to." }, { "prediction": "I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Can also cast them as `set`s and compare them." }, { "prediction": "@ -0,0 +1 @@ +package trigger", "reference": "Still TODO I guess?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Another cleanup. There are two additional `using namespace std::chrono;` under this one. Should also remove std::chrono:: from the full file. Please do this on a single commit." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Looking at this list of boolean flags I wonder if we should create enums for all of these options, so that the code becomes much more readable" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Is this necessary?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "How about this NS inside query NS?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "in line 79, sm also can be stateReader" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "maybe can not return a map directly, it will be modified by inner thread." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "What is the actual change here, why is this test change needed? Now the diff will send back more data?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "Might be better to use a tag here. I for one have used 1000 isotopes as a tag in the past..." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "This tests seems it was broken from the start :joy:. It \"worked\" because the old sample chance was small enough that this have always be off. Thanks for fixing this. Could you also change the strings on this test? `\"Recording off\"` and `\"new span is recording events\"`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "This is not actually the case, you need to modify `toConfiguration` below to prevent a configuration from being produced" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "I'm worried about we hide some important log here" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Python 3 will throw an exception for inf, but not providing a timeout will result in no timeout exception." }, { "prediction": "I'm not sure if this is the case, but I think it's the case, so I'm not sure if it's the case, but I think it's the case.", "reference": "As this method changes the state, it should be `POST`. Also, maybe to rename it to `createTag`?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "`ctx` is unused in rollbackTraffic" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I'm sure it's what you're looking for.", "reference": "Roslyn conventions have const in PascalCase." }, { "prediction": "I'm not sure if this is the correct way to do it, but I'm not sure if this is the correct way to do it.", "reference": "This is not bullet proof if e.g. user has `clientPort=1234` in `zoo.cfg` and in zkHost connection string. Then we'll add a warning that dynamic config differs from zkHost, which is not entirely true since we just lack the port part. We have no way from client to read the `clientPort` from server except from connecting to the server with 4LW *ont the clientPort* which is a chicken and egg. This hack will make the comparison work for default port, which is a compromise." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "We can probably delete this entire file. It's not used now and we'll (probably) write a custom serializer before we ever switch to MessagePack 2.1." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "Aren't you duplicating this option?" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "I'm not sure we should be doing this based on the extension? Calling them `.build_defs` is just a convention" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Should remove in `_MissingPandasLikeMultiIndex:` too" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "We should scope this down to the bits that we're actually using, otherwise the API is going to be problematic, as it includes references to NAT gateways and public and/or private subnets. Copying the types to be more local to the task in hand is fine." }, { "prediction": "This is not an AWS resource tag. Instead, it is an AWS resource tag.", "reference": "Is it is a hard requirement for this field to be 'cn-northwest-1' when wanting to interact with AWS China? It appears that putting in 'cn-north-1' would also result in using the alternative API endpoint (with the region overridden to use 'cn-northwest-1' for the created AWS client)." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Stephen already fixed this one. Only the OverSize test is flaky now right?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "if the `activity_mailer` has a layout, should we include the footer in that? Realize there may also be conflicts with work @rememberlenny is working on..." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "This makes me nervous, mostly because I don't know very much about it. Will users run into the gettext error in the wild? I can't reproduce it locally, but it's hard to be 100% sure. Is disabling gettext in Pal an option?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug.", "reference": "Is Java smart enough to know the generic type here? Never knew this." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "no thought given to reload" }, { "prediction": "private String calculateRateUnit(TimeUnit unit) { return calculateRateUnit(unit) + \" \" + calculateRateUnit(unit) + \" \" + calculateRateUnit(unit) + \" \" + calculateRateUnit(unit) + \" \" + calculateRateUnit(unit) + \" \" + calculateRateUnit(unit) + \" \" + calculateRateUnit(unit) + \" \" + calculateRateUnit(unit) + \" \" + calculateRateUnit(unit) + \" \" + calculateRateUnit(unit) + \" \" + calculateRateUnit(unit) + \" \" + calculateRateUnit(unit) + \" \" + calculateRateUnit(unit) + \" \" + calculateRateUnit(unit) + \" \" + calculateRateUnit(unit) + \" \" + calculateRateUnit(unit) + \" \" + calculateRateUnit(unit) + \" \" + calculateRateUnit(unit) + \" \" + calculateRateUnit(unit)", "reference": "Please, don't remove the `getDisabledMetricAttributes` method. All changes must be backward-compatible." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug", "reference": "Is this left over from debugging?" }, { "prediction": "I'm not sure if this is the correct way to do it, but it should work.", "reference": "I've fallen for this before myself :) We _do_ call `close` inside of `done` on L65" }, { "prediction": "I'm not sure if this is a bug, but if it's a bug, it should be fixed.", "reference": "That looks fine! You could use `\"rclone/\"+fs.Version` too if you wanted. BTW does tardigrade use http under the hood? If you were using rclone's http Client then you'd get a User-Agent and you'd also get support for `-vv --dump bodies` and other nice things." }, { "prediction": "I think this is a bug in the torch.clamp() function. It should be replaced with torch.clamp(neg_prob, min=1e-12) or torch.clamp(neg_prob, min=1e-12) or torch.clamp(neg_prob, min=1e-12) or torch.clamp(neg_prob, min=1e-12) or torch.clamp(neg_prob, min=1e-12) or torch.clamp(neg_prob, min=1e-12) or torch.clamp(neg_prob, min=1e-12) or torch.clamp(neg_prob, min=1e-12) or torch.clamp(neg_prob, min=1e-12) or torch.clamp(neg_prob, min=1e-12) or torch.clamp(neg_prob, min=1e-12) or torch.clamp(neg_prob, min=1e-12) or torch.clamp(neg_prob, min=1e-12) or torch.clamp(neg_prob, min=1e-12) or torch.clamp(neg_prob, min=1e-12) or torch.clamp(neg_prob, min", "reference": "Adding one line `prob = prob.clamp(min=EPS, max=1-EPS)` already works." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do.", "reference": "another option would be to create a `CreateRequestQueue(bool lockingQeueue)`, and set it only in `InitializeTarget`, isn't? The would prefer having the creation and \"business\" rules for the creation in one region, I think `InitializeTarget` would be the best place." }, { "prediction": "I'm not sure what you're trying to do here, but I think it should be something like this:", "reference": "Wait, I think the `subsurface_handle_place_above` code was correct before. `place_above` means \"place it above in rendering order\" right?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "why did this change?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this.", "reference": "Do you think we should have some tests here for `tlf.SingleTeam` too?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "No problem with this but might as well revert this file since nothing else changed." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm sure it's a bug.", "reference": "In my changes, I did not create a new `AspNetScopeManager`. I'm not familiar with it enough to know if this is a valid change or not" }, { "prediction": "I'm not sure if this is what you're looking for, but I think this is what you're looking for.", "reference": "Not cool with this. I think we talked about it in past. This is a side effect. If we want to introduce the side effect in our functions like `inRange` (which I am for) the side effect (error) should originate in that function and not in some internal `throwError` function. Every stacktract will start at line `2` of `trowError.js`. Been there, done that and falled back to throwing the error from the place where it should be thrown." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "We don't need this additional method." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "The purpose of this test is to ensure that the `OAuth2UserRequest` passed into `loadUser` is **not** null else throw `IllegalArgumentException`. Changing the `List` of `OAuth2UserService` mocks to `DefaultOAuth2UserService` doesn't really apply to what is being tested here. Please revert this. Thank you." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "nit: rename to nativeStk? proto might lead to think protobuf" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Why not `queryUUID` (and reference the same constant as in other places)?" }, { "prediction": "I'm not sure what you're trying to do, but I'm assuming you're trying to change the trust domain, so I'm not sure what you're trying to do. If you're trying to change the trust domain, you're probably going to want to change the trust domain, so I'm not sure what you're trying to do. If you're trying to change the trust domain, you're going to want to change the trust domain, so I'm not sure what you're trying to do. If you're trying to change the trust domain, you're going to want to change the trust domain, you're going to need to delete all existing registration entries. If you're trying to change the trust domain, you're going to need to delete all existing registration entries. If you're trying to change the trust domain, you're going to need to delete all existing registration entries. If you want to change the trust domain, you'll need to delete all existing registration entries.", "reference": "This is also used to log, of which our convention is leading uppercase..." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "What about we just name it `check_exact`?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "before, a binary annotation had the same service name as a regular annotation, masking the bug where we weren't querying the latter" }, { "prediction": "I think this is what you're looking for.", "reference": "Where does the `7` come from?" }, { "prediction": "I'm not sure if this is what you're looking for, but it should be something like this:", "reference": "I don't know how we haven't got bugs from some of these! As here this would have had a stale `value`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "One nit here I forgot about this before but we usually structure error messages as \"Cannot X because Y. Then the recommendation goes here\" I would also recommend not using \"it\" in the message since it the pronoun is a bit ambiguous. \"to specify write sort-order\" may be clearer" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "I'm surprised this worked at all! It was importing the default export but `eslint-plugin-import` warned me `warning Using exported name 'initialState' as identifier for default export import/no-named-as-default`" }, { "prediction": "I think this is what you're looking for.", "reference": "This was used in `app/views/video_tutorials/_video_tutorial_details.html.erb` how are we handling that now?" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed.", "reference": "Is `\\S+` really the right thing? Anybody know what kind of encoding this is? Perhaps if we know it doesn't have commas, we can just use `[^,]+`. Also, parens around the comma are unnecessary, since we're not using the capture group." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "This block of changes looks like you removed tests without replacing them anywhere. Did I miss something?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "n.b. private and computed values are now exposed to the API. They were hidden/not exposed before." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Nitpick: Please add a period after `link` :wink:" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug in the upstream.Start() function.", "reference": "we got no chance that `err` is not nil here, need to revisit how `NewUpstreamController` is defined." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Instead of building in routing for a browser-specific command, could you refactor the HttpCommandExecutor to allow arbitrary commands to be registered?" }, { "prediction": "I'm not sure what you're trying to do, but I think it's a good idea.", "reference": "It'd be nice to assert the right deprecation is being raised, just add a third argument of `/\"its\" method/`" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Do we want to add this to the docs?" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do. I'm not sure what you're trying to do.", "reference": "This isn't really related but makes debugging test failures much easier since you see the string representation of the code instead of the integer value." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Because of this new early exit." }, { "prediction": "@see Selenium::WebDriver::IE::Bridge # @see Selenium::WebDriver::IE::Bridge # @see Selenium::WebDriver::IE::Bridge # @see Selenium::WebDriver::IE::Bridge # @see Selenium::WebDriver::IE::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver::Edge::Bridge # @see Selenium::WebDriver", "reference": "Maybe call it `WireBridge`?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "can this be removed now?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug, so I'm not sure if it's a bug or a bug, but it's a bug.", "reference": "This is going to create a problem - we are already encountering issues with the length of the usock pathname on recent Linux kernels as the temp directory base has moved down to the var directory under a name created by a hash. So adding another field to it is going to add to the problem." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "What do you think about moving this to the `cloudformation` pkg?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Please make this private by default" }, { "prediction": "I'm not sure if this is what you're looking for, but it's what you're looking for.", "reference": "We can add `@Override` annotations to all of the implementations of this method. I think this is a best practice for us, but it would be nicer in any case." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Most of uses of `RefreshAndGet` seems to be made only for `Refresh` part, result is ignored. We can simplify this method to assigning single responsibility to it - just `Refresh()`." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "@Pierre-Sassoulas Are we sure this doesn't create problems? Without it for some reason we get an error on `accept-no-param-docs` being a duplicate error. I couldn't figure out why it did this. This solves the issue and passes the tests, but I wonder if this creates other issues.." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug, but it's a bug.", "reference": "Does it make sense to check for \"Created\" here as well? Or should it return an error in such case?" }, { "prediction": "I'm not sure if this is the case, but I think it's the case. I'm not sure if this is the case, but I'm not sure if it's the case.", "reference": "Did you mean to use `identifier.toString` here as well?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "interesting! didn't realize this was needed in RSpec 3" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "This is to avoid circular reference" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "As the bokeh renderer also has a ``load_nb`` classmethod (and notebooks are explicitly mentioned in that method name), I would consider making ``_notebook`` into a constant ``notebook_context`` class parameter. The docstring can say it is set to True if the ``load_nb`` classmethod has been called." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug, so I'm not sure if it's a bug, but I think it's a bug.", "reference": "Where is the actual command generated here? Shouldn't this be taking in `constructor(db, collectionName, options)` and then constructing the command off of that?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Mirror the `OPTIONAL OUT` of fullpath" }, { "prediction": "I'm not sure if this is what you're trying to do, but it's a bug.", "reference": "Please merge with master and replace with with \"future\" version." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Nit: Change is not needed for this PR :slightly_smiling_face:" }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it, but I think it's the best way to do it.", "reference": "if we are returning `nil` from an `else` I think we can just remove the `else` (and this method will still return `nil`)" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea to use a timer. I'm not sure if this is what you're looking for, but I think it's a good idea to use a timer. I'm not sure if this is what you're looking for, but it's a good idea to use a timer.", "reference": "side note: this change is ok as of today because we have not exported the results for this new type to BenchView yet. After we to that the namespace, type name and method name should not be changed (they create a benchmark ID which is used in BenchView)." }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "How exactly are you expecting the user to see issues with their Midas library? It seems like all error information is being swallowed and not clearly reported to the user. Even if the eventual result is to report that loading the file failed, it seems like the exception, in this case, might have more information about why." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Looks good, but seems `ReadMessage` hadn't used this Deadline in Underlying `WSConnection`?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Make it \"___*\" three underscores to make it even less likely to have a collision? I assume it will be hard to change the file name once this change is deployed..." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "We don't need this anymore after #2151" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "this is this removed? I don't understand in the context of this PR" }, { "prediction": "I'm not sure what you're trying to do, but I'm not sure what you're trying to do.", "reference": "`isinstance(ip6, Net6)` instead" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's a bug.", "reference": "Do we really need the param here? If only partial results returned, we could return ResultCode::PARTIAL_RESULTS;" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "this logic seems duplicated from the other new function. I think it should probably be a member function on `BuildTarget`" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm not sure what you're trying to do here.", "reference": "size reduce to 1/4 of using Gob" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "The Hash interface states that a call to `Write()` never returns an error. Does this also apply to the number of written bytes?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "In my tests, I found that `[[ \"\" -lt 12 ]]` evaluates to true, but `[[ -lt 12 ]]` is an error, which is why the subshell is wrapped in `\"`." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "I don't see a validation on `published_on`, we generally shouldn't specify it in the base factory unless the model would be invalid without the model. Is there a different way we can handle this?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "maybe add a `isExhaustive()` method on the enum to avoid these large conditions?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "so those regexps were wrong previously? e.g. they would match `/v\\/foo`? If so, raise a bug and fix on the 1.0 branch." }, { "prediction": "public static final String getSourceForMethod($method, $params) { return $this->getSourceForMethod($method, $params); } public static final String getSourceForMethod($method, $params) { return $this->getSourceForMethod($method, $params); } public static final String getSourceForMethod($method, $params) { return $this->getSourceForMethod($method, $params); } public static final String getSourceForMethod($method, $params) { return $this->getSourceForMethod($method, $params); } public static final String getSourceForMethod($method, $params) { return $this->getSourceForMethod($method, $params); } public static final String getSourceForMethod($method, $params) { return $this->getSourceForMethod($method, $params); } public static final String getSourceForMethod($method, $params) { return $this->getSourceForMethod($method, $params); } public static final String getSourceForMethod($method, $params) { return $this->getSourceForMethod($method, $params); } public static final String getSourceForMethod($method, $params) { return $this->getSourceForMethod($method, $params); }", "reference": "I think with MultiBackend we could have a slightly different logic: return true if there are no configured login targets ( = getLoginDrivers returns an empty array). MultiBackend could also check all configured login targets for loginIsHidden support and verify that at least one of the configured login targets allows login, but I wouldn't go that far without a use case. In a related note, I'm not quite sure if loginIsHidden works with ChoiceAuth at all, but that's a different issue." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Should we add error info for not supporting the compressed binary?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug. I'm not sure if it's a bug, but it's a bug.", "reference": "I suggest injecting this into the reconciler. For this and the others. Have Wire generate it and push it into the controller creation." }, { "prediction": "I don't think this is what you're looking for, but I think this is what you're looking for.", "reference": "Can't we just make _serializer static? We use same settings every time. I would also put those fields on top of the class for readability." }, { "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to do something like this:", "reference": "Can't we just use `metadata['websocket_flow']` to identify handshake flows and not add another attribute?" }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "Funny that we were wrapping this with string interpolation before..." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do here.", "reference": "I had an eslint error saying I must \"alias\" my model - so I copied this from controllers/site.js" }, { "prediction": "I'm not sure if this is what you're looking for, but it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting that it's worth noting", "reference": "unsure if the methodname can still be `GetMetricPoints()` as before..." }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems like you're trying to do something like this:", "reference": "This file contains the functional changes, the rest is for testing." }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, or if it's what you're looking for, or if it's what you're looking for.", "reference": "I know you didn't do this, but there's no need for the `nethttp` alias and it was confusing to me - just remove it and s/nethttp/http/ everywhere (it's fine that the package here is http itself, I do the same thing in transport/grpc)" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case.", "reference": "I felt that this was the most non-invasive way to fix the test, but this does expose some raw DB queries and knowledge about how SQLite works which may be a code smell. The alternative to getting this to pass is to perform enough writes to trigger a checkpoint, but that threshold is determined in the config stage and this test may not be able to know what that page threshold is set to. This could lead to inconsistent test runs which is why I elected to force the checkpoint regardless of the page threshold." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's a good idea to use std::stringstream instead of std::stringstream. If it's a good idea to use std::stringstream, it's a good idea to use std::stringstream instead of std::stringstream. If it's a good idea to use std::stringstream, it's a good idea to use std::stringstream instead of std::stringstream.", "reference": "Is new model format backward compatible with current v2?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "should we perhaps write a spec that ensures we don't send a welcome email to a user on login when the user is not new?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I think my preference would be to have the type be a `time.Duration` and use `time.ParseDuration` for parsing." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug, so I'm not sure if it's a bug.", "reference": "JMX offers normal APIs for this. I don't think you want the glassfish one." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "We should really leave a TODO or something or else we will forget them..." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it should be something like this:", "reference": "This exposes what a bad name `dagster_type` was, but is it crazy to want this to just be `type` -- do we gain usability by being super-explicit that this is a `runtime_type`? If so, would it make sense to rename the `config_field` to be `config_type`?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I think it's the case.", "reference": "It might help here if you give a brief explanation of what you mean with a selection being anchored at the start." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "move cachedStates to handle function" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "I don't think this can just be renamed; it's saying that privacyMode is a BooleanSetting, which it's not." }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug in the coreConcurrencyStagesMap.computeIfAbsent(coreName, k -> new ConcurrentLinkedQueue<>());. I'm not sure if this is a bug, but it seems to be a bug in the coreConcurrencyStagesMap.computeIfAbsent(coreName, k -> new ConcurrentLinkedQueue<>());. I'm not sure if this is a bug in the coreConcurrencyStagesMap.computeIfAbsent(coreName, k -> new ConcurrentLinkedQueue<>());. I'm not sure if this is a bug in the coreConcurrencyStagesMap.computeIfAbsent(coreName, k -> new ConcurrentLinkedQueue<>());. I'm not sure if this is a bug in the coreConcurrencyStagesMap.computeIfAbsent(coreName, k -> new ConcurrentLinkedQueue<>());. I'm not sure if this is a bug in the coreConcurrencyStagesMap.computeIfAbsent(coreName, k -> new ConcurrentLinkedQueue<>());. I'm not sure if this is a bug in the coreConcurrencyStagesMap.computeIfAbsent(coreName, k -> new ConcurrentLinkedQueue<>());.", "reference": "what was the reason for this change?" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems to be a bug. I'm not sure what you're trying to do, but it seems to be a bug.", "reference": "Minor, but these two nullable and the logic around them could be replaced by a Lazy." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this.", "reference": "I think I would just pass in `len(peers)`, on the principle of minimum information." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "Spark's default value is 10 but it also rewrites IN as OR/EQUALS. We can do better that this because of the way we evaluate IN predicates. On datasets we tested this, we saw performance improvements on IN predicates with up to 200 elements (on sorted column). We may increase the default value a bit but I am very reluctant to make it more than 300 since our jobs were 20% slower with IN predicates that contained 300 elements. That being said, the optimal value still depends on a particular query and table." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Please update copyright year." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "Same here, could just be `std::setprecision`." }, { "prediction": "I'm not sure if this is the case, but I think it's the case, so I'm not sure if it's the case, but I think it's the case.", "reference": "Do we still want the \"admins\" gate?" }, { "prediction": "I think this is what you are looking for: https://docs.aws.amazon.com/ruby/s3-ruby-example-upload-multiple-items/", "reference": "Simple Storage **Service**" }, { "prediction": "I'm not sure if this is the correct way to do this, but it is the correct way to do it.", "reference": "nit: `it is assumed`" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I would appreciate it if you could refrain from using `stdbool.h`. We allow the header files of H2O to be included from C++ (which means that `bool` might be a C++ type), and therefore my preference is to not use `bool` in our code (but instead use `int` or `char` for the purpose) to avoid confusion." }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "@danielbidala What happens if `searchScope` is not defined in `config_relation.yaml`?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "Do we want maybe a 1min timeout?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "I guess code never reaches this line, you can remove `else` block and just `return a[0], a[1]`. Also, probably rename `a` to `auth` as well." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Doesn't this no-arg constructor need to be public for serialization to work?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do, so I'm not sure what you're trying to do.", "reference": "Just use the word \"veld\" instead of \"gebied\" here" }, { "prediction": "I'm not sure if it's a bug, but it seems to be a bug. I'm not sure if it's a bug, but I'm sure it's a bug.", "reference": "This change (import org.shredzone.flatter4j.model.User;) does not seem relevant to this fix / commit." }, { "prediction": "I'm not sure if it's a bug, but it's a bug, so it's a bug.", "reference": "This should be a Bool() rather than a String(). (See the other PR for an example)" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "This should be a failure if we don't get the exact number of expected rules. You can use a constant if you don't want to update several lines any time you update the test rule strings." }, { "prediction": "public void Update() { if (_syncPeerPool.PeerCount == 0) { _syncPeerPool = syncPeerPool?? throw new ArgumentNullException(nameof(syncPeerPool)); _syncConfig = syncConfig?? throw new ArgumentNullException(nameof(syncConfig)); _logger = logManager.GetClassLogger()?? throw new ArgumentNullException(nameof(logManager)); _logger = logManager.GetClassLogger()?? throw new ArgumentNullException(nameof(logManager)); _logger = logManager.GetClassLogger()?? throw new ArgumentNullException(nameof(logManager)); _logger = logManager.GetClassLogger()?? throw new ArgumentNullException(nameof(logManager)); _logger = logManager.GetClassLogger()?? throw new ArgumentNullException(nameof(logManager)); _logger = logManager.GetClassLogger()?? throw new ArgumentNullException(nameof(logManager)); _logger = logManager.GetClassLogger()?? throw new ArgumentNullException(nameof(logManager)); _logger = logManager.GetClassLogger()?? throw new ArgumentNullException(nameof(logManager)); _logger = logManager.GetClassLogger()?? throw new Argument", "reference": "We need to switch from BeamSync to FullSync when we download all the needed headers, blocks, receipts and state" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Why you duplicate it? The underlaying transport should live as long as the multiplexed one. And must be destroyed after protocol is destroyed. Duplicating the transport may lead to object references hold and maybe memory freeing problems. I think this property must hold a reference to it and not a copy. The copy can lead to memory freeing problems." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "`in.Status.Experiment.Phase`. we can omit `ChaosStatus`" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm guessing you're looking for something like this:", "reference": "Just curious... why the alias here?" }, { "prediction": "I'm not sure if this is what you are looking for, but I think this is what you're looking for.", "reference": "Seems like this should conflict with changes I made during merging of the 20.2 RESX file translation" }, { "prediction": "I'm not sure what you're trying to do, but it seems to be a bug.", "reference": "Why disable this rule?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think you're looking for something like this:", "reference": "I think you don't need the `... if '{}' in arg else arg` part - if the arg doesn't contain `{}`, `arg.replace('{}',...)` will return the unchanged string anyways." }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a good idea.", "reference": "nit: Should we make this an attribute of the LoadGroupMembersPIpeline class?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but it's the correct way to do it.", "reference": "need to update this command to use the name field instead of principal_id" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "nit: I can't help but think the privateTransactionHandler should be a base-class member... every Priv Json RPC seems to need it..." }, { "prediction": "I don't think this is a bug, but I think it's a bug.", "reference": "Why does this start the main activity and not the preferences? With `overridePendingTransition(0, 0)`, this could instantly switch the theme without the user being disrupted" }, { "prediction": "public boolean isUp ( ) { return up; } public boolean isDown ( ) { return down; } public int getMaxSessionCount() { return maxSessionCount; } public void setMaxSessionCount(int maxSessionCount) { this.maxSessionCount = maxSessionCount; }", "reference": "Prefer a human-readable string rather than querying specific technologies. How would I indicate a session is running on BrowserStack? Or some custom thing?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this: https://pypi.python.org/pypi/setuptools", "reference": "It appears as though whoever checked in python changes didn't re-run regenerate:expected. I am modifying these files as a result of running that after a sync and build." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "This was copied from JavaMethodViewGenerator; only the `public static` method modifiers were added." }, { "prediction": "public long getEffectivePriorityFeePerGas() { return getMaxPriorityFeePerGas().get().getAsBigInteger().longValue(); } public long getMaxPriorityFeePerGas() { return getMaxPriorityFeePerGas().get().getAsBigInteger().longValue(); } public long getMaxFeePerGas() { return getMaxPriorityFeePerGas().get().getAsBigInteger().longValue(); } public long getMaxFeePerGas() { return getMaxPriorityFeePerGas().get().getAsBigInteger().longValue(); }", "reference": "this is going to throw for frontier transactions post-london" }, { "prediction": "I'm not sure if this is the issue, but I'm not sure if it's the issue.", "reference": "The catch clause is not needed. The finally clause alone is enough." }, { "prediction": "public boolean isUp ( ) { return up; } public boolean isDown ( ) { return down; } public int getMaxSessionCount() { return maxSessionCount; } public void setMaxSessionCount(int maxSessionCount) { this.maxSessionCount = maxSessionCount; }", "reference": "Prefer a human-readable string rather than querying specific technologies. How would I indicate a session is running on BrowserStack? Or some custom thing?" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "Changing the default value for isClosed from TRUE to FALSE can have other repercussions. We might miss throwing error. Can you please confirm this change." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Please use more meaningful names than `te`here and in other places." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do.", "reference": "Perhaps this would be more idiomatic as `ConfigFor(interface{}) (*PluginConfig, bool)`?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "nit: We could import `APPLICATION_AMZ_JSON_1_1` from `constants.py` here." }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, or if I'm wrong, or if I'm wrong, or if I'm wrong, or if I'm wrong, I'm wrong.", "reference": "Should this not inherit from IMvxMainThreadDispatcher?" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "line is 167 characters (from `lll`)" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, or if it's the case, or if it's just the case, it's just the case.", "reference": "nit: consider adding a blank line between L15 and L16." }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's a bug.", "reference": "This is another bug fix: Without skipping the bytes of the vector this would read garbage data." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "why need this? i don't see Gen.CreatorPubKey being used?" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "As previously mentioned, best to drop this locale override. It's not something we only provide in exceptional circumstances. Moreover, it doesn't work for this PR anyway, while massively increasing the code complexity!" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "is this supposed to be `Desired`?" }, { "prediction": "I'm not sure if this is the case, but if it is the case, then it's the case.", "reference": "The iterator is not wrapped when the score mode is set to `COMPLETE_NO_SCORES` so you don't need to change this assertion anymore?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea.", "reference": "Is there too much spaces there? (should be 4 I think)" }, { "prediction": "I'm not sure if this is what you're trying to do, but it seems to be a bug.", "reference": "IS_FIRST_PULL revision is better to use instance property, not static. When KieClient has only one instance, instance property is better. When KieClient has many instances(not possible), static is not good eitheir." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for the'mixins' => ['fontawesome5_icon_mixin'], which is what you're looking for. I'm guessing you're looking for the'mixins' => ['fontawesome5_icon_mixin'], which is what you're looking for, but I'm guessing you're looking for the'mixins' => ['fontawesome5_icon_mixin'], which is what you're looking for.", "reference": "This needs to be removed since we removed the mixin." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Can `weight_` be deleted?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "This is fine, but by Symfony convention this part is responsability of the compiler pass class, i.e `DependencyInjection\\Compiler\\?`" }, { "prediction": "The Puppet user is not the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user. It's the Puppet user", "reference": "The host object already has a nice way of querying configprint. Try `puppet('master')['user']`" }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "Let's call this `share` and not `upload` - the user wants to share their flows, uploading is just the implementation of that. :)" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "It would be better to keep focus on the main text control. But to get around the fact that Dialogs focus their first child on show, even when not active, something like Dialog.isActive should be chcked when appending text, rather than whether the text control has focus." }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm not sure if it's a bug, but it's a bug.", "reference": "So is this invoked every time we extend the trace?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Why not use switch here?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I think `NoAuth` is a better name" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "This does create a minor bifurcation in how closing the InputWriter is done in success vs failure cases. Is there anyway to merge this with the success exit path? This is something that seems like it would be better as a function closure instead of method on the `$esapi.Name` type. Can the `es.Close` not be used instead of this method?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Please keep this blank line. PEP8 says: > Method definitions inside a class are surrounded by a single blank line." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "You are not passing in a `:params` key here." }, { "prediction": "I think this is a bug. It should be fixed in the latest release.", "reference": "Probably change \"ovs\" to \"OVS\"." }, { "prediction": "I'm not sure if this is the correct way to do this, but I think it's the correct way to do it.", "reference": "Please linebreak this" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's a good idea.", "reference": "`= default` is implied here, so having it is redundant. Is it a stylistic choice to include it, or just an oversight?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Maybe it's time to fix the param name for this interface?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a bug.", "reference": "Why are we removing it? Looks like useful info. Obviously, field names should change." }, { "prediction": "I think this is a bug in NLog.LayoutRenderers. I'm not sure if this is a bug, but it's a bug in NLog.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.LayoutRenderers.Renderers.LayoutRenderers.LayoutRenderers.Renderers.LayoutRenderers.LayoutRenderers.Renderers.LayoutRenderers", "reference": "Missing fallback to MessageTemplates.ValueFormatter.Instance" }, { "prediction": "I'm not sure if this is a bug, but it should be fixed in the future.", "reference": "The parameter in the docstring should be fixed too. Actually, why don't you try to implement the other axis? It wouldn't be impossible to do if we use pandas UDF from a cursory look. We have enough time before the next release currently." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "This also runs a patch if its in the middle of one." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Could we rename this method to `updateKnownStatus`?" }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "Maybe it would make sense to move that to DecorateRootSpan? Currently it only has Azure stuff, but given the name of the method I feel like it would be semantically appropriate" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'll try to fix it.", "reference": "nit: these imports were in a separate group to ones from this repo" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Is it possible to rename the methods to `isXXXMethod` to keep the usage by the caller generic? The caller could use the result of these methods to verify whether a feature is enabled or to validate an input value for example." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Don't penalize everyone with 250ms delay b/c some machines have problems." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug, so I'm not sure if it's a bug, but I think it's a bug.", "reference": "This try-catch should be here so that watcher thread doesn't just exit in case of an exception. This change alone would probably be enough to fix the error as well, assuming that there's another `ENTRY_MODIFY` event when the file write is finalized. But of course not a perfect fix because it doesn't protect against possibly reading a non-empty but only partially written file?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Weird that we have to check for `s == nil` here.. I would instead have fixed the call stack to find out when this gets invoked with a nil server." }, { "prediction": "I'm not sure why you're getting this error, but I'm not sure why you're getting this error, but I'm not sure why you're getting this error, so I'm not sure why you're getting this error.", "reference": "The `import` statement for `Ember` is missing in this file." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Awesome :tada: I'd love to have a test case for this so that we don't regress on this feature in any future refactorings :+1:" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "For testing some of the rounding functions" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug, so I'm not sure what's causing it.", "reference": "This should be present in UPGRADE notes. Also on currently running projects you should suggest users to update these settings." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug, so I'm not sure if it's a bug, or if it's a bug.", "reference": "Are you sure you want to do this? This will affect the working set block cache too, such that it'll now be tracking global free space. It throws off the fraction calculation." }, { "prediction": "I think it's better to use std::lock_guard instead of std::lock_guard for this purpose. I think it's better to use std::lock_guard instead of std::lock_guard for this purpose.", "reference": "Why would the read access need to be mutexed? The caller might still get a wrong answer since the value might change immediately after the mutex is unlocked before the caller receives the value." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "This fits on one line without the parentheses :wink:" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Looks like `TestCloudRecovery` changes are unrelated?" }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Try to separate it to different methods. Invoke is huge :)" }, { "prediction": "I think this is what you're looking for.", "reference": "Looks like another spot that would benefit from `truncate`" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct, so I'm not sure if I'm correct, so I'm not sure if I'm correct.", "reference": "This change is not related to what this PR wanted to fix, but undefined behavior sanitizer warns without this parenthesis because `h2o__tokens + i` overflows." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "This is actually incorrect and should be the other way around. Going to fix this tomorrow. If `no_docstring_rgx == re.compile(\"\")` no function should be checked, since every function matches the pattern. If `no_docstring_rgx == re.compile(\"^$\")` all functions should be checked." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Should this be in a config file?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "purely preference, but have you considered using parentheses to indicate that a method is being tested? e.g., `describe('eachAsync()')`" }, { "prediction": "I'm not sure if this is the case, but I think it's the case, so I'm not sure if it's the case.", "reference": "Why not return success?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, and I'm not sure what you're trying to do, so I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Please use snake_case for properties to keep it consistent with the rest of the codebase." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "i don't understand why we need this change. what information is this providing when running in less than Debug loglevel? I prefer to revert this" }, { "prediction": "I'm not sure if this is the case, but I think it's the case.", "reference": "Oh, so this test leaks DateTimeUtils offset? It would be safer to place the reset in an `@After` method to not cause side effects even if the test case fails." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "Kind of a nit-pick, but is there no way to solve this while still not rendering an empty div if `footerText` is empty? We could still use the `Row` to maintain the same layout but then only render the `Cell` for the pagination - I think it's possible to use specific classes to horizontally offset?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Template is also not an object type so I don't expect to notify on templates. Instead when applying templates, we'll be updating roles/policies/services/groups." }, { "prediction": "I'm not sure what you're trying to do, but if you're trying to do something like this, you'll want to do something like this:", "reference": "Had to fix this to get my tests passing (should have been a new PR sorry)." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Small nit, and sorry for not spotting sooner.. this should have `omitempty` on it, else when marshalling nil values into json, it will be `caBundle: null` which trips up some JSON parsers" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Would be good to say the normal behavior is scanline order (left to right, top to bottom) and that transposing makes it work top to bottom and left to right." }, { "prediction": "You can use the ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "Perhaps note here that `--drive-use-created-date` takes precedence if both set?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "Use EPS=1e-15 as that in atss_head or FCOS head." }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here is what you're trying to do here.", "reference": "Is there a need to replace the Index with a MasterIndex?" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "are we adding stop state change in a different PR?" }, { "prediction": "I think this is what you're looking for, but I'm not sure if this is what you're looking for.", "reference": "How much difference is there between sort and sort_by?" }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "count doesn't seem to be used. Let's remove it." }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Mongo is a hard dependency for Mongoid. Why do we need an if-statement to if it's defined? We should always use Mongo::QueryCache" }, { "prediction": "I think this is what you're looking for.", "reference": "Does this point out at a ROR funder id? If so, could we get rid of the `funder_name` field on the plan and just use the `name` of the funder with id `funder_id`?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Use!! to cast to bool, rather than the ternary bool antipattern." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "why is it in the list twice to begin with?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "This way you will **never** be kicked while monsters are around you." }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this:", "reference": "This just fixes an unrelated prop type error, correct?" }, { "prediction": "I'm not sure if this is what you're looking for, but it's probably what you're looking for. I'm not sure if this is what you're looking for, but it's probably what you're looking for.", "reference": "This was a bug in KBFS-2071 -- oops." }, { "prediction": "The ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` ` `", "reference": "// Condition is a condition for... Condition" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Might be good to test that no emails were sent out, either. You should be able to use `deliveries` for this" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but it should work.", "reference": "Right now this is experimental and deeply flaky. We left this at `info` to make debugging user reports a lot easier." }, { "prediction": "I'm not sure if this is what you're looking for.", "reference": "Is this new list being consumed yet?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "moved to `errors.go` which is the only places `math/rand` is used in this package" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "This use is wrong, corrent is: `Shopsys\\FrameworkBundle\\Component\\Environment` It is the same in classes below" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "This is not really needed, the line added in `GridNodeConfiguration.java` is what really fixes the `remoteHost` regression." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "For my understanding, why was this removed?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but it should work.", "reference": "the whole idea was to display information on the plugin directory in case it was missing - need to add if...else... and display the plugin dir if it is configured (non empty) but cannot be found" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Can you please set this as an error on the password view, rather than a toast, just to make sure that it is kept consistent. Check out a couple of lines below." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "Shouldn't we pass here a proposal too?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here.", "reference": "im not a huge fan of exact text match in these tests, not sure what a good solution is that solves the same problem" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "this should _not_ be in the api. all postage APIs have moved to the debugAPI" }, { "prediction": "def _is_internal_node(node): - # at least one of an internal nodes children are dicts - # some (group args) may not be dicts - return any(isinstance(x, dict) for x in itervalues(node)) + return not _is_leaf_node(node) + +def _is_leaf_node(node): + \"\"\" + A leaf node either has no children or defines a `file` key. \"\"\" + return not node or node.get(RESERVED['file'])", "reference": "Including both functions seems like overkill for this PR since only _is_internal_node is ever used. Keep them if you think they'll both be used in the future, but if not, the code will be easier to read if you collapse the logic into a single function." }, { "prediction": "I'm not sure what you're trying to do, but I think you're looking for something like this:", "reference": "It seems that the two words mean the same thing." }, { "prediction": "I'm not sure if this is a bug, but if it's a bug, it's a bug.", "reference": "Do we need to set lastLogTerm_ to committedLogTerm when `lastLogId_ < committedLogId_`, on line 286" }, { "prediction": "I'm not sure if I'm correct, but I'm not sure if I'm correct. I'm not sure if I'm correct, but I'm not sure if I'm correct.", "reference": "About ~7% memory usage increase on average, at most 512KB" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "Was this too big of a pain to do now?" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do.", "reference": "Why need to spend time for initializing of array? when will we rewrite the contents anyway? This can take a lot of time in some algorithms. Especially if the filling is in sequential mode." }, { "prediction": "I think this is what you're looking for.", "reference": "Can this be `null:false, default: ''` to avoid the nil vs blank issue?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "Had to add this to get macOS to work." }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "What is the usage of this class?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Could we keep the original signatures as well, so we do not have to rewrite the method calls everywhere and add `null, null`? I think this could greatly reduce the changes needed in this patch" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug.", "reference": "Ideally this error should not be swallowed (can do in the next PR)" }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this:", "reference": "Wait a minute... You're passing it as a POST parameter. There's no way that can work." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "minor: to be consistent with other logs, either use \"cleaning up\" (preferred) or \"cleanup\"." }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like \"redis\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or \"redis-listenbrainz\" or", "reference": "Adding the config changes to the consul config template `consul_config.py.ctmpl` would be helpful too." }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this:", "reference": "While we're at it should we add Department? See Dataverse Category: Add Department #2829" }, { "prediction": "I think this is a bug in Selenium. I'm not sure if it's a bug in Selenium, but it's a bug in Selenium. I'm not sure if it's a bug in Selenium, but it's a bug in Selenium, so it's a bug in Selenium.", "reference": "Files should have an extra line at the end of them." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "TODO: check whether this is needed or not" }, { "prediction": "I'm not sure if this is what you're looking for, but I'm not sure if it's what you're looking for, but I think it's what you're looking for.", "reference": "`ReadConfig` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, or if it's the case, or if it's just the case, it's just the case.", "reference": "This is duplicated with `+build!cgo`?" }, { "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here. I'm guessing you're trying to find an element with implicit waits enabled, but I'm not sure what you're trying to do here. I'm guessing you're trying to find an element with implicit waits enabled, but I'm not sure what you're trying to do here. I'm guessing you're trying to find an element with implicit waits enabled, but I'm not sure what you're trying to do here.", "reference": "This should just be `.not_to raise_error` otherwise it potentially hides errors" }, { "prediction": "I'm not sure what you're trying to do here, but I think you're looking for something like this. I'm not sure what you're trying to do here, but I think you're looking for something like this. I'm not sure what you're trying to do here, but I think you're looking for something like this.", "reference": "Line 175 needs to be indented so that it's under `sfun`." }, { "prediction": "I'm not sure if this is what you're trying to do, but I'm not sure if it's what you're trying to do, but I'm not sure if this is what you're trying to do.", "reference": "It looks strange a bit. What is the reason?" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Is this one of those `LexicalPreservingPrinter` issues?" }, { "prediction": "I'm not sure if this is what you're looking for, but if it's what you're looking for, it's probably more readable.", "reference": "Can we also add the length of the slice here? Some like ` len %d`" }, { "prediction": "I'm not sure if this is what you're looking for, but it seems like you're looking for something like this: https://github.com/iotexproject/iotex-core/blob/master/github.com/iotexproject/iotex-core/src/github.com/iotexproject/iotex-core/src/github.com/iotexproject/iotex-core/src/github.com/iotexproject/iotex-core/src/github.com/iotexproject/iotex-core/src/github.com/iotexproject/iotex-core/src/github.com/iotexproject/iotex-core/src/github.com/iotexproject/iotex-core/src/github.com/iotexproject/iotex-core/src/github.com/iotexproject/iotex-core/src/github.com/iotexproject/iotex-core/src/github.com/iotexproject/iotex-core/src/github.com/iotexproject/iotex-core/src/github.com/iotexproject/iotex-core/", "reference": "move this line together to after line 16, group internal packages together" }, { "prediction": "I think this is what you're looking for.", "reference": "How about using a reference(project_id) instead of project name" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "File is not `gofmt`-ed with `-s`" }, { "prediction": "I think this is a bug. It should be a bug. It should be a bug. It should be a bug.", "reference": "@qqmyers this looks fine but have you seen any performance issue here? If so, we could right some helper method like doesExternalToolNeedDataset(externalTool). But if there's trivial performance impact, not worth it." }, { "prediction": "This is not a wxStaticBox, it's a wxStaticBox, but a wxStaticBox.", "reference": "Make this a member variable instead (move to header inside `class` and rename to `m_bUsingLocalPrefs`)." }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug, so I'm not sure if it's a bug, but I think it's a bug.", "reference": "Generally I'd say we should factor this out into something more extensible (check an array of potentially skipped tests, for examples), but since we're likely to remove this soon for scheduled work I think this is fine. What do you think @daprahamian?" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "Why are we skipping these tests? they should be passing in HIP-Clang." }, { "prediction": "I'm not sure what you're trying to do here, but I think you're trying to do something like this:", "reference": "I think a \"string\" in Scapy's spirit (if such a thing exists) is actually a `bytes` object in Python 3 (see `Str*Field`s). So maybe `RandString._fix()` should return a `bytes` object. What do you think?" }, { "prediction": "I'm not sure if this is the case, but I'm not sure if it's the case, but I'm not sure if it's the case, so I'm not sure if it's the case.", "reference": "This can be combined to 1 line, just tested, seems to work." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "what needs to happen if it is not present?" }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "`DeploymentConfig` is only for deployment configuration not Piped configuration so `ds.DeploymentConfig.PipedSpec` is always nil. Instead of that, you can have Piped config with `e.PipedConfig` because it is placing inside `executor.Input`." }, { "prediction": "I think this is what you're looking for.", "reference": "Simple Storage **Service**" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's a good idea to use a filter function. I'm not sure if this is what you're looking for, but I think it's a good idea to use a filter function to filter requests on a per-request basis. I'm not sure if this is what you're looking for, but it's a good idea to use a filter function to filter requests on a per-request basis. I'm not sure if this is what you're looking for, but it's a good idea to use a filter function to filter requests on a per-request basis. It's a good idea to use a filter function to filter requests on a per-request basis, and should return a boolean. It should return a boolean. + /// If functions returns true, the request is collected. + /// If functions returns false, the request is filtered out. + /// If filter throws exception, then this is considered as no filter being configured. + /// If filter throws exception, then this is considered as no filter being configured. + /// If filter throws exception, then this is considered as no filter being configured. + /// If", "reference": "This line doesn't seem to be right?" }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "this need to be moved up after getting policy.." }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this:", "reference": "I'm curious - is there a way to test these?" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "This was broken before as the name of the metadata table started with its type, not catalog." }, { "prediction": "I'm not sure if this is a bug, but it seems to be fixed in the latest release.", "reference": "Maybe remake `VersionAsString()` function, so that that we would have build info in all places" }, { "prediction": "I'm not sure if this is a bug, but it's a bug, so I'm not sure if it's a bug.", "reference": "This should probably say something other than SSL_peek?" }, { "prediction": "I'm not sure if this is what you are looking for, but I think this is what you're looking for.", "reference": "Nitpicking, but this should be capitalized since it's a product name :)" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "Why do we need RawTransactions?" }, { "prediction": "I'm not sure if this is a bug, but it seems to be a bug.", "reference": "File is not `gofmt`-ed with `-s` (from `gofmt`)" }, { "prediction": "I'm not sure if it's a bug, but I think it's a bug. I'm not sure if it's a bug, but I'm not sure if it's a bug.", "reference": "should not be this lessThan15MinAgo?" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, so I'm guessing it's a bug.", "reference": "Would it work if we changed the return type of 'RejectRequest*' methods to Exception and instead did `throw RejectRequest(...`?" }, { "prediction": "I'm not sure if this is a bug or a bug, but I'm not sure if it's a bug or a bug.", "reference": "It is not a \"perfect\" test, but: webOS 1.2 emulator says `probably`. webOS 3 emulator says \\``. webOS 4 emulator says \\``. Why did you remove `options.supportsDts`?" }, { "prediction": "I don't think this is a bug, but it's a bug.", "reference": "This check should be after the HIP_INIT_API to ensure HIP tracing & lazy init works correctly. Also return should be wrapped in ihipLogStatus() so that logging works correctly." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "Can't use short array syntax for the 3.1 release branch." }, { "prediction": "I'm not sure if this is a bug, but I think it's a bug.", "reference": "@rhc54 Is this intentional or for debug purposes?" }, { "prediction": "I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "Maybe it should be `plugins.history` here instead of `listeners.X`, since we use those for listeners configured via `.ini` files?" }, { "prediction": "What is the purpose of this? What is the purpose of this? What is the purpose of this? What is the purpose of this? What is the purpose of this? What is the purpose of this? What is the purpose of this?", "reference": "Hmm, I also don't have a better idea here. As a small thing, could you make this `@team_page.present?` or similar to make the intent slightly more clear?" }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "Without that check it would fail later (probably in the getDecryptingCipher method) but the error could be hard to make sense of." }, { "prediction": "I'm not sure what you're trying to do, but I think you're trying to do something like this, and I'm not sure what you're trying to do.", "reference": "I don't think that this belongs in the host code. A host is pretty much unaware of what hypervisor is running it and I don't want them to be so coupled to their hypervisor." }, { "prediction": "I'm not sure if this is a bug or a bug, but it seems to be a bug.", "reference": "I'm here to tell you that this doesn't make sense because of the way it works. `setuptools.setup()` installs this only for setup-time and then discards those. But the problem is that it will not pick up a newer version because the older version is already in runtime and module cannot substitute itself. The proper place for adding build deps nowadays is `pyproject.toml`->`[build-system]`->`requires'." }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug.", "reference": "fakeConnectionManager -> mockConnectionManager. We probably should not use the `fake` anymore." }, { "prediction": "I think this is what you are looking for, but I'm not sure if this is what you're looking for.", "reference": "Code style. Btw, it's weird Codacy didn't catch that." }, { "prediction": "I'm not sure if this is a bug, but it's a bug.", "reference": "no need in BigInt just m.Unwrap().Big().Bitlen() == 0" }, { "prediction": "I'm not sure if this is what you're trying to do, but I think it's what you're trying to do. I'm not sure what you're trying to do.", "reference": "I assume you want to change NetworkPolicy to use bundles in a separate PR later?" }, { "prediction": "I'm not sure if it's a bug, but I'm not sure if it's a bug, but it's a bug.", "reference": "nit: We could parameterize the commit hash, as it's used in multiple places." }, { "prediction": "I'm not sure if this will work, but it should work.", "reference": "move this above the \"Constants\" as this is 3rd party ones" }, { "prediction": "I think this is what you're looking for. I'm not sure if this is what you're looking for, but I think it's what you're looking for.", "reference": "`assert not in`" }, { "prediction": "I'm not sure if this is a bug, but I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, it's a bug.", "reference": "just curious, why was this modified?" }, { "prediction": "I don't think this is a bug, but it should be fixed in the future.", "reference": "I'm curious why the table name is bound at compile time? Is it just to save the table create/drop overhead in a prepare-once-execute-many situation?" }, { "prediction": "I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's a good idea to use a different job type. I'm not sure if this is what you're trying to do, but if it's what you're trying to do, it's a good idea to use a different job type. I'm not sure if this is what you're trying to do, but it's a good idea to use a different job type.", "reference": "quick question, isn't ProcessJob used by all job types? Then why is JOB_ID not found?" }, { "prediction": "I'm not sure if this will work, but I'm not sure if this will work, but it should work.", "reference": "looks like you forgot to actually increase the version" }, { "prediction": "The type of this object depends on the event, which is given by the above parameter.", "reference": "I think it might be helpful if we add `Default value: False.` on the end of the summary." }, { "prediction": "I'm not sure if this is the correct way to do it, but I think it's the correct way to do it. I'm not sure if this is the correct way to do it, but I think it's the correct way to do it.", "reference": "I think the check should be `config.sync.fullSynchronization === false` - otherwise this will get triggered even when full sync is `true`." }, { "prediction": "The piped does not contain the encryption configuration. I'm not sure if this is the case, but I'm not sure if this is the case.", "reference": "this blown my mind" }, { "prediction": "I'm not sure what you're trying to do, but I'm guessing you're trying to do something like this, but I'm not sure what you're trying to do.", "reference": "this should be controller-container-status" }, { "prediction": "I'm not sure if this is a bug or a bug, but it's a bug.", "reference": "Sort import. You can use IDE's organize import feature." }, { "prediction": "I'm not sure if it's a bug, but it's a bug.", "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC." }, { "prediction": "I'm not sure if this is a bug, but it should be fixed in the latest release.", "reference": "This PR is off to a rough start. :)" }, { "prediction": "I'm not sure if this is the correct way to do it, but if it's the correct way to do it, I'm not sure if it's the correct way to do it, but if it's the correct way to do it, I'm not sure if it's the correct way to do it, so I'm not sure if it's the correct way to do it.", "reference": "Actually, it looks like the entire `normalizeProxyConfiguration` function isn't needed anymore" }, { "prediction": "I'm not sure what you're trying to do here, but I'm guessing you're trying to do something like this: