{ "test_bleu_4": 0.010783125181619209, "test_exact_match": 0.0, "test_rouge": { "rouge1": 0.1255148936273559, "rouge2": 0.01447631164857676, "rougeL": 0.10613670752542012, "rougeLsum": 0.10613769329797046 }, "test_bertscore": { "precision": 0.8420395969008143, "recall": 0.8352784078748825, "f1": 0.8380822437751351 }, "test_meteor": 0.09357076200275144, "raw_data": [ { "prediction": "I don't think we need to change this.", "reference": "can we also test for `transport=rest`?" }, { "prediction": "I think this should be `$this->config->get($this->mainConfig)`", "reference": "If record_batch_size is not set in config.ini, this code will trigger a notice about an undefined value. I would suggest either wrapping the setPageSize() call in an `if (!empty(...)) {` check, or else providing a default value in the set call (i.e. `$config->Index->record_batch_size?? 100`)." }, { "prediction": "I don't think this is needed.", "reference": "I didn't realize we were hardcoding this, thanks for moving it to an env value." }, { "prediction": "I don't think we need to check if `file.data.size` is `NaN` or `isNaN(file.data.size)`", "reference": "We are trying to support IE 10-11, so we'll need a polyfill for this one, I think." }, { "prediction": "I don't think this is needed.", "reference": "It looks like there's a new `isNavigatingTo( url )` selector for this very purpose so let's use this here instead. This way we just need to use the one selector rather than two. Let's assign that to a similar-named variable here (e.g. `isNavigatingToPostResetURL`) rather than the prop it's used with." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to rename the function to `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col` or `im2col`", "reference": "I think im2col should only accommodate CPUMat." }, { "prediction": "I don't think we need to import email_factory from google.cloud.forseti.common.util.email.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.email_factory.", "reference": "alpha sort the imports" }, { "prediction": "I'm not sure if this is the right place to use snprintf_s_iiii() or snprintf_s_iiii() or snprintf_s_iiii()", "reference": "Can you explain why is this necessary? Is `snprintf()` with four integer arguments unsafe?" }, { "prediction": "I don't think this is the right place to use `getKeyboardLayout` and `getKeyboardLayout`", "reference": "How likely would it be that the keyboard layout for the NVDA main thread differs from the keyboard layout of the currently focused app?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`)" }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it.", "reference": "Also update line 2205 below" }, { "prediction": "I don't think we need to expose shared mount value here.", "reference": "n_: It is a good practice to name the variable to indicate what they contain. In this case since `shared` is supposed to have boolean, calling it: `isShared` can help in the readability of the code." }, { "prediction": "I don't think we need to call `render()` afterward.", "reference": "I suppose it's a false-positive error. Maybe there is a way to configure the `eslint-*` package to accept `i.e..... lower case` syntax" }, { "prediction": "I don't think we need to check if the parentSpanId is null or not.", "reference": "this maynot be a perf issue, if ToHexString() is not actually allocating a string, but returns the caches string value. to be confirmed." }, { "prediction": "I'm not sure if this should be `zap.Error(\"failed to update image\", zap.String(\"image-provider\", provider.Name()), zap.Error(err))` or `zap.Error(\"failed to update image\", zap.String(\"image-provider\", provider.Name()), zap.Error(err))` or `zap.Error(\"failed to update image\", zap.String(\"image-provider\", provider.Name()), zap.Error(err))`", "reference": "`zap.String(\"image-provider\", provider.Name())` should be in a same line." }, { "prediction": "I'm not sure why this was removed.", "reference": "Why this deletion?" }, { "prediction": "I'm not sure if this is the right test.", "reference": "This change looks unrelated to the CL description?" }, { "prediction": "I think this should be `DEDUP_RESUTL_CHECK(inputName, outputName, sentence, expected)`", "reference": "I'm not certain that `res`+`utl` isn't a thing." }, { "prediction": "I think this should be `Status.SUCCEEDED.getNumVal()`", "reference": "This method can cause bugs. Why don't you use list of finalize statuses and then use join by comma and that will give you correct value. Use Apache Commons Lang library List list = Arrays.asList(1,2,3,4,5,6,7); String str = org.apache.commons.lang.StringUtils.join(list, \",\"); You can use it at multiple places shown in this diff." }, { "prediction": "I think this should be `if (!dev) return;`", "reference": "Merge with next condition" }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "Maybe add it when it is used." }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do this. I'm not sure if it's the best way to do this, but I'm not sure if it's the best way to do it. I'm not sure if it's the best way to do it, but I'm not sure if it's the best way to do it.", "reference": "More clear naming: NONEXISTENT_ENABLED" }, { "prediction": "I'm not sure if this is the right fix.", "reference": "why is this change necessary?" }, { "prediction": "I'm not sure if this is the right fix.", "reference": "make a SchemaTypeNameConverter.getTypeNameForEmptyType() and call that here." }, { "prediction": "I think this should be `$request->getSession()->getLang()->getLocale()`", "reference": "Use braces on your conditional structures please" }, { "prediction": "I don't think this is needed.", "reference": "Great God, I have a question. This \".nebula_history\" file is used to save history commands. Is there a file size limit? When the file is large, does it take a long time to start initialization (loadHistory)? How did you think about this? Thx." }, { "prediction": "I think this should be `return;` instead of `return;`", "reference": "Isn't this the same check as two lines above?" }, { "prediction": "I'm not sure if this is the right place to import it.", "reference": "Don't redefine, just import the existing one in `cmdline.py`. :)" }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it.", "reference": "why not call `respond_to?(\"#{name}=\")` from the `if` line?" }, { "prediction": "I think this should be `.withWorkDirectory(workingDir);`", "reference": "This was properly set above as `.runfiles/` (with a fallback to workspace root dir) but never used past this line." }, { "prediction": "I don't think we need to add this attribute to MvvmCross.Core.Views.", "reference": "Are all these namespaces required for this attribute?" }, { "prediction": "I'm not sure if this is the right thing to do here. I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do.", "reference": "Given this may be used and printed in other ways, isn't `debug` more appropriate?" }, { "prediction": "I'm not sure if this is the right place to do this, but I think it's better to call `clear()` in the `clear()` function.", "reference": "Looks like this is unused? Did you mean to call it when clearing the block journal?" }, { "prediction": "I don't think this is needed.", "reference": "why named alters? how about this.alerts = alerts?" }, { "prediction": "I don't think we need to change this?", "reference": "not sure if this has to be here or not tbh" }, { "prediction": "I don't think we need to keep the entity name under 50 characters as per Azure limits.", "reference": "There's a better fix for this in #1741, which should replace this." }, { "prediction": "I'm not sure if we should change this to `[]byte(\"node1\"), NetworkID: 0, Light: false`", "reference": "Use swarm.Address not []byte as type, and construct it from actual byteslice or use swarm.NewAddress if it is constructed from hex-encoded string." }, { "prediction": "I'm not sure if this is the right place for this test, but I think it's better to move this test to the `TestFSRepoInit` class.", "reference": "It would be worth factoring this out to a function, but you don't have to do that here." }, { "prediction": "I don't think this is needed.", "reference": "There's no need for `final` in interfaces." }, { "prediction": "I don't think this is needed.", "reference": "Isn't this case handled as a custom tag in `Span.SetTag()` below? This switch is only for special tags that actually set `Span` properties." }, { "prediction": "I'm not sure if we should remove this line.", "reference": "This shouldn't be changed." }, { "prediction": "I don't think this file is part of Invenio. It's not part of Invenio.", "reference": "This one is important `2: I102 copyright year is outdated, expected 2014 but got 2012`" }, { "prediction": "I don't think this is needed.", "reference": "Are these imports needed (BiConsumer and Consumer)? If they are unused imports, then precommit will fail." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if it's the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "Why are we catching and logging exceptions? By doing that we make it look like the job has succeeded and it will be removed from the queue - if we didn't do that then it would stay queued..." }, { "prediction": "I think we should remove the `$cartItems = $this->cartFacade->getCartOfCurrentCustomer();` line.", "reference": "If there are `@param` tags in docblock, there should be `@return` tag also. (applies for a whole file)" }, { "prediction": "I don't think we need this enum.", "reference": "Is the concept of validators exclusive to IBFT2? I wonder if this category should be more explicitly linked to IBFT2." }, { "prediction": "I think this is not needed anymore.", "reference": "Spotless is configured to reject star imports. Please replace with explicit imports." }, { "prediction": "I think this should be `m_maxShmemPerBlock = d.template get_info();`", "reference": "Remind me why you are using CUDA vocabulary when naming these variables." }, { "prediction": "I think this should be `if (feedFilter == UserPreferences.FEED_FILTER_COUNTER_ZERO) {`", "reference": "Please turn the iteration order around (instead of `0...size` to `size...0`). The reason is that this sometimes skips indices when removing an item. You can therefore end up with feeds that have counter 0 and are still displayed." }, { "prediction": "I'm not sure if this is the right place to call `build_sub_pipeline` or `build_sub_pipeline`?", "reference": "this is a behavior change. solid_subset=[] represents an empty pipeline where as solid_subset=None is the full pipeline" }, { "prediction": "I'm not sure if this is the right place to log the error.", "reference": "this is a breaking change, any specific reason you want to do this?" }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "Blocking: we still want read write separation. Node functions should absolutely not write to the chain store and the interface should reflect that. Only the syncer should have this capability in production code. It should be no problem to keep casting chainForTest to a read-write interface, or doing other function decomposition and automatic casting tricks." }, { "prediction": "I don't think we need this.", "reference": "The PR description says the lowest on-demand request priority is `2^30`. Why the `-1` here?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "checking health again? I think it is not necessary." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it.", "reference": "Need an `if err == nil {break}` above this line so that we don't log/sleep if the retry succeeds." }, { "prediction": "I don't think this is needed.", "reference": "to reiterate my point above, this class is not the actual provided Promise, but rather something a user can provide a Promise to/with. I think a name like `PromiseProvider` is more appropriate." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "I guess we can only call this from a post-build function, but we might need to check that this target is to be built? I guess target A depends on B which has a post build. We `plz build :B` which adds C as a dep of A. Won't we queue C to be built even though it only needs to build if A needs to be built? That's kinda why I approached this the way I did. I trust you've thought about this but would be good to understand this a bit better." }, { "prediction": "I don't think we need to check for `arch.FREEBSD` or `arch.DARWIN` here.", "reference": "You should use `isinstance()` instead of comparing the class name to a string." }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to use `el.nodeName.toUpperCase()` instead of `el.nodeName.toLowerCase()`", "reference": "Why should audio and video elements always return `false` for `isHidden`?" }, { "prediction": "I'm not sure if this is the right place to register AppStart.", "reference": "This obviously won't work for all the other platforms." }, { "prediction": "I think this test should be `InjectableStepsFactory` instead of `InjectableStepsFactory`.", "reference": "Isn't he diamond operator Java7+?" }, { "prediction": "I'm not sure if this is the right place to put this method.", "reference": "Prefer adding a second `positive(String, double)` that delegates down to this three-param version. Using `null` in code is generally Not A Great Idea, and it looks ugly." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This pattern, where we add a new parameter without using it, often indicates to me that we've got a leaky interface or abstraction. I see this pattern _a lot_ in this patch, so wondering you have thoughts about it." }, { "prediction": "I think this should be `if err!= nil { return err } else if err!= nil { return err } else if err!= nil { return err } else if err!= nil { return err } else if err!= nil { return err } else if err!= nil { return err } else { return err }", "reference": "This seems like an improved pattern :)" }, { "prediction": "I don't think we need this anymore.", "reference": "`open_id_authentication` is no longer the name of the function, and it's not OpenID specific" }, { "prediction": "I think this should be `Balance: (XRB): (XRB): (XRB): (XRB: (XRB): (XRB: (XRB): (XRB: (XRB): (XRB: (XRB: (XRB: (XRB: (XRB: (XRB: (XRB: (XRB: (XRB: (XRB: (", "reference": "This didn't require corresponding changes to the test case(s)?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `env_file` or `env_file_name` or `env_file_name` or `env_file_name` or `env_file_name` or `env_file_name` or `env_file_name` or `env_file_name` or `env_file_name` or `env_file_name` or `env_file_name` or `env_file_name` or `env_file_name` or `env_file_name` or `env_file_name` or `env_file_name` or `env_file_name` or `env_file_name` or `env_file_path_name` or `env_file_path_name` or `env_file_path_name` or `env_file_path_name` or `env_file_path_name` or `env_file_path_name` or `env_file_path_name` or `env_file_path_name` or `env_file_path_", "reference": "A question! I think `string` totally works, but what do you think of `*string` for consistency?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Should this be: `aws.infrastructure.cluster.sigs.k8s.io` instead?" }, { "prediction": "I'm not sure this is the right place to do this.", "reference": "Not clear on why this change is correct." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "Hi Simon. Whether this should return true depends on what byte buffers are used? The same applies to ByteBufferIndexInput, actually... I don't think you can generally tell whether the ByteBuffers the input operates on come from a mmap call or from somewhere else (even direct buffers don't have to be a result of mmap)." }, { "prediction": "I don't think this is needed.", "reference": "All stories in this file also need to have the default padding." }, { "prediction": "I think this should be `assert(sibling->parent == subsurface->parent);`", "reference": "I don't think these asserts are necessary, because `subsurface_find_sibling` already searches in the parent. Or am I missing something?" }, { "prediction": "I don't think we need to do this, but I think it's better to do `where(\"published_on <=?\", Date.today).order('published_on desc')` instead of `where(\"published_on <=?\", Date.today).order('published_on desc')`", "reference": "Should this be `number` instead of `id`?" }, { "prediction": "I don't think this is needed.", "reference": "I have forgotten why we thought this restriction is necessary. A user registers a Hive/HBase table with us but is not able to use the table with the registered name in DML. Will UPDATE STATs will be on the original name too (and update stats code will find out registered name and use it for Table_uid?). This was the registration concept is almost like an internal implementation idea, at some point could even be done by some utility program for all existing Hive/hBase tables, and the user need not be aware of it? I am struggling with a user would want to register a table, if they cannot use it by that name." }, { "prediction": "are not used in in a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a", "reference": "Should most of these non-globals be static?" }, { "prediction": "I'm not sure if this is the best way to test this. I'm not sure if it's the best way to test this.", "reference": "Please do not approve PRs without tests!!!!" }, { "prediction": "I think win_id should be `win_id`.", "reference": "Now that you handle this in `webenginetab.py` you can undo all the changes in this file." }, { "prediction": "I think this should be `Application.launch(JavaFXApplication.class);`", "reference": "I think we should log the exception to a log file instead of printing it. The current behavior (not catching the exception) should lead to an automatic print of the exception to the terminal/console." }, { "prediction": "I'm not sure about this change, but I think it's better to use `Warn` instead of `Warn`.", "reference": "These changes to the resource helpers have some more far-reaching implications as they also affect calls made in hive-operator, I believe. It's probably OK still, though. Ideally, the resource helper would not be the one doing the logging, since it cannot know the severity, but that is well beyond something that we should tackle for this PR. I would rather have the hive-operator log warnings than have the syncsetinstance controller log errors." }, { "prediction": "I don't think we need this anymore.", "reference": "do you really want to change the behavior on foreign key?" }, { "prediction": "I'm not sure if this is the correct behavior. I'm not sure if this is the correct behavior, but I'm not sure if this is the correct behavior.", "reference": "Looks like my bad. Thanks for fixing!" }, { "prediction": "I don't think this is needed.", "reference": "I think \"Don't replace variables...\" would be cleaner." }, { "prediction": "I don't think we need to change this?", "reference": "Do you validate the possible strings? I've not read the code below but we should make sure if a string is supplied it is validate..." }, { "prediction": "I don't think we need to generate dataDiskName here. I don't think we need to generate dataDiskName here.", "reference": "I'd recommend using generateDataDiskName here as well -- might as well benefit from the safety that it gives to protect yourself from future changes to w.ID()." }, { "prediction": "I don't think this is needed.", "reference": "qq: do we want to include anything in the name to indicate that it is a position in the manifest?" }, { "prediction": "I think this should be `Log.d(LOGTAG, \"Compositor resume begin\");`", "reference": "These logs should probably use the `LOGTAG`" }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "From this, it was clear, that we are using our version of wireguard-go. And now it looks like we are using original packages which is confusing." }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Any particular reason for this? This potentially will make harder to investigate users issues" }, { "prediction": "I think this should be `Blockly.highlightedConnection_!= closestConnection || Blockly.localConnection_!= localConnection`", "reference": "Do you also need to check if Blockly.localConnection_ is non-null?" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if this is the right place for this.", "reference": "Not really a container, and it's not just about non-config data, not sure of a better description, @myronmarston?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea, but I'm not sure if it's a good idea.", "reference": "The desktop app will load this fine. on iOS I get `TypeError: undefined is not an object (evaluating '_$$_REQUIRE(_dependencyMap[8], \"stream\").Readable.Readable')` if I change it to `const Readable = require('stream').Readable;` or `const { Readable } = require('stream');` I get undefined errors from the stream on iOS: `[TypeError: stream.on is not a function. (In'stream.on(\"data\", function (chunk) { return chunks.push(chunk); })','stream.on' is undefined)]` What am I missing?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "this is needed since the chunk feeder shares memory across calls to the pipeline. this is in order to avoid multiple allocations. this change mimics the behavior of shed and localstore, and copies the data from the call into the in-memory store" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "wut. We can do this at the beginning of tests if we want right? Why are we depending on init?" }, { "prediction": "I think this should be `if acc!= nil && srv.gacc!= srv.gacc {`", "reference": "Same trick here IMO." }, { "prediction": "I don't think we need this anymore.", "reference": "Should be `@origin = element || origin || POINTER`" }, { "prediction": "I think this should be `if options.cstorSPC.spcName!= \"\" { bulkCstorSPCUpgrade(cmd, args) } else { bulkCstorSPCUpgrade(cmd, args) }`", "reference": "this example needs a fix?" }, { "prediction": "I'm not sure if this is the right place to close the window.", "reference": "Is it safe to assume this surface is a toplevel?" }, { "prediction": "I think this should be `pj_ctx_free()`", "reference": "we don't need that function" }, { "prediction": "I think this should be `win10` instead of `win10`.", "reference": "we'll also have to think about adding \"Windows Server 2014\" or whatever they come up with later." }, { "prediction": "I don't think this is the right place to call fetchActiveFlowByExecId.", "reference": "curious do we have an API to fetch an inactive flow?" }, { "prediction": "I'm not sure why this was removed.", "reference": "This branch is not needed anymore because every `vnode` that passes through `h` in compat or core will have the `$$typeof`-property now." }, { "prediction": "I don't think we need to check if `ariaHiddenValue` is null.", "reference": "Did you mean to use `hasAttribute`? You shouldn't. This does not improve performance and it messes with the readability." }, { "prediction": "I don't think this is needed anymore.", "reference": "Please import modules and not classes (except for Qt stuff)." }, { "prediction": "I think this should be `public void setImage(String image)`", "reference": "Hm... why do we have a \"DummyJavaNode\" in src/main? Looks like, this should have gone into src/test...." }, { "prediction": "I don't think this is needed.", "reference": "This seems meaningless. If we cannot add any info let us remove this." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Can you rename `Ports` to `PortsUnsafe`?" }, { "prediction": "I'm not sure if this is the right place for this method.", "reference": "This feels like it could be moved out to your first gem!" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "The expected behaviour for `poll` would be to match what `Deque` does, which is: > Retrieves and removes the head of the queue represented by this deque As such, you shouldn't need the `RequestId` here." }, { "prediction": "I don't think this is needed.", "reference": "This is super minor, but it'd be nice if this iterated over an arbitrary number of array inputs." }, { "prediction": "I think this should be `char path_buf[MAXIMUM_PATH];`", "reference": "What is the problem here? The commit message has strange wording \"readlink is defined with restrict pointers\": do you mean \"restricted\"? Is that a well-defined language term? I'm not sure what it means." }, { "prediction": "I'm not sure if this should be `ImmutableSet` or `ImmutableSet`.", "reference": "Why are we not wrapping here?" }, { "prediction": "I think we should remove the `@Nullable` annotation.", "reference": "I though that all data objects are being unified in the fashion where all default values are initialized in constructor, are not they?" }, { "prediction": "\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"", "reference": "Does this file actually need to be committed to git? Having to run `make generate` is rather tedious on each PR and it conflicts easily." }, { "prediction": "I'm not sure why this was removed.", "reference": "We don't need this anymore, as Google's library handles various auth mechanisms for us. We'll be less explicit about why we're failing but we gain support for several authentication methods- swings and roundabouts!" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "No need to speficy attribute here. Moreover in yaml it is default to use lowercase names." }, { "prediction": "I don't think this is needed.", "reference": "In general I'm a trying to understand the reason behind this PR. Looks like if a blob (name) already exists we check if the contents are identical? In what scenarios this is not the case? When we want to publish a package/asset that has changed but still we want to use the same version?" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it.", "reference": "Can rename `req` to be `opener`, since that is the object, and it wraps `req` internally?" }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "@MichaelDCurran, thoughts on adding a breakpoint format field attribute? It seems almost app specific, but I guess it does seem odd abusing line-prefix. Is there any more generic concept here?" }, { "prediction": "I think this should be `return self.size, self.location`", "reference": "This would return a tuple of two dictionaries. You need to combine them and return a dictionary" }, { "prediction": "I don't think this is needed.", "reference": "What do you think of moving the example to the help text of the prompt? and the prompt itself can be \"What is your application's GitHub repository URL?\"" }, { "prediction": "I don't think this is the right place for this test.", "reference": "Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs." }, { "prediction": "I'm not sure if this is correct.", "reference": "Nice use of std::distance. I'm a bit worried about first += 9 though." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Shouldn't this be `app.kubernetes.io/managed-by` as prometheus-operator manages this resource, but this resource isn't a part of prometheus-operator?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "As long as we're being extra-vigilant about NREs, should we check that `httpMethod` and `requestUri` are not null?" }, { "prediction": "I'm not sure if this is the right place for xrc20 or xrc20", "reference": "No need to have `xrc20` alias" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.", "reference": "the naming convention I'm been adopting if `_type` for instances of these classes. So maybe `context_config_type` is a better name for this fn" }, { "prediction": "Is gpuMining set to false?", "reference": "Don't call it GPU mining, call it `externalMining`, here and throughout." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "`within this with` typo, should be `within this width`" }, { "prediction": "I'm not sure if this should be `true` or `false`.", "reference": "how come this is false?" }, { "prediction": "I'm not sure if this is the right place to use `typeOf(args[i])!== types[i]` or `typeOf(args[i])!== types[i]`", "reference": "How about `Object.prototype.toString`? Or using the `typeof` operator?" }, { "prediction": "I think this should be `ctx.Context`", "reference": "I know @jzila suggested this, but I disagree: you're really not supposed to save a context in a struct. Can you get by with just saving the `Done()` channel instead? The `ctx` should continue to be passed around explicitly." }, { "prediction": "I don't think this is needed anymore.", "reference": "This check isn't right though." }, { "prediction": "I don't think we need to add this method to the `DynamicLangXApiView` class.", "reference": "maybe `toolkitVersion` instead? It doesn't necessarily have to be called that in the generated code, but in the view model classes, I think it makes it clearer that it is the version of toolkit itself." }, { "prediction": "I don't think we need this change.", "reference": "the response data was added intentionally in #612, i think we could keep the `setFileState` stuff here as a special case, at least for now" }, { "prediction": "I'm not sure if this is the right place to use `time.Now()` or `time.Until(deadline)`", "reference": "This isn't really easy to read." }, { "prediction": "I don't think we need to change the error message here.", "reference": "This line changed due to go formatting. Format was not there earlier." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "The name \"Without\" in code is a little nebulous. Maybe something more descriptive like TrimPrefix or StripPrefix or WithoutPathPrefix or something like that. (Thoughts?)" }, { "prediction": "I think this should be `FORBIDDEN.getStatusCode()` instead of `FORBIDDEN.getStatusCode()`.", "reference": "is this test in the move tests? I see what you mean then - it works, but I wonder if we won't lose track that it's being tested here." }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do here.", "reference": "I'm not sure if this wanted to be `json:\"tags\"` (which I'd set in my PR) or `json:\"tag\"` that someone elses PR had set. Given that the rest of the fields had their JSON field name set to the same as the struct field name, I opted for `tags`." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.", "reference": "since the logic here and in `Proposal` is exactly the same, do you think it makes sense for us to include it elsewhere? I am not opposed to duplicated code when it makes sense, but the reason I first identified this was that I was looking for code in NCR::WorkOrder that was not specific to Work Orders. Seems like fiscal year logic might be helpful for reporting for other clients. In that case, we'd want this scope on those client data classes as well. Might be wrong to include this in the FiscalYear mixin, but it does seem like it should be outside of Proposal and WorkOrder. Does that make sense?" }, { "prediction": "I don't think we need to add a timeout here. I think we need to add a timeout to the `on_connection_closed` method. I don't think we need to add a timeout to the `on_connection_closed` method. I think we need to add a timeout to the `on_connection_closed` method to the `on_connection_closed` method.", "reference": "there is no static method as a go between -- how does this work?" }, { "prediction": "I don't think we need to store this in Mongoid. I'm not sure if we need to store it in Mongoid.", "reference": "Can you please change the name of this class to be something else?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `coma_separator` parameter.", "reference": "I think we might prefer generalizing the interface rather than creating an exception. Current design of `h2o_next_token` assumes the input to be a comma-separated list, and allows the caller to specify a different separator when parsing a nested list. As I understand, what we are trying to attain in this PR is to have a way of parsing a flat list of semicolon-separated list. Assuming that is the case, I think it would be better to change the API of the function to accept two separators (i.e. inner and outer), where for our existing use-cases `outer` would be `,`." }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "why not recycling? I Lru cache now recycling?" }, { "prediction": "I don't think we need to change this?", "reference": "Why it is now called `PaymentVersionV3`?" }, { "prediction": "I think this should be `klog.V(4).Infof(\"there are %d nodes need to sync secret, operation: %s\", len(nodes), e.Type)` and not `klog.V(4).Infof(\"there are %d nodes need to sync secret, operation: %s\", len(nodes), e.Type)`", "reference": "changed for debug purpose?" }, { "prediction": "I think this should be `internal void SetParentProvider(BaseProvider parentProvider) { base.SetParentProvider(parentProvider); }`", "reference": "@cijothomas I needed a way to set the Exporter.ParentProvider when the Processor's gets set. Internal to SDK though." }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it.", "reference": "Talking through this scenario with @srividyacb and she's wondering if there should also be a check of `(from_trunk && node_based_graph.GetEdgeData(eid).flags.road_classification.IsLinkClass())` as highways with trunk classifications can also have this scenario." }, { "prediction": "I don't think we need to change this to `master_certname` or `master_host_certname`", "reference": "where does `master_certname` come from?" }, { "prediction": "I don't think we need to import HRNet here.", "reference": "The line breaking is unnecessary." }, { "prediction": "I don't think this is the right place to do this.", "reference": "why not enable split by space here?" }, { "prediction": "I'm not sure if this is a bug or not.", "reference": "Shouldn't the operator be &&?" }, { "prediction": "I don't think we need to do this. I'm not sure if we need to do this.", "reference": "My best guess is that you want to use host.name in these parts to get the name of the host?" }, { "prediction": "I'm not sure if we need to persist the root nodeType when we marshal the manifest. I'm not sure if we need to persist the root nodeType when we marshal the manifest, or if we need to persist the root nodeType when we marshal the manifest. If we need to persist the root nodeType when we marshal the manifest, we need to persist the root nodeType when we marshal the manifest. If we need to persist the root nodeType when we marshal the manifest, we need to persist the root nodeType when we marshal the manifest.", "reference": "IMO this edge case handling could remain here, just instead of overwriting the `n.nodeType`, the `makeEdgeType` method of `n` should be called, so `n.nodeType = nodeTypeEdge` -> `n.makeEdge()`" }, { "prediction": "I don't think this is the right place to do this, but I think it would be better to move this logic into `NotificationManager.updateReport(reportQueue, showAutoDownloadReport);` so that we don't have to call `updateReport(reportQueue, showAutoDownloadReport)` twice.", "reference": "Just wondering... The two kinds of notifications are now quite different (Channel, text, maybe even icon). Would it make sense to extract the auto download notification to a new class instead of handling everything in the existing `notificationManager`? I have not checked if this will lead to a lot of code duplication, though." }, { "prediction": "I don't think this is needed.", "reference": "Do we need to put this on the Call? We only need the API communication between the Encoding and the Transports which is currently done through the Transport.Request. The Call is used by users right?" }, { "prediction": "I don't think this is needed.", "reference": "`ctx` is unused in GenerateAPIKey" }, { "prediction": "I think this should be `log.L().Fatal(err.Error(), zap.Any(\"cfg\", cfg))` or `log.L().Fatal(err.Error(), zap.Any(\"cfg\", cfg))`", "reference": "Can you judge the type of error?" }, { "prediction": "I don't think this is needed.", "reference": "Much simpler than a weird and confusing ``convolve`` call!" }, { "prediction": "I don't think we need to change this test.", "reference": "Huh, this seems weird to me... Surely the suspenders render was called again in order to get the new `
Hello second 2
` output... Imma take a peak at these tests to understand what's going on" }, { "prediction": "I'm not sure if this is the right place to call this method. I'm not sure if it's the right place to call this method, but if it's the right place to call it, I'm not sure if it's the right place to call it, or if it's the right place to call it.", "reference": "Since this is just a helper function to create text, perhaps this could live in a helper? I noticed that we have a few other error/message creators in the application controller as well, but I think this type of function should be re-factored to be part of a helper." }, { "prediction": "I'm not sure about this, but I think it's better to use `msg_id` instead of `msg_id` here.", "reference": "Will this mess up parsing the messages by other editors? (vscode, vim...)" }, { "prediction": "I'm not sure if this is the right place for this file.", "reference": "Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I don't think we need to use `Memory.Lease()` here.", "reference": "Why can the pool be null?" }, { "prediction": "I don't think this is needed.", "reference": "It might be good to have a note here: > work-around for issue #7562 allowing us to differentiate presentational lists from interactive lists (such as of size greater 1 and ARIA list boxes). In firefox, this is possible by the presence of a read-only state, even in content editable." }, { "prediction": "I don't think we need to change this to `Set>`", "reference": "This set of changes is the one part of this that I'm not completely sure is valid. Can someone look over this to make sure I got the E's right?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "There doesn't seem to be a reason to copy this here." }, { "prediction": "I don't think this is needed.", "reference": "We've avoided including h2o headers in BPF programs because it's a runtime dependency. However, IIRC, this is because h2olog was maintained in the separate repository so that h2olog did not know where h2o was installed. Now h2olog can use `H2O_ROOT`, we should add it to BCC's `cflags` in order to include h2o headers in BPF programs." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "I think the docstring here should include the CLI arg `--alert.query-url` just to make it clear to users which setting this uses." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "Same change just above?" }, { "prediction": "I'm not sure if this is the right test.", "reference": "Could you check the result content rather than just the number of search results please? For example with this test if the search engine suddenly starts returning \"latin n\" for both queries, we won't know about it." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "nit: I think that `workloadID` should suffice for this test... that's what we'd be issuing anyways" }, { "prediction": "I'm not sure if this is the right place to use `spec_helper` or `rails_helper`", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I'm not sure about this change, but I think it would be better to remove the `ClassNotFoundException | NoClassDefFoundError` from the catch block.", "reference": "We should have a rule to detect identical catch branches" }, { "prediction": "I'm not sure if this is used anymore. I'm not sure if it's used anymore or if it's used anymore.", "reference": "remove these from the targets file." }, { "prediction": "I'm not sure why this is removed.", "reference": "now that we have the signature in the hive messages, it might be that this must be drastically reduced, since there are limits on the protobuf reader/writers i believe" }, { "prediction": "I think this package should be `mailjet-rest`", "reference": "I recommend that we move this to be optional, as other users might not need it. Can you look at `OPTIONAL_PACKAGES` section, around line 68?" }, { "prediction": "I don't think this is needed.", "reference": "I usually set idea to never use wildcard import such as `import java.util.*;` Now i use setting from javaslang standard." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea.", "reference": "Where is host['ips'] coming from?" }, { "prediction": "I'm not sure if this is the right place for this function, but I think it's better to move this function to `user.ParseIDMap` and use `user.ParseIDMap(string(data))` instead of `user.ParseIDMap(string(data))` in the `user.ParseIDMap` function.", "reference": "oh! missed a `:` here; let me fix that; also can get rid of the intermediate variable" }, { "prediction": "I'm not sure if this is the right place for this test, but I'm not sure if it's the right place for this test.", "reference": "Is this necessary?" }, { "prediction": "I don't think this is needed.", "reference": "I'd create a different method for each render section." }, { "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a `isReverted = false;` in the `EstimateGasOperationTracer` class. I think it would be better to have a `isReverted = false;` in the `EstimateGasOperationTracer` class.", "reference": "Instead of storing the revert flag in the tracer is it possible to use org.hyperledger.besu.ethereum.mainnet.TransactionProcessor.Result#getRevertReason? (via org.hyperledger.besu.ethereum.transaction.TransactionSimulatorResult#getResult)? If a TX reverts without a reason do we get an empty revert reason or a revert reason with zero bytes?" }, { "prediction": "I don't think we need to create a new SparkOrcReader for this test.", "reference": "I think this should test with and without container reuse if that is implemented in this PR. Probably just make this test parameterized." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do it.", "reference": "These modifications allow BaseFile to translate into a SparkRow with the specID as a column" }, { "prediction": "I'm not sure if this is the right place to use `typeof readPreference ==='string'? new ReadPreference(readPreference) : readPreference;` or `typeof readPreference ==='string'? new ReadPreference(readPreference) : readPreference;` or `typeof readPreference ==='string'? new ReadPreference(readPreference) : readPreference;` or `typeof readPreference ==='string'? new ReadPreference(readPreference) : readPreference;`", "reference": "is this something we've been missing this whole time?" }, { "prediction": "I'm not sure if we should change this to `allEvents = \"*\"` or `allEvents = \"*\"`?", "reference": "nit: this is a package-wide constant so better to narrow the scope like `allEventsSign`." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it.", "reference": "There seems to be some repetition. Does a local function make this code shorter overall?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "Might be cheaper to reuse the `null` assignment of line 313 and set `isHydrating` to null instead WDYT?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Revert this blank line" }, { "prediction": "I don't think we need to clear this property.", "reference": "This was introduced recently for the Hadoop 3 upgrade. Copy/paste error but definitely causing some of the new test failures." }, { "prediction": "I'm not sure if this is the right place to use it, but I think it's better to use `before_action :check_disabled_client!` instead of `before_action :check_disabled_client!`.", "reference": "I think we should only need to do this for `:approve` since we are using `authenticate_user!` for all other actions and that checks for disabled client" }, { "prediction": "I'm not sure if this is the right place to test this, but I'm not sure if it's the right place to test this.", "reference": "I wonder if we should create new tests for header checks; here for instance we're mixing querystring and headers. Thoughts?" }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "We should be able to add sensitive by hard-coding the parameters, same as you put into the metadata in apply_helpers." }, { "prediction": "I think we should move this file to `ShopBundle\\Model\\Order\\Item`", "reference": "Why do you think that it is necessary to create this class?" }, { "prediction": "I'm not sure if this is the right place to use `r.Seek(0, 0)` or `r.Seek(start, 0)` or `r.Seek(start, 0)` or `r.Seek(start, 0)` or `r.Seek(start, 0)` or `r.Seek(start, 0)` or `r.Seek(start, 0)` or `r.Seek(start, 0)` or `r.Seek(start, 0)` or `r.Seek(start, 0)` or `r.Seek(start, 0)` or `r.Seek(start, 0)`", "reference": "replacing the `1` with `io.SeekCurrent` may be good here" }, { "prediction": "I'm not sure if this is the right place to use it. I'm not sure if it's the right place to use it, but I'm not sure if it's the right place to use it or if it's the right place to use it.", "reference": "nit: perhaps this file would be better named `jwks_source.go`?" }, { "prediction": "Should we rename this constant to `param_override.properties`?", "reference": "It will be helpful to specify the intended priority as well for the properties within this file." }, { "prediction": "I'm not sure if this should be `RunFunc` or `RunFunc`.", "reference": "Make this private and update all the public functions to not take this argument. The variable you set below should also be private, then in the tests instead of passing the variable in to the function just update the variable. We don't want to expose the testing implementation in the public api if it can be avoided." }, { "prediction": "I don't think this is needed.", "reference": "Do you now why is it a specific table name is used as a default?" }, { "prediction": "I don't think this is needed.", "reference": "If all you're doing is checking for the existence of a directory as your \"temp\" directory, why does it matter what OS you're on?" }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "nit- would be cleaner to import it once" }, { "prediction": "I don't think we need to do this.", "reference": "Looks like there is a closing parenthesis `)` missing here." }, { "prediction": "I'm not sure if this is a bug or not, but I'm not sure if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug.", "reference": "this one bothers me. There are many places where this one is written to for an error message and just a single callsite is changed." }, { "prediction": "I don't think we need to do this. I think we should do this in a separate PR.", "reference": "You can put this in `kbfsOpsInit()` in you want, so we don't have to call it in every test." }, { "prediction": "I'm not sure if this is the right fix for 64-bit counter support.", "reference": "`ARM_32` is what clients define as an input to DR, and is not always defined internally: we use just `ARM` to mean AArch32." }, { "prediction": "I'm not sure about this, but I think it would be better to have a `FieldModel` class that has a `FieldModel` instance and has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance that has a `FieldModel` instance", "reference": "s/for use/to use for/" }, { "prediction": "I don't think we should change this to `avatar_filename` or `avatar_filename`", "reference": "` $event->getAvatarFilename()` this function return `string` or `null`. In this place ` $event->getAvatarFilename()->getValue()` return `Fatal error `" }, { "prediction": "I'm not sure if this is the correct error.", "reference": "why not creating a new error type for server's own resource limit exceed error and do conversion within rpc interceptor?" }, { "prediction": "I think this should be ``.", "reference": "Could be a timing thing here. When options are created they'll copy the ref for the current default propagator. If user sets through SDK the global propagator after that, it won't be reflected. Could leave it null here and then when it is used in instrumentation do `options.Propagator?? Propagators.DefaultTextMapPropagator`. It would be a slight perf hit but it makes it hot-swappable." }, { "prediction": "why remove this?", "reference": "Unrelated file. Please remove from PR." }, { "prediction": "I think this should be `Access-Control-Allow-Origin: *\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n", "reference": "Careful: you only want two newlines after the final header message. (That indicates the end of headers and the start of data.)" }, { "prediction": "I think this should be `Upgrade-Insecure-Requests` and not `Upgrade-Insecure-Requests`.", "reference": "This will not work on Python 3 (to which we are transitioning) because `.content` is bytes, not a str. Can you make the pattern a bytes object as well (like so: `b\"pattern\"`)?" }, { "prediction": "I don't think we need this anymore.", "reference": "This was to allow the tests to pass when the order of the required was different. Silly, but we don't have an easy way to check for \"equal but order doesn't matter\" in chai." }, { "prediction": "I don't think this is needed.", "reference": "maybe say \"returns the default cost method that returns an object of cost 1\"." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "I believe these rules will be enforced both (1) on egress from a local workload, and (2) on ingress **to** a local workload. Right? I understand that we definitely want (1), but do we really want to enforce (2) as well?" }, { "prediction": "I think this should be `JSONObject errorObj = new JSONObject(); errorObj.putOpt(\"response\", response.fullResponseAsJSONObject()); callbackContext.error(errorObj.toString());`", "reference": "Use `response.asJsonObject()` instead. Also, use `put()` instead of `putOpt()`, `null` as a value is fine." }, { "prediction": "I'm not sure if this is the correct behavior.", "reference": "Are you sure? We've changed it during an introduction of the IME support." }, { "prediction": "I think this should be `if (!empty($dqlFilter)) { $queryBuilder->andWhere($dqlFilter); } else { $queryBuilder->andWhere($dqlFilter); }`", "reference": "I think here we want the use of `empty()` to take care of empty strings. If you put `dql_filter: ''` in your YAML config... this will add `->andWhere('')` and it will fail, right?" }, { "prediction": "I'm not sure if this is the right fix.", "reference": "this is golang's named return, err is defined, `return` is equivalent to `return err` the current code has no problem" }, { "prediction": "I don't think we need to change this.", "reference": "I don't think this is right; in Rust terms it's like a `&mut String`, in Java `StringBuilder` - it's not a return value from the function which is what `(out)` is for." }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it. I'm not sure if this is the right way to do it, but if it's the right way to do it, I'm not sure if it's the right way to do it, and if it's the right way to do it, it's the right way to do it, but I'm not sure if it's the right way to do it.", "reference": "If the label is not binary, should we rename this function?" }, { "prediction": "I think this should be `r\"${__BeanShell(File.separator,)}\")`", "reference": "This is very-very bad idea because of its performance impact" }, { "prediction": "I'm not sure if this is needed.", "reference": "WHY U NOT SORT IMPORTS?" }, { "prediction": "I don't think we need to do this in the `sign_in_as` method, since we're already doing this in the `sign_in_as` method.", "reference": "Put a comma after the last item of a multiline hash." }, { "prediction": "I don't think this is needed anymore.", "reference": "How come we need ``Dimensioned`` in the top-level namespace?" }, { "prediction": "I'm not sure if this is the right place to remove it.", "reference": "excess whitespace through plugin." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea.", "reference": "What is the problem here? I feel we used this in a lot of places." }, { "prediction": "I don't think we need this restriction anymore.", "reference": "Update the docstring." }, { "prediction": "I'm not sure why this is needed.", "reference": "delete the empty line \"github.com/pkg/errors\" should be grouped with other third party packages same for the rest" }, { "prediction": "I don't think this is needed anymore.", "reference": "Assigning capabilities to the field here is not the best idea. Semantically this field contains the capabilities returned by the browser after session start. So here we sould better amend capabilities and return them from `init` method to pass later to `startSession` method (that will assign the capabilities returned by the browser to the field)." }, { "prediction": "I'm not sure if this is the right place for this method. I'm not sure if this is the right place for this method.", "reference": "Is this a breaking change, or is the API private?" }, { "prediction": "I don't think we need to import this file.", "reference": "I don't think we need this dependency in this project right now" }, { "prediction": "I don't think we need this.", "reference": "I don't think this is necessary since `CommonLabels` is a public func and every component name is also public constant." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "The `_example` field should be updated to include an interpreter with an array value." }, { "prediction": "I don't think we need to update this map.", "reference": "Put this in the godoc of SupportedProtocols instead. Preferably we would just use one map though. Why not just use this one?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to rename the `dockerGraphPath` to `dockerGraphPath` or `dockerGraphPath` to make it clear that it's a good idea to rename the `dockerGraphPath` to `dockerGraphPath` or `dockerGraphPath` to make it clear that it's a good idea to rename the `dockerGraphPath` to `dockerGraphPath` or `dockerGraphPath` to make it clear that it's a good idea to rename the `dockerGraphPath` to `dockerGraphPath` or `dockerGraphPath` to make it clear that it's a good idea to rename the `dockerGraphPath` to `dockerGraphPath` to `dockerGraphPath` or `dockerGraphPath` to make it clear that it's a good idea to rename the `dockerGraphPath` to `dockerGraphPath` or `dockerGraphPath` to `dockerGraphPath`.", "reference": "I'd feel a little safer if the first argument were a string, not a *string unless there's a particular reason for making it a pointer." }, { "prediction": "I don't think this is needed.", "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC." }, { "prediction": "I don't think this is needed.", "reference": "You can safely revert changes to this file." }, { "prediction": "I think we should remove the `cls_score.permute(0, 2, 3, 1).reshape(-1)` from the `cls_score.permute(0, 2, 3, 1).reshape(-1)`", "reference": "This deletion is unnecessary." }, { "prediction": "`typeof smallImage ==='string'? : smallImage`", "reference": "I'm not a huge fan of this overloading of the prop; accepting very different types of arguments for props like this can be confusing, and wasn't part of the IB. I understand wanting to import the SVG directly, but the IB suggests using `${global._googlesitekitLegacyData.admin.assetsRoot}${userInputSuccessImage}` as the `src`/`smallImage` value here. It'd be great to refactor this to accept components directly in the future, but let's do that all-at-once rather than this hybrid approach that makes the API less clear." }, { "prediction": "I don't think this is needed.", "reference": "I've had this happen recently with IntelliJ, was this intentional?" }, { "prediction": "I'm not sure if this is needed.", "reference": "Order(1) vs Order(logN) -- not sure it's measurable at the ~200 element size of the table. All of the published comparisons start at ~1000 elements." }, { "prediction": "I don't think this is needed anymore.", "reference": "I don't know about this aliasing and 'factory'. Previous version was rather straightforward: `location.CreateLocationResolver`. Perhaps `location.CreateResolver` would be even better? What do we actually gain here from moving DI to a separate sub-package?" }, { "prediction": "I don't think this is needed.", "reference": "Use `UpperCamelCase` for function names" }, { "prediction": "I don't think this is needed.", "reference": "I'm not 100% sold on this idea but I like it in general. Nice compromise between using the 'Date' constructor where possible and falling back to the pre #5880 behavior when it makes sense. However, instead of `Number(value) < 0`, let's do `Number(value) < MIN_YEAR` because `new Date('-2017')` is perfectly valid in JS and I don't want to break the date behavior." }, { "prediction": "I think this is a breaking change. It's a breaking change, but it's a breaking change.", "reference": "Remember to close SOLR-11877 after this" }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "this change should be reverted" }, { "prediction": "I'm not sure if we need to mock the `IsRegistered` method. I think we should mock the `IsRegistered` method.", "reference": "This function signature is a bit complicated, some parameters are IN type (stopLoop which is modified from outside), others are OUT (registeredEvent channel which is modified inside function) I suggest the following signature -> SubscribeToRegistrationEvent(identityAddress) returns registeredEvent chan of type (RegisteredEvent not int), Unsubscribe func(), error (in case of any error). That way caller can always cance subscription if needed and check for any errors. Also - unsubscribe function hides any internal details how subscribtion is really implemented" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "`.wav`?! cannot we use something slightly more modern and compressed instead? :) I dunno, like `.mp3` or `.aac` or `.ogg`..." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `luaA_client_swap(L, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_class, &client_client_class, &client_class, &client_client_class, &client_", "reference": "Wouldn't a single signal call be enough? (without the boolean even)" }, { "prediction": "I don't think we need to check for `current_user!= @note.author`", "reference": "I suspect that this whole block, which is going to be repeated a number of times, should probably be in a helper. I guess it would need to be given the object and the title and could probably figure out everything else from that?" }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "Should we expose this attribute in the Asciidoctor.js API?" }, { "prediction": "I think this should be `equals(element._2)`.", "reference": "I think contains on `Multimap` was broken - it should return true if one of the values is associated with the key? It that right" }, { "prediction": "I think this should be `DEFAULT_CONCURRENCY` and not `DEFAULT_CONCURRENCY`", "reference": "delete this line" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do it.", "reference": "Presumably we no longer need `force: true` here." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "HIP runtime is compiled using a C++ compiler. So comparison to both NULL as well as 0 does not make sense. Just comparing to NULL is sufficient." }, { "prediction": "I'm not sure if this is the right place to put this in the `mailer/welcome_notification.html.erb` file. I'm not sure if this is the right place to put it in the `mailer/welcome_notification.html.erb` file, but if it's the right place to put it in the `mailer/welcome_notification.html.erb` file, I'm not sure if it's the right place to put it in the `mailer/welcome_notification.html.erb` file. If it's the right place to put it in the `mailer/welcome_notification.html.erb` file, I'm not sure if it's the right place to put it in the `mailer/welcome_notification.html.erb` file. If it's the right place to put it in the `mailer/welcome_notification.html.erb` file, I'm not sure if it's the right place to put it in the `mailer/welcome_notification.html.erb` file. If it's the right place to put it in the `mailer/welcome_notification.html.erb", "reference": "these urls are still in `a` tags so we should probably include these links separately for a non-HTML version" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do this, I'm not sure if it's the right place to do it.", "reference": "That's fine though, meaning that you can send to this channel under the server lock. The internalSendLoop will pick up the change when the server lock is released (if loop is blocked trying to grab the server lock). Even the way you do it here (releasing the lock, sending, then reacquiring) does not guarantee that the internalSendLoop will have time to refresh in that interval." }, { "prediction": "I don't know if it''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''", "reference": "The name `enableDownloading` implies this is a boolean capability. How about `downloadDir`?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Found one internal team is using this method. Will coordinate with them about the migration solution." }, { "prediction": "I don't think we should add this to the `TracerSettings.HttpServerErrorCodes` file.", "reference": "The field `HttpServerErrorCodes` should be called `HttpServerErrorStatuses`" }, { "prediction": "I'm not sure about this. I'm not sure if it's a good idea.", "reference": "Can you please make each of these in a separate line. It will be easier to keep them sorted, and add/remove." }, { "prediction": "I don't think this is the right place to do this.", "reference": "should we error instead of silently ignoring the `cleanup` param? it defaults to `false`, so someone must have explicitly set it to `true`" }, { "prediction": "I'm not sure if this is the correct error message.", "reference": "There is no specific requirement that the root be called `root`, just that there is a single root directory and that it be the first entry in the zip." }, { "prediction": "I don't think we need to check for `me_path` here. I think we should check for `current_page?` and if `me_path` is empty, we should check for `me_path`", "reference": "perhaps we should encapsulate this logic in a helper method w a test?" }, { "prediction": "I don't think this is needed.", "reference": "Now that we're only using this repo as a Gem you shouldn't need to `require` an expanded local file path like below." }, { "prediction": "I think this should be `Integer.valueOf(granularity.between(EPOCH, timestamp)).intValue()`", "reference": "This isn't necessarily a year. It may be months, days, or hours. Can we return `intValue()` directly instead?" }, { "prediction": "I'm not sure why this was removed.", "reference": "this is redundant because it gets logged immediately on entering the handleContainerChange function" }, { "prediction": "I don't think we need to change this.", "reference": "`ds.GenericDeploymentConfig.DeploymentNotification` in L128 is nullable." }, { "prediction": "I don't think this is needed.", "reference": "this shouldn't be exposed here - this class isn't a carriage for this - its used internally to determine if/how we can mine." }, { "prediction": "I think we should remove the `Path` parameter.", "reference": "It's fine to leave these checks in. It'll make the exception come from `FirefoxDriver`, and that's probably clearer to a user." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.", "reference": "We don't want to include the `IntegrationSpecHelper` for models...mind moving this line out of the loop to be `config.include EnvironmentSpecHelper, type: :model`?" }, { "prediction": "I don't think we need to change this.", "reference": "Please check the return on these." }, { "prediction": "I don't think this is needed.", "reference": "Do we need `==` for true?" }, { "prediction": "I don't think we need this?", "reference": "Changing the default value may cause BC-breaking. Suggest changing this value in config." }, { "prediction": "I don't think this is the right place to change the value of `slider_pos` to `int(slider_pos)`", "reference": "how does that happen?" }, { "prediction": "I'm not sure about this, but I think it's better to move this to `rdkit.six.moves.py`.", "reference": "This is gross/clever. :-)" }, { "prediction": "I'm not sure if this is the right place for this test.", "reference": "Take a look at the name of this file. Definitely copy and" }, { "prediction": "I think this should be `resp.StatusCode == 503`", "reference": "Can you check with @mahebbar how to work this error. Should be different from 404." }, { "prediction": "I'm not sure about this, but I'm not sure if this is needed.", "reference": "Do we still need the upper bound `<3.9`?" }, { "prediction": "I think this should be `dirname(__DIR__). DIRECTORY_SEPARATOR. 'psalm' || realpath($input_path) === realpath(dirname(__DIR__, 3). DIRECTORY_SEPARATOR. 'bin'. DIRECTORY_SEPARATOR. 'psalm') || realpath($input_path) === realpath(dirname(__DIR__, 3). DIRECTORY_SEPARATOR. 'psalm') || realpath($input_path) === realpath(dirname(__DIR__, 3). DIRECTORY_SEPARATOR. 'bin'. DIRECTORY_SEPARATOR. 'psalm') || realpath($input_path) === realpath(dirname(__DIR__, 3). DIRECTORY_SEPARATOR. 'bin'. DIRECTORY_SEPARATOR. 'psalm') || realpath($input_path) === realpath(dirname(__DIR__, 3). DIRECTORY_SEPARATOR. 'bin'. DIRECTORY_SEPARATOR. 'psalm') || realpath($input_path) === realpath(dirname(__DIR__). DIRECTORY_SEPARATOR. 'psalm') || realpath(dirname(__DIR__). DIRECTORY_SEPARATOR. 'psalter') || realpath($input_path) === realpath(Phar::running(false)) || realpath($input_path) === realpath", "reference": "Does this mean `vendor/bin/psalm` is not a symlink (or whatever equivalent Windows has for symlinks) on Windows?" }, { "prediction": "I'm not sure if this is the right place to put this.", "reference": "@lpabon having a separate package name `aws_test` allows to test the package as if the tester was an external package. If the test package name is the same as the package being tested, the test package can also use methods and variables not exposed to the eventual user." }, { "prediction": "I'm not sure why this was removed.", "reference": "The exporter should still be able to test these histogram instrument kinds, right? Is there another reason to remove these?" }, { "prediction": "I think this should be called `ResetTxnBytes` instead of `ResetTxnBytes`.", "reference": "should this increment eval.Round somehow?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is the right thing to do, but I'm not sure if this is the right thing to do.", "reference": "Although this change looks good. Maybe there are other inconsistent cases too?" }, { "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "This is a way better method name." }, { "prediction": "Layout/TrailingBlankLines: Trailing whitespace detected.", "reference": "Prefer single-quoted strings when you don't need string interpolation or special symbols." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I was wondering if this should allow per role specification, instead of (or in addition to) a generic \"allowed everywhere\". So you could do: `{ separator: ['aria-valuenow', 'aria-valuemin', 'aria-valuemax'] }`. You could still allow the array, and you could add a wildcard option for the \"generic\" case you've got now: `{ '*': ['always-allowed'] }`." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I'm confused by the name. The string was a Hive string but it isn't any longer? Why should we care? (I imagine I'll find the answer later... there is some different semantic that we want downstream...)" }, { "prediction": "Please revert this change.", "reference": "Could you please leave the explicit imports?" }, { "prediction": "I don't think this is needed.", "reference": "Why need alias?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `tlfIDGetter()` or `tlfIDGetter()` here.", "reference": "Shouldn't this be a `libfs.nullIDGetter` (exported, of course)?" }, { "prediction": "I don't think we should change this to \"logicsig program size too large\" or \"logicsig program size too large\"", "reference": "I dislike the messages.go pattern; the strings are only used once and make more sense in context. The other two added reportErrorf() calls in clerk.go have inline strings." }, { "prediction": "I'm not sure why this was removed.", "reference": "Seems we don't need it anymore." }, { "prediction": "Line is too long. [89/80]", "reference": "This might cause problems with the weird way we publish Guidance and Groups in the UI. We will have to make sure that UAT is thorough." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `time.Hour` or `time.Minute` or `time.Second` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `time.Millisecond` or `", "reference": "this default needs to be on order 1 minute, I'm not sure why we defaulted to 1 hour below..." }, { "prediction": "I don't think this is the right place to do this.", "reference": "I figure to make `{env.*}` work, right? I can't think of any other placeholder that makes sense here" }, { "prediction": "I don't think we need to mock the network. I don't think we need to mock the network.", "reference": "Why change the port from 0 to getAvailablePort()?" }, { "prediction": "I'm not sure why this change is needed.", "reference": "For me would be great don't repeat timeout sending in every get_locator call. Looks like it should be sent into LocatorsManager init. And possibly it should me non mandatory, something like that: `def __init__ (self, locators, timeout=60):`" }, { "prediction": "I don't think we need this line.", "reference": "I feel like since now we don't initiate the `opts.projectName` with `opts.ProjectName()`, which means `opts.projectName` and `opts.ProjectName()` they don't necessarily equal to each other, we need to also substitute all usage of `opts.ProjectName()` within `Ask()`, `Validate()`, and `Execute()` to `opts.projectName`. Otherwise if `-p` is set, `opts.ProjectName()` will get expired." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "why do we thinkg that an empty string is ok to return from this method? I think the null should never be passed in here in the first place" }, { "prediction": "I don't think we need to check for `found` here.", "reference": "nit: can remove this `else` since we return from the condition above." }, { "prediction": "I don't think this is needed anymore.", "reference": "You missed `Write(...)`! I'm kidding ofc." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Was there a customer who had this set to an empty string?" }, { "prediction": "I'm not sure if this is the right place to put this method. I'm not sure if it's the right place to put it.", "reference": "I know we have the `reporter` spec below, but what about a unit test for this to explain reasoning behind logic? If I were going to update this decorator, I would assume it wasn't covered by tests because there is no unit test." }, { "prediction": "I don't think we need to add this method to the RestClientRequest interface.", "reference": "it's better to be : void attach(String name, Part part);" }, { "prediction": "I'm not sure if this is a breaking change, but I'm not sure if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, it's a breaking change, or if it's a breaking change, or if it's a", "reference": "I didn't see where the IOException can get thrown, is this just to match the V1 reader?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "We normally suppress this warning with `RDUSED_PARAM(forceRDKit)`" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "What if `Game::getPlayerByNameWildcard` had not been called before. It would not find a player, wouldn't it?" }, { "prediction": "I don't think this is needed.", "reference": "Why upper case \"R\"?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do it.", "reference": "Does this need to return an error or could it return `false, nil`?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Can you not change those scopes in public API classes? This applies here and in other places -- protected changed to package-scope for source is not really an API-compatible change." }, { "prediction": "I think this should be `$this->getRequest()->get('view_missing_traductions_only', 1),'max_input_vars_warning' => false`", "reference": "this parameter is only used in POST, please use `getRequest()->request->get('...');` Thanks" }, { "prediction": "I'm not sure if this is the right place to remove the `filename` param.", "reference": "Problem number 1: Scoped packages would have a `/` character here. Changing this to `validatePackage` resolves the 403." }, { "prediction": "I don't think this is necessary.", "reference": "I don't quite get why there would be key errors: ``deep_mapped`` is a clone of ``self`` and ``k`` comes from ``self.items()`` so why would the key ever be rejected?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "this chain ID determines only from which chain to withdraw, therefore your changes do not accomplish what you want them to accomplish. You'll need changes to `func (aps *hermesPromiseSettler) Withdraw(chainID int64, providerID identity.Identity, hermesID, beneficiary common.Address) error`. The method probably has to include two chain ids: to and from. Currently, the method internally uses: `aps.config.L1ChainID` -> the chain to withdraw to `chainID` -> the chainID that was passed as the chain that the withdrawal is originating from." }, { "prediction": "I think this should be `ContextWithRemoteSpanContext(ctx, tc.extract(supplier))`", "reference": "If instead we had `TraceContext.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative?" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to have a `paginated` variable.", "reference": "here shouldn't we use `depotFreeLimit`?" }, { "prediction": "I don't think we need this, but I don't think we need it.", "reference": "Could we use the Rails application's secret token instead? Do we actually need our own here?" }, { "prediction": "I don't think we need to change this test.", "reference": "so should be fixed here also" }, { "prediction": "I don't think this is correct.", "reference": "I would just remove this assert as it's going to get un-maintainable with a long list of valid sizes. Ditto below." }, { "prediction": "I think this should be `/var/lib/ecs` instead of `/var/lib/ecs`", "reference": "`HostDataDir` is misleading. Can we rename it to something more relevant? The constant should also be moved up and reused as necessary." }, { "prediction": "I don't think we need to do this.", "reference": "I still feel like we are double-counting the outer IP header here (once in `defaultMTUGRE` and once in `ipsecESPOverhead`) but I'm not that familiar with IPsec." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if it's the best way to do this, but I'm not sure if it's the best way to do it. I'm not sure if it's the best way to do it, but if it's the best way to do it, I'm not sure if it's the best way to do it. If it's the best way to do it, I'm not sure if it's the best way to do it, but if it's the best way to do it, I'm not sure if it's the best way to do it.", "reference": "Not sure what benefit we gain by extending BaseProcessor here, as this seems to be defining a new OnEnd method. Could we modify MeasurementItem to have all the things, and then MeasurementProcessor can be simply extending BaseProcessor (not blocking. just noting some observations in the PR :) )" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards." }, { "prediction": "I don't think this is the right thing to do.", "reference": "This seems like a more appropriate message under `ListenAndServe`. WDYT?" }, { "prediction": "I'm not sure why this was removed.", "reference": "Is this not required?" }, { "prediction": "I think this should be `isset($this->entity['search']['sort']['field'])? $this->entity['search']['sort']['field'] : $this->request->query->get('sortField'), $this->entity['search']['sort']['direction'] : $this->request->query->get('sortDirection'), $this->entity['search']['dql_filter']`", "reference": "We should start thinking of an object that encapsulates this information :) we might need more arguments in the future." }, { "prediction": "I'm not sure if this is the correct behavior. I'm not sure if this is the correct behavior.", "reference": "Given that we are (conceptually) searching across multiple self-dependencies, all we can say is that we didn't have a self dependency in which *both* source and dest masks were correct. Since the spec doesn't imagine this case, the valid usage statement assume we can differentiate only wrong source from only wrong dest within a *single* self-dependency -- which we can't across multiple (at least not meaningfully)... so we always return both the source/dest VUID's if we can't find a self-dependency in with *both* are correct." }, { "prediction": "I'm not sure about this test. I'm not sure if it's worth it.", "reference": "rename? MiningCoordinator always exists" }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "Here would be the same case you don't need to call `loadConfigs`, but you would need to reread configs using `getConfig` on each getHost function call, not once per file." }, { "prediction": "I think this should be `defer defer d.folder.fs.renameAndDeletionLock.Unlock()`", "reference": "Unlocking with defer means that this lock is still held curing the call to forgetNode(), below, which I see attempts to acquire `f.mu`, which looks dangerous to me." }, { "prediction": "I'm not sure if this is the right place for this test.", "reference": "Does anyone still use the cst out of this method? If not consider deleting" }, { "prediction": "I don't think we need this anymore.", "reference": "Line is too long. [97/80]" }, { "prediction": "I don't think this is needed anymore.", "reference": "This seems unused." }, { "prediction": "IsKubeEdgeController already running?", "reference": "@luguanglong, Thanks for the fix, can you re-phrase it to sound better something like \"This OS version is currently un-supported by keadm\"" }, { "prediction": "I don't think this is needed.", "reference": "should probably be called `_DeleteFpInfoAttr` because it removes it. Cleaning gives the impression it is still there. I would also move this to the end of the function `GetAtomicWeightsForFingerprint`." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "nit, can we use `VK_PIPELINE_BIND_POINT_RAY_TRACING_KHR` here (granted it isn't else where, maybe worth fixing here or in separate PR)" }, { "prediction": "I'm not sure if this is the right place to put this method.", "reference": "This will need to be updated in the upcase-exercises repo as well." }, { "prediction": "Metrics/LineLength: Line is too long. [89/80]", "reference": "Think it's worth extracting this to `Exercise#complete?`?" }, { "prediction": "I think we should remove the `getReversedExchangeRate` method.", "reference": "This is still a potentially useful public method - should we remove such methods?" }, { "prediction": "I'm not sure about this change, but I think it would be better to remove the `releaseLevel()` method from the `ApiDefaultsConfig` class.", "reference": "I don't understand this change, what is happening here?" }, { "prediction": "I don't think this is necessary.", "reference": "I think its worth stating this is `versionMajor`" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but I'm not sure if it's the right place to do it.", "reference": "rebuild: say loads and merges" }, { "prediction": "I'm not sure if this is the right place to remove it.", "reference": "Why was this removed here (also in the other file)? Shouldn't we import them so that the reference in the docs below is interpreted correctly?" }, { "prediction": "I don't think this is needed anymore.", "reference": "I'd prefer to have a blank line between the class declaration and its first member. Is it possible?" }, { "prediction": "I don't think we need to change this test to use `MONGOS_LEGACY_HELLO` instead of `MONGOS_LEGACY_HELLO`", "reference": "Is it really LEGACY_HELLO if we are using the most up to date HELLO? Perhaps `MONGOS_HELLO` would work here?" }, { "prediction": "I'm not sure if this is the correct behavior.", "reference": "I am afraid this is going to cause problems on Windows where it is not uncommon to have injected threads (CTRL_SHUTDOWN, CTRL_LOGOFF, etc.) we have no privileges to suspend -- and thus retrying will just fail again, and with the new \"synchall failure is fatal and should kill the process\" approach it turns what used to work for us on Windows into process death." }, { "prediction": "I think this should be `--mac_installer_signing_identifier` or `--mac_installer_signing_identifier`", "reference": "think it should only be in create_dist" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Do you plan to support Pod spec change? Like hostPort is added/removed later after Pod creation?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Is this behavior correct? It used to return `true`, which should map to `dokan.ExistingDir`. Was that previously a bug?" }, { "prediction": "I don't think we need to check if the region exists or not.", "reference": "What about just printing an empty list in this case? That would make the output more predictable." }, { "prediction": "I don't think we need this anymore.", "reference": "I looked and couldn't find any usage of `container` in any of the editor component files (js or hbs), so I assume this was used once and didn't get removed?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I just updated a number of sites using older versions of Roots onto WP 3.6 and this little function change was required. Multiple search bars were displaying when I used the search widget in a widgetized sidebar. Updated the roots_get_search_form as seen in this change resolved it for me!" }, { "prediction": "I don't think this is needed anymore.", "reference": "Fixes test failed in some cases" }, { "prediction": "I don't think we need to remove this once ads catalog moves to using prod.", "reference": "what's the prod url for this? just curious. @amirsaber" }, { "prediction": "I think this should be `azkaban.jvm.cmd.args` or `azkaban.jvm.args.args.args.args.args.args.args.args.args.args.args.args.args.args.args.args.args.args.args.args.args.args.args.args.args.args.args.args.args.args.args.args.args.args.args.args`", "reference": "Can you please change this to azkaban.jobs.java.opts?" }, { "prediction": "I'm not sure if we should remove this line.", "reference": "Here is another concatenation which should be updated. Even though `Source:` and the link are essentially separate, it isn't RTL friendly. This would be another good use for `createInterpolateElement` I think so that we wouldn't need to include all of the classnames in the translation string (or extract them to a placeholder). That would allow us to use the `Link` component as well, rather than using its resulting HTML as a string which will be a pain to maintain if we were to make changes to the base `Link` component." }, { "prediction": "I don't think this is needed.", "reference": "I would add an overload `GetCancelledZeroTask()` which calls `GetCancelledZeroTask(CancellationToken.None)`. This is cleaner than requiring the caller to pass `default(CancellationToken)` or `CancellationToken.None`." }, { "prediction": "I think this should be `if (VK_NULL_HANDLE!= swapchain)`", "reference": "Would it be equivalent to check if `chain!= nullptr` below? Not suggesting a change, just curious." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Should probably do `auto this_l (shared_from_this ());` and pass/use that instead of `this`. Same a few other places. IOW, replace both `shared_from_this()` and `this` with `this_l`" }, { "prediction": "I'm not sure if this is the correct message.", "reference": "And here. Please, use `'` for apostrophes in changed strings in this file." }, { "prediction": "I'm not sure this is the right place to call SimulateExecution. I'm not sure if it's the right place to call SimulateExecution. I'm not sure if it's the right place to call SimulateExecution, but if it's the right place to call SimulateExecution, I'm not sure if it's the right place to call SimulateExecution. If it's the right place to call SimulateExecution, I'm not sure if it's the right place to call SimulateExecution, but if it's the right place to call SimulateExecution, I'm not sure if it's the right place to call SimulateExecution.", "reference": "assignments should only be cuddled with other assignments (from `wsl`)" }, { "prediction": "I don't think this is needed.", "reference": "Please move this to `block_types.go`." }, { "prediction": "I'm not sure why this was removed.", "reference": "So this is not needed anymore for all attributes?" }, { "prediction": "I don't think we need this event anymore.", "reference": "Happy to get suggestion for better messaging here. Here's what I intended to convey: Something is wrong - the Exception is a hint to what might be the cause The impact of that - tracing wont work." }, { "prediction": "I think we should move this to es_starter.py?", "reference": "I think we can remove this function, right? (duplicate with `ses_starter.py`)" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "With this fix, I am not even sure we need to overwrite this function." }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `QUILT_USE_TQDM` or `QUILT_USE_TQDM` in the future. I'm not sure if it's a good idea to use `QUILT_USE_TQDM` or `QUILT_USE_TQDM` in the future.", "reference": "Why not just import this from `data_transfer`? As a rule copying the same code twice is not a good idea. Also: please run `pylint` on all files in this PR." }, { "prediction": "I'm not sure if we should remove this line.", "reference": "You've got an absolute path here referencing your home dir :-)." }, { "prediction": "I don't think this is needed anymore.", "reference": "Maybe I should do some sorting so that these properties don't keep moving around..." }, { "prediction": "I'm not sure why this was removed.", "reference": "Can we keep this test anyway, as it's part of the spec?" }, { "prediction": "I don't think this is needed.", "reference": "Can be removed" }, { "prediction": "I don't think this is needed.", "reference": "It's a minor quibble I know, but I like having the imports ordered by lengt" }, { "prediction": "I don't think we need to change the charset here.", "reference": "It's better to get the charset from context or other setting to let the user override it." }, { "prediction": "I'm not sure if this is the right place for this test, but I think it's better to move this test to the `NewTestCStorPools` method.", "reference": "this filename as well needs change" }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "I think we want to remove `omitempty` here" }, { "prediction": "I'm not sure if this is the right place to call `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler`` or `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler` or `NewSignalHandler`", "reference": "You cannot move this here because it breaks detach. Just call `tty.Close()` before returning the error from start" }, { "prediction": "I'm not sure if this is the right place to remove it.", "reference": "I updated only the implicit roles who needed a update for this new rule to validate." }, { "prediction": "I'm not sure if this is needed.", "reference": "> // Code generated by protoc-gen-go. DO NOT EDIT." }, { "prediction": "I think this should be `osconfig_not_supported: true` instead of `osconfig_not_supported: true`", "reference": "minor: skipOSConfigMetadata, otherwise, the name sounds like a boolean" }, { "prediction": "I don't think we need to check for null here.", "reference": "~~I think lines 65-67 should be moved into this else clause after `type =...` Else, it is a bit confusing why we check the enclose type validity a second time~~ Nevermind, will do some refactoring, myself. But thanks for \"fixing\" this!" }, { "prediction": "I'm not sure if this is the right place to call `GetSessions` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync` or `GetSessionsAsync`", "reference": "`sessions := endpoints.SessionsDTO{}` and using only `sessions` should be simpler." }, { "prediction": "I'm not sure if this is the right thing to do here, but I'm not sure if it's the right thing to do here.", "reference": "These need to be in the other order to avoid crashing when dcontext == GLOBAL_DCONTEXT (==-1)" }, { "prediction": "I don't think we need to change this.", "reference": "Why not change the other samples?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Indentation is mixed up here due to spaces/tabs, I'm guessing." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Should we provide a little more context in the error message? Maybe throw in something about what operation was being performed?" }, { "prediction": "I don't think we need to check for `$this->getConfigurationFromYaml()` here.", "reference": "Project standard is spaces, not tabs. Please fix and then we can merge this." }, { "prediction": "I don't think this is needed.", "reference": "@hgtw is there anything we're worried about with regards to using this cache? Do we want to do staged testing around expeditions before we merge? Curious your thoughts here" }, { "prediction": "I'm not sure about this change, but I think it's a good idea to remove the `alwaysTrue()` method from the `Iterator` class.", "reference": "The purpose of this was to allow pushing filters into the manifest files if we ever use a format other than Parquet. I think overall this is a good change because we can add it back later. Just wanted to note why the unused argument was there." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "I think BSON::Decimal128 should always be serialized as Decimal128 regardless of config option." }, { "prediction": "I'm not sure about this, but I'm not sure if it's a good idea to have a `plan_creator` in `bolt/plan_creator.rb` or `bolt/plan_creator.rb` in `bolt/plan_creator.rb` or `bolt/plan_creator.rb` or `bolt/plan_creator.rb` or `bolt/plan_creator.rb` or `bolt/plan_creator.rb` or `bolt/plan_creator.rb` or `bolt/plan_creator.rb` or `bolt/plan_creator.rb` or `bolt/plan_creator.rb` or `bolt/plan_creator.rb` or `bolt/plan_creator.rb` or `bolt/plan_creator.rb` or `bolt/plan_creator.rb` or `bolt/plan_creator.rb` or `bolt/plan_creator.rb` or `bolt/plan_creator.rb` or `bolt/plan_creator.rb` or `bolt/plan_creator.rb` or `bolt/plan", "reference": "We should probably just move the `require 'bolt/plan_creator'` in `Bolt::CLI` to `Bolt::Application` so it will already be loaded." }, { "prediction": "I think this should be `.WithWarmupCount(1) // 1 warmup is enough for our purpose.WithMaxTargetIterationCount(20) // 20 iterations is enough for our purpose.WithMaxTargetIterationCount(20); // 20 iterations is enough for our purpose.WithWarmupCount(1) // 1 warmup is enough for our purpose.WithMaxTargetIterationCount(20); // 20 iterations is enough for our purpose.WithMaxTargetIterationCount(20); // 20 iterations is enough for our purpose.WithWarmupCount(1) // 1 warmup is enough for our purpose.WithMaxTargetIterationCount(20); // 20 iterations is enough for our purpose.WithWarmupCount(1) // 1 warmup is enough for our purpose.WithMaxTargetIterationCount(20); // 20 iterations is enough for our purpose.WithMaxTargetIterationCount(20); // 20 iterations is enough for our purpose.WithMaxTargetIterationCount(20); // 20 iterations is enough for our purpose.WithMaxTargetIterationCount(20); // 20 iterations", "reference": ">20 [](start = 45, length = 2) Can we override this at runtime? Maybe it should be a command line option with default." }, { "prediction": "I don't think we need this property anymore.", "reference": "can just remove it?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Better call it `CleanUpMirrorInfo`?" }, { "prediction": "I'm not sure if this is the right place to start the retrieval provider. I'm not sure if this is the right place to start the retrieval provider.", "reference": "@shannonwells is there still something missing here?" }, { "prediction": "I don't think we need this setting.", "reference": "This could be more indicative of what it is... e.g... `stresstest_time_limit`" }, { "prediction": "Is this still needed?", "reference": "Shouldn't we do a `reader_payload_pool_.reset()` here?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea, but I'm not sure if it's a good idea.", "reference": "I'd prefer the nomenclature less tightly coupled to DRAND throughout. I played with renaming the `drand` package to `beacon` but it was too much noise in this change." }, { "prediction": "I think this should be `_current_key` instead of `_current_value`.", "reference": "I think I would prefer you declare `self._current_key=None` in the constructor and just return `self._current_key`. That way you can prevent anyone from overwriting `current_key` without needing to use `getattr` here." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it.", "reference": "I guess I like the name `mode` okay. I can't think of anything better." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "I would create a new method (NewStepWithDefaultTimeout?) for this purpose because timeout<=0 looks like a hidden logic" }, { "prediction": "I don't think this is needed anymore.", "reference": "Are these limit changes related?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Don't you mean `import scapy.consts`?" }, { "prediction": "I think this should be `rollbackPrimary`", "reference": "`ctx` is unused in rollbackPrimary" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "This is not what title says." }, { "prediction": "I think this interface should be `RuleViolationFix`", "reference": "a fix applies several fixes? maybe this should simply be `applyToNode`" }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if it's the right way to do this.", "reference": "U1000: func `fakeGetOk` is unused (from `unused`)" }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "Because there is a \"k8s.io/client-go/tools/cache\" below, we can sort out all the \"imports\" here." }, { "prediction": "I'm not sure if this is needed.", "reference": "Nit should be using `goimports` to format the import statements with standard libary imports first, new line, followed by non-standard library imports." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or not.", "reference": "Do we not have tests for pipeline delete" }, { "prediction": "I think this should be `--appendToFile` instead of `--appendToFile`.", "reference": "Good that you mention this constraint in the docstring :)" }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "remove this blank?" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to do this in a follow up PR.", "reference": "Partitions is misspelled 8 times in this commit, might make sense to fix the spelling for all of those." }, { "prediction": "I don't think we need to import qutescheme from qutebrowser.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils.utils", "reference": "Please remove this blank line - those are only used to group Python/third-party/qutebrowser imports." }, { "prediction": "I think this should be `var insecure bool = false`", "reference": "`insecure` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I think this should be `\"Interacting with repositories by HTTP protocol is not allowed\"` or `\"Interacting with repositories by HTTP protocol is not allowed\"`", "reference": "Same as above (HTTP in upper-case)" }, { "prediction": "I think this test should be `assertEquals('http://www.youtube.com/watch?v=123456', $this->getProvider()->getReferenceUrl($media));`", "reference": "This is getting repetitive maybe you could introduce an abstract test case with a `getExpectedUrl($providerReference)` method?" }, { "prediction": "I'm not sure if this is the right place for this function.", "reference": "I do not think returning `Value{}` is correct here. For example, `reflect.MakeFunc(...).Kind()` would return `reflect.Invalid` instead of `reflect.Func`. Therefore, I think this should panic instead." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Does this work for Custom Elements? iirc we're lacking test cases for them. /cc @andrewiggins @developit" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "Same change just above?" }, { "prediction": "I'm not sure about this, but I'm not sure if it's worth it.", "reference": "I suppose `apploader.js` isn't used by WebWorkers. So `self` will always be `window` here." }, { "prediction": "I'm not sure why this was removed.", "reference": "Since this var is no longer defined we should remove the `if skip_targets.any?` bit below." }, { "prediction": "I'm not sure if this is the right place to put this function. I think it's better to put this function in a `lambda_function_arn` function.", "reference": "I think we should `return arn` as a fallback at the end of this function (otherwise the `['Resource']` entry below could become `None`)." }, { "prediction": "I don't think we need to close the pinger session.", "reference": "Why session is started at all, if you need to shut it down e.g. DI should launch noopSession" }, { "prediction": "I'm not sure if this is the right place to delete workspace files. I'm not sure if it's the right place to delete workspace files, but if it's the right place to delete workspace files, I'm not sure if it's the right place to delete workspace files.", "reference": "nit: can we rename the interface to `wsFileDeleter`" }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "Why target cannot be external endpoints?" }, { "prediction": "I'm not sure if this is a good idea. I think it's a good idea to have a `Prefix for automatically created config elements.` or `Prefix for automatically created config elements.` or `Prefix for automatically created config elements.` or `Prefix for automatically created config elements.` or `Prefix for automatically created config elements.` or `Prefix for automatically created config elements.` or `Prefix for automatically created config elements.` or `Prefix for automatically created config elements.`", "reference": "We use a suffix \".AUTOCREATED\" for configsets, maybe we can use the same here?" }, { "prediction": "I don't think this is needed.", "reference": "This one won't be disposed. Should be (something like) `using var openTelemetry = OpenTelemetrySdk.EnableOpenTelemetry(` no?" }, { "prediction": "I'm not sure about this, but I'm not sure if it's a good idea to remove it.", "reference": "Why this is in the diff?" }, { "prediction": "I think this should be `CloudBackupGroupCreate` instead of `CloudBackupGroupCreate`.", "reference": "How is status determined? When the user calls CloudBackupCreate( src_volume_id ) they can then call CloudBackupStatus( src_volume_id ) Is there something similar for this new API?" }, { "prediction": "I don't think we need to do this.", "reference": "We could pass `excessDomChildren` to `options._catchError` and only do this if an error-boundary catches the error. Not entirely sure if that's better." }, { "prediction": "I think this should be `array_values($this->getFilters());`", "reference": "In php8 named parameters were introduced and now it is required to match called method parameter name when setting parameters by array destructing or call_user_func_array() etc." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "If instead we had `B3.extractSingleHeader` and `B3.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative?" }, { "prediction": "I think this should be `'Erstellen und weiter hinzuf\u00fcgen', 'create_and_continue' => 'Erstellen und weiter bearbeiten','save' => 'Speichern und weiter bearbeiten','save_and_continue' => 'Speichern und weiter bearbeiten','save_and_continue' => 'Speichern und weiter bearbeiten','save_and_continue' => 'Speichern und weiter bearbeiten','save_and_continue' => 'Speichern und weiter bearbeiten','save_and_continue' => 'Speichern und weiter bearbeiten','save_and_continue' => 'Speichern und weiter bearbeiten','save_and_continue' => 'Speichern und weiter bearbeiten','save_and_continue' => 'Speichern und weiter bearbeiten','save_and_continue' => 'Speichern und weiter bearbeiten','save_and_continue'", "reference": "I think this is more of a semantic difference than a typo - `weiter hinzufgen` is like `continue adding` whereas `weitere hinzufgen` is like `add more`. I think it makes sense to change it though" }, { "prediction": "I think this test should be `test_records_can_be_created_after_deletion` instead of `test_records_can_be_created_after_deletion`", "reference": "nit: 200 is superfluous" }, { "prediction": "I don't think we need to change this test.", "reference": "This is testing `unreserved keyword`" }, { "prediction": "I don't think we need to change the name of the method.", "reference": "paramsNatOrigin doesn't include sUVtoST. I would just remove that definition for now" }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "It feels like the test should be waiting for the prefetcher to shut down, but I don't have a great reason why other than that it might be confusing for debugging if there are still goroutines from old prefetchers lying. But I guess since `TogglePrefetcher(false)` doesn't actually set the prefetcher to nil, the queue shutdown method will still end up waiting for the shutdown to finish. If that sounds right, nevermind me." }, { "prediction": "I don't think we need to change this file.", "reference": "AWS Identity and Access Management (IAM)" }, { "prediction": "I don't think we should change this.", "reference": "As a long term thing, would it make sense to move the resource names as keys under the requirements map?" }, { "prediction": "I don't think we need to check for `headers` here.", "reference": "That doesn't fix the whole problem. The issue lays in this line right here, not the one above. There are two problems with this line: 1. It finds things that aren't cells in the table 2. if it doesn't find anything, it shouldn't return empty here, but continue down to look for row/ column headers." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it.", "reference": "I am pretty sure that this is infinite recursion as getAllProjects returns the project itself." }, { "prediction": "I don't think we need this list anymore.", "reference": "Something I didn't catch before I merged this PR, is the hyphenated constant a problem? E.g. should \"data-lists\" be \"data_lists\"? @paulkaplan" }, { "prediction": "I think this should be `if (not conf.use_winpcapy) and (not conf.use_pcap) and (not conf.use_dnet) and (not conf.use_dnet) and (not conf.use_dnet) and (not conf.use_winpcapy) and (not conf.use_pcap) and (not conf.use_dnet):`", "reference": "Can you write the test as `if not (conf.use_winpcapy or conf.use_pcap or conf.use_dnet):`" }, { "prediction": "I don't think we need to import ForeignAsset here.", "reference": "we have to include foreign assets on the repository directly because they don't belong to a job? This seems very awkward... Is this a step towards the job-less assets on the repository? Did you consider having `build_asset_job` take in a set of foreign assets instead? I suppose we would then need to subclass it to be a more special `AssetJobDefinition` that can keep track of them." }, { "prediction": "I'm not sure why this is needed.", "reference": "`-Wstringop-truncation` is a new kind of error detector introduced in GCC 8. As for this patch, these are two false-positives though." }, { "prediction": "I don't think we need to change this. I'm not sure if we need to change this.", "reference": "Can we port this error msg to v2 too? This one is better, as it explicitly states what sources are allowed." }, { "prediction": "I don't think this is needed.", "reference": "The convention so far has been to require directly from the defining file (in this case `../../read_preference'). I think the concern has been mostly about the potential for circular dependency cycles" }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to use `color_type` instead of `color_type` here.", "reference": "I suggest expanding dims here to simplify the formatting." }, { "prediction": "I don't think we need this file anymore.", "reference": "Why do you need to specify the kinto prefix here?" }, { "prediction": "I don't think this is the right place to use `f'outputs[{i}].shape = {!r}'.format(i, outputs[i].shape!r)`", "reference": "The `!r` is unnecessary." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but I'm not sure if it's the right place to do it.", "reference": "I didn't see existing tests for this `OpenBucketURL`. Not sure if it's easy to do without mocking these `opener` calls." }, { "prediction": "I don't think this is needed anymore.", "reference": "Should we default to `true`?" }, { "prediction": "I don't think this is needed.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I don't think this is needed anymore.", "reference": "Shouldn't these options also include `@babel/preset-env`? Also I see you set `babelrc` to `false`, could we rely on our existing `.babelrc` file? Feels like some duplicate configuration otherwise." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for this, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it.", "reference": "Nit: We can use `%s` since `disconnectReason` is a string." }, { "prediction": "I don't think we need to do this anymore.", "reference": "I think it's better to create a new example" }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "The stages are correct, but the more forgiving `kAttachmentRasterOrder` should be used, based on a review of the spec. That should give the same effect of suppressing the false positive conflict between the DEPTH R/W and resolve. > End-of-subpass multisample resolves are treated as color attachment writes for the purposes of synchronization. This applies to resolve operations for both color and depth/stencil attachments. That is, they are considered to execute in the VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT pipeline stage and their writes are synchronized with VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT. Synchronization between rendering within a subpass and any resolve operations at the end of the subpass occurs automatically, without need for explicit dependencies or pipeline barriers." }, { "prediction": "I don't think we need to change this.", "reference": "To be consistent, I think it should actually just be a single `-`" }, { "prediction": "I don't think this is needed anymore.", "reference": "this seems extraneous." }, { "prediction": "I'm not sure if this is the right thing to do here, but I think it's better to have a `Featureset.LongDomainFeatureSet` and use `Featureset.OnlySAN` in the `ValidateCertificate` method.", "reference": "Ah, I see here that 'LongDomain' is defined as something that contains a subdomain segment that is `maxLengthOfDomainSegment` long (which I think is 63 characters) - I don't think any public ACME servers/Let's Encrypt's staging environment has a restriction on this? if it does, and the 'pebble' based ACME server does not, then Pebble needs modifying to also fail in these cases as it aims to replicate the ACME RFC as closely as possible" }, { "prediction": "I'm not sure if this is the right place to install gdebi. I'm not sure if it's the right place to install gdebi or if it's the right place to install gdebi. I'm not sure if it's the right place to install gdebi or if it's the right place to install gdebi. I'm not sure if it's the right place to install gdebi or if it's the right place to install gdebi. I'm not sure if it's the right place to install gdebi.", "reference": "I think you need `-y` here to prevent a user confirmation prompt" }, { "prediction": "I don't think this is used.", "reference": "Repeating: I don't think this should be a core-wide global var. This should be isolated to arch/x86 or at least arch/, maybe inside getter/setters as mentioned above." }, { "prediction": "I'm not sure if this is the right place to put it.", "reference": "right URL is like in cmdrunner, using search.maven.org" }, { "prediction": "I don't think we need to change this. The endpoint value should start with http or https. The endpoint value should start with http or https. The endpoint value should start with https. The endpoint value should start with http or https. The endpoint value should start with https. The endpoint value should start with http or https. The endpoint value should start with https. The endpoint value should start with http or https. The endpoint value should start with https. The endpoint value should start with http or https. The endpoint value should start with https. The endpoint value should start with http or https. The endpoint value should start with https. The endpoint value should start with http or https. The endpoint value should start with https. The endpoint value should start with http or https. The endpoint value should start with https. The endpoint value should start with http or https. The endpoint value should start with https.", "reference": "The link to valid syntax is not really applicable for NET2_1, right?" }, { "prediction": "I don't think we need this.", "reference": "Shouldn't it be more specific, like \"gcppubsub supports all UTF-8 strings\"?" }, { "prediction": "I don't think this test is needed anymore.", "reference": "Everything in this class is SolrCloud-related, not legacy replication" }, { "prediction": "I don't think this is needed anymore.", "reference": "Could just assign directly and eliminate the `newval` var." }, { "prediction": "I don't think we need to change the title of the pull request. I'm not sure if we need to change the title of the pull request or if we need to change the title of the pull request.", "reference": "... with the name of the affected package, or \"all\", followed by a colon,..." }, { "prediction": "I think we should move this file to `src/Datadog.Trace.ClrProfiler.Managed.Core/Datadog.Trace.ClrProfiler.Managed.csproj`", "reference": "We'll want to remove this one if we make the assembly version constant." }, { "prediction": "I don't think we need this.", "reference": "Can we have a single function here that uses the same subscribers and just changes meta based on context?" }, { "prediction": "HIP will load the kernels and setup the function symbol map on program startup", "reference": "where would ` static startup_kernel_loader skl;` be instantiated? if it's not instantiated anywhere should this be removed?" }, { "prediction": "I don't think this is needed.", "reference": "I think we should move those util functions that work with drag-drop to @uppy/utils, so they can be shared (maybe later) with drag-drop plugin? Otherwise it will continue to depend on drag-drop module." }, { "prediction": "I think this is a breaking change.", "reference": "Migrate the spec.Labels to locator.Labels?" }, { "prediction": "I'm not sure if this is the right place for this test, but I'm not sure if it's the right place for this test.", "reference": "The test case already existed but it never tested properly because of the conditional in the test." }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it.", "reference": "I'm okay with this, but I don't see a lot of benefit to removing unnecessary parens. If extra parens make something more readable (like this) or clarify order of operations even when matching the default, I would say we should keep them." }, { "prediction": "I'm not sure if this is the right place to use volatile fields.", "reference": "@sarowe why was this volatile? It's fishy to see this as the only volatile field." }, { "prediction": "I don't think this is needed.", "reference": "template is not correct?" }, { "prediction": "I don't think we need to import `ASSIGNERS` here.", "reference": "Rename the registies to `BBOX_ASSIGNERS` and `BBOX_SAMPLERS` to avoid ambiguity. There is also a registry for dataset sampler." }, { "prediction": "I'm not sure if this is the right thing to do here. I'm not sure if this is the right thing to do.", "reference": "This is no longer stubbed on every test. Perhaps it should be, and should be unstubbed in the single case that it matters." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This seems much simpler! I'm not sure I follow what you mean by the threading part... Also tests are not liking this constant. Might need a require or to fully qualify this." }, { "prediction": "I don't think this is the right thing to do.", "reference": "Convention is \"FIXME: i#2144\" or \"XXX: i#2144\"" }, { "prediction": "I don't think this is needed.", "reference": "This should probably be a property instead of a method." }, { "prediction": "I think this should be `RECONCILED` instead of `RECONCILED`", "reference": "do we need to consider setting the `state` as well? If so, lot of changes might be required, like, setting to 'Reconciling' in upgrade code, setting to 'error' or'reconciled' in volumeReconciler functions." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it, but I'm not sure if it's the best way to do it.", "reference": "Line is too long. [82/80]" }, { "prediction": "I don't think we need this file anymore.", "reference": "Add blank line below license header." }, { "prediction": "I think we should move this logic to the `BaseMetastoreCatalog` class.", "reference": "I'm not clear on whether this really should be the right behavior. Basically we're saying that a replace table will keep the existing location (as opposed to using defaults). I suspect we don't have create or replace with location semantics, but this is making some assumptions that a replacement is somehow the same as the old. If we were to go with id based pathing convention, this wouldn't work. I don't think this is an issue at this point, but it might make sense to push this down to the location provider." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "Just run a global replacement for all `executionproto`." }, { "prediction": "I don't think we need to pass options here.", "reference": "@AutomatedTester @davehunt thoughts on a new keyword argument?" }, { "prediction": "I don't think we need to do this.", "reference": "Should line 47 be OPAE_ERR?" }, { "prediction": "I don't think this is needed.", "reference": "Not necessary, just write `time.Time{}`" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea.", "reference": "As these two strings simply get concatenated for the docs, there's a space missing after the dot here." }, { "prediction": "I think this should be `RecordTelemetry()` instead of `RecordTelemetry()`", "reference": "What about integrations where we don't plug ourselved on OnMethodBegin?" }, { "prediction": "I don't think we need to change this class.", "reference": "shouldn't **call** return a boolean?" }, { "prediction": "I don't think this is needed.", "reference": "ViewModel classes should not expose any classes from framework.model." }, { "prediction": "I'm not sure why this was removed.", "reference": "how would you feel about keeping these tests to be more explicit and having them `assert not _validate...`? or is your view that that is too duplicative of the tests in `test_evaluator.py`?" }, { "prediction": "I don't think we need this?", "reference": "Why do we use the `winrm_nodes` variable here and not the string `\"winrm_nodes\"` as we were using before?" }, { "prediction": "I don't think we need this file anymore.", "reference": "why update Copyright?" }, { "prediction": "I don't think this is needed.", "reference": "Does this mean we cannot update statistics with sampling on a table with LOB columns?" }, { "prediction": "I don't think this is needed.", "reference": "Look good, but I think a `[flags]` enum would be more future proof? Although i'm not sure if a flags-enum is working from the XML config. What do you think?" }, { "prediction": "I think this should be `row.treeNode.state === 'collapsed' && row.treeNode.children.length > 0 && row.treeNode.state === 'expanded' && row.treeNode.children.length > 0 && row.treeNode.state === 'collapsed' && row.treeNode.state === 'collapsed' && row.treeNode.children.length > 0 && row.treeNode.state === 'collapsed' && row.treeNode.state === 'expanded' && row.treeNode.children.length > 0 && row.treeNode.state === 'collapsed' && row.treeNode.state === 'collapsed' && row.treeNode.children.length > 0 && row.treeNode.state === 'collapsed' && row.treeNode.state === 'collapsed' && row.treeNode.children.length > 0 && row.treeNode.state === 'collapsed' && row.treeNode.state === 'expanded' && row.treeNode.state === 'collapsed' && row.treeNode.state === 'collapsed' && row.treeNode.state === 'collapsed' && row.treeNode.state", "reference": "Since I believe state will never be anything other than 'expanded' or collapse, you can rewrite this as follows: `return row.treeNode.state === 'expanded'? 'ui-grid-icon-minus-squared' : 'ui-grid-icon-plus-squared'; `" }, { "prediction": "I don't think we need this anymore.", "reference": "the latter part can go but isn't the first part of this still sound -- that we assume \"id\"?" }, { "prediction": "I don't think we need this change.", "reference": "Why is the escaping of @ and $ removed?" }, { "prediction": "I don't think we need this interface anymore.", "reference": "Nit: `Http` is redundant in this interface's name." }, { "prediction": "I'm not sure if this is the right place to check if SynchronizableEntitiesPrefix exists or not. I'm not sure if this is the right place to check if SynchronizableEntitiesPrefix exists or not.", "reference": "what if I set SynchronizableEntitiesPrefix to \"a/b/c/d\" in config?" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to check for `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir` or `isDir`", "reference": "nit: This error message doesn't mention that the path is a directory, maybe \"Dockerfile path is a directory:%s, please provide path to file.\"" }, { "prediction": "I think this line should be `# Copyright (c) 2021 Daniel van Noord <13665637+DanielNoord@users.noreply.github.com> # Copyright (c) 2021 Daniel van Noord <13665637+DanielNoord@users.noreply.github.com> # Copyright (c) 2021 Marc Mueller <30130371+cdce8p@users.noreply.github.com> # Copyright (c) 2021 Daniel van Noord <13665637+DanielNoord@users.noreply.github.com> # Copyright (c) 2021 Marc Mueller <30130371+cdce8p@users.noreply.github.com> # Copyright (c) 2021 Daniel van Noord <13665637+DanielNoord@users.noreply.github.com> # Copyright (c) 2021 Daniel van Noord <13665637+DanielNoord@users.noreply.github.com> # Copyright (c) 2021 Daniel van Noord van No", "reference": "This is done automatically, you can skip it next time ;)" }, { "prediction": "I think this should be `if self._tab.is_deleted():`", "reference": "This is needed in `set_value` because of `:open-editor` (you could open an editor, close the tab, then close the editor). I don't think it makes any sense to have it here?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `profiling_enabled` flag. I'm not sure if it's a good idea to have a `profiling_enabled` flag, but if it's a good idea to have a `profiling_enabled` flag, then I think it's a good idea to have a `profiling_enabled` flag, and if it's a good idea to have a `profiling_enabled` flag, then I think it's a good idea to have a `profiling_enabled` flag, and if it's a good idea to have a `profiling_enabled` flag, then I think it's a good idea to have a `profiling_enabled` flag, and if it's a good idea to have a `profiling_enabled` flag, then I think it's a good idea to have a `profiling_enabled` flag, and if it's a good idea to have a `profiling_enabled` flag, then I think it's a good idea to have a `profiling_enabled` flag.", "reference": "Perhaps we can assume that profiling is enabled if ProfilingPort is set? And/or configure a default port and frequency, so we don't have to set three config vars every time?" }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the right way to do it.", "reference": "This nil check won't correctly handle the case where forward_ssh_agent is set to false - it won't be nil but it should still not be set." }, { "prediction": "I'm not sure if this is the right event. I'm not sure if it's the right event, but if it's the right event, then I think it's the right event.", "reference": "We could avoid passing proto since threshold isn't needed." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "This route excluding needed for reconnect only when one connection is lost and we trying to establish another. I was thinking to make 2 separate flags for killswitch and reconnect enabling. This way we can keep killswitch working, but we don't need these routes excluded." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "why can this modification avoid crash?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This looks good -- signing out the user if the current user is disabled" }, { "prediction": "I don't think this is needed.", "reference": "The line exceeds 120 characters." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "Let's go ahead and change \"Site\" to \"Project\", since that's the path we've chosen. One less thing to alter in the other issue." }, { "prediction": "I think we should remove this line.", "reference": "I am for this change iff we are sure the information is no longer helpful. I think this could still be valuable for certain scenarios, wbu?" }, { "prediction": "I think it would be better to use a `Comparator.comparing(ImageRampup::getRampupPercentage())`", "reference": "I thought we decided on using the latest active version and not the one which is max ramped up." }, { "prediction": "I don't think we need to do this. I think we should do this in a separate PR.", "reference": "can we update this to a `log.Warningf`?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `subprocess.run` or `subprocess.check_call`.", "reference": "can we get something emitted in the logs on non-zero exits to trace back to for problems like this failing on the first invocation?" }, { "prediction": "I think this test should be moved to a separate PR.", "reference": "Do we need `schema manager` at here?" }, { "prediction": "I think this should be `C.CString(input)`", "reference": "This won't work because of the permissions on the directory when this is included as a library. But, we may be able to do this. The key would be wrapping this command with either a script or a go binary that ensures the current directory is writable. If the current directory is not writable, it would attempt to make it writable so that we could write out the produced binary. But I'm not sure if that will influence the hash that gets produced for `go.sum` since I am not sure how that is calculated. Alternatively, we can choose a place in `/usr/local` or choose a location that is writable in the go cache and use that. I'll give that a try since it might be needed for the ARM builds if we choose to only include `x86_64` precompiled binaries in the module." }, { "prediction": "I'm not sure if this is the right place to call `SetReturn` or if it's the right place to call `SetReturn` or if it's the right place to call `SetReturn`", "reference": "Correct me if I'm wrong, but is this necessary? Why not just use the value returned by `interpreter.Eval` and not mess with the scope? `interpreter.Eval` will return any produced side effects. This means TableObjects as well as any value resulting from any expression statements." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for this, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, I'm not sure if it's the right place for it, or if it's the right place for it, or if it's the right place for it, I'm not sure if it's the right place for it.", "reference": "This service is global per namespace, not per Alertmanager/Prometheus/ThanosRuler instance. So this approach won't work. But maybe I missing out something, can you describe your use case here?" }, { "prediction": "I think this should be `CanReattest`", "reference": "Do we need this default? Since we aren't using a sql.NullBool or *bool, an unset column will be interpreted as `false` already... We don't set a default on our other bool fields (e.g. entry admin and downstream columns)." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to do this in a separate PR.", "reference": "thanks for moving these over. makes more sense for them to be in the exports_helper" }, { "prediction": "I'm not sure if this is the right place to import keyconf. I'm not sure if it's the right place to import keyconf, but if it's the right place to import keyconf, it's probably better to move it to `qutebrowser.config.parsers.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.keyconf.key", "reference": "That import now isn't needed anymore" }, { "prediction": "I think this should be `path: path to the addon that will be installed.`", "reference": "Can you update the `Usage` to be an absolute path as well? Something like `/path/to/firebug.xpi`" }, { "prediction": "I don't think we need to register the `IMvxAccelerometer.Platform.Uap` in the `MvvmCross.Plugin.Accelerometer.Platform.Uap` file.", "reference": "This class is missing the `MvxPlugin` attribute" }, { "prediction": "I don't think this is needed.", "reference": "What if `wxLang` is returned `None` from `getWxLang`" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Please don't do changing like this unless it _**really**_ cares. BTW. Please look around to infer our naming conventions." }, { "prediction": "I think this should be `log.info(\"Preparing test environment\")`", "reference": "This is in test code: understanding what we're doing is important in this context." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `--goquorum-compatibility-enabled` or `--miner-enabled` or `--miner-enabled` or `--goquorum-compatibility-enabled` or `--miner-enabled` or `--goquorum-compatibility-enabled` or `--miner-enabled` or `--goquorum-compatibility-enabled` or `--miner-enabled` or `--goquorum-compatibility-enabled` or `--miner-enabled` or `--miner-enabled` or `--goquorum-compatibility-enabled` or `--miner-enabled` or `--miner-enabled` or `--miner-enabled` or `--goquorum-compatibility-enabled` or `--miner-enabled` or `--miner-enabled` or `--miner-enabled` or `--miner-enabled`", "reference": "prob should still have an example that has multiple option names even if you have to make it up. Or maybe we don't need this method?" }, { "prediction": "Layout/MultilineMethodCallIndentation: Align.csv files with.csv files if they span more than one line.
Layout/MultilineMethodCallIndentation: Align.csv files with.csv files if they span more than one line.
Layout/MultilineMethodCallIndentation: Align.csv files with.csv files if they span more than one line.
Layout/MultilineMethodCallIndentation: Align.csv files with.csv files if they span more than one line.
Layout/MultilineMethodCallIndentation: Align.csv files with.csv files if they span more than one line.
Layout/MultilineMethodCallIndentation: Align.csv files with.csv files if they span more than one line.
Layout/MultilineMethodCallIndentation: Align.csv files with.csv files if they span more than one line.
Layout/MultilineMethodCallIndentation: Align.csv files with.csv files with.csv files if they span more than one line.
Layout/MultilineMethodCallIndentation: Align.csv files with.csv files with.csv files if they span more than one line.
Layout/MultilineMethodCallIndentation: Align.csv files with", "reference": "I believe respond_to whitelists the formats passed to the block so if we don't want to display html, we can just remove the line format.html..." }, { "prediction": "I'm not sure if this is the right place for this command, but I'm not sure if it's the right place for this command.", "reference": "stylistic nitpick: I _feel_ like we've largely shown errors like this as \"error: \" vs. \"error=\". IMO colon/space reads better." }, { "prediction": "I don't think we need to include the `RTPSParticipantImpl.h` in the `RTPSParticipantImpl.h` file. I don't think we need to include the `RTPSParticipantImpl.h` in the `RTPSParticipantImpl.h` file.", "reference": "We could put this implementation in `RTPSWriter::create_change_pool` and avoid an extra function." }, { "prediction": "I don't think this is needed anymore.", "reference": "should this file ends with _test.go?" }, { "prediction": "I don't think we need to do this. I don't think we need to do this.", "reference": "It's because of this change. `ss` was unused and it made sense in the program. However I haven't read the IPv6 RFC so I'm unsure of what it does" }, { "prediction": "I think this is not needed anymore.", "reference": "\"Flatten\" is a verb, so I'd probably go with `flattenedIndex` as a variable name here." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "If it can only be called once, perhaps a more appropriate name is something like `setMaskables`? `addX` sounds like you can add many `X`es by calling it many times" }, { "prediction": "I'm not sure if this is the right place to do this, but I think it would be better to move this function to `DownloadConfigPackage` and call `DownloadConfigPackage` from `DownloadConfigPackage` in the `DownloadConfigPackage` function.", "reference": "Nodecfg should be downloading from a private bucket -- these shouldn't be for public consumption. In general these should be generic and expect environment to provide appropriate credentials and bucket." }, { "prediction": "I don't think this is needed.", "reference": "Could you please end the file with an empty line?" }, { "prediction": "I'm not sure if this is the right place to put this in.", "reference": "This is an incorrect change. The dialect spoken is an important part of the handshake and should be communicated to users." }, { "prediction": "I think this should be `isCanceledMx` or `isCanceledMx`", "reference": "Can this be non-exported to avoid direct use? It would be a breaking change but using previous package version would work." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea.", "reference": "Nit: this is just `return gcerrors.Code(err)`, isn't it?" }, { "prediction": "I'm not sure if we should remove this line.", "reference": "I don't know where this came from, but it's not a good idea. This is actually timing out after 5 rounds, not 5 blocks. 5 consecutive null blocks won't be that uncommon. Also when testing with a short block time, this is a very short duration that can contribute to flaky tests." }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "In Python 3 when pickling or unpickling objects, the file needs to be opened as binary so that no text encoding/decoding takes place. So for any open calls around pickle loads or dumps, the mode for reading must be rb and the mode for writing must be wb." }, { "prediction": "I don't think we need to change this.", "reference": "did you remove **params.qstring.method** intentionally? if so why?" }, { "prediction": "I think we should rename this to LOCALITY_TASK_INITIALIZE_THREADS_DEFAULT", "reference": "What is the current default? Is that inconsistent across uses and that's why this is null?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "Why did we make this change? How come it wasn't an issue before" }, { "prediction": "I'm not sure why this test was failing. I'm not sure why this test was failing.", "reference": "Can you tighten scope by moving to of these variables? i.e. Move to ~4372?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Nice to see this `dataverse.rserve.password` fix rolled in." }, { "prediction": "I'm not sure if this is the right place to use strlen_s. I'm not sure if this is the right place to use strnlen_s.", "reference": "How about the following faster alternative that doesn't need `strlen()` at all: if (*tmp_optarg == '\\0' || *endptr!= '\\0') { fprintf(...)... This would treat the bus argument as invalid if it's either empty (`tmp_optarg` points to '\\0') or invalid (`endptr` points to something other that a '\\0'). Actually, the existing code would accept an empty argument and set the bus to `0`, so if (*endptr!= '\\0') { fprintf(...)... would be enough. The check for an empty argument doesn't hurt, though." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.", "reference": "I could be missing something here, but the `from` and `cc` are the same. On the test email sent to gatewaycommunicator, these values are different." }, { "prediction": "I'm not sure if this is the right test.", "reference": "I'm honestly scared because act is now a hard requirement for useEffect which it wasn't before... This could break some tests :(" }, { "prediction": "I don't think we need to do this anymore.", "reference": "Could use election from `info_a.election`, or is this deliberate?" }, { "prediction": "Do we need to add this method to the `AbstractTypeExtension` class?", "reference": "looks like this should be `return array(LegacyFormHelper::getType('form'));`" }, { "prediction": "I'm not sure if this is the right place to check for `typeof opt_port!== 'function'`", "reference": "Maybe it would simpler to ignore opt_port if type!== 'number'?" }, { "prediction": "I don't think this is needed.", "reference": "Where was `name` being declared before?" }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it. I'm not sure if this is the right way to do it, but I'm not sure if it's the right way to do it. I'm not sure if it's the right way to do it, but if it's the right way to do it, it's the right way to do it. If it's the right way to do it, I'm not sure if it's the right way to do it, but if it's the right way to do it, it's the right way to do it. If it's the right way to do it, it's the right way to do it, but if it's the right way to do it, it's the right way to do it. If it's the right way to do it, it's the right way to do it.", "reference": "nit: use `corev1.ConditionUnknown`" }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it. I'm not sure if this is the right way to do it, but if it's the right way to do it, I'm not sure if it's the right way to do it, so I'm not sure if it's the right way to do it.", "reference": "You also need to add a similar check on line 992, there's another place where we check `length === 24`" }, { "prediction": "I'm not sure if this is the right place to call this method, but I'm not sure if it's the right place to call this method.", "reference": "nit: can extract the voteProvider as a local variable" }, { "prediction": "I'm not sure about this change, but I'm not sure if it's a good idea to change this test.", "reference": "[0] Not suggesting you change it here, but....kindof weird that there's just not an `assertFuncNotEquals`" }, { "prediction": "I'm not sure if this is the right place to call `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered` or `IsRegistered`` or `IsRegistered` or `IsRegistered` or `IsRegistered`` or `IsRegistered` or `IsRegistered`` or `IsRegistered` or `IsRegistered`` or `IsRegistered", "reference": "why are we passing'registryAddress' here? We probably should construct it together with bc. Registry is not something that change?" }, { "prediction": "It's like {@link RA.spreadPath|spreadPath} but preserves object under property path", "reference": "`.` at the end of the sentence" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do this, I'm not sure if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do it.", "reference": "wouldn't it be useful to split this into an error metric for the timing?" }, { "prediction": "I'm not sure if this is the best way to test this. I'm not sure if it's the best way to test this, but I'm not sure if it's the best way to test this.", "reference": "Not sure if this is good enough. Each generator will have it's own unit test anyway. Ideally, I think I'd want to test that each generator in the yml is actually a valid generator..." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea.", "reference": "line is 138 characters" }, { "prediction": "I'm not sure if this is the right way to do this. I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it.", "reference": "Nit: I would leave `Wire` out of the description; if you use this without wire you can still use it." }, { "prediction": "I don't think this is needed.", "reference": "Nit: each field can be on a separate line to make it visually easier to read." }, { "prediction": "I think this should be `compiler_info.json` instead of `compiler_info.json`", "reference": "Do we still have these files? Shouldn't we remove these?" }, { "prediction": "I don't think we need this. I think we should add a `ErrDurationInvalid` field to `certmanager/v1alpha1` so that we don't have to worry about the `ErrDurationInvalid` field.", "reference": "A lot of things to do with constants seemed to move since the original commit, so I stuck this here, Is there a better place for it?" }, { "prediction": "I think this should be `ActionChanSize: 1000, BlockChanSize: 1000, BlockSyncChanSize: 10,`", "reference": "is 10 too small compared to 1000? consider sync chan is unicast only (vs block chan is broadcast + unicast), i would say use 200~400 for BlockSyncChanSize my concern is that this would potentially slowdown sync speed of full-node" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "A full parse of the plan here on listing the plans will be expensive from both a computation and IO perspective." }, { "prediction": "I don't think this is needed. I think it should be `UART_TX_PIN` or `UART_RX_PIN` or `UART_TX_PIN` or `UART_RX_PIN` or `UART_TX_PIN` or `UART_RX_PIN` or `UART_TX_PIN` or `UART_RX_PIN` or `UART_TX_PIN` or `UART_RX_PIN` or `UART_RX_PIN`", "reference": "These constants use the `_PIN` suffix, while the other constants don't use it. I'm not sure what is best, but I would prefer to keep this consistent. Do you have an opinion on which it should be (with or without suffix)?" }, { "prediction": "I'm not sure if this should be `@SuppressWarnings({\"FieldMayBeFinal\", \"FieldMayBeFinal\"})` or `@SuppressWarnings({\"FieldMayBeFinal\", \"FieldMayBeFinal\"})`", "reference": "Hmm... this feels like discovery should come first. perhaps `--discovery-dns-url`? @NicolasMassart any opinions on this or ideas on who it should be run by?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "why is this needed?" }, { "prediction": "I don't think we need to pass `key` to `__init__`?", "reference": "I wonder if it'd be possible to autogenerate a key from the name within this function if one is not provided explicitly, rather than having all the callsites pass both the name and key (and usually as the same value)? Might give us a good place to implement a `name->key` function that isn't 1:1." }, { "prediction": "I'm not sure if this is the right place for the IPV4 and IPV6 fields. I'm not sure if this is the right place for the IPV4 and IPV6 fields, but I'm not sure if this is the right place for the IPV4 and IPV6 fields.", "reference": "@adriancole I do not see a change in the thrift file. Are there unit tests verifying that this manual serialization is compatible with the native Thrift serialization done by classes generated from `.thrift` IDL file?" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "spelling (variable name, all three changes)" }, { "prediction": "I don't think this is necessary. The caller can specify `desiredUID` to force a server check if that particular UID isn't a member of the team. The caller can specify `desiredUser` to force a server check if that particular UID isn't a member of the team. The caller can specify `desiredRole` to force a server check if that particular UID isn't a member of the team. The caller can specify `desiredUser` to force a server check if that particular UID isn't a member of the team. The caller can specify `desiredUser` to force a server check if that particular UID isn't a member of the team.", "reference": "I believe you meant \"specify `desiredUID` and `desiredRole`\"?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Please follow the import style, move it to its similar group" }, { "prediction": "I don't think this is the right place to call this function.", "reference": "Do we really need these? This is expanding on an API that we're about to do work on with the error stuff @kriskowal" }, { "prediction": "I'm not sure if this is the right place for this change, but I'm not sure if this is the right place for this change.", "reference": "passwordModificationTime is no longer used - did the change drop a time check that should be restored? Or should the param get dropped from the methods?" }, { "prediction": "I'm not sure if this is the right way to do this, but I think it's better to use `StringComparison.OrdinalIgnoreCase` instead of `StringComparison.OrdinalIgnoreCase`.", "reference": "Would it break here without trim? If so, can we do trim in Startup.cs so we don't need to add this code to every parser?" }, { "prediction": "I think this should be `Expect(string(out)).To(ContainSubstring(\"Another app is currently holding the xtables lock\"))`", "reference": "Since we're using Logrus, probably best to use `Infof` to avoid confusion (Logrus' Printf behaves differently to the built in one)" }, { "prediction": "I don't think this is needed.", "reference": "Hm, this looks like a change that should go upstream as well." }, { "prediction": "I don't think we need this anymore.", "reference": "let's keep ActionByActionHash and delete getActionByActionHash" }, { "prediction": "I think this should be `PricingGroup::getPricingGroup()`", "reference": "please use return type" }, { "prediction": "I don't think this is the right place for this test.", "reference": "This is deliberately at this level." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but I'm not sure if it's the right place to do it.", "reference": "I'm going to go ahead and undo this change, I don't think it was intentional." }, { "prediction": "I don't think this is needed anymore.", "reference": "> specialised This isn't a typo in my neck of the woods" }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "will change to `storage_target`" }, { "prediction": "I don't think we need this test anymore.", "reference": "This would be better as `cls.securitycenter_client`, to match what is being instantiated." }, { "prediction": "Do we have separate system32 directories for 32 and 64-bit processes?", "reference": "Could we have this initialization as part of the initialize method?" }, { "prediction": "I don't think we need to pass null here.", "reference": "This line should be removed as editController is not used from this context anymore." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This is correct in concept but the method signature doesn't really communicate the same thing. In other words, if the function produces an output table where is it? Its not on the function signature. Can you explain where the output table is created?" }, { "prediction": "I'm not sure if this should be `None` or `None` or `None`", "reference": "For insurance, it's best not to take it directly" }, { "prediction": "I don't think we need to pass `CharSequence[]` to `beforeChangeValueOf`?", "reference": "change 'value' to keysToSend, here and in other references in this commit. 'value' implies the user is getting the value of the element, rather than just the keys we're sending to it." }, { "prediction": "I think this should be `task.SetLocalIPAddress(taskIP)` instead of `task.SetLocalIPAddress(taskIP)`", "reference": "is the plan to fully migrate to boltdb and then remove the state save here?" }, { "prediction": "I'm not sure if this is a good idea. I think it's a good idea to use `colorColor` instead of `strongTextColor` in the `themeCache_` function.", "reference": "This should be `output.colorBright`. Unless I'm missing some reason for adding a new theme variable." }, { "prediction": "I'm not sure if this is needed.", "reference": "nit: I wonder if these should be moved down to where version is defined, just to keep them all in the same place." }, { "prediction": "I'm not sure why this is needed.", "reference": "Is this supported by every implementation of Java (and Android)? Should it be conditional upon `gen_nullable`?" }, { "prediction": "Line is too long. [89/80]", "reference": "@briri Thanks! I just caught this too updating my feature branch" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "I think you should move this block (and the `envpw := os.Getenv(\"RCLONE_CONFIG_PASS\")`) right to the start of the function, then we can remove the duplicate code below" }, { "prediction": "I'm not sure if this is the right test.", "reference": "Is this only to set the node to draining? I think we can do that inside `Before` or something?" }, { "prediction": "I don't think we need to do this. Is there a reason we don't need to do this?", "reference": "This should have been moved up above this inner `try` because the log message in the `catch` block does not apply to this." }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do here.", "reference": "Do we expect people to use PlanResult directly?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `wait.ExponentialBackoff(backoff, func() (bool, error)`) or `wait.ExponentialBackoff(backoff, func() (bool, error)`) or `wait.ExponentialBackoff(backoff, func() (bool, error)`) or `wait.ExponentialBackoff(backoff, func() (bool, error)`) or `wait.ExponentialBackoff(backoff, func() (bool, error)`) or `wait.ExponentialBackoff(backoff, func() (bool, error)`) or `wait.ExponentialBackoff(backoff, func() (bool, error)`) or `wait.ExponentialBackoff(backoff, func() (bool, error)`) or `wait.ExponentialBackoff(backoff, func() (bool, error)`", "reference": "Maybe we should call this something like `errToReturn`?" }, { "prediction": "I don't think we need to do this.", "reference": "should calculate numEpochIn1Year = xxx and <= fairBankEpochNum+numEpochIn1Year a.foundationBonusLastEpoch just happens to be equal to 1 year now, but should not count on that" }, { "prediction": "I don't think we need to worry about this.", "reference": "I wasn't sure if the content type needed to be removed from both the `default` and `usemap` objects - I'm not sure how usemap is used." }, { "prediction": "I don't think this is needed.", "reference": "Duplication of line 28 Please refer your tox -e flake8 It seems that XStrField, XShortField, FieldLenField are not used" }, { "prediction": "I don't think we need to do this, but I think it's better to use `self._file_model.index(row, 0, self._file_model.index(path))` instead of `self._file_model.index(row, 0, self._file_model.index(path))`", "reference": "I don't really understand the `self._file_model.index(path)` as parent here - you use `self._root_index` for `rowCount` above, so wouldn't the parent here need to be `self._root_index` as well?" }, { "prediction": "I think this should be `minQueryLength` or `maxQueryLength`", "reference": "Do we want validation somewhere that max >= min? Or simply treat the max < min case as ignoring max?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to change the behavior of `TopFrames == 1` to `TopFrames == 2` or `TopFrames == 3` or `TopFrames == 4` or `TopFrames == 1` or `TopFrames == 2` or `TopFrames == 3` or `TopFrames == 4`", "reference": ":+1: that's a easier example :)" }, { "prediction": "I think this should be `ProductQueryInterface`.", "reference": "If an external module decorates this interface, such a change will cause it to generate an error" }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to use `FNM_PERIOD` instead of `FNM_PERIOD`.", "reference": "Oh ha hah, FNM_PERIOD worked out nicely there. Points for co-opting a file system convention." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "wrong grouping. As you can tell from the other files, we put system packages in the first group, the 3rd party packages in the second group, and our own packages in the third group." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Is `o.name` always set here?" }, { "prediction": "I'm not sure if this is a breaking change.", "reference": "Can this line be removed, as `SteadyStateDependencies` isn't updated anywhere? Also do we need to check the `TransitionDependencySet` here?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea, but I'm not sure if it's a good idea.", "reference": "`plan.present?` and `has_active_subscription?` are equivalent. We can drop this change, while leaving the one on `app/controllers/application_controller.rb`." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `self.name = name` or `self.maxsplit = maxsplit` or `self.name = name` or `self.maxsplit = maxsplit` or `self.name = name` or `self.maxsplit = maxsplit` or `self.name = name` or `self.maxsplit = maxsplit` or `self.name = name` or `self.maxsplit = maxsplit` or `self.name = name` or `self.maxsplit = maxsplit or 'global'` or `self.name = name` or `self.maxsplit = maxsplit or 'global'` or `self.name = name` or `self.maxsplit = maxsplit or 'global'` or `self.name = name or 'global'` or `self.maxsplit = 'global' or 'global' or 'global' or 'global' or 'global' or 'global' or 'global' or 'global' or 'global' or 'global' or 'global' or 'global' or 'global' or 'global'", "reference": "No need for this, as pylint already only turns things off for this function and it's needed for the entire function." }, { "prediction": "I don't think we need to change this.", "reference": "L171 needs to be modified too?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but I'm not sure if it's the right place to do it.", "reference": "Why do you compare by nodeid? Simply saying d == e should be enough. Unless we have to objects in memory with the same nodeid. If that is so, something went really wrong." }, { "prediction": "I don't think this is needed.", "reference": "configs/pvt/retinanet_pvt_t_fpn_1x_coco.py --> configs/pvt/retinanet_pvt-t_fpn_1x_coco.py" }, { "prediction": "I'm not sure if this is a good idea. I think it's a good idea to rename the `DesiredStatus` field to `DesiredStatus,omitempty` or `DesiredStatus,omitempty` to `DesiredStatus,omitempty` and `DesiredStatus,omitempty` to `DesiredStatus,omitempty` and `DesiredStatus,omitempty` to `DesiredStatus,omitempty` and `DesiredStatus,omitempty` to `DesiredStatus,omitempty` and `DesiredStatus,omitempty` to `DesiredStatus,omitempty` and `DesiredStatus,omitempty` to `DesiredStatus,omitempty` and `DesiredStatus,omitempty` to `DesiredStatus,omitempty` and `DesiredStatus,omitempty` to `DesiredStatus,omitempty` to `DesiredStatus,omitempty` and `DesiredStatus,omitempty` to `DesiredStatus,omitempty` and `DesiredStatus,omitempty` to `DesiredStatus,omitempty` to `DesiredStatus,omitempty`", "reference": "Nit, this could be json:\",omitempty\"" }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if it's the right place to do this.", "reference": "It's kinda funny to read `s.Image.Image` I wonder why it resulted to this way. What would it take to refactor to just `s.Image`?" }, { "prediction": "I don't think this is needed.", "reference": "nit: I like the idea! can we instead change the tag to `integration-remote` to be more specific? I feel like it's possible for us to use the `deploy` build tag for possibly another scenario" }, { "prediction": "I don't think we need to change this line.", "reference": "Copy and paste error here. Edit: Also missing commas here and in other Perl croaks between some parameters and not others." }, { "prediction": "I don't think this is needed.", "reference": "stateRoot or maybe ParentHeader would make more sense from API point of view?" }, { "prediction": "I think we should remove the notification from PlaybackServiceFlavorHelper.", "reference": "Are you sure that this is no longer needed?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Would it help to use SCAN_COLUMNS as base to build SCAN_WITH_STATS_COLUMNS e.g like so `SCAN_WITHSTATS_COLUMNS = ImmutableList.builder().addAll(SCAN_COLUMNS).add(\"value_counts\",....).build()`?" }, { "prediction": "I don't think this is deprecated.", "reference": "`ctx` is unused in ReportStat" }, { "prediction": "I don't think this is needed.", "reference": "We don't want to add boost as a dependency when building the Thrift compiler. Sorry." }, { "prediction": "I don't think this is needed anymore.", "reference": "It's not printing the range. Also I think it's useful to print a warning above stating that the minimum change is -1000." }, { "prediction": "I don't think this is needed.", "reference": "if name is empty will this become enumerate? (and cause the unmarshal to fail?)" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it. I'm not sure if it's the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "How about including a flash message that explains the exercises are only available to subscribers of X plan?" }, { "prediction": "I don't think we need to do this. I'm not sure if we need to do this.", "reference": "You should also call `e.accept()` and `return` so the key press isn't processed further (as we're leaving insert mode anyways)." }, { "prediction": "I don't think we need to register this interceptor. I think we need to register it in the `Mail.register_interceptor` method.", "reference": "Freeze mutable objects assigned to constants." }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if it's the right way to do this.", "reference": "Hmm, this feels hacky. Maybe good enough if it makes the test more stable, but why is timing even an aspect here, since below it should wait for these two things anyway?" }, { "prediction": "I'm not sure if this is the right place to set the X-Forwarded-For header, but it seems like it's the right place to set the X-Forwarded-For header. I'm not sure if this is the right place to set the X-Forwarded-For header, or if it's the right place to set the X-Forwarded-For header, or if it's the right place to set the X-Forwarded-For header, or if it's the right place to set the X-Forwarded-For header, or if it's the right place to set the X-Forwarded-For header, or if it's the right place to set the X-Forwarded-For header, or if it's the right place to set the X-Forwarded-For header, or if it's the right place to set the X-Forwarded-For header, or if it's the right place to set the X-Forwarded-For header, or if it's the right place to set the X-Forwarded-For header.", "reference": "Do we want this on by default, or an opt-in (e.g. via some config while add the instrumentation)? I guess a more general question is - what's the bar for the default vs opt-in tags." }, { "prediction": "I'm not sure if this is the right place to register handlers. I'm not sure if it's the right place to register handlers, but if it's the right place to register handlers, I'm not sure if it's the right place to register handlers.", "reference": "`status` is just one of the features, named as status is not suitable." }, { "prediction": "I don't think this is the right place for this.", "reference": "There is an option to hide the subscriptions list from the sidebar. If it is hidden, the filter text should not be displayed." }, { "prediction": "I think this should be `query/memoryCircuitBreakerThreshold`", "reference": "I'd like for all of this to be dynamically configurable at some point, but it doesn't have to be in this PR. Can add it to the future SIP or create a separate JIRA for it, as you think would be appropriate." }, { "prediction": "I'm not sure why this is removed.", "reference": "move the constructor to down the `namespace`" }, { "prediction": "I'm not sure if this is the right thing to do here, but I think it's better to have a `FederatedClusterRef` struct that holds the reference to the federated cluster resource.", "reference": "Nit: ending with a '.' looks consistent with the fields around it." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `MintJWTSVIDRequest` and a `MintJWTSVIDResponse` in the `MintJWTSVID` method. If it's a good idea to have a `MintJWTSVIDRequest` and a `MintJWTSVIDResponse` in the `MintJWTSVID` method, I'm not sure if it's a good idea to have a `MintJWTSVIDRequest` and `MintJWTSVIDResponse` in the `MintJWTSVID` method. If it's a good idea to have a `MintJWTSVIDRequest` and `MintJWTSVIDResponse` in the `MintJWTSVID` method, I'm not sure if it's a good idea to have a `MintJWTSVIDRequest` and `MintJWTSVIDResponse` in the `MintJWTSVID` method. If it's a good idea to have a `MintJWTSVIDResponse` and `", "reference": "Audit log will not have a warning about they are using a deprecated path, is it something we must care about?" }, { "prediction": "I don't think this is necessary.", "reference": "I think you also want to update the condition to add ` || impl.Visibility == TypeMemberVisibility.FamilyOrAssembly`." }, { "prediction": "I don't think we need to change this. I don't think we need to change this.", "reference": "`DepositToRewardingFundBaseGas` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I don't think this is the right place for this command.", "reference": "What do you think of \"operations\"?? Also what do these emojis look like on Linux??" }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "I like the word \"give\" here. Feels like I'm giving a gift to my team." }, { "prediction": "I don't think we need to import `MultiOutputClassifier`, `MultiOutputRegressor`, `MultiOutputRegression`, `MultiOutputRegression`, and `MultiOutputRegressor` in this file.", "reference": "Is it possible to use `np.random` module instead?" }, { "prediction": "I don't think this is needed.", "reference": "``default=None`` implies ``allow_None`` so ``allow_None`` is superfluous here. As a special case, if allow_None=True (which is true by default if the parameter has a default of None when declared) then a value of None is also allowed." }, { "prediction": "I don't think this is the right place for this.", "reference": "Is there anything in particular that makes setting up the downstream rolebinding(s) to `system:k3s-controller` burdensome or confusing? This changes looks fine to me but it seems a shame to alias an embedded k3s controller. If we are doing this in other places that I am not aware of then we can dismiss this concern out of hand." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I don't think this is needed.", "reference": "nit: all other types in this project have full names, so maybe a better name would be `OperatingSystem`?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Why is this needed here?" }, { "prediction": "I'm not sure if this is the right place to return an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional.empty() or an Optional", "reference": "mmm, why a method declaration should not have the TypeVariableResolutionCapability? Is this ok?" }, { "prediction": "I think this should be `privateTransactionHandler` instead of `privateTransactionHandler`.", "reference": "nit: any reason you swapped the ordering?" }, { "prediction": "I don't think this is needed anymore.", "reference": "can you de-uglify at least this line?.. hard to tell what changed..." }, { "prediction": "I'm not sure why this was removed.", "reference": "Please can you merge master in before making these changes. I just reinstated a bunch of BPF UTs. Possible that the UTs use this code." }, { "prediction": "I don't think we need this test.", "reference": "Do you want to add additional cases for `Bla.__b()` and `self.__c()`? (Just add additional classmethods `__b` and `__c` and the calls to `__init__`)" }, { "prediction": "I'm not sure about this change, but I think it's a good idea to move this line up to the `get_current_user_records_that_can_be_displayed` function.", "reference": "the recids is never changed after. So, it should contains the exact shown results, whatever are the rights for the user (admin or simple user, restricted collections...)" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Shouldn't the docstring mention that the MD5 checksum of `p` is computed each time and verified? Also, could there be use cases where a caller might not want such a check to happen because, eg, a blob storage solution doesn't provide MD5 verification or uses another hash algorithm such as SHA256?" }, { "prediction": "I think this should be `if eventName==\"gainFocus\" and not doPreGainFocus(obj,sleepMode=sleepMode):` or `if eventName==\"gainFocus\" and not doPreGainFocus(obj,sleepMode=sleepMode):`", "reference": "focusRedirect is used in the powerpnt appModule. We might have to make sure that this does not break. Having said that, I really like this being handled on the events level!" }, { "prediction": "I don't think this is needed anymore.", "reference": "You imports are out of order" }, { "prediction": "I'm not sure if this is the right place to change the default job name.", "reference": "This should not be called Flow Trigger. FlowTrigger should has its own flowTrigger job name, for instance, \"flowtrigger\"" }, { "prediction": "I'm not sure if this is the right place to put this file.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I'm not sure if this is the right place for this, but I think it's better to use `Console.WriteLine(\"***WARNING*** The current build is DEBUG which may affect timing!\\n\");`", "reference": "Why do we need `\\n` if we already use `WriteLine`? (and `\\n` is not cross platform)" }, { "prediction": "I don't think we should change this to \"besu\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or \"prometheus\" or", "reference": "What is instrumentation name used for? I'm not seeing other classes use it, only a getter, constructor, and builder." }, { "prediction": "I think this should be removed as well.", "reference": "@kristofgazso could you review these warnings?" }, { "prediction": "I'm not sure if this is the right place to put this.", "reference": "will delete this." }, { "prediction": "Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument when opening brace is on a separate line from the last argument when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line.", "reference": "~~Indent 2 lines above~~ Disregard. My fault" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea, but I'm not sure if it's a good idea or if it's a good idea.", "reference": "What was the bug that this is fixing?" }, { "prediction": "I don't think this is needed.", "reference": "This will always add the authorization header to the request object. Is this the right scope for these two lines? If username/password are not defined, it will encode 'Basic :'" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "Is this always how Bazel does paths? Would it be nicer to do `-DBAZEL_TEST_DATA_PATH=../com_github_google_flatbuffers/tests/` so this string is not hardcoded in the the source?" }, { "prediction": "I don't think we need to do this. I'm not sure if we need to do this.", "reference": "Not an expert of ES, so not sure of the impact here." }, { "prediction": "I don't think this is needed.", "reference": "Who deletes the memory for the granteeList? (or the roleList for that matter)" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "This loop is missing a lock on subscriptions_mutex." }, { "prediction": "I'm not sure if this is the right route. I'm not sure if it's the right route, but if it's the right route, I'm not sure if it's the right route. If it's the right route, I'm not sure if it's the right route, but if it's the right route, I'm not sure if it's the right route.", "reference": "shouldn't clearance be setting these up for us?" }, { "prediction": "I'm not sure if this should be `NoOp` or `NoOp` or `NoOp` or `NoOp` or `NoOp` or `NoOp` or `NoOp` or `NoOp` or `NoOp` or `NoOp` or `NoOp` or `NoOp` or `NoOp` or `NoOp` or `NoOp` or `NoOp` or `NoOp` or `NoOp` or `NoOp` or `NoOp` or `NoOp` or `NoOp` or `NoOp` or `NoOp`", "reference": "Need to update the doc for `TelemetrySDK` and `Host` structs deleting references from removed functions." }, { "prediction": "I'm not sure if this is needed anymore.", "reference": "I think we should keep that here and add a new method `isSyntacticallyFinal` that returns `super.isFinal()` (and can be used in UnnecessaryModifier). Otherwise the contract of `isFinal` is not respected" }, { "prediction": "I don't think we need to call scrollIfNecessary multiple times?", "reference": "Is there a reason why we wouldn't want to check this every time? Why are we only checking for the footer and scroll bar when enableCellEditOnFocus is true?" }, { "prediction": "I don't think this is needed.", "reference": "You need to create an API for this class. This class should follow roughly the same dependency structure than RemoteAvailableInstallersPlayOnLinuxImplementation / RemoteAvailableInstallers. Maybe we could use a inner class here?" }, { "prediction": "I don't think we need to update the `start_time` and `execution_time` values.", "reference": "This should not be a case, right? If `run_id` is the same `workflow_id` can't be changed. Actually surprised that it is not part of a key." }, { "prediction": "I don't think this is needed anymore.", "reference": "How would AQR work for an INSERT/SELECT of one table into another where a LOB column is being copied?" }, { "prediction": "I don't think this is needed.", "reference": "Since these are ultimately different endpoints, it would be nice if we could move them up one level and nuke the common `sds` directory in order to reduce path stutter" }, { "prediction": "I don't think we need to check for null here.", "reference": "Please check also whether `null` occurs in the rest of `beforeChangeResult` array." }, { "prediction": "I'm not sure if this is client side, but I'm not sure if this is client side.", "reference": "Outdated docs. There is no response, there's an ack." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I'd rather have the container process remove the FIFO after it unblocks. Then `start` can always `Exec()`, and you can catch the \"FIFO does not exist\" error and translate it to a prettier \"someone must have already started the container\"." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "can you check if there's other similar cases to add nil-check like this?" }, { "prediction": "I'm not sure about this, but I think it's better to use `if commonname is not None and len(commonname) < 64` instead of `if is_valid_commonname: cert.get_subject().CN = organization`", "reference": "`<= 64`? I just picked up what you said in #3981 (\"the CN field is limited to 64 characters\") but maybe there's something I don't know where the 64th character is needed (trailing dot or whatever?) Also this sounds like something that could be beautifully unit tested. Sorry for bugging you :grin:" }, { "prediction": "I don't think we need this method anymore.", "reference": "I understand that this grabs a Licenses objects but what is the autocomplete method used for? What does this do in context of the auto_completes controller?" }, { "prediction": "I think this method should be renamed to `transactionLocationByHash`", "reference": "I don't really like that way of naming methods based on their arguments. But I can see that the other method names are the same..." }, { "prediction": "I don't think this is needed.", "reference": "@sekmiller This method correctly strips the leading and trailing slashes (and also \".\" and \"-\"); But I thought the plan was also to replace any multiple slashes between nested folders with a single slash. For example, as implemented now, I can enter \"folder1///folder2\", and it gets saved and displayed like this, with the 3 slashes. I thought we wanted to sanitize it as \"folder1/folder2\"." }, { "prediction": "I'm not sure why this is needed.", "reference": "Looks like the X86 inline assembly is not happy with this type. I will update that" }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "Tabs and a space, again." }, { "prediction": "I think this should be called `gettaskname` instead of `gettaskname`", "reference": "Please just enclose if blocks with brackets; this has created issues in the past so I'd prefer we don't use them" }, { "prediction": "I think we should remove the `approve_path` method from the `proposal_controller.rb` file.", "reference": "`version` isn't need anymore because it's built into `approve_proposal_url`, yes?" }, { "prediction": "I don't think we need to import _dbmField from scapy.data import _dbmField from scapy.data import _dbmField from scapy.data import _dbmField from scapy.data import _dbmField", "reference": "Moved to the bottom of the file. `CtrlPDU` sits on `BTLE_DATA` so let's put it after" }, { "prediction": "I'm not sure if this is the right place to put this file. I'm not sure if it's the right place to put this file.", "reference": "This ends up requiring the `json` gem, right? Is there any way we can do this to be implementation agnostic (e.g. to let me use `yajl-ruby` for performance reasons (or because my app already brings in a JSON library)" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "This seems dangerous. What circumstances lead to the need for a retry? Can that happen more than once? I'm concerned that if we hit the pathological state, this could turn into a CPU spinner. I wonder if we could get the same benefit from just \"trying again\" and failing if it fails the second time." }, { "prediction": "I don't think this is needed.", "reference": "If there is a reference to other fields or methods, please do the initialization in the constructor." }, { "prediction": "I don't think this is needed.", "reference": "These should be importing from `pill-container`" }, { "prediction": "I don't think we need to sendCancelMessage(RETURNVALUE_NOTPOSSIBLE, \"Sorry, not possible.\")", "reference": "Why this change? It will now only show on the bottom of the screen as white text, is it correct behaviour?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea to use `field_value(f, except_operations: [Rendering::HelperMethod])` or `field_value(f, except_operations: [Rendering::HelperMethod])` or `field_value(f, except_operations: [Rendering::HelperMethod])` or `field_value(f, except_operations: [Rendering::HelperMethod])` or `field_value(f, except_operations: [Rendering::HelperMethod])` or `field_value(f, except_operations: [Rendering::HelperMethod])` or `field_value(f, except_operations: [Rendering::HelperMethod])` or `field_value(f, except_operations: [Rendering::HelperMethod])` or `field_value(f, except_operations: [Rendering::HelperMethod])` or `field_value(f, except_operations: [Rendering::HelperMethod])` or `field_value(f, except_operations: [Rendering::HelperMethod])` or `field_value(f, except_operations: [Rendering", "reference": "Does this need to allocate a string or would a nil value (indicating no header) be a better?" }, { "prediction": "I think this should be `this.constructor` instead of `this.constructor`.", "reference": "Nit: Past tense of `reset` is also `reset`." }, { "prediction": "I don't think we need this command. I think we should use `getfee` instead of `getfee_per_kb`", "reference": "Shouldn't this use `'n'` instead?" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "revert back to 'TASK_TYPE_ACTIVITY_TIMEOUT'" }, { "prediction": "I don't think this is needed.", "reference": "Shouldn't we prefer passing a pointer by reference T*&, since these are C++ bindings?" }, { "prediction": "I don't think this is the right place to do this.", "reference": "nit: Personally I feel that it's cleaner to let `toAntreaPeerForCRD` to take `ingressRule` as a param instead of `ingressRule.From`. It can call `processRefCGs` inside the function and do the ipBlock/AG union within the function itself. It might not be worth the refactor though." }, { "prediction": "I'm not sure if this is the right place to update the version details.", "reference": "Pending has been set only for SPC.. why? for other CRs as well, this need to be done.. right?" }, { "prediction": "I think this should be `$options['class']` instead of `$options['class']`", "reference": "would use an empty string here as default and then check for emptiness in the twig template. I dont like mixing types @core23 what do you think?" }, { "prediction": "Please use `StringUtils.toUpperCamel(methodInfo.responsePageTokenName()).toUpperCamel()`", "reference": "How come we need case manipulation for the nextPageToken and not for pageToken?" }, { "prediction": "I don't think we need this route anymore.", "reference": "why use these rather than regular named paths?" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it, but I'm not sure if it's the best way to do it.", "reference": "Hm, I don't think the extra flags are doing any harm here, but it does seem like `--help` is the only flag you could *actually* use with this command. We might eventually want to separate those out." }, { "prediction": "I'm not sure about this flow, but I'm not sure if it's a good idea to have a `top_artists_candidate_set_df` and `top_artists_candidate_set_df` in the same file. I think it's better to have a `top_artists_candidate_set_df` and `top_artists_candidate_set_df` in the same file, and then use `top_artists_candidate_set_df` to get the data from `top_artists_candidate_set_df` and `top_artists_candidate_set_df` to get the data from `top_artists_candidate_set_df` and `top_artists_candidate_set_df` to get the data from `top_artists_candidate_set_df` and `top_artists_candidate_set_df` to get the data from `top_artists_candidate_set_df` and `top_artists_candidate_set_df` to get the data from `top_artists_candidate_set_df` and `top_artists_candidate_", "reference": "We should make this a docstring, so that editors are able to pick it up." }, { "prediction": "I don't think we need this test.", "reference": "Put a comma after the last parameter of a multiline method call." }, { "prediction": "I don't think we should remove this line.", "reference": "App cache size is now managed dynamically by the `WebView`. This statement has no effect in the new framework." }, { "prediction": "I don't think we need to check for `img` or `input` or `area`?", "reference": "VirtualNode has a `hasAttr` function, any reason why you're not using it?" }, { "prediction": "I don't think we need to remove this line.", "reference": "This now throws when running tests (maybe the move to java 11??). Do we want to keep it?" }, { "prediction": "I think this should be `if len(sha1) > 7 { return sha1[:7] }`", "reference": "We can allow 7-char SHA, does not mean we want to show with 7-char in default, please change to `if len() > 10`, then cut." }, { "prediction": "I don't think we need to add new files to upload folder.", "reference": "this one should also have quotes i guess :)" }, { "prediction": "I'm not sure if this is the right place for this test, but I'm not sure if it's the right place for this test.", "reference": "Using the variable on range scope `mock` in function literal (from `scopelint`)" }, { "prediction": "I don't think we need to change this line.", "reference": "does this result in a 200 when the dataset is still inprogress/publishing not yet finalized? Seems like 202 is the right code for that (as it was) and the test should be watching for a 202?" }, { "prediction": "I think this should be `OrderPath` instead of `OrderPath`", "reference": "Previously you could only order by the field you were searching by. But for full-text search, you can search across all indexed fields, and it didn't make sense not to have a sorting. For backward compatibility, the javascript code uses indexPath as the orderPath when no orderPath is provided." }, { "prediction": "I don't think this is needed.", "reference": "VIM didn't like your whitespace." }, { "prediction": "I don't think this is needed anymore.", "reference": "Are you sure the namespace should change?" }, { "prediction": "I don't think this is needed anymore.", "reference": "@martijn00 I'm not sure why we're keeping the object parameter and return type since this can be done by using MvxApplication with THint set to object" }, { "prediction": "I don't think this is needed.", "reference": "why do we create a time type here?" }, { "prediction": "I don't think we need to use `css!components/listview/listview`", "reference": "Does this style actually need to get loaded in all of these components?" }, { "prediction": "I don't think this is needed anymore.", "reference": "import but not used so you did not resolve compile warnings?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This is so much more concise and beautiful than the previous formula" }, { "prediction": "I don't think this is needed.", "reference": "Is there any reason not to have the `static` modifier for the logger? _(that would be in keeping with the reference being uppercase)_" }, { "prediction": "I'm not sure if this is the right place for this interface, but I think it's better to move it to the `Connection` interface.", "reference": "It's not about session creation config. It's about passing consumer config parameters to underlying transport - nothing to do with session itself" }, { "prediction": "I'm not sure if we should change this to `overrideEnableDebug` or `overrideEnableDebug`", "reference": "Why is there an \"enable\" in the param name? Couldn't it just be `overrideDebug`? Here are everywhere else." }, { "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body beginning.", "reference": "`published.recently_published_first` reads a little oddly to me. Is this the same thing as `Video.published.ordered`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Encountered this because I had a stray comma. Figured I'd tweak it a bit." }, { "prediction": "I'm not sure if this is the right place to test this.", "reference": "qq: Should this include the iptables6-save sim. to the inverse checks above?" }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it.", "reference": "im open to explicitly checking NotSet value here but json logic already handles it so kept it this way." }, { "prediction": "I don't think this is needed.", "reference": "The naming of the include file appears to be unlucky." }, { "prediction": "I think this should be `self.legend_opts.update(**leg_spec)`", "reference": "Bit worried about this. At minimum you should make a copy of the dict here to avoid modifying a user supplied variable." }, { "prediction": "I don't think we need to do this. I'm not sure if we need to do this, but I'm not sure if we need to do this.", "reference": "Is it better to create one before pruning? In case creation fails we don't want to delete the previous one. We create a new one, it is tagged as latest, so the previous can be deleted. `CreateLaunchTemplateVersion` returns the version created, how about directly trying to delete the previous version? Assuming the numbering is strictly increasing." }, { "prediction": "I don't think this is needed anymore.", "reference": "Do we require the specific implementation information here?" }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "How about `exists?(['domain ~*?', domain.downcase])`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "Is this getting used in other places? Can we switch all the places to use the new API you added?" }, { "prediction": "I'm not sure why this was removed.", "reference": "This need to be checked with linux. AFAIK, we have this file in our bin directory that is a link to the system file." }, { "prediction": "I don't think this is needed.", "reference": "Shouldn't we import `default`? I can't get here to test." }, { "prediction": "I'm not sure if this is the right place to use `run_server` or `run_server`", "reference": "!!!!!!!!!!!!! @graingert, does this mean that tests haven't been running???" }, { "prediction": "I don't think we need to change this.", "reference": "I've already tried the null-coalescing operator here and got a strange error, so did this the old-fashioned way." }, { "prediction": "I don't think we need to check for `isListRole` here. I think it's better to check for `isListRole` here.", "reference": "This doesn't follow our spacing convention. It's also a little hard to read. Can you reformat?" }, { "prediction": "I'm not sure if this is a breaking change or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, it's a breaking change, or if it's a breaking change, or if it's a breaking change, it's a breaking change, or if it's a breaking change, it's a breaking change, or if it's a breaking change, it's a breaking change, or if it's a breaking change, it's a breaking change, or if it's a breaking change, or if it's a breaking change, it's a breaking change.", "reference": "The deploy should come before template? EDIT: I see that in other files, we put a separate line and put deploy at the end. What is the reason for this?" }, { "prediction": "I don't think we need this config anymore.", "reference": "Consider making a constant (e.g. `MetricStreamConfiguration.Drop`)." }, { "prediction": "I don't think this is needed anymore.", "reference": "same question: why not just switch this to range too?" }, { "prediction": "I think this should be `const std::string type(m_IO->InquireVariableType(name));`", "reference": "@chuckatkins most places used an empty string for \"no type\", but a few used `\"unknown\"`. I've converted both cases to `Type::None`. Do you know why there was a distinction before?" }, { "prediction": "I don't think this is needed.", "reference": "should we assert for the type for `FeatureGroupData`? I think it should be 1-Byte type." }, { "prediction": "I'm not sure why this change is needed, but I'm not sure why it's needed.", "reference": "As long as you are sure this is definitely correct now... :-)" }, { "prediction": "I don't think this is the right place for this. I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.", "reference": "... so that all action buttons have the same height :-)" }, { "prediction": "I don't think this is needed.", "reference": "Use correct, alpha sorted, include order. Correct order means: 1. Header corresponding to this source (i.e. `\"LatencyTestPublisher.hpp\"`) 2. C system headers 3. C++ system headers 4. Alpha-sorted external libraries headers 5. Alpha-sorted public headers from this project 6. Alpha-sorted private headers" }, { "prediction": "I'm not sure if this is the right thing to do here. I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do.", "reference": "I hate this name, open to suggestions." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it.", "reference": "Does this log line work? We need Warningf or just warning without the format string." }, { "prediction": "I think this should be `c.MetricsProcessors...`", "reference": "The pull controller would need similar updates." }, { "prediction": "I don't think we need this file anymore.", "reference": "ignore this.. just didn't want to litter with a commit update to satisfy license plugin" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Is this definition needed since it doesn't look like it's being used anywhere?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Can this condition be reworded using `if` please?" }, { "prediction": "I don't think we need to check if `inputs!= nullptr &&!inputs->hasData()`", "reference": "after ||, no need inputs!= nullptr" }, { "prediction": "I'm not sure if this should be `AppInStage` or `AppInPipelineStage`", "reference": "Is it just preference or on purpose that using slice of structs instead of slice of pointers?" }, { "prediction": "I don't think we need to check if oldDom is null or not.", "reference": "This line always confused me anyway. Good catch!" }, { "prediction": "I'm not sure if this is the right place to call `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown()` or `Shutdown", "reference": "Should we add `ctx` to `BlockServer.Shutdown()` for this purpose? Would be nice, but I don't care too much." }, { "prediction": "I don't think this is needed.", "reference": "Duration_t at RTPS level must be serialized using fractions." }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "\"peer\" has its own meaning within YARPC with its own class of objects. This should probably be \"dispatcher\" too?" }, { "prediction": "I don't think this is needed.", "reference": "I do not like this line break before `=true`. Maybe starting the list in the next line would help to reduce the indent? This way we could keep this string together." }, { "prediction": "I don't think we need this anymore.", "reference": "_plugins should be removed too" }, { "prediction": "`nn === 'img' || nn === 'input' || nn === 'area`", "reference": "The rule selector will not include `` and `` elements. Why not make this a new, separate rule altogether?" }, { "prediction": "I'm not sure if this is the right place to handle the `UnsupportedError` exception.", "reference": "@The-Compiler Is this style okay or would you prefer a common userscript exception base?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "we'd need to return a MongooseBuffer here instead of the Binary. lets add the subtype option to the buffer schema type as referenced in #1000 instead." }, { "prediction": "I'm not sure if we are providing a selector or document. If we are not providing a selector or document, then we should return an error.", "reference": "Let's remove this change." }, { "prediction": "I don't think we need this.", "reference": "Could you split this into multiple lines?" }, { "prediction": "I don't think this is needed.", "reference": "This technically works, however it may be safer to use both `getCurrentReferenceURL` and `getCurrentEntityURL` and then make this condition `currentReferenceURL === currentEntityURL`. Currently, this code only works based on the internals of `getCurrentReferenceURL`, so by checking both we would decouple that." }, { "prediction": "I'm not sure if we should change this to `respMsg = fmt.Sprintf(\"Response code: %d, response body: %s\", resp.StatusCode, string(body))` or `respMsg = fmt.Sprintf(\"Response code: %d, response body: %s\", resp.StatusCode, string(body))`", "reference": "It does not recommend capitalization" }, { "prediction": "I'm not sure if this is the right thing to do here. I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do.", "reference": "Minor thing, but can you use 1.9 hash syntax for this?" }, { "prediction": "I don't think this is needed.", "reference": "I tried to follow the code structure already present." }, { "prediction": "I think this should be `throw new IOException(\"Could not transfer all bytes of \" + from.toPath());` or `throw new IOException(\"Could not transfer all bytes of \" + from.toPath());`", "reference": "seems reasonable to also want to include the 'to' location?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Please leave 1 space char between commas here and other places in this PR." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "hm is this really &&? Not ||? Was it initially correct if any of these things are not set that it needs to recreated?" }, { "prediction": "I think this should be `cli.hasOption(\"collections\") || cli.hasOption('u')`", "reference": "Please don't use C-style array declarations. IMO our pre-commit ought to be enhanced to not allow this" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or not.", "reference": "@rhc54 This doesn't look like a comprehensive comparison. For `PMIX_STRING` we seem to actually compare the content of the data while here we only compare meta-information which doesn't ensure that values are the same." }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if this is a good idea or if it's a good idea.", "reference": "I think `bypass_frontier_confirmation` conveys the intention better (default false as well)" }, { "prediction": "I don't think this is needed anymore.", "reference": "This looks like it goes beyond the scope of removing `BlockHeight()`, in the future please do this in a separate commit at a minimum -- separate PR is fine too." }, { "prediction": "I don't think this is needed.", "reference": "You'll also need to adjust `FakeWebTabAudio` in `tests/helpers/stubs.py`." }, { "prediction": "I don't think we need to remove this file.", "reference": "@csrwng what should we do here? This one is from origin." }, { "prediction": "I don't think this is needed.", "reference": "Follow alphabetical order." }, { "prediction": "I don't think this is needed.", "reference": "As far as I can tell, these always get and set the context as an `IReadOnlyDictionary`. Can we use that here instead of `object` and get rid of the `as IReadOnlyDictionary`?" }, { "prediction": "I'm not sure if this is the right place to use `html.escape(self._opt.text)` or `html.escape(self._opt.text)` or `html.escape(self._opt.text)` or `html.escape(self._opt.text)` or `html.escape(self._opt.text)` or `html.escape(self._opt.text)` or `html.escape(self._opt.text)` or `html.escape(self._opt.text)` or `html.escape(self._opt.text)` or `html.escape(self._opt.text)` or `html.escape(self._opt.text)` or `html.escape(self._opt.text)`", "reference": "As you only have `{}` as the format string (without anything else in it), this is the same as doing `self._doc.setHtml(html.escape(self._opt.text))`" }, { "prediction": "I think this should be `azkaban.security.credential.name`", "reference": "Where would this be configured? In azkaban.properties?" }, { "prediction": "I don't think this is needed.", "reference": "1. Use `const` instead of `var` here. 2. Move the check to after the `if (update == null || typeof update!== 'object')`." }, { "prediction": "I don't think this is needed. The kernel overhead of an eventfd file descriptor is much lower than that of a pipe, and only one file descriptor is required. The kernel overhead of an eventfd file descriptor is much lower than that of a pipe, and only one file descriptor is required. The kernel overhead of an eventfd file descriptor is much lower than that of a pipe, and only one file descriptor is required. The kernel overhead of an eventfd file descriptor is much lower than that of a pipe, and only one file descriptor is required. The kernel overhead of an eventfd file descriptor is much lower than that of a pipe, and only one file descriptor is required.", "reference": "Let's assume that on Linux `eventfd` is always available as a wrapper of the eventfd2 system call. It is supported since linux 2.6.27 + glibc 2.9, as well as from the ancient versions of bionic. In other words, it would be fair to argue that the pair would be available on practically all platforms that provide `pipe2`. Therefore switching from using `pipe2` to `eventfd` on linux unconditionally would not cause issues on our users." }, { "prediction": "I don't think we need to create a new DBCStatistics object. I don't think we need to create a new DBCStatistics object. I think we should create a new DBCStatistics object and pass it to the constructor.", "reference": "This field could be `final`." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it.", "reference": "would be good to have a test for the case when `shutdown!` raises" }, { "prediction": "I think this should be `if (CmpCommon::getDefault(HBASE_ASYNC_OPERATIONS) == DF_ON && t == ComTdbHbaseAccess::INSERT_ && t == ComTdbHbaseAccess::INSERT_ && t == ComTdbHbaseAccess::INSERT_ && t == ComTdbHbaseAccess::INSERT_ && t == ComTdbHbaseAccess::INSERT_ && t == ComTdbHbaseAccess::INSERT_ && t == ComTdbHbaseAccess::INSERT_ && t == ComTdbHbaseAccess::INSERT_ && t == ComTdbHbaseAccess::INSERT_ && t == ComTdbHbaseAccess::INSERT_ && t == ComTdbHbaseAccess::INSERT_ && t == ComTdbHbaseAccess::INSERT_ && t == ComTdbHbaseAccess::INSERT_ && t == ComTdbHbaseHbaseAccess::INSERT_)`", "reference": "Does upsert pass this check also?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Apologies reviewers, I did end up pushing another change. I was starting to request SRE-P help to get the apiserver configs from some clusters before and after when I realized I can just log the stdout from the patch command to see if anything was changed or not. Much simpler to verify if my work did or did not make changes to the config during the transition. Also got the spacing issue you mentioned @abhinavdahiya Thanks all." }, { "prediction": "I'm not sure if this is a good idea. I think it's a good idea to rename this to `_kbfs_config.go` or `_kbfs_config.go` or something like that.", "reference": "I'm not sure this naming is a good idea; that's the format for macOS xattr metadata files on unsupported filesystems." }, { "prediction": "Line is too long. [89/80]", "reference": "Metrics/LineLength: Line is too long. [85/80]" }, { "prediction": "I don't think this is needed anymore.", "reference": "Please remove these imports. The project's style is to use `Assert.assertEquals` and not import static methods in general. This also caused a lot of unnecessary changes." }, { "prediction": "I don't think this is the right place to do this.", "reference": "thanks. Note that returning at this point might leak memory from the allocations above, so the PR will need to take care of that too." }, { "prediction": "I think this should be `self.config_state_before_fullscreen = config.val.content.desktop_fullscreen or self.config_state_before_fullscreen`", "reference": "If you really want to rename this, you'll also need to adjust the name in `__init__` and in other places it's used (`browser/commands.py`)." }, { "prediction": "I don't think we need this anymore.", "reference": "As discussed at standup, I gave up on this. Calling `DeleteMapLayerMetadataCommand` felt cleaner anyway because there might be other cleanup that needs to happen. @scolapasta and @matthew-a-dunlap plan to discuss this." }, { "prediction": "I'm not sure about this, but I think it's better to use `fmt.Printf(\"EXP:%+v\\n\", objExp.GetObject())` instead of `fmt.Errorf(\"unexpected difference between actions: %s\", pretty.Diff(objExp.GetObject(), objAct.GetObject()))` or `fmt.Printf(\"unexpected difference between actions: %s\", pretty.Diff(objExp.GetObject(), objAct.GetObject()))` or `fmt.Printf(\"unexpected difference between actions: %s\", pretty.Diff(objExp.GetObject(), objAct.GetObject()))` or `fmt.Printf(\"unexpected difference between actions: %s\", pretty.Diff(objExp.GetObject(), objAct.GetObject()))`", "reference": "Do we need these changes? If so, can you tidy up the messages? Looks like it might have been your testing/debugging changes" }, { "prediction": "I don't think we need this.", "reference": "where is the default being set?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "these changes should likely be in the next commit instead" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Since you have defined this struct, I would suggest to replace all exist literal structs by this." }, { "prediction": "I don't think this is needed.", "reference": "The field name doesn't really capture what this option does. I think `mConfirmDiscardMessage` would be a better choice." }, { "prediction": "I think this should be `if (!is_string($media->getBinaryContent())) { throw new \\RuntimeException(sprintf( 'Invalid data provided for binary content, choose among: string, %s, %s', 'Symfony\\Component\\HttpFoundation\\File\\File', 'Symfony\\Component\\HttpFoundation\\Request', 'Symfony\\Component\\HttpFoundation\\Request', 'Symfony\\Component\\HttpFoundation\\File', 'Symfony\\Component\\HttpFoundation\\Request', 'Symfony\\Component\\HttpFoundation\\Request', 'Symfony\\Component\\HttpFoundation\\Request', 'Symfony\\Component\\HttpFoundation\\Request', 'Symfony\\Component\\HttpFoundation\\Request', 'Symfony\\Component\\HttpFoundation\\Request', 'Symfony\\Component\\HttpFoundation\\Request', 'Symfony\\Component\\HttpFoundation\\Request', 'Symfony\\Component\\HttpFoundation\\Request', 'Symfony\\Component\\HttpFoundation\\Request', 'Symfony\\Component\\HttpFoundation\\Request', 'Symfony\\Component\\HttpFoundation\\", "reference": "what if `$media->getBinaryContent() == Symfony\\Component\\HttpFoundation\\File\\File` does `is_string()` return `true`? ping @greg0ire" }, { "prediction": "I don't think this is needed anymore.", "reference": "maybe rather than `bool` make this field a `StructDef *`?" }, { "prediction": "I'm not sure if this is the right way to do this. I'm not sure if this is the right way to do this, but I'm not sure if it's the right way to do it.", "reference": "Shall we maybe put this in a `const` like `backgroundTaskTimeout`?" }, { "prediction": "I don't think we need to catch this exception.", "reference": "CI is complaining about this." }, { "prediction": "I think this method should be renamed to `calculateRemovalTime`", "reference": "Let's only change a file if it is really necessary. Such a change does not bring much value and makes it harder to find the original commit in which the method was introduced." }, { "prediction": "I think this should be `$useLazyLoading = array_key_exists('lazy', $attributes)? (bool)$attributes['lazy'] : true;`", "reference": "I would prefer to set up space between classes in format pattern, `%s %s` and then use `trim()` to remove unnecessary whitespaces. This will also solve stripping whitespaces from the beginning and end of a string `$attributes['class']`" }, { "prediction": "I think this should be `LOG(ERROR) << \"unknown setence type[\" << sentence_->getType() <<\"]\";`", "reference": "when Op is illegal should return here?" }, { "prediction": "I think we should remove the `versionKey` from the `installedVersions` array.", "reference": "don't we need to remove the project version from installedVersions?" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if it's the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "This is intended. Pls revert this." }, { "prediction": "I'm not sure if this is the correct behavior.", "reference": "Something wrong with cast to `(Comparator<> & Serializable)`, need to be investigated" }, { "prediction": "I'm not sure why this was removed.", "reference": "I think we need this. Not sure, I'll test." }, { "prediction": "I don't think we need this anymore.", "reference": "I'm going to need to check if google compute requires these steps in this order, or if you can disable iptables after the fact." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, it's the right place to do it.", "reference": "Did go change their tags with the new version?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I don't recall what we decided here in terms of which source would get priority. As written, the static configuration will overwrite datastore results." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I think it should still panic for when there are no outputs; might be nice to special-case that though so the message is more explicit." }, { "prediction": "I don't think we need to create a new `MetricsConfigBuilder` for the `MetricsConfigBuilder` class.", "reference": "*NULL_DEREFERENCE:* object `null` is dereferenced by call to `meterSupplier(...)` at line 122." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea, but I'm not sure if it's a good idea or if it's a good idea.", "reference": "switch over to.mode" }, { "prediction": "I don't think we need to change this test.", "reference": "I guess your IDE did some auto-fixing here" }, { "prediction": "I don't think this is needed anymore.", "reference": "This is an unused import failing recommit still." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I'm concerned that we're conflating multiple things here. There are 2 things that Beaker should really care about: - Network transport - i.e. `ssh` vs `winrm` - Interpreter - i.e. `bash`, `cmd`, `powershell`, etc The problem is that @cowofevil is running Bitvise SSH, and he assumed we should be setting `is_cygwin: false` in node definitions. But that doesn't really accurately convey what we care about, and since Beaker doesn't appear to track network transport apart from interpreter, we end up in a strange state. `is_cygwin: false` appears to end up setting `is_powershell?` to `true`, which IMHO is not accurate or appropriate. Bitvise templates use `ssh` (like Cygwin), but the interpreter used is `cmd`, not `powershell`." }, { "prediction": "I don't think we need to change this to `role=\"dialog\" role=\"dialog\" aria-label=\"<%=_(\"Missing Fields Alert\")%>\" style=\"display:none\">`", "reference": "I think this is ok for now. This ties into the larger issue of the site not having a consistent method for relaying form input errors. Please make sure the focus gets set on the close button when the dialog opens." }, { "prediction": "The plugin uses GhostTable and SamplesGenerator for calculations. The plugin uses GhostTable and SamplesGenerator for calculations. The plugin uses GhostTable and SamplesGenerator for calculations.", "reference": "Should these link be removed?" }, { "prediction": "`add_undo=True` should be `True`", "reference": "Please make this a keyword-only argument by adding a `*` argument before `add_undo`." }, { "prediction": "I don't think this is needed.", "reference": "didn't quite follow what this code block is doing." }, { "prediction": "I think this should be `onWindowKeyDown` instead of `onWindowKeyDown`.", "reference": "this doesn't sound pretty... I would rather we have a proper navigation for all modes - AFAIK TV remote navigation is very similar to normal keyboard, but maybe it just uses another key codes - those should be extracted in a single file and defined there depending on context then" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "After diffing the children we check whether the value got out of sync, if it did we update it. We also update the `_prevValue` to prepare for the next event hitting our controlled component" }, { "prediction": "I'm not sure if this is the right place to start a Bee node. I'm not sure if it's the right place to start a Bee node, but if it's the right place to start a Bee node, I'm not sure if it's the right place to start a Bee node. If it's the right place to start a Bee node, I'm not sure if it's the right place to start a Bee node. If it's the right place to start a Bee node, I'm not sure if it's the right place to start a Bee node.", "reference": "It provides a type called Node which is a fully functional bee client. This package is where the dependencies are injected. It is not just a glue-code, it is concept of node." }, { "prediction": "I'm not sure if this is a good idea. I think it's a good idea to add a `download-directory` option to the `config.py` file.", "reference": "I think this will change `''` to `'%'` unconditionally, i.e. there'll be no way to set `''` anymore. This should really only be used for values which make no sense anymore." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to return the row key.", "reference": "Nit: this table's row key map -> this table's row keys map" }, { "prediction": "I think this should be `PJ_LOG_ERROR`", "reference": "this change should be reverted" }, { "prediction": "I don't think this is needed.", "reference": "I'm a bit confused about the `os.path.dirname(basedir)` here - is this just to get to the parent directory? Either way, I think I'd prefer just having this in `update_version.py` as it's not needed in qutebrowser itself." }, { "prediction": "I'm not sure if this is the right fix.", "reference": "Revert this change and see below why..." }, { "prediction": "I don't think we need this anymore.", "reference": "Should not switch to `lvis_v1_instance` here because that base config uses ClassBalancedDataset to oversample the data." }, { "prediction": "I'm not sure if this is the best way to do this, but I think it's better to use `logger.info(String.format(\"Adding %s %d times\", caps, info.getMaximumSimultaneousSessions())))` instead of `logger.info(String.format(\"Adding %s %d times\", caps, info.getMaximumSimultaneousSessions())))`", "reference": "This is an informational message that allows someone to read the console output and understand how the grid node is configured. Please leave." }, { "prediction": "I'm not sure if this is the right place to call this function.", "reference": "This doesn't make sense to me. What does RaiseSingleton mean? To me it sounds like a single object is being.. raised? Not sure." }, { "prediction": "I don't think this is needed.", "reference": "What's the benefit of having jobExecutorTests as a member variable? What do you think about making the method static? Afterall, it is a stateless method." }, { "prediction": "I'm not sure if this is the right place to check metadata objects. I think it's better to check metadata objects and their associated blocks for errors.", "reference": "This looks like it's only downloading things, not really checking their true validity. Especially for the MD object. Should we call `BareRootMetadata.IsValidAndSigned()` in `mdGet`?" }, { "prediction": "I don't think we need to do this in the `image_data_reader.cpp` file.", "reference": "Nikoli, I believe that this addresses your concern. One question for you or Jae-Seung is if any allocation from the clone is properly cleaned up when the vector is destroyed. I believe that it should." }, { "prediction": "I'm not sure if this is the right thing to do. I'm not sure if it's the right thing to do.", "reference": "should be `ECSApp`" }, { "prediction": "I think this should be `return self.size.copy()`", "reference": "flake8 is going to fail on this having 2 lines" }, { "prediction": "I don't think we need this anymore.", "reference": "should we make a dir named controllers/scheduler/podchaos" }, { "prediction": "I'm not sure if we should change this to `hostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname` or `KeyNodeHostname`", "reference": "there seems to be one KeyNode in kubernetes.go of PV.. would it make sense to use it?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Im gonna be a little annoying here but did you configure your linter correctly? This empty line should not be here. Maybe go to settings and check if `goimports` is enabled?" }, { "prediction": "I don't think this is needed.", "reference": "Don't think this belongs in this pr" }, { "prediction": "I don't think this is needed.", "reference": "We can assert on the existence of Outbounds through ClientConfig calls right? Since this is only for tests, do we need this function?" }, { "prediction": "I'm not sure if this is the right way to do it.", "reference": "@martijn00 so this PR introduces a new ViewModel lifecyle method? It isn't in the PR description/any new docs" }, { "prediction": "I'm not sure if this is needed, but I think it's a good idea to add a `input_img_shape` attribute to the transformer_head.", "reference": "Are these modification duplicate? Or should we move it into base detector." }, { "prediction": "I'm not sure why this change is needed.", "reference": "Since this is private and single use it should be un-wrapped inside of the two-arg dagSeed method." }, { "prediction": "I don't think this is needed anymore.", "reference": "why the order change? Also for the next chunk. (I understand the result will be the same though)" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "I wonder if this should just be a single `string`? We don't have any cases where we return different types and it would make the parser simpler to just read a single identifier." }, { "prediction": "I think this should be `inputFiles.get(task.file().path().toString())`", "reference": "I don't think this needs to change. Can you go back to the previous implementation?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Bump it 2 lines higher, 'c' > 'u'." }, { "prediction": "I think this file should be renamed to `parser/AstTypes.h`.", "reference": "Please do not add author here" }, { "prediction": "I don't think this is needed.", "reference": "Similarly, we should be able to persist action uniformly" }, { "prediction": "I'm not sure if this is the right place to put this method. I'm not sure if it's the right place to put it.", "reference": "I think i'd prefer this override to be in the test helper instead, if that's possible?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "This would be better with context added via wrapping or fmt.errorf()" }, { "prediction": "I'm not sure if this is the right place to put this package.", "reference": "What's the purpose of this file?" }, { "prediction": "I'm not sure if this is the right place to set passcodeLength. I think it's better to set passcodeLengthKnown to false and then set passcodeLengthKnown to true.", "reference": "@bhariharan Why was passcode length requirement allowed to be lowered?" }, { "prediction": "I'm not sure about this. I'm not sure if it's a good idea.", "reference": "This file needs a license header, too. Sorry I didn't catch that earlier." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "probably don't need `[:]` why not reference into `github.com/algorand/go-algorand/daemon/algod/api/server/lib` here and skip bouncing off daemon/algod/server.go?" }, { "prediction": "I don't think this is needed.", "reference": "Why reference is converted to table?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "should we implement pagination in the fake datastore so the server startup code that paginates entries for trust domain validation can be tested?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "What mechanism will be exposed so the caller knows they're using the vectorized version?" }, { "prediction": "Layout/SpaceInsideBlockBraces: Space inside { missing.
Layout/SpaceInsideBlockBraces: Space inside } missing.", "reference": "Can we remove respond_to block its not required here" }, { "prediction": "I don't think this is needed anymore.", "reference": "Do not do that even in example, we demonstrate bad practice" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Hm, taking a second look over this, this is why we have the object inheritance structure that we do. This could be divided up by having a custom determine_if_x86_64 in the pswindows/exec hosts and then a default method in hosts.rb. That way all the custom ps windows work is in a single location." }, { "prediction": "I'm not sure if this is the right place for this test. I'm not sure if this is the right place for this test.", "reference": "We have to `.Complete` now because of empty/null string test cases." }, { "prediction": "I'm not sure if this is the right place to do this, but I think it's better to move this line up to the `if options[:recursive] = File.directory?(source) if options[:recursive].nil? && options[:chunk_size] = options[:chunk_size] else if options[:chunk_size] = options[:chunk_size else 16384 result = Result.new(@hostname, [source, target]) options[:chunk_size] = options[:chunk_size] || 16384 result = Result.new(@hostname, [source, target]) options[:chunk_size] = options[:chunk_size] || 16384 result = Result.new(@hostname, [source, target]) options[:chunk_size] = options[:chunk_size] || 16384 result = Result.new(@hostname, [source, target]) options[:chunk_size] = options[:chunk_size] || 16384 result = Result.new(@hostname, [source, target]) options[:chunk_size] = options[:chunk_size] = options[:chunk_size] || 16384 result = Result.new(@hostname, [source, target])", "reference": "Is there still a way to specify no recursion?" }, { "prediction": "I'm not sure if this is the right name for the tool, but if it's the right name for the tool, then it's the right name for the tool. I'm not sure if it's the right name for the tool, but if it's the right name for the tool, then it's the right name for the tool.", "reference": "How is this name being URI safe and being used programmatically related?" }, { "prediction": "I don't think this is needed anymore.", "reference": "I think we have to keep this as a fallback for now, else it's a small breaking change :(" }, { "prediction": "I think this is a breaking change.", "reference": "nit: shouldn't be part of this PR." }, { "prediction": "I'm not sure if this is the correct behavior.", "reference": "this change looks wrong to me. I think the test is trying to signal that something went wrong by throwing the `Error` here, otherwise the `catch` below will swallow it." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it.", "reference": "I'm doubting if this should be `if (_layout.IsThreadAgnostic)`, as ThreadAgnostic stuff could be calculated on every thread. (and thus could be lazy). non-ThreadAgnostic should be calculated on the main thread." }, { "prediction": "I don't think this is needed anymore.", "reference": "Please use only `Logger` instead of `org.slf4j.Logger`" }, { "prediction": "I don't think we need to do this. I don't think we need to do this.", "reference": "Should this be \"no limiter drop\", since this isn't an absolutely essential activity for the stability of the network?" }, { "prediction": "I don't think we need to log the error here.", "reference": "I updated many of the success messages, because most of these operations don't return data if they succeed. This meant many of the operations would print: `Success null` if the script ran successfully." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to raise an error, but if it's a good idea to raise an error, I'm not sure if it's a good idea to raise an error, or if it's a good idea to raise an error if it's not a good idea to raise an error if it's not a good idea to raise an error if it's not a good idea to raise an error if it's not a good idea to raise an error if it's not a good idea to raise an error if it's not a good idea to raise an error if it's not a good idea to raise an error if it's not a good idea to raise an error if it's not a good idea to raise an error if it's not a good idea to raise an error.", "reference": "Could you simply add it to the previous clause?" }, { "prediction": "I think this should be `var procCodeA = a.getAttribute('proccode'); var procCodeB = b.getAttribute('proccode'); if (procCodeA < procCodeB) { return -1; } else if (procCodeA > procCodeB) { return 1; } else { return 0; } else { return procCodeA.localeCompare(procCodeB, undefined, { sensitivity: 'base', numeric: true }); }", "reference": "@joshyrobot, I think you can just use localeCompare with only the first argument and leave the other arguments out (here and all the other lines changed). It seems to do the right thing, and then we don't have to worry about these extra options." }, { "prediction": "I think this should be `if (slaOptions!= null && slaOptions.size() > 0) { exflow.setSlaOptions(slaOptions); } else { exflow.setSlaOptions(slaOptions); }`", "reference": "@chengren311 : where does this logic move to?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Can we have a `nil` exception check at `s.scope.ManagedMachinePool`" }, { "prediction": "I think we should remove the `sort_count` and `sort_alphabetic` from the `Options` class. I think it's better to remove the `sort_count` and `sort_alphabetic` from the `Options` class.", "reference": "Rather than deleting this, should you just reformat it so it's the `*` settings, so if nothing is configured in facets.ini, the existing default behavior continues to work?" }, { "prediction": "I don't think this is needed.", "reference": "wrap, single line" }, { "prediction": "I think this should be `returnType == null || returnType.isEmpty()`.", "reference": "always use brackets for if statements" }, { "prediction": "I don't think this is needed.", "reference": "`NUnitIntegration` doesn't need to cache this anymore." }, { "prediction": "I'm not sure if this is the right thing to do here, but I'm not sure if it's the right thing to do here.", "reference": "Why did you change it to `>=` here?" }, { "prediction": "I think we should move this logic to a separate class.", "reference": "Looks like this needs to be updated. There is no need to remove `hadoop.` if Hadoop tables don't use this code path." }, { "prediction": "I don't think this is needed.", "reference": "This require isn't need anymore, right?" }, { "prediction": "I don't think we need crypto here.", "reference": "a bit weird to see payments crypto package inside connection manager. There probably will be services not having any relation with payments that will use connection manager. Thats why probably ping-ping by itself can be useful without any relation to payments.." }, { "prediction": "I don't think we need to change this.", "reference": "I like the overall idea here, but I wonder if it would be more clear to define the property in the trait, and then set it in the constructors of the classes using the trait. Alternatively, at a bare minimum, it may be a good idea to add `?? 'Bibliographic'` here, to account for the possibility of the trait being used in a class that does not define the property at all." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "I would prefer to not have a magic number, but construct this value out of other constants we already have." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for this, or if it's the right place for it.", "reference": "The limitation is if somebody configure another policy with the same name, but it is an edge case we can ignore I guess." }, { "prediction": "I'm not sure if this is a breaking change or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, I'm not sure what it'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''--'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''", "reference": "? The package is named `hashivault`." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "I don't think this should enable xwayland, because it's convenient to toggle xwayland just by setting `xwayland` to `false`" }, { "prediction": "I'm not sure why this was removed.", "reference": "Remove this line by accident?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Calling `.stream()` on a `DomainObjectCollection` is pretty much always a bug, as it doesn't include objects added later (and encourages people to use afterEvaluate). I wonder if we should make this an error prone check?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Thanks for paying attention to other places this might happen. This one is particularly important; I probably never should have gotten in the habit of CheckErr(), since it does a log.Panic() explicitly, which looks like something else until you look closely. It's supposed to be used places where \"can't happen\" but Things Can Happen." }, { "prediction": "I don't think this is needed.", "reference": "What is the different between nw_tos and ip_dscp? Only high 6 bits vs low 6 bits and supported version?" }, { "prediction": "I think this should be `MolToCXSmiles(*mol)`", "reference": "I'm assuming that asSmarts & cxSmiles == asSmarts" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "Seems like an oversight but I don't think the super would do anything else in this case unless I'm mistaken." }, { "prediction": "I don't think this is needed.", "reference": "Curious, do we consider this as pedantic for example code?" }, { "prediction": "Why not use `strtolower($this->entity['name']), $formType, $formOptions);`?", "reference": "Should we convert the entity name to snake case using `Doctrine\\Common\\Inflector\\Inflector::tableize` or similar? Should a `snaked_name` or whatever be part of the entity metadata in order to use it for form names, ids, & other html attributes?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "Should be `client.outboundIp`" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "Must these `using` statements not go inside the `namespace` block?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "Why? I thought the previous way was idiomatic. (Same with the `MetadataVer` stuff above.)" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "shouldn't we `reject` here instead?" }, { "prediction": "I don't think this is the right place to do this. I'm not sure if it's the right place to do this.", "reference": "check err or use gasPriceUnitIOTX, _ := if we are sure action.Core.GasPrice is correct" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Just curious, was wait not used at all before?" }, { "prediction": "I'm not sure if this is needed.", "reference": "nit: can we remove this?" }, { "prediction": "I think this should be synchronized.", "reference": "is it not a problem when one synchronized function is called by other?" }, { "prediction": "Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line.", "reference": "We (even as admins) shouldn't override the User Preference settings like `email_master`, `email_posts`, `email_kudos`, `email_new_followers`. These all would be set by the user of their choice. Please do remove these attributes from editing//updating. Thanks!" }, { "prediction": "I think this should be `Este :attribute is already attached`", "reference": "\"Este :attribute j est anexado.\" sounds better." }, { "prediction": "I don't think we need to import `frame` and `series` from `databricks.koalas`", "reference": "This line should be repeated for every module that needs testing. One cannot rely on nosetest to automatically discover all the modules. On the bright side, there is no need to change any of the other files." }, { "prediction": "I'm not sure why this was removed.", "reference": "This error was unused" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Personally I wish we didn't have a proto for every single little thing we do. RequestShardAction with an enum for the action type would be a lot cleaner imo, but I'm pretty sure that ship has sailed :) Just kvetching." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but I'm not sure if it's the right place to do it.", "reference": "Does this make more sense as `trails/_trail` now?" }, { "prediction": "I don't think this is the right place to get outpost ARN from the metadata service.", "reference": "synced offline. let's move this to `agent_unix.go` to make the IMDS call, since this is not supported in Windows." }, { "prediction": "I'm not sure if this is the right place to put this mapping.", "reference": "Too much indentation here. Should match the lines above, which have four spaces." }, { "prediction": "I don't think we need this anymore.", "reference": "Same here we still need this test to make sure the fallback works." }, { "prediction": "I don't think this is needed.", "reference": "I'm wondering if we can actually base this on a `IMvxPresentationAttribute` instead of the base one." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "could we switch to `undefined` here?" }, { "prediction": "I don't think we need to call cleanupSyncsSoupIfNeeded here.", "reference": "The cleanup call" }, { "prediction": "I don't think this is the right thing to do here. I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do here.", "reference": "I think \"View artist\" is a bit more standard and expected. Or even \"Go to artist\" to take the Spotify terminology as-is." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but if it's the best way to do it, I'm not sure if it's the best way to do it.", "reference": "It might make sense to refactor this later so that we use a Bolt-native type to hide sensitive values." }, { "prediction": "I think this should be `if __name__ == \"__main__\":`", "reference": "We were trying to move away from this to force people to always run tests under py.test." }, { "prediction": "I think this should be `self._get_firefox_options()`", "reference": "1 - create browser specific options class: - chromeoptions - firefoxoptions - argsoptions" }, { "prediction": "I don't think this is the right fix.", "reference": "should be a case insensitive match though no? DOCTYPE and doctype are both widely used" }, { "prediction": "I'm not sure if this is the right place to put this method. I think it would be better to move this method to `WidgetsController` and use it in the `WidgetsController` class.", "reference": "We must have a `fail ParamNotFound` here for cases where `@account.nil?`." }, { "prediction": "I don't think this is needed.", "reference": "How come this change was needed?" }, { "prediction": "I don't think this is needed.", "reference": "Why are there only 6 pins here, while below it appears to have 8 ADC inputs? Are pin 2 and 5 used for something else on this board?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I think we need an issue to track that chain sync omits BLS messages, and then to fix and test it!" }, { "prediction": "I don't think we should change this to `http://2c429f18.ngrok.io` or `http://2c429f18.ngrok.io` or `http://2c429f18.ngrok.io`", "reference": "what is this default about? I am not using ngrok atm so would prefer an env var." }, { "prediction": "It's recommended to set this value to 'false' in production enviroments.", "reference": "@Samuell1 Might be better to say \"Automatically check for plugin updates on login\"." }, { "prediction": "I don't think this is needed.", "reference": "Thanks for the additional Process helper! Can we also cache the first `Process.GetCurrentProcess()` result in a static field so we don't have to repeatedly call it? It means we would also need to dispose it when the static `_runtimeMetricsWriter` instance is disposed" }, { "prediction": "I'm not sure if this is the right place to test this.", "reference": "just wondering what is the result of breaking the logic we test here? it seems that in that case we will just not return immediately, but i'm not sure whether the test will fail?" }, { "prediction": "I think this should be `os.Mkdir(dir, \"src\")`", "reference": "We should fail the test if this returns `err!= nil`." }, { "prediction": "I'm not sure if we should increment metricProvisionFailedTerminal or not. I'm not sure if we should increment metricProvisionFailedTerminal or not. I think we should increment metricProvisionFailedTerminal or metricProvisionFailedTerminal or metricProvisionFailedTerminal or metricProvisionFailedTerminal or metricProvisionFailedTerminal or metricProvisionFailedTerminal or metricProvisionFailedTerminal or metricProvisionFailedTerminal.", "reference": "What is the drawback of not having this flag as a gating condition to report the metric?" }, { "prediction": "I think this should be `fmt.Printf(\"Graceful stop...\")` or `fmt.Printf(\"Graceful stop...\")`", "reference": "`getProcessName()` will be less ambiguous, since Caddy has \"apps\" that it runs internally." }, { "prediction": "I'm not sure if this is the right place to use DML_ComWrapperRCW or DML_ComWrapperCCW or DML_ComWrapperRCW or DML_ComWrapperCCW.", "reference": "Is there any way to not hardcode this given we know the size in bytes? The public API has the flexibility of being a Span. Should we maybe not do anything printing DML? The runtime allocates the buffer, but it's a \"scratch memory\" area, The delegate gets it passed in and they decide how to use it. Also, how is DML used if the feature is for macOS support?" }, { "prediction": "I don't think this is needed.", "reference": "How about just override the `buildFilter`? Passing another function here is a little weird." }, { "prediction": "Is this just a TestRPM build with all RPMs hydrated?", "reference": "This should just be a `.Bool()` flag I think, we don't encode anything beyond y/n here. See `$(RUN_CHECK)` and `$(STOP_ON_PKG_FAIL)` for examples of how to pass those in." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Is this needed?" }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it. I'm not sure if this is the right way to do it, but I'm not sure if it's the right way to do it, so I'm not sure if it's the right way to do it.", "reference": "This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted." }, { "prediction": "I don't think this is needed.", "reference": "how about moving it under L26" }, { "prediction": "I don't think we need to do this. I'm not sure if we need to do this.", "reference": "I think this needs to be tested" }, { "prediction": "I'm not sure if this is the right place to put it.", "reference": "Style/MutableConstant: Freeze mutable objects assigned to constants." }, { "prediction": "I don't think this is needed anymore.", "reference": "Just a thought, really. If it's a bug that can be probed for (and it can be - see Adrian's repro) then it could as well be a static initialization of a supplier of Deflater instances; if we probe for a buggy JVM, we return the wrapper. If we don't we return the Deflater. This way on non-affected JVMs nothing happens and if we do use the wrapper, we know the JVM is broken." }, { "prediction": "I'm not sure why this change is needed.", "reference": "Looks like this should be publicly accessible for tests in any modules?" }, { "prediction": "I don't think this is needed.", "reference": "Allow putenv is necessary to be able to get environment variables with `getenv`?" }, { "prediction": "I don't think this is needed.", "reference": "use function to check it. - don't do everything in main" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use global_configs.", "reference": "Sorry I'm confused. Why not kwarg this like the others?" }, { "prediction": "I'm not sure if this is the right fix.", "reference": "First, any changes here should be synchronized with instr_compute_VSIB_index(). Second, the original looks correct to me: the first letter of the opcode name suffix is the index size, while the second is the memory size. So \"vpgatherdq\" is a d-sized index and q-sized memory. The operand size we store for memory accesses is always the memory size, not the address size, and for VSIB we store a single memory element size. It looks like we have no inside-opnd_t storage of the index size: that's done by dispatch on opcode it seems. I have a bunch of notes of discussions on how to handle VSIB: we decided to bail on encoding too much inside the opnd_t I guess." }, { "prediction": "I think this should be `build_tracking_url` instead of `build_tracking_url`.", "reference": "Sorry for going back and forth. Adding docstring here would be very helpful for others to understand the need of this method." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or not.", "reference": "You introduced a bug here." }, { "prediction": "I don't think we need to do this.", "reference": "Should we log a warning/error if only one is specified and not the other?" }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if it's the right way to do this.", "reference": "`ctx` is unused in GetLatestEvent" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This looks good to me. Personally, I would have the following for maximum flexibility: * convert peering_port from uint64_t to int. * Set the default value to \"-1\" to specify the value is not set * if the value is -1 then do `config.node.peering_port = network_params.network.default_node_port` That would allow for 0 to mean, select the port number yourself and be more consistent. But I am happy with the change as is, as well." }, { "prediction": "I'm not sure if this is a good idea, but I think it's worthwhile to remove the `rescale` method from the `ImageTransform` class. I think it's worthwhile to remove the `rescale` method from the `ImageTransform` class.", "reference": "The blank line between the summary and detailed description is better to be kept." }, { "prediction": "I'm not sure if this is the right place to remove unused shapes. I'm not sure if it's the right place to remove unused shapes. I'm not sure if it's the right place to remove unused shapes, but if it's the right place to remove unused shapes, I'm not sure if it's the right place to remove unused shapes.", "reference": "Curiously, are these indents intended or should they be aligned?" }, { "prediction": "I don't think we need to check for `roleText` here.", "reference": "What if we changed this to this? roleText=attrs.get('roleText', lambda:getSpeechTextForProperties(reason=reason,role=role)) That will prevent the function from ever needing called in the roletext case, and removes that if." }, { "prediction": "I'm not sure about this, but I'm not sure if this is the right thing to do. I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do.", "reference": "This will still result in a safe_read_tls_magic on AMD in tls_thread_preinit()." }, { "prediction": "I'm not sure if this test is related to this PR.", "reference": "Can you remove this change?" }, { "prediction": "I'm not sure if this is the right fix.", "reference": "Oh, was that a bug in the validation?" }, { "prediction": "I don't think we need to check for `subscribeonandroid.com/` here. I think we should check for `subscribeonandroid.com/` instead.", "reference": "Please use the Google java code style. Basically, add more space characters like in the statements below. Next to method arguments and curly braces. This is currently not checked on CI because it is too inconsistent in the code base but I would prefer new code to be consistent." }, { "prediction": "I'm not sure if this is the right place to delete `val1` and `val2`", "reference": "Actually, I don't think we need to create object on heap." }, { "prediction": "I think this should be `\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\", "reference": "this is a file we copy from gRPC, sp ideally it be fixed upstream as well.." }, { "prediction": "I don't think we need this anymore.", "reference": "changes like this, just strangle guava usages to be replaced by DelayLimiter into one place" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for this, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it.", "reference": "PropTypes need to be updated accordingly here. Note that the type also needs updating, not just the case. That is, these should both expect a `PropTypes.elementType` now instead of an `element`." }, { "prediction": "I'm not sure if this is the right thing to do here, but I think it's better to check if the resource_group_id_name is not zero.", "reference": "maybe extra paren around `strncmp(...)!= 0`" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "We should call `Windows.onResume `: - When the app is launched for the first time - When the app is resumed after being paused (home button and resume or device goes to sleep) - After a permission prompt is displayed" }, { "prediction": "I think this class should be `BftForksSchedule>` instead of `BftForksSchedule>`", "reference": "Rename to ForksSchedule? Maybe in separate PR." }, { "prediction": "I don't think this is needed anymore.", "reference": "Why a blank line here?" }, { "prediction": "I don't think we need this method anymore.", "reference": "I have a sense that this will actually eventually change to check the actual date so that subscriptions can be deactivated in the future. But I mention that here just to keep you in the loop. We should not make that change now, because it's not needed functionality." }, { "prediction": "I think this should be `if (argSpec.isOption()) { return null; // skip default for positional params } else if (argSpec.isOption()) { return null; // skip default for positional params } else if (argSpec.isOption()) { return null; // skip default for positional params } else if (argSpec.isOption()) { return null; // skip default for positional params } else { return null; // skip default for positional params } else { return null; // skip default for positional params } else { return null; // skip default for positional params }", "reference": "What is the reasoning for using the negation of `isOption()` instead of simply using `isPositional()` to identify a positional param?" }, { "prediction": "I don't think this is the right place to send basic data. I'm not sure if this is the right place to send basic data, but if it's the right place to send basic data, then it's the right place to send basic data. If it's the right place to send basic data, then it's the right place to send basic data. If it's the right place to send basic data, then it's the right place to send basic data. If it's the right place to send basic data, then it's the right place to send basic data. If it's the right place to send basic data, then it's the right place to send basic data. If it's the right place to send basic data, then it's the right place to send basic data. If it's the right place to send basic data, then it's the right place to send basic data. If it's the right place to send basic data, then it's the right place to send basic data. If it's the right place to send basic data, then it's the right place to send basic data.", "reference": "Why would you add those if client version min is set to 1100?" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "You can delete this, it will now need to live in `gointerfaces` package" }, { "prediction": "Line is too long. [89/80]", "reference": "Okay, I still don't understand why you have to add `html_safe` here, and it still seems like a very bad idea. It will allow html tags in the title, and keep Rails from escaping literal greater-than or less-than chars not intended as HTML tags. It ought to work to just let Rails do HTML-escaing as normal, without any manual `html_safe` or `strip_tags` or whatever. I am not clear on what problem you are trying to solve, why the straightfoward approach does not work." }, { "prediction": "I think this should be `mActionBarSubject.showSubjectInMessageHeader()`", "reference": "What is is subject when it's not the email subject. Why are we having to do this crap? What's calling this with an empty string?" }, { "prediction": "I think this should be `AlwaysSample` instead of `AlwaysSample`.", "reference": "Could you also remove the `defaultSamplingProbability` constant from `sampling.go`? It seems to became unused with this change." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "can you delete the `generateDeploymentStrategicPatch` function as well?" }, { "prediction": "I think this should be `LOG.info(String.format(\"Connecting to %s and %s\", publishConnection, subscribeConnection));`", "reference": "I'd keep this at `info` level..." }, { "prediction": "I think this check should be done in a separate PR.", "reference": "Don't use DCHECK to debug your code if it's the regular branch you need to handle." }, { "prediction": "I'm not sure why this was removed.", "reference": "You should return null here instead. Null is an acceptable default value for the image attribute." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "react bails as well?" }, { "prediction": "I don't think we need this anymore.", "reference": "Can you please tell me why you did this?" }, { "prediction": "I don't think we need to do this. I'm not sure if we need to do this.", "reference": "Reading this again it should prob prefer the `videoConstraints.facingMode` value over `facingMode` if the former was already set" }, { "prediction": "I don't think this belongs_to is necessary.", "reference": "There's a good bit of class-level stuff that's repeated in our various product types. Think it's worth extracting a...dare I say it...module?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Please do not modify the `config.Target` field, it should contain exactly what is extracted from the JSON files. Instead, you can either: * Add a getter to the `config` variable (`*compileopts.Config`), so you can simply call `config.WasmAbi()` to get the value. * Use a local variable instead. The getter would be slightly cleaner, as it matches the pattern of other configurations (`CGO_ENABLED`, `GC`, `NeedsStackObjects`, etc)." }, { "prediction": "I'm not sure if this is the right place to start the test.", "reference": "The nil check is not necessary for these. Append checks both sides for nil." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "Shouldn't we instead have the SDK apply these, internally? I.e., I would expect to see the dctx entries included in the span as first-class distributed correlations, not as span attributes." }, { "prediction": "I'm not sure if this is the right place to call `GetTopolo` or `SearchTopology`. I'm not sure if this is the right place to call `GetTopolo` or `SearchTopology` or `SearchTopologyResponse`.", "reference": "nit: rename this in proto and update impl to `Search` to avoid stutter" }, { "prediction": "I think this should be `$this->adminDomainTabsFacade->getSelectedDomainId()` instead of `$this->adminDomainTabsFacade->getSelectedDomainId()`", "reference": "is it necessary to order by id as a second ordering? this will take place only when several new slider items are created without reordering (position is then null). Wouldn't be better to recalculate position after creating a new item? (right now items with null in position behave differently in administration and on frontend)" }, { "prediction": "I don't think we need to change this?", "reference": "`ClaimFromRewardingFundBaseGas` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "How about modifying the NOGIL definition so that it only does anything if the thread safety flag (RDK_BUILD_THREADSAFE_SSS) is set?" }, { "prediction": "I don't think we need this interface.", "reference": "blockheighter would be more clear" }, { "prediction": "I think this should be `Status::OK()`.", "reference": "This is so weird as a utility function." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Why? What would happen if you did not?" }, { "prediction": "I don't think we need to check if `o!= null` here.", "reference": "Unrelated bugfix for NPE." }, { "prediction": "I don't think we should change this. I think we should change this to `isWritable` instead of `isWritable`", "reference": "What if some extended the `AdminController` and had a check for the old option name? Could that be a valid use case?" }, { "prediction": "I think we should move this to the `fetchSegmentMap` method. I think we should move this to the `fetchSegmentMap` method.", "reference": "This will be only available when data-manager is enabled, is there a fallback in case data manager is disabled?" }, { "prediction": "I don't think we need to change this.", "reference": "Do you think we want to move the call to `generateWorkerServiceRecommendedActions` inside `RecommandedActions()`?" }, { "prediction": "I'm not sure if this is a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug.", "reference": "The VUIDs in this area are not great, but I think `ValidateQueryPoolStride` should probably be skipped if the query pool was created with type `VK_QUERY_TYPE_PERFORMANCE_QUERY`. VUID-02828 might be a better fit, but again, the existing VUIDs step on each other so it requires a bit of interpretation." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Iguess you should use ToDbKey here" }, { "prediction": "I'm not sure why this was removed.", "reference": "x.tbk is the \"index\" below, and is done in Start()" }, { "prediction": "I don't think this is needed.", "reference": "Do we already have a convention for this? If not, would we consider \"DataDog.IsAppInsights\". And then use \"DataDog.\" prefix for all this settings, environment variables etc..? Such settings are, essentially, public APIs because they may conflict with customer data. Regardless of that, AppInsights has an s at the end :)" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "this assignment is not necessary if the offsetof() is used in the configmap" }, { "prediction": "I'm not sure why this was removed.", "reference": "I'd rather leave a TODO here at least." }, { "prediction": "I'm not sure if this is the right test. I'm not sure if it's the right test.", "reference": "Shouldn't this be `resource`?" }, { "prediction": "I don't think this is needed.", "reference": "Why does this become blocking for the CPU path? Shouldn't it remain independent of the GPU path?" }, { "prediction": "I'm not sure if it'''''''''''''''',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',", "reference": "Do we need to change occurences where `setup` was called before?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Is this TODO still valid? Or are we going to put this somewhere else later?" }, { "prediction": "I don't think we need to check for playing now.", "reference": "We generally don't do parantheses in if conditions in Python. :) this could be better written as `if from_ts is None`" }, { "prediction": "I think this should be `tname[299] = '\\0', hostname[199]='\\0', port[99]='\\0';`", "reference": "Odd that we'd set just element 299 of a 2000-byte buffer to null. But I see that this is the way it was before." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a score function.", "reference": "ScoreFunc is not used in this PR. Maybe to add it later when needed?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "super nit: I think this might be easier to read as `requestHeadersFromResponseWriter`" }, { "prediction": "I'm not sure if this is needed.", "reference": "Need to include \"common/base/Base.h\" in front of this line" }, { "prediction": "I don't think this is needed anymore.", "reference": "Changes in this file should go into a separate PR." }, { "prediction": "I think this method should be `String quoted(String text)`", "reference": "Please ensure that this will not start putting single quotes where double quotes are expected." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "`ProvideConfig` was changed, looks like it will not compile for windows, and should be changed too." }, { "prediction": "I'm not sure if this is the right place to call this function.", "reference": "This does not look right, you're listing all private repositories.." }, { "prediction": "I don't think we should do this in a separate PR.", "reference": "An OPTIONS request should respond from _any_ path? Seems weird to me..." }, { "prediction": "I think this should be `width` and `height` instead of `width` and `height`.", "reference": "you need to add the content type" }, { "prediction": "I don't think this is needed.", "reference": "Do we need to distinguish between these two processes? I'm thinking maybe we can have a list of processes and treat them all equally." }, { "prediction": "I think this should be `define(AARCH64) || defined(X64) || defined(X64)`", "reference": "This is used only for out-of-line -- so yes this seems right to do for x64. Inlined is aligned separately at the end of prepare_for_clean_call(). There the ifdef is x86_64 or MACOS -- no ARM, why not? Also, please add || MACOS here to match the inlined." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "guess I'm wondering if this needs to be refactored to use Schema.joinCondition() or similar?" }, { "prediction": "Use the new Ruby 1.9 hash syntax.
Use the new Ruby 1.9 hash syntax.
Line is too long. [89/80]
Space inside { missing.
Space inside } missing.", "reference": "Does it make sense to restrict this option to `exec` only? You could add it specific to that subcommand using the `method_option`...method. There's an example of it for hosts in the `init` function." }, { "prediction": "I don't think this is needed.", "reference": "This is very expensive (lots of allocations, lots of data copying). Could we do something like check IndexOf('%') and bypass if no hit?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "This should be `WorldType.isDeadmanWorld(client.getWorldType())` to be inline with the other WorldType calls." }, { "prediction": "I don't think we need to do this anymore.", "reference": "do we also need to change `mlvl_confid` -> `mlvl_confidences`>" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "I feel slightly that InterfaceExclude is not a clear name - bearing in mind that our config names are, to some extent, an external API. From an external point of view, a clearer name might be IPVSInterfaces. Then it would obviously make sense for the value to be something like 'kube-ipvs0', and it would be a matter of Felix's internal implementation that we choose to exclude those interfaces from our monitoring. Alternatively, if we want to keep this at a level that is more general than just IPVS, perhaps 'UnmonitoredInterfaces'? WDYT?" }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if it's the right way to do it.", "reference": "This should be `re.search` with a `^` anchor added to the regex, as what we want here is really any path starting with something like `E:`." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Since `IsKubernetesBuiltInResource` at L69 returns false due to lack `networking.istio.io/v1alpha3` in `builtInApiVersions` within `pkg/app/piped/cloudprovider/kubernetes/resourcekey.go`, it will never reach this point." }, { "prediction": "I'm not sure if this is the right place to create a factory, but I'm not sure if this is the right place to create a factory, or if it's the right place to create a factory, or if it's the right place to create a factory, or if it's the right place to create a factory, or if it's the right place to create a factory, or if it's the right place to create a factory, or if it's the right place to create a factory, or if it's the right place to create a factory, or if it's the right place to create a factory, or if it's the right place to create a factory, or if it's the right place to create a factory.", "reference": "Does codecov not run this test? Not sure how else it would not be covered." }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do here.", "reference": "can we add some sample of JSON_DATA format in the usage?" }, { "prediction": "I don't think we need the `DistributedSpanContext` property anymore.", "reference": "Using `Tracer.Instance` in here is problematic for testing It will likely cause some other tests to break I think - that's why we started passing in `IScopeManager` EDIT: I see you used `[TracerRestore]` - maybe that'll be enough!" }, { "prediction": "I don't think this is needed.", "reference": "make all of these `static final` fields UPPER_SNAKE - they are constants." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "No possible chance for weird overflows here, right?" }, { "prediction": "I don't think we need this constant.", "reference": "Or we could use a Float object to more clearly show as user-settable via non-null?" }, { "prediction": "I think this should be `finalizedHeader` instead of `finalizedHeader`.", "reference": "finalizedHeader should be saved in FinalizationManager when we have FinalizationBlockHash!= Keccak.Zero" }, { "prediction": "I don't think we need to add scratchDiskName here. I think we should add scratchDiskName to the `diskImporterDiskName` field.", "reference": "Not using ExactName: true would remove the need for manually adding workflow ID as it would be added automatically by Daisy. E.g. 'disk-importer-2-import-ovf-7mn7h' was created from diskImporterDiskName above even though only 'disk-importer-2' was specified. ExactName: true should be used for resources that shouldn't include any temp prefix/suffix, such as disks that will be permanently attached to a created instance. Scratch disk is not one of them." }, { "prediction": "I'm not sure if this is the right place to use `scol_for(sdf, col)` or `scol_for(sdf, col)`", "reference": "If we support multi-index column later, we need to rename to fit the pandas' requirement." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for it.", "reference": "I'm not sure this is really needed. JSONValue type can be used the same as a map as far as operators go, including range. I'd leave this out for now unless there is a strong reason to keep it." }, { "prediction": "I'm not sure if this is the right place to start decaying.", "reference": "sorry for nitpicking but I would love a new line under this line" }, { "prediction": "I'm not sure if we should change this to `ChannelImplementation`?", "reference": "ChannelImplementation field naming is not clear, is it some kind of standard? Maybe it can be named ChannelID?" }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to add a `RemoveFiles` method to the `ActionProvider` class.", "reference": "Looks like there is a typo: `expireSnapshots` -> `removeFiles` or whatever name we go with." }, { "prediction": "`currentSortOrder == values[i] || currentSortOrder == null) { idxCurrentSort = i; break; }", "reference": "Thanks for looking into this. I think it looks a bit strange to have this check inside the for loop. Wouldn't it also work to initialize `idxCurrentSort` with 0 instead?" }, { "prediction": "I don't think we need to change this. I don't think we need to change this.", "reference": "Just a small ordering thing: Could you please bring `IMPORTANCE_HIGH` to the bottom and maybe even have one line between it and the Notification IDs?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "Should this be boost logged?" }, { "prediction": "I don't think we need to pass `violations` to `convert_to_timestamp`.", "reference": "What is the reason for doing expunge here? This method is purely for converting the timestamp." }, { "prediction": "I think we should use `ValidAvroName` instead of `ValidAvroName`", "reference": "This calls sanitize twice if the name isn't valid." }, { "prediction": "I'm not sure if this is the right place to put this method.", "reference": "Is there an equivalent that'd allow zero or one?" }, { "prediction": "I'm not sure if this is the right place to set the object name. I'm not sure if this is the right place to set the object name, but if it's the right place to set the object name, then the task object name needs to be set.", "reference": "Is it possible to update/re-evaluate entire metatask object for every repeat? If we decide/need to use a repeatWith resources in let us say labelSelector(bad example) then we would have to add another logic to update those properties." }, { "prediction": "I'm not sure if this is the right place for this, but I think it's better to use `int(syscall.Stdin)` instead of `int(syscall.Stdin)` and then use `int(syscall.Stdin)` here.", "reference": "unnecessary conversion (from `unconvert`)" }, { "prediction": "I'm not sure why this was removed.", "reference": "typo in commit message `openening`" }, { "prediction": "I don't think this is needed.", "reference": "User-code doesn't see the internal ADIOS headers anymore. This whole include block should just be `#include `" }, { "prediction": "I don't think we need to change this test. I think we should be able to use `patch_json` instead of `patch_json`.", "reference": "nit: I guess we can omit this (unless you had a reason to specify it)" }, { "prediction": "I don't think this is needed.", "reference": "Why is Hub public?" }, { "prediction": "I'm not sure why this was removed.", "reference": "why is this deleted?" }, { "prediction": "I don't think this is the right place to start this.", "reference": "Maybe move that into a partial" }, { "prediction": "I don't think this is the right place for this test.", "reference": "Error return value of `dao.Stop` is not checked (from `errcheck`)" }, { "prediction": "I'm not sure if this is the correct message.", "reference": "util.Warning()? Easier to say." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "this default is kinda superfluous (although i see it was already there before PR )" }, { "prediction": "I don't think we need this anymore.", "reference": "How is this related?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I'm breaking one of the rules here, it feels like the right thing to do. Open to alternative suggestions." }, { "prediction": "I'm not sure if this is the right place for this test. I'm not sure if it's the right place for this test.", "reference": "The use of `#should` was triggering an rspec depracation warning for me, which is why I switched this to the rspec 3 style." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, I'm not sure if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "Why are you setting the CacheChange as REQUESTED when it is not valid (it was erased from history)?" }, { "prediction": "I don't think this is needed.", "reference": "`lodash` shouldn't be grouped under WordPress dependencies" }, { "prediction": "I don't think we need this anymore.", "reference": "This needs to be public so that Avro can call it." }, { "prediction": "I don't think this is needed anymore.", "reference": "`Google*` shouldn't be under External dependencies - seems like ESlint is not properly recognizing that these are aliases to internal dependencies." }, { "prediction": "I think this should be `assert isinstance(data, ks.Series)`", "reference": "I think he meant the docstring in this constructor. yea we should fix" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it.", "reference": "so.. this basically follows the pattern from JapaneseTokenizer, I think... but somehow I don't see where we defined ResourceScheme? We're not referencing the one in kuromoji, right?" }, { "prediction": "I don't think we need this.", "reference": "It would probably be better to do: const SecurityProtocolType Tls13 = (SecurityProtocolType)12288" }, { "prediction": "I don't think we need this anymore.", "reference": "Similar to the above, put this setting back but keep the value as `'{}'`" }, { "prediction": "I don't think we need this logger.", "reference": "As discussed in chat - we should run this function within an app context which means that we'd already have a logger configured, and a connection to timescale set up" }, { "prediction": "I'm not sure if this is the right place to remove it. I'm not sure if this is the right place to remove it, but I'm not sure if it's the right place to remove it or if it's the right place to remove it.", "reference": "I'm curious about why this needed to be removed." }, { "prediction": "I don't think this is needed anymore.", "reference": "why did you remove `zip`? It is used!" }, { "prediction": "I don't think we need to mark the topic ready?", "reference": "Is there any reason that we don't add a similar condition like `ChannelConditionTopic` to the channel?" }, { "prediction": "I don't think this is needed anymore.", "reference": "before php8 \"goto\" was a reserved word and was not allowed as part of the namespace. Now test checks for validity of plugin namespace according to PSR-4" }, { "prediction": "I don't think we need to do this.", "reference": "nit: I'm not sure it can be addressed in this diff, but it seems odd that NewOutbound supports TLS but NewSingleOutbound does not. As a somewhat naive user I would expect the only difference between these two APIs is how peers are chosen." }, { "prediction": "I'm not sure if this is the right place to close the response body. I'm not sure if this is the right place to close the response body.", "reference": "I would advise to enhance the test for the method `CallOneway` - we should have a test very similar to `TestCallSuccess`. We should test: - Success with response (even if it is callOneway) - Success with no response and empty payload - Errors" }, { "prediction": "I don't think this is needed.", "reference": "We're already matching +. Not sure why this changed." }, { "prediction": "I don't think this is needed.", "reference": "Please add line breaks, so the line doesn't exceed 80 chars." }, { "prediction": "I don't think we need to pass `activitySource` and `options` to `AspNetCoreInstrumentation`.", "reference": "I initially thought (inccoreclty) this is a breaking change! The public api analyzer is a gift!" }, { "prediction": "I don't think this is needed anymore.", "reference": "I'm not sure how this one didn't segfault before." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "Same points as in other test file." }, { "prediction": "I don't think this is needed anymore.", "reference": "Did you run gradlew tidy? Wildcard imports shouldn't be there, hence the question." }, { "prediction": "I'm not sure this is the right place for this test. I'm not sure if this is the right place for this test, but I'm not sure if it's the right place for this test.", "reference": "Put a comma after the last parameter of a multiline method call." }, { "prediction": "I'm not sure if this is the right thing to do.", "reference": "Is this going to restrict the output to *ONLY* ports that are bound to vfio-pci? That's not what we discussed yesterday." }, { "prediction": "I don't think we need to do id address lookup here or we might defer that to VM address lookup here.", "reference": "Intention is to do the lookup here, I believe (where we can cache it). This would make the call non-pure function though. I'll confirm with lotus. ID addresses are the *only* addresses I expect to actually see here." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `ssh` or `ssh2` or `ssh3` or `ssh4` or `ssh3` or `ssh4` or `ssh3` or `ssh4` or `ssh3` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or `ssh4` or", "reference": "electronic medical record file system (EMRFS)" }, { "prediction": "I don't think we need this directive anymore.", "reference": "Put this higher in the list, like after \"bind\", since I guess we're considering the max request body size to be kind of a native/fundamental feature, built directly into the vhosts." }, { "prediction": "I don't think this is needed anymore.", "reference": "oh come on :(" }, { "prediction": "I'm not sure if this is the right place to put this in.", "reference": "This is an incorrect change. The dialect spoken is an important part of the handshake and should be communicated to users." }, { "prediction": "I'm not sure if this is a service account or a service account, but I think it's a service account.", "reference": "Remove as this is not needed anymore." }, { "prediction": "I'm not sure if this is the right place to do this, but I think it's better to have `do_it` return `None` if `optional_int` is `None` and `do_it` return `None` if `optional_int` is `None` and `do_it` return `None` if `optional_int` is `None` and `do_it` return `None` if `optional_int` is `None` and `do_it` return `None` if `optional_int` is `None` and `do_it` return `None` if `optional_int` is `None` and `do_it` return `None` if `optional_int` is `None` and `do_it` return `None` if `optional_int` is `None` and `do_it` return `None` if `optional_int` is `None` and `do_it` return `None` if `optional_int` is `None` and `do_it` return `None` if `optional_int` is `None` and `do_it` return `None`", "reference": "This new class is for checking that #4551 works correctly with PlantUML output too." }, { "prediction": "I think this should be `cmapi.UsageKeyEncipherment`, not `cmapi.UsageKeyEncipherment`.", "reference": "Will this cause all certificates to be re-issued?" }, { "prediction": "I'm not sure if this is the right place to free it.", "reference": "I think tmp is also leaked at the end of this loop if no error cases are encountered." }, { "prediction": "I think this is a breaking change. It's a breaking change, but it's a breaking change. I think it's a breaking change.", "reference": "The previous version didn't use `keyProjection` because the entire key must be projected. If the key is a struct of multiple columns, then projecting a subset of those columns can easily introduce key collisions that aren't in the original data." }, { "prediction": "I don't think this is the right place to check space existence. I'm not sure if this is the right place to check space existence, but if it's the right place to check space existence, then it's the right place to check space existence. I'm not sure if it's the right place to check space existence, but if it's the right place to check space existence, then it's the right place to check space existence. If it's the right place to check space existence, then it's the right place to check space existence, but if it's the right place to check space existence, then it's the right place to check space existence, and if it's the right place to check space existence, then it's the right place to check space existence.", "reference": "Why not use StatusOr? We can't ensure spaceId is greater than zero, especially when AdHocSchemaManager is used." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "Does it seem we only use that as the json-rpc client? Do we have any other choice? It's a little weird." }, { "prediction": "I don't think it'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''", "reference": "Could you split this into multiple lines?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Doesn't the snapshot ID start off as null? It seems like we don't need to set it here." }, { "prediction": "I'm not sure if this is the right place to use `lookupPath` and `lookupPath`", "reference": "I wondered why `buffer` was passed into `LookupPath`. What is happening here? Is `buffer[:0]` equivalent to `[]V4TrieEntry{}`, and hence `buffer` isn't needed any more?" }, { "prediction": "I don't think we need to validate the state view.", "reference": "nit: Ideally we would would use this abstraction everywhere we need this translation. I believe it's needed in the mining worker and the storage and market connectors." }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "need to fix the error message here" }, { "prediction": "I think this is not fixed.", "reference": "Unsure of how to handle this one." }, { "prediction": "I think this should be \"Dropping Kill action as execution\"", "reference": "Will this.flowFinished verify with every finished state stated in Status.isStatusFinished method? If so, no need to verify isKilled." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "replace \"Child Workflow\" with \"any workflow\"" }, { "prediction": "I'm not sure about this, but I'm not sure if it's a good idea to have a symbolic link.", "reference": "Instead of showing the words \"symbolic link\" under the \"Size\" column, how about we introduce new icons for symbolic link to file and symbolic link to directory?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Please add back the description of the parameter" }, { "prediction": "I'm not sure if this is the right place to do this.trees = { graphite: treeRoot.findChild('id', 'GraphiteTree'), mygraphs: treeRoot.findChild('id', 'MyGraphsTree'), mygraphs: treeRoot.findChild('id', 'MyGraphsTree'), mygraphs: treeRoot.findChild('id', 'MyGraphsTree'), mygraphs: treeRoot.findChild('id', 'MyGraphsTree'), mygraphs: treeRoot.findChild('id', 'MyGraphsTree'), mygraphs: treeRoot.findChild('id', 'MyGraphsTree'), mygraphs: treeRoot.findChild('id', 'MyGraphsTree'), mygraphs: treeRoot.findChild('id', 'MyGraphsTree'), mygraphs: treeRoot.findChild('id', 'MyGraphsTree'), mygraphs: treeRoot.findChild('id', 'MyGraphsTree'), mygraphs: treeRoot.findChild('id', 'MyGraphsTree'), mygraphs: treeRoot.findChild('id', 'MyGraphsTree'), mygraphs: treeRoot.findChild('id', 'MyGraphsTree'),", "reference": "Superfluous space inserted." }, { "prediction": "`node.ownerSVGElement` should be `node.ownerSVGElement`", "reference": "Didn't fix the problem. `href=\"\"` for SVG will still result in `undefined` getting returned by this function." }, { "prediction": "I don't think we need to change this test.", "reference": "This seems like a strange change... I wouldn't think that a change to access tags in the profiles would result in different bearings in this tests?" }, { "prediction": "I don't think this is needed.", "reference": "As isCaret is False by default, explicitly specifying isCaret=False here is not needed, and is perhaps a little confusing. I'd prefer that anywhere in the codebase that isCaret is only ever specified if it needs to be set to true. Mirroring that of isFocus for setNavigatorObject." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "We can't freeze this and then add something to it in the next line. The `freeze` on line 43 is sufficient. If Rubocop flags this we need to exclude it." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Why is this needed?" }, { "prediction": "I think this should be `m.Get(\"/repos\", reqToken()).Get(repo.ListMyRepos).Post(bind(api.CreateRepoOption{}), repo.Create)`", "reference": "Why not put two other routes after this line (221)?" }, { "prediction": "I think this should be `if (!addrs.value().empty()) { return addrs.status(); } else if (!addrs.value().empty()) { return addrs.status(); } else if (!addrs.value().empty()) { return addrs.status(); } else if (addrs.value().empty()) { return addrs.status(); } else if (addrs.value().empty()) { return addrs.status(); } else if (addrs.value().empty()) { return addrs.status(); } else if (addrs.value().empty()) { return addrs.status(); } else if (addrs.value().empty()) { return addrs.status(); }", "reference": "If FLAGS_meta_server_addrs is not empty, in which case \"toHosts\" return empty array?" }, { "prediction": "I don't think we need this. I don't think we need it.", "reference": "There is a function to output a \"JSONBool\" string. That would be a good start for finding uses. But maybe just have a look at where we decide whether it is a numerical or not, thus wrapping quotes around its value. Then you have it all I guess." }, { "prediction": "I don't think this line is needed.", "reference": "oops, it should be `data._scol` so that it respects the expression stored in Series. Let me fix it quick." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Thanks for moving this up with the rest of the variables. Much tidier :)" }, { "prediction": "I'm not sure if this is the best way to do this, but I think it's better to have a `PaymentPerTime` variable that holds the payment per time. I'm not sure if this is the best way to do it.", "reference": "I think `Rate` is a more precise and concise term for `PaymentPerTime`." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I think this should maybe be: var limit = input.IndexOfAny(new[] { '+', '-', ']' }, **posNext**); You pretty much want to ignore any sign that is before the \"M\". But, if there is a sign somewhere before the M, and also after the M, you'd want to be able to find the sign after the M, right?" }, { "prediction": "I think this should be `if(true === ConfigQuery::checkAvailableStock()) {`", "reference": "if `checkStockNotEmpty` returns a reponse, you must return it or your script will continue its execution." }, { "prediction": "I'm not sure if this is the right place for this change.", "reference": "Any specific reason for this change? klog should work correctly here." }, { "prediction": "I don't think this is the right place to do this, but I think it's better to do this in a separate PR.", "reference": "we don't mention `last_modified` here?" }, { "prediction": "I'm not sure if this is the right place to use hyperx, but I think it's better to use `hyperx(h)` instead of `hyperx(h)`", "reference": "same deal about the global state maybe interfering as in ActionBrowseTagline" }, { "prediction": "I think this test should be `Assert.Throws(() => new LruCache(maxCapacity, \"test\");));`", "reference": "so sweet to see a test as the first thing" }, { "prediction": "I don't think this is needed.", "reference": "usually when HTTP_PROXY=\"\" (empty), proxy should be disabled. could you set it to NULL when it's empty string?" }, { "prediction": "I think this should be `int` instead of `int`.", "reference": "Can you throw an exception if width or height are both null" }, { "prediction": "I don't think we need to change this.", "reference": "This is a breaking change. I guess these might have been intentionally exported." }, { "prediction": "I think we should move this logic to `TableScan` class.", "reference": "I don't think this is necessary. When options are used to set the split size in the Spark reader, it uses `TableProperties.SPLIT_SIZE` to pass it here. That should work for metadata tables as well, right? The situation that we need to handle in this PR is setting the default, like you had before. We just want to use a metadata split size so you can set it and not have the same split size used (by default) for both metadata and data scans." }, { "prediction": "I'm not sure about this, but I think it's better to have a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide` and a `Divide", "reference": "wait a sec, shouldn't this be `'*'`?" }, { "prediction": "I don't think this is needed.", "reference": "It think you'll want the var for GMI import as well: daisy_workflows/ovf_import/create_gmi.wf.json (Unfortunately there's duplication between the two :/ )" }, { "prediction": "I don't think this is needed.", "reference": "Nit: Group this with the other commands by moving it down one line." }, { "prediction": "I think this should be `UnsupportedEncodingException`.", "reference": "I would like to emphasize that a user can use non-vectorized reads to handle this file so maybe something like \"Cannot perform a vectorized read of ParquetV2 File with encoding %s, disable vectorized reading with $param to read this table/file\"" }, { "prediction": "I think this should be `ParamName`", "reference": "Maybe add `positional=False`. It does not need it more than the other parameters, but one must start somewhere." }, { "prediction": "I don't think we need to change this test.", "reference": "Since we're here, can we use a template?" }, { "prediction": "I think this is a bit of a hack, but I don't think it's worth it.", "reference": "saw you're also doing this in `test_types.py`: `spark = _spark_context()['test'].resources['spark'].resource_fn(None)` since `_spark_context()` uses `spark_session_local` won't the above break the tests?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "`has(default)` i think is the preferred way of doing this" }, { "prediction": "I don't think we need to change this test.", "reference": "always put a space after a comma" }, { "prediction": "I don't think this is needed.", "reference": "@angmas1 move the else up, next to the closing bracket of the if block. Also, there is no need for the braces as your else statement contains only a single line. Make your if-else block similar to the block in lines 277-280." }, { "prediction": "I don't think we need to pass options here.", "reference": "@AutomatedTester @davehunt thoughts on a new keyword argument?" }, { "prediction": "I think this should be `Set slots` instead of `Set slots`.", "reference": "This change shouldn't be necessary for this PR. Please remove it." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This variable is mostly unused, how about we make `NewTestCtx` return a pointer?" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.", "reference": "What is the basis of this value?" }, { "prediction": "I don't think we need to include gce_metadata.h or gce_metadata.h.", "reference": "Nit: was this extra blank line added intentionally?" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "nit: inconsistent spacing around =" }, { "prediction": "I don't think we need this anymore.", "reference": "We still need this import" }, { "prediction": "I'm not sure why this change is needed.", "reference": "We are pulling this because we removed \"groupID\" state and put it into the strategy implementations" }, { "prediction": "I don't think this is needed anymore.", "reference": "Is this file actually related to PCA?" }, { "prediction": "I don't think we need to change this.", "reference": "See above, this should probably remain `isFirstAdmin`." }, { "prediction": "I think this should be `Type[]ArrayExpression`", "reference": "Why the change to make it public? The expression interface has the `TypeOf` method?" }, { "prediction": "I'm not sure if this is the right place for this test.", "reference": "don't mind the snake cases in the test names. If there are in the test cases, it's fine IMO" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to rename it to `IdentityUnlockingDto`. I think it's a good idea to rename it to `IdentityUnlockingDto`. I'm not sure if it's a good idea to rename it to `IdentityUnlockingDto` or if it's a good idea to rename it to `IdentityUnlockingDto`.", "reference": "`Id` defines REST resource address and should not be in payload" }, { "prediction": "I think this should be `--class_wise` or `--class_wise`", "reference": "We can omit the underscore and just use `classwise`." }, { "prediction": "I think this should be `$rootCategory = $this->container->get('sonata.classification.manager.category')->getRootCategory($context);`", "reference": "Why not throw an exception instead then?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Looks like this doesn't need to change. Can you revert this?" }, { "prediction": "I don't think this is needed.", "reference": "please import it like `from kinto.config import template`" }, { "prediction": "I think this should be `Boolean.parseBoolean(p);`", "reference": "There are lots of default value changed, not sure if it break the old behavior." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I don't think we need to pass `false` to `AddPeer` and `RemovePeer` to the `AddPeer` and `RemovePeer` methods. I don't think we need to pass `false` to `AddPeer` and `RemovePeer` methods.", "reference": "parameter should be called removeFromStaticNodes" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "The handler will have an extra property in the marker to signal the implementation is in the provider, for the cases we want to add functionality, for example, custom implementations not in moto." }, { "prediction": "I don't think we need this column anymore.", "reference": "Is this method actually being used anywhere? If not, I think we should remove it." }, { "prediction": "I don't think this is needed.", "reference": "Thanks! I somehow lost this between my far too many branchs." }, { "prediction": "I don't think this is needed anymore.", "reference": "i think this should get put into its own file. This could start to grow :)" }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if this is the right place to do it.", "reference": "Can you add a TODO for loading the tarball of the pause image into Docker?" }, { "prediction": "I think this should be `System.currentTimeMillis() - startMs` or `System.currentTimeMillis() - startMs`", "reference": "Is there any value in setting the process to null like this?" }, { "prediction": "I don't think we need this check.", "reference": "This could be a good time to add a check that the prediction and target dimensions (except channel) agree?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "The requirement that OP_isb is bb-final needs to be a rule for clients, just like the rule that syscalls and interrupts must be bb-final: i.e., please add it to the dr_register_bb_event() docs." }, { "prediction": "I'm not sure if this is the right place for this, but I think it's better to use `Globalize.translate(\"ListPaging\").replace(\"{0}\", (totalRecordCount? startIndex + 1 : 0) + \"-\" + recordsEnd).replace(\"{1}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{1}), totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{1}), totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{", "reference": "The translate library has a method to replace the variables." }, { "prediction": "I don't think we need to test this, but I think it's a good idea to test `fillna` with `np.nan` and `np.nan` as well.", "reference": "i don't think this test case is correct. in both cases inpalce=True returns nothing. We need to compare the ks. Also we probably need to make a copy of it. Otherwise you pollute the following \"ks\" because ks has been changed." }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Any proposals how to make the naming somehow include the \"completed\" idea of this hook? `TlsHandshakeCompletedHook` or similar? Or using the `...Start/End...` scheme?" }, { "prediction": "I think this should be `syncReport.FullSyncBlocksDownloaded.Update(_blockTree.BestSuggestedHeader?.Number?? 0);`", "reference": "it introduces a lot of complexity to the state, can we flush straightaway or create a two level flush store where the questions are read form unflushed data?" }, { "prediction": "I don't think we need to change this line.", "reference": "There are two calls to getUrlFromRouteCache, but you're only urlencoding one of them. Is that intentional? Would it make more sense to do the url-encoding inside the getUrlFromRouteCache function?" }, { "prediction": "I'm not sure if this is the right place to set the activeEditor.row and the activeEditor.col properties. I'm not sure if this is the right place to set the activeEditor.row and the activeEditor.col properties. I'm not sure if this is the right place to set the activeEditor.row and the activeEditor.col properties. I'm not sure if this is the right place to set the activeEditor.row and the activeEditor.col properties. I'm not sure if this is the right place to set the activeEditor.row and the activeEditor.col properties. I'm not sure if this is the right place to set the activeEditor.row and the activeEditor.col properties. I'm not sure if this is the right place to set the activeEditor.row and the activeEditor.col properties. I'm not sure if this is the right place to set the activeEditor.row and the activeEditor.col properties.", "reference": "Maybe we can use `this.instance.getCell` with `topMost` flag to get `TD` element?" }, { "prediction": "I'm not sure if this is the right thing to do here.", "reference": "Change this to Debug Level" }, { "prediction": "I think this should be `_allLayoutsAreThreadSafe = _allLayouts.All(layout => layout.ThreadSafe); _scannedForLayouts = true;`", "reference": "I refactored the Aggregate, those are hard to read" }, { "prediction": "I'm not sure why this was removed.", "reference": "This is now done in the after method, so this test won't pass any more." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it.", "reference": "What was the point of creating `user_block` if you're then not going to use it ;-)" }, { "prediction": "I don't think we need to remove this line.", "reference": "@ueshin, I thought we can remove this entire file. Does that require some more works?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea, but I'm not sure if this is a good idea.", "reference": "Just `return tokens.string[1:-1]` is enough" }, { "prediction": "Metrics/LineLength: Line is too long. [89/80]", "reference": "1 trailing blank lines detected." }, { "prediction": "I think this should be `Double.MAX_VALUE`.", "reference": "Isn't this the default max width? In any case I would prefer to see these definitions in the css files." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "Is this thread-safe? (If not, and if the solution is to introduce locking, let's reconsider how we do the scheme changing instead...)" }, { "prediction": "I'm not sure if this is the right place to use kfold_random. I'm not sure if it's the right place to use kfold_random.", "reference": "Looks like this file has tabs instead of spaces." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this. I'm not sure if this is the right place to do this, but if it's the right place to do this, I'm not sure if it's the right place to do this.", "reference": "Hmm should we clean up container resources before task resources here? or the order does not really matter here?" }, { "prediction": "I'm not sure why this was removed.", "reference": "Please undo this :wink:" }, { "prediction": "Line is too long. [89/80]
Line is too long. [89/80]
Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "thanks for adding this missing association" }, { "prediction": "I don't think we need to expose this in the `HttpsConnectionFilterOptions` class. I'm not sure if we need to expose it in the `HttpsConnectionFilterOptions` class, but I'm not sure if we need to expose it in the `HttpsConnectionFilterOptions` class.", "reference": "Should I remove this in favor of the HttpsConnectionFilterOptions overload?" }, { "prediction": "I think this should be `int` instead of `int`.", "reference": "This shode be nullable, there alway sholud be at least one status in system, if not exist that mean data problme" }, { "prediction": "I don't think we need to add JS file to unistall-sw.js", "reference": "Spaces not tabs" }, { "prediction": "I don't think we need to do this for v10 and v8?", "reference": "To get the files inside a directory, please use `readDirStats()`." }, { "prediction": "I'm not sure if this is the right place for this test.", "reference": "might be worth to call these `Isolation` instead of containers here and when presented to the user -- docker/rkt, in addition to cgroups and namespaces, also provide image discovery and filesystem preparation; there's also the security context and probably 1-2 other small things" }, { "prediction": "I'm not sure if this is the right place to put this file.", "reference": "File is empty, consider removing?" }, { "prediction": "I don't think this is needed.", "reference": "This seems to return the registry_url. The more meaningful URL is the catalog URL, which is the URL the user specifies in `quilt3.login`. The username might also be as useful here if not more useful." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "Was the addition of `GasPriceOracleAddress` here erroneous?" }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Space inside } missing.", "reference": "I believe that you are going to have to do some work here to get the env var support for these values to still work correctly, otherwise they will get stored as :department instead of host_tags[:department]." }, { "prediction": "I don't think we need to iterate over the `mSessions` array.", "reference": "How was this causing the exception?" }, { "prediction": "I think this should be `if (currentCulture == 'zh-tw' || currentCulture == 'zh-hk') { require([\"css!jellyfin-noto/css/TC\"]); } else { require([\"css!jellyfin-noto/css/SC\"]); }`", "reference": "I still have issues with it loading Simplified Chinese by default over Japanese, since they also share characters and we're not sure if characters are different or not. As-is, this fixes Traditional Chinese and Simplified Chinese, but we're not sure if it'd still screw up Japanese text or not. I maintain that, in my opinion, Japanese should be the only script of this kind loaded by default (Because of Hiragana and Katakana, that aren't shared with any other script) and either variant of Chinese should be loaded only in their respective case." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this.", "reference": "Isn't it better to stub AtomatonQuery and yield it here. IIRC it resolves simplest MTQ highlighting cases as nobrainer." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "Line is too long. [96/80]" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for this, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, I'm not sure if it's the right place for it.", "reference": "My only concern with changing the node selector here is that someone else _could_ have built their own images for other platforms and set them to be used using the flag override on the controller, which in turn this change would break. Perhaps not changing the selector for acmesolver pods makes most sense, and then working on actually having support for Windows? wdyt?" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for this, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, I'm not sure if it's the right place for it.", "reference": "Why do we need interface `InnerObjectWithSelector`, I searched the usage with this field, it seems nowhere use `GetSelectorSpecs()` methods provided by `InnerObjectWithSelector`" }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "Do we need this `init` here? We have already called the `InitContext` in `StartModule` directly." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but I'm not sure if it's the right place to do it.", "reference": "This `if` is not necessary" }, { "prediction": "I don't think we need this value for input masking.", "reference": "should we add a `mangle.json` mapping for this? We could reuse a property name that's only used on component or vnode objects right now, like `__s` (\"next state\")." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `--modulepath` or `--modulepath` in the future. I'm not sure if it's a good idea to use `--modulepath` or if it's a good idea to use `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath` or `--modulepath`", "reference": "Please update the yard docs to indicate this new option." }, { "prediction": "I'm not sure if this should be optional, but I'm not sure if it's a good idea to make it optional.", "reference": "Can you provide an example in the godoc section on how to use this? From the implementation it looks like the AvailabilityZone field is required for example, otherwise it can fail / error, is that correct?" }, { "prediction": "I'm not sure if this is the right place to use `CodeVersion` or `Version`?", "reference": "It would be great if this could be captured by a test." }, { "prediction": "I don't think we need to do this. I'm not sure if we need to do this.", "reference": "1000 -> 100 maybe too much, 200 ish to 500ish maybe a good option" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Any reason we need to keep this package's `ChecksumAddress` type or can we get rid of it too?" }, { "prediction": "I don't think this is needed.", "reference": "Above the one that was picked was the Button* prefix, and here it's the Header* prefix. Maybe the Button prefix is more general." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea, but I'm not sure if it's a good idea.", "reference": "I might prefer changing: public Block FindPendingBlock() => FindBlock(PendingHash, BlockTreeLookupOptions.None); public BlockHeader FindPendingHeader() => FindHeader(PendingHash, BlockTreeLookupOptions.None); in IBlockFinder, what do you think?" }, { "prediction": "I'm not sure if this should be optional, but I'm not sure if it's necessary.", "reference": "This is necessary due to a bug in 4.7. Follow HIVE-1561 for getting rid of it." }, { "prediction": "I think this should be `options.has_many :exercises, source_type: 'Exercise'`", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I think this should be `XStringToKeysym()` instead of `XStringToKeysym()`", "reference": "Some day (tm) I will also get rid of that one. But today is not that day..." }, { "prediction": "I think this should be `if (substr($localPath, 0, 1)!== '/')`", "reference": "Add a space between if and opening parenthesis please (i.e. `if (`)" }, { "prediction": "I don't think this is needed.", "reference": "nit: `rename` instead of `alias`?" }, { "prediction": "I think this should be `/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/sda1/dev/dev/sda1/dev/sda1/dev/dev/sda1/dev/dev/sda1/dev/", "reference": "Per AWS docs EC instances have the root mounted at /dev/sda1. This label should be skipped." }, { "prediction": "I'm not sure why this was removed.", "reference": "I'm not sure it is a better way to address lose message, if wait here, edge controller cant process message, event from watching api-server will be lost yet, right?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Please keep the correct alignment, it seems broken now (at least in Github). Can you reverse the test (`if p.value_size is None`)? Also, do you want `6` when `p.value_size is None` or `x + 6`? Maybe, in that case, something like `lambda p, x: x + 6 + (0 if p.value_size is None else p.value_size)` would be easier to read. Or even easier: `lambda p, x: x + 6 + (p.value_size or 0)`." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Can we make sure ECS service treats it as int64 as well?" }, { "prediction": "I don't think this is needed.", "reference": "Please follow the naming convention for variables, i.e. `windowText`." }, { "prediction": "I don't think we need castv1alpha1 anymore.", "reference": "alias can be `cast`" }, { "prediction": "I don't think this is needed.", "reference": "Let's use `%zu` instead of casting to `uint64_t` and using `PRIu64`. The alternative is to change the type of `mmap_errors` to `uint64_t`, though I'd prefer not doing that because some 32-bit platforms might not provide atomic operation support for `uint64_t`." }, { "prediction": "I'm not sure if we should change this to `SeverityLevel.WARNING` or `SeverityLevel.SUGGESTION` or `SeverityLevel.WARNING` or `SeverityLevel.SUGGESTION` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.SUGGESTION` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING`", "reference": "I recall there being a reason we had this one set only to suggeation. @carterkozak do you remember why? or is my memory getting corrupted?" }, { "prediction": "I don't think this is needed.", "reference": "This should now be made into `if (it->second.empty())`?" }, { "prediction": "I don't think this is needed. The `num_of_searches` variable should be `None`.", "reference": "Do we need to worry about a race condition on this decrement (@The-Compiler)? I'm not sure how the python callbacks work, so this might not need to be something to worry about." }, { "prediction": "I'm not sure this is the right place to test this.", "reference": "Should these assert that the extracted `SpanContext` is remote?" }, { "prediction": "I'm not sure if it''''''''''''''''''',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',',", "reference": "typo: allow low quality matches." }, { "prediction": "I don't think we need to pass `cmds.Server` here.", "reference": "At some point we need to condense down and refactor our \"configs\" as we have too many in too many places and we're starting to get more illegible code. No change necessary but calling out for future reference." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Can we add the `if label` conditional to this please?" }, { "prediction": "I think this should be `mlflow>=0.2.0`", "reference": "@thunterdb, can we increase the minimal version to almost the latest ones? I was thinking people will mostly use the latest version of mlflow" }, { "prediction": "I'm not sure if this should be `@param {boolean} hasFillDataChanged Indicates whether the original fillData has been changed in the `beforeAutofill` hook.", "reference": "If the last argument is going to be removed, why would we add it to the API docs? Shouldn't it be private for internal use?" }, { "prediction": "I'm not sure if this is the right place to import `intermediates_manager` or `intermediates_manager`", "reference": "`Intermediates` or `Intermediate`" }, { "prediction": "I think this should be `is_element_displayed` instead of `is_element_displayed`", "reference": "This is not the right exception class. There is an InvalidSelectorException class that covers bad locators." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it?", "reference": "If this code isn't needed, it should be removed." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Should the `doRequest` func be a method on the `connection` type instead of passing state from the type?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "we'll probably tackle these e2e tests at the end" }, { "prediction": "I don't think this is needed.", "reference": "what is this address pointing to? what are we measuring here? I want to have a better understanding." }, { "prediction": "I think this should be `distinct(execution_dependencies.dep_status = 4)`", "reference": "Would it be better to pass the dependency status as the parameter into the SQL string? In case the enum value is changed in the future, we don't need to change the code here." }, { "prediction": "I don't think this is needed.", "reference": "Hah I had `gorename` failing without this too." }, { "prediction": "I don't think we need to write the rules_file_path or rules_file_path here. I don't think we need to write the rules_file_path or rules_file_path in this case.", "reference": "maybe prefix these with `appsec_` for consistency?" }, { "prediction": "I don't think this is needed.", "reference": "nit: this should be down further with the other github imports" }, { "prediction": "I think this should be `if ctypes.windll.kernel32.FreeConsole()!= 0:`", "reference": "Why is this change necessary or related to the rest of the PR?" }, { "prediction": "I don't think we need to change the `see:` to `see:`", "reference": "Hm, I wonder if the `see:` prefix is even necessary?" }, { "prediction": "I don't think this is needed.", "reference": "This should be translated." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "I originally had this PR only changing the R package, but then ran into this error > Error: [LightGBM] [Fatal] Cannot change metric during training This is thrown even if you aren't actually CHANGING `metric`. I think the change here in `c_api` is closer to the desired behavior, only throwing an error if the parameter is being changed." }, { "prediction": "Line is too long. [89/80]", "reference": "These changes are just to make cli_spec a little more readable for VS Code users, as there's a bug with the Ruby plugin's syntax highlighting when you use multi-line regex literals." }, { "prediction": "I don't think this is needed anymore.", "reference": "Shouldn't the global pull secret by in the namespace of the hive-operator? It is part of the operand." }, { "prediction": "I'm not sure if this is the right place to test this, but I'm not sure if it's the right place to test this.", "reference": "kinesis-mock applies KINESIS_LATENCY to RegisterStreamConsumer actions so I added a sleep here." }, { "prediction": "I'm not sure if this is a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug.", "reference": "Only V1 or V3 is return from `getMetaVersionFromKV`. So where do we call `updateMetaV2ToV3`?" }, { "prediction": "I don't think this is needed.", "reference": "I think that V0 is missing here, which will prevent plugins that haven't been converted to work." }, { "prediction": "Can we move this to a separate file?", "reference": "Should we remove this?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "Put on top of the import." }, { "prediction": "I think this should be `AnalyticsModule`.", "reference": "See above, this shouldn't be added." }, { "prediction": "I'm not sure about this. I'm not sure if it''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''", "reference": "This'll likely get fixed upstream, we should let them deal with it." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Somehow, this field does not seems useful for the exposed package api, only for the tests. Would you consider having an unexported field in `hostFactory func(context.Context,...libp2p.Option) (host.Host, error)` instead to be set only by a new helper function defined in export_test.go. This is just a suggestion, not a hard requirement for the PR approval." }, { "prediction": "I don't think we need to do this. I'm not sure if we need to do this. I'm not sure if we need to do this.", "reference": "As a first argument to these function, please pass the date that should go forward/backward. Also please clarify what is \"n\" (possible values, unit) and what is timeDuration (possible values, unit, as from your code it seems to be \"day\", \"hours\", etc. but from your example it seems to be milliseconds)." }, { "prediction": "I don't think this is needed anymore.", "reference": "Are you sure you really need this code here? that script will be certainly run in NVDA's main thread, and core would have already called setLanguage." }, { "prediction": "I don't think this is needed anymore.", "reference": "why is this changed?" }, { "prediction": "I'm not sure about this, but I think it would be better to just call `Get(doc Document, revision)` instead of `Get(doc Document, revision)`", "reference": "Should this be \"the new revision value\"?" }, { "prediction": "I think this should be \"Dette feltet m\u00e5 aksepteres n\u00e5r :other\"", "reference": "You have deleted :attribute" }, { "prediction": "I don't think we need to change this file.", "reference": "The license header should be updated to the Apache one." }, { "prediction": "I don't think we need this test.", "reference": "@zacharycmontoya Is there any way to distinguish a `SocketHttpHandler` from another `HttpMessageHandler` request?" }, { "prediction": "I don't think this is needed.", "reference": "Not sure about this one -- did you check somehow?" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it.", "reference": "Is there a good reason to keep this at the `pe_ver_win` name now that it's per-host?" }, { "prediction": "I don't think we need to create a new fragment for the summary product fragment.", "reference": "Not in the order of display : Front, Ingredient, Nutrition here (which is the right thing), Actually displayed: Front, Nutrition, Ingredients" }, { "prediction": "I'm not sure if this is needed.", "reference": "Why delete `StartTime`? This `StartTime` was used to avoid the PID was reused." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "My concern here, is that if the dump_puppet_log also throws then we will lose the data about the teardown_exception." }, { "prediction": "(style) line over 80 characters", "reference": "Should it be `int64_t`?" }, { "prediction": "I think we should move this to `powsolver.java` and use `org.apache.tuweni.bytes.Bytes` instead of `org.apache.tuweni.units.bigints.UInt256`", "reference": "is this value related to something?" }, { "prediction": "I'm not sure if we need to pass the result to the `SendTransaction` method. I'm not sure if we need to pass the result to the `SendTransaction` method. I'm not sure if we need to pass the result to the `SendTransaction` method or if we need to pass the result to the `SendTransaction` method. I'm not sure if we need to pass the result to the `SendTransaction` method, but if we need to pass it to the `SendTransaction` method, then we need to pass the result to the `SendTransaction` method.", "reference": "Add names to tuple elements ValueTask<(Keccak? Hash, AddTxResult? AddResult)>, should they both be nullable?" }, { "prediction": "I'm not sure if this is the right place to replaceAcronyms. I'm not sure if it's the right place to replaceAcronyms, but I'm not sure if it's the right place to replaceAcronyms.", "reference": "I think it might make more sense to do this in Name.upperCamel; it is the entry point for upper camel strings." }, { "prediction": "I'm not sure why this change is needed.", "reference": "Huh? The point is that a cast isn't necessary" }, { "prediction": "I think this should be `InstallCRD` or `InstallCRD`", "reference": "can we name it like `InstallV1Alpha1CRDs`?" }, { "prediction": "I think this label should be \"hive.openshift.io/hiveutil-created\" or \"hive.openshift.io/hiveutil-created\"", "reference": "I need something to match when creating selectorsyncsets so added this label." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "Isn't `nil` the default return value from an empty `rescue` clause? If that's correct, then we could just remove the `nil` line entirely as it doesn't serve a purpose." }, { "prediction": "I don't think this is the right place for this PR.", "reference": "Simple Storage **Service**" }, { "prediction": "I'm not sure if this is the right place to remove obsolete indexes. I'm not sure if it's the right place to remove obsolete indexes, but if it's the right place to remove obsolete indexes, I'm not sure if it's the right place to remove obsolete indexes. If it's the right place to remove obsolete indexes, I'm not sure if it's the right place to remove obsolete indexes, but if it's the right place to remove obsolete indexes, I'm not sure if it's the right place to remove obsolete indexes.", "reference": "Wouldn't that cause the obsolete indexes to be downloaded over and over again? After all these are still stored in the repository." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "We might want to move this logic to a Plain Old Ruby Object down the road. Not a blocker." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "move `this.toolbox_.position();` to just after line 1477. Context: the if statement on line 1472 checks whether this is a toolbox with categories, and if so it populates the toolbox. Positioning the toolbox is a reasonable followup to that, and means you don't need an extra if. You may also need to call `this.flyout_.position()` after line 1483, which is the equivalent for the non-category toolbox." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Should the function above be.FirstOrDefault() instead? Otherwise, why check for null and tell ReSharper to ignore the fact that it can never be null?" }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "Let's not create new connection, but rather user `common.db` one" }, { "prediction": "I don't think this is needed.", "reference": "Can this use asset_path rather than defining an image_url helper?" }, { "prediction": "I don't think this is needed.", "reference": "Hindley-Milner signatures don't use literal types. They explusively use types. It's deal with that" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Could we just extend PolicyRule with more fields? It was originally designed as the struct required by openflow client, nested structs seem not helping. And for the name of the fields, initialism should be uppercase, OFID and NPName doesn't look good, then maybe FlowID, PolicyName.." }, { "prediction": "I don't think this is needed anymore.", "reference": "I really dislike this alignment approach, as it makes identifying individual functions quite hard, but I kept consistent with the previous style. Since no sorting was evident, I pushed it to the end of the block. Meanwhile, is this supposed to be tested or meaningfully testable somehow?" }, { "prediction": "I'm not sure if this is the right place to call `handle_event` or `is_complete`. I'm not sure if this is the right place to call `get_steps_to_execute` or if it's the right place to call `get_steps_to_execute` or if it's the right place to call `get_steps_to_execute` or if it's the right place to call `get_steps_to_execute` or if it's the right place to call `get_steps_to_execute` or if it's the right place to call `get_steps_to_execute` or if it's the right place to call `get_steps_to_execute` or if it's the right place to call `get_steps_to_execute`", "reference": "Could also consider modifying the ActiveExecution..." }, { "prediction": "I'm not sure if this is the right place to use `get_subscript_const_value` or `get_subscript_const_value`", "reference": "Does it make sense to change that to a custom error instead of `ValueError`?" }, { "prediction": "I don't think we need to pass ticket count here.", "reference": "I guess this will need to change soon." }, { "prediction": "I don't think this is needed anymore.", "reference": "Restore this spacing - not sure why it has to be removed?" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea.", "reference": "These defines cause issues in base.h leading to failing android builds. Locale independency is now set in multiple spots, in cmake and in base.h. The base.h uses feature test macros wrong. Feature test macros can be used to indicate that a feature should be made available. They do not guarantee that it is available. On the cmake side this is done by the check symbol macros (similar to what autoconf does). On the android side not. I would suggest removing this from base.h and define locale independent in gradle. It is available since android 21 I believe. Is there a way in gradle to set locale independent only if android api >= 21?" }, { "prediction": "I think this should be `(loopBody!= getDst)? loopBody->outputVar() : sampleLimit->outputVar() : sampleLimit->outputVar();`", "reference": "Why not delete these codes?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "If pull message failed after some reties, we should ensure the storaged exit, otherwise it has risk to loss data." }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to use `first` and `count` here.", "reference": "looks like you don't need to import first and count here anymore" }, { "prediction": "I think this should be `NotifyNewTask(clusterName, tasks)` and not `NotifyNewVisibilityTasks(clusterName, tasks)`", "reference": "FYI, visibility task processing is local only, meaning pushing something to local ES cluster / local archival endpoint" }, { "prediction": "I don't think this is needed anymore.", "reference": "This import can be removed." }, { "prediction": "I don't think we need this check.", "reference": "1. Nit: We can have a general helper to identify if a region is pseudo region. We might already have one somewhere. 2. Does any type of ARN support FIPS? If not, we may just move this check in arn package?" }, { "prediction": "I don't think this is needed.", "reference": "is this phrase completed in a next line? Or forgot to add... what?" }, { "prediction": "I don't think this is needed.", "reference": "`('train', 5)` and `('train', 1)` are actually the same." }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if this is the right place to do it.", "reference": "Would it be too complicated to refactor `currLimit` to be an `int64`?" }, { "prediction": "I'm not sure if this is the right place for this method, but I'm not sure if it's the right place for this method.", "reference": "Would it be more performant to just `include ::RSpec::Core::Pending` here? /cc @myronmarston" }, { "prediction": "I'm not sure if this should be optional, but I'm not sure if it's necessary.", "reference": "Should be podiochaos?" }, { "prediction": "I don't think this is needed.", "reference": "Is the `codecs.register(lambda name: None)` gracefully handled by codecs? The lambda is expected to return a tuple of functions (encoder, decoder, stream_reader, stream_writer) (or a CodecInfo object), according to the docs. I've only checked python's built-in help, though." }, { "prediction": "I'm not sure if this is the right place to put this in.", "reference": "in this case, it could be either instrument name or the view name, which could be invalid. might be better if we can offer very specific message. (not blocking this, we can add this as a follow up,if needed)" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "I'd rather just send the parameter twice than break encapsulation here. There's already precedence with webelement IDs" }, { "prediction": "I don't think this is used.", "reference": "You may put 'open-mmlab://res2net101_v1d_26w_4s' here. MMCV will be updated later." }, { "prediction": "I don't think this is needed.", "reference": "May be worth making this more specific, to avoid potential conflicts, maybe `pagespeedDashboardWidget`? Or `webVitalsDashboardWidget`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I guess this assignment is now redundant?" }, { "prediction": "I'm not sure if this is the right place to call into the specific backend. I'm not sure if this is the right place to call into the specific backend, but if it's the right place to call into the specific backend, I'm not sure if it's the right place to call into the specific backend. If it's the right place to call into the specific backend, I'm not sure if it's the right place to call into the specific backend.", "reference": "See above note re: blockNum synchronization." }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "wonder if we could avoid doing named imports if we type aliased `backoff.Backoff` in the `.../agent/common/backoff` package?" }, { "prediction": "I'm not sure why this is removed.", "reference": "Or maybe put into alphabetical order with the other #includes." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This runs the entire duration of the program; this change is not needed." }, { "prediction": "I don't think this is needed.", "reference": "I don't feel well about the `ALWAYS_UPDATE` option   sounds like a workaround. I can imagine that some of the plugins want to observe all options. Maybe, in that case, we can reuse the `CONFIG_KEYS` that would return an empty array for observing all settings and `false` for disabling observing at all? I just thinking aloud - Like `CONFIG_KEYS` sounds reasonable. We could support and maintain it in the future, even after implementing the \"observability\" to the MetaManager then `ALWAYS_UPDATE`... I don't know :)" }, { "prediction": "I think this should be `clang-format off`.", "reference": "A \"tab difference\"? As in, there are tab characters somewhere? This disabling of clang-format for all the code here seems like overkill. Are you sure there's not some other solution? I don't really understand the problem though. Do you mean clang-format-diff?" }, { "prediction": "Please revert this change.", "reference": "Could you please leave the explicit imports?" }, { "prediction": "I think this should be `if (methodConfigMap.get(methodConfigProto.getName())!= null) { continue; } else { methodConfigs.add(methodConfigMap.get(methodConfigProto.getName())); }`", "reference": "Can we check for containsKey here?" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `--help` or `--help` or `--help` or `--help` or `--help` or `--help` or `--help` or `--help` or `--help` or `--help` or `--help` or `--help` or `--help` or `--help` or `--help` or `--help` or `--help` or `--help` or `--help` or `--help` or `--help` or `--help`` or `--help` or `--help` or `--help`` or `--help` or `--help` or `--help`` or `--help` or `--help`` or `--help` or `--help`` or `--help` or `--help` or `--help`` or `--help` or `--help` or `--help`` or `--help` or `--help` or `--help`` or `--help` or `--help` or `--help``", "reference": "Exit successfully. We served the help the user wanted." }, { "prediction": "I'm not sure if this is the right thing to do here. I'm not sure if it's the right thing to do here.", "reference": "Had to rename this because `InitialPackage()` already existed." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Can we put this in a different helper?" }, { "prediction": "I'm not sure if this is a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug.", "reference": "I'm not sure where your 31 comes from? I see 15 here and 2 above for pc and flags, for 17 total beyond the SIMD." }, { "prediction": "I don't think this is needed.", "reference": "If you want, you could change this to `allowCors(response` (like in \"version\", above) to allow Cross-Origin Resource Sharing. I'm sort of wondering what's returned if no API terms of use are set." }, { "prediction": "I don't think this is needed.", "reference": "Why do we need to override this if all we're doing is passing it up?" }, { "prediction": "I don't think we need to send all controls.", "reference": "Just wondering whether it's safe to send all CQDs to the child compiler. As this missing CQD is causing trouble, maybe some other user CQDs that now get sent could also cause the statement to fail? Also, if I have a table with a nullable unique column, should I have to set this CQD to create another table like it, or should the CREATE TABLE LIKE work without the CQD?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "EARLIEST_TESTED_RELEASE might be slightly more clear" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `bpylint` or `bpylint` here.", "reference": "I think replacing `.*` with `\\s*` from after the hash makes sense, but not the rest of the changes." }, { "prediction": "I think this should be `varint,7,opt,name=enableLogging`", "reference": "interesting.. did not know varint tag covered bool as well" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Could you please elaborate the reason for not using `gkc_summary` like the values above? I ask this, because I assume what we want to collect is a histogram of event loop latency, and we use `gkc_summary` for collecting histograms." }, { "prediction": "I don't think we need to change this.", "reference": "getHash should be a public and without an `_` if used here." }, { "prediction": "I think this should be `if blk.Height == 0 { return nil } else { return nil }`", "reference": "Unrelated to these changes -- we will probably want some special handling for genesis block validation." }, { "prediction": "I think this should be `float64` or `float32`", "reference": "This is probably overkill since we don't actually need to pass this specific interface anywhere, but I don't mind it!" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "@janos I moved this back here, to avoid having multiple add peer calls being handled. I think it's either this or a global lock across the whole function. I think this is a better approach, especially since `hive.Broadcast` is blocking. We can remove the map entry on errors if needed. LMKWYT?" }, { "prediction": "I think this should be `<%= link_to \"Approve\", approval_response_path(approver_action: 'approve', cart_id: cart.id, scheme: 'https', user_id: current_user.id, ) %>`", "reference": "Minor: can we put the conditional outside of the partial?" }, { "prediction": "I don't think we need to check for `isinstance(offline, PacketList)` here.", "reference": "We need to find something more efficient than this. We can probably just check the first element and assume the type list is consistent.." }, { "prediction": "I'm not sure if this is a task or a task. I'm not sure if it's a task or a task. I'm not sure if it's a task or a task, but if it's a task or a task, it's a task.", "reference": "How \" via service code in response to event.\"? I don't think we'll get in the no schedule option to the release. We should probably wait for some customer feedback first to make sure we're addressing different event-triggers the best way" }, { "prediction": "I don't think we need this anymore.", "reference": "Please move unrelated formatting changes to their own PR (same with the resources.py file)." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Make this a public attribute (remove the leading `_`) if you want to access it from the outside." }, { "prediction": "I don't think this is needed.", "reference": "this conditional is useless now so it should be removed" }, { "prediction": "I think this test should be `static_cast(i+1)`", "reference": "`vecofstructs->size()` already returns a `uoffset_t`. So if you just change the type of `i`, you don't need any casts." }, { "prediction": "I don't think we need to do this. I'm not sure if we need to do this.", "reference": "Nit: Maybe merge this with the configProto check on line 208? Don't feel that strongly though, please keep separate if you prefer." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I know we already did this in 4.0 so carry on, but I'm facepalming here we should've made an overrided setMessageHandler that sets ismaster to true when hello is present. Esp in 4.0 where we already have some overrides written. We can keep going here and maybe open a ticket to some effect of that solution" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I believe we could use `link_to` here (although not super important). Also, we should internationalize this value. I'm not 100% sure what our process is for adding new UI strings these days (e.g. skip the specs that will fail if we add a new key to only one language, use Google Translate to translate the value for us, some other option)." }, { "prediction": "I'm not sure if this is the right fix. I'm not sure if this is the right fix, but I'm not sure if it's the right fix or if it's the right fix or if it's the right fix or if it's the right fix.", "reference": "This was already in vkGetPhysicalDeviceDisplayProperties2KHR..." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `dockerEngineValidator` interface. I'm not sure if it's a good idea to have a `dockerEngineValidator` interface, but if it's a good idea to have a `dockerEngineValidator` interface, I'm not sure if it's a good idea to have a `dockerEngineValidator` interface. If it's a good idea to have a `dockerEngineValidator` interface, I'm not sure if it's a good idea to have a `dockerEngineValidator` interface, but if it's a good idea to have a `dockerEngineValidator` interface, I'm not sure if it's a good idea to have a `dockerEngineValidator` interface. If it's a good idea to have a `dockerEngineValidator` interface, I'm not sure if it's a good idea to have a `dockerEngineValidator` interface. If it's a good idea to have a `dockerEngineValidator` interface, I'm not sure if it's a good idea to have a `dockerEngineValidator` interface.", "reference": "nit: I'd expect a public method called IsDockerEngineRunning to return a boolean yes/no, not the error message. Can we change either the return value or the name? Something like `CallDockerEngine`" }, { "prediction": "I don't think we need this column anymore.", "reference": "If i remembered correctly, type_name is '{RESOURCE_TYPE}/{RESOURCE_NAME}', if type_name is 700 max then name cannot exceed that size" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this. I'm not sure if it's the right place to do this.", "reference": "When calling functions with keyword arguments: please provide the arguments as keyword arguments, not positional arguments." }, { "prediction": "I don't think we need to change this?", "reference": "We may follow the argument order: conv_cfg, norm_cfg, act_cfg." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "`options['binary'] = WebDriver::Chrome.path` if set?" }, { "prediction": "I don't think this is needed.", "reference": "folly library should be put on the top." }, { "prediction": "I don't think we need to check for `name!== (name = name.replace(/^xlink:?/, '')));`", "reference": "Do we have to restrict this to SVG elements? I think setting namespaced attributes on normal dom elements (while not as common) is still valid, so perhaps we can save some bytes by removing the `isSvg` check?" }, { "prediction": "I think we should move this logic to `RowIndexMapper.isHiddenRow(row)` so that we don't have to worry about `rowIndexMapper.isHiddenRow(row)` and `rowIndexMapper.isHidden(row)`", "reference": "Please add it to the `REMOVED_HOOKS` constant." }, { "prediction": "I don't think this is needed.", "reference": "This variable needs `.v1` at the end of it, or the tests below need it. There are some test failures as a result" }, { "prediction": "Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line.", "reference": "Is this access protected so that only admins can access this route?" }, { "prediction": "I don't think this is needed.", "reference": "What happens if the minimum x coord is > 0? This will incorrectly set it as zero, right?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this. I'm not sure if it's the right place to do this.", "reference": "I think you want to look at current pending + batchSize and if that is > o.maxp no?" }, { "prediction": "I'm not sure if we should change this to `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok` or `Ok`", "reference": "Should this be `codes.Error`? `codes.Internal` was an error status before." }, { "prediction": "Layout/MultilineMethodCallIndentation: Indent the first parameter one step more than the previous line.", "reference": "I don't think you need these lines." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "You didn't mean to export this, right?" }, { "prediction": "Line is too long. [89/80]", "reference": "Simple Notification **Service** (singular)" }, { "prediction": "I don't think this is needed.", "reference": "Do we still need this?" }, { "prediction": "why remove this?", "reference": "We do have a disconnect between the privateMarkerTransactionFactory.getSender() call and the createPrivateMarkerTransaction() call. When the plugin receives the call to create the PMT it does not know what the sender was returned by the other call. At a minimum we need to pass in the sender to the second call. I would prefer that the plugin does the locking if that is necessary. If you are using random keys you don't have to lock! Besu could signal to the plugin when a PMT was un- or successfully added to the pool using a callback. Callback could be null if this is not needed. The plugin would have to be able to get the nonce for a certain key from besu. What do you think?" }, { "prediction": "I think this should be `MessageDefaultError` instead of `MessageDefaultError`.", "reference": "This is a bit inconsistent with the `ErrorStartHourGreaterThanEnd` in the previous file. Wouldn't `ErrorDefault``fit better here?" }, { "prediction": "I'm not sure if this is the right place to test network policy stats.", "reference": "I think it will revert the change @antoninbas did on purpose 05eee251c9c53400277def576f92d614ca234898" }, { "prediction": "I'm not sure if this is the right place to use wireguard.cali or wireguard.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali", "reference": "nit: a switch perhaps?" }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "Would it make sense for `opensearch_description_tag` to have default values for the title and href attributes?" }, { "prediction": "I don't think this is the right place to do this.", "reference": "Just noticed this while debugging -- it's unlikely to be causing issues in practice." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "That seems unrelated - did that fix a random test failure you noticed while working on this issue?" }, { "prediction": "I think this should be `doCommit(base, updated);`", "reference": "This kind of concern should be handled in the `TableMetadata` update methods. This is similar to `metadata.rollbackTo`, which not only sets the current version, but also updates the table history. I think that all of those methods should add the current object's `file.location()` to the previous metadata location list, if it is non-null. That way, the caller never needs to remember to update it." }, { "prediction": "I don't think this is needed.", "reference": "We need to know why all the tensors are detached in `get_bboxed`." }, { "prediction": "I don't think this is needed.", "reference": "Unrelated but shouldn't this raise `attribute-defined-outside-init`?" }, { "prediction": "I think this should be `create_no_window=False`.", "reference": "I would rather no have this as a `kwarg` as it encourages \"growth\" which lead to an unweildy constructor in other classes. Let's add a method or property to take care of this instead as I think it's usage is going to be quite low." }, { "prediction": "I don't think we need to do this anymore.", "reference": "You just changed my life :) I grew very attached to this safe nav approach when working with Groovy years ago `obj?.method`. Glad to see its now a part of Ruby!" }, { "prediction": "I don't think this is needed anymore.", "reference": "do you mean 'clearfix' class?" }, { "prediction": "I think this should be `options.causalConsistency=true`", "reference": "`causalConsistency` is already defined on `SessionOptions`. We do not need to duplicate it here." }, { "prediction": "I think this import should be in `org.mockito.ArgumentMatchers.anyString()`", "reference": "This should not be included since there are no code changes." }, { "prediction": "I'm not sure if this is the right place to handle preflight OPTIONS request. I'm not sure if it's the right place to handle preflight OPTIONS request, but if it's the right place to handle preflight OPTIONS request, I'm not sure if it's the right place to handle preflight OPTIONS request. If it's the right place to handle preflight OPTIONS request, I'm not sure if it's the right place to handle preflight OPTIONS request. If it's the right place to handle preflight OPTIONS request, I'm not sure if it's the right place to handle preflight OPTIONS request. If it's the right place to handle preflight OPTIONS request, I'm not sure if it's the right place to handle preflight OPTIONS request. If it's the right place to handle preflight OPTIONS request, I'm not sure if it's the right place to handle preflight OPTIONS request. If it's the right place to handle preflight OPTIONS request, I'm not sure if it's the right place to handle preflight OPTIONS request. If it's the right place to handle preflight OPTIONS request, I'm not sure", "reference": "If all we need just response 200, then we could use `c.Status(http.StatusOK)` here." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Should be checking for error here" }, { "prediction": "I don't think we need to pass an array here.", "reference": "Put a space between `(array)` and `$this` and I'll merge it" }, { "prediction": "I think this should be `all bool`.", "reference": "You could add this to stack.go, which has similar functions (to avoid yet another small file). None of these are likely to be implemented considering what TinyGo is designed for." }, { "prediction": "I don't think this is needed.", "reference": "the class names `NotificationHolder` and `NotificationsHolder` are fairly difficult to quickly tell apart, particularly since they are often used close to each other" }, { "prediction": "I don't think this is needed anymore.", "reference": "Avoid wildcard imports" }, { "prediction": "I'm not sure if this is the right place to call this function.", "reference": "Need to do this to unblock mockgen. The interface method needs to be public to be visible in another package. The right fix is to delete this test only interface method" }, { "prediction": "I don't think we need to check for loadbalanced here.", "reference": "same question here as I have on the other file regarding doing this check here vs L112 vs not at all" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Adding `// +build!windows` (as a separate line) will do the same for Windows. So while you are at it we might add it as well." }, { "prediction": "I think we should remove this line.", "reference": "this is used as important way of mocking for unit tests, FYI" }, { "prediction": "I don't think we need muted alpha here.", "reference": "Sorry, should have been clearer, I meant adding this to the ``Histogram`` options one line above." }, { "prediction": "I'm not sure why this test is failing. I'm not sure why it fails.", "reference": "Just ignorance on my part, but what is the significance of the change from C23NHe2 to C23NHx2?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `bin_range` or `histogram_range` in the `Histogram` class. I'm not sure if it's a good idea to have a `bin_range` and `histogram_range` in the `Histogram` class.", "reference": "What about tuples or pandas series? Do we want to support lots of different types or force a single type?" }, { "prediction": "I'm not sure why this was removed.", "reference": "Small thing, without the check above this will throw a NoNodeException if the path doesn't exist. Maybe this can be wrapped in a try/catch just for the NoNodeException, so that the more user-friendly message used above can be thrown instead: `throw new KeeperException.NoNodeException(\"No collection found at path: \" + path);` Just a thought, I'm not even sure it's worth it." }, { "prediction": "Line is too long. [89/80]", "reference": "I don't know why this worked before, but we should be explicit on not verifying that a blank string (allowed as a way to remove a url/download_url) is a valid url as it is not." }, { "prediction": "I'm not sure if we should deprecate this in Bolt 3.0.", "reference": "Do we want to raise an error here instead of warning? Or would it be better to just see if Bolt happens to succeed, and let it fail on it's own if it fails? I'd lean towards raising an error, but that's different from \"removing support\"." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "This is kind of confusing with the other `filter_options`." }, { "prediction": "I'm not sure if this is the right place to handle favorites. I'm not sure if this is the right place to handle favorites, but I'm not sure if this is the right place to handle favorites. I'm not sure if this is the right place to handle favorites.", "reference": "Could the `deleteFromFavorites` happen when `head == nil` because it's not initialized yet somehow but not because TLF doesn't exist? I was concerned if this would make it possible in any way to have favorites seemingly deleted on a device while it's not actually happened on server." }, { "prediction": "I don't think this is needed anymore.", "reference": "It doesn't look like this particular \"rowCount\" variable is used anywhere. I suppose we could delete it. The code change is harmless though." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Hmm, probably we should instead write whatever `status` is returned instead of coding a special case." }, { "prediction": "I don't think we need this.", "reference": "Could using the pointer-to-struct approach here cause confusion later? We've had several problems of that kind in the past. What does it mean if the struct is non-nil but its fields are nil? Is that even allowed? (libcalico-go question) Are there any validation requirements for this new rule addition; should it only be allowed if `Protocol == TCP`, for example?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "why this recursive relationship definition?" }, { "prediction": "I'm not sure if this should be optional or not.", "reference": "More sentence, less list please. > Encoding of the handler. This field is optional. We don't need to mention exactly what it's used for because that list can expand (as it has already in this change)." }, { "prediction": "I don't think we should remove this line.", "reference": "Not part of this PR, but should the section above say what the name of the metric is for each method?" }, { "prediction": "I don't think this is needed.", "reference": "there are changes that are upcoming to this section. For now, this works (to demo the usage of Gauge), and the changes to this section are coming as separate PRs." }, { "prediction": "IsProcessBackground() is not needed anymore?", "reference": "This is equivalent to stdout. Why not just replace stdin with stdout in `IsProcessBackground`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "Rather than test for nullptr, just treat the pointer as a bool, i.e. `if(p_jmsg[\"compress_method\"])`" }, { "prediction": "I think this should be `if (!executablePath.startsWith(getContainersPath())) { Platform.runLater(() -> createShortcut(executablePath, getContainersPath())); } else { Platform.runLater(() -> createShortcut(executablePath, getContainersPath())); }`", "reference": "Can we move the remaining code of this method to a new method? I don't like the `return;` here, we could try to replace it with an `if... else...` syntax. What do you think?" }, { "prediction": "I'm not sure if this is the right place to put this in.", "reference": "nitpick: _and collections_" }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if this is the right thing to do. I'm not sure if this is the right thing to do, but if it's the right thing to do, I'm not sure if it's the right thing to do, but if it's the right thing to do, I'm not sure if it's the right thing to do. If it's the right thing to do, I'm not sure if it's the right thing to do, but if it's the right thing to do, it's the right thing to do.", "reference": "I believe these need to be explicitly initialized in `proxy_send_prepare`" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This is unnecessary. The declaration of `t0` on line 179 is still in scope inside the `except` block." }, { "prediction": "I don't think this is needed. I think it's better to add a `@beautiful beautiful.border_color_marked` attribute to the `request::border` object and add a `@beautiful beautiful.border_color_marked` attribute to the `request::border` object.", "reference": "The `border_color_`... properties don't support solid colors, not only this one. Maybe `@param solid_color` should be used instead of adding this note to every one of them?" }, { "prediction": "I don't think this is needed.", "reference": "We don't need this file, we can use the one that is in the grid-ui directory" }, { "prediction": "I think this should be `if (path.endsWith(\"/\")) { //.bazelignore allows the \"/\" path suffix, but WorkspacePath doesn't. //.bazelignore allows the \"/\" path suffix, but WorkspacePath doesn't. //.bazelignore allows the \"/\" path suffix, but WorkspacePath doesn't. //.bazelignore allows the \"/\" path suffix, but WorkspacePath doesn't. //.bazelignore allows the \"/\" path suffix, but WorkspacePath doesn't. //.bazelignore allows the \"/\" path suffix, but WorkspacePath doesn't. //.bazelignore allows the \"/\" path suffix, but WorkspacePath doesn't. //.bazelignore allows the \"/\" path suffix, but WorkspacePath doesn't. //.bazelignore allows the \"/\" path suffix, but WorkspacePath doesn't. //.bazelignore allows the \"/\" path suffix, but WorkspacePath doesn't. //.bazelignore allows the \"/\" path suffix, but WorkspacePath doesn't.", "reference": "FYI: inlined this method in the internal review." }, { "prediction": "I don't think this is needed anymore.", "reference": "Werid, the checksum between this file and the one on branch `develop` is the same not sure why it's showing a diff" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to change the name of the metric, but if it's a good idea to change the name of the metric, I'm not sure if it's a good idea to change the name of the metric, or if it's a good idea to change the name of the metric, or if it's a good idea to change the name of the metric. I'm not sure if it's a good idea to change the name of the metric, but if it's a good idea to change the name of the metric, I think it's a good idea to change the name of the metric.", "reference": "Prometheus doesn't have concept of Meter (like OTLP does).. Trying to see if this is a good approach to use the meter name as namespace, to avoid name collisions, when same instrument name is used across multiple instruments, from different Meter." }, { "prediction": "I don't think we need to check if `$config->Catalog == $config->Catalog && $config->AuthManager()->getAuthMethod() == 'Shibboleth'`", "reference": "The formatting of this is a bit strange; I'd suggest collapsing this back to a single line, and moving the `&&` to the beginning of the second line to meet the line length restriction." }, { "prediction": "I'm not sure if this is the right place to use memcpy.", "reference": "One or the other should be non-NULL. If segments is NULL, the alloc above will have size zero, which we do not allow (there's no header): it should assert in debug build. So there should be asserts that one is non-NULL at the top, and if there really needs to be some kind of defensive check down here, it should cover the alloc too." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but I'm not sure if it's the right place to do it.", "reference": "I'm surprised rubocop isn't picking up singe quotes?" }, { "prediction": "I think this should be `time.ParseTime(\"unixTimestamp\", \"2016-09-27T15:50Z\")` and not `time.ParseTime(\"unixTimestamp\", \"2016-09-27T15:50Z\")`", "reference": "Is this line still needed?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Maybe use specific values for all the watt.times fields? Even better, have a const for it at the top of the file?" }, { "prediction": "I'm not sure if this is the right place to put this in.", "reference": "nit: UNICODE_BRAILLE_TABLE or something might be a better name for this. IMO, braille-patterns.cti is a terrible name. This table allows Unicode braille characters to be used anywhere to produce raw dots." }, { "prediction": "I'm not sure why this was removed.", "reference": "Why are we removing the option to skip machine pool generation?" }, { "prediction": "I don't think we need to expose this interface. I'm not sure if we need to expose it.", "reference": "\"Request line\" here too." }, { "prediction": "I don't think this is needed.", "reference": "Please remove this." }, { "prediction": "I think we should move this to `Account.paginate_by_sql` and use `Account.paginate_by_sql` instead of `Account.paginate_by_sql`", "reference": "Weird bug. Combining those joins and group calls was triggering AREL to generate the sql cache inside of will_paginate before the final call. This is a harmless workaround, but hints that will_paginate might becoming seriously deprecated." }, { "prediction": "Line is too long. [89/80]", "reference": "This can be simplified as discussed before." }, { "prediction": "I don't think we need this.", "reference": "Does `internal` or `test` in the file name actually do anything here? Or is that just to show these functions are only for tests?" }, { "prediction": "I'm not sure if this is the correct test.", "reference": "does this boolean indicate unsafe serialization?" }, { "prediction": "I don't think we need this method anymore.", "reference": "Maybe rewrite to `Is only implemented for React Native`? (I assume that is the case)." }, { "prediction": "I think this should be `ResourcesField!= null &&!resourcesField.isMap() &&!resourcesField.isMap() &&!resourcesField.isMap() &&!resourcesField.isMap() &&!resourcesField.isMap() &&!resourcesField.isMap() &&!resourcesField.isMap()) { pageSizeField = methodModel.getInputField(pagingParams.getNameForMaxResults()); } else if (language == TargetLanguage.JAVA && transportProtocol == TransportProtocol.HTTP) { pageSizeField = methodModel.getInputField(pagingParams.getNameForMaxResults()); } else if (language == TargetLanguage.PHP && transportProtocol == TransportProtocol.HTTP) { pageSizeField = methodModel.getInputField(pagingParams.getNameForMaxResults()); } else if (language == TargetLanguage.PHP) { pageSizeField = methodModel.getInputField(pagingParams.getNameForMaxResults()); } else if (language == TargetLanguage.JAVA) { pageSizeField = methodModel.getInputField(pagingParams.getNameForMaxResults()); } else if (language == TargetLanguage.PHP) { pageSizeField = methodModel.getInputField(pagingParams.getNameForMax", "reference": "Do we not need this in Java because Java *is* handling map responses?" }, { "prediction": "I'm not sure if this is the right thing to do, but I think it's better to add a `accept_messages` method to the Task class.", "reference": "Maybe \"For configuring which scheduler messages can be received.\"?" }, { "prediction": "I don't think we need to clear entity manager for saving memory.", "reference": "It will stop working with orm, so this is not a good fix, Try using some method in a common interface" }, { "prediction": "I'm not sure if this is the right place to add diagnostic listeners. I'm not sure if it's the right place to add diagnostic listeners, but if it's the right place to add diagnostic listeners, I'm not sure if it's the right place to add them.", "reference": "`s` is not necessarily the same as `sampler` - sampler could be null and this crazy lambda underneath falls back to something. So please use `s`" }, { "prediction": "I think this should be done in a separate PR.", "reference": "This code is a bit confusing. Should HttpParameterType set to the original one or it is always BODY?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Why did this change?" }, { "prediction": "I don't think we need to create a new proto for table status. I think we should create a new proto for table status and create a new proto for table status.", "reference": "nit: `status` collides with imported package named `status`" }, { "prediction": "IsWritingCatchpointFile returning true when a catchpoint file is being generated?", "reference": "\"memory pressure could be decreased\" --> \"to avoid memory pressure\"" }, { "prediction": "I don't think this is the right place for this test. I think it's better to use `db_user.get_or_create(uid, \"user_%d\" % uid)` instead of `db_user.get_or_create(uid, \"user_%d\" % uid)`", "reference": "I think it would make sense to fetch the cache values after deleting the listens and making sure they are what we expect." }, { "prediction": "I don't think this is needed.", "reference": "I'm thinking about covering this change with the test. Can you do that?" }, { "prediction": "I don't think we need to pass cPorts here.", "reference": "Not sure if it's a good idea to remove stop channel. If user cancels connection how will you stop pinger?" }, { "prediction": "I'm not sure if this is the right place to use docker.AuthConfiguration.", "reference": "Could you please add a `TODO` here that we won't need `docker.AuthConfiguration` anymore when we migrate to SDK's pull image?" }, { "prediction": "I don't think this is needed.", "reference": "Is there a scenario were we want to get an arbitrary set of blobs that don't share a common root?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Can you leave a note about why we are skipping regex tests?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This was the only caller of CreateRepo, so I inlined it." }, { "prediction": "I'm not sure if this is a good idea. I think it's a good idea to add a `AuthPath` field to the VaultAuth struct. I'm not sure if it's a good idea to add a `AuthPath` field to the VaultAuth struct, but if it's a good idea to add a `AuthPath` field to the VaultAuth struct, then I think it's a good idea to add a `AuthPath` field to the VaultAuth struct to make it clear that it's a good idea to add a `AuthPath` field to the VaultAuth struct to make it clear that it's a good idea to add a `AuthPath` field to the VaultAuth struct to make it clear that it's a good idea to add a `AuthPath` field to the VaultAuth struct to make it clear that it's a good idea to add a `AuthPath` field to the VaultAuth struct to make it clear that it's a good idea to add a `AuthPath` field to the VaultAuth struct to the VaultAuth struct.", "reference": "As this is already a child of `auth`, I think we can shorten this to `path`" }, { "prediction": "I don't think this is necessary.", "reference": "This call should use element, not 0 I think." }, { "prediction": "I'm not sure if this is a good option. I'm not sure if it's a good option, but if it's a good option, I think it's a good option. I'm not sure if it's a good option, but if it's a good option, I think it's a good option.", "reference": "This is missing the definition of `fetch_until_empty_page` - it needs to go in the config section above." }, { "prediction": "I'm not sure if this is the right place to use `File.expand_path?(path))` or `File.expand_path?(path)`", "reference": "I don't think this one needs to be changed since the only previous path is already an absolute one." }, { "prediction": "I don't think we need to pass locationProvider here.", "reference": "Since we kept the original constructor we might not need this change now." }, { "prediction": "I think this should be `LOG.debug(\"Refreshed [{}]\", fullName);`", "reference": "There is already a log in `BaseMetastoreTableOperations` for this. It has the location, but not the table name. Maybe just add table name to that one." }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "This should be in the last group." }, { "prediction": "I think this should be `_statsd?.Send();`", "reference": "I believe you should either remove this or rename the PR. You can't change the behavior of the tracer (even to fix a bug) in a PR named \"unit test improvements\"" }, { "prediction": "I don't think we need to add this to the `certmanager.k8s.io` file.", "reference": "I've gone with this group name, however I'm open to suggestions on alternatives!" }, { "prediction": "I don't think we need this?", "reference": "should this be GOQUORUM" }, { "prediction": "I'm not sure if this is the correct way to do this.", "reference": "I think checkCoinbase is not skipping checking coinbase. Instead, true-> checking num(coinbase tx) = 1, false -> checking num(coinbase tx) = 0." }, { "prediction": "I don't think this is needed anymore.", "reference": "same here, move it out" }, { "prediction": "I'm not sure about this, but I'm not sure if it's a good idea.", "reference": "Can you elaborate on why you need different behavior depending on Tools being built independently or not?" }, { "prediction": "Line is too long. [89/80]", "reference": "because of the above if statement will requires both ex_save and guid_save to be true, this code will always return 'example answer'. This should be revised with `example_answer.present?` and `guidance.present?`" }, { "prediction": "I don't think this is needed.", "reference": "why not context from stdlib?" }, { "prediction": "I'm not sure if we should change this to `Proto3Binary` or `Proto3Binary`?", "reference": "Just saw this and wasn't able to hold myself from renaming :-)." }, { "prediction": "I'm not sure if this is the right way to test this.", "reference": "Can we keep the other assertion too? I think it's helpful to ensure that the uninstall function was called too" }, { "prediction": "I'm not sure if this is the right place for this warning, but I'm not sure if it's the right place for this warning, or if it's the right place for this warning, or if it's the right place for this warning, or if it's the right place for the warning, or if it's the right place for the warning, or if it's the right place for the warning, or if it's the right place for the warning, or if it's the right place for the warning, or if it's the right place for the warning, or if it's the right place for the warning, or if it's the right place for the warning, or if it's the right place for the warning, or if it's the right place for the warning, or if it's the right place for the warning, or if it's the right place for the warning, or if it's the right place for the warning, it's the right place for the warning.", "reference": "`warn_with` prefixes the message with `WARNING:`, right? So this will put `WARNING:` twice. It would be good to verify all the warnings look good after this change, given how easy it is to make a simple mistake like this :(." }, { "prediction": "I think this should be `message *types.SignedMessage` or `message *types.SignedMessage`", "reference": "FYI In the message queue I use the term \"stamp\" to refer to the time-like mark associated with each message. It's opaque to the queue/pool and should make no difference if the stamps and age limit were converted to seconds. So this could then become `Stamper` with `CurrentStamp()` method, no reference to \"blocks\" or height etc. The wrapper struct could be `StampedMessage. The interpretation as block height is deferred to the user/constructor that hooks things up, the \"business logic\". This is just an observation, take or ignore as you wish." }, { "prediction": "I'm not sure if this is the right place to do this, but I think it's better to move this logic into `get_lifecycle` and use `get_lifecycle_from_bucket_name` in `get_lifecycle_from_bucket_name` instead of `get_lifecycle_from_bucket_name` in `get_lifecycle_from_bucket_name` and then call `get_lifecycle_from_bucket_name` in `get_lifecycle_from_bucket_name` to `get_lifecycle_from_bucket_name` and then call `get_lifecycle_from_bucket_name` in `get_lifecycle_from_bucket_name` in `get_lifecycle_from_bucket_name` and `get_lifecycle_from_bucket_name` in `get_lifecycle_from_bucket_name` in `get_lifecycle_from_bucket_name` and `get_bucket_name` in `get_lifecycle_from_bucket_name` and `get_bucket_name` in `get_lifecycle_from_bucket_name` and `get_bucket_name` in `get_lifecycle_from_bucket_name`.", "reference": "Can we remove the `TODO` statement here? (as this is actually fixed in this PR)" }, { "prediction": "I don't think this is needed.", "reference": "m prefix no longer in code style" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "need to filter the entities in buffer as well" }, { "prediction": "I don't think this is needed anymore.", "reference": "Please add spaces before and after the equals sign" }, { "prediction": "I don't think this is needed anymore.", "reference": "This file could also be cleaned up/deleted. But lets do this separately after ensuring all the event logging has been ported to the current logmxevent_traf.cpp file completely." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for this, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, I'm not sure if it's the right place for it, or if it's the right place for it, but if it's the right place for it, it's the right place for it.", "reference": ":thinking:, the line number here is the line of the example (`example.location`), that's probably why I finally chose to display the example title because it's what can be found on this line, and saying that the error is from there is confusing. But presenting the actual failures is indeed better, so maybe we can get the failure actual line number from the exception backtrace and then output two distinct lines for failures like this one?" }, { "prediction": "I don't think we need to pass `create_no_window=False` here.", "reference": "We shouldn't add this as a new `kwarg` here. This should all be done on the options class" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea.", "reference": "Should this be `OS_VOLUME_SUPPORT` to match the symbol key names?" }, { "prediction": "I'm not sure if this is needed.", "reference": "In C, file scope variables are already initialized to 0 so the \"= NULL\" is redundant. Not a big deal." }, { "prediction": "I don't think this is needed.", "reference": "on line 40, the `relevantNode` can change and therefore the `doc` might change too for the lookup on line 43. I think this code should be moved to where the `doc` is actually being used" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "nit: just to be similar to others, can you change to interpolation?" }, { "prediction": "I don't think this is needed.", "reference": "Would this make more sense as an option on an Issuer resource (specifically on the CA issuer) rather than as a flag? It's not ideal that we have a flag that _looks_ like it could be 'global' but is actually not IMO. Also, if Istio is reading the CSR object, is it possible for it to read the CA from the CSR itself too and append the two instead? Not sure if we ever decided whether to use annotations for this purpose @JoshVanL?" }, { "prediction": "I don't think we need this.", "reference": "Because this acts as a coordination point between client and server, it should go in core.py instead of const.py (so eventually the server could use it to guarantee that it delivers dates in the expected format)." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "expected statement, found 'else' (and 1 more errors)" }, { "prediction": "I think this should be `FakeIDRandomOrBust(public, private)`", "reference": "IMO this doesn't need to be in the `kbfs` repo. And I don't like setting the byte. We can always compare with the randomly generated `TlfID`." }, { "prediction": "I'm not sure if this is the right name for this module. I'm not sure if it's the right name for this module.", "reference": "What's the difference from ModuleName in `pkg/apis/meta/v1alpha1/types.go`?" }, { "prediction": "I don't think this is needed anymore.", "reference": "We shouldn't be changing this task as we are trying to break our dependency on it and switch to using the shipped version." }, { "prediction": "I'm not sure if this is the right place to do this, but I think it's better to do this in a follow up PR.", "reference": "Shouldn't we have a low bar for generating out-of-line context switch, i.e., if we need save more than n (3?) simd or m (4) gprs we should go out-of-line? And it should be || instead &&. It seems the bar is still very high after this change." }, { "prediction": "I think we should move this file to the `sdk/instrumentation.go` file.", "reference": "Should the API have a dependency on the SDK?" }, { "prediction": "I'm not sure if this is the right place to test this, but I'm not sure if it's the right place to test this.", "reference": "Is this a sometimes leaky test?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "It should be possible to create a test case that enter the loop. That would be a good enough test case for me. Have a look at the extern type inference test cases that already exist. Since you can just pick the type variables the extern type use, you should be able to create a conflict that requires this loop to fix." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "It might make sense to log this." }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "Line is too long. [84/80]" }, { "prediction": "I think this should be `goog:chromeOptions`", "reference": "nice touch since Google likes to change things every now and then." }, { "prediction": "I don't think this is needed.", "reference": "Thank you this is so much nicer than the old `Rails.configuration.branding['blah']['blah']['blah']` :)" }, { "prediction": "I don't think we should add this to the `Resource` class.", "reference": "nit: Would you mind alpha-sorting this?" }, { "prediction": "I think this should be `manifest.content() == ManifestContent.DATA`.", "reference": "For my understanding, the DATA manifest & DELETE manifest could share the same read / write path so I think we could use the common reader+writer. Is there any other reason that we need to make them separate paths?" }, { "prediction": "Line is too long. [89/80]", "reference": "that change should be sufficient for avoiding the override of contact_us_url helper. The one defined at the.yml it is within a hash so no problem should arise." }, { "prediction": "I think this should be `Element hinzuf\u00fcgen` instead of `Element hinzuf\u00fcgen`", "reference": "We actually had a discussion about this exactly in #3470, some languages seem to go for one, some for the other" }, { "prediction": "I think we should add a `GrpcStreamingDetailView` to `DynamicLangXApiView`", "reference": "Is PHP the first dynamic MVVM language with grpc streaming support?" }, { "prediction": "I'm not sure why this is needed.", "reference": "the `if` isn't necessary here; it's safe to call `delete` on `nullptr`" }, { "prediction": "I don't think this is needed.", "reference": "Change if the method's name finally changes to `clear_history` as proposed elsewhere" }, { "prediction": "I'm not sure if this is the right place to use `docutils.getDocFilePath(\"userGuide.html\")` or `docutils.getDocFilePath(\"userGuide.html\")`", "reference": "can this one also be moved to the top of the file?" }, { "prediction": "I'm not sure if this should be `GroupMembers` or `GroupMembers`", "reference": "So if I understand this correctly the externalEntities should be computed and stored in GroupMember, while current code usage of GroupMemberPod will be migrated to GroupMember later?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Don't we have tests to change after this breaking change? probably we're not using hard coded strings in our tests when we create a `Span`?" }, { "prediction": "I was not able to find any reference for this.", "reference": "will this fail if the env variable doesn't exist? Is this the preferred behaviour?" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if this is a good idea.", "reference": "bad line wrap" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "What does the `8` here represent? Can you give it a name?" }, { "prediction": "I don't think this is needed.", "reference": "`MPRester(os.environ[\"MP_API_KEY\"])` can be left simply as `MPRester()` and it will pick up the API key from the environment. What is the purpose of this file otherwise? Is it better suited for `dev_scripts`, or a test?" }, { "prediction": "Line is too long. [89/80]", "reference": "Looks like there may be more changes to this file than intended?" }, { "prediction": "I think this is a breaking change. I'm not sure if this is a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change.", "reference": "when message type is not expected, contine to next loop instead of return to finish infinite loop" }, { "prediction": "I don't think this is needed.", "reference": "This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards." }, { "prediction": "I'm not sure if this is the right place to delete the instanceID.", "reference": "instanceID should stay the same for a AWSMachine?" }, { "prediction": "I don't think this is needed.", "reference": "Since this is a dict don't you want `False` or do we clean that up elsewhere?" }, { "prediction": "I don't think this is needed.", "reference": "what's the reason you had to add the `host` argument to all `get_work` calls?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but I'm not sure if it's the right place to do it.", "reference": "This will never be a dataset so we can simplify the code here" }, { "prediction": "I think we should move this method to `BlockProcessor` instead of `MainnetBlockProcessor`.", "reference": "This should be moved into the PrivacyBlockProcessor instead of adding the constructor here." }, { "prediction": "I'm not sure if it's a good idea.", "reference": "nit: Remove \"insightfilestore\". I think \"insightstore\" is good enough and as I see we are using that name at other places too." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `@round_started` or `@round_count` or `@round_count` or `@round_count` or `@round_count` or `@round_count` or `@round_count` or `@round_count` or `@round_count` or `@round_count` or `@round_count` or `@round_count` or `@round_count` or `@round_count` or `@round_count` or `@round_count` or `@round_count` or `@@round_count` or `@@round_count` or `@@round_count` or `@@round_count` or `@@round_count`", "reference": "It looks like you've removed `bisect_round_finished` but kept `bisect_round_started`. Seems a little odd that they aren't paired. Not sure if there's anything to do about that though..." }, { "prediction": "I think this should be `set_perc.throttle_set(-1)` instead of `set_perc.throttle_set(-1)`", "reference": "I'm not sure how to fix the lint and mypy warnings on this line. I could just ignore them, but I feel like the linter should know this exists." }, { "prediction": "I'm not sure if this is the right thing to do, but it seems like it should be `SKIP_SESSION` instead of `SKIP_SESSION`.", "reference": "why remove `Symbol`?" }, { "prediction": "I'm not sure if this is correct. I think it should be `\u00a3\u00a2\u00a5\u00a7\u20ac()*+,\\-.\\/:;<=>?@\\[\\u2000-\\u206F\\u2E00-\\u2E7F\\\\'!\"#$%&()*+,\\-.\\/:;<=>?@\\[\\]^_`{|}~\u00b1]/g`", "reference": "Why are currency signs considered punctuation? They technically fall under the BMP range for Currency Symbols `\\u20A0-\\u20CF` (covered in `getUnicodeNonBmpRegExp`, which is itself a misnomer)" }, { "prediction": "I don't think this is needed.", "reference": "You have forgotten a coma `,`" }, { "prediction": "I don't think we need to change the name of img_meta. I think we should rename img_meta.filename to img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename'] or img_meta['filename']", "reference": "For different datasets, we may want to save the images differently. Sometimes the datasets are categorized into several subfolders, and we want to keep it when saving visualization results, and sometimes we just want to save all images in `out_dir`. An argument may be added to control the behavior." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "if `other` could have a guaranteed `0` byte in it, this whole `if` could be removed, and above you could just add `|| c2 == '\\0'` to get the same effect?" }, { "prediction": "I don't think this is needed.", "reference": "nit: can this be a primitive value?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This maybe not what we want. If `rewrite` occurred before, `r.URL.Path` contains the result and we should use it. Otherwise `rewrite` middleware will disfunction when combining with `browser`." }, { "prediction": "I'm not sure if this is the best way to do this, but I think it's better to add a `self.reporters += self.services` to the `Engine` class.", "reference": "Why change this?" }, { "prediction": "I don't think this is needed anymore.", "reference": "_nitpick_ Isn't it now actually NotLogFakeHttpExceptions**Error**Listener?" }, { "prediction": "I'm not sure if this is the right place to set the resource type.", "reference": "Why not just look for the \"type\" property instead of creating a ResourceType property?" }, { "prediction": "I don't think we need to pass ChainID here.", "reference": "should use `bc.config.Blockchain.ChainID`" }, { "prediction": "I don't think we need this property anymore.", "reference": "this doesn't need to know about NativeClient" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `rule_name` or `resource_name` field in the `ViolationAccess` class.", "reference": "I know we discussed if we should add in the resource_name to the hash, and I actually don't think it's required. The violation hash was recently updated (not released) to include the violated rule, so when the next release goes out, user's findings will get updated. The resource name doesn't hurt to have here, but not required." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "The variable name is also misleading imo. The width from the buffer comes from `wl_shm_buffer_get_width` (or a similar EGL thing), which is what gets encoded into `surface->texture->width`." }, { "prediction": "I think this should be `self.data['artist_msid'], self.data['recording_msid'], self.data['artist_name'], self.data['recording_name'], self.data['artist_name'], self.data['artist_name'], self.data['recording_msid'], self.data['artist_name'], self.data['recording_msid'], self.data['artist_name'], self.data['recording_name'], self.data['artist_name'], self.data['recording_msid'], self.data['artist_name'], self.data['recording_name'], self.data['artist_name'], self.data['recording_msid'], self.data['artist_name'], self.data['recording_msid'], self.data['artist_name'], self.data['recording_msid'], self.data['artist_name'], self.data['recording_msid'], self.data['artist_name'], self.data['recording_msid'], self.data['recording_msid'], self.data['artist_name'], self.data['recording_msid", "reference": "Why are you using these tags to carry these msids?" }, { "prediction": "I'm not sure why this is needed.", "reference": "flb_strdup() should do the work here. note: use Fluent Bit memory wrappers" }, { "prediction": "I think this should be `go:generate sh -c \"protoc -I. -I \"$(go list -f '{{.Dir }}' -m github.com/gogo/protobuf)/protobuf\" --gogofaster_out=. retrieval.proto\" --gogofaster_out=. retrieval.proto\" --gogofaster_out=. retrieval.proto\" --gogofaster_out=. retrieval.proto\" --gogofaster_out=. retrieval.proto\" --gogofaster_out=. retrieval.proto\" --gogofaster_out=. retrieval.proto\" --gogofaster_out=. retrieval.proto\" --gogofaster_out=. retrieval.proto\" --gogofaster_out=. retrieval.proto\" --gogofaster_out=. retrieval.proto\" --gogofaster_out=. retrieval.proto\" --gogofaster_out=. retrieval.proto\" --gogofaster_out=. retrieval.proto\" --gogofaster_out=. retrieval.proto\" --gogofaster_out=.proto\" --", "reference": "This line should be separated from the package declaration by one line as it is not the package description." }, { "prediction": "I'm not sure if this is the right place for this test.", "reference": "shadow: declaration of \"err\" shadows declaration at line 410 (from `govet`)" }, { "prediction": "I don't think we need this anymore.", "reference": "Maybe next time better to make separate PR?" }, { "prediction": "I don't think we need to check if det_bboxes is a list.", "reference": "line 316 also handles this case, need to simplify the logic." }, { "prediction": "I'm not sure if this is the right place to use `gcp.HTTPClient` and `gcsblob.OpenBucket: client is required`", "reference": "We used to have a simple check for bucket and object names, we then decided to remove it and rely on the backend service to check for the name. Is there any reason to add an empty name check now?" }, { "prediction": "I think this should be `std::chrono::duration_cast(max_blocking_time_point - std::chrono::steady_clock::now());`", "reference": "Line too long" }, { "prediction": "I don't think we need to do this. I don't think we need to do this.", "reference": "This isn't aligned though." }, { "prediction": "I don't think this is a test-time augmentation. It's a test-time augmentation test-time augmentation test-time augmentation test-time augmentation test-time augmentation test-time augmentation test-time augmentation test-time augmentation test-time augmentation test-time augmentation test-time augmentation test-time augmentation test-time augmentation test-time augmentation test-time augmentation", "reference": "it is mean -> it means PAAHead does not support test-time augmentation." }, { "prediction": "I don't think we need to import `bibdocfile.registry`?", "reference": "@lnielsen-cern thanks. I missed it :(" }, { "prediction": "I don't think we need to change this?", "reference": "@tofumatt, has it been changed intentionally? It doesn't seem to be required in IB, plus we haven't had `content-drilldown` before... If it has been changed intentionally, then should we update the `AnalyticsDashboardWidget` component to be use `content-drilldown` instead of `content-pages` as well?" }, { "prediction": "I don't think we need to import retrying from google.cloud.security.common.gcp_api.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying.Retrying", "reference": "nit: don't think an extra line is needed here; as retrying is an installed library and should be grouped with the rest of the installed library." }, { "prediction": "I think this should be `EnableAdminAPI`", "reference": "This should be a bool" }, { "prediction": "I think this is a breaking change. I'm not sure if this is a breaking change or if it's a breaking change or if it's a breaking change, but if it's a breaking change, it's a breaking change.", "reference": "`if (llvm::dyn_cast_or_null(GetSwiftType(compiler_type).getPointer())`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "The `generateVariantWorkloadManifests` function below relies on the config manifests specified in Git, but it was passed with the newly created canary's manifests where their name was updated." }, { "prediction": "I don't think this is needed anymore.", "reference": "are this docs neccesary?" }, { "prediction": "I don't think we need to change this?", "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC." }, { "prediction": "I don't think we need to clear the loss weight for the Softmax internal layer.", "reference": "This change suppose to resolve issue #2968. `loss_weight` should be of length 2, the second entry is ignored." }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "Is there an easy way to check for conflict suffix to avoid false positives here?" }, { "prediction": "I'm not sure if this is the right place to use `@context.get_validated_task` or `@context.get_validated_task`", "reference": "`apply_prep.run_task` also seems like it can just use `@context.run_task`" }, { "prediction": "I think this should be `autoFocus(page)`", "reference": "do you have any idea on how to fix it?" }, { "prediction": "I'm not sure if this is the right place to test this, but I'm not sure if it's the right place to test this.", "reference": "You don't need to fix this (you've done so many iterations). But for next time, you can make this into a docstring so it'll have a nicer descriptive name when the tests are running." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to call `EnIAttachment.HasExpired()` or `EnEnIAttachment.HasExpired()` or `EnEnIAttachment.HasExpired()` or `EnIAttachment.HasExpired()` or `EnIAttachment.HasExpired()` or `EnIAttachment.HasExpired()` or `EnIAttachment.HasExpired()` or `EnIAttachment.HasExpired()` or `EnIAttachment.HasExpired()` or `EnIAttachment.HasExpired()` or `EnIAttachment.HasExpired()` or `EnIAttachment.HasExpired()` or `EnIAttachment.HasExpired()` or `EnIAttachment.HasExpired()` or `EnIAttachment.HasExpired()` or `EnIAttachment.HasExpired()` or `EnIAttachment.HasExpired()` or `EnIAttachment.HasExpired()` or `EnIAttachment.HasExpired()` or `EnIAttachment.HasExpired()` or `EnIAttachment.HasExpired()` or `EnIAttachment.HasExpired()` or `EnIAttachment.HasExpired", "reference": "When does 'expiresAt' change? Do you need this?" }, { "prediction": "I don't think this is needed.", "reference": "There are enums for genders + `PLAYERSEX_LAST`." }, { "prediction": "I don't think we need to change this test.", "reference": "Should this use the constants as well? Or intentionally covering the fact that the constants may change" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "The case of a negative size (= keep all elements) was not handled in this function." }, { "prediction": "I think this should be `maxWorkflowTaskTimeout: \"system.maxWorkflowTaskTimeout\"`", "reference": "I think we should keep this dynamic config knob for operations purpose." }, { "prediction": "I'm not sure why this change is needed.", "reference": "Was this intentional? Perhaps this could be replaced with another way to check the offsets?" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it.", "reference": "the buckets are created via the stackset, customers don't need to provide them" }, { "prediction": "I'm not sure if this is the right way to do this. I'm not sure if this is the right way to do it.", "reference": "This doesn't have the same behavior as before. Maybe you want `reverse_merge` (and it either just works or we implement it on `Blacklight::Solr::Request`)" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do this.", "reference": "This should be ` /$(ghc_find #{config[:ghc]})/ ` instead of ` /#{ghc_version}/ `, I think." }, { "prediction": "I don't think we need this anymore.", "reference": "We should deprecate this at some point." }, { "prediction": "I don't think this is needed.", "reference": "Move these two arguments before `loss_cls`." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "[Super NIT]: i := serialNumber if i == 0 { i = mathrand.Int63n(...) }" }, { "prediction": "The tool format of the input file. The tool format of the input file. The tool format of the input file.", "reference": "-f short form here collided with --force. :)" }, { "prediction": "I'm not sure why this test was failing. I'm not sure why this test is failing.", "reference": "I think it is better to describe in the release note that `rerender()` was removed." }, { "prediction": "I don't think this is needed anymore.", "reference": "We could also test this easily with `runpy.run_module`, what do you think?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Is it OK to fall through if it's not assignable? I was kind of surprised when the tests passed. Maybe one of the options below ends up working? For the new tests, this panics because `**not assignable uuid.UUID to []uint8**`. `uuid.UUID` is an array, not a slice." }, { "prediction": "I think this should be `nd.RetrievalAPI`", "reference": "I know this is after the fact but imo blockAPI should be blockMiningAPI." }, { "prediction": "I don't think this is needed.", "reference": "it's just a pattern as it was. SystemAttributeCode should have it's own definition and validate by it" }, { "prediction": "I think we should move this to a separate file.", "reference": "Similar to the code block when we use prefix, maybe we can unify them to base?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it.", "reference": "I think `Duration` is useful for this action and we shouldn't ignore it." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea.", "reference": "Everything below here can be replaced with `return s.err, len(p) - len(s.dataForWriting)`." }, { "prediction": "I don't think this is needed.", "reference": "Again, we can also guard `g_host_hip_lock_arrays.atomic`, can't we?" }, { "prediction": "I don't think we need to do this. I think we should move this to the `ImportSimpleProductCommandHandler` class. The `ImportSimpleProductCommandHandler` should be moved to the `ImportSimpleProductCommandHandler` class.", "reference": "Variable name should start from lowercase latter" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Why has this timeout doubled?" }, { "prediction": "I'm not sure if this is a good change. I'm not sure if it's a good change, but I'm not sure if it's a good change.", "reference": "Should IptablesPostWriteCheckIntervalSecs be set back to its previous smaller value, if use of the iptables lock is disabled?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "You're missing a `return` here, but I'll add it :smile:" }, { "prediction": "I think this should be `gles2_get_texture_in_context(wlr_texture);`", "reference": "Can you try adding back this assertion? I'd like to assert that the texture has been created in the same context as the renderer." }, { "prediction": "I'm not sure if this is the right approach, but I'm not sure if this is the right approach. I'm not sure if this is the right approach, but I'm not sure if it's the right approach.", "reference": "This won't work with Python 3 because it will already be a string. In that case we need to use `decode_header` from utils." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do it.", "reference": "Why is the respond_to check here?" }, { "prediction": "I'm not sure if this is the right way to do this, but I think it's better to use `$end_bracket_position` instead of `$end_bracket_position + 1`.", "reference": "@orklah are you sure it's the same as `$chars[$i]`? It looks like `$i` is changed above, after `$char` assignment." }, { "prediction": "I think this test should be `TestDeleteVertexTest::instance(kv.get(), nullptr, nullptr);`", "reference": "I have a question? How do I construct a indexManager for testcase?" }, { "prediction": "I think this should be `if (adapter == NULL || adapter->plugin.dl_handle == NULL) return -1;`", "reference": "These checks aren't needed. See pluginmgr.c : opae_plugin_mgr_load_dflt_plugins( )." }, { "prediction": "I don't think we need this method anymore.", "reference": "Please take a care about prefixing." }, { "prediction": "I don't think we need to create a new account for every transaction. I don't think we need to create a new account for every transaction. I'm not sure if we need to create a new account for every transaction.", "reference": "this line doesn't match what the rest says" }, { "prediction": "I don't think this is needed.", "reference": "Since it's not working for linux, maybe leave the!linux in there as well?" }, { "prediction": "I think this should be `\"source %q already exists in workflow\"`", "reference": "Should we remove the key-value pair entirely? Same for workflows in general. We have a \"sourceExists\" method that checks if a key is there if I remember correctly." }, { "prediction": "I don't think we need this change.", "reference": "Unrelated bug fix" }, { "prediction": "I don't think we need this anymore.", "reference": "We probably want to let the translation library handle the string replacement for these as well." }, { "prediction": "I don't think we need this flag anymore.", "reference": "should combine these 2 list (list_gossip and list_db) into just one list command, and show the discrepancy between the 2 if any." }, { "prediction": "I don't think this is needed.", "reference": "What do you think about prefixing the Policy method names with `can_`?" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea.", "reference": "Based on the docs, credential process can return a key `SessionToken`" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "I think this if should be removed (see issue)" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "I would avoid importing `felix/ipsets` package because this package is the windows equivalent and should be at the same level of `felix/ipsets`. We could add linux specific dependencies into `felix/ipsets` later and it will break Windows build." }, { "prediction": "I don't think this is needed.", "reference": "nitpick: Please move this down to the other imports, as it's a Python stdlib import." }, { "prediction": "I don't think we need this anymore.", "reference": "\"for getting started guides\" reads a bit weird, like it's missing punctuation. Maybe just \"for a tutorial\"?" }, { "prediction": "I don't think we need to change this.", "reference": "This looks like a dead parameter -- maybe a copy and paste error. If it's truly unused, maybe you can open a separate PR to simply delete it, and then it's one less detail to worry about here." }, { "prediction": "I think this should be `row[i] = values.NewInt(int64(col))`", "reference": "Nit: Should we add support for `int` and `uint` in the `values.New()` function? That would allow us to to handle all of these types in one case. Maybe there's a good reason why we don't do that already, but I'm not sure what it is." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `CachedRuleViolation` instance.", "reference": "if you are not dealing with cache now, please revert these changes. On their own they make little sense" }, { "prediction": "I'm not sure if this is the right place to call this method.", "reference": "Wearing my extra-douche-bag hat I would say not spaces on a blank line. Maybe at some point we could have some automated process remove these things. For now I would not bother changing it." }, { "prediction": "I don't think this is needed.", "reference": "I think it would be better to use an `ItemUpdatedEvent` like for the \"prefer streaming\" preference. We already have a ton of events that need to be handled in all list fragments that just do the same everywhere. I think we could even remove some of the existing events in the future." }, { "prediction": "I think this should be `select * from products where name = :name`", "reference": "I think we have to manually write a down for this migration." }, { "prediction": "I don't think we need to change this line.", "reference": "I don't think we still need this check, but I'd leave it as an assertion for now." }, { "prediction": "Line is too long. [89/80]", "reference": "Since this may be the case, wondering if we should call the param `updated_at_i` or something so that we don't run into a problem distinguishing them down the road?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "wondering why we need to join the paths here; seems evt.commandLine only takes whatever appExe is" }, { "prediction": "I don't think this is the right place to do this, but I think it's better to use `StringUtils.deleteWhitespace(serviceName, \"UTF-8\");` instead of `StringUtils.deleteWhitespace(serviceName, \"UTF-8\");`", "reference": "1.not format code 2.failed but still continue? 3.\"UTF-8\" can changed to java.nio.charset.StandardCharsets.UTF_8.name()" }, { "prediction": "I don't think this is needed anymore.", "reference": "I'm wondering if we should add this to a `utils` module in `astroid`. Porting the util to `pylint` doesn't make sense as we would need to duplicate the globals that are being used in the function, but importing from `brain` also feels weird. @Pierre-Sassoulas Do you have an opinion?" }, { "prediction": "I don't think this is needed.", "reference": "This seems different than what we do for corrupted request headers. I would like to determine the correct behavior and consolidate this logic." }, { "prediction": "I don't think we need this anymore.", "reference": "Please make the change in the CAI inventory, rather than changing the scanner." }, { "prediction": "I don't think this is needed anymore.", "reference": "adding this `abstract` is a breaking API change. Even though I agree it makes perfect sense to have it, we can't break this API until PMD 7.0.0. We should revert this particular change. We could make a reminder ticket like we did with #463 for 6.0.0" }, { "prediction": "I'm not sure if it''''''''''''''''''''''''''''''''''''''''''','''''''''''''''''''''''''''''''''''''',''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''')'''''''''''''''''''''''''''''''''''''''''')''''''''''''''''''''''''''''''''''''''''''''''''''''", "reference": "This is following the existing convention, but I'm not sure the convention is a good one. I think it would be better to have one shared example group: - It means we don't need to add new example groups twice every time. - If the shared example group looks large, that makes it more obvious that our team models have too much shared behavior. I don't want to do anything about this right now (I'm pretty sure I can wipe out this shared example group when I change team plans), but it's good to keep in mind." }, { "prediction": "I'm not sure if this is the correct behavior. I'm not sure if this is the correct behavior.", "reference": "I do not think we need to do a source code change to handle this. We could set the subnetwork to default to /32 (/128 for ipv6 ipv4-mapped)" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "It looks good overall! The only issue I have is that the description string is now duplicated twice right? Once in the struct and once in the parameter string? Maybe let's pass the struct to the command so that `ostree_option_context_parse` can set it as the summary? Similar to what we do in rpm-ostree." }, { "prediction": "I don't think this class is needed anymore.", "reference": "This states very clearly that this is a derivative of Chrome and not Chromium. Do we need to extract an abstract `ChromiumCommandExecutor` and have both Edge and Chrome derive from that?" }, { "prediction": "It may be a custom enum class or an explicit Enum class usage", "reference": "it seems to me, the issue lies on `isEnum()` itself, returning false for something that is an enum. I'd rather change it there than here." }, { "prediction": "I don't think this is needed.", "reference": "Please use `{}` instead of `dict()`" }, { "prediction": "I'm not sure if we should move this to a separate file.", "reference": "I have concerns about using this in more places before #3278 - I'll take a look at that again shortly." }, { "prediction": "I'm not sure if this is the right place for this test, but I'm not sure if it's the right place for this test.", "reference": "new field needs to be asserted" }, { "prediction": "I don't think we need to set the lastLogIdSent_ in this case.", "reference": "when send log failed, why update the last sent log id?" }, { "prediction": "I'm not sure why this change is needed.", "reference": "what was the problem with the previous order? `prepend` comes conceptually before `append`, i.e. `insert before` should be before `insert after`, I think" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea, but I'm not sure if this is a good idea.", "reference": "Why is this necessary? Could you provide some context?" }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "Is there a recommended quote style for attributes? I see single and double here, double further down." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this. I'm not sure if it's the right place to do this.", "reference": "Please use an atomic bool." }, { "prediction": "I don't think this is needed.", "reference": "Consider naming this class `SpanExtensions` to follow C# conventions." }, { "prediction": "I'm not sure if this is the right place to remove it.", "reference": "FYI @lucaspimentel and @colin-higgins since you have already approved, I wanted to point out this required change. By fixing `FrameworkDescription` to use the correct logger, it created a cycle between these two static constructors, so I'm removing this log line and delaying it to when it's actually constructed later in the Tracer. Let me know if you find that acceptable or have any suggestions." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "Ah, so we are going to need to update node/host files for this to work?" }, { "prediction": "I think this should be `LOG.info(\"Created container \" + id);`", "reference": "This code is new and not tested well. While we may drop the log level before we ship 4.0, right now this is extremely helpful to users." }, { "prediction": "Layout/TrailingBlankLines: Trailing whitespace detected.", "reference": "used named path (`proposals_path`) instead?" }, { "prediction": "I don't think this is needed.", "reference": "Am I misreading something, or is there a mismatched parenthesis here? Please let me know whether or not this is cause for concern -- just wanted to be totally sure before merging, since I can't test this from here. Thanks!" }, { "prediction": "I don't think we need to check the service name in the response.", "reference": "Might we want a hook to allow emitting metrics or logs in the case of a permitted empty service header response (or similar UpdateSpanWithErr on empty service header in response if strict enforcement is desired by the caller)?" }, { "prediction": "I don't think we need to change this.", "reference": "if using dict.get, this could just be `kwargs.get('protocol', 'https')`" }, { "prediction": "I don't think this is needed.", "reference": "Add docs to the new methods here" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "what does it mean enabled?" }, { "prediction": "I don't think we need to change this line.", "reference": "Getting an error when calling with db.execSQL (in sqlcipher 4.3.0, pragma returns ok)." }, { "prediction": "I'm not sure if this is the right way to do this.", "reference": "Maybe we could remove `\" \" + ctx.Tr(\"dashboard\")` completely?" }, { "prediction": "Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "Simple Storage **Service**" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it.", "reference": "Let's add some assertions here to ensure we don't panic. Length of results. Conditionally cast second result to error." }, { "prediction": "I don't think this is needed.", "reference": "Where did we take this default from?" }, { "prediction": "I'm not sure if this should be optional, but I think it's a good idea to add it to the `options.compareStartDate` and `options.compareEndDate` param.", "reference": "Let's move these down to be after all required arguments rather than in between." }, { "prediction": "Is this necessary?", "reference": "Should we just null the Map and let the GC handle the memory? Clearing just removes items, but not capacity, so this would leave some memory on the table." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "did you mean to delete this line?" }, { "prediction": "I think this should be `System.out.print(\"getDataverseException: \" + this.datasetFieldType.getDisplayName());`", "reference": "Should we use logger instead?" }, { "prediction": "I don't think we need to change this test.", "reference": "I think it would be preferred to do `expect(helper).to be_analytics`" }, { "prediction": "I'm not sure this is the right place for this, but I'm not sure if it's the right place for this, and if it's the right place for this, I'm not sure if it's the right place for this.", "reference": "Actually, I think it's okay to just change to `if isinstance(key, (str)) or is_list_like(key):` and `key = list(key) if is_list_like(key) else key` for simplicity for now." }, { "prediction": "I'm not sure if this is the right place for this change.", "reference": "If there any other tests, I would make it optional there also." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "This can be removed too, right?" }, { "prediction": "I don't think this is the right place to do this.", "reference": "If you're going to allow people to specify multiple SMTP servers, you should also properly export/import them." }, { "prediction": "I don't think we need to add this to the `RuntimeMetrics.cs` file.", "reference": "nit: Can we prefix these variables with `AspNetCore`?" }, { "prediction": "I don't think we need to change this test.", "reference": "Can this also include a quick test for transpiling by name?" }, { "prediction": "I'm not sure if we should remove this struct in favor of `SessionStats`", "reference": "This TODO can be removed" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "can we make tabAccessibilityIdentifier = null as default?" }, { "prediction": "I'm not sure if this is the right place to do this, but I think it's better to move this to the `context.Background()` function.", "reference": "Should we print this error?" }, { "prediction": "I think this should be `int(multi_scores.size(1) - 1)`", "reference": "For which reason do we need to convert this to int here?" }, { "prediction": "I'm not sure if this is the right fix.", "reference": "FWIW, wondering if the error is interesting here (I actually arrived at this code initially to change `supportsFreezer()` to return a `bool`" }, { "prediction": "I'm not sure if this is the right place to remove it.", "reference": "Does this still need to be a partial? is the intention down the line to move back towards a conditionally different title?" }, { "prediction": "I don't think we need to update these to real values. I don't think we need to update these to real values.", "reference": "seems like `RegistryURL` is missing? Same for a few other places that create `archer.Environment` below." }, { "prediction": "I'm not sure if this is the right place to import it.", "reference": "Are these imports needed?" }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "I think you can remove the `(isIE11? it.skip : it)(` above, if you're going to skip the test this way." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "IMO we should instead fix the above call to do `long actualChecksumIn = Long.reverseBytes(in.readLong());` to get the actual checksum value? This way the below error message would also be correct?" }, { "prediction": "I'm not sure if this is the right place to delete unused index files. I'm not sure if it's the right place to delete unused index files, but if it's the right place to delete unused index files, I'm not sure if it's the right place to delete unused index files. If it's the right place to delete unused index files, I'm not sure if it's the right place to delete unused index files. If it's the right place to delete unused index files, I'm not sure if it's the right place to delete unused index files. If it's the right place to delete unused index files, I'm not sure if it's the right place to delete unused index files. If it's the right place to delete unused index files, I'm not sure if it's the right place to delete unused index files. If it's the right place to delete unused index files, I'm not sure if it's the right place to delete unused index files. If it's the right place to delete unused index files, I'm not sure if it's the right place to delete unused index files.", "reference": "I think we also need something similar for `rebuild-index`?" }, { "prediction": "I'm not sure if it''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''','''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''", "reference": "I think convention is snake case for import naming?" }, { "prediction": "I don't think we need to add handle column to indexScanBuilder.addColumns(tableInfo.getColumn(col.getName()).toProto(tableInfo));", "reference": "i think haspk is false?" }, { "prediction": "I'm not sure if this is the right place for this option.", "reference": "you should add this to the cover command too (but let's have a more general convo about whether it's a flag or config option)" }, { "prediction": "I'm not sure if this is the right place to use `metrics.ClientConfig{}` or `metrics.ClientConfig{}`", "reference": "instead of passing in pointer to empty struct, we should make it optional and support passing nil and use default cfg if it is nil." }, { "prediction": "I'm not sure about this, but I think it's better to use `sorted(obj.to_dict().items())` instead of `sorted(list(obj.to_dict().items()))`", "reference": "A fair bit faster, although still not great, hence also adding a hashkey." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.", "reference": "If we're going to leave this in here, how about we at least pull it into partial?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "This `context` is used correctly, there is nothing left TO DO." }, { "prediction": "I'm not sure if this is the right place to use `result.toArray(err, docs)` or `result.toArray(err, docs)` or `result.toArray(err, docs)` or `result.toArray(err, docs)` or `result.toArray(err, docs)` or `result.toArray(err, docs)` or `result.toArray(err, docs)` or `result.toArray(err, docs)` or `result.toArray(err, docs)`", "reference": "If `docs` is an empty array there will be an error" }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it.", "reference": "Is it really necessary to have the user specify this, or can the reverse proxy infer QUIC from the upstream's Alt-Svc headers?" }, { "prediction": "I don't think we need to change this.", "reference": "just remove the entire variable." }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Maybe we should put that in the option description?" }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it.", "reference": "Why do we need to make this optional? Isn't the idea of the builder that if you don't need this value you just don't call the `keyFilePath ` method?" }, { "prediction": "I think we should move this to a separate method.", "reference": "Shall we do the same for ORC and Avro?" }, { "prediction": "I don't think this file is needed anymore.", "reference": "Should be a space between line" }, { "prediction": "I don't think this is needed.", "reference": "if not behind interface then equally we can use SecureRandom.GetBytes directly, otherwise let us push it behind ISecureRandom so we can test with this class wherever used" }, { "prediction": "I'm not sure if this should be a tile, but it seems like it should be a tile, not a tile.", "reference": "Probably will undo this change for now, as I'm just targeting Weekly Iteration in this PR." }, { "prediction": "I'm not sure why this was removed.", "reference": "Unused parameter warning? How comes we did not catch that before? In any case please open another PR for this." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `default_iou_thr` or a `default_ioa_thr` or a `default_ioa_thr`. I'm not sure if it's a good idea to have a `default_iou_thr` or a `default_ioa_thr` or a `default_ioa_thr` or a `default_ioa_thr` or a `default_ioa_thr` or a `default_ioa_thr` or a `default_ioa_thr` or a `default_ioa_thr` or a `default_ioa_thr` or a `default_ioa_thr` or a `default_ioa_thr` or a `default_ioa_thr` or a `default_ioa_thr` or a `default_ioa_thr` or a `default_ioa_thr` or a `default_ioa_th` or a `default_ioa_th", "reference": "I recommend move all openimage related logic to a new function" }, { "prediction": "I'm not sure if this is a valid cgroup, or if it's a valid cgroup, or if it's a valid cgroup, or if it's a valid cgroup, or if it's a valid cgroup, or if it's a valid cgroup, or if it's a valid cgroup, then it's a valid cgroup. I'm not sure if this is a valid cgroup, or if it's a valid cgroup, or if it's a valid cgroup, then it's a valid cgroup, or if it's a valid cgroup, then it's a valid cgroup, or if it's a valid cgroup, then it's a valid cgroup, or if it's a valid cgroup, then it's a valid cgroup, or if it's a valid cgroup, then it's a valid cgroup, or if it's a valid cgroup, then it's a valid cgroup, or if it's a valid cgroup, then it's a valid cgroup.", "reference": "We shouldn't have a bool for this. If there is a path passed, then we use it. Resource may or may not be empty." }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "I like how you used the count on the translate call to handle this." }, { "prediction": "I think this should be `$handler->hasDismax() && $this->getLuceneHelper()->containsAdvancedLuceneSyntax($string) && $this->getLuceneHelper()->containsAdvancedLuceneSyntax($string) && $this->getLuceneHelper()->containsAdvancedLuceneSyntax($string) && $this->getLuceneHelper()->containsAdvancedLuceneSyntax($string) && $this->getLuceneHelper()->containsAdvancedLuceneSyntax($string) && $this->getLuceneHelper()->containsAdvancedLuceneSyntax($string) && $this->getLuceneHelper()->containsAdvancedLuceneSyntax($string) && $this->getLuceneHelper()->containsAdvancedLuceneSyntax($string) && $this->getLuceneHelper()->containsAdvancedLuceneSyntax($string) && $this->getLuceneHelper()->containsAdvancedLuceneSyntax($string) && $this->getLuceneHelper()->containsAdvancedLuceneSyntax($string) && $this->getLuceneHelper()->containsAdvancedLuceneSyntax($string) && $this->getLuceneHelper()->containsAdvancedLuceneSyntax($string) && $this->getLuceneHelper", "reference": "Do we need to do this from the outside, or is there a spot in the handler code where we can do this automatically? (I haven't studied it closely yet... just wondering if you've already thought it through or if it's worth taking a closer look)." }, { "prediction": "I don't think this is needed.", "reference": "[Checkstyle] INFO: Using the '._' form of import should be avoided - java.util._." }, { "prediction": "I don't think we need to change this.", "reference": "So, why everything is in memory but the permission backend?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it.", "reference": "Are you sure it should be null and not an empty List?" }, { "prediction": "I don't think we need Frameworks here.", "reference": "Unfortunately I think the assumption of \"empty\" means the default dependency section is not correct. For a project.json file the default dependencies section is a shared section between all the different target frameworks and our TargetGroup being empty may map to many different target frameworks so they aren't really equated." }, { "prediction": "I don't think we need this test anymore.", "reference": "This test was verifying the wrong thing." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "pls pr a name change fro muon here too separately." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "nit: we can use `defer opts.spinner.Stop(\"Error!\")` after l.180 to make it slightly neater" }, { "prediction": "I don't think this is needed.", "reference": "This is declared in the wrong block" }, { "prediction": "I think this should be `message.Header.Sync` instead of `message.Header.Sync`", "reference": "In fact it would be useful for debug, i prefer combine them into one debug level log." }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do this.", "reference": "We would need to localize them eventually too, just FYI" }, { "prediction": "I don't think we need to change the name of the layer.", "reference": "It looks like the proto code needs to change the function name from set_name to set_type to be consistent." }, { "prediction": "I'm not sure if this is the right place to put this file. I'm not sure if it's the right place to put this file.", "reference": "I think we can avoid using this pattern for this use case." }, { "prediction": "I'm not sure if this is needed.", "reference": "Could you please change this to `#ifndef __linux__`? That's when we use our own implementation instead of `posix_spawnp`." }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it. I'm not sure if this is the right way to do it, but if it's the right way to do it, I'm not sure if it's the right way to do it. If it's the right way to do it, I'm not sure if it's the right way to do it, but if it's the right way to do it, I'm not sure if it's the right way to do it. If it's the right way to do it, I'm not sure if it's the right way to do it, but if it's the right way to do it, I'm not sure.", "reference": "Nit: put the `&&` on the previous line so that a reader knows that there's more to the statement at a casual glance." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Technically the \"right\" variables to use would be the ones in `libgit/autogit_node_wrappers.go\", which define how the tlf types map to subdirs for autogit specifically. (They would have to be exported.) But this is fine too I guess, just a little dirtier." }, { "prediction": "Line is too long. [89/80]", "reference": "Should there be a template or something associated with this email? Right now it's identical to `notification_for_approver`" }, { "prediction": "I think this should be `$em = $this->getDoctrine()->getManager();`", "reference": "i hope there is some extension in phpstan for this" }, { "prediction": "I think this should be `if (sep == 0) return 0; else if (sep == 0) return 0; else if (sep == 0) return 0; else if (sep == 0) return 0; else if (sep == 0) return 0; else if (sep == 0) return 0; else if (sep == 0) return 0; else if (sep == 0) return 0; else if (sep == 0) return 0; else if (sep == 0) return 0; else return 0; else if (sep == 0) return 0; else if (sep == 0) return 0; else if (sep == 0) return 0; else if (sep == 0) return 0; else if (sep == 0) return 0;", "reference": "We don't store empty dictionary entries anymore: they bring no benefits, only trouble." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Optional: This function is C++ specific and could be declared as `static`." }, { "prediction": "I don't think we need to pass the tagKey and tagValue here. Can we pass the tagKey and tagValue as well?", "reference": "we can't remove functions as that would introduce backward compatibility issues in our java client. So we should also have a function with the original arguments: ` public Roles getRoles(String domainName, Boolean members) { return getRoles(domainName, members, null, null); } ` For the Go client we don't have a wrapper so no option but to update your client code as necessary, but for java we have the wrapper thus we always maintain backward compatibility" }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if it's the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I'd recommend keeping this in `warn_deprecation` and not adding an override of `warn`." }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "I think we should use a `blitz` bin instead" }, { "prediction": "I don't think we need to do this. I think we need to check for `dataset.is_virtual_vdims` and if `dataset.is_virtual_vdims` then we need to check for `dataset.is_virtual_vdims`", "reference": "Why not make the ``derived_vdims`` flag (or similar, ``validate_vdims`` maybe?) an explicit argument to ``validate``?" }, { "prediction": "I'm not sure if this is the right place to create a snapshot for Pure FA volume. I'm not sure if it's the right place to create a snapshot for Pure FA volume, but if it's the right place to create a snapshot for Pure FA volume, then I think it's better to create a snapshot for Pure FA volume. I'm not sure if this is the right place to create a snapshot for Pure FA volume, but if it's the right place to create a snapshot for Pure FA volume, then I think it's better to create a snapshot for Pure FA volume.", "reference": "was it not possible to do this at the filter or porx driver layer? We typically try to avoid driver-specific things in the SDK layer" }, { "prediction": "I don't think this file is needed.", "reference": "please update the year. it can be setup in intellij template." }, { "prediction": "I think this test should be `testSlf4jTraceNullMessageNoArgs()`", "reference": "what's the use-case for this?" }, { "prediction": "`as_index` should be `bool`", "reference": "nit: `as_index must be an boolean` -> `as_index must be a boolean`" }, { "prediction": "I think this should be `$currentVersion = $newVersion, $newVersion = $newVersion, $deleteModuleData = false`", "reference": "What is the goal of that method? And what are `$currentVersion` and `$newVersion`? Are they Thelia or Module version? :)" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.", "reference": "Is there an advantage to this vs setting `this.version` in the constructor? Cleaner this way, at the top?" }, { "prediction": "I don't think this is needed.", "reference": "Fix for URISyntaxException." }, { "prediction": "I think this should be `if routeUpd.Dst == nil {`", "reference": "Would be good to UT this case" }, { "prediction": "I don't think this is needed.", "reference": "Why we need to add this?" }, { "prediction": "I'm not sure if this is the right place to use `spec_helper` or `rails_helper`", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I don't think we need to add this to the `JetStreamStats` struct, since it's only used by the `JetStreamStats` struct, and we don't need to add it to the `JetStreamStats` struct.", "reference": "This is ok to change since I believe that these were added just in main and not in public release." }, { "prediction": "I'm not sure if this is the right place for this. I'm not sure if it's the right place for this, but I'm not sure if it's the right place for this.", "reference": "Not needed in this PR, just want to make sure people think about this (maybe make an issue)? This is a lot of strings in a row. It will be hard/impossible for someone reading the code to see that everything is in the correct position. I recommend creating a struct instead of passing seven strings in a row. A similar problem exists on most of the `MakeFoo(...)` style methods in this change." }, { "prediction": "I don't think we need to write the tool notifications here. Is there a reason we need to write the tool notifications here?", "reference": "_jaw drops_ I would have sworn I wrote those lines. Good catch." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it.", "reference": "This needs to be tested." }, { "prediction": "I'm not sure if this is the right place to test this, but I'm not sure if it's the right place to test this.", "reference": "I believe you're missing the comparison after 'be'" }, { "prediction": "I'm not sure if this is the right place to put the error into the cache.", "reference": "move 103~105 to in front of 97?" }, { "prediction": "I don't think this is needed.", "reference": "Lots of unnecessary imports left in this file." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Does this actually produce different code?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do it.", "reference": "This should account for whitespace. Simply putting `.trim()` on the attribute value should do." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if it's the best way to do this.", "reference": "I don't think we need these. Simpler just to put `routetable.TargetType...` inline below." }, { "prediction": "I don't think this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Nested if statement. You can merge both statements nested together to create one" }, { "prediction": "I think this should be `isJava10` or `isJava10`", "reference": "Nitpick: add a space after the comma. Also, we should consider that the format of the version could change in the future so we could get something that is not a parsable integer." }, { "prediction": "I don't think this is the right thing to do here.", "reference": "For your reference in future, I sugguest to use the `ASSERT_*` family." }, { "prediction": "I'm not sure if this is needed.", "reference": "no need to import `fmt/format.h` here since the `KimInit` class is derived from `Pointers`. Any class derived from `Pointers` can assumed that `lmptype.h`, `mpi.h`, `cstddef`, `cstdio`, `string`, `utils.h` and `fmt/format.h` are already included through `pointers.h`." }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "Can we have prefix of `OPENEBS_IO` e.g.: `OPENEBS_IO_INSTANCE_NAME`" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `GetOrCreateRootNode` or `GetOrCreateRootNode` here. I'm not sure if it's a good idea to use `GetOrCreateRootNode` or `GetOrCreateRootNode` here.", "reference": "Might as well fix these bare returns by making them `return errors.New(...` directly." }, { "prediction": "I think we should use `org.hyperledger.besu.datatypes.Hash.EMPTY` instead of `org.hyperledger.besu.datatypes.Hash.EMPTY`", "reference": "we can use import here" }, { "prediction": "I think we should remove this TODO.", "reference": "thx for removing these" }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do it. I'm not sure if it's the best way to do it, but I'm not sure if it's the best way to do it.", "reference": "I snuck this one in as well as checkstyle crashing (on files from resources) caused an unfinished xml to be written, and it wasn't obvious where that XML was" }, { "prediction": "I'm not sure if this is a good change.", "reference": "How is this different than \"good case\"?" }, { "prediction": "I'm not sure this is the right place for this interface. I'm not sure if it's the right place for this interface.", "reference": "the last parameter name should be `serviceName` as is in the implementation" }, { "prediction": "I think this test should be `assertNoEol(\"line1\\n line2 *\\n * line3\");`", "reference": "@ftomassetti - okay, this is a little meh." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "Note, changed initial capitalisation of this for consistency. Can do it the other way around too if that'd be better. :wink:" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "hey, aren't we supposed to be passing in two parameters here?" }, { "prediction": "I don't think this is needed.", "reference": "please keep alphabetical ordering :)" }, { "prediction": "I don't think this is needed.", "reference": "Selenium must compile against Java 6. Revert this line." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "what is that `\"\"`, the adapterType? can you add `\"\" /* adapterType */`... in other places as well... might be cleaner if it's a pointer or some varargs at the end but don't have any strong preference.." }, { "prediction": "I'm not sure if this is the right place to check for `pType!== 'boolean'` or `pType!=='string'`", "reference": "This check is a little odd, and will still mess up with empty strings `''` because empty string is falsy. Can we change this to `|| _this.getValue(path) == null`?" }, { "prediction": "`tabIndex` should be `isFocusable` and `isFocusable` should be `isFocusable`.", "reference": "Just a minor suggestion: If you `parseInt` when you access the attribute then you shouldn't have to do it twice in the ternary." }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "This change in particular is strange. I'm not sure why it would now be necessary. The previous default would've been true, and the default behavior without a new net-ssh version should be unchanged." }, { "prediction": "I don't think we need to change this.", "reference": "Why is that? Should be redundant as the default value exists." }, { "prediction": "I'm not sure if we should change this to `true` or `false`", "reference": "Are all fields beginning with \"Debug\" automatically `;local`? (I guess so, but just checking.)" }, { "prediction": "I don't think we need this interface.", "reference": "While I think it makes sense to update the mapping programmatically, I don't see much value in exposing it as part of the table API. We want to keep the Table API small, so if we can handle this by using a separate API that consumes and produces JSON, then that is preferred. Also, we may have more than one mapping in the future, so keeping this decoupled also helps out for those use cases. For now, let's build a utility class to perform these updates. We can always add this to the public API later if we choose to." }, { "prediction": "I think this should be `waitOnAll(getStatsMergeTimeout());`", "reference": "We would want ssmp to wake up every 3 seconds if there are no other requests to it and do some cleanup tasks. So, it is not clear why do you want to set this to 0." }, { "prediction": "I don't think we need to preload special types.", "reference": "Is this really necessary? I would expect these types to be included with the loop below." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "You could do span and it's magic of typecast to int for better efficiency" }, { "prediction": "I don't think vendor prefixes are needed here.", "reference": "Looks like you've covered `-webkit-transform`, but what about `-ms-transform`?" }, { "prediction": "I think this should be `MvxBindingLog.Error(\"All collection changes \");`", "reference": "Is there something missing from the message here?" }, { "prediction": "I don't think this is needed.", "reference": "Hmm, what does this syntax mean?" }, { "prediction": "I think this should be `getOrCreateWorkflowExecution(ctx, namespaceID, execution, callerTypeAPI)`", "reference": "should this be callerTypeTask?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Currently update is set as @plan.editable_by?(@user.id) Which one is the correct behavior? I can see a case for only owners/co-owners to be able to set visibility, test status, and other plan details" }, { "prediction": "I don't think we need to change this.", "reference": "Maybe make it configurable? Or store the actual level index in DB, making this binary search obsolete?" }, { "prediction": "I think this test should be moved to `HiveMetastoreTest`", "reference": "Nit: this file doesn't need to change. Can you revert this to avoid git conflicts?" }, { "prediction": "I don't think this is needed.", "reference": "There's no reason for this to be a callback now technically but as per our tech decision, we want all handlers to use `useCallback` now" }, { "prediction": "I don't think we need this?", "reference": "This isn't strictly part of this PR, but could you move `multiSigString` from `crypto/multisig.go` into this list of `HashID` values? Now that we have other things being hashed into addresses (specifically, these new logic addresses), it's important that the hash input for multisig addrs is domain-separated from logic addresses." }, { "prediction": "I don't think this is needed.", "reference": "nit: you could have named it just \"TestCase\" (if django's TestCase was imported differently)" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if it's the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here." }, { "prediction": "I'm not sure if this is the right place to remove the synthetic value.", "reference": "All the callers of `ExtractSomeIfAny`, always pass `true` to `synthetic_value`. Can we get rid of the extra argument?" }, { "prediction": "I don't think this is needed.", "reference": "Better to use the absolute path." }, { "prediction": "I don't think we need to change this?", "reference": "this is 16 hours, is that enough?" }, { "prediction": "I'm not sure if this is the right place to put this method.", "reference": "removing boilerplate. You could also add a `StartSpan` with varargs to inline string attributes." }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "Can you replace these single letter variables with full names?" }, { "prediction": "I don't think this is needed anymore.", "reference": "At first I wasn't sure, but now I think I'm sold on making PrepareRequest an action over adding a state object to the context." }, { "prediction": "I don't think we need to update the generator if it contains a version number. I don't think we need to update the generator if it contains a version number. I don't think we need to update the generator if it contains a version number.", "reference": "Would it be too greedy to preg_replace `VuFind (\\d+\\.?)+` with `'VuFind '. $this->to` anywhere in the string? This would update something like 'Finna (VuFind 7.1.0)' as well. Just a thought, please disregard if you'd like to keep it as is." }, { "prediction": "I don't think we need to read the config name from the state reader. I don't think we need to read the config name from the state reader. If we need to read the config name from the state reader, we need to read it from the state reader.", "reference": "BTW for brevity, you can remove `getZkStateReader().` here and elsewhere since ZkController has a convenience method for the cluster state." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but I'm not sure if it's the right place to do it.", "reference": "If there are no manifests, then entries should be `CloseableIterable.empty()`, not the manifest iterable. That doesn't need to be closeable." }, { "prediction": "I'm not sure if this is the right place to put this test.", "reference": "this class should be named `ArrayInitializationVerbosenessTest` to work" }, { "prediction": "I don't think this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it.", "reference": "Do we want to allow users to disable `console` as well? The schema currently says that it only permits a hash for `console`." }, { "prediction": "I think this test should be skipped.", "reference": "It would be very helpful to describe succinctly either inline or by linking to an issue going into depth why each test is not working. If we merge like this your knowledge of what is going on is lost and other people in the code need to do a ton of reading before understanding when/how/if we should unskip." }, { "prediction": "I don't think we need to pass `currentDataLoaded` and `previousDataLoaded` to `legacyAdSenseDashboardWidgetOverview`.", "reference": "As this is a `useEffect` this could be a cause for concern! Note that `useEffect` re-runs when a dependency changes **not** when a dependency is truthy (the previous code does look a bit like it's expecting that)" }, { "prediction": "I don't think this is needed.", "reference": "Should we be doing this with `make_unique` or something?" }, { "prediction": "Line is too long. [89/80]", "reference": "we don't want to set default values for this. Since it is the actual email, we want to make sure we are always passing in the `user` and `proposal`. we have a default value of `nil` for modifier because sometimes will update a proposal via `rails console` in which case there will be no recorded modifier." }, { "prediction": "I don't think this is needed anymore.", "reference": "Yes this import was in the wrong place, but should ideally be in the first list of imports (among `go/build`, `go/token`, etc.). You may move it there, or just revert this change as it's actually unrelated." }, { "prediction": "I don't think we need to change this.", "reference": "It's unnecessary to duplicate the `name`." }, { "prediction": "I don't think we need to check for `true` here.", "reference": "this was a mistake when adding phpstan strict plugin" }, { "prediction": "I don't think we need to check for null placeholders in placeholder.test.js.", "reference": "Nit: I think it should be `to handle` here." }, { "prediction": "I'm not sure if this is the right place to check for null.", "reference": "Please don't make unrelated changes or let your tools make unrelated changes." }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if this is a good idea.", "reference": "`numAccounts` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I don't think we need to unset the plugin from the internal container.", "reference": "Is the ID correctly normalized at this point?" }, { "prediction": "I don't think this is needed.", "reference": "if 0 is a special constant meaning \"no limit\" let's make it a constant and name it correctly :)" }, { "prediction": "I'm not sure if this is the right way to do this.", "reference": "Curious about the reason behind this change" }, { "prediction": "I don't think this is the right place to put block in bitswap exchange. I think it should be `cborStore.Put(ctx, b)` or `cborStore.Put(ctx, b)`", "reference": "wait, i thought the cborstore was for state tree?" }, { "prediction": "I think this should be `self.get('KEY', obj)`", "reference": "This logic is now duplicated here and in `_delete_temporary_files`... Maybe do it all at once - find temp files, delete them, and fix the logical keys?" }, { "prediction": "I don't think this is needed.", "reference": "How about name it with NullResponseTypeProcessor" }, { "prediction": "I don't think this check is needed.", "reference": "Maybe `Log::Fatal` here? `[LightGBM] [Fatal] Check failed: feat_is_unconstrained at...` (and kernel death in case of Jupyter Notebook) seems to be not so informative and user-friendly." }, { "prediction": "I don't think we need to do this anymore.", "reference": "Not sure I like the name ``_apply``. Even though ``_process`` is supposed to process elements already, how about ``_process_element`` which processes elements, *excluding* Overlays/NdOverlays." }, { "prediction": "I'm not sure if this is the right value for the node role. I'm not sure if it's the right value for the node role, or if it's the right value for the node role, or if it's the right value for the node role, or if it's the right value for the node role, or if it's the right value for the node role, or if it's the right value for the node role, or if it's the right value for the node role, then it's the right value for the node role.", "reference": "Let's use this constant when ASG is created as well (currently hardcoded)." }, { "prediction": "I'm not sure about this, but I think it's better to make this `OBJECT_ACCESS_COUNTS` in a separate PR. I think it's better to make it `OBJECT_ACCESS_COUNTS` in a separate PR and make it `OBJECT_ACCESS_COUNTS` in a separate PR. I think it's better to make it `OBJECT_ACCESS_COUNTS` in a separate PR and make it `OBJECT_ACCESS_COUNTS` in a separate PR.", "reference": "Oh is `bucket` actually higher cardinality than `eventname`?" }, { "prediction": "I don't think this is needed anymore.", "reference": "You can't rely on QtWebEngine being available - but why do you need to import this here at all?" }, { "prediction": "I don't think this is needed.", "reference": "How did you determine these - and how can we be confident that nothing is missing?" }, { "prediction": "I'm not sure if this is the right place to add this header.", "reference": "What is this page going to do that is different than the products index we already have?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else." }, { "prediction": "I don't think we need to change this. I'm not sure if we need to change this.", "reference": "Is this intended to be here? Seems it belongs to a different PR." }, { "prediction": "I'm not sure if this is the right place to set the foreground color, but I'm not sure if this is the right place to set the foreground color, or if it's the right place to set the foreground color, or if it's the right place to set the foreground color, or if it's the right place to set the foreground color, or if it's the right place to set the foreground color, or if it's the right place to set the foreground color, or if it's the right place to set the foreground color, or if it's the right place to set the foreground color, or if it's the right place to set the foreground color, or if it's the right place to set the foreground color.", "reference": "These changes, while harmless, were no longer needed with newer versions of System.Console thanks to @ianhays" }, { "prediction": "I don't think this is needed.", "reference": "Umm... this isn't relevant to this PR" }, { "prediction": "I think this should be `All = ~0`", "reference": "While All make some sense here it doesn't make a lot of sense in the SkipOnFramework context. I wonder if we really need to expose anything more here. You can just blindly use 0." }, { "prediction": "I'm not sure if this is the right place to put this file.", "reference": "Actually, this is not correct. Package `cmd/bee` doe snot have any notion of commands or even libraries used for them. It is as simple as possible, just calling the function from `cmd/bee/cmd` which actually implements commands." }, { "prediction": "I don't think we need this anymore.", "reference": "This change is causing tests to fail because users sits at `/app/users`, not `/app/admin/users`" }, { "prediction": "I'm not sure if this is the best option. I'm not sure if it's the best option, but I'm not sure if it's the best option. If it's the best option, I'm not sure if it's the best option. If it's the best option, I'm not sure if it's the best option. If it's the best option, I'm not sure if it's the best option, but if it's the best option, I'm not sure.", "reference": "Could you provide more information on what exactly each of those three options do?" }, { "prediction": "I don't think we need to use `System.IO.File.ReadAllLines` here.", "reference": "Why this line break?" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "We're importing this twice with different aliases." }, { "prediction": "I'm not sure if this is the correct version, but I'm not sure if this is the correct version.", "reference": "We should avoid adding a pandera dependency to Dagster itself." }, { "prediction": "I don't think this is the right place to do this, but I don't think this is the right place to do this.", "reference": "Can be replaced with `org.jkiss.utils.ArrayUtils#add`." }, { "prediction": "I think this should be synchronized (electionContexts) instead of synchronized (electionContexts)", "reference": "While we're here, this line (and a few others) should be `customThreadPool.submit(() -> IOUtils.closeQuietly(overseer);` I have no idea why we're creating a collection and a stream for a single object." }, { "prediction": "I don't think we need to check for managedIdentityClientID and managedIdentityResourceID?", "reference": "Should these restrictions also be reflected in the API docs?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this, or if it's the right place to do it.", "reference": "What about the request headers if someone uses `request_header`? :thinking:" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Verify that external-dns allows setting this parameter multiple times (that it's not \"last one wins\")." }, { "prediction": "I don't think we need this anymore.", "reference": "Maybe 2 host/ip values could be used in the example?" }, { "prediction": "I'm not sure if this is the right place for this test. I'm not sure if this is the right place for this test, but I'm not sure if it's the right place for this test.", "reference": "We're only testing `RateLimiter.Allowed(Span)`, so I think we can use a mock `ITraceContext` instead of a real `Tracer` or `TraceContext`." }, { "prediction": "I don't think we need to pass the trainer to build_model_from_prototext. I think we should pass the trainer to build_model_from_prototext.", "reference": "IMO, this is the wrong way to associate a model with a trainer... Why the string when you actually have a trainer object?" }, { "prediction": "I think this should be `block_exists(block_a.type(), hash)`", "reference": "Wondering if we can directly put types here & for other similar ledger_processor items like rai::block_type::state" }, { "prediction": "I'm not sure if this is the right place to remove the old packs. I'm not sure if it's the right place to remove the old packs.", "reference": "As `DeleteFiles` is not only used for prune this function deserves its own file. Maybe something like `delete_files.go` or `parallel.go`?" }, { "prediction": "I don't think we should remove this line.", "reference": "It should be simplified character. `` -> ``" }, { "prediction": "I think this should be `bool VisitAccounts => true;`", "reference": "I am pretty sure it breaks the visitor pattern, visitor should have no knowledge about the structure of what it is visiting or control over visiting mechanism" }, { "prediction": "I don't think we need to change this.", "reference": "'A' instead of 'An' here" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea.", "reference": "Can you flip it back (here and in other places)? It is more natural to represent \"10 seconds\" as `10 * time.Second`." }, { "prediction": "I don't think this is the right place for this test.", "reference": "Why was this necessary? You should just use the `dask_classifier` defined below this. With this change, you'd only be doing the local predict on arrays each time, but we want to test on all of DataFrame, Array, and sparse matrix." }, { "prediction": "I don't think this is needed.", "reference": "To me, this is sort of weird to have a completely separate page for this. Can we extract the different stuff (github, videos, downloads) presentation from the top of `app/views/purchases/show.html.erb` and reuse it on this page. I worry that we'll change things with fulfillment or copy and have to change it in multiple places." }, { "prediction": "I don't think this is needed.", "reference": "Please revert the lines above. Not touching unrelated code keeps the git history clean." }, { "prediction": "I don't think this is needed.", "reference": "`short_version` and `version_info`" }, { "prediction": "I'm not sure if this is the right thing to do here. I'm not sure if this is the right thing to do, but I'm not sure if this is the right thing to do.", "reference": "This is supposed to be `status`. Why did you change this?" }, { "prediction": "I don't think this is needed.", "reference": "I will change all of these at some point next week." }, { "prediction": "I don't think we need this property anymore.", "reference": "I made this change because, while trying to debug, in Visual Studio, the `IntegrationSignatureTests`, this property getter was hit and interfered with my ability to complete the debugging." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "nit: `\"Unexpected error while calculating: unable to convert %T to %T: %v\"`" }, { "prediction": "I'm not sure if this is the right place to call this method.", "reference": "I'd actually recommend not putting this in the `SampleConfig`, it's intended more for properties that are inherent of the discovery format. Add a method `getSampleAppName(String apiTypeName)` to `SampleNamer` and override it in the language specific `SampleNamer`s if needed. Then assign it in the transformer." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `sort-object-map-by-key` or `sort-array-to-keyed-object-map-by-key` or `sort-array-to-keyed-object-map-by-key` or `sort-array-to-keyed-object-map-by-key` or `sort-array-to-keyed-object-map-by-key` or `sort-array-to-keyed-object-map-by-key` or `sort-array-to-keyed-object-map-by-key` or `sort-array-to-keyed-object-map-by-key` or `sort-array-to-keyed-object-map-by-key` or `sort-array-to-keyed-object-map-by-keyed-object-key` or `sort-array-to-keyed-object-map-by-keyed-keyed-object-map-by-key`", "reference": "Do we need to export these new functions? I thought the plan going forward was to keep util imports separated to make circular imports less likely and possibly do better chunk splitting. Since only new code references these files, we can scope the import to the specific files." }, { "prediction": "I'm not sure if this is the right place to put this file.", "reference": "Rails will autorequire `acts_as_editable` once it encounters the constant `ActsAsEditable`. Thus if we move `ActiveRecord::Base.send :include, ActsAsEditable` from _acts_as_editable.rb_ to this file, the require line will not be needed anymore. Instead of requiring the file ourselves, we will let Rails do it for us. This fix will also remove the need to explicitly require `acts_as_editable` in _mock_active_record_base.rb_." }, { "prediction": "I'm not sure if this is the right place for this class.", "reference": "I think we should name this `grpcMethodName` or similar. That is what this refers to, right? The fact that it is upper camel is an implementation." }, { "prediction": "I think this should be `FPGA_MSG(\"%s is not a valid input\", _N);`", "reference": "What if.. appears, but not as the first character, eg \"errors/../../../../../../../../../../../\"?" }, { "prediction": "I don't think we need this anymore.", "reference": "Thanks, this should make things a bit easier for people who pick up the codebase but aren't a `curation center`" }, { "prediction": "I don't think this is needed anymore.", "reference": "why not removing it?" }, { "prediction": "I don't think we need this?", "reference": "same nit here: maybe word as - \"disables validation of the temporal cluster's server certificate\"" }, { "prediction": "I think this test should be `assertEquals(\"Should use the current catalog\", getTableEnv().getCurrentCatalog(), catalogName); Assert.assertEquals(\"Should use the configured default namespace\", catalogName); Assert.assertEquals(\"Should use the configured default namespace\", catalogName); Assert.assertEquals(\"Should use the configured default namespace\", catalogName); Assert.assertEquals(\"Should use the configured default namespace\", catalogName); Assert.assertEquals(\"Should use the configured default namespace\", getTableEnv().getCurrentCatalog(), catalogName); Assert.assertEquals(\"Should use the configured default namespace\", catalogName); Assert.assertEquals(\"Should use the configured default namespace\", getTableEnv().getCurrentCatalog(), catalogName); Assert.assertEquals(\"Should use the configured default namespace\", catalogName); Assert.assertEquals(\"Should use the configured default namespace\", catalogName); Assert.assertEquals(\"Should use the configured default namespace\", getTableEnv().getCurrentCatalog(), catalogName); Assert.assertEquals(\"Should use the configured default namespace\", catalogName);", "reference": "Nit: other statements use all caps for SQL reserved words. Should this be `SHOW TABLES`?" }, { "prediction": "I think this should be `c == '.' || c == '.' || c == ':`", "reference": "Do we need this? isLuaIdentifier() is used not only in extract_next_token() but also in extract_prev_toke(). I wonder whether the change for isLuaIdentifier() has an impact on extract_prev_toke() or not. If you are not sure, keep isLuaIdentifier() as is. If you are sure, could you write your conviction to the commit log." }, { "prediction": "I'm not sure if we should change this to \"WorkloadIPs\" or \"WorkloadIPs\" or \"WorkloadIPs\" or \"WorkloadIPs\" or \"WorkloadIPs\" or \"WorkloadIPs\" or \"WorkloadIPs\" or \"WorkloadIPs\" or \"WorkloadIPs\" or \"WorkloadIPs\" or \"WorkloadIPs\" or \"WorkloadIPs\" or \"WorkloadIPs\" or \"WorkloadIPs\" or \"WorkloadIPs\" or \"WorkloadIPs\" or \"WorkloadIPs\" or \"WorkloadIPs\" or \"WorkloadIPs\" or \"WorkloadIPs\" or \"WorkloadIPs\" or \"WorkloadIPs\" or \"WorkloadIPs\"", "reference": "This line should actually be: `if c.KubernetesProvider == config.ProviderAKS && c.Wireguard.EncryptHostTraffic {` because we only need to tweak the MTU like this on AKS." }, { "prediction": "I'm not sure if this is a breaking change.", "reference": "Do we need to change this flag as well?" }, { "prediction": "I think this should be `module.exports.source ='+ JSON.stringify(source) + ';';`", "reference": "Including the source twice here makes the filesize jump to 432kb. Is there any way to minimize repeating it?" }, { "prediction": "I think this should be `switchTo().window(' + nameOrHandle + ')`", "reference": "This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings." }, { "prediction": "I don't think this is critical. It's critical that the order of plan vars is not changed, as Puppet will deserialize the variables in the order they appear earlier in a plan.", "reference": "Only one line of code? What a simple issue!" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "Conceptual question: why do history and matching need throttler at all? Shouldn't throttling to be handled on FE only?" }, { "prediction": "I don't think this is needed.", "reference": "Would this be possible: `addCNP` has already processed the CNP to an internalNP, just hasn't added this internalNP to the `internalNetworkPolicyStore`. In this case, `reprocessCNP` will skip processing this CNP and `addCNP` will just add the \"old\" internalNP to `internalNetworkPolicyStore`." }, { "prediction": "Line is too long. [89/80]", "reference": "Minor: you can access `current_user` in here directly - don't need to pass it in. Unless you prefer passing it explicitly?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "What is the purpose of `&` on this line?" }, { "prediction": "I'm not sure about this, but I think it's better to use `^[a-zA-Z0-9]+$/.test(webDataStreamID)` instead of `^[a-zA-Z0-9]+$/.test(webDataStreamID)`", "reference": "See above, the `isValidWebDataStreamID` implementation from before is actually correct. What we need here instead is a new `isValidMeasurementID` function." }, { "prediction": "I think this should be `c.closeConnection(ReadError)` instead of `c.closeConnection(ReadError)`", "reference": "Should be an error... it is important for the admin of the server attempting to create the leafnode connection to see the error asap." }, { "prediction": "I'm not sure about this, but I think it would be better to use `state.discard(controlTypes.STATE_SELECTABLE)` instead of `state.discard(controlTypes.STATE_SELECTED)`", "reference": "Could you split these conditions up over multiple lines please." }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if it's the right place to do this.", "reference": "I think we can just change this to `Split` instead of `SplitN`. I don't think we need to limit the number of parts in the tag." }, { "prediction": "I don't think we need to change this.", "reference": "So this is actually a mistake that I introduced without realizing it, and have known would need to be fixed when we get here. The format of the ports directive is \"host:container\". We only want the host port to change, not the internal container ports. The ports variable probably needs to be a map which maps external -> internal ports." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "An alternate approach would be to always initialize shardInfo with a dummy (non-nil) value, which could protect against other uses before it's initialized (I couldn't find any though). But I can change it to do it that way instead." }, { "prediction": "I think this should be `LastWriter` instead of `LastWriter`.", "reference": "Maybe we can just put the entire `DirEntry` in here? I can imagine it might be useful for debugging to get the block ID/refnonce, encrypted size, key gen, data version, etc. What do you think?" }, { "prediction": "I'm not sure if this is the correct behavior.", "reference": "For the commit message: The paragraphs seem to be out of order? The `Would not work because` refers to the stuff before, but there is a `This may seem pointless, but` in-between." }, { "prediction": "I don't think we need this anymore.", "reference": "Why did you remove these packages from the prelude, will your new functions not work without this change?" }, { "prediction": "I think this should be `std::transform(keys.begin(), keys.end(), std::back_inserter(kvKeys));`", "reference": "We'd better reserve enough space before using kvKeys to avoid extra malloc." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "would it make sense to return empty or error if label doesn't exists?" }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "Don't penalize everyone with 250ms delay b/c some machines have problems." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Probably want a space after the second %s?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This seems like an internal error still?" }, { "prediction": "Line is too long. [89/80]", "reference": "Line is too long. [94/80]" }, { "prediction": "I don't think we need this interface.", "reference": "out of curiosity, why creating another struct to wrap it?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "discipline vs. Discipline? Not sure of which is correct. Also not sure if there is already an existing string const." }, { "prediction": "I think this should be done in the `ResourceDescriptorConfig` class.", "reference": "I believe this will break common resources, as they are defined in a common file, but must generate classes in service-specific namespace, so using protoFile to determine package of the generated class would not work, because common_resources namespace does not match service namespace." }, { "prediction": "I don't think we need this.", "reference": "How about `SPARK_DEFAULT_SERIES_NAME`?" }, { "prediction": "I don't think we need this. I don't think we need it.", "reference": "The other properties are in `commit.status-check`, not `commit.status-checks`. Could you remove the extra `s`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "Side note: I'd love to see more of these fields exposed on configuration." }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "In the case of accounts generated by API clients, what name gets put for the `inviter_name` or `invited_by` record?" }, { "prediction": "Do I need to implement getStartBlock here?", "reference": "I think this class is only relevant for updating the QbftConfigOptions based on the transitions config, so probably not." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "what is the number thrown by Geth?" }, { "prediction": "I think this should be `apiConfig.split(\"/\")[3].split('?')[0]`", "reference": "This would still crash on malformed database connection string like \"test\"" }, { "prediction": "I'm not sure if this is the right place to put this function.", "reference": "it is not an interface, maybe we can move to another package?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Same here. Can we use `this.instance.getSettings()` to get `tableMeta`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Not sure whether this validation is useful." }, { "prediction": "I think this should be `if question and hasattr(question, 'yank_text'):` or `if question and hasattr(question, 'yank_text'):`", "reference": "Various things to note here: - Why would `question` ever be falsey (or `None`) here, i.e. why the `if question`? - Why would `question` ever not have that attribute? You set it in `Question.__init__`, so that check does nothing at all (and generally, `hasattr()` should be avoided if possible). - Why do you want to yank `None` (what does that do?) rather than e.g. show an error if there's nothing to yank?" }, { "prediction": "I think this should be `print(event['Stats'])` or `print(event['Stats'])`", "reference": "If this is needed for testing, you should use `pytest --log-cli-level=INFO` instead." }, { "prediction": "I don't think we need to change this.", "reference": "We should drop ipify in all places i guess" }, { "prediction": "I don't think this is needed anymore.", "reference": "Add explanations around these variables - what do they mean, how they should be configured, etc." }, { "prediction": "this should be called on app init", "reference": "One thing tho - I would really appreciate any advice on where to move this to, so that it's called on initialisation of the website." }, { "prediction": "I think this should be `displayGatheredResources`", "reference": "To much tabs here (1 tab)" }, { "prediction": "I think we should move this method to `ExecutionLogsDao#removeExecutionLogsByTime`", "reference": "This is not maintaining retention time for logs as we are deleting only 1000 entries and we might end up with huge number of rows spanning over multiple months over a period of time if the cluster generates more rows as we are restricting ourselves to delete only 24k rows/day. Like I pointed out earlier a better would be to probably run this clean up every hour with some batch_size in a loop while there are records to be deleted(i.e older than 12 weeks) and committing each batch." }, { "prediction": "I think this should be `TimeNowPtrUtcAddSeconds(1000 * time.Second)`", "reference": "I don't like this helper func :-). Yeah, definitely don't like." }, { "prediction": "I'm not sure why this was removed.", "reference": "Same here. This should remain unchanged. Please, add it back." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "@kvwalker should this method have `ignoreUndefined` supported as an `option`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "we dont use a `sugaredlogger` anywhere else in clutch, just curious why were using it here?" }, { "prediction": "I'm not sure why this was removed.", "reference": "Not evident from looking at this diff but the queue is already being cleared four lines below." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Why is this a 'transaction' and not in the block header?" }, { "prediction": "I don't think this is needed.", "reference": "This doesn't fit the abstraction level. Should we have a property bag for extra stuff?" }, { "prediction": "I think this should be `src/core/**/*.h`, not `src/core/**/*.h`.", "reference": "Looks like it is pretty easy to miss it when adding new files under `ci`. Hopefully, this doesn't happen too often." }, { "prediction": "I'm not sure if this should be defered, but I'm not sure if it's necessary to wait for the service to be ready.", "reference": "do we really need the `Ready` call if startup fails midway?" }, { "prediction": "I'm not sure if this is the right place for this test, but I'm not sure if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, I'm not sure if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test.", "reference": "You can avoid changing the code if there are parameter defaults. right?" }, { "prediction": "I'm not sure if this is the right assertion.", "reference": "I wonder why the newline disappeared here? I guess we'll merge and see how SauceLabs fares across the supported browsers." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "I know this is legal, but I prefer we put brackets on our calls" }, { "prediction": "I don't think we need to delete the server certificate.", "reference": "AWS Identity and Access Management (IAM)" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "We keep who wrote the code anonymous." }, { "prediction": "I don't think we need to check for undefined here.", "reference": "Two things to make the code more error-proof and simplify it: 1. To be safe, this should be: `! isUndefined( decimal ) &&! isUndefined( decimal.value )` 2. The other clause that you changed below can be combined with that since `decimal` isn't used anywhere else, and so there's no point to re-check whether it's not undefined. In other words, this should become: `! isUndefined( decimal ) &&! isUndefined( decimal.value ) && 1000 > number`, and then you can remove the `decimal = decimal.value` assignment and replace it with line 146 (assignment of `readableNumber`)." }, { "prediction": "I don't think this is needed.", "reference": "Wouldn't composite outbounds compose the transport, such that it would still be represented as a single transport?" }, { "prediction": "I think this should be `defer ctx.Cleanup(t)`", "reference": "nit: there is no need for a new line here, usually we tend to put an object creation and its deferred deletion next to each other. It helps not forgetting about the cleanup." }, { "prediction": "Do we need to add this to the `RequestPostInitializeListener` class?", "reference": "Feel free to use the full notation with my email address: `Maxime Steinhausser ` :smile:" }, { "prediction": "I'm not sure why this is removed.", "reference": "This was unused across the codebase" }, { "prediction": "I think this should be `s.Warnf(\"Account lookup for consumer create failed: %v\", err)` or `s.Warnf(\"Account lookup for consumer create failed: %v\", err)`", "reference": "Should we put in which account we were trying to look up?" }, { "prediction": "I don't think we need to add this to the `InventoryTypeClass` class.", "reference": "either SUPPORTED_TYPECLASS or supported_typeclass. Camelcase only for class names." }, { "prediction": "I think this should be `pinned INT NOT NULL DEFAULT 0`", "reference": "This is not going to work. You need to add a migration to the database." }, { "prediction": "I don't think we need to rename this method. It's not clear what it does.", "reference": "Should these methods be renamed in this PR?" }, { "prediction": "I don't think we need to check for invalid instrument name. I think we need to check for invalid instrument name. I don't think we need to check for invalid instrument name.", "reference": "we need to include the `metricStreamName` which is invalid, so users know whats causing the issue." }, { "prediction": "I think this should be `AssemblyLoadContext.Default.LoadFromAssemblyPath(binaryPath);`", "reference": "Please run Platform tests `DiaSessionTests`." }, { "prediction": "I'm not sure about this, but I think this should be `MSG_AVX_512_SUPPORT_INCOMPLETE_STRING\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" PFX\" @\" PFX\" PFX\" @\" PFX\" PFX\" @\" PFX\" PFX\" @\" PFX\" PFX\" @\" PFX\" @\" PFX\" PFX\" @\" PFX\" @\" PFX\" @\" PFX\" P\" @\" PFX\" P\" @\" PFX\" P\" @\" PFX\" P\" @\" P\"", "reference": "This is debug-build-only: we want a release-build notice. SYSLOG takes the name w/o the MSG and no _STRING. Args are via events.mc specifiers." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "is it possible to have both forms here? I was hoping we wouldn't be introducing more cases where we had to check the upper and lowercase version of URI options." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `name` or `name` here.", "reference": "Does the name suffix hardcode something? Not clear how changing the name fixes this." }, { "prediction": "I think this should be `QueueProcessorThreadState` instead of `QueueProcessorThreadState`.", "reference": "Is undispatched same as queued? getQueuedFlows?" }, { "prediction": "I don't think we need to change this.", "reference": "See above, same for all similar cases below." }, { "prediction": "I'm not sure why we're appending traceLogs here.", "reference": "Why is this done twice?" }, { "prediction": "I don't think we need this condition.", "reference": "This sync can ensure that the condition of the child node is consistent with the parent node, but I still don't understand when the child will be overwritten, and this behavior is not what we expected?" }, { "prediction": "I think this should be `DEBUG_TEST_FAILURE=true`", "reference": "This was renamed to avoid any confusion with the more general case of debugging via `plz debug`" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "String valStr = (String)val; valStr.substring(0, Math.min(valStr.length(), prefixLength)) Make it clean." }, { "prediction": "I don't think this is the right thing to do.", "reference": "Sorry, this still makes no sense.. the value of any union or enum is simply a name integer constant, it has nothing to do with the `BASE_TYPE_` enum. This value should be `0`. In particular: `Every union has the NONE field, which always has value 0`." }, { "prediction": "I don't think this is needed.", "reference": "Looks like getAzkabanURL() is added after concrete Alerter (Emailer)::getAzkabanURL(), so that Override annotation is needed." }, { "prediction": "I don't think we need to check for `mask.dtype!= np.bool` here.", "reference": "The above 3 lines can be written as: `mask = segms[i].astype(bool)`" }, { "prediction": "I don't think this is needed.", "reference": "File is not `gofmt`-ed with `-s` (from `gofmt`)" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "Thought it's good to have this logged down so that we can check the used value in the logs." }, { "prediction": "I'm not sure if this should be optional, but I'm not sure if it's a good idea to make it optional.", "reference": "I don't think you can call this optional unless it's a pointer - remove this?" }, { "prediction": "I think this should be `Toast.makeText(getActivity(), R.string.txtNoData, Toast.LENGTH_LONG).show();`", "reference": "@naofum please use `isEmpty`method instead" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `maybe_handle.get()` or `maybe_handle.get()` here. I'm not sure if `maybe_handle.get()` is a good idea to use `maybe_handle.get()` or `maybe_handle.get()` or `maybe_handle.get()` or `maybe_handle.get()` or `maybe_handle.get()` or `maybe_handle.get()` or `maybe_handle.get()` or `maybe_handle.get()` or `maybe_handle.get()` or `maybe_handle.get()` or `maybe_handle.get()` or `maybe_handle.get()` or `maybe_handle.get()` or `maybe_handle.get()` or `maybe_handle.get()` or `maybe_handle.get()` or `maybe_handle.get()` or `maybe_handle.get()` or `maybe_handle.get()` or `maybe_handle.get()` or `maybe_handle.get()` or `", "reference": "i think this is unrelated and needs to be reverted. need to discuss at sync." }, { "prediction": "I don't think we need this class anymore.", "reference": "Are we eventually moving those type interfaces from plugin project to datatype project? If not, then we'd have a dependency from core onto plugins, which seems a little counter-intuitive to me." }, { "prediction": "I don't think this is needed.", "reference": "Love how we can finally use async/await in the codebase." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Very minor: this line could be moved to a more narrow scope, inside `if (!representative.decode_account (representative_text))` Other than that, LGTM" }, { "prediction": "IsPresent flag helps in tagging connections that can be exported by Flow Exporter?", "reference": "when is this consumed? I'm probably missing it but I can't find it right now" }, { "prediction": "IsRollup() needed?", "reference": "I think we also need to add the rollupGroupExprList() to the cache key. If we rebuild the list above from a ValueIdSet on line 418 above, it is probably going to be in the same order, regardless whether it was ROLLUP(a,b) or ROLLUP(b,a)." }, { "prediction": "I don't think this is needed.", "reference": "can use `getParamTypeName` instead" }, { "prediction": "I don't think this is needed anymore.", "reference": "Why send the parameters? They're accessible directly from `$this->request` so there's no need to inject them in the method" }, { "prediction": "I don't think this is needed.", "reference": "Tiny nit: I would prefer `not selected_file` or `len(selected_file) == 0`, as if choose_file starts returning, for example, tuples instead of lists, this won't break." }, { "prediction": "I'm not sure if this is the right place to remove the name file. I'm not sure if it's the right place to remove the name file, but if it's the right place to remove the name file, I think it's the right place to remove the name file. If it's the right place to remove the name file, then it's the right place to remove the name file. If it's the right place to remove the name file, then it's the right place to remove the name file. If it's the right place to remove the name file, then it's the right place to remove the name file.", "reference": "How will this code behave with hostnames that contain hyphens?" }, { "prediction": "I don't think we need this.", "reference": "I think this is redundant since \"NullForEmpty\" already calls \"Trim()\"." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `GroupCloudBackupID` field in the `CloudBackupGroupCreateResponse` struct. I'm not sure if it's a good idea to have a `GroupCloudBackupID` field in the `CloudBackupGroupCreateResponse` struct. If it's a good idea to have a `GroupCloudBackupID` field in the `CloudBackupGroupCreateResponse` struct, I'm not sure if it's a good idea to have a `GroupCloudBackupID` field in the `CloudBackupGroupCreateResponse` struct. If it's a good idea to have a `GroupCloudBackupID` field in the `CloudBackupGroupCreateResponse` struct, I'm not sure if it's a good idea to have a `GroupCloudBackupID` field in the `CloudBackupGroupCreateResponse` struct. If it's a good idea to have a `GroupCloudBackupID` field in the `CloudBackupGroupCreateResponse` struct, I'm not sure if it's a good idea to have a `GroupCloudBackupID` field in the `CloudBackup", "reference": "Change this to IDs too?" }, { "prediction": "I think this should be `Set list_of_DC_SCOUT_RAIDS = ImmutableSet.of( \"SCPFCCSPCF\", \"SCFPCSCPCF\", \"SCPFCCCSSF\", \"SCPFCPSCSF\", \"SCPFCPSCSF\", \"SCPFCPSCSF\", \"SCPFCPSCSF\", \"SCPFCPSCSF\", \"SCPFCPSCSF\", \"SCPFCPSCSF\", \"SCPFCPSCSF\", \"SCPFCPSCSF\", \"SCPFCPSCSF\", \"SCPFCPSCSF\", \"SCPFCPSCSF\", \"SCPFCPSCSF\", \"SCPFCPSCSF\", \"SCPFCPSCSF\", \"SCPFCPSCSF\", \"SCPFCPCSCSF\", \"SCPFCPSCSF\", \"SCPFCPSCSF\", \"SCPFCPCSCSF\", \"SCPFCPSCSF\", \"SCPFCPCSCF\", \"SCPFCPSCF\", \"SCPFCPSCF\"`", "reference": "private static final, and it should be located in raidsoverlay, as it's not needed in the plugin. also the name could be a bit better, DC_SCOUT_RAIDS or similiar." }, { "prediction": "I'm not sure if this is the correct behavior.", "reference": "attr_value is 128 bytes?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "if it's unpredictable - why uppercase it at all?" }, { "prediction": "I think this should be `fmt.Println(\"beforeinstallkubeedge\")` or `fmt.Println(\"beforeinstallkubeedge\")`", "reference": "Please remove all these debug prints. It doesn't look good." }, { "prediction": "I don't think this is needed.", "reference": "Consumers of this interface should not be required to provide `sampleHeight`. This should be an expected consensus parameter." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but I'm not sure if it's the right place to do it.", "reference": "I don't believe this is the right fix. If startTime comes after closeTime, then it means some other event triggered invocation of this code path like workflow timeout. In this case we should still try to fire the cron on previous value so we should just return start the delta between startTime and closeTime immediately." }, { "prediction": "I think this should be `CloudBackupStatusType` instead of `CloudBackupStatusType`.", "reference": "Not sure if we need tag here, it is an implementation detail in portworx that isn't exposed in openstorage" }, { "prediction": "I think this should be `@param bool $extended`", "reference": "I wonder if it would be cleaner to refactor all of this similar to the SolrMarc driver, so we have a property with Summon field names associated with types, and we iterate through it in a loop... that way we don't have to repeat the loop code four times with different variable names." }, { "prediction": "I don't think this is the right place for this.", "reference": "Need the `solrClientCache.close();` further down in the method be removed since a shared cache is now used?" }, { "prediction": "I think this should be `Version int64`", "reference": "according to the PR (schema changes?) these 2 field should be removed?" }, { "prediction": "I'm not sure why this was removed.", "reference": "Panic here if `exp.Target.StressChaos.CintainerName` is nil." }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "This allows for some hacks like returning an iterator that matches more docs than the scorer. I liked the previous approach that returned an iterator better." }, { "prediction": "I think this should be `LOG.debug(\"Opening [{}] for read\", file);`", "reference": "Aren't there already logs for this from the underlying file system implementation?" }, { "prediction": "I think this test should be `assertEquals($spec, $defaults, $hndl->toArray());`", "reference": "It would be good to have a test in here that demonstrates the new munge functionality; I can help set that up if you're not sure how." }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to have a `max_retrials_to_get_pods` parameter. If it's a good idea to have a `max_retrials_to_get_pods` parameter, then I think it's a good idea to have a `max_retrials_to_get_pods` parameter that's a good idea to have a `max_retrials_to_get_pods` parameter that's a good idea to have a `max_retrials_to_get_pods` parameter that's a good idea to have a `max_retrials_to_get_pods` parameter that's a good idea to have a `max_retrials_to_get_pods` parameter that's a good idea to have a `max_retrials_to_get_pods` parameter that's a good idea to have a `max_retrials_to_get_pods` parameter that's a good idea to have a `max_retrial", "reference": "`retrials` isn't the word you intend. I think you mean `retries` and to that end, can the var name just be `max_retries`?" }, { "prediction": "I think it should be 255 characters or less.", "reference": "Value in product should contain 255 characters or less." }, { "prediction": "I'm not sure about this change, but I think it's better to use `int(configs[i].Consensus.RollDPoS.ProposerInterval/time.Second)` instead of `int(configs[i].Consensus.RollDPoS.FSM.ProposerInterval/time.Second)`", "reference": "line is 133 characters (from `lll`)" }, { "prediction": "I don't think we need to pass personal_options here.", "reference": "since we're calling the file.rspec-local, I think we should rename local_options to project_options and use local_options for.rspec-local - WDYT?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Will we want to refactor this when we drop rsolr 1.x support?" }, { "prediction": "I don't think we need to pass the nodeIP and nodePasswordFile to the `getNodeNamedCrt` function.", "reference": "should this really be multiple IPs?" }, { "prediction": "I'm not sure if this is the right place to render this partial.", "reference": "Hmm, is that partial used in multiple places? Maybe we can just move that file in here." }, { "prediction": "I don't think we need this file.", "reference": "Should be 2014-2016" }, { "prediction": "I think this should be `value.StartsWith(quote) && value.EndsWith(quote) && value.StartsWith(quote) && value.EndsWith(quote) && value.StartsWith(quote) && value.StartsWith(quote) && value.EndsWith(quote) && value.StartsWith(quote) && value.StartsWith(quote) && value.EndsWith(quote) && value.StartsWith(quote) && value.EndsWith(quote) && value.StartsWith(quote) && value.StartsWith(quote) && value.EndsWith(quote) && value.StartsWith(quote) && value.StartsWith(quote) && value.EndsWith(quote) && value.StartsWith(quote) && value.StartsWith(quote) && value.StartsWith(quote) && value.EndsWith(quote) && value.StartsWith(quote) && value.StartsWith(quote) && value.EndsWith(quote) && value.StartsWith(quote) && value.StartsWith(quote) && value.EndsWith(quote) && value.StartsWith(quote) && value.EndsWith(quote) && value.StartsWith(quote) && value", "reference": "Looks like my fault for sure in trying to handle international inputs regardless of locale. I think the correct fix is actually to get rid of TrySplitColumns and use ParseDsvFields instead. It is what gets used in the end, and it already has logic for dealing with quoted fields." }, { "prediction": "I don't think we need to close cursors here.", "reference": "similarly here, are the these cursors not being closed when the client is closed?" }, { "prediction": "I think this should be `map[string]func(string) Policy`", "reference": "Or maybe `func(args...string) Policy` to make it dynamic in case of any future policy that may require more than one args." }, { "prediction": "I don't think we need to call `MakeFBOsForExistingJournals` here.", "reference": "Should this happen even if the above failed?" }, { "prediction": "I don't think we need this file anymore.", "reference": "Please dont change this." }, { "prediction": "I don't think this is the right place to do this.", "reference": "There is a strange $b that looks wrong." }, { "prediction": "I don't think we need this variable anymore.", "reference": "Is it still important to have `speakEntry` here? It is checked before this value `containerContainsText` is used in the \"General\" section." }, { "prediction": "I don't think this is needed.", "reference": "It is `$JAVA_HOME/bin`, not `$JAVA_HOME`, which should be added." }, { "prediction": "I'm not sure why this is needed.", "reference": "Should move this to within the `#else` block as it's only used there." }, { "prediction": "I think this should be `$this->tester->waitForAjax();`", "reference": "is this a common rule to wait one extra second after ajax? I'm thinking about moving this extra wait into waitForAjax method." }, { "prediction": "I don't think we need this anymore.", "reference": "Maybe you can correct the typo \"if\" too :)" }, { "prediction": "I don't think this is needed.", "reference": "I'd prefer a name less chat-specific, since later on we could have other app types that want the same behavior. Maybe `IdentifyAndAllowTrackBreaks`?" }, { "prediction": "I think this should be `if (import_mpi4py() < 0) {`", "reference": "I think I was involved in writing that caster, but I never fully understood the `import_mpi4py` thing. Why is importing mpi4py still necessary at that point? I would think if the user is passing a communicator from python code, they must already have imported mpi4py themselves, or does that not propagate through into the wrapping layer?" }, { "prediction": "I'm not sure if this is the right place to close the response.", "reference": "This seems like a more interesting change. Maybe we should re-name the PR" }, { "prediction": "I don't think we need this feature anymore.", "reference": "Nit: implement the methods for these interfaces explicitly in this file for consistency. It can be passthrough." }, { "prediction": "I think this should be `isMap(false)`", "reference": "Not directly related to your PR, but I think here we should create a Type enum (MAP, ARRAY, PRIMITIVE) instead of having 3 flags." }, { "prediction": "I think we should move this line to the end of the loop.", "reference": "Do you want this to be a stack variable? The work method might return at any time (example: when the parent queue fills up) and then get called again, which would cause this variable to become false again. I'm wondering if this variable should be a member instead?" }, { "prediction": "I think this should be `reinterpret_cast(&spaceId), sizeof(spaceId));`", "reference": "You could reserve a const space to save the extra computation." }, { "prediction": "I don't think this is needed.", "reference": "Did you consider adding rooted paths like `C:\\ProgramData` and paths with flipped separators?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do this, I'm not sure if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do it.", "reference": "does this line cause a panic if it is above the if condition?" }, { "prediction": "I'm not sure if this is the right place to put it.", "reference": "Maybe `LibraryDetailsPanelType` would be clearer." }, { "prediction": "I'm not sure why this was removed.", "reference": "minor nit - add \"persist-filesystem\" and \"persist-directory\" into commit message, as its something people may search on (maybe applies to a few other commit messages)" }, { "prediction": "Is this still needed?", "reference": "I verified offline with @jeremyg-lunarg this should be removed." }, { "prediction": "I think this should be `fmt.Println(\"incldued_wf name:\", i.Workflow.Name, \" timeout:\", i.Workflow.DefaultTimeout)` and not `fmt.Println(\"incldued_wf name:\", i.Workflow.Name, \" timeout:\", i.Workflow.DefaultTimeout)`", "reference": "This should be removed? If not, typo in incldued_wf" }, { "prediction": "I don't think we need to change this.", "reference": "Sorry for the delay on this! It looks like Circle CI isn't running tests on some of the PRs, but this doesn't look like it would work I might be missing something, but are the tests all passing locally?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Do you think the godoc should mention that all delimiters will be suffixed with `/`?" }, { "prediction": "I think this should be `aURL.startsWith(\"data:\") || SessionStore.get().isCurrentSessionPrivate()`", "reference": "what if I want to load my own, a different, data URI in Private Browsing mode? I do this often on desktop (e.g., `data:text/html,×`). admittedly, I wouldn't expect this to be done by a non-developer, but this will certainly cause a minor bug." }, { "prediction": "I don't think this is needed.", "reference": "I remember the sequence number 0 is kept for the data files for iceberg v1, so in theory the sequence number from delete files should start from 1. So setting it to 0 as the default value sounds correct." }, { "prediction": "I don't think this is needed.", "reference": "For all these MYSQL queries unsigned is required. I have tested again and without unsigned these queries are failing." }, { "prediction": "I don't think we should change this to `MAX_HISTORY` or `MAX_HISTORY_`", "reference": "Are there tests for this? What happens when you get to limit?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "Whole thing could be collapsed to `data['config']['transport'] ||= 'local' if target.name == 'localhost'`." }, { "prediction": "I don't think we need to bind serviceAndGetSignKeyId() here.", "reference": "maybe throw in `&& mServiceConnection.isBound()`, there are cases where the connection might die" }, { "prediction": "IsEip1344Enabled => true?", "reference": "Can we add Istanbul with this first EIP please? (or as a separate issue)" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I don't understand this change" }, { "prediction": "I don't think this is the correct message. I think it's better to say \"Invalid Public key\" instead of \"Invalid Public key\".", "reference": "Let's allow translators for this string to be translated: `self.show_warning(_('Invalid Public key'))`" }, { "prediction": "I don't think we need to check if the role is `form` or `form` or `form` or `form` or `form` or `form` or `form` or `form` or `form` or `form` or `form` or `form` or `form` or `form` or `form` or `form` or `form` or `form` or `form` or `form` or `form` or `form` or `form` or `form`", "reference": "This needs to work with `role=form` too." }, { "prediction": "I don't think we need to update previews for output connections. Is there a reason we need to update previews for output connections?", "reference": "This should be before the if on line 1028, which should turn into an else if" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `NSSelectorMatchExp` field in the `ClusterNetworkPolicySpecBuilder` struct. If it's a good idea to have a `NSSelectorMatchExp` field in the `ClusterNetworkPolicySpecBuilder` struct, then I think it's better to have a `NSSelectorMatchExp` field in the `ClusterNetworkPolicySpecBuilder` struct. If it's a good idea to have a `NSSelectorMatchExp` field in the `ClusterNetworkPolicySpecBuilder` struct, then I think it's better to have a `NSSelectorMatchExp` field in the `ClusterNetworkPolicySpecBuilder` struct. I'm not sure if it's a good idea to have a `NSSelectorMatchExp` field in the `ClusterNetworkPolicySpecBuilder` struct. If it's a good idea to have a `NSSelectorMatchExp` field in the `ClusterNetworkPolicySpecBuilder` struct, then I think it's better to have a `NSSelectorMatchExp` field in the `Cluster", "reference": "Not really introduced by this PR, but I don't recall why these have to be pointers, while `PodSelector` / `NSSelector` do not. Do you know the reason?" }, { "prediction": "I'm not sure if this is the right approach. I'm not sure if this is the right approach.", "reference": "Is there a reason why we are ignoring the ackDelay if it would result in a value smaller than the min? Why not `max(sample - ackDelay, minRTT)`?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Here's an example of how the files in the `NotYetGenerated` directory drifted out of sync from the generated files. When we made the equality comparers internal, we neglected to fix this one." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if it's the best way to do this.", "reference": "nice. we should do this elsewhere too. We have a lot of repeated stuff in the policies" }, { "prediction": "I'm not sure if this is the right place for this test, but I'm not sure if it's the right place for this test.", "reference": "Small formatting thing, but can you remove the space before the semicolon?" }, { "prediction": "I don't think we need to change this.", "reference": "Not new, but nit: _writeLeng*th*." }, { "prediction": "I'm not sure if this is the right place to test this. I'm not sure if it's the right place to test this.", "reference": "Our habit is to go ahead and put a description line (or more) in front of every function, not just non-test or exported functions." }, { "prediction": "I'm not sure if this is the right place for this test.", "reference": "Remove this file from the PR" }, { "prediction": "I don't think we need to pass additional vars here.", "reference": "I think that for cloud variables, the default value in the prompt should be the variable name without the cloud prefix; this is slightly different from the scratch 2.0 behavior, but I think would ultimately lead to less confusion. Proposing code changes below:" }, { "prediction": "I'm not sure if this is a bug or if it's a bug, or if it's a bug, I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, I'm not sure if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, or if it's a bug, but I'm not sure.", "reference": "I think I would rather fish this interface through than use it as the basis for heuristics." }, { "prediction": "I don't think we need this anymore.", "reference": "Probably not worth making this line-ending change, since it is the only change to this file." }, { "prediction": "I don't think we need to check for `opnd_size_in_bytes(OPSZ_CACHE_LINE) == 64, \"OPSZ_CACHE_LINE!= 64\"", "reference": "Is this the correct place for this assert? Does this routine rely on it being 64, or was this only for testing?" }, { "prediction": "I don't think this is needed anymore.", "reference": "No pb please" }, { "prediction": "I don't think we need this column anymore.", "reference": "We need to add indexes here on both `subscriber_id` and `changeset_id` or things will quickly collapse as we build up subscribers ;-) What I would suggest is a unique index on `[:subscriber_id, :changeset_id]` which will also make duplicate entries impossible, and an ordinary index on `[:changeset_id]` for finding the subscribers to a changeset." }, { "prediction": "I don't think this is needed.", "reference": "use the context versions of everything, e.g. `PostMessageContext` and thread it through the functions. will save you a bunch of refactoring trouble later on." }, { "prediction": "I think this should be \"Does the given object (maybe an instance or class) implements the interface.\"", "reference": "\"not to be used elsewhere other than\"" }, { "prediction": "I don't think this is needed.", "reference": "Thanks for the contribution, @coolderli! I also think the newPosDeleteWriter need the properties setting..." }, { "prediction": "I think this should be `user_id` and `team_id`", "reference": "These additions seem unrelated to this change?" }, { "prediction": "I don't think we need this.", "reference": "Could we move this to a class for Hadoop configuration properties, like `org.apache.iceberg.hadoop.ConfigProperties`?" }, { "prediction": "I think we can remove the `if!manageFlag {` block as well.", "reference": "The related statements should also be deleted." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "Shouldn't this line be removed?" }, { "prediction": "I don't think this is needed.", "reference": "Just move this into `const.py`. It already has similar stuff. Also, make it uppercase since it's a const." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Issue is that `currentMode = newMode;` is called at the end of the method. Passcode screen will come up, but since the activity thinks current mode is biometric check we don't check passcode when submitted." }, { "prediction": "I don't think we need to change this. I don't think we need to change this.", "reference": "Need change it back?" }, { "prediction": "I don't think this is the right place to put this secret key.", "reference": "Didn't we delete this file a while back because it isn't used but people think that it's a security vulnerability that it's checked in?" }, { "prediction": "I don't think this is needed anymore.", "reference": "nit: Looks like this can be removed now" }, { "prediction": "I'm not sure why this was removed.", "reference": "Can probably remove the lines above it too (L60-62), since ProvisionDefaultCA() makes sure the map isn't nil." }, { "prediction": "I don't think this is needed.", "reference": "Do you think it's worth erroring out? It's likely that this is a configuration error that the user might want to know about?" }, { "prediction": "I'm not sure if this is the right fix.", "reference": "I think the functional test should not change here, this is probably a test in itself :)" }, { "prediction": "I don't think this is needed.", "reference": "Why this to be a public function?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I think we can remove the timing for export env vars" }, { "prediction": "I don't think we need to do this anymore.", "reference": "wrong import grouping" }, { "prediction": "I'm not sure if this is the right place to use System.arraycopy, but I think it's better to use System.arraycopy.", "reference": "There is a doubled semicolon ;)" }, { "prediction": "I don't think this is needed.", "reference": "I'm wondering why this isn't . Seems like one would have to copy the md5.h file into the source tree somewhere for this to compile cleanly. Maybe you meant to use angle brackets instead of quotes?" }, { "prediction": "I don't think we need to change this class.", "reference": "shouldn't **call** return a boolean?" }, { "prediction": "I don't think this is needed.", "reference": "We don't need to cast to client here. (well, from spell gem not AA etc) We should also make sure the charm is a casted spell before calling SendSpellBarEnable." }, { "prediction": "I think this should be `invocation_id = Column(DateTime(), nullable=False)`", "reference": "This is not an `id`. This should either be `invocation_time` or `invocated_at` to be consistent with what we are using elsewhere, and also to better rerflect the column's DateTime type. Also, within the context of this table, there is no idea of what `invocation` is. I know that `scanner` may not be future-proof, but we need to find something more descriptive. Perhaps one possibility is to call this `audit_time`." }, { "prediction": "I don't think this is needed.", "reference": "should the 'Receiver' be the clawback address in case of clawback transaction?" }, { "prediction": "I think this should be `/latest/volumes/`", "reference": "@ashishranjan738 -- Where are these consts used? in which pkg?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "The only change I would suggest is moving these lines back below the `templates_path` variable to keep the diffs smaller." }, { "prediction": "I don't think this is needed.", "reference": "Having it above kept the block info in the cached changes, which could end up confusing things quite a bit." }, { "prediction": "I'm not sure if this is the right place to call `run_task` or `run_task` or `run_task` or `run_task` or `run_task` or `run_task` or `run_task` or `run_task` or `run_task` or `run_task` or `run_task` or `run_task` or `run_task` or `run_task` or `run_task` or `run_task` or `run_task` or `run_task` or `run_task` or `run_task` or `run_task` or `run_task` or `run_task` or `run_task` or `run_task` or `run_task`", "reference": "If the execute_task returns an `ExecutionResult`, the passing of a block would be unnecessary. Instead, the `ExecutionResult` could be presented to the user in some standardized way (iterating over the result of each node, etc.)." }, { "prediction": "I don't think we need to make a struct here.", "reference": "Not sure why we make a new channel here. If we don't use this channel, how about creating it inside the `Connect`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "There are two question here: 1. If you only modify lastLogId, but the `iter` is not modified, I really don't know whether we can succeed. 2. We will check the if the term has changed in `replicateLogs` (if rollback really happen, the term must have been updated), so I really doubt whether the problem should be fixed in this way. Or you could describe it in more details." }, { "prediction": "I think we should remove the `getName()` and `getFormType()` from the `FormFlow` class.", "reference": "Hello @jDolba, I have reviewed your PR and I found one problem. `$step->getFormType()` can return `FormTypeInterface`. You cannot use interface as key for an array. Can you find some better way to fix this? Thank you." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.", "reference": "i was confused by keyword \"inventory\" here. my understanding is this starts the osconfig-agent which covers inventory lookup and package-management(correct me if i am wrong)." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "These are really meant to be the keys in the capabilities, not the keys of values within the capabilities" }, { "prediction": "I don't think we need sinon here.", "reference": "This breaks tests on IE because this will import an `esm` bundle. For that reason `sinon` is available as a global in our test suite and never imported. The global is aliased to the proper `es5` file." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Maybe move all the Loss Recovery constants to a separate file." }, { "prediction": "I think this should be `diskName string mode string attacher, detacher`", "reference": "this field is added so that we can find disk name by device name from attachments" }, { "prediction": "I don't think this is needed.", "reference": "Unnecessary new line" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or not.", "reference": "First determine if the namespace already exists, so it's clearer that it's handling namespaces that aren't included in the `c.config.Namespaces`" }, { "prediction": "I don't think we need to change this file.", "reference": "What changed in the styles that means we don't need this?" }, { "prediction": "I don't think this is needed.", "reference": "This pattern should be applied to the other instance where NewtonsoftEscapeJProperty is used and you can remove the NewtonsoftEscapeJProperty method." }, { "prediction": "I think this should be `self.warning(\"Histogram edges should be supplied as a tuple, passing the edges will be deprecated in holoviews 2.0.\")`", "reference": "Something to mention in the next changelog/release notes. It will be good to get histogram working consistently with everything else." }, { "prediction": "I'm not sure if this is the right place for this change.", "reference": "What does this contain? Is it PVC namespace or is it openebs?" }, { "prediction": "I don't think this is needed.", "reference": "Design note: Using local concrete data types on a feature abstraction makes it hard to generalize / replace. This is tolerable so long as this remains a kestrel exclusive feature, but we'd need a different design if this were ever moved to HttpAbstractions." }, { "prediction": "I'm not sure if it's a good idea to make it a good idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea to make it a bad idea.", "reference": "this will break R package, you should update the R files accordingly. BTW, the call state should be in the last argument." }, { "prediction": "I don't think we need to check for `null!== $mediaContext` here.", "reference": "Shouldn't we throw an exception if the context is null instead?" }, { "prediction": "I don't think this is needed.", "reference": "These should both be const, not var right?" }, { "prediction": "I don't think this is needed.", "reference": "Rename the directory, match_costers -> match_costs" }, { "prediction": "I think this test should be `self.assertEquals(int(count), 2)`", "reference": "I don't think this should go in the model tests, since it is done in the resource. `PaginatedDeleteTest` seems more appropriate" }, { "prediction": "I don't think this is the right thing to do here. I think this should be `SessionNotFoundException`.", "reference": "It would be better to just change RWD to throw IllegalStateException if you attempt to execute a command after quit (unless it's a second call to quit())" }, { "prediction": "I'm not sure if this is the right place to call `InstallNewPipeline` or `InstallNewPipeline`.", "reference": "Could we move this to an example test to allow the compiler to help us ensure it stays up-to-date in the future?" }, { "prediction": "I'm not sure why this was removed.", "reference": "Maybe we could update these to use $future and then check on stderr? that way when we deprecate stdout we can not have to delete tests." }, { "prediction": "I don't think we need to change this?", "reference": "Remove this since it always has to be set afterwards." }, { "prediction": "I think this test should be `testCrUnmergedWriteMultiblockFile(t *testing.T)` and not `testCrUnmergedWriteMultiblockFile(t *testing.T)`", "reference": "These two tests were causing us to use too many goroutines with `-race` using the default block change size, I think due to prefetching." }, { "prediction": "I don't think this is needed.", "reference": "Is that `try..except` block really needed? I mean, when it could fail?" }, { "prediction": "I don't think this is needed.", "reference": "If you only want to run a specific group of tests you can always use `.only` like `it.only()` or `describe.only()`. It may not speed up the globbing process as much as this change here :)" }, { "prediction": "I don't think we should change the batch size?", "reference": "nit: I'd probably rename this to `BATCH_SIZE_RANGES`, to use a slightly more descriptive name." }, { "prediction": "I'm not sure if this is the correct priority.", "reference": "aren't these the wrong way around?" }, { "prediction": "I don't think this is needed.", "reference": "Lets call this getConfigSetService and maybe rename the field now (or later)" }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "Could / should we make these constants and give them a type?" }, { "prediction": "I'm not sure about this.", "reference": "lets stick with lowercase for consistency." }, { "prediction": "I don't think we need this line anymore.", "reference": "ordering of imports went wrong" }, { "prediction": "I think this should be `String.valueOf(MetadataTableType.ALL_DATA_FILES)`", "reference": "I think these can all be.name() to get the value we are looking for" }, { "prediction": "I'm not sure about this, but I think it's better to use `printOnlyString` instead of `printOnlyString`.", "reference": "Is this a good place for these test cases?" }, { "prediction": "I think this should be `print response_name, attr_name, default = response_data[response_name])`", "reference": "Did you mean to leave the print statement?" }, { "prediction": "I think we should use BN instead of BN.", "reference": "I would do `new BN(Interpreter.LOCKTIME_THRESHOLD)`" }, { "prediction": "I don't think this is needed.", "reference": "@ftomassetti I turned the tree walking algorithms into iterators so you don't have to visit every node when you only wanted a few, like for a `findFirst`." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Need to add type name here to be compatible with proto string representation." }, { "prediction": "I'm not sure if this is the right place to put the finest message, but I think it's better to put the finest message in a separate file.", "reference": "This is to let people know that the tooling is doing something during a build. Please leave." }, { "prediction": "I don't think we need to change this.", "reference": "Why is the principal changing here?" }, { "prediction": "I don't think we need to do this. I'm not sure if we need to do this, but I'm not sure if we need to do this.", "reference": "Naming nit: let's use `AZURE_STORAGE_` prefix for consistency with the other ones." }, { "prediction": "I don't think this is needed.", "reference": "I'm a bit confused. We have an actual `ProgressBar` Uppy React wrapper component that we are testing. Why do we need a mock for it?" }, { "prediction": "I don't think this is needed.", "reference": "can we use `github.com/pkg/errors`?" }, { "prediction": "I'm not sure about this change, but I'm not sure if it's worth it.", "reference": "I changed the name of the arguments here just to help make the code clearer." }, { "prediction": "I'm not sure if this is the right thing to do, but I think it's better to call `DynamicMap` directly from the `Callable` class.", "reference": "I think either 'avoiding calls to the function' or 'to avoid calling the function...' would be read better." }, { "prediction": "I'm not sure if this is safe to presist as long as shared_attachments_ is not cleared. I'm not sure if this is safe to presist as long as shared_attachments_ is not cleared.", "reference": "@sfricke-samsung -- thanks. saves a few atomic ops which is always good :) The TODO is there to track that this object is storing *both* vectors of shared_ptr and plain pointers to the same data. The shared are to ensure scope, and the plain are for backwards compatibility with existing code that consumed a plain pointer vector (and some code that still does). That should be cleaned up." }, { "prediction": "I don't think this is needed.", "reference": "minor: typo (knowMetricsTypes -> knownMetricsTypes)" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "This adds a case-insensitive flag to the type in the RangeSpec, but I don't think RangeSpecs are written to handle case-insensitive comparisons. Take a look at the methods that deal with comparisons when building RangeSpecs, in file Range.cpp. So, I think you would have to do one of two things: a) disable the RangeSpec transformation for case-insensitive comparison operators (the easy way) or b) change the RangeSpec methods to handle case-insensitive comparisons." }, { "prediction": "I think this method should be `tryToSolveType` instead of `tryToSolveType`.", "reference": "I would throw an exception if the type is not solved" }, { "prediction": "I'm not sure why this was removed.", "reference": "if remove `dt.skipLoad` - then this tests will run. You probably mean opposite?" }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "I feel like we do this in a lot of places should we move that out into its own PR?" }, { "prediction": "I'm not sure if this is a breaking change. I'm not sure if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, it's a breaking change, or if it's a breaking change, or if it's a breaking change, it's a breaking change, or if it's a breaking change, or if it's a breaking change, it's a breaking change, or if it's a breaking change, or if it's a breaking change, it's a breaking change, or if it's a breaking change, or if it's a breaking change, it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, it's a breaking change.", "reference": "Already asked you in Matrix, but I'll do it here again so it can be discussed publicly. Why?" }, { "prediction": "I think this should be `\"Unnecessary \"%s\" after \"return\"`", "reference": "I think here should be a comma before remove, in all the cases" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "Single quote is used by default in this project." }, { "prediction": "I'm not sure if this is a bug or if it's a bug or if it's a bug or if it's a bug.", "reference": "S1023: redundant `return` statement (from `gosimple`)" }, { "prediction": "I'm not sure if this is the right place to close webhooks, but I think it's better to call `Close(ctx context.Context)` instead of `Close(ctx context.Context)` and then call `Close(ctx context.Context)` in the `Run` function.", "reference": "`ctx` is unused in Close" }, { "prediction": "I think we should use `NotFoundHttpException` instead of `NotFoundHttpException`.", "reference": "I'm confused. This exception is thrown when `HeurekaCategory` is not found in database. But this exception extends Http exception. Why? What has database search common with http? If the only reason is that it is the same in the whole project, then fine. But then we have even bigger problem - we don't know how to use exceptions." }, { "prediction": "I'm not sure if we should do this in a follow-up PR.", "reference": "Is it necessary to add the suffix `on_head`, because it belongs to` bbox_head`?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "Hmm, I wonder if this should just be e.g. `--with-grub-2.02` instead. (Not sure Autoconf supports periods in these switches.) Today's modern GRUB is tomorrow's ancient GRUB. :) Or maybe we should be specific about the feature this is enabling, which might be safer given that each distro carries so many patches. E.g. `--without-grub-efi-16-suffixes`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I think it's better to move this to the `Client` struct.", "reference": "Add a GetSerialPortOutput method to Instance that way you don't need to access the client, also it makes the call cleaner as you don't have the odd i.Client and path.Base(i.Project), path.Base(i.Zone)" }, { "prediction": "I'm not sure if this is the right place to put this in.", "reference": "Line is too long. [104/80]" }, { "prediction": "I'm not sure if this is the right thing to do here. I'm not sure if it's the right thing to do here.", "reference": "Since CD updates (assignment & power state) are now done in this controller..." }, { "prediction": "I don't think this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Hmm I'd rather not support this option going forward - it seems like a one-off just to work around this particular issue. Would it be fine to just remove the `deepStackTrace` option? The rest of the PR looks great - I love the idea of switching to sets." }, { "prediction": "I'm not sure if this is the right place to put this method, but I think it's better to put this method in a separate PR.", "reference": "on the one hand I like how little this is doing. On the other hand, `inbound_mail_parser` is doing most of the work here so maybe it's not as helpful as I originally thought" }, { "prediction": "I think this should be `history_depth(10).asynchronously(eprosima::fastrtps::rtps::RTPSWriterPublishMode::ASYNCHRONOUS_WRITER).init();`", "reference": "This line is too long" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This isn't a fatal error, we don't want to crash just because we can't set configs, we have sane defaults set" }, { "prediction": "I'm not sure if this is the right place to use `lookupPath` and `lookupPath`", "reference": "I wondered why `buffer` was passed into `LookupPath`. What is happening here? Is `buffer[:0]` equivalent to `[]V4TrieEntry{}`, and hence `buffer` isn't needed any more?" }, { "prediction": "I don't think we need to use `_blank` here. I think we should use `_blank` instead of `_blank`.", "reference": "I don't really like the name of this file, especially the encoding of an implementation detail (the fact that it's a table) in the name. Can we just use `_message_body.html.erb` instead maybe?" }, { "prediction": "I think this should be `varint,7,opt,name=enableLogging`", "reference": "Feel better not to expose our internal implementation in API/CRD, so no need to mention agent here. Consider: EnableLogging indicates whether or not to generate logs when rules are matched. Default to false." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "use `NebulaKeyUtilsV3::dataVersionValue()` to replace the literal value?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "No need for the `\\` here, inside parentheses whitespace is ignored by Python." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `certificate_pem` or `certificate_pem` here. I'm not sure if it's a good idea to use `certificate_pem` or if it's a good idea to use `certificate_pem` or `certificate_pem` here.", "reference": "This doesn't seem like the right expected result... it should be the same as the `clientCert` var defined above." }, { "prediction": "I'm not sure if this is a bug or if it's a bug or if it's a bug, or if it's a bug, I'm not sure.", "reference": "need to rename this now." }, { "prediction": "I don't think we need to do this anymore.", "reference": "NIT: This shouldn't be a TODO. It is just a note isn't it?" }, { "prediction": "I think this should be `message.warning('Edited element vanished')`.", "reference": "I changed this to an error, that seems more appropriate than a warning here." }, { "prediction": "IsEvmTransfer() { numLog++ } IsEvmTransfer() { numLog++ }", "reference": "This change could mute unit test failure, but it is better to update unit tests" }, { "prediction": "I don't think we need to delete the notificationIdsInUse.", "reference": "All other places that access `notificationIdsInUse` are in methods with descriptive names. We should do the same here. Maybe `markNotificationIdAsFree()`?" }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if this is the right thing to do. I'm not sure if this is the right thing to do, but if it's the right thing to do, I'm not sure if it's the right thing to do. If it's the right thing to do, I'm not sure if it's the right thing to do, but if it's the right thing to do, it's the right thing to do. I'm not sure if it's the right thing to do, but if it's the right thing to do, it's the right thing to do. If it's the right thing to do, it's the right thing to do.", "reference": "keep as `ErrNotFound`, it is the same convention as in other packages" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Same here, we need to call `callback` in else branch" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "At this point we already check that the record is valid and so it could never be nulll" }, { "prediction": "I don't think this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do it.", "reference": "Would it not be more sensible just to move setting of the title to later in the method rather than duplicating it here?" }, { "prediction": "I don't think this is needed.", "reference": "why not do it in `reclaimExpiredSessions`? and `pushSessionToCache` can delete" }, { "prediction": "I don't think this is needed.", "reference": "out_channels/num_outs/type are unnecessary" }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if this is the right thing to do.", "reference": "You can create an issue for it and put it on the backlog so we don't forget it." }, { "prediction": "I don't think we need to check for validNetworkMode here.", "reference": "So now we are checking twice, both here and in `weaveCIDRsFromConfig`. Not great. I suggest changing the `ok` return of `weaveCIDRsFromConfig` to a messsage (or error?) instead, which we can then log." }, { "prediction": "I'm not sure if this is the right place to remove the `clear_contents` call.", "reference": "An alternative to setting format to the default in Package.__init__ would be to set it in create_package. I think we can assume all packages are created by create_package, but not necessarily by build_package." }, { "prediction": "I think we should move this to the `MiningState` struct.", "reference": "Let's add fee recipient as well." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `__init__` method, but if it's a good idea to have a `__init__` method, then I think it's a good idea to have a `__init__` method.", "reference": "No need for those with `super-init-not-called`, as pylint already only turns things off for this function and it's needed for the entire function." }, { "prediction": "I don't think we need this.", "reference": "I think there's another spot for this in DefaultCapabilityMatcher" }, { "prediction": "I'm not sure if this is the right place for this method. I'm not sure if it's the right place for this method, but if it's the right place for this method, I'm not sure if it's the right place for this method.", "reference": "this name seems pretty vague -- thoughts on a more descriptive method name?" }, { "prediction": "I don't think we need this file anymore.", "reference": "what changed in this line?" }, { "prediction": "I don't think this is needed.", "reference": "Instead of doing this let's add another function similar to `hasZeroData` for selecting the `reportArgs` since this is all sourced from selected values. Then `hasZeroData` can use this internally, as well as the component itself. Since this function would be internal just for the purpose of avoiding duplication, we don't need to expose it on the component the same way though." }, { "prediction": "I think we should remove the `$exceptionClassName = basename(str_replace('\\\\', '/', get_class($exception)));` line.", "reference": "This line was useful for auto-completion, I think it should be re-added with specifying the var name (`$exception`) and simplifying the FQCN." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "This looks like you're not collecting everything from the error channel." }, { "prediction": "I think we should use `@checkout.plan_name` instead of `@checkout.plan_name`", "reference": "This currently violates the Law of Demeter. Using `checkout.plan_name` is the quick resolution." }, { "prediction": "I don't think this is needed anymore.", "reference": "is there any scenario when `$temporaryFilename` can be null?" }, { "prediction": "I'm not sure about this, but I think it's better to use `@SuppressWarnings(\"ReferenceEquality\")` instead of `@SuppressWarnings(\"ReferenceEquality\")` in the `FlinkTypeToType` class.", "reference": "this is for the `boolean isRoot = root == rowType` check, which seems to be on purpose, but maybe you could double check whether using ref. equality here is still wanted? Same for `SparkTypeToType`" }, { "prediction": "I don't think this is needed.", "reference": "No need to damage after `roots_drag_icon_update_position`, this is already done in `roots_drag_icon_update_position`" }, { "prediction": "I think this should be `torch.device('cpu')`", "reference": "Have you tested exporting to ONNX with `device=cuda`?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or not.", "reference": "Do we also need to validate `envName` flag then? `appName` and `envName` are used in `initLogsSvc` which are called by `svc logs` from within `Execute()`" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it.", "reference": "@LukeTowers I think I would prefer that we don't force it, on the basis that: a) some people would be opting to configure their web server to protect against this kind of attack and would disable this feature in October CMS to get a small performance increase. b) it might be a bit misleading to say that `app.trustedHosts` set to `false` disables the feature entirely, just to have it be overridden here regardless." }, { "prediction": "I don't think this is needed anymore.", "reference": "i like that you are trying to correct the naming, but its making the PR longer :( i guess in future we can do such changes in separate PRs" }, { "prediction": "I'm not sure if this is the correct behavior.", "reference": "Are we marking what the browser's accessibility tree says or what screen readers with those browsers say?" }, { "prediction": "I'm not sure if this is the right place to call `Close()` or `FullClose()`", "reference": "This method should behave as intended, to block until it reads an EOF from the other side." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `Fsck` or `Fsck` here.", "reference": "I prefer starts with `Failed to xxx`, how about `Failed to perform health check on xxx`?" }, { "prediction": "I'm not sure if this is the right place to set the tags.", "reference": "All these calls make me think we should refactor how traces are started and allow \"source tags\" that we initialize a trace with. I'd like to do this in a follow up." }, { "prediction": "I don't think we need this file anymore.", "reference": "This file shouldn't be in this PR" }, { "prediction": "I think this test should be `SKIPPED-nonEmptyAssignmentToListElementChangeType` instead of `SKIPPED-nonEmptyAssignmentToListElementChangeType`", "reference": "This now causes `LessSpecificReturnStatement - src/somefile.php:9:32 - The type 'non-empty-list<5|string>' is more general than the declared return type 'non-empty-list' for takesList`, which seems correct to me. The type `non-empty-list<5|string>` contains the type `non-empty-list`. Thoughts?" }, { "prediction": "I don't think we need to log this message.", "reference": "Are you going to change that back?" }, { "prediction": "I don't think this is needed.", "reference": "we have a standard format for putting these together elsewhere, it does the filter check first and errors out and then sets based on the value. i think this should be adjusted to do that. there's no logical change, just an approach change." }, { "prediction": "I don't think we need to do this. I'm not sure if we need to do this.", "reference": "Note this should be `delay` instead of `scale` here. I'll fix this in my branch." }, { "prediction": "I'm not sure why this was removed.", "reference": "`on` likely still needs a bind, similar to `this.resetProgress = this.resetProgress.bind(this)` correct?" }, { "prediction": "I don't think this is needed.", "reference": "Considering the trade-off between training speed and accuracy, multi-scale training is temporarily kept. More elegant implementation will be adopted in the future." }, { "prediction": "I'm not sure if this is the right place to put this import.", "reference": "Can you move this up along with the other builtin libraries?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "I actually think it makes sense to reposition this checkbox after the notifyForPendingUpdateCheckBox. The current order of check boxes is a bit arbitrary now." }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to add a description for this command. I'm not sure if it's a good idea to add a description for this command, or if it's a good idea to add a description for this command.", "reference": "Why do we have both `before` and `after`? Naively I would expect this to work as follows: `plz query changed` with no arguments compares the current working directory state to the last commit (i.e. HEAD, i.e. a noop when directly on a git commit). `plz query changed --since [reflike]` compare the current working directory state to the given reflike. So for CI I would expect to run something like `plz query changed --since @{upstream} (or origin/master I guess)`. And on merge I'd either run everything or just `plz query changed --since HEAD^` (given our workflow) - I don't think I'd ever want to do anything else. Either way I think before and after are slightly confusing terms here." }, { "prediction": "I'm not sure if this should be `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary` or `is_binary`", "reference": "Is there a reason why we can't use `~dst`? It feels like that could be good enough.I would like to avoid extending the filter syntax unless there's an urgent need. :)" }, { "prediction": "I don't think this is needed.", "reference": "Why local and not UTC?" }, { "prediction": "I don't think we need to check for `!diagArea_->contains(-2013)) &&!diagArea_->contains(-2012))`", "reference": "2012 is a retryable error. Will avoiding rgenerating it here cause a difference in behavior in createServer()?" }, { "prediction": "I'm not sure if this is needed.", "reference": "move to line 14 below" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "the method name should match teh docs" }, { "prediction": "I think this should be `require.NoError`.", "reference": "Won't this happen automatically when we flip the default version in the config?" }, { "prediction": "I think this test should be `/var/www/html/docroot` instead of `/var/www/html/docroot`", "reference": "This would also change back to /var/www/html/docroot if we go that way." }, { "prediction": "I don't think this is needed.", "reference": "This still needs to use the new option. We'll need tests for it too." }, { "prediction": "I don't think this is needed.", "reference": "We are no longer including file name in the source files." }, { "prediction": "I'm not sure if this is the right place to put this in. I'm not sure if this is the right place to put it in.", "reference": "no need for this. Devise provides us with `current_user` and `user_signed_in?` helpers." }, { "prediction": "I don't think this method is used anymore.", "reference": "Would `Object.equals(capability.getName(), NAME)` would be safer, as you wouldn't have to do null checks?" }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if it's the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Hmm, I wonder if we should revert #1862 instead? BTW, what failure do you get w/o this line?" }, { "prediction": "I'm not sure if this is the right place to do this, but I think it's better to use `ValidateURL(out.APIURL)` instead of `ValidateURL(out.APIURL)`", "reference": "since there are several places where we do 1) get secret key ref and 2) validate URL, maybe it's worth having a common method? it could also trim spaces as done here (but not at the other places currently)." }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "TestNormalize... I would also split them" }, { "prediction": "I don't think we need this anymore.", "reference": "All changes to this file are going to conflict with #7599. Please revert these as well. They will be addressed during the Python 3 transition." }, { "prediction": "I'm not sure if this is thread safe or not. I think it's better to use `r.RLock()` instead of `r.RUnlock()`.", "reference": "Just thought, using spinlock (busy wait with compare and swap) that generates 2 random numbers inside rlock. We know that collisions are rare and we don't need that \"large\" write lock really but lock namely for \"rand\". Or least use a separate Lock (Mutex), namely for \"rand\" (wrap it into method). Mutex will use some sort of spinlock as well but it may use some linked list to make it more fair." }, { "prediction": "I don't think this is needed. I think it's better to use `sys.getdefaultversion()` instead of `sys.getdefaultversion()` and then use `sys.getdefaultversion()`.", "reference": "Can we grab it directly from `__pkginfo__` as that is the source of truth for the version?" }, { "prediction": "I don't think this is needed.", "reference": "We can revert this to reduce the diff of the PR." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "This looks weird. `isCloud` should define if it is a cloud or no. Here it does it partially, and it can be overriden by protoPkg value (which also an argument to this function). Please make sure that isCloud completely defines the cloud thing. (i.e. it an be as straightforward as moving `protoPkg.contains(\"cloud\")` from here to the place where `assembleGoImportPath` is called." }, { "prediction": "I think this should be `(LobTgtFileFlags)fileflags == Lob_Error_Or_Create || (LobTgtFileFlags)fileflags == Lob_Error_Or_Create || (LobTgtFileFlags)fileflags == Lob_Error_Or_Create || (LobTgtFileFlags)fileflags == Lob_Error_Or_Create || (LobTgtFileFlags)fileflags == Lob_Error_Or_Create || (LobTgtFileFlags)fileflags == Lob_Error_Or_Create || (LobTgtFileFlags)fileflags == Lob_Error_Or_Create || (LobTgtFileFlags)fileflags == Lob_Error_Or_Create || (LobTgtFileFlags)fileflags == Lob_Error_Or_Create || (LobTgtFileFlags)fileflags == Lob_Error_Or_Create || (LobTgtFileFlags)fileflags == Lob_Append_Or_Error || (LobTgtFileFlags)fileflags == Lob_Error_Or_Create || (LobTgtFileFlags)file", "reference": "Declaring fileflags to be of type LobTgtFileFlags would eliminate the need for all this casting. And would be safer. (Not a show-stopper though.)" }, { "prediction": "I'm not sure if this is the right place to put the finest message.", "reference": "This change prevents a user understanding how their server is configured. Best to leave at `info` level." }, { "prediction": "I'm not sure about this, but I'm not sure if it's worth it.", "reference": "Typically we would add something to the build system environment to differentiate this; also is there an alternative that can be used with older OpenSSL? Other folks who are committers will need to decide if it is worth supporting an older and likely quite vulnerable (to hacks) OpenSSL library." }, { "prediction": "I'm not sure if this is the right place to read active block producers.", "reference": "`readActiveBlockProducersByHeightTests` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I don't think this is needed anymore.", "reference": "Falls back on `Constants.ID` if there's no custom field set." }, { "prediction": "I think this should be `in.skip(this.getOffset());`", "reference": "I believe this is what we want to rearrange: this in.skip() should not be happening here, in the open method, but in the setOffset() method itself. Because we want to be able to change that offset after the initial open. The setOffset() method will need to throw an IOException, if it's called while the InputStream is still null; or if the skip() call itself results in an IOException()" }, { "prediction": "I think this should be `return getMethodNameDeclaratorNode().getParent().getChild(0) instanceof ASTPrimitiveType;`", "reference": "In case the method is `void`, there won't be any children and `getChild(0)` throws. We'll need to check with `isVoid()` for that case. I'll update this when I merge." }, { "prediction": "I think this should be `yarpc.Interceptors{requestLogInterceptor{}}`", "reference": "If the yarpc.Interceptors wrapper will be added to any user interceptor, why not do it transitively. Can save one step for users. Same apply to filter." }, { "prediction": "I don't think this is needed.", "reference": "Is there anything we should do in the event we're unable to renaming the directory?" }, { "prediction": "I'm not sure if this is the right place to start the ingress handler. I'm not sure if this is the right place to start the ingress handler, or if it's the right place to start the ingress handler, but if it's the right place to start the ingress handler, I'm not sure if it's the right place to start the ingress handler.", "reference": "How is this env var populated? Can this be retrieved from cluster metadata?" }, { "prediction": "I don't think this is the right event.", "reference": "Should probably skip the success event here, since it could be a noop." }, { "prediction": "`squareShape: 'overflowSquare'` should be `squareShape: 'overflowSquare'`", "reference": "I added this here because people cards (which depends on cardBuilder) had this added in blurhash. Not sure when this is used though cc @JustAMan" }, { "prediction": "I don't think we need this anymore.", "reference": "Let's keep this line in the docstring, to let end users know they shouldn't be using this directly." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "can do the same for other validateXXX()" }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "Why is this necessary?" }, { "prediction": "I don't think this is needed.", "reference": "Please move this import upper to other similar imports" }, { "prediction": "I don't think we need to do this.", "reference": "Include the key word \"translated\". Otherwise the reader will find this confusing." }, { "prediction": "I think this should be `@Memoized` instead of `@Memoized`.", "reference": "why. is this called per request? if so this also adds a lock internally. can we not add this at the moment until analyzed as this assumption isnt carried to the several other impls. the only other consumer of this is the http api and that isnt hit often enough for specializations." }, { "prediction": "I don't think we need to change this. I think we should be able to get the `actualNode.selected` value from the `select` element.", "reference": "I believe this means dependent checks can no longer operate on virtual nodes, which is something we've been pushing for lately. We may need to find a different way to solve this issue, as I don't think we want to cause a regression while fixing a bug." }, { "prediction": "I don't think this is needed anymore.", "reference": "ditto about use of `abspath`" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "this reduces the runtime by 50 times" }, { "prediction": "I think this test should be `RemoteDistributorTest` instead of `RemoteDistributorTest`.", "reference": "Probably best not to have an empty test...." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "direct `newInstance` call is also deprecated now" }, { "prediction": "I'm not sure if we should remove this line.", "reference": "We have a bit of a convention where imports are split into three blocks: first Go standard library, then imports from outside the repo, then imports from inside the repo." }, { "prediction": "I think this should be protected.", "reference": "Why was this change needed?" }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to use `ifname` instead of `ifname`.", "reference": "can you use this opportunity to remove `.readlines()` useless list creation? (`addresses = [l for l in fd if l.find(\"netmask\") >= 0]`)" }, { "prediction": "I'm not sure if we should change this message to \"The plan was expceted to mention the host #{node.hostname} with _output\" or \"The plan was expceted to mention the host #{node.hostname} with _output\" or \"The plan was expceted to mention the host #{node.hostname} with _output\" or \"The plan was expceted to mention the host #{node.hostname} with _output\" or \"The plan was expceted to mention the host #{node.hostname} with _output\" or \"The plan was expceted to mention the host #{node.hostname} with _output\" or \"The plan was expceted to mention the host #{node.hostname} with _output\" or \"The plan was expceted to mention the host #{node.hostname} with _output\" or \"The plan was expceted to mention the host #{node.hostname} with _output\" or \"The plan was expceted to mention the host #{node.hostname} with _output\" or \"The plan was expceted to mention the host #{node.hostname} with _output\" or \"The plan was expceted to mention the host #{", "reference": "Why does this check differ from `plan_ssh.rb`?" }, { "prediction": "I'm not sure if we should remove this line.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "Is this still needed?", "reference": "It was @lodejard who initially suggested this pattern. I think that it had something to do about prioritizing future writes even if there was a pending write operation ready to handle the newly requested write. I'm not sure I fully understood the explanation for having up to 3 pending write requests, because only having one queued write at a time still makes sense to me. I'll talk to him about it." }, { "prediction": "I think this should be `debug_clear_online_weight` or `debug_dump_online_weight`", "reference": "We have cli --online_weight_clear in cli.cpp" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "So the request.Headers is a map of []string. Are you sure that the HTTP library doesn't already do this split for us?" }, { "prediction": "I think this should be \"Execution stopped, crashed executor/container\"", "reference": "How is this message used? Can we remove the \"crashed executor/container\" part which is an implementation detail?" }, { "prediction": "I'm not sure if this is the right place to put the HEAP_SNAPSHOT.", "reference": "Instead of building in routing for a browser-specific command, could you refactor the HttpCommandExecutor to allow arbitrary commands to be registered?" }, { "prediction": "I don't think this is needed.", "reference": "Space after `=`." }, { "prediction": "I think this should be done in a separate PR.", "reference": "if just need to do something after createInvocation just override and call super first is enough?" }, { "prediction": "I'm not sure if it'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''',''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''", "reference": "By the way, I fixed `announce` method (missing `super` call to announce JDK version)" }, { "prediction": "I think this should be `@SuppressWarnings(\"unchecked\")` and not `@SuppressWarnings(\"unchecked\")`", "reference": "I'm not sure about that... This line can produce ClassCastException if Comparator do not check this." }, { "prediction": "I'm not sure this is the right place for this.", "reference": "There wasn't any special reason for this to return a pointer, right?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Why the need for a `ConcurrentHashMap`?" }, { "prediction": "I don't think this is needed.", "reference": "New code should use strict equality `===`" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `run_cli_json` or `run_cli_json` here. I'm not sure if it's a good idea to use `run_cli_json` or `run_cli_json` here. I'm not sure if it's a good idea to use `run_cli_json` or `run_cli_json` in the future, but if it's a good idea to use `run_cli_json` or `run_cli_json` in the future, I'm not sure if it's a good idea to use `run_cli_json` or `run_cli_json` in the future. If it's a good idea to use `run_cli_json` or `run_cli_json` in the future, I'm not sure if it's a good idea to use `run_cli_json` or `run_cli_json` in the future. If it's a good idea to use `run_cli_json` or `run_cli_json` in", "reference": "`expect(resources['Notify[local pid]']['events'][0]['desired_value']).to match(/(\\d+)/)` seems clearer." }, { "prediction": "I don't think we need to pass config here.", "reference": "Removed now-unneeded param." }, { "prediction": "I don't think we need this anymore.", "reference": "(NON-blocking, this can be tracked in follow up issue) @anorth @mishmosh is the toplevel getting too crowded? Should we have a `network` grandparent command, or maybe a `stats` command?" }, { "prediction": "I don't think we should change the name of the service.", "reference": "The `_x` function needs to be imported at the top of the file (in addition to `__`)" }, { "prediction": "I'm not sure if this is the right place for this test.", "reference": "This is functionally equivalent to the code it replaces." }, { "prediction": "I don't think this is the correct value for ENIType.", "reference": "can you change the field name here to \"InterfaceAssociationProtocol\"? same for the Config struct in agent/ecscni/types.go. i think it's better to keep the field name consistent between agent and acs payload" }, { "prediction": "I'm not sure if this is the right place for this file.", "reference": "See above, same for the other cases." }, { "prediction": "I don't think we need this annotation anymore.", "reference": "Shouldn't line 313 be public \\ SettableGauge\\ **settable**Gauge(String name) {? It would also be good to call it a few times and with differnet types (Long, Integer, String) in the test as well." }, { "prediction": "I'm not sure about this, but I think it's better to remove the `# pylint: disable=inconsistent-return-statements` line.", "reference": "I would prefer to just fix the occurences of this new check rather than disable them" }, { "prediction": "I don't think we need to change this.", "reference": "The tests should be fixed in #4841, so this is no longer needed" }, { "prediction": "I don't think this is needed.", "reference": "I think it should been in `SharedKernel` module." }, { "prediction": "I think we should add description here.", "reference": "Can we add some description for this field?" }, { "prediction": "I think this should be `Duration` instead of `Duration`.", "reference": "Should its name be Time or Duration? I can see them both." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "Is this used anywhere?" }, { "prediction": "I'm not sure if this is the right test.", "reference": "I believe that you can use `assert` instead of `require` here and in the following lines" }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "In `storagemarket.go` you used `nil` for an unwanted out parameter. Do something consistent (nil seems fine if supported)." }, { "prediction": "I'm not sure if this is the right place to put this variable.", "reference": "is this a new pattern we use in bee? interesting" }, { "prediction": "I'm not sure if this is the correct behavior. I'm not sure if this is the correct behavior. I'm not sure if this is the correct behavior.", "reference": "If you think this PR works, i'll clean this up before resubmitting." }, { "prediction": "I think this should be `io.servicecomb` or `io.servicecomb`", "reference": "are you sure you can read version by this artifactid?" }, { "prediction": "I don't think this is needed anymore.", "reference": "We can get rid of this import then." }, { "prediction": "I don't think we need this switch.", "reference": "Should we do our own vtable?" }, { "prediction": "I don't think we need this anymore.", "reference": "This is the actual fix." }, { "prediction": "I think this should be 60 * time.Second, not 60 * time.Second.", "reference": "If sync has really a negative impact, this is just moving the issue from 10sec to 60sec. Wonder if you should not expose the (auto)sync params so users can decide." }, { "prediction": "I don't think this is the right thing to do here. It should be called when MapLen returns true or decoding a struct. It should be called when MapLen returns true or decoding a struct. If the callback returns false, DecodeMap should return immediately. It should be called when MapLen returns true or decoding a struct. If the callback returns false, DecodeMap should return immediately. It should be called when MapLen returns true or decoding a struct. If the callback returns false, DecodeMap should return immediately. If the callback returns false, DecodeMap should return immediately.", "reference": "should be called => will be called" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "not sure whether we should do this. It may cause problem that delegates upgrade their nodes at different time, that they will have different \"last block time\", some use \"commit time\", some use \"block time\". Potential solution: Only use block time after berling, and then delete it in the next version after berling. Open to discussion." }, { "prediction": "I don't think we need to unwrap the exception.", "reference": "So one question I have is why is the error coming back from `buildReplicaPositions` not an `Assign.AssignmentException`? Is it because it is wrapped in a `SolrException` from the remote node?" }, { "prediction": "I don't think we need to change this test.", "reference": "`dt` won't work for some reason?" }, { "prediction": "I don't think this is needed.", "reference": "Is this because \"KOALAS_USAGE_LOGGER\" can be `None`??" }, { "prediction": "I don't think this is needed.", "reference": "I like it but maybe the better name will be EthGasPriceConstants or EthGasPriceEstimatorConstants? but Constants not Config" }, { "prediction": "I'm not sure if this is the right place for this test.", "reference": "I would inline the constructor as well" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "I'm not confident about this..." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "There is also `v1alpha1.CertificateRequestKind` I think?" }, { "prediction": "I'm not sure if this is a good idea. I think it's a good idea to have a `sender_gcpbroker` job that returns a `sender_gcpbroker` job. I'm not sure if it's a good idea to have a `sender_gcpbroker` job that returns a `sender_gcpbroker` job, but if it's a good idea to have a `sender_gcpbroker` job that returns a `sender_gcpbroker` job that returns a `sender_gcpbroker` job that returns a `sender_gcpbroker` job that returns a `sender_gcpbroker` job that returns a `sender_gcpbroker` job that returns a `sender_gcpbroker` job that returns a `sender_gcpbroker` job that returns a `sender_gcpbroker` job that returns a `sender_gcpbroker` job that returns a `sender_gcpbroker` job that returns a `sender_gcpbroker` job that returns a `sender_gcpbroker` job that returns a `sender_gcpbroker` job that returns a `sender_gcp` job that returns a `sender", "reference": "Can we rename it to make it less confusing? Instead of \"sender-gcpbroker\", maybe name it to \"retryable-sender\"" }, { "prediction": "I'm not sure if this is the correct error message, but I'm not sure if it's the right error message. I'm not sure if it's the right error message or if it's the right one.", "reference": "So looking at the definition of the `literal()` function in this class, it seems it's possible for it to return null. I guess it's not a concern as we would get NPE on the above call at line 136 when trying to call `.to` if `literal()` returned `null` before even getting to this part that calls `literal().value()`, but something I thought I'd bring up. Perhaps something we might follow up on in another issue or possibly I just missed the workflow that makes `literal()`'s result non-null by the time this `bindLiteralOperration` is called." }, { "prediction": "I think this test should be `assertTrue(abs(nrmse.getMetric()[\"value\"]-target)< OPFMetricsTest.DELTA)`. I think this test should be `assertTrue(abs(nrmse.getMetric()[\"value\"]-target)< OPFMetricsTest.DELTA)`.", "reference": "Why did you break the line? It looks like it is under 80 characters without the break and it is inside parens so no need for backslash anyway" }, { "prediction": "I don't think this is needed.", "reference": "@guolinke Don't you mind to rename this variable to `DATATABLE_INSTALLED`, for the consistency with other variables (for example, there are `PANDAS_INSTALLED` but not `PD_INSTALLED`). Also, `DT` is a little bit confusing: sometimes `dt` is used for `datetime`." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "We're fine with double quotes here. Just for future reference." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "can we keep this around? We should make sure we can distinguish between properly wrapped errors and \"unwrapped\" errors" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "`RecordPipelineShaderStage()` might change `topology_at_rasterizer `, according to shader code, so we should check `pInputAssemblyState `first." }, { "prediction": "I don't think this is needed.", "reference": "Should we just inline the assets here? I can't think of an advantage to having them in a separate file." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "detectStaleEndpoints to be more specific?" }, { "prediction": "I think this test should be in `SpatialPoolerCompatabilityTest`", "reference": "Please create a new issue for addressing this (if there isn't one already), so it doesn't get lost." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to make a `chan interface{}` or if it's a good idea to make a `chan interface{}`", "reference": "Nothing was ever coming out of this channel because its already being consumed. Create a new channel here and feed it in HandleNewHead method." }, { "prediction": "I don't think we need to change this file.", "reference": "AWS Identity and Access Management (IAM)" }, { "prediction": "I don't think this is the right place for this test.", "reference": "This is deliberately at this level." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "payload entered on command line is in hex-encoded format should use same processing as in ioctl/cmd/action/actiontransfer.go" }, { "prediction": "I think this should be `$alreadyCreatedDemoPricingGroupsByDomain = $this->pricingGroupFacade->getByDomainId($domainId);`", "reference": "should this be kept in the `else` branch?" }, { "prediction": "I'm not sure if this is a good idea. I think it's a good idea to move this to a separate PR.", "reference": "Why not put this below \"strings\"?" }, { "prediction": "I don't think this is needed.", "reference": "Make it `internal` if it's just for testing." }, { "prediction": "I'm not sure if this is a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug.", "reference": "What is triggering this message in this file?" }, { "prediction": "I don't think we need to close the pool.", "reference": "Are you sure this should be removed?" }, { "prediction": "I don't think this is needed.", "reference": "What's that good for? The field is initialized in the constructor." }, { "prediction": "I'm not sure if this is the right place to close the file.", "reference": "This shouldn't be necessary (same below). Do you have a traceback for me?" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "No newline needed here." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "Why a separate block?" }, { "prediction": "I don't think this is needed.", "reference": "Probably better to ask @AssadHashmi or another AArch64 expert for a review rather than me -- @AssadHashmi if you could confirm that these status registers are 64-bit despite having only a few fields?" }, { "prediction": "I don't think this is needed.", "reference": "`purpose` and `coin_type` and `account` would mimic the BIP-0044 wording, but it's up to you." }, { "prediction": "I don't think this is needed.", "reference": "Is this the critical change? It does seem wrong to use Select() instead of Checked = true. Not sure why that would pass sometimes and not others, though." }, { "prediction": "I don't think this is needed.", "reference": "Seems a little low, but is this an installer default?" }, { "prediction": "I don't think this is needed.", "reference": "Maybe we could provide our own `configure` function that includes `logger._logger = None` because I don't see a use case in kinto for using `reset_logger` besides configuring the logger." }, { "prediction": "I don't think we need this.", "reference": "This will cause the same breakage that was caused when we added Proof to Block. Be sure to let people (infra?) know ahead of time" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Fixed the test; @strib want to validate that this is okay? Seems to be consistent new GC behavior." }, { "prediction": "I'm not sure if we should change this to `subdoom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom` or `subdom`", "reference": "Afaict, nothing cares" }, { "prediction": "I don't think we need to do this in minimal mode, since there's no node cache.", "reference": "I must be missing something, but why does not having a node cache imply not neededing to re-embed the block changes, in particular? Isn't it just the fact that we don't do any writes?" }, { "prediction": "I don't think we need to make this readonly.", "reference": "Are these changes from `class` to `struct` breaking if called from an older version of `Datadog.Trace.ClrProfiler.Managed`?" }, { "prediction": "I don't think this is needed anymore.", "reference": "These are just aliases now" }, { "prediction": "I'm not sure if this is the best way to do this, but I think it's better to use `.html_safe` instead of `.html_safe`", "reference": "Does this mean we can remove `raw` from `_head_contents` partial?" }, { "prediction": "I'm not sure if this is the right place to close the splash window, but I think it's better to use `this.splashWindow.close()` instead of `this.splashWindow.close()`", "reference": "`isDestroyed` is a function, not a property. This condition will always return false." }, { "prediction": "I don't think we need this.", "reference": "Why are we adding these versions?" }, { "prediction": "I don't think this is the right thing to do. I think it would be better to use `current_app.logger.info('imported %d listens for %s' % (len(listens), str(user)))` instead of `current_app.logger.info('imported %d listens for %s' % (len(listens), str(user)))`", "reference": "fyi, you can do this by doing `.info(\"string %s %s\", formatparam, formatparam2)` instead of doing a string format with `\"str\" % (params)` the idea is that it'll only do the string interpolation if logging is enabled for this level, which theoretically is an optimisation, but in this case probably isn't important" }, { "prediction": "I don't think this is needed.", "reference": "Would this work, as a one liner? `setTimeout(window.location.reload, 5000);`" }, { "prediction": "I'm not sure if this is a breaking change or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, I'm not sure if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, I'm not sure.", "reference": "Can you move `crypto/tls` into the block at the top with all the other stdlib imports?" }, { "prediction": "I don't think we need to change this.", "reference": "What is the motivation for this change?" }, { "prediction": "I don't think we need to do this. I'm not sure if we need to do this.", "reference": "OK, so the concrete implementation will loop? But then it's important that this method waits for a while before it returns no messages. To be specific, a GCP implementation that set `ReturnImmediately` to true or false would both satisfy this requirement, but the first would cause busy-waiting." }, { "prediction": "I think this should be `NG_RETURN_IF_ERROR(validatePath(matchClause->path(), *matchClauseCtx));`", "reference": "The data structure of `MatchClauseContext` may need to be redesigned." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "You say on the issue that something has to be receiving while the messages are being published. But here it's possible that the publish goroutine starts, and maybe even completes, before Receive is ever called." }, { "prediction": "Line is too long. [89/80]", "reference": "how do we know that the step in question is an approval type step?" }, { "prediction": "I don't think this is needed anymore.", "reference": "JMX offers normal APIs for this. I don't think you want the glassfish one." }, { "prediction": "I'm not sure if this is needed, but I think it's a good idea to move this module to the top of the file.", "reference": "Is this still Java 8 compatible? @danieldietrich do we need a separate, modularized Java 9 release also?" }, { "prediction": "I don't think we need to do this. I don't think we need to do this in hip_ext_sampler_descriptor.hip_ext_sampler_descriptor.hip_ext_sampler_descriptor.hip_ext_sampler_descriptor.hip_ext_sampler_descriptor.hip_ext_sampler_descriptor.hip_ext_sampler_descriptor.hip_ext_sampler_descriptor.hip_ext_sampler_descriptor.hip_ext_sampler_descriptor.hip_ext_sampler_descriptor.hip_ext_sampler_descriptor.hip_ext_sampler_descriptor.hip_ext_sampler_descriptor.hip_ext_sampler_descriptor.hip_ext_sampler_descriptor.hip_ext_sampler_descriptor.hip_ext_sampler_descriptor.hip_ext_sampler_descriptor.hip_ext_sampler_descriptor.address_mode = HSA_EXT_EXT_SAMPLER_ADDRESSING_MODE_CLAMP_TO_EDGE;", "reference": "Should update the user input address and filter modes and pass those in fillSamplerDescriptor?" }, { "prediction": "I don't think we need this, but I think we should be able to use `fetch('show.adult_musical')` instead of `fetch('show.kids_musical')`", "reference": "This object should be in `lib/music/show.rb` and you should also wrap this object in the `Faker::Music::Show`." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I think logic will have to move to bolt since the vague discussions around bolt run plan --noop is that it would just skip any tasks that don't support_noop rather than error. This is fine until we actually elaborate that though." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "File is not `goimports`-ed" }, { "prediction": "I think this test should be `test_unknown_bucket_raises_404`", "reference": "why should unknown raise a 403?" }, { "prediction": "I'm not sure this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "The true clause of your condition, can't this just be c._nextState since `assign({}, c._nextState)` is equal to returning c._nextState, or am I misunderstanding something here?" }, { "prediction": "I don't think it'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''", "reference": "nit: align the leftmost quotes" }, { "prediction": "I don't think we need this?", "reference": "Probably \"server port\" -> \"TCP port\"" }, { "prediction": "I don't think this is needed.", "reference": "can you use FilterCodec instead?" }, { "prediction": "I don't think this is needed.", "reference": "I know there's only two values but I find it a bit confusing that it's true/false. Could you change it to a string enum with values \"portrait\" and \"landscape\"? Then when calling printToPdf you can just do `landscape: Setting.value('export.pdfPageOrientation') === 'landscape'`" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I think this migration should fail for MDBX if it uses old table names" }, { "prediction": "I'm not sure if this is the right way to do this. I'm not sure if this is the right way to do it.", "reference": "Should this be negated? `!@options[:hosts_file].nil?` Otherwise it'll enter the `if` statement and `nil` will be passed to `HostsFileParser.parse_hosts_file`, which I'm assuming is bad." }, { "prediction": "I don't think this is needed.", "reference": "I'm doubting if adding a bool here is a good idea. Maybe it should be an option object? Otherwise it's hard to extend. But an option object is a bit strange in a fluent API? What do you think @snakefoot?" }, { "prediction": "I don't think we need to change this class.", "reference": "This is used in o.a.l.sandbox.search.PhraseWildcardQuery." }, { "prediction": "I think this should be `protocol.Dock`", "reference": "view should be loaded on start for both statedb and factory" }, { "prediction": "I don't think this is needed anymore.", "reference": "Why rename? Just curious..." }, { "prediction": "I think this should be `setVisibility(View.GONE)`", "reference": "Is this needed? I think it calls the super function that already does that." }, { "prediction": "I don't think this is necessary.", "reference": "This might slow down the inference time, are we sure we need to do that?" }, { "prediction": "I'm not sure if this is the right place for this PR, but I'm not sure if it's worth it.", "reference": "This would read better if you add \"Skip code/lines\" or (exclude/hide code if you follow my earlier suggestion\")" }, { "prediction": "I don't think this is needed.", "reference": "Looks like glassfish went a bit nuts doing a refactor" }, { "prediction": "I think this should be `Task.WhenAll(tasks)`.", "reference": "nit: allocate the list using the number of processors." }, { "prediction": "I don't think we need this change.", "reference": "Was this change triggered by baseline?" }, { "prediction": "Line is too long. [89/80]", "reference": "This code was doing nothing as far as I can tell and was making the SQL find nothing with the new version of Rails. Remove it unless someone can explain why it is there." }, { "prediction": "I don't think this is needed.", "reference": "Setting browser based login as the default for `RestAPIExplorer`." }, { "prediction": "I don't think this is needed.", "reference": "maybe we can do this in Init function?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "How about if request ID not set, service should generate a random uuid?" }, { "prediction": "I'm not sure why this test is failing. I'm not sure if it's necessary.", "reference": "minor: this is an opportunity for you to split these long lines into multiple lines :)" }, { "prediction": "I don't think this is the right thing to do here. I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do here.", "reference": "It would be nice to have exception dumped somewhere (debug logs, info logs)." }, { "prediction": "I don't think we need to expose providers to expose provider-specific types. I'm not sure if we need to expose providers to expose provider-specific types.", "reference": "So I don't think this is right, as discussed on #657." }, { "prediction": "I think this should be `group_id, member_role, member_type, member_id, member_email, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, member_status, group_id, group_id, group_email, group_email, group_status, group_status, group_status, group_status, group_status, group_status, group_status, group_status, group_status, group_status, group_status, group_status, group_status, group_status, group_status, group_status, group", "reference": "should the group_id = \"{0}\" be group_id = %s You'd still keep the {} for the group_members_{} for the tablename but make the filter clause parameterized." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Path can contain variable pattern in the middle. Also, `$` is not enough to tell if this is JMeter variable. We have correct variable detecting somewhere in our code." }, { "prediction": "I don't think this is needed.", "reference": "@bennothommo can you revert this section? It shouldn't be required." }, { "prediction": "Line is too long. [89/80]", "reference": "Minor: maybe move the above to a `#fiscal_year` method?" }, { "prediction": "I'm not sure if this is the right place to test this, but I'm not sure if this is the right place to test this.", "reference": "You should use the current directory instead - it's a temporary directory that will get removed when the test is done." }, { "prediction": "I think this test should be `thread.join()`", "reference": "I think we don't need synchronization here." }, { "prediction": "I'm not sure if this is the right thing to do, but I think it's better to use `String.format(String.join(serverHttpSecurity.anonymous(), \"\\\")` instead of `String.join(serverHttpSecurity.anonymous(), \"\\\")`", "reference": "I don't think this should be changed since on the reactive side we don't support anonymous users." }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it.", "reference": "Maybe this `if` should be on line 118?" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to change this to `int64` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32` or `int32`", "reference": "Cool. (I thought I had fixed this already in #812.)" }, { "prediction": "I'm not sure if this is the right place to move this to the transport itself. I'm not sure if this is the right place to move it to the transport itself.", "reference": "I intend to do this as soon as I have tests passing." }, { "prediction": "I'm not sure if this is the right place to use `sys.stdin.read()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()` or `sys.stdin.write()`", "reference": "Please remove the `test_*` from the filename - otherwise pytest will try to collect tests from it." }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "Did you file a bug to follow up on this?" }, { "prediction": "I don't think we need to do this in the `read.parquet.vectorization.enabled` method. I don't think we need to do this in the `read.parquet.vectorization.enabled` method. I think we need to do this in the `read.parquet.vectorization.enabled` method.", "reference": "Looks like these 4 lines didn't actually change. Can you revert the whitespace changes here?" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if it's the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "This can't be merged with any usage of `require 'pathname'` in lib, it's not always available and we don't want false positives for people (where they don't realise they needed to requite it). Its also unnecessary, no other formatter uses it to look up failure locations. See the exception presenter etc for how we format lines." }, { "prediction": "I think this should be `assertThat().statusCode(OK.getStatusCode());`.", "reference": "It would be nice to fix the indentation above." }, { "prediction": "I don't think this is needed anymore.", "reference": "`short_names` is still optional, so `=` that indicates it has to stay there." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this.", "reference": "missing calling of this method" }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "We could get rid of this dependency being forced on clients by changing the `StackConfiguration` interface abstraction to deal with strings instead of `cloudformation.Parameters` and `cloudformation.Tags`, and internally to the `cloudformation` package translate the input strings into the `service/cloudformation` package specific values hiding that from consumers. I don't think that should be taken on as part of this PR, but I think we should consider doing it at some point." }, { "prediction": "I'm not sure if this should be `root=true` or `root=false` or `root=true` or `root=false`", "reference": "`StressChaos` does not contains a field.spec.action" }, { "prediction": "Why not use `string` instead of `string`?", "reference": "Non-int literal strings are no longer coercible to int, I think this is an improvement. Without this change it now reports `InvalidArgument`." }, { "prediction": "I think this should be `sizeof(a) / sizeof(a[0]))`", "reference": "I this used anyplace?" }, { "prediction": "I think this should be `.maxWorkerThreads(8)`", "reference": "Why was this change required?" }, { "prediction": "I'm not sure if this should be `false` or `true` or `false` or `true` or `false` or `true` or `false` or `false` or `true` or `false` or `true` or `false` or `true` or `false` or `false` or `true` or `false` or `false` or `true` or `false` or `true` or `false` or `false` or `true` or `false` or `false` or `false`", "reference": "I like that we have this attribute here. However, I think the way we use it right now might be confusing in the future. For example, when only camunda admin is checked, this exception will be instantiated with a message and `missingAdminRole` is `false`. I think that is counter-intuitive. I would expect this exception to have `missingAdminRole` set to `true`. With this explicit information, the exception message could now be generated inside this exception class with the text block that is currently used in the authorization manager. We could maybe generally reuse that text block then also for the case where a user is no admin and also has none of the required permissions. I haven't tried it myself but I think it would be great if we could streamline those things a bit more if we're working on it now. Let me know what you think." }, { "prediction": "I don't think this method is used anymore.", "reference": "Not sure why we're creating a new `ByteBuffer` here, ideally this refers to the existing one?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Same here re: `STORE_NAME` to `MODULES_SEARCH_CONSOLE`." }, { "prediction": "I don't think we need to change this. I'm not sure if we need to change this.", "reference": "I could've sworn I got a `403` myself when I got that response locally. Is `200` what the API would send back for a `permission: false` tag?" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to rename the `IdentityManager` struct to `KeystoreManager` or `KeystoreManager`.", "reference": "This attribute was intentionally private. - lets force usage of factory `NewIdentityManager()` - lets ramake to `NewIdentityManager(keydir string)` -> `NewIdentityManager(keystore keystoreManager)`" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Is this too frequent?" }, { "prediction": "I'm not sure if this is a good idea, but it's a good idea to add a `zip` extension to the `UploadModel` class.", "reference": "will this not make it possible to use a zip file, e.g. on other importers who do not have to support it?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Needs to be mentioned in `__all__` below." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "What if the app's signal handler, executed at pre-syscall for epoll_pwait, executes its own epoll_pwait? For that matter: what happens natively if that happens? I would not expect the kernel to keep a stack -- does that clobber the kernel's stored pre-syscall mask?" }, { "prediction": "It is important that the returned list is sorted in ascending order.It is important that the returned list is sorted in ascending order.It is important that the returned list is sorted in ascending order.", "reference": "Nit: missing a space. I think we should phrase the new content a little differently. \"It is important\" isn't very clear. I think it should be \"offsets will be returned in sorted order.\"" }, { "prediction": "I don't think this is needed anymore.", "reference": "Can you remove this blank line and put the added import in sorted order (likely your editor will do this)" }, { "prediction": "I'm not sure if this is the correct behavior.", "reference": "Even if `pthread_create()` for `ocsp_updater_thread()` fails, `h2o` can continue to serve. But I'm a little worried whether `h2o` should continue to serve in this case. How about you?" }, { "prediction": "I'm not sure if this is the right place to put it.", "reference": "I like introduction of these constants for account/container creation, but the `ACCOUNT_CHOOSE` one isn't needed I think. This should instead be an \"empty\" value (either `''` or `0`), to indicate more clearly that this field is not filled. It should be the same for choosing a container." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I noticed that passing in `[]` for the locales argument instead of 'undefined' seems to have the same effect. I think that's preferred over passing in `undefined` as a value, and unfortunately passing in `null` seems to throw an error." }, { "prediction": "I think this should be `!strings.HasSuffix(DbCfg.Host, \"]\")`", "reference": "1. `0` is redundant. 2. We should save result of `strings.LastIndex(DbCfg.Host, \":\")` to a variable and reuse." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `HeaderSupport` flag. I'm not sure if it's a good idea to have a `HeaderSupport` flag, but if it's a good idea to have a `HeaderSupport` flag, I'm not sure if it's a good idea to have a `HeaderSupport` flag, and if it's a good idea to have a `HeaderSupport` flag, I'm not sure if it's a good idea to have a `HeaderSupport` flag, and if it's a good idea to have a `HeaderSupport` flag, I'm not sure if it's a good idea to have a `HeaderSupport` flag, and if it's a good idea to have a `HeaderSupport` flag, I'm not sure if it's a good idea to have a `HeaderSupport` flag, and if it's a good idea to have a `HeaderSupport` flag, I'm not sure if it's a good idea to have a `HeaderSupport` flag, and if it's a good idea to have a", "reference": "Do you envision \"new\" servers not supporting header, or is it more a way to test mix of old and new? If so, we could make it a \"private\" (non exported) option." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "For future reference. Try not to do refactoring in the same PR which solves some bug or implements some feature. Not to clutter reading. Do it in separate PR." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to change this flag.", "reference": "I'm not sure about changing the flag name. unit is more accurate, but for I think for most people asset is also a fine name to use." }, { "prediction": "I don't think this is needed.", "reference": "Which windows gets activated? A random other window?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do this, I'm not sure if it's the right place to do this.", "reference": "Just to make sure, this is totally lossless? If I put a v2 there, then it gets upgraded to v3, but my function expects v2, then this is fine and nothing is lost?" }, { "prediction": "I think this should be a constant.", "reference": "In the past, we have 3 Flink streaming jobs (1 for each AWS region) writing to the same table. We need to write to 3 different watermark table properties (1 for each region). Watermark consumer then use the min value to determine the overall table watermark. A provider pattern similar to `WRITE_LOCATION_PROVIDER_IMPL` can work. A default impl could be a single property name. not sure if there is a simpler way to achieve this." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Can you change this to `ResolvedUsersMap` and build a new map with both readers/writers? That way, we get the nice side effect of not exposing the internal map of the handle, and simplifying the callers a bit." }, { "prediction": "I don't think this is needed.", "reference": "I typically try to avoid nested ternary expressions. Can we rewrite this as if statements? Worst case, can we break it out into its own function?" }, { "prediction": "I don't think this is needed.", "reference": "Do we still support handshakes without SNI present?" }, { "prediction": "I'm not sure if this is the right place to put this message in.", "reference": "Maybe it's because I work too much on a centralized logging system but it could be great to add a \"category\" like \"attribute\", \"substitution\", \"include directive\", \"macro\", \"extension\"..." }, { "prediction": "I'm not sure this is the right thing to do here.", "reference": "it have no sense in python -> it makes no sense in python" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "maybe just do a separate implementation of the pool for openvpn case? It's a bit confusing having two methods here." }, { "prediction": "I'm not sure if we need to close the topology if it's already closed.", "reference": "how is it possible to have a `topology` that is falsey when we had to call `topology.connect` in order to get here?" }, { "prediction": "I don't think we need to stub `current_churn: 10` here.", "reference": "Do we need this expectation? If we don't call this method on `PlanFinder` there's no way for the `10` to be returned. Seems somewhat redundant. What do you think?" }, { "prediction": "I'm not sure why this is removed.", "reference": "We need to do the same for edgecore" }, { "prediction": "I don't think this is needed.", "reference": "This fix has nothing to do with the product change. Just a fix I am making for the test issue." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "Don't know what should be the default. Lets keep BatchingProcessor for now. And revisit the area after beta." }, { "prediction": "I'm not sure if this is the right place to use `rspec/support/reentrant_mutex` or `rspec/support/reentrant_mutex`", "reference": "Ah that's how it's happening, it's probably using the `require_relative` in the optimised one and that counts as a different require to the bare one." }, { "prediction": "I don't think we need to register NibForCellReuse here.", "reference": "What happens if there is no NIB/XIB with that name?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "this is not necessary?" }, { "prediction": "I don't think this is needed.", "reference": "typo: `asmsecrets \"github...`" }, { "prediction": "I'm not sure if this is the right place to use `wp_json_encode()` or `wp_json_decode()` or `wp_json_encode()`", "reference": "I think that the JSON encoding should be handled by the control itself, not the sanitization function. This should only confirm that the input is correct, not reformat it" }, { "prediction": "I don't think this is needed.", "reference": "Should we put a TODO here to route the http.Transport through here?" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it.", "reference": "Sorry, could you explain more about the issue? Doesn't ComputerName already default to local computer? > -ComputerName Specifies one or more Hyper-V hosts on which the virtual switch is to be configured. NetBIOS names, IP addresses, and fully qualified domain names are allowable. The default is the local computer. Use localhost or a dot (.) to specify the local computer explicitly." }, { "prediction": "I'm not sure if this is a good idea. I think it's a good idea to add a `allowError` parameter to the `runCliTool` function.", "reference": "`allowError` is a big vague. Does this mean the test case is asserting that an error should occur? If it means \"maybe an error can occur, and that's okay\" -- what's an example of this?" }, { "prediction": "I'm not sure if this is the right thing to do here, but I think it's better to use `alias.IOAddress(xrc20ContractAddress)` instead of `alias.IOAddress(xrc20ContractAddress)`", "reference": "return statements should not be cuddled if block has more than two lines (from `wsl`)" }, { "prediction": "I don't think we need this class anymore.", "reference": "Why does VirtualMachineMetrics have to implement Metric?" }, { "prediction": "I'm not sure why this was removed.", "reference": "line is 121 characters" }, { "prediction": "I don't think we need to change this.", "reference": "How's that linked esbench looking with slice?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "The split and join was probably done to ensure that this still works on Windows because os.path.dirname works differently depending on the os you're running under :(. It would probably be a little better to do `dirname, _, fn = path.rpartition('/')` if you want something cleaner than the split/join." }, { "prediction": "I'm not sure this is the right place for this method, but I think it's better to move this method to SessionMap.", "reference": "This is not the right approach. The `Distributor` maintains a model of the current state of the Grid. That model already contains the information about every active session. We don't need to modify `SessionMap` to expose it further." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Can you make this a member var as all the other deadlines? Then you can drop the param to resetTimer() and simplify some of the code below iiuc." }, { "prediction": "I'm not sure why this change is necessary.", "reference": "I don't understand the reason for the changes from unique_ptr to ROMOL_SPTR that you made in this file. The pointers aren't being shared or used elsewhere so I don't think there's any reason to make them shared. Did I miss something?" }, { "prediction": "I think we should rename this to `PLUGINS` since it's not used anywhere else.", "reference": "why change the variable name at all?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but I'm not sure if it's the right place to do it.", "reference": "Since I'm still trying to keep these straight in my head, can you elaborate on what problem this solves?" }, { "prediction": "I don't think we need to check for null here.", "reference": "Prefer TextUtils.isEmpty() which handles getReportSpamRecipient() being null" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else." }, { "prediction": "I don't think this is needed.", "reference": "Do we actually use Include anywhere yet or is this just for completion?" }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do.", "reference": "It still bugs me this was misspelled in the standard and now the wrong spelling is the commonly used one :wink:" }, { "prediction": "I don't think this is needed.", "reference": "seems we missed de-uglifying this one" }, { "prediction": "I think this should be `NewWorkflowUnspecified`", "reference": "i guess these types & cron / retry specific belong to a dedicated util / struct" }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it.", "reference": "Also update line 2205 below" }, { "prediction": "I don't think this is needed.", "reference": "`direction` is referenced nowhere. Do I miss something?" }, { "prediction": "I don't think this is needed anymore.", "reference": "The two places this was used have been removed so we can fully remove this dependency." }, { "prediction": "I'm not sure if this is the right place to delete the agreement.sql file.", "reference": "This is a duplicate generation of the same file as below." }, { "prediction": "I don't think we need to check if `cfg.gpus` is None.", "reference": "We may deprecate `gpus` if `gpu_ids` is specified." }, { "prediction": "I don't think we need finest here.", "reference": "Right now this is experimental and deeply flaky. We left this at `info` to make debugging user reports a lot easier." }, { "prediction": "I don't think this is needed.", "reference": "unnecessary spaces here are doubling the size of this otherwise extremely useful addition" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I think we should use `FileExistsPolicy.Overwrite` instead. Files _should_ always be newer, but in the unlikely case they wouldn't be, I'm afraid some files would be overwritten and other not, leading to inconsistencies that will be hard to figure out." }, { "prediction": "I think this should be `std::cout << \"test3_5\" << std::endl;`", "reference": "this should probably be removed" }, { "prediction": "I'm not sure if this is the right place for this test. I'm not sure if it's the right place for this test.", "reference": "Nit: I would actually prefer that pretty JSON is the default, with a flag for compressed JSON. Can we acheive that easily?" }, { "prediction": "I think this should be `OptionalIngressRules` and `OptionalIngressRules`", "reference": "Will need to think about this one. `additionalIngressRules` feels a bit opaque in terms of eventual outcome." }, { "prediction": "I don't think this is needed anymore.", "reference": "Can we avoid making this public with the other updates?" }, { "prediction": "The size of datum_vector must be equals to transformed_blob->num()", "reference": "Why did you change this equal instead of less or equal?" }, { "prediction": "I don't think we need to change this interface. I don't think we need to change this interface.", "reference": "missing final for the blockHash field" }, { "prediction": "I'm not sure if this is the right place to put this file. I'm not sure if it's the right place to put this file.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I don't think we need to convert FP32 to FP64 here. I don't think we need to convert FP32 to FP64 here.", "reference": "`x_float` instead of `float_x`." }, { "prediction": "I don't think this is needed.", "reference": "Is this for `No Babel config...` from ESLint? If so, it will be fixed in my ES6 PR." }, { "prediction": "I think this should be `t.Fatalf(\"expected state %+v to equal %+v\", state, s)`", "reference": "Not important, but the code used to keep checking other cases even after one of them failed, and now it's not. Fine either way for me, just noticing." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "I think I saw this line in last PR, you can update your base branch and rebase to avoid this. And it would be awesome if you can rebase instead of merge each time you push PR to the `moby` branch, that will make the commits history clearer." }, { "prediction": "I think this should be `if (get_thread_id() == tid)`", "reference": "If this can change the PC of this thread, it requires handling: we can't blindly execute the syscall and lose control of the thread when the flags include CONTEXT_CONTROL. (Note that most docs imply that setting your own context this way is not supported or has undefined or unpredictable results: any idea how often that's the case, or does it generally work?) We need to handle in a similar fashion to NtContinue or setting another thread's context to ensure we retain control." }, { "prediction": "I don't think we need this method anymore.", "reference": "@huzaifaiftikhar Changed the endpoint as suggested by Stephane in the latest commit." }, { "prediction": "I don't think this is needed.", "reference": "There's no core.Number yet. ;)" }, { "prediction": "I'm not sure if this command should be used cautiously and only when there is an issue with the current state of the data. I'm not sure if this command should be used cautiously and only when there is an issue with the current state of the data.", "reference": "...,...will be posted." }, { "prediction": "I don't think we need to change this.", "reference": "Can you update this function to be `ShowHeader`? There is only one use of it at the moment in `tools/fast/series/get_head_block_height.go`." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `QUILT_USE_TQDM` or `QUILT_USE_TQDM` in the future. I'm not sure if it's a good idea to use `QUILT_USE_TQDM` or `QUILT_USE_TQDM` in the future, but if it's a good idea to use `QUILT_USE_TQDM` or `QUILT_USE_TQDM` in the future, it's a good idea to use `QUILT_USE_TQDM` or `QUILT_USE_TQDM` in the future. If it's a good idea to use `QUILT_USE_TQDM` or `QUILT_USE_TQDM` in the future, I'm not sure if it's a good idea to use `QUILT_USE_TQDM` or `QUILT_USE_TQDM` in the future. If it's a good idea to use `QUILT_USE_TQDM` or `QUILT_", "reference": "@akarve, this disables `tqdm` by default, is it intended? Also name `QUILT_USE_TQDM` might be too specific, IMHO `QUILT_INTERACTIVE` or `QUILT_PROGRESS_BARS` or something might be better." }, { "prediction": "I think this test should be `assert.NoError(t, err)`", "reference": "unrelated but just changing for consistency with code below it" }, { "prediction": "I think this is a breaking change. I'm not sure if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change.", "reference": "This will call `componentWillUpdate()` for mounts because the else clause is removed. It should only be called for updates." }, { "prediction": "I don't think we need to add history here.", "reference": "We should add write inheritance too." }, { "prediction": "I think this should be `os.environ.get('JAVA_OPTS', '').strip() or 0.0`", "reference": "Please rename this to `LAMBDA_JAVA_OPTS`, and add a short description to the README." }, { "prediction": "I don't think this is needed.", "reference": "Should be in the same import group." }, { "prediction": "I don't think we need to check for `pkt.tls_session.tls_version > 0x0200` or `pkt.tls_session.tls_version > 0x0200`?", "reference": "Operator precedence is very confusing here. Care to add parentheses? ` ((version or 0x0303) >= 0x0200)` Same below." }, { "prediction": "I don't think this is needed anymore.", "reference": "javaparser-core has no dependencies and it should stay that way. So no log4j. And even then there would have been a preference for slf4j." }, { "prediction": "I don't think we need to re-identify the specific DTA flavor. I think we need to re-identify the specific DTA flavor. I don't think we need to re-identify the specific DTA flavor.", "reference": "Why not just retest all? it's not expensive (I think)." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "ecr and ecr0 aren't deterministically named here. This change will just cause confusion in the git history. Could you either: a) fix this and make it deterministic b) regenerate the mock until it doesn't flip definitions for ecr and ecr0" }, { "prediction": "I'm not sure if this is needed.", "reference": "This looks like bash... does this work in ruby? Or is the idea to inject the entire script into the subsequent commands?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "I don't understand why this change is in this PR?" }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "It's a little hard to tell from the diff, but as a result of this PR, the only non-deprecated helpers are: - `has_facet_values?` (probably not long for this world) - `render_facet_partials` (perhaps part of a future component) - `render_facet_limit` (possibly obsolete once components get traction) - `facet_field_in_params` (a little tricky to deprecate at the moment) - `facet_field_presenter`" }, { "prediction": "I don't think this is the right thing to do.", "reference": "The right-hand part shouldn't use `__proto__`. Should be just `PersonObject.__proto__ = Realm.Object`." }, { "prediction": "I'm not sure if this panic is the right place to panic. I'm not sure if this is the right place to panic or if it's the right place to panic or if it's the right place to panic.", "reference": "the == case might be legit, or not? If there is no task written since last read, but we trigger a new read, would the min == max? Or should the upper layer handle that case?" }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "Good catch! But is it guaranteed that `old_size < new_size` here? If not, wouldn't we want to take `min(old_size, new_size)` as the copy length?" }, { "prediction": "I don't think we need to disable once MemberHidesStaticFromOuterClass is called.", "reference": "This is the only one that worries me a bit. It would be good if Brendan signed off on it." }, { "prediction": "I think this should be `OptionalArrayMethodView.Builder()`.", "reference": "`LongRunningOperationDetailView` already has `isEmptyOperation`." }, { "prediction": "I don't think this is needed.", "reference": "This will always add the authorization header to the request object. Is this the right scope for these two lines? If username/password are not defined, it will encode 'Basic :'" }, { "prediction": "Line is too long. [89/80]", "reference": "Don't think a scope adds much value for us here. Also, for future reference, you don't need to use the `self.all` it is implied. Could just be: `scope :updated_at_desc, -> { order(updated_at: :desc) }` No need to change this one now though, it works." }, { "prediction": "I'm not sure this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I believe `Base.` is unnecessary in this case, as the class already extends `Base`." }, { "prediction": "I don't think we need to change this. I think we should change this to `width: size, fillWidth: size, fillHeight: size, type: 'Primary'`", "reference": "Couldn't this result in images being scaled too small when the width is less than the height assuming the width is still what is being passed here?" }, { "prediction": "I don't think this is needed.", "reference": "Here also, let's not cache value on top of file, but use `plugins.getConfig(\"api\").offline_mode` directly where it is needed" }, { "prediction": "I don't think we need to check if `$config->Catalog->shibboleth_library_cards` is null.", "reference": "You can combine the two checks into a single `!empty()` check." }, { "prediction": "I don't think this is the correct error message.", "reference": "Should we add a warning for anything over say 8M? Just suggesting that is not recommended?" }, { "prediction": "I'm not sure if this is the right place to do this, but I think it's better to move this function to the `go/client/go/client/go/client.go` file. I think it's better to move this function to the `go/client/go/client/go/client.go` file.", "reference": "Looks like there are no callers left of this function." }, { "prediction": "I'm not sure if this is the right place to call this function.", "reference": "Should there still be a ` bool` trailing `showOutput`?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Did we can change to v1" }, { "prediction": "I'm not sure if this is needed for catchErrorInComponent to properly traverse upwards through fragments. I'm not sure if this is needed for catchErrorInComponent.", "reference": "Can you please double check that this won't break anything?" }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if it's the right place to do this.", "reference": "optionals, shouldn't need to be stated explicitly" }, { "prediction": "I don't think this is needed.", "reference": "That seems quite low - why not just 0x5130ffff?" }, { "prediction": "I don't think this is needed.", "reference": "Why is this needed?" }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do this.", "reference": "`Bolt::Config.user_path` returns `nil` if there's no homedir, so this will still error in that case." }, { "prediction": "I don't think this is the right place to do this, but I think it's better to use `String()` instead of `String()`.", "reference": "nit: use %s for strings and %v for objects." }, { "prediction": "I don't think we need this anymore.", "reference": "Same as before, the properties already exists in parent" }, { "prediction": "I don't think we need to change this file.", "reference": "This fix is not quite correct. The `%s` should be replaced with `version` and the `%d` on line 39 should be replaced with `datetime.datetime.now().year`." }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it.", "reference": "Maybe we should only set active = false if `strcmp(type, \"pause\") == 0`?" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if it's the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "Same here. and all others." }, { "prediction": "I don't think this is needed.", "reference": "Intentionally committed? I'm not against it, we already have a way to get goroutines without killing the process: `/keybase/.kbfs_profiles/goroutine`." }, { "prediction": "I think this should be `guidP(PParam.prefix);`", "reference": "I think this blank line may be removed" }, { "prediction": "I think this should be `True if the bookmark was added, and False if it was removed.`", "reference": "I think this should be a keyword-only argument, i.e. do `def add(self, url, title, *, toggle=False):` and adjust the caller to do `toggle=toggle`." }, { "prediction": "I think this should be `UINT32 DevStatus`", "reference": "@aimanrosli23 Judging from the commit description, I do not know why this file got changed so much. Could you help to double confirm if you do not revert the changes brought by commits: SHA-1: 643623147a1feaddd734ddd84604e1d8e9dcebee * MdeModulePkg/SdMmcPciHcDxe: Send SEND_STATUS at lower frequency SHA-1: 49accdedf956f175041040e677163b7cbb746283 * MdeModulePkg/SdMmcPciHcDxe: Hook SwitchClockFreq after SD clock start" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "How about YAML.load_file()" }, { "prediction": "I think this should be `executionStopped` instead of `containerDispatchFail`.", "reference": "Maybe make this `volatile` or atomic as this can be set/read from different threads? Also, separately you may want to check if some of the methods here need to be `synchronized`." }, { "prediction": "Do we need to register this event in drwrap_exit?", "reference": "Check the return value of the drmgr ones." }, { "prediction": "I don't think this is needed.", "reference": "This should be `'cache'`" }, { "prediction": "I'm not sure if this is the right thing to do, but I think it's better to have a `GetOldRepoPath` method that returns the full path of the old repo, and then call `MakeNewRepo()` with the full path of the new repo.", "reference": "The name \"old\" might cause confusion here. After installation, the \"old\" repo is at an archived path, and the new migrated repo is at the old path. Maybe something like \"target\" or \"canonical\"?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I think this is somewhat definitive proof that this error exists in `core` rather than `native`. We are correctly resolving the `readPreference` in the previous line, but you are able to identify that eventually the command generated in `core` is not decorated with the passed `readPreference`. Did you try to solve this there already?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "During genesis sync it can unwind 5M blocks?" }, { "prediction": "I think this should be `Racy - times out ~50% of the time running locally with --race`.", "reference": "was it caused by the removal of removeTaskQueueManager() from this test?" }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Space inside } missing.", "reference": "Wouldn't it just be easier to force search_session to return `with_indifferent_access`? Since you've done the hard work already, I don't think there's a problem doing it this way, but.." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "So, such tasks that could possibly not meet the deadline will never have a chance to run? I think this is not nice behavior, especially for those projects who has sometimes some very small tasks after the big one." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it.", "reference": "You should add the check above this line instead. If string is empty, don't even call the function." }, { "prediction": "I don't think we need to do this. I think we should do this in a separate PR.", "reference": "If clientCert attribute doesn't exist for some reason I set it to false." }, { "prediction": "I don't think we need to do this. I'm not sure if we need to do this, but I'm not sure if it's worth it.", "reference": "Do we need `app_host_flags` variable? We can directly concat with `flags`. `sh.cmd curl_cmd(unless Travis::Build.config&.ssl&.verify? flags +'-k' : flags, location, static_file_location), cmd_opts` right?" }, { "prediction": "I'm not sure this is the right place to stop walking.", "reference": "Walk should actually be completed (`onWalkCompleted`) after the event is stopped. This also makes it possible for monster to walk by smaller paths." }, { "prediction": "I'm not sure if this is the right place to handle the root chunk. I'm not sure if this is the right place to handle the root chunk, but if it's the right place to handle the root chunk, I'm not sure if it's the right place to handle the root chunk.", "reference": "typo in `weather` (should be `whether`)" }, { "prediction": "I think this flag should be `true` or `false`", "reference": "Thoughts on having the URI as the param, instead of a boolean? The default value would be the normal prod image, and then your test would override with the staging image." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "I'm surprised this is needed, but we should probably assert num_scan == 1 at least, otherwise I expect the file is pretty broken." }, { "prediction": "I don't think this is needed.", "reference": "Could we set a default value for `partitions` and `{0, network::NetworkUtils::getAvailablePort()}`?" }, { "prediction": "I don't think this is needed.", "reference": "Needs xml docs. The API names alone don't provide enough explanation about what these mean and how to set them. Also, we should provide some validation of inputs, such as MaxTime must be > MinTime, MinimumRate must be >= 0, etc. Consider making the properties readonly and adding a constructor that does these validations." }, { "prediction": "I'm not sure if this is the right place to put this function.", "reference": "Would it make sense to create an empty file here, perhaps in a tmp dir, instead of checking empty files into Git?" }, { "prediction": "I don't think this is needed.", "reference": "This change is due to `clang_format` and is not related to this PR." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Why did you not add the signals to the call of block_all_signals_except() and instead baked them into the function? Ok, if you had a good reason for it, otherwise I would add it to the except list of the function call, since that's what it was meant for." }, { "prediction": "I think this interface should be `FeedFileDownloadStatusRequesterInterface`.", "reference": "Could this be done by mocking objects instead? I feel like this is changing too much of the actual logic just for the tests." }, { "prediction": "I think this should be `null`.", "reference": "why not just use `ManifestContent` instead of `Integer`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "can we do that in TxValidator?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to rename this to `ServiceName` or `ServiceType`.", "reference": "We definitely want some detailed and thoughtful docs being added to this type." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or not.", "reference": "We would like this code to run, even when `config.XDPEnabled` is false, so that Felix can clean up its own XDP state after a restart." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "If the status is `ERR_SPACE_NOT_FOUND` why return `SUCCEEDED`?" }, { "prediction": "I don't think we need to reverse the order of planes in layer sequence. I don't think we need to reverse the order of planes in layer sequence.", "reference": "It is is more appropriate to use `downsample_first`. If `downsample_first=True`, the downsample block is the first block and it is used for ResNet. If `downsample_first=False`, the downsample block is the last block, which is used by Hourglass network." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`)" }, { "prediction": "I think this should be `consider-using-sys-exit` instead of `consider-using-sys-exit`.", "reference": "I don't know if there are strict conventions about this, but I think the name of the warning should be the diagnosis, not the suggested course of action. In this case, that would mean changing the name of the warning to `interactive-exit` or something like that." }, { "prediction": "I'm not sure this is the right thing to do here.", "reference": "If `crt.Spec.CommonName` is not set, and `cert.Subject.CommonName` *is* set, we are not correctly handling it here." }, { "prediction": "I'm not sure if this is the right place to test this, but I'm not sure if it's the right place to test this.", "reference": "This isn't a test, so it shouldn't be named `test_init`. You could name it `cmdhistory_init` or so." }, { "prediction": "I don't think this is needed.", "reference": "why is this pulling from `self.spark_version` config section rather than the `spark` config section (`py-packages` appears to pull from a config section called `spark`)" }, { "prediction": "I'm not sure if this is the right place for this test.", "reference": "nit: Think it can be one line.." }, { "prediction": "I think this import should be in `org.camunda.bpm.application`, not in `org.camunda.bpm.application`.", "reference": "please inline imports" }, { "prediction": "I'm not sure if we can't join cgroups if we're in a rootless container.", "reference": "This check is still correct in some cases, but I guess erroring out is acceptable if someone explicitly asked for an impossible cgroup configuration (now that we could in principle nest things). I would like to see a test for this though." }, { "prediction": "I don't think we need this.", "reference": "Should we update integral to operate on a single column as well?" }, { "prediction": "I think this should be `cudaStream_t s = cuda_get_deep_copy_stream();`", "reference": "Doesn't belong to this PR" }, { "prediction": "I'm not sure if this is the right place to register the container instance. I'm not sure if this is the right place to register the container instance, but if it's the right place to register the container instance, then it's the right place to register the container instance. I'm not sure if it's the right place to register the container instance, but if it's the right place to register the container instance, then it's the right place to register the container instance.", "reference": "Just for my own understanding, does aws ecs API take this token as a new input attribute? Which version of the aws sdk? I did not find it in the official aws sdk doc." }, { "prediction": "I don't think we need to change this to \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or \"UA\" or", "reference": "Could we shorten this constant to maybe `FEATURE_USER_AUTH`?" }, { "prediction": "I think this should be `numRekeyWorkers`", "reference": "Any particular reason for 8? I feel like we could probably handle more..." }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if it's the right way to do this.", "reference": "Try to use factory association declaration for default values, so it could minimal the line length. You may write in fetch_job factory like association :repository, factory: :repository." }, { "prediction": "I don't think this is needed anymore.", "reference": "Should the \"cancelled\" class be added regardless of the proposal's state?" }, { "prediction": "I'm not sure if this is the right place to call `eventEmitter.call(this);`", "reference": "nit: random whitespace change, let's try to keep these out of commits unless there are other useful changes." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea, but I'm not sure if it's a good idea.", "reference": "Seems kinda dangerous - what if models length is different from paths length?" }, { "prediction": "I'm not sure if this is the right place to pass the prune.Mode parameter.", "reference": "set real one plz (get it from DB)." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "Should this be initialized to zeroes?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "The query is already built at this point, so I don't think this particular change actually helps wrt SOLR-10732? (and the `base.size()==0` case is already trivially optimized in `SolrIndexSearcher.numDocs(Query, DocSet)`)" }, { "prediction": "I don't think this is needed anymore.", "reference": "re-add the type in the annotation here" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Could we simpify it as `cmd.Stderr = &bytes.Buffer{}`?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `X509Expired` function that returns true if the X509 cert has expired. I'm not sure if it's a good idea to have a `X509Expired` function that returns true if the X509 cert has expired. I'm not sure if it's a good idea to have a `X509Expired` function that returns true if the X509 cert has expired, but if it's a good idea to have a `X509Expired` function that returns true if the X509 cert has expired, and if it's a good idea to have a `X509Expired` function that returns true if the X509 cert has expired, and if it's a good idea to have a `X509Expired` function that returns true if the X509 cert has expired, and if it's a good idea to have a `X509Expired` function that returns true if the X509 cert has expired, and if it's a good idea to have a `X509Expired` function that returns true if the X509 cert has expired, and if it's a good", "reference": "there's enough \"nots\" in here that while it's correct by my review, I'd like to see a small unit test (just passing in an expired and non-expired cert)" }, { "prediction": "I don't think this is needed anymore.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea.", "reference": "The config option should probably have a more specific name. Also it's not for all gridded data but specifically for Images (and its subclasses)." }, { "prediction": "I'm not sure if this is the right place for this test. I'm not sure if this is the right place for this test, but I'm not sure if it's the right place for this test.", "reference": "Be careful. This is not a preference but an option in a dialog." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "this will modify the incoming object, which may not be desirable in some cases. i think we should stick with the local var, override it with deployment.ClusterName if deployment.ClusterName not empty" }, { "prediction": "I'm not sure why this was removed.", "reference": "Is this not required?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "You're using scare quotes on these terms instead of defining them." }, { "prediction": "I don't think this is needed.", "reference": "These should both be const, not var right?" }, { "prediction": "I don't think we need to change this?", "reference": "Can you catch a more specific exception here? Thanks :-)" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "This is a bug during handling the recover logic in `common chaos` controller, I fixed in this request when I found it." }, { "prediction": "I don't think this is needed.", "reference": "During testing, we adopt the score threshold specified in the config file. Here the threshold is only used for visualization, and the variable name `score_thr` can be misleading. Renaming it to `show_score_thr` would be better." }, { "prediction": "I don't think we need this anymore.", "reference": "can you make this `nav-primary` please? i'd like to roll with this since the `
    ` class is `nav`, and primary is the name of the navigation menu" }, { "prediction": "I don't think this is the right place to do this, but I think it's better to use `$rootScope.root + 'p/' + context.calendar.publicToken + '/' + displayname;` instead of `$rootScope.root + 'p/' + context.calendar.publicToken + '/' + displayname;`", "reference": "@georgehrke Just out of curiosity. Couldn't you combine at least the combine the regex for '-' and '' with groups?" }, { "prediction": "I'm not sure about this change, but I think it would be better to move the `FindQualifiedType` call into `HashedCollectionConfig::GetAnyObjectType` and use `FindQualifiedType` in `HashedCollectionConfig::GetAnyObjectType` in `HashedCollectionConfig::GetAnyObjectType`.", "reference": "I think this is objectively better than looking up the object by name. As a follow-up, I'm going to see whether we do this name-based lookup somewhere else and switch to your method." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Why are you dividing by scale in the LTR case but not the RTL case?" }, { "prediction": "I don't think this is needed.", "reference": "Update after command rename" }, { "prediction": "I don't think we need to add this filter to `googlesitekit.ModuleSettingsDetails-${ moduleSlug }`", "reference": "I added this change to fix a bug with the legacy settings wrapper which was preventing it from working properly with the other modules" }, { "prediction": "I don't think we need to change this?", "reference": "isn't AZKABAN_FLOW_VERSION_2_0 more explicit?" }, { "prediction": "I'm not sure if this is the right place to do nothing.", "reference": "Please don't leave an empty default" }, { "prediction": "I'm not sure if this is the right place for this file.", "reference": "This isn't directly related, but the `import React from'react';` below should be removed. We never import this directly and any modules from it we need are imported through `@wordpress/element`. This was probably added automatically at some point, but we also provide this automatically via `ProvidePlugin`." }, { "prediction": "We don't need the 800+ lines of output. We don't need the 800+ lines of output.", "reference": "You can also use `echo: false` instead. Either is fine; I'm just pointing it out." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "what's the reason for this moved line?" }, { "prediction": "I don't think this is needed.", "reference": "I don't really follow what is happening here, but it looks like this _could_ conflict with the logic on the lines above... should this be an `else if`?" }, { "prediction": "I think this is a breaking change. I'm not sure if this is a breaking change, but I'm not sure if it's a breaking change.", "reference": "`s => s.IsHidden == false` What's the purpose of adding this?" }, { "prediction": "I think we should move this to a separate file. I think we should move this to a separate file and move it to a separate file.", "reference": "I would name this `clef-ethereum-address`. We already have a bunch of addresses in Bee, and people might wrongly think that this is yet another address" }, { "prediction": "I think this test should be in `test6ChangeBondLength`", "reference": "you can just remove this" }, { "prediction": "I'm not sure if this is the right approach.", "reference": "I think we should avoid creating a dummy CR in the case of SPC. Please see if we can avoid this since we will not be patching anything in this CR." }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "Honestly not sure myself, but do you think it makes sense to move this conditional into the partial?" }, { "prediction": "I'm not sure if this is the right place to use `qutebrowser-prefix-` or `qutebrowser-prefix-`", "reference": "As discussed in IRC (just so it doesn't get lost): This probably should be `-basedir-`, not `-prefix-`" }, { "prediction": "I don't think this is needed.", "reference": "basepath can be absoluta path and this needs to be supported" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Didn't get to the commit message" }, { "prediction": "Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line when opening brace is on a separate line.", "reference": "What about raising `ActionView::MissingTemplate` instead? That's what HighVoltage does." }, { "prediction": "I don't think this is the right thing to do here.", "reference": "Is it kept for compatibility?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I would find it pretty reasonable to add a MinerSigner method on the state view that puts these together." }, { "prediction": "I don't think we need to add this column to DBUpgrader.", "reference": "It's stored in `PodDBAdapter.VERSION`. I usually use the expected release version code for that change. As this will be released in AntennaPod 2.2.0, the code would be `2020000`." }, { "prediction": "I'm not sure if this is the correct error message, but I'm not sure if it's the right error message.", "reference": "What about method name itself? Do we run this for SQL too?" }, { "prediction": "I don't think we need to change this?", "reference": "`instanceUrl` should be `cs1.salesforce.com`. `communityUrl` would be `mobilesdk.cs1.my.salesforce.com`." }, { "prediction": "I don't think we need to copy the name to the variableBase->m_Name.copy(name, *size);", "reference": "Let's use `if(name!= nullptr)` to remove ambiguity" }, { "prediction": "I'm not sure if this is the right place to implement this method. I'm not sure if it's the right place to implement this method.", "reference": "I wonder if it would make sense to have a separate namer for metadata? Metadata files tend to be expressed in a different language from the repo language, and have mutually exclusive concepts. So, `PackageMetadataNamer`." }, { "prediction": "I think this should be `private final`.", "reference": "This rule is quite specific to qbft and so I don't think it should be part of the common rules. Would rather the common bft code didn't know anything about contract based voting/validator governance." }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do here.", "reference": "This makes our life harder than it needs to be. A Set is unordered by definition. Please remove this method from Set and add it to SortedSet, but with no default implementation. We need to duplicate it then to LinkedHashSet but that's ok, it is the best we can do. Could you please add it also to SortedMap and LinkedHashMap? We are then able to close the original issue." }, { "prediction": "I don't think we need to do this for every request. I'm not sure if we need to do this for every request or for every request. I'm not sure if we need to do this for every request or for every request.", "reference": "we can replace `for` with `params.update(response_headers)`" }, { "prediction": "I don't think we need to remove this line.", "reference": "Any chance this is available in.NET Core 2.0 now?" }, { "prediction": "I don't think this is needed anymore.", "reference": "I wonder if it's necessary to let app pass in the context. What app level context should be sent? If no, is it enough for p2p agent to compose a context with network info there?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "Why do we need both includes here?" }, { "prediction": "I don't think this is needed anymore.", "reference": "SmartStoreInspectorTest expected results in a certain order" }, { "prediction": "I don't think this is the right place to do this, but I think it's a good idea to move this check into the `data_reader_jag_conduit::load_conduit_node` function.", "reference": "I think that you need something like `m_using_random_node.emplace(m_io_thread_pool->get_local_thread_id());`" }, { "prediction": "I think this should be `if (isUsedLocalVarWithoutInitializer(entry, result.usedVariables)) { continue; }`", "reference": "I don't think we need to maintain a separate set. The problem here is that the \"assignment\" that is killed for this variable is not really an assignment. If we just don't `assign` the variable with the non-existent value, it will not be reported. I pushed a fix." }, { "prediction": "I think this should be `long targetSplitSize()`.", "reference": "Let me know if this is too pervasive. It is currently a private method in `BaseTableScan`. It seems both `SparkBatchQueryScan` and `SparkMergeScan` need to know the scan-specific split size when planning tasks. Therefore, I made it open. Another approach is to move all the `planTasks` logic to scan implementations, but for the combine tasks by partition feature, it requires grouping scan tasks by partition first, instead of returning them in an iterator fashion. I'm not sure if this is OK. `SparkMergeScan` also seems to re-implemented its own plan tasks logic." }, { "prediction": "I'm not sure if this is the right place to use `fmt.Sprintf` or `fmt.Sprintf`", "reference": "Not sure what is this change doing?" }, { "prediction": "I don't think this is needed anymore.", "reference": "this is funky. either don't take` minutes` as keyword arg or take both `minutes` and `days` and pass all of them on to `timedelta`. i'm guessing you're aiming for backwards compatibility, but i don't think it's worth it given how confusing this is. atlernatively, make `mins=60*24*30` the default. and that brings me to another issue, `mins=None` is not a very useful default." }, { "prediction": "I don't think this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Please use a tab for indentation instead of spaces." }, { "prediction": "I'm not sure if this is the right fix.", "reference": "I can't believe we didn't see this typo before :))" }, { "prediction": "I don't think this is needed.", "reference": "If the logger isn't used, it probably doesn't need to be added." }, { "prediction": "I don't think we need to add `script.type = 'text/javascript'` here.", "reference": "These files should in `/javascript/brython`" }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it. I'm not sure if this is the right way to do it, but I'm not sure if it's the right way to do it, and if it's the right way to do it, I'm not sure if it's the right way to do it, but if it's the right way to do it, I'm not sure if it's the right way to do it, but if it's the right way to do it, I think it's better to do it this way.", "reference": "minor, you can squash these into one `if`" }, { "prediction": "I think this test should be `TestHandleNamespaceTask_RegisterNamespaceTask_IsGlobalNamespace()`", "reference": "Used regexes to do most of this, hence different methods of string creation of UUIDs. I plan to follow up with an additional change to remove direct references to google/pborman UUID so `uuid.New()` and `uuid.NewRandom()` will instead use our `primitives.UUID`." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it. If it's the right place to do it, I'm not sure if it's the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it. If it's the right place to do it, I'm not sure if it's the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it. If it's the right place to do it, I'm not sure if it's the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it. If it's the right place to do it, I'm not sure", "reference": "Add a TODO here to revisit if this was problematic." }, { "prediction": "I don't think this should be `True` or `DIoULoss`.", "reference": "Note generally it -> It" }, { "prediction": "I don't think this is needed.", "reference": "Is this relevant to this PR?" }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it.", "reference": "Can we instead ensure that `opts[:run_in_parellel]` will always be a boolean? Otherwise we'll have to account for the case when it's a non-boolean value in multiple places, such as any/every other `if` statement." }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "Is this just moved out of the other files? It doesn't seem like this was generated like the other files." }, { "prediction": "I don't think this is needed.", "reference": "I started out doing everything `async`, but it was getting in the way of debugging, so I switched back to all synchronous until I got things working. We should probably move everything back to `async` and remove the synchronous versions." }, { "prediction": "I don't think this is needed.", "reference": "this looks already too complicated..." }, { "prediction": "I think this test should be moved to a separate PR.", "reference": "As for the testings, we better to verify the actual effects of the compaction. Of course, you could do it in future." }, { "prediction": "I think this should be `tables.removeIf(TiTableInfo::isView)`", "reference": "should we add a TODO here?" }, { "prediction": "I'm not sure if this is the right place to move this file.", "reference": "This can be inlined below as `GoogleSitekitDashboardDetails` is an unnecessary wrapper now." }, { "prediction": "I don't think we need this anymore.", "reference": "NewVHS -> NewVersionHistories this one looks better" }, { "prediction": "I'm not sure if this is the right place to use `attr_accessor` or `attr_accessor`", "reference": "Is this `@missing_text`?" }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "Minor suggestion, but wouldn't it be cleaner to simply replace PACKAGE_NAME_FORMAT to all the optional path, then check that the path is empty in validate_package_name? We might also want a helper function to pull out the package name and sub-package path." }, { "prediction": "I don't think this is needed.", "reference": "we should have a way to insert components into a i18n string. so that we could define a translation string like `'%{filename} is being edited'`, and inject the filename `` at the right place. I imagine there must be a language where the `Editing` text should come after the file name. we can think about that later tho." }, { "prediction": "I think this should be `if (!pglob.gl_pathv) continue;`", "reference": "Probably want break instead of continue." }, { "prediction": "I don't think we need to change this.", "reference": "This was on purpose that I would set logging (NoLog=false) and a dummy logger below. The idea is to have better code coverage and test of debug/trace statements. Any reason you have removed this?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "does adding a `Stream.empty()` help here?" }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do this. I'm not sure if it's the best way to do this, but I'm not sure if it's the best way to do it. I'm not sure if it's the best way to do it, but I'm not sure if it's the best way to do it.", "reference": "This is not being used anymore, so can be removed." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this.", "reference": "Is it called some where?" }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "Please remove this extra blank line." }, { "prediction": "I don't think this is needed anymore.", "reference": "this is really the key, if you don't set this then gradle doesn't wire up the tasks that produce various files inside these configurations as inputs... I think we were just getting lucky before." }, { "prediction": "I'm not sure if this is the right place to test this, but I'm not sure if it's the right place to test this.", "reference": "Sorry if I'm missing something here, but shouldn't this message be about failing to match with an *empty* selector, and/or perhaps even an empty *tag* instead of selector? The message seems a bit disconnected from what we're testing?" }, { "prediction": "I don't think this is needed.", "reference": "nit: please move these inside namespace." }, { "prediction": "I'm not sure if this is a good idea. If we're in debug more for the payments we're in debug more for the payments done in a VPN session. If we're in debug more for the payments done in a VPN session, we're in debug more for the payments done in a VPN session.", "reference": "may users try to abuse it?" }, { "prediction": "I think this should be `new_buf_size - old_buf_size`", "reference": "why is this space removed?" }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do.", "reference": "Can we remove this other line now then?" }, { "prediction": "I don't think this is needed.", "reference": "There's a comma missing here at the end :wink:" }, { "prediction": "I don't think we need this anymore.", "reference": "Why is this not required any longer?" }, { "prediction": "I don't think this is needed.", "reference": "Indentation seems a bit fucked up here. Run `go fmt`." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.", "reference": "any chance in == nil? same below" }, { "prediction": "I'm not sure if this is the right place to use h2o_sysfn, but I'm not sure if it's the right place to use h2o_sysfn, or if it's the right place to use h2o_sysfn, or if it's the right place to use h2o_sysfn, or if it's the right place to use h2o_sysfn, or if it's the right place to use h2o_sysfn, or if it's the right place to use h2o_sysfn, or if it's the right place to use h2o_sysfn, or if it's the right place to use h2o_sysfn, or if it's the right place to use h2o_sysfn.", "reference": "We would change the source code of h2o so that certain syscalls will be invoked through the `h2o_sysfn` macro." }, { "prediction": "I don't think this is needed.", "reference": "the name kTimelineCannotBeSignalled is confusing. It's not that a TimelineSemphore cannot be signaled... it's the \"VK_KHR_timeline_semaphore is enabled *variant* of the \"binary cannot be signaled\" message. We should probably have a consistent naming scheme to clarify. kBinaryCannotBeSignalledAltTimeline or hide the complexity in Get*VUID functions as needed somehow (pass in the extension structure?)" }, { "prediction": "I don't think this is needed.", "reference": "Could you add a type hint? `percentiles: Optional[List[float]] = None`" }, { "prediction": "I don't think we should use `User.where.not(building_number: nil).pluck('DISTINCT building_number')`", "reference": "Maybe putting ones they've used before first would be good, but this is fine for now." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if it's the best way to do this.", "reference": "I don't think we need these. Simpler just to put `routetable.TargetType...` inline below." }, { "prediction": "I don't think this is needed anymore.", "reference": "Why this instead of the old way?" }, { "prediction": "I don't think this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Just combining the inner if/else blocks like this is what I originally meant (I didn't mean replacing all the invisible checks in the outer if, I realize that would have been a functionality change regarding the rule) This should now be equivalent to `if (RuleB(Pets, LivelikeBreakCharmOnInvis) || IsInvisible(formerpet))` (the second check for the rule being false after the `||` would be implied, anything after the `||` would only be evaluated if the rule was false)" }, { "prediction": "I think this should be `strings.ReplaceAll(key, \"_\", \"\")`", "reference": "We don't want to write this back to the definition do we? Probably just want to create a local variable for it." }, { "prediction": "I think this should be `PlaybackPreferences.clearCurrentlyPlayingTemporaryPlaybackSpeed()`", "reference": "Good catch! Could you please move this to `PlaybackService.this.onPlaybackEnded`? I think it's more clean if everything is in one single place." }, { "prediction": "Is this needed?", "reference": "We're trying to avoid X.org specific code. So I'm not a fan of this. Can't this be achieved in display server agnostic way?" }, { "prediction": "I don't think this is needed.", "reference": "This class can be removed?" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "To minimize the possibility of regret, perhaps we name this `ZapLogger`." }, { "prediction": "Line is too long. [89/80]
    Space inside { missing.
    Space inside } missing.", "reference": "This looks a little weird, but it's a feature of the gem we're using. You can give it a symbol representing the method you want called on current_user." }, { "prediction": "I don't think we need this file anymore.", "reference": "`Anomaly` imported here, but not used. Please run the changed files through pylint with nupic pylint config and fix pylint findings related to your changes." }, { "prediction": "I don't think this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "We needed this testutils file after all" }, { "prediction": "I don't think we need to change this.", "reference": "line is 161 characters (from `lll`)" }, { "prediction": "I'm not sure if this is needed.", "reference": "Please re-format/groupimport this line. You might need a little manual work." }, { "prediction": "Do we need to do this in a separate PR?", "reference": "minor, you can just use `wf` instead of `worker.wf`" }, { "prediction": "I'm not sure if this is the right place for this test. I'm not sure if it's the right place for this test.", "reference": "I would suggest putting this in the resources directory with the same package as of this test class. Then you can utilize the method azkaban.utils.TestUtils#readResource to read it as string." }, { "prediction": "I don't think this is needed anymore.", "reference": "could not import github.com/openebs/maya/pkg/upgrade/templates (invalid package name: \"\") (from `typecheck`)" }, { "prediction": "I'm not sure if this is a breaking change, but I'm not sure if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, I'm not sure if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, I'm not sure if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, but I'm not sure if it's a breaking change.", "reference": "a official -> an official" }, { "prediction": "I don't think we need to check for KINESIS_PROVIDER here. I think we need to check for KINESIS_PROVIDER in ProxyListenerKinesis.py.", "reference": "I only want the proxy request for this to run for kinesalite." }, { "prediction": "I don't think we need to change this.props.dateFormat", "reference": "White space boya?" }, { "prediction": "I'm not sure if this is the right type for the `StackSummary` field.", "reference": "Maybe ditch these since `StackSummary` is not used anymore." }, { "prediction": "I don't think we need to change the label bias here.", "reference": "suggest to indicate the value range & meaning in docstring" }, { "prediction": "I don't think we need to change this?", "reference": "not sure if it works with prometheus by default, otherwise we will have to add this into prometheus config also" }, { "prediction": "I think this should be `CleanupEndPointMark`", "reference": "The rule renderer isn't meant to be stateful so probably best to move this out of here" }, { "prediction": "I think this should be `findNvidiaContainerRuntimes(nil)` instead of `findNvidiaContainerRuntimes(nil)`", "reference": "passing in a `nil` here just so that the tests can pass in an alternative implementation seems weird, but I don't know what the convention is for doing something like this - @briandowns?" }, { "prediction": "I'm not sure if this is the right place to use `doT` or `doT`", "reference": "IMO `dot` should be preferred. Remember `aXe`?" }, { "prediction": "I think this should be `Console.ReadKey();`", "reference": "Not a huge deal but this will block tests, also, don't they stay open by default now?" }, { "prediction": "I don't think this is the right place to do this.", "reference": "Could you make it a local constant for now?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "What is this `collection_id` field here?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "Is there a reason why we don't use logging for this?" }, { "prediction": "I don't think this is needed.", "reference": "Exceptions should be placed in application layer -> infrastructure is aware of application - not the other way around" }, { "prediction": "I'm not sure if this is the right thing to do, but I think it's better to use `C0301` instead of `C0301`.", "reference": "IIRC issue mentioned reporting _symbolic message_ - so in this case it would be `line-too-long`." }, { "prediction": "I don't think this is needed.", "reference": "Is this intended to be `spells[spell_id].reflectable` here? Edit: Should be `spells[spell_id].feedbackable`, right?" }, { "prediction": "I don't think we need this column.", "reference": "How should we set this for existing teams?" }, { "prediction": "I'm not sure if this is the right place to test infraID already set on cluster provision. I'm not sure if it's the right place to test infraID already set on cluster provision, but if it's the right place to test infraID already set on cluster provision, I'm not sure if it's the right place to test infraID already set on cluster provision.", "reference": "It would be nice if we could verify that this is in fact the error we expected. But that's a latent issue, something for the backlog." }, { "prediction": "I don't think this is needed anymore.", "reference": "I hate then some internal process specific middleware leaks into connection manager :( todo later." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Reflects where these files were moved for `pkg_resources`." }, { "prediction": "I don't think this is needed.", "reference": "This should be computed('i18n.locale'...." }, { "prediction": "I'm not sure if this is the right thing to do, but I think it's better to use `net.ipv4.conf.eth20.rp_filter=2` instead of `net.ipv4.conf.eth20.rp_filter=2` and then use `net.ipv4.conf.eth20.rp_filter=2` here.", "reference": "Can you explain to me what goes wrong here? Can the test be adjusted to set up working routing instead?" }, { "prediction": "I don't think this is needed anymore.", "reference": "We can get rid of this import then." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Not sure how useful is unlock event." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Consider make the second argument a `encoderOptions` which includes the `lowercaseFields` just like opening a collection." }, { "prediction": "I think we should move this method to HiveIcebergOutputCommitter.", "reference": "What is the value of renaming this to `ctx`? We generally prefer the longer names because they are easier to read and to type." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Hm. This could be a case of left-sided driving, having u-turn lanes on the right side. Good catch, but looks good to me." }, { "prediction": "I don't think we need to change this.", "reference": "There was a [JsonPropertyName(\"success\")] here it did serialize fine for me, so I am not sure what was the matter? Also maybe uppercase?" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for this, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, I'm not sure if it's the right place for it, or if it's the right place for it, or if it's the right place for it.", "reference": "we can just use read env here, pretty sure" }, { "prediction": "I don't think this hook is used anymore.", "reference": "Could you replace local hook with global hook `afterModifyTransformStart`?" }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to use `self._files.clear()` instead of `self._files.clear()`.", "reference": "You seem to be basing your PRs off an commit, which keeps reintroducing these changes, which makes it harder to review your PRs." }, { "prediction": "I'm not sure if this is the right place to check for `typeof opt_port!== 'function'`", "reference": "Maybe it would simpler to ignore opt_port if type!== 'number'?" }, { "prediction": "I don't think we need to change this.", "reference": "As far as I can tell, `IDictionary` implements `IEnumerable>` so we are just making it more generic. From the issue, I understood that we want to maintain sequence/order. I believe `IEnumerable<>` won't fix the issue." }, { "prediction": "I'm not sure if this is the right place to put the finest message.", "reference": "This change prevents a user understanding how their server is configured. Best to leave at `info` level." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "I will add the following to the list: - api.SpecScale - api.SpecSticky" }, { "prediction": "I don't think this is needed anymore.", "reference": "As defaultSendPort is being removed, and I don't like TODOs on examples, please remove the whole line" }, { "prediction": "I'm not sure why this is removed.", "reference": "since we are now no longer expecting an input of float to return an empty string, i have removed this test case." }, { "prediction": "I'm not sure if this is the right place to register the counter. I'm not sure if it's the right place to register the counter.", "reference": "It would be cleaner if you were to pack the name&desc in a `MetricName` and pass it to `MakeCounter`" }, { "prediction": "I don't think this is needed anymore.", "reference": "Do you know why do we need this?" }, { "prediction": "I don't think this is needed.", "reference": "I guess this using is what causes the build to fail" }, { "prediction": "I don't think this is needed.", "reference": "I like the explicit unregister approach." }, { "prediction": "I'm not sure if this is used. I'm not sure if it's used. If it's used, then it's used.", "reference": "We should able to use 0x30 as summary, and make 0x80 reserved for future." }, { "prediction": "I don't think we need to skip client span?", "reference": "This allows strategic exclusion of http spans." }, { "prediction": "I think this should be `@var string[]|null` instead of `@var string[]|null`", "reference": "why not just `string[]` instead of nullable" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "How does this work? Why isn't each tag after the first picked up as a new arg/flag?" }, { "prediction": "I don't think we need to change the name of the resource.", "reference": "This key is actually yet to be determined. Meeting with the backend team and Garner to discuss." }, { "prediction": "I'm not sure why this was removed.", "reference": "Why remove the crash protection? We're just going to get a bug filed on it." }, { "prediction": "I'm not sure if this is the right option.", "reference": "Maybe be consistent and name it `FRAME_OPTIONS`." }, { "prediction": "I'm not sure why this was removed.", "reference": "This check/exception is a guard for the next few lines of code. It shouldn't be necessary now. In fact, I don't think you need the if (parentConnection.type == Blockly.INPUT_VALUE) branch at all." }, { "prediction": "I think this test should be `assertTrue(res)`", "reference": "Could probably move these constants too?" }, { "prediction": "I'm not sure this is the right place to stop the ping proposal. I'm not sure if this is the right place to stop the ping proposal, but if it's the right place to stop the ping proposal, I think it's the right place to stop the ping proposal.", "reference": "Maybe 'failed' instead of'missing'. Also do we really need to write ticket numbers here?" }, { "prediction": "I don't think we need this anymore.", "reference": "Test used to use old bouncycastle dependency which isn't needed anymore from Hadoop. Switched to use builtin Java split." }, { "prediction": "I'm not sure if this is the right thing to do, but I think it's better to use `os.path.basename(v.identifier).lower()` instead of `os.path.basename(v.identifier).lower()`", "reference": "nit: I think this would be more readable as \"Some language names contain Unicode characters\"." }, { "prediction": "This file is not covered by the GNU General Public License.", "reference": "Thanks for adding the header, but I don't think 2017 is a very accurate guess here. Could you do a quick search with git blame and change this accordingly?" }, { "prediction": "I don't think this is needed.", "reference": "Oh interesting - does web-test-runner not resolve package.json files?" }, { "prediction": "I don't think we need this.", "reference": "Is there a way to derive this value from the locale itself? I feel hardcoding the prefix in the props isn't the right approach, but I'm not sure what the locale file contains exactly." }, { "prediction": "I don't think this is necessary.", "reference": "I'd much rather see these warnings in our devtools (`debug/index.js`). Strings contribute quite a bit to our file size and moving them there would prevent bloating core." }, { "prediction": "I don't think we need to change this to `INDICES_QUERY` or `INDICES_COLUMN_TYPE_COL` or `INDICES_COLUMN_TYPE_COL`", "reference": "Use `String.format(Locale.US,...) to avoid the `Lint` warning." }, { "prediction": "I'm not sure if this is the correct name.", "reference": "nit: ServiceReference represents a reference to a v1.Service." }, { "prediction": "I'm not sure if this should be `[]string` or `[]string`.", "reference": "since it changes to the array, how about change the name to `DeviceNames`" }, { "prediction": "I don't think this is needed.", "reference": "Can we avoid this. upgrade engine code should take care of this." }, { "prediction": "I don't think we should change this to `DEFAULT_TOKEN_EXP_MINUTES` or `DEFAULT_TOKEN_EXP_MINUTES`", "reference": "should also be alphabetized or at least grouped and alphabetized within group" }, { "prediction": "I think this should be `assert results.webengine_error is not None`.", "reference": "No need for this, as pylint already only turns things off for this function and it's needed for the entire function." }, { "prediction": "I don't think we need to do this. I'm not sure if we need to do this in a follow up PR.", "reference": "nit: can we remove \"can't\" from the error message?" }, { "prediction": "I don't think we need to update the cVR.Status.Phase = apis.CVRStatusRecreate", "reference": "instead of modifying 'Status' which impacts the state diagram, how about using some annotations on CVR? This can probably help for our upgrade as well. Is this possible? cc: @AmitKumarDas" }, { "prediction": "I'm not sure if this is the correct URL, but I'm not sure if it's a good idea to use `kubernetes.io` or `kubeedge/kubeedge/kubeedge/kubeedge/kubernetes.io` or `kubeedge/kubeedge/kubeedge/kubernetes.io` or `kubeedge/kubeedge/kubeedge/kubernetes.io` or `kubeedge/kubeedge/kubeedge/kubernetes.io` or `kubeedge/kubeedge/kubeedge/kubeedge/kubernetes.io` or `kubeedge/kubeedge/kubeedge/kubeedge/kubeedge/kubeedge/kubeedge/kubeedge/kubeedge/kubeedge/kubeedge/kubeedge/kubeedge/kubeedge/kubeedge/kubeedge/kubeedge/kubeedge/kubeedge/kubeedge/", "reference": "Rename this as KubernetesGPGURL - >KubernetesUbuntuGPGURL, Modify it where ever it is used." }, { "prediction": "I don't think this is needed.", "reference": "I'm not totally sure I like the idea of putting a default fee here, but I guess so long as we make sure to track the default fee of bitcoin core, we're good. We should really also take a look at the byte size of the transaction, and use that to determine what the fee should be. But that could also be a different PR." }, { "prediction": "\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"", "reference": "oh yeah, `tail`, `update`, `prepend`, `append`, `subSequence`, `trim` just became effectively constant (without memory leak) :)" }, { "prediction": "I don't think we need to change this line.", "reference": "Can you add back a deprecated `destroyLinks` method for backward compatibility? It can simply proxy `destroyResourceLinks`, and we can remove it in the next major release." }, { "prediction": "I think this should be `parseServerOptions` instead of `parseServerOptions`.", "reference": "A reminder that we should discuss whether to rename this to \"sockets\" or \"listeners\"." }, { "prediction": "I don't think this is needed.", "reference": "Why do you need to include this using declaration?" }, { "prediction": "I don't think this is needed.", "reference": "@halter73 where is this file generated from?" }, { "prediction": "I think this should be `IEnumerable MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List MongoDB => new List<", "reference": "What do these `#if TRUE` accomplish?" }, { "prediction": "I think this should be `if (Sdk.SuppressInstrumentation && Activity.Current == null) { return; }`", "reference": "Probably a good optimization to have this, but I don't think it's strictly required. For \"legacy\" Activity flows we pass them through an ActivitySource for sampling. So the logic below should also catch these?" }, { "prediction": "I don't think we need to change the view_request_cta to view_request_cta?", "reference": "@jessieay Intentionally moving away from passing a param?" }, { "prediction": "I don't think we need to do this anymore.", "reference": "I think you could condense this code considerably by getting rid of the initialization and foreach loop and simply saying: `$firstname = trim(implode(' ', $nameArr));` What do you think?" }, { "prediction": "I'm not sure why this is needed.", "reference": "hmm, we actually should _add_ `'use strict'` everywhere" }, { "prediction": "I don't think this is the right place for this, but I think it's better to use `logger.warn()` instead of `logger.debug()`.", "reference": "it's not just fetching override properties here, right?" }, { "prediction": "I'm not sure if this is a valid reason, but I'm not sure if it's a valid reason, or if it's a valid reason, or if it's a valid reason, or if it's a valid reason, or if it's a valid reason, or if it's a valid reason, or if it's a valid reason, or if it's a valid reason, or if it's a valid reason, or if it's a valid reason, or if it's a valid reason, or if it's a valid reason, or if it's a valid reason, or if it's a valid reason, or if it's a valid reason, or if it's a valid reason, or if it's a valid reason, or if it's a valid reason, or if it's a valid reason, then it's a valid reason.", "reference": "Is it worth logging the error?" }, { "prediction": "I don't think this is needed.", "reference": "What's the point of this class?" }, { "prediction": "I don't think we need to change this. I think we need to check if the content type is'movies' or'mixed' and if so, we need to check if the content type is'movies' or'mixed' and if so, we need to check if the content type is'movies' or'mixed' and if so, we need to check if the content type is'movies' or'mixed' and if so, we need to check if the content type is'movies' or'mixed' and if so, we need to check if the content type is'movies' or'mixed' and if so, we need to check if the content type is'movies' or'mixed' and if so, we need to check if the content type is'movies' or'mixed' and if so, we need to check if the content type is'mixed' or'mixed' and if so, we need to check if the content type is'mixed' or'mixed'", "reference": "I'm being picky here, but I think I would prefer `toggle` to be kept here and just change the condition to `contentType!=='movies' && contentType!=='mixed'` or `!['movies','mixed'].includes(contentType)`." }, { "prediction": "I'm not sure if this is needed.", "reference": "Please put this down with the other \"github.com\" imports." }, { "prediction": "I don't think we need to pass a bool to nano::block_processor::add (std::shared_ptr block_a, bool push_front_preference) to nano::block_processor::add (std::shared_ptr block_a, bool push_front_preference) to nano::block_processor::add (std::shared_ptr block_a, bool push_front_preference) to nano::block_processor::add (std::shared_ptr block_a, bool push_front_preference)", "reference": "Minor but probably want `push_front_preference` to have a trailing `_a` to be consistent with the other parameter" }, { "prediction": "I think this should be `InclusiveManifestEvaluator(PartitionSpec spec, Expression rowFilter, boolean caseSensitive)`", "reference": "Nit: the formatting is a bit off. I would expect this to be 2 indentations from `this.expr =...` but this is 8 spaces, not 4. Also, most places leave the `);` on the last line of the method arguments." }, { "prediction": "I don't think this is needed anymore.", "reference": "Ack, @chrisdunelm snuck this class extension past me. This is not a pattern I want to have used..." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if this is the right place for this.", "reference": "nitpick: I wonder if we should name it `flush` only (?)" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if it's the best way to do this.", "reference": "Why gauges, not counters?" }, { "prediction": "I don't think we need to change this.", "reference": "Just making a note here that this may break pre GWs between pre 2.2.0 and 2.2.0 servers. Not sure, will have to experiment/dig a bit more." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "Shall we rename this status to CONTAINER_FAILED? ^^ cc: @sshardool" }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do.", "reference": "Thinking out loud here: I believe the only reason we need `peer.ID` as a parameter to this method is because we are not persisting blocks from pubsub (instead we are refetching them). If nodes persist the blocks they received over pubsub then I think we can guarantee peers we share a connection with (i.e. that are in the peer tracker) will always have the blocks we are fetching (else how would have we gotten the pubsub message). I imagine the concept of an `initialPeer` can go away once #2962 lands since the peers in the tracker will have the block. Although I don't think that covers the case of fetching blocks our peers have deemed semantically invalid and thus not stored..." }, { "prediction": "The standard definitions of CEL functions and operators can be found [here](https://github.com/google/cel-spec/blob/master/doc/langdef.md#standard-definitions). The standard definitions of CEL functions and operators can be found [here](https://github.com/google/cel-spec/blob/master/doc/langdef.md#standard-definitions).", "reference": "I know it has no effect but my eyes can't help. Is that line not too long?" }, { "prediction": "I'm not sure why this was removed.", "reference": "Does that mean we disable service loop prevention for packet generated by local host?" }, { "prediction": "I'm not sure if this is the correct behavior. I'm not sure if this is the correct behavior.", "reference": "It seems a little odd to have both `host.is_cygwin?` *and* `host.cygwin_installed?` defined (with a possibility of having `is_cygwin?` be `true`, but `cygwin_installed?` returning `false`). Do the docs clearly explain the difference?" }, { "prediction": "I'm not sure if this is the right fix.", "reference": "Does this mean manifests will be written with the v2 schema (i.e. with sequence numbers) even though `TableMetadata` is v1 and the manifest list is written with v1? And this should work because we do a projection on read and sequence number is optional?" }, { "prediction": "I think this should be renamed to `REWRITTEN_FILE_SCAN_TASK_SET_ID`", "reference": "Should we be sharing this property key with the read? Maybe it should be belong to the file-scan-task object itself?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `debug_cmd` field. If it's a good idea to have a `debug_cmd` field, then I think it's a good idea to have a `debug_cmd` field that's a good idea to have a `debug_cmd` field that's a good idea to have a `debug_cmd` field that's a good idea to have a `debug_cmd` field that's a good idea to have a `debug_cmd` field that's a good idea to have a `debug_cmd` field that's a good idea to have a `debug_cmd` field that's a good idea to have a `debug_cmd` field that's a good idea to have a `debug_cmd` field that's a good idea to have a `debug_cmd` field that's a good idea to have a `debug_cmd` field that's a good idea to have a `debug_cmd` field that's a good idea to have a `debug_cmd` field that's a good idea", "reference": "Nice! Good idea to move these out of the main struct." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Thanks for paying attention to other places this might happen. This one is particularly important; I probably never should have gotten in the habit of CheckErr(), since it does a log.Panic() explicitly, which looks like something else until you look closely. It's supposed to be used places where \"can't happen\" but Things Can Happen." }, { "prediction": "I don't think we need this enum anymore.", "reference": "Converting this to an enum makes it obvious that I combined things that don't really belong together. It would probably be better to create two enums `StoreType` and `TransportType` (in more appropriate locations). That also makes it necessary to have (at least) two `ServerSettings` classes. `IncomingServerSettings` and `OutgoingServerSettings`. Also, the naming is inconsistent. Maybe it would be better to make the string that is used for import/export explicit, e.g. WEBDAV(\"WebDAV\")." }, { "prediction": "I'm not sure if this is the right place to put this method.", "reference": "It's out of scope for this PR, but I don't find this utility's name to be particularly intuitive. It speaks to nothing of what it does. Does it create a token list? Process one? Get one? `tokenListToArray` would be nice." }, { "prediction": "I don't think this is the right place to do this.", "reference": "The message for this check used the existence of a label to determine the output, which doesn't work with the current schema. So I updated it since the data only needed to know a label was present and not what it was." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "nit: \"The current project does not have requested application\"" }, { "prediction": "I think this should be `FORBIDDEN = ['id'];` and not `FORBIDDEN = ['id'];`", "reference": "Extend Unit test for this class" }, { "prediction": "I think this should be `DD_APPSEC_IP_HEADER`", "reference": "This is this a copy / paste error from above." }, { "prediction": "I don't think this is needed.", "reference": "this package has to be renamed to `typeinference`" }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do here.", "reference": "This cancels the above null-check I guess." }, { "prediction": "I don't think we need to change the name of the property.", "reference": "change to timerIntervalInMillis" }, { "prediction": "I think this should be `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None`` or `None` or `None` or `None` or `None` or `None` or `None`` or `None` or `None` or `None`` or `None` or `None` `None`` or `None` or `None`", "reference": "`any rules` should be `any roles`" }, { "prediction": "I don't think we need to do this anymore.", "reference": "Why does the method need to be renamed? I would just keep the old name and update the other uses (which are only tests). That way, we can reduce code duplication." }, { "prediction": "I don't think this is needed.", "reference": "I'm not sure if this is going to work - I think it's fine to keep them hardcoded here, as the statusbar can still show `:`, `/` and `?` even if the key is rebound." }, { "prediction": "I'm not sure why this is removed.", "reference": "@tmetzke shouldn't we replace this library with the `2.12.1` instead of removing it?" }, { "prediction": "I don't think we need this field anymore.", "reference": "uint64 seems excessive here. Should we reduce to a uint32 @whyrusleeping?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Hmm, I thought this was getting used. These are used elsewhere as a cached value (in `svc deploy` it's `o.targetApp`) but I guess since storage doesn't actually need to validate that the app exists, just that there are local services, we never used it." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "To keep it simple, how would you feel about just using r.RemoteAddr? Since every request comes through here I want it to be as lean as possible. Frankly I'm OK with the port showing up in the log; maybe it'd even be useful to someone." }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to move this logic into the `if grantFB` block.", "reference": "grant bonus depends on both `admin{}` stored in statedb, and `P2Start/End` in local struct, which is kind of weird at Kamchatka height, we add the bonus Start/End epoch into `admin{}`, so it solely depends on `admin{}` stored in statedb" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `f` or `f` here.", "reference": "Use single quote to wrap the str." }, { "prediction": "I don't think we need to change this error message.", "reference": "Is the plan to rename this later?" }, { "prediction": "I think this should be `!in_array($this->strategy, $this->strategies)`", "reference": "Is there a reason why we need a special case for Email at this point? Is the idea that other methods can turn into Email even if it's not configured as a top-level option?" }, { "prediction": "I think this should be `if len(dir) == 0 { panic(\"dir unexpectedly empty\") }`", "reference": "This wording is a bit ambiguos, I first thought it meant the directory has no entries in it. maybe \"dir\" -> \"dir string\"?" }, { "prediction": "I don't think this is needed.", "reference": "Why do we need both `HPX::m_hpx_initialized` and `HPX:: m_was_initialized`?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or not.", "reference": "also check RPCName?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Remove unused import" }, { "prediction": "I'm not sure if this is the right place to start a new instance.", "reference": "I assume there will never be a scenario where justValidate is expected to be true on a restart" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this. I'm not sure if it's the right place to do this.", "reference": "Report listeners are synchronized, even 'though the cache is thread-safe... I've not profiled it, but it may be a cause of contingency. Any better way around this? Also, do listeners **really** need to be synchronized? Can't we just make them thread-safe?" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if this is the right place for this, or if it's the right place for this, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, I'm not sure if it's the right place for it, or if it's the right place for it, or if it's the right place for it, I'm not sure if it's the right place for it.", "reference": "I don't think this is correct. When `compiler` is not given in `.travis.yml`, the announcement will be `--version`, which results in \"`command not found`\" (though not critical), and the cache slug will lack this information (also not critical)." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "Why do this rather than `args = []` in the function signature?" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "I think we probably *should* do validation of whether there is a suitable implementation if local-validation is true. I'm not sure how useful that actually is though" }, { "prediction": "I'm not sure if this is the right fix, but I'm not sure if this is the right fix or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug.", "reference": "@StrikerRUS here may need to concat two data by col." }, { "prediction": "I'm not sure if this is the right place to use `JavadocComment` or `JavadocComment` here.", "reference": "Why the space?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or not.", "reference": "please resolve the extra indentation" }, { "prediction": "I don't think we need to check for null here.", "reference": "More proof that this check is needed always." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "`m_al_comms` now contains smart pointers." }, { "prediction": "I don't think this is needed.", "reference": "Did you do a test run with the compare script? I'm nervous about what happens on all the generators..." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, or if it's the right place to do it.", "reference": "For a client, we store host, as string c.host. That is what we use for monitoring and statsz. Not sure if its useful here or not. Looks like probably not." }, { "prediction": "I think this test should be `Assert.assertEquals(\"Spark partitions should match\", 4, resultDf.javaRDD().getNumPartitions());`", "reference": "This change is suspicious. Why did the number of partitions increase?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea, but I'm not sure if it's a good idea.", "reference": "I'm still new to this area, so please forgive what may be a stupid question: When would this be false? And do we have a test for that situation?" }, { "prediction": "I'm not sure if this should be `true` or `false`.", "reference": "Should there be any changes to this file at all?" }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "The only field being used is the KeyType; Instead, we can probably just make a `keyType` variable here." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This should be done by code-gen change happening in the hydra repo. I am tweaking it just to get CI into a 'passing' state" }, { "prediction": "I don't think this is needed.", "reference": "Cleaned up when I originally added support for passing `screenContext` here (and later `viewContext`) but that was removed." }, { "prediction": "I think this should be `return name[0] == '?' && name[1] == 'Z' && name[0] == '_' && name[1] == 'Z' && name[0] == '_' && name[1] == 'Z' && name[0] == 'Z' && name[1] == 'Z' && name[0] == 'Z' && name[1] == 'Z' && name[0] == 'Z' && name[1] == 'Z' && name[0] == 'Z' && name[1] == 'Z' && name[0] == 'Z' && name[1] == 'Z' && name[1] == 'Z' && name[1] == 'Z' && name[0] == 'Z' && name[1] == 'Z' && name[1] == 'Z')`", "reference": "This looks like a bunch of whitespace fixing that's unrelated. Can you revert?" }, { "prediction": "I don't think we need this anymore.", "reference": "should be removed instead" }, { "prediction": "I don't think this test is needed.", "reference": "should use randomization?" }, { "prediction": "I don't think we need to change this?", "reference": "returning nil because we want to mayactl to exit with 0 status code." }, { "prediction": "I don't think we need to change this?", "reference": "Is this change relevant to the PR? (and I believe we should use `text/plain` considering the fact that it can be displayed using web browsers...)" }, { "prediction": "I don't think we need to change this.", "reference": "`[Flags]` is now auto-generated by an argument to the `EnumHint`. (The attributes happen to come out in this order. I don't think it's worth controlling the order.) #Resolved" }, { "prediction": "I'm not sure if this should be `true` or `false`.", "reference": "I think same here - in general we don't need to use Setters / Getters since configParams isn't a public API." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this. I'm not sure if it's the right place to do this.", "reference": "Why using `fmt.Sprintf` where `fmt.Sprint` would do the work (notice no `f` in function name)?" }, { "prediction": "I don't think this is needed.", "reference": "Extraneous blank line." }, { "prediction": "I don't think we need to change this error message.", "reference": "nit: syntax : neither -> nor" }, { "prediction": "I think we can remove the `DistributedSpanContext` from the `TraceIdKey` and `SpanIdKey` from the `HttpHeaderNames.TraceIdKey` and `HttpHeaderNames.ParentId` properties.", "reference": "Is it safe to assume that these two keys are always present? `this[string]` will throw a `KeyNotFoundException` if they are not." }, { "prediction": "I think this should be `execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution.execution", "reference": "Is the `flowDefinitionId` sufficient to uniquely identify the flow or does it need to be the tuple ``?" }, { "prediction": "I don't think this is needed.", "reference": "Shouldn't it be in the reverse order? `DateTime::createFromInterface()` returns `self` and accepts `DateTimeInterface`." }, { "prediction": "I'm not sure if we should remove this line.", "reference": "this check is now redundant. The rest of the function downwards basically does the same thing but with safer checks." }, { "prediction": "I don't think we need this anymore.", "reference": "Please could you remove the useless space." }, { "prediction": "I'm not sure if this is the right fix.", "reference": "What's the point of this block (and isn't it effectively dead code)?" }, { "prediction": "I'm not sure if this is the right place to do this, but I think it's better to use `ENV.fetch(\"DISCOURSE_SSO_SECRET\")` instead of `ENV.fetch(\"DISCOURSE_SSO_SECRET\")`", "reference": "Put a comma after the last parameter of a multiline method call." }, { "prediction": "I think this should be in dagster.py.", "reference": "Newline at end of file plz" }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "Can this be refactored to avoid including the aws sdk in the types that we expose? I know it's not being exposed directly through the types we expose, but I do worry that it might make it easier to accidentally do that in the future and not realize it as easily." }, { "prediction": "I think this should be `$GLOBALS['TYPO3_DB']->exec_UPDATEquery( 'tx_solr_indexqueue_item', 'tx_solr_indexqueue_uid = '. (int)$item->getIndexQueueUid(), ['indexed' => time()] );`", "reference": "Hi thomas, i would propose to indicate in the name, that only the indextime is updated, otherwise somebody might think the whole items is getting updated. I would propose something like \"updateIndexTimeByItem(Item $item)\"" }, { "prediction": "I think this should be `is_element_displayed` instead of `is_element_displayed`", "reference": "This is not the right exception class. There is an InvalidSelectorException class that covers bad locators." }, { "prediction": "I don't think this is needed.", "reference": "I assume this came from format?" }, { "prediction": "I think this should be `@var boolean $clearSearchIndex;`", "reference": "I'd suggest a default value of `false` just to make sure existing tasks are ok when they get deserialized after an update to a version containing this code." }, { "prediction": "I'm not sure if this is the right place for this, but I think it's better to use `dumpConfig().Sdump(keys)` instead of `dumpConfig().Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).Sdump(keys).S", "reference": "Do we really need this? Seems like it would pollute the logs pretty badly." }, { "prediction": "I don't think we need to store this in the `MemoryPoolIterator2` class. I don't think we need to store it in the `MemoryPoolIterator2` class.", "reference": "`Vector.Count` should Jit to const when intrinsic; not sure when `Vector.IsHardwareAccelerated == false` ; however we know `readonly static int` does Jit to const." }, { "prediction": "I don't think this is needed.", "reference": "Can we use a skipIf decorator instead?" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if this is a good idea.", "reference": "Missing version tags" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "I think this should also filter out `validate_resolve_reference` hooks." }, { "prediction": "I'm not sure why this is needed.", "reference": "unrelated, but required fix as metrics branch got broken with the latest main->metrics merge and conflict resolution." }, { "prediction": "I'm not sure about this, but I think it's better to remove the `#Copyright` from the `#globalCommands.py` file. I'm not sure if it's a good idea to remove the `#Copyright` from the `#globalCommands.py` file, or if it's a good idea to remove the `#Copyright` from the `#globalCommands.py` file. If it's a good idea to remove the `#Copyright` from the `#globalCommands.py` file, then I think it's better to remove the `#Copyright` from the `#globalCommands.py` file. If it's a good idea to remove the `#Copyright` from the `#globalCommands.py` file, then I think it's better to remove the `#Copyright` from the `#globalCommands.py` file.", "reference": "Feel free to remove this line" }, { "prediction": "I'm not sure if this is the right place to click the link.", "reference": "~~Should this match the key updated above?~~ :+1:" }, { "prediction": "I'm not sure if this is the right place to close the file.", "reference": "`gofmt` allows a more compact form `defer func() { _ = f.Close() }()` or just add `// nolint:errcheck` before `defer`." }, { "prediction": "I don't think this is needed anymore.", "reference": "collateral is in FIL" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "We should not create channel of node which are not connected." }, { "prediction": "I don't think we need to change this. I think we need to add a `options.db` property to the `options.mechanismProperties` object.", "reference": "I think the docstring should say something like \"Alias for the `source` option\" or something similar." }, { "prediction": "I think this should be `@JsonProperty(\"recycling_instructions_to_discard_fr\")` and not `@JsonProperty(\"recycling_instructions_to_recycle_fr\")`", "reference": "Please use properties without suffix `_fr` so they can work across different languages as @teolemon mentioned" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to call `start_request` or `destroy_request`.", "reference": "Declaration here is `static` but the definition at the bottom is non-static?" }, { "prediction": "I don't think this is needed.", "reference": "Hi @myml, thanks for the contribution! `blob` and `blob/driver` are both in the same module, so you shouldn't need to split this change up into multiple Pull Requests. Also, I'd like to see it working, including the implementation for `s3blob` and `gcsblob` (these should be easy, just pass-through to the provider) and `fileblob` (might be trickier...), and a test in `drivertest/drivertest.go`." }, { "prediction": "I don't think we need to change this. I'm not sure if we need to change this.", "reference": "Was it a bug?" }, { "prediction": "`attr_value['string'] is not None` probably not required as `attr_value['string'] == value`", "reference": "# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done" }, { "prediction": "`tabbed_browser._now_focused._last_hovered_link` should be `lambda: tabbed_browser._now_focused._last_hovered_link`", "reference": "You're accessing private variables here - `last_hovered_link` should be public in `TabData`. As for `tabbed_browser._now_focused`, I think you can use `tabbed_browser.widget.currentWidget()` instead." }, { "prediction": "I'm not sure if this is the right place to put this method.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I don't think this is needed.", "reference": "We should file a bug for this - we don't need the extensions class if there are no operations on the client" }, { "prediction": "I'm not sure if this is the right place to store metrics. I think we should move this to the `NewMounter` function.", "reference": "Is it possible to import from k8s instead of copy in? :)" }, { "prediction": "I think this should be `float $start_time`", "reference": "`@param float` can be dropped here." }, { "prediction": "I don't think this is needed anymore.", "reference": "maybe we can leave this change un-reverted." }, { "prediction": "I don't think this is the right place for this class.", "reference": "I wouldn't make MethodDeclarator an AccessNode, nor an Annotatable. It's the MethodDeclaration that can be annotated, and has info about the modifiers, and is already an AccessNode" }, { "prediction": "I think this should be `public PlayerHeadIconChanged(Player player)`", "reference": "delete this class" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Replacing `+` (1 or more) with `*` (0 or more) would've also done the trick." }, { "prediction": "I'm not sure this is the right place to close the writer, but I think it's better to just close the writer if it's still open.", "reference": "I've been meaning to fix this for a while. Thanks." }, { "prediction": "I don't think we need this anymore.", "reference": "This is adding multiple processor pipelines. I guess you wanted to add multiple processors to the same, single pipeline?" }, { "prediction": "I don't think this is needed.", "reference": "If you need str(x[0]) here, you'll probably need str(x) the line after that I suppose. Also, shouldn't we use `raw()` here instead of `str()`?" }, { "prediction": "I don't think we need to change this.", "reference": "3.6 seconds? what does it stand for?" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "If the command fails, is stdout nil or \"\"?" }, { "prediction": "I don't think we need to change this test.", "reference": "Why is api-version now removed in the generated code?" }, { "prediction": "I don't think this is needed.", "reference": "We may register all built-in optimizers of PyTorch here to simplify the builder." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "No need for this new variable." }, { "prediction": "I don't think this is needed.", "reference": "doesn't this enqueue a double render or is that safeguarded somehow" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, I'm not sure if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "But now you may get DATA RACE reports because c.acc is sometimes changed. I wonder if we should not rework that whole sending subs through route." }, { "prediction": "I don't think this is needed.", "reference": "Use `ADIADIOS2_HAVE_HDF5`, not `ADIOS_HAVE_PHDF5`" }, { "prediction": "I'm not sure if this is the right thing to do here. I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do.", "reference": "Would be nice to put this in a separate context named `\"with a string and a non-string\"` (since that's what it is -- it's definitely not a non-string and a string!)." }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea.", "reference": "Should MAX_PERTABLE_ENTRY here be 10?" }, { "prediction": "I don't think this is needed.", "reference": "Should move these out of frame into a static class? Similar to reason phrases?" }, { "prediction": "I don't think we need to check for `UseLane` here.", "reference": "That means we still create `UseLane` instructions but threat them like `Suppressed`? Can we maybe change this in the pre-processing so that we will just emit `Suppress` instructions in these cases?" }, { "prediction": "I'm not sure if this is a breaking change. I'm not sure if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change.", "reference": "no need to move here, iotex-proto is outside of iotex-core and considered same as iotex-address, go-pkgs" }, { "prediction": "I think this should be `if defined(LINUX) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined(X86_64) && defined", "reference": "Looks like a clang-format style violation: should turn Travis red." }, { "prediction": "I'm not sure about this, but I think it's a good idea to add a `success_color` setting to the `failure_color` setting. I'm not sure if it's a good idea to add a `success_color` setting to the `failure_color` setting, or if it's a good idea to add a `failure_color` setting to the `run_all_when_everything_filtered_color` setting.", "reference": "I think we need some YARD docs here, particularly to list all the color symbols that are valid. Otherwise users will have to look at the source to discover that." }, { "prediction": "I don't think this is needed.", "reference": "Not sure if this needs a doc block or not since it's completely internal, but for cleaning this up. (@felixarntz docs?)" }, { "prediction": "I'm not sure if this is needed.", "reference": "The change here is to address what exactly?" }, { "prediction": "I don't think we need to do this here. I'm not sure if we need to do this. I'm not sure if we need to do this. I'm not sure if we need to do this.", "reference": "Is this really an Option? IIUC, you compute it automatically for the URLOpener case, why would we require a user to fill it in when using the constructor? I.e., can't we drop this and use `adal.MSIAvailable` instead? If that call is expensive, cache it on `bucket`, not `Options`." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Was this done automatically or by hand?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "This looks like it will only work for the first child, since after that we've overridden `desired_group`. Should we have a separate variable for this?" }, { "prediction": "I think this should be \"UNASSIGNED-cache-file-error\"", "reference": "Should this be a constant somewhere?" }, { "prediction": "I don't think we need to add this to the `OpenTelemetry.Instrumentation.Http` assembly.", "reference": "nit: sort alphabetically." }, { "prediction": "I don't think this is needed.", "reference": "Now, It's redundant, I suppose." }, { "prediction": "I'm not sure if we should deprecate the `ListImplementation` in favor of \"go.uber.org/yarpc/peer/peerlist/v2\".", "reference": "nit: The format recognized by tooling is `// Deprecated: [..]` so you likely want this to be, // Deprecated: Use \"go.uber.org/yarpc/peer/peerlist/v2\".Implementation instead." }, { "prediction": "I'm not sure if this should be `infof` or `infof`.", "reference": "nit: 1. when formatting input strings, make sure to place them in quotes so we could identify white space issues. i.e. '%s' 2. If there is untyped, non-nil error, you want to log the error string as well." }, { "prediction": "IsProfilerAttached() and IsProfilerAttached() are not used anywhere?", "reference": "I believe this can be fixed with the original code if you just omit the \".dll\" file extension so it reads `[DllImport(\"Datadog.Trace.ClrProfiler.Native\")]`. On Windows it would look for `Datadog.Trace.ClrProfiler.Native.dll` and Linux/Mac it would look for `Datadog.Trace.ClrProfiler.Native.so`." }, { "prediction": "I don't think this is needed.", "reference": "couldn't we just read the boolean as a string (I would assume that this return \"true\" or \"false\"), migrate if to its new value and keep using the same pref key?" }, { "prediction": "I think this should be `static int json_input = 0;`", "reference": "If these variables are only used in main function, move these to the beginning of that function. If there is a foreseeable reason to have them as global statics just let me know." }, { "prediction": "I'm not sure if this is the correct behavior.", "reference": "This one was wrong." }, { "prediction": "I don't think this is the right thing to do here.", "reference": "What happens if nodes throughout a hierarchy are modified (as they would be)? It looks like we're going to `Reset` once for each `NodeID` affected." }, { "prediction": "Is this still needed?", "reference": "> Note that allocation of vmheap fails upon initializing dynamoRIO 64 on WoW64 processes. Thus, we need to pass -reachable_heap to avoid having to make this allocation. This should be solved by changing the default `vmheap_size` to be much smaller than 8GB for x64 DR inside WOW64." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "Is it really worth expanding our public API for this? After all, isn't calling this the same as calling `notification.fully_formatted(...).lines`? If so, I'd rather not widen our API (and thus, increase our maintenance burden) when it's so simple to get all the lines already." }, { "prediction": "I'm not sure if this is the right place to remove the `SnippetSetRunner.class.getPackage().getName().replace('.', '/');` annotation.", "reference": "Is it necessary to keep this class around just to define this constant? Or can we place it somewhere else?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Question - do we cache NetworkPolicy itself? If so, here we can point to NetworkPolicy?" }, { "prediction": "I'm not sure why this was removed.", "reference": "For my view, `Register` means the process of **insert node resource to etcd through api-server**, which is called by upstream rather than here, how about changing the func name to `OnConnected`?" }, { "prediction": "I don't think this is needed.", "reference": "I would prefer an active verb for this property, e.g. `initializeTelemetry`. The reason is that this property refers to something the engine does once on startup. Other properties that use passive voice (e.g. `authorizationEnabled`) refer to a state of the engine during its lifetime." }, { "prediction": "I don't think this is needed.", "reference": "please use new line to maintain reasonable line width" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I would skip this check or add an internal server error response." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this. I'm not sure if this is the right place to do it, but I'm not sure if it's the right place to do it.", "reference": "missing `{` here (and then `}` after `notary_password = config.notary_password`); it's only going to do the first one" }, { "prediction": "I'm not sure if this is the right place for this test.", "reference": "This is odd because it's actually in our generated SiteSettingsPath, not in the SiteLocalSettingsPath (wp-config-ddev.php). Are these two files swapped somehow? I'd expect SiteSettingsPath to be wp-config.php and SiteLocalSettingsPath to be wp-config-ddev.php. BTW, I'm *way* ok with renaming that to SiteDdevSettingsPath." }, { "prediction": "I think this should be `kythe.io/kythe/go/extractors/config/default.go`", "reference": "It seems like this must necessarily be a stopgap. Can you please add a TODO(#xyz) to point to the appropriate issue?" }, { "prediction": "I'm not sure if this is the right place to start Kubelet proxy. I'm not sure if this is the right place to start Kubelet proxy. I'm not sure if this is the right place to start Kubelet proxy, but if it's the right place to start Kubelet proxy, I'm not sure if it's the right place to start Kubelet proxy. If it's the right place to start Kubelet proxy, I'm not sure if it's the right place to start Kubelet proxy.", "reference": "Is the return signature necessary since we never actually return if there is a problem (I'm referring to the call to `logrus.Fatalf`). Let's pick a pattern and stick with it." }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "@btecu why is this override needed here? I'm not seeing a `new` being used here." }, { "prediction": "I don't think we need to close the connection.", "reference": "Should it not be more something like: `MaxAccountConnectionsExceeded` here?" }, { "prediction": "I'm not sure if this is the right test.", "reference": "minor: use a non-default CE service account for testing (since default is handled in a specific way in the code)" }, { "prediction": "I don't think we need to run the test against sectors with larger sector size. I think we need to run the test against sectors with larger sector size and then run the test against sectors with larger sector size. I think we need to run the test against sectors with larger sector size and then run the test against sectors with larger sector size. I think we need to run the test against sectors with larger sector size and then run the test against sectors with larger sector size.", "reference": "This is how I ran the 512MiB test. It's probably too much data for a fixture, and makes for longer functional tests (although still less than a minute on my laptop)." }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if it's the right way to do this.", "reference": "So we weren't able to hide the fact that the file wasn't pre-generated and had to introduce this \"option\" to detect that?" }, { "prediction": "I'm not sure if we should expose the maps as public variables to document the mappings. I'm not sure if we should expose the maps as public variables to document the mappings. I'm not sure if we should expose the maps as public variables to document the mappings.", "reference": "Agree that exporting these maps is the best tradeoff, just registering my ongoing discontent with the lack of `const` collections." }, { "prediction": "I don't think this is needed.", "reference": "This could probably use `const` as well?" }, { "prediction": "I'm not sure if this is the right thing to do here. I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do.", "reference": "it doesn't look like these need to be exported?" }, { "prediction": "I don't think this is needed anymore.", "reference": "I think you should remove \"fmt\" here. And change `fmt.Errorf` to `errors.Errorf`." }, { "prediction": "I think this column should be `nullable: false`", "reference": "Here's the `resources` attribute @jferris. I'm not against renaming `Product` to `Resource`, and this one... something else." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "If the context is unused, this is equivalent to `var wg errgroup.Group`." }, { "prediction": "I don't think this is needed.", "reference": "very minor: I'd prefer these two added rows are switched so that fragsizeIsMinimum directly follows fragsize" }, { "prediction": "I think this should be `host == 'localhost' or host.startswith('127.')`", "reference": "Given that 115 returns `True`, why would this be `False` here?" }, { "prediction": "I don't think this test is needed.", "reference": "Please move this test method just below `oauth2LoginWithOneClientConfiguredThenRedirectForAuthorization()`" }, { "prediction": "I don't think this is needed.", "reference": "Why this new configuration?" }, { "prediction": "I think this should be `ByteBuffer buffer = ((ByteBuffer) value).duplicate();`", "reference": "I don't think that we need to check `hasArray` here. I think the reason why this didn't previously check `hasArray` is that the array passed to `DataByteArray` must start at offset 0 and be valid through the array length, so a copy was needed in almost every case. It may be simpler to change this to use `ByteBuffers.toByteArray` and pass the result to create `DataByteArray`." }, { "prediction": "I'm not sure if this is the right place for this method.", "reference": "`spanReference` -> `baggage`" }, { "prediction": "I don't think this is the right place to put this file.", "reference": "Why the `/-/verdaccio/`?" }, { "prediction": "I'm not sure if this is the right place for this test, but I'm not sure if it's the right place for this test.", "reference": "Has been waiting for a million years" }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "Minor grammar detail: the 'than' is unnecessary" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I think you can just simply fix this line to `self[:2].to_pandas()`" }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "if we are returning the `ws` here when passing in `se:cdp` we can just return it straight or do we have to make a request to get the `ws` address?" }, { "prediction": "I don't think this is needed anymore.", "reference": "I could add a resolver for this (like above) but it seems more sensible to just change the one reference!" }, { "prediction": "I think this should be `final long actualTimeSinceParent = timestamp - parentTimestamp;`", "reference": "not sure \"actual\" adds value - secondsSinceParent is probably closer." }, { "prediction": "I'm not sure if this is the right place to do this, but I think it's better to move this method to `SearchHelper` and use it in the `SearchHelper` class.", "reference": "Line is too long. [94/80]" }, { "prediction": "I think this should be `min_items_error` instead of `min_items_error`.", "reference": "The error should be `At least :number items are required`" }, { "prediction": "I'm not sure about this change, but I'm not sure if it's a good idea to remove it.", "reference": "singleCaseSwitch: should rewrite switch statement to if statement (from `gocritic`)" }, { "prediction": "I'm not sure if this is a breaking change, but I'm not sure if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, I'm not sure if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, I'd say.", "reference": "Could combine this with `encryptionKeyGetter` to have a single `keyGetter` interface. I'm not sure which way is better." }, { "prediction": "I don't think this is needed anymore.", "reference": "Is there any security issue here? If we integrate with Hive security (and I don't know if we have or not) is there some notion of re-authentication at connection time?" }, { "prediction": "I don't think we need this anymore.", "reference": "Does this mean we do not support writeConcern on `createCollection`?" }, { "prediction": "I'm not sure if this is the right place for this test.", "reference": "I guess `sid` was for `sessionID`, but now it looks strange: `sid.ID`." }, { "prediction": "I don't think this is needed.", "reference": "We'll need `infrav1.SecurityGroupBastion` as well" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This `fileName` should probably be `remote` and be relative to the Fs root as per normal rclone usage." }, { "prediction": "I think this test should be removed.", "reference": "That way we are back to having just one index on k_0 So we can really compare the execution times with and without re-indexing" }, { "prediction": "I don't think this is needed.", "reference": "Expression that uses a negation pattern to exclude all characters that aren't in the expression." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "Similar to my suggestion for HTTP, let's remove this and use `ServiceHeader` instead." }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "The serviceDirOnHost[0:1] was completely wrong. It wasn't just Windows, glad you got this fixed!" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to change it.", "reference": "Would membership take 10+ seconds to detect the failed node?" }, { "prediction": "I'm not sure if this is the right place to do this, but I think it's better to use `os.path.exists` instead of `os.path.exists`.", "reference": "hmm, in this case perhaps the whole try-except could be removed altogether? because if the file does not exist, it's already returning `None`. In any other case it should actually probably fail with the exception, no?" }, { "prediction": "I'm not sure if this is the right place to put this function.", "reference": "This function does not need to be public" }, { "prediction": "I don't think we need this anymore.", "reference": "Any chance we can get a CSS class for this? I know it's just in one place but feels like a dangerous precedent to set." }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do this.", "reference": "> && this.Extensions.ContainsKey(\"nextMethodName\") [](start = 96, length = 48) From line 124, looks like we don't need `&& this.Extensions.ContainsKey(\"nextMethodName\")` condition or we don't need line 124 #Closed" }, { "prediction": "I'm not sure why this was removed.", "reference": "Moving this code from compat to core shaves 47 bytes out of compat and only adds 6 bytes to core so I thought it was worth it." }, { "prediction": "I don't think this is needed anymore.", "reference": "Please use \".NET Core 3\" - i'm trying hard to use one form, and this is the one MS advices" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Unrelated to this change, but this is a fix for when TestDoStartCgroupInitHappyPath has a failure after the test goroutine has already exited." }, { "prediction": "I don't think this is needed.", "reference": "Hmm, I'd really expect this to work, and yet it doesn't. I'll investigate later, though it might get Monday until I get the time." }, { "prediction": "I don't think this is needed.", "reference": "Does this changes affect process building dynamic libraries anyhow?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Could you limit what is imported here?" }, { "prediction": "Do we need to do this? I don't think we need to do this.", "reference": "just to clarify - on line 1074 we update `zip_file_content` for non-local lambdas, but never store it, which means lambda never picks it up" }, { "prediction": "I don't think this is needed.", "reference": "Golang naming convention is to use camel case `icmpPktWithTypeCode` Often the linter will complain" }, { "prediction": "I'm not sure why this was removed.", "reference": "We can do away with assigning the response here too." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Bumping the newViewportHeight" }, { "prediction": "I don't think this is needed anymore.", "reference": "Is this change correct? Looks like a typo and not sure this should be changed?" }, { "prediction": "I'm not sure if this is a good idea. I think it's better to use `get_module_part` instead of `get_module_part`.", "reference": "I checked the tests coverage and strangely it look like those three lines are not covered (?!). Do you have the same result on your side?" }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "nit: please try to avoid changing end of the file (it adds a noise to the code review, but does not provide too much value)" }, { "prediction": "I don't think this is needed.", "reference": "I don't see the \"only\" part reflected in the code but maybe I'm missing it. Also, the indentation is misleading: the `.SelectMany` calls are perfectly aligned but are *not* operating on the same \"level\". I'd expect the second `SelectMany` to be on the same height as the inner `Where`, just break `pathObj => pathObj.Where` and lines won't be that long." }, { "prediction": "I'm not sure if this is the right place to use `plugin_hooks` or `plugin_hooks_for_resource_instance`", "reference": "It seems like most of these will never be nil, are they optional just in case?" }, { "prediction": "I don't think we need to change this test.", "reference": "`.addColumn(\"c1\", IntegerType.INT, true)` means `PkHandle=true`, maybe should add `.setPkHandle(true)` in line 31" }, { "prediction": "I don't think we need to change this to `Integer.valueOf(obj).longValue()`", "reference": "how about `Cannot encode row key with non-integer type` directly?" }, { "prediction": "I think this interface should be renamed to `fetchActiveFlowByExecId`", "reference": "The method names `fetchUnfinishedExecutions` and `fetchUnfinishedFlows` are too similar to each other. Would it be better to use the name `fetchUnfinishedFlowsMetadata` since you are only fetching metadata info about the flow?" }, { "prediction": "I don't think we need to install libevent msgpack on Travis.", "reference": "Note that `sudo` is not available by default on BSDs; there are a few places in the codebase here where that's explicitly worked around by using `su`." }, { "prediction": "I'm not sure if this is the right answer.", "reference": "ultra nit: missing Oxford comma :P" }, { "prediction": "I don't think this is needed.", "reference": "This is not supported in Spark 3.0.0-rc2 yet. I'd skip this for now." }, { "prediction": "I don't think this is needed.", "reference": "BLOCKING: Why does `Query` return an `*exec.FunctionSignature`?" }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "please move this down to immediately above the assignment to `c.dirtyBcache`" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "Don't need the `, err` part since you've already handled it." }, { "prediction": "I don't think we need this test.", "reference": "Please add two additional SECTIONs that show that this also works if the dative bond is in the reactant (reaction SMARTS `[O:1]->[H+]>>[O:1].[H+]`) or in the agents (reaction SMARTS `[O:1][H]>N->[Cu]>[O:1].[H]`)" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "What happens if the certificate rotation fails and we are prematurely removing this file?" }, { "prediction": "I don't think this is needed.", "reference": "does this change belong here?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This returns an error" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "If we think we might someday write a native nftables backend, do you think it would make sense to just use generic dataplane configuration? e.g, `dataplane = iptables | ebpf | nftables`, but for now selecting `nftables` uses iptables in nft compat mode?" }, { "prediction": "I'm not sure if this is the right place for this test, but I'm not sure if it's the right place for this test.", "reference": "Looks like that helper function is general enough that it should reside in testhelpers" }, { "prediction": "I think this should be `if app.DisableSettingsManagement { // Ignore because this is a settings file. }`", "reference": "This isn't incorrect IMO, but I think it would be better to fix this in drupal7PostStartAction and also in drupal6PostStartAction. It seems to me like those were both somehow neglected on this. Use drupal8PostStartAction as example. Congrats on your first golang PR! Please make sure to test it manually." }, { "prediction": "I'm not sure if this is the right place to test this.", "reference": "I'd like to ensure that the error message at least has some reference to the flag that is not allowed. Something like `/ERROR(.+)--hosts/` would work." }, { "prediction": "I don't think we need to change this.", "reference": "Should we say \"specifying two public subnets\"?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do it.", "reference": "Issue number? When? Why?" }, { "prediction": "I don't think this is needed anymore.", "reference": "You should not rely on `PitchCommand` being imported into speech. Please import it from `speech.commands`." }, { "prediction": "I don't think we need to change this test.", "reference": "Is this a constant used in the Nessie project itself? If so, perhaps you might consider a follow up for adding `NessieCatalogProperties` class at some point, to help make them more clear to users looking to adopt Nessie coming from the Iceberg repo itself" }, { "prediction": "I think this should be `TaskQueue: db.taskQueueName, TaskType: db.taskType, PageSize: batchSize, ReadLevel: minTaskID, // exclusive, MaxReadLevel: maxTaskID, // inclusive`", "reference": "maybe we should rename: MinTaskID -> MinTaskIDExclusive, MaxTaskID -> MaxTaskIDInclusive," }, { "prediction": "I'm not sure if this is the case.", "reference": "You may need to make this configurable if we expect people to be able to use the normal Nvidia runtime on other Linux distributions like Ubuntu or Debian." }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "Originally the DenyExport was a subscribe permission because it meant that if on this LN connection, if we deny export of \"foo\" it means that it would reject a subscription (hence subscribe permission) on \"foo\" from the other side. Now you are changing to simply not allowing this server to publish on \"foo\". I am not saying this is wrong, but we completely flip the meaning." }, { "prediction": "I don't think this is needed.", "reference": "> k1 src0 src2 -> dst s/src2/src1/ nit: k1 is actually src0 according to instr_get_src(instr, 0) which makes this a little confusing" }, { "prediction": "I'm not sure about this change.", "reference": "I believe that you meant to have the following on the second one, right? `dataDirStat.Mode()^0077`" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "The reason a `ByteCount` is used here, is that the H2 mapping in gQUIC requires this layer violation, which is why `CloseRemote` is not part of the public API. This layer violation will be resolved in IETF QUIC" }, { "prediction": "IsInvisVsUndead and IsInvisVsAnimals?", "reference": "I dig the helper function!" }, { "prediction": "I think this should be `package samples contains sample programs using the pubsub API.`", "reference": "Please add the Copyright header." }, { "prediction": "I don't think this is needed.", "reference": "Is this the best way to import `FileSystemTarget`?" }, { "prediction": "I'm not sure if this is the right fix. I'm not sure if this is the right fix or if it's the right fix or if it's the right fix, but if it's the right fix, I'm not sure if it's the right fix or if it's the right fix or if it's the right fix or if it's the right fix.", "reference": "Wait -- os_local_state_t.tid is thread_id_t though, so we need to read a pointer-sized value via READ_TLS_SLOT_IMM, rather than changing these locals to ints. Maybe have a READ_TLS_TIDSZ_SLOT_IMM or sthg." }, { "prediction": "I don't think we need to do this. I don't think we need to do this.", "reference": "Don't use! in the messages because it isn't used on xplat. There is a SOSPrefix define that can be used (blank on xplat and! on Windows). Do we really need 3 newlines?" }, { "prediction": "DagsterInvariantViolationError is not a valid error message.", "reference": "print out what we got here in the error" }, { "prediction": "I think this should be `jx_check_errors(jx *j);`", "reference": "Does this need to be global?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "Yep, could be simplified. Now looks like other *Map.values() impls" }, { "prediction": "I think this should be `printLastApiResponse()`", "reference": "This method will be for debug?" }, { "prediction": "I don't think this is needed.", "reference": "// Key returns the private key for a specified name that was encrypted with the // provided password. If the private key does not exists it creates a new one // with a name and the password, and returns with `created` set to true." }, { "prediction": "I think this should be `PackageEntity` instead of `ClassEntity`.", "reference": "Adding the type hints revealed that it was necessary to distinguish between a ``PackageEntity`` and a ``ClassEntity``, because the ``ClassEntity`` has additional attributes that were dynamically added in the previous code, which confused ``mypy``." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `add_prefix` or `add_suffix` here.", "reference": "These two functions should be available now." }, { "prediction": "I'm not sure if this is the right place to check if the file has the same size and modTime. I'm not sure if this is the right place to check if the file has the same size and modTime. I'm not sure if this is the right place to check if the file has the same size and modTime. I'm not sure if it's the right place to check if the file has the same size and modTime, but if it's the right place to check if the file has the same size and modTime, I'm not sure if it's the right place to check if the file has the same size and modTime. If it's the right place to check if the file has the same size and modTime, I'm not sure if it's the right place to check if the file has the same size and modTime. If it's the right place to check if the file has the same size and modTime, I'm not sure if it's the right place to check if the file has the same size and modTime.", "reference": "`fi` is what the result of Stat is called elsewhere in this file not `finfo`" }, { "prediction": "I'm not sure why this was removed.", "reference": "I'm confused; are we just dropping these methods without deprecation?" }, { "prediction": "I don't think this is needed.", "reference": "can we use PC's time to version in Distributed Systems?" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.", "reference": "is this \"unless\" actually needed?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "We don't accept empty words for lookup anymore, again" }, { "prediction": "I don't think this is the right place for this, but I'm not sure if this is the right place for this.", "reference": "We'll have to account for CI installations being faster than local ones. Do y'all think we should leave it at < 30 green / < 50 orange | >= 50 red or lower our thresholds?" }, { "prediction": "I don't think this is needed.", "reference": "No need for this to be `W3C_` since there is no JWP equivalent" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.", "reference": "As far as I can tell, there's nothing that creates an instance of `Random` or that calls `rand` or `seed`. Am I missing it? If not, let's remove the `Random` class since we don't really need it and we can move the definitions of `shuffle` into `RSpec::Core::Ordering`. One less type :)." }, { "prediction": "I don't think this is needed.", "reference": "Is this ever actually used?" }, { "prediction": "I don't think this is needed.", "reference": "this section of the codebase should be noted as a candidate for caching, and as a place where multiple tipsets is making things extra tricky" }, { "prediction": "I'm not sure if we should do this in a separate PR. I'm not sure if we should do this in a separate PR.", "reference": "Do we need to save the existing value of the stolen reg somehow?" }, { "prediction": "I'm not sure if we should change this to `max_results` or `max_results` or `max_results` or `max_results` or `max_results` or `max_results` or `max_results` or `max_results` or `max_results` or `max_results` or `max_results` or `max_results` or `max_results` or `max_results` or `max_results` or `max_results` or `max_results` or `max_results` or `max_results` or `max_results` or `max_results` or `max_results`", "reference": "maxResults should come from FLAGS once #244 is submitted." }, { "prediction": "I don't think this is needed.", "reference": "is this wanted?" }, { "prediction": "I'm not sure if this is the best way to do this, but I think it's better to use `pytest.importorskip('linode')` instead of `pytest.importorskip('linode')`", "reference": "What exception is actually happening here? AFAIK `pytest.importorskip` with just return `None` if there's nothing to import. Which means that this check'd always return `True`. `pytest.importorskip` is specifically designed to trigger skipping the current test anyway so I don't know why you would wrap it like this." }, { "prediction": "I'm not sure if we should change this to `application/x-www-form-urlencoded` or `application/x-www-form-urlencoded` or `application/x-www-form-urlencoded`", "reference": "Does it send requests with urlencoded bodies anywhere? I thought it sends only json. Maybe content-type should be `application/json` by default?" }, { "prediction": "Do not update chromium?", "reference": "I'm not sure about adding more flags here when we're trying to simplify things, I thought we were going to check for patches changes to decide if we needed to update or not?" }, { "prediction": "I don't think we need to change the testTransferPb to testTransferPb.", "reference": "`testExecutionPb` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I think we should remove the `getProviderReference` method from the `ImageProvider` class.", "reference": "~Method is public and removing it would be a BC Break, you can deprecate it if you want.~" }, { "prediction": "I think this should be `fmt.Errorf(\"%s\", debug.Stack())`", "reference": "this got me a little confused when reading `build.log`. The err is printed with a log.Error later on but that ends up after the stack trace." }, { "prediction": "I'm not sure if this is the right thing to do. I'm not sure if this is the right thing to do, but if it's the right thing to do, I'm not sure if it's the right thing to do.", "reference": "Can we make these more explicitly for Rust only? It seems like JS and Go use flags with their name in them." }, { "prediction": "I'm not sure if this is the right place for this, but I think it's better to use `fmt.Errorf(\"open bucket %q: invalid query parameter %q\", u, param)` instead of `fmt.Errorf(\"open bucket %q: invalid query parameter %q\", u, param)`", "reference": "Should unsupported query parameters just be ignored? I think that's more common than error out." }, { "prediction": "I'm not sure if this is the right thing to do. I'm not sure if it's the right thing to do, but if it's the right thing to do, then I'm not sure if it's the right thing to do. I'm not sure if it's the right thing to do, but if it's the right thing to do, then I'm not sure if it's the right thing to do. If it's the right thing to do, then I'm not sure if it's the right thing to do. If it's the right thing to do, then I'm not sure if it's the right thing to do. If it's the right thing to do, then I'm not sure if it's the right thing to do, but if it's the right thing to do, then I think it's the right thing to do.", "reference": "Actually can we avoid mentioning `Register._UNSET_NAMESPACE`. I thought of it as an implementation detail of the simpler concept of \"being unset\". Perhaps the docs become more natural if we remove the \"If called without arguments or with...\" part and just say \"you have to call this function without arguments at the end of any file it has been used. That is to ensure blah blah\". Something like that. Just a suggestion." }, { "prediction": "I don't think this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I assume it raises COMError? If so perhaps best to just catch that specifically, so as to not hide other more critical errors." }, { "prediction": "I don't think we need to add middleware to the stack. I don't think we need to add middleware to the stack.", "reference": "Since minify can generate errors, it should at least go after the errors middleware. And you definitely don't want to be minifying after the gzip writer has closed." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.", "reference": "nit: we could remove the `config` field as it is a duplicate of the `provider.config` field." }, { "prediction": "I think this should be `forseti-server-allow-grpc-internal`", "reference": "Nit: from the Internet." }, { "prediction": "I don't think this is needed.", "reference": "this is internal package, move to bottom and run'make fmt'" }, { "prediction": "I don't think this is needed.", "reference": "Why is this better than ApplicationStopping?" }, { "prediction": "I don't think this is needed.", "reference": "Maybe worth expanding that these 2 are supported by cert-manager but other values exist" }, { "prediction": "I don't think we need to change this.", "reference": "Why was this merged? It should have raised some questions IMO @core23 @OskarStark. It's already in 3 releases now, so we can't revert it can we? How can we fix this? Please have a look at #1065" }, { "prediction": "I think this should be `null`", "reference": "What if `node.jsonRpcConfiguration().getAuthenticationPublicKeyFile()` is empty string, would that cause a problem here?" }, { "prediction": "I'm not sure if we should add this to the `Certificate` struct. I'm not sure if we should add it to the `Certificate` struct.", "reference": "The `omitempty` struct tag does not do anything for non-pointer structs. I think we may need to consider making both of these fields pointers, so that they are excluded from output when not set, and also to make it easier to compare to the zero value. That said, I'm happy to merge this now and open an issue to verify the behaviour is as we want ahead of cutting v0.6.0." }, { "prediction": "I don't think we need to change this interface.", "reference": "I think this is should absolutely be `==`, as the interface cannot control the implementation of equals (and it's part of the contract of the enclosing function). Can we add this interface to the exceptions of the rule?" }, { "prediction": "I don't think this is needed anymore.", "reference": "It looks like the UID is the only other thing that we use from `namespace`, so I suggest to copy that out and lose `namespace`, so we don't have to worry about setting it to nil." }, { "prediction": "I think this should be `aws/codebuild/amazonlinux2-x86_64-standard:3.0\"`", "reference": "Can we define this constant in the`deploy` pkg instead? this would allow us to keep it private" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for this, or if it's the right place for this, or if it's the right place for the `mydir` module.", "reference": "I don't like this fixture name, should be a noun like `initialized_linter`? But it's outside of the scope of this MR." }, { "prediction": "I don't think we need to pass settingsService into the JsonPrinter constructor to check the :ExcludeEmailFromExport setting. I don't think we need to pass settingsService into the JsonPrinter constructor to check the :ExcludeEmailFromExport setting.", "reference": "Could we keep this as a static reference (JsonPrinter.jsonAsDatasetDto(releasedVersion); and perhaps change the constructor line to just be a static set method and use that here instead? (I suspect it was the warning that'static methods should be accessed in a static manner' from my IDE that caused me to make this change in the first place...) (I can make a PR to your branch if you want.)" }, { "prediction": "I don't think this is needed.", "reference": "Keys.COMMAND seems to be an alias to Keys.META. That isn't mentioned?" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "This should go in `ConfigLocal` (and then re-generate the mocks)." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Nitty but entry.get for the same thing" }, { "prediction": "This is the golang entry point for runc init, executed before main() but after libcontainer/nsenter's nsexec().", "reference": "Might not hurt to mention the function never returns (since this all ends in `execve`) so `main` never actually runs." }, { "prediction": "I don't think we need this.", "reference": "nit: add new line after this block" }, { "prediction": "I don't think we need to change this.", "reference": "I believe there is some javascript that also uses this 60px number for calculations. I think I'd rather keep the number in px instead of rem to make that correspondence easier to see. If 3.25rem!= 60px, can you also change the other place where `60` is used to in the JS?" }, { "prediction": "I don't think we need to import `util_errors` here.", "reference": "retrying is an installed 3rd party library just like jinja and sendgrid; perhaps try grouping all of them together?" }, { "prediction": "I don't think this is needed.", "reference": "you could always use List.listIterator with previous() and hasPrevious() to traverse all kinds of j.u.List backwards. No need for special cases for ArrayList and Vector." }, { "prediction": "I think this should be a bit more efficient, like storing only the difference of bitmaps and adding the new operation in the end.", "reference": "remove the bitmap of index 1 from the list not the 0th one. because when we keep on undoing, it would be better if we end up with the original image rather than some randomly edited image. I am not sure whether only just removing bitmap from the list would clear memory. I think you should call bitmap.recycle before removing that bitmap from the list." }, { "prediction": "I don't think this file is needed anymore.", "reference": "this is a existing file so let's keep 2019" }, { "prediction": "I don't think this is the right thing to do here. I think it's better to use `Integer.valueOf(type.getBitMask())` instead of `Integer.valueOf(type.getBitMask())`", "reference": "can you change this instead to just `type.toString()` and then you wouldn't have to expose the getBitMask in the enum. (Alternatively you could have used `type.hashCode()` but that doesn't feel as nice)" }, { "prediction": "I'm not sure if this is the right place to use ReadOnlyTrieStore. I'm not sure if it's the right place to use ReadOnlyTrieStore, but if it's the right place to use ReadOnlyTrieStore, I'm not sure if it's the right place to use ReadOnlyTrieStore or if it's the right place to use ReadOnlyTrieStore.", "reference": "AsReadOnly() would be better here" }, { "prediction": "I'm not sure about this, but I think it would be better to have a `collection.update()` method that returns a `Collection.update()` method that returns a `Collection.update()` method that returns a `Collection.update()` method that returns a `Collection.update()` method that returns a `Collection.update()` method that returns a `Collection.update()` method that returns a `Collection.update()` method that returns a `Collection.update()` method that returns a `Collection.update()` method that returns a `Collection.update()` method that returns a `Collection.update()` method that returns a `Collection.update()` method that returns a `Collection.update()` method that returns a `Collection.update()` method that returns a `Collection.update()` method that returns a `Collection.update()` method that returns a `Collection.update()` method that returns a `Collection.update()` method that returns a `Collection.update()` method that returns a `Collection.update()` method that returns a `Collection.update()` method that returns a `Collection.update()` method that returns a `Collection.update()` method", "reference": "I suggest that we use `query_based_sync` instead of `partial_sync`." }, { "prediction": "I don't think we need to worry about this. I think we need to make sure that the PUT request does not include a \"x-ms-blob-type\" header, and that the PUT request does not include a \"x-ms-blob-type\" header.", "reference": "How does the user use this? By converting the type using `As` function and add the header? Maybe add an example on how." }, { "prediction": "I don't think this is needed anymore.", "reference": "I'm trying to understand the effects of this change. Is setting this to something other than the old default (that is, `initCodeTransformer = new InitCodeTransformer()`) generally necessary, or are we doing this only to support Python?" }, { "prediction": "I don't think this is the right thing to do. I'm not sure if this is the right thing to do, but if it's the right thing to do, I'm not sure if it's the right thing to do.", "reference": "\"Constructor\" isn't a standard term in Go or this project, although we use it informally amongst ourselves. And I think it will confuse people coming from languages like Java. So can we leave this as it was?" }, { "prediction": "I'm not sure if this is the right place to test this.", "reference": "Why do we have to change the test dir?" }, { "prediction": "I don't think we need to check for `SUMMARY` or `SUMMARY` in this case.", "reference": "This should test the flattened tree instead. details > summary works across shadow tree boundaries." }, { "prediction": "I don't think this is needed.", "reference": "Not sure I am a big fan of these duplicated Log classes." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "It's long-winded, but the convention is to give constants a common prefix which, see `reasonDomainVerified`." }, { "prediction": "I don't think we need to change this?", "reference": "Using lanes later down, this threshold could be reduced for similar effects. Otherwise we look a bit to far." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "Let's get more verbose about names. struct `wq_conda_environment`: if it can really only be used for conda. struct `wq_software_environment`: if it has potential use outside of conda." }, { "prediction": "I think this should be `lastPageInPaginatedResp := false`", "reference": "Should we set this back to `false` inside each `t.Run`? so that we can have more than one testcase that can have paginated responses" }, { "prediction": "I don't think this is needed.", "reference": "What about using `dataManifests == null || deleteManifests == null`?" }, { "prediction": "I don't think we need GlobalHitsThresholdChecker here.", "reference": "The `HitsThresholdChecker` should be created once and shared within the collectors? We also don't need to use the `GlobalHitsThresholdChecker` if the executor is null or if there is a single slice." }, { "prediction": "I don't think this is needed.", "reference": "move this to below `antrea.io` import section" }, { "prediction": "I don't think we need to do this.", "reference": "Seems likely to confuse people. What if we moved it into ActivitySourceAdapter and made it private?" }, { "prediction": "I don't think this is the right thing to do.", "reference": "gas price don't need to be a multiple cuz we support allll gas prices now" }, { "prediction": "I think this should be `OnClientProcessExit`", "reference": "We are exposing implementation details in the interface. What if there is no processes involved in an implementation of `ITestRequestSender`?" }, { "prediction": "I'm not sure about this, but I think this should be `print('Error occurred on the server side, message: {}'.format(e.message))` or `print('Error occurred on the server side, message: {}'.format(e.message))`", "reference": "It would be awesome not to handle the broad exception here. Instead, raise a custom exception, something like `ModelNotSetException`, from the `require_model()`, and then handle it here with a nicer message to tell the user to set the model first." }, { "prediction": "I think this should be `Customize Theme` instead of `Customize Theme`", "reference": "This already exists under the `theme` lang key, please remove this." }, { "prediction": "I don't think we need this component anymore.", "reference": "Let's add a simple inline HOC around the default export below to provide the value as a prop (no need to introduce a reusable function for this yet)." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea, but I don't think it's a good idea.", "reference": "I believe that you end up printing out the result of the assignment here instead of the netmask." }, { "prediction": "I don't think this is needed.", "reference": "We have to update the filename here." }, { "prediction": "I don't think this is needed anymore.", "reference": "The `--cpp-field-case` looks like `--cpp-field-style` instead of `-case`. - 'unchanged' - leave unchanged (default); - 'upper_camel' -upper camel case; - 'lower_camel' - lower camel case." }, { "prediction": "I'm not sure why this is removed.", "reference": "I haven't thought about this a lot yet, but if we were to try this change, we'd still need to keep the code to delete it from the `.origin` file for backcompat." }, { "prediction": "I don't think this is needed.", "reference": "In my opinion I think it is possible to add `private final` here" }, { "prediction": "I don't think this is needed.", "reference": "Feel like \"exit\" doesn't convey that the packet will be dropped. \"drop-and-exit\" or \"error-exit\" maybe?" }, { "prediction": "I think this should be \"A Main actor must have a create constructor which takes a single Env\"", "reference": "How do you feel about \"The Main actor\" instead of \"A Main actor\", while we're already here changing the message?" }, { "prediction": "I don't think we need to do this in a follow-up PR.", "reference": "I cannot see that this new permission is used anywhere? And if the new zk handler is covered by `zk-read`, should not also existing `ZookeeperInfoHandler` handler implement PermissionNameProvider and declare the same permission, for consistency?" }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it.", "reference": "Is this reasonable?" }, { "prediction": "I don't think we need to implement Shear and Rotate transforms here.", "reference": "We may move this TODO to Line15." }, { "prediction": "I think this should be `return $this->checkStockNotEmpty();`", "reference": "You have to verify the return type. If it's a reponse, return it. Otherwise do nothing." }, { "prediction": "I'm not sure why this is needed.", "reference": "No. Keep the header include and do `extern template...` to skip the instantiation from that compile unit. (I pushed a fix directly to your branch)" }, { "prediction": "I'm not sure if this is the right place to use `min` and `max` here.", "reference": "these tests are currently somewhat nonsensical. This code expands to `a, b = {}.keys` when it really should be expanding to `a, b = {}.keys()` -- though fixing this causes the test to fail so I suspect something worse is going on here that I don't quite understand?" }, { "prediction": "I think this test should be `Assert.assertNotNull(\"location.value.long, should not be read\", projectedL1.get(\"long_r2\"));`", "reference": "Why did this need to change?" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "/go/pkg/mod/golang.org/x/xerrors@v0.0.0-20190410155217-1f06c39b4373/adaptor_go1_13.go:16:21: Frame not declared by package errors (from `typecheck`)" }, { "prediction": "I think this should be `ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader.ZkStateReader", "reference": "Probably doesn't go here because I think it's specific to the HTTP API layer. This class is too internal to declare such a name." }, { "prediction": "I'm not sure if this is the right place to test health status.", "reference": "in preparation of directly writing the /health endpoint one day.. we should have content checks." }, { "prediction": "I'm not sure if this is the right place for this error, but I'm not sure if it's the right place for this error.", "reference": "question (non-blocking): Is there a benefit from using `%q` instead of `%s`?" }, { "prediction": "I'm not sure why this is removed.", "reference": "I would suggest to keep two empty lines between functions in cpp files" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "This change causes the test to fail on both rocm-1.9.x and rocm-head." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `RuleViolationFixer` interface. I'm not sure if it's a good idea to have a `RuleViolationFixer` interface, but if it's a good idea to have a `RuleViolationFixer` interface, I'm not sure if it's a good idea to have a `RuleViolationFixer` interface. If it's a good idea to have a `RuleViolationFixer` interface, I'm not sure if it's a good idea to have a `RuleViolationFixer` interface. If it's a good idea to have a `RuleViolationFixer` interface, I think it's a good idea to have a `RuleViolationFixer` interface.", "reference": "I'd consider moving all fix related stuff to a distinct package to avoid contaminating the base package" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do it. I'm not sure if it's the right place to do this, but I'm not sure if it's the right place to do it, and if it's the right place to do it, it's the right place to do it.", "reference": "Use `os.path.join` for path concatenation." }, { "prediction": "I don't think this is needed anymore.", "reference": "Use upper case: YOLACTHead, YOLACTProtonet, YOLACTSegmHead" }, { "prediction": "I'm not sure if this is the right place for this change.", "reference": "The driver tests should be updated to use the concrete type instead of the driver directly; right now your test coverage of the concrete type is 0%." }, { "prediction": "I don't think we need to catch this exception.", "reference": "I would prefer the message to be more actionable. Like 'There should be no space between & and the variable name' or something similar." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "The image attribute is not supposed to be the text of the node. I'd rather keep it separate (the previous `@Text` attribute was fine). A practical reason for that is in the future, other languages may have a way to get the text of their node, in which case that wouldn't be fetched with `getImage`, for compatibility, but probably with a `getText` method, or `getSourceCode` like in #1728. Also we *may* deprecate or otherwise put `getImage` out of use as soon as 7.0, given its contract is super loose." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for it.", "reference": "The `[] +` seems weird to me. Why is it there?" }, { "prediction": "Line is too long. [89/80]
    Line is too long. [89/80]
    Line is too long. [89/80]
    Line is too long. [89/80]
    Line is too long. [89/80]
    Line is too long. [89/80]
    Line is too long. [89/80]
    Line is too long. [89/80]
    Metrics/LineLength: Line is too long. [89/80]
    Metrics/LineLength: Line is too long. [89/80]
    Metrics/LineLength: Line is too long. [89/80]
    Metrics/LineLength: Line is too long. [89/80]
    Metrics/LineLength: Line is too long. [89/80]
    Metrics/LineLength: Line is too long. [89/80]
    Metrics/LineLength: Line is too long. [89/80]
    Metrics/LineLength: Line is too long. [89/80]
    Metrics/Line is too long.", "reference": "Not sure if this constant is defined at the right place style-wise. Maybe move it up to before 'belongs_to' like DISCOUNT_TYPES in coupon.rb?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do it.", "reference": "What about a line with just spaces/tabs? Or a line with a couple spaces followed by a `#`?" }, { "prediction": "Line is too long. [89/80]", "reference": "if funder_is is not blank (L375) there is not need to check if org_id is not blank (L379) since you will never enter in the if (L374)." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Don't need this-> here." }, { "prediction": "I don't think we need to import `_metadata` from `google.cloud.forseti.common.util`", "reference": "I'm a little concerned about relying on a private module, as they could change the implementation at some point, I'd like to have some test to validate this is working as intended." }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it. I'm not sure if this is the right way to do it, but I'm not sure if it's the right way to do it, and if it's the right way to do it, I'm not sure if it's the right way to do it, but if it's the right way to do it, I'm not sure if it's the right way to do it, and if it's the right way to do it, it's the right way to do it, and if it's the right way to do it, it's the right way to do it, and if it's the right way to do it, it's the right way to do it, and if it's the right way to do it, it's the right way to do it, and if it's the right way to do it, it's the right way to do it.", "reference": "There might other values that we don't support here (eg. `[]`). So it might be safer to check for the supported types instead (string or number)." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "FYI, It won't have any benefit to move from trivial types." }, { "prediction": "I'm not sure if it''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''','''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''", "reference": "i missed these discussions- but ` \"secrets-ssm-environment-variables\"` is what was agreed upon with cp?" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "whats the difference between this package and `github.com/golang/protobuf`? or did vscode just decided this was the package it wanted to used?" }, { "prediction": "I don't think this is needed.", "reference": "Just asking: What does this line do? Does it add the stylesheet from the parent to the dialog?" }, { "prediction": "I'm not sure if this is needed.", "reference": "Including the scikit-learn dependency here would pull in scikit-learn for everyone who depends on Dagster. If you put it in the setup.py under docs_snippets, we'd avoid that problem (although I think it's already there)." }, { "prediction": "I'm not sure why this is removed.", "reference": "Why remove this?" }, { "prediction": "I'm not sure why this test was removed.", "reference": "Why remove this? It seems like we should keep this around as a regression test, unless we can guarantee this will never be called without a model set (does your new code guarantee that?)" }, { "prediction": "I don't think this is needed.", "reference": "Because this defaults to `{}` if `global._googlesitekitUserData?.permissions` is `false`-y, the checks below around `state.capabilities` always result in the `!! capabilities === true` path. This shouldn't have a default value of `{}` if there's the possibility that `global._googlesitekitUserData?.permissions` can be `undefined`/`false`/`null` legitimately." }, { "prediction": "I think this should be `log.ram_handler.change_log_capacity(capacity)`", "reference": "Please add a space after the comma here (generally, with arguments there's always a space after commas)." }, { "prediction": "I don't think this is needed anymore.", "reference": "From the context, should it say \"Flags defined in this class must be used with caution...\"?" }, { "prediction": "I don't think this is needed.", "reference": "We don't need this file, we can use the one that is in the grid-ui directory" }, { "prediction": "I don't think we need this.", "reference": "\"Exported key for account\"?" }, { "prediction": "I don't think this is needed.", "reference": "Normally we use Environment.NewLine unless you really want it to always be \\r\\n" }, { "prediction": "I don't think we should remove this method.", "reference": "why did you remove `verifyHeaders`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Thanks for cleaning up these deprecated calls" }, { "prediction": "I'm not sure if this is the correct error message, but I'm not sure if it's the right error message. I'm not sure if it's the right error message or if it's the right error message.", "reference": "@akarve this breaks error catching logic on the front end, I'll fix this. That's why I prefer to use some machine-friendly error codes that won't change frequently." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to change this to `resType == constants.ResourceTypeConfigmap || resType == constants.ResourceTypeSecret || resType == constants.ResourceTypeService || resType == constants.ResourceTypeEndpoints` or `resType == constants.ResourceTypeSecret || resType == constants.ResourceTypeService || resType == constants.ResourceTypeEndpoints` or `resType == constants.ResourceTypeSecret || resType == constants.ResourceTypeSecret || resType == constants.ResourceTypeService` or `resType == constants.ResourceTypeSecret || resType == constants.ResourceTypeEndpoints` or `resType == constants.ResourceTypeSecret || resType == constants.ResourceTypeService` or `resType == constants.ResourceTypeSecret || resType == constants.ResourceTypeSecret || resType == constants.ResourceTypeEndpoints` or `resType == constants.ResourceTypeSecret || resType == constants.ResourceTypeService` or `resType == constants.ResourceTypeSecret || resType == constants.ResourceTypeSecret || resType == constants.ResourceTypeEndpoints`", "reference": "We support process remoteQuery for Service. Why are we removing it?" }, { "prediction": "I don't think this is the right place to do this.", "reference": "This is specifically for testing?" }, { "prediction": "I think we should remove the `getStatistics` method from the `AbstractAdmin` class.", "reference": "I think this is related to the social stats and probably does not need to be removed." }, { "prediction": "I'm not sure if this is the right place to disable eslint-disable jsdoc/require-description-complete-sentence. I'm not sure if this is the right place to disable it.", "reference": "Yep, jsdoc again.. It seems that when the plugin description is wrapped within `eslint-disable/enable` expression it's not generated at all. After adding the `@class AutoColumnSize` tag right after the `@plugin` tag the plugin appears in the docs. Please review the other plugins." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This usage of the result doesn't look quite right. I would not expect the first page of values to be empty if there were multiple pages of results. This also obscures the error case when no values are returned (handled in the next `if` block) by returning a more generic error from the Azure SDK from `result.NextWithContext()`." }, { "prediction": "I'm not sure if this is the right place to get address details.", "reference": "unknown field AddressDetails in struct literal (from `typecheck`)" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Just noticed, are we specifically missing the addition of `SharedConfigState: session.SharedConfigEnable`?" }, { "prediction": "I think this should be `if (oldTimeIntensities!= null && oldTimeIntensities.NumPoints > 0) {`", "reference": "Not sure what this is. Bad merge?" }, { "prediction": "I don't think we need to lock the `acc.mu.Lock()`?", "reference": "I think this may be a RW lock." }, { "prediction": "I'm not sure if this is the right place to import helpers. I'm not sure if it's the right place to import helpers.", "reference": "Perhaps we should tuck this away into a dedicated subdir and name it `config` or something similar? Or maybe it would be happy living in `common`?" }, { "prediction": "I don't think we need to learn it. I think we need to learn it before sending them the recipe.", "reference": "Doing a select query inside of a loop like this is not ideal. We should fetch recipes once and then loop through it in memory to perform this check" }, { "prediction": "I think this should be `copy=True`", "reference": "too long here. (104 > 100)" }, { "prediction": "I don't think we need to catch the exception here.", "reference": "Use TryGetValue instead of catching exception" }, { "prediction": "I'm not sure if this is the right place to test this, but I'm not sure if it's the right place to test this.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I think this method should be either: - a static method of `RTPSWriter` to avoid a StatelessWriter redefinition of the function. - a setter in the `CacheChange_t` struct." }, { "prediction": "I'm not sure if we should do that here, but I'm not sure if we should do that here. I'm not sure if we should do that here.", "reference": "You add a stream back reference for trailers, and all of the sudden we have tight coupling!" }, { "prediction": "I don't think this is needed anymore.", "reference": "I don't think we use `AspNetAmbientContext` anymore since. We can probably delete this file." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "Please avoid committing build artifacts, as they produce unnecessary conflicts and noise." }, { "prediction": "I'm not sure if this is the right place to use `__call__` or `__call__` here. I'm not sure if `__call__` is the right place to use `__call__` or `__call__` here.", "reference": "this is vendored code so i would hesitate to make random changes to it" }, { "prediction": "I don't think this is needed.", "reference": "We are using a different style for JSON tags. `ethAddress` - camalCase `referral_code` - snake_case" }, { "prediction": "I don't think we need to change this to `HttpContextIntegration.DefaultHttpContextTypeName`", "reference": "Should this be `\"Microsoft.AspNetCore.Http.DefaultHttpContext\"`?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "removed asserts from `Vector` as it's stable enough and it may hinder inlining, even if turned off :/" }, { "prediction": "I'm not sure if this is the right place to do this. I think it would be better to have `message.msgid` and `message.msg_type` in the `MessageDefinitionStore` class. I think it would be better to have `message.msg_type` and `message.msg_type` in the `MessageDefinitionStore` class.", "reference": "Do we want to raise on the function or on the decorator?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "How complex is to to replace `album_*` with `release_*` everywhere in the `Listen` class and places that use it?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea.", "reference": "You haven't changed any of the callers of `.Add` to check the return value, so we're now ignoring duplicates. Please fix that." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `getNodeFromTree` or `getNodeFromTree` here.", "reference": "@straker should this not push to `vnode._cache.isHiddenWithCSS`?" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for it.", "reference": "\"an interface\" in conceptual sense vs \"interfaces\" or \"set of interfaces\", referring to the Go interfaces - database/sql uses the latter, should we?" }, { "prediction": "I don't think we need to check the status.getReason() == DownloadError.ERROR_IO_ERROR or the status.getReason() == DownloadError.ERROR_CONNECTION_ERROR", "reference": "This now checks nearly all errors that can occur. How about explicitly listing cases where we want it to retry? I think there are not many cases where we want that, as the many added conditions in the last years show :)" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `doSync` flag, but if it's a good idea to have a `doSync` flag, I'm not sure if it's a good idea to have a `doSync` flag. If it's a good idea to have a `doSync` flag, I'm not sure if it's a good idea to have a `doSync` flag, but if it's a good idea to have a `doSync` flag, I'm not sure if it's a good idea to have a `doSync` flag. If it's a good idea to have a `doSync` flag, I'm not sure if it's a good idea to have a `doSync` flag, but if it's a good idea to have a `doSync` flag, I think it's a good idea to have a `doSync` flag.", "reference": "Can you make this accept an action instead?" }, { "prediction": "I'm not sure if this is the right place to do this, but I think it's better to add a `description: \"test desc\", product: product)` to the `create(:download, download_file_name: \"test.txt\", description: \"test desc\", product: product)`", "reference": "Tab inconsistency here (3 spaces instead of 2 spaces)" }, { "prediction": "I don't think we need to change this. I'm not sure if we need to change this.", "reference": "these change means we are changing epoch to 1 hour?" }, { "prediction": "I don't think this is needed.", "reference": "Why this is defined in the middle of imports?" }, { "prediction": "I'm not sure if this is the right place to import it.", "reference": "Could you move this to the original position?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Is there a test that'd have caught this?" }, { "prediction": "I'm not sure if this is the right place for this test.", "reference": "ListWorkflowExecutionsRequest <- this can be nil?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Do we need to continue to support the old link, or is it dead dead dead?" }, { "prediction": "I don't think this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "Do we need `ConcurrentDictionary`? `Dictionary` can be safely read from multiple threads. See `GlobalTags`." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "this seems like more of a Debugf statement" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "We're capturing cb_state non-const, but the function is const so, safe enough, but after going to reader/writer locks we're all going to have to key a careful eye on anything in this pattern." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this.", "reference": "Probably want to wrap the endpoint discovery work that follows in this `if` statement instead of returning early. This will make it easier to add additional request code generation logic in the future. e.g. if we add any code generation after the endpoint discovery block this check will cause it to be skipped." }, { "prediction": "I'm not sure if this is the correct behavior. I'm not sure if this is the correct behavior, but I'm not sure if it's the correct behavior.", "reference": "This test was giving a false positive because my change caused it to throw a different error that contained `createElement` when it should've been throwing this error. Caught this by looking at the code coverage and noticing that the line under the condition I changed was no longer covered lol." }, { "prediction": "I'm not sure if this is the right place to call this function.", "reference": "I think this is added to wrong file. You wanted to add to cmd/agent/, right?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it.", "reference": "Each `ExpectedCondition` implements `java.util.Function` These are expected to be stateless. This condition will leak previous `elementText` on the second usage, which doesn't seem ideal." }, { "prediction": "I think this should be `DeviceID`", "reference": "Could we consider a more explicit name, like `devicePciAddress`?" }, { "prediction": "I think this should be `if (!execName.endsWith(\".exe\")) { pattern.append(\"(\\\\.exe)?\"); } else { pattern.append(\"(\\\\.exe)?\"); }`", "reference": "Why change this from a foreach? I can't see it gaining anything here and code styles shouldn't change just for the sake of it." }, { "prediction": "I think this should be `$response = $this->_sendRawGet($solrconfigXmlUrl);`", "reference": "Is this supposed to be part of this PR?" }, { "prediction": "I'm not sure if this is a good idea. I think it's better to use `isHidden` instead of `isHidden`.", "reference": "DRY, worth extracting this method to axe.utils" }, { "prediction": "I don't think we need this.", "reference": "I think there's another spot for this in DefaultCapabilityMatcher" }, { "prediction": "I'm not sure if this is the right place to do this, but I think it's better to use `os.path.join(self._configfile, 'key-config.txt')` instead of `os.path.join(self._configfile, 'key-config.txt')` and then use `os.path.join(self._configfile, 'key-config.txt')` in `os.path.join(self._configfile, 'key-config.txt')` and then use `os.path.join(self._configfile, 'key-config.txt')` in `os.path.join(self._configfile, 'key-config.txt')` and then use `os.path.join(self._configfile, 'key-config.txt')` in `os.path.join(self._configfile, 'key-config.txt')` in `os.path.join(self._configfile, 'key-config.txt')`", "reference": "`QtOSError` inherits `OSError`, so I don't think it's needed to list them both here." }, { "prediction": "I'm not sure why this was removed.", "reference": "Instead of patching vendor, let's update the version of sdk-go to a more recent one that doesn't have this line." }, { "prediction": "I'm not sure if this is the right place to set this.", "reference": "Don't think this should be here. The default is set somewhere else." }, { "prediction": "I'm not sure if this is the right place to stop the test. I'm not sure if it's the right place to stop the test, but if it's the right place to stop the test, then it's the right place to stop the test.", "reference": "Not really important in this PR, but does BlazeMeter describe \"progress\" values anywhere? It might be nice to have a set of constants like `PROGRESS_DOWNLOADING_IMAGE`, `PROGRESS_BOOTING`, `PROGRESS_RUNNING_TEST`, etc in our BZA client." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "nit: `

    ` after the line" }, { "prediction": "I think this should be `libArm64/*.exe` or `libArm64/*.ttf`", "reference": "Should we include the files with otf extension here, too? If not, I wonder why we do allow them in the source but we don't include them as per the setup" }, { "prediction": "I'm not sure why this was removed.", "reference": "i think it's OK to leave this?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Does this need to be public? The only reference to `FlinkTypeVisitor` that I see in this PR is here, so I'm not sure why this is needed." }, { "prediction": "I don't think we need to change this.", "reference": "No line at end of file warning" }, { "prediction": "I don't think this is needed.", "reference": "This looks unused, shouldn't it point to inner processor in any way?" }, { "prediction": "I'm not sure why this was removed.", "reference": "There may be a few isolated cases where the FirstN node is added during preCodeGen. Please see GenPreCode.cpp RelRoot::preCodeGen(). The example given there about Order by where sort is added in optimizer, or a FirstN where the N value is to be specified with a param seem to be cases where we would add the FirstN later. Will current change cause such views to marked as updateable? This is minor and could be resolved later, if any change is necessary." }, { "prediction": "I think this should be `String.format(method.getSimpleName(), method.getNickname(), method.getSimpleName())`", "reference": "I think you should compose the %sClient part using the Name class, and then do the remaining composition with plain concatenation. Side question: why does the return type name look like it is a client type name?" }, { "prediction": "I don't think this is needed.", "reference": "All stories in this file also need the default padding." }, { "prediction": "I don't think this is needed.", "reference": "Curious - what would be the actual value?" }, { "prediction": "I don't think we need to change this. I think we need to change this to `get_git_hash()[:7]`", "reference": "Is it necessary to record the palette in the checkpoint? Any reason?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Not sure how to best do this without creating a new connection to the server everytime. Do this in another thread?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to test this.", "reference": "should we have a similar test for gsa18f procurements?" }, { "prediction": "I'm not sure this is the right place for this change.", "reference": "change `v.recipient` to address.Address, so can use `AccountState(v,recipient)`" }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "Open to doing away with this altogether and maybe injecting this logic somehow into `requires_approval_notice?` in LinearDispatcher." }, { "prediction": "I'm not sure if this should be `true` or `false` or `true` or `false` or `false` or `true` or `false` or `false` or `true` or `false` or `true` or `false` or `false` or `true` or `false` or `true` or `false` or `false` or `true`` or `false` or `true`` or `false` or `false` or `true`` or `false` or `false``?", "reference": "remove this and always enable tracer, just set the default timeout to something higher (20 seconds)" }, { "prediction": "I'm not sure if this is the right place to put this icon.", "reference": "Can we give this field a more descriptive name? When I use a variable named `icon` I normally expect an `Image` object." }, { "prediction": "I'm not sure if this should be a `Filter` command, but it's a `Filter` command, so I'm not sure if it should be a `Filter` command, or if it's a `Filter` command, or if it's a `Filter` command, or if it's a `Filter` command, or if it's a `Filter` command, or if it's a `Filter` command, or if it's a `Filter` command, or if it's a `Filter` command, or if it's a `Filter` command, or if it's a `Filter` command, or if it's a `Filter` command, or if it's a `Filter` command, or if it's a `Filter` command, or if it's a `Filter` command, or if it's a `Filter` command, or if it's a `Filter` command, or if it's a `Filter` command, or if it's a `Filter` command, or if it's a `Filter` command, it's a `Filter` command, or if it's a `", "reference": "can't these just use the global `include` and `exclude` flags?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Is this still necessary?" }, { "prediction": "I'm not sure if we should change this to `http://localhost:port/` or `http://localhost:port/`", "reference": "Interesting! Happen to catch an exception message or anything I can look into?" }, { "prediction": "I'm not sure why this was removed.", "reference": "did this get moved to mpromise? I don't recall if it's in that lib or not." }, { "prediction": "I'm not sure if this should be `Ports []int` or `Ports []int`", "reference": "json objects should be `camelCase`" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `SectorSize` variable. I'm not sure if it's a good idea to have a `SectorSize` variable. If it's a good idea to have a `SectorSize` variable, I'm not sure if it's a good idea to have a `SectorSize` variable. If it's a good idea to have a `SectorSize` variable, I'm not sure if it's a good idea to have a `SectorSize` variable. If it's a good idea to have a `SectorSize` variable, I'm not sure if it's a good idea to have a `SectorSize` variable. If it's a good idea to have a `SectorSize` variable, I'm not sure if it's a good idea to have a `SectorSize` variable. If it's a good idea to have a `SectorSize` variable, I'm not sure if it's a good idea to have a `SectorSize` variable. If it's", "reference": "QuarterGiBSectorSize? SectorSize265MiB? Spelling out 256 seems overly verbose." }, { "prediction": "I don't think this is needed anymore.", "reference": "Maybe with this change we can remove `using OpenTelemetry.Logs`." }, { "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to move this logic to a separate function.", "reference": "Fix this name too." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "why this is an issue?" }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it. I'm not sure if this is the right way to do it, but I'm not sure if it's the right way to do it, and if it's the right way to do it, I'm not sure if it's the right way to do it.", "reference": "The condition should be inverse?" }, { "prediction": "I don't think we need to change this?", "reference": "this seems to be a property key name, so should it be a inside configurationkey.java?" }, { "prediction": "I think this should be `bin.ZFS` or `bin.BASH`", "reference": "G204: Subprocess launching should be audited (from `gosec`)" }, { "prediction": "I think this should be `@property`.", "reference": "Please add docs here. And also warn users that this mode should be avoided whenever possible, because any blocking IO will make the keep-alive-thread not run." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `Object.keys( dimensionFilters ).every( ( dimension ) => typeof dimensionFilters[ dimension ] ==='string' )` or `Object.keys( dimensionFilters ).every( ( dimension ) => typeof dimensionFilters[ dimension ] ==='string' )` or `Object.keys( dimensionFilters ).every( ( dimension ) => typeof dimensionFilters[ dimension ] ==='string' )`", "reference": "We shouldn't require dimension values to be a string. They just need to be scalar values (probably we could check whether it's either a string or a number). Something more important to cover in the validation here though is to ensure that a map of `dimensionName => dimensionValue` is passed. The keys here actually need to be strings. For example someone shouldn't be able to pass an array of values." }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "let's do a pointer cast of nil, similar to the `MapRouter` above" }, { "prediction": "I don't think we should add this action to the `SettingsManager::get_instance()->add()` method.", "reference": "action should use a prefix of `hfg` rather than `neve` as we plan to bootstrap this as a standalone library. Moreover, previously filter/actions used in this library was using the same pattern." }, { "prediction": "I don't think this is needed.", "reference": "I'm halfway tempted to disable this for all https connections. Do you know of any clients that actually renegotiate for any reason?" }, { "prediction": "I don't think we need to change this class.", "reference": "shouldn't **call** return a boolean?" }, { "prediction": "I don't think we need this PR.", "reference": "I don't think you need the blank import here. This one uses awsdynamodb directly." }, { "prediction": "I don't think this is used.", "reference": "I think this should be initialized to `null` instead of a predicate. There is no need to run an extra predicate (with an extra method dispatch for each row in a data file. That's a tight loop so we should do more work here to avoid it. Instead of using `isDeleted.or`, this should test whether `isDeleted` is `null` and either initialize `isDeleted` or call `isDeleted.or`." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "What is this and the next entry in config_handler used for?" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if it's the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "will your editor integrate `gofmt`, `goimports`, etc...?" }, { "prediction": "I think we should check if intent is null or not. I don't think we need to check if intent is null or not.", "reference": "looks like the code is not properly formatted. for example here are some missing spaces in **if** command. please take care and reformat the code using default android formatting." }, { "prediction": "I think this should be `--bug-path-length` instead of `--bug-path-length`", "reference": "Please add some valid examples to help message like `\"4:10\"`, `\"4:\"`, `\":10\"`" }, { "prediction": "I'm not sure if this is the right place to test this, but I'm not sure if it's the right place to test this.", "reference": "Is it only Symbols we're worried about converting? Is it not safe to just call `to_s` anyway?" }, { "prediction": "I think we should remove this test. I don't think we need it anymore.", "reference": "Note for those who come across this later: It was moved to `testhelpers.mining.go` so that `testhelpers.NewDaemon` and the `mining/worker_test.go` can share it." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "What about `sort_by(&:in_progress?)`? Maybe with a `.reverse` thrown in?" }, { "prediction": "I'm not sure if this is a breaking change.", "reference": "Flag is removed because it is only gRPC now." }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if this is the right place to do this.", "reference": "Might be better to rephrase to: Please refer to the ``init scenario`` command in order to generate a custom ``molecule`` scenario. Since you aren't customizing the default scenario since it already exists, right?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `write_text` or `write_text` here. I'm not sure if it's a good idea to use `write_text` or `write_text` here. I'm not sure if it's a good idea to use `write_text` or `write_text` here. I'm not sure if it's a good idea to use `write_text` or `write_text` in the future, but if it's a good idea to use `write_text` or `write_text` in the future, I'm not sure if it's a good idea to use `write_text` or `write_text` in the future.", "reference": "Shall we merge these `if` for `path lib` and then do the `attrname` one. I'm trying to count `if`-calls and its getting late but I think we can reduce the number checks needed to get into L648 from 3 to 2 if you understand what I mean" }, { "prediction": "I don't think this is needed.", "reference": "why depend on recovery???" }, { "prediction": "I'm not sure if this is the right place to close the done channel.", "reference": "the done channel only aims to be closed, so `chan struct{}` is better then `chan interface{}`" }, { "prediction": "I'm not sure if this is the correct error.", "reference": "Do you mean to have gas_oracle changes in this PR?" }, { "prediction": "I don't think we need to add this to the `flash_msg.html.erb` file.", "reference": "Is this effectively requiring browsers support javascript?" }, { "prediction": "I don't think we need to do this. I think we should do this in a separate PR.", "reference": "Lowercase `boolean` - use the primitive type." }, { "prediction": "I don't think we need to check if blob exists before calling CheckIfBlobExists.", "reference": "This isn't the correct logic. if allowOverride == true and!blobExists then upload. Just don't do the exist check if allowOverride is set to true." }, { "prediction": "I'm not sure if this is the right fix, but I'm not sure if it's the right fix or if it's the right fix or if it's the right fix, or if it's the right fix, I'm not sure.", "reference": "Can you replace these by `else if` please?" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if it's the best way to do this.", "reference": "Would be nice if the field had a unique class name that could be used to target it, instead of `fromRange` But doesn't seem to be a common thing in the code base." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Does this code fit on one line under 80 characters? It would be more consistent with our existing style." }, { "prediction": "I don't think this is needed.", "reference": "Not a requirement here. But i see a change in naming convention. We can rename the function to `CstorSparsePoolArtifactsFor070`." }, { "prediction": "I don't think this is needed.", "reference": "Why do you configure the UART like this? It's already configured by default." }, { "prediction": "I don't think this is needed.", "reference": "Wow. Good catch. \"This `#include` was brought to you by the department of redundancy department.\" ;)" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "Well it's actually calling `AuthorizeOrder` and this seems like a DebugLevel message to me, maybe it should be dropped entirely." }, { "prediction": "I think this should be `(ptr == nullptr) || (bytes == 0)) return;`", "reference": "Should this be using the `CUDA_SAFE_CALL` macro here?" }, { "prediction": "I'm not sure if this is the correct behavior.", "reference": "What cases do you see as being valid for not having any tests to run? If a test project doesn't have any tests to run we should avoid running it at the project level." }, { "prediction": "I'm not sure if this is the right place to unlock mirrors.", "reference": "and is it possible that mset.mirror.msgs be nil? because if so, then you would get a panic also because of that." }, { "prediction": "I think this should be `pixman_region32_copy(&state->opaque, &next->opaque);`", "reference": "`next->opaque` should not be cleared." }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do here.", "reference": "already what? I know what, but seems like smth. is missing in this sentence" }, { "prediction": "I don't think this is needed anymore.", "reference": "Can you put spaces after the `{`and before the `}`" }, { "prediction": "I'm not sure if this is the right place to import this file.", "reference": "We said we would put `[ ]` around the version. `[forseti-security] [v2.3.0]`" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Seems len(cnb[0]) will be the length after the write since of the *v thing we saw no?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `QueueLoad` method that returns a `QueueLoad` object. I'm not sure if it's a good idea to have a `QueueLoad` method that returns a `QueueLoad` object. If it's a good idea to have a `QueueLoad` method that returns a `QueueLoad` object, then I think it's a good idea to have a `QueueLoad` method that returns a `QueueLoad` object. If it's a good idea to have a `QueueLoad` method that returns a `QueueLoad` object, then I think it's a good idea to have a `QueueLoad` method that returns a `QueueLoad` object.", "reference": "can we make use of storagepoolclaim type rather than the generic interface{} type?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this. I'm not sure if this is the right place to do this, but if it's the right place to do this, I'm not sure if it's the right place to do this.", "reference": "this should happen before the `go k.manage()`, otherwise the node will always try the bootnodes first" }, { "prediction": "I think this should be `/(?=[^\\\\]%[nbs])/` instead of `/(?=[^\\\\]%[nbs])/`", "reference": "Is this actually a lint related change?" }, { "prediction": "I'm not sure if this autoload is used anywhere.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `opt_nonempty_str_param` function. If it's a good idea to have a `opt_nonempty_str_param` function, I'm not sure if it's a good idea to have a `opt_nonempty_str_param` function. If it's a good idea to have a `opt_nonempty_str_param` function, I'm not sure if it's a good idea to have a `opt_nonempty_str_param` function. If it's a good idea to have a `opt_nonempty_str_param` function, I'm not sure if it's a good idea to have a `opt_nonempty_str_param` function. If it's a good idea to have a `opt_nonempty_str_param` function, I'm not sure if it's a good idea to have a `opt_nonempty_str_param` function. If it's a good idea to have a `opt_nonempty_str_param`", "reference": "what does this do that str_param does not?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have this function return a string, or if it's a good idea to have it return a string.", "reference": "For GCP we included the API name (see below) so you can distinguish between uses other than `blob` once they exist, WDYT?" }, { "prediction": "I don't think this is needed.", "reference": "what would you think about doing this include on-demand within S3ObjectStore methods and then failing in a loud way?" }, { "prediction": "I think this should be `if (stopped) { break; } else { break; }`", "reference": "May be better make `stopped` atomic, then it can be just `for (auto i (node.store.latest_begin (transaction_a, next_frontier_account)), n (node.store.latest_end ()); i!= n && &&!stopped && elections_count < max_elections; ++i)`" }, { "prediction": "I don't think this is needed anymore.", "reference": "In `src/storage/InternalStorageServiceHandler.h ` file, the client in `client->future_chainAddEdges ` should be InterStorageServiceAsyncClient?" }, { "prediction": "I'm not sure if it''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''", "reference": "`go.sum` needs to be updated for this. Please run `go mod tidy`" }, { "prediction": "I think this should be `SecretBackendSecretsManager`", "reference": "Not sure if this was discussed previously, but is there a specific use case in mind for having this as an API field rather than a configuration option on the controller manager? Is there a specific use case in mind where one would want to choose different backends for individual Clusters/Machines vs having it a global configuration for an instance of the infrastructure provider?" }, { "prediction": "I don't think we need this anymore.", "reference": "Same thing with the OtlpExporter" }, { "prediction": "I'm not sure why this is removed.", "reference": "Should not be removed." }, { "prediction": "I don't think we need this anymore.", "reference": "Not a blocker for anything, but should this be moved to beaker-pe? Is that ticketed anywhere?" }, { "prediction": "I'm not sure if this is the right place to call `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit()` or `submit", "reference": "this shouldn't be beforeClickOn, but rather beforeSubmit? and added to WebDriverEventListener. Since submit does not synthesize the 'click' events, this isn't accurate." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "this ternary operator is hiding an `if/else` within an `if/else` - any chance we could move the logic ELSEwhere? (see what I did there --?? :100: )" }, { "prediction": "I don't think this is needed anymore.", "reference": "Is this really internal? Or will the API be different in PMD 7.0.0? Well, the interface doesn't offer much functionality anyway..." }, { "prediction": "I'm not sure if this should be `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi` or `multi`` or `multi` or `multi`` or `multi` or `multi`` or `multi` or `multi`` or `multi` or `multi`` or `multi` or `multi`` or `multi` or `multi` or `multi`` or `multi` or `multi` or `multi`` or `multi` or `multi`` or `multi` or `multi`` or `multi` or `multi`` or `multi` or `multi`` or `multi` or `multi`` or `multi`` or", "reference": "Does it have to be arrays? Isn't it ragged 'data' (i.e multiple elements of different lengths)?" }, { "prediction": "I think this should be `true` instead of `true`.", "reference": "Per my understanding, this flag only impacts \"NoCleanup\" disk. If so, we may name it more clear. The reason of this ask is because I plan to add some other flag to force cleanup for other non-NoCleanup disks." }, { "prediction": "I don't think this class is used anymore.", "reference": "In my changes for `RequiresDistributionAndOrdering`, this class went away and is replaced by an inner class. I think that pattern worked well. Maybe we could do that before this one to reduce the number of changes here." }, { "prediction": "I'm not sure if it''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''", "reference": "Shouldn't this be called `hp` instead of `life`?" }, { "prediction": "I don't think we need to change this.", "reference": "Because the default value of allowedOrigins is * (all origins), so it isn't necessary to set again at all." }, { "prediction": "I'm not sure if this is the right place to remove the `reloadType` parameter.", "reference": "Undo this modification" }, { "prediction": "I'm not sure if this is a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug.", "reference": "Please check my thoughts here... I changed the test to not `ToString()` attribute values. This was important to test things when `net.peer.port` was both an int or a string, but I was unsure if Zipkin supported non-string attributes." }, { "prediction": "I don't think we need this.", "reference": "Looks like you made changes on `CameraResultType` class, but didn't commit them. And you also have to do the changes on the types in @capacitor/core" }, { "prediction": "I don't think this is needed anymore.", "reference": "Can you explain the history of the bug a bit, and why this fixes it?" }, { "prediction": "I'm not sure if this is the right place to put this method. I'm not sure if it's the right place to put it.", "reference": "What do you think about `mentor_mail_to` or `mentor_mail_to_link` in order to match Rails' `mail_to` method, which is what this calls? I'm not sure about this suggestion..." }, { "prediction": "I don't think we need to change this line.", "reference": "Looks like this will make the check in every loop. Consider extracting the null check." }, { "prediction": "I'm not sure if this is the right place to test this.", "reference": "Maybe `it \"can safely be reset when there are not yet any shared example groups\"`? That's the edge case that wasn't working, right?" }, { "prediction": "I don't think this is needed anymore.", "reference": "naming: please use `asmfactory`" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "FYI you could use a raw string for this which removes the need for escaping the inner quotes." }, { "prediction": "I'm not sure if this is the right place to test this, but I'm not sure if it's the right place to test this.", "reference": "2 blank lines here (between functions)" }, { "prediction": "I think we should move this method to the `RewriteFiles` class.", "reference": "Nit: we try to avoid whitespace changes because they can easily cause unnecessary commit conflicts." }, { "prediction": "I don't think we need to do this. The `$offset - $end_pos === 2 && substr($file_contents, $end_pos, 2) === '::'` should be `$offset - $end_pos === 2 && substr($file_contents, $end_pos, 2) === '::'`", "reference": "As mentioned below, I'm not sure why this is only allowing refs that are tagged with `*` at the start!" }, { "prediction": "I think this method should be renamed to `equals(Object o)`", "reference": "Don't forget the {} symbols, and please use EqualsBuilder and HashcodeBuilder as possible" }, { "prediction": "I'm not sure if this is the right place for this test, but I'm not sure if it's the right place for this test.", "reference": "Allocate buffer once outside loop." }, { "prediction": "I'm not sure if this is the right place for this test. I'm not sure if this is the right place for this test.", "reference": "It would be better to check that system.nodes[1]->network.port is somewhere in the target without specifying its exact position. But it is a very minor point and I have no string opinion on it just thought I'd mention it because our tests in general have too implementation detail." }, { "prediction": "I don't think this is the right thing to do, but I think it's a good idea to have these conditionals in the `access.api.exception.metadata.not.available.for.nontabular.file` file.", "reference": "Should this be in a bundle?" }, { "prediction": "I think this should be `Debug.Assert(Activity.Current == null || Activity.Current == activity, \"There was an unexpected active Activity on the result thread.\");`", "reference": "When Activity is lost (more precisely, ExecutionContext is lost) in the HttpModule we restore the root (HttpIn) Activity. That makes this assert invalid. I tried to fix the HttpModule so that it restores the Activity that was last running, but it is impossible to retrieve do to the way ExecutionContext works. It isn't an issue to remove the assert, but it is unnerving. Any instrumentation running in IIS reliant on Activity.Current could run into trouble." }, { "prediction": "I'm not sure if this is the right place to register handlers. I'm not sure if it's the right place to register handlers, but if it's the right place to register handlers, then it's the right place to register handlers. I'm not sure if this is the right place to register handlers, but if it's the right place to register handlers, then it's the right place to register handlers. If it's the right place to register handlers, then it's the right place to register handlers. If it's the right place to register handlers, then it's the right place to register handlers. If it's the right place to register handlers, then it's the right place to register handlers. If it's the right place to register handlers, then it's the right place to register handlers. If it's the right place to register handlers, then it's the right place to register handlers.", "reference": "what was the point in moving handlers registration into a separate method?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "At this point we probably want to ensure there's a store command set." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "This code is way too complicated for what it does. I don't want to be a PITA, but what can you consider rewriting it in a simpler way? I'm talking about the whole `_getDerivationIndexes` function" }, { "prediction": "I don't think we need to check for hex here.", "reference": "Don't throw base exception, specify more precise type" }, { "prediction": "I don't think we need to cast `inputs` to `dst_type`.", "reference": "Recursive -> Recursively converted -> convert" }, { "prediction": "I don't think we need to change this.", "reference": "why is this object API only? I think the reason why we didn't do this before was because this code was shared with Java which doesn't have value structs." }, { "prediction": "I think this should be `DockerVersion: \"+dockerVersion\"`", "reference": "just to confirm, so backend will deal with both old format and new format?" }, { "prediction": "I don't think this is needed.", "reference": "huh, look at that, I wasn't aware you could constrain a type by Enum" }, { "prediction": "I don't think this is needed.", "reference": "Even though the debug parameter is effectively ignored, should this default to `false` instead of `true`?" }, { "prediction": "I don't think this is needed.", "reference": "What is the purpose of this interface? Unlike ParamDocView, it doesn't seem to be used anywhere to enable polymorphism" }, { "prediction": "I don't think we need this?", "reference": "We added a library to generate a UUID for the request_id directive \"github.com/nu7hatch/gouuid\" can we uses the same one for what you want rather than add another dependency? Or if the google one is better can we remove the nu7hatch library?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Shouldn't this be `i * Interval`? You're multiplying nanos with a Duration, I'm not sure what's the result :)" }, { "prediction": "I think this should be `set_protection(guard, PAGE_SIZE, MEMPROT_READ);`", "reference": "I guess it's not no-access to match Windows where guard pages are readable." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Not a blocker, but would probably be useful to have a `scope :non_pending_approvers` on the `Proposal` model." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Add trailing comma" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "I see someone say SIGKILL can not be caught by process. The original code here about `SIGKILL` is useless?" }, { "prediction": "I don't think we need to change this.", "reference": "As it is a mobile only theme, please make sure the option appears only on mobile" }, { "prediction": "I think this should be `parse_param_list(params)`", "reference": "Would like a docstring and type annotations here" }, { "prediction": "I'm not sure if this is the right place to store the shard key fields. I'm not sure if this is the right place to store the shard key fields. I'm not sure if this is the right place to store the shard key fields, or if it's the right place to store the shard key fields. I'm not sure if it's the right place to store the shard key fields, but if it's the right place to store the shard key fields, I'm not sure if it's the right place to store the shard key fields.", "reference": "This is an API change. Why was it made?" }, { "prediction": "I don't think this is needed.", "reference": "Please move using inside namespace." }, { "prediction": "Is poSEnabled set to false?", "reference": "shall we create some enum flags for setasmain shouldprocess and pos?" }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do.", "reference": "Should this `PUPPET_AGENT_STARTUP_MODE` have a corresponding yardoc change?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Why not simply remove the `pytest` import now that it's not needed anymore? :wink:" }, { "prediction": "I don't think this is needed.", "reference": "Yeah, not filled in yet." }, { "prediction": "I don't think this is needed.", "reference": "don't use style. Use a class instead. reducing `col-xs-12` down to 8 or 6 or whatever should do the trick" }, { "prediction": "I don't think we need to reload cache if table is null.", "reference": "should we also do `reloadCache` when database is null?" }, { "prediction": "I don't think we need to create a new ROMol object.", "reference": "Why not just return QueryMol directly? Why require the copy?" }, { "prediction": "I think this should be `os.path.join(os.path.dirname(__file__), '../../', fname )`", "reference": "Could you add a docstring?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "looks like you added newlines after blocks in a few files - I generally like newlines before/after multi-line blocks _except_ when the end the block is directly nested inside another block (eg: two `end`s next to each other) what do you think?" }, { "prediction": "I don't think we need this anymore.", "reference": "@jlerbsc's fix in #2918 in action - thanks! :smiling_face_with_three_hearts:" }, { "prediction": "I'm not sure if this should be `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None`` or `None` or `None` or `None` or `None` or `None`` or `None` or `None`` or `None` or `None` or `None`` or `None` or `None` or `None` or `None` or `None`` or `None`` or `None`` or `None`` or `None```````````````None````````None```````None``````None`````None`````None`````None````None````None````None````None````None````None````None````None````None````None````None````None````None`", "reference": "nitpick: Please lower-case `Zero_count` (as it's a literal argument name) and `Argument` here." }, { "prediction": "I don't think we need to change the name of the issuer.", "reference": "change the name of the function to match its functionality? account IsIssuing?" }, { "prediction": "I don't think this is needed.", "reference": "for later: add docstring (can just copy paste Pandas')" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "nit: @sonofachamp pointed out to me that the idiomatic way is \"archermocks\" (lowercase for package names)" }, { "prediction": "I don't think this is needed anymore.", "reference": "Ugh I'm stupid, can you change this to `yarpc.InternalErrorf`?" }, { "prediction": "I think this should be `table.name() + \".all_data_files\"`", "reference": "We instantiate some metadata tables in tests so I kept the old constructor too. Won't harm if someone is using it directly too." }, { "prediction": "I don't think this is the right place to do this.", "reference": "I think the better place to put this might be `lib/options/PopulateOptions.js`. That should make it easier - checking options in `populate()` can get confusing." }, { "prediction": "I don't think we need to pass `params` to `PingProvider`.", "reference": "Lets have simple function arguments here, because now struct `traversal.Params` started to have 2 purposes: 1. used as contract in DTO between consumer-provider 2. as function parameters for internal code calls" }, { "prediction": "I think this test should be `RemoteDistributorTest` instead of `RemoteDistributorTest`.", "reference": "Probably best not to have an empty test...." }, { "prediction": "I don't think we need this image.", "reference": "`image_tag` in the `testimonials` files?" }, { "prediction": "I think this should be `\"WHERE execution_id=?\"`", "reference": "I believe flow.toObject() method is throwing NPE if SLA option list (i.e. this.executionOptions.getSlaOptions()) is null or one of the value in the list (i.e. this.executionOptions.getSlaOptions()) is null. If that is the case we could fix root cause of NPE in the ExecutableFlow.toObject() method. The corresponding code to populate SLA options can be modified as follows. final List> slaOptions = Optional.ofNullable(this.executionOptions.getSlaOptions()).orElse(Collections.emptyList()).stream().filter(Objects::nonNull).map(slaOption -> slaOption.toObject()).collect(Collectors.toList());" }, { "prediction": "I don't think this is needed. I think it's better to use `favicon.ico` instead of `favicon.ico` and then use `this.get('model.icon') || '/favicon.ico'`", "reference": "So I haven't tested this - but since the icon location is just directly dumped into the img _src_ attribute, won't this cause issues with Ghost blogs in a subdirectory? If I'm misunderstanding what the purpose of the default is then let me know" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Why swallow the exception here rather than propagate it?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "How about `column_index_names`? `column_names` sounds ambiguous." }, { "prediction": "I don't think we need this.", "reference": "+1 on this. Do we want to have it as `WRITE_METRICS_MODE_COLUMN_CONF_PREFIX` to be consistent with defaults? Is there a possibility we will have `READ_METRICS_MODE_COLUMN_CONF_PREFIX`? Not sure." }, { "prediction": "I think this test should be `test_cumprod` (or `test_cumprod_from_pandas`).", "reference": "Shall we use different inputs for `PySpark < 2.4` where `transpose` won't work with different data types." }, { "prediction": "I don't think this is needed.", "reference": "we should sort the headers like in spark: public packages, then pyspark, then internal" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "looks like we should drop this var from the transport options struct" }, { "prediction": "I'm not sure why this was removed.", "reference": "Ah, yeah, this is the test for the validation that I mentioned in a remark above about relaxing the validation." }, { "prediction": "I'm not sure if this should be `None` or `None` or `None` or `None` or `None` or `None` or `None` or `None`` or `None`` or `None`` or `None`` or `None`` or `None`` or `None`` or `None`` or `None`` or `None`` or `None`` or `None`` or `None`` or `None`` or `None`` or `None`` or `None`````````None```````None``````None``````None`````None`````None`````None`````None`````None`````None`````None`````None`````None`````None`````None`````None`````None`````None`````None````None````None````", "reference": "For tensors, it is better to illustrate the shape." }, { "prediction": "I don't think we need this test.", "reference": "This was removed in a recent PR for the admin bar, but should have been kept. It's been restored in the other admin bar PR but I've added it here to for completeness." }, { "prediction": "I don't think this is the right place for this test.", "reference": "nit: probably swap the if condition and `if/else` and check `NETCOREAPP2_1` which looks more natural." }, { "prediction": "I'm not sure if this is the right way to do this.", "reference": "for the tag, should it be `requestor_rtt` since the other is `responder_rtt`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "The one sad part of this is that is will generate a lot of overhead if you loop through a vector, since it obtains the vector every time. But with the current API there is no alternative I guess, and it is better to have the option than not." }, { "prediction": "I don't think this is needed anymore.", "reference": "nit: there should be a newline between `types` and `go-ipfs-files`." }, { "prediction": "I'm not sure if this is the right place to put this variable.", "reference": "would be nice to have this as a parameter (Options), re: technical debt discussions" }, { "prediction": "I don't think this is needed.", "reference": "complete ignorance here but is it ok to import this from `com.sun`? can it break under non-oracle JREs?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this. I'm not sure if this is the right place to do this.", "reference": "Is this some way of saying that the span is going to be sampled? I'm basing this question on the condition I saw for the `OnEnd` to be called - `mustExport := s.spanContext.IsSampled() && )`. Shouldn't the condition be `s.spanContext.IsSampled()` to match the condition for calling the `OnEnd`?" }, { "prediction": "I don't think we need to update the snapshot list details in volumereplica. I don't think we need to update the snapshot list details in volumereplica. If we need to update the snapshot list details in volumereplica, we need to update the snapshot list details in volumereplica.", "reference": "just calling UpdateSnapshotInfo() should be fine" }, { "prediction": "I don't think we need to rate limit messages by default when in debug mode.", "reference": "Was `DefaultLogMessageRateLimit` not configurable anywhere?" }, { "prediction": "I don't think we need to test this. I'm not sure if it's a good idea to test this.", "reference": "Please use the `assert` instead. Same below." }, { "prediction": "This should be `A name suche as Europe or Overseas`.", "reference": "Owww, I think I found a typo. `suche`" }, { "prediction": "I'm not sure why this was removed.", "reference": "This can happen because we could get `PhantomNodes` that are not admissible as source/target right?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `clientSessionState` and `clientSessionState` in the `init` function. If it's a good idea to have a `clientSessionState` and `clientSessionState` in the `init` function, then I'm not sure if it's a good idea to have a `clientSessionState` and `clientSessionState` in the `init` function. If it's a good idea to have a `clientSessionState` and `clientSessionState` in the `init` function, then I think it's a good idea to have a `clientSessionState` and `clientSessionState` in the `init` function. If it's a good idea to have a `clientSessionState` and `clientSessionState` in the `init` function, then I think it's a good idea to have a `clientSessionState` and `clientSessionState` in the `init` function.", "reference": "Should we add a note here to file a bug if this ever happens?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "overflow is still possible, isn't it?" }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "This seems more like a personal preference, so maybe this should be in your `~/.rspec`?" }, { "prediction": "I'm not sure about this. I'm not sure if it's a good idea, but I'm not sure if it's a good idea. I'm not sure if it's a good idea, but if it's a good idea, it's a good idea.", "reference": "To avoid a circular import between pcapdnet and automaton" }, { "prediction": "I don't think this is needed anymore.", "reference": "Please remove this blank line." }, { "prediction": "I think this should be `InitWorkloadIdentityStatus()`", "reference": "it feels that the WorkloadIdentityCondition should be added to this Status... And if you have workload identity enabled, but not working, then you can mark that condition failed, and also Mark the ready false... not entirely sure though" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "I think these got refactored to `LvlFindInChain` to better conform with the coding guidelines. I think MarkL left these in for backwards compatibility." }, { "prediction": "I'm not sure if this is the right thing to do, but I think it's better to use `@wraps(f)` instead of `@wraps(f)`", "reference": "It's fine for this PR, but in the future try to minimize unrelated changes." }, { "prediction": "I don't think this is needed.", "reference": "The library -> modules and filters -> filter path changes are breaking changes or?" }, { "prediction": "I don't think this is needed.", "reference": "Can we encapsulate this check (`os.environ.get(\"TEST_TARGET\") == \"AWS_CLOUD\"`) into a small config/util function? (and also use it in `integration/conftest.py`) (I'd generally try to avoid accessing `os.environ` directly across the codebase. I'm aware that we're already doing this in a few places, but maybe we can start pulling things out - this will also help us create more systematic config/environment abstractions as we go...)" }, { "prediction": "`stack.push(child[i])` should be `stack.push(child[i]).reverse().forEach((item) => { stack.push(item); });`", "reference": "An `if` statement would be better here. Functions, concat and reverse are all very expensive." }, { "prediction": "I'm not sure if this is the right way to do this.", "reference": "`Log here: connect to default factory for goerli network

    `" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "nits, should add `break` to avoid redundant iterations." }, { "prediction": "I think this test should be `Assert.False(provider.AccountExists(_address1))`.", "reference": "I think we want an exception here, there should never be a transfer to a nonexisting account." }, { "prediction": "I think this should be `LOG.info(\"Created container \" + id);`", "reference": "This code is new and not tested well. While we may drop the log level before we ship 4.0, right now this is extremely helpful to users." }, { "prediction": "I don't think we need to change this test.", "reference": "Can we make these asserts more strict/precise? I remember this test helped to spot the issue of inconsistent results on different platforms due to using `sort` instead of `stable_sort`." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I thought about adjusting for case here as well? For example `.rb,rb,.RB,.rb` would all map to ruby interpreter specified? Is that too much \"magic\"? Is there a sane workflow that someone would choose to map `.rb` to one interpreter and `.RB` to another?" }, { "prediction": "This function is called if the sysroot is loaded. This function is called if the sysroot is loaded.", "reference": "In this and the one below, should we assert `self!= NULL` first?" }, { "prediction": "I think this test should be `assertSame(200, $view->getResponse()->getStatusCode(), 'Should return 200');`", "reference": "Why this is needed?" }, { "prediction": "I think this should be `get_user_meta`", "reference": "we already have.meta() so I don't think we want get_meta() for PackageEntry" }, { "prediction": "I think this is a breaking change.", "reference": "question: can we always get the startts from dagrequest?" }, { "prediction": "I don't think this is the right place to do this.", "reference": "Nit-picking, but this can be simplified to reference `properties[ 0 ]` since that is already retrieved 2 lines above." }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "This technically works because we call `get_targets` before we remove the target, so it's bound to have been resolved. But I'm not sure I would like to rely on that assumption. Should we also remove it from `@unresolved_targets` to be safe?" }, { "prediction": "I don't think we need to change this.", "reference": "So what happens if I try to get code on a EOA?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `self._get_values_to_unpack(inferred)` or `self._get_values_to_unpack(inferred)` here.", "reference": "Can't we return an empty list and then just compare the lengths? Thereby removing this `if`." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Mb change it to 'doesPassRestrictions()'? Doesn't sound enough like a boolean-returning method to me." }, { "prediction": "I'm not sure this is the right place for this interface.", "reference": "TODO: in fact At when used with noncurrent time should not return a next index. only latest should.." }, { "prediction": "`tmp.props.children` should be `Array.isArray(tmp)`", "reference": "There are scenario's where we skip an update with a placeholder, in this case tmp returns null with render, this is not an array so we `[null]` it" }, { "prediction": "I don't think this is needed anymore.", "reference": "@danieldietrich, this wasn't tested so I presumed it wasn't working before either :p" }, { "prediction": "I don't think this is needed anymore.", "reference": "Please leave two empty lines after the `use` statement" }, { "prediction": "I'm not sure if this is the right place to import k8s.io/kubernetes/pkg/kubelet/cm.", "reference": "Please move this import in the 3rd group which is for external dependencies" }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to use `is_internal_node` instead of `is_internal_node`.", "reference": "So what exactly is this fixing? The unit test is passing with or without this change." }, { "prediction": "I don't think this is needed.", "reference": "auto targetFile = fs::FileUtils::joinPath(newPath, folly::stringPrintf(\"%019ld.wal\", it->first));" }, { "prediction": "I think this method should be renamed to `snapshotIdsBetween` since it's not used anywhere else.", "reference": "I don't see any place that checks whether the from snapshot is an ancestor of the to snapshot. That seems like a requirement for this to work correctly to me." }, { "prediction": "I don't think we need to check if the helpText is empty.", "reference": "Other calls to getHelpText() are wrapped in an `isset()` check. Would it make sense to be consistent, and either restore that here or remove it elsewhere?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Why the change? If `output_stream` is set to something non-nil, it seems odd (and potentially wrong) to overwrite it...." }, { "prediction": "I don't think this belongs_to is needed.", "reference": "Thinking this should have an underscore." }, { "prediction": "I'm not sure why this test is failing. I'm not sure if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug.", "reference": "To accommodate the change to the method being private." }, { "prediction": "I don't think this is needed.", "reference": "Shouldn't we traverse all definitions and apply this rule over all model definitions in the doc" }, { "prediction": "I don't think this is needed.", "reference": "Please rename this class that it ends with the suffix \"Test\" - otherwise the tests won't be executed." }, { "prediction": "I think this file should be renamed to `prettier-config.js`.", "reference": "As a JS file, this should also receive our standard file header." }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if this is a good idea or if it's a good idea.", "reference": "I take it memQuotaRatio is an \"out\" parameter at line 1810? Also, why use MIN_QUOTA in both the cases of memQuota being too low and too high? Contrast this code with RelRoot::codeGen where we set MIN_QUOTA only in the too low case." }, { "prediction": "I'm not sure why this was removed.", "reference": "It looks like for newpullsubscription, we have two functions. One for pullsubscription with default, one for pullsubscription without default. If you remove setdefault here, then there is no differences between these two functions." }, { "prediction": "I'm not sure if this should be `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals` or `decimals`", "reference": "not dramatic, but why 32bits if we allow a range that is smaller than 8?" }, { "prediction": "I'm not sure if this is a good idea. I think it's a good idea to have a `ClientPromise` struct with a `SerialNumber` and a `BenefiterId` struct with a `BenefiterId` and a `Amount` struct with a `SerialNumber` and a `BenefiterId` struct with a `BenefiterId` and a `BenefiterId` struct with a `BenefiterId` and a `BenefiterId` struct with a `BenefiterId` and a `BenefiterId` struct with a `BenefiterId` and a `BenefiterId` struct with a `BenefiterId` and a `BenefiterId` struct with a `BenefiterId` and a `BenefiterId` struct with a `BenefiterId` struct with a `BenefiterId` struct with a `BenefiterId` struct with a `BenefiterId` struct with a `BenefiterId` struct with a `BenefiterId` struct with a `BenefiterId` struct with a `BenefiterId` struct with a `BenefiterId` struct", "reference": "- Use type from `service_discovery/dto/price.go` - Rename `Price` -> `Money`" }, { "prediction": "I don't think this is the right thing to do here.", "reference": "one space missing at the beginning" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "I worry that having `Platform` as `string` instead of `*string` would result in it getting overriden with `\"\"` if the environment manifest config doesn't specify `platform`. If it gets overridden as `\"\"`, that could be a problem for users that are not using `linux/amd64` right? If this indeed is a potential impact, could we double check in `ApplyEnv`'s unit test? Same with the `Platform` in `TaskConfig`. Sorry for not seeing this in my previous review!!!" }, { "prediction": "I don't think this is needed.", "reference": "I like the new directory `/api`, what is the thinking behind `/external`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "staticcheck flags this: replace with `for k :=..`" }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to use `timeout` instead of `timeout`.", "reference": "There's already a sleep right above" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "This feels hacky, is there a better way?" }, { "prediction": "I'm not sure if this is the right place to import `OrderedDict` or `OrderedDict`", "reference": "Can we move this logic into the `boto.compat` module? Then it's just `from boto.compat import OrderedDict` instead. Also, this is introducing a new dependency. What about users on 2.6.x that don't have the OrderedDict module installed? We may need to fall back to an ordinary `dict` so that existing code in the wild does not break." }, { "prediction": "I don't think this is needed.", "reference": "\"Gets the JSON serialization settings.\" would be better?" }, { "prediction": "I think this should be `/file/{addr}/upload`, not `/file/{addr}/download`", "reference": "The endpoint should be in plural `/files`." }, { "prediction": "I'm not sure about this, but I think it would be better to make DaylightDummy and DaylightDummy as well.", "reference": "??? Why do we need to have a different API in Python? Oh, wait, I see what you did. It's to fake the namespaces. Given that I don't think the namespaces are necessary, and that less of these should be exposed anyway, I think these should go." }, { "prediction": "I'm not sure if this is the right place to call this function.", "reference": "I think this line is gofmt issue? @daixiang0" }, { "prediction": "I'm not sure if this is the right place to test this, but I'm not sure if it's the right place to test this.", "reference": "probably better to assert the values directly; technically you could pass this test with an implementation that always returned \"\" for the subrepo for example." }, { "prediction": "I don't think this is needed anymore.", "reference": "line is 161 characters (from `lll`)" }, { "prediction": "I don't think we need this class anymore.", "reference": "Are these changes needed?" }, { "prediction": "I don't think we need this change.", "reference": "It seems like reducing the sensitivity would make the test failure less likely to occur, but not fix the issue?" }, { "prediction": "I don't think we need to use `I18nTimestampableTrait` here.", "reference": "missing use statement for importing the full namespace" }, { "prediction": "I'm not sure if this is the correct address format, but I think it's the correct address format.", "reference": "Generally error messages in Go shouldn't start with capital letter. I see this rule is broken in many places here. Why?" }, { "prediction": "I'm not sure why this change is needed.", "reference": "These test checks if selection coordinates don't return negative values in that edge cases. Please revert the changes and set `autoWrapCol` and `autoWrapRow` to `false` to the Handsontable instance. This change applies to the entire Core_selection.spec.js file." }, { "prediction": "I don't think we need this.", "reference": "I would prefer flag SkipGasPricingValidation" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "could be `const &`?" }, { "prediction": "I don't think we need to hideProgressAfterFinish here.", "reference": "The docs should also be updated with the new option." }, { "prediction": "I don't think we need this function. I think we should move this function to `send_email_smtp` and use it in `send_notification` function.", "reference": "Name is _way_ to generic for this patch to be accepted I think. Can you rename it to maybe `send_sns_notification` or something else you find suitable?" }, { "prediction": "I'm not sure this is the right place to use `*cfg.Logging.Level`", "reference": "Out of the scope." }, { "prediction": "I don't think this is needed.", "reference": "I think we need an if block to check that if this API is really missing. We wouldn't want to override the browser's implementation." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "I was wondering, things like EDITOR_TYPE, VALIDATOR_TYPE, RENDERER_TYPE are not obligatory. Therefore if the custom editor will be registered with this method, `name` will be set to `undefined`. Should we handle this scenario?" }, { "prediction": "I'm not sure why this was removed.", "reference": "This line should not be removed, as it is not the description of the package, but a copyright header." }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "Wouldn't it be more space efficient to make this a `byte` enum or bitfield?" }, { "prediction": "I'm not sure if this is the right place for this change, but I'm not sure if this is the right place for this change, or if it's the right place for this change, or if it's the right place for this change, or if it's the right place for this change, or if it's the right place for this change, I'm not sure if this is the right place for this change.", "reference": "Flake8 doesn't like the assignment, but non-use of `e` here. I think we can just remove the try/except here for `cursor.execute(sql)`." }, { "prediction": "I don't think we need this interface.", "reference": "Maybe add short example list:.... type body declarations, such as AnnotationMembers, Methods, Fields" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "These are really meant to be the keys in the capabilities, not the keys of values within the capabilities" }, { "prediction": "I don't think we need this interface.", "reference": "It is debatable whether we have to default this. I did this to avoid breaking custom implementations." }, { "prediction": "`attr_value['string'] is not None` probably not required as `attr_value['string'] == value`", "reference": "# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done" }, { "prediction": "I don't think we need this addon anymore.", "reference": "we shouldn't need the \"addon\" rename" }, { "prediction": "I'm not sure if this should be `must_be_admin` or `must_be_admin` or `must_be_admin` or `must_be_admin` or `must_be_admin` or `must_be_admin` or `must_be_admin` or `must_be_admin` or `must_be_admin` or `must_be_admin` or `must_be_admin` or `must_be_admin` or `must_be_admin` or `must_be_admin` or `must_be_admin` or `must_be_admin` or `must_be_admin`", "reference": "These are covered by routing constraints." }, { "prediction": "I think this should be `aws.StringSlice([]string{*instanceID}, aws.StringSlice([]string{*instanceID}, aws.StringSlice([]string{*instanceID}, aws.StringSlice([]string{*instanceID}, aws.StringSlice([]string{*instanceID}, aws.StringSlice([]string{*instanceID}, aws.StringSlice([]string{*instanceID}, aws.StringSlice([]string{*instanceID}, aws.StringSlice([]string{*instanceID}, aws.StringSlice([]string{*instanceID}, aws.StringSlice([]string{*instanceID}, aws.StringSlice([]string{*instanceID}, aws.StringSlice([]string{*instanceID}, aws.StringSlice([]string{*instanceID}, aws.StringSlice([]string{*instanceID}, aws.StringSlice([]string{*instanceID}, aws.StringSlice([]string{*instanceID}, aws.StringSlice([]string{*instanceID}, aws.StringSlice([]string{*instanceID}, aws.StringSlice([]string{*instanceID}, aws.StringSlice([]string{*", "reference": "Could we use just a normal string here?" }, { "prediction": "I'm not sure if this is the right place to import it. I'm not sure if it's the right place to import it, but I'm not sure if it's the right place to import it.", "reference": "`isFunction(Symbol)` triggers a `ReferenceError` if Symbol is undefined. Using `typeof Symbol === 'function'` is OK however." }, { "prediction": "I think this should be `lock.unlock ();`", "reference": "Is there an else clause (with a lock.unlock ()) missing here as well? If we think we do not need an else clause then lets add an else clause containing assert zero." }, { "prediction": "I'm not sure if this is the right place to send payment from unencrypted wallet. I'm not sure if it's the right place to send payment from unencrypted wallet. I'm not sure if it's the right place to send payment from unencrypted wallet, but if it's the right place to send payment from unencrypted wallet, I'm not sure if it's the right place to send payment from unencrypted wallet. I'm not sure if it's the right place to send payment from unencrypted wallet, but if it's the right place to send payment from unencrypted wallet, I'm not sure if it's the right place to send payment from unencrypted wallet. If it's the right place to send payment from unencrypted wallet, I'm not sure if it's the right place to send payment from unencrypted wallet. If it's the right place to send payment from unencrypted wallet, I'm not sure if it's the right place to send payment from unencrypted wallet, but if it's the right place to send payment from unencrypted wallet, I'm not sure if it's the right place to send payment from unencrypted", "reference": "do we foresee `32` ever changing? (as well as its use in error checking in `clerk.go`) if \"no\" this is fine, if \"yes\" it's probably still fine" }, { "prediction": "I don't think this is needed anymore.", "reference": "you don't need to create a enum for this, java allows you to switch on a string ;) (since java 7?)" }, { "prediction": "I don't think we need to load roles from the store.", "reference": "This should be `modelPromises.roles = this.get('store').query('role',...` and the promise body should just `return roles;`. This is because the `model()` hook will pause for the returned promises to be resolved before continuing so when returning `RSVP.hash` you end up with a hash containing the values returned from the promises so the controller and everything else relying on the `model` object doesn't need to worry about things being async." }, { "prediction": "I don't think we need to check for `sectioning.includes(role)` here.", "reference": "This is basically a repeat of `main-is-top-level.js`. I suggest having these 3 checks point to the same evaluate file. You can change what element they test through the rule selector as well as the check.json options property. So you would have `main-is-top-level.json`, `banner-is-top-level.json` and `contentinfo-is-top-level.json` each point to `landmark-is-top-level.js`, and pass in a different `options` object which tells it what element you're trying to test." }, { "prediction": "I don't think this is needed.", "reference": "Why do we need this check? setCore already handles nulls." }, { "prediction": "I'm not sure this is the right place to do this.", "reference": "good catch, thanks. This is going to make the user experience much better." }, { "prediction": "I don't think this is needed anymore.", "reference": "TODO: remove this unused import" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "Hmm leaking the library name out in the Workload API doesn't seem great. Do we want to catch these errors and return a canned \"could not parse token\" or something instead?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `./gradlew` or `./gradlew` here. I'm not sure if `./gradlew` or `./gradlew` is a good idea. I'm not sure if `./gradlew` or `./gradlew` is a good idea, but I'm not sure if `./gradlew` or `./gradlew` is a good idea. I'm not sure if `./gradlew` or `./gradlew` is a good idea, but I'm not sure if `./gradlew` or `./gradlew` is a good idea. If `./gradlew` or `./gradlew` is a good idea, I'm not sure if `./gradlew` or `./gradlew` is a good idea. If `./gradlew` or `./gradlew` is a good idea, I'm not sure if it's a good idea to use `./gradlew` or `./gradlew` or `./gradlew` or `./gradlew` or `./gradlew` or `./gradlew", "reference": "I think `-f gradlew` is better for code unity" }, { "prediction": "I think this should be `DEFAULT_READER_FETCH_RECORD_BATCH_SIZE`", "reference": "Is there precedent for this config key? What other keys are similar? The others in this file start with `table.exec.iceberg`. Is there a reason for not continuing with that convention?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Can we avoid no-change changes being committed - they make it harder to distinguish actual changes from code editor changes" }, { "prediction": "I don't think we need to update the name of an AWS Identity and Access Management (AWS IAM) server certificate. I don't think we need to update the name of an AWS Identity and Access Management (AWS IAM) server certificate. I don't think we need to update the name of an AWS Identity and Access Management (AWS IAM) server certificate.", "reference": "AWS Identity and Access Management (IAM)" }, { "prediction": "I don't think we need this anymore.", "reference": "You dont use this dependency anymore" }, { "prediction": "I don't think this flag is needed.", "reference": "Here is the test that checks that the sqlcipher in use was compiled with the right flags" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Turns out that if the hosts are not in an `array`, an `Exception` is not thrown anymore :-( It simply returns `null`. So, we need to attempt to parse a `string` outside the `catch` block for it to work." }, { "prediction": "I don't think this is needed.", "reference": "this test only covers the happy path. what about no acceptable rest template found?" }, { "prediction": "I think this should be `LOG.finer(String.format(\"Firefox Session %d assigned to %s\", i, chromeSession.getUri()));`", "reference": "Since this is in a test, I imagine that the choice of `info` level was deliberate." }, { "prediction": "I don't think this is needed anymore.", "reference": "this should probably be named somewhere if you want to reuse it." }, { "prediction": "we are not going to use AWS STS", "reference": "needs a rename to not include AWS" }, { "prediction": "I'm not sure about this, but I'm not sure if it's worth it.", "reference": "Isn't sigma have `double` type?" }, { "prediction": "I don't think this is needed.", "reference": "May be better use nano::keypair that generates ramdom value?" }, { "prediction": "I don't know what the user selected for BSON options here.", "reference": "I think the more complete solution will save off a `ignoreUndefined` in the base class for the bulk operation (with a default of `false`), and use that for calculations. Was there a reason you didn't want to support the option from the operation level?" }, { "prediction": "I don't think we need to do anything here.", "reference": "The catch (Exception e) block that follows does an updateSync, which will get a SmartStore instance (while logging out is taking place) - and then terrible things will happen - a database gets created for the outgoing user that won't be openable by the returning user causing the app to crash at logout. This is a somewhat superficial fix - SmartStore should not return an instance for an outgoing user." }, { "prediction": "I think this test should be moved to a separate PR.", "reference": "huh does this work without a `Return`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Don't think we want this line, right? (Plus \"failing\" is spelled wrong)." }, { "prediction": "I don't think we need to check for local feeds.", "reference": "I think it would be more clear to have local-feed-hiding all in one place (bottom of this method?). Further up the method, there already is some code that hides the website icon, for example." }, { "prediction": "I think we should remove the `fixtures_dummy_content` from the `Maintenance` menu.", "reference": "Why remove this one? It doesn't work yet, but we'll add it sooner or later." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `docstore` field in the `docstoreRevision` struct. I'm not sure if it's a good idea to have a `docstore` field in the `docstoreRevision` struct. If it's a good idea to have a `docstore` field in the `docstoreRevision` struct, then I think it's a good idea to have a `docstore` field in the `docstoreRevision` struct. If it's a good idea to have a `docstore` field in the `docstoreRevision` struct, then I think it's a good idea to have a `docstore` field in the `docstoreRevision` struct. If it's a good idea to have a `docstore` field in the `docstoreRevision` struct, then I think it's a good idea to have a `docstore` field in the `docstoreRevision` struct, then I think it's a good idea to have a `docstore` field in the `docstoreRevision` struct.", "reference": "Why did you remove the struct tags?" }, { "prediction": "I don't think we need to do this. I think we should do this in the `final_status.py` file.", "reference": "Let's be neutral with tag names. Let's just have \"ReportURL\"" }, { "prediction": "I'm not sure if this is the right place to test this.", "reference": "Use an explicit time to ensure conversion is not copy-paste and wrong." }, { "prediction": "I think this should be `\\n` instead of `\\n`", "reference": "The logic now is to look for ``. This `` output is also not consistent with the other two functions you mentioned. Do the other two RPCs not report an error?" }, { "prediction": "I'm not sure if this is the right place to put this method, but I think it's better to move this method to the `ApiController` class.", "reference": "Use nested module/class definitions instead of compact style." }, { "prediction": "I think this should be `Init KBFSOps` instead of `Init KBFSOps`", "reference": "Do you think we need to keep this in, or is it just leftover personal debugging? Seems like it wouldn't be too useful most of the time, but I don't care too much if you want to keep it." }, { "prediction": "I don't think this is needed.", "reference": "showNPCs is not needed" }, { "prediction": "I'm not sure if this is a good idea. I think it's better to use `ErrParameterAlreadyExists` instead of `ErrParameterAlreadyExists`. I think it's better to use `ErrParameterAlreadyExists` in the `ErrParameterAlreadyExists` struct.", "reference": "Docstring for public function pls" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "This should use `t.Errorf` instead. You want the second part of the test to run even when the first part fails." }, { "prediction": "I don't think this is needed.", "reference": "Should this if block better be changed to `#if H2O_USE_LIBUV \\n #else... #endif`? The reason I wonder is because that's the way the QUIC context is being initilaized at the beginning of this function. Though I would not expect practical difference between the two approaches, because ATM the only case where we create QUIC connections is when the protocol selector is set to non-zero, and because when it is set to non-zero `h2o_quiy_close_all_connections` becomes a no-op." }, { "prediction": "I don't think this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "`Object.is` is an ES6 feature of JS so I don't think we can use it here (or we have to change our browser support matrix or specify that an Object.is polyfill is pre-req of `preact/hooks`). Should we just do an `===` check in `preact/hooks` and provide a `Object.is` polyfill and version of `useReducer` in `preact/compat`?" }, { "prediction": "`typeof options.roles ==='string'? [options.roles] : [];`", "reference": "This was a bug I picked up by using the TS interface as a guide, this seems like it was / is the intention, also is a bug in master (needs port)" }, { "prediction": "I think this should be `COLOCATED_WITH`", "reference": "It would be helpful to explicit here what this really means and assumes." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "`ExpectedBalances` is a global variable (from `gochecknoglobals`)" }, { "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "This is another place where I'd feel more comfortable with declaring the class private. We can always make it public in the future if someone makes a case for that, but I prefer to err on the side of privateness for things like this that 99% of RSpec users won't have a reason to use." }, { "prediction": "I don't think we need to set the issuer account here.", "reference": "Feels like this should be left as is and add a new createClientWithIssuers or something like that. Avoid all the \"\"" }, { "prediction": "I don't think we need to check for null here.", "reference": "Minor unrelated bug in the IDP flow where the error wasn't getting displayed as a `Toast`." }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "I thought we got rid of this thing?" }, { "prediction": "I'm not sure if we should remove the `$entry_path_type` and `$entry_path_description` from the `TaintNodeData` class.", "reference": "Please convert int params as well." }, { "prediction": "I don't think we need to change this.", "reference": "Fixed bug in implementation. Now I can run the validator from the VS Tools menu, double-click on an output line, and navigate to the site of the issue." }, { "prediction": "I don't think we should add this to the `TracerSettings.HttpServerErrorStatuses` section.", "reference": "Can we rename this field to `HttpServerErrorCodes` or `HttpServerErrorStatuses`? It will contain a list of status _codes_, not a list of _errors_. (Personally I prefer \"codes\" over \"statuses\", but we can't change `DD_HTTP_SERVER_ERROR_CODES`.)" }, { "prediction": "I'm not sure if this is the right place to seek to head, but I'm not sure if it's the right place to seek to head, or if it's the right place to seek to head, or if it's the right place to seek to head, or if it's the right place to seek to head, or if it's the right place to seek to head, or if it's the right place to seek to head, or if it's the right place to seek to head, or if it's the right place to seek to head, or if it's the right place to seek to head, or if it's the right place to seek to head, or if it's the right place to seek to head, or if it's the right place to seek to head, or if it's the right place to seek to head.", "reference": "would you please use: flb_utils_bool(...) here?, that function wraps the on/off/true/false stuff." }, { "prediction": "I think this should be `prerelease` instead of `prerelease`", "reference": "`invocationInfoTokensToRedact: null` (I really like the convention of using a named parameter whenever the value doesn't communicate the meaning, such as for literal values.)" }, { "prediction": "I don't think we need async_test here.", "reference": "maybe renamed to `async_simple_test` if we consider supporting aug test later on?" }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if it's the right place to do this.", "reference": "So where is default_attributes now? Is it used anywhere else still? If not, can it be removed along with any tests of it?" }, { "prediction": "I'm not sure if this is the correct behavior. I'm not sure if this is the correct behavior. I'm not sure if this is the correct behavior.", "reference": "We could move this to the base class and remove all these changes. What do you think?" }, { "prediction": "I'm not sure if this is the correct behavior. I'm not sure if this is the right behavior.", "reference": "While we're doing some translation work, could you extract this button text and the other static text from the view?" }, { "prediction": "I don't think this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "Nit: Please fix indentation (note: Azkaban uses 2 spaces and not tabs)." }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if this is the right thing to do.", "reference": "This change is necessary because the schema version is ignored unless a schema is specified. I think that has always been the intent." }, { "prediction": "I don't think this is the correct version.", "reference": "The api/docs/release.dox changelog message is missing: maybe you planned to add it once NtAllocateVirtualMemoryEx and NtMapViewOfSectionEx support is in? I would say, add it here in the same diff that raises max_supported_os_version." }, { "prediction": "I don't think we need to check for `aria-hidden` here.", "reference": "Just do: `return node.hasAttribute('aria-hidden')`" }, { "prediction": "I'm not sure if this is the best way to test this, but I'm not sure if it's the best way to test this.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I don't think this is needed.", "reference": "Do we need `_processDataPoisoned`? Can the name or the id of the current process ever change? Or the machine name?" }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to use `os.Getenv(\"NOTIFY_SOCKET\")` instead of `os.Unsetenv(\"NOTIFY_SOCKET\")`.", "reference": "Did it not work out to wait until after containerd and kubelet are started?" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "variable names suggestions from me: - damageboost, ITEM_PARSE_DAMAGEBOOST, \"damage boost +x%\" - healingboost, ITEM_PARSE_HEALINGBOOST, \"healing power +y%\" - managainboost, ITEM_PARSE_MANAGAINBOOST, \"mana restoration +z%\" alternatively the other names can stay, because \"increase\" convention isn't that bad, just change mana values to: - \"increasemanarestored\", ITEM_PARSE_INCREASEMANARESTORED, \"mana restoration +z%\"" }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to have a `has_all_data` column in the table. I think it's a good idea to have a `has_all_data` column in the table, but I'm not sure if it's a good idea to have a `has_all_data` column in the table. I think it's better to have a `has_all_data` column in the table, and then have a `has_all_data` column in the table. I think it's better to have a `has_all_data` column in the table, and then have a `has_all_data` column in the table. I think it's better to have a `has_all_data` column in the table, and then have a `has_all_data` column in the table. I think it's better to have a `has_all_data` column in the table, and then have a `has_all_data` column in the table. I think it's a good idea to have a `has_all_data` column in the table", "reference": "Why can't this be determined by 'PARTIAL_SUCCESS' in the `status` field?" }, { "prediction": "I don't think this is necessary.", "reference": "Does it make sense to generate a Exception here? Maybe yes, because it wouldn't make sense to generate a path without the id of the media right?" }, { "prediction": "I don't think we need to create a new instance for SalesforceTLSSocketFactory. I think we should create a new instance for SalesforceTLSSocketFactory and then create a new instance for SalesforceTLSSocketFactory. I think we should create a new instance for SalesforceTLSSocketFactory and then create a new instance for SalesforceTLSSocketFactory and then create a new instance for SalesforceTLSSocketFactory.", "reference": "This should be made private." }, { "prediction": "I think this should be `BaseSVIDPath: a.getBaseSVIDPath()` instead of `BaseSVIDPath: a.getBaseSVIDPath()`", "reference": "perhaps this is better modeled as a pkg-level var?" }, { "prediction": "I don't think this is needed.", "reference": "I don't think there is a maximum scale, neither for Hive nor for Trafodion. The only condition right now is that the scale can't exceed the precision. Example of a valid scale: DECIMAL(18,18). The maximum of 6 digits applies only to TIMESTAMP columns, where we don't support resolution below microseconds." }, { "prediction": "I don't think this is needed.", "reference": "`ctx` is unused in UpdateProjectStaticUser" }, { "prediction": "I don't think this is needed.", "reference": "Why is this not the default, and why only for JS?" }, { "prediction": "Line is too long. [89/80]
    Space inside { missing.
    Space inside } missing.", "reference": "A repository has many badges so we should also add type column in scope." }, { "prediction": "I'm not sure if this is the correct behavior. I'm not sure if this is the correct behavior, but I'm not sure if this is the correct behavior.", "reference": "Now a hash set, so can't index into it." }, { "prediction": "I don't think we need this method anymore.", "reference": "@jpogran Does this seem like a reasonable way to know if we're in powershell vs. CMD or *sh?" }, { "prediction": "I think this should be `contentType!= null &&!contentType.toLowerCase().startsWith(MediaType.APPLICATION_JSON)) { // TODO: we should consider body encoding return IOUtils.toString(inputStream, \"UTF-8\"); }`", "reference": "1.toLowerCase(Locale.US)? 2.where is accept bug fix?" }, { "prediction": "I'm not sure why this was removed. I'm not sure if it's a good idea to remove the `assert 1 == e.value.code` line.", "reference": "We should still be providing something to the user in the case of a `KeyError` instead of a stack trace!?" }, { "prediction": "I think we should move this method to `DataMarketplace.Core.Services.GetNonceAsync`", "reference": "check Lukasz's fix with NonceReserving - is that not better?" }, { "prediction": "I think this should be `this.sourceBlock_.setColour(colour, colour, colour);`", "reference": "Would you explain why here please? E.g. from the PR description > the renderer expects to be able to use the secondary color as the fill for a shadow." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "Lock needs to go to `RecoverFromDb` instead. Here it may cause deadlocks. My convention was that un-exported functions do not lock, only exported ones (with name starting with a capital letter)" }, { "prediction": "I think this method should be called `getDomains()` instead of `getDomains()`", "reference": "German keyboard would also be used in Austria and Switzerland, so this should have included `.at` and `.ch`." }, { "prediction": "I'm not sure why this was removed.", "reference": "since this makes the indexer thing really only used for a single table, now, you can put in a TODO for me to cleanup and simplify this" }, { "prediction": "I think this should be `NSCD_SOCKET_VOLUME_MOUNT_PATH`", "reference": "Should we have this path passed from the Azkaban properties? If this is the standard path for nscd even outside LinkedIn, then we can keep it." }, { "prediction": "I'm not sure if we should rely on the stream name. I'm not sure if we should rely on the stream name, or if we should rely on the stream name. I'm not sure if we should rely on the stream name, or if we should rely on the stream name, or if we should rely on the stream name. I'm not sure if we should rely on the stream name.", "reference": "Could be a non-public field. `allowNoSubject`" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Don't think this is quite right - think the build one also needs an `IsOriginalTarget` (c.f. code in `src/build`)" }, { "prediction": "I think this should be `array('results' => $this->processResults($entities, $targetEntityConfig));`", "reference": "what about adding typehints instead? I don't think we need to add docblocks for every private methods." }, { "prediction": "I don't think this is needed.", "reference": "Is it fine to pass the \"-o compression=on\" in the middle instead of at the end?" }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "Probably make them all keyword arguments." }, { "prediction": "I'm not sure why this was removed.", "reference": "Why not just check the backdrop setting here as well for the time being? We can combine the code later but at least then it would be configurable if people like the backgrounds." }, { "prediction": "I don't think we need to change this.", "reference": "why are we turning this one into a Warning?" }, { "prediction": "I think this should be `String.valueOf(sourceIDs.size())` or `String.valueOf(sourceIDs.size())`", "reference": "Wouldn't it be better to use double quotes for the opening parenthesis?" }, { "prediction": "I don't think this is needed.", "reference": "Remove the cast" }, { "prediction": "I don't think this file is needed anymore.", "reference": "What criteria do we use to bump the copyright years? An update to the module?" }, { "prediction": "I think this should be `results[key] = gt_seg`", "reference": "should we rm line 269?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Perhaps the code at `source/core.py:564: postNvdaStartup.notify()` should be queued instead? If we are saying the loop must have started before NVDA's startup is complete, then the `postNvdaStartup` action is incorrect." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Needed this for testing locally with mail view but not used for any tests. Might be nice to have some seed scripts at some point." }, { "prediction": "I don't think this is the right place to do this.", "reference": "wait, if we only do this for successful status codes won't we miss a whole slew of responses? We should be checking this for all codes right?" }, { "prediction": "I don't think we need to change this test.", "reference": "Adding in the service yaml `library.yaml` here." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Why is this dereference needed?" }, { "prediction": "I don't think this is needed.", "reference": "Might want to add that this only happens if you have write permissions to the folder." }, { "prediction": "I'm not sure if this should be `true` or `false` or `true` or `false`", "reference": "Adding a small blurb about why someone would want to enable this flag would help clarify what it is for. Such as something about when providing a custom retry handler and how`ShouldRetry` will be handled with and without the flag enabled." }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "assume the user will be able to register for a custom service name in future?" }, { "prediction": "Is this needed?", "reference": "The extra two empty lines seem unnecessary. Please review your diffs more carefully." }, { "prediction": "I don't think we need this anymore.", "reference": "What the reason to embed the Oracle?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Shouldn't this happen automatically with High Voltage?" }, { "prediction": "I don't think this is the right place to do this.", "reference": "This is changed because we need `projectId` to be printed as `$projectId` in PHP." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.", "reference": "This title change seems more accurate to me however not sure if this will confuse users." }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if it's the right way to do it.", "reference": "Here (and on line 158 as well), would it be more efficient to use the String end_with() method? Not tested" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this. I'm not sure if it's the right place to do this, but I'm not sure if it's the right place to do it.", "reference": "Why are you creating a new (second) `RAMHandler` here? Is this just an oversight from deleting the previous code?" }, { "prediction": "I don't think we need to check if the edge index exists or not.", "reference": "Move the line 27 to line 31 is better?" }, { "prediction": "IsRekeySet() needed?", "reference": "In slack I mentioned we should only do this if the update is from some other device, to make sure our own updates don't cause issues. Maybe the revision check above is good enough to prevent this, but I just want to make sure you thought about it." }, { "prediction": "I'm not sure why this was removed.", "reference": "I would instead explain that random is the default, but you can switch back to defined, or another ordering scheme." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "Is there a reason you left this at 0?" }, { "prediction": "I don't think this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "The value of `key` will never be `null` at this point, because `getKey()` will generate a value if it is `null`." }, { "prediction": "I don't think we need to create a scope here. I don't think we need to create a scope here.", "reference": "NIT: You should first check if AdoNetExcludedTypes.Count is greater than 0 before calling Contains (fast-path)" }, { "prediction": "I don't think this is needed.", "reference": "should rearrange so as to follow import ordering." }, { "prediction": "I'm not sure if we should change this to \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\" or \"ZOMBIE\"", "reference": "what is the use case for create workflow with completed state?" }, { "prediction": "I think this test should be `RemoteDistributorTest` instead of `RemoteDistributorTest`.", "reference": "Probably best not to have an empty test...." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Missing the license" }, { "prediction": "I think this should be `if p.config.EnableCleanupReplicationTask() {`", "reference": "Looks like this was previously guarded by `EnableCleanupReplicationTask` flag. Now looks like this is always needed. Just want to confirm the intention is if `GlobalNamespace` is enabled then we want run cleanupReplicationTasks in all cases?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Potentially it'll be good to remove all of them excluding \"tbb/tbb.h\" But let's do it next time" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to do this, but I'm not sure if it's a good idea.", "reference": "I would just mention which tolerance - namely as reported by ``sys.float_info``" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but I'm not sure if it's the right place to do it.", "reference": ":+1: Ideally this'll become something you could pass in to the config" }, { "prediction": "I think we should move this line up to the next line.", "reference": "Should using `thenValue` to replace `then`?" }, { "prediction": "I don't think we need to check for integration enabled?", "reference": "This follows the convention of each callback starting with the `IsIntegrationEnabled` check." }, { "prediction": "I don't think we need to change this. I think we should make this `bool isDeltaValue = false; bool isMonotonicValue = false;`", "reference": "this is not required to be part of this PR right? (With UpDownCounter being absent in.NET, we can make this hardcoded for now, i think)" }, { "prediction": "I think this interface should be `IConnectionHandler` instead of `IConnectionInformation`.", "reference": "Add the PipeFactory here" }, { "prediction": "I'm not sure why this was removed.", "reference": "please add `var _ impltypes.ChaosImpl = (*Delegate)(nil)`" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "nit: is this added deliberately?" }, { "prediction": "I don't think this is the right place for this test.", "reference": "Given the number of tests which need this (I think I counted seven) should we maybe just install this one globally? Is there even a place to do that? Something in `test_helper` maybe?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike` or `isPromiseLike`", "reference": "we don't use this anymore, so we can delete it." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.", "reference": "nit: change to \"Telemetry configuration loaded from '%s'\"" }, { "prediction": "I'm not sure if this is a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug.", "reference": "Why did this value change?" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "maybe `duckpubsubv1alpha1`?" }, { "prediction": "I don't think we need to do this. I think we should do this in the `parse_manifest_json` method.", "reference": "The id is not mandatory for web extensions. Could you update this to support a web extension without an id?" }, { "prediction": "I'm not sure why this was removed.", "reference": "I actually prefer them to be defined here. Client who calls `lib` should define the args, not `lib` itself." }, { "prediction": "I'm not sure if this is the right place to close the console. I'm not sure if it's the right place to close the console.", "reference": "I think this should've been done with the `defer`-named-return trick. I'll submit a PR for it." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "The bind address should be configurable." }, { "prediction": "I think this method should be `private void fetchCategories(File[] categoryDirectories)`", "reference": "Maybe the empty `delete()` should be implemented as default in the interface." }, { "prediction": "I don't think this is needed.", "reference": "How to ensure CMAKE_SOURCE_DIR is set correctly?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea, but I'm not sure if this is a good idea.", "reference": "safer to make a copy of incoming *big.Int" }, { "prediction": "I'm not sure if this is the correct timeout.", "reference": "how did we choose this value? does this hold good for Windows too?" }, { "prediction": "I don't think this is needed.", "reference": "To follow the other build tags, maybe we can call it `criu`?" }, { "prediction": "I don't think we need to change the default value here. I'm not sure if we need to change the default value, but I'm not sure if we need to change the default value.", "reference": "Should we load this from the config file too?" }, { "prediction": "I don't think we should do this in webhook. I think we should do it in webhook.", "reference": "Can you file an issue for this?" }, { "prediction": "I don't think we need to check if `this[kIsMaster]` is null.", "reference": "@nbbeeken what were the cases where `!!this[kIsMaster]` was yielding an incorrect value? we should try to cover them in the tests" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "This whole function feels messy. I don't have a better idea at the moment though." }, { "prediction": "I don't think we need this anymore.", "reference": "should use Number instead of Long" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `MockProvider` here. I'm not sure if it's a good idea to use `MockProvider` or `MockProvider`.", "reference": "Can you rename this and the file `InfluxDBProvider` and `influxdb_provider.go` respectively?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "This is the real culprit, as now vlen will always be a Number (and known to the compiler as such). You could probably go one step further and avoid the ToBoolean on `vchildren` as well by writing something like `vlen = (vchildren!== undefined)? vchildren.length : 0` if that matches the contract." }, { "prediction": "I don't think this is needed.", "reference": "missing space before `TextView`" }, { "prediction": "I don't think this is needed.", "reference": "so this attribute is used as u8 in code, but saves as int32? Why?" }, { "prediction": "I don't think we need to change this.", "reference": "can RDSE be added to the list? It has its capnp files." }, { "prediction": "I'm not sure if this is the right place for this function, but I think it's better to move this function into `certToInjectableFunc` so that it's more clear what it's used for.", "reference": "These functions only ever read from the API and should always be reading from a cache, so I have made that explicit by expecting a Reader here and supplying a `cache.Cache` as the client." }, { "prediction": "I don't think this is necessary.", "reference": "No, we can't skip any of the mangling after the suspend point: this should follow the other mangling and undo its push." }, { "prediction": "I don't think this is needed anymore.", "reference": "this is generated code.. these changes will need to be made in the code generator to have them stick." }, { "prediction": "I don't think this is needed.", "reference": "Should we abstract this into a reusable utility so it doesn't have to get repeated in every test file needing Shadow DOM support?" }, { "prediction": "I'm not sure if this is the right place for this test.", "reference": "Maybe we rename this to `command_monitoring.test.js` to match the directory name change? Or would you rather do that as part of the greater test cleanup? I'm fine either way." }, { "prediction": "I think this should be `String.prototype.$conditionalHandlers = handleSingle, $regex: handleSingle, $not: handleSingle, $regex: handleSingle, $not: handleSingle, $regex: handleSingle, $not: handleSingle, $regex: handleSingle, $not: handleSingle, $regex: handleSingle, $not: handleSingle, $regex: handleSingle, $not: handleSingle, $regex: handleSingle, $not: handleSingle, $regex: handleSingle, $not: handleSingle, $regex: handleSingle, $not: handleSingle, $regex: handleSingle, $not: handleSingle, $regex: handleSingle, $not: handleSingle, $regex: handleSingle, $not: handleSingle, $regex: handleSingle, $not: handleSingle, $regex: handleSingle, $not: handleSingle, $regex: handleSingle, $not: handleSingle, $not: handleSingle, $regex: handleSingle, $not: handleSingle, $not: handleSingle, $regex: handleSingle, $not: handleSingle, $not: handleSingle, $regex: handleSingle, $not: handleSingle, $not: handleSingle", "reference": "Why is this change necessary? `handleSingle()` will cast it to a string, no?" }, { "prediction": "I don't think this is the right name for this table.", "reference": "This newly added method should be well defined, should it return `TableIdentifier` or just `String`?" }, { "prediction": "I think this message should be `Multimedia has a relation with some products`.", "reference": "have a relation with a product" }, { "prediction": "I think this should be `if k8sInfra.PodExist(\"default\", name) {`", "reference": "I guess that there is still a window here, because the GC could happen between the `PodExist` and `Delete` calls. Would it be better instead to check `err` and allow it if it says \"pod has already been deleted\"?" }, { "prediction": "I don't think this is needed anymore.", "reference": "SQLAlchemy's session management does magic to make sure that if the rollback fails you still get the original exception that caused the rollback. Also it looks nicer." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or not.", "reference": "This switch statement can be removed. Just return q.items[act.Nonce]!= nil" }, { "prediction": "I don't think we need to change this.", "reference": "I think `==` for nodes is more readable than equals. An equals calls looks like it could be recursing, because intuitively two nodes are equal if their subtree are the equal. But everywhere you replaced, we don't want to test whether the subtrees are structurally equal, we want to know whether they're the same. Only `==` captures this intent, using equals obscures this. Not to mention that equals may NPE and is in that sense less ergonomic. I think we should enhance the rule with a list of types for which `==` is correct. Edit: in the meantime i think we could suppress those new violations..." }, { "prediction": "I don't think this is needed.", "reference": "What's the scenario for passing multiple filters?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "move to after check log.empty()" }, { "prediction": "I don't think this is needed anymore.", "reference": "This line needs to be removed" }, { "prediction": "I'm not sure if this is a good change. I'm not sure if this is a good change.", "reference": "Can we delete such const like `CloudBuildSourceEvent` and `CloudBuildSourceBuildId` since all those are contained under schemas/v1?" }, { "prediction": "I don't think we need to add this to the `pkg/apis/hive/pkg/apis/hive.go` file.", "reference": "This is unused." }, { "prediction": "I don't think we need to add a `CompositePropagator` to the `TraceContextFormat` and `BaggageFormat` properties.", "reference": "Any reason not to put `using System.Collections.Generic` (guess there shouldn't be naming conflicts)?" }, { "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body beginning.", "reference": "Could the name of this controller just be shortened to `TwitterCardsController`? Is the `Player` there adding information?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Backends with hostnames that depend on the request are always up?" }, { "prediction": "I don't think we need to import `JsonPatchException` here.", "reference": "I'd rather catch those to `utils.py` and raise a simple ValueError from them. From the resource point of view, these are details of implementation" }, { "prediction": "I don't think we need this anymore.", "reference": "make this 1.0? I don't think all that many people do `language: julia` without any `julia:` specifiers, but may as well keep that possible?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to do this, but I'm not sure if it's a good idea to do this.", "reference": "nit: `AZURE_KEYVAULT_AUTH_VIA_CLI` is defined by us, so it might be helpful to differentiate it from azure's env names. Maybe starts with `GOCDK`." }, { "prediction": "I don't think this is needed.", "reference": "Depend on interfaces not on structures" }, { "prediction": "I think this should be `gStorageServer->notifyStop()`", "reference": "This fix looks good. My concern, don't forget to fix metad too!" }, { "prediction": "I think this should be `!(earliest.BID() == NullBranchID && latest.BID() == LocalSquashBranchID)`", "reference": "Just noticed this nil context. Perhaps plumb through ctx too, or change to `Debug`?" }, { "prediction": "I'm not sure if we should change this to `application/x-www-form-urlencoded` or `application/x-www-form-urlencoded` or `application/x-www-form-urlencoded`", "reference": "Does it send requests with urlencoded bodies anywhere? I thought it sends only json. Maybe content-type should be `application/json` by default?" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "Again use of `constexpr` is recomended." }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "Minor point but I would call this ``redim_graph`` instead." }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "As I was trying to figure out how the error messages are written out, since they are returned from `getOrCreate` and `reconcile`, it looks like we are using plain `klog` to write them out instead of using the logger from the scope above" }, { "prediction": "I'm not sure if this is the right place to log this error.", "reference": "Now it's double logging, is not it? Because `service.ipForward.Enable()` logs extra `warning`" }, { "prediction": "I'm not sure if this is the right place to set home location. I'm not sure if it's the right place to set home location, but if it's the right place to set home location, it's the right place to set home location.", "reference": "Whatever the decision is about the request type to use, this should only match what is needed and not the other one." }, { "prediction": "I don't think we need to update previews for output connections.", "reference": "...and in turn, this should probably be var updatePreviews = true; if (!(localConnection && localConnection.type == Blockly.OUTPUT_VALUE) && (Blockly.localConnection_ && Blockly.highlightedConnection_)) { since the first clause is a no-op. If you want to leave it this way for clarity, that's fine too." }, { "prediction": "I'm not sure about this, but I think it would be better to remove the `force_rebuild=False` argument from the constructor. I'm not sure if it's a good idea to remove the `force_rebuild=False` argument from the constructor.", "reference": "Please remove this TODO, since they will not apply anymore after you are done. :) Can you please remove this everywhere else in this PR?" }, { "prediction": "I don't think this test is needed.", "reference": "This seems like an incomplete schema definition. will that have any effect on the tests?" }, { "prediction": "I'm not sure if this should be called when loading from text file.", "reference": "The testing cases are failing because `SetHeader` does not only handle cases where input are from files. It also reads categorical feature indices from the config parameters (see the part outside the `if (filename!= nullptr) {... }`). Skipping `SetHeader` directly here will cause errors when we load data from numpy or pandas arrays (where `filename == nullptr`) and use categorical features. So I think we should move the the check `filename!= nullptr && CheckCanLoadFromBin(filename) == \"\"` into `SetHeader`. That is, we change `if (filename!= nullptr) {... }` into `if (filename!= nullptr && CheckCanLoadFromBin(filename) == \"\") {... }`" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `ExitError` or `ExitError` here.", "reference": "I think we should change the variable name of `err` in `if err, ok := err.(*exec.ExitError); ok `, this re-assignment of `err` still affects the next `else` branch" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "`Status` has identical semantics with `StatusOr`." }, { "prediction": "I don't think we need to add labels here.", "reference": "why is this named in a different style from other paths?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Swapped these to ensure that we aren't passing a nil cluster in to util.IsPaused" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "I don't see pkgManager used anywhere, is there a reason we need this?" }, { "prediction": "Why not use `PathUtils.toAbsolutePath(instanceDir)` instead of `PathUtils.toAbsolutePath(instanceDir)`?", "reference": "A bit late, but I don't think this is necessary, as all callers will send absolute paths. And if you ever get a relative path, resolving it with `toAbsolutePath()` leads to it being relative to whatever CWD the app is started with, while the typical resolving of relative `instanceDir` is to resolve it relative to CoreContainer#coreRootDirectory." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "There's an awful lot of test failures here because `localFieldPathType.schema` may not contain a `getters` array." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Mysql allows for `||` concatenation (e.g. `firstname||' '||surname`) if you enable it: `set sql_mode=PIPES_AS_CONCAT;`. I think this check is safer though" }, { "prediction": "I don't think we need this.", "reference": "NOTE: this is the default ENS registry address. If the ENS suite is deployed from the current builds to any chain, it will always be found at this address." }, { "prediction": "I'm not sure if this is the right place to draw videos, but I'm not sure if it's the right place to draw videos, or if it's the right place to draw videos, or if it's the right place to draw videos, or if it's the right place to draw videos, or if it's the right place to draw videos, or if it's the right place to draw videos, or if it's the right place to draw videos, or if it's the right place to draw videos, or if it's the right place to draw videos, or if it's the right place to draw videos, or if it's the right place to draw videos, or if it's the right place to draw videos, or if it's the right place to draw videos, or if it's the right place to draw videos.", "reference": "I'm curious why you are using `draw` in this route file?" }, { "prediction": "I think this should be `ctx.Handle(404, \"GetRawDiff\", err)` and not `ctx.Handle(404, \"GetRawDiff\", err)`", "reference": "Those variables are only been used once, I think we don't need to create them at all, just pass values to the `GetRawDiff` directly." }, { "prediction": "I don't think this is needed anymore.", "reference": "I like the idea of replacing all the `#if NET461` with `#if NETFRAMEWORK`... is that worth doing now? Means fewer changes if we go to 4.7.2 at some point" }, { "prediction": "I think we should rename this to `clutchProviderName`", "reference": "to fix the docs build failure, make this const var named without the suffix `Name`" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea.", "reference": "This bugfix also included, in case a subjectAlternativeName was present in the cert, then URIs (e.g SVID SPIFFE auth) would not have been attempted." }, { "prediction": "I don't think we need this interface.", "reference": "Same here. Feels like the wrong location." }, { "prediction": "I'm not sure if this is the right place to import `mhtml` or `download_path_suggestion`.", "reference": "Please make `_path_suggestion` public (i.e. remove the `_`) in `downloads.py`." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "Woah, these flag names gotta get shorter. (Edit: I'll try to suggest some if needed, will think on it.)" }, { "prediction": "I'm not sure if this is the right place for this initializer, but I'm not sure if it's the right place for this initializer.", "reference": "Is this the code that's supposed to use the Rails app's only when in Rails4? What's the point of the first `if app.respond_to?(:secrets)`, both the `if` and the `elsif` have the same body, is only the second one needed? If `app.config` has a `secret_key_base`, then use it, the end. Is there a need for first checking if `app.respond_to?(:secrets)`?" }, { "prediction": "I don't think this is needed.", "reference": "Does this not apply to C enums on Linux?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Should this check if the error is `RetryableWriteError` before adding the label?" }, { "prediction": "I'm not sure if this is the right place to use rollup-plugin-commonjs or rollup-plugin-commonjs. I'm not sure if rollup-plugin-commonjs is the right place to use rollup-plugin-commonjs or rollup-plugin-commonjs. If rollup-plugin-commonjs is the right place to use rollup-plugin-commonjs, then rollup-plugin-commonjs will automatically resolve `.default`. If rollup-plugin-commonjs is the right place to use rollup-plugin-commonjs, then rollup-plugin-commonjs will automatically resolve `.default`. If rollup is the right place to use rollup-plugin-commonjs, then rollup-plugin-commonjs will automatically resolve `.default` and rollup-plugin-commonjs will automatically resolve `.default`.", "reference": "Oh wow, that's one complicated require :)" }, { "prediction": "I'm not sure if we should change this to `request_context.go` or `request_context.go`", "reference": "do you mean how to \"use\"" }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if this is the right thing to do.", "reference": "We can't really test this anymore since ref and props.ref are at the backing node level now" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "Did you intend to set this in the constructor?" }, { "prediction": "I don't think this is the right place for this.", "reference": "This looks fine as a first approach, and can we put a TODO here about ubuntu 18.04 being hardcoded?" }, { "prediction": "I don't think this is needed anymore.", "reference": "This isn't strictly needed since lmdb / leveldb data that is unencoded does not require OpenCV IO. I think `DataLayer` should only require lmdb / leveldb. If one tries to use encoded data without OpenCV the `DataTransformer` guards will report the dependency failure." }, { "prediction": "I don't think this is the right place to do this.", "reference": "Should we take out this change? This was only in there to try to brute force the start of the apiserver yesterday." }, { "prediction": "Align the elements of a hash literal if they span more than one line.", "reference": "I worry that this association name is a bit confusing. Yoz was asking me about the concept of completion yesterday, which is why I think of it. It wasn't clear to him exactly what it was. what about calling this a `step_completer`? we know that a proposal has many steps, so I think that might be clearer. in the future, we also might want the rename the `approver` relation because a step is not always an approval these days." }, { "prediction": "I don't think we need this anymore.", "reference": "Just add a to-do saying we need to add api-version in the check some time in the future when we enable the single-swagger spec mode for validation." }, { "prediction": "I think this should be `setDatasource('thelia','mysql')`", "reference": "@lunika Please see this. It allows us to do `Propel::getConnection()` easily, as we have only one database." }, { "prediction": "I think this should be `IHasTags = scope.Span.Tags as IHasTags;`", "reference": "Not related to this particular cast but I wonder if we shouldn't have a cast helper that would log if null to gain visibility." }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if it's the right way to do it.", "reference": "why do we need to explicitly declare these fields?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Note that there are multiple OAI servers -- that's why `$serverClass` is a variable here. You'll want to fetch `$serverClass` from the service manager rather than a hard-coded value, and also set up a module.config.php for the authority record version, `VuFind\\OAI\\Server\\Auth`. Should be easy enough since it can share the same factory." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This is no longer needed and should be removed." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "could use named return params here to avoid declaring the opts, and using naked returns instead." }, { "prediction": "I don't think this is needed.", "reference": "this is an unrelated fix. I noticed when an instagram carousel post is mixed with images and videos, the videos don't come with thumbnails, so I am adding a fallback thumbnail for this case." }, { "prediction": "I don't think this is needed.", "reference": "\"... after protocol version 1\"?" }, { "prediction": "I don't think this is needed.", "reference": "Is there a unit test that covers this regexp? I am afraid that changing it might break things =/" }, { "prediction": "Please use `String#toLowerUnderscore()` instead of `String#toLowerUnderscore()`.", "reference": "This change is okay IMO because an `@` variable in Ruby is not a reference -- `@` variables are instance variables. Also, it's never used by the Ruby transformers." }, { "prediction": "I don't think we should change the name of the payment.", "reference": "Why this change was needed? Because in `po` files it's with curly braces?" }, { "prediction": "I'm not sure if this is the right fix.", "reference": "Wait -- where did this change come from? This seems unrelated to trace building and seems like it could affect basic execution, unlike the rest of this PR which is all under the off-by-default trace option. Please separate this into its own PR and probably ask @AssadHashmi to review." }, { "prediction": "I'm not sure if this is the right place to put presets. I'm not sure if it's the right place to put presets. I'm not sure if it's the right place to put presets, but if it's the right place to put presets, I'm not sure if it's the right place to put presets. If it's the right place to put presets, I'm not sure if it's the right place to put presets. If it's the right place to put presets, I'm not sure if it's the right place to put presets. If it's the right place to put presets, I'm not sure if it's the right place to put presets. If it's the right place to put presets, I'm not sure if it's the right place to put presets. If it's the right place to put presets, I'm not sure if it's the right place to put presets. If it's the right place to put presets, I'm not sure if it's the right place to put presets.", "reference": "seems to be redundant (mention `docusaurus` )" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "Can we combine this with the Rollback API? We could still support the `rollback` method here, but combine `Rollback` and `CherryPick` into something like `ManageSnapshots`. Then we could reuse logic for enforcing checks of the current snapshot. What do you think?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Maybe just `env_prefix`, I don't think this is referring to the WQ manager." }, { "prediction": "I don't think this is needed anymore.", "reference": "Unrelated line change :)" }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "I raised an eyebrow at making `net` depend on `k8s.io`, but it seems we're already doing that." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I think ticket meant, not applying replacement in this method, but rather applying encodeSomeHtml to each and every localization string" }, { "prediction": "I don't think we need this check.", "reference": "ticket for the 4.0 epic?" }, { "prediction": "I think this should be `True`", "reference": "`cfg.model.get('neck')` will return None if neck does not exist, thus we can omit the default value." }, { "prediction": "I don't think we need this anymore.", "reference": "Trailing whitespace detected." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "I don't see why a `cxxflags` key is necessary? C flags are important in the target file because they define things like the float ABI. But these flags are also used for C++. I can't think of a reason why you would want to configure C++ flags in a target file." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Update year range in Copyright notice, and elsewhere too." }, { "prediction": "I'm not sure if we need to change this. I'm not sure if we need to change this. I'm not sure if we need to change this.", "reference": "Can we update this PR to not be a breaking change? i.e. if a user specifies `accessKeyID`, it is still used. But if a user specifies `accessKeyIDSecretRef`, it takes precedence?" }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it.", "reference": "You don't actually need both tests here as \"truthiness\" means that `\"0\"` is false and hence the first test will be true..." }, { "prediction": "I don't think we need to change this test.", "reference": "Everything else in here is using `I18n`. Should we do that here to be consistent?" }, { "prediction": "I'm not sure if this is a good change.", "reference": "What do you think about changing the ordering to be `::`? I think it matches the most with what we previously had so that it doesn't change too much for our users." }, { "prediction": "I'm not sure if this is the right fix.", "reference": "I'm fairly sure this precondition is always true due to the mod (%)" }, { "prediction": "I'm not sure if this is the right fix.", "reference": "I love seeing diffs like this one, adding a `String` message to an otherwise cryptic `assert`! It makes me realize you must have had a hellacious debugging session!" }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if this is the right thing to do.", "reference": "1. No logger exists to produce a message 2. Can't assume the latest version because missed version means 0." }, { "prediction": "I don't think this is needed.", "reference": "I saw a wrong reuse of the cache between a partial analysis of a single file and a full run where errors due to lack of context on the first partial run was reported on the full run. Shouldn't we use a hash that is composer.lock + psalm.xml + command line to be safe?" }, { "prediction": "I don't think we need this anymore.", "reference": "Could you also update it in `at_time`?" }, { "prediction": "I think this should be `Boolean.parseBoolean()`.", "reference": "Because schema is non-final we can't just switch this to a lambda" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "proposal: **always** add the exception to the end of the message. So no need to to pass exception twice (implicit and explicit). Need a lot of changes." }, { "prediction": "I think this should be `InvocationStartProcessingEvent event = (InvocationStartProcessingEvent) data;`", "reference": "why? event.getInvocationType is not you want?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea, but I think it's a good idea.", "reference": "nit: how about `GitSHA`?" }, { "prediction": "I think this should be `makeflow.failed.%d` or `makeflow.failed.%d`", "reference": "If you move the other functions, this should also be moved to `makeflow_gc.h`." }, { "prediction": "I don't think this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "This whole block bugs me. Expire_time to me suggest that an absolute time of when something happens and duration is an interval of time. While the code looks correct, it feels awkward to read." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Can we add `_dom` as an argument to createVNode here? I think it might be shorter (could totally be wrong!)" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I think that the iret handling is not yet good." }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "Huh, that's kinda weird. I get it, but it's unexpected to me..." }, { "prediction": "I'm not sure why this was removed.", "reference": "why is this removed? it is important when you upload from stream of unknown size" }, { "prediction": "Line is too long. [89/80]", "reference": "Out of curiosity, why is this needed? Does it enforce what class can be assigned?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do it.", "reference": "non-blocking: Now that we have a handful of statements which deal with creating a listener, it may make sense to introduce a `createListener` method or something similar" }, { "prediction": "I don't think we need to create a new instance of `MevBlockProductionTransactionsExecutor`", "reference": "factory should be stateless if possible, looks like much complexity added" }, { "prediction": "I think this should be `Project ID on which to run the BigQuery Job`.", "reference": "Could you please add short description for the default value as well?" }, { "prediction": "I think this should be `err := logger.Fatal().Err(err).Msgf(\"Failed to commit state changes on height %d\", blk.Height())`", "reference": "Leave a TODO message to say we will fix the log level in the future, once committing the block and the state become a transaction" }, { "prediction": "I think we should rename this to \"write.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.parquet.delete.delete.parquet.delete.delete.parquet.delete.par", "reference": "this can be integer" }, { "prediction": "I don't think we need this.", "reference": "nitpick: Please remove the blank line here" }, { "prediction": "I don't think we need this anymore.", "reference": "What is this for? The only methods I can see by that name in the rails doc are generating a foreign key name from a model class name but you seem to be giving a key name as argument?" }, { "prediction": "I think this should be `authenticationPlugin!= null && authenticationPlugin.plugin.getMetricRegistry() == null && pkiAuthenticationPlugin!= null && pkiAuthenticationPlugin.getMetricRegistry() == null && pkiAuthenticationPlugin!= null && pkiAuthenticationPlugin.initializeMetrics(metricManager, SolrInfoBean.Group.node.toString(), metricTag, \"/authentication/pki\");`", "reference": "Is this second check necessary? we know that just after the plugin was created its metricRegistry is null, it's set only after `initializeMetrics` has been called." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but I'm not sure if it's the right place to do it.", "reference": "shouldn't this be `return TALKACTION_BREAK;` as the player does not meet the required group access?" }, { "prediction": "I think this test should be `verify(clique.blockIsCreatedByProposer(minerNode1));`", "reference": "does this still work if minerNode1 has already proposed a block before 2 & 3 are stopped?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I am wondering if we can either make this a feature or have a way to turn it off in production. My concern is that we might be adding more of these kind of code in the future." }, { "prediction": "I don't think we need this anymore.", "reference": "We can just use `.stack()` here? Then I guess we can reuse when supporting multi-index columns." }, { "prediction": "I don't think this is needed.", "reference": "What are the possibilities here? Since we plan on supporting.net standard 2.0 from day 1, we might as well tackle that now." }, { "prediction": "I'm not sure if this is the right place for this method, but it seems like it should be `SpanContext` or `SpanReference`. I'm not sure if it's the right place for this method, or if it's the right place for this method, or if it's the right place for this method.", "reference": "should the parameters be called reference or context?" }, { "prediction": "I'm not sure if this is the right place to use `byteslice` or `byteslice_from_buffer` or `byteslice_from_buffer` or `byteslice_from_buffer` or `byteslice_from_buffer` or `byteslice_from_buffer` or `byteslice_from_buffer` or `byteslice_from_buffer` or `byteslice_from_buffer` or `byteslice_from_buffer` or `byteslice_from_buffer` or `byteslice_from_buffer` or `byteslice_from_buffer` or `byteslice_from_buffer` or `byteslice_from_buffer` or `byteslice_from_buffer` or `byteslice_from_buffer` or `byteslice_from_buffer` or `byteslice_from_buffer` or `byteslice_from_buffer` or `byteslice_from_buffer` or `byteslice_from_buffer` or `byteslice_from_buffer`", "reference": "Do we need to also change `length` here (and below) to `bytesize`? Perhaps we ought to make a copy of `in_buffer` encoded as binary and then the existing algorithm should work." }, { "prediction": "I think this should be `url.toString()` instead of `url.toDisplayString()`", "reference": "This should be `toDisplayString()` to not contain e.g. passwords." }, { "prediction": "I'm not sure if this is the right place to set it.", "reference": "Can we just say that having a non-nil `autocomplete_path` implies that autocomplete is enabled?" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "Note that the package github.com/golang/protobuf/proto is deprecated. We're instructed to use the \"google.golang.org/protobuf/proto\" package instead. I didn't want to change it now to avoid intrusive changes whose consequences are, currently, unknown." }, { "prediction": "I'm not sure why this was removed.", "reference": "Are these gone routes? Do we need to 301 them?" }, { "prediction": "I don't think this is needed anymore.", "reference": "move them to internal group of imports" }, { "prediction": "I think this should be `glog.Errorf(\"Please handle cStorPool '%s' event on '%s'\", string(operation), string(cStorPoolGot.ObjectMeta.Name))`", "reference": "can we rewrite this as: `ignored event '%s' for cstor pool '%s'`" }, { "prediction": "I don't think we need this column anymore.", "reference": "not all client data types have an approving official (eg: 18F does not). do we still want to include the relation here?" }, { "prediction": "`T extends WebElement` should be `T extends WebElement`.", "reference": "This change should also probably go into the corresponding method of the abstract By class?" }, { "prediction": "I think we should remove the `util.combineBaseUrl` from the `util.combineBaseUrl` function.", "reference": "why this remove?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `io.ReadCloser` or `io.ReadCloser`.", "reference": "As the test failures indicate, making this change is going to mean changing everything which currently implements this interface." }, { "prediction": "I'm not sure if this is the right place to put this redirect.", "reference": "Do we want to redirect this to the forum or something in case people have it linked/bookmarked?" }, { "prediction": "I'm not sure if this should be 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM' or 'NM'", "reference": "@peterzimon came up with this 'NM' piece as a placeholder for New Member initials, without this the screen looks broken. It changes to normal initials calculation once email or name is entered. Lmk if you'd like to put something different here ;)" }, { "prediction": "I think this should be `member-subscription` instead of `member-subscription`.", "reference": "@kevinansfield Would be cool if you can take a if this is the best way to add `subscriptions` info on member model. This uses the transform + separate model definition way which seemed to be the right way from other references in Admin" }, { "prediction": "I don't think this is needed.", "reference": "This is the common way of dealing with optional dependencies" }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "nit: we can replace all `kr` in this file with like `src`." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "same concern here as above" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Thank you for this, I gather this repairs failures that I've seen in another PR." }, { "prediction": "I don't think we need to change this.", "reference": "This place probably makes sense to me. We can consider exposing an argument to make the dedup step optional (I am not sure it is a good idea but I want to think this through together). The dedup step we are adding is going to trigger a shuffle. Technically, we are fine in the existing expire snapshots action as it does the dedup in `except`. The question is what kind of performance impact deduplicating here will have. We only have duplicates if multiple manifests reference the same files. In `rewrite_manifests` procedure, we rewrite all manifests, meaning we produce a snapshot with new manifests where entries are old data files. Also, there are updates and deletes that may rewrite manifests. I think deduplicating here makes sense to me in all cases. Thoughts, @rdblue @flyrain @RussellSpitzer @karuppayya?" }, { "prediction": "I don't think we need to delete the osdconfig data from etcd config.", "reference": "can we move the code before deleteNodeFromDB? this way even if the node crashes after remove config we can still re-run decommission again?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Seems the default value of `melt`'s `var_name` at namespace.py should be changed as well." }, { "prediction": "I don't think we need to do this. I'm not sure if we need to do this in the future, but I'm not sure if we need to do this in the future or if we need to do it in the future.", "reference": "I think botocore's serializer should already create the correct headers. However, they are currently not used in `_botocore_parser_integration_test`(line #217). Maybe we could remove the headers here and just use a fallback in the `_botocore_parser_integration_test` (i.e. use the given headers if they are set, otherwise use the headers generated by botocore's serializer)?" }, { "prediction": "I don't think we need to change the title here. I think we should change the title to something more descriptive.", "reference": "This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted." }, { "prediction": "I don't think we need to change this.id or _getName(this.id) or _getName(this.name) or _getName(this.id)", "reference": "in case you want to rename one of the plugins when instantiating, from options?" }, { "prediction": "I think this should be `CTU_FUNC_MAP_CMD = 'clang-func-mapping'`", "reference": "This default variable should be moved into a config variable, created by `package_context`, and read from `config\\package_layout.json`." }, { "prediction": "I'm not sure if this is a good test.", "reference": "Can I ask you to add a new line after `const` assignment? I believe that this increases the code readability by encapsulating assignment and logic (expecting) blocks." }, { "prediction": "I don't think this is needed.", "reference": "So the intention is you configure with `-CMAKE_CXX_FLAGS=\"-D KOKKOS_IMPL_TURN_OFF_CUDA_HOST_INIT_CHECK\"`?" }, { "prediction": "I don't think we need to change this.", "reference": "This was a bug." }, { "prediction": "I think this should be `$isAttributeClassExistsAndNotEmpty = array_key_exists('lazy', $attributes)? (bool)$attributes['lazy'] : true;`", "reference": "Is OK that we don't have some placeholder?" }, { "prediction": "I don't think we need to change this?", "reference": "Sectorbuilder behaves differently depending on whether it's given 1 or more threads. It won't seal if only given 1." }, { "prediction": "I don't think this is needed.", "reference": "Sort of believe We should put MetricManager in constructor parameter given this case." }, { "prediction": "I don't think this is needed.", "reference": "Do we need to check `fieldId` is larger than 1000?" }, { "prediction": "I'm not sure if this is the right place to call `onWriterChangeReceivedByAll` or `onWriterChangeReceivedByAll`", "reference": "I think this should be called after the if below (the one for disable positive acks)" }, { "prediction": "I don't think we need to change this method.", "reference": "I'd like to avoid changing this method since it is public and using a URI will probably change behavior for users passing strings (String -> URI -> Path instead of String -> Path)." }, { "prediction": "I'm not sure if this is the right place for this test. I'm not sure if it's the right place for this test.", "reference": "Should these restore the stashed env after the test runs?" }, { "prediction": "I think this should be `if d is not None` or `if d is not None` or `if d is not None` or `if d is not None` or `if d is not None` or `if d is not None` or `if d is not None` or `if d is not None` or `if d is not None` or `if d is not None` or `if d is not None` or `if d is not None` or `if d is not None` or `if d is not None`", "reference": "We're calculating the full list of kwargs here (even if the first element of the list would return True) so we could improve performance by using a generator line 408 in ``for default_node in all_defaults:``." }, { "prediction": "I don't think we need to change this to `accountDeltaCount` or `accountDeltaCount`?", "reference": "Can ndelta differ depending on when the deltas are compacted? That is, when intermediate updates are dropped?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Our checkstyle config likes it better when the `

    ` is before the first word of the next paragraph, and not on a blank line" }, { "prediction": "I think this should be `cmd.Start()` instead of `criuServer.Close()`", "reference": "This looks to be the only place where we return early before the close below, so if the \"double close\" is bothering people, closing manually here (and removing the `defer`) could be an option" }, { "prediction": "I'm not sure if this is the right place to run `npm run test:js` or `npm run test:js` or `npm run test:js` or `npm run test:js` or `npm run test:js` or `npm run test:js` or `npm run test:js` or `npm run test:js` or `npm run test:js` or `npm run test:js` or `npm run test:js` or `npm run test:js` or `npm run test:js` or `npm run test:js` or `npm run test:js` or `npm run test:js` or `npm run test:js` or `npm run test:js` or `npm run test:js`", "reference": "This task can probably be deleted since we don't need gulp to run Jest." }, { "prediction": "I don't think this is needed.", "reference": "Doesn't this need to include `Errno::ECONNRESET` to fix the issue?" }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do this.", "reference": "never heard of a qirector... what's their role again? (also should be 'for a movie')" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "Implement the \"collect all props for one vertex\" logic inside QueryVertexPropsProcessor" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This is to prevent parsing things like \"1.1\" as \"1\" until we implement it properly." }, { "prediction": "I don't think this is needed anymore.", "reference": "Can we change `_getCheckpointParentDir` to be a public function explicitly? It seems like something that clients of experiment runner may wish to use." }, { "prediction": "I don't think this is the right label for a group of advanced options in the Advanced settings panel.", "reference": "Why is a restart necessary?" }, { "prediction": "I'm not sure if this is the right place to handle external instances or internal instances. I'm not sure if this is the right place to handle external instances or internal instances. I'm not sure if this is the right place to handle external instances or internal instances.", "reference": "Should setting the task runtime also go under the above if condition?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "SPIRE uses the leadingLowerCase convention for unexported constants" }, { "prediction": "I don't think this is needed anymore.", "reference": "The newest JSchema code generator orders `System` usings first." }, { "prediction": "I don't think this is the right place to do this, but I think it would be better to move this logic into `IcebergSerDe` class and use `IcebergSerDe.create(configuration, tableSchema, caseSensitive)` in `IcebergSerDe.java` to make `IcebergSerDe.create(configuration, tableSchema, caseSensitive)` a `IcebergSerDe.create(configuration, tableSchema, caseSensitive)` method, and call `IcebergSerDe.create(configuration, tableSchema, caseSensitive)` from `IcebergSerDe` to `IcebergSerDe.create(configuration, tableSchema, caseSensitive)` in `IcebergSerDe.java` method.", "reference": "I understand that we want to have a possibility to configure the IcebergInputFormat to be case sensitive or case insensitive since it can be used by other MR jobs as well. Do we want to allow the users of Hive to shot themselves on the foot and enable case sensitivity? My first guess would be that we should not use the configuration here, just go with `false`, but if you have some specific use-case in your mind I can be easily convinced" }, { "prediction": "I don't think this is needed.", "reference": "Will the above call to cStorPoolAddEventHandler() get executed in the same thread as this line?" }, { "prediction": "IsAAllocaInst().IsNil() { // No suspend points or stack allocations. Lower without turning it into a coroutine. c.lowerFuncFast(fn) }", "reference": "I don't think alloca instructions are always at the start of the entry block. I think it would be safer to check the entire entry block for alloca instructions, just in case some are not the first instruction. (Technically they can be anywhere in the function but we check in other places that this isn't possible)." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Why isn't this 4789 (which I think is the Felix default)?" }, { "prediction": "I'm not sure if this is the right event.", "reference": "Can this be `Import operations failure`? In addition, is this the right time to change the variable names? e.g. `ReasonImportOperationsFailure`, `ReasonImportFailure`, `ReasonImportSuccessful`, `ReasonCreateResourceFailure`, `ReasonImportResourceSuccessful` Naming convention that i have assumed here is as follows: `Reason`" }, { "prediction": "I don't think this is needed.", "reference": "I suspect this isn't needed because I think `rb_intern` gets marked already." }, { "prediction": "I think this should be `log.finest(\"In dev mode. Copying required files in case we're using a WebDriver-backed Selenium\")`", "reference": "This change is incorrect: the current log level is correct." }, { "prediction": "I don't think we should change this to `VERSION_LOW_CARDINALITY_LEAVES`", "reference": "Can you add a space before the equal sign? There are a couple other places where spaces are missing in this PR." }, { "prediction": "I don't think this is needed anymore.", "reference": "Please follow the todo naming convention." }, { "prediction": "I don't think this is needed.", "reference": "These are no longer used and changes should instead be made directly to the files in `deploy/chart/crds` /assign @JoshVanL /unassign" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Is this really necessary to work around this way? The old version works fine with me when converting to ONNX." }, { "prediction": "I think this should be `errors.New(\"Blob already closed\")`", "reference": "Same as above: don't start error strings with a capital letter, and don't fix unneeded things in an unrelated commit ;)" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Is this a testing debug statement?" }, { "prediction": "I don't think this is the right place to do this.", "reference": "you'll need to wrap the _whole thing_ within this async call (or refactor it so everything below is in a new temporary function). The code below this section depends on a value for `object` after the parsing occurs, but what you're doing here is kicking off a race condition where `object` is null, but _might_ parse quickly enough to assign it the parsed parts. Instead, you need to do everything that depends on the parsed object in the callback of `parse`." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `std::unique_lock` or `std::unique_lock` here.", "reference": "This is now going to be protecting `stopped` when it doesn't need to. If you are going to do this then can you make `stopped` non-atomic and protect it in `stop`. It's cheap to make a `unique_lock` fyi, it's just a pointer to a mutex and a `bool`. The `lk.lock ()` in the loop is superfluous so probably shouldn't have been there to begin with." }, { "prediction": "I'm not sure if this is the right place to put this in.", "reference": "Lets not give packages names if we dont have to. If a package requires a rename, we should change the actual name while/if we can." }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it. I'm not sure if this is the right way to do it, but I'm not sure if it's the right way to do it, and if it's the right way to do it, it's the right way to do it, and if it's the right way to do it, it's the right way to do it, but if it's the right way to do it, it's the right way to do it, and if it's the right way to do it, it's the right way to do it, and if it's the right way to do it, it's the right way to do it, and if it's the right way to do it, it's the right way to do it.", "reference": "Not sure I see where this is coming from. This is a bug fix? Should be mentioned in the commit message? Same below." }, { "prediction": "I'm not sure why this was removed.", "reference": "I reverted this change in the last commit, I think we should revert it here. I know this leads to confusing test output for skipped tests, but I would prefer to tackle that in a separate PR specifically focused on that problem. In fact, I think the issue might really be with the leak checker, and not how this test runner is defined. Please make a ticket for this (if it doesn't already exist) and revert this change" }, { "prediction": "I think this should be `True` or `False`.", "reference": "Can this part be done in `dataset.get_ann_info`? Just like CocoDataset converts xywh to xyxy in `_parse_ann_info`" }, { "prediction": "I'm not sure if this is the right place for this change.", "reference": "Should we change the name of this test struct to be `testTracerProvider` as well?" }, { "prediction": "I don't think this is needed.", "reference": "\"google.golang.org/grpc\" should be together with \"go.uber.org/zap\" all \"\"github.com/iotexproject/iotex-core/*\" stay together" }, { "prediction": "I think this should be in the `_init_stylesheet` method.", "reference": "No need for a separate variable here - just call `utils.read_file` directly below." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it.", "reference": "Thanks for the fixing, small question, Here the message just be written to the channel, will it be blocked?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "maybe we will have something like `Bodies []byte(\"bodies\")` instead of them being a number? with numbers we are making it harder to insert stages mid-process." }, { "prediction": "I'm not sure about this, but I'm not sure if it's a good idea to rename the `ExternalEntityReference` to `ExternalEntityReference` or `ExternalEntityReference` to make it clear that the `ExternalEntityReference` is the same as the `ExternalEntityReference`. I'm not sure if it's a good idea to rename the `ExternalEntityReference` to `ExternalEntityReference` or `ExternalEntityReference`, but if it's a good idea to rename the `ExternalEntityReference` to `ExternalEntityReference`, I think it's a good idea to rename the `ExternalEntityReference` to `ExternalEntityReference` or `ExternalEntityReference` to `ExternalEntityReference`.", "reference": "out of curiosity, why making this change? If no real reason, could you restore to avoid unnecessary changes of several generated files?" }, { "prediction": "I think this should be `StateEventPublisher.Publish(StateEventTopic, StateEvent{ State: NotConnected, SessionInfo: manager.sessionInfo, })`", "reference": "Could we public events if `manager.serStatus()`?" }, { "prediction": "I don't think we need to check that the element exists on the page, or that the plugin you are targeting has been installed.", "reference": "could be misread as ``, maybe something redundant but very clear like \"before the closing `` tag\"?" }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "This test is specifically checking behavior on sync I/O (note there are tests with Write in the name, and other tests with WriteAsync). Enable sync I/O here." }, { "prediction": "I don't think we need to do this. I think we should do this in a separate PR.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I think this should be `cstorVolumeSource`", "reference": "nit: Should we have something like `volumeName@snapShotname` and this will be filled only if it is a clone creation" }, { "prediction": "I think this should be `if err!= nil { return err } else if err!= nil { return err } else if err!= nil { return err } else if err!= nil { return err } else if err!= nil { return err } else if err!= nil { return err } else { return err }", "reference": "This seems like an improved pattern :)" }, { "prediction": "I think snakebite is not needed anymore.", "reference": "I think it would be better to have a separate configuration option for specifying which HDFS interaction layer to use instead of using the existing hadoop version option. I think there are still cases where things might have to rely on Hadoop version for other things, and overwriting that information with \"snakebite\" would make that difficult. The existing hadoop version option could still be used to distinguish the different HDFS CLI flavours." }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if it's the right place to do this, but I'm not sure if it's the right place to do it.", "reference": "Why are we filtering content twice? It seems like just filtering it in PAL should work." }, { "prediction": "I don't think we need to change this.", "reference": "These should probably move to `constants.js`" }, { "prediction": "I don't think this is needed.", "reference": "Again, you don't want to depend on glassfish." }, { "prediction": "I'm not sure if this should be `2019, 06` or `2019, 06` or `2019, 06` or `2019, 06` or `2019, 06` or `2019, 06` or `2019, 06` or `2019, 06` or `2019, 06` or `2019, 06` or `2019, 06` or `2019, 06` or `2019, 06` or `2019, 06` or `2019, 06` or `2019, 06` or `2019, 06` or `2019, 06` or `2019, 06` or `2019, 06` or `2019, 06` or `2019, 06` or `2019, 06`", "reference": "it should be `Faker::Space.launch_vehicle`, otherwise it will crash" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this.", "reference": "Isn't it quite expensive to check whether the file exists on every write?" }, { "prediction": "I don't think this is needed.", "reference": "Please hide this behind a flag and add a setter function to the builder." }, { "prediction": "I think this route should be `/all`", "reference": "old api should be deprecated if we don't intend on using it anymore. Again this should happen through swagger api and then removed from next release. We should also release not this as a breaking change. (same with all the other cloudsnap api renames." }, { "prediction": "I think this should be `log.warn(\"can not listen {}, port may have been occupied, this may cause client report error when being accessed. skip {}\", ep.getSocketAddress(), this.getClass().getName());`", "reference": "so strange...... canTcpListen is to detect, if this transport can init when customers deployed vertx and servlet rest transport, we must detect which one will be used only both of them refused to init is a problem. we have already print that......" }, { "prediction": "I think this should be `SELECT_COUNT_FORM`", "reference": "Did you mean for this to be `FORM`, instead of `FROM`?" }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to add a `--enable-gzip-compressed` flag to the `aws secret manager` struct to make sure that the user data is gzip-compressed before it is sent to ec2 instance. I'm not sure if it's a good idea to add a `--enable-gzip-compressed` flag to the `aws secret manager` struct, or if it's a good idea to add a `--enable-gzip-compressed` flag to the `aws secret manager` struct to make sure that the user data is gzip-compressed before it is sent to ec2 instance. I'm not sure if it's a good idea to add a `--enable-gzip-compressed` flag to the `aws secret manager` struct to make sure that the user data is gzip-compressed before it is sent to ec2 instance.", "reference": "What are your thoughts on the long term solution for the naming of this variable? Do you think we should revert the logic when we are ready to make the next set of breaking API changes?" }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "There's a syntax error on this line." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "You lose the value of `result` when you `goto out`" }, { "prediction": "`ratio_ == undefined? 0 : this.ratio_; // Move the scrollbar slider.`", "reference": "Just a style thing, why not `this.ratio_ || 0`?" }, { "prediction": "I think this should be `getMaskedIp(ipNet.IPNet)`", "reference": "I think the stdlib's `net.IP` has a `Mask()` method, does that do what we need?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Why does substitute need to be public? Are we allowing/encouraging variable usage when using Daisy as a library?" }, { "prediction": "I think this should be `assert isinstance(js_elem, dict), js_elem = webengineelem.WebEngineElement(js_elem, tab=self._tab)`", "reference": "We should probably use ctrl-enter if `tab` is given, just like in `follow_selected`?" }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "This file looks like anti pattern `ServiceLocator` and lucky it's not used anywhere. Can I remove it? (in separate PR)." }, { "prediction": "I don't think this is needed.", "reference": "we can just have this method call the next, passing in the file metadatas (deduplication of logic)" }, { "prediction": "I don't think this is needed.", "reference": "What happens here if you send the `wheelEvent` directly to the `tabbed_browser` and let it take care of propagating it to its children (i.e. the focused tab)? If that works, I guess that'd be cleaner." }, { "prediction": "I don't think this is needed.", "reference": "it seems python 2 don't support `end=''`. @StrikerRUS @henry0312 any better solution? or we drop the support of python 2?" }, { "prediction": "I'm not sure if this is a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug.", "reference": "This test already exists in the object_tracker layer." }, { "prediction": "I think we should move this check to the `GoQuorumOptions.goQuorumCompatibilityMode` method. I think we should move this check to the `GoQuorumOptions.goQuorumCompatibilityMode` method.", "reference": "Same here, can we presume if `privacyParameters` is set we need goQuorum handling? Or is there a goQuorum sub option in `privacyParametes`?" }, { "prediction": "I think this should be done in a separate PR.", "reference": "The addition of delete files in `newManifests` far above the addition of data files threw me a bit. Is it intentional to ensure the delete files are at the front of the list?" }, { "prediction": "I'm not sure if this is the right thing to do here. I'm not sure if it's the right thing to do here.", "reference": "Interesting. The call to `Array(groups)` below this would seem to indicate this doesn't _have_ to be an array. I think the problem is actually that passing a hash to `Array()` actually converts the hash to an array of key/value pairs rather than wrapping it in an array. So maybe `Array(groups)` should be `groups = [groups] unless groups.is_a?(Array)`." }, { "prediction": "I think we should move this to the table properties. I think we should move the table properties to the table properties. I think we should move the table properties from the table properties to the table properties.", "reference": "This is not a particularly good default but we need it to keep the old behavior." }, { "prediction": "I'm not sure why this was removed.", "reference": "We have other tests to assert all properties of a condition are valid. It's enough to assert the condition is not nil here." }, { "prediction": "I don't think this is needed anymore.", "reference": "shouldn't the import be renamed `crdv1alpha1` by convention? It seems that you took care of renaming everywhere else..." }, { "prediction": "I'm not sure if this is the right place to put it.", "reference": "nit: Can Linux-specific paths be moved to a conditionally-compiled file for Linux?" }, { "prediction": "I'm not sure this is the right place for this method, but I think it's better to move this method to SessionMap.", "reference": "This is not the right approach. The `Distributor` maintains a model of the current state of the Grid. That model already contains the information about every active session. We don't need to modify `SessionMap` to expose it further." }, { "prediction": "I'm not sure if this is the right thing to do, but I think it's better to use `r.log.CDebugf(ctx, \"Treating for-push the same as a regular list\")` instead of `r.log.CDebugf(ctx, \"Treating for-push the same as a regular list\")`", "reference": "Git doc seems to suggest `for-push` is a optimization. Do we have a plan/ticket for treating them differently?" }, { "prediction": "I don't think this is needed.", "reference": "This not necessary since you moved the layers to `contrib/`." }, { "prediction": "I don't think we need to change this. I'm not sure if we need to change this.", "reference": "I think this also needs to be removed from `resources/bolt_bash_completion.sh`, `rakelib/pwsh.rake`, `lib/bolt_spec/plans.rb`, and `lib/bolt/config/options.rb`." }, { "prediction": "I'm not sure if this is the right place to put this test.", "reference": "I fixed this today with a direct push to master. My build was failing otherwise." }, { "prediction": "I don't think this is needed.", "reference": "not sure why this is in a \"rule\" child package from the interface..." }, { "prediction": "I don't think this is needed.", "reference": "Not needed, please remove." }, { "prediction": "I don't think this is needed.", "reference": "Shouldn't the logic be: * the result is a mismatch if either is a unix path but the other is not * if both are unix paths, then perform case-sensitive comparison * if both are not unix paths, then perform case-insensitive comparison" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "This is just rearranging it alphabetically" }, { "prediction": "I'm not sure about this, but I think it's better to add a `# pylint: disable=too-many-locals` to `pytest.mark.parametrize(['git_commit', 'frozen','style', 'with_webkit', 'known_distribution'], [ (True, False, True, True), # normal, True, True, True), # normal, True, True, True)]`", "reference": "I think this disables it for the rest of the file - you should be able to use it inside of the function instead." }, { "prediction": "I'm not sure if this is the right thing to do, but I think it's better to use `int` instead of `string`.", "reference": "this could receive the MediaInterface directly or an identifier, it is correct to type it with int|string? or just use mixed?" }, { "prediction": "I think we should move this method to `MultiLeafFieldComparator`", "reference": "Why not return `Object[]`?" }, { "prediction": "I don't think this is needed.", "reference": "Looks like we are trying to match the new ordering of fields in `ManifestFile`. Earlier, we co-located `...FilesCount` with `...RowsCount` to match the ordering of methods in `ManifestFile` and args in constructors. Is this change intentional?" }, { "prediction": "I don't think this is needed.", "reference": "You're already setting drop loot to false just above." }, { "prediction": "I think this should be `sync.Once`.", "reference": "`once` is very generic and doesn't specify it's purpose - `closeOnce`?" }, { "prediction": "I think this test should be protected.", "reference": "Why did this need to change from `private`? Oh for the test below. And this is only a test class too." }, { "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals:", "reference": "Should test the `has?` method here" }, { "prediction": "I think this test should be `$this->assertNotNull($link, 'Save Search')`", "reference": "I think you want to be asserting/clicking $saveLink, not $link." }, { "prediction": "I think this should be `Optional[str]`", "reference": "We don't have `target_name` on `@sensor` - why introduce it for `@asset_sensor`? If we do want to introduce it everywhere, can we just call it `job_name` to avoid introducing a new term?" }, { "prediction": "I don't think this is needed.", "reference": "Missing copyright header (+other new files)." }, { "prediction": "I'm not sure about this change, but I think it's a good idea to remove the `TIMESTAMP` field from the schema.", "reference": "Could we do the flag check here as well to check whether or not we have enabled the \"Handle without timezone\" flag here as well? We may be using this not on the read path (like in the migrate/snapshot code) and it would be good to catch it here as well and make sure users know what is happening." }, { "prediction": "I'm not sure about this, but I'm not sure if it's a good idea to rename this file to `pipeline_failure_sensor.py` or `pipeline_failure_sensor.py` or `pipeline_failure_sensor.py` or `pipeline_failure_sensor.py` or `pipeline_failure_sensor.py` or `pipeline_failure_sensor.py` or `pipeline_failure_sensor.py` or `pipeline_failure_sensor.py` or `pipeline_failure_sensor.py` or `pipeline_failure_sensor.py` or `pipeline_failure_sensor.py` or `pipeline_failure_sensor.py` or `pipeline_failure_sensor.py` or `pipeline_failure_sensor.py` or `pipeline_failure_sensor.py` or `pipeline_failure_sensor.py` or `pipeline_failure_sensor.py` or `pipeline_failure_sensor.py` or `pipeline_failure_sensor.py` or `pipeline_failure_sensor.py` or `pipeline_failure_sensor.py` or `pipeline_failure_sensor.py` or `pipeline_failure_sensor.py`", "reference": "why is the file named `pipeline_definition_definition_sensor`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "None not needed, can just be `return`. not important for this release" }, { "prediction": "The dispensed Algos have no monetary value and should only be used to enable development on the Algorand blockchain test networks. Please do not abuse it by requesting millions of Algos.", "reference": "I think it's missing closing `

    ` tags in line 108 and 109 unless they don't matter..." }, { "prediction": "I think this should be `String#valueOf(scriptEngineNameJavaScript)` or `String#valueOf(scriptEngineNameJavaScript)`", "reference": "So it seems that loading a script file from the classpath needs to be enabled explicitly now since this is `false` by default. Is it possible to enable this via the YAML config file in a Camunda Platform Run distribution?" }, { "prediction": "I don't think we need this anymore.", "reference": "can we delete any code in the provider implementation? i imagine the entire thing is unused now?" }, { "prediction": "This function is not used anymore.", "reference": "I suggest we remove all these unused functions. I don't expect any external projects to be importing packages from `cert-manager/test/...`" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Looks like the template argument doesn't resolve by default so you need `std::lock_guard lck`" }, { "prediction": "I don't think we need this anymore.", "reference": "Are we removing this public method? Could it be useful to someone? Maybe we could implement it once in Node using the metamodel" }, { "prediction": "I'm not sure if this is the right place for this method, but I'm not sure if it's the right place for this method.", "reference": "I think this method is unused now?" }, { "prediction": "I don't think we need to create a new status controller for the antrea policy.", "reference": "I know we discussed this before and decided to reuse the AntreaPolicy gate. But do you think realization status will introduce much overhead or not?" }, { "prediction": "I think this should be `/api/v1/namespaces/default/pods`", "reference": "please add a blank line at the end of this file. Applicable to similar cases below" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "This is not really needed, the line added in `GridNodeConfiguration.java` is what really fixes the `remoteHost` regression." }, { "prediction": "I think we should add a check for `toSearcher.getFilterCache().isAsync()` to ensure that `toSearcher.getFilterCache().isAsync()` is true.", "reference": "filterCache can be null" }, { "prediction": "I'm not sure if this is needed.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "If strstr returns NULL, the check on 378 won't fire, because param_name will be at least SET_PARAM_CMD_LEN." }, { "prediction": "I don't think this is needed anymore.", "reference": "Does this change affect the performance of other algorithms, except KMeans?" }, { "prediction": "I'm not sure if this is the correct behavior.", "reference": "What do these changes have to do with the request ID?" }, { "prediction": "I don't think this is needed anymore.", "reference": "I'm kind of surprised this doesn't require `typename`?" }, { "prediction": "I'm not sure if this is the right place to import agreement.", "reference": "nit: move this one down." }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do here.", "reference": "maybe'standard Tukey boxplot definition' if it is standard? Otherwise sounds like it is just *a* definition for boxplots..." }, { "prediction": "I don't think we need this.", "reference": "I feel we should not fix this." }, { "prediction": "I don't think this is needed.", "reference": "I think these are not necessary" }, { "prediction": "The flag will be removed. The flag will be removed.", "reference": "Please update the user guide too." }, { "prediction": "I think this should be `$locationMap[$location->id] = $location->discoveryDisplayName?? $location->name;`", "reference": "If you use `compact('name', 'code')` here, you'll get an associative array, which might make the rest of the code more readable (instead of using hard-coded 0/1 indexes)." }, { "prediction": "I don't think this copyright is needed.", "reference": "Should it be 2011-14 instead ;-)" }, { "prediction": "I'm not sure if this is the right place to set max idle connections. I'm not sure if this is the right place to set max idle connections.", "reference": "I want to write some type of test for this but there are not Getter methods to assert this value. I tried to extract the value via the stats that are exposed without luck." }, { "prediction": "I think this should be `Iterate Gsuite group settings from GCP API. Args: gsuite_id (str): Gsuite id.`", "reference": "This needs to take the group id, not the gsuite id." }, { "prediction": "I don't think we need to change this?", "reference": "These should use the constants defined in JsonTests.cs" }, { "prediction": "I don't think we need to track this event.", "reference": "Kind of unrelated to this PR, but let's update this to `getDataErrorComponent('search-console', error.message, false, false, false, error )` so that everything is passed as expected." }, { "prediction": "I think this should be `Results` or `ResultsDict`.", "reference": ":obj:\\`dataset\\` cannot be correctly rendered" }, { "prediction": "I don't think we need this method. I'm not sure if we need it.", "reference": "I think `email` is something we get from devise, and I think the goal of putting it in the generator was not to tie others to that particular implementation?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this. I'm not sure if it's the right place to do this, but if it's the right place to do this, I'm not sure if it's the right place to do it.", "reference": "If the span producers pushing to the queue do so faster than the this can drain, it will cause this to hang. I'm guessing we can update the `enqueue` method to check if the `stopCh` is closed and not send any more spans while this flushes what has already been pushed." }, { "prediction": "I don't think this is needed anymore.", "reference": "Not sure about that, an array is iterable right? But if I pass array, that clear method wont work" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "make sure the config changes stuck. are there any invalid config values? maybe write tests around empty `trust_domain`, negative/missing `ttl`, invalid `key_size`, etc..." }, { "prediction": "`window.__mochaResult__` should be `window.__mochaResult__`", "reference": "Why are you changing this?" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for it.", "reference": "@phirefly Can we look at a list of RWAs, or ask someone to double-check that this format is correct? Otherwise :shipit:" }, { "prediction": "I think this should be `DISTRIBUTION_MODE, \"none\"`", "reference": "Still request a local sort for bin-packing based on the defined table sort order." }, { "prediction": "I don't think we need to pass `user_id` to `request_candidate_sets`?", "reference": "As with the other PR, user name is better." }, { "prediction": "I don't think we need this.", "reference": "a peer's accounting lock is held during `Pay`. we should avoid adding additional blockchain calls here if possible." }, { "prediction": "I don't think this is needed.", "reference": "Maybe wording could be improved. Is this \"not enabled\" or it is \"not available\". Not sure about that." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it.", "reference": "I looked at the new `conditionalBranchesEvaluated` function and it looks like the part added is a duplicate of the line above?" }, { "prediction": "I don't think this is the right thing to do.", "reference": "can you put this flag in `blockRefInfo` instead? It would be a shame to add one more file per block, especially since we've run into inode limits. I guess `blockRefInfo` should maybe then be renamed to `blockInfo` or something. But we're stuck with the filename." }, { "prediction": "I don't think we need to check for nil here.", "reference": "Shouldn't we keep other parameters if only IP is empty? Or maybe return an error if it's a mandatory argument?" }, { "prediction": "I don't think we need to change this test.", "reference": "Was this just wrong before? The names indicated types but type wasn't specified. I guess the tests passed as comparison worked with ``type=None``?" }, { "prediction": "I think we should rename this to `colName` since it's not used anywhere else.", "reference": "icebergCol.name() is the unqualified column name" }, { "prediction": "I think this should be `insufficient_data_actions` and `ok_actions`", "reference": "It's generally a bad idea to use mutable types like lists as default values for parameters. Lots of strange, difficult to debug side effects can occur. I see that there was already one example of this prior to this commit which probably explains why it seemed innocuous to add more but I'm going to rework this before committing to master." }, { "prediction": "I think this should be `eslint-config-prettier`", "reference": "We run prettier as an eslint plugin, so this harmful" }, { "prediction": "I'm not sure if this is the right place to use dynamic types. I'm not sure if it's the right place to use dynamic types, but if it's the right place to use dynamic types, then I'm not sure if it's the right place to use dynamic types.", "reference": "Check if the TypeDescriptor and MemberDescriptor includes are necessary" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "delete the empty line here." }, { "prediction": "I'm not sure if this is the right way to test this, but I'm not sure if it's the right way to test this.", "reference": "Line is too long. [89/80]" }, { "prediction": "I think this should be `protected`.", "reference": "You don't need to expose this method to do what you want. There are already public addNewGetMapping, addNewPostMapping, and addNewDeleteMapping methods." }, { "prediction": "I'm not sure if this is a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change.", "reference": "This test passes in `dev`. Why wouldn't this work?" }, { "prediction": "I don't think we need to include the AWS Device Farm testing feature.", "reference": "ARN -> Amazon Resource Number (ARN)" }, { "prediction": "I'm not sure if we need to remove the `ILoggerFactory` and `KestrelTestLoggerFactory` from the `ConfigureEchoAddress` method. I'm not sure if we need to remove the `ILoggerFactory` from the `ConfigureEchoAddress` method.", "reference": "Why not use the overload that takes an instance?" }, { "prediction": "I'm not sure about this. I'm not sure if it's a good idea.", "reference": "`Blockchian` is a misspelling of `Blockchain` (from `misspell`)" }, { "prediction": "I'm not sure if this should be `json:\"-\"` or `json:\"-\"` or `json:\"-\"` or `json:\"-\"` or `json:\"-\"` or `json:\"-\"` or `json:\"-\"` or `json:\"-\"` or `json:\"-\"` or `json:\"-\"` or `json:\"-\"` or `json:\"-\"` or `json:\"-\"` or `json:\"-\"` or `json:\"-\"` or `json:\"-\"` or `json:\"-\"`` or `json:\"-\"`` or `json:\"-\"`` or `json:\"-\"`` or `json:\"-\"`` or `json:\"-\"`` or `json:\"-\"`` or `json:\"-\"`` or `json:\"-\"`` or `json:\"-\"`` or `json:\"-\"`` or `json:\"-\"`` or `json:\"-\"`` or `json:\"-\"`` or `json:\"-\"`` or `json:\"-\"` `json:\"-\"```", "reference": "`agent/gpu/nvidia_gpu_manager_unix.go:47: struct field lock has json tag but is not exported`" }, { "prediction": "I don't think this is needed.", "reference": "nit: better rename to `TEST_QUEUE_ARN` or `TEST_EVENT_SOURCE_ARN`" }, { "prediction": "I don't think we need to do this. I'm not sure if we need to do this, but I'm not sure if we need to do this.", "reference": "Would this mean that podMonitorSelectors suffer from the same issue if they are the only configuration set?" }, { "prediction": "I'm not sure if this is the right place to call `GetEnvironment` or `GetEnvironmentResponse`. I'm not sure if it's the right place to call `GetEnvironment` or `GetEnvironmentResponse`. I'm not sure if it's the right place to call `GetEnvironment` or if it's the right place to call `GetEnvironment` or if it's the right place to call `GetEnvironment` or `GetEnvironmentResponse`.", "reference": "`ctx` is unused in GetEnvironment" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "We usually use OkDialog()" }, { "prediction": "I'm not sure if this is a good option, but I'm not sure if it's a good option. I'm not sure if it's a good option, but if it's a good option, it's a good option.", "reference": "could we please change that to something that indicates that this feature is not \"production\" ready!" }, { "prediction": "I'm not sure if it''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''", "reference": "swim -> swin. Other configs and file names also should be modified." }, { "prediction": "I don't think we need to pass the key to the `get_bigquery_projectids` method. I think we should pass the key to the `get_bigquery_projectids` method instead of passing it to the `get_bigquery_projectids` method.", "reference": "nit: arg description for \"key\"?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "If we don't have a `dir` yet, we wouldn't need to do a sync right? If so, perhaps we can just `getStoredDir()` like `Attr()`?" }, { "prediction": "I don't think this is needed.", "reference": "I still don't seem to fully understand this. Why are we testing the host if DR_HOST_NOT_TARGET is not set?" }, { "prediction": "I'm not sure this is the right place for this test.", "reference": "in the current implementation, both schemes are supported (you can call either `/bzz` or `/v1/bzz`). i would suggest to keep it this way" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "hmm, I think we can just do `new Error(assembly.error)` and that should set `error.message` correctly too. I don't know why it was done this way with a separate `.message` assignment before :sweat_smile: Should we do `error.assembly = assembly` so the template editor can access it that way, rather than parsing `error.details`?" }, { "prediction": "I don't think this is needed.", "reference": "This should never be empty. The access field always needs a value of at least `c:0` or `r:0`" }, { "prediction": "I'm not sure if this is the right place to use RustParser, but I think it's better to use RustParser directly.", "reference": "Another question is, do we want to call `os.Getenv()` every time we parse a file? That seems a lot." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "minor: please rename all occurrences of `A` to `T`. please also rename `v` to `value`." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's worth it.", "reference": "Do we want it to be so dynamic? My first idea was to base it on SyncConfig.BeamSync." }, { "prediction": "I don't think this is the right thing to do here. I think it's better to use `Integer.valueOf(type.getBitMask())` instead of `Integer.valueOf(type.getBitMask())`", "reference": "can you change this instead to just `type.toString()` and then you wouldn't have to expose the getBitMask in the enum. (Alternatively you could have used `type.hashCode()` but that doesn't feel as nice)" }, { "prediction": "I don't think this is the right assertion.", "reference": "I'm confused by these tests. Shouldn't the template string `@importance_type@` have been replaced with the actual value of `importance_type`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Let's keep using NewKeeper so that it got covered by tests." }, { "prediction": "I don't think this is needed.", "reference": "I only see new imports. Is there any functional change in this file?" }, { "prediction": "I don't think we need to do this.", "reference": "ineffectual assignment to `err` (from `ineffassign`)" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`)" }, { "prediction": "I think this should be `WrapLogs()`", "reference": "Make sure the old logging functions still work, but add deprecation warnings (unfortunately Python suppresses deprecation warnings by default, so I'm not sure if anyone'll notice)." }, { "prediction": "I think this test should be `enableAuthorization(true)`", "reference": "Not directly related to the topic of this ticket: I think this API design is a bit confusing. To disable delemetry, I would write `managementService.enableTelemetry(false)` which is not intuitive to read. Maybe `toggleTelemetry` instead of `enableTelemetry` is more clear." }, { "prediction": "I don't think this is necessary.", "reference": "Again I suggest returning `AnnotatedCodeLocation[][]`." }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if it's the right place to do this.", "reference": "We should probably require an increased verbosity to output for anything below the cluster itself to avoid spamming the logs. It would also be good to give additional context as to what we are attempting to reconcile since the controller has multiple workers." }, { "prediction": "I'm not sure if we should add this to the `OptionsNetwork` struct. I'm not sure if we should add it to the `OptionsNetwork` struct, or if we should add it to the `OptionsNetwork` struct. I'm not sure if we should add it to the `OptionsNetwork` struct, or if we should add it to the `OptionsNetwork` struct. I'm not sure if we should add it to the `OptionsNetwork` struct.", "reference": "Not needed anymore" }, { "prediction": "I don't think this is the right place for this, but I think it's better to add a `Log.Debug(\"Enabling calltarget state by ref.\")` to the `NativeMethods.EnableCallTargetStateByRef()` method. It's not a big deal, but I think it's better to add a `Log.Debug(\"Enabling calltarget state by ref.\")` method to the `NativeMethods.EnableCallTargetStateByRef()` method.", "reference": "Am I right in thinking this completely avoids the situation where `enable_calltarget_state_by_ref` is `true`, but the managed integrations don't expect a by ref argument? For example, if there's an exception here, that seems like a fatal problem, as we would have a mismatch for jit rewriting? We should disable instrumentation entirely in that case shouldn't we? i.e. if this (or the existing `EnableByRefInstrumentation`) calls fail, should we bail out of this method entirely as we can't safely instrument?" }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "nit: spaces seem off" }, { "prediction": "I don't think we need to pass the `ExtractorCallbacks` to `PBFParser::PBFParser`", "reference": "shouldn't the em parameter be called ec?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Please change this to use o.DidSign(o) as implements this logic without performing any of these checks that duplicate something that JWT can do correctly. If the JWT deserialized properly, and DidSign returns true, the JWT was signed by one of the listed operator keys." }, { "prediction": "I think this should be `return ((FeedItem) o2.getComponent()).getPubDate().compareTo(((FeedItem) o1.getComponent()).getPubDate());`", "reference": "Talking about style, IMO extracting either `getComponent()` or `getPubDate()` to variables would make this line easier to read." }, { "prediction": "I don't think this is needed.", "reference": "package header missing" }, { "prediction": "I'm not sure if this is the right place to call `oldCatchError` or `oldCatchError`", "reference": "Just a thought (doesn't change the output or anything) - do you think we'll ever want to access the other properties of `oldVNode` from within `_childDidSuspend`? If so we could pass `oldVNode` here and then check these properties in the _childDidSuspend implementation. I don't have strong feelings either way, just occurred to me." }, { "prediction": "I don't think this is needed.", "reference": "We should be configuring the base paths somewhere.." }, { "prediction": "I'm not sure if this is the right thing to do here, but I think it's better to add a test for the `min_sizes` and `max_sizes` to the `build_anchor_generator` function.", "reference": "May also need to test the normal functionality with min/max_sizes" }, { "prediction": "I don't think this is needed.", "reference": "We can remove this one. It's just a random one I got for free for testing." }, { "prediction": "I don't think we need to do this.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I don't think this is needed.", "reference": "(maybe this should be MyDevice or just removed entirely?)" }, { "prediction": "I'm not sure if this is the right place to send an event. I think we should send an event whose Task is nil.", "reference": "Can you do a nil check here, as the task isn't always nil here?" }, { "prediction": "I don't think this is needed anymore.", "reference": "`lodash` shouldn't be grouped under WordPress dependencies" }, { "prediction": "))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))", "reference": "Does order matter? Should we sort by enode key to make duplication checking easier?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "Can you explain this too? This seems to go beyond linting." }, { "prediction": "I'm not sure why this test was removed.", "reference": "I just moved this into the render.js UT file since this test doesn't actually use an components" }, { "prediction": "I don't think we need to do this. I'm not sure if we should do this in a separate PR.", "reference": "We do have to capture and check the err here right? I don't think we need to capture the location of the file though for this context." }, { "prediction": "I'm not sure if we should remove this line.", "reference": "an unused import" }, { "prediction": "I don't think this is the right thing to do here.", "reference": "If this value doesn't exist (do an `, ok :=...` check), we should initialize and store it" }, { "prediction": "I'm not sure if this is the right place to use `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER` or `Number.MIN_SAFE_INTEGER`", "reference": "Would use parenthesis to explicitly state the associations of operands ```js const MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER || (-(2 ** 53) - 1)" }, { "prediction": "I don't think we need this anymore.", "reference": "This handle is now private to pyserial, but if there is no public function to retrieve it I guess this is the best we can do." }, { "prediction": "I'm not sure if this is a good change.", "reference": "This function is what **the compositor** calls when it wants to fullscreen a client, not what the client calls." }, { "prediction": "I'm not sure if this is the right place for this test, but I'm not sure if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, I'm not sure if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test.", "reference": "s/not existed Pod/non-existing Pod" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to rename the getter to `autoscalingAlarmNamesGetter` or if it's a good idea to rename the getter to `autoscalingAlarmNamesGetter` or `autoscalingAlarmNamesGetter` or `autoscalingAlarmNamesGetter` or `autoscalingAlarmNamesGetter` or `autoscalingAlarmNamesGetter` or `autoscalingAlarmNamesGetter` or `autoscalingAlarmNamesGetter` or `autoscalingAlarmNamesGetter` or `autoscalingAlarmNamesGetter` or `autoscalingAlarmNamesGetter` or `autoscalingAlarmNamesGetter` or `autoscalingAlarmNamesGetter` or `autoscalingAlarmNamesGetter` or `autoscalingAlarmNamesGetter` or `autoscalingAlarmNamesGetter` or `autoscalingAlarmNamesGetter` or `autoscalingAlarmNamesGetter` or `autoscalingAlarmNamesGetter` or `autoscalingAlarmNamesGetter`", "reference": "Why did we not leave this as just `svcDescriber`?" }, { "prediction": "I'm not sure if this is the right place to import it.", "reference": "nit: I think we've been (in)consistent in leaving a blank line here." }, { "prediction": "I don't think we need this column anymore.", "reference": "Maybe we can change it to a more generic name like source_id." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "What's the theory on why this could fix the hang? It seems like the call to `GetRootNodeForTest` will always need to call into the crypto object before returning an error, and so it should block on that `c` receive, after which the test immediately drains `errCh`. So I don't quite see how buffering would help..." }, { "prediction": "I don't think this is needed.", "reference": "Maybe add an assert in arch_init or somewhere?" }, { "prediction": "I think this should be `wait.Poll(time.Second, 15*time.Second, func() (done bool, err error)`)", "reference": "I wonder what does this `// nolint` ignore? And what are the standards that you choose which error to fix and which to ignore?" }, { "prediction": "I think this should be `if (cores.getZkController().getZkStateReader().aliasesManager.update()) { // no change. go back }`", "reference": "what about the line below, forceUpdateCollection?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Doesn't this go in the opposite direction of #1051 / #1062 by putting platform-specific logic back into this module?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "I think this is the only line in JS legacy code that should be updated based on the renaming. `global.googlesitekit.setup.isAuthenticated = response.authenticated;` would be sufficient to keep the old name for the legacy JS data (which will be phased out in the long term) while supporting the new name in the API route. All updates to the JS components above wouldn't be necessary." }, { "prediction": "I don't think we need to check for `options.options?.pingWaitTime` here.", "reference": "Technically, this would allow `pingWaitTime` to be `false`. I don't know if it matters here." }, { "prediction": "I think this test should be `self.assertTrue(True)`", "reference": "I only want the proxy request for this to run for kinesalite. So this just returns true if the KINESIS_PROVIDER is kinesis-mock" }, { "prediction": "I'm not sure if this is the right place to move this file.", "reference": "Please add your name to the list of copyright holders." }, { "prediction": "I think this should be `private int maxRetryTimes;`", "reference": "Maybe maxRetryTimes should be bigger than 2. Return Max(maxRestryTime, 2)?" }, { "prediction": "I don't think we need to pass `signedUserName` to `CloneLink`.", "reference": "Call `userName` is good enough, `signedUserName` is narrowing the actual usage of this method." }, { "prediction": "I don't think this is needed.", "reference": "How would you feel about a static method to express intent?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea.", "reference": "Do we know for sure that no other code changed its value? (Maybe some weird testing use case or something) Why not just use the actual value instead of risk lying?" }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "the partInstall.go isn't an auto-generated file, and the part.sql doesn't exists either." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `GetAll` or `PutHash` in this case.", "reference": "`k` is unused in PutHash" }, { "prediction": "I think this method should be `copyStream(InputStream input, OutputStream output)`", "reference": "Use IOUtils instead" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "It's not related to the line of code, but I don't know how to write it in a more proper place. Looks like `e2e/myst-provider/db/myst.db` should be in `.gitignore` file and should not be commited." }, { "prediction": "I think this should be `goog:chromeOptions`", "reference": "nice touch since Google likes to change things every now and then." }, { "prediction": "I think this should be `getPluginInfo(CircuitBreakerManager.class.getName())`", "reference": "Make `CircuitBreakerManager` implement `PluginInfoInitialized`" }, { "prediction": "I think this should be `QVariant.Type.UInt.value`", "reference": "This is extra awkward, QVariant.convert() takes a QMetaType which takes the value of a QMetaType.Type." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "Nit: finished -> finish, \"done passing it\" -> \"passed it\"." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "Maybe mention that it will be saved to the filesystem otherwise?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Probably cleaner and more general to do this: string,Format(\"Column {0}\", i+1) That way if the local language has a convention like \"3 column, this is\" it still works." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This can be uniformed too" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `mtx sync.Mutex` or `mtx sync.Mutex`.", "reference": "It looks to me that this does not have to be exported." }, { "prediction": "I don't think we need to create an ApiConfig with no content. I think we should create an ApiConfig with no content. Exposed for testing.", "reference": "It looks like this is only used in order to extract the snippet file names from GapicProviderFactory. I wonder if it would be better expose the snippet file names directly, without exposing a test-only function in non-test code." }, { "prediction": "I think we should remove this method.", "reference": "Another question: this is being removed, but I don't see a corresponding removal if it being called? Was it never used (or am I just missing it)? (is it related to what was in the onclick that got removed, i.e. was that supposed to call this and not something in the backing bean?)" }, { "prediction": "I'm not sure if this is the right thing to do here.", "reference": "Suggestion: `.. does not have an Approved condition set to true`" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "I would say that client class should have default of False and Cloud prov should enable deleting." }, { "prediction": "I don't think we need this file anymore.", "reference": "Did this remove the BOM or something?" }, { "prediction": "I don't think this is needed.", "reference": "This makes the BlockHeaderValidator mutable, and IMHO should not be done. Note we have a builder that has the exact same method, so instead of mutating a produced BlockHeaderValidator we should hook into wherever the builder is being created." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to rename this function to `playWaveFile` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync` or `playWaveFileAsync`", "reference": "May be add information about parameters to the doc string while at it?" }, { "prediction": "I don't think we need to change this. I think we should change this to `PRIV_GET_TRANSACTION_COUNT_LEGACY`", "reference": "Naming of this sounds a bit awkward. Perhaps priv_legacy_getTransactionCount or priv_legacyGetTransactionCount?" }, { "prediction": "I'm not sure why this is removed.", "reference": "This one should probably be added to the list in #24. It's possibly indicative of an issue, but there isn't a VUID for it." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for this, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it.", "reference": "Why this indentation change? Seems the original indentation would be fine, and leaves more room." }, { "prediction": "I think this should be `update=True`.", "reference": "Would be nice to know what the `update` argument does in the docstring." }, { "prediction": "I'm not sure if this is the right place to import `StringIO.StringIO` or `StringIO.cStringIO`", "reference": "I think we can just use `io.BytesIO` here." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.", "reference": "This ensures that the User-Agent header matches during replay." }, { "prediction": "I don't think we need to change this to \"NAHEAP_ESTIMATED_MAX\" or \"NAHEAP_ESTIMATED_MAX\"", "reference": "What units are used for this default?" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.", "reference": "I am wondering if it makes sense to make this a flag to `flatc` rather than a preprocessor flag, since this is generated code, it would make more sense to simply omit this code completely if the flag is not specified" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Doesn't this change the behavior (edit: oh, I see, never mind)." }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if it's the right way to do this.", "reference": "I think you need a `do` at the end of this line." }, { "prediction": "I'm not sure if this is the right way to do this, but I think it's better to use `params_for_search(params.merge(:sort => sort_key)))` instead of `params_for_search(params.merge(:sort => sort_key)))`", "reference": "Not passing in a `:params` key here." }, { "prediction": "I think this should be `clusterAssigned` instead of `RunningClusterPowerState`.", "reference": "Feels like this should be an option and not the default. Leaving them running would give you immediate response to claims, which might be what some people would want. Hibernation is AWS only right now and probably other clouds will just disregard the setting but arguably validation should be rejecting attempts to create / update powerstate on gcp/azure/etc. I'd pitch we put this onto the pool spec and make you opt in." }, { "prediction": "I don't think this is needed anymore.", "reference": "I think I saw somewhere that it has been fixed and that you can use #NETCOREAPP3_0_OR_GREATER but I may be wrong." }, { "prediction": "I think this should be `return r.ctx.Active() || r.cfsm.CurrentState()!= consensusfsm.InitState`", "reference": "what's the second part for?" }, { "prediction": "I don't think this test is needed anymore.", "reference": "It's not clear to me what the \"super\" test above is for. As far as I can see, the test runs a spellcheck for \"super\" but then uses \"fob\" as the index into suggestions, which will never find an entry." }, { "prediction": "I don't think this is needed anymore.", "reference": "revert this file change" }, { "prediction": "I'm not sure about this, but I think it would be better to remove the useless-suppression from the docstring.", "reference": "I think this is the most elegant way to allow us to still fail on `I`." }, { "prediction": "I think this should be `$searchableFields = $this->getDoctrine()->getConnection()->getDatabasePlatform()->getWildcards();`", "reference": "Wouldn't it be better to use a sql `IN ( :exact_value )`?" }, { "prediction": "I don't think this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "So far this is not working as expected... working to further investigate WinRM protocol and the gems behavior." }, { "prediction": "I don't think this is needed anymore.", "reference": "So now there're two ways to get requests: `ScenarioExecutor.get_requests()` and `Scenario.get_requests()`. To avoid confusion we should probably make `Scenario.get_requests()` method private, or hide it in some other way." }, { "prediction": "I don't think this is needed anymore.", "reference": "This existed already, but seeing as you are changing the variable to have an explicit type it could be made a const reference to remove a copy." }, { "prediction": "I'm not sure if this is the right place to put this class.", "reference": "I don't think this code is being tested; this method can be removed without the test failing" }, { "prediction": "I think this should be `ArrayList.empty()`", "reference": "@codepoet2017390 You have already initialized this ArrayList in the onPreExecute method then why do it here too?" }, { "prediction": "I don't think this is the right thing to do, but I think it's a good idea to add a `can_create?` to the `ProcurementPolicy` class.", "reference": "This covers the `RESTRICT_ACCESS=true` x non-gsa pair, but we probably want to test the three other permutations: (`RA=true`, gsa), (`RA=false`, non-gsa), (`RA=false`, gsa)" }, { "prediction": "I'm not sure if this is the right place to remove the `clearTimeout` call. I'm not sure if this is the right place to remove the `clearTimeout` call, but if it's the right place to remove the `clearTimeout` call, I'm not sure if it's the right place to remove the `clearTimeout` call. If it's the right place to remove the `clearTimeout` call, I'm not sure if it's the right place to remove the `clearTimeout` call. If it's the right place to remove the `clearTimeout` call, I'm not sure if it's the right place to remove the `clearTimeout` call. If it's the right place to remove the `clearTimeout` call, I'm not sure if it's the right place to remove the `clearTimeout` call. If it's the right place to remove the `clearTimeout` call, I'm not sure if it's the right place to remove the `clearTimeout` call. If it's the right place to remove the `clearTimeout` call, I'm not sure if it's the right place to", "reference": "Please don't do this - if you want to disable code permanently delete the code, if you need to disable it to test don't commit. Such sections are very poorly highlighted during review and can cause unspotted issues slipping through the process..." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "I'm starting too feel we have too much abstraction and too many interfaces here. But this method is definitely the most confusing IMO. For one, it's called \"Get*\" but it does not return anything... I don't have a good understanding of what's going on anymore, so it's hard for me to suggest an alternative, but it's pretty clear to me that this interface needs to be rethought. An interface where all the parameters are themselves arbitrary objects (`interface{}`), whose actual type depends on the specific interface implementation, is not a helpful abstraction" }, { "prediction": "I don't think this is needed.", "reference": "It fills me with endless sadness that we can't use Selenium's own `SessionId` here." }, { "prediction": "I think this should be `ZkStateReader.exists(ALIASES, null, true);`", "reference": "Interesting. So you've found that it's faster to request only the \"Stat\" without the data so long as this is the typical path?" }, { "prediction": "I don't think we need this.", "reference": "Is this a future fix? I thought the local identifier scope and the package issue were the same one." }, { "prediction": "I'm not sure about this, but I think it would be better to use `isApplicationObject(obj)` instead of `isApplicationObject(obj)`", "reference": "Not super important, but this line could be split up." }, { "prediction": "I think this should be `h2o_context_dispose(ctx->storage.entries[i]);`", "reference": "Maybe we should better call the dispose function without checking the value of `item.data` (since the dispose function is setup before `data` is set up)." }, { "prediction": "I don't think we need to set_mode(Caffe::GPU) here.", "reference": "Why set to GPU, is it CPU?" }, { "prediction": "I don't think this is needed.", "reference": "This should be `computed('i18n.locale'....`" }, { "prediction": "I don't think we need this anymore.", "reference": "can we not expose the channel directly? or at least expose it as a read only channel?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `pkg-config` or `pkg-config` here.", "reference": "Can we add a `--with-bashcompdir` here to override this? I'd like to be able to do unprivileged builds." }, { "prediction": "I don't think this is needed.", "reference": "We will be removing this maya/volume package completely. Do not use this." }, { "prediction": "I don't think we need host_bad_alloc() anymore.", "reference": "Why you think that `model_ptr` will be `nullptr` when memory allocation is failed? I think `new daal_knn::Model(column_count)` would throw `std::bad_alloc` if `operator new` is not overloaded. Is it overloaded by DAAL in the way it simply returns `nullptr` in case of bad allocation?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Where does this 0.001 come from? Is this from the network collateral cost function, which happens to be hardcoded right now? I think it's going to rot very quickly: it depends on sector size and (probably) block height." }, { "prediction": "I don't think this file is needed.", "reference": "Please update the license header in each source file. For more information see: #2697" }, { "prediction": "I don't think this is needed.", "reference": "!numbers -> numbers" }, { "prediction": "I don't think this is needed.", "reference": "so we don't have universal rules afterwards? In that case I'd remove this entirely (and maybe some places where it's used get cleaner) since we shouldn't ever add a universal rule. Not only because it's way simpler in TS, I'm also just super skeptical about \"universal\". In case of this rule, even control characters may have their place in Swaggers, e.g. in `examples` sections where you can have raw response bodies where control characters are perfectly valid." }, { "prediction": "I'm not sure if this should be detached, but it seems like it should be detached.", "reference": "You're welcome to surface this option through the API, but I'm not going to make this the default behavior." }, { "prediction": "I don't think we need to pass a bool to `buildBinaryFor`.", "reference": "Just a thought that any further extensions of `buildBinaryFor` signature could be done as `buildBinaryFor(..., opts... BuildOptions)` for better readability." }, { "prediction": "I don't think we need this anymore.", "reference": "I'll fix the InMemoryExporter right after this PR lands" }, { "prediction": "I'm not sure if this is a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug.", "reference": "Good call, none of these are technically invalid" }, { "prediction": "I don't think this is needed.", "reference": "this one should be updated too" }, { "prediction": "I don't think this is the right place to add the instance id.", "reference": "maybe need to add microserviceId too." }, { "prediction": "I don't think this is needed, but I think it's better to add a `# pylint: disable=line-too-long, too-few-public-methods, missing-class-docstring, function-redefined, inconsistent-return-statements, missing-function-docstring, function-redefined, inconsistent-return-statements, missing-type-doc`.", "reference": "I'm curious, do you create this commit at the very end by rebasing and taking the value you had after moving everything?" }, { "prediction": "I'm not sure if this is a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug.", "reference": "It's no longer possible to use `modifyRow` to trim rows and that's ok to use TrimRows instead. But I think we should move this test to TrimRows plugin tests as `trimRows` setting is not a part of the `core`." }, { "prediction": "I think this should be `if (assert_is_extension(cmd, node)) { return NULL; } else { return 1; }`", "reference": "The function seems to either return \"default\" or return the extension stripping the preceding dot. Does the fact mean that we can no longer register `.default` as an extension?" }, { "prediction": "I think this should be `ImageDigest`", "reference": "this may require a statefile version update" }, { "prediction": "This class is deprecated and will be removed in the next major. Use SplFileObject::fgetcsv() instead.", "reference": "I like when `@deprecated` contains how to resolve it - eg. \"use `SplFileObject::fgetcsv()` instead\". The information in upgrade notes is usefull only during upgrade." }, { "prediction": "I'm wondering if we should rename this to `dns` or `dns_v1`?", "reference": "Nice to see that your local environment is up-to-date now for these changes." }, { "prediction": "I don't think this is needed.", "reference": "Instead of setting it to null, i think lets set it to {}" }, { "prediction": "I don't think we need to change this.", "reference": "We should bump this before releasing and remove all legacy fields that are safe to do so. Since we cannot have multiple versions anyway there's little value in walking around with the \"alpha\" stamp." }, { "prediction": "I think this test should be `if test \"x$san_enabled\"!= \"xno\" ; then`", "reference": "I might suggest a different name for the `DEEPBIND` config.h macro. Perhaps `FLUX_DEEPBIND` to give a hint in the code that we're using a locally provided define." }, { "prediction": "I don't think this is needed anymore.", "reference": "Code generated by protoc-gen-go. **DO NOT EDIT.**. The correct way to fix `deprecated` in this file may be updating the protoc / protobuf / grpc and regenerate this file." }, { "prediction": "I think this test should be `@Deprecated`", "reference": "We should make sure that we cover the testcases in a new unit test class." }, { "prediction": "I don't think this is needed.", "reference": "Is this only used in test code? Is there future utility in it for production code? If not, it would be nice if this could be moved into a test package. I'm not sure how hard that would be. CC @laser" }, { "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `APIServiceLabel` to the `config.APIServiceLabel` field in the `PluginConfig` class.", "reference": "Super curious how you noticed this, as SPIRE itself currently only configures once...?" }, { "prediction": "I don't think this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but I'm not sure if it's the right place to do it.", "reference": "This `startsWith` seems a bit brittle because in the code base we'll occasionally spell it \"DataFile\"." }, { "prediction": "I think this should be a very big Integer.", "reference": "if it keeps reconnecting for too long, how should we get alerted?" }, { "prediction": "I don't think this is needed.", "reference": "it's better to use single name style in one name." }, { "prediction": "I'm not sure if this is the right place to set the default send port.", "reference": "As defaultSendPort is being removed, and I don't like TODOs on examples, please remove the whole line" }, { "prediction": "I'm not sure if this is the right fix. I'm not sure if this is the right fix or if it's the right fix, but I'm not sure if it's the right fix or if it's the right fix or if it's the right fix.", "reference": "Should we return `nil` when `err == errChangeSetEmpty` instead of calling l.103 `WaitUntilStackUpdateCompleteWithContext`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Hmmm I thought spotless would wrap this line, but it doesn't seem to complain about it" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "I think this will require updating the api version. we are planning to do this anyways, so perhaps we can lump this in so we don't have to update too many times?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "revert this for parity" }, { "prediction": "I think this should be `INITIAL_BATCH` instead of `INCR_BATCH`", "reference": "INCR_BATCH and DECR_BATCH could be exposed as tuneable command line options but that might be too low level to expose. I think keeping private for now where \"in the know\" folks could use to try and tune makes sense. These values were choosen mostly \"at random\" and have worked out for us thus far." }, { "prediction": "I think this should be `TagWriter *writer = new TagWriter(writerTable[wtype]);`", "reference": "Currently this isn't very clean because we have to re-use some of the predefined parser types - the demo uses WRITER_U_CTAGS but there should be some support for custom writer type." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I think this was left it accidentally :)" }, { "prediction": "I don't think we need to move this.", "reference": "Can you finish re-ordering this list to match the one that was deleted?" }, { "prediction": "I'm not sure if this is the right place to set the container name.", "reference": "Do we need to check if `exp.Target.StressChaos` is `nil`?" }, { "prediction": "I don't think we need to change this file.", "reference": "AWS Identity and Access Management (IAM)" }, { "prediction": "\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"", "reference": "not calling this is going to impact current functionality which depends on PVC.. let us still call this and set the values to default as 'none' (or empty) by handling the error from 'get' operation" }, { "prediction": "I'm not sure if this is the right place to write to the eventfd. I'm not sure if this is the right place to write to the eventfd, or if it's the right place to write to the eventfd, or if it's the right place to write to the eventfd, or if it's the right place to write to the eventfd, or if it's the right place to write to the eventfd, or if it's the right place to write to the eventfd, or if it's the right place to write to the eventfd, or if it's the right place to write to the eventfd, or if it's the right place to write to the eventfd.", "reference": "`!=` is no the same as `<`" }, { "prediction": "I don't think this is needed.", "reference": "No need to create a dir for transformer. Simply move transformer.py into mmdet/models/utils/" }, { "prediction": "I don't think we need to handleDeeplink here. I don't think we need to handleDeeplink here.", "reference": "Can't you just add `SelectSubscriptionActivity` directly to the manifest instead of opening `MainActivity` that then starts it?" }, { "prediction": "I think this should be `run-check` instead of `run-check`.", "reference": "Maybe say \"the spec's %check section\" so it's clearer what we mean." }, { "prediction": "I think this should be `this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted()) && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.isSorted() && this.is", "reference": "I think after change this check `rowInMapper === null` is always false, so it's useless." }, { "prediction": "I don't think this is needed.", "reference": "ClockIpLpi2c4.Enable() is required. The same change is required for enablePeripheralClocks()." }, { "prediction": "I don't think we need this?", "reference": "nit: this should be `SHA` since it is an acronym for `Secure Hash Algorithm`, no?" }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "Not sure if Intl can be defined but not `Intl.DateTimeFormat`. Both seem to have the same percentage on CanIUse." }, { "prediction": "I'm not sure if this is the right place to send the event or not.", "reference": "PTAL, looks like the order of PVC & PV is reversed for different storage-engine types, for Jiva/CStor the args sent to sendEventOrIgnore are `PV, PVCName`." }, { "prediction": "I don't think this is needed anymore.", "reference": "Remove the trailing white space" }, { "prediction": "I don't think this line is needed.", "reference": "No need to modify this." }, { "prediction": "I don't think we need this change.", "reference": "would be nice at some point to clean this signature up... not relevant for this PR" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Here, is it `null` because it is `null` in `$fieldConfiguration`, or because it has been set to `null` above in the `array_replace`? If it doesn't exists at all in `$fieldConfiguration`, I think you should add `type => 'text'` above in the `array_replace`." }, { "prediction": "I think this should be `node instanceof ClassOrInterfaceDeclaration && ((ClassOrInterfaceDeclaration) node).getFullyQualifiedName().get().endsWith(className))`", "reference": "I was thinking about this for #2928 too, which also uses `endsWith`... Presumably `SomeOtherObject` would match `endsWith(\"Object\")`, meaning that something more sophisticated like splitting it then iterating right to left would be needed in order to do this robustly?" }, { "prediction": "I don't think we need to add this to the `ZipkinExporterOptions` class.", "reference": "I think this name is a bit confusing because if you asked someone what type of exporter they were using they would probably say Zipkin or Jaeger, etc. How about `ProcessorType` with `Simple` and `Batch` definitions?" }, { "prediction": "I think this should be `\"9bf9752a-54a2-451a-a541-444add56f96b\"` or `\"9bf9752a-54a2-451a-a541-444add56f96b\"`", "reference": "`req` is unused in RecreatePipedKey" }, { "prediction": "I don't think we need to change this line.", "reference": "The \"Adsense\" term needs to be capitalized - I just noticed this was wrong through ACs and IB, so not a problem of the PR itself really. I'll quickly fix it." }, { "prediction": "I'm not sure if this is the right place to register functions.", "reference": "do which methods need to be registered? is it basically just the ones that are directly referenced in ParDo calls? (The Beam GoDoc doesn't say anything about it. :/ )" }, { "prediction": "I don't think this is needed.", "reference": "@bmckinney does this mean that the bibtex citation will be available via API?" }, { "prediction": "I don't think this is needed.", "reference": "We should probably tag the cliquet-fxa version as well." }, { "prediction": "I don't think this is needed.", "reference": "IIRC we need to use memset, because an empty brace is not C99 comformant, and because we cannot use `{0}` because how the struct is organized is not defined in POSIX (the initializer cannot be `{0}` if the first property of the struct is a struct)." }, { "prediction": "I'm not sure if this should be optional, but I'm not sure if it's worth it.", "reference": "Will we be adding this to `AppliedTo` as well? If not, any reason why not?" }, { "prediction": "I don't think this is needed.", "reference": "Just a note that this feels weird being on the base NVDAObject rather than IAccessible, but right now, I understand that's how it has to be because we fire MSAA caret events on the focus object regardless of whether it's IAccessible. I think we should consider restricting these caret events to focus objects that are IAccessible subclasses in future, but that change is probably too risky for this PR. CC @MichaelDCurran for his thoughts." }, { "prediction": "I don't think we need to pass the `payment_detail` field to the `createForm` method. I think we should pass the `payment_detail` field to the `createForm` method.", "reference": "This change and other similar ones should not be part of this commit. This commit is about adding a ImageUploadType not fixing controllers and stuff." }, { "prediction": "I don't think we need this.", "reference": "I am a bit confused about PING here. Ping is implied and it overlaps with \"$SYS.REQ.ACCOUNT.%s.%s\" where the last token is what is requested (CONNZ) and the one before is the requested account id." }, { "prediction": "I don't think we need to do this in the `CloudMigrateStatus` function. I think we need to do this in the `CloudMigrateStatus` function. I think we need to do this in the `CloudMigrateStatus` function.", "reference": "nit: use the OptSubFolder constants. Also in the client you are using \"maxdepth\" but in the server the constant for \"depth\" is being used." }, { "prediction": "I don't think we need to change this test.", "reference": "I also moved this to `/verdaccio/storage` since it's written in runtime, and the approach here is to make the configuration by default read-only." }, { "prediction": "I don't think this is needed.", "reference": "nit: s/has cancel method/has a cancel method" }, { "prediction": "I'm not sure if this is the right way to test this, but I'm not sure if it's the right way to test this.", "reference": "Useless assignment to variable - `second_quiz`. Use `_` or `_second_quiz` as a variable name to indicate that it won't be used." }, { "prediction": "I don't think we need to do this for pre-compressed files. I don't think we need to do this for pre-compressed files. I'm not sure if we need to do this for pre-compressed files.", "reference": "Is this still needed since there's the `GzipPrecompressed` type?" }, { "prediction": "I don't think we need this class anymore.", "reference": "this is spelled wrong and also not used so remove it" }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to remove the `@SuppressWarnings(\"Convert2Lambda\")` from the `ServerWebExchangeMatcher` class.", "reference": "It might be right here that's the issue ^" }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it. I'm not sure if this is the right way to do it, or if it's the right way to do it, or if it's the right way to do it, I'm not sure if it's the right way to do it, or if it's the right way to do it, or if it's the right way to do it, I'm not sure if it's the right way to do it.", "reference": "@danieldietrich let's leave existing extension. Here we just mark `keyComparator()` with `@Deprecated` annotation" }, { "prediction": "I think this file should be included in this PR.", "reference": "This breaks CI. I am not sure why you need to include io.h in this file especially on linux." }, { "prediction": "I'm not sure if this is the right place to call `slice.call(parentDom.childNodes)` or `slice.call(parentDom.childNodes)` or `slice.call(parentDom.childNodes)` or `slice.call(parentDom.childNodes)` or `slice.call(parentDom.childNodes)` or `slice.call(parentDom.childNodes)`", "reference": "this seems equivalent" }, { "prediction": "I don't think we need to change this?", "reference": "change size to 50MB criticial, 10MB warn... change count to 50k critical, 5k warn..." }, { "prediction": "I don't think this is the right place to do this. I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "This has nothing to do with master/slave replication. Is this something we want to change too? If so, I guess this is an aggregation?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Maybe it makes sense to mention that those zombies are not forever, but only up to the moment when the parent process exits? Is that correct according to your observations, @benoittgt? Please disregard this note if zombies remain after." }, { "prediction": "I don't think we need to mock the mock.", "reference": "moto mock setup needs to happen before boto usage." }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if this is a good idea or if it's a good idea to have a `first_metric_only` flag. I'm not sure if it's a good idea to have a `first_metric_only` flag, or if it's a good idea to have a `first_metric_only` flag, and if it's a good idea to have a `first_metric_only` flag, I think it's a good idea to have a `first_metric_only` flag, and if it's a good idea to have a `first_metric_only` flag, I think it's a good idea to have a `first_metric_only` flag, and if it's a good idea to have a `first_metric_only` flag, I think it's a good idea to have a `first_metric_only` flag, and if it's a good idea to have a `first_metric_only` flag, I think it's a good idea to have a `first_metric_only` flag, and if it's a good", "reference": "`hasattr(cb, 'first_metric_only') and cb.first_metric_only` -> `getattr(cb, 'first_metric_only', False)`" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "no newline for function" }, { "prediction": "I'm not sure if this is the right fix.", "reference": "This makes me feel icky. We could also go the route of making `wlr_output.scale` a double instead of a float, but that would be a more widely reaching change." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Again, would be awesome if you could remove the tabs in these 3-4 lines as well." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "You're moving multiple times from `step.name`; you're not allowed to do that. Instead you have to copy the `step.name` string and (if you want to) move once at the very last." }, { "prediction": "I don't think we need to change this.", "reference": "What about `may not end`? @jancborchardt" }, { "prediction": "I don't think we need to change the message here.", "reference": "If you think about it, the status should be PermissionDenied?" }, { "prediction": "I don't think we need to change this. I'm not sure if it's a good idea to change it.", "reference": "Calculation looks good but don't know what format etc grafana expects this to be in." }, { "prediction": "I'm not sure if this is the right place to test this, but I'm not sure if it's the right place to test this.", "reference": "nit: We could use the `to_str(..)` util here. (let's not bother changing for this PR.. )" }, { "prediction": "I'm not sure if this is the right place for this file.", "reference": "Can you rename alias to `executiongenpb`. The rule is package+\"pb\" for `temporal-proto` and package+\"genpb\" for server protos." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Any noticeable performance hit? Any other way to avoid the allocation and copy even of the array?" }, { "prediction": "I don't think this is needed anymore.", "reference": "What if you remove this line entirely from here?" }, { "prediction": "I don't think this is needed.", "reference": "`on_lateral` can also be implemented" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but I'm not sure if it's the right place to do it.", "reference": "Please add a space between `if` and `(`." }, { "prediction": "I don't think we need this.", "reference": "This statuses might have been better off with some custom status type. However, good for now." }, { "prediction": "IsGlobalUnicast() still needed?", "reference": "Thanks for catching the bug. Here your change lets `v4IPNet` and `v6IPNet` take the first IPv4/IPv6 address in `addrList`. Maybe choose the last one also works and makes code simpler? What's your idea? @tnqn" }, { "prediction": "I'm not sure if this is the right place to handle this, but I'm not sure if it's the right place to handle this.", "reference": "nitpick: you can name this variable just `details`" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "The character class in the regex should probably be \"[a-zA-Z0-9_]\"." }, { "prediction": "I'm not sure why this was removed.", "reference": "Please also increment `Settings.VERSION` and update `AccountSettings`." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "I think this should just say \"build \". And when builddate wasn't set, e.g. somebody built weave with 'go build' or some other way, this should return \"unknown\"." }, { "prediction": "I think this should be `String.format(\"Rewriting manifests(staging location=%s) of %s\", stagingLocation, table.name()));`", "reference": "Can we move this into a separate var and call it `desc` like below?" }, { "prediction": "I don't think this is needed.", "reference": "why RpcSchema need this annotations?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it.", "reference": "Not sure it makes sense to send the reply if we did not delete from the map, but I guess it does not hurt.." }, { "prediction": "I'm not sure if this is the right place to use `row` and `colCount` in the `createRow` function.", "reference": "Most of these variables can be moved after `return` or to the body of `if` statement." }, { "prediction": "I'm not sure if this is the correct error. I'm not sure if it's the correct error.", "reference": "nit: Is this actually just a http \"unauthorised\" response? Or is that too vague? If this is the right way to go... is \"token\" the right word\" Or do we want to say something else?" }, { "prediction": "I don't think this is the right place for this.", "reference": "We check for `$future` in PuppetDB::Config, so this won't change behavior if you don't have `future` set." }, { "prediction": "I don't think we need to raise KeyError here.", "reference": "I think you should remove `if isinstance(by, str):`,. We also should fix the error message `raise ValueError('Not a valid index: TODO')` to match with pandas'" }, { "prediction": "I'm not sure if this is the right place to set this property. I'm not sure if it's the right place to set it.", "reference": "Curious - do we want this to be `OTel.GrpcHandler.Request`? For example, if someone is debugging a crash dump, they would get some hint that it was added by OpenTelemetry." }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if this is the right thing to do.", "reference": "nit: unnecessary `

    `" }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "Should just be `#ifdef ADIOS2_HAVE_HDF5`" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for this, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, I'm not sure if it's the right place for it, or if it's the right place for it, or if it's the right place for it, I'm not sure if it's the right place for it, or if it's the right place for it.", "reference": "FYI: I deployed a stack with multiple lengths for the stack name and resource id to cloudformation, to see how it truncates the parts for the final FunctionName" }, { "prediction": "I think we should remove the `AppDomain: i.appDomain, Path: \"/\", }", "reference": "Did we not use this field @_@" }, { "prediction": "I don't think this is needed.", "reference": "shouldn't this be `android_keystore_name`?" }, { "prediction": "I don't think we need to check if the secret is nil or not.", "reference": "Double check the issuers package too :)" }, { "prediction": "I'm not sure if this is the right thing to do, but I think it's better to use `_visit_consumer` instead of `_check_consumer`. I think it's better to use `_visit_consumer` and `_check_consumer` in the `VariableVisitConsumerAction` class.", "reference": "This is out of date right? Now that `_is_first_level_self_reference` uses it as well? Perhaps we should make the docstring more general and not refer to method names that could change." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This test alone takes around 10-12 minutes to run. It has 20 subtests each of which takes around one minute. We should see if we there are redundant subtests that we can remove, or look for a way to optimize them." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `Object.keys(newProps).sort()` or `Object.keys(oldProps).sort()`", "reference": "Good call, we need to keep that check :+1:" }, { "prediction": "I don't think this is needed.", "reference": "Should the interface have 2 `ParseHeaders` methods?" }, { "prediction": "I don't think we need to do this in Hive Hive Hive Hive Hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive hive", "reference": "Nit: Does this make more sense as `iceberg.hive.metadata...`? The rest of the configs seem to start with `iceberg.hive`." }, { "prediction": "I don't think this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Is `baseURL` not required?" }, { "prediction": "I don't think this is right?", "reference": "Just delete it, `embedding_rpn_head` is not a `Detector` which should have `show_result`." }, { "prediction": "I don't think we need to expose the `HttpHeadersHost` and `HttpUrl` methods.", "reference": "Where do we _get_ tag values? edit: I mean, where are these `GetFoo()` methods called from? It just seems weird to me that we are getting tag values from spans. I thought we only ever _set_ tags on spans." }, { "prediction": "I think this should be `log.Printf(\"Reading kzip with %v encoding\", pref)`", "reference": "This seems like log spam. Maybe expose the encoding as a method and log at the point of interest?" }, { "prediction": "I don't think we need to change this?", "reference": "I looked up that one, and it seems correct: Authentification is French, Authentication seems to be correct" }, { "prediction": "I'm not sure about this, but I think it's better to use `print traceback.format_exc()` instead of `print traceback.format_exc()` and then use `print traceback.format_exc()` to print the traceback.", "reference": "Can we print a more human-friendly warning here, saying that plotting won't work or something along those lines?" }, { "prediction": "I don't think this is needed anymore.", "reference": "@mhils didn't we try to get rid of these (now empty) wrapper classes?" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "I would avoid importing `felix/ipsets` package because this package is the windows equivalent and should be at the same level of `felix/ipsets`. We could add linux specific dependencies into `felix/ipsets` later and it will break Windows build." }, { "prediction": "I think this should be `registerTable(TableIdentifier identifier, String metadataFileLocation)`", "reference": "Maybe, `import` would be a better name." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea.", "reference": "Wouldn't we want `PARAMETER_MAX_RESULTS` in here as well? (I might be miunderstanding how this is used)" }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "We can re-use the config in our tests." }, { "prediction": "I'm not sure if this is a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug.", "reference": "Wouldn't we have the same issue with the internal libevent? IIRC, the integration is pretty close to an exact duplicate. Or does the libevent m4 code already take that into account when setting this variable? PMIx _requires_ libevent, so it isn't like pmix_libevent_support can be anything other than 1. I'm okay with leaving this question for separate resolution - just wondering why we don't have the same issue here." }, { "prediction": "I don't think this is needed.", "reference": "The actual User-Agent string uses \"CriOS\" not \"CRiOS\"" }, { "prediction": "I don't think this is needed anymore.", "reference": "Unused code deletion. Is that a desired thing? No implementation of this actually used this indexer, so removing it seemed reasonable (and was suggested by the compiler). Maybe this had an indexer so plugins could use it? This change is definitely pushing the limits of what is appropriate in a \"cleanup\" as it is changing public API surface area." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "We'd lose the data here from the original teardown_exception and only get the dump_exception - I fear that that could make the actual error difficult to track if it cascades." }, { "prediction": "I don't think this is needed.", "reference": "At this point in `diff()` we should know if we're dealing with a `component` or a native `html` element. We can reuse that information in this if-statement here :+1:" }, { "prediction": "I'm not sure if this is the correct way to do this.", "reference": "somewhere in reward protocol, we need to do if epoch is Fairbank { a.foundationBonusP2StartEpoch = genesis.xxx a.foundationBonusP2EndEpoch = genesis.yyy p.state(sm, adminKey, &a) } that is to write the 2 new values at Fairbank height then this logic can follow" }, { "prediction": "I don't think we need to recreate the CloudAssetInventory table.", "reference": "Dropping and recreating would delete all t he previous records, are they any important?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "While it is technically OK to use `m.GetPaths()` here, and it's a mock code so it doesn't really matter, I'd still like to have `m.Path(\"devices\")` used here, because since commit 714c91e9f73a1512808476eb532b4aa36bbb7530 we're not supposed to use GetPaths() for anything other than state save/restore." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Let's be consistent everywhere: either \"Disable\"/\"Enable\" or \"Disabled\"/\"Enabled\". I'm voting for the latter.:)" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to have a `GoQuorumCompatibilityMode` flag.", "reference": "this works and is the smallest possible change but we could definitely fail earlier" }, { "prediction": "I'm not sure if this is the right place to build nodeps. I'm not sure if it's the right place to build nodeps, but if it's the right place to build nodeps, I'm not sure if it's the right place to build nodeps, or if it's the right place to build nodeps, or if it's the right place to build nodeps, or if it's the right place to build nodeps, or if it's the right place to build nodeps, or if it's the right place to build nodeps, or if it's the right place to build nodeps, or if it's the right place to build nodeps, or if it's the right place to build nodeps, or if it's the right place to build nodeps, or if it's the right place to build nodeps, or if it's the right place to build nodeps, or if it's the right place to build nodeps, or if it's the right place to build nodeps, or if it's the right place to build nodeps, or if it's the right place to build", "reference": "Should not have snuck in here right? This is a golang 1.17 feature, wii definitely want to update these" }, { "prediction": "I'm not sure if this is the right place to set this.prevFolderId_ = null;", "reference": "Could you explain the logic with prevFolderId?" }, { "prediction": "I don't think this is needed.", "reference": "Please add license header" }, { "prediction": "I don't think this is needed.", "reference": "It bothers me that the user calls `initialize` without also calling `finalize`. It seems to me that we're essentially making `lbann_comm` a singleton object. Going further down this path, we would put `initialize` inside `lbann_comm`'s constructor and `finalize` in the destructor. This has it's own weirdness - the user must make sure it's lifespan matches the beginning and end of the program. We may also run into the case where someone might want multiple instances of `lbann_comm`, but this is not too important." }, { "prediction": "I don't think this is needed anymore.", "reference": "We should probably make a unique_ptr typedef in ROMol.h and start using that liberally." }, { "prediction": "I don't think this is needed.", "reference": "Can you add missing asterisk?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "late to the party, but I bet it meant to be `capitalizeLettersAfterNumbers` :)" }, { "prediction": "I think this should be `boolean firstTimeEmptyObject = false;`", "reference": "The Activity is recreated on configuration changes and the value of the field is lost. So, e.g. pressing'send' once will display the error message. If you rotate the device and press'send' again, the message will show another time. Use `onSaveInstanceState()` and `onRetainInstanceState()` to save and restore the value of the field." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Looks like a \"find and replace\" unintended change here" }, { "prediction": "I don't think we need to strip unlearned columns here.", "reference": "haven't we got rid off `randomSP` recently? (I think `not learn` implied that)" }, { "prediction": "I'm not sure if this is the right place to do this, but I think it's better to use `in.GetStatus().Experiment.Phase` instead of `in.GetStatus().Experiment.Phase`", "reference": "Why we need use `in.GetStatus()` function here? Can we use `in.Status.xxxx` directly?" }, { "prediction": "I'm not sure if this is intention to force cache invalidation.", "reference": "@cretz Just a thought: what if another renewal process updates the certificate between the beginning of this for loop (above on line 67) and actually calling RenewCert? Even though we have a read lock on the certCache, something else could have renewed it by now, and finished, which would cause this certificate to be renewed twice. Could you double-check my thinking here and see if that's a plausible 'race' condition? I wonder if the lock needs to be put over this whole function. (It's still early here; I could be wrong...)" }, { "prediction": "I don't think this is needed anymore.", "reference": "We don't need this for the PInvoke?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "nits, I think add a log (using s.logger) to show why does this return with no error is better." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Btw, It would be nice if we have some tests for those validation functions." }, { "prediction": "I don't think this is needed.", "reference": "Should this be called something that indicates its function, rather than its content? validationMessagePrefix, or similar?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Please remove this line" }, { "prediction": "I don't think this is the right thing to do.", "reference": "You could change the name of the command line switch too. Short options are typically one character after hyphen. wxWidgets' command line parser seems to handle `-nd` without confusing it with `-n` or `-d` but I'm not sure if that's by design or by accident. I'd remove the short option. `--no-daemon` is with hyphen but the rest of Manager and client uses underscore. Please change that." }, { "prediction": "I'm not sure about this, but I'm not sure if it's worth it.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I think this should be `error` instead of `error`.", "reference": "Why are we mentioning toybox in this message? AND it still says \"tdnf error\". What's the actual error? Should it be resolved instead of flagged?" }, { "prediction": "I don't think this is the right thing to do.", "reference": "You can remove these if they've been resolved in NODE-3405 and this isn't depending on it" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "don't need the class here if its empty" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "This should be computed('i18n.locale'...." }, { "prediction": "I don't think we need to raise an exception here.", "reference": "Please add return and return type description to docstring of this method." }, { "prediction": "Metrics/LineLength: Line is too long. [89/80]", "reference": "What does 1 << 32 do? In irb typing this yields 4294967296. I didn't find the append operator in Numeric or Integer." }, { "prediction": "I'm not sure if this is the right place for this method. I'm not sure if this is the right place for this method, but if it's the right place for this method, I'm not sure if it's the right place for this method.", "reference": "We generally use metadata for this sort of thing, indeed there is a `metadata[:execution_result]`." }, { "prediction": "I'm not sure if this should be `True` or `False` or `True` or `False` or `True` or `True` or `False` or `False` or `False` or `True`` or `False` or `False` or `True`` or `False` or `False` or `True`` or `False` or `False` or `False` or `True`` or `False` or `True`` or `False` or `True`` or `False` or `True`` or `False` or `True`` or `False` or `True`` or `False` or `False`` or `False` or `False`` or `False` or `False`` or `True` or `False`` or `True` or `False`` or `False`` or `False` or `False`` or `False`` or `False`` or `False`` or `False`` or `False`` or `False`` or `False``` or `False`` or `False``` or `True` or True` or `False``", "reference": "This was very confusing until I realized this might refer to the *bokeh* use of the word'streaming'." }, { "prediction": "I think this should be `map[string][]api.ContainerStateChange` instead of `map[string][]api.ContainerStateChange`", "reference": "Can you rename this as `tasksToContainerStates`? If you do that, you can rename the lock as well" }, { "prediction": "I don't think we need to check for null here.", "reference": "Fixing `lint` warnings that have existed for a while." }, { "prediction": "I don't think this is needed.", "reference": "An iterator **of {\\@code n} sequential elements,** where each element ~are~ **is the** given {\\@code element}." }, { "prediction": "I don't think we need to change the name of `MySqlCommand` to `MySqlCommand`.", "reference": "If all of the `SqlCommandIntegrationName` values are the same, can we just remove it from `IAdoNetClientData` entirely and put the constant there?" }, { "prediction": "I don't think this is needed.", "reference": "Maybe regroup this import with the other cert-manager packages." }, { "prediction": "I don't think we need to change this.", "reference": "There are spaces missing ;) Just have a look at the code style of the `if` statement above" }, { "prediction": "I think this should be `candidateMsgs := candidateMsgs[:block.BlockMessageLimit]`", "reference": "We should pass the size limit as a parameter to Drain so that we don't take messages out of the pool and then drop them. It's ok to merge as is, I will file an issue." }, { "prediction": "I'm not sure about this, but I'm not sure if it's worth it.", "reference": "Patch lists are used in many places so this is going to break other updates. This should just be a local change in emit_special_ibl_xfer() to pass the second-to-last instruction instead of the last instruction." }, { "prediction": "I was not able to run the tests. I am not able to run the tests. I am not able to run the tests. I am not able to run the tests.", "reference": "@argakiig previous work was above live threshold, causing the high difficulty to bleed into other blocks when genesis open was processed in tests." }, { "prediction": "I think this migration should be reverted.", "reference": "Metrics/LineLength: Line is too long. [89/80]" }, { "prediction": "I think this should be `HidepidDisable`", "reference": "Please also extend the config tests now to include the new field." }, { "prediction": "I don't think we need to set `RenderEmptyLiteral = true` here.", "reference": "I think it's wise to keep the behavior backwards-compatible (so `false` as default)" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or not.", "reference": "We don't need this line, do we?" }, { "prediction": "I don't think we need this anymore.", "reference": "I don't know if we've actually had this problem on Upcase. I'd lean towards having a blank file unless (like on robots) we see multiple errors per week from this crawler." }, { "prediction": "I don't think this is needed.", "reference": "I'm not good at picking colors, if anyone else has a preference." }, { "prediction": "I don't think this is needed.", "reference": "Note that even if you cancel the timer, the refreshFolders function might still be running since it's async. Could that be a problem for the test units? One big issue I had with tests is they sometimes would work and sometimes fail randomly, and that's because there are still code running in the background. One example was the ItemChange class, which saves data asynchronously. So I've implemented a waitForAllSaved(), which can be used for test units, to make sure nothing is running once the test ends. So just wondering if we might end up with this issue here." }, { "prediction": "I'm not sure if this is the right place to test this, but I'm not sure if it's the right place to test this.", "reference": "can we make this something more descriptive? like... types should compile? I'm still not sure exactly what this is testing... this says \"Exported types\" - but what does tsd actually look at?" }, { "prediction": "I'm not sure if this is the right place to remove the `onShowCustomView` and `onHideCustomView` methods. I'm not sure if this is the right place to remove the `onShowCustomView` and `onHideCustomView` methods. I'm not sure if this is the right place to remove the `onShowCustomView` and `onHideCustomView` methods, but if it's the right place to remove the `onShowCustomView` and `onHideCustomView` methods, I'm not sure if it's the right place to remove the `onShowCustomView` and `onHideCustomView` methods. If it's the right place to remove the `onShowCustomView` and `onHideCustomView` methods, I'm not sure if it's the right place to remove the `onShowCustomView` and `onHideCustomView` methods. If it's the right place to remove the `onShowCustomView` and `onHideCustomView` methods, I'm not sure if it's the right place to remove the `onShowCustomView` and `onHideCustomView` methods.", "reference": "this method is need for full screen video button to appear in players" }, { "prediction": "I think this should be `uint64`", "reference": "Why is this a pointer?" }, { "prediction": "I think this should be `\"The width of truncate must larger than zero,but is %s\"`", "reference": "nit: Space after comma" }, { "prediction": "I don't think this is needed.", "reference": "A similar field is already define in `scapy/layers/bluetooth.py`. Can you merge both definitions?" }, { "prediction": "I don't think this is needed.", "reference": "`std::strtok` isn't necessary. The `std::string::find_first_of` is better C++ alternative to `std::strtok`. For example, see `CheckedError Parser::ParseEnumFromString` method." }, { "prediction": "I'm not sure why this was removed.", "reference": "This property is already declared in a parent with the same visibility/type/value. This one is redundant." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it, but I'm not sure if it's the best way to do it.", "reference": "This is required, otherwise multiprocessing will (for some reason) crash" }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "Please put in a separate line-separated block" }, { "prediction": "I'm not sure if this is the right place to print the error.", "reference": "Should error be eaten? If so, not clear why" }, { "prediction": "I don't think this is needed.", "reference": "This attribute is not defined if the condition is not met. Instead, you could define another RouteFactory (e.g. `BucketRouteFactory` with a class attribute like `allow_empty_list`)" }, { "prediction": "I don't think this is needed.", "reference": "Can we use the existing `InstalledTimestamp` function?" }, { "prediction": "I don't think we need to check if there are any invalid field and there is nutrition data, scroll to the nutrition fragmento viewPager.setCurrentItem(2, true); if (addProductNutritionFactsFragment.isFieldsInvalid()) { saveEditedProduct(); } else { if (isNutritionDataAvailable() && addProductNutritionFactsFragment.containsInvalidValue()) { saveEditedProduct(); } else { if (isNutritionDataAvailable() && addProductNutritionFactsFragment.isFieldsInvalid()) { viewPager.setCurrentItem(2, true); } else { if (isNutritionDataAvailable() && addProductNutritionFactsFragment.isFieldsInvalid()) { saveEditedProduct(); } else { if (isNutritionDataAvailable() && addProductNutritionFactsFragment.containsInvalidValue()) { viewPager.setCurrentItem(2, true); } else { if (isNutritionDataAvailable() && addProductNutritionFactsFragment.isFieldsInvalid()) { viewPager.setCurrentItem(2, true); } else { saveEditedProduct(); } } }", "reference": "weird naming: `is` but `fields` (plural or singular?). If the method checks if the fragment has an invalid value, then \"hasInvalidValue\" or \"containsInvalidValue\" is fine no?" }, { "prediction": "I'm not sure if this is the right place for this change.", "reference": "Does this mean that `listenbrainz.org/user/iliekcomputers` will start getting 404s?" }, { "prediction": "I'm not sure if this is the right way to do it.", "reference": "Line is too long. [82/80]" }, { "prediction": "I think this should be `async_select_unrequired = True`", "reference": "That's a strange name =)" }, { "prediction": "I'm not sure if this is the right place to put this test, but I think it's better to put this test in a separate file.", "reference": "Thoughts on this? I'm not crazy about the brittleness of this but haven't found a good way to test more generically that a specific (custom) template has been rendered." }, { "prediction": "I'm not sure if this is the right place to call this `subscribe` method. I think it's better to call it `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid` or `isValid`", "reference": "Have we reached binding-level agreement on the `subscribe` terminology? My only concern is that it doesn't seem descriptive enough and may be confused with subscribing for notifications." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "would it not be safer to move this condition to the `addLink` method?" }, { "prediction": "I don't think this is needed.", "reference": "I think this might read better: > some apps need the response headers before starting to stream content with http2, so it's important to explicitly flush the headers to the client before streaming the data." }, { "prediction": "I don't think we need this interface.", "reference": "What does this return if there is no partition? I think that we should consider adding a struct type that describes this tuple. That way, we can use an empty struct for unpartitioned and a non-empty struct for tasks that are combined by partition. We could also support more combinations, like combining across day partitions by not across bucket partitions or similar." }, { "prediction": "I don't think this is the right thing to do here.", "reference": "Also, it might be worth returning this for the above lookup on `kbfsRepoDir` as well, which could happen if someone tries to delete a repo in a TLF that has never had any repos at all." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "Can this be `Hidden: true` as we already have a bunch of flags that are printed on `--help` and this seems like an average person should not care about it." }, { "prediction": "I don't think this is needed.", "reference": "Wouldn't this set $strictVariables = true when Config::get returns false?" }, { "prediction": "I don't think this is needed.", "reference": "was this meant to be checked in?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "check spaces after const name..." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "If the GPU setting is enabled, resourceFields.NvidiaGPUManager will be nil, right?" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it.", "reference": "We should probably verify that it's readable too" }, { "prediction": "I don't think we need this change.", "reference": "See, here's an example where you removed the variable but kept the call, which makes sense." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Please use `request.getTitle()` instead of `feed.getHumanReadableIdentifier()`: In this case, `feed` does not have a human readable title yet" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "I think the wording on the left is better" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Please update the method described to point out that it maintains a chain of interceptors and they will be called in the same order passed in the options." }, { "prediction": "I don't think this is the right place to do this, but I don't think this is the right place to do this. I'm not sure if this is the right place to do it.", "reference": "Is this case purely hypothetical or did it solve an issue that occurred in your testing? I'm trying to understand this change a little better" }, { "prediction": "I'm not sure this is the right place for this. I'm not sure if it's the right place for this, but I'm not sure if it's the right place for this.", "reference": "Use instead `convert.Int32ToString` that was added in #762 for this purpose." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "If key is present, tree.put(k,v) needs to return a new instance for Maps and the same instance for Sets. Therefore we currently perform an additional 'contains' check for Sets. A future optimization may add an additional flag `replace` to the backing HAMT.put() / RedBlackTree.insert() methods. Sets set it to replace=false, Maps set it to replace=true. But for now this solution is working for us." }, { "prediction": "I don't think this is needed.", "reference": "This is a regression test for code I found while working on this." }, { "prediction": "I think this should be `char[len1+1]; char *jsonAttr = new(heap) char[len2+1]; char *jsonAttr = new(heap) char[len1+1]; char *jsonAttr = new(heap) char[len2+1]; jsonAttr[len1] = '\\0'; jsonAttr[len2] = '\\0'; json_extract_path_text(&rltStr, jsonStr, 1, jsonAttr); if (ret!= JSON_OK) { json_extract_path_text(&rltStr, jsonStr, 1, jsonAttr); }", "reference": "I'm wondering if we need to delete jsonStr and jsonAttr after the json_extract_path_text call to avoid unnecessary heap pressure. Though if json_extract_path_text itself does new's on the same heap, we'd get heap fragmentation. Another approach would be to allocate these on the stack instead, avoiding both concerns: char jsonStr[len1+1]; char jsonAttr[len2+1];..." }, { "prediction": "I think this should be `int(request.args.get('from', 0))`", "reference": "Does it come as `str`?" }, { "prediction": "I don't think this is the right place to do this, but I think it's better to use `String.valueOf(allergens.size() - 1)` instead of `String.valueOf(allergens.size() - 1).toString()`", "reference": "This should actually read as the following `for (int i = 0; i < allergens.size(); i++)`" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this.", "reference": "This is so useful and safety, I want to propose making AppendBool, AppendInt, etc. all private functions, and forcing us to use AppendValue(j, values.New(false)), etc." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Really, really small nit I believe there's 3x tabs in here? And should it be just 2x?" }, { "prediction": "I'm not sure if this should be `true` or `false`.", "reference": "Perhaps note that rclone can't do this yet?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "You probably don't need to set an empty config here." }, { "prediction": "I don't think this is needed.", "reference": "I think you are missing `cftime.DatetimeAllLeap` here. That said, all of these are subclasses of `cftime.datetime`, so I think you could get away with just using `cftime.datetime` here, rather than enumerating all of the different subclasses (since `cftime_types` is only used for instance checks)." }, { "prediction": "is a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a", "reference": "don't we need to set this label on pool pods? I don't see them being set" }, { "prediction": "I'm not sure if this is the right error message.", "reference": "can remove, it isn't reachable." }, { "prediction": "I'm not sure if we should change this to be true?", "reference": "`expect(cancellation).to be_can_downgrade_instead` would be preferred :rainbow: :rainbow:" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Gross. The OS should timeout writes for completely unresponsive clients to begin with. Long term, the better solution is to enforce a minimum minimum data rate for responses. This might require a way to cancel LibuvAwaitables, but it definitely not OK to immediately kill the socket and any ongoing writes just because the request processing loop completed. You could consider doing that after some kind of timeout, but at that point you might as well just enforce a minimum rate." }, { "prediction": "I don't think we need to pass `thread_pool` to `fetch_datum`?", "reference": "If this is not used, we should just delete the line." }, { "prediction": "I'm not sure this is the right place for this, but I'm not sure if it's the right place for this, and if it's the right place for this, I'm not sure if it's the right place for this.", "reference": "Are there other callers to this function. How will they be impacted." }, { "prediction": "I'm not sure if this is the right place to import it. I'm not sure if it's the right place to import it, but if it's the right place to import it, I'm not sure if it's the right place to import it.", "reference": "Let's be consistent. The majority of boto code does not use relative imports. Let's just stick to the existing standard of \"from boto.package.subpackage import Thing\"." }, { "prediction": "I'm not sure if this should be `Optional.empty()` or `Optional.empty()`", "reference": "Suggestion: specify `arity` for this option." }, { "prediction": "I think this should be `True` or `False`.", "reference": "This is a parameter available for the matplotlib backend IIRC. In which case, it is good to see this support added to the Bokeh backend." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "trim has performance impact and this is the lowest level library... seems the trim if occurs should happen in the UI or Query controller instead.." }, { "prediction": "I don't think this is needed.", "reference": "Probably also needed for the `http.client.FOUND` below?" }, { "prediction": "I don't think this is needed.", "reference": "Can you also add this to Compiler.md?" }, { "prediction": "I don't think this is needed.", "reference": "!numbers -> numbers" }, { "prediction": "I'm not sure if this is the right place for this method.", "reference": "This description doesn't seem quite right for the longrunning case - `longrunning` isn't an orgname." }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do this. I'm not sure if it's the best way to do this.", "reference": "maybe give it a more descriptive name, e.g. `competitiveFilter`" }, { "prediction": "I don't think we need a master list here.", "reference": "This occurrence of \"master\" is unrelated to master/slave replication. Maybe simply remove the word \"master\" or replace it with \"reference\" but \"primary\" doesn't really make sense." }, { "prediction": "I don't think this is needed.", "reference": "BLOCKING: This is a problem. We shouldn't be introducing new dependencies on proofs into actors. The miner has some dependencies that should be removed (#2555). This could be accomplished either by moving `proofs.Mode` to `types.ProofsMode` or by forgoing a new type altogether and replacing it with a boolean. The later would have the additional advantage of reducing the number of types we have to export through ABI. I get why `proofs.Mode` has value as a type over a boolean, but I'm not sure it's worth it here." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "We probably want to log the fact that a `MessageId` was not present in the response. In addition the `RequestID` from `request.Request` should be included in the message so that the user is aware of the issue." }, { "prediction": "I don't think we need to change this.", "reference": "It feels a bit strange to re-assign that here, as that line itself has no context on why it's reassigned. I'd prefer if we could pass `{ propertyID: webPropertyId }` below instead (that's how we do that elsewhere too). This also applies to other similar re-assignments below - let's rather pass the values within the objects as applicable, since then there is more clear context on why this \"rename\" / \"reassignment\" is necessary (because of an object expecting specific properties)." }, { "prediction": "I don't think this is needed.", "reference": "remove this in the new pr aswell when moving compare to plugins as discussed." }, { "prediction": "I'm not sure if this is the right fix. I'm not sure if this is the right fix or if it's the right fix, but I'm not sure if it's the right fix or if it's the right fix or if it's the right fix or if it's the right fix.", "reference": "check varHolder is nullptr is redundant, ExecutionContext ensure" }, { "prediction": "I don't think we need to do this. I think we should do this in a separate PR, but I don't think we need to do this in a separate PR.", "reference": "Make these frozen constants?" }, { "prediction": "I think this should be `
    ` instead of `
    `",
          "reference": "Please use something like html.escape() to ensure that the text is totally safe to include within html. < is not enough."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "why is a buffered channel larger than 1 needed here? the separate goroutines can just try to write to the channel with a select-default block, and then it is not needed. i find the current implementation a bit convoluted, maybe we could simplify it a bit? not sure why it is needed for example to communicate an empty result. these patterns can be simplified using waitgroups"
        },
        {
          "prediction": "I don't think we need this file anymore.",
          "reference": "There seem to be more changes in here than I'd expect (mostly `limit: 255` additions)."
        },
        {
          "prediction": "I don't think this is used.",
          "reference": "I'm not sure, but I think it's `Tenant`"
        },
        {
          "prediction": "I'm not sure if this should be `true` or `false`.",
          "reference": "Not sure if it's an issue, but this is a breaking change in a public API. Maybe we should add as an overload without optional parameter instead and delegate the existing call to this one?"
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "as opposed to exposing the chooser function and increasing our API exposure for the purpose of tests, can we move the HTTP transport config test into this package?"
        },
        {
          "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea, but if it's a good idea, it's a good idea.",
          "reference": "This is using the legacy DRM interface. DPMS levels have been removed from the atomic interface IIRC. Should we handle DPMS levels at all?"
        },
        {
          "prediction": "I'm not sure if this is a good idea.",
          "reference": "I think this was correct before. The nonce passed in here is the nonce at a block (which is the next nonce not yet used, e.g. 0 if the account was never used, 1 if only the tx with nonce 0 has been sent). So if the in-block nonce is 12, then a transaction with nonce 12 cannot have been included yet."
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "Please name the file ShareExtension.js, as you import it under this name (also could you convert it to TypeScript please?)"
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "Not sure if we need it, but if we set it, be sure to add `,omitempty`."
        },
        {
          "prediction": "The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a QUIC packet. The PublicHeader of a",
          "reference": "It's the whole `PublicHeader` that will change soon, and we should state that here, not in the member functions. If Jana's proposal for a new header is accepted, we might also want to rename the fields here. For example, there won't be a dedicated version flag anymore, so a more appropriate name might be `ContainsVersion` instead of `VersionFlag`."
        },
        {
          "prediction": "I think `Object` should be `Character` instead of `Character`.",
          "reference": "I think `element` can stay of type `Character` because `Character` is a final class. The we do not need the cast in the line below."
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "Not sure, if we should do it the other way round. If you ask be in the middle of the night, whether Interface should return true as \"isInterface\" and what Annotation would return. I'd tell you, Annotations should return false.... I want to say, on first glance, I'd say, it's easier to have \"isInterface\" and \"isAnnotation\" rather than \"isInterface\", \"isAnnotation\" and \"isRegularInterface\"... But I see, we also have \"isRegularClass\".... We still have the possibility to change the semantics of those APIs in PMD 7 *Update:* Or in other words: What is less surprising? That isInterface returns true for annotations or that it returns false?"
        },
        {
          "prediction": "I don't think we need this anymore.",
          "reference": "This will potentially skip package results. Do we really want that?"
        },
        {
          "prediction": "I don't think this is an analogue.",
          "reference": "Please remove `HIP_UNSUPPORTED`"
        },
        {
          "prediction": "I don't think we need to store this in a struct.",
          "reference": "if this is a \"Status\" type then the variable name \"Stats\" (which implies \"statistics\") seems wrong (or at least confusing to me)"
        },
        {
          "prediction": "I'm not sure if this is the right place to use it. I'm not sure if it's the right place to use it, but if it's the right place to use it, I'm not sure if it's the right place to use it, or if it's the right place to use it, or if it's the right place to use it, I'm not sure if it's the right place to use it, or if it's the right place to use it, or if it's the right place to use it.",
          "reference": "maybe will be better to put it into the default worker's config rather than hardcoding the address?"
        },
        {
          "prediction": "I'm not sure why this test is failing. I'm not sure if it's worth it.",
          "reference": "It seems like this is not meant to test the option failure, but rather that `raw` can be set. This may be a superfluous test now, and we might want to delete it."
        },
        {
          "prediction": "I think this should be `view_set_fullscreen(output->fullscreen_view, false, output->wlr_output);`",
          "reference": "This is already done by `view_set_fullscreen`"
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "mmm I followed the convention of this collection. It has Add, Remove, RemoveAll, so All sounds reasonable. Else It would likely be AddPeer, RemovePeer, RemovePeers and Peers."
        },
        {
          "prediction": "I think this method should be called `getByUuid` instead of `getByIds`",
          "reference": "_nitpick_ I'm thinking about whether this method should be in the previous commit or not. I know it's not yet used there, but in theory, neither do UUID itself."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do this, I'm not sure if it's the right place to do this.",
          "reference": "\"break\" is right? You skip the line 768."
        },
        {
          "prediction": "Use the new Ruby 1.9 hash syntax.
    Space inside { missing.
    Space inside } missing.", "reference": "Can this use the route helper instead?" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for this, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, I'm not sure if it's the right place for it.", "reference": "Why is this field exported and others aren't?" }, { "prediction": "I'm not sure if this is a good test.", "reference": "should we rename this like `mongodb_srv_tests.js`?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `googlesitekit.pageTitle` or `googlesitekit.pageTitle.length` or `googlesitekit.pageTitle.length` or `googlesitekit.pageTitle.length` or `googlesitekit.pageTitle.length` or `googlesitekit.pageTitle.length` or `googlesitekit.pageTitle.length` or `googlesitekit.pageTitle.length` or `googlesitekit.pageTitle.length` or `googlesitekit.pageTitle.length` or `googlesitekit.pageTitle.length` or `googlesitekit.pageTitle.length` or `googlesitekit.pageTitle.length` or `googlesitekit.pageTitle.length` or `googlesitekit.pageTitle.length` or `googlesitekit.pageTitle.length` or `googlesitekit.pageTitle.length` or `googlesitekit.pageTitle.", "reference": "This should still have a value when there is no page title, e.g. just `__( 'Search Traffic Summary', 'google-site-kit' )`." }, { "prediction": "I think this should be `@link`.", "reference": "Oops.. meant to link to SplitOp here. I'll clean up in my next commit" }, { "prediction": "I don't think this is needed.", "reference": "Remove these unnecessary imports that you've added." }, { "prediction": "I'm not sure if we should change this to `success_https` or `success_hover` or `success_warning` or `success_https` or `success_hover` or `success_warning` or `success_hover` or `success_https` or `success_hover` or `success_https` or `success_hover` or `success_https` or `success_hover` or `success_https` or `success_hover` or `success_https` or `success_hover` or `success_https` or `success_hover` or `success_https` or `success_hover` or `success_https` or `success_hover` or `success_https`", "reference": "That space shouldn't be here :wink: This lead to an exception whenever a page with an error was loaded, e.g. an inexistent host - I just fixed that :smile:" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "It seems this is not the way to fix issue #505." }, { "prediction": "I don't think we need to change this line.", "reference": "Please take a look at the docstring of `F.binary_cross_entropy_with_logits`. `weight` should be a tensor that matches the input tensor shape. It is Not the class-aware weight. `pos_weight` should be a vector with a length equal to the number of classes." }, { "prediction": "I don't think this is the right place for this test.", "reference": "Same here, merge with an existing test." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "@aimanrosli23 Could you help to confirm if you do not revert the change in below commit: SHA-1: 643623147a1feaddd734ddd84604e1d8e9dcebee * MdeModulePkg/SdMmcPciHcDxe: Send SEND_STATUS at lower frequency" }, { "prediction": "I think we should move this method to `AvroSchemaUtil` and move it to `AvroSchemaUtil`.", "reference": "Can we do this without a breaking API change? What about adding a different name to convert directly to a Schema?" }, { "prediction": "I don't think we need to use `bluebird` here.", "reference": "Why do we need to pull bluebird in here?" }, { "prediction": "I think this should be a finally block.", "reference": "If *two* threads successfully download the same project into two different temp dirs, and one of them successfully renames one to its final destination, the `if`on line 102 will be false _in the other thread_, and it would leave its temp dir behind." }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if this is the right thing to do.", "reference": "I would appreciate it if you could rename `link` to `all_link` so that the roles of the two links (the other is `target_link`) become clearer." }, { "prediction": "I don't think we need to change this test.", "reference": "Is there a reason not to use `smi.create_expectedIndex` here (and in other places)? The `smi.create_expectedIndex` function will also check to make sure that you don't accidentally skip or duplicate any indexes. With the goal of avoiding errors in the test. It does mean that you have to be diligent with how the expected indexes are created, which can be annoying too. My logic was that it is better to be annoyed by constraints during development time than to find out some time later that the test didn't do what I thought." }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it.", "reference": "Put a comma after the last parameter of a multiline method call." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea, but I'm not sure if it's a good idea.", "reference": "I don't know if we even need this parameter." }, { "prediction": "I don't think we need to rename this file.", "reference": "What is the new result of this file if we keep it the same than before? It's just to picture easily what changed in this MR :) (thinking is hard)" }, { "prediction": "I don't think we need await here.", "reference": "This needs to be synchronous for the timeout to work." }, { "prediction": "We will be in touch with us at learn@thoughtbot.com should you have any questions or concerns. However, please don't hesitate to get in touch with us at learn@thoughtbot.com should you have any questions or concerns. However, please don't hesitate to get in touch with us at learn@thoughtbot.com should you have any questions or concerns.", "reference": "Can you break this onto multiple lines?" }, { "prediction": "I don't think we need to change this.", "reference": "OK, it looks like all children have bit 4 set, but it doesn't really matter at this split point: just informative, nothing reads it." }, { "prediction": "I don't think we need to do this in a follow-up PR.", "reference": "Sorry for the very basic question but why do we still have a DNSZone CRD in light of the DNSEndpoint, I don't fully understand the differences." }, { "prediction": "I don't think this is needed.", "reference": "Looks like loop with overhead. You can: - create SID - test private function `sessionIsUnique()`" }, { "prediction": "I don't think this is used anymore.", "reference": "In my opinion, it would be better to have two separate settings. One that stores if sorting is enabled and one that stores the order. That allows to toggle automatic sort without having to re-select the order." }, { "prediction": "I don't think this is needed anymore.", "reference": "/me can't wait to rename this repo :)" }, { "prediction": "I don't think this is used.", "reference": "nit: maybe call these `loadCollection()/loadDb()`" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `task.Task.run` or `task.Task.run` or `task.Task.run` or `task.Task.run` or `task.Task.run` or `task.Task.run` or `task.Task.run` or `task.Task.run` or `task.Task.run` or `task.Task.run` or `task.Task.run` or `task.Task.run` or `task.Task.run` or `task.Task.run` or `task.Task.run` or `task.Task.run` or `task.Task.run` or `task.Task.run` or `task.Task.run` or `task.Task.run` or `task.Task.run` or `task.Task.run` or `task.Task.run` or `task.run` or task.run` or `task.run`", "reference": "Did you consider just do `return Task is an external data dependency and data does not exist (yet?).'`? Less `None`'s and `ifs`." }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "Some day, we really need to make these toolbars pluggable.." }, { "prediction": "I don't think this is needed.", "reference": "This should be `pygment=False` like in `browsertab.py`" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Should this be moved down (or up) to under the client lock instead of server lock?" }, { "prediction": "I'm not sure why this was removed.", "reference": "Why are we removing this?" }, { "prediction": "Line is too long. [89/80]", "reference": "What do you think about using `self.id`?" }, { "prediction": "I'm not sure if this is the right place to start Typha connection. I'm not sure if it's the right place to start Typha connection, but if it's the right place to start Typha connection, then it's the right place to start Typha connection.", "reference": "Please log once here at Error level \"Failed to connect to Typha, will retry...\"" }, { "prediction": "I don't think we need this anymore.", "reference": "Can you revert this change? The `VERSION` value will be updated after maintainer determines the version at release." }, { "prediction": "I don't think we need to change the name of the service.", "reference": "It could be better if we use the up case letter to specify the constant string name. Such as QUALIFIED_SERVICE_NAME_KEY can let the user know it's a constant string." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "This should be `@configuration.failure_exit_code`, we don't want to hard code 1." }, { "prediction": "I don't think this is needed.", "reference": "Changed per review in Blockly." }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if this is the right place to do this.", "reference": "Hi @wenyingd. so what's the original dst MAC of the reply packet from kube-proxy?" }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to add a `exclude-too-few-public-methods` argument to the `MisdesignChecker` class.", "reference": "Note: I wasn't sure what the right wording would be for this, so I used existing language from elsewhere in the codebase." }, { "prediction": "I don't think we need to do this. I'm not sure if we need to do this, but I think it's better to do this in a separate PR.", "reference": "Docstring for `platform`." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This should be called before any `os.Exit` otherwise it could still mess up things." }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to change it.", "reference": "shouldn't this be `short`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Can you please paste the output of `volume list` command which will show capacity of a openebs volume." }, { "prediction": "I think this should be `@SuppressWarnings(\"unchecked\")` or `@SuppressWarnings(\"unchecked\")`", "reference": "I'd make this a `throw new NullPointerException(\"metric == null\");` instead" }, { "prediction": "I don't think this is needed.", "reference": "Include should be order lexicographically." }, { "prediction": "I don't think this is needed anymore.", "reference": "We need to pass in the Activity context here, so that LoginActivity is used, and so that LoginActivity can get onActivityResult from the PasscodeActivity. Without this, the application context is used, and we don't get a callback when the passcode is done." }, { "prediction": "Align the parameters of a method call if they span more than one line.", "reference": "Can you move these to the top please, for consistency with other models - normally we put scopes immediately after the associations at the top of the model. As to names I agree with @gravitystorm that these names may be confusing but I'm not sure the ones I suggested are perfect either so I'm not really sure what's best. The goal of my names was just to separate point which could be ordered (as `ordered`) from those which can't (as `unordered`) but I realise that may not be very clear from the names." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but I'm not sure if it's the right place to do it.", "reference": "Looks like the episode should also not be deleted when repeating" }, { "prediction": "I don't think this is needed.", "reference": "I feel like goimports would move this import line by the other non-std packages... can you double-check that? Run goimports or set up your editor to run it on save. :+1:" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "`options['binary'] = WebDriver::Chrome.path` if set?" }, { "prediction": "I don't think we need this file anymore.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I don't think this is needed.", "reference": "Nit: Supported -> Enabled." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Yay! I was too lazy to fix this." }, { "prediction": "I don't think this is needed anymore.", "reference": "other declaration of errors (from `typecheck`)" }, { "prediction": "I don't think this is needed.", "reference": "nit: error starts with capital letter" }, { "prediction": "I don't think this is needed anymore.", "reference": "the original code ignores \\Draft and \\Recent, whereas your change will not. what this matters, i'm not sure." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Why was this necessary?" }, { "prediction": "I think this should be `Rerun` or `Rerun`", "reference": "Can you also do this for Cover?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "So I tried adding this VU a long time ago, thought it would be this simple of a check, but turns out there were other validation in the way for getting here in `ValidateImageAspectMask` I assume that is what is failing CI here, realized it would require some more refactoring" }, { "prediction": "I'm not sure if this is the right place for this function, but I'm not sure if it's the right place for this function.", "reference": "This method is not needed for postgresql, by default sum function omits null values so we can remove this file" }, { "prediction": "I'm not sure if this is the correct way to do this.", "reference": "Can you provide a `--with-systemdsystemgeneratordir` option here? So that I can do unprivileged installs without completely turning off systemd. I can add it as a follow-up PR too." }, { "prediction": "I don't think this is needed anymore.", "reference": "`classification` is misspelled" }, { "prediction": "I don't think we need to emit samples that were specifically generated for backward-compatibility. I don't think we need to emit samples that were specifically generated for backward-compatibility.", "reference": "Can you change this to `sampleInitCode`?" }, { "prediction": "I don't think this is the right place to do this.", "reference": "I added a startTs information in `TiDagRequest` output. Not really sure if it is useful? @zhexuany" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This prevents margin/border/padding CSS from affecting the width/height (otherwise in Chrome a width and height of 1 would result in a rect size of 5x5)." }, { "prediction": "Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "prefer to just add this to the `verify_authorized` exception list above since we're already making exceptions." }, { "prediction": "I think this should be `reset($storage->used_trait_lc)` instead of `reset($storage->used_trait_lc)`", "reference": "was there a reason to not loop over parent classes here?" }, { "prediction": "I don't think this is needed anymore.", "reference": "@billybonks Why move `import Ember from 'ember';` to the top?" }, { "prediction": "I'm not sure if this is the right place for this column.", "reference": "Everything's so simple (a `ThreeStateWorkflow`) until it isn't :smirk:" }, { "prediction": "I think this test should be `np.NaN, np.NaN, 0.5`", "reference": "I don't quite understand where the NaNs come from..." }, { "prediction": "I don't think we need to change this.", "reference": "File is not `goimports`-ed" }, { "prediction": "I don't think this is needed.", "reference": "I wonder if we should look at moving the Python stuff to a plugin and doing this there rather than adding to core plz at this point?" }, { "prediction": "I don't think we need to change this line.", "reference": "This is the actual bug fix. I prob should have broken this out into two PRs." }, { "prediction": "I don't think we should add this to Nethermind.Core.Specs", "reference": "I am not sure if we need this, we already have DifficultyBombDelays" }, { "prediction": "Is this needed?", "reference": "move to finally - I can see at least one return that would omit it, also any exception and so on" }, { "prediction": "I don't think we need to check stakingV2 here.", "reference": "remove `genesisConfig.GravityChainStartHeight == 0`" }, { "prediction": "I think this should be `vendor/symfony/var-dumper/Resources/functions/dump.php` instead of `vendor/symfony/var-dumper/Resources/functions/dump.php`", "reference": "this might kill whole application if `var-dumper` will not be installed. What about two separate file_exists conditions (monorepo/project)?" }, { "prediction": "I don't think we need to create the settings file here.", "reference": "Hrm. Maybe this isn't the correct spot to run this? Because it errors if the app type doesn't support settings. But we want to check that before running it." }, { "prediction": "I don't think we need to change the name of the function.", "reference": "Why are you changing this name?" }, { "prediction": "I don't think this is enough.", "reference": "as we discussed, maybe it would be better to - [ ] set OVERRIDE_IN_DOCKER=1 in the Dockerfile - [ ] replace the if statement with `os.path.exists(\"/run/.containerenv\")` as @dfangl suggested" }, { "prediction": "I think this should be `is_ancestor_name` instead of `is_ancestor_name`.", "reference": "I like this style of doing things better than having super big conditional without explanation. Even though I know this won't be re-used it's nice to have a function if only for clarity." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Our preference here is to either have inline statements e.g. `@group_level -= 1 if @group_level > 0` but stylistically here I think `return @group_level if @group_level == 0` might be nicer. As it stands however our rubocop is picking this up as a fail :(" }, { "prediction": "I don't think we need to fix this in the parent class.", "reference": "Spark3 Is supported in OSS Iceberg, Do you mean this particular function is not supported in Spark3? If so I think we should have a more clear reason why" }, { "prediction": "I don't think this is needed. I think it should be `check.str_param(notebook_path, \"notebook_path\")` or `check.str_param(notebook_path, \"notebook_path\")`", "reference": "something about the arbitrary file access part here makes me nervous. Can we keep the `if not path.endswith(\".ipynb\")` check from before here as well? Just imagining a weird attack scenario where somebody somehow uses this to get access to confidental files or something" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I wonder if we should push this and the search_params_logic into the blacklight config." }, { "prediction": "I'm not sure if this is the right place to set it.", "reference": "don't need this line, since it is not tested here?" }, { "prediction": "I think this should be `None` and not `None`.", "reference": "I wonder if adding this new param in the middle of the param list might screw up some existing code that is depending on the old parameter order. Might be better to add it to the end of the parameter list?" }, { "prediction": "I think this should be `String.format(\"%s/(build|src/generated.*)/.*\", project.getProjectDir().getAbsolutePath()));`", "reference": "I wonder if this absolute path is gonna affect the build-cache relocatability of these compile tasks??" }, { "prediction": "I'm not sure if this is the right place for this.session.inTransaction()", "reference": "possible bug if `fullResponse` is false" }, { "prediction": "I don't think this is needed anymore.", "reference": "nitpick: Please only `import string` here and use `string.ascii_lowercase` - I really like to see what module stuff is coming from without looking at the imports." }, { "prediction": "I don't think we need to do this anymore.", "reference": "nitpick: the only reason we have a catch for every one of these promises is because the test isn't properly chaining promises (returning them within each `then`). We could reduce the `catch` with `console.dir` to a single instance if that was done" }, { "prediction": "I'm not sure if this is the right place for this test.", "reference": "why do this?" }, { "prediction": "I don't think we need to change this.", "reference": "For consistency, would it not be best to also replace the first class name? `traceLog('Class '. static::class.'has been deprecated, use '. SystemMediaLibrary::class.'instead.')`" }, { "prediction": "I think this should be `true` or `false`.", "reference": "this should be `EnabledAdminAPI` and the json string should then be `enableAdminAPI`" }, { "prediction": "I don't think this is needed.", "reference": "Noticed some missing imports in manage.py so thought I'd add them" }, { "prediction": "I think we should remove this flag from flow exporter.", "reference": "as a future improvement, maybe we should just change `ForAllFlowRecordsDo` so that `updateOrSendFlowRecord` uses a flow record pointer instead of a copy of stored flow record. This whole code is executed with the lock any way." }, { "prediction": "I don't think this is needed.", "reference": "I am not sure what GitHub wants to tell me with this icon here :)" }, { "prediction": "I don't think we need to change this test.", "reference": "can we also check for smaller zoom levels returning valid error codes?" }, { "prediction": "I don't think we need to add this to the `ScenarioMeasurement.cs` file.", "reference": "1) These names are not great, doesn't help explain what they do. 2) Instead of methods like this that hard code some number of = and *, why not a method that takes the string, defaults to a char to surround with, and a width? 3) Do we really even need headers like this in the output? Maybe we ditch them." }, { "prediction": "I'm not sure if this is the correct behavior. I'm not sure if this is the correct behavior.", "reference": "The autocomplete editor shouldn't change its own behavior, I assume that `autoWrapCol` and `autoWrapRow` options should be set to `false` in handsontable editor." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "out of curiosity, with IPv6 introduced, why there's no change to the expected output of openflow in the test?" }, { "prediction": "I'm not sure if this is correct. I'm not sure if it's correct or not.", "reference": "nit: grammar: instruction" }, { "prediction": "I don't think this is needed.", "reference": "We can revert this to reduce the diff of the PR." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "i think this missed the reconciler to callsite change" }, { "prediction": "I don't think this is needed.", "reference": "Please reuse `getClientConfigPath`." }, { "prediction": "I'm not sure if this is the right place to use `../../tools/spec-runner/matcher.default` or `../../tools/spec-runner/matcher.default`", "reference": "Should we use the shared chai-addon.js file here? Actually we should consolidate any `chai.use` calls, I see 20 instances, quick win?" }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "Maybe move _agreedCapabilities and _availableCapabilities from List to SortedSet? We could order them by code and then by version already." }, { "prediction": "I'm not sure this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I see the `+1` issue, but we used to check if `o.lss!= nil` and we don't anymore, so we are sure that it won't be nil here, right?" }, { "prediction": "I don't think this is the best way to do this. I'm not sure if this is the best way to do it.", "reference": "why is the `send` needed?" }, { "prediction": "I don't think we need to check if `bboxes` is `torch.Tensor` or `torch.Tensor`?", "reference": "Is this necessary? If so, we need to update the docstring." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Checking for actionable here instead of grabbing the first pending approval. I tested this with proposal ID 265 on staging." }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if this is a good idea.", "reference": "I made this change because I wasn't getting printouts of the'result' value when the assert was inlined for some reason. I think it's related to creating new CallbackCheckers maybe?" }, { "prediction": "I don't think we need this interface.", "reference": "nit: the correct name is \"request line\", so let's use the right one here :)" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "This should now use `[]`, so it crashes if the var is missing" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this. I'm not sure if this is the right place to do this.", "reference": "you could use `bpf_map_update_elem` with `BPF_EXIST`" }, { "prediction": "I'm not sure why we're getting an IOException here.", "reference": "thanks for noticing this! But I think we should not have it in this PR." }, { "prediction": "I don't think this is needed.", "reference": "A few things: - This may not serialize because I think the property for the sequence number on an input is `.sequenceNumber`. - There should be tests to cover these statements - Indentation is incorrect (should be two spaces, as similar to the statements above)" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to raise an error if the data format is not supported.", "reference": "If this is a base method that could be used by others, should you hardcode 'GCS uploader' here?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "just a little thing: let's introduce a `final int bound = length - back.length();` that saves us calculating the bound each time checking the loop condition." }, { "prediction": "I think this should be `/settlements/pay/{peer}`", "reference": "I think that this should be a POST method, as it changes the state. Get requests should not change the state. With different method, I would suggest to have the handler under `\"/settlements/{peer}\"` path." }, { "prediction": "I don't think this is used.", "reference": "This is the default value?" }, { "prediction": "I don't think this is needed anymore.", "reference": "The spaces are actually legitimate here: in python, you: - first import standard library modules (hint: time is one) - then import 3rd party library modules - then import the modules from you project (here kinto). Between each block you need an empty line." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to change the name of the object.", "reference": "Haha, whoa, I'm not sure how I let that one go by. :)" }, { "prediction": "I don't think this is needed.", "reference": "FWIW: We have FileUtil.generateOriginalExtension for tabular files but it uses a hardcoded list rather than the properties file." }, { "prediction": "I'm not sure if we should do this in the `StartDataplaneDriver` function. I'm not sure if we should do this in the `StartDataplaneDriver` function, but I'm not sure if we should do this in the `StartDataplaneDriver` function.", "reference": "I would consider extracting this logic in to a helper function to make it a bit more readable, but that's just my opinion." }, { "prediction": "I'm not sure if we should change this to `true` or `false`", "reference": "Are all fields beginning with \"Debug\" automatically `;local`? (I guess so, but just checking.)" }, { "prediction": "I think this should be `DeprecationWarning: EvalHook and DistEvalHook is a deprecated, please use \"mmcv.runner.EvalHook\" or \"mmcv.runner.DistEvalHook\"`", "reference": "We should let this module inherits from the EvalHook supported in MMCV, and only override the `__init__` function by adding the warnings. The other functions can use those in MMCV." }, { "prediction": "I don't think this is needed.", "reference": "Let's use prepared statements here instead" }, { "prediction": "I don't think this is needed.", "reference": "Just leaving this in one place but thanks so much for re-organising all these imports." }, { "prediction": "I think this should be `#ifdef X86 #ifdef X86 #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif #endif", "reference": "Ditto, here and below" }, { "prediction": "I'm not sure if this is the right fix, but I think it's better to use `typeof vnode.type!=='function' && typeof vnode.props[key]!=null && typeof vnode.props[key]!=='function' && typeof vnode.props[key]!=null && typeof vnode.props[key]!=='function' && typeof vnode.props[key]!=null && typeof vnode.props[key]!=null && typeof vnode.props[key]!=null && typeof vnode.props[key]!=='function' && typeof vnode.props[key]!=null && typeof vnode.props[key]!=null && typeof vnode.props[key]!=null && typeof vnode.type!=='function' && typeof vnode.props[key]!=null && typeof vnode.props[key]!=null && typeof vnode.type!=='function' && typeof vnode.props[key]!=null && typeof vnode.type!=='function' && typeof vnode.props[key]!=null && typeof vnode.type!=='function' && typeof vnode.props[key]!=null && typeof", "reference": "Let's move the check outside the `for`-loop so that we don't have to do it for every prop. If we change it to check for `vnode.type ==='string'` we can automatically skip checking text nodes which don't have props" }, { "prediction": "I'm not sure if this should be `finalize_column` or `finalize_row` or `finalize_column` or `finalize_row` or `finalize_column` or `finalize_row` or `finalize_row` or `finalize_column` or `finalize_row` or `finalize_column` or `finalize_row` or `finalize_column` or `finalize_row` or `finalize_column` or `finalize_row` or `finalize_column` or `finalize_row` or `finalize_column` or `finalize_row` or `finalize_column`", "reference": "Seems like the docstring here should simply be \"Deprecated; use `hooks` instead.\"." }, { "prediction": "I don't think this is needed.", "reference": "It would be nice to have an `attr` in `styles.xml` for this, so we don't need the same `if` statement in multiple places" }, { "prediction": "I think this should be `t.belongs_to :user`", "reference": "How about `null: false` on these two lines? Also `t.timestamps null: false`?" }, { "prediction": "I don't think we need to do this. I think we need to check whether the table/view exists in the metastore.", "reference": "This recommendation isn't very helpful because it isn't clear what \"the metastore\" is. How about this instead: \"To fix this, use an alternative metastore\"." }, { "prediction": "I don't think this method is used anymore.", "reference": "The `SymbolTable` deals only with symbols, I think we can just call this `isUsed` here." }, { "prediction": "I don't think this is needed.", "reference": "Please hide this behind a flag and add a setter function to the builder." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Just a side-node, no need to change it here: The term \"recent\" might be confusing at a later point in time." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "When can it be undefined? Wouldn't that be a bug?" }, { "prediction": "I don't think this is needed anymore.", "reference": "JMX offers normal APIs for this. I don't think you want the glassfish one." }, { "prediction": "I'm not sure if this is the right place to use `F.mean(colname).alias(\"{}_mean\".format(colname)), ).toPandas()` or `F.mean(colname).alias(\"{}_mean\".format(colname)), ).toPandas()`", "reference": "Could you remove `,' at the end?" }, { "prediction": "I'm not sure if this is the right place to check for `typeof opt_port!== 'function'`", "reference": "Maybe it would simpler to ignore opt_port if type!== 'number'?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "do you want to rename the codec tag here too?" }, { "prediction": "I don't think we need this.", "reference": "These command names are specific to Chromium-based browsers. Please move to `ChromiumDriverCommand`" }, { "prediction": "I don't think this is needed.", "reference": "Hm.. should we auto-patch? I am less sure on this yet as `percentile_approx` seems a Spark function and auto-patching it in Koalas seems a bit counterintuitive." }, { "prediction": "I don't think this is needed anymore.", "reference": "I found domain use in `AllFeedsTest::getAllFeedExportCreationData` and class AllFeedsTest is descendant of `FunctionalTestCase`. I think so we can rewrite this too.." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I am wondering if it is better to consolidate all committer checkpoint states into a single structure, e.g. Pojo class or Avro record which are Flink supported state types for schema evolution." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I assume this is a performance optimization to only check this once when creating the signal filter? While you're at it, maybe make `BLACKLIST` a set instead?" }, { "prediction": "I don't think this is needed.", "reference": "Please use async/await and try/catch" }, { "prediction": "I don't think this is needed.", "reference": "Like I said, this code looks incorrect. Why is it still looking up the attribute? Why is it getting the type from `nested->type.struct_def` instead of `field.nested_flatbuffer`? Are you running `generate_code.sh`, because I think `nested->type.struct_def` would be null?" }, { "prediction": "I'm not sure if this is the correct behavior for Push Descriptor Extension.", "reference": "Actually, I'm not sure why lines 1663-1668 are here. Looks like Push descriptors aren't used in the test at all. @ziga-lunarg?" }, { "prediction": "Please use `String#equalsIgnoreCase(field.getSimpleName())`", "reference": "Don't we still want to check it it's a keyword?" }, { "prediction": "I'm not sure if this is the right place for this, but I think it's better to use `#{link_text}` instead of `#{link_text}`.", "reference": "this can just me `link_text` :tomato:" }, { "prediction": "I'm not sure if this is the right place to test this, but I'm not sure if it's the right place to test this.", "reference": "What if the Series contains null values?" }, { "prediction": "I think this should be `PhysicalLocationComponent.CreatePhysicalLocationComponent()`.", "reference": "Every place you see a change like this, it's because `PhysicalLocation` is now its own object, not an array of `PhysicalLocationComponent` objects. The `Uri` is the key into the `FileInfo` dictionary." }, { "prediction": "I don't think we need to change this?", "reference": "Like in atss_head" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to do this in a loop. I'm not sure if it's a good idea to do this in a loop, but if it's a good idea to do it in a loop, I think it's a good idea to do it in a loop.", "reference": "nit : I think it would be better to have the multiplier being calculated along with `pool.numPendingWholeBlocks`, so that we could always multiply the feePerByte with that multiplier. Not only that it would be faster, but it would also have constant time. btw - Correct me if I'm wrong, but with this change, you're practically rolling back your previous change while making it `pool.expFeeFactor` adjustable, right?" }, { "prediction": "I'm not sure if this is the right place to put this method in the `ApplicationController` class. I think it's better to move this method to the `ApplicationController` class.", "reference": "Is there a reason we _wouldn't_ want to do this? A bit of a security hole :grimacing:" }, { "prediction": "I don't think this is needed.", "reference": "Please add a copyright notice to all new files. Is there a tool to check and auto update copyright notices?" }, { "prediction": "I don't think we need to change the label here.", "reference": "A new translation dump should be made after this change (removing the \"Email\" message)" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "CI is failing saying `expected [TypeError: null is not an object (evaluating 'implicitNodes(role).map')] to equal null`." }, { "prediction": "I don't think this is needed anymore.", "reference": "@JoviDeCroock I replaced the refs here with simple assignments." }, { "prediction": "Why is this protected?", "reference": "nit: Could we use VisibleForTesting annotation here?" }, { "prediction": "I'm not sure if this is the right place for this test, but I think it's better to use `joins(:topic).where(\"posts_count = '1'\").order('created_at desc')`", "reference": "Can we create some post records to assert sort_by" }, { "prediction": "I don't think we need to reset the stream.", "reference": "is this necessary?" }, { "prediction": "I don't think we need to make this `ImmutableList>`?", "reference": "What is the purpose of this? It seems like it is used to indicate whether there is a filter on a span. But what filter? Could there eventually be multiple filters per span? Just not understanding." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "using a certain type instead of using string directly." }, { "prediction": "I don't think we need to rename the same file.", "reference": "fix trailing," }, { "prediction": "I'm not sure if this is the right place to put the `mlat` link in here.", "reference": "I've fixed it for this change but for future reference there's no point doing string substitution for a single value like that - it will just slow things down. Just use `:mlat => trace.latitude` etc instead." }, { "prediction": "I don't think we need this anymore.", "reference": "The form no logger needs validation?" }, { "prediction": "I think this should be `metricsToExport!= null && metricsToExport.Metrics.Count > 0 && metricsToExport.Metrics.Count > 0 && metricsToExport.Metrics.Count > 0`", "reference": "there'd be more changes in the area, when we implement \"clean-up\" of aggregators if no new updates. (i think we currently send metricitem to exporters with zero as value)" }, { "prediction": "I'm not sure if this is the right place to test the `id` and `resource_name` attributes.", "reference": "Usually we only keep the assertions that are relevant to the specification (ie. the test title). For example, the test on the values of id and details is not properly relevant for the spec _collections are isolated by bucket_. I suggest that you only keep the assertions regarding `details` in dedicated tests similar to `test_unknown_collection_raises_404` from `test_views_records.py`, but for each of bucket, group, collection and record in the other `test_views_` files." }, { "prediction": "I don't think we need this anymore.", "reference": "The test sources are ok though, you don't need to remove those changes" }, { "prediction": "I think this should be `width: width, maxWidth: width * 2, type: \"Primary\"`", "reference": "`maxWidth: width * 2,` Potentially, this will be the same as `getImageUrl`: 80px or 500px. I can't verify this - need for normal LiveTV tuner." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Not really related to this issue but should we use fuzzy search here as well (like for apps)?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "isn't the usual capitalization for subcommands force-qr? (don't care too much about it)" }, { "prediction": "I'm not sure if we should change this to `SeverityLevel.WARNING` or `SeverityLevel.SUGGESTION` or `SeverityLevel.WARNING` or `SeverityLevel.SUGGESTION` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.SUGGESTION` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `SeverityLevel.WARNING` or `Severity", "reference": "Do you know how many repos have hit this?" }, { "prediction": "I'm not sure if this is the right place to put this text.", "reference": "I'll be interested to see if our gettext rake tasks will pick up on this text to translate" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I think you need to change line 928 value from 6 to 7 too, since now table will have 7 values" }, { "prediction": "I think this test should be `assert set(f1.names) == set(f2.names)`.", "reference": "Does `f0[::-1, :]` mean all the rows taken in a reverse order?" }, { "prediction": "I'm not sure if this is the right place to put this test.", "reference": "Looks like there are strange characters here." }, { "prediction": "I don't think we need to check if `chaos.IsPaused()` is true.", "reference": "It is better to have a check to ensure the format is valid." }, { "prediction": "I don't think this is needed anymore.", "reference": "How about `nextAlreadyDefined` variable name in method signature?" }, { "prediction": "I don't think we need to change this.", "reference": "In older SDK versions the data converter was called 3 times but now it is 2. This is because logic was changed deep in the interceptor chains on when values are serialized and encoded and such. Previously we invoked the data converter on results _even if there was an error_ (and most of the time they were nil). Now we don't do such a thing, resulting in fewer calls." }, { "prediction": "I'm not sure if this is the right place for this file.", "reference": "formatting... can this import go next to the other sources ones?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to remove it.", "reference": "I don't understand why anyone would pass 0? If you don't want to attach to an existing process you just wouldn't pass -attach. I would remove that sentence and make 0 an invalid argument." }, { "prediction": "I'm not sure why this is removed.", "reference": "This change is responsible for #2775" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Should we add this to the other \"never\" verification in lines 71-73 above, too?" }, { "prediction": "I don't think this is needed.", "reference": "Fixed this since it no longer needed to be switched from a generator to a list, this was missed when I cleaned up the dataset code in an earlier PR." }, { "prediction": "I'm not sure if this is the best way to do this, but I think it's better to use `logger.info(String.format(\"Adding %s %d times\", caps, info.getMaximumSimultaneousSessions())))` instead of `logger.info(String.format(\"Adding %s %d times\", caps, info.getMaximumSimultaneousSessions())))`", "reference": "This is an informational message that allows someone to read the console output and understand how the grid node is configured. Please leave." }, { "prediction": "I think this should be `SELECT name_facts.* FROM name_facts WHERE name_facts.name_id = #{name_id.to_i} OR name_facts.name_id IN ( SELECT AA.preferred_name_id FROM analysis_aliases AA WHERE AA.analysis_id = projects.best_analysis_id AND AA.commit_name_id = #{name_id.to_i} AND AA.commit_name_id = #{name_id.to_i}))`", "reference": "Can we convert this to an arel as below ContributorFact.joins(:project).where(projects: { id: project_id}).where('name_id =? or name_id in (?)', name_id, AnalysisAlias.select(:preferred_name_id).joins(:project).where(commit_name_id: name_id) )" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Does this cause issues if you have lots of load on the machine? Having a global variable for this seems like a bad idea IMO." }, { "prediction": "I don't think this is the correct error message.", "reference": "We probably don't need to print the msg with e.getMessage(). It will be printed by the logger since we are passing the exception as a parameter." }, { "prediction": "I'm not sure why this was removed, but I think it's a good idea to remove the `patched_testinfra_get_tests` method from `molecule.verifier.testinfra.Testinfra._get_tests` and remove the `patched_testinfra_get_tests` method from `molecule.verifier.testinfra.Testinfra._get_tests` method.", "reference": "Can we get a test with multiple directories as per the initial example?" }, { "prediction": "I think this should be `x+` instead of `x+`", "reference": "I assume this is because you were seeing cases where left was a negative number? When?" }, { "prediction": "I don't think this is needed.", "reference": "this is undoing recent changes for increased consistency of include file statements. please restore to the original." }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to remove it.", "reference": "If these are applied in order, should `LambdaMethoReference` come after `OptionalOrElseMethodInvocation`" }, { "prediction": "I don't think this is needed anymore.", "reference": "Why this rename?" }, { "prediction": "I don't think we need to check for `mock_main` here.", "reference": "Why do we do this check here? `sys.version_info` cannot be less than 3.3 as pylint does not support older versions. I think we should avoid popping `__main__` altogether." }, { "prediction": "I don't think this is needed.", "reference": "This can be removed too." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I'm a little worried about the new extra calls to `MakeMdId`, since in most local-server KBFS profiles, hashing is the biggest CPU user, and not re-using the value calculated by the client will result in even more hashing. That said, I understand why you did it this way, and I don't have a concrete suggestion on how to make it better. Just something to keep in mind; plus it might be worth comparing the test speed before and after this change to make sure it didn't slow things down too much." }, { "prediction": "I don't think this is needed.", "reference": "`lodash` shouldn't be grouped under WordPress dependencies" }, { "prediction": "I think this file should be renamed to `Copyright (C) 2006-2012 NVDA Contributors`", "reference": "Just curious, but how did you work out that Aleksey Sadovoy, Peter Vgner and Joseph Lee contributed to this file? Did you look at the repository history?" }, { "prediction": "I don't think we need this.", "reference": "You could call OnStopRude() directly here to do the same thing." }, { "prediction": "I'm not sure if this is the right thing to do here. I'm not sure if it's the right thing to do here.", "reference": "This TODO and this `sort` depend on how the UI looks like. So I think we should fix the UI before continuing on updating this web API. For example, in case the UI flow is as below, this API will receive a Piped ID and then return just ones belonging to that Piped. - User picks where they want to deploy first (select one Piped and one cloud provider) - Then API will be called to show the list of suggested apps for that Piped and cloud provider - User picks app they want to create" }, { "prediction": "I'm not sure if this is a good idea. I think it's better to say \"This command displays status of available snapshotrevert.\".", "reference": "This command rolls back the volume data to the specified snapshot. Once the roll back to snapshot is successful, all the data changes made after the snapshot was taken will be post. This command should be used cautiously and only when there is an issue with the current state of the data." }, { "prediction": "I think this should be `\"ecs-functional-tests/awslogs/%s\"`", "reference": "should this be a separate/new functional test?" }, { "prediction": "I'm not sure if this is the right place to test this, but I'm not sure if it's the right place to test it.", "reference": "Can these also assert at least the length of arrays returned and ideally contents?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "`hasattr(task, 'param_visibilities')` is more concise with the same effect, but either one works." }, { "prediction": "I think this message should be \"Positional arguments are out of order\" or \"Arguments given to a function call have are being passed in a different order\"", "reference": "I would hedge this a little, maybe `Positional arguments appear to be out of order`. After all, it's just a guess." }, { "prediction": "I don't think this is needed.", "reference": "you can directly call show() method from **SnackBarHandler.show(coordinatorLayout, getString(no_account_signed_in)).show();** no need to create an extra object and then call the show method." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "concatHosts may be a better func name to explain this?" }, { "prediction": "I don't think this is needed.", "reference": "A function that returns empty string." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "If it's not the root package, or if it is the root package but we don't add the psudo :pleasings rule there, print an error." }, { "prediction": "I'm not sure if this is the right place to put this in.", "reference": "can delete this line" }, { "prediction": "I don't think this is the right place to do this.", "reference": "Will it still be an issue if all the models use the same data set?" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if this is the right place for this.", "reference": "How does this controller_name method work? Does this method grab the context of the url request? Wouldn't this always result in 'widget'?" }, { "prediction": "I don't think this is needed.", "reference": "Let's get rid of these for the final version and if you get rid of the macro I left last time I'd be more than grateful." }, { "prediction": "I don't think this is needed.", "reference": "Instead of `DELETE_MARK`, how about `IS_DELETED`? I don't think that \"mark\" is clear enough to describe what this is. Similarly, I think the docs should be \"Whether the row has been deleted\". There's no need to include \"delete mark\" because that's identifying something that is not defined (this column is _deleted and \"mark\" is not introduced), and \"or not\" is unnecessary because it is implied by \"whether\"." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Does it make sense to have this very thin wrapper that only calls `create_dependencies`? And maybe having `create_dependencies` return a set would be better than convert here?" }, { "prediction": "I don't think we need to pass the escape argument to h2o_get_compressible_types. I think we should pass the escape argument to h2o_get_compressible_types. I don't think we need to pass the escape argument to h2o_get_compressible_types. I don't think we need to pass the escape argument to h2o_get_compressible_types. I don't think we need to pass the escape argument to h2o_get_compressible_types.", "reference": "How about renaming `escape` to `use_path_normalized` or something to better indicate that it is a selection between `path` and `path_normalized`?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `NULL_ACCOUNTABLE` field in the `Accountable` class. I'm not sure if it's a good idea to have a `NULL_ACCOUNTABLE` field in the `Accountable` class. If it's a good idea to have a `NULL_ACCOUNTABLE` field in the `Accountable` class, I'm not sure if it's a good idea to have a `NULL_ACCOUNTABLE` field in the `Accountable` class. If it's a good idea to have a `NULL_ACCOUNTABLE` field in the `Accountable` class, I'm not sure if it's a good idea to have a `NULL_ACCOUNTABLE` field in the `Accountable` class. If it's a good idea to have a `NULL_ACCOUNTABLE` field in the `Accountable` class, I'm not sure if it's a good idea to have a `NULL_ACCOUNTABLE` field in the `Accountable` class. If it's a good idea to have a `NULL_ACCOUNTABLE` field in", "reference": "Interface members are always `static final` right?" }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do this. I'm not sure if it's the best way to do this.", "reference": "It seems to me that this could be in the runtime_nintendoswitch.go file, or is there a reason to keep it separate?" }, { "prediction": "Is this still needed?", "reference": "I was actually looking at this code over the weekend and wondering whether we were trying to link here. I assume it's been cargo culted from something else in the compiler." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `name` or `department_name` here. I'm not sure if it's a good idea to use `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or `department_name` or", "reference": "nice extraction of the form for being used at new/edit. We should have more of these" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's worth it.", "reference": "Are the coefficients the actual bug fix?" }, { "prediction": "I don't think we need to check for `IntegrityError` here. I don't think we need to check for `IntegrityError` here.", "reference": "Why are the error code options in a list and not a tuple?" }, { "prediction": "I think this test should be `TEST_BAD_ANC = [Project('123'), Folder('456'), Organization('ABC')]`", "reference": "Need alignment with the preceding line." }, { "prediction": "I don't think we need this method anymore.", "reference": "Changing from a static method to a constant is inessential to Type Transactions and has a long reach, adding many unneeded files and diff lines." }, { "prediction": "I'm not sure if this is the right fix. I'm not sure if this is the right fix or if it's the right fix or if it's the right fix.", "reference": "There is one caveat: javaslang.collection.Iterator is Iterable. With Iterator it does not work. Let's revert this line. Does this happen elsewhere, too? I will double-check the code..." }, { "prediction": "I think this should be `True` or `False`", "reference": "Why change the default value of `is_diff`?" }, { "prediction": "I don't think we need to change this to `tenacity>=6.3.0` or `tenacity>=6.3.0`", "reference": "I think tacking on `,<7` would be a wise precaution in case of future incompatible changes in tenacity." }, { "prediction": "I don't think this is needed anymore.", "reference": "I don't think is necessary to remove the return type" }, { "prediction": "I don't think we need to pass the secret from the authenticator service to decrypt the passcode from the authenticator service. I don't think we need to pass the secret from the authenticator service to decrypt the passcode from the authenticator service. I don't think we need to pass the secret from the authenticator service to decrypt the passcode from the authenticator service.", "reference": "Also added this check, since client secret is not used except in the IP bypass scenario." }, { "prediction": "I don't think we need to clear profile ID here.", "reference": "That's unrelated, but shouldn't there also be a call to `setInternalWebPropertyID`, making it empty, for this case? Otherwise, when selecting to create a new property, any previous internal web property ID will still be in state, potentially causing problems." }, { "prediction": "I'm not sure why this was removed.", "reference": "I wonder if we should trigger a PHP error and ensure it ends up in the log?" }, { "prediction": "Metrics/LineLength: Line is too long. [89/80]", "reference": "The `move_topic` action be a `post` request since it changes the state of the object." }, { "prediction": "I think this should be `new(core.BuildMetadata)` instead of `new(core.BuildMetadata)`", "reference": "Should we just return a non-nil metadata from `Test`?" }, { "prediction": "I'm not sure if this is the right place to call this method.", "reference": "Noticing this is really just the same as cart_notification_email. Would be nice to be able to view custom templates. I may update this with some set up that will make viewing specific custom emails easily." }, { "prediction": "I don't think we should remove this.", "reference": "please don't use wildcard imports" }, { "prediction": "`sourceDataReference` should be `null`", "reference": "Should we even fix this test? IMO it should be refactored to check that values are recalculated after `setSourceDataAtCell` and `setSourceDataAtRowProp` calls. This will be the correct way to alter the data since now and we're not testing this use case." }, { "prediction": "I'm not sure if we should remove this line.", "reference": "I'm not sure if this is standard practice, but I would prefer to leave this initialization here, if only to show that such a variable exists in this file (instead of inferring it from the globals). It can also cause weird issues if, for example, `init` isn't run before other methods." }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if this is the right thing to do.", "reference": "This isn't how you throw an exception in C++. I'd suggest you take a look elsewhere in the RDKit C++ codebase and see how ValueError exceptions are thrown. Hint: there's a function called `throw_value_error()` that you may find useful." }, { "prediction": "I'm not sure about this change, but I think it would be better to move the block_get into the block_work() function.", "reference": "Was changing this to a write transaction required?" }, { "prediction": "The must all be individually abi encodable. The must all be individually abi encodable. The must all be individually abi encodable.", "reference": "nit: I think \"They\"?" }, { "prediction": "I don't think this is needed.", "reference": "is it a result of some multiplication or some other meaningful number? would be nice to display as a power of something or the mult" }, { "prediction": "I'm not sure if this is the right place for this feature. I'm not sure if it's the right place for this feature, but if it's the right place for this feature, I'm not sure if it's the right place for this feature.", "reference": "I think this class is a good example of where Payload could significantly improve things. I'm okay with this class as it stands. If you merge this in, I'd like to have a go at refactoring it after introducing Payload." }, { "prediction": "I don't think this is needed.", "reference": "Just a small tip: I think you don't need to include pytest here. You can run tests using: - `pytest tests/path/to/my/test` under the virtualenv to run a single test. - `pytest tests/` under the virtualenv to run all the tests. - `make tests` to run all the tests for all python versions, like travis do. Hope this helps! :)" }, { "prediction": "I think this should be `name.replace(k,v)` or `name.replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v)).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v)).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(k,v).replace(", "reference": "Might be worth sorting the replacement items so this is deterministic." }, { "prediction": "I don't think this is needed.", "reference": "Should we set the default `TargetNamespace ` to `chaos-testing`? I noticed that the installation script defaults to chaos-testing." }, { "prediction": "I'm not sure why this was removed.", "reference": "Why was this `Task.Yield` removed? It was added in purpose." }, { "prediction": "I'm not sure if this is the right place to call `getRequiredFields` or `getRequiredFieldsList` or `getRequiredFieldsList` or `getRequiredFieldsList`", "reference": "You'll also want to do this below, for the `optionalFieldConfigs`. See `GapicMethodConfig.java:180`." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "We'd better use \"spaceId\" as variable name here. Because i can't figure out the really type for \"space\" at the first glimpse due to \"auto\" used." }, { "prediction": "I don't think we need this.", "reference": "I assume we have a package reference somewhere that pulls down the nuget package?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "But why introduce publish on `accConnsEventSubjNew` subject if we never subscribe on that subject. What is the plan then? Replace subscription on \"old\" with \"new\" at one point? Not sure about all that.." }, { "prediction": "I'm not sure if this should be NULL, but I'm not sure if this should be NULL.", "reference": "can we use `nullptr` for consistency?" }, { "prediction": "I don't think this is needed anymore.", "reference": "strange, for templating\\EngineBundle it was `\\Symfony\\Bundle\\FrameworkBundle\\`" }, { "prediction": "I'm not sure if this is the right fix. I'm not sure if this is the right fix or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug.", "reference": "But if we're on the merge deployment, and the next one is the booted deployment, we'll still be inserting between the merge and booted deployment, right? It seems like we would need e.g. `met_merge` and `met_booted` vars to keep track." }, { "prediction": "I don't think we need to do this. I think we need to check if the `role` attribute is present in the `virtualNode` and if so, we need to check if the `role` attribute is present in the `virtualNode` attribute.", "reference": "Can you put the output of this into data, and list which roles are invalid? Same thing with abstract role. I know that's not strictly part of this PR, but it'd make the messaging about this a bunch better." }, { "prediction": "I don't think this is needed anymore.", "reference": "rename ibftTwo arg to bft" }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it.", "reference": "Should we go ahead and push `agent_is_crawler?` into the `skip_session_tracking?` method?" }, { "prediction": "I don't think we need to upgrade mmcv to 1.3.16?", "reference": "How about we raise a warning here and simply change to use self.data_infos = self.load_annotations(self.ann_file)" }, { "prediction": "I don't think this file is needed anymore.", "reference": "Please remove this line to comply with the standard for copyright headers." }, { "prediction": "I don't think we need twoThirds here.", "reference": "seems incorrect - for 5 validators it will tell that 3 is enough to seal and you need 4 2/3 * 5 is 3.3" }, { "prediction": "I don't think this is needed.", "reference": "Nit: please remove unnecessary whitespace changes." }, { "prediction": "I don't think we need to change the name of the requestBody field. I think we should change the name of the requestBody field to something more descriptive.", "reference": "Is this captured in a test?" }, { "prediction": "I don't think this is needed anymore.", "reference": "This is used in o.a.l.sandbox.search.LargeNumHitsTopDocsCollector." }, { "prediction": "I don't think this is needed.", "reference": "We may also do the same for `schedule_2x.py` and `schedule_20e.py`." }, { "prediction": "Line is too long. [89/80]", "reference": "Should foreign key here be something like `diary_entry_id`? Or above, in `diary_entry.rb`, it should be `diary_entry_id`?" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to have this in a separate PR. I'm not sure if it's a good idea to have it in a separate PR, but I'm not sure if it's a good idea to have it in a separate PR. If it's a good idea to have it in a separate PR, I'm not sure if it's a good idea to have it in a separate PR.", "reference": "session is a new term. Should we call more like currentCommandBatch or something else?" }, { "prediction": "I don't think we need to change this.", "reference": "Will go fmt before squash." }, { "prediction": "I think this should be `PrivilegedCapable: true`", "reference": "Setting this to `true` means that it will always get merged in. The way merging is done here is that if a value is its zero value (`false` for `bool`), the value is considered unchanged. In order for this to work, you'll need to change this to be a `*bool` type instead." }, { "prediction": "I don't think we need this anymore.", "reference": "It was decided that blockSignerAddress is not only redundant (use the miner owner public key instead which is already stored), but does not belong in config." }, { "prediction": "I don't think we need jsonschema here.", "reference": "are we not asking for trouble here by not pinning this? or does 3.* imply all of the draft versions we'd try to validate?" }, { "prediction": "I don't think this is needed anymore.", "reference": "No, we want to compare `tm_py` and `tm_cpp` in this test." }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to limit the size of the payload in bytes (100Mb). I think it's a good idea to limit the size of the payload in bytes (100Mb). I think it's better to limit the size of the payload in bytes (100Mb) to the size of the payload in bytes (100Mb). I think it's better to limit the size of the payload in bytes (100Mb) to the size of the payload in bytes (100Mb).", "reference": "Let me know if we'd rather have this as an env variable." }, { "prediction": "I don't think we need to change the name of the service account. I think we should change the name of the service account to something more descriptive.", "reference": "question: what is happening here?" }, { "prediction": "I think this test should be `AbstractSetTest emptyWithNull()`", "reference": "\\[Checkstyle\\] ERROR: 'protected' modifier out of order with the JLS suggestions\\." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Can we use EJSON from bson here? and in doing so avoid bringing in the deprecated `mongodb-extjson` lib `const { EJSON } = require('bson')`" }, { "prediction": "I don't think we need this anymore.", "reference": "So this parameter is now deprecated?" }, { "prediction": "I don't think this is needed.", "reference": "Actually, it looks like HAVE_RSEQ is only used to determine whether the rseq.h header is around, which then only determines whether the regression test is built: it does not affect whether the core handles an application using rseq. The core rseq mangling code and all the code in rseq_linux.c is always enabled. I believe the idea is that we want DR built on one machine to work on as many others as possible, rather than requiring a custom build for every variant of kernel feature or whatnot. What is the top-level problem being solved here? If it requires disabling or enabling the core handling rseq, probably a separate option should be put in place and maybe HAVE_RSEQ renamed to make it clearer what its consequences are." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "I don't see a corresponding call to freeSelectorSet... am I missing something?" }, { "prediction": "I don't think this is the right place to put this test.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I don't think we need this key anymore.", "reference": "Is this part of spec?" }, { "prediction": "(style) line over 80 characters", "reference": "Hmm, do we need to do this for Windows too? It won't have this private loader TLS issue but it will run DR code in a separate thread before DR init is fully done which I think violates some assumptions. For Windows we would move this wait from win32/os.c to win32/callback.s intercept_new_thread where it checks whether it's a client thread right before calling dynamo_thread_init. If you do not want to deal with Windows you could bail on my suggestion and leave the issue open (or maybe file a new issue) for Windows, or if you want to put the suggested core/win32/ change in place and your new test passes on Appveyor we could then claim to have fully solved this related issue too for all platforms." }, { "prediction": "I don't think this is needed.", "reference": "We can remove this function and use `lambda_function_name(..)` in this file instead." }, { "prediction": "I don't think we need to change the name of this function.", "reference": "nitpick: `ApplicationVersion` could be `AppVersion`. It's smaller but gives the same understanding for purposes of the field." }, { "prediction": "I think this should be `if resp == nil && err == nil { return &workflowservice.PollWorkflowTaskQueueResponse{}, nil`", "reference": "nit: maybe prefer `resp = &workflowservice.PollWorkflowTaskQueueResponse{}` over adding another function exit points especially for non-error cases?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "Do we specifically need to keep the read preference as a symbol for use elsewhere? If not, I think it would be cleaner to just modify the options before caching them in the `client_options` method so that we don't do this check every time. If we do need it a a symbol elsewhere, I'd suggest either putting `return @client if @client` at the top of the method (and changing the assignment below from `||=` to `=`) or moving this within the parenthetical block in the last assignment so that we don't repeat this work." }, { "prediction": "I don't think we need to set preferredMimeType here.", "reference": "Since this is for video only, should it be called `preferredVideoMimeType`? If we add it for pictures later, it will likely need to be a different option." }, { "prediction": "I don't think this is needed.", "reference": "That doesn't make sense. LayoutEntry doesn't match the generator concept." }, { "prediction": "I don't think we need to change this test.", "reference": "I think the customer visible strings should be \"Service\" instead of \"Svc\" to make it obvious to them" }, { "prediction": "I think this test should not be run as a user.", "reference": "Explain why this property is necessary?" }, { "prediction": "I don't think this is needed.", "reference": "It should accept executions as the input" }, { "prediction": "I don't think we need this test. I think it's better to use `assert batch_size == 1` instead of `assert batch_size == 1`", "reference": "Is this limitation necessary?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to rename it to `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned` or `selfSigned`", "reference": ":question: Should there be validation to ensure that only one of these attributes is used?" }, { "prediction": "I don't think we need to use Interop\\Container\\ContainerInterface.", "reference": "I would recommend using Psr\\Container\\ContainerInterface here instead of Interop\\Container\\ContainerInterface; both currently work, but the Interop version is deprecated and will eventually be removed, so using the Psr version will save us time in the future." }, { "prediction": "I think this test should be `/var/www/html/docroot` instead of `/var/www/html/docroot`", "reference": "This would also change back to /var/www/html/docroot if we go that way." }, { "prediction": "I don't think this is needed anymore.", "reference": "Does this need to be public? Can't one of the helper functions below pass the data? If it really needs to be public, could it be write-protected?" }, { "prediction": "why remove this?", "reference": "Thanks. Now that you've improved this we should just init and expose the StorageAPI on the node, like the other.s" }, { "prediction": "I don't think this is needed.", "reference": "it will be better if you can provide some examples" }, { "prediction": "I don't think this is needed.", "reference": "\"return type\" and \"response type\" have never really been contrasted before, and it's unclear what their meaning is here. Could you clarify?" }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to use `import json` in the `libcodechecker.log` file.", "reference": "Import order has been violated here." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Are you suggesting deleting the concept of message querying from plumbing (sounds like more trouble than its worth) or suggesting deleting the snapshot based implementation?" }, { "prediction": "I think this should be `--labels` or `--labels`", "reference": "I recommend using StringSliceVarP to resolve the label flag, like `-l key1=value1,key2=value2`. What do you think?" }, { "prediction": "I think this should be `$this->allTabs->primary->icons = $icons;`", "reference": "@Samuell1 Will assigning the same icons array to all the tabs result in, for example, a primary tab called \"Colours\" and secondary tab called \"Colours\" having the same icon?" }, { "prediction": "I'm not sure if this is the right place to call this function.", "reference": "A docstring for this function please." }, { "prediction": "I don't think we need to add this feature to the `Kestrel.Core.Internal` namespace.", "reference": "heads up @JunTaoLuo" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": ".GetMethod() cannot return null now, correct?" }, { "prediction": "I don't think we need volume_up anymore.", "reference": "Same thing here, I think the proper fix is elsewhere." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "errno is a global variable that might be set by any system library call. It is dangerous to rely on it except right after the system call where it is set. But in this code, it looks like the library call is buried inside ExpLOBInterfaceSelectCursor. It would be safer if the latter function saved errno after whatever system library call it calls, and returns that as an \"out\" parameter, which this code could then check." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for this, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, then it's the right place for it.", "reference": "`hasattr` is kinda terrible; just append extra info in the subclass." }, { "prediction": "I think this should be `True` or `False`.", "reference": "Fair warning, the way that exception block is written won't work in python3 Python 3.2.3 (default, Jun 8 2012, 05:36:09) [GCC 4.7.0 20120507 (Red Hat 4.7.0-5)] on linux2 Type \"help\", \"copyright\", \"credits\" or \"license\" for more information. > > > try: > > >... raise ValueError(\"foo\") > > >... except ValueError,e: > > > File \"\", line 3 > > > except ValueError, e: > > > ^ > > > SyntaxError: invalid syntax" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this.", "reference": "This only updates the metadata and not the actual thing you are trying to solve for the docker hypervisor." }, { "prediction": "I don't think this package is needed.", "reference": "should this package be internal? don't we want to use it e.g. in go-contrib?" }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if this is the right thing to do. I'm not sure if this is the right thing to do, but if it's the right thing to do, I'm not sure if it's the right thing to do, but if it's the right thing to do, I'm not sure if it's the right thing to do, but if it's the right thing to do, it's the right thing to do.", "reference": "Just curious, why did you make this change?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it.", "reference": "Can you handle error cases such as `pd.get_dummies(pdf, prefix={\"A\": \"foo\"})`?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "Where is this environment variable being set?" }, { "prediction": "`module must be a child of nn.Module, but got {module_class}`", "reference": "`module_class ` is already a class and `type(module_class)` always returns ``" }, { "prediction": "I don't think we need to do this. I think we should do this in a separate PR. I don't think we need to do this in a separate PR.", "reference": "Nit: The lambda can be replaced with a method reference: `SparkOrcWriter::new` I think." }, { "prediction": "I don't think this is needed. I think it's better to use `is_int(obj, int_like=False)` instead of `is_int(obj, int_like=False)` and then use `is_int(obj, int_like=False)` instead of `is_int(obj, int_like=False)`", "reference": "It would be nice to have a docstring that says what range of integer-like objects will be accepted, as well as what the int_like argument is meant for." }, { "prediction": "I think this should be `:licenses` instead of `:licenses`", "reference": "How do we manage updates to this view down the road?" }, { "prediction": "I don't think this is needed.", "reference": "We can revert this to reduce the diff of the PR." }, { "prediction": "I'm not sure if this is the expected behavior.", "reference": "I think we should refactor or drop this test, as it is not testing the points format now, but IndexingChain/FieldsInfos' logic. Maybe we could rename the test `testMergeMissing` and configure the first segment to not have the `id` field at all." }, { "prediction": "I'm not sure why this was removed.", "reference": "not sure I follow why all this goes away?" }, { "prediction": "I'm not sure if this is the right place for this test. I'm not sure if it's the right place for this test, but if it's the right place for this test, I'm not sure if it's the right place for this test.", "reference": "Is this `{clipboard}` or `{primary}`, as the deprecation message for `:paste-primary` says?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "Human unreadable. IMHO user should input MYST value: 0.0006 @chompomonim, opinions?" }, { "prediction": "I'm not sure why this was removed.", "reference": "May be you could elaborate on why you removed this? I see some of this logic has been moved to ia2Web, but couldn't there be cases outside ia2Web (i.e. UIA) in which case ROLE_TABLEROW and ROLE_TABLECOLUMN are mapped to objects, in which case these objects will be of presentation type content erroneously?" }, { "prediction": "I'm not sure about this change, but I think it would be better to move this line into the `if (g_events->eventPlayerOnTradeAccept(player, tradePartner, playerTradeItem, tradePartnerItem)) { internalCloseTrade(player); return; }` block.", "reference": "This is not consistent. Either rename the first to `tradePlayerItem` (which is ugly) or the second to `partnerTradeItem` (:+1:)" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for this, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, I'm not sure if it's the right place for it.", "reference": "is there a reason we don't want to gx this dependency?" }, { "prediction": "I don't think this is needed.", "reference": "I'd suggest to add \"ATI \" and \"Intel(R) \" to this list" }, { "prediction": "I don't think we need to change this line.", "reference": "This is using a different lang key, we should switch it to using the new key and remove the old key if it is no longer used." }, { "prediction": "I'm not sure if this is the right thing to do here. I'm not sure if this is the right thing to do, but if it's the right thing to do, I'm not sure if it's the right thing to do.", "reference": "shouldn't this work? nodesRegex = regexp.MustCompile(api.SpecNodes + \"=(('[0-9A-Za-z,_-]+')|([0-9A-Za-z_-]+)),?\")" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do it.", "reference": "You mentioned this change was prompted because the `before_create` action was actually a defect. This will be done only for a new record; why is `before_validation`, which will be called repeatedly as accounts get updated and saved, correct whereas `before_create` is not? It looks like one would want to assign and activation code, etc., only once." }, { "prediction": "I don't think we need to register this rule. I don't think we need to register it.", "reference": "What's the rationale for a default setting to not use a GlobalSamplingRate of 1? I don't know much about the sampling rate stuff" }, { "prediction": "I'm not sure if this is the right place to use it. I'm not sure if it's the right place to use it, but if it's the right place to use it, I'm not sure if it's the right place to use it or if it's the right place to use it or if it's the right place to use it or if it's the right place to use it.", "reference": "Don't we know if it's 64 by this point? Do we have to test for the directory on every call, or can't we just split the value based on the platform?" }, { "prediction": "I don't think this is needed.", "reference": "It's not async" }, { "prediction": "I don't think we need to change this. I think we need to change the name of the exporter to something more descriptive. I don't think we need to change the name of the exporter.", "reference": "Maybe we could add some use of `exporterOptions` in this example, otherwise the proper code would replace this variable name with an underscore?" }, { "prediction": "I don't think this is needed.", "reference": "Maybe would be better to rename it to \"onEveryKey\" or \"fireOnEveryKey\"." }, { "prediction": "I don't think this is needed anymore.", "reference": "if we're switching to calling FileDownloadHelper, we can just call that directly from the xhtml (see line 357 for example) and then remove this method completely. This is because the other thing it does is check PrivateURLUser, but the FileDownloadHelper method already does that. (and while we're at it, we can remove the method from FileUtil as this is the only place that method is called)" }, { "prediction": "I'm not sure if this is the right place to remove the method config.", "reference": "is `fullName` still required as a parameter?" }, { "prediction": "I think this should be `LOG.info(\"Bound legacy RC support\")`", "reference": "This informational message is important to users. Please leave." }, { "prediction": "I don't think we need this anymore.", "reference": "Why do we want to remove this one? Are we planning to substitute it?" }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "We may create an issue to track this so we don't forget?" }, { "prediction": "I'm not sure if this is the right place for this helper, but I'm not sure if it's the right place for this helper.", "reference": "This file has the executable bit set." }, { "prediction": "I think this should be `db.logger.Info(\"setting db capacity to :\", db.capacity)`", "reference": "Improve the formatting of the message `.Infof(\"setting db capacity to: %v\", db.capacity)` There is a space before `:` and this way it is easier to see the formatting." }, { "prediction": "I think this should be `std::unique_lock lock(RTPSDomain::m_mutex);`", "reference": "This lock cannot be released here, as it is protecting m_RTPSParticipants and the participant reference." }, { "prediction": "I don't think this is needed.", "reference": "we'll need this in `_findAndModify` too" }, { "prediction": "I don't think this is the right place to do this.", "reference": "This is the fix for the crash. The function to create the intent to launch this activity requires `dbName`, so it has to be set to `null`. In such cases, the value for `dbName` will be set to `null` and cause issues throughout this activity. This adds a default value if the explicitly assigned value in `null`." }, { "prediction": "I think this should be `event_textChange` instead of `event_textChange`.", "reference": "Shouldn't we also trigger vision update here, so that if someone has caret highlighting enabled the correct character is highlighted?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Woah, how does this change, which includes semicolons, result in the baseline change? Are the semicolon chars just part of the internal representation of the import type?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Can't you just use runnvda.bat here?" }, { "prediction": "I'm not sure why this was removed.", "reference": "these definitions of UNUSED aren't the same as the one you imported, so callers should be fixed (if any)" }, { "prediction": "I don't think we need to add this to the `IPAMNetworkConfig` struct.", "reference": "is type a free string too?" }, { "prediction": "I don't think we need to pass `model_func` here.", "reference": "here input could be a normal function or an instance of torch.nn.Module." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "Example output: \"19.03.git.a7f4a860d0c\" At some point `nixpkgsVersion` was renamed to `version` since someone may use an old channel we fallback to `nixpkgsVersion` for backwards compatibility." }, { "prediction": "I'm not sure if this is needed anymore.", "reference": "Class import is therefore redundant I guess :)" }, { "prediction": "I think this should be `errorNodeCreationIPFailure = \"Parsing passed IP %v failed: need a valid IPv4 or IPv6 address with a specified port number. Acting as though IP was not supplied.\"", "reference": "If parsing fails, don't act as no IP specified. Error out." }, { "prediction": "I don't think we need this enum anymore.", "reference": "... here the semicolon wanted to run away from the enum ;)" }, { "prediction": "I don't think we need to add secondary config here.", "reference": "Note that this is in the context of SolrCloud, so \"secondary\" doesn't apply and should be instead follower" }, { "prediction": "Align the elements of a hash literal if they span more than one line.", "reference": "This one is a query parameter and probably really should be ID and in fact I'm mystified as to how this is working because the controller code definitely wants a number for that parameter so the test framework must be converting it back to an ID as best I can tell." }, { "prediction": "I think we should move this line to `FileScan::preCodeGen(Generator * generator, TRUE);`", "reference": "Need to ensure this is set to TRU for LOB datatype access too not just for hive." }, { "prediction": "I don't think we need to pass the stats function to the stats function. I think we should pass the stats function to the stats function instead of passing it to the stats function.", "reference": "You're using the Sphinx docstring style here (maybe because it's the default in PyCharm?). Instead, you should use the NumPy style (that you've also used in other places) to be more consistent with the rest of the project." }, { "prediction": "I don't think this is the right place to start localhost. I'm not sure if this is the right place to start localhost, but if it's the right place to start localhost, then it's the right place to start localhost. I'm not sure if it's the right place to start localhost, but if it's the right place to start localhost, then it's the right place to start localhost. I'm not sure if it's the right place to start localhost, but if it's the right place to start localhost, then it's the right place to start localhost. If it's the right place to start localhost, then it's the right place to start localhost. If it's the right place to start localhost, then it's the right place to start localhost. If it's the right place to start localhost, then it's the right place to start localhost. If it's the right place to start localhost, then it's the right place to start localhost. If it's the right place to start localhost, then it's the right place", "reference": "Don't really need this since the rest of the method will no-op but it's also safe to return early." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "Don't use relative paths. src directory is already on the include search path" }, { "prediction": "I don't think we need this file anymore.", "reference": "this file can be removed" }, { "prediction": "I don't think this is needed anymore.", "reference": "Do we have test cases that name is null?" }, { "prediction": "I think this should be `if vs.Len() > 0 { a.sum += math.Int64.Sum(vs) } else { if vs.IsValid(i) { a.sum += vs.Value(i) } }`", "reference": "in a separate PR, I'll check for a table that is empty/all-null and skip this function call completely." }, { "prediction": "I don't think this is the right place to catch the `ConfigurationException` exception.", "reference": "We really, really want to catch _everything_ here. It is safe to leave `azkabanEventReporter` set to null." }, { "prediction": "I think this should be `if (parentDom.lastChild!==newDom) { parentDom.appendChild(newDom); } else { parentDom.appendChild(newDom); }`", "reference": "Can't we add the check here?" }, { "prediction": "I don't think we need to raise an exception here.", "reference": "body is being used here for the first time without every being populated. This will error. To run tests do `./go clean test_py` and that will run the Firefox tests" }, { "prediction": "I don't think this is needed.", "reference": "Tell me if you have a better field name for this." }, { "prediction": "I don't think we need this anymore.", "reference": "FYI, I have a branch I started to improve this. Nuke can read the target frameworks from the project files, so we don't have to do this mess. Ran into some other issues so it didn't take priority" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "This is just `mol->atomNeightors()`, is it?" }, { "prediction": "I think it's better to use `task::clustering` instead of `task::clustering`", "reference": "This alias is just for a single occurrence. Maybe it ins't necessary?" }, { "prediction": "I don't think this is needed anymore.", "reference": "You can delete this `NONE` case." }, { "prediction": "I'm not sure if this is a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug.", "reference": "@cnorthrop -- here is a test with a name change. Is this going to affect your internal CI?" }, { "prediction": "I think this should be `SEND_COMMANDS_FOR_DOWNLOAD_CHROME_HEAD_LESS` instead of `SEND_COMMANDS_FOR_DOWNLOAD_CHROME_HEAD_LESS`", "reference": "Nit: `Headless` is one word, not two, and so doesn't need camelcasing in this way." }, { "prediction": "I think this should be `parallel_scheduling_processes`", "reference": "I think this will cause a warning, can you set the default to zero (`0`)?" }, { "prediction": "I don't think we need to change this.", "reference": "confusing naming. Identity from \"id\" package :/ why we need alias here? (and in other imports)" }, { "prediction": "I don't think we should change this to `None_ok=True`", "reference": "It'd be nice to fix up existing configs with the change - that'd mean adding the option to `RENAMED_OPTIONS` in `config.py` and adding something like `_get_value_transformer({'true': '', 'false': '*'})` to `CHANGED_OPTIONS`. I think I never tried adding an option to both, but it should work." }, { "prediction": "I don't think we need to change this line.", "reference": "Perhaps use the new `.keys()` method here instead?" }, { "prediction": "I'm not sure if this is the right change. I'm not sure if it's the right change, but I'm not sure if it's the right change.", "reference": "We don't need this option because plan-preview is comparing between 2 commits, not using the live state." }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "I'm not sure about putting this in the options. I would see it living in an object and then being queried on through a class - a more object oriented, ruby solution." }, { "prediction": "I'm not sure if this is the right thing to do here. I'm not sure if it's the right thing to do here.", "reference": "So `Status` returns metrics?" }, { "prediction": "Metrics/LineLength: Line is too long. [89/80]", "reference": "Can we make a generic method say, `set_infographic_view` and in that method we can check the 4 values (outside_committers, portfolio_projects, outside_projects, affiliated_committers) and check against params[:action] and params[:view] and then trigger the respective method dynamically as it takes the standard argument(s) for all the four methods. What do you think?" }, { "prediction": "I don't think we need to check for null here. I think we should check if o is null or not.", "reference": "Why would this be called to copy a non-Date object?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This alignment issue had not appear because no multiple `Boolmsg`s had been serialized at once." }, { "prediction": "I think this should be `OptionalTrue`", "reference": "Why are we not implementing a BooleanDefaultFalse struct and replacing all of these config vars that default to false with that? Are \"default false\" config vars not affected by this bug?" }, { "prediction": "I'm not sure if this is the right place to set the access_level. I'm not sure if this is the right place to set the access_level or if it's the right place to set the access_level. I'm not sure if it's the right place to set the access_level or if it's the right place to set the access_level. I'm not sure if it's the right place to set the access_level or if it's the right place to set the access_level.", "reference": "Replaced this method with a ruby idiomatic setter." }, { "prediction": "This program is free software, you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation.", "reference": "wrong place hehe" }, { "prediction": "I don't think we need to do this. I'm not sure if this is the right place to do this.", "reference": "Can this be `test -e /var/run/mysqld/mysqld.sock` instead of `ls`? Using `ls` for noninteractive stuff is a recipe for sadness, IMHO. /cc @tianon" }, { "prediction": "Line is too long. [89/80]
    Line is too long. [89/80]
    Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Metrics/LineLength: Line is too long. [91/80]
    Metrics/LineLength: Line is too long. [91/80]
    Metrics/LineLength: Line is too long. [91/80]
    Metrics/LineLength: Line is too long. [91/80]
    Metrics/LineLength: Line is too long. [91/80]
    Metrics/LineLength: Line is too long. [91/80]
    Metrics/LineLength: Line is too long. [91/80]
    Metrics/LineLength: Line is too long. [91/80]
    Metrics/LineLength: Line is too long. [91/80]
    Metrics/LineLength: Line is too long.", "reference": "Are these `dependent: destroy` attributes intended to implement cascading deletes? I had assumed they were added because of the `paranoia` gem, but since that is no longer part of this PR, are they here as a best practice?" }, { "prediction": "I think this should be `if (stream->tunnel!= NULL && tunnel->destroy(tunnel))`", "reference": "This approach would work only if there's a guarantee that the stream does not get freed before `establish_tunnel` is called, even though it _may_ enter CLOSE_WAIT state (at which point `stream->tunnel` is set to NULL). I do not think that assumption holds. Hence the alternate approach." }, { "prediction": "I'm not sure if this is a good idea. I think it's a good idea to have the `enable` and `enable_or_disable` parameters in the `toml.put` call.", "reference": "Did you mean to remove the periods here while newly adding to other locations?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "the check can now be `if newLen < 0`" }, { "prediction": "I'm not sure if this is the right place to remove it.", "reference": "If we're going to clean up this package, can we also remove those two `_` imports that appear to serve no purpose? (FWIW, they're also in the manager package too...)" }, { "prediction": "I think this should be `static std::unique_ptr ds_instance(new MMFFAromCollection(nullptr));`", "reference": "Won't this leak like a sieve? The caller can't delete this as one is a unique_ptr and one is not." }, { "prediction": "I don't think we need to delete the version form _attachments.", "reference": "form => from" }, { "prediction": "I don't think this is needed anymore.", "reference": "Ok, we can't switch it now, because the properties are a field of the interface Rule - which makes it public API. Maybe we should remove it here in the (Java) API in 7.0.0? The only API left would be, when using a rule and setting the properties in the ruleset xml. There the type doesn't matter - since the String is then automatically converted into a Pattern." }, { "prediction": "I'm not sure if we should change this test to use `google.example.myproto.v1`?", "reference": "Pass in null here, instead of a value? Maaaaybe we should add an overload for `GapicProductConfig.create` that matches the original signature and passes through null? I don't feel strongly about that though, so happy to leave asis if you prefer." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Include all compounds parts from the very beginning for the case check to work later" }, { "prediction": "I think this should be `\"unix://\"`", "reference": "if the user specifies a url scheme on the cli this is going to cause problems, no?" }, { "prediction": "I'm not sure if this is the right fix.", "reference": "How about that `scaleFactor`?" }, { "prediction": "I think this should be `return Type::getInt(false, $result);`", "reference": "`assert(is_int($result));` would be preferable I think, even if we know it can't ever be false" }, { "prediction": "I think we should remove the `$item->getId()` from the `$this->items` array.", "reference": "I'm unfortunately unable to review whether you've changed everything that used to use cartIds" }, { "prediction": "I don't think this is needed anymore.", "reference": "Please don't touch unrelated files to keep the git history clean" }, { "prediction": "I don't think this is needed.", "reference": "Per our style guide, I don't think we indent `private` keyword. Would you mind fixing that?" }, { "prediction": "I don't think we need this anymore.", "reference": "Will this change the input `heatmap`? Is this behavior expected or not?" }, { "prediction": "I'm not sure if this is the right place for this package. I'm not sure if it's the right place for this package, but if it's the right place for this package, I'm not sure if it's the right place for this package.", "reference": "If I'm reading this right, this changes the parameter name so it'd constitute a breaking change :cold_sweat: Are we missing a test that should have been failing up until now?" }, { "prediction": "I don't think we need to remove this file.", "reference": "Need copyright/license info." }, { "prediction": "I'm not sure why this was removed.", "reference": "Is this `info log` necessary? If it is not useful, can you consider deleting it?" }, { "prediction": "I'm not sure if this is the right place to start with RCLONE_ENCRYPT_V1 instead of V0. I'm not sure if this is the right place to start with RCLONE_ENCRYPT_V1 or if it's the right place to start with RCLONE_ENCRYPT_V1", "reference": "Unrelated change, but seems to be the correct purpose of the test." }, { "prediction": "I don't think this is the right place for this.", "reference": "Should it be `'uppy-input-`?" }, { "prediction": "I think this should be `const trmul_fun tr_mul = linalg.tr_mul; tr_mul(&(ij_bond->H.m[1][0]),&(ik_bond->H.m[1][0]),&(triptr->H1xH2.m[1][0]));`", "reference": "what's the reasoning to keep these always true or dead-code blocks?" }, { "prediction": "I don't think this is needed.", "reference": "It would be a good practice to do `.off('click', '.tab-buttons > div').on('click', '.tab-buttons > div', function() {`" }, { "prediction": "I'm not sure if this should be enabled or disabled. I'm not sure if it's a good idea.", "reference": "I suggest that we rely on `--controllers='*,gateway-shim'` for now, and we can then move from `--controllers='*,gateway-shim'` to automatically enabling the Gateway API support on startup using the discovery API in 1.6 or 1.7, what do you think? Note that the logic I wrote in e5436df521015057e77de3fe02c174ea8a863b93 should also use this `GatewaySolverEnabled` flag I think." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I moved the instantiation of the signature algorithm here, to execute it before the native libraries are configured. Otherwise the wrong signature algorithm could be configured in a future release when more than one is supported in Besu." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `PyLinter` or `PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.PyLinter.Pyinter.Pyinter.Pyinter.Pyinter.Pyinter.Pyinter.Pyinter.Pyinter.Pyinter.Pyinter.Pyinter.Pyinter.Pyinter.Pyinter.Pyinter.Pyinter.Pyinter.Pyinter.Pyinter.Pyinter.Pyinter", "reference": "Why remove this?" }, { "prediction": "I don't think this is needed.", "reference": "`this.ieService_` should be initialized to null in the constructor." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Why not `ebpf::BPF bpf;`? Assuming that the instance is not huge, I do not think there is a good reason to use a pointer when it can be retained as a value." }, { "prediction": "I don't think we need this?", "reference": "nit: move to last block" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "nit: I'm under the impression that `log` is the convention for golang, and that the `er` suffix is usually reserved for interfaces" }, { "prediction": "I don't think this is needed.", "reference": "Why is IsolationLevel fully qualified? System.Data is already in scope? What do I miss?" }, { "prediction": "I don't think we need this anymore.", "reference": "do we still need SanityCheck()? seems they all return nil now" }, { "prediction": "I'm not sure why this is removed.", "reference": "What I am missing in this PR, and I think we discussed that on the weekly meeting, is that all the code snippets that advise using `loadData` should be changed to one of the two new methods. Otherwise we send confusing mixed signals by promoting `loadData` everywhere in the guides. `loadData` is not deprecated, but is legacy." }, { "prediction": "I don't think we need this anymore.", "reference": "Line is too long. [100/80]" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I suggest \"no parent snapshot found, will read all data\\n\"." }, { "prediction": "I don't think we need this anymore.", "reference": "`LogManager.ThrowExceptions = true` has very special meaning when unit-testing. Why the change to `LogFactory.ThrowExceptions = true` and enabling after the config-load?" }, { "prediction": "I don't think we need this anymore.", "reference": "It should be return \"''\"; I will fix it" }, { "prediction": "I think this test is still failing because `m.entrySet()` returns a `Map>`", "reference": "This is wrong, should be `entry.getValue()`" }, { "prediction": "I'm not sure if this is the right place for this change, but I'm not sure if this is the right place for this change.", "reference": "nit: why can't we combine the two add operations into one so that we add `{\"nameCertificates\": []}` to `/spec/servingCerts`?" }, { "prediction": "I don't think this is needed.", "reference": "These whitespace only changes make it very difficult to review this change. Is there any way you could separate just the code changes into one PR and the whitespace only fixes into another? Or are they sufficiently merged together at this point? Chrome is having a real tough time rendering these large diffs." }, { "prediction": "I don't think this is needed.", "reference": "why does this suddenly need a config ref" }, { "prediction": "I think we can't load this up front because it's ES2015 and we need it only for certain tests that run under those conditions. We can't load it up front because it's ES2015 and we also need it only for certain tests that run under those conditions.", "reference": "Unfortunately, I couldn't find a way to get karma to conditionally load stuff from a CDN, so I had to include it." }, { "prediction": "I don't think we need to add this to the `vnl_file_vector` file.", "reference": "Those functions are not currently wrapped, so I don't think it is necessary to exclude them (at least for now)." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Nit: since this is now a private function rather than a variable, would it make sense to move it after the public functions in this file for readability?" }, { "prediction": "I don't think we need to change this.", "reference": "I'm assuming that MolDraw2Qt drops the alpha channel?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a test for `SimpleStructWithProperties` and `LargeStructWithProperties` in the `ReadJson` class. If it's a good idea to have a test for `SimpleStructWithProperties` and `LargeStructWithProperties` in the `ReadJson` class, then it's a good idea to have a test for `SimpleStructWithProperties` and `LargeStructWithProperties` in the `ReadJson` class. If it's a good idea to have a test for `SimpleStructWithProperties` and `LargeStructWithProperties` in the `ReadJson` class, then it's a good idea to have a test for `SimpleStructWithProperties` and `LargeStructWithProperties` in the `ReadJson` class. If it's a good idea to have a test for `SimpleStructWithProperties` and `LargeStructWithProperties` in the `ReadJson` class, then it's a good idea to have a test for `LargeStructWithProperties` and `LargeStruct", "reference": "the code looks good to me, but I just wonder if it is a real use case: (de)serializing a single integer." }, { "prediction": "I don't think this is needed.", "reference": "Pls remove the print statements. Also, you do not need the if statement." }, { "prediction": "I'm not sure if this is the right place to use `![CDATA[{{ value.string_value }}]]` or `![CDATA[{{ value.string_value }}]]` or `![CDATA[{{ value.string_value }}]]` or `![CDATA[{{ value.string_value }}]]` or `![CDATA[{{ value.string_value }}]]` or `![CDATA[{{ value.string_value }}]]` or `![CDATA[{{ value.string_value }}]]` or `![CDATA[{{ value.string_value }}]]`", "reference": "Thanks for this fix @eltone! Wondering if we should make this a bit more resilient to upstream changes, e.g., via a regex replacement. Not critical, though - we can pick that up in a follow-up PR.. Thanks" }, { "prediction": "I'm not sure if this is the right place to setSniff.", "reference": "Should this be instead a configurable option?" }, { "prediction": "I think this should be `if cd.SourceSnapshot!= \"\" {`", "reference": "unit test needs an update?" }, { "prediction": "I don't think this is needed anymore.", "reference": "I realised that this is not used anywhere" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "why add the default branch? this may cause there exist multiple configWatchers that notify the eventsCh at the same time?" }, { "prediction": "I don't think we need to sendZlp() here.", "reference": "This line appears to have caused the regression. What is it supposed to be doing?" }, { "prediction": "`attr_value['string'] is not None` probably not required as `attr_value['string'] == value`", "reference": "# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea, but I'm not sure if it's a good idea or if it's a good idea.", "reference": "@alanwest I noticed this while changing the code. I think we _might_ run into some race condition - if a scraper happens to hit the HTTP server before we could add the reader, what would happen (I guess we will hit exception, which turns into HTTP 500)? I haven't looked into the HTTP server logic. I think it _might_ be OKAY. A better version could be - we only start the HTTP server once the exporter/reader are fully ready and both are hooked up to the provider." }, { "prediction": "I think this should be `await SubmitRequest(aspNetCorePort, \"/shutdown\");`", "reference": "As for Owin, I think we should exclude this URL in `IsNotServerLifeCheck` too?" }, { "prediction": "I don't think we need to expose the `HttpClientFactory` to the `HttpClientFactoryExporterOptions` class.", "reference": "Does it make sense to just fold these options back into the exporter options? My thinking is that this option is unlike the processor/metric reader options in that it actually is about the exporter itself." }, { "prediction": "I don't think we need to change this.", "reference": "here is `:seconds` missing" }, { "prediction": "I don't think this is necessary.", "reference": "change of name is not needed" }, { "prediction": "I'm not sure if this is the right place to test this, but I'm not sure if it's the right place to test this.", "reference": "Hm.. so this case doesn't work anymore?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Please indent this so it lines up with the `(`" }, { "prediction": "I'm not sure if this is the right place to put this code.", "reference": "We should still register the script. Just not enqueue it." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I think this can stay as a method. And we can write our own attribute_change(name) as required." }, { "prediction": "I think this should be `ItemTemplateSelector.GetItemLayoutId(viewType)`", "reference": "@alexshikov @Cheesebaron I might be missing something but isn't the viewType parameter here the actual layout resource id? Why would the GetItemLayoutId method need to be called again? On line 127, the exact same method is called except this time passing in the index of the object in the backing data source, which makes sense - the template selector can return the layout id based on the index of the item in the list." }, { "prediction": "I don't think this is needed.", "reference": "Can you change this to use `.format()`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it?", "reference": "Maybe the parameter should be consulted higher up the stack so that we only set dropEncap if we're rendering a workload egress chain and the flag is set?" }, { "prediction": "I'm not sure if this is a good change.", "reference": "new casing is less ELiTE" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "This leaks EGL/GL implementation details into the generic renderer interface." }, { "prediction": "I don't think this is needed.", "reference": "Maybe add *key* i.e. `\"The \\\\`deploy.on\\\\` key should be a hash (dictionary).`" }, { "prediction": "I think this is a breaking change. I'm not sure if it's a good idea to change it.", "reference": "its be good also change $code na $id, actual name is misleading and that was probably actual error generator" }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to have a `lb_recent_sorted` key in the `ListenStore` class. I think it's a good idea to have a `lb_recent_sorted` key in the `ListenStore` class. I think it's better to have a `lb_recent_sorted` key in the `ListenStore` class.", "reference": "I changed the name of the key, to make deployment easier." }, { "prediction": "I'm not sure if we should do this in a follow up PR. I'm not sure if we should do this in a follow up PR. I'm not sure if we should do this in a follow up PR.", "reference": "isn't this going to be true by default? if yes, then let's have the env var named `ECS_DISABLE_SPOT_INSTANCE_DRAINING` and have default as false." }, { "prediction": "I don't think we need to import `__future__` here.", "reference": "Do you think we might need this anywhere else in HoloViews?" }, { "prediction": "I don't think this is needed.", "reference": "@MrTimscampi don't we want to remove this term entirely? Might as well do it now if that's the case." }, { "prediction": "I don't think we need multiple FILE(s) in the backend output format (e.g., HTML 5, DocBook 4.5, etc.) I don't think we need multiple FILE(s) in the backend output format (e.g., HTML 5, DocBook 4.5, etc.)", "reference": "I have followed the convention of `cp`" }, { "prediction": "I don't think this is needed anymore.", "reference": "The docs say it's `false|null`" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Thinking on it more, I actually really like your idea to rename `type` to `factor`." }, { "prediction": "I'm not sure if this is the best way to handle security exceptions. I'm not sure if this is the best way to handle security exceptions, but I'm not sure if this is the best way to handle security exceptions.", "reference": "This error message is redundant. All of this information is included in the stack trace. In general it's a good idea to avoid using method names in error messages. Chances are the method will be renamed at some point, but the string won't be updated accordingly. Then you'll end up with a very confusing error message. I suggest changing the message to: \"Failed to unblock network loads. Missing INTERNET permission?\"" }, { "prediction": "I don't think this file is needed anymore.", "reference": "Feel free to add your own name while at it." }, { "prediction": "I don't think we need this alias anymore.", "reference": "`signer` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "shouldn't this be `&& opts[:localize]` (i.e. both nil and false skip localization?)" }, { "prediction": "I don't think we need pickle here.", "reference": "This can also be removed." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Not critical but \"common\" is not that helpful in the commit title. Maybe go with \"libkvs/txn:\" for this one?" }, { "prediction": "I don't think we need this.", "reference": "It's been a while, but I just noticed this was wrong: It migrated `True` to `when-searching` (so people with `scrolling.bar = True` suddenly didn't have scrollbars anymore) and `False` to never. Instead, it should migrate `True` to `always` (no behavior change) and `False` to `when-searching` (so people notice the new feature). I fixed this in cc0f5fc6d400e12833ba729049e31d16cf836d53." }, { "prediction": "I think this should be `fs_path.decode(\"utf-8\")`", "reference": ".decode(sys.getfilesystemencoding()) will be better. Although I think rrdtool should accept bytes.." }, { "prediction": "I don't think we need this interface.", "reference": "An interface call per header might be more expensive than we want to pay. Do we really need this to be abstracted? I think a parser abstraction makes sense, but it seems to me like a separate abstraction for handling headers (one by one) might be an overkill." }, { "prediction": "I'm not sure why this is needed.", "reference": "Resharper annotations, always +1" }, { "prediction": "I don't think we need to mark hidden.", "reference": "same here, CryptoSm2 won't be changed once command is compiled" }, { "prediction": "I think we should move this to a separate PR.", "reference": "Loading the login page after the certificate has been loaded. Views can only be loaded from UI thread." }, { "prediction": "I'm not sure about this change, but I think it's a good idea to change the message to `invalid configuration` or `invalid configuration`.", "reference": "Technically it doesn't belong here; let me remove it." }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "remember to update the hash once the upstream PR is merged" }, { "prediction": "I don't think this is needed anymore.", "reference": "Sends the incoming message to the decryptor, which will then forward it to the interface once processing is complete." }, { "prediction": "I don't think this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "FYI This will go the other way, with nil being the correct value for \"no params\"" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Is this necessary? Are there duplicates in your LibKeyIndex?" }, { "prediction": "I'm not sure if this is the right place to call this method.", "reference": "Why will the gomock files be regenerated? It seems to be irrelevant" }, { "prediction": "I think this should be `make(chan *model.ReportableCommand, 1), nowFunc: time.Now, logger: logger, })`", "reference": "I'm very curious about why using buffered-channel. Is there something wrong to use an unbuffered channel with zero capacity?" }, { "prediction": "I'm not sure if this is the right place to use `RunOnceTask` or `RunOnceTask`. I think it's better to use `RunOnceTask` instead of `RunOnceTask`.", "reference": "It seems like you accidentally pulled some unrelated changes to util_test into this." }, { "prediction": "I'm not sure if this is needed.", "reference": "do not toucm NDM please - there will be lots of conflicts" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "This looks legitimate - Would cause a classCastException. But have we ever seen it in the wild?" }, { "prediction": "I think this should be `True` or `False`.", "reference": "This looks out of scope for this particular PR." }, { "prediction": "I don't think this is needed.", "reference": "Don't need () if only one." }, { "prediction": "I think this should be `private String mailHost; private String mailPort; private String mailUser; private String mailPassword; private String mailSender; private String mailSender; private String mailSender; private String mailSender; private String mailPassword; private String mailSender; private String mailSender; private String mailPassword; private String mailSender; private String mailSender; private String mailPassword; private String mailSender; private String mailSender; private String mailPassword; private String mailSender; private String mailSender; private String mailPassword; private String mailSender; private String mailSender; private String mailSender; private String mailPassword; private String mailSender; private String mailSender; private String mailSender; private String mailSender; private String mailSender; private String mailPassword; private String mailSender; private String mailSender; private String mailSender; private String mailSender; private String mailSender; private String mailSender; private String mailSender; private String mailSender; private String mailSender; private String mailSender; private String mailSender; private String mailSender; private String mailSender; private String mailSender; private String mailSender; private String mailSender; private String mailSender; private String mailSender; private String mailSender", "reference": "Why not have mailPort as int since your are already parsing while calling t.connect?" }, { "prediction": "I don't think we need to change this.", "reference": "In the future, do not remove these trailing commas as they have the purpose of making append-diffs easier to read. :)" }, { "prediction": "I don't think we need to reset the `$raw = reset($raw);` here.", "reference": "Was this added by accident? It doesn't seem related to Syndetics, and I don't think it should be necessary in core VuFind (but maybe it's related to one of your local customizations)." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to add a `AllowedForeignJWTClaims` field to the `Config` struct. If it's a good idea to add a `AllowedForeignJWTClaims` field to the `Config` struct, I'm not sure if it's a good idea to add a `AllowedForeignJWTClaims` field to the `Config` struct. If it's a good idea to add a `AllowUnauthenticatedVerifiers` field to the `Config` struct, I'm not sure if it's a good idea to add a `AllowUnauthenticatedVerifiers` field to the `Config` struct. If it's a good idea to add a `AllowUnauthenticatedVerifiers` field to the `Config` struct, I'm not sure if it's a good idea to add a `AllowUnauthenticatedVerifiers` field to the `Config` struct. If it's a good idea to add a `AllowUnauthenticatedVerifiers` field to the `Config` struct, I'm not sure if it's a good idea to add a `Allow", "reference": "i know the ergonomics are a little nicer with map[string]bool, but I prefer map[string]struct{} for sets for a few reasons: 1 - optimized storage (not very relevant here) 2 - don't have to think about the conditions where the key exists in the map or if the value could somehow be false" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This is very unclear what Server means. We need a better name, maybe ServerExtension?" }, { "prediction": "I'm not sure why this was removed.", "reference": "I wonder if we should trigger a PHP error and ensure it ends up in the log?" }, { "prediction": "I don't think this is needed.", "reference": "Hmmm not sure about this. Is it fine @ar2rsawseen?" }, { "prediction": "I think this interface should be renamed to `go()`.", "reference": "Why do you prefer `go` over `run`?" }, { "prediction": "I don't think this is needed.", "reference": "Unintentional, please remove" }, { "prediction": "I don't think we need this method anymore.", "reference": "What was the reason behind moving this?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Did you mean to put that `join` after the `map` rather than inside it? Also should it be `safe_join` or is interpolating it into an `_html` resource going to have much the same effect>" }, { "prediction": "I don't think we need this anymore.", "reference": "`Indicates if this Realm has been closed.`?" }, { "prediction": "I don't think this is needed anymore.", "reference": "how is this change adding corr to Series? Do all the methods that are added to Frame automatically get added to Series?" }, { "prediction": "I'm not sure if this is the right place to call `GetTipSetStateRoot` or `GetTipSetStateRoot`?", "reference": "Just a heads up for anyone else reviewing this, this logic and all the repetitions of it should be greatly simplified by subsequent work relating to issue #2552." }, { "prediction": "I don't think we need to do this in managed code.", "reference": "@billwert I have kept the `1000` InvocationsPerIteration, but do note this is very small for the small types." }, { "prediction": "I'm not sure if this is the right place to remove it.", "reference": "Unrelated whitespace change." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Slight formatting issue here. There should be a space after the asterisk." }, { "prediction": "I don't think this is needed anymore.", "reference": "Slight preference for declaring variables inline rather than at the top of the function. That way you can use const for both of these." }, { "prediction": "I don't think this is needed anymore.", "reference": "this is a duplicate file of the one in demo-schema. please remove this file." }, { "prediction": "I don't think this is needed.", "reference": "Nit: unified names between geth and contracts" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Necessary? Could you just use DefaultBuildState here?" }, { "prediction": "I don't think this is needed anymore.", "reference": "linked hashmap retains order" }, { "prediction": "I'm not sure if this is the correct way to do this. I'm not sure if it's the right way to do this.", "reference": "And the old names for these variables made more sense imo." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Are you sure this change is correct?" }, { "prediction": "I don't think we need to change this.", "reference": "The previously linked bug does not apply anymore? If so, this is LGTM!" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "Why are we renaming all of the tests?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Instead of having this logic, would it make sense to require *users* to encompass the specified IPv6 address within `[` and `]`? Why the magic handling here?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Why not also replace this one with calls to `GetProp`?" }, { "prediction": "I don't think we should consider strongly negative numbers as winners.", "reference": "Still need to remove trailing spaces on this line" }, { "prediction": "I don't think we need this interface.", "reference": "Please use the `@Experimental` annotation on this" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it.", "reference": "I found ~10 more instances of this typo. we can fix those in subsequent PRs." }, { "prediction": "I'm not sure if this is the right place to use metric namespace.", "reference": "How about making metricNamespace an option, and by default it's the same as `component`? e.g.m Init(component, WithMetricNamespace(\"trigger\"))" }, { "prediction": "I think this should be called `nextPageTokenName` instead of `nextPageTokenName`.", "reference": "Just checking: no need for case manipulation?" }, { "prediction": "I'm not sure if this is the right place for this change. I think it's better to move this method to `GrpcMetadataGeneratorTool` class. I think it's better to move this method to `GrpcMetadataGeneratorTool` class. I think it's better to move this method to `GrpcMetadataGeneratorTool` class.", "reference": "Same as above, not that descriptive" }, { "prediction": "I'm not sure if this is the right fix. I'm not sure if this is the right fix or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug.", "reference": "> i#4670 signl-interrupted special ibl xfer frag: Unlink if signal pending nit: This looks like one of many commits with the text before the colon. nit: On the long side: 56 or 60 chars is what some views show Spelling error." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea, but I'm not sure if it's a good idea.", "reference": "Should we need to invoke pthread_cancel?" }, { "prediction": "I think this should be `System.getProperty(ZMSConsts.ZMS_PROP_USER_DOMAIN, ZMSConsts.USER_DOMAIN)`", "reference": "this is auto generated file so no changes are allowed here" }, { "prediction": "I don't think this is needed.", "reference": "All buttons are submit buttons, except if they are `type=reset` or `type=button`. I suggest you do an exclude of those, rather than only include `button[type=submit]`." }, { "prediction": "I'm not sure if we should change this to `5.20` or `5.20` or `5.20` or `5.20` or `5.20` or `5.20` or `5.20` or `5.20` or `5.20` or `5.20` or `5.20` or `5.20` or `5.20` or `5.20` or `5.20` or `5.20` or `5.20` or `5.20` or `5.20` or `5.20` or `5.20` or `5.20`", "reference": "can you please make this multi line, this version is hard to read." }, { "prediction": "I don't think we need this.", "reference": "For consistency, it's best to either always use strict equality (`===`) or loose equality (`==`) in `typeof` checks, and to not mix them." }, { "prediction": "Line is too long. [89/80]", "reference": "Work Orders would never have only one approver, right?" }, { "prediction": "I think we should move this enum to `java.lang.Enum` to `java.lang.Enum` and use it in `java.lang.Enum`.", "reference": "`code` is written to the message as a `byte`, so I think it's better to declare it in the enum as `byte` as well to avoid a narrowing primitive conversion from `int` to `byte` in runtime." }, { "prediction": "I don't think we need this.", "reference": "This is the only \"extra\" change here." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "Please TODO and link to an issue for changing this." }, { "prediction": "I think this should be `'Failed to add %{smart_count} files due to internal errors'` or `'Failed to add %{smart_count} files due to internal errors'`", "reference": "Can we make the script output trailing commas?" }, { "prediction": "I don't think we need this flag.", "reference": "This file should get a file header" }, { "prediction": "I don't think this is needed anymore.", "reference": "maybe we need process the os error more safely and friendly when open file failed, because this error is very common when cpu has a high pressure, crash directly is danger." }, { "prediction": "I don't think we need cryptoSm2 here. I don't think we need cryptoSm2 here.", "reference": "we need to pay attention not to use this flag everywhere." }, { "prediction": "I'm not sure why this was removed.", "reference": "curious about this change, since it is not mentioned in the commit message and now we have `uint8` all over the place" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "wait, are we not mising `WithStamp` here?" }, { "prediction": "I'm not sure if this is the right place to call `GetStageProgress` or `GetStageProgress` or `GetStageProgress` or `GetStageProgress` or `GetStageProgress` or `GetStageProgress` or `GetStageProgress` or `GetStageProgress` or `GetStageProgress` or `GetStageProgress` or `GetStageProgress` or `GetStageProgress` or `GetStageProgress` or `GetStageProgress` or `GetStageProgress` or `GetStageProgress` or `GetStageProgress` or `GetStageProgress` or `GetStageProgress` or `GetStageProgress` or `GetStageProgress` or `GetStageProgress` or `GetStageProgress` or `GetStageProgress` or `GetStageProgress`", "reference": "oh. didn't know we store this stage progress." }, { "prediction": "I don't think this is needed.", "reference": "Going with definition from here: > Does Unicode have private-use characters? > A: Yes. There are three ranges of private-use characters in the standard. The main range in the BMP is U+E000..U+F8FF, containing 6,400 private-use characters. That range is often referred to as the Private Use Area (PUA). But there are also two large ranges of supplementary private-use characters, consisting of most of the code points on Planes 15 and 16: U+F0000..U+FFFFD and U+100000..U+10FFFD. Together those ranges allocate another 131,068 private-use characters. Altogether, then, there are 137,468 private-use characters in Unicode. It looks like we are only ignoring ones in BMP and not the supplementary private-use characters. Shouldn't we consider the supplementary ones too?" }, { "prediction": "I don't think this is needed.", "reference": "This change is un-tested and requires testing" }, { "prediction": "I don't think we need to use the jupyter_bokeh ipywidget model. I think we should use the jupyter_bokeh ipywidget model instead.", "reference": "Should the docstring mention the vscode option?" }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "ISTM that since `artman` know the \"real\" value of the GAPIC config name, it should pass that value to toolkit, rather than toolkit guessing the name based on a heuristic. Then again, I don't know what this value actually does for Java codegen..." }, { "prediction": "I don't think this is needed.", "reference": "Please back out the import changes in files you haven't touched. I think these happen if you run goimports without having the vendor directory populated" }, { "prediction": "I think this should be `WriteAsync` instead of `FlushAsync`.", "reference": "Should this be `ISocketOutput where T : struct`?" }, { "prediction": "I don't think we need this interface. I think we should make this interface public and add a `@private Snapshot snapshot = Snapshot.createSnapshot(snapshotName, sequenceNumber, manifestListLocation, manifestListLocation, manifestListLocation, snapshotName, snapshotName, snapshotName, snapshotName, snapshotName, snapshotName, snapshotName, snapshotName, snapshotName, snapshotName, snapshotName, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatus, snapshotStatusSnapshotStatusSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshotSnapshot", "reference": "In which case will this actually return 0? If there is no snapshot, then there is no `Snapshot` object, right?" }, { "prediction": "`CLASSES` should be a tuple of str, not a tuple of tuple of str.", "reference": "This part of code is valuable and necessary. Can we move it to another place for a more clear logic and only check it once? For example, move it to line 133 before delving into each module." }, { "prediction": "I don't think we need this anymore.", "reference": "Are we at all worried that changing pins will cause release hiccups? I think we've decided that relaxing pins should be safe but adding pins has caused us build issues in the past - so I think we're fine?" }, { "prediction": "I don't think this is needed.", "reference": "could you please explain a bit where these numbers come from? for example: why is there no `swarm.EncryptedSectionSize`?" }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do here.", "reference": "s/object content/blob object/ (for consistency with the `Size` docs)" }, { "prediction": "I'm not sure about this, but I think it's better to remove the `junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-jupiter:junit-", "reference": "Rather than deleting this entirely, could we just emit it as a `warn` or `info` log line?" }, { "prediction": "I'm not sure if this is the right place to use `cfg.CA` or `cfg.CA`?", "reference": "Is there a chance of this being a BC break of somekind? I.e. what if an old instance of Caddy is running in a cluster with a newer one?" }, { "prediction": "I don't think this is needed.", "reference": "Thanks for this... is this the only place where the rollback is needed? Are there others?" }, { "prediction": "I think this test should be `testRoundTrip(t, &blk.Block{Type: crypto.SigTypeSecp256k1, Data: []byte{}}, BLSAggregateSig: crypto.Signature{Type: crypto.SigTypeBLS, Data: []byte{}}, BLSAggregateSig: crypto.Signature{Type: crypto.SigTypeBLS, Data: []byte{}}, BLSAggregateSig: crypto.Signature{Type: crypto.SigTypeBLS, Data: []byte{}}, BLSAggregateSig: crypto.Signature{Type: crypto.SigTypeBLS, Data: []byte{}}, BLSAggregateSig: crypto.Signature{Type: crypto.SigTypeBLS, Data: []byte{}}, BLSAggregateSig: crypto.Signature{Type: crypto.SigTypeBLS, Data: []byte{}}, BLSAggregateSig: crypto.Signature{Type: crypto.SigTypeBLS, Data: []byte{}}, BLSAggregateSig: crypto.Signature{Type: crypto.SigTypeBLS, Data: []byte{}}, BLSAggregateSig: crypto.Signature{Type: crypto.SigTypeBLS, Data: []byte{}}, BLSAggregateSig", "reference": "Should this also be a pointer? What happens if there are no BLS messages? I guess that's what this test is exercising, and Lotus also uses a non-pointer here." }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if it's the right place to do this.", "reference": "This was definitely a subtle bug right here." }, { "prediction": "I don't think we need to do this. I think we should do this in a separate PR. I'm not sure if we should do this in a separate PR, but I think it's better to do it in a separate PR.", "reference": "If this method gets all the emails, it should be named appropriately. **all_emails** or just **emails**." }, { "prediction": "I don't think we should change this to 14689", "reference": "Can we still random, but if we randomly get a port is used before, we randomly pick again?" }, { "prediction": "I think this should be `create_no_window=False`.", "reference": "I would rather no have this as a `kwarg` as it encourages \"growth\" which lead to an unweildy constructor in other classes. Let's add a method or property to take care of this instead as I think it's usage is going to be quite low." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `can_cancel_form!` method in `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f` or `Gsa18f`", "reference": "what if a purchaser is also an approver? or would that not happen?" }, { "prediction": "I think this should be `if not network.config.has_fee_estimates():`.", "reference": "Not sure why this change. You forgot to handle the case where the user has dynamic fees disabled and there are no fee estimates available. He should be able to sweep none-the-less (as he is using static fees anyway). The line with `config.fee_per_kb()` below, that you have deleted, handled that." }, { "prediction": "I don't think this is needed.", "reference": "sorry, I wasn't familiar with this TopLevelCondition... What it would be in this case? The AuditsLogReady condition?" }, { "prediction": "I think this should be `inputCache` instead of `inputCache`.", "reference": "Where does the `alloc` field get set?" }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to use `int64` instead of `int64`.", "reference": "looks expensive to do it on each query" }, { "prediction": "I don't think we need to change this?", "reference": "@rhyolight -- but weren't we supposed to be standardizing on using underscores in file names (versus camelcase)?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Can this simply call `in_memory.empty?`?" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it.", "reference": "The styling/wording here probably needs some thought. It's more of a placeholder." }, { "prediction": "I don't think we need this patch anymore.", "reference": "Using a plural route helps in detecting the path automatically for `= form_for @password_reset`." }, { "prediction": "I'm not sure if this is the right place for this test.", "reference": "Is `metadata` required on all tests? I actually just removed the metadata field entirely from a few tests in my PR." }, { "prediction": "I think this should be `throw new IOException(\"Could not transfer all bytes of \" + from.toPath());` or `throw new IOException(\"Could not transfer all bytes of \" + from.toPath());`", "reference": "seems reasonable to also want to include the 'to' location?" }, { "prediction": "I think this should be `final boolean wasDeleted = baseDir.delete();`", "reference": "I don't think we need to necessarily check if that returned true or not, we should just remove the shutdown hook. Since nothing would check or do anything with this flag anyways." }, { "prediction": "I don't think this is necessary.", "reference": "Better to push getting policy details into a func we can reuse later." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `Start` method that returns `nil`, but if it's a good idea to have a `Stop` method that returns `nil`, it's a good idea to have a `Start` method that returns `nil`, and then call `Stop()` on the `Outbound` object.", "reference": "optional: while there's nothing to do, a good way to catch bugs (where we use an outbound without calling `Start`) might be to have this outbound verify that `Start` is called before `Call` or `Stop`" }, { "prediction": "I'm not sure if this is a good change. I'm not sure if it's a good change, or if it's a good change, or if it's a good change, I'm not sure.", "reference": "Not a blocker by any means, but I think there is value in keeping the local imports in a separate group." }, { "prediction": "I'm not sure if this is the right place for this test.", "reference": "nit - I would test the error message as well. For panic, you might need to see if the stack contains the error message, instead of equaling." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Didn't we have specific logic for handling slices vs structs?" }, { "prediction": "I'm not sure if this is the right place to inject saylinks. I'm not sure if this is the right place to inject saylinks, but if it's the right place to inject saylinks, I'm not sure if it's the right place to inject saylinks.", "reference": "`c_str()` is not needed." }, { "prediction": "I don't think we need to check for `ServiceExternalIP` or `ServiceExternalIP`?", "reference": "The handler will be installed twice if you don't remove the below one." }, { "prediction": "I think this method should be renamed to `getEpochLengthActivationBlock`", "reference": "How about putting `epochLength` (or something like that) in place of `a` just to make it easier to read" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "Wouldn't this still fire afterwards if you created one called `pleasings`? or am I missing something?" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "I don't love this syntax; it doesn't match anything we're currently doing and it's not obvious. Why isn't this `/keybase/private/jzila,kb_bot/.kbfs_autogit/public/jzila/kbp.git`?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `zipWith()` or `zipWith()` in this case.", "reference": "Does a type-hint work instead of casting? `return ofAll(toList(). zipWith(that, mapper));` (Probably not, just a question.)" }, { "prediction": "I don't think we need to change this file.", "reference": "Are these required?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "This is consistent for all clients that we will check yes? Seems like we should just use the singleton, maybe pass it to the parse function or since clients have a server pointer set it at server start and just access that way without locks?" }, { "prediction": "I think this should be `javaToken.kind == JavaTokenKinds.DECIMAL_LITERAL || javaToken.kind == JavaTokenKinds.INTEGER_LITERAL || javaToken.kind == JavaTokenKinds.FLOATING_POINT_LITERAL || javaToken.kind == JavaTokenKinds.INTEGER_LITERAL || javaToken.kind == JavaTokenKinds.FLOATING_POINT_LITERAL || javaToken.kind == JavaTokenKinds.DECIMAL_LITERAL || javaToken.kind == JavaTokenKinds.CHARACTER_LITERAL || javaToken.kind == JavaTokenKinds.CHARACTER_LITERAL || javaToken.kind == JavaTokenKinds.CHARACTER_LITERAL || javaToken.kind == JavaTokenKinds.DECIMAL_LITERAL || javaToken.kind == JavaTokenKinds.FLOATING_POINT_LITERAL || javaToken.kind == JavaTokenKinds.INTEGER_LITERAL || javaToken.kind == JavaTokenKinds.FLOATING_POINT_LITERAL || javaToken.kind == JavaTokenKinds.FLOATING_POINT_LITERAL || javaToken.kind == JavaTokenKinds.INTEGER_LITERAL || javaToken.kind == JavaTokenKinds.FLOATING_POINT_LITERAL || java", "reference": "Note that this is a bug, that should be fixed on master. `DECIMAL_LITERAL` cannot match any token, because it's declared with a `#`." }, { "prediction": "I don't think this is needed.", "reference": "Don't need extra line here." }, { "prediction": "I'm not sure about this change, but I'm not sure if it's worth it.", "reference": "For the first look, this change is strange. Were we passing these tests before?" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it.", "reference": "On Windows, doesn't `os.Args[0]` include the `.exe`? What if you run the program like `caddy.exe`?" }, { "prediction": "I'm not sure if this is needed anymore.", "reference": "I don't see anywhere where `ServiceConfiguration` interface implementation would return any kind of error. Not sure if its needed, but we could ALWAYS return a valid 'pseudo' configuration without possibility of error." }, { "prediction": "I think this test should be `assertThat(CommonRenderingUtil.getDocLines(\"a\\nb\\r\\nc\")).isEmpty()`", "reference": "Do we actually want to split on `\\r`? I thought that the \"newline sequence\" was only `\\r\\n` on windows." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or not.", "reference": "Nit: these lines are duplicated from above. They can be refactored by setting etype in a conditional and putting 282 and 283 below that." }, { "prediction": "I think this should be `s.Noticef(\"Server Exiting..\")`", "reference": "I would do an s.Notice(\"Initiating Shutdown...\") then after Shutdown() do the original Server Exiting." }, { "prediction": "I don't think this is the right place to do this. I think we should move this logic into the `CanClaimRefund` method.", "reference": "Not sure with how many seconds on average are we dealing with but maybe it's better to have hh:mm:ss format in logs - you can make it with `TimeSpan.FromSeconds(seconds).ToString()`" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Why is this required? The user should be able to omit it and use the defaults." }, { "prediction": "I don't think this is needed.", "reference": "I don't think the naming of this setting conveys what it does. Maybe something like \"Ignore mouse movement triggered by other applications\"" }, { "prediction": "I don't think we need to pass the `CollectorUri` to `FailedToReachCollector`?", "reference": "Didn't went with backwards compatibility since it's still in beta" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to throw an error if the bondsToCut is not set.", "reference": "Perhaps bondsToCut must be None or non empty." }, { "prediction": "I don't think we need to change the chart type here.", "reference": "See above, we could avoid adding that (same applies below)." }, { "prediction": "I don't think we need this anymore.", "reference": "should use Number instead of Long" }, { "prediction": "I don't think this is needed.", "reference": "Should the rest of the file be updated to use `expect` or should this test use the same format as the rest of the tests?" }, { "prediction": "I don't think we need to update dnsZone status after refresh. I think we need to update dnsZone status after refresh.", "reference": "How would you feel about a different approach where the `DeleteAWSRecordSets` gets passed the zone ID and zone name rather than the `DNSZone`?" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `prob` or `prob_range` here.", "reference": "it seems `random.uniform(0, 1)` similar to `random.randint(2)`, all have 1/2 probabilities." }, { "prediction": "I don't think this is needed.", "reference": "Added to support EBS volume creation, used like this: blockDeviceMap = [] blockDeviceMap.append( {'DeviceName':'/dev/sdc', 'VirtualName' : 'ephemeral0'}) blockDeviceMap.append( {'DeviceName':'/dev/sdh', 'Ebs': {'VolumeSize' : '100'} })" }, { "prediction": "I think this should be `http://testUrl` instead of `http://testUrl`", "reference": "We shouldn't depend that url is `mysterium` - it can be just `testRequestURL`. Also, `URL` has to be upper-case." }, { "prediction": "I'm not sure if this is the right place to lock the lock.", "reference": "We could delay this look-up now and only do it in the non-skip case. I suspect this is true for (almost) all of the top-level refactored functions." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Typically, to be simple, we could reserve a const length space." }, { "prediction": "I don't think this is needed anymore.", "reference": "Need to add a license and copyright header to each file." }, { "prediction": "I think this should be `hidden_field_tag` instead of `hidden_field_tag`.", "reference": "If I'm not mistaken, this line is now outside of the `if signed_out?` block, right? Any concerns about that? Seems odd that we wouldn't accept coupons for signed in users, but I want to make sure we understand the ramifications of this change." }, { "prediction": "I don't think this is needed anymore.", "reference": "Please remove the unused import of DBPDataSource." }, { "prediction": "I don't think this is needed.", "reference": "I think you should add some extra message here saying it was originally sent as an error, for diagnosability." }, { "prediction": "I'm not sure if this is correct.", "reference": "I believe that all the changes in this file are not valid for v1.2 of the Avalon toolkit." }, { "prediction": "I don't think we need to merge original role and meta role attributes.", "reference": "we cannot change the behavior of the processRole - that method is used in lots of places. this call must be done only in the method where templates are being handled." }, { "prediction": "I think we should rename this to something more descriptive.", "reference": "I think we probably want to follow the same naming convention that we do with `execAgentConfigFileNameTemplate` (using the SHA in the name of the file). This file might be confgurable in the future and when that happens we will be ready. Plus it's pretty much the same code that we already use for the config file." }, { "prediction": "I think this should be `if(manual_wall_time_option!= 0) {`", "reference": "If following above, this would be: end_time = time(0) + manual_wall_time_option, which is simpler. Also, make the check manual_wall_time_option > 0, otherwise negative times would terminate the worker right away." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it. I'm not sure if this is the best way to do it, but I'm not sure if it's the best way to do it.", "reference": "If we aren't using `errors.Is` we don't need the `Unwrap` as we have `Cause` which is what pkg/errors uses." }, { "prediction": "I don't think this is needed anymore.", "reference": "redundant empty line" }, { "prediction": "I'm not sure if this is a good change.", "reference": "The config.lua.dist still shows `houseAccountOwner`" }, { "prediction": "I don't think we need this anymore.", "reference": "I think we can leave this import and use non FQNs in the code." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "I'd rather just send the parameter twice than break encapsulation here. There's already precedence with webelement IDs" }, { "prediction": "I don't think we need this anymore.", "reference": "We should probably exit early if there are no items in the list." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "As we can't use old names we should warn in whats new for 2.12 that this can happen." }, { "prediction": "I'm not sure if this is the right place to run this test.", "reference": "good job finding this package, I hope it's actively maintained" }, { "prediction": "I'm not sure if this is a bug or if it's a bug or if it's a bug, or if it's a bug, I'm not sure.", "reference": "same changes as in hipEnvVar.cpp" }, { "prediction": "I don't think this is needed.", "reference": "NULL check should be before this line" }, { "prediction": "I'm not sure if this is the right place to check for null.", "reference": "Seems like client.getlocalplayer is being called a lot, would it be worth it to do final Player player = client.getlocalplayer?" }, { "prediction": "I'm not sure if this is the right place to move null value to result. I'm not sure if this is the right place to move null value to result.", "reference": "this change is not correct. 3-valued boolean logic requires that comparison of null to another value during intermediate operations should make the result null and not false. The place where null becomes false is at the very end of that expression. As an example, with the changed logic, this expression will return incorrect result. select * from t where not (a = 1); if a is null, the where predicate will become true which is incorrect. With the original 3-valued result, the where pred will become false and not return any result." }, { "prediction": "I think this should be `{locale}\": r.Header.Get(\"Detected-Locale\")` or `{locale}\": r.Header.Get(\"Detected-Locale\")`", "reference": "This can already be done with `{>Detected-Locale}`, why make another way to do it?" }, { "prediction": "I think this should be `true` instead of `false`.", "reference": "These changes just match the logic update in the next method that was done previously - to assure the whole set of files is valid rather than that there is at least one that would be changed." }, { "prediction": "I think this should be `w.WriteHeader(http.StatusContinue)` instead of `w.WriteHeader(http.StatusContinue)`", "reference": "Why setting the status to Continue as at the end it is written OK? Status should be written only once." }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "Howdy! You'll want to do this same thing (replace `hydrateParamCache` with `proofs/bin/paramcache` and then do the copy) in `smartdeps`, too." }, { "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `--volname --snapname ` to the usage message.", "reference": "nit : Remove the extra lines" }, { "prediction": "I'm not sure if this is a good option. I'm not sure if it's a good option, but if it's a good option, I think it's a good option. I'm not sure if it's a good option, but if it's a good option, I think it's a good option. If it's a good option, I think it's a good option.", "reference": "Instead of adding a new option, I wonder if we could decide on a port that would disable listening. For instance, port set to 0 means that we use default port 4222. Setting to -1 means that we let OS pick a random free port. We could say anything negative lower than -1 (say -2) means disabled? You don't have to update the PR for that, just wondering if that would be better or not and let's see what others think." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `clang-tidy` or `clang-tidy`.", "reference": "Should we add some default case if non of the above return some analyzer name? Something like `unknown analyzer`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Nvm. The original version is best... *hides from the angry rubocop*" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "we can drop this and use the returned body above, right?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Is echoing enabled on purpose here or it's a remainder of your tests?" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "I think this should just be worked into the next message and follow the verbosity of it." }, { "prediction": "I don't think we need to pass `urlParams` here.", "reference": "This also needs to be reverted." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "`FromCommand` seems to fit better, since with my suggestion below, all pauses will raise a signal on `needPause`. Also maybe the format `journalPauseConflict` and `journalPauseCommand` is better, since the journal isn't necessarily paused yet once we raise a pause signal." }, { "prediction": "IsServiceNonRetryableErrorGRPC checks if the error is a retryable error?", "reference": "This is fix from another PR #120." }, { "prediction": "I don't think we need to change this. I'm not sure if we need to change this.", "reference": "I *think* it makes sense to try the more general dictionary (i.e standard python literals) format first. Might be other implications I haven't figured out yet. Then again, ``MultiInterface`` is pretty new so it probably doesn't matter wrt backwards compatibility." }, { "prediction": "I don't think this is needed.", "reference": "lol that variable name" }, { "prediction": "I don't think we need to change the chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain and chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain chain", "reference": "Upper case is reserved for our versions of top-level chains i.e. the `FORWARD` chain jumps to `cali-FORWARD`." }, { "prediction": "I don't think this is needed.", "reference": "json_handler::receive () has already started a read tx that can be used here right?" }, { "prediction": "I'm not sure if this is the right place for this test, but I'm not sure if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test.", "reference": "We should add the definition to `.storybook/config.js` as well." }, { "prediction": "I think this should be `(Lng32 *)op_data[1] == 0 || *(Lng32 *)op_data[1] == -1)`", "reference": "I don't believe this is correct. Consider the query, \"select a from t1x where not(b = 0 and c = 0)\". When B and C are both null, both equal predicates evaluate to null, and the AND evaluates to null. The NOT then also evaluates to null. The WHERE clause should treat the result of the NOT as false. But with this fix, the result of the AND will be false, making the NOT true. There needs to be three cases here for ITM_AND: If the first operand is false, then the AND is false. If the first operand is true, then the result is the second operand. If the first operand is null, then if the second operand is false, the result is false otherwise the result is null. Similar logic needs to be added to the ITM_OR case." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "`bound/2` is generally the previous bound that we tested, except when `bound` is equal to 1. It won't break in that case since callers are not supposed to call advance on a target that is lte the current doc ID, but this might still make room for bugs?" }, { "prediction": "I don't think this is needed.", "reference": "Can we remove `raw`, `fullResult`, and `serializeFunctions`?" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "[Nit] I don't have a proposed suggestion, but security seems too generic of a name here." }, { "prediction": "I don't think we need to do this. I'm not sure if we need to do this, but I think we should do this in a separate PR.", "reference": "do we need to force a buildConfig here? I know it's in muon, but that might actually be making things harder for people" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "Shouldn't need this-> here." }, { "prediction": "I don't think we need this file anymore.", "reference": "Why delete this?" }, { "prediction": "I don't think this is needed.", "reference": "This line is here to be compatible with the current way `refs` work, right?" }, { "prediction": "I don't think this is needed. I think it's better to use `number_to_currency(value)` instead of `number_to_currency(value)`", "reference": "Hmm, I wonder if we can safely assume all decimals should be displayed as $$...ok for now I suppose." }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it.", "reference": "Good spec :). Very clear and easy to see what it's doing." }, { "prediction": "I'm not sure if this is the right place to put this method in the `ExploreController` class, but I think it's a good place to put this method in the `ExploreController` class.", "reference": "Shouldn't we need to sanitize the `params[:filter]` from a defined expected values?" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if it's the best way to do this.", "reference": "Should we bite the bullet and poll for the full 5 minutes that AWS recommends? If we do that, we'll probably want to leave some kind of breadcrumb in the event log to let users know why it's taking so long to launch." }, { "prediction": "I don't think this is needed anymore.", "reference": "Guava changed `Objects` -> `MoreObjects`" }, { "prediction": "I don't think this is needed.", "reference": "All these hand generated mocks can be deleted. I think we already moved everything to gomocks." }, { "prediction": "I'm not sure why this change is necessary.", "reference": "what about string/number etc _ids? this will fail." }, { "prediction": "I'm not sure if this is the correct error message.", "reference": "Looks like the test had a bug prior to this." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it.", "reference": "Should start with joplin://x-callback-url/. Also maybe create a helper function to check if a url is valid?" }, { "prediction": "I don't think we need to change the id here.", "reference": "PR works great. Just out of curiosity: why all the id changes?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "config map first value is wrong, it aims to define the \"value type\", that value will lead to an undefined behavior." }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do here.", "reference": "This doesn't make sense. The thing being constructed is a blob.Bucket. \"Constructing\" the pointer is trivial." }, { "prediction": "I don't think this is needed anymore.", "reference": "Outch. A configuration/parsing refactor is on the radar but this seems more pressing." }, { "prediction": "I don't think we need this. I think we should use moment.js instead of moment.js", "reference": "Unfortunately this won't work when the \"All time\" range is chosen because `memberStats.days` will be `\"all-time\"` and not a number. What you could do instead is to use `memberStats.stats` as the dependent key and use `Object.keys(memberStats.stats.total_on_date)[0]` to grab the first date in the range and build the label from there." }, { "prediction": "I don't think we need this feature anymore.", "reference": "Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "Is this still needed?", "reference": "We need this left in as `axe.configure` is for the top-level page `axe` and we still need to configure the axe script inside the iframe as well (so both have to be configured)," }, { "prediction": "What kind of change implementing this rule can cause?", "reference": "is this rule serviceimpacting? I'm thinking it's mostly around the modeling of pageable in the swagger, thoughts?" }, { "prediction": "I'm not sure if this is a good change. I'm not sure if it's a good change or if it's a good change.", "reference": "same here, replace `ks` and `kc` to something more related to Source." }, { "prediction": "I don't think we need to do this in the `MvvmCross.Platform.Converters` class.", "reference": "We should probably ask here if `dict` contains a key with the appropiate value, and leave a trace in case it doesn't, to make it easier to debug for developers." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it, but I'm not sure if it's the best way to do it.", "reference": "this should only be indented 2 spaces" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Nit, these Err not nils should be `t.Fatalf` not error. We want to the test to stop if this error occurs." }, { "prediction": "I think this should be `false`", "reference": "shouldn't every `Boolean` in this pr be `boolean`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but I'm not sure if it's the right place to do it.", "reference": "This `if` is not necessary" }, { "prediction": "I don't think this is needed.", "reference": "Are you using this anywhere? (I couldn't find it.)" }, { "prediction": "I think this should be `defer s.recordStepTime(s.name, startTime, endTime)`", "reference": "Can be inlined" }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do this.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I don't think this is needed.", "reference": "Please use `kinto.core.utils.json`" }, { "prediction": "I'm not sure if this is the correct error message, but I'm not sure if it's the right error message. I'm not sure if it's the right error message, but if it's the right error message, it's the right one.", "reference": "Since we're returning the error with the same content, we don't need to log it here; it will get bubbled up and emitted that way." }, { "prediction": "I don't think this test is needed.", "reference": "What happens if someone import `typing` and thus uses `@typing.final` instead?" }, { "prediction": "I'm not sure if this is the correct version. I'm not sure if it's the correct version, but I'm not sure if it's the correct version.", "reference": "Better remove this dependency altogether" }, { "prediction": "h2o_mem_freefreefreefreefreefreefreefreefreefreefreefreefreefree free free free free free free free free free free free free free free free free free free free free free free free free free free free", "reference": "Could you please move the declaration to httpclient.h? I think we have a consistent pattern in declaring global variables in header files." }, { "prediction": "I don't think we need to change this. I don't think we need to change this.", "reference": "We will also need to add this to the spec." }, { "prediction": "I'm not sure why this was removed.", "reference": "In startEvaluator, we have the paysetHint; we should use it to preinitialize the state delta allocation. The number of transactions and the deltas are typically growing in a linear fashion, so preallocating twice as much in the array initializer would be a good idea." }, { "prediction": "I think this should be `WebDriverException.scheduleIpHostResolving()`", "reference": "we shouldn't add a bunch of static initializers 'everywhere' in the code. Probably just one would be good, during the construction of the 'RemoteWebDriver' class." }, { "prediction": "I don't think this is needed.", "reference": "Would it be possible to move the creation of the `new { Prop = (object)_value }` out of the benchmark? In the current version, the benchmark includes the cost of creating and serializing the object, while if possible it should be the cost of serialization only." }, { "prediction": "I think we should move this to the `TranslationAdapterLocoBundle` class.", "reference": "only dev and local" }, { "prediction": "I don't think we need to drop the jobs_queue_reserved_at_index table. I don't think we need to drop the jobs_queue_reserved_at_index table. I think we should just drop the jobs_queue_reserved_at_index table.", "reference": "This should not be nullable, instead it should be `->default(0);`" }, { "prediction": "I'm not sure about this change. I think it's a breaking change.", "reference": "What about `selectedColumns`? I believe it is frequently used throughout the project." }, { "prediction": "I don't think we need this field anymore.", "reference": "I thought we switched the approach from a payload to boost attribute? Besides; it's not clear we need this toggle at all since the user could arrange for this behavior simply by having the new DelimitedBoost filter thing in the chain." }, { "prediction": "I'm not sure why this was removed.", "reference": "the previous code used 'export' when platform is cisco-5, presumably because 'env' cannot be used to load variables? I have no idea if that's the case but this env vs export logic is not here" }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to add a `SecretCount` field to the `CloudInit` struct.", "reference": "I'm wondering if we need to add some type of validation here that the SecretCount!= 0... Or do we think it would be valid to have a SecretCount of 0?" }, { "prediction": "I don't think slaveOk is needed here.", "reference": "This test is being skipped. I unskipped it, and it failed in the same way for both `slaveOk: false` and `secondaryOk: false`. I'm not sure how else to test this broken test." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for this, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, I'm not sure if it's the right place for it.", "reference": "I don't believe that we need a pointer to an interface for the `to` side of this since we're just assigning a value to the to field." }, { "prediction": "I don't think we need to do this. I think we should add a `count` argument to `repeat` so that we don't have to worry about `count` and `times` in the future.", "reference": "No blank line after the docstring." }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "nit: move this to the group below." }, { "prediction": "I'm not sure if this is the right fix.", "reference": "This is fine, but maybe we should change the variable name to \"bufferSize_as_uint\"? Or \"...uint32\"?" }, { "prediction": "Line is too long. [89/80]
    Space inside { missing.
    Space inside } missing.", "reference": "Use snake_case for variable names." }, { "prediction": "I'm not sure if this is the right place for this test. I'm not sure if it's the right place for this test.", "reference": "Obviously, don't merge this to master." }, { "prediction": "I'm not sure if this is the right place to test this, but I'm not sure if it's the right place to test this.", "reference": "Nearly there! This should assert on the output, take the result of \"start\" and \"finish\" as an example :)" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This loop is going to burn CPU if len(s.q) == 0. Maybe a small sleep?" }, { "prediction": "I don't think this is needed.", "reference": "can you give a reason why session should be contained in RegionManager?" }, { "prediction": "I don't think we need this test.", "reference": "You are comparing two signerIDs here, error message should be \"Signers should match\"" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to lock the IAM role credentials.", "reference": "Who's acquiring this lock for writes?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This throws a linter error, don't use object creation for side effects. I feel like it's kinda messed up that the errors are thrown by the constructor and not that the constructor will throw them" }, { "prediction": "I'm not sure if this is the right place for this test. I'm not sure if this is the right place for this test, but I'm not sure if this is the right place for this test.", "reference": "Should there be a `trail.topic_name` method so we don't annoy Demeter?" }, { "prediction": "I don't think team is a team, it's not a team, it's a team.", "reference": "instead of passing \"None\" it would be more readable to create a constant e.g. TEAM_PUBLIC = None and then call build_package(TEAM_PUBLIC,...)" }, { "prediction": "I think we should move this file to `Psalm/Internal/exception_handler.php`", "reference": "Would it make sense to include this file via composer files-autoloading instead?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it.", "reference": "Each `ExpectedCondition` implements `java.util.Function` These are expected to be stateless. This condition will leak previous `elementText` on the second usage, which doesn't seem ideal." }, { "prediction": "I'm wondering if we should move this test to the `go-sqlmock` package. I'm not sure if we should move this test to the `go-sqlmock` package, or if we should move this test to the `go-sqlmock` package. I'm not sure if we should move this test to the `go-sqlmock` package, or if we should move it to the `go-sqlmock` package.", "reference": "Extra newline here. Thanks for moving it under the `testing` import though. This just needs to be grouped with the other imports below it." }, { "prediction": "I don't think this is needed.", "reference": "Should we ignore case when doing the comparison?" }, { "prediction": "Is this needed?", "reference": "The same `ifdef` should apply to `#include ` line 14" }, { "prediction": "I don't think this is the right place for this method.", "reference": "We're instrumenting a static method, so there's no instance in this case. `diagnosticSource` is the first argument." }, { "prediction": "I'm not sure if this should be `false` or `true` or `false` or `false` or `false` or `false` or `false` or `false` or `false` or `false` or `false` or `false` or `false` or `false` or `false` or `false` or `false` or `false` or `false` or `false` or `false`` or `false` or `false` or `false`` or `false` or `false`` or `false` or `false`` or `false` or `false`` or `false`` or `false`` or `false`` or `false`` or `false`` or `false`` or `false`` or `false`` or `false`` or `false`` or `false`` or `false`` or `false``` or `false``` or `false``` or `false``` or `false````` or `false`` or `false``` or `false``` or `false```` or `false```", "reference": "I feel like this belongs in `RecipientPresenter` (which should really be `MetadataPresenter`), but I suppose having it next to requestReadReceipt makes sense as well. feel free to leave as is." }, { "prediction": "I don't think we need to update this to 1.4.1?", "reference": "Let's go back to 1.4.0 until the release is being prepared." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "I would avoid the term \"errno\" as it implies the glibc variable. Use error_code or status or something." }, { "prediction": "I don't think we need to pass dependencies here.", "reference": "@abhinav @kriskowal what do you think about putting the handler on `d`?" }, { "prediction": "I'm not sure if this is the right thing to do here. I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do.", "reference": "Why `restic.TagLists` and no `restic.TagList`? Because I'm using `restic.TagList` here and using `restic.TagLists` is a lot of changes" }, { "prediction": "I think this should be `timeout: 1 * time.Hour, expected: context.Canceled`", "reference": "An hour seems a significant amount of time to wait for within a test, does it need to be that long?" }, { "prediction": "I'm not sure if this is the right way to do this. I'm not sure if this is the right way to do this.", "reference": "Nit: (newish to golang, don't hesitate to tell me I'm wrong here, but...) I'd have written this code, just for readability: keepAlive := false return d.dial(hostName, tlsClientConfig, keepAlive)... or even return d.dial(hostName, tlsClientConfig, false) // keepAlive=false Personally I think Golang should have included named args; I think it's one of the things python got right." }, { "prediction": "I don't think we need to add Msmq here.", "reference": "I don't think it would cause any version conflict, but I'd feel safer if you declared it last, so that the numerical id of the existing integrations don't change" }, { "prediction": "I'm not sure if this is the correct message, but I think it's better to say \"The CertificateRequest %q is an invalid request\"", "reference": "Can we provide some more useful actionable info here? `fmt.Sprintf(\"The certificate request could not be completed due to invalid request options: %s\", req.Status.Conditions[InvalidRequestCondition].Message)`" }, { "prediction": "I don't think this is needed.", "reference": "yeah, can change to 8545" }, { "prediction": "I don't think this is needed.", "reference": "As far as I can see you're not rollbacking transaction anywhere. This could potentially cause further issues(and very hard to debug ones) with not synchronized transactions between message handling. Is the transaction required in this place anyway? You seem only to be fetching data here. ack method is performing some updates so it makes sense" }, { "prediction": "I don't think this is needed.", "reference": "What's the meaning of null URIEndpointObject?" }, { "prediction": "I'm not sure about this, but I'm not sure if it's a good idea to move this to a separate PR. I'm not sure if it's a good idea to move this to a separate PR.", "reference": "Why did you remove the time? It can be useful if some actions are ran in jobs?" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I don't think this is needed.", "reference": "What the reason to change imports?" }, { "prediction": "I don't think we need to check for `Exception e` here.", "reference": "Nit: continuation indents are 2 indents / 4 spaces." }, { "prediction": "I don't think this is needed.", "reference": "You can use `netloc.rsplit(\":\")` for that." }, { "prediction": "I think this should be `zap.Error(\"configuration file for Image Watcher not found\", zap.String(\"repo-id\", repoCfg.RepoID), zap.Error(err), zap.String(\"repo-id\", repoCfg.RepoID), zap.Error(err), zap.String(\"repo-id\", repoCfg.RepoID), zap.Error(err), zap.String(\"repo-id\", repoCfg.RepoID), zap.Error(err), zap.String(\"repo-id\", repoCfg.RepoID), zap.Error(err), zap.String(\"repo-id\", repoCfg.RepoID), zap.Error(err), zap.String(\"repo-id\", repoCfg.RepoID), zap.Error(err), zap.String(\"repo-id\", repoCfg.RepoID), zap.Error(err), zap.String(\"repo-id\", repoCfg.RepoID), zap.Error(err), zap.String(\"repo-id\", repoCfg.RepoID), zap.Error(err), zap.String(\"repo-id\", repoCfg.RepoID),", "reference": "nits, I don't get the point of this change" }, { "prediction": "I don't think this is needed.", "reference": "`warningPrefix` looks the same on both platforms, we could move it up to `log.go`." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "What's the motivation behind switching to plural here? I think we want singular cc @abhinav" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "What do you think about renaming this method `FromErrorAndCode(code Code, err error) *Status`? One of the benefits is that it will be consistent with the naming of `func FromError(err error) *Status {` which does something almost similar." }, { "prediction": "I'm not sure if this should be null.", "reference": "we cannot state that by default the same value is used if we stopped using null - it would suggest that when you change JSON RPC and leave WS port default then they would be same." }, { "prediction": "I'm not sure if this is the right place to start ginkgo.", "reference": "I'm still not convinced dropping Chrome logs is the right thing to do, but if you insist" }, { "prediction": "I don't think this is the right thing to do here.", "reference": "It would be helpful to include some reasoning here. With the reflection model, it is often the case that names are not available." }, { "prediction": "I'm not sure if this is the right place to set up process log before anything bad happens. I'm not sure if this is the right place to set up process log before anything bad happens. I'm not sure if this is the right place to set up process log before anything bad happens. I'm not sure if this is the right place to set up process log before anything bad happens.", "reference": "Instead of setting this here, why not have the flag call in the init function set `caddy.LogDestination` directly, and switch on that?" }, { "prediction": "I'm not sure if this is the right place to import it.", "reference": "This belongs under \"WordPress dependencies\"." }, { "prediction": "I don't think we need this.", "reference": "Was there an issue on `net452`?" }, { "prediction": "I think this should be `if (_platformNotSupportedExceptionMessage!= null) { Write($\"System.PlatformNotSupportedException(\\\"{_platformNotSupportedExceptionMessage}\\\"); \"); } else if (_platformNotSupportedExceptionMessage.StartsWith(\"SR.\")) { Write($\"System.PlatformNotSupportedException(\\\"{_platformNotSupportedExceptionMessage}\\\"); \"); } else if (_platformNotSupportedExceptionMessage.StartsWith(\"SR.\")) { Write($\"System.PlatformNotSupportedException(\\\"{_platformNotSupportedExceptionMessage}\\\"); \"); } else { Write($\"System.PlatformNotSupportedException(\\\"{_platformNotSupportedExceptionMessage}\\\"); \"); }", "reference": "Another option is to always write it without quotes. I always have to use SR. And why not?" }, { "prediction": "I don't think we need to import deepmerge from 'deepmerge'", "reference": "This should use the `merge` function added in #473 instead of introducing a new dependency" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Shouldn't this say \"a binding with descriptor type VK_DESCRIPTOR_TYPE_MUTABLE_VALVE\"" }, { "prediction": "I think this should be `const struct wlr_tablet_tool_v2_grab_interface {.name = \"wp_tablet_tool-cursor\",.type = \"wlr_tablet_tool_v2_grab_interface\" }`", "reference": "This variable name should probably contain `grab`" }, { "prediction": "I'm not sure if this should be `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020` or `H2020`` or `H2020` or `H2020` or `H2020`` or `H2020` or `H2020`` or `H2020` or `H2020`` or `H", "reference": "Which initializer should we be using for open_aire? The one in `external_apis` or this one in `initializers`?" }, { "prediction": "I don't think we need to do this. I don't think we need to do this.", "reference": "remove todo on line 28?" }, { "prediction": "I don't think this is needed.", "reference": "clean unnecessary arguments." }, { "prediction": "I think this should be `FAILED(65), FAILED(70), SKIPPED(90), SKIPPED(90), FAILED(70), SKIPPED(90), FAILED(90), FAILED(70), SKIPPED(90), FAILED(70), SKIPPED(90), FAILED(90), FAILED(70), SKIPPED(90), FAILED(90), FAILED(70), FAILED_FINISHING(80), SKIPPED(90), FAILED(90), FAILED(70), FAILED_FINISHING(80), SKIPPED(90), FAILED(90), FAILED(70), FAILED_FINISHING(80), SKIPPED(90), FAILED(90), FAILED(70), FAILED_FINISHING(80), FAILED(90), FAILED(70), FAILED_FINISHING(80), SKIPPED(90), FAILED(90), FAILED(90), FAILED(70), FAILED(70), FAILED(70), FAILED(70), FAILED_FINISHING(80), SKIPPED(90), SKIPPED(90), FAILED(90), FAILED(70), FAILED(70), FAILED(70), FAILED(70), FAILED_FINISHING(80), SKIPPED(90), SKIPPED(90), FAILED(90), FAILED(20", "reference": "Could the name of the status be confusing to users? It says the execution stopped but is it a temporary stop? Will it continue to run at some point? To me the name does not suggest a final status but a transition one. WDYT @sshardool @jakhani @djaiswal83 @aditya1105" }, { "prediction": "I don't think we need to import `ansible_playbook` from `ansible_playbook`", "reference": "Since we created a Provisioners directory, can we do the same with the tests, and follow the same structure as the code?" }, { "prediction": "I don't think this is needed.", "reference": "We don't need that one anymore?" }, { "prediction": "I don't think we need STORE here.", "reference": "Since we're determining the local node's host info in the `Store()` init, we need to import the `STORE` object here. Is this OK, or should I be determining the host info earlier. (When parsing settings?)" }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if this is the right thing to do.", "reference": "I think, there is no `#getKind()` method anymore, is it? The approach would now be testing with instanceof. Or could we return a more specific type than JavaNode now?" }, { "prediction": "I don't think this is needed.", "reference": "can we localise these? not sure if we have easy access to a translator instance from `generic-provider-views`" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "This is the VID from Adafruit. Doesn't Particle have a different VID? (CC @suda)." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "The function is only used once, and this body is now only 1 call with the same args (e.g. basically an alias for `vStringTruncate`), it could probably be simply removed. But if you wanna keep the naming for clarity, it also sounds reasonable." }, { "prediction": "I'm not sure if this is the right place for this message.", "reference": "please change to `could not connect to peer: %s`. it is not relevant to say \"from kademlia\" in a warning" }, { "prediction": "I think this should be `time::TimeUtils::rmDateTimeStrMs(timestamp)`", "reference": "Why need to remove this? Datetime has microseconds in fact." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "What's up with this, isn't it nil? Why not use the real T value from the test function? @elcore @wmark" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "this feels weird" }, { "prediction": "I don't think we need this enum.", "reference": "I don't think this is the type of network we should be putting in our named networks." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "debug? I suspect this will be removed before merge?" }, { "prediction": "I'm not sure if this is the right place for this test, but I'm not sure if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test.", "reference": "should this be here twice?" }, { "prediction": "I think this should be moved to a separate PR.", "reference": "`generate_special` - a meaningless name for me. Can we provide more detailed naming?" }, { "prediction": "Line is too long. [89/80]", "reference": "This isn't something you introduced in your changes, but the change makes more obvious to me that this test would be better as a unit test of some kind (probably a controller test). Testing a 404 is an edge case that probably doesn't need to be tested with all components in integration." }, { "prediction": "I think this should be `logger.info(\"Using delegate supplier: \" + clazz.getName());`", "reference": "We chose `info` in the test code for obvious reasons. Changing to `finest` makes debugging harder and noisier." }, { "prediction": "I think this should be `\"http://\" + remoteHost.getHost() + \":\" + remoteHost.getPort()`", "reference": "any reason you're assigning to the local variable 'id' too?" }, { "prediction": "I don't think this is needed.", "reference": "Need to fix this import :)" }, { "prediction": "I'm not sure if this is the right way to do this.", "reference": "sorry these tests suck so much we are working to kill them" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's worth it.", "reference": "Why not adjust `currentTime` to be in ms directly?" }, { "prediction": "I'm not sure if this is the right fix. I'm not sure if this is the right fix, but I'm not sure if it's the right fix.", "reference": "> restore, we find the matching spill for that restore which uses the same slot nit: Two separate sentences: separate with `.` or something besides `,`." }, { "prediction": "I don't think we need this anymore.", "reference": "this flag not used" }, { "prediction": "I think this should be `$this->dateConverter->convertToDisplayDate( \"Y-m-d H:i\", $profile->expirationDate )?? null`", "reference": "I don't think `?? null` works here... that's to ensure PHP doesn't throw an \"undefined\" error about `$profile->expirationDate`, but now the code is assuming that `$profile->expirationDate` will be set. Might be cleaner to do:
     $expiration = isset($profile->expirationDate)? $this->dateConverter->convertToDisplayDate(\"Y-m-d H:i\", $profile->expirationDate) : null; 
    And then assigning the `$expiration` value in the return array..." }, { "prediction": "I don't think this is needed.", "reference": "An ENV should be used? Are you sure that the Vue examples are built in the production mode?" }, { "prediction": "I don't think we need to change this.", "reference": "Nit: this should actually always be float since we convert it before we construct the namedtuple." }, { "prediction": "I think this should be `LOG(FATAL) << \"makeDir \" << path << \" failed\";`", "reference": "The result of `FileUtils::fileType` could be saved, instead of calling twice." }, { "prediction": "I don't think we need to catch an exception here.", "reference": "Can you log the exception?" }, { "prediction": "I think this should be `flb_debug(\"[http_client] proxy host: %s port: %i\", c->proxy.host, c->proxy.port);`", "reference": "since this debug message is inside a plugin code, it should use flb_plg_debug(ctx->ins, \"...\"), on this case don't need the component prefix since the API will put it there automatically" }, { "prediction": "I don't think this is needed anymore.", "reference": "I also took advantage of the changes to change the Timestamps used in this notification from \"java.sql.Timestamp\" to \"com.yahoo.rdl.Timestamp\"." }, { "prediction": "I don't think we need to change this?", "reference": "It would be nice all these tweaks to be configurable from cmd line, with sensible defaults" }, { "prediction": "I don't think this is the right fix.", "reference": "Why do we need this `check_same_thead` to be false? I feel a bit uncomfortable about this." }, { "prediction": "I don't think we need to check if the object is a CustomObject or not.", "reference": "We should probably test with constructors which aren't in the schema, and functions which aren't constructors." }, { "prediction": "I think this should be `#if defined(KOKKOS_ENABLE_PROFILING)`", "reference": "this call doesn't work doesn't? I mean there doesn't seem to be an 2 argument allocate overload. Maybe arg_logical_size should just be defaulted to the arg_alloc_size thing. Or we should just report out physical allocation size instead of logical." }, { "prediction": "I think this should be `/opt/puppetlabs/puppet/bin/puppet/bin/puppet/bin/puppet/bin/puppet/bin/puppet/bin/puppet/bin/puppet/bin/puppet/bin/puppet/bin/puppet/bin/puppet/bin/puppet/bin/puppet/bin/puppet/bin/puppet/bin/puppet/bin/puppet/bin/puppet/bin/puppet/bin/puppet/bin/puppet/puppet/bin/puppet/puppet/bin/puppet/puppet/bin/puppet/puppet/bin/puppet/puppet/bin/puppet/puppet/bin/puppet/puppet/bin/puppet/puppet/bin/puppet/puppet/bin/puppet/puppet/bin/puppet/puppet/bin/puppet/", "reference": "This winds up flipping the desired values. Looks like I gave you a bum steer @kevpl" }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "nit: let's call our address ioAddr from now on" }, { "prediction": "I don't think this is needed.", "reference": "You're killing this \"else\" case here which currently flags an error when maxBoundDescriptorSets == 0." }, { "prediction": "I think this should be `gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gboolean gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid gvoid g", "reference": "Nitpick: I'd append `_cb` to the function name here to mark it as a callback. Otherwise it looks a bit like this will do the entire job of removing null checksum refs from a hash table." }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if this is a good idea.", "reference": "or you can use `filter(x =>!x.isView)`" }, { "prediction": "I think we should remove this line.", "reference": "Instead of NewBuffer on the line above, do NewReader to avoid having to wrap later." }, { "prediction": "I'm not sure about this, but I'm not sure if it's a good idea to add a `too-many-locals` argument to this function. I'm not sure if it's a good idea to add a `too-many-locals` argument to this function, or if it's a good idea to add a `too-many-statements` argument to this function.", "reference": "No need for this, as pylint already only turns things off for this function and it's needed for the entire function." }, { "prediction": "I don't think we need this.", "reference": "extra brownie points ( overall solution ): we've currently triple-encoding the payset - 1. we encode it to calculate the block size. 2. we encode it to calculate the commit hash ( either via flat, or as Merkle tree ). 3. we encode it as a whole for the purpose of preparing the proposal ( I know that this isn't always the case, but this case happens to be on the critical path ). Caching the encoded data of the *first* block could help us repeating the process." }, { "prediction": "I don't think we need to change this test.", "reference": "This assertion should use the actual expanded string, so that it is clear what the message produced looks like. Right now one has to run the code to determine what the message is." }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "similar here for imports, these should be consolidated (and also consolidated with the grouping below)" }, { "prediction": "I don't think we need to pass `file_client_args` to the `load_bboxes` function.", "reference": "Maybe there is no need to modify it. Because if you don't use the mask, it won't be initialized." }, { "prediction": "I don't think we need this change.", "reference": "Is there a reason we wouldn't want the trailing `%`? I'm guessing that without the trailing `%` it will just do a strict match vs a partial prefix right?" }, { "prediction": "I don't think we need to include the stdio.h and stdint.h files.", "reference": "Please update the DMA test app in AFU repo once this gets approved." }, { "prediction": "I don't think we should remove this line.", "reference": "There should be a migration for that as well to reflect the change on in-production instances" }, { "prediction": "I don't think this is needed.", "reference": "Why does it have to be `\"\"` instead of an empty string" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for this PR.", "reference": "This is very strongly opinionated so feel free to disagree with me better, but as conditionals get more complex I like turn them into ifs instead of unlesses. What do you think?" }, { "prediction": "I think this should be `list.sort_by { Kernel.rand(list.size) }`", "reference": "Will this obey the seed set on Kernel?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea. I'm not sure if this is a good idea or if it's a good idea or if it's a good idea.", "reference": "We shouldn't use the `&.` syntax here, since we expect that `executor` will never be `nil`. For the functions that _can_ be called from apply / without an executor, `&.` is still appropriate." }, { "prediction": "I'm not sure this is the right place for this method.", "reference": "Why the switch from period to colon?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea.", "reference": "Can you just fix the warning instead? It's actually important for this to have a default of `\"\"` as the subsequent merges with `DefaultConfig()` and `fileConfig()` need to work. If you make this not `\"\"`, you break the assumptions of `Merge()`." }, { "prediction": "I don't think we need to add this to `Nethermind.Baseline.Config`", "reference": "let us not add this" }, { "prediction": "I don't think this is needed.", "reference": "Is there a need for group as well? crun sets both." }, { "prediction": "I'm not sure if this is the right place for this test.", "reference": "@cijothomas This build-up pattern was really confusing. It looks like internally ActivityProcessor is intended to be chained but there is nothing in the abstract class that enforces it. We never set a \"Next\" or make sure that the chain is called. Probably need to do some more work in this area?" }, { "prediction": "I don't think we need to call `findOneAndUpdate` here.", "reference": "`this.getFilter()` won't work on `pre('save')`. Perhaps make this `toySchema.pre(['updateOne', 'findOneAndUpdate'])`?" }, { "prediction": "I don't think this is the right place for this test.", "reference": "Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs." }, { "prediction": "I'm not sure why this was removed.", "reference": "I think this is the only place where we use `UvShutdownReq`. Can we remove the type altogether? Or do you prefer to keep it around?" }, { "prediction": "I'm not sure if this is the right place to configure TLS.", "reference": "I think we can get this to work by passing in the root ca cert fixture that upstream ca is using" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Just occurred to me to ask: is the condor log date in localtime or UTC?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Can you remove the sculliscep varbits from here too?" }, { "prediction": "I think this should be `return $retval && do_query(\"alter table host add index host_cpid (host_cpid)\");`", "reference": "I understand that it is a common practice in this script to add indexes this way but why don't we check index existence before adding it? I'm not very familiar with MySql but it's can be done easily in MSSQL and I'm pretty sure that there is a way to do the same here." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea, but I think it's better to just pass `duration` to the `create_pause` method.", "reference": "we should probably deprecate (and display a warning) the misspelled keyword arg here rather than removing it... and then add the new one. This changes a public API and will break any code that is currently using the misspelled version." }, { "prediction": "I think this should be `h2o_fatal`", "reference": "Should we do something like `h2o__fatal(file, line, \"fatal error: %s, %s\\n\", mess, RSTRING_PTR(...))` here?" }, { "prediction": "I don't think we need to skip flaky tests.", "reference": "is this one all platforms?" }, { "prediction": "I'm not sure why this change is needed, but I'm not sure why it's needed.", "reference": "why capitals grr?" }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do this. I'm not sure if it's the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "Surely all the above should go into `common`." }, { "prediction": "I'm not sure why this was removed.", "reference": "This is an unrelated change, but was failing CI... probably introduced in master." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "This piece isn't backwards compatible, but it's enough of an edge case that I think it's unlikely to be a problem." }, { "prediction": "I think this should be `MaxBatchByteSize: 10 * 1000 * 1000,`", "reference": "MB is presumably 1024 * 1024." }, { "prediction": "I don't think this is needed.", "reference": "Didn't we extract this logic to a `react-features` helper?" }, { "prediction": "I'm not sure why this was removed.", "reference": "But But, overlapping async writes will get corrupted" }, { "prediction": "I don't think we need to add this to the `go-filecoin/config.go` file.", "reference": "Not your immediate problem, but having everything depend on a package that has the config for everything else is ick. Can you move the MessagePoolConfig here and reverse the dependency?" }, { "prediction": "I think this test should be moved to `PasscodeActivityTest` as well.", "reference": "recently, IME_ACTION_GO action can trigger key_down and key_up event successfully, so we don't need to send enter key separately as before, otherwise will trigger it twice and cause to enter empty passcode, which cause test failed." }, { "prediction": "I think this should be `NG_RETURN_IF_ERROR(checkExprDepth(filter));`", "reference": "It seems that you only need to do this `checkExprDepth()` inside `deduceExprType()`. So you don't have to add this check everywhere." }, { "prediction": "I think this test should be `assert(mailCreator.createErrorEmail( executableFlow, message, azkabanName, scheme, clientHostname, clientPortNumber));`", "reference": "why split into two lines?" }, { "prediction": "I don't think we need to change this?", "reference": "Does this need to be public or can it be package-private?" }, { "prediction": "I don't think this is needed.", "reference": "Questionable way of looping through editors and calling `canEditFile` to show the edit button. Is there a better way?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "`that is null` doesn't sound very useful to me. Could we rename `that` to `target` or something less context dependent :)?" }, { "prediction": "I think this should be `print(x)` instead of `print(x)`", "reference": "Just to be consistent, can we use the print function `print()` instead of the keyword. Same goes for line 437." }, { "prediction": "I don't think we need this.", "reference": "Having to pass in `price` and `limit` is pretty common. Do we want to have this be another argument, maybe a combined structure that can be used for every action that requires it?" }, { "prediction": "I don't think we need to unbind events here.", "reference": "Could you move it after `stop`?" }, { "prediction": "I don't think we need to change the name of the body parameter. I think we should change the name of the body parameter to something more descriptive.", "reference": "The variable `method` seems not used. Maybe we can remove the parameter `bodyParamName` and generate it by invoking `ParamUtils.generateBodyParameterName(method)`?" }, { "prediction": "Why is this removed?", "reference": "I don't think this should be here?" }, { "prediction": "I'm not sure if this is the right place to call this function.", "reference": "Either I'm missing something or specs actors should remove this call cc @anorth" }, { "prediction": "I don't think this is needed.", "reference": "Please undo all these changes as they are white-space only." }, { "prediction": "I don't think this is needed.", "reference": "You forgot an optimization? `$countries = CountryField::FORMAT_ISO_3166_ALPHA3 === $countryCodeFormat? Countries::getAlpha3Names() : $countriesAlpha2;`" }, { "prediction": "I'm not sure about this, but I think it's better to use `\"current Python interpreter version (e.g., '3.8')\"` instead of `\"current Python interpreter version (e.g., '3.8')\"`", "reference": "Shouldn't this also return the current value specified by the user? At least that's what the docstring says and what the previous version did." }, { "prediction": "I don't think we need this parameter.", "reference": "> the time range the listen search the time range of the listen search?" }, { "prediction": "Do we need to set dynamo_preserve_zmm_caller_saved = true here?", "reference": "This snprintf, etc. needs to all be inside the DO_ONCE: all this overhead happening on every single decode is likely a huge performance hit." }, { "prediction": "I don't think we need this option.", "reference": "would call it connect_retries" }, { "prediction": "I don't think we need to test this. I think it's better to use `assert_eq` instead of `assertRaisesRegex`.", "reference": "Why are we using `repr`?" }, { "prediction": "I think this should be `ZMSImplFactory.getZmsInstance()` instead of `ZMSImplFactory.getZmsInstance()`.", "reference": "I use the same zms instance to check authentication in swagger endpoints. Same thing in ZTS." }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do here.", "reference": "Consider consolidating the common code in a common setup method in tests?" }, { "prediction": "I don't think we need to change this.", "reference": "q: do you need to run the annotation processor over EthProtocolConfiguration prior to writing this file? (i.e.to ensure ImmutableEthProtcolConfiguration exists)? Does Auto-import etc. still work in the IDE?" }, { "prediction": "I'm not sure if this is the right thing to do here. I'm not sure if it's the right thing to do here.", "reference": "What is the motivation for switching from `Schema` to `DiscoveryField` everywhere?" }, { "prediction": "I'm not sure if we should do this in a follow up PR. I'm not sure if we should do this in a follow up PR. I'm not sure if we should do this in a follow up PR.", "reference": "What happens when ECS Init/whatever's starting the Agent mounts some other directory as Agent's data directory (`-v /tmp:/data`) sets `ECS_HOST_DATA_DIR` to `\"/var/lib/ecs\"` It doesn't seem like a strong enough abstraction to be dependent on Agent configuration options to expect `ECS_HOST_DATA_DIR` to be the same as whatever's being mounted as `/data` on the host. My main concern is the late-binding/asynchronous failures this could lead to if the wrong host mount was specified. Wondering if there are better alternatives here. Can we at the very least inspect the Agent container and check if `ECS_HOST_DATA_DIR` is mounted? If the answer is that we'll revisit the validation here at some latter stage, that's fine too. But, I want us to be aware of potential failures here." }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `XCB_ERRORS` or `XCB_XCB_ERRORS` in the future. I'm not sure if it's a good idea to use `XCB_ERRORS` or `XCB_XCB_ERRORS` in the future, but if it's a good idea to use `XCB_ERRORS` or `XCB_XCB_ERRORS` in the future, it's a good idea to use `XCB_ERRORS` or `XCB_XCB_ERRORS` in the future. If it's a good idea to use `XCB_XCB_ERRORS` or `XCB_XCB_ERRORS` in the future, I'm not sure if it's a good idea to use `XCB_XCB_ERRORS` or `XCB_XCB_XCB_ERRORS` in the future.", "reference": "btw that's obviously out of scope of this PR but since i noticed this line here it reminded me a thing: on some systems i've noticed the font didn't had those characters, so it was just a square or empty space and sometimes they're just a bit shifted in position (if font doesn't have them and using from fallback font which have incompatible dimensions of characters) how do you think is it worth creating an issue to discuss/address it or it could just waste time on bikeshedding?" }, { "prediction": "I don't think this is needed.", "reference": "alias is not needed" }, { "prediction": "I don't think this is needed anymore.", "reference": "Do we need to include the path?" }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to change it.", "reference": "During our zoom and working on this, I said that I believe it was set to 64MB, not 32MB, but the diff shows that I was wrong. So we could change it back to 32MB." }, { "prediction": "I don't think this is needed.", "reference": "Here I thought you always insisted on ` log \"github.com/Sirupsen/logrus\" ` :) I might do a PR that just globally switches that out wherever we have log." }, { "prediction": "I'm not sure if this is correct. I'm not sure if it's correct or not.", "reference": "We maintain that each (logical) key generation has the same set of device keys, so no need to plumb through `keyGen`." }, { "prediction": "I don't think this is needed.", "reference": "Please use `from unittest import mock` instead of this package." }, { "prediction": "I think this should be `this.options.cursor` instead of `this.options.cursor`", "reference": "Should be `if (this.options && this.options.cursor) {`. Options may be undefined. Also, going forward, mongoose will always use curly braces around if blocks." }, { "prediction": "I'm not sure if this is the right thing to do. I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do.", "reference": "This should remain as mailrelay.blackducksoftware.com for staging. Not sure this will be valid, but it shouldn't go through the production mail server." }, { "prediction": "I don't think this is needed.", "reference": "Maybe we should have a Debug.Assert for when `Slab!= null` to ensure that we are always returning the block (in our tests at least)." }, { "prediction": "I don't think we need to delete the `defaultValue` property.", "reference": "Okay sorry about this I was really confused on how to support uncontrolled in this case, so what we want to do is apply `defaultValue` when `props.value` is falsy but not undefined, right? In the case of us seeing it is controlled (value & onChange present) we apply defaultValue to `props.value` (and delete props.defaultValue) In the case of uncontrolled we shouldn't enter this branch at all and go for full native dom behavior" }, { "prediction": "I don't think this is needed.", "reference": "`lodash` shouldn't be grouped under WordPress dependencies" }, { "prediction": "I think this label selector should be `OpenEBSLocalPVProvisionerLabelSelector` or `OpenEBSLocalPVProvisionerLabelSelector`", "reference": "The latest yaml in openebs/master has changed to name=admission-webhook. cc: @prateekpandey14" }, { "prediction": "Line is too long. [89/80]", "reference": "using **an** Amazon Simple... Simple Notification **Service** (singular)" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea, but I'm not sure if it's a good idea.", "reference": "Probably don't intend for this `1 ||` to still be here" }, { "prediction": "I'm not sure why this was removed.", "reference": "Looks like this is failing to compile on Windows (VS 2015 I think)." }, { "prediction": "I'm not sure if this is the right place to call this function.", "reference": "nit: call the arg something simple like `f` to avoid repeating \"beforeQuery\"." }, { "prediction": "I'm not sure if this is the right place to register the global hook. I'm not sure if it's the right place to register the global hook.", "reference": "do you think this should be `osd/auth` as a pkg to make it more unique and void conflicts with other `auth` packages?" }, { "prediction": "I don't think this is needed.", "reference": "Why are you passing out the Message?" }, { "prediction": "I'm not sure if this is the right place to unlock the `mu.Unlock()` call.", "reference": "Yikes, this was a bug :grimacing:" }, { "prediction": "I'm not sure if this is the right place to subscribe to the `Selectors` object.", "reference": "I am not sure which one of these is considered idiomatic go... maybe @azdagron has an opinion here? /me prefers the verb since it's shorter. I guess I don't care _too_ much, but it would be good to get some general agreement so we are all following the same conventions" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "Please check this for error and emit appropriate debugging information. I know this was pre-existing code, but we just have to fix things like this as we go." }, { "prediction": "I think this should be `if cond == nil || cond.Status == corev1.ConditionUnknown { unreachable = true return }`", "reference": "This seems unrelated, should be a separate PR." }, { "prediction": "I don't think this is needed.", "reference": "Never use relative includes, prefer full path" }, { "prediction": "I'm not sure if this is the right place to test this, but I'm not sure if it's the right place to test this.", "reference": "This should fit on the line above without going over the 79-char limit, no?" }, { "prediction": "I'm not sure if this is the right place to remove this stub.", "reference": "Is this related to the other contents of this pull request?" }, { "prediction": "I'm not sure if this should be `AddonsExtraParams` or `AddonsExtraParams`", "reference": "Should this be `*string`?" }, { "prediction": "I'm not sure why this was removed.", "reference": "In the old code here there was no Source Selector, but CreateDefaultProfile will specify a Source Selector of `\"\"`. Is that equivalent?" }, { "prediction": "Line is too long. [89/80]", "reference": "We should pick this across for all our deprecation specs" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Longer term, I think it could be valuable to move this to cluster-api, and then other repos could take advantage of this as well." }, { "prediction": "I'm not sure if this is the right place for this test, but I think it's better to move this test to a separate PR.", "reference": "Is this a related change?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "Given that this is repeated, can we do it outside here and the Create call, what do you think about moving it outside?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do it.", "reference": "Changing `prop`=>`col` by reference? I think you can prepare map `prop`=>`col` in L51." }, { "prediction": "I don't think this is needed.", "reference": "I hate to ask, but can we make this flag shorter so it lines up? :(" }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "Note to reviewers: latent, dedup import" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Seems this func is no more needed after your refactoring." }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `Steindorfer` or `Steindorfer` here.", "reference": "already added (see several rows below)" }, { "prediction": "I'm not sure if this is the right place to use wireguard.cali or wireguard.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali.cali", "reference": "nit: a switch perhaps?" }, { "prediction": "I'm not sure if we should change this to `true` or `false`?", "reference": "Great you caught this. Super critical to not retry these errors." }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "Just a little change to make the var effectively final, which is clearer." }, { "prediction": "I'm not sure if this is the right place for this change, but I'm not sure if it's worth it.", "reference": "Using `\"{}\".format(...)` is a bit beside the point..." }, { "prediction": "I'm not sure if this is the right place for this test, but I'm not sure if it's the right place for this test.", "reference": "I think these should remain as they are." }, { "prediction": "I'm not sure if this is the right place.", "reference": "Let's just call this PERF_PACKAGES and have them in the same format as WINDOWS/SLES/DEBIAN_PACKAGES constants - since it is only a single package and, as written, you'd have to update the code to add more package names anyway. Might as well be consistent with the rest of the code." }, { "prediction": "I'm not sure if this is the right place to get the taskPluginID.", "reference": "We don't have a `getPluginIDfromTaskIndex` function? I think it should be implemented in Globals/Plugins.h /.cpp" }, { "prediction": "I don't think we need lazy field loading here.", "reference": "@shalinmangar If lazy field loading isn't enabled, I don't think this actually changes the behavior of `SolrIndexSearcher`, since it was previously ignoring the fields list anyway. What it _should_ do is allow certain distributed queries, like the ones in `DistribJoinFromCollectionTest`, to co-exist with `SolrIndexSearcher#doc()` respecting the `fields` set instead of just discarding it." }, { "prediction": "I don't think this is needed.", "reference": "Should we be using version 3 now?" }, { "prediction": "I don't think this is the right place to do this.", "reference": "Would be better to throw a more specific exception, but for now it will do." }, { "prediction": "I don't think we need to remove this line.", "reference": "We should not replace Wei with a type that is shared across multiple units. We need this as `Wei` for type and unit safety." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "I'm pretty sure this should emit a util.Warning*(), since we're skipping by here and never hitting anything that will give them a warning about what's happened." }, { "prediction": "I think this should be `GetParserWithBuiltins(state *core.BuildState)`", "reference": "This function isn't useful? it's just a clone of GetParserWithBuiltins?" }, { "prediction": "Is cpuCircuitBreakerEnabled and memoryCircuitBreakerThresholdPct?", "reference": "I'm not sure if the boolean flags should always contain `is`, also I generally hate too long names... ;) we already know this is a section for circuit breakers, so the name doesn't have to repeat all of it. How about `cpuBreakerEnabled`, `memoryBreakerEnabled` etc?" }, { "prediction": "I'm not sure if this is the right place to add a rewrite that replaces one set of deletes with another that contains the same deleted rows. I'm not sure if this is the right place to add a rewrite that replaces one set of deletes with another that contains the same deleted rows. I'm not sure if this is the right place to add a rewrite that replaces one set of deletes with another that contains the same deleted rows.", "reference": "Before we start the replacing equality deletes with position deletes, I think we need to refactor the RewriteFiles API to adjust more cases: 1. Rewrite data files and remove all the delete rows. The files to delete will be a set of data files and a set of delete files, and the files to add will be a set of data files. 2. Replace equality deletes with position deletes, the files to delete will be a set of equality delete files (we will need to ensure that all delete files are equality delete files? ), the files to add will be a set of position delete files. 3. Merging small delete files into a bigger delete files. The files to delete will be a set of equality/position delete files, the files to add will be a set of equality/position delete files." }, { "prediction": "I don't think we need to use ActionView::Helpers::CacheHelper#cache here.", "reference": "Layout/TrailingWhitespace: Trailing whitespace detected." }, { "prediction": "I don't think this is needed.", "reference": "Is it possible that the shortcuts list is empty?" }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "This just changes the error message from `unable to save snapshot: [...] context canceled` to `canceled`." }, { "prediction": "I think this should be `HttpHeaders.CONTENT_LENGTH`", "reference": "maybe it's better to remove HttpHeaders.CONTENT_LENGTH after the loop" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Very cool. We are now collecting the fruits after your length implementation!" }, { "prediction": "I don't think we need to add this to the `rules.yml` file.", "reference": "Is this the same copy of the rules file from above? If so, can just use the copy from above, and this can be dropped." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this. I'm not sure if this is the right place to do this.", "reference": "Please break this into multiple lines." }, { "prediction": "I think we should move this line to `HttpContextHelpers.AddHeaderTagsFromHttpResponse(httpContext, scope);`", "reference": "Shouldn't this new line replace the few lines above?" }, { "prediction": "I'm not sure if this is the right place to put this in.", "reference": "Perhaps this belongs in universe?" }, { "prediction": "I don't think this is needed.", "reference": "there is a `kEpsilon` you can use directly." }, { "prediction": "I'm not sure if this is a good change.", "reference": "This should be grouped with the below imports, and the two separate groups of imports below should likely also be grouped together" }, { "prediction": "I don't think this is needed anymore.", "reference": "It looks like this error_code field is used to return a string to the caller, not just a const input string to be consumed as in the rest of this PR? If so, my personal preference would be to leave it as a std::string* instead of a reference; I don't know offhand what the VL coding style dictates." }, { "prediction": "I'm not sure if this is a good idea. I think it's a good idea to move this function into the MetaUtils::partPrefix() method.", "reference": "If return by value, then why bother to make it `static`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "You'll need to add docs for the argument, see e.g. the `debug_log_filter` docstring above." }, { "prediction": "I'm wondering if we should move this to the `sdktrace` package.", "reference": "`sdktrace` or `tracesdk`, pick one." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "can we return null instead?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to do this, but I'm not sure if it's a good idea to do this in a separate PR.", "reference": "You mean XXX and \"we should\" or \"NYI\" or sthg. Maybe put it on the ifdef line." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "minor: can be in-lined in return" }, { "prediction": "I'm not sure if this is the correct behavior.", "reference": "why the additional \"\\n\"?" }, { "prediction": "I'm not sure why this is needed.", "reference": "This seems to be a big omission. If the first buffer reports an error, stream seems to just discard it." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Maybe move this one down too?" }, { "prediction": "I don't think this is needed.", "reference": "We do this in lots of places I'm starting to notice...typically you'd avoid taking concrete dependencies, but we also avoid package dependencies as well which makes sense (i.e. not using an IoC, etc.). Any reason we don't implement some form of poor-man's DI and/or a simple factory instead of new-ing things up everywhere. This may be a simple example (as I'm guessing this is likely the only place this is ever or ever will be used), but separating them doesn't take any more time/effort either really." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "What if formatPrefix doesn't include a space? Will the resulting error have e.Error() stuck at the end without any space?" }, { "prediction": "I don't think this is needed.", "reference": "that doesn't say a lot to me. Can you please be more specific on the function of pushsync?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea, but I'm not sure if it's a good idea.", "reference": "> subpass uses a depth/stencil attachment in renderPass with a read-only layout for the depth aspect Assume - VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_STENCIL_ATTACHMENT_OPTIMAL - VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_OPTIMAL count as well seems there is a `NormalizeDepthImageLayout` for this" }, { "prediction": "I don't think we need to change this.", "reference": "This shouldn't be altered, you probably meant to update `AREA_PAGE_DASHBOARD_ALL_TRAFFIC` further below :)" }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "what does this change do exactly?" }, { "prediction": "I think this should be `context.Context` instead of `context.Context`", "reference": "What's the purpose of this `backgroundCtx` field?" }, { "prediction": "I think this should be `FirstContractIncarnation = 0`", "reference": "non contract incarnation" }, { "prediction": "I'm not sure if this is the right place to use `message['message']` or `message['message']`?", "reference": "I would recommend to leave out `None` because None is already the default." }, { "prediction": "I'm not sure if this is the right place to log this error.", "reference": "Should the \"bad hello message\" case above also disconnect?" }, { "prediction": "I think this should be `public static boolean fragmentEnabled = false;`", "reference": "Shouldn't this be in the child and not in the base plugin? Wouldn't having it here enable all derived plugins at once?" }, { "prediction": "I think this should be `--example-matches STRING`", "reference": "Should probably say REGEX or PATTERN rather than string." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea.", "reference": "I felt we don't need to set it that strict, like if somehow pubsub happens to allow extra 20 bytes for metadata, this test won't work. We would suggest to use 11MB instead." }, { "prediction": "I don't think we need to change this.", "reference": "In theory `isset($metadata['associationType'])` is `false` if the linked field is not an association field, isn't?" }, { "prediction": "Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "@tute the only thing I needed to enable this like as `password` is not in default flow anymore I think." }, { "prediction": "I don't think we need to change this test.", "reference": "nit: to be consistent with `self.members`, please move this up one line, so that it's closer to `allUsers`? You will need to update your test reference." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "we might as well just access `config.gClientVerbose` directly here. If any other options are passed to `gclientSync` or `gclientRunhooks` then the verbose option will be lost the way it's used now" }, { "prediction": "I think this should be `logging` instead of `logging`.", "reference": "Change the key to `default_tab` instead and I'll merge this" }, { "prediction": "Line is too long. [89/80]", "reference": "we still can end up passing a blank org_id to the scope method if for any reason the params is not present..." }, { "prediction": "I'm not sure if this is the right place to use enums. I'm not sure if this is the right place to use enums, but I'm not sure if this is the right place to use enums.", "reference": "I think yes, this makes sense to expose this. +1" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea.", "reference": "let us put the sample yaml snippet i.e. maya api server deployment that makes use of this env & value" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "What changed to cause this?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to rename the `StoreSession` function to `GetAll` or `GetAll` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync` or `GetAllAsync`", "reference": "Repeating big interface in many places shows smtg is wrong with design" }, { "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body beginning.", "reference": "Inheriting from `AccountsController` to get access to the `redirect_if_disabled` filter." }, { "prediction": "Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "Simple Storage **Service**" }, { "prediction": "I don't think this is needed.", "reference": "Enter at the end of the file! :-D (and at the end of lines ;-) )" }, { "prediction": "I think we should rename this column to `scheduled_for_cancellation_on`", "reference": "Put a comma after the last parameter of a multiline method call." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this. I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Don't you want to place this check before you add `succ` to `newSucc`?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Commit 676eeeab10884456a5f70ce708a8aa5116ecbaf7 contains a lot of unrelated code style changes. Please get rid of these." }, { "prediction": "I don't think this is needed anymore.", "reference": "Well this sucks, I wish you'd mentioned you were using a private API, perhaps we could have made a public one with better guarantees before `0.12.6` was released." }, { "prediction": "I'm not sure why this was removed.", "reference": "Consider instead moving this into an _test file so it's public but only usable in tests." }, { "prediction": "I'm not sure if this is the right place to log the state transition.", "reference": "Any reason why we want to remove this code? It helps debugging AWS ebs attach issues. Ideally yes a library should have minimal logging, but there is no way we can track long running AWS attach calls." }, { "prediction": "I don't think we need to add this to the `experiment_run` table.", "reference": "nit: indentation doesn't match (unfortunately i don't know of a way to automatically lint these sql statements with how we're using them currently)" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "Should we remove the other `setup_profiler` call site and just let this be the one call site for it, since, AFAIK, the other one is no longer necessary with this? Also, can we make `setup_profiler` private?" }, { "prediction": "I think this should be hidden.", "reference": "Are there any other templates where this command needs to be added, or were those issues specific to storage requiring us to enable a new command group?" }, { "prediction": "I'm not sure why this was removed.", "reference": "perhaps file can be removed altogether (trying to avoid an empty package for these build tags)" }, { "prediction": "I think this should be `if (!get_ldr_module_64(name, NULL, &mod)) return NULL; return mod.BaseAddress;`", "reference": "NULL change, could you move that out too?" }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do this.", "reference": "A brief explanation about this func is required." }, { "prediction": "I'm not sure if this is the right fix. I'm not sure if it's the right fix.", "reference": "Could you add description for below static function?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Since this is only counting the failed attempts, can you call it failedAttemptsCount or retryCount instead of attemptsCount?" }, { "prediction": "I'm not sure if this is the right place to import `os` or `pkg_resources`.", "reference": "I don't think this will work." }, { "prediction": "I don't think we need to expose the `IHttpRequestLineHandler` to the `IHttpHeadersHandler` class. I'm not sure if we need to expose it to the `IHttpHeadersHandler` class or if we need to expose it to the `IHttpHeadersHandler` class. I'm not sure if we need to expose it to the `IHttpHeadersHandler` class, but if we need to expose it to the `IHttpHeadersHandler` class, then we need to expose it to the `IHttpHeadersHandler` class.", "reference": "Since http2 is coming do we want to call this something more specific?" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "I don't think we want to revert the accessibility issues the tool caught, do we?" }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it.", "reference": "I prefer naming this rateLimitedRemoteHost This can be local host but reads remote Host Is Non Local." }, { "prediction": "I'm not sure if this is the right fix. I'm not sure if this is the right fix or if it's the right fix.", "reference": "Hmm I think I might've messed up this condition here... Need to look more at it" }, { "prediction": "I'm not sure about this, but I think it would be better to use `isinstance(package_stats, dict)` instead of `isinstance(package_stats, dict)`", "reference": "This also makes the exception to be raised on non-dict falsy values which I think was expected." }, { "prediction": "I think this should be `True` or `False`", "reference": "Is this correct? The auto indexing behavior caused problems fixed in a recently merged PR..." }, { "prediction": "I don't think we need to change this to `1.6.5, <1.9`", "reference": "Hmm, didn't we just find out that 1.6 *does NOT* work? We should bump the minimum as well." }, { "prediction": "I think this should be called `assert_internal` instead of `assert_internal`.", "reference": "Will calling `abort()` cause problems for our test suite?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "for my own edificaton, what's this?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "make it harmless to commit ws == nil" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `abs_out_exe` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_location` or `abs_out_", "reference": "Hmmmm, I'm not sure I like these becoming a replacement any build rule has access to. It seems like if it were used in an actual build rule it would only be doing bad things. Can we just use `filepath.Abs` on the returned path in run_step.go?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "That's actually not as bad as I thought it was going to be." }, { "prediction": "I think this method should be `public List findAllUnpublished()`", "reference": "Hmm, I'm surprised if we don't already have a \"find all unpublished datasets\" method but I don't really know. Maybe @scolapasta knows." }, { "prediction": "I think this should be \"Emitted when calling the super builtin with the current class\"", "reference": "The checks in this file are disabled by default since they are meant for Python 3 porting, and this one does not have to do with Python 3 porting at all." }, { "prediction": "I don't think this is needed.", "reference": "I would change \"should be sent\" to \"must be received\"." }, { "prediction": "I don't think this is needed anymore.", "reference": "Please put it in following way : `// DeleteStoragePool receives StoragePoolClaim delete event and calls the required handlers to delete other pool related resources.`" }, { "prediction": "I think this should be `cse.uploads.directory`", "reference": "It's better to use servicecomb now." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `defaultRenewBeforeExpiryDuration` or `defaultRenewBeforeExpiryDuration`.", "reference": "Make the flag derived default available in the readiness controller" }, { "prediction": "I think this should be `syncset pause` instead of `syncset pause`", "reference": "Confirmed this test fails when the fix is reverted" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This method is still possible insecure as it may archive not only logs files. I suggest to filter file names to ensure that they start with `.mysterium-log*`." }, { "prediction": "I don't think this is needed.", "reference": "DCN should not be able to use `init_cfg`." }, { "prediction": "I'm not sure if this is valid.", "reference": "It is a bit weird to see a message like \"something must be valid\"." }, { "prediction": "I think this should be `LOG.finest(\"Logging configured.\");`", "reference": "Again. This is part of the start up of the server, and the diagnostics are helpful." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do this.", "reference": "I think you need a `,` at the end of the line?" }, { "prediction": "I think this is not needed anymore.", "reference": "Please avoid wildcard imports." }, { "prediction": "I don't think this is the right place to do this.", "reference": "Did we consider making the timeout an argument to the build task? Would amke it easer to configure in the future: change a build property vs. rebuilding the DLL." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "dumb question: the commit message talks about dual-stack support but it seems that in a dual-stack cluster, Egress will only support the IPv4 address family?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Do you want to cherry-pick these separately and get them merged already or keep it in here? Both is fine with me!" }, { "prediction": "I think this test should be `checkAnalysisPerformance(\"en\", 1_000_000);`", "reference": "Hmm what are these magical constant numbers? And why does this change mean they should increase?" }, { "prediction": "I don't think we need this anymore.", "reference": "This change shouldn't be included with this push. Shouldn't push version changes with a pull-request." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "nit: let's move this right under where we create the `responseWriter`, before `h.callHandler`" }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "The way it was implemented, needed to pass the template values. Please check whether we want this." }, { "prediction": "I don't think this is needed.", "reference": "Just FYI we need this to align with `builtin.EpochDurationSeconds` from specs-actors or the state machine computations will be off. We'll need to turn this into a config option and follow the same monkey patching paths as the min miner size, seal proof types etc. The EpochDurationSeconds is currently a `const` so can't do it yet tho." }, { "prediction": "I'm not sure why this is needed.", "reference": "Is this import needed?" }, { "prediction": "I don't think this is needed.", "reference": "Dashboard stories also need to have the default padding." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "Is there a reason why we wouldn't use this as the default?" }, { "prediction": "I don't think this is needed anymore.", "reference": "if there is an tag of the same name?" }, { "prediction": "I don't think we need this anymore.", "reference": "I'd add `// +build go1.10` to prevent from accidentally compiling with older Go." }, { "prediction": "I don't think we need to import `safe_unicode` here.", "reference": "Not sure how this import relates to the PR but seems like a good idea anyway..." }, { "prediction": "I don't think this is needed.", "reference": "Hmm this is strange, why should the SettingsStruct import something from `WebServer`? If that's really needed, then we must move stuff as it makes no sense to have some code related to viewing things included in a settings struct. It should be the other way around." }, { "prediction": "I don't think this is needed.", "reference": "nit: Space between these lines." }, { "prediction": "I'm not sure if this is the right place to use translator, but I think it's better to use `Translator` instead of `Translator`.", "reference": "Why aggregator should have this translator? It's Selenium specifics for now..." }, { "prediction": "I think this should be `@private`.", "reference": "I don't understand why this function is needed? Can't you just pass the information when the `DocComparator` is created in the SortField?" }, { "prediction": "I don't think we need to rescue Gibbon::MailChimpError.", "reference": "This rescue is repeated exactly in `app/jobs/mailchimp_removal_job.rb`. Could we extract a method and pull it up into `MailChimpJob` for reuse?" }, { "prediction": "I think this should be `options.headers = options.headers || {}`", "reference": "It's not directly related to this PR, but it would be nice to flow the original error as we're going to print that if the promise is rejected and it'll be more informative than the vague `Network request failed`. Also, I'm not a js dev, so maybe I'm wrong, but throwing a TypeError feels a bit odd." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Can we print a debug message when this is used? Since it's a debugging variable, I wouldn't want users to have issues because of a left-over env." }, { "prediction": "I don't think this is needed.", "reference": "Should we have an avatar, truncate, etc examples, too?" }, { "prediction": "I think this is a breaking change.", "reference": "could you add this to `docs/source/reference/indexing.rst`?" }, { "prediction": "I'm not sure why this is needed.", "reference": "Why the change from rdkit.six to six?" }, { "prediction": "I think it would be better to use `requestOptions.get('localOnly')` instead of `requestOptions.get('localOnly')`", "reference": "Looking good, let's just move this inside the `if` to avoid doing the extra work if we don't need it." }, { "prediction": "I'm not sure if this is the correct behavior. I think it's better to use `expect(err).to.match(/This batch has already been executed, create new batch to execute/);`", "reference": "I think we should change this to an instanceOf check for MongoBatchReExecutionError" }, { "prediction": "I'm not sure if this is the right place to use `NewConverter` in the `ProfileDecoder` class. I think it's better to use `NewConverter` in the `ProfileDecoder` class.", "reference": "Required by the libcalico-go changes" }, { "prediction": "I don't think this is needed.", "reference": "Explain why we don't reuse the corresponding server error locally?" }, { "prediction": "I'm not sure if this is the right place to do this, but I think it's better to use `DateUtil.formatDate(this.releaseOrCreateDate)` instead of `DateUtil.formatDate(this.releaseOrCreateDate)` and then use `DateUtil.formatDate(this.releaseOrCreateDate)`", "reference": "@JayanthyChengan This change is still missing (and should be last one!): change this line to call getDateToDisplayOnCard(), that way the logic is in only one place (that method)." }, { "prediction": "I don't think we need this anymore.", "reference": "What was wrong with more concrete error?" }, { "prediction": "I don't think we need to add post/page slug to body_class() classes if it doesn't exist.", "reference": "can you replace the tabs with 2 spaces please to match the rest of the project?" }, { "prediction": "I think this should be `TimeSrc` and `TimeDst`", "reference": "Why are we adding it to the integral function?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Same for this file" }, { "prediction": "I don't think this is needed anymore.", "reference": "Looks good! But why it's still a out parameter? We can refactor the whole tree because it's internal?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.", "reference": "probably better to use `wlr_seat_keyboard_end_grab()`." }, { "prediction": "I think this should be `if (transaction.getChainId().isEmpty() &&!configuration.isUnprotectedTransactionsAllowed()) { return ValidationResult.invalid(TransactionInvalidReason.UNPROTECTED_TRANSACTION); } else if (transaction.getChainId().isEmpty() &&!configuration.isUnprotectedTransactionsAllowed()) { return ValidationResult.invalid(TransactionInvalidReason.UNPROTECTED_TRANSACTION); } else if (transaction.getChainId().isEmpty() &&!configuration.isUnprotectedTransactionsAllowed()) { return ValidationResult.invalid(TransactionInvalidReason.UNPROTECTED_TRANSACTION); } else if (transaction.getChainId().isEmpty() &&!configuration.isUnprotectedTransactionsAllowed()) { return ValidationResult.invalid(TransactionInvalidReason.UNPROTECTED_TRANSACTION); } else if (transaction.getChainId().isEmpty() &&!configuration.isUnprotectedTransactionsAllowed()) { return ValidationResult.invalid(TransactionInvalidReason.UNPROTECTED_TRANSACTION); } else if (transaction.getChainId().isEmpty() &&!configuration.isUnprotectedTransactionsAllowed()) { return ValidationResult.invalid(TransactionInvalidReason.UNPROTECTED_TRANSACTION); }", "reference": "Such a large test impact for such a little 3 line change ;)" }, { "prediction": "I think this should be `Transport[]` instead of `Transport[]`", "reference": "Is the `cascade` necessary? It should work also without the casdade, because Payments are always already persisted when use cases with them. If it doesn't work, please tell me the reason. It is as same in Transport." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "This is not very short. I'm not sure sure if there's a system for assigning shortcodes to issues." }, { "prediction": "I don't think we need this annotation.", "reference": "We should probably prefix this with `acme-http01` to bring it in-line with other annotations, e.g. `certmanager.k8s.io/acme-http01-edit-in-place`. It's quite wordy, but it *is* more specific (and I'd hope more obvious to the user what it is for?)" }, { "prediction": "I don't think this is needed.", "reference": "No need to add this file change for this PR. Please remove it." }, { "prediction": "I don't think we need to change this to `java.lang.String`", "reference": "this extra dot at the end is causing a couple tests to fail on Travis" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `str(kargs.get('iface') if 'iface' in kargs else conf.iface)` or `str(kargs.get('iface') if 'iface' in kargs else conf.iface)` or `str(kargs.get('iface') if 'iface' in kargs else conf.iface)` or `str(kargs.get('iface') if 'iface' in kargs else conf.iface)` or `str(kargs.get('iface') if 'iface' in kargs else conf.iface)` or `str(kargs.get('iface') if 'iface' in kargs else conf.iface)`", "reference": "Did you try using `global` with a regular integer?" }, { "prediction": "I don't think we need to change the size of the EdgeBasedEdge.", "reference": "windows size might be off" }, { "prediction": "I don't think this is needed anymore.", "reference": "This should still be guarded with an `#ifdef` since the DataMan code will only be supported for shared lib builds." }, { "prediction": "@hash[:affiliation].present?", "reference": "thanks for cleaning up these old length checks" }, { "prediction": "I'm not sure if this is the right place for this change, but I'm not sure if it's the right place for this change. I'm not sure if it's the right place for this change, but I'm not sure if it's the right place for this change.", "reference": "What will be logged when the `Input.Namespace` was not specified?" }, { "prediction": "I don't think this is needed.", "reference": "I wouldn't expose this until the feature is ready. We are most likely to cut releases while still in development" }, { "prediction": "I don't think we need to use `aria-query` here. I'm not sure if `aria-query` is the right name for `aria-query` or `aria-query`.", "reference": "I don't think we should pull aria-query into axe-core at this point. There's a much simpler fix for this. Please don't overthink it." }, { "prediction": "I don't think this is needed anymore.", "reference": "@ejsmith What if instead of making these two methods public we made it a partial class and moved them to a separate file so that file could be part of the include list? I bring it up just because I don't think it is a very nice API that was ever intended to be public? I think they are only called by a couple of other very internal-y spots. /cc @reyang" }, { "prediction": "I think this should be `new Trigger.TriggerBuilder(\"azkaban_sla\", \"azkaban\", triggerCond, expireCond, actions).build();`", "reference": "would be good to turn these into constants." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Seems like it should be `generated by Wire` here and in the SUT?" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "I know the main cases show up in the daemon test already but a little bit more unit test coverage would be nice and probably not too annoying to set up. Ideas: 1. Verify that the string \"no duplicates\" is in the LastDuplicate field when we propose a new deal. 2. Verify that proposing a duplicate deal fails when the duplicates boolean is set false. 3. Start out in a state with more than 1 duplicates. Verify that the LastDuplicate field is set to the last duplicate when we propose with a true duplicates bool." }, { "prediction": "I don't think we need to change the name of `timeoutMilliseconds` to `timeoutMilliseconds >= 0` or `timeoutMilliseconds <= 0` or `timeoutMilliseconds >= 0`?", "reference": "`Timeout.Infinite` is actually `-1`. Here the correct message can be taken from Line:67." }, { "prediction": "I don't think this is needed anymore.", "reference": "I think we need `#if!SILVERLIGHT` here and at the test." }, { "prediction": "I don't think this is needed anymore.", "reference": "Can you change this import to the apache dependency? I didn't even know that jgit contains such a method..." }, { "prediction": "I don't think we need to change the name of the service account.", "reference": "Four strings in a row makes me nervous, can we use an arguments struct instead? Or reuse the struct I recommend in the reconciler." }, { "prediction": "I don't think we need to do this.", "reference": "should work with no options, if my suggestion is accepted. JSON is the one that gets weird since a JSON object appended to a JSON object isn't valid JSON." }, { "prediction": "I don't think we need to change this to `check-streaming` or `check-streaming` or `check-streaming`?", "reference": "I presume this isn't some special term..." }, { "prediction": "I don't think we need to check if the heading length is greater than the paragraph length.", "reference": "Did you mean to return here? ;) You'll also need to add an `incomplete` message to the rule metadata." }, { "prediction": "I don't think this is needed.", "reference": "Why are we calling these as annotations? I guess this is an old type that we are re-using. But lets make it a point to avoid once we feel that this design/code is not good." }, { "prediction": "I think we should move this method to `RestClientSenderFilter` and call `onStartSendRequest()` in the `onFilter` method.", "reference": "`invocation.getInvocationStageTrace().startSend()` is inside `RestClientSender.send`" }, { "prediction": "I don't think we need to change this. I'm not sure if we need to change this.", "reference": "use \"actionHash\" to be consistent with other places" }, { "prediction": "I don't think this is needed.", "reference": "Can we derive `Class` by looking at one of the label choices, if at least one is always provided? Given these are immutable, a real-world case for an empty enumerations eludes me." }, { "prediction": "I'm not sure if this is the right place for this test.", "reference": "I am now confused here, the spec says > If format is VK_FORMAT_UNDEFINED, all members of samplerYcbcrConversionComponents must be the identity swizzle. The spec also says > samplerYcbcrConversionComponents is the component swizzle that **should** be used in VkSamplerYcbcrConversionCreateInfo. so you are allowed to set the swizzle to anything I want, so I guess this is valid usage here... but now I am more curious if I have an external format does it not have to follow any component swizzle rules and can be anything regardless of the `ycbcrModel`? (I guess really a question for @critsec and is not a blocking concern for the scope of this PR)" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I'd say the error should be an error, not instructions to the user. So error would be something like \"site should be running and is not\"" }, { "prediction": "I don't think we need this test anymore.", "reference": "Thanks for this PR @pinzon! Rather than resetting the `sms_messages` list, can we fix the assertion in line 902 - rather than asserting `len` equality, we should assert that all expected messages are contained in the list. (In this case the phone numbers should be reasonably random, and ideally we should not have duplicates across different tests). We're planning to introduce test parallelization in the near future, and this will help us avoiding undesired side-effects. Thanks" }, { "prediction": "I don't think we need to move this file to `github.com/mysteriumnetwork/node/client/stats/dto`", "reference": "Some weird blocks formation again." }, { "prediction": "I'm not sure if this is the correct behavior.", "reference": "This is worrisome." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea, but I'm not sure if it's a good idea.", "reference": "nit try rephrasing to something like \" AutoFilesystemTrimUsage returns the volume usage and trimmable space of locally mounted pxd volumes\"" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "currently the puppet-agent package doesn't symlink files into /opt/puppetlabs/bin. Also many puppet acceptance tests that execute on Unix assume puppetbindir is a single directory (windows doesn't have this issue). So I think if we want to unblock testing, this should just be changed to `h['puppetbindir'] = '/opt/puppetlabs/puppet/bin`" }, { "prediction": "I don't think we need this anymore.", "reference": "any point in keeping this here?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or not.", "reference": "I don't think we need this check. Instead `Entries.merge` should check that its argument is correctly sorted (in addition to the existing pre/post check on the method receiver)." }, { "prediction": "I'm not sure if this is needed.", "reference": "This is not really good to mix different code bases. @TheMarex I understand the point about placing code into cpp file, but we still need to move templated version into an impl header, remove references to offline code here and keep template instantiations in a cpp file to avoid rebuild. So offline code could instantiate own implementations using private impl headers. Otherwise we again make wrong dependencies into OSRM code and block changes in separate projects." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Then, where is it removed?" }, { "prediction": "I'm not sure if this is the right place for this test, but I'm not sure if it's the right place for this test.", "reference": "The tests are not run concurrently? (I don't know. Better check.)" }, { "prediction": "I think this should be `this.workspace_.scale` instead of `this.workspace_.scale`.", "reference": "Regardless of scale?" }, { "prediction": "I don't think this is needed.", "reference": "Nit: should not we hide them from printing out?" }, { "prediction": "I think this test should be `ImageToTensor` instead of `DefaultFormatBundle`.", "reference": "What is the reason to modify those things? I noticed it breaks the examples using `asyncio`" }, { "prediction": "I don't think we need to change this.", "reference": "WHOOOOOOOPS! so this is a wire protocol breaking change. I deployed a dev version of yarpc 1.9 to demo-yarpc-go and it caused bad request errors because it couldn't determine the procedure anymore. (in coordination with yarpc-prober)" }, { "prediction": "I don't think this is needed.", "reference": "if we keep this, can we stick to our convention of using UPPER_CASE for constants? Otherwise this looks like a floating variable to me." }, { "prediction": "I don't think this is needed.", "reference": "You probably don't want to assume that `self.underlayer` has a `seq` attribute." }, { "prediction": "I don't think we need this anymore.", "reference": "This apparently breaks the language selection." }, { "prediction": "This migration is added to circumvent issue #623 and have special characters in it.", "reference": "since we're not using mysql, do we need this migration?" }, { "prediction": "I'm not sure about this, but I'm not sure if this is the case. I'm not sure if it's the case, but if it's the case, I'm not sure if it's the case, but if it's the case, I'm not sure if it's the case. I'm not sure if it's the case, but if it's the case, I'm not sure if it's the case, but if it's the case, I'm not sure if it's the case.", "reference": "i'm not sure about htis naming here. both the word partition and adjustment are very ambiguous and it's not clear what it does. i would maybe go for something less generic and more concrete like `GOV_CLOUD_SUPPORT`" }, { "prediction": "I don't think this is the right place to use ConcurrentHashMap.", "reference": "unfinishedFlows might not be the same as activeFlows. Will it cause confusion here?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "Same, remove the error handling." }, { "prediction": "I don't think this is needed.", "reference": "We should not change this at this time." }, { "prediction": "I don't think this is needed.", "reference": "We may also update the docstring in the AnchorGenerator's arguments at around line 15." }, { "prediction": "I don't think we need to do this.", "reference": "FormatHandle isn't current typesafe w.r.t. requiring *VULKAN* handles... so this slipped through." }, { "prediction": "I don't think this is needed anymore.", "reference": "What kind of dependency is here, I think we have own implementation of event wo external dependencies" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "Throw an exception instead" }, { "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do it. I'm not sure if this is the right way to do it, but if it's the right way to do it, I'm not sure if it's the right way to do it. I'm not sure if it's the right way to do it, but if it's the right way to do it, I'm not sure if it's the right way to do it. If it's the right way to do it, I'm not sure if it's the right way to do it, but if it's the right way to do it, I think it's the right way to do it. If it's the right way to do it, I think it's the right way to do it.", "reference": "we shouldn't need the `FactoryBot.` in these. Ok to leave for now since all of these specs have them. Can clean up later" }, { "prediction": "I think this should be `Storage::url($uploadsPath). '/';`", "reference": "Isn't the better option to actually do `$this->getDisk()->url($uploadsPath)` without changing the filesystems config? Not sure why you think that change is required but it's definitely not getting merged." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do this, I'm not sure if it's the right place to do this.", "reference": "Not sure if we need this. It's not tested because it only guards against a new conditional definition of a dunder method in a built-in package. I am fine with leaving it out." }, { "prediction": "I don't think this is needed.", "reference": "Is this the only task in this library? If so this is good, if not then we should do it for each task." }, { "prediction": "I don't think we need to change this.", "reference": "I am not sure what is 120 and what is 10. Hence unable to review." }, { "prediction": "I think this should be `EnableDNS` or `EnableDNS`", "reference": "Not needed anymore" }, { "prediction": "I don't think pingpong exposes RTTs. I'm not sure if pingpong exposes RTTs, or if pingpong exposes RTTs, or if pingpong exposes RTTs, or if pingpong exposes RTTs, or if pingpong exposes RTTs, or if pingpong does not expose RTTs.", "reference": "Please not abbreviations" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it. If it's the right place to do it, I'm not sure if it's the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it. If it's the right place to do it, I'm not sure if it's the right place to do it. If it's the right place to do it, I'm not sure if it's the right place to do it. If it's the right place to do it, I'm not sure if it's the right place to do it. If it's the right place to do it, I'm not sure if it's the right place to do it. If it's the right place to do it, I'm not sure if it", "reference": "This shouldn't get stomped over on line 207" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "are they not 1-indexed?" }, { "prediction": "I don't think we need to change this.", "reference": "I know that previously this check was here but @ralph-pichler replaced it with the `CheckTimestamp` field stating that checking against `Timestamp` was incorrect. @ralph-pichler can you elaborate?" }, { "prediction": "I don't think this is needed.", "reference": "`short_version = __version__`" }, { "prediction": "I don't think we need to update the status of an access key for an AWS Identity and Access Management (AWS IAM) user. I don't think we need to update the status of an access key for an AWS Identity and Access Management (AWS IAM) user. I think we need to update the status of an access key for an AWS Identity and Access Management (AWS IAM) user. I don't think we need to update the status of an access key for an AWS Identity and Access Management (AWS IAM) user. I don't think we need to update the status of an access key for an AWS Identity and Access Management (AWS IAM) user.", "reference": "AWS Identity and Access Management (IAM)" }, { "prediction": "I don't think we need to change this class.", "reference": "Required for the SparkDataFile SerDe" }, { "prediction": "I think this should be `return!in_value.IsBaseClass();`", "reference": "Do you want to make this an assertion instead?" }, { "prediction": "This file is not covered by the GNU General Public License.", "reference": "When updating the copyright, we tend to cover previous years, not just the current. So, if we started the file in 2015, we'd update to say 2015-2016. I'm not sure if there's a legal requirement surrounding this, but it's the convention we and many others have adopted for code." }, { "prediction": "I think this should be done in a separate PR.", "reference": "Wait, so it looks like this function is called _every_ time we fetch the root node, i.e. we do an MD head fetch every time we fetch the root node? Not for this PR, but it seems like we should make that unnecessary, since this function only ever does anything when head is `nil`, i.e. the first time. Maybe add a TODO?" }, { "prediction": "I'm not sure why this change is needed.", "reference": "Why are you changing this?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or not.", "reference": "`json.RawMessage` is a `[]byte`, which is already a pointer. Why do we need to have pointer here if we just reading this value?" }, { "prediction": "I'm not sure about this, but I think it would be better to use `Version.GetFullVersionWithRuntimeInfo()` instead of `Version.GetFullVersionWithRuntimeInfo()`.", "reference": "should we actually switch to `All` or just add `0.4.0` explicitly to the list of supported CNI versions? What is a new CNI version is released?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea, but if it's a good idea, it's a good idea to move it up to the `google.cloud.security.common.gcp_type`.", "reference": "pylint might complain that this isn't alphasorted?" }, { "prediction": "I don't think we need to enable-certificate-errors here.", "reference": "It seems that NetworkService is behind a feature flag because it's still experimental. If we see new issues, we should look at flipping this back off." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "I think it makes more sense to have this be a method on TaskStatus. Also, nit, Backend, not BackEnd." }, { "prediction": "I think this should be `HIPInternal::impl_get_instance_id()`", "reference": "Could you please elaborate on why you need all this magic here? In which cases do you want the same id to be returned? Does this work the same way for all backends?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "nit: `PluginConfigs` feels a little better" }, { "prediction": "I'm not sure if this is the right place for this test. I'm not sure if it's the right place for this test.", "reference": "think we need to find out the root-cause and fix, instead of just removing `NoError`? it erred b/c `context canceled`, so call this before context cancelled is the right fix" }, { "prediction": "I think this should be `go dbc.Put(ctx, tlfID, buf, serverHalf)`", "reference": "Please expand \"later behavior\". Presumably something to do with the prefetch logic?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "The `response` variable is not used, it can be removed, also the fmt.Errorf." }, { "prediction": "I think this should be `return value?.Length > 0? string.IsNullOrEmpty(value.Trim()) : true;`", "reference": "Do you find this really easier to read?" }, { "prediction": "I don't think this is needed.", "reference": "A small nit: This variable should start with a lower case letter." }, { "prediction": "I'm not sure if this is the right place for this change, but I'm not sure if it's the right place for this change, or if it's the right place for this change, or if it's the right place for this change, I'm not sure if it's the right place for this change, or if it's the right place for this change, or if it's the right place for this change, I'm not sure if it's the right place for this change, or if it's the right place for this change, or if it's the right place for this change, or if it's the right place for this change, I'm not sure if it's the right place for this change.", "reference": "Where is this used for Node?" }, { "prediction": "I don't think we need to change this.", "reference": "Is `` really easier to understand than `` for CLI user? For me, `identity` seems like a concept we use publicly, and `id` is just an internal shortcut for it." }, { "prediction": "I don't think we need to do this. I'm not sure if we need to do this.", "reference": "nit.. `if`.. `else` for logging probably can be avoided.. maybe only log that an internal group was created for cluster group" }, { "prediction": "I don't think this is needed anymore.", "reference": "There's a lot of changed tests -- but no new tests. You need unit and integration tests for this." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "WithMessage what gas limit is?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Why are these skipped?" }, { "prediction": "I'm not sure if this should be `Enable` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug`` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug` or `Debug`", "reference": "We'd better add the `json:\"metaServer,omitempty\"` here" }, { "prediction": "I don't think this is needed. I think it's better to use `sys.executable` instead of `sys.executable`.", "reference": "So... when we want to install mitmproxy with pinned dependencies, we first install all pinned dependencies, and then in a second step install mitmproxy as editable, making sure that no additional dependencies are sneaking in." }, { "prediction": "I think this should be `err!= nil`.", "reference": "not sure how this got in master, but the linter is unhappy about it so I fixed it here" }, { "prediction": "I'm not sure if this is a good idea.", "reference": "No need for this TODO anymore, right?" }, { "prediction": "I don't think we need to include `kinto.plugins.default_bucket` and `kinto.plugins.default_excludes` here.", "reference": "I would assign the key you're looking for into a variable first, and then use it in the comparisons." }, { "prediction": "I'm not sure if this is the right place to remove the plugin from our internal container.", "reference": "Would be better to normalize it at the start of the method to pass through to all the other calls" }, { "prediction": "I think this should be `$this->parentForm->model->isSafeMode()`", "reference": "This can't exist here either because the code editor can be used on other models than CMS templates. You could probably implement this as a `hint` property (so `hint: cms::lang.cms_object.safe_mode_enabled`) on the codeeditor formwidget instead though and I'd be fine with that." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, it's the right place to do it.", "reference": "This line is unnecessary." }, { "prediction": "I'm not sure why this was removed.", "reference": "How did this compile in the first place? Is there a matching declaration in a header that should be removed too?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Please remove the colon at the end, and merge the PR once the CI succeeds. Thank you for the PR." }, { "prediction": "I don't think we need this anymore.", "reference": "whoops. this should be protoc-gen-doc, since that is the only bit left that is built out-of-tree (everything else is either downloaded or built via modules already depended on by spire's go.mod)" }, { "prediction": "I think this interface should be `AZKABAN_EVENT_REPORTING_ENABLED`", "reference": "The convention is to use

    see the google style guide and use checkstyle to check. You can change it later." }, { "prediction": "I'm not sure if this is the right place to use `self.item_marker` or `self.list_marker`.", "reference": "Using non-keyword args after the keyword arg (parent-self) will cause a SyntaxError." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it.", "reference": "I think you'll want to add some YARD docs to this method to get the PR approved" }, { "prediction": "I don't think this is needed.", "reference": "Hmm, AFAICT `*out_variant` isn't explicitly set to `NULL` in the `ENOENT` case." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Nit: \"Failed to configure TLS for SDK client\"?" }, { "prediction": "I don't think we need to change this test.", "reference": "please update your branch to the latest `master`. This change was already made in #4359" }, { "prediction": "I don't think this is needed.", "reference": "This line should be formatted" }, { "prediction": "I think this should be `block_processor_batch_max_time`", "reference": "\"default 65536\" Not sure if it's important to state, but block_processor_full_size has a different default for fast_bootstrap." }, { "prediction": "I'm not sure if this is needed.", "reference": "remove unnecessary whitespace changes" }, { "prediction": "I'm not sure why this was removed.", "reference": "Are these conditions covered elsewhere?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "the above check (by transitivity) checked for `in_data.name_id == out_data.name_id && in_data.name_id!= EMPTY_NAME_ID && out_data.name_id!= EMPTY_NAME_ID`. The final check of `out_data.name_id!= EMPTY_NAME_ID` is missing now." }, { "prediction": "I don't think this check is needed.", "reference": "The event handle is being passed by reference, so the dereference on 591 is actually correct. To follow the convention that variables be declared before executable statements, please change the code to the following: struct _fpga_event_handle *_eh; fpga_result result = FPGA_OK; int err = 0; if (!event_handle) { return FPGA_INVALID_PARAM; } _eh = (struct _fpga_event_handle *) *event_handle;" }, { "prediction": "I'm not sure if it''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''", "reference": "reorder includes to be alphabetically ordered" }, { "prediction": "I think this should be `need_unmap=True`", "reference": "Rename `need_unmap` to `unmap`." }, { "prediction": "I don't think this is needed anymore.", "reference": "In line 28, it has been declared twice, so removing `cm` should not impact, can you explain me little bit? :)" }, { "prediction": "I'm not sure if this is the right place to acquire topology cache lock. I'm not sure if it's the right place to acquire topology cache lock.", "reference": "i don't think these unexported functions belong on the public interface, they can exist solely on the struct." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I'm not entirely clear on why this is necessary?" }, { "prediction": "`cast` should be `cast`", "reference": "Why do we need to cast to `str` here?" }, { "prediction": "I think this test should be removed.", "reference": "The ignore import above should be unused now and can be removed." }, { "prediction": "I don't think this is needed.", "reference": "redundant null check?" }, { "prediction": "I'm not sure if this is the right thing to do here, but I'm not sure if it's the right thing to do here.", "reference": "initialization of available ram is here" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Can have negative numbers with the '-' on the right (`10-`) by just using line 610." }, { "prediction": "I don't think we need to change this file.", "reference": "AWS Identity and Access Management (IAM)" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Shouldn't we use store a message which indicates that there was no available checker command? By the way how is it possible that metadata.json doesn't contain the checker command? Maybe this was the case in the earlier versions?" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "Given that this is a boolean predicate, maybe it should be `full_backtrace?`." }, { "prediction": "I don't think this is needed anymore.", "reference": "Just curious why the blank line here?" }, { "prediction": "I don't think this is needed anymore.", "reference": "I like the idea, but we don't want a dependency on mitmproxy in pathod." }, { "prediction": "I don't think we need to do this. I'm not sure if we need to do this, but I'm not sure if it's worth it.", "reference": "Why not adding this to the interface and keep passing the interface (as the interface is internal I don't get why you're not adding it there)" }, { "prediction": "I'm not sure if this is the right place to import `PY310_PLUS` or `PY310_PLUS`", "reference": "`PY310` should probably be imported from `pylint.const`" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `GetSerialConsoleOutputValue(key)` or `GetSerialConsoleOutputValueAsBool(key)` or `GetSerialConsoleOutputValueAsBool(key)` or `GetSerialConsoleOutputValueAsBool(key)` or `GetSerialConsoleOutputValueAsBool(key)` or `GetSerialConsoleOutputValueAsBool(key)` or `GetSerialConsoleOutputValueAsBool(key)` or `GetSerialConsoleOutputValueAsBool(key)` or `GetSerialConsoleOutputValueAsBool(key)` or `GetSerialConsoleOutputValueAsBool(key)` or `GetSerialConsoleOutputValueAsBool(key)` or `GetSerialConsoleOutputValueAsBool(key)` or `GetSerialConsoleOutputValueAsBool(key)` or `GetSerialConsoleOutputValueAsBool(key)` or `GetSerialConsoleOutputValueAsBool(key)` or `GetSerialConsoleOutputValueAsBool(key)` or `GetSerialConsoleOutputValueAsBool(key)` or `GetSerialConsoleOutputValueAsBool(key", "reference": "Can we propagate this error up the stack?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Why reference is converted to table?" }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "You shouldn't use assert for runtime errors." }, { "prediction": "I don't think this is needed.", "reference": "Does this really belong in the vendor directory if you wrote it? At very least, should it get its own repo somewhere in addition to being dropped here?" }, { "prediction": "I think this test should be `SampleXPathRule` instead of `SampleXPathRule`", "reference": "I think it would be better to place the rule name before the message. Messages are of varying lengths and the rule names will end up misaligned" }, { "prediction": "I think this should be \"Logical tautology in comparison\" or \"Logical tautology in comparison\".", "reference": "Can we remove the argument from this message? A message will include a line number already that points to the place in the code that has the problem. I think we can remove it." }, { "prediction": "I don't think this is needed anymore.", "reference": "This whole class is now a mix of virtual and non-virtual. I tried to see what would happen if I made everything non-virtual in dev, and the build still passes. It turns out that none of the other methods actually need to be virtual. Can you make *all* the logging methods either virtual or not for consistency? Thanks." }, { "prediction": "I don't think we need to add this flag to the `mysterium.network` field.", "reference": "This looks a bit cryptic to me, and also it contains a dash. How about `mymysterium.url`?" }, { "prediction": "I don't think this is needed.", "reference": "You did notice the no newline at the end of this file, right?" }, { "prediction": "I don't think we need to change the name of `CodeFlows` to `CodeFlows`.", "reference": "Here's the object model change. `CodeFlows` is a set of objects of type `CodeFlow`, rather than a list of list of `AnnotatedCodeLocation`. Exactly parallel with `Stacks`." }, { "prediction": "I don't think this is needed.", "reference": "Sorry, one more thing... You should use `app.config` instead of importing it directly. See the code below." }, { "prediction": "I think this should be `void close()`.", "reference": "This was correct before; \"setup\" is a noun and \"set up\" is the verb form." }, { "prediction": "I'm not sure if we should change the value of `getAccounts()` to `getAccounts()` or `getAccounts()`", "reference": "What's the reason for this change here? I didn't see it mentioned in the PR and it's a bit of a confusing param name" }, { "prediction": "I don't think this is the right place to do this, but I think it's better to use `this.storage.config.localList.get().map( function(q) { return this.storage.config.localList.get().map( function(package) { return { ref: package, score: 1 }; } )`", "reference": "I wonder why ~ and not a wildcard instead?" }, { "prediction": "I don't think this is the right place to do this.", "reference": "when will this happened? if happened, just ignore it Silently?" }, { "prediction": "I think this should be `5672/6408 bytes`", "reference": "3x the smaller size would be around 17k, and we need it to be at least about 13k, which is 2x the larger size. I'd probably set this to 15k to split the difference and hopefully avoid needing to update this again as tests change. This is minor, though." }, { "prediction": "I don't think this is the right thing to do here.", "reference": "@scottpurdy, strictly speaking, should this scenario raise a ValueError exception instead of AssertionError?" }, { "prediction": "I'm not sure if this is the right place to put this enum, but I think it's better to put it in a separate file.", "reference": "Can you please add open source disclaimer?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I dont want to do composite keys on purpose to verify at compile time if the message is completely filled out appropriately @sectioneight" }, { "prediction": "I don't think this is needed.", "reference": "don't need this line, since it is not tested in api_test?" }, { "prediction": "I don't think this is needed.", "reference": "Does this mean the list operation is done for all the namespaces? How to list the volume replicas per namespace?" }, { "prediction": "I don't think we need to copy nms_cfg_ in batched_nms.py?", "reference": "I suggest adding `class_agnostic` as an argument of `batched_nms()`, with the default value False." }, { "prediction": "I don't think this is needed.", "reference": "@rdblue, did we not add the name on purpose?" }, { "prediction": "I don't think we need this anymore.", "reference": "Why is this now public?" }, { "prediction": "I'm not sure this is the right place to do this, but I think it's better to have a `@search_context_response = response.total` and then use `@search_state.reset(current_search_session.query_params).to_hash` to reset the `search_session['total'] = response.total` to reset the `@search_session['total'] = response.total` to reset the `@search_session['total'] = response.total` to reset the `@search_state.reset(current_search_session.query_params).to_hash` to reset the `@search_session['total'] = response.total` to reset the `@search_state.reset(current_search_session.query_params).to_hash` to reset the `@search_session['total'] = response.total` to reset the `@search_state.reset(current_search_session.query_params).to_hash` to reset the `@search_session['total'] = response.total` to reset the `@search_session['total'] = response.total` to reset the `@search_session", "reference": "I guess we should backport some deprecation for this?" }, { "prediction": "I'm not sure if this is the right place to remove the `path_for` method. I'm not sure if `path_for` is the right place to remove the `path_for` method, but I'm not sure if it's the right place to remove the `path_for` method. If it's the right place to remove the `path_for` method, I'm not sure if it's the right place to remove the `path_for` method. If it's the right place to remove the `path_for` method, I'm not sure if it's the right place to remove the `path_for` method. If it's the right place to remove the `path_for` method, I'm not sure if it's the right place to remove the `path_for` method. If it's the right place to remove the `path_for` method, I'm not sure if it's the right place to remove the `path_for` method.", "reference": "Moving this code inside the last case statement doesn't seem right. Why are we defining `name` and `is_relative` variables there if we aren't using them anywhere?" }, { "prediction": "I'm not sure if this is the right place to use DR_REG_##reg, but I think it's better to use DR_REG_##reg instead of DR_REG_##reg. I'm not sure if this is the right place to use DR_REG_##reg, or if it's the right place to use DR_REG_##reg, or if it's the right place to use DR_REG_##reg, or if it's the right place to use DR_REG_##reg, or if it's the right place to use DR_REG_##reg, or if it's the right place to use DR_REG_##reg, or if it's the right place to use DR_REG_##reg, or if it's the right place to use DR_REG_##reg, or if it's the right place to use DR_REG_##reg, or if it's the right place to use DR_REG_##reg.", "reference": "I would say just change REGARG: no need for a separate thing." }, { "prediction": "I don't think this is needed.", "reference": "we can remove this template, it is no longer in use" }, { "prediction": "I'm not sure if we should remove this line. I'm not sure if we should remove it.", "reference": "This doesn't look like it has as much coverage of the recursive code as it once did." }, { "prediction": "I don't think we should add this to the `aws_load_balancer_spec.go` file.", "reference": "Do we actually expect users to provide more information here than possibly a SecurityGroup ID? If not, then this should probably use a new type, otherwise users might be confused by what options would be respected/ignored when used in this context." }, { "prediction": "I don't think this is needed.", "reference": "This seems like a new dependency on rometools. Do we need it?" }, { "prediction": "I'm not sure if this is the right place to log this message.", "reference": "Waiting for the pull takes a long time. This message informs the user that at least one of the images being pulled is available. Please leave." }, { "prediction": "I'm not sure if this is a breaking change.", "reference": "I can not think in a good use for it, but may we allow a way to setup a fake with a hook for logs? this fake is special, and we may need access to some of thoe logs, at the same time it may be an overkill because we dont want to test \"sql\" implementation but results.. but we can create some tests with end to end logs in some scenaries, What do you think about it?" }, { "prediction": "I don't think this is needed.", "reference": "I don't think you should be changing the dag unilaterally at parse time. If cores isn't specified, then it isn't specified." }, { "prediction": "I don't think we need to do this. I don't think we need to do this.", "reference": "Instead of just \"See SubscriberOptions....\", say something like \"Use... to choose between the two.\"" }, { "prediction": "I don't think this is needed.", "reference": "Use with statement for `f`" }, { "prediction": "I'm not sure if this is the right place for this test.", "reference": "It's a small style point, but could you remove the \"extra\" space before the colon that precedes the return type? This would make it more closely match the prevailing style in these tests and in the standard libraries." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this. I'm not sure if it's the right place to do this.", "reference": "seems clunky to me to have an `MDOps` interface method that some implementations don't implement. Perhaps define a separate interface, like, `BranchResolver`, and then callers that have an `MDOps` object can check via type assertion?" }, { "prediction": "`T extends WebElement` should be `T extends WebElement`.", "reference": "This change should also probably go into the corresponding method of the abstract By class?" }, { "prediction": "I don't think this is needed.", "reference": "File is not `gofmt`-ed with `-s` (from `gofmt`)" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This is likely to return an error value if the client fails to read the response we write, which is why I chose to ignore this error." }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do.", "reference": "this method is not used" }, { "prediction": "I think this should be `self.load_finished.emit(ok)` instead of `self.title_changed.emit(ok)`", "reference": "Right now it's a bit unclear that this needs to be called explicitly by the implementing class. If, for example, there's another backend, it won't get this update unless we add the same function as webkit. Could you either add a note to this docstring explaining that this needs to be called, or find some way to automatically trigger this so the webkit override isn't needed (and some override passed on webengine)." }, { "prediction": "I'm not sure if this is the right place to test this.", "reference": "Why this change (test name still says \"must pass with metadata\")?" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for this, and if it's the right place for this, I'm not sure if it's the right place for this, or if it's the right place for this, but if it's the right place for this, I'm not sure if it's the right place for this, or if it's the right place for this, or if it's the right place for this, but if it's the right place for this, I'm not sure if it's the right place for this, or if it's the right place for this, but if it's the right place for this, I'm fine.", "reference": "Another nitpick: parens around the arg pretty please" }, { "prediction": "I'm not sure why this was removed.", "reference": "This spec can be modified, giving you extra strength (Check this fetch key doesn't work and therefore returns `nil`)" }, { "prediction": "I think this should be `caddy_rewrite_original_uri`", "reference": "Oh, I guess I mentioned/pressed this point in the other issue, that this should probably go into the httpserver package. In fact, so should the const above this (URLPathCtxKey). These are specific to the HTTP server." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "Not added by you, but we don't really need the '5' here.." }, { "prediction": "I'm not sure if we should remove this.", "reference": "The vendor prefix is still being used on Chromium based browsers like Edge Chromium and Chrome. Did you mean to remove this?" }, { "prediction": "I think this should be `_(\"Emulates pressing %s on the system keyboard\", emuGesture.displayName)`", "reference": "I don't think this is needed anymore?" }, { "prediction": "I think this should be a helper function, not a helper function.", "reference": "This is the only occurrence I see in the code where we now need to convert from a boolean protobuf wrapper to a boolean pointer. This felt a little cumbersome here; should we consider moving it somewhere else as a helper function?" }, { "prediction": "I'm not sure why this was removed.", "reference": "Need you to delete the `version_` from `HostInfo` struct?" }, { "prediction": "I don't think this is needed.", "reference": "This could be the cleanest looking check we've got. Great job Jey." }, { "prediction": "I don't think we need to check for `' == $url` here.", "reference": "Who invited yoda? In all seriousness though, wouldn't an `if (empty())` be better here?" }, { "prediction": "I'm not sure if this is the right place to use `window.location.href = 'index.html';` or `window.location.href = 'index.html';`", "reference": "You can use `appRouter.goHome` to do this (It's defined in site.js), it's less hacky than overriding the href." }, { "prediction": "I'm not sure if this is the right place to remove the part.", "reference": "When could this happen?" }, { "prediction": "I don't think this is needed anymore.", "reference": "I assume this was removed because it was redundant? and conflicted with the now dynamic contentType? Edit: Oh I see it being set was moved to the `PostSegmentAsync` call." }, { "prediction": "I don't think we need socks here. I think we should add a `ProxyConfig socks(String host, int port, String username, String password)` to the `ProxyConfig` class.", "reference": "Here is a newline missing" }, { "prediction": "I'm not sure if this is the correct URL.", "reference": "Did you mean to make this http rather than https?" }, { "prediction": "I don't think this is needed anymore.", "reference": "The updated copyright header should be: # Copyright (C) 2006-2018 NV Access Limited, yourname" }, { "prediction": "I think this should be `$performanceTestSample = $performanceTestSamplesOfUrl as $performanceTestSample;`", "reference": "wow :+1:, i do not even know how this test works." }, { "prediction": "I don't think this is needed anymore.", "reference": "File should be renamed `PlugIn` -> `Plugin`" }, { "prediction": "I don't think this is needed.", "reference": "I scanned the new test cases quickly. Do we have one for an egressIPPool with multiple different IP ranges?" }, { "prediction": "I don't think this is needed.", "reference": "you can use a different name, like `maybe_activate` or `is_active` without `component` in the method name as this is used in the class name. E.g: `$component->should_component_be_active` is using twice the `component` word" }, { "prediction": "I don't think we need to check for `ret.options && ret.callback` here.", "reference": "I think this might not be a complete enough check: what if `options` is `null`/`undefined`?" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this.", "reference": "Useless assignment to variable - `user`." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I think we would want to keep `-O` instead. I wonder how this worked before, though." }, { "prediction": "I don't think this is needed.", "reference": "another alternate option which doesn't have the risk of too many entries (when user keeps providing keys in different order) Have the dictionary as before If tagKeys lookup fail, sort and lookup again. If fails, insert both original tagKeys and its sorted one to the dictionary. So that we only store atmost 2 entries per key set. And we only do a single lookup in hotpath, as opposed to 2 look ups." }, { "prediction": "I think we should move this function to the `Plan::updateSymbols` method.", "reference": "if (out!= nullptr)" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this. I'm not sure if it's the right place to do this, but I'm not sure if it's the right place to do it.", "reference": "In the listenstore you catch the exception and then pass it on via Raise. However, here you do not catch the exception. You should catch the exception, but since this is a minor aspect of this page, perhaps show an error message when the count cannot be loaded in time. Then the rest of the page can still be rendered, rather than failing the whole page." }, { "prediction": "I don't think we need transfer here.", "reference": "wouldn't it be simpler to just add `or transfer` here? That way the more complicated set of conditionals down below don't have to get more clauses." }, { "prediction": "I don't think this is needed anymore.", "reference": "ditto; please fix everywhere" }, { "prediction": "I'm not sure if this should be `true` or `false`.", "reference": "Can you break this line into two parts - the first line makes the option help text for `--sftp-server` and its too long! `Specifies the path or command to run a sftp server on the remote host. The subsystem option is ignored when sftp_server is defined.`" }, { "prediction": "I don't think this is needed anymore.", "reference": "I reverted that one in a previous PR because of a CI failure but it was actually unrelated" }, { "prediction": "I think this should be `if len(latestVersion)!= 0 { return err }`", "reference": "The for loop is useless here, since any error will make the function return." }, { "prediction": "I think this test should be moved to the `test_utils.py` file.", "reference": "Fix file endings here and elsewhere." }, { "prediction": "I don't think we need to change this. I think we should change this to something like \"Backoff ended for %.128s\" or something like that.", "reference": "I'd better increase `buf` length to MAXPATHLEN and not cut p->get_project_name() output twice" }, { "prediction": "I think this should be `fmt.Printf(\"here it is: %s\", err)`", "reference": "Please remove the prints, even though this code will be trashed." }, { "prediction": "I don't think this is needed anymore.", "reference": "Not sure if you added deliberately but I've seen these popping up; is goimports adding them?" }, { "prediction": "I don't think we need to change this. I think we need to change this to `nolint dst.Spec.NetworkSpec.VPC.AvailabilityZoneSelection = restored.Spec.NetworkSpec.VPC.AvailabilityZoneSelection`", "reference": "I think we might need some special handling for `Spec.ControlPlaneLoadBalancer.SecurityGroups`, it looks like we are currently only handling the case that `Spec.ControlPlaneLoadBalancer` is nil." }, { "prediction": "I don't think this is needed.", "reference": "Is this from a third-party library?" }, { "prediction": "I don't think this is needed.", "reference": "Please put the `el.tabIndex > -1` in the first part of the expression. The matcher will run on every node on the page, so we should put the fastest part first." }, { "prediction": "I don't think this is needed anymore.", "reference": "`identity` is unused now, is it for future usage?" }, { "prediction": "Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "This would have assisted me a lot! I am on the \"functions\" page more than any other page in the docs" }, { "prediction": "I don't think we need to encode the module name here. I think we should encode the module name with `module_name.encode('ascii')` or `module_name.encode('ascii')`", "reference": "I think it's better we keep `(` and encode with default encoding (utf-8)." }, { "prediction": "I think this should be `java.trimTrailingWhitespace();`", "reference": "this is gonna be different in an IDE vs from gradlew??" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Do we not already have something for isolating syntax?" }, { "prediction": "This file is part of Invenio. I think it should be `2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013, 2013,", "reference": "1: D100 Docstring missing 4: I102 copyright year is outdated, expected 2014 but got 2012 158: D103 Docstring missing 168: D101 Docstring missing 170: D102 Docstring missing 180: D102 Docstring missing 187: D102 Docstring missing" }, { "prediction": "Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "how **to** deny" }, { "prediction": "I don't think we need to add this to the `Http1AndHttp2ExperimentSwitch` class.", "reference": "The only beef I have with this is that it's app domain global." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Can you link to the GitHub issue and/or PR so that it is easy for future readers to find out more about this?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Typical to report the value found as well as the valid bounds." }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to have a `transactionLastValidRound` variable that stores the last valid round.", "reference": "maybe we want 0 as a default value?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "can we get height from sf at very beginning of the function and use that as height of the block?" }, { "prediction": "I don't think this is needed.", "reference": "Does this have to be public and in the primary namespace?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it.", "reference": "I'm a bit confused. Doesn't `mdWriterLock` already synchronizes calls to this function?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but I'm not sure if it's the right place to do it.", "reference": "Does it make sense to generate a dailyMotion url without the video reference? It does not to me, but can we throw an exception here?" }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "Why the separation of imports here?" }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "Random extra newline." }, { "prediction": "Do we need to call `dom.getFocusableElements()` here?", "reference": "No need for this variable." }, { "prediction": "I think this should be `_format_msg(msg: str)` or `_format_msg(msg: str, abort_on: abort_on)`", "reference": "Why not use `msg` directly below?" }, { "prediction": "I think this should be `@SuppressWarnings({\"checkstyle:IllegalType\", \"checkstyle:VisibilityModifier\"})`", "reference": "I think other places changed to use `Deque` instead of suppressing the warning." }, { "prediction": "I don't think this is needed.", "reference": "missing: utility, cstddef also: vector is already included in the header (interface requires vectors as in/out types)" }, { "prediction": "I don't think this is needed.", "reference": "I'm not sure this is necessary in the config here, as Jest would be setting the global `fetchMock = ''`. See below." }, { "prediction": "I don't think this is the right thing to do.", "reference": "Can `mFolder == null` happen during regular operations? Or is it only so we can be lazy in tests?" }, { "prediction": "Align the elements of a hash literal if they span more than one line.", "reference": "I'd suggest using the actual MIME types here - so `text/plain` and `multipart/alternative` or does that cause problems with what postgres allows for enumeration names? If so then maybe just replace the slash with an underscore?" }, { "prediction": "I don't think this is the right place for this.", "reference": "Ohh. `TeamName` is actually a \"friendly\" name displayed in the Catalog - not the name used in the CLI. So I guess we'll need a new variable here. (That is, this is going to be mainly a `quilt.yaml` change. You won't need the `.lower()`, though.)" }, { "prediction": "I don't think we need to backup this file.", "reference": "Nit: Don't move it between `require_dummy_response` definition and usage, this can live above or below :)" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to add a fallback endpoint to the block service. If it's a good idea to add a fallback endpoint to the block service, then we'll need to add a fallback endpoint to the block service. If it's a good idea to add a fallback endpoint to the block service, then we'll need to add a fallback endpoint to the block service. If it's a good idea to add a fallback endpoint to the block service, then we'll need to add a fallback endpoint to the block service. If it's a good idea to add a fallback endpoint to the block service, then we'll need to add a fallback endpoint to the block service.", "reference": "With the current code, it not work if `EnableCatchupFromArchiveServers` is disabled. to fix it: in getDNSAddrs, change the predicate to `if wn.config.EnableCatchupFromArchiveServers || wn.config. EnableCatchupFromArchiveServers {` and in the catchup/service.go and catchup/catchpointService.go, use the `PeersPhonebookArchivers` only when `wn.config.EnableCatchupFromArchiveServers` is enabled." }, { "prediction": "I'm not sure this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Why not make `SearchForNodes` do a `GetOrCreate` for the root node? (Not advocating for it, but just wondering if there's another reason than avoiding having to pass in the path.)" }, { "prediction": "I'm not sure if this is the right place to start dns daemons. I'm not sure if this is the right place to start dns daemons. I'm not sure if it's the right place to start dns daemons, but if it's the right place to start dns daemons, I'm not sure if it's the right place to start dns daemons or if it's the right place to start dns daemons.", "reference": ":+1: amazing that this has been missing since it was originally implemented" }, { "prediction": "I think this should be `return file.toInputFile().getLength()`", "reference": "Just want to note here that although we do check `length` while writing to choose whether to close and start a new file, that doesn't happen for ORC already so it is fine to use a FS call in this method." }, { "prediction": "I'm not sure if this is the right fix.", "reference": "nit: I feel multiple `if (...) { return... }` is more readable than `if... else...`." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This is needed for us to work in IDE UTs" }, { "prediction": "I'm not sure if this should be `starred_only` or `starred_only` or `starred_only` or `starred_only` or `starred_only` or `starred_only` or `starred_only` or `starred_only` or `starred_only` or `starred_only` or `starred_only` or `starred_only` or `starred_only` or `starred_only` or `starred_only` or `starred_only` or `starred_only` or `starred_only` or `starred_only` or `starred_only`", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "this `label=` is docker specific, while here in libcontainer there shouldn't be any mention to docker. `DisableSecOpt` and `DupSecOpt` should just deal with `disable,role,type,level`. Both CRI-O and docker should just pass `disable,role,type.level` stuff and not `label=...`." }, { "prediction": "I think this should be `recurse` or `recurse`", "reference": "You need to declare variable `recurse` above, same place as `localTime`." }, { "prediction": "I'm not sure if this is the right place to use `element.xdensity` or `element.ydensity` or `element.xdensity` or `element.ydensity` or `element.xdensity` or `element.xdensity` or `element.ydensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xdensity` or `element.xd", "reference": "Why does `clone` not already copy `xdensity` and `ydensity` from what it is cloning?" }, { "prediction": "I don't think we need to check for null here.", "reference": "Curious - do we do the same for traces (when no ActivitySource / legacy source are added)? (and why we want to do it for metrics?)" }, { "prediction": "I don't think this is needed anymore.", "reference": "@aimanrosli23 For the changes in file SdMmcPciHci.c, please make sure that you do not revert the changes made by the below commits: SHA-1: 49accdedf956f175041040e677163b7cbb746283 * MdeModulePkg/SdMmcPciHcDxe: Hook SwitchClockFreq after SD clock start SHA-1: c67617f3c677c342efde780e229f841f4e0f6c7e * MdeModulePkg/SdMmcPciHcDxe: Add retries for sync commands SHA-1: 6d387610855ee27b49cb720de29ed809ea59dadc * MdeModulePkg/SdMmcPciHcDxe: Read response on command completion SHA-1: 63fd7f389874081ea37452b1f79ac013d52755e3 * MdeModulePkg/SdMmcPciHcDxe: Do not map memory for non DMA transfer" }, { "prediction": "I don't think this is needed.", "reference": "You'll also need to add `webelem.Group.all` everywhere as that matches as well" }, { "prediction": "I'm not sure if this is the right place to enable bank account field when BA80 is selected. I'm not sure if this is the right place to enable bank account field when BA80 is selected. I'm not sure if it's the right place to enable bank account field when BA80 is selected, but if it's the right place to enable bank account field when BA80 is selected, then it's the right place to enable bank account field when BA80 is selected. I'm not sure if it's the right place to enable bank account field when BA80 is selected, but if it's the right place to enable bank account field when BA80 is selected, then it's the right place to enable bank account field when BA80 is selected. If it's the right place to enable bank account field when BA80 is selected, then it's the right place to enable bank account field when BA80 is selected. If it's the right place to enable bank account field when BA80 is selected, then it's the right place to enable bank account field when BA80 is selected. If it's the right place to enable bank account field when BA80 is selected, then", "reference": "Does this need to be an ERB template?" }, { "prediction": "I don't think this is needed.", "reference": "do we want to register this in the mock server for testing?" }, { "prediction": "I don't think we need to change this test.", "reference": "shouldnt this be `0:996` (+4) so the 1000s below fit?" }, { "prediction": "I don't think this is needed.", "reference": "The docstring of this context_manager should be updated. As now ``sort=False`` is valid, it should just say it disables sorting regardless of whether the NdMapping has ``sort=True`` or ``sort=False``. I also think the line 'Should only be used if values are guaranteed to be sorted before or after the operation is performed.' should just say something else - maybe just that the initial ordering (whatever it is) should be preserved?" }, { "prediction": "I don't think we need to change this test.", "reference": "This tests failed unless I swapped the order here. Perhaps some new class transform broke the old form?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "extract the port and set to `debug_java_port`" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it.", "reference": "When the argument list is `[\"one\", \"two three\"]` then you concatenate it as you do it here, you won't be able to get the original list back with split. You need to annotate the list items better. (Or if you won't do the split by yourself, the called shell will do it. So you need shell escaping. How portable is that?) The main driver to change this in `intercept-build` was to get rid of these concatenation and splitting errors. The current compilation database parser in Clang understands the `arguments` filed... So the question, why don't you pass the command around as a list instead of a string?" }, { "prediction": "I'm not sure if this is the right place to call this function.", "reference": "`ctx` is unused in EnablePiped" }, { "prediction": "I don't think we need to pass `authenticated` to `__init__`?", "reference": "Why do we have both a list of valid sessions and an instance variable if a session is destroyed?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "nit : I think that it would be \"cleaner\" to set the `flushcount` to nil in case of an error nice catch ;-)" }, { "prediction": "I don't think we need this test anymore.", "reference": "You may want to use assertNull" }, { "prediction": "I don't think this is the right place for this test.", "reference": "Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs." }, { "prediction": "I'm not sure why this was removed.", "reference": "Why did you remove this?" }, { "prediction": "I don't think this is the right place to log the error.", "reference": "Why we need another error printouts? We already have it inside addMapping.." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "This LGTM, but I'm curious if this fixed a specific error you were hitting?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Actually we rely on this functionality in cgroup v2, where the subsystem is empty." }, { "prediction": "I'm not sure if this is the right place for this test.", "reference": "suggestion: use `core` package name" }, { "prediction": "I don't think we need to change the default value here.", "reference": "I think we can entirely remove this `limit` parameter for now to be consistent with other APIs." }, { "prediction": "I'm not sure if this is the right place to start moto server, but I'm not sure if it's the right place to start moto server, or if it's the right place to start moto server, or if it's the right place to start moto server, or if it's the right place to start moto server, or if it's the right place to start moto server, or if it's the right place to start moto server, or if it's the right place to start moto server, or if it's the right place to start moto server, or if it's the right place to start moto server.", "reference": "nit: `Resource Groups Tagging API` -> `Resource Groups API`" }, { "prediction": "I'm not sure if it''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''", "reference": "This type of list + delete always make me a bit uneasy but guess there's no atomic way to do this...... Could you put a todo to retry the \"ClearRepository + delete repo\" flow a few times? Basically, imagine a new image is added right after we call `ListImages`, then `DeleteImages` will not delete that newly added image. Then the delete repo call will fail" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for this, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, I'm not sure if it's the right place for it, or if it's the right place for it, or if it's the right place for it.", "reference": "You can remove this since ES6 modules are strict by default. And thanks for contributing to the Jellyfin Project." }, { "prediction": "')\"(((( ( ( ( ( ( ( ( ( ( ( ()))))))))))))))))))))))))))))))))))))))", "reference": "Why did eip1559 go from a list (0xf9020280.....) to a wrapped string (0xb902060ff9020280...) and not just concatenation (0x0ff9020280...)? implementation detail or is this how it sits on the wire now?" }, { "prediction": "I think this should be `include_bad_conf_check_b.conf:10:19: unknown field \"monitoring_port\"` instead of `include_bad_conf_check_b.conf:10:19: unknown field \"monitoring_port\"`", "reference": "@wallyqs Since on Windows it would be `\\` instead of `/` I just look at the suffix past `configs/`. Let me know if that's ok or not." }, { "prediction": "I don't think we need this. I think we should add a `Matrix` field to the `InsightResultType_MATRIX` model.", "reference": "nit: Remove this assignment because it is not necessary." }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to use `glnx_openat_rdonly` instead of `glnx_openat_rdonly`.", "reference": "This seems like a common enough pattern to offer an equivalent wrapper in `ot-fs-util.c`, no?" }, { "prediction": "I don't think this is the right place to do this.", "reference": "Wouldn't this crash the app if the user is currently listening to a stream?" }, { "prediction": "I think this should be `!strings.HasSuffix(directory, \"/\")`", "reference": "This looks like an unrelated change? What is it for?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but I'm not sure if it's the right place to do it.", "reference": "Wait, what is this doing? Is this a way to create methods that are only accessible from tests?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Is it more reasonable to return some errors here, such as returning error codes (403 and so on?)?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Thinking out loud... would `_nextDom` be a better name for this?" }, { "prediction": "I'm not sure why this was removed.", "reference": "Turns out the unittests also had a false positive." }, { "prediction": "I don't think we need this method anymore.", "reference": "I think these method names would be clearer if written as \"Create a {type} counter|gauge|measure with given name\". eg \"Create a int64 counter with given name\" \"Create a double gauge with given name\"" }, { "prediction": "I think this should be `nullptr`", "reference": "it pushes a boolean, so it has to be explicitly casted to boolean with!= nullptr, same with all other similar stuff" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it.", "reference": "It would be nice to have an equivalent of this call on `DataWriterImpl::enable`" }, { "prediction": "I think this should be `Status: model.ChainBlockStatus_DEPLOYMENT_BLOCK_RUNNING, StartedAt: time.Now().Unix(), })`", "reference": "Isn't this PENDING?" }, { "prediction": "I'm not sure about this, but I think it's better to use `!axe.commons.text.sanitize(node.getAttribute('title') || '')` instead of `!!axe.commons.text.sanitize(node.getAttribute('title') || '')`", "reference": "minor detail, why aim to sanitize title if tile is empty (in some cases)? worth adding an && to check for that." }, { "prediction": "I don't think this is needed anymore.", "reference": "Code shared by ParentChildrenSyncDownTarget and ParentChildrenSyncUpTarget moved to ParentChildrenSyncTargetHelper" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "The bug is not about the priority, But we use 2 config items CAPACITY and SEQUENTIAL to control 1 action: thoughput. If'sequential' is given to 'False' as default in configfile and then I use 'capacity' to 10 in my test.yml, the 'capacity''s priority should be higher than default'sequential'. So, I suggest we use only one 'capacity', it is enough. '1' is sequential, more than 1 is capacity, None is sys.maxsize." }, { "prediction": "I'm not sure if this is the right place for this test, but I'm not sure if it's the right place for this test.", "reference": "I don't know if I'd call any of these FAST tests integration tests. They are unit tests for FAST. They use a mock plugin which doesn't actually start any external processes, etc." }, { "prediction": "I'm not sure if this is the right place to call this function, but I think it's better to call it `CurrentVersion()` and then call `CurrentVersion()` with the `CurrentVersion()` argument.", "reference": "Can you provide corresponding UT for this." }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "nit: this should be below the yarpc group" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "singleCaseSwitch: should rewrite switch statement to if statement (from `gocritic`)" }, { "prediction": "I'm not sure if this is the right place to start Typha connection. I'm not sure if it's the right place to start Typha connection, but if it's the right place to start Typha connection, then it's the right place to start Typha connection.", "reference": "Please log once here at Error level \"Failed to connect to Typha, will retry...\"" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "Do we need the forXDP parameter in runBpfUnitTest? If not, I think better to revert in order to save a few changes." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use a regex here, but I think it's a good idea to use a regex here.", "reference": "So we fix it only for kinto and not for all cliquet resources?" }, { "prediction": "I don't think this is needed anymore.", "reference": "No empty line between" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "We have `ResolveRootfs` in `libcontainer/utils` so maybe use that one here?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Just curious, do we have positive test covered somewhere?" }, { "prediction": "I think this should be `if (serial == 0)`", "reference": "Style error, put a space between `if` and `(`" }, { "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to make this `EnableEndpointDiscovery` optional. I'm not sure if it's a good idea to make it optional.", "reference": "It's a bit odd to have a \"disable\" boolean, though it looks like you already do that for a few other flags." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea.", "reference": "Why did you pick two hours for this?" }, { "prediction": "I'm not sure about this change, but I think it's a good idea to change the behavior of the `NewPassword` function.", "reference": "What about \"enter new password\"? That would be a bit more consistent to the `ReadPasswordTwice` usage in cmd_init." }, { "prediction": "I don't think this is needed anymore.", "reference": "Another redundant import" }, { "prediction": "I'm not sure if this is the right place to release the stream.", "reference": "What kind of errors might cause us to reach this point? Could any of them be recoverable i.e. might work if we asked the same server again? Similar question for below, but perhaps with a slightly different answer" }, { "prediction": "I don't think this is needed anymore.", "reference": "What is the difference between GraphType and graph_type. Naming should be more accurate." }, { "prediction": "I don't think this is needed anymore.", "reference": "hmmm in docblock of contructor it is EntityManagerInterface....maybe it should be that way.... :confused:" }, { "prediction": "I'm not sure if this is the right place for this function, but I'm not sure if it's the right place for this function.", "reference": "I'm curious why you went the route of adding a new method name for this. Given that you it would be possible to just have an an overload of `GetPos()`, and that this change breaks existing code, I wonder why you chose to go this way." }, { "prediction": "I don't think we need to do this. I think we should add a `statusLabel` property to `subscription.statusLabel` so that we don't have to change the value of `statusLabel`.", "reference": "Does this need to change `'active'` to `'Active'` and that? Or is that done in CSS or something?" }, { "prediction": "I don't think this is needed.", "reference": "Why are these constants public? They should also be listed above members." }, { "prediction": "We have to fix the v value if this is a private transaction.", "reference": "This TODO isn't related to this change. We should remove it." }, { "prediction": "I don't think we need this PR anymore.", "reference": "`FieldMetrics` is parameterized, but this is a bare reference. Could you update it? I think it should be `FieldMetrics` since the metrics are not necessarily for the written value type, `D`." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do it.", "reference": "@cijothomas do we want this to be `Set` or `Add`?" }, { "prediction": "I don't think this is needed.", "reference": "Why are we dropping GasCap?" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for this, or if it's the right place for it, or if it's the right place for it, I'm not sure if it's the right place for it.", "reference": "should we end the text with a.?" }, { "prediction": "I think this is not the right place to do this.", "reference": "Could this instead keep the `go_native` and add to it \"or the last exit was the special reset exit\"?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Oh, I missed this one: The other instances of `this` you've added as lambda contexts aren't really needed, although they're harmless. However, in the above connection, the missing context is `panel`, not `this`. Please correct it! Clazy may show warnings about lambda contexts (I don't use Clazy) but, if so, that's a problem in clazy: it isn't smart enough to know about them." }, { "prediction": "I'm not sure why this was removed.", "reference": "can we add a try / except around this to make it more stable? I like the idea of any mistakenly un-quit drivers closing down after the process is quit (the java server does this... also i forget to do driver.quit often when i use the command line repl :) )" }, { "prediction": "I don't think we need this check.", "reference": "when would this happen? backward compatibility?" }, { "prediction": "I don't think this is needed.", "reference": "I'm not sure what the value of this is. So far we've solved this by always doing `tagName.toUpperCase()` for everything. I think we should stick with this." }, { "prediction": "This command displays status of available snapshot. This command displays status of available snapshot.", "reference": "This command displays available snapshots on a volume." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "`spb` is the standard package name we use for this proto." }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if this is the right thing to do.", "reference": "/javascript/firefox-driver is the Selenium implementation of a WebDriver for Firefox. Since it generally isn't W3C compatible, it shouldn't change. We can just drop this change." }, { "prediction": "I'm not sure if this is the right place to upgrade to parallel process.", "reference": "is this pr support parallelly process application?" }, { "prediction": "I don't think this is needed.", "reference": "Based on the assumption that when `EnablePulls` is `true`, `CanEnablePulls` must be `true` as well, then this `if` check is redundant. Actually... we have `AllowsPulls` now... why not use that?" }, { "prediction": "I don't think this is needed.", "reference": "I am not sure why the API requires both project name and project ID as inputs. Wouldn't it introduce more opportunities for clients to make mistakes?" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "I believe this was happening for several different flash messages - should we add `now` to all flash messages? (there might be a downside to doing that, but I am not sure what it would be)" }, { "prediction": "I think this should be `@inheritdoc` instead of `@inheritdoc`.", "reference": "There is no docblock on the parent method. Also, not related, but I forgot to typehint the `$templating` constructor argument above." }, { "prediction": "I think this should be `if runtime.GOARCH == \"arm64\" { t.Log(\"Skipping php5.6 test on arm64 because deb.sury.org packages do not include it currently\") } else { t.Log(\"Skipping php5.6 test on arm64 because deb.sury.org packages do not include it currently\") }`", "reference": "Silly me. This shouldn't be done in the tests, but instead in the actual definition of ValidPHPVersions on arm64. Same with Mysql and MariaDB." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "Shouldn't this work as well for Disjoint?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "You've not updated the `o.Status.Reason = fmt.Sprintf(\"Failed to retrieve Order resource: %v\", err)` line below here when you changed this, so here we are checking `errUpdate` but will print the contents of `err` instead." }, { "prediction": "I don't think this is needed.", "reference": "Doesn't this need to include `Errno::ECONNRESET` to fix the issue?" }, { "prediction": "I think we should rename this constant to something more descriptive. I think it's better to rename it to something more descriptive.", "reference": "Please consider keeping the config key in one line as it will help in case someone is looking at how this config is used. public static final String PROJECT_CACHE_THROTTLE_PERCENTAGE = \"azkaban.project_cache_throttle_percentage\";" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `ListPowerSelectorEntries` or `ListPowerSelectorEntries` here.", "reference": "This is a hard one, naming-wise... `ListPowerSelectorEntries` is logical given `ListSelectorEntries`. Another option could be `ListMatchingEntries` or even `FindMatchingEntries`. :shrug:" }, { "prediction": "I'm not sure if this is the right place to use `uint` or `uint64` or `uint32` or `uint64` or `uint32` or `uint64` or `uint32` or `uint32` or `uint64` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32", "reference": "This should be called `Uint` or `Uint32` or simply using our `Uint64` type instead. All of our numbers have varint encoding. It's not inherently a varint." }, { "prediction": "I don't think this is needed.", "reference": "No need for this when you don't need to customize anything about the argument." }, { "prediction": "I'm not sure if this is the right place to move this away from using ID attr.", "reference": "We're now going to have 3 `#sections_accordion` will need to see how JS behaves. We should probably switch to a class selector instead" }, { "prediction": "I think this should be `t.timestamps null: false`", "reference": "did you mean to leave this in here?" }, { "prediction": "I'm not sure if this flag is used anywhere else. I think it should be `false` or `true`.", "reference": "Mention that it only applies to Windows. This is kind of implied, but better to be explicit." }, { "prediction": "I don't think this is needed.", "reference": "again: it is a bad practice to have some global parameters with such common names for unit test purpose." }, { "prediction": "I don't think we need this anymore.", "reference": "Should we use `\\DateTimeInterface` or `DateTimeInterface` and declaration of `DateTimeInterface` in `use`?" }, { "prediction": "I'm not sure if this is the right place to use it.", "reference": "What do you think of moving this stack related constant to the `stack` pkg?" }, { "prediction": "I'm not sure if this is the right place to check for rekeying. I'm not sure if this is the right place to check for rekeying, but if it's the right place to check for rekeying, I'm not sure if it's the right place to check for rekeying. If it's the right place to check for rekeying, I'm not sure if it's the right place to check for rekeying, but if it's the right place to check for rekeying, I'm not sure if it's the right place to check for rekeying, but if it's the right place to check for rekeying, I'm not sure if it's the right place to check for rekeying, or if it's the right place to check for rekeying.", "reference": "Hm, I guess that you're doing this here since `WellFormed` is on a `transactions.Transaction` and not a `transactions.SignedTxn`, but quickly grepping through our code, it looks like we always a `SignedTxn` around when calling `WellFormed` (except maybe some tests?)... this doesn't have to happen here, but maybe we should update that in a separate PR since this really feels like a `WellFormed` check." }, { "prediction": "I don't think this is needed.", "reference": "This story also needs the default padding." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "Hmm why did we remove the randomness about which (confusingly) different exception to throw here? This randomness was (is?) useful to help test that Lucene indeed catches `FNFE` and `NSFE` interchangeably." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Hm, so before in that case `current_collection_id` looks like it was actually an uninitialized pointer. It seems weird to me that the tests pass both ways. I haven't looked closely at the tests - is there something wrong there that causes this to spuriously pass before?" }, { "prediction": "I don't think this is the right thing to do.", "reference": "s it the best way to tag \"foo\" of \"`define foo...\" with constant kind? Introducing \"d/definition\" kind and tagging the \"foo\" with the definition kind is an alternative way. Using the unified kind \"constant\" in many areas reduces the information that client tools get from a tags file. In my experience, it is better to tag different things with different kinds. If ctags hides the differences, and just reports various language objects as \"constant,\" in some cases, a client tool must parse the raw.sv source file for distinguishing whether a given tag is \"`define\"'ed or not. IMHO, ctags should not be too smart. Instead, ctags should be stupid; it should report what it sees in source input files as-is to client tools that will do something smart." }, { "prediction": "I'm not sure if we should remove this line.", "reference": "is this a breaking change? If I'm not mistaken, this is translating a user-provided `wtimeout` in the connection string into `wTimeoutMS`" }, { "prediction": "I don't think this is needed.", "reference": "Can we rename this file to `lambda_echo.py`, to be more descriptive and in line with the other files in this directory? (all files in this folder are lambda functions, after all)" }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.", "reference": "why not do it like this?

     const ( Kill Action = iota Errno Trap Allow Trace ) 
    "
        },
        {
          "prediction": "I think this should be `this.appenders[i] == null`",
          "reference": "lock(this) is a bad practise, since you lock the entire instance. cosider: var appenderCache = xxxx. lock(appenderCache) { Thread.Sleep(TimeSpan.FromHours(5)); } while inside AppenderCache instance lock(this) { is blocked 5 hours. } Its always better to make a class private lock objects."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.",
          "reference": "should we use the constant above?"
        },
        {
          "prediction": "I don't think this is a good idea.",
          "reference": "I think something like `size_res` would be more descriptive."
        },
        {
          "prediction": "I'm not sure about this, but I'm not sure if it's a good idea to use `value` or `value_error` or `value_output` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message` or `metrics_message`` or `metrics_message` or `metrics_message`",
          "reference": "Oh lol so this was...really more of a bug?"
        },
        {
          "prediction": "I don't think this is better than using 2",
          "reference": "Well, it is providing a platform neutral way of calling Task or TaskEx. We could just call it PlatformTask."
        },
        {
          "prediction": "I think this should be `free(xwayland);`",
          "reference": "Typo: this should free `xwayland` instead"
        },
        {
          "prediction": "I don't think this is needed anymore.",
          "reference": "Is it ok to use \"math/rand\" instead of \"crypto/rand\" here? Do we need to protect this ID somehow?"
        },
        {
          "prediction": "I don't think this is needed anymore.",
          "reference": "Why did we have `logxi` in the first place? Maybe it makes sense to remove it from `glide.lock? It will safe us in the future from using logger which is not working."
        },
        {
          "prediction": "I think this should be `out.write(\"UNF = {\"); out.write(UNF); out.write(\"},\\r\\n\");`",
          "reference": "Is there a reason to use `getUNF()` and `UNF` in the same block?"
        },
        {
          "prediction": "I'm not sure about this change, but I think it's a good idea to change the regex to match operators.",
          "reference": "Again this seems odd that megacheck cares"
        },
        {
          "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for this, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, I'm not sure if it's the right place for it, or if it's the right place for it, I'm not sure if it's the right place for it, or if it's the right place for it, or if it's the right place for it.",
          "reference": "I assume this will resolve to nil if this isn't in the config?"
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "I looks like we can make `allowOptionalMappings` non-optional since we have another overload without it. (I thought this generated a compiler warning, but maybe it's just R#)"
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "` per scale.` -> ` per scale.` need to clean the unnecessary blank space"
        },
        {
          "prediction": "I don't think we need to export this method.",
          "reference": "there's no import for Export"
        },
        {
          "prediction": "I'm not sure if this is the right place to register the node API.",
          "reference": "i don't think we want/need to make the node API available over UDS"
        },
        {
          "prediction": "I think this should be `return $this->articleFacade->findById($articleId);`",
          "reference": "How about to skip if and returning null and return a result of `ArticleFacade::findById` directly?"
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "I think this change is currently unnecessary. I like the idea of `map()`, `filter()`, etc. returning vanilla JavaScript arrays rather than mongoose arrays, but I think that's a bit too heavy of a change for a patch release. I think that all we need for this release is the `if (!parent || parent.$__.populated == null) return;` change."
        },
        {
          "prediction": "I'm not sure if this is the right place to use `git rev-parse HEAD 2>/dev/null || \\\\` or `git rev-parse HEAD 2>/dev/null || \\\\` or `git rev-parse HEAD 2>/dev/null || \\\\` or `git rev-parse HEAD 2>/dev/null || \\\\` or `git rev-parse HEAD 2>/dev/null || \\\\` or `git rev-parse HEAD 2>/dev/null || \\\\` or `git rev-parse HEAD 2>/dev/null || \\\\` or `git rev-parse HEAD 2>/dev/null || \\\\` or `git rev-parse HEAD 2>/dev/null || \\\\` or `git rev-parse HEAD 2>/dev/null || \\\\` or `git rev-parse HEAD 2>/dev/null || \\\\` or `git rev-parse HEAD 2>/dev/null || \\\\` or `git rev-parse HEAD 2>/dev/null || \\\\` or `git rev-parse HEAD 2>/dev/null || \\\\` or `git rev-parse HEAD 2>/dev/null || \\\\` or `git rev-parse HEAD 2>/dev/null || \\\\ `git rev-",
          "reference": "how about \"unknown\" instead of \"fafafaf\"?"
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "nit: do we gain anything from naming the output error `err` in this definition?"
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this, or if it's the right place to do it.",
          "reference": "This can happen with any dialog. Maybe the best place to add this change would be the dialog component instead."
        },
        {
          "prediction": "I think this should be `dumpEnvOutputOnFail(t, env.Processes())`",
          "reference": "Should this be `TearDown` since it now calls this method? Something I would like to see is, on test failure don't teardown completely instead leave the FAST repo in place with the stderr and stdout files and direct the user to that location. What do you think?"
        },
        {
          "prediction": "I think this should be `MetricNegLogLikelihood(metricSpec)`",
          "reference": "There's not particular reason to use a short name. Can we use a more descriptive name for the metric? Perhaps \"negativeLogLikelihood\"?"
        },
        {
          "prediction": "I think this should be `isType (token, TOKEN_KEYWORD) && token->keyword == KEYWORD_function && repr == NULL`",
          "reference": "not handling in case of `repr` makes the behavior probably a little too unpredictable. Is there a reason not to, apart missing stuff in the `repr`? Does it lead to some problem?"
        },
        {
          "prediction": "I think this should be `awaitable = _context.Input.AdvanceTo(consumed, examined);`",
          "reference": "Remove the finally?"
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "Build on AArch64 fails because WCHAR is not defined."
        },
        {
          "prediction": "I think this should be `test.envName`",
          "reference": "Do we use this const?"
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this. I'm not sure if it's the right place to do this.",
          "reference": "I think this may need to be `SetCertificateRequestAnnotations` as it returns a `CertificateRequestModifier`"
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.",
          "reference": "it would likely be better to do this in the Identifier.by_scheme_name method itself."
        },
        {
          "prediction": "I don't think we need to change this.",
          "reference": "@janette looking at this test code, I'm pretty sure that it's going to give a false positive. Where is it actually checking the contents of the first four datasets against expected values? All the assertion at the end of the test seems to check is that at least four datasets exist."
        },
        {
          "prediction": "I'm not sure if this is the right place to use it.",
          "reference": "Would this break things if Ghost is run in a subdirectory or no?"
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.",
          "reference": "maybe switch the order in order to make this a positive assertion instead of a negative one? i.e. `if key =~ /id/` first."
        },
        {
          "prediction": "I don't think we need to import `ElementNotVisibleException` here.",
          "reference": "Is this an oversight for some code in the body?"
        },
        {
          "prediction": "I think this should be `state.setProduct(mProduct);`",
          "reference": "Reason for adding this? I couldn't find where you are retrieving it back."
        },
        {
          "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if this is the right thing to do.",
          "reference": "Can we expect adequate information emitted to the log in case either requiring preloads.rb or doing the requires in preloads.rb fails? If the answer is yes, I think we can merge this PR right away."
        },
        {
          "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body beginning.",
          "reference": "How about a `app/views/layouts/pages.html.erb` layout that contains the HTML head, body, wrappers and yield's the `new-topics` template into it? I think we might be able to delete the `app/controllers/pages_controller.rb` file at that point."
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "This is a coarse solution. This check is helpful, but you should also add a check in `$__version()` to avoid calling `isSelected()` if `key === false`"
        },
        {
          "prediction": "I think this should be `ApplicationID` and `ApplicationName`",
          "reference": "Passing only needed data to make it can be reused by `planpreview` package where there is no deployment data."
        },
        {
          "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `CustomClientAuth` and a `CustomRouterAuth` struct. I'm not sure if it's a good idea to have a `CustomClientAuth` and a `CustomRouterAuth` struct, but if it's a good idea to have a `CustomClientAuth` and a `CustomRouterAuth` struct, I'm not sure if it's a good idea to have a `CustomClientAuth` and a `CustomRouterAuth` struct, but if it's a good idea to have a `CustomClientAuth` and a `CustomRouterAuth` struct, I'm not sure if it's a good idea to have a `CustomClientAuth` and a `CustomRouterAuth` struct. If it's a good idea to have a `CustomRouterAuth` and a `CustomRouterAuth` struct, I'm not sure if it's a good idea to have a `CustomClientAuth` and a `CustomRouterAuth` struct. If it's a good idea to have a `CustomRouterAuth` and a `CustomRouterAuth` struct,",
          "reference": "Could we rename those to `CustomClientAuthentication` (same for Router) to remove ambiguity between Authentication and Authorization (permissions)?"
        },
        {
          "prediction": "I'm not sure if this is used. I'm not sure if it's used.",
          "reference": "Is the name \"IMvxFormsViewPresenter\" too close to \"IMvxFormsPagePresenter\"? Perhaps something like \"IMvxFormsNativeViewPresenter\" or \"IMvxFormsPlatformViewPresenter\" or inline with Forms naming \"IMvxFormsOnPlatformViewPresenter\""
        },
        {
          "prediction": "I don't think we need to check for `child!=null && child!==true && child!==false`",
          "reference": "`typeof child!= 'boolean'` maybe?"
        },
        {
          "prediction": "I'm not sure if this is the right place to check for null values.",
          "reference": "Why && changed to ||?"
        },
        {
          "prediction": "I think this should be `NewIDAddress(4)`",
          "reference": "nit: not a big deal right now but spec assigns ID 0 to InitAddress"
        },
        {
          "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if this is the right thing to do.",
          "reference": "/javascript/firefox-driver is the Selenium implementation of a WebDriver for Firefox. Since it generally isn't W3C compatible, it shouldn't change. We can just drop this change."
        },
        {
          "prediction": "I don't think this is needed. I think it's better to call super().setZoomFactor(fact)",
          "reference": "There are various places where `setZoomFactor` is used but `fuzzyval` isn't set: - `__init__` and `on_config_changed` (should be okay as `init_neighborlist` gets called which essentially does the same) - `zoom` (calls `zoom_perc` with `fuzzyval=False`), which is used by `:zoom-in` and `:zoom-out`. Are you sure this won't break those calls? (Yes, I know there should be tests for this - I'm working on that.) Other existing places probably should get simplified."
        },
        {
          "prediction": "I'm not sure if this is the right place to mark this as a testing node. I'm not sure if this is the right place to mark it as a testing node, or if it's the right place to mark it as a testing node. I'm not sure if it's the right place to mark it as a testing node, or if it's the right place to mark it as a testing node, or if it's the right place to mark it as a testing node, or if it's the right place to mark it as a testing node, or if it's the right place to mark it as a testing node, or if it's the right place to mark it as a testing node, or if it's the right place to mark it as a testing node, or if it's the right place to mark it as a testing node, or if it's the right place to mark it as a testing node, or if it's the right place to mark it as a testing node, or if it's the right place to mark it as a testing node.",
          "reference": "Is there a benefit to keeping this in RefinementSettings? Or could we move it into its own class in TestUtil?"
        },
        {
          "prediction": "I'm not sure if this is the right thing to do here.",
          "reference": "I would have expected the Ready method to need to change to be a `<-chan Result` instead of a `<-chan map[string]Result`. The difference being that now the Ready channel can produce more than one set of results. In fact the name Ready is inaccurate now since its not about the query being ready but just a mechanism to deliver results. If this should be a follow up PR that is fine, lets create an issue for it."
        },
        {
          "prediction": "I don't think we need to change this interface.",
          "reference": "why? what if we want to access those methods outside of azkaban-common?"
        },
        {
          "prediction": "I'm not sure if this is the right place for this module.",
          "reference": "Rename file too"
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "Need to populate the `RequestID` field for these errors. This can be obtained from r.RequestID i think, but need to make sure. The `r.RequestID` should of been populated from the `UnmarshalMeta` handler list."
        },
        {
          "prediction": "I'm not sure if this is a good change.",
          "reference": "Why is the `final` being removed here?"
        },
        {
          "prediction": "I don't think this is needed anymore.",
          "reference": "Maybe let's take this opportunity to change easylogging to a git submodule?"
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "Should we just be generous and elide all extra whitespace? `strings.TrimSpace`"
        },
        {
          "prediction": "I don't think we should remove this method.",
          "reference": "This is an inaccurate API that has outlived it's purpose. We can't make the determination of phone (vs) tablet, with a 7\" screen in the mix. Also, with the advent of fragments, this API means very little now. It's not being used anywhere, since we switched to `ActionBar`."
        },
        {
          "prediction": "I think this should be `log.finest(version());`",
          "reference": "This change means that users can't easily see which version of the selenium server they're using. This is `info` level information."
        },
        {
          "prediction": "I don't think we need to mock the token?",
          "reference": "You should just use `with patch(...):`, so it unpatches it automatically. Also, much simpler."
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "This didn't use to work for me. Are you sure that returns the correct instance from startup?"
        },
        {
          "prediction": "I'm not sure if this is the right place for this method, but I think it's a good idea to rename the method to `MethodCallExpr` or `MethodCallExpr` to make it more clear what it's doing.",
          "reference": "Looks good. Eventually we could remove some of these constructors, but for now adding these two seems the way to go"
        },
        {
          "prediction": "I'm not sure if this is a good idea.",
          "reference": "@jalavik should be have somewhere enum/list/registry of possible tags?"
        },
        {
          "prediction": "I'm not sure about this, but I'm not sure if it's a good idea to disable logging too many args.",
          "reference": "why is this pylint disable needed?"
        },
        {
          "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.",
          "reference": "The new sync feature is only being supported from within Terraform. Installations using the deprecated method will have this feature disabled."
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "This type of return (f'xxx') is not recommended, it is recommended to return 'xxx'"
        },
        {
          "prediction": "I don't think we need to do this in X86?",
          "reference": "I would make this level 1 or 2."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "Is that path in a variable anyway? Not a big fan of hard coding it here."
        },
        {
          "prediction": "I'm not sure if this is a breaking change. I'm not sure if it's a breaking change or if it's a breaking change or if it's a breaking change.",
          "reference": "nit: Move `IdentityTemplateLabel` to be under `IdentityTemplate` to match the struct in config_crd.go"
        },
        {
          "prediction": "I don't think we need to add this to the `AnalyticsHelper` class.",
          "reference": "Not necessarily related to this PR, but don't you think having a centralized place for all interactions with analytics might make this into a very big class? Is that something that you don't worry about until it happens?"
        },
        {
          "prediction": "I think this should be `err := ctx.Err(); err == context.DeadlineExceeded { return s.getTimeoutError() }`",
          "reference": "it seems that my terminal is dead when I press ctrl+c during running daisy cli today, is this PR fixing that?"
        },
        {
          "prediction": "I don't think we need to change this.",
          "reference": "If we are going to add config to specify the maximum message pool size, we should probably also add a parameter for the maximum nonce gap and pass it into the `IngestionValidator`. This could be done in this PR or added as an issue."
        },
        {
          "prediction": "I think this is not needed anymore.",
          "reference": "please inline imports"
        },
        {
          "prediction": "I'm not sure if this is a good change. I'm not sure if it's a good change, but I'm not sure if it's a good change.",
          "reference": "Should IptablesPostWriteCheckIntervalSecs be set back to its previous smaller value, if use of the iptables lock is disabled?"
        },
        {
          "prediction": "I'm not sure if this is the right place for this error, but I'm not sure if it's the right place for this error.",
          "reference": "Please use packageInfo here instead. As it is used in `app.js`."
        },
        {
          "prediction": "I don't think we need to use the cache.",
          "reference": "this seems unrelated to the rest of the PR, although related to the original report"
        },
        {
          "prediction": "I'm not sure if this is the right fix.",
          "reference": "Would a check for added columns with non-null default be sufficient for aligned format?"
        },
        {
          "prediction": "I don't think this flag is used.",
          "reference": "Is this PR implementing compute service account for OVF import as well? I thought it's only image/one-step import? Btw, OVF importer uses \"-\" instead of \"_\" in flags (should be `compute-service-account`)."
        },
        {
          "prediction": "I don't think we should change this route.",
          "reference": "Why change to element?? in whole application use plural convention??"
        },
        {
          "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.",
          "reference": "Tiniest nit but this can be `tabindex={-1}`, `width={11}`, `height={11}`"
        },
        {
          "prediction": "I don't think we need to test this. I'm not sure if it's a good idea to test this.",
          "reference": "Unrelated to this PR, we should remove this exception. We now require `numpy`."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "Is the loop over vars and adding them to the subworkflow below in this file needed, since it's already done by NewSubWorkflowFromFile?"
        },
        {
          "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do it.",
          "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping."
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "Having to write this util makes me think that maybe we should have kept the csv_input stuff. I don't know."
        },
        {
          "prediction": "I think we should move this to `BlockRetrievalQueue`.",
          "reference": "Passing in and saving a reference to the `BlockCache` at init time is going to break if something calls `config.ResetCaches()`, because it replaces the `BlockCache` instance completely. This happens on user logout or by a manual write to `.kbfs_reset_caches`. So you probably want to give it the whole `config`, or maybe just the `config.BlockCache` function pointer."
        },
        {
          "prediction": "I'm not sure if this is the right place to close the stream. I'm not sure if this is the right place to close the stream. I'm not sure if this is the right place to close the stream, or if it's the right place to close the stream.",
          "reference": "I am not sure this could happen. st should be nil if the error happens. If it does happen, we could also do st.Reset(), since it is an erroureous state so it closes both sides of the stream."
        },
        {
          "prediction": "I'm not sure if this is the right place to log the stack, but I'm not sure if this is the right place to log the stack, or if it's the right place to log the stack, or if it's the right place to log the stack, or if it's the right place to log the stack, or if it's the right place to log the stack, or if it's the right place to log the stack, or if it's the right place to log the stack, or if it's the right place to log the stack, or if it's the right place to log the stack.",
          "reference": "I'm guessing this was just added for debugging? Should probably remove it so we aren't modifying 3rd party libs."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "This seems reversed... if `success?` is true, wouldn't we use `success`?"
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "This seemed like the easiest way to allow log level checks, it will require an update to the vendors tool, to ignore that file on update."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I think it's better to use `elsif @user %> <% elsif @user %> <% end %> <% end %> <% elsif @user %> <% end %> <% end %> <% end %>",
          "reference": "Should we disallow entry authors to unsubscribe to their entries?"
        },
        {
          "prediction": "I think this file should be renamed to `Copyright (C)` to make it easier to read.",
          "reference": "2016 should be 2017."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it.",
          "reference": "boolean exists = (existSchema!= null) && (existSchema.getSummary()!= null);"
        },
        {
          "prediction": "I'm not sure if this is the right place to call `runPoolDescribe` or `runPoolDescribe`",
          "reference": "It does not look idiomatic."
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "Generally, we do not use newlines between project imports, we only separate them from the stdlib imports"
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I think it would be better to move this logic into `playbackManager.js` and call `playbackManager.setKeyboardSteps(userSettings.skipBackLength() * 1000000 / nowPlayingItem.RunTimeTicks, userSettings.skipForwardLength() * 1000000 / nowPlayingItem.RunTimeTicks);`",
          "reference": "can this long line be wrapped?"
        },
        {
          "prediction": "I'm not sure about this, but I'm not sure if it's worth it. I'm not sure if it's worth it, but I'm not sure if it's worth it or if it's worth it.",
          "reference": "I'd use the same message that I suggested in the release changelog."
        },
        {
          "prediction": "I'm not sure if we should remove this line.",
          "reference": "Keep semi-colons at end of function defs please"
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "A little skeptical of `explain` being here. Why is this now a property of all commands?"
        },
        {
          "prediction": "I don't think we need this file anymore.",
          "reference": "License copied two times!!"
        },
        {
          "prediction": "I don't think we need to change the matcher here.",
          "reference": "... their **superclass**"
        },
        {
          "prediction": "I'm not sure if this is a good idea.",
          "reference": "I'm not sure if this is the right thing to be doing here. It seems like there should be a more systemic fix instead of this patch."
        },
        {
          "prediction": "`undefined` if dependencies are loading. `undefined` if dependencies are loading. `undefined` if dependencies are loading. `undefined` if dependencies are loading. `undefined` if dependencies are loading.",
          "reference": "Not sure why these are up here can we move these down to be part of the `@return` tag instead? This is what we usually do (e.g. `getCurrentEntityURL`)"
        },
        {
          "prediction": "I'm not sure if this is a good idea, but I think it's better to use `Array.wrap(field_names).map { |field_name| self[field_name] }.flatten.compact` instead of `Array.wrap(field_names).map { |field_name| self[field_name] }.flatten.compact`",
          "reference": "Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "We keep who wrote the code anonymous."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it.",
          "reference": "Mention something in logs, that fake registration was used e.g. `Fake identity registered`"
        },
        {
          "prediction": "I don't think this is the right thing to do here.",
          "reference": "I think it would make sense to also set `internalWebPropertyID` to `''` here. Otherwise, it might keep its previous value (let's say a property was selected before, but then the user chooses \"Create new property\"), but since it always should depend on `propertyID`, that would be incorrect."
        },
        {
          "prediction": "I'm not sure about this, but I think it would be better to use `MolOps::addHs(m);` instead of `MolOps::addHs(m);`",
          "reference": "It might be reasonable to add a check that sanitization still fails here."
        },
        {
          "prediction": "I think this should be `attemptNo: 0` instead of `attemptNo: 0`.",
          "reference": "Why not use attemptNo instead of another call to getAttempt? Even better, consider using a private method to calculate this string. This logic is in two places."
        },
        {
          "prediction": "I don't think we need this anymore.",
          "reference": "Yuck. Rails bug."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "It's useally a common practice to not use `l` as a variable (we have disabled this test in scapy because our code has tons, but it would have PEP8 failed otherwise), but it would be better not to create any. In general, single letter variables are not liked that much. Especially with windows where the fonts make 1=l How about `lay`?"
        },
        {
          "prediction": "I think this should be `w.WriteHeader(http.StatusContinue, fmt.Sprint(tag.Uid))`",
          "reference": "DRY these 5 lines into a function call, no?"
        },
        {
          "prediction": "I'm not sure if this is the right place to log the error. I'm not sure if it's the right place to log the error, or if it's the right place to log the error. I'm not sure if it's the right place to log the error, or if it's the right place to log the error. I'm not sure if it's the right place to log the error, but if it's the right place to log the error, it's the right place to log the error.",
          "reference": "should we be trying to close here? or just return directly @fabxc? same goes for `stopc`..."
        },
        {
          "prediction": "Line is too long. [89/80]",
          "reference": "just re-ordered for clarity"
        },
        {
          "prediction": "I think this should be `%s not found at namespace: %q\\n\", volname, namespace, http.StatusText(resp.StatusCode))`",
          "reference": "Can you fix this also to print what is the IP address used to connect. Rename --> \"M_API server\" to maya apiservice"
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "This fails on Go 1.11 because `indexByte` is already defined in strings_go111.go. I would suggest simply renaming one of the two, for example you could rename the other one to `strings_indexByte` (that will be one of the things we'll drop when we drop Go 1.11 support so it's better to make that one look ugly instead of the function that we will likely keep for a longer time)."
        },
        {
          "prediction": "I don't think we need to change this.",
          "reference": "Now `dbType=' MockDbType.int32 '` is correctly interpreted and the value is rendered as an integer instead of a string; hence no more double quotes."
        },
        {
          "prediction": "I think this is a breaking change. I'm not sure if it's a breaking change, but I think it's a breaking change.",
          "reference": "typo in `$contend`"
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "Nit: empty line"
        },
        {
          "prediction": "I think this should be `if fb == (FolderBranch{}) { panic(\"zero FolderBranch in getOps\") } else { panic(\"zero FolderBranch in getOps\") }`",
          "reference": "I figured this was more fool-proof than trying to plumb the error up from everywhere."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "We know debug and trace as globals exist and are defaulted to 0. In this instance we need to know that c is non- nil, srv is non-nil and logging is non-nil before we can trust this statement not to panic."
        },
        {
          "prediction": "I'm not sure why this was removed.",
          "reference": "Good removal here for two reasons: we're redeclaring `app.ConfigPath` immediately below without having used the initial value, and `app.GetConfigPath()` will build the value using the same process as in this line anyway."
        },
        {
          "prediction": "Is this still needed?",
          "reference": "Should BuildBase be removed?"
        },
        {
          "prediction": "I'm not sure if this is a test or a test. I'm not sure if it's a test or a test. If it's a test or a test, it's a test or a test.",
          "reference": "this was a bad Goland auto-import that I missed in the previous PR. Thanks to @rkowalick and @acruikshank for catching it"
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "Good catch here. Reading the code, it actually seems kind of dumb that `replaceAtom` needs to copy the atom it's passed. Ah well, we're more or less stuck with that."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "What's the reason for adding the output pointer here? I'd expect it to be derivable from the actual handler that's called."
        },
        {
          "prediction": "I'm not sure if this is the right place to put this method.",
          "reference": "I don't see tests for this (or the similar method on `Team`)."
        },
        {
          "prediction": "I don't think we need this anymore.",
          "reference": "should use Number instead of Long"
        },
        {
          "prediction": "I'm not sure if this is the right place for this, but I think it's better to move this check to `c.mu.Lock()`.",
          "reference": "We had the checks for those two errors for a reason, why do we not need them anymore?"
        },
        {
          "prediction": "I don't think this is needed anymore.",
          "reference": "Why didn't you just switch to `range` here too?"
        },
        {
          "prediction": "I'm not sure if this is the right place to call this function. I'm not sure if it's the right place to call this function.",
          "reference": "I don't even think `nil` should be allowed, since it uses global state to get the client."
        },
        {
          "prediction": "I don't think this is the right place to start debugging.",
          "reference": "You somehow got a change from `master` into your branch again, in e6d2167085688264e5ee6a81cfd2a7a8f10ded13. While it's not something terribly bad (as it will be fine after merging), it's kind of confusing, and I have no idea how it happens :laughing: Are you trying to update changes from `master` while working on your branch somehow? How do you do that?"
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.",
          "reference": "Minor, can we drop the leading `!` and just swap the if and the else blocks?"
        },
        {
          "prediction": "I don't think this line is necessary. It should be `\\ and bbox_feats.shape[0] > 0:`",
          "reference": "`bbox_feats.shape[0] > 0` requires the number of proposal is not 0."
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "Just FYI, I had to remove this unused import because Travis/`npm run lint` were complaining."
        },
        {
          "prediction": "I'm not sure if this is needed.",
          "reference": "format.h is not a system header but bundled with LAMMPS. This should be `#include \"fmt/format.h\"`"
        },
        {
          "prediction": "I think this should be `version >= BKDWriter.VERSION_LOW_CARDINALITY_LEAVES`",
          "reference": "could we always call visitDocValuesWithCardinality? It seems to include the version check already?"
        },
        {
          "prediction": "I don't think we need to change this?",
          "reference": "I think if they _don't_ specify a port, we should assume grid default (which is 4444)"
        },
        {
          "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `TautomerEnumerator` here. I'm not sure if it's a good idea to use `TautomerEnumerator` here.",
          "reference": "This looks to be a breaking change. I know it will affect some of my code that uses the Tautomer enumerator."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "Perhaps remove this line"
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "Ah, missed this one. Sorry: you don't need to test the atomic number here. that's taken care of above on line 683."
        },
        {
          "prediction": "I'm not sure if this is the case, but I'm not sure if this is the case.",
          "reference": "roundInfo() is called by couple of places in consensus for safety, better test/verify the delay of return err due to this Sleep() would not affect the normal functionality, like consensus can still be reached, full-node can correctly sync"
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "This 32 could go away too."
        },
        {
          "prediction": "I don't think we need to pass `pageSpeedLink` and `pageSpeedLabel` here.",
          "reference": "These props should be less specifically named since the component is generic, for example `anchorLink`, `anchorLinkLabel`."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "In the future, it'd be great if we can separate commits or PRs that aren't in the same scope"
        },
        {
          "prediction": "I'm not sure if this is the right fix. I'm not sure if this is the right fix, but I'm not sure if it's the right fix.",
          "reference": "can you define the string format on a different line, so it can be named, and so that it does not have to be constructed twice?"
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.",
          "reference": "Can we write a unit test for this."
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "Same as above, use `.delete('_autosave')`, not the command handler."
        },
        {
          "prediction": "I'm not sure if this is the right place to remove the `idToConstant` variable.",
          "reference": "It isn't necessary to check whether there are projected ID columns. The code is shorter if the values are available by default, even if they aren't used. This fixes the problem where there are constants to add (like `_file`) but no identity partition values are projected."
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "Update after command rename"
        },
        {
          "prediction": "I don't think this is needed anymore.",
          "reference": "@KroArtem This is the Checkstyle violation. This import should be grouped with other `net.sourceforge.pmd` imports below, in alphabetical order"
        },
        {
          "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.",
          "reference": "File is not `goimports`-ed (from `goimports`)"
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "This change seems unrelated to copying email addresses to the clipboard. Please limit the scope of pull requests as much as possible."
        },
        {
          "prediction": "I don't think we need to close the keymap if the keymap is NULL.",
          "reference": "I'm assuming that there isn't a way for us to skip sending an fd here (-1?), and that we're allocating this fd just to send a legal but useless value across?"
        },
        {
          "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.",
          "reference": "might be good for the units (bytes?) to be in the variable name."
        },
        {
          "prediction": "Metrics/LineLength: Line is too long. [89/80]",
          "reference": "Metrics/BlockLength: Block has too many lines. [166/25]"
        },
        {
          "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if this is the right thing to do.",
          "reference": "I'd end the sentence after `special indicator (line 3)`. And then start a new sentence: `The special field can indicate that the field specifies a reset, is a sequence ID, or is a timestamp for the record.`"
        },
        {
          "prediction": "I don't think we need this anymore.",
          "reference": "These empty lines can be kept."
        },
        {
          "prediction": "I'm not sure about this change, but I don't think it's worth it.",
          "reference": "For some reason these tests started failing due to an extra `NEWLINE` returned from `h.query()`. Have not tried to check whether this may be a problem for real templates or not, just fixed the failing tests. Anyone with an opinion here?"
        },
        {
          "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.",
          "reference": "It is better to have a method than a var."
        },
        {
          "prediction": "I'm not sure if this is a good change. I'm not sure if it's a good change, but I'm not sure if it's a good change.",
          "reference": "concurrent poller won't be larger than concurrent execution. Jump from 2 -> 16 seems aggressive. I suggest to use 8. Ideally, this should be dynamic config. :)"
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "List is redundant."
        },
        {
          "prediction": "I think this should be `if(getSupportActionBar()!= null && getSupportActionBar().setDisplayHomeAsUpEnabled(true) && getSupportActionBar().getDisplayHomeAsUpEnabled(true) && getSupportActionBar().getDisplayHomeAsUpEnabled(true) && getSupportActionBar().getDisplayHomeAsUpEnabled(true) && getSupportActionBar().getDisplayHomeAsUpEnabled(true) && getSupportActionBar().getDisplayHomeAsUpEnabled(true) && getSupportActionBar().getDisplayHomeAsUpEnabled(true) && getSupportActionBar().getDisplayHomeAsUpEnabled(true) && getSupportActionBar().getDisplayHomeAsUpEnabled(true) && getSupportActionBar().getDisplayHomeAsUpEnabled(true) && getSupportActionBar().getDisplayHomeAsUpEnabled(true) && getSupportActionBar().getDisplayHomeAsUpEnabled(true) && getSupportActionBar().getDisplayHomeAsUpEnabled(true) && getSupportActionBar().getDisplayHomeAsUpEnabled(true) && getSupportActionBar().getDisplayHomeAsUpEnabled(true) && getSupportActionBar().getDisplayHomeAsUpEnabled(true) && getSupportActionBar().getDisplayHomeAsUpEnabled(true) && getSupportActionBar().getDisplayHomeAsUpEnabled(true) && getSupportActionBar().getDisplayHome",
          "reference": "Please use a string resource here rather than the hardcoded string \"user\". This allows the app to be multilingual."
        },
        {
          "prediction": "I don't think we need this anymore.",
          "reference": "@aswathkk Why did we remove this import? I guess we are using it."
        },
        {
          "prediction": "I think this should be `PrepareToStop()`.",
          "reference": "Why? I thought this is for graceful shutdown."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.",
          "reference": "Can `result.stdout` or `result.stderr` be nil?"
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "@mprobst Looks like the `isStdLib` function has been removed in the latest Python plugin. Any thoughts on how to handle this? The new version doesn't seem to have any relevant alternatives."
        },
        {
          "prediction": "I think this should be `MaxIPSetSize int`.",
          "reference": "How can there be a configured max ipset size? Surely we need to write ipsets with however many members are implied by the Calico datastore?"
        },
        {
          "prediction": "I think this should be `incident.messages.delete_singular` instead of `incident.messages.delete_singular`",
          "reference": "This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted."
        },
        {
          "prediction": "I don't think we need to implement isNaN here.",
          "reference": "why not be consistent with `isNull` and `notNull` and return null?"
        },
        {
          "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or if it's a good idea to have a `docker_labels` field in the `backend_service.go` file. If it's a good idea to have a `docker_labels` field in the `backend_service.go` file, I'm not sure if it's a good idea to have a `docker_labels` field in the `backend_service.go` file. If it's a good idea to have a `docker_labels` field in the `backend_service.go` file, then I think it's a good idea to have a `docker_labels` field in the `backend_service.go` file. If it's a good idea to have a `docker_labels` field in the `backend_service.go` file, then I think it's a good idea to have a `docker_labels` field in the `backend_service.go` file. If it's a good idea to have a `docker_labels` field in the `backend_service.go` file, then I think it's",
          "reference": "Did we forget to remove this field?"
        },
        {
          "prediction": "I think this method should be renamed to `elementCount()`.",
          "reference": "What if there is no element?"
        },
        {
          "prediction": "I'm not sure if this is the right place to lock the buildActionMutex, or if it's the right place to lock the buildActionMutex, or if it's the right place to lock the buildActionMutex, or if it's the right place to lock the buildActionMutex, or if it's the right place to lock the buildActionMutex, or if it's the right place to lock the buildActionMutex, or if it's the right place to lock the buildActionMutex, or if it's the right place to lock the buildActionMutex, or if it's the right place to lock the buildActionMutex.",
          "reference": "I think you need to be careful to honour isTest and stamp here."
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "why zero value for `arrayType` for the default value of the optional args?"
        },
        {
          "prediction": "I think this should be `['.control-filter' => $this->render()];`",
          "reference": "@robinbonnes ~~Would you mind putting the array key and value on a new line - it makes it more readable as an array.~~ Never mind, see discussion below."
        },
        {
          "prediction": "I don't think we need to add cniNet and cniIpam to this file.",
          "reference": "I've never seen us do this anywhere else - why here? Why not `address, meshAddress string`?"
        },
        {
          "prediction": "I don't think we need to create a new `JsonQueryConverter` for every request.",
          "reference": "I think it's necessary only for the earlier \"dynamic\" approach. I suppose it's not necessary in the eager one."
        },
        {
          "prediction": "I think we should move this method to the `Configurator` class. I think we should move this method to the `Configurator` class.",
          "reference": "Same here than [there](#r26168925)"
        },
        {
          "prediction": "I'm not sure about this change, but I think it would be better to use `String#replaceAll(\"[^a-zA-Z0-9_]+\", \"\");` instead of `String#replaceAll(\"[^a-zA-Z0-9_.]+\", \"\");`",
          "reference": "Again we should think about moving this pattern to a static final field"
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "haven't been implemented the `__constructor` for `NormalizerConfigPass`?"
        },
        {
          "prediction": "I don't think we need this module anymore.",
          "reference": "Docstring is missing."
        },
        {
          "prediction": "I'm not sure if this should be `return false;` or `return true;` or `return false;` or `return false;`?",
          "reference": "I don't see the reason of this return as it will stop loading in half because an error, thats bad imo. Or you load it all and report errors or you load nothing and terminate, the first is as it always was so I wouldn't change that."
        },
        {
          "prediction": "I'm not sure if this is the right place to call this method.",
          "reference": "change from AddPeer to AddPeers added a space in some occurrences"
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC."
        },
        {
          "prediction": "I don't think this is needed anymore.",
          "reference": "Do you remove \"s\" from \"iptables\" to IPTable\" on purpose? I feel it should be \"IPTablesRules\"."
        },
        {
          "prediction": "I don't think this is needed anymore.",
          "reference": "nit: not your problem - but I wonder if this should have been a \"ConstantResponseRpc\" - which takes a name and a value.... maybe a more reusable concept."
        },
        {
          "prediction": "I think this is a breaking change. It's a breaking change.",
          "reference": "These changes have been resolved upstream. We can revert changes to this file when synced."
        },
        {
          "prediction": "I'm not sure if this is the right term for this PR, but I'm not sure if it's the right term for this PR. I'm not sure if it's the right term for this PR, or if it's the right term for this PR, or if it's the right term for this PR, or if it's the right term for this PR, it's the right term for this PR.",
          "reference": "The description predates this diff but I think we can come up with something more grounded."
        },
        {
          "prediction": "I don't think we need to create asnapshot of volume.",
          "reference": "Let the Kind, APIVersion & Metadata follow the rules followed by Volume. What is the reason for a change for snapshot struct?"
        },
        {
          "prediction": "I don't think we need this annotation anymore.",
          "reference": "seems that we did not strong depend servo no need to keep it? change to another one?"
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "Looks like this used to be UB before with an empty blocks and then calling `.second` on the `.front()`. Did it ever crash though?"
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this.",
          "reference": "Sorry about the code churn here, reworking this use normal loops and async await made debugging far more straight forward. For example, if configuring the fail point fails you find out when stepping over that line vs having to look for the ultimate catch clause that handled it."
        },
        {
          "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.",
          "reference": "this is wrong and should be reverted"
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "I think you'll need to add an import for runtime, before you can merge this PR. (Presumably it was already there for something else when you were working on this, but has since disappeared.)"
        },
        {
          "prediction": "I don't think we need this test anymore.",
          "reference": "Unrelated typo fix."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "I don't think we need an empty value here; any middleware that wants a default value for empty placeholders will pass in what that value should be."
        },
        {
          "prediction": "I'm not sure if this is the right place to use `--storybook-host=http://` or `--storybook-host=https://`",
          "reference": "Why was this changed?"
        },
        {
          "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.",
          "reference": "Compared to using traditional enums, I suggest to use `Status` or `StatusOr`, since they are more expressive and informative. Besides, isolating the definitions of error code of individual modules from the ones of the RPC interface is a good practice, isn't it?"
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "Use the return of the conditional for variable assignment and comparison."
        },
        {
          "prediction": "I don't think we need to import `AnyKey` here.",
          "reference": "just realised... This breaks things since there is not selenium types module, is there a PR for this?"
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "move to line 23 below"
        },
        {
          "prediction": "I think we should remove this method.",
          "reference": "the first problem i found in the passcode change flow is that these two lines were happening in 'lock()' but not in'showLockActivity' which is what the passcode change flow calls. I've just moved them to happen in that method."
        },
        {
          "prediction": "I think this should be `self._solid_def.name: self._solid_config`",
          "reference": "Doing this adds the actual resources themselves to the dictionary. I think for now, there's no way to know what the resource config provided may be, as we don't permit resource config on `build_solid_context`, so this part can be omitted."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "1 trailing blank lines detected."
        },
        {
          "prediction": "I'm not sure if this is the right place for this test.",
          "reference": "I would personally prefer a filename without an abbreviation, a newcomer to the project wouldn't be able to translate \"pv\" to \"partition-value\"."
        },
        {
          "prediction": "I think this should be `if (parameters!= null && parameters.Count() > 0) { return; } else if (parameters.Count() == 1 && parameters[0].ParameterType == typeof(IMvxBundle)) { return; } else if (parameters.Count() == 1 && parameters[0].ParameterType == typeof(IMvxBundle)) { return; } else if (parameters.Count() == 1 && parameters[0].ParameterType == typeof(IMvxBundle)) { return; } else if (parameters.Count() == 1 && parameters[0].ParameterType == typeof(IMvxBundle)) { return; } else { return; }",
          "reference": "This check looks odd to me. I can't quite grok it. Why is it needed now? What's changed?"
        },
        {
          "prediction": "I'm not sure if this is the right place to start JetStream. I'm not sure if it's the right place to start JetStream, but if it's the right place to start JetStream, I'm not sure if it's the right place to start JetStream, or if it's the right place to start JetStream, or if it's the right place to start JetStream, or if it's the right place to start JetStream, or if it's the right place to start JetStream, or if it's the right place to start JetStream, or if it's the right place to start JetStream.",
          "reference": "This change is needed because otherwise the path was being changed from `path/store/jetstream` to `path/store/` and files stored differently after re-enabling."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "is this necessary? doesn't `client.close()` imply all sessions will be ended?"
        },
        {
          "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.",
          "reference": "Extra line, it's not needed here."
        },
        {
          "prediction": "I'm not sure if we're going to use `bolt/pal` or `bolt/bolt/pal`?",
          "reference": "Is this OK to add in the spec helper? I need to call `Bolt::PAL.load_puppet` so that I can use the new `Bolt::PAL::Issues` module when verifying that plans forbid functions."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "or is it `i < length - back.length()`? `\"12345\".padTo(10, 'a')` should be `12345aaaaa`"
        },
        {
          "prediction": "I don't think we need to pass `custom_imports` to `train_detector`?",
          "reference": "custom_imports -> custom_hooks"
        },
        {
          "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this, or if it's the right place for this, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it, or if it's the right place for it.",
          "reference": "I don't get why are we baking new hash structures to represent phases, sections, questions. We are not only loosing the references defined in models but also we have to figure out keys and values for this newly structures."
        },
        {
          "prediction": "I'm not sure if this is the right place to call `openInput(String name, IOContext context, boolean preload)` or `openInput(String name, IOContext context, boolean preload)`",
          "reference": "It's somewhat confusing that the `preload` parameter shadows the instance variable; maybe rename the instance variable to `globalPreload` or `preloadDefault` or so to prevent future confusion?"
        },
        {
          "prediction": "I'm not sure if this is a good idea, but I think it's better to have a `ImageWithHealthcheck` struct with a `name` field. I'm not sure if it's a good idea to have a `name` field in the `ScheduledJob` struct, or if it's a good idea to have a `name` field in the `ScheduledJob` struct, but if it's a good idea to have a `name` field in the `ScheduledJob` struct, I think it's a good idea to have a `name` field in the `ScheduledJob` struct. I'm not sure if it's a good idea to have a `name` field in the `ScheduledJob` struct, but if it's a good idea to have a `name` field in the `ScheduledJob` struct, I think it's a good idea to have a `name` field in the `ScheduledJob` struct.",
          "reference": "Are we setting these values anywhere?"
        },
        {
          "prediction": "I don't think this is needed anymore.",
          "reference": "This has to be in front of all other includes"
        },
        {
          "prediction": "I'm not sure if this is the right fix.",
          "reference": "These changes make sense to me. @ricrogz : you wrote (I think ) the original version of this as part of #2553 Do you see any reason to not make the change?"
        },
        {
          "prediction": "I think this should be `window.location.pathname || window.location.pathname || '';`",
          "reference": "`window.self === window`"
        },
        {
          "prediction": "I'm not sure if this is the right thing to do, but I think it's a good idea to rename the file to `ErrWorkspaceNotFound`.",
          "reference": "maybe we should keep one test case for ErrFileNotExists and update only one file for ErrWorkspaceNotFound?"
        },
        {
          "prediction": "Is this still needed?",
          "reference": "Please add `ConsigureAwait(false)` here and on `ShutdownAsync` below."
        },
        {
          "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `vardel` or `vardel` here.",
          "reference": "Isn't this a false positive? Why are we reporting `unused-variable` on a `del` operation with a `undefined-variable`."
        },
        {
          "prediction": "I'm not sure if this is the right place to send the stats.",
          "reference": "Is it correct that `SessionDto` should be here?"
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "sorry I missed this earlier. We no longer use ovs-ofctl for flow programming AFAIK, why not add this support to ofnet / libOpenflow?"
        },
        {
          "prediction": "I don't think this is needed anymore.",
          "reference": "Make this consistent with the other definition please `'false'` vs `false`"
        },
        {
          "prediction": "I'm not sure if this is a good idea. I think it's a good idea to call `Exit(0)` in the `CleanupHandler` function.",
          "reference": "I think this is a good way to do it. :+1:"
        },
        {
          "prediction": "I'm not sure if this is a good idea.",
          "reference": "Why this is needed?"
        },
        {
          "prediction": "I don't think this is needed anymore.",
          "reference": "Can we define this directly in the function `NewConnTrackOvsAppCtl` instead of passing this as an argument?"
        },
        {
          "prediction": "I'm not sure this is the right thing to do here.",
          "reference": "False positives are annoying..."
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "Is the infrastructure layer an appropriate one? I don't think so tbh, more like an application, or even a domain one."
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "Why is this required to turn the static readonlies into jitted const? Is this a bug in the jitter?"
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "feel free to make this a \"typed\" named tuple (overriding __new__) if you are feeling frisky"
        },
        {
          "prediction": "I think this should be `const MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER || (2 ** 53) - 1;`",
          "reference": "Would use parenthesis to explicitly state the associations of operands ```js const MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER || ((2 ** 53) - 1)"
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "The bug was caused by this order change in the last refactoring."
        },
        {
          "prediction": "I don't think we need to import `docker.utils.kwargs_from_env` here.",
          "reference": "This is already imported as docker. You're safe to simply use `docker.utils.kwargs_from_env()` below."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "No need to add this fun. Using RunnableActionsBuilder#AddActions instead"
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's worth it.",
          "reference": "I don't think it's possible to do this for hooks"
        },
        {
          "prediction": "I'm not sure if this is a good idea. I think it's better to use `this.wait(sec * 1000);` instead of `this.wait(sec * 1000);`",
          "reference": "wait(1ms) when sec=0. wait(0ms) waits forever so that's why this is better."
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "Do we need `domain` and `so_reuseport` now that we open new sockets immediately after calling `add_listener`?"
        },
        {
          "prediction": "I don't think we need this interface anymore.",
          "reference": "The formatting seems different from the rest of the code"
        },
        {
          "prediction": "Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region. Can't determine region.",
          "reference": "What about calling this package \"parameters\"? utils\\parameters are utils related to parameters."
        },
        {
          "prediction": "I'm not sure if this is the right way to test this.",
          "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping."
        },
        {
          "prediction": "I'm not sure if this is the right place for this command, but it seems like it should be `--help Show this help message and exit.`",
          "reference": "what is the actual difference here?"
        },
        {
          "prediction": "I don't think this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but I'm not sure if it's the right place to do it.",
          "reference": "Parsing URLs is hard. Any fixes should avoid manually parsing the URL."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "This is a private api, it doesn't need to return anything so `@group_level -= 1 if @group_level > 0` is preferred."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": ".GetValueOr(0)... but really, shouldn't m_value_strife also be optional?"
        },
        {
          "prediction": "I'm not sure if this is the best way to do this, but I think it's better to use `Record` instead of `Record`",
          "reference": "Working around a possible limitation in the JSDoc plugin's typescript syntax checking. This means the same thing"
        },
        {
          "prediction": "I don't think this is needed.",
          "reference": "Should be readonly"
        },
        {
          "prediction": "I'm not sure about this, but I'm not sure if it's a good idea to import `six.moves` from `rdkit.six.moves` in `rdkit.six.moves.py` and `rdkit.six.moves.py` from `rdkit.six.moves.py` to `rdkit.six.moves.py` and `rdkit.six.moves.py` from `rdkit.six.moves.py` to `rdkit.six.moves.py` and `rdkit.six.moves.py` from `rdkit.six.moves.py` to `rdkit.six.moves.py` and `rdkit.six.moves.py` from `rdkit.six.moves.py` to `rdkit.six.moves.py` and `rdkit.six.moves.py` to `rdkit.six.moves.py` and `rdkit.six.moves.py` to `rdkit.six.moves.moves.py` to `rdkit.six.moves.moves",
          "reference": "I'm not going to stop accepting the PR, but I really hate these artifacts getting dropped in the Python code just to stop things like coverage checkers and linters from complaining."
        },
        {
          "prediction": "I don't think we need this year anymore.",
          "reference": "FYI modifying an existing file generally doesn't invalidate the copyright date. The date here is when the copy right _begins_, so moving it later is arguably misleading-it still applies. Not a big deal, just something I've seen a few times in passing."
        },
        {
          "prediction": "I don't think we need to change this.",
          "reference": "Because the default value of allowedOrigins is * (all origins), so it isn't necessary to set again at all."
        },
        {
          "prediction": "I think this should be `checkNotNull(namespace, \"Warehouse location is not set: hive.metastore.warehouse.dir=null\")`",
          "reference": "Style: indentation should be 4 spaces (2 indents) from the start of `Preconditions`."
        },
        {
          "prediction": "I think this should be `$toManyAssociations = array(ClassMetadataInfo::ONE_TO_MANY, ClassMetadataInfo::MANY_TO_MANY));`",
          "reference": "I don't know why I suggested a html attribute at first (my bad), or maybe you think it makes sense. Otherwise, what about a simple class?"
        },
        {
          "prediction": "I'm not sure if this is a good idea. I think it's a good idea to have a `tracker_root` variable that's set to `UoE` and then set it to `UoE`. I think it's a good idea to have a `tracker_root` variable that's set to `UoE` and then set it to `UoE`.",
          "reference": "Probably want something more generic here like 'DMPRoadmap' so that other installations aren't using UoE by default."
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "Must this not change to `MustBeRethrownImmediately`?"
        },
        {
          "prediction": "I think we should remove this line.",
          "reference": "Can it be pointer?"
        },
        {
          "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.",
          "reference": "Not related to this issue but this condition seems weak."
        },
        {
          "prediction": "I think this should be `isset($this->mainConfig->Record->preferredMarcField) && array_key_exists($this->mainConfig->Record->preferredMarcField, $this->fields))? $this->mainConfig->Record->preferredMarcField : 'fullrecord';`",
          "reference": "I think this might be a little more readable in two lines as: 
     $preferredMarcField = $this->mainConfig->Record->preferredMarcField?? 'fullrecord'; $marc = trim($this->fields[$preferredMarcField]?? $this->fields['fullrecord']); 
    " }, { "prediction": "I don't think this is needed anymore.", "reference": "does this still allow this file to be used with Python installations that don't have numpy?" }, { "prediction": "I think this should be `a-z1-9`", "reference": "what about 0? Version probably can' start with 0, but v10 is theoretically possible." }, { "prediction": "I don't think this is needed.", "reference": "Usually we consider APIs that have filesystem interactions to be part of IFileHelper, this would allow us to inject a testable implementation easily. `Path.IsRootedPath` doesn't access the file system. It is string comparison I believe." }, { "prediction": "I don't think we need to change the status here.", "reference": "Do we need to use quote? Why not `status: Init`" }, { "prediction": "I'm not sure why this was removed.", "reference": "Nice catch! I don't think I would have caught that, did you search the whole code base for pre-existing functions?" }, { "prediction": "I think this test should be `testClusterDeploymentWithoutRegionLabel()`", "reference": "Remove this line." }, { "prediction": "I'm not sure why this is removed.", "reference": "This is no longer called in any of our unit tests, right?" }, { "prediction": "I'm not sure if this should be `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32` or `uint32`", "reference": "I think typically K8s APIs will use `int32` and not `uint32`. I think we should keep it consistent with the rule `Priority` above. I believe that the rationale for using `int32` in general is: * some programming languages don't have native support for unsigned integers * it's easier to catch sign errors with signed integers, depending on the programming language (it it's negative, it's clearly an error but if it's a very large number, it could be normal or it could be a negative number overflow)" }, { "prediction": "I'm not sure if we should add this column to `plans` table. I'm not sure if we should add it to `plans` table, but I think we should add it to `plans` table.", "reference": "If you end up changing grant to an association, this may need to change to a reference to enforce the foreign_key `add_reference :plans, :grant`" }, { "prediction": "I don't think this is needed anymore.", "reference": "This won't work because `notification` comes from an API response here. I think this would be the same as the change to `Alert` where it would get `SmallSunSVG`." }, { "prediction": "I'm not sure if this is a good idea.", "reference": "This is not checked below?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Will this ever return a \"Stack does not exist\" error? Should we handle it silently here rather than making higher level packages do error checking?" }, { "prediction": "I'm not sure if this is the right place to import `package_registry` or `get_package_registry`", "reference": "minor: at this scale, one import per line reads better" }, { "prediction": "I don't think we should change this to `{\\\"org\\\":[]}\"`", "reference": "Should remove the default templates as well." }, { "prediction": "I'm not sure if this is a breaking change, but I'm not sure if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, it's a breaking change, or if it's a breaking change, it's a breaking change, or if it's a breaking change, it's a breaking change, or if it's a breaking change, it's a breaking change, or if it's a breaking change, or if it's a breaking change, it's a breaking change, or if it's a breaking change, or if it's a breaking change, it's a breaking change, or if it's a breaking change, or if it's a breaking change, it's a breaking change.", "reference": "Why not `let`?" }, { "prediction": "I think this should be `org.apache.commons.logging.Logger.logStartupInfo(false)`", "reference": "ns -> DNS My first reading was this is referring to System.nanoTime and thought hrm?" }, { "prediction": "this is a vestigial parameter that is not used and will be removed in the future check.opt_str_param(scheduler, \"scheduler\")", "reference": "is there a reason not to remove the param now? I think the serdes will still work?" }, { "prediction": "I don't think we need to change this test.", "reference": "`places=2` seems to be very poor comparison. Do you have any thoughts why is it fail with more strict checks?" }, { "prediction": "I don't think this is the right place for this, but I think it's better to use `logger.info(\"Project \" + name + \" doesn't exist in cache, fetching from DB now.\");`", "reference": "should we make level debug? Also just FYI, with debug level, we can add more detailed logging for better debuggability without concerning overwhelming logging message" }, { "prediction": "I don't think this is needed anymore.", "reference": "I needed to add this import for Sphinx to inspect C++ runtime objects properly. This should be the only code change in this PR." }, { "prediction": "I don't think this is needed.", "reference": "Changes in this file aren't related to the PR, are they? You took the opportunity to change the group deletion to using the subscriber too?" }, { "prediction": "I don't think this is needed.", "reference": "I'd probably move this into `MetricsConfig` as a private method. Seems like we only use it there." }, { "prediction": "I'm not sure if this is the right thing to do here.", "reference": "Not clear here what you mean with this list" }, { "prediction": "I think this should be `@SuppressWarnings(\"checkstyle:InnerAssignment\")` and not `@SuppressWarnings(\"checkstyle:InnerAssignment\")`", "reference": "Curious, is there a way we can get around this without suppressing?" }, { "prediction": "I think this should be `sessionInstance.ProposalID = proposalID`", "reference": "I don't think we this field in session, it's a serial number for proposal but not unique index itself" }, { "prediction": "I don't think this is needed.", "reference": "Can't have two benchmarks with `Baseline = true`" }, { "prediction": "I don't think this is needed.", "reference": "Same here: Empty line before and no `Internal dependencies` docblock (mandatory anyway once #217 lands)." }, { "prediction": "I think this should be \"The configuration file name.\"", "reference": "sorry, the default value for this field is no longer allowed?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Why does this work? I'd've expected that an admin could create a file anywhere." }, { "prediction": "I'm not sure if this is the right place to use `config[:configuration] || 'Release'` or `config[:platform] || 'x64'`", "reference": "falling back to `x64` seems like a really bad idea given that the VS templates default to x86 these days." }, { "prediction": "I don't think we need to change this test.", "reference": "Bit surprised by this. I would have thought either you want to set it for both mpl and bokeh...or alternatively it was only ever meant for bokeh and was always wrong?" }, { "prediction": "I think this should be `if node.as_string().startswith('from.')`", "reference": "Check modname instead, but only if it's a ImportFrom." }, { "prediction": "I don't think we need this. I'm not sure if we need it.", "reference": "How about `write.metadata.previous-versions-max`? No need to refer to these as a log." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it.", "reference": "We generally do this via tags in the Rakefile, not separate environment variables." }, { "prediction": "I don't think this is needed.", "reference": "Update after command rename" }, { "prediction": "I don't think we need to check if `self._predictedFieldName in self._input` is not None.", "reference": "`if X not in Y:`" }, { "prediction": "I think this should be `10`", "reference": "Do we know why the pool is exhausted? In the past, we had a few leaks in the Spark catalog code which led to this. It can be also a valid use case too if we simply need a larger pool." }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do this.", "reference": "Logging in Bolt still seems to be a little messy. I think this is more correct than what I had before, but made sure I wouldn't overwrite an existing level. And if console logging gets more options, both debug and verbose need to be fixed here." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "This could be simplified (if including is fine): `auto address_string = boost::algorithm::erase_first_copy (address.to_string (), \"::ffff:\");`" }, { "prediction": "I think this should be `LOG.info(\"Registered a node \" + proxy);`", "reference": "This is wildly unhelpful to users --- they need to know when a proxy has been registered." }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "Why do we need `do_not_validate_attachment_file_type` is we're doing it in the previous line?" }, { "prediction": "I think this is a breaking change. I think it's a breaking change.", "reference": "Loading login page right away only for the regular use case." }, { "prediction": "Do not recursively re-render of a component and it's children?", "reference": "IIRC this flag disables re-rendering entirely (`s/recursively //`)" }, { "prediction": "I don't think this is needed anymore.", "reference": "Did you test this redirect? @thornbill mentioned it might need `web` at the front, but if this works fine I'd rather leave it this way." }, { "prediction": "I'm not sure why this is removed.", "reference": "FYI, this returned `StringValues` which is a value type (aka can never be null)." }, { "prediction": "I think this should be `c.ConstInt(c.uintptrType, 8, false)`", "reference": "Oh no, that's a bug." }, { "prediction": "I'm not sure if this is the right thing to do here. I'm not sure if it's the right thing to do here.", "reference": "Let's leave a note in CHANGES to replace this with an error metadata struct or interface, unless it would be less effort overall to take a run at it in this change." }, { "prediction": "I'm not sure about this, but I'm not sure if this is a breaking change. I'm not sure if it's a breaking change, or if it's a breaking change, but I'm not sure if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, or if it's a breaking change, I'm not sure.", "reference": "The changelog entry does a better job of explaining how this is used than this description. In particular, this says that you need to set `mapTo` if the underlying name is different, but not that `mapTo` *is* the underlying name." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "These imports will probably need to be refactored so they aren't here. That applies for all of the database drivers. The reason for this is because we sometimes want a driver to be available and sometimes we don't. When we include this library in our cloud offering, the sqlite3 connector needs to be gone because it's a security vulnerability and there's no use case for it in a cloud environment. But for flux itself, I can see how sqlite3 would be really useful and so I like this change. But this import needs to only exist within the tests and within the `cmd/flux` package. It cannot be here." }, { "prediction": "I don't think we need this anymore.", "reference": "We can use `getQualifiedKeyName` here instead. I will update." }, { "prediction": "I don't think we need to do this anymore.", "reference": "Could you clarifty why some of those are removed?" }, { "prediction": "I'm not sure if this is the right place to call this function, but I think it's better to call it `ListDeploymentConfigTemplatesResponse` instead of `ListDeploymentConfigTemplates`.", "reference": "`ctx` is unused in ListDeploymentConfigTemplates" }, { "prediction": "I don't think this is the right place for this.", "reference": "nice to see the usage of block for a more readable link name" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Can these use `static_cast` instead? Other than that, it's fine." }, { "prediction": "I think this should be removed.", "reference": "This output is only present when `DEBUG=True`. Does it really bother so much?" }, { "prediction": "I don't think this is needed anymore.", "reference": "I think it should pass wallet transaction as well, otherwise there will be 2 wallet read transactions in 1 threads (next in scan_receivable)" }, { "prediction": "I'm not sure if this is a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug.", "reference": "RDKit::Utils is now in the namespace for localeswitcer... We could change it to something else." }, { "prediction": "I'm not sure if we need to flatten the tuple.", "reference": "@itholic, can we fix it in `_normalize_keyword_aggregation`?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea.", "reference": "It seems like we have the main plan in the database but the downgrade plan in the code. Probably okay for now, but as our thinking of how downgrades/plans develops we may want to consolidate." }, { "prediction": "I think this should be `WebDriverException.scheduleIpHostResolving()`", "reference": "we shouldn't add a bunch of static initializers 'everywhere' in the code. Probably just one would be good, during the construction of the 'RemoteWebDriver' class." }, { "prediction": "I'm not sure if this is a good option.", "reference": "do we need both flags? maybe infer that `clef-signer-enabled` whenever `clef-signer-endpoint` is defined?" }, { "prediction": "I don't think this is needed.", "reference": "Do we need this? I didn't see css files (only scss)." }, { "prediction": "I don't think this is the right way to do this, but I think it's better to use `is_local_interface(host)` instead of `is_local_interface(host)`", "reference": "This feels like a weird `if not... or not` to me. Can you talk out the intent here?" }, { "prediction": "I'm not sure if this is the right place to do this, but I think it's better to put this in the `AnnualBillingMailer` controller and use `AnnualBillingMailer.notification(current_user).deliver` instead of `AnnualBillingMailer.notification(current_user).deliver` in the `AnnualBillingMailer` controller.", "reference": "Align the parameters of a method call if they span more than one line." }, { "prediction": "I don't think we need this package anymore.", "reference": "`@package *` can be removed as well." }, { "prediction": "I don't think we need this anymore.", "reference": "@ScottGarman is there a reason that `redhat_fips` needs to be a beaker platform? Why can't it be another platform that beaker just understands as `redhat`?" }, { "prediction": "I think we should remove the raft service from the store.", "reference": "Where is the other place?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Are you subclassing from `UserList` instead of `list` to satisfy some constraint of Jython? My main concern here is that this is a subtle breaking change to the API because `UserList` is not a subclass of `list`. This has the unfortunate side effect of breaking any user that is using `isinstance` checks to see if a `ResultSet` is a `list`." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if it's the best way to do this.", "reference": "We can DRY the above three functions" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to have a `Supplier>, HashMap>` method. If it's a good idea to have a `Supplier>, HashMap>` method, I'm not sure if it's a good idea to have a `Supplier>, HashMap>` method. If it's a good idea to have a `Supplier>, HashMap>, HashMap>` method, I'm not sure if it's a good idea to have a `Supplier>, HashMap>` method. If it's a good idea to have a `Supplier>, HashMap>` method, I'm not sure if it's a good idea to have a `Supplier>, HashMap", "reference": "Only no good is good code. Nice that you were able to remove all this duplicate stuff!" }, { "prediction": "I don't think we need to change this. I think we should change this to \"RetrySettings\" instead of \"RetrySettingsType\"", "reference": "Looking at the code, it seems very odd that this method even exists in the SurfaceNamer, since it is only implemented and used in the PhpSurfaceNamer, and in fact the RetrySettings class name is hardcoded elsewhere. WDYT of just removing this method from SurfaceNamer and PhpSurfaceNamer?" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if it's the best way to do this.", "reference": "these interfaces are defined twice. we should use only one and have it in `storage` package maybe" }, { "prediction": "I don't think this is needed anymore.", "reference": "This is the wrong context for usage of `global` keyword. It need only be used inside functions." }, { "prediction": "I think this should be `if (targetType.isAssignableFrom(child.getClass())) { results.add(targetType.cast(child)); } else { if (targetType.isAssignableFrom(child.getClass())) { results.add(targetType.cast(child)); } else { if (targetType.isAssignableFrom(child.getClass())) { results.add(targetType.cast(child)); } }`", "reference": "this change should be described in the changelog. I'll update it when merging if nothing else arises." }, { "prediction": "I'm not sure if this is the right place to create a dispatcher.", "reference": "Just to stay consistent with naming let's call it CreateGRPCDispatcherForOutbound. Also rename 'CreateDispatcherForOutbound' to 'CreateTChannelDispatcherForOutbound'" }, { "prediction": "I'm not sure if this should be finest, but it seems like it should be finest.", "reference": "This will always need to be displayed to users." }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if it's the best way to do it. I'm not sure if this is the best way to do it, but I'm not sure if it's the best way to do it.", "reference": "This looks very much like `repr` now (we miss 127 though) - maybe just do `repr(x)` + strip outer parantheses?" }, { "prediction": "I think this should be `&taskInfo.VisibilityTimestamp` instead of `&taskInfo.VisibilityTimestamp`.", "reference": "I don't see this field is set in task_generator.go. worth to double check if we put the timestamp when creating replication tasks." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "nit: I prefer the space before and after this check to make it very easy to scan when reading through code" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do it.", "reference": "should users also do a triple-flush?" }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to remove it from the test.", "reference": "What is the implication of removing these from the test? I thought the idea was to have all types supported by `docstore` here, and do things in the drivers to make them support them (e.g., list of size 2 for complex). If you're removing them because firestore doesn't have native support, then we're going to end up only testing the intersection of all types supported by all drivers; we need a better way." }, { "prediction": "I'm not sure if `vals` should be a `list` or `list`?", "reference": "Let's also adjust the somewhat weird type signature here as well. This probably should be `typing.Any` instead of `str` in the last line if we intend to support ints." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "The body can just be `os.RemoveAll(dir)`" }, { "prediction": "I don't think we need to change this. I think we should change this to `castToDouble(value)`", "reference": "Is this covered by regression tests? Also you might make a patch onto refactor branch." }, { "prediction": "I don't think this is needed.", "reference": "This is maybe more of an admin request? WDYT?" }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if it's the right thing to do here.", "reference": "Here I thought of `toHashMap` and later add `toTreeMap`. But I start to see, what you may have in mind. Alternatively we could provide a `toMap` and `toSortedMap`, which is great, too. On the other hand is always good to be as specific as possible. What do you think?" }, { "prediction": "I think this should be `localProjectAppNames []string`.", "reference": "maybe localProjectAppNames? Just a thought." }, { "prediction": "I don't think this is needed.", "reference": "This isn't new, but getHeightWidth is now defined in block_svg.js, block_render_svg_horizontal.js, and block_render_svg_vertical.js. One of these should be unnecessary." }, { "prediction": "I think this test should be `WaitForAllTxnsToConfirm(curRound+5, txids)`", "reference": "I can't see any reason why this would fix a failure in `a.True(confirmed, \"txgroup\")`. We might have an issue elsewhere, but increasing the wait time wouldn't help." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "This section needs to be modified; crontab format differs between OS releases (Debian and CentOS, at least)." }, { "prediction": "I think this should be `True` or `False`", "reference": "if we think this is likely to be augmented with a additional 'run coordination' features or configuration in the future, we could make it an object of some kind instead (or an enum, if we think there may be other resume modes in the future besides just on/off). Just imagining 6 months in the future, it would be unfortunate if there were 7 new args here as the feature gets more complex" }, { "prediction": "I don't think we need to import grid_sample here.", "reference": "`affine_grid` and `grid_sample` are currently unused. We may remove it from `ops/__init__.py` to speedup the loading of mmdet." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do it.", "reference": "Is there a reason why you need to support negative `AttackTimeout`? Why not just throw an error?" }, { "prediction": "I don't think we need to import pyspark.sql.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.functions.", "reference": "nit: an unnecessary change?" }, { "prediction": "I don't think this is needed.", "reference": "Is trailer parsing something we have to do in this PR? It would be really helpful to separate stuff like this into smaller, self-contained PRs." }, { "prediction": "I think this should be `wait_for { ready? }` instead of `wait_for { ready? }`", "reference": "Any chance of a wait-forever situation here? Is there a reasonable timeout?" }, { "prediction": "I'm not sure if this is the right fix, but I'm not sure if this is the right fix or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug or if it's a bug).", "reference": "line is 165 characters" }, { "prediction": "I think this should be `if clusterConfig.FrontendAddress == \"\" { // Poke all the in-process namespace caches to refresh without waiting for the usual refresh interval. } else { // Wait for one whole cycle of the namespace cache v2 refresh interval to be sure that our namespaces are loaded. }`", "reference": "is this for cross DC case?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Remove this line." }, { "prediction": "I don't think we need to do this anymore.", "reference": "Maybe it would make sense to use `webmVideoCodecs` here and just append `vpx`. I'm not sure if av1 is currently supported when transcoding to webm though. It looks like it can be included in the mp4 transcoding profile now." }, { "prediction": "I don't think we need this anymore.", "reference": "Interestingly, this has nothing to do with replication, no clue what this means here" }, { "prediction": "I'm not sure if this is the right way to do it.", "reference": "Is that because we don't provide a UI for these?" }, { "prediction": "I don't think we need to do this. I'm not sure if we need to do this.", "reference": "Standard is either to use `HappyPath` (CamelCase) or `happy path` (lowercase sentence). I usually prefer the latter." }, { "prediction": "`blkRegistryOption := blockchain.RegistryOption(®istry)`", "reference": "instead of using blkMemDao, we could generate a blockMemDao, and then use it as the second parameter." }, { "prediction": "I'm not sure if this is the right place to call this function.", "reference": "nit(2/10): `topology && topology.description!= null`;" }, { "prediction": "I don't think this is needed.", "reference": "why the space? I may not know all the style conventions." }, { "prediction": "I don't think we need this test, but I think it's better to use `assert.isTrue(checks.dlitem.evaluate.apply(null, checkArgs));` instead of `assert.isFalse(checks.dlitem.evaluate.apply(null, checkArgs));`", "reference": "Should be \"should fail if the **dt element** has a parent
    with a changed role\"" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Just to be clear: 1. This is required for compression, right? 2. This won't actually result in our dynos serving the assets, since they'll be served via the CDN, correct?" }, { "prediction": "Why remove this warning?", "reference": "not sure about removing this ping @Soullivaneuh" }, { "prediction": "I don't think we need to pass `scheduled_for_deactivation_on` to `scheduled_for_deactivation_on`", "reference": "Put a comma after the last parameter of a multiline method call." }, { "prediction": "I think this should be `expects error when instance could not be found: %v`.", "reference": "If instance could not be found when the provider id is set, `findInstance()` returns `ErrInstanceNotFoundByID` error. So that during reconcileNormal(), we don't create a new instance. In `reconcileDelete()`, when ErrInstanceNotFoundByID is seen, deletion continues to clean up even if the instance is gone (may be manually deleted)." }, { "prediction": "I don't think we need to store this in `_skylineWindow.Document`", "reference": "I would recommend making this a Tuple<ReplicateValue, IColllection<object>> You only need to convert things to strings if you need to persist them in Settings or something. If they only need to live for the life of dialog, you can keep everything as objects. You can use \"null\" for the ReplicateValue for when they have not chosen a property." }, { "prediction": "I don't think we need to change this.", "reference": "I think there is no point providing action key here, as it will be called specifically, rather than randomly" }, { "prediction": "I don't think we need this anymore.", "reference": "`XUnitIntegration` doesn't need to cache this anymore." }, { "prediction": "I think this should be `631` and not `631`.", "reference": "Can we have something line `# noqa` there instead? I think it's fine like this though." }, { "prediction": "I'm not sure if this is the right place to do this. I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "this variable is used in both branches so I've decided to declare it above" }, { "prediction": "I don't think we need to set the FLAG_ACTIVITY_SINGLE_TOP flag here.", "reference": "`setFlags()` overwrites the previous flag, we should be using `addFlags()` to append flags." }, { "prediction": "I don't think this is needed.", "reference": "Need `return` after this." }, { "prediction": "I think this trait should be `CacheableResponseTrait` instead of `CacheableResponseTrait`.", "reference": "I would say we should not use the `CacheableResponseTrait` within the `JsonResponseTrait`. Traits within traits tend to lead to a bad developer experience as it can be really hard to find the actual method you're seeing in the implementing class, and in this case it looks like we're using _both_ the cacheable and the JSON traits in the same controller, so it's redundant anyway. I'd recommend just removing that use statement from `JsonResponseTrait` and make sure `ChaceableResponseTrait` is included everywhere it's needed specifically." }, { "prediction": "I think this should be `LOG.info(String.format(\"XPUB binding to %s, XSUB binding to %s\", xpubAddr, xsubAddr));`", "reference": "This change is unhelpful: it precludes users from knowing which ports are being used for what purpose within the system." }, { "prediction": "I'm not sure if this is the right place for this method. I'm not sure if it's the right place for this method, but if it's the right place for this method, I'm not sure if it's the right place for this method.", "reference": "Whoa, we weren't doing this before?? Derp." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "I'm surprised we didn't go with something like `flow := f.Flow.Copy()` to take care of all the fields at once, but as long as it works it's good enough for me" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea or not.", "reference": "We would like this code to run, even when `config.XDPEnabled` is false, so that Felix can clean up its own XDP state after a restart." }, { "prediction": "I don't think this is needed.", "reference": "I'd declare this field `qualifiedName` private to hide it. Unless it really needs to be modified from somewhere else... (e.g. unit tests..), but then, we should find a solution, where this field can stay private." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.", "reference": "is this exhaustive? or rather, any psudo header started with `:` is un-parsable/invalid in HTTP/1 right?" }, { "prediction": "I'm not sure if this is the correct behavior.", "reference": "Is this change implying something or just seems fit b/c regardless of outcome the sessions should still be length 1?" }, { "prediction": "I don't think we need to hard-code the zero-index here.", "reference": "Maybe throw an exception if there is more than one, so that discovering the lack of support is easier when someone tries to use it down the road." }, { "prediction": "I don't think we need this route anymore.", "reference": "Prefer single-quoted strings when you don't need string interpolation or special symbols." }, { "prediction": "I'm not sure if this is the right place to call this function. I'm not sure if it's the right place to call this function.", "reference": "I feel the name of this function could be better, conveying it's a predicate. Something like `HasDockerTestEnvironment` or `CanRunLocalServerTests`, etc." }, { "prediction": "I don't think we need to change this.", "reference": "This seems unrelated to your PR, how did this end up in here?" }, { "prediction": "I think this should be `String.toLowerCase()`.", "reference": "Is `username` expected to be case insensitive?" }, { "prediction": "I don't think this is needed anymore.", "reference": "File is not `gofmt`-ed with `-s` (from `gofmt`)" }, { "prediction": "I don't think we need to deprecate the `TimeTracker` class.", "reference": "Is there any point to the deprecation? If someone was using these APIs, can they continue to do so in any meaningful fashion now that you've disconnected them from the PMD internals? Normally \"compiles but doesn't work\" is considered a bug." }, { "prediction": "`str` is a better name than `str`", "reference": "You can remove the `QItemSelection` import in this file now." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Use `std::shared_lock` and `std::try_to_lock_t`. BTW. Why we fail on contention?" }, { "prediction": "I don't think this is the right thing to do.", "reference": "Not sure what this actually does, but do you need to add `\"\"` here? Or does `[\".jsx\", \".js\"]` work too?" }, { "prediction": "I don't think this is needed.", "reference": "let's group imports in the order: std third party first party" }, { "prediction": "I'm not sure if this is the right place for this test, but I'm not sure if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test, or if it's the right place for this test.", "reference": "So the tests run only when the db exists? Else everything passes?" }, { "prediction": "I think this should be `io.Writer` instead of `io.Closer`.", "reference": "`Remove` is unclear. It seems the point is to allow the `FifoByteSink` to delete the underlying file. There seems to be an implicit contract that consumers of this interface call `Remove` after `Close` without necessarily understanding what `Remove` does. I get that it's a little awkward to have `FifoByteSink` delete the file in `Close`. It would probably be best to just remove this from the interface, since `AddSink` is working with an actual `FifoByteSink`. I would rename it in `FifoByteSync` to `DeleteFile` or `Cleanup` or something that's makes it more clear what's being removed." }, { "prediction": "I think we should move this to a separate file.", "reference": "Mentioned elsewhere but repeating again: would be nice to have units (ideally `Size *Bytes`)." }, { "prediction": "Line is too long. [89/80]", "reference": "I think a test in `spec/integration` might help keep this file a bit more manageable, especially since we're just checking file contents and errors. But basically the same idea!" }, { "prediction": "I'm not sure why this was removed.", "reference": "This spec can be modified, giving you extra strength (Check this fetch key doesn't work and therefore returns `nil`)" }, { "prediction": "I'm not sure if this is correct. I'm not sure if this is the right thing to do.", "reference": "So this means that we can remove a callback via instr_set_label_callback(). Maybe consider adding another API function for removal, and add a new assert here such that cb!= NULL?" }, { "prediction": "I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "why are we using an instance variable instead of accessing the visibility method?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Ok. Can we just disable this linter?" }, { "prediction": "I don't think this is needed anymore.", "reference": "this is `test_data` and all other instances are `testdata` - does this change affect any test files, or are there actually no directories called `test_data` in the repo? (I just checked, it seems like there aren't...)" }, { "prediction": "I don't think this is needed anymore.", "reference": "Fixing `lint` warnings that have existed for a while." }, { "prediction": "I don't think this is a good idea.", "reference": "Better to rename this to CASDefaultCstorSparsePool." }, { "prediction": "I think we should move this method to `awsClientFactory.close()` so that we don't have to call `close()` twice.", "reference": "Since we'e not 100% sure if `close` will be called more than once, should we set `client` to `null` or add an `AtomicBoolean closed` that will then handle the idempotency issue?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "And here - what happens if name id is invalid" }, { "prediction": "I don't think this is needed.", "reference": "__toString() is not a part of QueryInterface" }, { "prediction": "I don't think this is needed anymore.", "reference": "nit: Could you add an empty line between `import datetime` (built-in library block) and `import numpy as np` (third-party library block)?" }, { "prediction": "I don't think this is needed.", "reference": "Please remove `HIP_UNSUPPORTED`" }, { "prediction": "I don't think this is needed.", "reference": "Having boolean parameters to change function behavior is not a good practice because it violates the principle of functions being responsible for a single task, so the need for this indicates we need to split something out of here instead. We can introduce a function like `getCurrentDateRangeDayCount` or similar, which does this." }, { "prediction": "I'm not sure why this was removed.", "reference": "Is this not required?" }, { "prediction": "I'm not sure if this is still needed.", "reference": "savedStates is for confirmed states, not needed in working set" }, { "prediction": "I'm not sure if this is the right place to do this.", "reference": "Why should we move it into `bootstrap.go` file?" }, { "prediction": "I don't think this is needed.", "reference": "In the next major version, I plan on changing the em-unit breakpoints to be pixel values to keep everything consistent. Would be great to handle this with pixels as well, but still allow em-units to be defined with a string" }, { "prediction": "I'm not sure if this is the right place to use `str(idx + 1).rjust(2)` or `str(idx + 1).rjust(2)` or `str(idx + 1).rjust(2)` or `str(idx + 1).rjust(2)` or `str(idx + 1).rjust(2)` or `str(idx + 1).rjust(2)` or `str(idx + 1).rjust(2)` or `str(idx + 1).rjust(2)` or `str(idx + 1).rjust(2)` or `str(idx + 1).rjust(2)` or `str(idx + 1).rjust(2)` or `str(idx + 1).rjust(2)` or `str(idx + 1).rjust(2)` or `str(idx + 1).rjust(2)` or `str(idx + 1).rjust(2)` or `str(idx + 1).rjust(2)` or `str(idx + 1).rjust(2)` or `str(idx + 1).rjust(2)` or `str(idx + 1).rjust(2)` or `str(idx + 1).rjust(2)` or `str(idx + 1).rjust(2)` or `str(idx + 1).rjust(2)`", "reference": "I don't think this will actually align the indexes, if you have > 100 tabs, the tabs over 100 will be misaligned. In addition with less than 10 tabs, there will be a pointless space." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "hrm, unsigned headers now won't be included." }, { "prediction": "I think this should be `strlen($value) >= 256`", "reference": "what if `$value ='' `?" }, { "prediction": "I don't think this is the right place to do this.", "reference": "What about using `!files.hasNext` instead? I'm not sure we want to assume that the iterable can be consumed multiple times. Plus there's no need to consume the entire iterable just to check whether it is empty." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "I think we could add bool addArticle here defaulted to false like its done in item class so std::string Container::getName(bool addArticle /* = false*/) const { and pass that variable to getNameDescription call" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "What if a library function on the outside still calls the old method? It is then no longer blocked properly. Have you tested the change?" }, { "prediction": "I'm not sure this is the right place to do this.", "reference": "@i110 Do you have an idea on how we should propagate errors that occur in this block? The error condition happens when i) `h2o_buffer_reserve` fails to allocate space (happens in master as well), or ii) `fill_cb` returns an error (unique to this PR)." }, { "prediction": "I don't think we need to change this.", "reference": "Does this mean the times will show up in emails as UTC?" }, { "prediction": "I don't think we need to change this.", "reference": "What's the motivation for having one of these be a cycle and the other be a fixed color?" }, { "prediction": "I don't think we need to remove empty entries from table.ToMarkdown().Split(Environment.NewLine, StringSplitOptions.RemoveEmptyEntries))", "reference": "What will be an empty entry now?" }, { "prediction": "I don't think we need this.hot.isRtl()? 'right' : 'left' : 'right'", "reference": "Can I ask you to add jsdoc tag that would mark the prop as `@private`?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "Do you need this? Don't think you use it?" }, { "prediction": "I don't think this is needed.", "reference": "`this.` seems unnecessary" }, { "prediction": "I don't think we need to change this?", "reference": "nit: can be removed before merging..." }, { "prediction": "I'm not sure if this is the right place for this test.", "reference": "Maybe a single quote would be compatible with airbnb style." }, { "prediction": "I'm not sure this is the right place for this method, but I think it's better to move this method to SessionMap.", "reference": "This is not the right approach. The `Distributor` maintains a model of the current state of the Grid. That model already contains the information about every active session. We don't need to modify `SessionMap` to expose it further." }, { "prediction": "I'm not sure if this is the right place for this change.", "reference": "@Marwes @wolffcm This is the file where I made a change the the expected output. Its a little bit weird, but I think that the final output makes sense for the most part." }, { "prediction": "I think this should be `nil` instead of `nil`.", "reference": "I think we probably need a util.Warning() here." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it. I'm not sure if this is the right place to do it.", "reference": "Let's make have a signature that's consistent with `PhysicalKey.from_path`. Users should also have access to PhysicalKey since that class is part of the API (e.g., `Package.resolve_hash`)." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.", "reference": "What is this directive for?" }, { "prediction": "I think this should be \"chained comparisons like \"a < b and b < c\" or \"a < b < c\" or \"a < b < c\" or \"a < b < c\" or \"a < b < c\" or \"a < b < c\" or \"a < b < c\" or \"a < b < c\" or \"a < b < c\" or \"a < b < c\" or \"a < b < c\" or \"a < b < c\" or \"a < b < c\" or \"a < b < c\" or \"a < b < c\" or \"a < b < c\" or \"a < b < c\" or \"a < b < c\"", "reference": "I'd rephrase it as `Simplify chained comparison between the operands`." }, { "prediction": "I think we should remove this line.", "reference": "so in the performance data fixtures, there will be references for the second domain only?" }, { "prediction": "I think this should be `LOG.info(\"Registered a node \" + proxy);`", "reference": "This is wildly unhelpful to users --- they need to know when a proxy has been registered." }, { "prediction": "I don't think we need to change this.", "reference": "If there is no authority header (i.e. someone intentionally deleted it), I would argue we probably don't want a Host header in the replay either. How about we only add it if it exists, and do nothing otherwise?" }, { "prediction": "I think we should remove the `Error` from the `ResponseMetadataHandler` as it's not used anywhere else.", "reference": "is there any unit test that can be updated to verify this?" }, { "prediction": "I don't think this is the right place to do this, but I think it's a good idea to move this check into the `if (ctx->protected_mode)` block. I think it's better to move this check into the `if (ctx->protected_mode)` block, and move the `if (ctx->protected_mode)` block into the `if (ctx->protected_mode)` block.", "reference": "exiting at this point is leaking memory, take a look at the valgrind output. the sbuffer must be destroyed." }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to add a `markexpr=None` option to the `markexpr=None` option, or if it's a good idea to add a `markexpr=None` option to the `markexpr=None` option, or if it's a good idea to add a `markexpr=None` option to the `markexpr=None` option, or if it's a good idea to add a `markexpr=None` option to the `markexpr=None` option, or if it's a good idea to add a `markexpr=None` option to the `markexpr=None` option, or if it's a good idea to add a `markexpr=None` option to the `markexpr=None` option, or if it's a good idea to add a `markexpr=None` option to the `markexpr=None` option, or if it's a good idea to add a `markexpr=None` option to the `markexpr=None` option to the `markexpr=None` option to the `markexpr=", "reference": "i think you want a different flag and help like `--ffmpeg` or something; and you need to mark any tests you want skipped" }, { "prediction": "I'm not sure if this is the right place for this change.", "reference": "this needed to change? or it was just some formatting thing?" }, { "prediction": "I don't think this is needed anymore.", "reference": "What's the advantage of doing it this way over, say, changing the `.circleci/config.yaml` to have `TRACE` as the `root.log.level`?" }, { "prediction": "I don't think this is needed.", "reference": "typo: if -> of" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "It'll be interesting to see who or what this breaks..." }, { "prediction": "I think this should be `log.finest(\"In dev mode. Copying required files in case we're using a WebDriver-backed Selenium\")`", "reference": "This change is incorrect: the current log level is correct." }, { "prediction": "I'm not sure if this is the right place for this.", "reference": "There are few cases like this where default logger is used from CLI/db tools. I would copy `NewTestLogger` to `NewCLILogger` and use it everywhere in CLI. In future these two might be different." }, { "prediction": "I don't think we need to do this. I think we should do this in a separate PR.", "reference": "While it provides re-use, this method does not make sense in `AbstractAuthenticationToken` because it knows nothing of a hash key. Instead, we should move this to a private method within each subclass." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "index by memory address? I realize I don't understand why we don't just build a list :)" }, { "prediction": "I don't think this is needed.", "reference": "Not part of this commit, but we thought that this may not be a good place for this url, as it is in the `/user/` namespace (effectively preventing us having a user called `lastfmscraper`, however rare it may be)" }, { "prediction": "I don't think this is needed.", "reference": "Does not appear to be used." }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it.", "reference": "I think this starts a new `powershell.exe` interpreter each time, which is pretty slow to run a single command. Can we just do `on(bolt, \"cmd /c #{bolt_command}\")`? /cc @Iristyle" }, { "prediction": "@video_page.purchaseable.collection? is the same as @video_page.purchaseable.collection?", "reference": "Can we add a `collection?` method to the `VideoPage` so we don't violate Law of Demeter here?" }, { "prediction": "I'm not sure why this was removed.", "reference": "Deleting unused code." }, { "prediction": "I don't think this is needed anymore.", "reference": "`PseudoSampler` can also be imported from `..bbox`" }, { "prediction": "I'm not sure if this is the right place to import agreementtest.go.", "reference": "Could you move this import to where the other `github.com/algorand/go-algorand` imports are?" }, { "prediction": "I don't think we need to change this?", "reference": "I'd rather not activate this protocol by default for now, unless there is a good reason for that." }, { "prediction": "I don't think we need to import `DataAccess` from `google.cloud.forseti.services.inventory.storage`", "reference": "Remove these 2 blank lines." }, { "prediction": "I'm not sure if this is the right thing to do here, but I think it's better to use `fmt.Printf(\"aa: %x\", tx.Hash())` instead of `fmt.Printf(\"aa: %x\", tx.Hash())`", "reference": "Want to remove this?" }, { "prediction": "I don't think this is needed anymore.", "reference": "is this a golint requirement? huh. mixed feelings :)" }, { "prediction": "I think this test should be `assertThat(result.equals(\"password\")).isTrue();`", "reference": "Generally with these tests please split up these tests so that there is a different test for each method" }, { "prediction": "I don't think this is needed.", "reference": "Should something use the lock passed in?" }, { "prediction": "I don't think we need to change this.", "reference": "Is this dependant on some version of Docker? Do we need to include both or `volumes` is deprecated (or just wrong!?)?" }, { "prediction": "I think this should be `Leader.getState() == State.ACTIVE && zkShardTerms.getHighestTerm() == zkShardTerms.getTerm(leader.getName()))`", "reference": "I know this is not new code, but should we change `leader.getState() == State.ACTIVE` to `leader.isActive(liveNodes)`?" }, { "prediction": "I don't think we need to check for `AbstractAnyTypeDeclaration` or `AbstractAnyTypeDeclaration` here.", "reference": "Why not use ASTAnyTypeDeclaration? AbstractAnyTypeDeclaration is deprecated" }, { "prediction": "I don't think we need to import `save` here.", "reference": "A blank line at the very end of each file should eliminate the \"No EOF\" warning we see above" }, { "prediction": "I think this should be `CurrentWorkflowConditionFailedError := err2.(*persistence.CurrentWorkflowConditionFailedError)`", "reference": "These would both be more robust with `errors.As` so that we could safely chain errors." }, { "prediction": "I think this is a breaking change. I'm not sure if this is a breaking change or if it's a breaking change or if it's a breaking change or if it's a breaking change, but if it's a breaking change, it's a breaking change.", "reference": "This is checking the same condition twice?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do it.", "reference": "Aren't we able to handle the case where we have MPI-CUDA without NCCL, even if it's suboptimal?" }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to have a `const uint32 PhantomStatId = 999999;`", "reference": "Wouldn't we want to namespace this `AA` or something similar" }, { "prediction": "I don't think we need to check for `envCfg.EnableSharedConfig && envCfg.Creds.HasKeys()` here.", "reference": "This probably should look beyond envConfig, and include `aws.Config.Credentials` as well." }, { "prediction": "I don't think we need this filter anymore. I don't think we need it anymore.", "reference": "How does this filter differ from TooExpensiveTxFilter?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "Use \" List\" instead of ArrayList in declaration." }, { "prediction": "I don't think we need to check if runtime_type.name is not None and runtime_type.name in self.TYPE_REGISTRY:", "reference": "we might consider hard throwing when name is None since that is explicitly not working right now and then linking to issue in the exception error message" }, { "prediction": "I don't think this is needed.", "reference": "Just noticed this - why \"like\" and not straight \"=\"" }, { "prediction": "I don't think we need to change this test.", "reference": "is this a new test? if yes, isn't it better to check for each env var is present, and the value, instead of a count?" }, { "prediction": "I think this should be `String.format(\"Failed to setInstances, appId={}, microserviceName={}.\", getAppId(), getMicroserviceName(), getAppId(), getMicroserviceName())`", "reference": "when will lost exception? by my test, never happened." }, { "prediction": "I don't think we need to pass `urlstr` to `QDesktopServices.openUrl`?", "reference": "You should re-stringify it here with `QUrl.FullyEncoded`." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use the ephemeral public key for el-Gamal, but if it's a good idea to use the ephemeral public key for el-Gamal, it's a good idea to use the ephemeral public key for el-Gamal. If it's a good idea to use the ephemeral public key for el-Gamal, I think it's a good idea to use the ephemeral public key for el-Gamal, but I'm not sure if it's a good idea to use the ephemeral public key for el-Gamal.", "reference": "i'm not sure why the quit channel is needed in this context" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "When `args.MemoryLimit` is empty, will `MustParse` panic?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this. I'm not sure if this is the right place to do this, or if it's the right place to do it, but if it's the right place to do it, I'm not sure if it's the right place to do it.", "reference": "How soon after this will Apply() be called? It would be a shame if there was still a significant delay before a missing or superfluous route was corrected." }, { "prediction": "I'm not sure if this is the right place for this, but I'm not sure if it's the right place for this.", "reference": "I add a `idx` property, and it is only use for benchmark `heap.Remove`, is it acceptable?" }, { "prediction": "I'm not sure if this is the right place for this file. I'm not sure if it's the right place for this file or if it's the right place for this file.", "reference": "daemonic t got inserted." }, { "prediction": "I think this should be `--data-path or specify the --genesis-file`.", "reference": "This edit is non-essential." }, { "prediction": "I don't think this is needed.", "reference": "Might be safer to ponyfill this?" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if this is the right place to do this, or if it's the right place to do this, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it, or if it's the right place to do it.", "reference": "why was this join not necessary before?" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `DirectoryReader.open` or `DirectoryReader.close()` here.", "reference": "Here we compare to the expected call count 3. Because 3 TermsEnum are created: it is a PrefixQuery and there is one TermsEnum created for AutomatonQuery.intersect() (the next call timeout check is skipped once), then 2 TermsEnum created for the 2 matching terms \"one\" and \"ones\"). Would it be clearer to have a separate test method? We could index more docs, for example 50 with a prefix-generated term (e.g. \"term\"+increment). There would be a PrefixQuery for \"term\", the same test code, and we would test the TIMEOUT_CHECK_SAMPLING: - 1 TermsEnum for Automaton.intersect(), and the next calls would be sampled (50/TIMEOUT_CHECK_SAMPLING=3) => call count +4 - 1 TermsEnum for each enumerated term => call count +50 We could verify call count = 54 (instead of 101 without sampling)" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if it's the best way to do this.", "reference": "Add `--format` as an option. Does it make sense to have all display options available? Also need to add `--inventoryfile` and possibly the global_config_options." }, { "prediction": "I don't think this is needed.", "reference": "Any thoughts on making this false by default? My suggestion is make this opt-in. Storing exception is somewhat expensive, so lets do this only if users opt-in" }, { "prediction": "I don't think we need to catch `Throwable` here.", "reference": "usually I do either ` IOException|RuntimeException` or if doing Throwable, use propagateIfFatal" }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Wondering whether it should be `self.clone`, or `other.clone` or maybe a new `DynamicMap` declaration entirely. I see this is in the condition where `other` is a `DynamicMap`but is this definitely right in terms of `kdims`? I need to think about it more..." }, { "prediction": "I don't think we should change this to SECURITY.", "reference": "I chose a new category because over time I'd like to add metrics also for Authorization plugins and Auditlog plugins (all components registered in security.json). An alternative could have been `CONTAINER` I guess?" }, { "prediction": "I don't think this is needed.", "reference": "IoAddrLen Golang prefers short variable names" }, { "prediction": "I don't think we need to change this.", "reference": "PHPCR-ODM does not allow blank aliases.." }, { "prediction": "I don't think this is needed.", "reference": "This seems trivial to forge. Can we tie this into the authentication code paths somehow so that we can really trust that the request is coming from a server instead of just some application claiming to be a server?" }, { "prediction": "I think this file should be renamed to `Kokkos_Concepts.hpp`", "reference": "Why are you including ``?" }, { "prediction": "I don't think this is needed.", "reference": "So previously health check was consuming from the normal metrics queue, now we duplicate the data to a new queue? I feel like there should be more changes to ensure the health check handler reads from the new queue? @DrewZhang13" }, { "prediction": "I don't think we need to do this.", "reference": "Yep, looks right; your new selector _should_ disqualify the rule from being XDP accelerated." }, { "prediction": "I don't think this is needed.", "reference": "cc @anurse This exists now. Kestrel currently passes the current time to all callbacks as an optimization. Just an FYI." }, { "prediction": "I don't think we need to change this.", "reference": "remove 3.8+ f-string format to allow use in google colab" }, { "prediction": "I'm not sure if this is the right place to save xmm. I'm not sure if this is the right place to save xmm, or if it's the right place to save xmm, or if it's the right place to save xmm, or if it's the right place to save xmm, or if it's the right place to save xmm, or if it's the right place to save xmm, or if it's the right place to save xmm, then it's the right place to save xmm.", "reference": "Should we assert that xstate is aligned here?" }, { "prediction": "I don't think this is needed anymore.", "reference": "any particular reason for suppressing this change?" }, { "prediction": "I think this method should be renamed to `DIFFICULTY_BOMB_REMOVED`", "reference": "Hot take: could this instead become `NO_DIFFICULTY_BOMB` and have` HOMESTEAD` wrap it? So this comes first then homestad with the bomb adjustment, making no difficulty the base case?" }, { "prediction": "I don't think we need this.", "reference": "I suggest to use a scheme like \"blobvar\". \"blob\" would potentially collide if we have another API that use the blob package as a driver." }, { "prediction": "I think this should be `to_ts=max_ts` instead of `to_ts=min_ts`", "reference": "This assumes that the user has at least one listen, it should have a guard around it, because this won't always be the case" }, { "prediction": "I'm not sure if this is correct.", "reference": "Seems like a lot of unintended changes. Are your line break settings causing these?" }, { "prediction": "I don't think this is needed anymore.", "reference": "@StrikerRUS what if we just removed build numbers and did `r-pkgdown=1.3.0`? Won't we have to fix this again if the RTD build machines change?" }, { "prediction": "I don't think we need this file anymore.", "reference": "I'm not arguing with it, but how did you decide to make this change?" }, { "prediction": "This file is part of Invenio. I think it should be `2011, 2012, 2013, 2014 CERN.`", "reference": "1: D400 First line should end with '.', not 'd' 4: I102 copyright year is outdated, expected 2014 but got 2012 25:29: E126 continuation line over-indented for hanging indent 31: D103 Docstring missing 40: D103 Docstring missing 57: D103 Docstring missing 68: D103 Docstring missing 101: D103 Docstring missing 115: D401 First line should be imperative: 'Call', not 'Calls' 115: D400 First line should end with '.', not 't' 134: D400 First line should end with '.', not 'e' 134: D205 Blank line missing between one-line summary and description" }, { "prediction": "I don't think this is needed.", "reference": "Explain that this must match the `CommonName` of the first (or is it last?) certificate in the chain, where the first certificate is the chain root CA and the last certificate is the leaf certificate." }, { "prediction": "I don't think we need this?", "reference": "do we really need this behavour to be configurable?" }, { "prediction": "I'm not sure if this is needed.", "reference": "Hmm interesting. Do the tests check out on this?" }, { "prediction": "I don't think this is needed.", "reference": "For another PR, another `--X` candidate." }, { "prediction": "I don't think we need to change this.", "reference": "Do we need to add this constant for `group_windows.go`? Otherwise, I believe the build will fail on windows. Also what do you think of adding the emoji at the end? The windows one could be plain." }, { "prediction": "I don't think this is needed.", "reference": "this is a junit 3 import, not a junit 4" }, { "prediction": "I'm not sure if this is the right place to start hibernating, or if it's the right place to start hibernating, or if it's the right place to start hibernating, or if it's the right place to start hibernating, or if it's the right place to start hibernating, or if it's the right place to start hibernating, or if it's the right place to start hibernating, or if it's the right place to start hibernating, or if it's the right place to start hibernating, or if it's the right place to start hibernating, or if it's the right place to start hibernating, or if it's the right place to start hibernating, or if it's the right place to start hibernating, or if it's the right place to start hibernating, or if it's the right place to start hibernating, then start hibernating, etc.", "reference": "shouldn't there be a reque expected here?" }, { "prediction": "I don't think we need this property anymore.", "reference": "I prefer to make it `protected set`. What do you think?" }, { "prediction": "I'm not sure if it'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''?''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''", "reference": "Maybe rename this to JetStreamStoreDir?" }, { "prediction": "I'm not sure if this is the right thing to do, but I'm not sure if this is the right thing to do.", "reference": "You can start by logging out the error" }, { "prediction": "I don't think this is needed.", "reference": "In general, what is the reason for the fallback price to be public? If it is public, why does it take baseFeePerGas instead of a block header?" }, { "prediction": "I think this interface should be renamed to `Function1, PartialFunction>`", "reference": "follow-up of #2002" }, { "prediction": "I think this should be `conf.getPartitionPerSplit() / conf.getPartitionPerSplit()`", "reference": "could you give some explanations of what problem do you want to solve by this change, and how/why it works?" }, { "prediction": "I don't think this is needed anymore.", "reference": "LongLivedMarshalByRefObject exists in both the netstandard and netfx xunit?" }, { "prediction": "I'm not sure if this is the best way to do this. I'm not sure if it's the best way to do this, but I'm not sure if it's the best way to do it.", "reference": "the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Testing on linux with this change, containerd no longer stops when k3s stops." }, { "prediction": "I'm not sure if this is called every time the connection flow controller attempts. I'm not sure if it's called every time the connection flow controller attempts. I'm not sure if it's called every time the connection flow controller attempts or if it's called every time the connection flow controller attempts. If it's called every time the connection flow controller attempts, then the caller can prevent an increase of the window.", "reference": "Maybe [u]int64 to be consistent with other byte-valued vars in this struct?" }, { "prediction": "I don't think this is needed.", "reference": "This brings up the question... do we need to start assigning users to the different use cases in some way? We don't want this link to show up for Ric, for example." }, { "prediction": "I'm not sure if this is the right place to do this, but I'm not sure if it's the right place to do this.", "reference": "Unless I'm misunderstanding something, this should just be `prefetch_(param.data_param().prefetch())`, no? That should just use the default value if there's no explicit `data_param` or `data_param.prefetch` set, removing the need to also duplicate and hardcode `PREFETCH_COUNT`." }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if it's a good idea to use `txEncode(tx.Transaction, ad transactions.ApplyData)` or `txEncode(tx transactions.Transaction, ad transactions.ApplyData)` or `txEncode(tx transactions.Transaction, ad transactions.ApplyData)` or `txEncode(tx transactions.Transaction, ad transactions.ApplyData)` or `txEncode(tx transactions.Transaction, ad transactions.ApplyData)` or `txEncode(tx transactions.Transaction, ad transactions.ApplyData)` or `txEncode(tx transactions.Transaction, ad transactions.ApplyData)` or `txEncode(tx transactions.Transaction, ad transactions.ApplyData)` or `txEncode(tx transactions.Transaction, ad transactions.ApplyData)` or `txEncode(tx transactions.Transaction, ad transactions.ApplyData)` or `txEncode(tx transactions.Transaction, ad transactions.ApplyData)` or `txEncode(tx transactions.Transaction, ad transactions.ApplyData)` or `txEncode(tx transactions.Transaction, ad transactions.ApplyData)`", "reference": "nit : move this into a default clause in the previous switch statement." }, { "prediction": "I don't think we need this anymore.", "reference": "It should be return \"''\"; I will fix it" }, { "prediction": "I don't think we should change this to `LeadershipEvent`", "reference": "Go standard linter hates `Id`s and likes `ID`s, please do not resist." }, { "prediction": "I'm not sure if this is a good idea, but I think it's better to use `git fetch origin` instead of `git fetch origin`", "reference": "I don't think retrying here is as useful, since `git-checkout` doesn't access the network AFAIK, and if it fails once it's probably going to fail all three times." }, { "prediction": "I'm not sure about this change, but I think it's better to rename the function to `SetCertificateRenewalTIme` and rename it to `SetCertificateRenewalTime`.", "reference": "Fixing this typo caused a build failure in `cmd/ctl/pkg/status/certificate/certificate_test.go:238` Could you also update it there?" }, { "prediction": "I don't think this is needed.", "reference": "Please note that adding this will import `extension_condition` in the entire scapy (as you are located in a layer). You might want to move this inside the RTP class? Would be better i think" }, { "prediction": "I'm not sure if this is a good idea. I'm not sure if this is a good idea.", "reference": "This will need updating, as I'm not sure we'll want to turn on random ordering if they've specified a seed for programmatic use." }, { "prediction": "I think this should be `#ifdef CLIENT_INTERFACE` instead of `#ifdef CLIENT_INTERFACE`", "reference": "Are you sure these are all client libs? This seems fragile: if we later load sthg else early this will break. Seems best to have some kind of sanity check: at least add an assert in the current location where this is set." }, { "prediction": "I think this should be `Resources.SmallMoleculeLibraryAttributes_KeyValuePairs_OtherIDs, OtherKeys.Replace('\\t','\\n')`", "reference": "Picking nits here, but as a Dictionary already is a collection of KeyValuePairs there's undoubtably a way to code this that doesn't involve constructing any new ones." }, { "prediction": "I don't think this is needed.", "reference": "As Miklas stated, please avoid wildcard imports." }, { "prediction": "I don't think this is needed anymore.", "reference": "Maybe change it to `module.exports = server`? Becase there's nothing else to export here" }, { "prediction": "I'm wondering if we should remove this line.", "reference": "This may be an automated change, but the import seems to fit better where it was previously." }, { "prediction": "I don't think this is needed. I think it should be `