Update mimir.py

mimir.py

@@ -25,11 +25,11 @@ We also cache neighbors (generated for the NE attack).
 """
 
 _CITATION = """\
-@article{duan2024do,
-  title={Do Membership Inference Attacks Work on Large Language Models?},
-  author={Duan*, Michael and \textbf{A. Suri*} and Mireshghallah, Niloofar and Min, Sewon and Shi, Weijia and Zettlemoyer, Luke and Tsvetkov, Yulia and Choi, Yejin and Evans, David and Hajishirzi, Hannaneh},
-  journal={arXiv preprint arXiv:???},
-  year={2024}
+@article{duan2024membership,
+      title={Do Membership Inference Attacks Work on Large Language Models?}, 
+      author={Michael Duan and Anshuman Suri and Niloofar Mireshghallah and Sewon Min and Weijia Shi and Luke Zettlemoyer and Yulia Tsvetkov and Yejin Choi and David Evans and Hannaneh Hajishirzi},
+      year={2024},
+      journal={arXiv:2402.07841},
 }
 """
 
@@ -112,9 +112,12 @@ class MimirDataset(GeneratorBasedBuilder):
             # This is the description that will appear on the datasets page.
             description=_DESCRIPTION,
             # This defines the different columns of the dataset and their types
-            features=datasets.Features(
-                {"text": datasets.Sequence(datasets.Value("string"))}
-            ),
+            features=datasets.Features({
+                "member": datasets.Value("string"),
+                "nonmember": datasets.Value("string"),
+                "member_neighbors": datasets.Sequence(datasets.Value("string")),
+                "nonmember_neighbors": datasets.Sequence(datasets.Value("string"))
+            }),
             # If there's a common (input, target) tuple from the features,
             # specify them here. They'll be used if as_supervised=True in
             # builder.as_dataset.
@@ -122,7 +125,7 @@ class MimirDataset(GeneratorBasedBuilder):
             # Homepage of the dataset for documentation
             homepage=_HOMEPAGE,
             # Citation for the dataset
-            # citation=_CITATION,
+            citation=_CITATION,
         )
 
     def _split_generators(self, dl_manager: DownloadManager):
@@ -136,47 +139,79 @@ class MimirDataset(GeneratorBasedBuilder):
         )
 
         if len(self.config.subsets) > 0:
-            subset_splits = [f"{self.config.name}_{subset}" for subset in self.config.subsets]
+            suffixes = [f"{subset}" for subset in self.config.subsets]
+            # subset_splits = [f"{self.config.name}_{subset}" for subset in self.config.subsets]
         else:
-            subset_splits = [self.config.name]
+            suffixes = ["none"]
+            # subset_splits = [self.config.name]
 
         file_paths = {}
-        for subset_split in subset_splits:
+        for subset_split_suffix in suffixes:
+            internal_fp = {}
+
+            subset_split_suffix_use = f"_{subset_split_suffix}" if subset_split_suffix != "none" else ""
+
             # Add standard member and non-member paths
-            file_paths[f"{subset_split}_member"] = os.path.join(parent_dir, "train", subset_split + ".jsonl")
-            file_paths[f"{subset_split}_nonmember"] = os.path.join(parent_dir, "test", subset_split + ".jsonl")
+            internal_fp['member'] = os.path.join(parent_dir, "train", f"{self.config.name}{subset_split_suffix_use}.jsonl")
+            internal_fp['nonmember'] = os.path.join(parent_dir, "test", f"{self.config.name}{subset_split_suffix_use}.jsonl")
+            # file_paths[f"{subset_split}_member"] = os.path.join(parent_dir, "train", subset_split + ".jsonl")
+            # file_paths[f"{subset_split}_nonmember"] = os.path.join(parent_dir, "test", subset_split + ".jsonl")
             
             # Load associated neighbors
-            file_paths[f"{subset_split}_member_neighbors"] = os.path.join(
+            internal_fp['member_neighbors'] = os.path.join(
                 parent_dir,
                 "train_neighbors",
-                subset_split + f"{NEIGHBOR_SUFFIX}.jsonl",
+                f"{self.config.name}{subset_split_suffix_use}{NEIGHBOR_SUFFIX}.jsonl",
             )
-            file_paths[f"{subset_split}_nonmember_neighbors"] = os.path.join(
+            internal_fp['nonmember_neighbors'] = os.path.join(
                 parent_dir,
                 "test_neighbors",
-                subset_split + f"{NEIGHBOR_SUFFIX}.jsonl",
+                f"{self.config.name}{subset_split_suffix_use}{NEIGHBOR_SUFFIX}.jsonl",
             )
+            # file_paths[f"{subset_split}_member_neighbors"] = os.path.join(
+            #     parent_dir,
+            #     "train_neighbors",
+            #     subset_split + f"{NEIGHBOR_SUFFIX}.jsonl",
+            # )
+            # file_paths[f"{subset_split}_nonmember_neighbors"] = os.path.join(
+            #     parent_dir,
+            #     "test_neighbors",
+            #     subset_split + f"{NEIGHBOR_SUFFIX}.jsonl",
+            # )
+            file_paths[subset_split_suffix] = internal_fp
 
         # Now that we know which files to load, download them
-        download_paths = []
-        k2i = {}
-        for i, (k, v) in enumerate(file_paths.items()):
-            download_paths.append(_DOWNLOAD_URL + v)
-            k2i[k] = i
-        data_dir = dl_manager.download_and_extract(download_paths)
+        data_dir = {}
+        for k, v_dict in file_paths.items():
+            download_paths = []
+            for v in v_dict.values():
+                download_paths.append(_DOWNLOAD_URL + v)
+                # [f"{k}{k_inside}"] = _DOWNLOAD_URL + v
+            paths = dl_manager.download_and_extract(download_paths)
+            internal_dict = {k:v for k, v in zip(v_dict.keys(), paths)}
+            data_dir[k] = internal_dict
 
         splits = []
-        for k in file_paths.keys():
-            splits.append(SplitGenerator(name=k, gen_kwargs={"file_path": data_dir[k2i[k]]}))
+        for k in suffixes:
+            splits.append(SplitGenerator(name=k, gen_kwargs={"file_path_dict": data_dir[k]}))
         return splits
 
-    def _generate_examples(self, file_path):
+    def _generate_examples(self, file_path_dict):
         """Yields examples."""
+        # yield 0, file_path_dict
+        # Open all four files in file_path_dict and yield examples (one from each file) simultaneously
+        with open(file_path_dict["member"], "r") as f_member, open(file_path_dict["nonmember"], "r") as f_nonmember, open(file_path_dict["member_neighbors"], "r") as f_member_neighbors, open(file_path_dict["nonmember_neighbors"], "r") as f_nonmember_neighbors:
+            for id, (member, nonmember, member_neighbors, nonmember_neighbors) in enumerate(zip(f_member, f_nonmember, f_member_neighbors, f_nonmember_neighbors)):
+                yield id, {
+                    "member": json.loads(member),
+                    "nonmember": json.loads(nonmember),
+                    "member_neighbors": json.loads(member_neighbors),
+                    "nonmember_neighbors": json.loads(nonmember_neighbors),
+                }
         # Open the specified .jsonl file and read each line
-        with open(file_path, "r") as f:
-            for id, line in enumerate(f):
-                data = json.loads(line)
-                if type(data) != list:
-                    data = [data]
-                yield id, {"text": data}
+        # with open(file_path, "r") as f:
+        #     for id, line in enumerate(f):
+        #         data = json.loads(line)
+        #         if type(data) != list:
+        #             data = [data]
+        #         yield id, {"text": data}