File size: 2,658 Bytes
8247f19 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 | diff --git a/.github/semgrep-rules/insecure-unpack-archive.yml b/.github/semgrep-rules/insecure-unpack-archive.yml
new file mode 100644
index 0000000..d40f645
--- /dev/null
+++ b/.github/semgrep-rules/insecure-unpack-archive.yml
@@ -0,0 +1,21 @@
+rules:
+ - id: insecure-shutil-unpack-archive-use
+ message: The Python 'shutil' shutil.extract_archive is vulnerable to
+ arbitrary file overwrites
+ languages:
+ - python
+ severity: ERROR
+ metadata:
+ category: security
+ technology:
+ - python
+ owasp:
+ - A06:2017 - Security Misconfiguration
+ - A05:2021 - Security Misconfiguration
+ cwe:
+ - "CWE-22: Improper Limitation of a Pathname to a Restricted Directory
+ ('Path Traversal')"
+ license: Commons Clause License Condition v1.0[LGPL-2.1-only]
+ pattern-either:
+ - pattern: |
+ shutil.unpack_archive(...)
\ No newline at end of file
diff --git a/.github/workflows/semgrep.yml b/.github/workflows/semgrep.yml
index e16e8ba..80320c4 100644
--- a/.github/workflows/semgrep.yml
+++ b/.github/workflows/semgrep.yml
@@ -26,9 +26,17 @@ jobs:
- uses: actions/checkout@v3
- run: semgrep --config auto --sarif --output semgrep.sarif ./guarddog
+ - run: semgrep --config .github/semgrep-rules --sarif --output semgrep-custom.sarif ./guarddog
- name: Upload SARIF file for GitHub Advanced Security Dashboard
uses: github/codeql-action/upload-sarif@v2
with:
+ category: semgrep-builtin
sarif_file: semgrep.sarif
- if: always()
+
+ - name: Upload SARIF file for custom Semgrep rules for GitHub Advanced Security Dashboard
+ uses: github/codeql-action/upload-sarif@v2
+ with:
+ category: semgrep-custom
+ sarif_file: semgrep-custom.sarif
+
diff --git a/guarddog/scanners/package_scanner.py b/guarddog/scanners/package_scanner.py
index 79f216f..0647c9a 100644
--- a/guarddog/scanners/package_scanner.py
+++ b/guarddog/scanners/package_scanner.py
@@ -1,7 +1,6 @@
import json
import os
-import shutil
-import tarsafe # type: ignore
+import tarsafe # type:ignore
import tempfile
import requests
@@ -160,5 +159,8 @@ class PackageScanner(Scanner):
with open(zippath, "wb") as f:
f.write(response.raw.read())
- shutil.unpack_archive(zippath, unzippedpath)
- os.remove(zippath)
+ if zippath.endswith('.tar.gz'):
+ tarsafe.open(zippath).extractall(unzippedpath)
+ os.remove(zippath)
+ else:
+ raise ValueError("unsupported archive extension: " + zippath)
|