diff --git a/js/libs/ui-shared/src/context/ErrorPage.tsx b/js/libs/ui-shared/src/context/ErrorPage.tsx index 5035e7ec8c..248bf94480 100644 --- a/js/libs/ui-shared/src/context/ErrorPage.tsx +++ b/js/libs/ui-shared/src/context/ErrorPage.tsx @@ -7,18 +7,17 @@ import { TextContent, } from "@patternfly/react-core"; import { useTranslation } from "react-i18next"; -import { getNetworkErrorDescription } from "../utils/errors"; +import { getNetworkErrorMessage } from "../utils/errors"; type ErrorPageProps = { error?: unknown; }; export const ErrorPage = (props: ErrorPageProps) => { - const { t } = useTranslation(); + const { t, i18n } = useTranslation(); const error = props.error; - const errorMessage = - getErrorMessage(error) || - getNetworkErrorDescription(error)?.replace(/\+/g, " "); + const errorMessage = getErrorMessage(error); + const networkErrorMessage = getNetworkErrorMessage(error); console.error(error); function onRetry() { @@ -29,7 +28,7 @@ export const ErrorPage = (props: ErrorPageProps) => { { {errorMessage ? ( {t(errorMessage)} + ) : networkErrorMessage && i18n.exists(networkErrorMessage) ? ( + {t(networkErrorMessage)} ) : ( {t("somethingWentWrongDescription")} )} @@ -52,10 +53,6 @@ export const ErrorPage = (props: ErrorPageProps) => { }; function getErrorMessage(error: unknown): string | null { - if (typeof error === "string") { - return error; - } - if (error instanceof Error) { return error.message; } diff --git a/js/libs/ui-shared/src/context/KeycloakContext.tsx b/js/libs/ui-shared/src/context/KeycloakContext.tsx index 060015e0f4..5746c6aefb 100644 --- a/js/libs/ui-shared/src/context/KeycloakContext.tsx +++ b/js/libs/ui-shared/src/context/KeycloakContext.tsx @@ -67,7 +67,7 @@ export const KeycloakProvider = ({ const init = () => keycloak.init({ - onLoad: "check-sso", + onLoad: "login-required", pkceMethod: "S256", responseMode: "query", scope: environment.scope, @@ -80,14 +80,8 @@ export const KeycloakProvider = ({ calledOnce.current = true; }, [keycloak]); - const searchParams = new URLSearchParams(window.location.search); - - if (error || searchParams.get("error_description")) { - return ( - - ); + if (error) { + return ; } if (!init) {