issue stringlengths 10 256k | solution stringlengths 1 101M |
|---|---|
Elasticsearch check fails when used with Opensearch
**Note:** If you have a feature request, you should [contact support](https://docs.datadoghq.com/help/) so the request can be properly tracked.
**Output of the [info page](https://docs.datadoghq.com/agent/guide/agent-commands/#agent-status-and-information)**
```... | diff --git a/elastic/datadog_checks/elastic/elastic.py b/elastic/datadog_checks/elastic/elastic.py
--- a/elastic/datadog_checks/elastic/elastic.py
+++ b/elastic/datadog_checks/elastic/elastic.py
@@ -139,11 +139,17 @@ def _get_es_version(self):
try:
data = self._get_data(self._config.url, send_sc=F... |
[nginx] NGINX Plus extended status API depreciated; Integration needs to use Plus API instead
NGINX R13 was just released and it replaces the Extended Status API with the NGINX Plus API.
[See Announcement](https://www.nginx.com/blog/nginx-plus-r13-released/)
A future version of NGINX Plus will drop support for th... | diff --git a/nginx/datadog_checks/nginx/__init__.py b/nginx/datadog_checks/nginx/__init__.py
--- a/nginx/datadog_checks/nginx/__init__.py
+++ b/nginx/datadog_checks/nginx/__init__.py
@@ -2,6 +2,6 @@
Nginx = nginx.Nginx
-__version__ = "1.1.0"
+__version__ = "1.2.0"
__all__ = ['nginx']
diff --git a/nginx/datadog_... |
Support for "headers" configuration in haproxy.yaml?
Hi all, I'm interested in passing a custom header to my HAProxy integration in `haproxy.yaml`, like this:
```
instances:
- name: haproxy
url: http://localhost:3000
headers:
service-route: haproxy-stats
```
However, that [doesn't ap... | diff --git a/haproxy/datadog_checks/haproxy/__init__.py b/haproxy/datadog_checks/haproxy/__init__.py
--- a/haproxy/datadog_checks/haproxy/__init__.py
+++ b/haproxy/datadog_checks/haproxy/__init__.py
@@ -2,6 +2,6 @@
HAProxy = haproxy.HAProxy
-__version__ = "1.0.2"
+__version__ = "1.2.0"
__all__ = ['haproxy']
dif... |
process monitor throws warnings on postgresql: Warning: Process 123 disappeared while scanning
process monitor throws warnings on postgresql: Warning: Process 123 disappeared while scanning
process
-------
- instance #0 [OK]
- instance DataDog/dd-agent#1 [WARNING]
Warning: Process 16039 di... | diff --git a/process/datadog_checks/process/process.py b/process/datadog_checks/process/process.py
--- a/process/datadog_checks/process/process.py
+++ b/process/datadog_checks/process/process.py
@@ -260,7 +260,7 @@ def psutil_wrapper(self, process, method, accessors=None, *args, **kwargs):
except psutil.Ac... |
[sqlserver] Add 'recovery model' tag to database metrics
Add the `recovery_model_desc` column from `sys.databases` to `SqlBaseStats` as a tag. This would be a useful addition to be able to filter off of for alerts, and since the data is already being queried it should be a minor update.
https://github.com/DataDog/in... | diff --git a/sqlserver/datadog_checks/sqlserver/metrics.py b/sqlserver/datadog_checks/sqlserver/metrics.py
--- a/sqlserver/datadog_checks/sqlserver/metrics.py
+++ b/sqlserver/datadog_checks/sqlserver/metrics.py
@@ -697,6 +697,7 @@ def fetch_all_values(cls, cursor, counters_list, logger, databases=None):
def fetch_... |
[apache] fix metric collection
### What does this PR do?
This collects the correct data for `apache.net.bytes_per_s` and `apache.net.request_per_s`.
https://www.datadoghq.com/blog/collect-apache-performance-metrics
https://wiki.opennms.org/wiki/Monitoring_Apache_with_the_HTTP_collector
https://httpd.apache.org/... | diff --git a/apache/datadog_checks/apache/__init__.py b/apache/datadog_checks/apache/__init__.py
--- a/apache/datadog_checks/apache/__init__.py
+++ b/apache/datadog_checks/apache/__init__.py
@@ -2,6 +2,6 @@
Apache = apache.Apache
-__version__ = "1.1.1"
+__version__ = "1.1.2"
__all__ = ['apache']
diff --git a/ap... |
Consul NodeName (NodeId) in Service Checks
**Note:** If you have a feature request, you should [contact support](https://docs.datadoghq.com/help/) so the request can be properly tracked.
**Output of the [info page](https://docs.datadoghq.com/agent/guide/agent-commands/#agent-status-and-information)**
```text
Get... | diff --git a/consul/datadog_checks/consul/consul.py b/consul/datadog_checks/consul/consul.py
--- a/consul/datadog_checks/consul/consul.py
+++ b/consul/datadog_checks/consul/consul.py
@@ -372,6 +372,8 @@ def check(self, _):
tags.append('service:{}'.format(check['ServiceName']))
... |
[Active Directory] Entry point is using datadog_checks.ntp console script
In the Active Directory integration's `setup.py` the entrypoint (for running without an agent) uses the datadog_checks.ntp console script.
```
# The entrypoint to run the check manually without an agent
entry_points={
'conso... | diff --git a/active_directory/setup.py b/active_directory/setup.py
--- a/active_directory/setup.py
+++ b/active_directory/setup.py
@@ -116,12 +116,5 @@ def find_version(*file_paths):
# Extra files to ship with the wheel package
package_data={b'datadog_checks.active_directory': ['conf.yaml.example']},
- i... |
[oracle] Integration fails when Oracle DB has offline tablespace
**Output of the [info page](https://docs.datadoghq.com/agent/faq/agent-commands/#agent-status-and-information)**
```
====================
Collector (v 5.22.1)
====================
Status date: 2018-04-14 10:05:29 (16s ago)
Pid: 26119
Plat... | diff --git a/oracle/datadog_checks/oracle/__init__.py b/oracle/datadog_checks/oracle/__init__.py
--- a/oracle/datadog_checks/oracle/__init__.py
+++ b/oracle/datadog_checks/oracle/__init__.py
@@ -2,6 +2,6 @@
Oracle = oracle.Oracle
-__version__ = "1.1.0"
+__version__ = "1.2.0"
__all__ = ['oracle']
diff --git a/or... |
etcd leader check uses unsupported endpoint
The etcd integration currently uses the `/v3alpha/maintenance/status` endpoint when determining whether the instance it's checking is the leader:
https://github.com/DataDog/integrations-core/blame/7ab36d84f116ccbdef71ed12b84e81462ca38113/etcd/datadog_checks/etcd/etcd.py#L127... | diff --git a/etcd/datadog_checks/etcd/etcd.py b/etcd/datadog_checks/etcd/etcd.py
--- a/etcd/datadog_checks/etcd/etcd.py
+++ b/etcd/datadog_checks/etcd/etcd.py
@@ -123,9 +123,7 @@ def access_api(self, scraper_config, path, data='{}'):
return response
def is_leader(self, scraper_config):
- # Modify... |
Correctly compute the `templates.count` metric
### What does this PR do?
<!-- A brief description of the change being made with this pull request. -->
Correctly compute the templates.count metric
### Motivation
<!-- What inspired you to submit this pull request? -->
- QA for https://github.com/DataDog/integr... | diff --git a/elastic/datadog_checks/elastic/__about__.py b/elastic/datadog_checks/elastic/__about__.py
--- a/elastic/datadog_checks/elastic/__about__.py
+++ b/elastic/datadog_checks/elastic/__about__.py
@@ -2,4 +2,4 @@
# All rights reserved
# Licensed under a 3-clause BSD style license (see LICENSE)
-__version__ = ... |
[btrfs] Incorrect Metrics and misleading default dashboard
**Output of the info page**
```
❯ sudo /etc/init.d/datadog-agent info
====================
Collector (v 5.17.2)
====================
Status date: 2017-09-24 19:12:35 (13s ago)
Pid: 2931
Platform: Linux-4.9.0-3-amd64-x86_64-with-debian-9.1
P... | diff --git a/btrfs/datadog_checks/btrfs/btrfs.py b/btrfs/datadog_checks/btrfs/btrfs.py
--- a/btrfs/datadog_checks/btrfs/btrfs.py
+++ b/btrfs/datadog_checks/btrfs/btrfs.py
@@ -52,10 +52,17 @@
})
BTRFS_IOC_SPACE_INFO = 0xc0109414
+BTRFS_IOC_DEV_INFO = 0xd000941e
+BTRFS_IOC_FS_INFO = 0x8400941f
TWO_LONGS_STRUCT = s... |
[btrfs] Incorrect Metrics and misleading default dashboard
**Output of the info page**
```
❯ sudo /etc/init.d/datadog-agent info
====================
Collector (v 5.17.2)
====================
Status date: 2017-09-24 19:12:35 (13s ago)
Pid: 2931
Platform: Linux-4.9.0-3-amd64-x86_64-with-debian-9.1
P... | diff --git a/btrfs/datadog_checks/btrfs/btrfs.py b/btrfs/datadog_checks/btrfs/btrfs.py
--- a/btrfs/datadog_checks/btrfs/btrfs.py
+++ b/btrfs/datadog_checks/btrfs/btrfs.py
@@ -23,11 +23,16 @@
SINGLE = "single"
RAID0 = "raid0"
RAID1 = "raid1"
+RAID5 = "raid5"
+RAID6 = "raid6"
RAID10 = "raid10"
DUP = "dup"
UNKNOWN =... |
[docker_daemon] Spurious warnings due to race condition with stopped containers
**Output of the [info page](https://docs.datadoghq.com/agent/faq/agent-commands/#agent-status-and-information)**
```text
====================
Collector (v 5.23.0)
====================
Status date: 2018-05-20 23:50:24 (19s ago)
... | diff --git a/docker_daemon/datadog_checks/docker_daemon/docker_daemon.py b/docker_daemon/datadog_checks/docker_daemon/docker_daemon.py
--- a/docker_daemon/datadog_checks/docker_daemon/docker_daemon.py
+++ b/docker_daemon/datadog_checks/docker_daemon/docker_daemon.py
@@ -759,9 +759,9 @@ def _report_net_metrics(self, con... |
[MySQL] Error while fetching mysql pid from psutil (psutil.NoSuchProcess)
I'm using dd-agent 5.22.3 on Gentoo Linux. Occasionally (once or twice a week) , the MySQL check fails with the following error:
```
ERROR (mysql.py:811): Error while fetching mysql pid from psutil
Traceback (most recent call last):
F... | diff --git a/mysql/datadog_checks/mysql/mysql.py b/mysql/datadog_checks/mysql/mysql.py
--- a/mysql/datadog_checks/mysql/mysql.py
+++ b/mysql/datadog_checks/mysql/mysql.py
@@ -25,6 +25,7 @@
RATE = "rate"
COUNT = "count"
MONOTONIC = "monotonic_count"
+PROC_NAME = 'mysqld'
# Vars found in "SHOW STATUS;"
STATUS_VARS... |
NTP check broken: Servname not supported for ai_socktype (missing /etc/services from netbase)
Just upgraded from 5.23.0 to 5.24.0 using the official docker image to resolve issue #1346 and it broke the NTP check with the following error:
```
2018-05-17 11:30:31 UTC | INFO | dd.collector | config(config.py:1249) | i... | diff --git a/ntp/datadog_checks/__init__.py b/ntp/datadog_checks/__init__.py
--- a/ntp/datadog_checks/__init__.py
+++ b/ntp/datadog_checks/__init__.py
@@ -0,0 +1,5 @@
+# (C) Datadog, Inc. 2018
+# All rights reserved
+# Licensed under a 3-clause BSD style license (see LICENSE)
+
+__path__ = __import__('pkgutil').extend_... |
Instructions to run integrations tests fail on tox
**Additional environment details (Operating System, Cloud provider, etc):**
Ubuntu 14.04, Python 2.7.6
**Steps to reproduce the issue:**
1. Follow instructions at https://github.com/DataDog/integrations-core/blob/e3985fe43853f6ee3bb11e8d9d20a18ca12ae340/docs/dev... | diff --git a/kubernetes_state/datadog_checks/kubernetes_state/kubernetes_state.py b/kubernetes_state/datadog_checks/kubernetes_state/kubernetes_state.py
--- a/kubernetes_state/datadog_checks/kubernetes_state/kubernetes_state.py
+++ b/kubernetes_state/datadog_checks/kubernetes_state/kubernetes_state.py
@@ -17,7 +17,7 @@... |
Fargate checks fails when there are stopped containers in the task
I'm running the agent as a sidecar in a Fargate task as described [here](https://www.datadoghq.com/blog/monitor-aws-fargate/). The fargate check continuously fails with the following error:
```text
[ AGENT ] 2018-07-27 06:30:33 UTC | ERROR | (runner... | diff --git a/ecs_fargate/datadog_checks/ecs_fargate/ecs_fargate.py b/ecs_fargate/datadog_checks/ecs_fargate/ecs_fargate.py
--- a/ecs_fargate/datadog_checks/ecs_fargate/ecs_fargate.py
+++ b/ecs_fargate/datadog_checks/ecs_fargate/ecs_fargate.py
@@ -1,12 +1,10 @@
# (C) Datadog, Inc. 2010-2017
# All rights reserved
# Li... |
[nginx] Incorrectly reporting vts stats and nginxplus as gauge instead of rate
The agent check code always uses gauge to report any number found in the vts/nginxplus json.
Those numbers are in reality ever increasing total counters, wich makes the gauge useless in datadog.
Some keys (for example the requests/sec)... | diff --git a/nginx/datadog_checks/nginx/nginx.py b/nginx/datadog_checks/nginx/nginx.py
--- a/nginx/datadog_checks/nginx/nginx.py
+++ b/nginx/datadog_checks/nginx/nginx.py
@@ -90,7 +90,7 @@ def check(self, instance):
funcs = {
'gauge': self.gauge,
'rate': self.rate,
- 'count... |
query_string should not be dependant on status URL path
https://github.com/DataDog/integrations-core/blob/e74e94794e57ba3fa32214ddc78cb1d978faa230/php_fpm/datadog_checks/php_fpm/php_fpm.py#L200
This line sets the query_string only if the status URL is the default URL, which means any non-default status URLs will fai... | diff --git a/php_fpm/datadog_checks/php_fpm/php_fpm.py b/php_fpm/datadog_checks/php_fpm/php_fpm.py
--- a/php_fpm/datadog_checks/php_fpm/php_fpm.py
+++ b/php_fpm/datadog_checks/php_fpm/php_fpm.py
@@ -107,7 +107,7 @@ def _process_status(self, status_url, auth, tags, http_host, timeout, disable_ss
data = {}
... |
postfix integration causing log spam.
**Output of the [info page](https://docs.datadoghq.com/agent/faq/agent-commands/#agent-status-and-information)**
```text
Getting the status from the agent.
==============
Agent (v6.5.1)
==============
Status date: 2018-09-24 15:37:09.556012 UTC
Pid: 14192
Python... | diff --git a/postfix/datadog_checks/postfix/postfix.py b/postfix/datadog_checks/postfix/postfix.py
--- a/postfix/datadog_checks/postfix/postfix.py
+++ b/postfix/datadog_checks/postfix/postfix.py
@@ -176,8 +176,9 @@ def _get_queue_count(self, directory, queues, tags):
count = sum(len(files) for root, di... |
[redis] KeyError in commandstats when `cmdstat_host` is present.
I am getting a `KeyError` when `command_stats` is enabled. This occurs only on some of the redis instances within my cluster.
I've traced back the error to [this line of code](https://github.com/DataDog/integrations-core/blob/master/redisdb/check.py#L3... | diff --git a/redisdb/datadog_checks/redisdb/redisdb.py b/redisdb/datadog_checks/redisdb/redisdb.py
--- a/redisdb/datadog_checks/redisdb/redisdb.py
+++ b/redisdb/datadog_checks/redisdb/redisdb.py
@@ -408,8 +408,13 @@ def _check_command_stats(self, conn, tags):
for key, stats in command_stats.iteritems():
... |
Additional metrics for Elasticsearch
Currently, the Elasticsearch in flight requests circuit breaker metrics are not captured. Can we add the following metrics?
- breakers.in_flight_requests.tripped
- breakers.in_flight_requests.overhead
- breakers.in_flight_requests.estimated_size_in_bytes
| diff --git a/elastic/datadog_checks/elastic/elastic.py b/elastic/datadog_checks/elastic/elastic.py
--- a/elastic/datadog_checks/elastic/elastic.py
+++ b/elastic/datadog_checks/elastic/elastic.py
@@ -358,12 +358,16 @@ class ESCheck(AgentCheck):
"elasticsearch.thread_pool.force_merge.rejected": ("rate", "thread_... |
[elastic] delayed_unassigned_shards should be included in CLUSTER_HEALTH_METRICS
The current version of the elastic integration does not collect the delayed_unassigned_shards metric from _cluster/health. The delayed_unassigned_shards metric is useful for tracking how shards are handled after a node leaves the cluster.... | diff --git a/elastic/datadog_checks/elastic/elastic.py b/elastic/datadog_checks/elastic/elastic.py
--- a/elastic/datadog_checks/elastic/elastic.py
+++ b/elastic/datadog_checks/elastic/elastic.py
@@ -395,6 +395,10 @@ class ESCheck(AgentCheck):
"elasticsearch.cluster_status": ("gauge", "status", lambda v: {"red"... |
Feature request: monitoring resource requests only for pods in the running state
We're running datadog 6.4.2 in several GKE clusters, along with kube-state-metrics to help monitor the state of the cluster.
`kube_state_metrics.*` metrics are flowing through to datadog as expected, and we've got some useful dashboards... | diff --git a/datadog_checks_base/datadog_checks/base/checks/openmetrics/mixins.py b/datadog_checks_base/datadog_checks/base/checks/openmetrics/mixins.py
--- a/datadog_checks_base/datadog_checks/base/checks/openmetrics/mixins.py
+++ b/datadog_checks_base/datadog_checks/base/checks/openmetrics/mixins.py
@@ -295,23 +295,3... |
vault: Allow custom CA bundle
FR: Allow setting a custom CA bundle for the `vault` integration, similar to the `http_check`
| diff --git a/vault/datadog_checks/vault/vault.py b/vault/datadog_checks/vault/vault.py
--- a/vault/datadog_checks/vault/vault.py
+++ b/vault/datadog_checks/vault/vault.py
@@ -5,6 +5,7 @@
from time import time as timestamp
import requests
+from six import string_types
from urllib3.exceptions import InsecureRequestW... |
[couch] error "local variable 'db_stats' referenced before assignment"
I just started using datadog and have an issue getting the couch integration to run (on MacOS Sierra).
`/usr/local/bin/datadog-agent info` reports this:
````
Checks
======
ntp
---
- Collected 0 metrics, 0 events & 1 s... | diff --git a/couch/check.py b/couch/check.py
--- a/couch/check.py
+++ b/couch/check.py
@@ -4,6 +4,7 @@
# stdlib
from urlparse import urljoin
+from urllib import quote
# 3rd party
import requests
@@ -119,7 +120,7 @@ def get_data(self, server, instance):
databases = list(databases)[:self.MAX_DB]
... |
MongoDB integration should run the `top` command on the admin database.
When configuring the agent check for a database != `admin` to gather stats on the collections, the `top` additional metric no longer works:
```
dd.collector[29969]: WARNING (mongo.py:997): Failed to record `top` metrics top may only be run agai... | diff --git a/mongo/datadog_checks/mongo/mongo.py b/mongo/datadog_checks/mongo/mongo.py
--- a/mongo/datadog_checks/mongo/mongo.py
+++ b/mongo/datadog_checks/mongo/mongo.py
@@ -959,7 +959,7 @@ def total_seconds(td):
# Report the usage metrics for dbs/collections
if 'top' in additional_metrics:
... |
New Etcd preview integration doesn't fully work with default kubernetes etcd versions
The etcd integration with `use_preview=true` to use the new v3 specific integration determines leader using `/v3beta` paths
https://github.com/DataDog/integrations-core/blob/4400118a16668dd9fc4b1b98e8601ff9cdf74767/etcd/datadog_che... | diff --git a/etcd/datadog_checks/etcd/etcd.py b/etcd/datadog_checks/etcd/etcd.py
--- a/etcd/datadog_checks/etcd/etcd.py
+++ b/etcd/datadog_checks/etcd/etcd.py
@@ -99,7 +99,7 @@ def check(self, instance):
self.check_post_v3(instance)
else:
self.warning(
- 'In Agent 6.10 ... |
[postgres] Improve config reading errors
I had this `postgres.yaml`:
```
init_config:
instances:
- host: pepepe
...
custom_metrics:
- query: SELECT %s FROM pg_locks WHERE granted = false;
metrics:
count(distinct pid): [postgresql.connections_locked]
descriptors: []
... | diff --git a/postgres/check.py b/postgres/check.py
--- a/postgres/check.py
+++ b/postgres/check.py
@@ -651,14 +651,17 @@ def _get_custom_metrics(self, custom_metrics, key):
self.log.debug("Metric: {0}".format(m))
- for ref, (_, mtype) in m['metrics'].iteritems():
- cap_mtype =... |
Misleading gearman.workers metric
The gearmand check is using `get_status()` to get the number of workers. The code is getting the number of workers for each task and adding all together to get the number of workers. The problem is that a single worker can be registered for multiple tasks. Unless you have all your work... | diff --git a/gearmand/datadog_checks/gearmand/gearmand.py b/gearmand/datadog_checks/gearmand/gearmand.py
--- a/gearmand/datadog_checks/gearmand/gearmand.py
+++ b/gearmand/datadog_checks/gearmand/gearmand.py
@@ -32,15 +32,13 @@ def _get_client(self, host, port):
return self.gearman_clients[(host, port)]
- ... |
[vault] Fix sealed nodes management
Vault `/sys/health` API endpoint returns a HTTP 503 code for sealed nodes.
The `access_api` method of the Vault check will handle this as an HTTPError and set the `SERVICE_CHECK_CONNECT` to `critical` while the API is perfectly reachable. It will also prevent other checks (`SERVI... | diff --git a/vault/datadog_checks/vault/vault.py b/vault/datadog_checks/vault/vault.py
--- a/vault/datadog_checks/vault/vault.py
+++ b/vault/datadog_checks/vault/vault.py
@@ -30,6 +30,17 @@ class Vault(AgentCheck):
'ssl_ignore_warning': {'name': 'tls_ignore_warning'},
}
+ # Expected HTTP Error codes ... |
Datadog's kubelet integration partially broken with kube 1.16.x
**Note:** If you have a feature request, you should [contact support](https://docs.datadoghq.com/help/) so the request can be properly tracked.
https://github.com/DataDog/integrations-core/blob/master/kubelet/datadog_checks/kubelet/prometheus.py#L18 (no... | diff --git a/kubelet/datadog_checks/kubelet/kubelet.py b/kubelet/datadog_checks/kubelet/kubelet.py
--- a/kubelet/datadog_checks/kubelet/kubelet.py
+++ b/kubelet/datadog_checks/kubelet/kubelet.py
@@ -132,7 +132,7 @@ def __init__(self, name, init_config, agentConfig, instances=None):
self.cadvisor_scraper_conf... |
MySQL Replication Lag doesn't tag by channel name
MySQL 5.7 introduces "replication channels", which means a slave can replicate from multiple masters ("sources") at any given time.
To measure replication lag across `n` channels, it'd be great if DataDog could tag the `mysql.replication.seconds_behind_master` metric... | diff --git a/mysql/check.py b/mysql/check.py
--- a/mysql/check.py
+++ b/mysql/check.py
@@ -543,12 +543,12 @@ def _collect_metrics(self, host, db, tags, options, queries):
# MySQL 5.7.x might not have 'Slave_running'. See: https://bugs.mysql.com/bug.php?id=78544
# look at replica vars collected... |
Agent 7.16.0 cannot parse non-semantic nginx version
After upgrading DataDog agent to 7.16.0 nginx integration stopped working.
Agent Log:
```Dec 18 15:42:50 nginxproxy agent[29323]: 2019-12-18 15:42:50 EST | CORE | ERROR | (pkg/collector/python/datadog_agent.go:116 in LogMessage) | nginx:17d65b5a97c80644 | (core.p... | diff --git a/nginx/datadog_checks/nginx/nginx.py b/nginx/datadog_checks/nginx/nginx.py
--- a/nginx/datadog_checks/nginx/nginx.py
+++ b/nginx/datadog_checks/nginx/nginx.py
@@ -215,7 +215,7 @@ def _get_plus_api_data(self, api_url, plus_api_version, endpoint, nest):
return payload
def _set_version_metadata... |
Vulnerability in secondary dependency of datadog-checks-dev[cli]
Version-pinning for python packages in datadog-checks-dev[cli] is outdated and links to a repo with vulnerability CVE-2017-18342.
**Steps to reproduce the issue:**
1. Create a Pipfile with this content:
```
[packages]
"datadog-checks-dev[cli]" = "*... | diff --git a/datadog_checks_dev/setup.py b/datadog_checks_dev/setup.py
--- a/datadog_checks_dev/setup.py
+++ b/datadog_checks_dev/setup.py
@@ -26,7 +26,7 @@
'coverage==4.5.4', # pinned due to https://github.com/nedbat/coveragepy/issues/883
'mock',
'psutil',
- 'PyYAML>=5.1',
+ 'PyYAML>=5.3',
'... |
WMI integration throws Exception: SWbemLocator Not enough storage is available to process this command
```text
===============
Agent (v7.16.0)
===============
Status date: 2020-02-05 15:56:45.740020 GMT
Agent start: 2020-02-05 15:03:08.601503 GMT
Pid: 25188
Go Version: go1.12.9
Python Version: 3.7... | diff --git a/datadog_checks_base/datadog_checks/base/checks/win/wmi/__init__.py b/datadog_checks_base/datadog_checks/base/checks/win/wmi/__init__.py
--- a/datadog_checks_base/datadog_checks/base/checks/win/wmi/__init__.py
+++ b/datadog_checks_base/datadog_checks/base/checks/win/wmi/__init__.py
@@ -114,14 +114,15 @@ def... |
[TLS: local_cert_path] unable to load PEM certs with .crt extensions
**Note:** If you have a feature request, you should [contact support](https://docs.datadoghq.com/help/) so the request can be properly tracked.
**Output of the [info page](https://docs.datadoghq.com/agent/guide/agent-commands/#agent-status-and-info... | diff --git a/tls/datadog_checks/tls/tls.py b/tls/datadog_checks/tls/tls.py
--- a/tls/datadog_checks/tls/tls.py
+++ b/tls/datadog_checks/tls/tls.py
@@ -118,7 +118,6 @@ def __init__(self, name, init_config, instances):
# Assign lazily since these aren't used by both collection methods
self._validation... |
postfix integration should not require sudo to root
Reading the source code to integrations-core/postfix/check.py I note that it does a sudo to root to run the find command.
This is noted in the docs / comments :
> WARNING: the user that dd-agent runs as must have sudo access for the 'find' command
> --
> | s... | diff --git a/postfix/check.py b/postfix/check.py
--- a/postfix/check.py
+++ b/postfix/check.py
@@ -17,7 +17,9 @@ class PostfixCheck(AgentCheck):
sudo access is not required when running dd-agent as root (not recommended)
example /etc/sudoers entry:
- dd-agent ALL=(ALL) NOPASSWD:/usr/bin... |
[Supervisor] Confusing error message when proc_regex is a string
When `proc_regex` option is (wrongly) configured as a string (i.e `proc_regex: 'some-regex'`), the error message is unclear. I was struggling to understand, because when the string was indeed not empty and valid.
It should be something like
> proc_reg... | diff --git a/supervisord/datadog_checks/supervisord/supervisord.py b/supervisord/datadog_checks/supervisord/supervisord.py
--- a/supervisord/datadog_checks/supervisord/supervisord.py
+++ b/supervisord/datadog_checks/supervisord/supervisord.py
@@ -115,11 +115,11 @@ def check(self, instance):
# Filter monitored ... |
[Supervisor] Can't use user & pass options when using socket
On my Supervisor installation, I have no `[inet_http_server]` section, and yet I can do `supervisorctl -c supervisord.conf -u <user> -p <password>`
**/etc/supervisor/supervisord.conf**
```ini
[unix_http_server]
file=/var/run/supervisor.sock
[superv... | diff --git a/supervisord/datadog_checks/supervisord/supervisord.py b/supervisord/datadog_checks/supervisord/supervisord.py
--- a/supervisord/datadog_checks/supervisord/supervisord.py
+++ b/supervisord/datadog_checks/supervisord/supervisord.py
@@ -91,7 +91,7 @@ def check(self, instance):
)
... |
datadog 7.18.0 => 7.19.0 breaks compatibility with haproxy 2.1.4 stats socket
**Output of the info page (if this is a bug)**
```
Getting the status from the agent.
===============
Agent (v7.19.0)
===============
Status date: 2020-05-04 11:10:14.927133 UTC
Agent start: 2020-05-04 11:09:24.682282 UTC
P... | diff --git a/haproxy/datadog_checks/haproxy/haproxy.py b/haproxy/datadog_checks/haproxy/haproxy.py
--- a/haproxy/datadog_checks/haproxy/haproxy.py
+++ b/haproxy/datadog_checks/haproxy/haproxy.py
@@ -310,7 +310,9 @@ def _fetch_socket_data(self, parsed_url):
(tables,) = self._run_socket_commands(parsed_u... |
Bug in network check
On this line:
https://github.com/DataDog/integrations-core/blob/master/network/check.py#L438
This should be `self.log` rather than `self.logger`. As it is, this raises
```
AttributeError: 'Network' object has no attribute 'logger'
```
| diff --git a/network/check.py b/network/check.py
--- a/network/check.py
+++ b/network/check.py
@@ -435,7 +435,7 @@ def _check_bsd(self, instance):
# -7 -6 -5 -4 -3 -2 -1
for h in ("Ipkts", "Ierrs", "Ibytes", "Opkts", "Oerrs", "Obytes", "Coll"):
... |
network: collect TCPRetransFail metric
Nothing additional to add, this is just a metric that we'd like to collect. We had a host that was hitting a high number of these that was causing some network instability. The closest metric we had was `system.net.tcp.retrans_segs` but this just indicates that a segment was retra... | diff --git a/network/check.py b/network/check.py
--- a/network/check.py
+++ b/network/check.py
@@ -363,6 +363,7 @@ def _check_linux(self, instance):
'ListenOverflows': 'system.net.tcp.listen_overflows',
'ListenDrops': 'system.net.tcp.listen_drops',
'TCPBacklogDrop': 's... |
Using unicode username/password for RabbitMQ agent will result in 401 unauthorised access
**Note:** If you have a feature request, you should [contact support](https://docs.datadoghq.com/help/) so the request can be properly tracked.
**Output of the [info page](https://docs.datadoghq.com/agent/guide/agent-commands/#... | diff --git a/rabbitmq/datadog_checks/rabbitmq/rabbitmq.py b/rabbitmq/datadog_checks/rabbitmq/rabbitmq.py
--- a/rabbitmq/datadog_checks/rabbitmq/rabbitmq.py
+++ b/rabbitmq/datadog_checks/rabbitmq/rabbitmq.py
@@ -145,6 +145,7 @@ class RabbitMQ(AgentCheck):
'rabbitmq_pass': {'name': 'password'},
'ssl_ver... |
Envoy check crashes when collecting metrics from Istio Envoy
**Output of the [info page](https://docs.datadoghq.com/agent/guide/agent-commands/#agent-status-and-information)**
```text
Getting the status from the agent.
===============
Agent (v6.20.0)
===============
Status date: 2020-09-30 03:44:21.621801... | diff --git a/envoy/datadog_checks/envoy/parser.py b/envoy/datadog_checks/envoy/parser.py
--- a/envoy/datadog_checks/envoy/parser.py
+++ b/envoy/datadog_checks/envoy/parser.py
@@ -41,6 +41,10 @@ def parse_metric(metric, metric_mapping=METRIC_TREE):
if metric_part in metric_mapping and num_tags >= minimum_tag_le... |
Detect replication DR secondary mode and skip Prometheus metric collection
### What does this PR do?
When vault is in replication dr secondary mode, the prometheus metrics endpoint is not available.
This PR detects when vault is in replication DR mode and allows the check to continue running while logging a debug me... | diff --git a/vault/datadog_checks/vault/vault.py b/vault/datadog_checks/vault/vault.py
--- a/vault/datadog_checks/vault/vault.py
+++ b/vault/datadog_checks/vault/vault.py
@@ -202,6 +202,8 @@ def check_health_v1(self, submission_queue, dynamic_tags):
if replication_mode == 'secondary':
self._replic... |
Add a service check for missing directories
### What does this PR do?
Add option to notify on missing directories and avoid throwing an exception
### Motivation
[JIRA#1057](https://datadoghq.atlassian.net/browse/AI-1057)
### Additional Notes
### Review checklist (to be filled by reviewers)
- [ ] Feature o... | diff --git a/directory/datadog_checks/directory/directory.py b/directory/datadog_checks/directory/directory.py
--- a/directory/datadog_checks/directory/directory.py
+++ b/directory/datadog_checks/directory/directory.py
@@ -44,13 +44,15 @@ def __init__(self, *args, **kwargs):
self.config = DirectoryConfig(self.... |
datadog-snowflake: got error "Unable to load the check: unable to load any check from config 'snowflake'"
**Additional environment details (Operating System, Cloud provider, etc):**
* Cloud provider: Amazon ECS
* Instance type: t3.medium
* Operating System: Amazon Linux2
**Steps to reproduce the issue:**
1.
``... | diff --git a/snowflake/datadog_checks/snowflake/__init__.py b/snowflake/datadog_checks/snowflake/__init__.py
--- a/snowflake/datadog_checks/snowflake/__init__.py
+++ b/snowflake/datadog_checks/snowflake/__init__.py
@@ -1,6 +1,15 @@
# (C) Datadog, Inc. 2020-present
# All rights reserved
# Licensed under a 3-clause BS... |
Elasticsearch - Snapshots metrics
Hello,
we would like to monitor Elasticsearch snapshotting handled by https://www.elastic.co/guide/en/elasticsearch/reference/current/snapshot-lifecycle-management-api.html and be alerted in case there aren't new snapshots sucessfully created for whatever reason.
SLM provides stat... | diff --git a/elastic/datadog_checks/elastic/elastic.py b/elastic/datadog_checks/elastic/elastic.py
--- a/elastic/datadog_checks/elastic/elastic.py
+++ b/elastic/datadog_checks/elastic/elastic.py
@@ -17,6 +17,7 @@
index_stats_for_version,
node_system_stats_for_version,
pshard_stats_for_version,
+ slm_s... |
Convert latency/latencies in admission's metrics name to duration
### What does this PR do?
<!-- A brief description of the change being made with this pull request. -->
Fixed the bug that some kube-apiserver metrics are not collected, such as `kube_apiserver.admission_webhook_admission_latencies_seconds`.
The d... | diff --git a/kube_apiserver_metrics/datadog_checks/kube_apiserver_metrics/kube_apiserver_metrics.py b/kube_apiserver_metrics/datadog_checks/kube_apiserver_metrics/kube_apiserver_metrics.py
--- a/kube_apiserver_metrics/datadog_checks/kube_apiserver_metrics/kube_apiserver_metrics.py
+++ b/kube_apiserver_metrics/datadog_c... |
Elasticsearch cluster/index health values
Hello,
I have noticed that in the [Elasticsearch](https://github.com/DataDog/integrations-core/tree/e3368b3ebaa87d37e01be3b1f58e26fa00e8337f/elastic) integration, index health values are reported as:
https://github.com/DataDog/integrations-core/blob/e3368b3ebaa87d37e01be3... | diff --git a/elastic/datadog_checks/elastic/elastic.py b/elastic/datadog_checks/elastic/elastic.py
--- a/elastic/datadog_checks/elastic/elastic.py
+++ b/elastic/datadog_checks/elastic/elastic.py
@@ -154,6 +154,7 @@ def _get_index_metrics(self, admin_forwarder, version, base_tags):
index_resp = self._get_data(i... |
Add SLM metrics
### What does this PR do?
<!-- A brief description of the change being made with this pull request. -->
Add metrics about snapshot lifecycle management, available since 7.4.0
### Motivation
<!-- What inspired you to submit this pull request? -->
Resolve #8178
### Additional Notes
<!-- Anythi... | diff --git a/elastic/datadog_checks/elastic/config.py b/elastic/datadog_checks/elastic/config.py
--- a/elastic/datadog_checks/elastic/config.py
+++ b/elastic/datadog_checks/elastic/config.py
@@ -15,6 +15,7 @@
'pshard_graceful_to',
'node_name_as_host',
'cluster_stats',
+ 'slm_stats',
... |
Missing metrics from kube_apiserver_metrics
Looking at what's in /metrics that does not get scraped, I found a few items that would have been handy this afternoon while trying to troubleshoot an EKS cluster. I'm including the first timeseries for each. Some of the go_memstats_ metrics could be useful, too.
I'm using... | diff --git a/kube_apiserver_metrics/datadog_checks/kube_apiserver_metrics/kube_apiserver_metrics.py b/kube_apiserver_metrics/datadog_checks/kube_apiserver_metrics/kube_apiserver_metrics.py
--- a/kube_apiserver_metrics/datadog_checks/kube_apiserver_metrics/kube_apiserver_metrics.py
+++ b/kube_apiserver_metrics/datadog_c... |
[ceph] luminous support for service check?
<!--
This issue queue is primarily intended for tracking features, bugs and work items associated with
the Datadog Agent open-source project.
Prior to submitting an issue please review the following:
- [ ] [Troubleshooting](https://datadog.zendesk.com/hc/en-us/sectio... | diff --git a/ceph/check.py b/ceph/check.py
--- a/ceph/check.py
+++ b/ceph/check.py
@@ -24,6 +24,26 @@ class Ceph(AgentCheck):
DEFAULT_CEPH_CMD = '/usr/bin/ceph'
DEFAULT_CEPH_CLUSTER = 'ceph'
+ DEFAULT_HEALTH_CHECKS = [
+ 'OSD_DOWN',
+ 'OSD_ORPHAN',
+ 'OSD_FULL',
+ 'OSD_NEARFUL... |
[zookeeper] bytes_received and bytes_sent metrics do not represent bytes
The `zookeeper.bytes_received` and `zookeeper.bytes_sent` metrics are misnamed.
The data for these metrics is collected from the ZK `stat` command, which prints `Received` and `Sent` fields. But these fields represent [packets received and s... | diff --git a/zk/check.py b/zk/check.py
--- a/zk/check.py
+++ b/zk/check.py
@@ -310,11 +310,17 @@ def parse_stat(self, buf):
# Received: 101032173
_, value = buf.readline().split(':')
+ # Fixme: This metric name is wrong. It should be removed in a major version of the agent
+ # See http... |
[envoy] Missing Envoy metrics
Agent (v7.26.0)
A number of statistics from Envoyproxy are not exposed in Datadog. Amongst others these include the following:
https://www.envoyproxy.io/docs/envoy/latest/configuration/security/secret#statistics
https://www.envoyproxy.io/docs/envoy/latest/configuration/overview/ex... | diff --git a/envoy/datadog_checks/envoy/metrics.py b/envoy/datadog_checks/envoy/metrics.py
--- a/envoy/datadog_checks/envoy/metrics.py
+++ b/envoy/datadog_checks/envoy/metrics.py
@@ -264,6 +264,14 @@
),
'method': 'monotonic_count',
},
+ 'cluster_manager.cds.update_time': {
+ 'tags': (
+... |
[mysql] Failed to initialize the mysql check because of a too long hostname
**Output of the [info page](https://docs.datadoghq.com/agent/guide/agent-commands/#agent-status-and-information)**
```text
===============
Agent (v7.29.0)
===============
Status date: 2021-07-27 09:06:16.456 UTC (1627376776456)
Ag... | diff --git a/datadog_checks_base/datadog_checks/base/stubs/datadog_agent.py b/datadog_checks_base/datadog_checks/base/stubs/datadog_agent.py
--- a/datadog_checks_base/datadog_checks/base/stubs/datadog_agent.py
+++ b/datadog_checks_base/datadog_checks/base/stubs/datadog_agent.py
@@ -18,6 +18,7 @@ def __init__(self):
... |
MongoDB: Collection-agnostic aggregations like $currentOp doesn't work
Agent 7.29.1, running on Ubuntu Linux 18.04.
**Steps to reproduce the issue:**
Add the following configuration to `/etc/datadog-agent/conf.d/mongo.d/conf.yaml` and restart the agent:
```
custom_queries:
- metric_prefix: mongodb.cust... | diff --git a/mongo/datadog_checks/mongo/collectors/custom_queries.py b/mongo/datadog_checks/mongo/collectors/custom_queries.py
--- a/mongo/datadog_checks/mongo/collectors/custom_queries.py
+++ b/mongo/datadog_checks/mongo/collectors/custom_queries.py
@@ -56,8 +56,10 @@ def _collect_custom_metrics_for_query(self, api, r... |
[marathon] [regression] Incorrect tags on Marathon metrics after dd-agent upgrade to 5.17
**Output of the [info page](https://help.datadoghq.com/hc/en-us/articles/203764635-Agent-Status-and-Information) **
```
====================
Collector (v 5.17.2)
====================
Status date: 2017-10-16 15:18:21 (4s... | diff --git a/marathon/check.py b/marathon/check.py
--- a/marathon/check.py
+++ b/marathon/check.py
@@ -152,10 +152,10 @@ def process_apps(self, url, timeout, auth, acs_url, ssl_verify, tags=None, group
if response is not None:
self.gauge('marathon.apps', len(response['apps']), tags=tags)
... |
[Zookeeper] metadata.csv is missing many metrics emitted by the check
Per the [`check.py` docstring](https://github.com/jeffwidman/integrations-core/blob/patch-2/zk/check.py#L10-L15):
Duplicate information is being reported by both `mntr` and `stat` to keep backwards compatability.
Example:
`stat` ... | diff --git a/zk/check.py b/zk/check.py
--- a/zk/check.py
+++ b/zk/check.py
@@ -2,18 +2,7 @@
# All rights reserved
# Licensed under Simplified BSD License (see LICENSE)
-'''
-As of zookeeper 3.4.0, the `mntr` admin command is provided for easy parsing of zookeeper stats.
-This check first parses the `stat` admin com... |
MySQL Replication Lag doesn't tag by channel name
MySQL 5.7 introduces "replication channels", which means a slave can replicate from multiple masters ("sources") at any given time.
To measure replication lag across `n` channels, it'd be great if DataDog could tag the `mysql.replication.seconds_behind_master` metric... | diff --git a/activemq_xml/check.py b/activemq_xml/check.py
--- a/activemq_xml/check.py
+++ b/activemq_xml/check.py
@@ -1,4 +1,4 @@
-# (C) Datadog, Inc. 2010-2016
+# (C) Datadog, Inc. 2010-2017
# All rights reserved
# Licensed under Simplified BSD License (see LICENSE)
diff --git a/agent_metrics/check.py b/agent_met... |
DocumentAssembler on array<string>
### Is there an existing issue for this?
- [X] I have searched the existing issues and did not find a match.
### Who can help?
_No response_
### What are you working on?
I don't know why but my question was deleted. Therefore, I will repeat again.
I am working with a dataframe t... | diff --git a/python/sparknlp/annotator/classifier_dl/bert_for_zero_shot_classification.py b/python/sparknlp/annotator/classifier_dl/bert_for_zero_shot_classification.py
--- a/python/sparknlp/annotator/classifier_dl/bert_for_zero_shot_classification.py
+++ b/python/sparknlp/annotator/classifier_dl/bert_for_zero_shot_cla... |
BART Summarization max tokens?
### Is there an existing issue for this?
- [X] I have searched the existing issues and did not find a match.
### What are you working on?
I am trying to summarize potentially long texts with distilbart_xsum_12_6.
### Current Behavior
Currently I get an error on long texts... | diff --git a/python/docs/conf.py b/python/docs/conf.py
--- a/python/docs/conf.py
+++ b/python/docs/conf.py
@@ -23,7 +23,7 @@
author = "John Snow Labs"
# The full version, including alpha/beta/rc tags
-release = "4.4.4"
+release = "5.0.0"
pyspark_version = "3.2.3"
# -- General configuration ---------------------... |
The summarization model(s) are not giving any result
Hello,
Sorry for posting this under the "documentation" label, but I thought it is more appropriate than the "bug". The problem I am facing is currently of **two** types.
1️⃣ Model is **not downloading** at all
2️⃣ Model can be downloaded but **cannot do the inf... | diff --git a/python/docs/conf.py b/python/docs/conf.py
--- a/python/docs/conf.py
+++ b/python/docs/conf.py
@@ -23,7 +23,7 @@
author = "John Snow Labs"
# The full version, including alpha/beta/rc tags
-release = "5.0.1"
+release = "5.0.2"
pyspark_version = "3.2.3"
# -- General configuration ---------------------... |
"RuntimeError: Address already in use" when running multiple multi-gpu training (DDP).
**Describe the bug**
I see "RuntimeError: Address already in use" error message if I try to run two multi-gpu training session (using ddp) at the same time.
**To Reproduce**
Run two multi-gpu training session at the same time.
... | diff --git a/pytorch_lightning/trainer/trainer.py b/pytorch_lightning/trainer/trainer.py
--- a/pytorch_lightning/trainer/trainer.py
+++ b/pytorch_lightning/trainer/trainer.py
@@ -958,6 +958,7 @@ def fit(
task = int(os.environ['SLURM_LOCALID'])
self.ddp_train(task, model)
e... |
logging basic configuration level: INFO vs. WARNING (usability with W&B)
Thanks for the amazing package! I am having a great time using it.
# Issue
Recently, I have been playing around with the weights and biases (W&B) logging functionality and I noticed that I was getting a lot of logging messages in my jupyter n... | diff --git a/pytorch_lightning/__init__.py b/pytorch_lightning/__init__.py
--- a/pytorch_lightning/__init__.py
+++ b/pytorch_lightning/__init__.py
@@ -24,9 +24,6 @@
# We are not importing the rest of the scikit during the build
# process, as it may not be compiled yet
else:
- import logging as log
- lo... |
Checkpoint naming broken
## 🐛 Bug
I would like to be able to save checkpoints with custom names that include the value of my `val_loss`, ie. `path/epoch_2-val_loss_0.2.hdf5 `. The [documentation](https://pytorch-lightning.readthedocs.io/en/latest/pytorch_lightning.callbacks.html#pytorch_lightning.callbacks.ModelChe... | diff --git a/pytorch_lightning/callbacks/model_checkpoint.py b/pytorch_lightning/callbacks/model_checkpoint.py
--- a/pytorch_lightning/callbacks/model_checkpoint.py
+++ b/pytorch_lightning/callbacks/model_checkpoint.py
@@ -1,5 +1,5 @@
import os
-import shutil
+import glob
import logging as log
import warnings
@@ -... |
Disable automatic checkpoint loading
**Is your feature request related to a problem? Please describe.**
The last checkpoint is being automatically restored when a checkpoint exists. This is an issue for me when the model has previously been trained with different settings or I want to train a network from scratch.
... | diff --git a/pytorch_lightning/trainer/callback_config.py b/pytorch_lightning/trainer/callback_config.py
--- a/pytorch_lightning/trainer/callback_config.py
+++ b/pytorch_lightning/trainer/callback_config.py
@@ -12,6 +12,9 @@ class TrainerCallbackConfigMixin(ABC):
# the proper values/initialisation should be done ... |
Precision=16 with TPUs bug
## 🐛 Bug
Setting precision=16 when training with a TPU throws an error
### To Reproduce
see colab: https://colab.research.google.com/drive/1s-ZDIqzgKQ1Byf-Lw58RZ8LGgmdB6qjB
Relavent stack trace:
```
Exception in device=TPU:0: str expected, not int
Traceback (most recent call... | diff --git a/pytorch_lightning/trainer/distrib_parts.py b/pytorch_lightning/trainer/distrib_parts.py
--- a/pytorch_lightning/trainer/distrib_parts.py
+++ b/pytorch_lightning/trainer/distrib_parts.py
@@ -489,7 +489,7 @@ def tpu_train(self, tpu_core_idx, model):
# init 16 bit for TPU
if self.precision... |
Support storing hparams as a dict
## 🚀 Feature
Right now, we assume `model.hparams` is an `argparse.Namespace`. We've had a number of requests to support `hparams` as a simple `dict`. Let's do it.
| diff --git a/pytorch_lightning/callbacks/model_checkpoint.py b/pytorch_lightning/callbacks/model_checkpoint.py
--- a/pytorch_lightning/callbacks/model_checkpoint.py
+++ b/pytorch_lightning/callbacks/model_checkpoint.py
@@ -27,9 +27,11 @@ class ModelCheckpoint(Callback):
# save epoch and val_loss in n... |
Update CHANGELOG for 0.7.x
## 🐛 Bug
<!-- A clear and concise description of what the bug is. -->
Updated CHANGELOG according to the reset changes (about last two weeks) especially deprecated items like `data_loader` or `xxxxx_end`
### Additional context
<!-- Add any other context about the problem here. --... | diff --git a/pytorch_lightning/core/decorators.py b/pytorch_lightning/core/decorators.py
--- a/pytorch_lightning/core/decorators.py
+++ b/pytorch_lightning/core/decorators.py
@@ -6,11 +6,10 @@
def data_loader(fn):
"""Decorator to make any fx with this use the lazy property.
- :param fn:
- :return:
+ Wa... |
make metric-comparison in ModelCheckpoint robust to NaN
## 🐛 Bug
When the metric that is used in `ModelCheckpoint` reaches `NaN` in one epoch and then returns to a number in the following epoch, the model will not be saved as comparisons to `NaN` always return `False`.
Here a screenshot from my training:
![... | diff --git a/pytorch_lightning/trainer/trainer.py b/pytorch_lightning/trainer/trainer.py
--- a/pytorch_lightning/trainer/trainer.py
+++ b/pytorch_lightning/trainer/trainer.py
@@ -109,7 +109,7 @@ def __init__(
distributed_backend: Optional[str] = None,
use_amp=False, # backward compatible, tod... |
Lower default progress_bar_refresh_rate
## 🚀 Feature
From a conversation in Slack.
In v0.7.1, the default value of `progress_bar_refresh_rate` is 50, which I think too high.
It is a measure to prevent notebook freezing, however, I believe most users run PL on CLI.
In addition, the high default value confuses the ... | diff --git a/pytorch_lightning/trainer/__init__.py b/pytorch_lightning/trainer/__init__.py
--- a/pytorch_lightning/trainer/__init__.py
+++ b/pytorch_lightning/trainer/__init__.py
@@ -619,13 +619,13 @@ def on_train_end(self):
progress_bar_refresh_rate
^^^^^^^^^^^^^^^^^^^^^^^^^
How often to refresh progress bar (in st... |
Support IterableDatasets for validation and test, not just train set [blocked by #953]
## 🚀 Feature
Currently Lightning supports `IterableDatasets` only in the training set (see [code](https://github.com/PyTorchLightning/pytorch-lightning/blob/master/pytorch_lightning/trainer/data_loading.py#L177)). This makes them s... | diff --git a/pytorch_lightning/trainer/data_loading.py b/pytorch_lightning/trainer/data_loading.py
--- a/pytorch_lightning/trainer/data_loading.py
+++ b/pytorch_lightning/trainer/data_loading.py
@@ -1,9 +1,11 @@
from abc import ABC, abstractmethod
+from typing import Union, List, Tuple, Callable
import torch.distri... |
enable progress bar = update freq 1
i think we can collapse two args.
- remove enable progress bar arg.
- disable the progress bar when update freq = 0
| diff --git a/pytorch_lightning/trainer/__init__.py b/pytorch_lightning/trainer/__init__.py
--- a/pytorch_lightning/trainer/__init__.py
+++ b/pytorch_lightning/trainer/__init__.py
@@ -646,6 +646,8 @@ def on_train_end(self):
# default used by the Trainer
trainer = Trainer(progress_bar_refresh_rate=1)
+ # d... |
Checkpoint fails in single node multi-GPU mode using DDP
## 🐛 Bug
Checkpoint fails in single node multi-GPU mode using DDP.
### To Reproduce
```bash
python pl_examples/basic_examples/gpu_template.py --distributed_backend ddp --gpus 2
```
```bash
Epoch 2: : 700it [00:28, 42.69it/s, l/home/xz/anaconda3/e... | diff --git a/pytorch_lightning/callbacks/model_checkpoint.py b/pytorch_lightning/callbacks/model_checkpoint.py
--- a/pytorch_lightning/callbacks/model_checkpoint.py
+++ b/pytorch_lightning/callbacks/model_checkpoint.py
@@ -175,6 +175,10 @@ def format_checkpoint_name(self, epoch, metrics, ver=None):
return file... |
ReduceLROnPlateau scheduler type check
## 🐛 Bug
Incorrect type check for scheduler of class ReduceLROnPlateau.
https://github.com/PyTorchLightning/pytorch-lightning/blob/bc01b9ac1c0ddf503f83755c00d5541a2679e5b4/pytorch_lightning/trainer/trainer.py#L713
I believe, this check:
`isinstance(scheduler, optim.lr_sch... | diff --git a/pytorch_lightning/trainer/trainer.py b/pytorch_lightning/trainer/trainer.py
--- a/pytorch_lightning/trainer/trainer.py
+++ b/pytorch_lightning/trainer/trainer.py
@@ -707,8 +707,8 @@ def configure_schedulers(self, schedulers: list):
if 'scheduler' not in scheduler:
rais... |
`use_amp` is broken in 0.7.0
I see that `use_amp` is deprecated but since the Trainer still accepts it as an argument, I believe this is still a bug.
The issue is that the [hook that deals with this](https://github.com/PyTorchLightning/pytorch-lightning/blob/3c2fd560aa4d31b4f48ee225b83361deec53d9c7/pytorch_lightnin... | diff --git a/pl_examples/basic_examples/gpu_template.py b/pl_examples/basic_examples/gpu_template.py
--- a/pl_examples/basic_examples/gpu_template.py
+++ b/pl_examples/basic_examples/gpu_template.py
@@ -32,7 +32,7 @@ def main(hparams):
max_epochs=hparams.epochs,
gpus=hparams.gpus,
distributed... |
Add support for hierarchical dict
## 🚀 Feature
### Motivation
Since v0.7.0, LightningModule accepts dict hparams, however, still TensorBoardLogger raises an error with hierarchical dict. Considering the compatibility of the other package, especially Hydra #807, hierarchical dict should be accepted by any loggers.
... | diff --git a/pytorch_lightning/loggers/base.py b/pytorch_lightning/loggers/base.py
--- a/pytorch_lightning/loggers/base.py
+++ b/pytorch_lightning/loggers/base.py
@@ -55,6 +55,39 @@ def _convert_params(params: Union[Dict[str, Any], Namespace]) -> Dict[str, Any]:
return params
+ @staticmethod
+ def _f... |
clarify 3 things in docs
**clarify 3 things in docs**
1. DP, DDP don't matter with TPUs. TPUs work in DDP by default (at least rn).
2. Explain how the different steps are called (i thought we did).
(here: https://pytorch-lightning.readthedocs.io/en/0.7.1/lightning-module.html#training-loop-structure)
```
# how... | diff --git a/pytorch_lightning/core/__init__.py b/pytorch_lightning/core/__init__.py
--- a/pytorch_lightning/core/__init__.py
+++ b/pytorch_lightning/core/__init__.py
@@ -107,9 +107,10 @@ def configure_optimizers(self):
-----------------------
The general pattern is that each loop (training, validation, test loop)
... |
Pretty test result with pprint
## 🚀 Feature
### Motivation
Test results are shown at the end of test loops since v0.7.0.
The content of the indication is `prog_bar_metrics`, which is basically inputted as a `dict`.
By default, this part uses built-in `print` function:
 dictionary parameters should be settable from the Trainer constructor.
### Motivation
The documentation doesn't seem to be clear that the LRS have the following additional... | diff --git a/pytorch_lightning/core/lightning.py b/pytorch_lightning/core/lightning.py
--- a/pytorch_lightning/core/lightning.py
+++ b/pytorch_lightning/core/lightning.py
@@ -942,28 +942,27 @@ def configure_optimizers(self):
dis_sched = CosineAnnealing(discriminator_opt, T_max=10) # called every ep... |
CI: Force docs compilation warnings to be raised as errors
## 📚 Documentation
We frequently have the issue that a part of the code is changed but the documentation gets broken. Since most doc breaking changes only raise warnings, they are often overlooked.
Let's fix all the warnings and force the build to raise... | diff --git a/docs/source/conf.py b/docs/source/conf.py
--- a/docs/source/conf.py
+++ b/docs/source/conf.py
@@ -73,7 +73,7 @@
# ones.
extensions = [
'sphinx.ext.autodoc',
- 'sphinxcontrib.mockautodoc',
+ # 'sphinxcontrib.mockautodoc', # raises error: directive 'automodule' is already registered ...
# ... |
multi-gpu ddp calls validation and testing loops too many times
When using ddp with multiple gpus, each validation and test loop is called with the entire validation dataset for each gpu.
Expected behavior is that the dataset is divided appropriately across the gpus.
I am using current master (cloned Mar 14), Ubu... | diff --git a/pytorch_lightning/trainer/data_loading.py b/pytorch_lightning/trainer/data_loading.py
--- a/pytorch_lightning/trainer/data_loading.py
+++ b/pytorch_lightning/trainer/data_loading.py
@@ -91,15 +91,12 @@ def auto_add_sampler(self, dataloader: DataLoader, train: bool) -> DataLoader:
)
... |
Wandb logger doesn't upload saved model checkpoint for final epoch
## 🐛 Bug
When training a model on the TPU and using the wandb logger, the checkpoint for the last epoch trained doesn't get uploaded to wandb.
### To Reproduce
Colab notebook: https://colab.research.google.com/drive/1oPaRWGZcz6YEol012xFADN42LV... | diff --git a/pytorch_lightning/loggers/wandb.py b/pytorch_lightning/loggers/wandb.py
--- a/pytorch_lightning/loggers/wandb.py
+++ b/pytorch_lightning/loggers/wandb.py
@@ -101,14 +101,6 @@ def log_metrics(self, metrics: Dict[str, float], step: Optional[int] = None) ->
metrics['global_step'] = step
... |
Additional dataloader created and discarded when training with reload_dataloaders_every_epoch
## 🐛 Bug
I am training with reload_dataloaders_every_epoch and I've noticed it instantiates an extra DataLoader before training for which nothing is run. This is an issue for me as I am training with chunks that get loaded... | diff --git a/pytorch_lightning/trainer/evaluation_loop.py b/pytorch_lightning/trainer/evaluation_loop.py
--- a/pytorch_lightning/trainer/evaluation_loop.py
+++ b/pytorch_lightning/trainer/evaluation_loop.py
@@ -338,14 +338,14 @@ def run_evaluation(self, test_mode: bool = False):
# select dataloaders
... |
update docs to recommend __call__ for forward passes
## 📚 Documentation
We should update the docs to recommend usage of `self(x)` for calculating the forward pass rather than `self.forward(x)`. Calling `forward()` directly can cause issues when you're using PyTorch model hooks (eg. see the additional logic in [`nn.... | diff --git a/pl_examples/basic_examples/lightning_module_template.py b/pl_examples/basic_examples/lightning_module_template.py
--- a/pl_examples/basic_examples/lightning_module_template.py
+++ b/pl_examples/basic_examples/lightning_module_template.py
@@ -106,7 +106,7 @@ def training_step(self, batch, batch_idx):
... |
Support for non-static data for reinforcement learning
What would be the best approach for reinforcement learning problems where you would need to interact with the environment for data? Maybe DataLoader is restricting?
| diff --git a/pl_examples/basic_examples/lightning_module_template.py b/pl_examples/basic_examples/lightning_module_template.py
--- a/pl_examples/basic_examples/lightning_module_template.py
+++ b/pl_examples/basic_examples/lightning_module_template.py
@@ -19,7 +19,24 @@
class LightningTemplateModel(LightningModule):
... |
Early stopping not working on 0.7.1
<!--
### Common bugs:
1. Tensorboard not showing in Jupyter-notebook see [issue 79](https://github.com/PyTorchLightning/pytorch-lightning/issues/79).
2. PyTorch 1.1.0 vs 1.2.0 support [see FAQ](https://github.com/PyTorchLightning/pytorch-lightning#faq)
-->
## 🐛 Bug
... | diff --git a/pytorch_lightning/trainer/training_loop.py b/pytorch_lightning/trainer/training_loop.py
--- a/pytorch_lightning/trainer/training_loop.py
+++ b/pytorch_lightning/trainer/training_loop.py
@@ -367,8 +367,8 @@ def train(self):
met_min_steps = self.global_step >= self.min_steps if self.min_step... |
Disabling validation with val_percent_check=0.0 not working
<!--
### Common bugs:
1. Tensorboard not showing in Jupyter-notebook see [issue 79](https://github.com/PyTorchLightning/pytorch-lightning/issues/79).
2. PyTorch 1.1.0 vs 1.2.0 support [see FAQ](https://github.com/PyTorchLightning/pytorch-lightning#faq)... | diff --git a/pytorch_lightning/trainer/trainer.py b/pytorch_lightning/trainer/trainer.py
--- a/pytorch_lightning/trainer/trainer.py
+++ b/pytorch_lightning/trainer/trainer.py
@@ -876,7 +876,8 @@ def run_pretrain_routine(self, model: LightningModule):
return
# check if we should run validation du... |
Train loss vs loss on progress bar
## ❓ Questions and Help
<!-- If you still can't find what you need: -->
#### What is your question?
I don't understand why `train_loss` is different than `loss` even though I assign the same value. Perhaps one loss is calculated over the whole dataset and the other one is only ... | diff --git a/pytorch_lightning/core/lightning.py b/pytorch_lightning/core/lightning.py
--- a/pytorch_lightning/core/lightning.py
+++ b/pytorch_lightning/core/lightning.py
@@ -220,6 +220,10 @@ def training_step(self, batch, batch_idx, hiddens):
You can also return a -1 instead of a dict to stop the curren... |
Restoring training session docs
## 📚 Documentation
["Restoring training session"](https://pytorch-lightning.readthedocs.io/en/latest/pytorch_lightning.trainer.training_io.html#restoring-training-session) documentation shows example, which does not work correctly - [Google Colab](https://colab.research.google.com/dr... | diff --git a/pytorch_lightning/trainer/training_io.py b/pytorch_lightning/trainer/training_io.py
--- a/pytorch_lightning/trainer/training_io.py
+++ b/pytorch_lightning/trainer/training_io.py
@@ -39,15 +39,9 @@
.. code-block:: python
from pytorch_lightning import Trainer
- from pytorch_lightning.loggers impor... |
AdvancedProfiler error
Hi, as others have pointed out, the Profiler doesn't seem to work (it prints nothing), and trying out the AdvancedProfiler as in https://pytorch-lightning.readthedocs.io/en/latest/profiler.html like:
```
from pytorch_lightning.profiler import AdvancedProfiler
profiler = AdvancedProfiler(ou... | diff --git a/pytorch_lightning/__init__.py b/pytorch_lightning/__init__.py
--- a/pytorch_lightning/__init__.py
+++ b/pytorch_lightning/__init__.py
@@ -10,9 +10,10 @@
__docs__ = "PyTorch Lightning is the lightweight PyTorch wrapper for ML researchers." \
" Scale your models. Write less boilerplate."
-from... |
GAN example: Only one backward() call?
In the PyTorch GAN tutorial [https://pytorch.org/tutorials/beginner/dcgan_faces_tutorial.html](https://pytorch.org/tutorials/beginner/dcgan_faces_tutorial.html) there are two backward() calls for the discriminator. How do you ensure this with your structure, where backward() gets ... | diff --git a/pytorch_lightning/core/lightning.py b/pytorch_lightning/core/lightning.py
--- a/pytorch_lightning/core/lightning.py
+++ b/pytorch_lightning/core/lightning.py
@@ -914,10 +914,20 @@ def configure_optimizers(self) -> Union[
If you don't define this method Lightning will automatically use Adam(lr=1e... |
Add support for loading flattened meta_tags.csv
## 🚀 Feature
### Motivation
PL+TensorBoard can log hierarchical dict after #1152, however, `meta_tags.csv` has been disabled by the change.
### Pitch
- Make `meta_tags.csv` back to a hierarchical dict based on their delimiter.
### Alternatives
62de7948634b1cd... | diff --git a/pytorch_lightning/core/lightning.py b/pytorch_lightning/core/lightning.py
--- a/pytorch_lightning/core/lightning.py
+++ b/pytorch_lightning/core/lightning.py
@@ -1,6 +1,7 @@
import collections
import inspect
import os
+import warnings
from abc import ABC, abstractmethod
from argparse import Namespace
... |
Multiple undesired checkpoints created during single epoch
## 🐛 Bug
Thanks for the great project! When I sent custom `ModelCheckpoint` to `Trainer` and hoping to get one checkpoint each epoch, the Trainer eventually produced a lot of versioned checkpoints within a single epoch, wasting lots of disk space and were c... | diff --git a/pl_examples/multi_node_examples/multi_node_ddp_demo.py b/pl_examples/multi_node_examples/multi_node_ddp_demo.py
--- a/pl_examples/multi_node_examples/multi_node_ddp_demo.py
+++ b/pl_examples/multi_node_examples/multi_node_ddp_demo.py
@@ -16,11 +16,7 @@
def main(hparams):
- """
- Main training ro... |
change Checkpoint callback's `save_best_only` to `save_top_k`
**Is your feature request related to a problem? Please describe.**
`save_best_only` is a special case of `save_top_k`. However, `save_tok_k` checkpoints can be used to create ensemble model during the test time.
**Describe the solution you'd like**
keep... | diff --git a/pytorch_lightning/callbacks/pt_callbacks.py b/pytorch_lightning/callbacks/pt_callbacks.py
--- a/pytorch_lightning/callbacks/pt_callbacks.py
+++ b/pytorch_lightning/callbacks/pt_callbacks.py
@@ -158,11 +158,17 @@ class ModelCheckpoint(Callback):
filepath: string, path to save the model file.
... |
Validation every epoch with non-finite dataloader
## 🚀 Feature
<!-- A clear and concise description of the feature proposal -->
Providing a way to do validation every epoch with non-finite (`__len__` not implemented) dataloaders.
### Motivation
<!-- Please outline the motivation for the proposal. Is your fea... | diff --git a/pytorch_lightning/trainer/data_loading.py b/pytorch_lightning/trainer/data_loading.py
--- a/pytorch_lightning/trainer/data_loading.py
+++ b/pytorch_lightning/trainer/data_loading.py
@@ -136,16 +136,19 @@ def reset_train_dataloader(self, model: LightningModule) -> None:
'If you want to ... |
Metrics: Base Metric
## 🚀 Feature
Add a base class for proper metric implementation
| diff --git a/pytorch_lightning/metrics/__init__.py b/pytorch_lightning/metrics/__init__.py
new file mode 100644
--- /dev/null
+++ b/pytorch_lightning/metrics/__init__.py
@@ -0,0 +1,5 @@
+"""
+Metrics
+=======
+TODO
+"""
diff --git a/pytorch_lightning/metrics/converters.py b/pytorch_lightning/metrics/converters.py
new f... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.