hyd2apse Claude Fable 5 commited on
Commit
a78dddd
·
1 Parent(s): 6229b2a

dubbo: bound the Mutiny negative-path await wherever the test exists

Browse files

The MutinyClientCallsTest stabilization (await().indefinitely() ->
atMost(10s)) was gated on MILESTONE_ID == M016.1 in both the compatibility
script and the test-compat Dockerfile, while the same test ships in other
checkpoints' trees (M003.3 END, M025 both states). An implementation that
drops the mocked failure then hangs the whole reactor at the unpatched
checkpoints until the evaluator's outer 3600s timeout, fail-closing the
entire cell (kimi-k3 M003.3/M025, 2026-07-18; three-way adjudication in
SWE-Milestone-data/reeval/dubbo_kimi_deepaudit_20260718/ADJUDICATION_CONSENSUS.md).

Gate on the runtime fact instead: patch whenever the test file exists in the
checked-out state. Golden semantics unchanged (correct implementations
observe the failure immediately); hanging implementations become one
deterministic failing test instead of a zeroed cell — identical to the
treatment M016.1 already had.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BXhU3BbzS4HgWvgvXeB1t1

apache_dubbo_dubbo-3.3.3_dubbo-3.3.6/dockerfiles/Dockerfile.test-compat CHANGED
@@ -42,7 +42,7 @@ RUN set -euo pipefail; \
42
  compat_targets=( \
43
  dubbo-metrics/dubbo-tracing/src/test/java/org/apache/dubbo/tracing/utils/ObservationConventionUtils.java \
44
  ); \
45
- if [[ "${MILESTONE_ID}" == "M016.1" ]]; then \
46
  compat_targets+=( \
47
  dubbo-plugin/dubbo-mutiny/src/test/java/org/apache/dubbo/mutiny/MutinyClientCallsTest.java \
48
  ); \
 
42
  compat_targets=( \
43
  dubbo-metrics/dubbo-tracing/src/test/java/org/apache/dubbo/tracing/utils/ObservationConventionUtils.java \
44
  ); \
45
+ if [[ -f dubbo-plugin/dubbo-mutiny/src/test/java/org/apache/dubbo/mutiny/MutinyClientCallsTest.java ]]; then \
46
  compat_targets+=( \
47
  dubbo-plugin/dubbo-mutiny/src/test/java/org/apache/dubbo/mutiny/MutinyClientCallsTest.java \
48
  ); \
apache_dubbo_dubbo-3.3.3_dubbo-3.3.6/dockerfiles/dubbo_test_compatibility.sh CHANGED
@@ -64,20 +64,19 @@ fi
64
 
65
  echo ">>> Dubbo test compatibility patch applied successfully"
66
 
67
- # M016.1 owns a negative-path test that deliberately feeds an exception into
68
- # the candidate implementation. An implementation that drops that exception
69
  # leaves Mutiny's indefinite await blocked forever. Surefire's fork timeout is
70
  # not a reliable assertion boundary: depending on fork shutdown timing it can
71
  # either omit this test report and continue, or hang the whole reactor until the
72
  # evaluator's outer timeout. Bound the evaluator-owned await instead, so a
73
  # correct implementation still observes "boom" immediately while an incorrect
74
  # implementation becomes a deterministic failing test after ten seconds.
75
- if [[ "${MILESTONE_ID:-}" == "M016.1" ]]; then
76
- if [[ ! -f "$mutiny_client_calls_test" ]]; then
77
- echo "ERROR: Mutiny compatibility target is missing: $mutiny_client_calls_test" >&2
78
- exit 49
79
- fi
80
-
81
  mutiny_method=$(
82
  sed -n \
83
  '/void testOneToOneThrowsErrorWithMutinyAwait()/,/^[[:space:]]*@Test/p' \
@@ -105,5 +104,5 @@ if [[ "${MILESTONE_ID:-}" == "M016.1" ]]; then
105
  exit 51
106
  fi
107
 
108
- echo ">>> Dubbo M016.1 Mutiny negative-path wait bounded successfully"
109
  fi
 
64
 
65
  echo ">>> Dubbo test compatibility patch applied successfully"
66
 
67
+ # The Mutiny negative-path test deliberately feeds an exception into the
68
+ # candidate implementation. An implementation that drops that exception
69
  # leaves Mutiny's indefinite await blocked forever. Surefire's fork timeout is
70
  # not a reliable assertion boundary: depending on fork shutdown timing it can
71
  # either omit this test report and continue, or hang the whole reactor until the
72
  # evaluator's outer timeout. Bound the evaluator-owned await instead, so a
73
  # correct implementation still observes "boom" immediately while an incorrect
74
  # implementation becomes a deterministic failing test after ten seconds.
75
+ # Applied to every checkpoint whose tree carries the test (not just M016.1):
76
+ # the hazard travels with the test file, and gating on one milestone id left
77
+ # identical hanging implementations measured at M016.1 but zeroing whole
78
+ # cells at M003.3/M025 (kimi-k3 2026-07-18 incident).
79
+ if [[ -f "$mutiny_client_calls_test" ]]; then
 
80
  mutiny_method=$(
81
  sed -n \
82
  '/void testOneToOneThrowsErrorWithMutinyAwait()/,/^[[:space:]]*@Test/p' \
 
104
  exit 51
105
  fi
106
 
107
+ echo ">>> Dubbo Mutiny negative-path wait bounded successfully (${MILESTONE_ID:-unknown})"
108
  fi