File size: 8,540 Bytes
1e92f2d |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 |
import { FileRef, NextInstance, nextTestSetup } from 'e2e-utils'
import { retry } from 'next-test-utils'
import { createRequestTracker } from 'e2e-utils/request-tracker'
import stripAnsi from 'strip-ansi'
import { accountForOverhead } from './account-for-overhead'
import { join } from 'path'
const CONFIG_ERROR =
'Server Actions Size Limit must be a valid number or filesize format larger than 1MB'
describe('app-dir action size limit invalid config', () => {
const { next, isNextStart, isNextDeploy, skipped } = nextTestSetup({
files: __dirname,
overrideFiles: process.env.TEST_NODE_MIDDLEWARE
? {
'middleware.js': new FileRef(join(__dirname, 'middleware-node.js')),
}
: {},
skipStart: true,
dependencies: {
nanoid: '4.0.1',
'server-only': 'latest',
},
})
if (skipped) return
const logs: string[] = []
beforeAll(() => {
const onLog = (log: string) => {
logs.push(stripAnsi(log.trim()))
}
next.on('stdout', onLog)
next.on('stderr', onLog)
})
afterEach(async () => {
logs.length = 0
await next.stop()
})
if (isNextStart) {
it('should error if serverActions.bodySizeLimit config is a negative number', async function () {
await using _ = await patchFileWithCleanup(
next,
'next.config.js',
`
module.exports = {
experimental: {
serverActions: { bodySizeLimit: -3000 },
},
}
`
)
try {
await next.start()
} catch {}
expect(next.cliOutput).toContain(CONFIG_ERROR)
})
it('should error if serverActions.bodySizeLimit config is invalid', async function () {
await using _ = await patchFileWithCleanup(
next,
'next.config.js',
`
module.exports = {
experimental: {
serverActions: { bodySizeLimit: 'testmb' },
},
}
`
)
try {
await next.start()
} catch {}
expect(next.cliOutput).toContain(CONFIG_ERROR)
})
it('should error if serverActions.bodySizeLimit config is a negative size', async function () {
await using _ = await patchFileWithCleanup(
next,
'next.config.js',
`
module.exports = {
experimental: {
serverActions: { bodySizeLimit: '-3000mb' },
},
}
`
)
try {
await next.start()
} catch {}
expect(next.cliOutput).toContain(CONFIG_ERROR)
})
}
describe('should respect the size set in serverActions.bodySizeLimit for plaintext fetch actions', () => {
beforeEach(async () => {
await next.start()
})
it('should not error for requests that stay below the size limit', async () => {
const browser = await next.browser('/file')
const requestTracker = createRequestTracker(browser)
// below the limit: ok
const [, actionResponse] = await requestTracker.captureResponse(
() => browser.elementByCss('#size-1mb').click(),
{ request: { method: 'POST', pathname: '/file' } }
)
expect(actionResponse.status()).toBe(200)
expect(
await actionResponse.request().headerValue('content-type')
).toStartWith('text/plain')
if (!isNextDeploy) {
await retry(() =>
expect(logs).toContainEqual(
expect.stringContaining(`size = ${accountForOverhead(1)}`)
)
)
expect(logs).not.toContainEqual(
expect.stringContaining('Error: Body exceeded 2mb limit')
)
}
})
it('should error for requests that exceed the size limit', async () => {
const browser = await next.browser('/file')
const requestTracker = createRequestTracker(browser)
const [, actionResponse] = await requestTracker.captureResponse(
() => browser.elementByCss('#size-3mb').click(),
{ request: { method: 'POST', pathname: '/file' } }
)
expect(actionResponse.status()).toBe(500) // TODO: 413?
expect(
await actionResponse.request().headerValue('content-type')
).toStartWith('text/plain')
// The error should have been returned to the client and thrown, triggering the nearest error boundary.
expect(await browser.elementByCss('#error').text()).toBe(
'Something went wrong!'
)
if (!isNextDeploy) {
await retry(() => {
expect(logs).toContainEqual(
expect.stringContaining('Error: Body exceeded 2mb limit')
)
expect(logs).toContainEqual(
expect.stringContaining(
'To configure the body size limit for Server Actions, see'
)
)
})
expect(logs).not.toContainEqual(expect.stringMatching(/^size = /))
}
})
})
describe('should respect the size set in serverActions.bodySizeLimit for multipart fetch actions', () => {
beforeEach(async () => {
await next.start()
})
it('should not error for requests that stay below the size limit', async () => {
const browser = await next.browser('/form')
const requestTracker = createRequestTracker(browser)
const [, actionResponse] = await requestTracker.captureResponse(
() => browser.elementByCss('#size-1mb').click(),
{ request: { method: 'POST', pathname: '/form' } }
)
expect(actionResponse.status()).toBe(200)
expect(
await actionResponse.request().headerValue('content-type')
).toStartWith('multipart/form-data')
if (!isNextDeploy) {
await retry(() =>
expect(logs).toContainEqual(
expect.stringContaining(`size = ${accountForOverhead(1)}`)
)
)
expect(logs).not.toContainEqual(
expect.stringContaining('Error: Body exceeded 2mb limit')
)
}
})
it('should not error for requests that are at the size limit', async () => {
const browser = await next.browser('/form')
const requestTracker = createRequestTracker(browser)
const [, actionResponse] = await requestTracker.captureResponse(
() => browser.elementByCss('#size-2mb').click(),
{ request: { method: 'POST', pathname: '/form' } }
)
expect(actionResponse.status()).toBe(200)
expect(
await actionResponse.request().headerValue('content-type')
).toStartWith('multipart/form-data')
if (!isNextDeploy) {
await retry(() =>
expect(logs).toContainEqual(
expect.stringContaining(`size = ${accountForOverhead(2)}`)
)
)
expect(logs).not.toContainEqual(
expect.stringContaining('Error: Body exceeded 2mb limit')
)
}
})
it('should error for requests that exceed the size limit', async () => {
const browser = await next.browser('/form')
const requestTracker = createRequestTracker(browser)
const [, actionResponse] = await requestTracker.captureResponse(
() => browser.elementByCss('#size-3mb').click(),
{ request: { method: 'POST', pathname: '/form' } }
)
expect(actionResponse.status()).toBe(500) // TODO: 413?
expect(
await actionResponse.request().headerValue('content-type')
).toStartWith('multipart/form-data')
// The error should have been returned to the client and thrown, triggering the nearest error boundary.
expect(await browser.elementByCss('#error').text()).toBe(
'Something went wrong!'
)
if (!isNextDeploy) {
await retry(() => {
expect(logs).toContainEqual(
expect.stringContaining('Error: Body exceeded 2mb limit')
)
expect(logs).toContainEqual(
expect.stringContaining(
'To configure the body size limit for Server Actions, see'
)
)
})
expect(logs).not.toContainEqual(expect.stringMatching(/^size = /))
}
})
})
})
async function patchFileWithCleanup(
next: NextInstance,
filename: Parameters<NextInstance['patchFile']>[0],
contents: Parameters<NextInstance['patchFile']>[1]
): Promise<AsyncDisposable> {
const originalFile = (await next.hasFile(filename))
? await next.readFile(filename)
: null
await next.patchFile(filename, contents)
return {
async [Symbol.asyncDispose]() {
if (originalFile === null) {
await next.deleteFile(filename)
} else {
await next.patchFile(filename, originalFile)
}
},
}
}
|