File size: 13,610 Bytes
5fed0fc |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 |
#!/usr/bin/env python3
"""
Check solution coverage: Expected (models × problems × variants) vs Actual (solutions/).
Usage:
python check_solutions.py
python check_solutions.py --no-color
"""
import argparse
import sys
from collections import defaultdict
from dataclasses import dataclass
from pathlib import Path
from typing import Dict, List, Optional, Set
# Add parent to path for imports
sys.path.insert(0, str(Path(__file__).parent.parent.parent / "src"))
from frontier_cs.models import get_model_prefix, sanitize_problem_name
class Colors:
"""ANSI color codes."""
RESET = "\033[0m"
BOLD = "\033[1m"
DIM = "\033[2m"
RED = "\033[31m"
GREEN = "\033[32m"
YELLOW = "\033[33m"
BLUE = "\033[34m"
CYAN = "\033[36m"
_enabled = True
@classmethod
def disable(cls):
cls._enabled = False
@classmethod
def c(cls, text: str, color: str) -> str:
if not cls._enabled:
return text
return f"{color}{text}{cls.RESET}"
def bold(text: str) -> str:
return Colors.c(text, Colors.BOLD)
def dim(text: str) -> str:
return Colors.c(text, Colors.DIM)
def red(text: str) -> str:
return Colors.c(text, Colors.RED)
def green(text: str) -> str:
return Colors.c(text, Colors.GREEN)
def yellow(text: str) -> str:
return Colors.c(text, Colors.YELLOW)
def blue(text: str) -> str:
return Colors.c(text, Colors.BLUE)
def cyan(text: str) -> str:
return Colors.c(text, Colors.CYAN)
def warning(text: str) -> str:
return Colors.c(f"âš {text}", Colors.YELLOW)
def error(text: str) -> str:
return Colors.c(f"✗ {text}", Colors.RED)
def success(text: str) -> str:
return Colors.c(f"✓ {text}", Colors.GREEN)
def info(text: str) -> str:
return Colors.c(f"ℹ {text}", Colors.CYAN)
def read_problem_list(path: Path) -> List[str]:
"""Read problems from problems.txt."""
problems: List[str] = []
if not path.exists():
return problems
for line in path.read_text(encoding="utf-8").splitlines():
line = line.strip()
if not line or line.startswith("#"):
continue
# Normalize: remove 'research/problems/' prefix
for prefix in ("research/problems/", "problems/"):
if line.startswith(prefix):
line = line[len(prefix):]
break
problems.append(line)
return problems
def read_models_list(path: Path) -> List[str]:
"""Read models from models.txt."""
models: List[str] = []
if not path.exists():
return models
for line in path.read_text(encoding="utf-8").splitlines():
line = line.strip()
if not line or line.startswith("#"):
continue
models.append(line)
return models
def read_variant_indices(path: Path) -> List[int]:
"""Read variant indices from num_solutions.txt."""
if not path.exists():
return [0]
lines = []
for line in path.read_text(encoding="utf-8").splitlines():
line = line.strip()
if line and not line.startswith("#"):
lines.append(line)
if not lines:
return [0]
# Single number = count
if len(lines) == 1:
try:
count = int(lines[0])
return list(range(count)) if count > 0 else [0]
except ValueError:
pass
# Multiple lines = explicit indices
indices = []
for line in lines:
try:
indices.append(int(line))
except ValueError:
pass
return indices if indices else [0]
def read_solution_config(solution_dir: Path) -> Optional[str]:
"""Read problem from solution's config.yaml."""
config_file = solution_dir / "config.yaml"
if not config_file.exists():
return None
try:
content = config_file.read_text(encoding="utf-8")
for line in content.splitlines():
line = line.strip()
if line.startswith("problem:"):
return line.split(":", 1)[1].strip()
except Exception:
pass
return None
def find_solution_file(solution_dir: Path) -> Optional[Path]:
"""Find the solution file in a solution directory."""
# Check common solution file names in order of preference
for name in ["solve.sh", "solution.py", "solution.cpp"]:
candidate = solution_dir / name
if candidate.exists():
return candidate
# Fallback: any Python file
py_files = list(solution_dir.glob("*.py"))
if py_files:
return py_files[0]
return None
def check_solution_file(solution_dir: Path) -> tuple[Optional[Path], bool]:
"""
Check solution file existence and validity.
Returns:
(solution_file, is_empty)
- solution_file: Path to solution file or None if not found
- is_empty: True if file exists but is empty/whitespace only
"""
solution_file = find_solution_file(solution_dir)
if solution_file is None:
return None, False
try:
content = solution_file.read_text(encoding="utf-8").strip()
is_empty = len(content) == 0
except Exception:
is_empty = True
return solution_file, is_empty
def compute_expected(
problems: List[str],
models: List[str],
variants: List[int],
) -> Dict[str, str]:
"""Compute expected solution names -> problem mapping."""
expected: Dict[str, str] = {}
for problem in problems:
problem_name = sanitize_problem_name(problem)
for model in models:
model_prefix = get_model_prefix(model)
for variant_idx in variants:
suffix = "" if variant_idx == 0 else f"_{variant_idx}"
solution_name = f"{model_prefix}_{problem_name}{suffix}"
expected[solution_name] = problem
return expected
@dataclass
class SolutionInfo:
"""Information about a solution directory."""
problem: Optional[str] # Problem from config.yaml (None if missing)
solution_file: Optional[Path] # Solution file path (None if missing)
is_empty: bool # True if solution file is empty
def collect_actual(solutions_dir: Path) -> Dict[str, SolutionInfo]:
"""Collect actual solutions from directory with structure info."""
actual: Dict[str, SolutionInfo] = {}
if not solutions_dir.is_dir():
return actual
for sol_dir in solutions_dir.iterdir():
if sol_dir.is_dir() and not sol_dir.name.startswith("."):
problem = read_solution_config(sol_dir)
solution_file, is_empty = check_solution_file(sol_dir)
actual[sol_dir.name] = SolutionInfo(
problem=problem,
solution_file=solution_file,
is_empty=is_empty,
)
return actual
def main():
base_dir = Path(__file__).parent # research/scripts/
research_dir = base_dir.parent # research/
repo_root = research_dir.parent # Root of repository
parser = argparse.ArgumentParser(
description="Check solution coverage (Expected vs Actual)",
formatter_class=argparse.RawDescriptionHelpFormatter,
)
parser.add_argument(
"--problems-file",
type=Path,
default=base_dir / "problems.txt",
help="Problems file (default: research/scripts/problems.txt)",
)
parser.add_argument(
"--models-file",
type=Path,
default=base_dir / "models.txt",
help="Models file (default: research/scripts/models.txt)",
)
parser.add_argument(
"--variants-file",
type=Path,
default=base_dir / "num_solutions.txt",
help="Variants file (default: research/scripts/num_solutions.txt)",
)
parser.add_argument(
"--solutions-dir",
type=Path,
default=repo_root / "solutions",
help="Solutions directory (default: solutions/)",
)
parser.add_argument(
"--no-color",
action="store_true",
help="Disable colored output",
)
args = parser.parse_args()
if args.no_color:
Colors.disable()
# Read config files
problems = read_problem_list(args.problems_file) if args.problems_file.exists() else []
models = read_models_list(args.models_file) if args.models_file.exists() else []
variants = read_variant_indices(args.variants_file) if args.variants_file.exists() else [0]
if not problems:
print(warning(f"No problems found in {args.problems_file}"))
if not models:
print(warning(f"No models found in {args.models_file}"))
# Compute expected and actual
expected = compute_expected(problems, models, variants) if problems and models else {}
actual = collect_actual(args.solutions_dir)
# Analyze
expected_set = set(expected.keys())
actual_set = set(actual.keys())
generated = expected_set & actual_set # Expected and exists
missing = expected_set - actual_set # Expected but not generated
extra = actual_set - expected_set # Exists but not expected
# Structure issues
no_config = {name for name, info in actual.items() if info.problem is None}
no_solution_file = {name for name, info in actual.items() if info.solution_file is None}
empty_solution = {name for name, info in actual.items() if info.is_empty}
# Print report
print()
line = "=" * 60
print(cyan(line))
print(cyan(bold("Solution Coverage Report")))
print(cyan(line))
print()
total_expected = len(expected)
total_generated = len(generated)
total_missing = len(missing)
total_extra = len(extra)
print(f" Expected (models × problems × variants): {bold(str(total_expected))}")
print(f" Generated (expected & exists): {green(bold(str(total_generated)))}")
print(f" Missing (expected but not generated): {yellow(bold(str(total_missing)))}")
print(f" Extra (exists but not expected): {blue(bold(str(total_extra)))}")
print()
# Coverage bar
if total_expected > 0:
coverage = total_generated / total_expected
bar_width = 40
filled = int(bar_width * coverage)
bar = "â–ˆ" * filled + "â–‘" * (bar_width - filled)
pct = f"{coverage * 100:.1f}%"
color = green if coverage > 0.8 else yellow if coverage > 0.3 else red
print(f" Coverage: [{color(bar)}] {color(pct)}")
print()
# Missing by model
if missing:
print(warning(f"{total_missing} solutions not yet generated:"))
by_model: Dict[str, int] = defaultdict(int)
for name in missing:
prefix = name.split("_", 1)[0]
by_model[prefix] += 1
for prefix in sorted(by_model.keys()):
print(f" {prefix}: {by_model[prefix]} missing")
print()
# Extra solutions
if extra:
print(info(f"{total_extra} extra solutions (not in expected set):"))
for name in sorted(extra)[:10]:
info_obj = actual.get(name)
problem = info_obj.problem if info_obj else None
print(f" {dim(name)}: {problem or dim('no config.yaml')}")
if len(extra) > 10:
print(f" {dim(f'... and {len(extra) - 10} more')}")
print()
# Structure issues
has_issues = False
if no_config:
has_issues = True
print(error(f"{len(no_config)} solutions missing config.yaml:"))
for name in sorted(no_config)[:10]:
print(f" {red(name)}")
if len(no_config) > 10:
print(f" {dim(f'... and {len(no_config) - 10} more')}")
print()
if no_solution_file:
has_issues = True
print(error(f"{len(no_solution_file)} solutions missing solve.sh/solution.py:"))
for name in sorted(no_solution_file)[:10]:
print(f" {red(name)}")
if len(no_solution_file) > 10:
print(f" {dim(f'... and {len(no_solution_file) - 10} more')}")
print()
if empty_solution:
has_issues = True
print(warning(f"{len(empty_solution)} solutions with empty solution file:"))
for name in sorted(empty_solution)[:10]:
info_obj = actual.get(name)
file_name = info_obj.solution_file.name if info_obj and info_obj.solution_file else "?"
print(f" {yellow(name)} ({dim(file_name)})")
if len(empty_solution) > 10:
print(f" {dim(f'... and {len(empty_solution) - 10} more')}")
print()
# Summary
print(dim("─" * 40))
all_good = total_missing == 0 and not has_issues
if all_good:
print(success("All expected solutions are generated with valid structure"))
else:
if total_missing > 0:
print(f" Run {bold('generate_solutions.py')} to generate missing solutions")
if no_config:
print(f" Fix solutions missing {bold('config.yaml')}")
if no_solution_file:
print(f" Fix solutions missing {bold('solve.sh/solution.py')}")
if empty_solution:
print(f" Fix solutions with {bold('empty solution files')}")
print(dim("─" * 40))
# Exit code
return 1 if (has_issues or total_missing > 0) else 0
if __name__ == "__main__":
sys.exit(main())
|