More comments

opusparcus.py

@@ -94,11 +94,12 @@ class Opusparcus(datasets.GeneratorBasedBuilder):
         OpusparcusConfig(lang=lang, quality=quality, version=_VERSION) for lang in LANGS for quality in QUALITIES
     ]
     
-    #DEFAULT_CONFIG_NAME = "test"  # It's not mandatory to have a default configuration. Just use one if it make sense.
+    # There is no default configuration. User always needs to specify one:
+    #DEFAULT_CONFIG_NAME = None
 
     def _info(self):
-        # TODO: This method specifies the datasets.DatasetInfo object which contains informations and typings for the dataset
-        #if self.config.name == "test":  # This is the name of the configuration selected in BUILDER_CONFIGS above
+        # This method specifies the datasets.DatasetInfo object which
+        # contains informations and typings for the dataset
         features = datasets.Features(
             {
                 "lang": datasets.Value("string"),
@@ -113,11 +114,11 @@ class Opusparcus(datasets.GeneratorBasedBuilder):
             # This is the description that will appear on the datasets page.
             description=_DESCRIPTION,
             # This defines the different columns of the dataset and their types
-            features=features,  # Here we define them above because they are different between the two configurations
+            features=features,
             # If there's a common (input, target) tuple from the features,
             # specify them here. They'll be used if as_supervised=True in
-            # builder.as_dataset.
-            supervised_keys=None,
+            # builder.as_dataset:
+            supervised_keys=(sent1, sent2), # is this correct?
             # Homepage of the dataset for documentation
             homepage=_HOMEPAGE,
             # License for the dataset if available
@@ -137,6 +138,10 @@ class Opusparcus(datasets.GeneratorBasedBuilder):
         # separated by a period, containing the values of
         # self.config.lang and self.config.quality.
 
+        if lang is None:
+            # This is an error, nothing to do here
+            return []
+        
         # Select which file of the training data contains the matching data:
         if self.config.quality < 70:
             # We need to retrieve the largest training set file
@@ -259,7 +264,7 @@ class Opusparcus(datasets.GeneratorBasedBuilder):
                     }
         else:
             # The validation and test sets are in jsonl files.
-            # They contain the fields "lang" and "quality" that we filter on.
+            # They contain the fields "lang" and "annot_score" that we filter on.
             # If we ask for the full sets, we will keep all data entries, also
             # the sentence pairs that were not considered paraphrases by the
             # annotators: