Upload knessetCorpus.py

knessetCorpus.py

@@ -1,14 +1,9 @@
-
-import datasets
 import json
-import zipfile
-import bz2
 import os
-import urllib.request
-from io import BytesIO
+from typing import List
+from huggingface_hub import hf_hub_url
 
-
-from typing import List, Dict, Any, Generator
+import datasets
 
 
 _KnessetCorpus_CITATION = "@misc{goldin2024knesset, title={The Knesset Corpus: An Annotated Corpus of Hebrew Parliamentary Proceedings}, author={Gili Goldin and Nick Howell and Noam Ordan and Ella Rabinovich and Shuly Wintner}, year={2024}, eprint={2405.18115}, archivePrefix={arXiv}, primaryClass={cs.CL} }"
@@ -359,124 +354,40 @@ class KnessetCorpus(datasets.GeneratorBasedBuilder):
         elif self.config.name == "knessetMembers":
             id_field_name = "person_id"
 
-        for filepath in data_files:
-            if '::' in filepath:  # Handle URLs with protocol prefixes
-                _, url = filepath.split('::', 1)
-                try:
-                    response = urllib.request.urlopen(url)
-                    content = response.read()
-                    if filepath.endswith('.zip'):
-                        yield from self._process_zip_content(content, id_field_name, url)
-                    elif filepath.endswith('.bz2'):
-                        yield from self._process_bz2_content(content, id_field_name, url)
-                except Exception as e:
-                    print(f"Error downloading {url}: {e}")
-            else:  # Handle local files
-                if filepath.endswith('.zip'):
-                    yield from self._process_zip_file(filepath, id_field_name)
-                elif filepath.endswith('.bz2'):
-                    yield from self._process_bz2_file(filepath, id_field_name)
-                else:
-                    print(f"Unsupported file format: {filepath}")
-
-    def _process_zip_content(self, content: bytes, id_field_name: str, url: str) -> Generator[tuple, None, None]:
-        try:
-            with zipfile.ZipFile(BytesIO(content)) as zip_ref:
-                for file_info in zip_ref.filelist:
-                    if not file_info.filename.endswith('.json'):
-                        continue
-
-                    with zip_ref.open(file_info) as f:
-                        content = f.read().decode('utf-8')
-                        for line in content.splitlines():
-                            if not line.strip():
-                                continue
-
+        for i, filepath in enumerate(data_files):
+            try:
+                with open(filepath, encoding="utf-8") as f:
+                    for line in f:
+                        sample = {}
+                        try:
+                            row = json.loads(line)
+                        except Exception as e:
+                            print(f'couldnt load sample. error was: {e}. Continuing to next sample')
+                            continue
+                        id_ = row.get(id_field_name, None)
+                        if id_ is None:
+                            print(f"Key '{id_field_name}' not found in row. Skipping this row. row is: {row}")
+                            continue
+                        for feature in self._info().features:
+                            sample[feature] = row[feature]
+
+                            # Handle nested structures (e.g., `protocol_sentences`)
+                        if "protocol_sentences" in row:
+                            protocol_sentences = row.get("protocol_sentences", [])
+                            for sentence in protocol_sentences:
+                                sentence_id = sentence.get("sentence_id", None)
+                                if sentence_id:
+                                    yield sentence_id, sentence
+                        else:
                             try:
-                                row = json.loads(line)
-                            except json.JSONDecodeError as e:
-                                print(f"JSON decode error in zip file from {url}, file {file_info.filename}: {e}")
-                                continue
-
-                            yield from self._process_row(row, id_field_name)
-
-        except Exception as e:
-            print(f"Error processing zip content from {url}: {e}")
-
-    def _process_bz2_content(self, content: bytes, id_field_name: str, url: str) -> Generator[tuple, None, None]:
-        try:
-            decompressed = bz2.decompress(content).decode('utf-8')
-            for line in decompressed.splitlines():
-                if not line.strip():
-                    continue
-
-                try:
-                    row = json.loads(line)
-                except json.JSONDecodeError as e:
-                    print(f"JSON decode error in bz2 content from {url}: {e}")
-                    continue
-
-                yield from self._process_row(row, id_field_name)
-
-        except Exception as e:
-            print(f"Error processing bz2 content from {url}: {e}")
-
-    def _process_zip_file(self, filepath: str, id_field_name: str) -> Generator[tuple, None, None]:
-        try:
-            with zipfile.ZipFile(filepath, 'r') as zip_ref:
-                for file_info in zip_ref.filelist:
-                    if not file_info.filename.endswith('.json'):
-                        continue
-
-                    with zip_ref.open(file_info) as f:
-                        content = f.read().decode('utf-8')
-                        for line in content.splitlines():
-                            if not line.strip():
-                                continue
+                                yield id_, sample
+                            except Exception as e:
+                                print(f'couldnt yield sample. error: {e}. sample is: {sample}.', flush=True)
+            except Exception as e:
+                print(f"Error opening file '{filepath}': {e}. Skipping.")
+
+
 
-                            try:
-                                row = json.loads(line)
-                            except json.JSONDecodeError as e:
-                                print(f"JSON decode error in zip file {filepath}, file {file_info.filename}: {e}")
-                                continue
-
-                            yield from self._process_row(row, id_field_name)
-
-        except Exception as e:
-            print(f"Error opening zip file {filepath}: {e}")
-
-    def _process_bz2_file(self, filepath: str, id_field_name: str) -> Generator[tuple, None, None]:
-        try:
-            with bz2.open(filepath, 'rt', encoding='utf-8') as f:
-                for line in f:
-                    if not line.strip():
-                        continue
-
-                    try:
-                        row = json.loads(line)
-                    except json.JSONDecodeError as e:
-                        print(f"JSON decode error in bz2 file {filepath}: {e}")
-                        continue
-
-                    yield from self._process_row(row, id_field_name)
-
-        except Exception as e:
-            print(f"Error opening bz2 file {filepath}: {e}")
-
-    def _process_row(self, row: Dict[str, Any], id_field_name: str) -> Generator[tuple, None, None]:
-        id_ = row.get(id_field_name)
-        if id_ is None:
-            print(f"Key '{id_field_name}' not found in row. Skipping this row. row is: {row}")
-            return
-
-        if "protocol_sentences" in row:
-            for sentence in row.get("protocol_sentences", []):
-                sentence_id = sentence.get("sentence_id")
-                if sentence_id:
-                    yield sentence_id, sentence
-        else:
-            sample = {feature: row[feature] for feature in self._info().features if feature in row}
-            yield id_, sample