File size: 7,506 Bytes
fcc38f9
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
import heapq
from collections import defaultdict
from typing import List, Set

class TopKStringTracker:
    """
    Efficient Top-K string tracking data structure
    
    Core ideas:
    1. Use hash table to record string counts
    2. Use min-heap to maintain top-m strings (heap root is the m-th largest element)
    3. Lazy cleanup: avoid frequent heap operations
    """
    
    def __init__(self, m: int):
        """
        Initialize the data structure
        
        Args:
            m: Maximum number of strings to retain
        """
        self.m = m
        self.count = defaultdict(int)  # string -> occurrence count
        self.heap = []  # min-heap: (count, string)
        self.in_heap = set()  # track strings in heap to avoid duplicates
        
    def add_strings(self, strings: List[str]) -> None:
        """
        Add k strings to the data structure
        
        Args:
            strings: List of strings to add
        """
        # Convert string list to count dictionary
        string_counts = defaultdict(int)
        for s in strings:
            string_counts[s] += 1
        
        # Use add_string_dict to handle the actual addition
        self.add_string_dict(dict(string_counts))
    
    def add_string_dict(self, string_counts: dict) -> None:
        """
        Add strings with their counts from a dictionary
        
        Args:
            string_counts: Dictionary mapping strings to their occurrence counts
        """
        # Update counts from dictionary
        for string, count in string_counts.items():
            if count <= 0:  # Skip invalid counts
                continue
                
            self.count[string] += count
            
            # If string is already in heap, we don't immediately update heap
            # Instead, we perform lazy update when needed
            if string in self.in_heap:
                continue
                
            # If heap is not full, add directly
            if len(self.heap) < self.m:
                heapq.heappush(self.heap, (self.count[string], string))
                self.in_heap.add(string)
            else:
                # Heap is full, check if we need to replace the heap root
                min_count, min_string = self.heap[0]
                if self.count[string] > min_count:
                    # Remove heap root
                    heapq.heappop(self.heap)
                    self.in_heap.remove(min_string)
                    # Add new element
                    heapq.heappush(self.heap, (self.count[string], string))
                    self.in_heap.add(string)
        
        # Cleanup and rebuild heap (handle count update cases)
        self._cleanup_heap()
    
    def _cleanup_heap(self) -> None:
        """
        Clean up outdated counts in heap and rebuild heap structure
        """
        # Collect current counts of all strings in heap
        current_items = []
        for count, string in self.heap:
            if string in self.count:  # String still exists
                current_items.append((self.count[string], string))
        
        # Rebuild heap
        self.heap = []
        self.in_heap = set()
        
        # Sort by count and take top m
        current_items.sort(reverse=True)
        for count, string in current_items[:self.m]:
            heapq.heappush(self.heap, (count, string))
            self.in_heap.add(string)
    
    def get_top_k(self, k: int) -> Set[str]:
        """
        Return the set of top-k strings by occurrence count
        
        Args:
            k: Number of strings to return
            
        Returns:
            Set containing the top-k strings
        """
        # Get all strings with their counts
        all_items = [(count, string) for string, count in self.count.items()]
        
        # Sort and take top k
        all_items.sort(reverse=True, key=lambda x: x[0])
        
        return {string for _, string in all_items[:k]}
    
    def trim_to_m(self) -> None:
        """
        Keep only the top-m strings by occurrence count, delete others
        """
        if len(self.count) <= self.m:
            return
        
        # Get all strings with their counts, sort by count
        all_items = [(count, string) for string, count in self.count.items()]
        all_items.sort(reverse=True, key=lambda x: x[0])
        
        # Keep top m
        top_m_strings = {string for _, string in all_items[:self.m]}
        
        # FIX: Preserve defaultdict behavior when rebuilding count dictionary
        new_count = defaultdict(int)
        for s in top_m_strings:
            new_count[s] = self.count[s]
        self.count = new_count
        
        # Rebuild heap
        self.heap = [(self.count[s], s) for s in top_m_strings]
        heapq.heapify(self.heap)
        self.in_heap = set(top_m_strings)
    
    def size(self) -> int:
        """Return the number of strings currently stored"""
        return len(self.count)
    
    def get_count(self, string: str) -> int:
        """Get the occurrence count of a specific string"""
        return self.count.get(string, 0)


# Enhanced test code with edge cases
def test_topk_tracker():
    """Test the functionality of TopKStringTracker including edge cases"""
    print("=== TopK String Tracker Test ===")
    
    # Initialize, keep top 5 strings
    tracker = TopKStringTracker(m=5)
    
    # Test 1: Basic functionality
    print("\n1. Adding first batch of strings:")
    batch1 = ["apple", "banana", "apple", "cherry"]
    tracker.add_strings(batch1)
    print(f"Added: {batch1}")
    print(f"Current top-3: {tracker.get_top_k(3)}")
    print(f"Current storage size: {tracker.size()}")
    
    # Test 2: More strings
    print("\n2. Adding second batch of strings:")
    batch2 = ["banana", "banana", "date", "elderberry"]
    tracker.add_strings(batch2)
    print(f"Added: {batch2}")
    print(f"Current top-3: {tracker.get_top_k(3)}")
    
    # Test 3: Dictionary addition
    print("\n3. Adding strings from dictionary:")
    string_dict = {"apple": 2, "kiwi": 5, "mango": 3, "banana": 1}
    tracker.add_string_dict(string_dict)
    print(f"Added dict: {string_dict}")
    print(f"Current top-5: {tracker.get_top_k(5)}")
    
    # Test 4: CRITICAL TEST - Trim and then add new strings (reproduces the bug)
    print("\n4. Testing trim_to_m followed by new additions:")
    print(f"Before trim - storage size: {tracker.size()}")
    tracker.trim_to_m()
    print(f"After trim - storage size: {tracker.size()}")
    
    # This should not cause KeyError anymore
    print("Adding new string after trim...")
    new_string = "The player is above and to the right of the goal, and there is a hole below and to the left of the player."
    tracker.add_strings([new_string])
    print("✓ Successfully added new string after trim!")
    print(f"Count of new string: {tracker.get_count(new_string)}")
    
    # Test 5: Edge cases
    print("\n5. Testing edge cases:")
    
    # Empty list
    tracker.add_strings([])
    print("✓ Empty list handled")
    
    # Zero/negative counts in dictionary
    tracker.add_string_dict({"invalid1": 0, "invalid2": -1, "valid": 2})
    print("✓ Invalid counts handled")
    
    # Requesting more top-k than available
    all_strings = tracker.get_top_k(100)
    print(f"✓ Requesting top-100 returned {len(all_strings)} strings")
    
    print("\n=== Test Complete ===")


if __name__ == "__main__":
    test_topk_tracker()