simplify script

FGVC-Aircraft.py

@@ -265,6 +265,17 @@ _VARIANTS = [
 ]
 
 
+def parse_annotations(annotations, join_labels=True):
+    annotations = [annotation.strip().split() for annotation in annotations]
+    if join_labels:
+        return {
+            annotation[0].strip(): " ".join(annotation[1:])
+            for annotation in annotations
+        }
+    else:
+        return {annotation[0].strip(): annotation[1:] for annotation in annotations}
+
+
 class FGVCAircraft(datasets.GeneratorBasedBuilder):
 
     VERSION = datasets.Version("1.0.0")
@@ -341,37 +352,32 @@ class FGVCAircraft(datasets.GeneratorBasedBuilder):
         ]
 
     def _generate_examples(self, images_dir, annotations_dir, split):
-        filenames = open(annotations_dir / f"images_{split}.txt").readlines()
-        filenames = [filename.strip() + ".jpg" for filename in filenames]
+        image_ids = open(annotations_dir / f"images_{split}.txt").readlines()
+        image_ids = [image_id.strip() for image_id in image_ids]
 
         families = open(annotations_dir / f"images_family_{split}.txt").readlines()
-        families = [" ".join(family.strip().split()[1:]) for family in families]
+        families = parse_annotations(families)
 
         manufacturers = open(
             annotations_dir / f"images_manufacturer_{split}.txt"
         ).readlines()
-
-        manufacturers = [
-            " ".join(manufacturer.strip().split()[1:]) for manufacturer in manufacturers
-        ]
+        manufacturers = parse_annotations(manufacturers)
 
         variants = open(annotations_dir / f"images_variant_{split}.txt").readlines()
-        variants = [" ".join(variant.strip().split()[1:]) for variant in variants]
+        variants = parse_annotations(variants)
 
         bounding_boxes = open(
             os.path.join(annotations_dir, "images_box.txt")
         ).readlines()
-        bounding_boxes = [box.strip().split() for box in bounding_boxes]
-        bboxes = {}
-        for box in bounding_boxes:
-            bboxes[box[0]] = box[1:]
-
-        for i, filename in enumerate(filenames):
-            full_path = images_dir / filename
-            family = families[i]
-            manufacturer = manufacturers[i]
-            variant = variants[i]
-            xmin, ymin, xmax, ymax = list(map(int, bboxes[filename.split(".")[0]]))
+
+        bounding_boxes = parse_annotations(bounding_boxes, join_labels=False)
+
+        for image_id in image_ids:
+            full_path = images_dir / f"{image_id}.jpg"
+            family = families[image_id]
+            manufacturer = manufacturers[image_id]
+            variant = variants[image_id]
+            xmin, ymin, xmax, ymax = list(map(int, bounding_boxes[image_id]))
 
             record = {
                 "image": str(full_path),
@@ -380,4 +386,4 @@ class FGVCAircraft(datasets.GeneratorBasedBuilder):
                 "manufacturer": manufacturer,
                 "variant": variant,
             }
-            yield filename, record
+            yield image_id, record