get dataset from url

NLVR2.py

@@ -37,17 +37,12 @@ _HOMEPAGE = "https://lil.nlp.cornell.edu/nlvr/"
 
 _LICENSE = "CC BY 4.0"  
 
-_URL_BASE = "https://raw.githubusercontent.com/lil-lab/nlvr/master/nlvr2/data/"
+_URL_JSON = "https://raw.githubusercontent.com/lil-lab/nlvr/master/nlvr2/data/"
+_URL_IMG = f"https://lil.nlp.cornell.edu/resources/NLVR2/train_img.zip"
 _SPLITS = {
-    # "train": "train.json",
-    "validation": "dev.json",
-    "test1": "test1.json",
-}
-_JZ_IMG_FOLDER_PATH = f"{os.environ['cnw_ALL_CCFRSCRATCH']}/local_datasets/nlvr2/"
-_IMG_SPLITS = {
-    # "train": "train_nlvr2.tar.gz",
-    "validation": "dev_nlvr2.tar.gz",
-    "test1": "test1_nlvr2.tar.gz",
+    "train": "train",
+    "validation": "dev",
+    "test1": "test1",
 }
 
 
@@ -78,26 +73,26 @@ class NLVR2Dataset(datasets.GeneratorBasedBuilder):
     def _split_generators(self, dl_manager):
         urls = {
             "Default": {
-                # "train": os.path.join(_URL_BASE, _SPLITS["train"]),
-                "validation": os.path.join(_URL_BASE, _SPLITS["validation"]),
-                "test1": os.path.join(_URL_BASE, _SPLITS["test1"]),
+                "train": os.path.join(_URL_JSON,  f'{_SPLITS["train"]}.json'),
+                "validation": os.path.join(_URL_JSON, f'{_SPLITS["validation"]}.json'),
+                "test1": os.path.join(_URL_JSON, f'{_SPLITS["test1"]}.json'),
             },
         }
         files_path = dl_manager.download_and_extract(urls)
 
         images_files = {
-            # "train": os.path.join(_JZ_IMG_FOLDER_PATH, _IMG_SPLITS["train"]),
-            "validation": os.path.join(_JZ_IMG_FOLDER_PATH, _IMG_SPLITS["validation"]),
-            "test1": os.path.join(_JZ_IMG_FOLDER_PATH, _IMG_SPLITS["test1"]),
+            "train": os.path.join(_URL_IMG, f'{_SPLITS["train"]}.zip'),
+            "validation": os.path.join(_URL_IMG, f'{_SPLITS["validation"]}.zip'),
+            "test1": os.path.join(_URL_IMG, f'{_SPLITS["test1"]}.zip'),
         }
-        # train_img_path = os.path.join(dl_manager.extract(images_files["train"]),  "train_nlvr2")
-        validation_img_path = os.path.join(dl_manager.extract(images_files["validation"]),  "dev_nlvr2")
-        test1_img_path = os.path.join(dl_manager.extract(images_files["test1"]),  "test1_nlvr2")
+        train_img_path = os.path.join(dl_manager.extract(images_files["train"]),  "train")
+        validation_img_path = os.path.join(dl_manager.download_and_extract(images_files["validation"]),  "dev")
+        test1_img_path = os.path.join(dl_manager.download_and_extract(images_files["test1"]),  "test1")
         return [
-            # datasets.SplitGenerator(
-            #     name=datasets.Split.TRAIN,
-            #     gen_kwargs={"files_path": files_path[self.config.name]["train"], "images_path": train_img_path, "split_name": "train"},
-            # ),
+            datasets.SplitGenerator(
+                name=datasets.Split.TRAIN,
+                gen_kwargs={"files_path": files_path[self.config.name]["train"], "images_path": train_img_path, "split_name": "train"},
+            ),
             datasets.SplitGenerator(
                 name=datasets.Split.VALIDATION,
                 gen_kwargs={"files_path": files_path[self.config.name]["validation"], "images_path": validation_img_path, "split_name": "dev"},
@@ -117,7 +112,8 @@ class NLVR2Dataset(datasets.GeneratorBasedBuilder):
             right_img_identifier = f"{split_name}-{common_img_identifier[1]}-{common_img_identifier[2]}-img1.png"
             left_image_path = str(os.path.join(images_path, left_img_identifier))
             right_image_path = str(os.path.join(images_path, right_img_identifier))
-            # if os.path.exists(left_image_path) and os.path.exists(right_image_path):
+            assert (os.path.exists(left_image_path)) 
+            assert (os.path.exists(right_image_path))
             record = {
                 "identifier": ex["identifier"],
                 "sentence": ex["sentence"],