allow for multiple datasets per split

NLVR2.py

@@ -42,7 +42,7 @@ _URL_IMG = f"https://lil.nlp.cornell.edu/resources/NLVR2/"
 _SPLITS = {
     "train": "train",
     "validation": "dev",
-    "test1": "test1",
+    "test": "test",
 }
 
 
@@ -76,6 +76,7 @@ class NLVR2Dataset(datasets.GeneratorBasedBuilder):
                 "train": os.path.join(_URL_JSON,  f'{_SPLITS["train"]}.json'),
                 "validation": os.path.join(_URL_JSON, f'{_SPLITS["validation"]}.json'),
                 "test1": os.path.join(_URL_JSON, f'{_SPLITS["test1"]}.json'),
+                "test2": os.path.join(_URL_JSON, f'{_SPLITS["test2"]}.json'),
             },
         }
         files_path = dl_manager.download_and_extract(urls)
@@ -84,47 +85,51 @@ class NLVR2Dataset(datasets.GeneratorBasedBuilder):
             "train": os.path.join(_URL_IMG, f'{_SPLITS["train"]}_img.zip'),
             "validation": os.path.join(_URL_IMG, f'{_SPLITS["validation"]}_img.zip'),
             "test1": os.path.join(_URL_IMG, f'{_SPLITS["test1"]}_img.zip'),
+            "test2": os.path.join(_URL_IMG, f'{_SPLITS["test2"]}.zip'),
         }
         train_img_path = os.path.join(dl_manager.extract(images_files["train"]), "images", "train")
         validation_img_path = os.path.join(dl_manager.download_and_extract(images_files["validation"]),  "dev")
         test1_img_path = os.path.join(dl_manager.download_and_extract(images_files["test1"]),  "test1")
+        test2_img_path = os.path.join(dl_manager.download_and_extract(images_files["test2"]),  "test2")
+
         return [
             datasets.SplitGenerator(
                 name=datasets.Split.TRAIN,
-                gen_kwargs={"files_path": files_path[self.config.name]["train"], "images_path": train_img_path, "split_name": "train"},
+                gen_kwargs={"files_paths": [files_path[self.config.name]["train"]], "images_paths": [train_img_path], "split_name": "train"},
             ),
             datasets.SplitGenerator(
                 name=datasets.Split.VALIDATION,
-                gen_kwargs={"files_path": files_path[self.config.name]["validation"], "images_path": validation_img_path, "split_name": "dev"},
+                gen_kwargs={"files_paths": [files_path[self.config.name]["validation"]], "images_paths": [validation_img_path], "split_name": "dev"},
             ),
             datasets.SplitGenerator(
                 name=datasets.Split.TEST,
-                gen_kwargs={"files_path": files_path[self.config.name]["test1"], "images_path": test1_img_path, "split_name": "test1"},
+                gen_kwargs={"files_paths": [files_path[self.config.name]["test1"], files_path[self.config.name]["test1"]], "images_paths": [test1_img_path, test2_img_path], "split_name": "test"},
             ),
         ]
 
-    def _generate_examples(self, files_path, images_path, split_name):
+    def _generate_examples(self, files_paths, images_paths, split_name):
         idx = 0
-        for line in open(files_path).readlines():
-            ex = json.loads(line)
-            common_img_identifier = ex["identifier"].split("-")
-            left_img_identifier = f"{split_name}-{common_img_identifier[1]}-{common_img_identifier[2]}-img0.png"
-            right_img_identifier = f"{split_name}-{common_img_identifier[1]}-{common_img_identifier[2]}-img1.png"
-            if split_name == "train":
-                directory = str(ex["directory"])
-                left_image_path = str(os.path.join(images_path, directory, left_img_identifier))
-                right_image_path = str(os.path.join(images_path, directory, right_img_identifier))
-            else: 
-                left_image_path = str(os.path.join(images_path, left_img_identifier))
-                right_image_path = str(os.path.join(images_path, right_img_identifier))
-            assert (os.path.exists(left_image_path)) 
-            assert (os.path.exists(right_image_path))
-            record = {
-                "identifier": ex["identifier"],
-                "sentence": ex["sentence"],
-                "left_image": left_image_path,
-                "right_image": right_image_path,
-                "label": ex["label"],
-            }
-            idx += 1
-            yield idx, record
+        for i, files_path in enumerate(files_paths):
+            for line in open(files_path).readlines():
+                ex = json.loads(line)
+                common_img_identifier = ex["identifier"].split("-")
+                left_img_identifier = f"{common_img_identifier[0]}-{common_img_identifier[1]}-{common_img_identifier[2]}-img0.png"
+                right_img_identifier = f"{common_img_identifier[0]}-{common_img_identifier[1]}-{common_img_identifier[2]}-img1.png"
+                if split_name == "train":
+                    directory = str(ex["directory"])
+                    left_image_path = str(os.path.join(images_paths[i], directory, left_img_identifier))
+                    right_image_path = str(os.path.join(images_paths[i], directory, right_img_identifier))
+                else: 
+                    left_image_path = str(os.path.join(images_paths[i], left_img_identifier))
+                    right_image_path = str(os.path.join(images_paths[i], right_img_identifier))
+                assert (os.path.exists(left_image_path)) 
+                assert (os.path.exists(right_image_path))
+                record = {
+                    "identifier": ex["identifier"],
+                    "sentence": ex["sentence"],
+                    "left_image": left_image_path,
+                    "right_image": right_image_path,
+                    "label": ex["label"],
+                }
+                idx += 1
+                yield idx, record