File size: 9,592 Bytes
3b67767 |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 |
package shell
import (
"context"
"strings"
"testing"
"github.com/stretchr/testify/require"
)
func TestCommandBlocking(t *testing.T) {
tests := []struct {
name string
blockFuncs []BlockFunc
command string
shouldBlock bool
}{
{
name: "block simple command",
blockFuncs: []BlockFunc{
func(args []string) bool {
return len(args) > 0 && args[0] == "curl"
},
},
command: "curl https://example.com",
shouldBlock: true,
},
{
name: "allow non-blocked command",
blockFuncs: []BlockFunc{
func(args []string) bool {
return len(args) > 0 && args[0] == "curl"
},
},
command: "echo hello",
shouldBlock: false,
},
{
name: "block subcommand",
blockFuncs: []BlockFunc{
func(args []string) bool {
return len(args) >= 2 && args[0] == "brew" && args[1] == "install"
},
},
command: "brew install wget",
shouldBlock: true,
},
{
name: "allow different subcommand",
blockFuncs: []BlockFunc{
func(args []string) bool {
return len(args) >= 2 && args[0] == "brew" && args[1] == "install"
},
},
command: "brew list",
shouldBlock: false,
},
{
name: "block npm global install with -g",
blockFuncs: []BlockFunc{
ArgumentsBlocker("npm", []string{"install"}, []string{"-g"}),
},
command: "npm install -g typescript",
shouldBlock: true,
},
{
name: "block npm global install with --global",
blockFuncs: []BlockFunc{
ArgumentsBlocker("npm", []string{"install"}, []string{"--global"}),
},
command: "npm install --global typescript",
shouldBlock: true,
},
{
name: "allow npm local install",
blockFuncs: []BlockFunc{
ArgumentsBlocker("npm", []string{"install"}, []string{"-g"}),
ArgumentsBlocker("npm", []string{"install"}, []string{"--global"}),
},
command: "npm install typescript",
shouldBlock: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
// Create a temporary directory for each test
tmpDir := t.TempDir()
shell := NewShell(&Options{
WorkingDir: tmpDir,
BlockFuncs: tt.blockFuncs,
})
_, _, err := shell.Exec(context.Background(), tt.command)
if tt.shouldBlock {
if err == nil {
t.Errorf("Expected command to be blocked, but it was allowed")
} else if !strings.Contains(err.Error(), "not allowed for security reasons") {
t.Errorf("Expected security error, got: %v", err)
}
} else {
// For non-blocked commands, we might get other errors (like command not found)
// but we shouldn't get the security error
if err != nil && strings.Contains(err.Error(), "not allowed for security reasons") {
t.Errorf("Command was unexpectedly blocked: %v", err)
}
}
})
}
}
func TestArgumentsBlocker(t *testing.T) {
tests := []struct {
name string
cmd string
args []string
flags []string
input []string
shouldBlock bool
}{
// Basic command blocking
{
name: "block exact command match",
cmd: "npm",
args: []string{"install"},
flags: nil,
input: []string{"npm", "install", "package"},
shouldBlock: true,
},
{
name: "allow different command",
cmd: "npm",
args: []string{"install"},
flags: nil,
input: []string{"yarn", "install", "package"},
shouldBlock: false,
},
{
name: "allow different subcommand",
cmd: "npm",
args: []string{"install"},
flags: nil,
input: []string{"npm", "list"},
shouldBlock: false,
},
// Flag-based blocking
{
name: "block with single flag",
cmd: "npm",
args: []string{"install"},
flags: []string{"-g"},
input: []string{"npm", "install", "-g", "typescript"},
shouldBlock: true,
},
{
name: "block with flag in different position",
cmd: "npm",
args: []string{"install"},
flags: []string{"-g"},
input: []string{"npm", "install", "typescript", "-g"},
shouldBlock: true,
},
{
name: "allow without required flag",
cmd: "npm",
args: []string{"install"},
flags: []string{"-g"},
input: []string{"npm", "install", "typescript"},
shouldBlock: false,
},
{
name: "block with multiple flags",
cmd: "pip",
args: []string{"install"},
flags: []string{"--user"},
input: []string{"pip", "install", "--user", "--upgrade", "package"},
shouldBlock: true,
},
// Complex argument patterns
{
name: "block multi-arg subcommand",
cmd: "yarn",
args: []string{"global", "add"},
flags: nil,
input: []string{"yarn", "global", "add", "typescript"},
shouldBlock: true,
},
{
name: "allow partial multi-arg match",
cmd: "yarn",
args: []string{"global", "add"},
flags: nil,
input: []string{"yarn", "global", "list"},
shouldBlock: false,
},
// Edge cases
{
name: "handle empty input",
cmd: "npm",
args: []string{"install"},
flags: nil,
input: []string{},
shouldBlock: false,
},
{
name: "handle command only",
cmd: "npm",
args: []string{"install"},
flags: nil,
input: []string{"npm"},
shouldBlock: false,
},
{
name: "block pacman with -S flag",
cmd: "pacman",
args: nil,
flags: []string{"-S"},
input: []string{"pacman", "-S", "package"},
shouldBlock: true,
},
{
name: "allow pacman without -S flag",
cmd: "pacman",
args: nil,
flags: []string{"-S"},
input: []string{"pacman", "-Q", "package"},
shouldBlock: false,
},
// `go test -exec`
{
name: "go test exec",
cmd: "go",
args: []string{"test"},
flags: []string{"-exec"},
input: []string{"go", "test", "-exec", "bash -c 'echo hello'"},
shouldBlock: true,
},
{
name: "go test exec",
cmd: "go",
args: []string{"test"},
flags: []string{"-exec"},
input: []string{"go", "test", `-exec="bash -c 'echo hello'"`},
shouldBlock: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
blocker := ArgumentsBlocker(tt.cmd, tt.args, tt.flags)
result := blocker(tt.input)
require.Equal(t, tt.shouldBlock, result,
"Expected block=%v for input %v", tt.shouldBlock, tt.input)
})
}
}
func TestCommandsBlocker(t *testing.T) {
tests := []struct {
name string
banned []string
input []string
shouldBlock bool
}{
{
name: "block single banned command",
banned: []string{"curl"},
input: []string{"curl", "https://example.com"},
shouldBlock: true,
},
{
name: "allow non-banned command",
banned: []string{"curl", "wget"},
input: []string{"echo", "hello"},
shouldBlock: false,
},
{
name: "block from multiple banned",
banned: []string{"curl", "wget", "nc"},
input: []string{"wget", "https://example.com"},
shouldBlock: true,
},
{
name: "handle empty input",
banned: []string{"curl"},
input: []string{},
shouldBlock: false,
},
{
name: "case sensitive matching",
banned: []string{"curl"},
input: []string{"CURL", "https://example.com"},
shouldBlock: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
blocker := CommandsBlocker(tt.banned)
result := blocker(tt.input)
require.Equal(t, tt.shouldBlock, result,
"Expected block=%v for input %v", tt.shouldBlock, tt.input)
})
}
}
func TestSplitArgsFlags(t *testing.T) {
tests := []struct {
name string
input []string
wantArgs []string
wantFlags []string
}{
{
name: "only args",
input: []string{"install", "package", "another"},
wantArgs: []string{"install", "package", "another"},
wantFlags: []string{},
},
{
name: "only flags",
input: []string{"-g", "--verbose", "-f"},
wantArgs: []string{},
wantFlags: []string{"-g", "--verbose", "-f"},
},
{
name: "mixed args and flags",
input: []string{"install", "-g", "package", "--verbose"},
wantArgs: []string{"install", "package"},
wantFlags: []string{"-g", "--verbose"},
},
{
name: "empty input",
input: []string{},
wantArgs: []string{},
wantFlags: []string{},
},
{
name: "single dash flag",
input: []string{"-S", "package"},
wantArgs: []string{"package"},
wantFlags: []string{"-S"},
},
{
name: "flag with equals sign",
input: []string{"-exec=bash", "package"},
wantArgs: []string{"package"},
wantFlags: []string{"-exec"},
},
{
name: "long flag with equals sign",
input: []string{"--config=/path/to/config", "run"},
wantArgs: []string{"run"},
wantFlags: []string{"--config"},
},
{
name: "flag with complex value",
input: []string{`-exec="bash -c 'echo hello'"`, "test"},
wantArgs: []string{"test"},
wantFlags: []string{"-exec"},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
args, flags := splitArgsFlags(tt.input)
require.Equal(t, tt.wantArgs, args, "args mismatch")
require.Equal(t, tt.wantFlags, flags, "flags mismatch")
})
}
}
|