repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟡 Minor_ **Define TLS credential variables in the HTTP/2 snippet.** On Lines 132-134, `tlsKey` and `tlsCert` are used but never declared, so the example is not runnable as-is. <details> <summary>Suggested patch</summary> ```diff +import { readFileSync } from 'node:fs'; + +const tlsKey = r...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/server/skills/adapter-standalone/SKILL.md b/packages/server/skills/adapter-standalone/SKILL.md new file mode 100644 index 00000000000..368bb93d710 --- /dev/null +++ b/packages/server/skills/adapter-standalone/SKILL.md @@ -0,0 +1,184 @@ +--- +name: adapter-standalone +description: > + Mount tRPC o...
[ "packages/server/skills/adapter-standalone/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Define TLS credential variables in the HTTP/2 snippet.** \nOn Lines 132-134, `tlsKey` and `tlsCert` are used but never declared, so the example is not runnable as-is.\n\n\n<details>\n<summary>Suggested patch</summary>\n\n```diff\n+import { readFileSync } fro...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟠 Major_ <details> <summary>🧩 Analysis chain</summary> 🌐 Web query: `For tRPC v11, does httpSubscriptionLink send connectionParams in the URL query string for SSE, and what auth methods are officially recommended for sensitive tokens?` 💡 Result: Yes. In tRPC v11, `httpSubscriptionLink` ...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/server/skills/auth/SKILL.md b/packages/server/skills/auth/SKILL.md new file mode 100644 index 00000000000..e19135921a8 --- /dev/null +++ b/packages/server/skills/auth/SKILL.md @@ -0,0 +1,342 @@ +--- +name: auth +description: > + Implement JWT/cookie authentication and authorization in tRPC using ...
[ "packages/server/skills/auth/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🌐 Web query:\n\n`For tRPC v11, does httpSubscriptionLink send connectionParams in the URL query string for SSE, and what auth methods are officially recommended for sensitive tokens?`\n\n💡 Result:\n\nYes. In ...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟠 Major_ **Use strict route-prefix matching for cache eligibility.** `includes('public')` can misclassify routes and unintentionally cache responses that were not meant to be treated as public. <details> <summary>Suggested doc fix</summary> ```diff - const allPublic = paths && paths.ever...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/server/skills/caching/SKILL.md b/packages/server/skills/caching/SKILL.md new file mode 100644 index 00000000000..ede436d1ca5 --- /dev/null +++ b/packages/server/skills/caching/SKILL.md @@ -0,0 +1,205 @@ +--- +name: caching +description: > + Set HTTP cache headers on tRPC query responses via respo...
[ "packages/server/skills/caching/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**Use strict route-prefix matching for cache eligibility.**\n\n`includes('public')` can misclassify routes and unintentionally cache responses that were not meant to be treated as public.\n\n<details>\n<summary>Suggested doc fix</summary>\n\n```diff\n- const...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟡 Minor_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell #!/bin/bash # Verify how lazy-loaded routers are documented/used across the repo. # Expected: examples should consistently select a router export, or clearly document default-export requirement. rg -n -C2 "...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/server/skills/server-setup/SKILL.md b/packages/server/skills/server-setup/SKILL.md new file mode 100644 index 00000000000..20a78a77ae2 --- /dev/null +++ b/packages/server/skills/server-setup/SKILL.md @@ -0,0 +1,378 @@ +--- +name: server-setup +description: > + Initialize tRPC with initTRPC.create...
[ "packages/server/skills/server-setup/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Verify how lazy-loaded routers are documented/used across the repo.\n# Expected: examples should consistently select a router export, or clearly document default-...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟡 Minor_ **`byId` is referenced but not defined in the documented router.** Line 131 calls `caller.post.byId(...)`, but the setup router (Line 46-56) only defines `add` and `list`, so this example is not copy-paste runnable. <details> <summary>Suggested doc fix</summary> ```diff - const ...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/server/skills/server-side-calls/SKILL.md b/packages/server/skills/server-side-calls/SKILL.md new file mode 100644 index 00000000000..39f5df9c2a5 --- /dev/null +++ b/packages/server/skills/server-side-calls/SKILL.md @@ -0,0 +1,249 @@ +--- +name: server-side-calls +description: > + Call tRPC proced...
[ "packages/server/skills/server-side-calls/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**`byId` is referenced but not defined in the documented router.**\n\nLine 131 calls `caller.post.byId(...)`, but the setup router (Line 46-56) only defines `add` and `list`, so this example is not copy-paste runnable.\n\n<details>\n<summary>Suggested doc fix</...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟡 Minor_ **Guard missing service routes before invoking `link`.** At Line 128, `servers[serverName]` can be `undefined`; calling it on Line 129 yields a generic runtime TypeError instead of a clear routing error. <details> <summary>Suggested fix</summary> ```diff const link = servers...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/server/skills/service-oriented-architecture/SKILL.md b/packages/server/skills/service-oriented-architecture/SKILL.md new file mode 100644 index 00000000000..a7d3f71ab31 --- /dev/null +++ b/packages/server/skills/service-oriented-architecture/SKILL.md @@ -0,0 +1,247 @@ +--- +name: service-oriented-...
[ "packages/server/skills/service-oriented-architecture/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Guard missing service routes before invoking `link`.**\n\nAt Line 128, `servers[serverName]` can be `undefined`; calling it on Line 129 yields a generic runtime TypeError instead of a clear routing error.\n\n<details>\n<summary>Suggested fix</summary>\n\n```d...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟡 Minor_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell #!/bin/bash set -euo pipefail # Verify the actual httpBatchLink signature in source before finalizing the snippet type annotation. fd 'httpBatchLink.ts' packages/client/src -t f -x rg -n -C3 'export .*httpBa...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/server/skills/service-oriented-architecture/SKILL.md b/packages/server/skills/service-oriented-architecture/SKILL.md new file mode 100644 index 00000000000..a7d3f71ab31 --- /dev/null +++ b/packages/server/skills/service-oriented-architecture/SKILL.md @@ -0,0 +1,247 @@ +--- +name: service-oriented-...
[ "packages/server/skills/service-oriented-architecture/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n# Verify the actual httpBatchLink signature in source before finalizing the snippet type annotation.\nfd 'httpBatchLink.ts' packages/client/src -...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟡 Minor_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell #!/bin/bash # Verify where createWSClient is imported from across docs/code. rg -nP "createWSClient\s*[,)]|from '@trpc/client'|from '@trpc/server/adapters/ws'" -C2 ``` Repository: trpc/trpc Length of outpu...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/server/skills/subscriptions/SKILL.md b/packages/server/skills/subscriptions/SKILL.md new file mode 100644 index 00000000000..f963915679a --- /dev/null +++ b/packages/server/skills/subscriptions/SKILL.md @@ -0,0 +1,406 @@ +--- +name: subscriptions +description: > + Set up real-time event streams w...
[ "packages/server/skills/subscriptions/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Verify where createWSClient is imported from across docs/code.\nrg -nP \"createWSClient\\s*[,)]|from '@trpc/client'|from '@trpc/server/adapters/ws'\" -C2\n```\n\n...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🔴 Critical_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell #!/bin/bash set -euo pipefail echo "== bin script ==" sed -n '1,220p' packages/tanstack-react-query/bin/intent.js echo echo "== package dependency blocks ==" jq '{dependencies, devDependencies, peerDepe...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/tanstack-react-query/package.json b/packages/tanstack-react-query/package.json index 090979c49dd..d59e6ce9a9d 100644 --- a/packages/tanstack-react-query/package.json +++ b/packages/tanstack-react-query/package.json @@ -39,7 +39,10 @@ "README.md", "package.json", "!**/*.test.*", - ...
[ "packages/tanstack-react-query/package.json" ]
[ { "comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\necho \"== bin script ==\"\nsed -n '1,220p' packages/tanstack-react-query/bin/intent.js\n\necho\necho \"== package dependency blocks ==\"\njq...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟠 Major_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell #!/bin/bash set -euo pipefail # Expect no matches after fix rg -nP --multiline 'async function\s+\w+\s*\([^)]*\)\s*\{[\s\S]*?\buseTRPCClient\s*\(' \ packages/tanstack-react-query/skills/react-query-setup/S...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/tanstack-react-query/skills/react-query-setup/SKILL.md b/packages/tanstack-react-query/skills/react-query-setup/SKILL.md new file mode 100644 index 00000000000..ec9e3898657 --- /dev/null +++ b/packages/tanstack-react-query/skills/react-query-setup/SKILL.md @@ -0,0 +1,347 @@ +--- +name: react-query...
[ "packages/tanstack-react-query/skills/react-query-setup/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n# Expect no matches after fix\nrg -nP --multiline 'async function\\s+\\w+\\s*\\([^)]*\\)\\s*\\{[\\s\\S]*?\\buseTRPCClient\\s*\\(' \\\n packages/...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟡 Minor_ **Tighten phrasing for readability.** Line 314 can be simplified by replacing “inside of” with “inside”. <details> <summary>🧰 Tools</summary> <details> <summary>🪛 LanguageTool</summary> [style] ~314-~314: This phrase is redundant. Consider using “inside”. Context: ...RPCProvide...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/tanstack-react-query/skills/react-query-setup/SKILL.md b/packages/tanstack-react-query/skills/react-query-setup/SKILL.md new file mode 100644 index 00000000000..ec9e3898657 --- /dev/null +++ b/packages/tanstack-react-query/skills/react-query-setup/SKILL.md @@ -0,0 +1,347 @@ +--- +name: react-query...
[ "packages/tanstack-react-query/skills/react-query-setup/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Tighten phrasing for readability.** \nLine 314 can be simplified by replacing “inside of” with “inside”.\n\n<details>\n<summary>🧰 Tools</summary>\n\n<details>\n<summary>🪛 LanguageTool</summary>\n\n[style] ~314-~314: This phrase is redundant. Consider using...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟡 Minor_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell #!/bin/bash # Description: Verify tRPC version 11.13.4 exists and check transformer API usage # Check if version exists in package.json or npm registry echo "Checking for tRPC version references in the repo...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/client/skills/superjson/SKILL.md b/packages/client/skills/superjson/SKILL.md new file mode 100644 index 00000000000..c5ffe2ffb32 --- /dev/null +++ b/packages/client/skills/superjson/SKILL.md @@ -0,0 +1,273 @@ +--- +name: superjson +description: > + Configure SuperJSON transformer on both server i...
[ "packages/client/skills/superjson/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Description: Verify tRPC version 11.13.4 exists and check transformer API usage\n\n# Check if version exists in package.json or npm registry\necho \"Checking for ...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟡 Minor_ **Add a language hint to the fenced tree block.** The fenced block at Line 27 is missing a language identifier (markdownlint MD040). <details> <summary>Suggested fix</summary> ```diff -``` +```text . ├── src │ ├── pages ... └── ... ``` ``` </details> <details> <summary>🧰...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/next/skills/nextjs-pages-router/SKILL.md b/packages/next/skills/nextjs-pages-router/SKILL.md new file mode 100644 index 00000000000..fee734626e2 --- /dev/null +++ b/packages/next/skills/nextjs-pages-router/SKILL.md @@ -0,0 +1,371 @@ +--- +name: nextjs-pages-router +description: > + Set up tRPC in...
[ "packages/next/skills/nextjs-pages-router/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Add a language hint to the fenced tree block.**\n\nThe fenced block at Line 27 is missing a language identifier (markdownlint MD040).\n\n\n<details>\n<summary>Suggested fix</summary>\n\n```diff\n-```\n+```text\n .\n ├── src\n │ ├── pages\n ...\n └── ...\n `...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟠 Major_ **Avoid permissive wildcard CORS in the API example.** Using `Access-Control-Allow-Origin: *` and `Access-Control-Allow-Headers: *` is unsafe for production and conflicts with cookie/session-based auth patterns often used with tRPC. <details> <summary>Suggested hardening</summary> ...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/next/skills/nextjs-pages-router/SKILL.md b/packages/next/skills/nextjs-pages-router/SKILL.md new file mode 100644 index 00000000000..fee734626e2 --- /dev/null +++ b/packages/next/skills/nextjs-pages-router/SKILL.md @@ -0,0 +1,371 @@ +--- +name: nextjs-pages-router +description: > + Set up tRPC in...
[ "packages/next/skills/nextjs-pages-router/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**Avoid permissive wildcard CORS in the API example.**\n\nUsing `Access-Control-Allow-Origin: *` and `Access-Control-Allow-Headers: *` is unsafe for production and conflicts with cookie/session-based auth patterns often used with tRPC.\n\n\n<details>\n<summary>...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟡 Minor_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell # First, check if the file exists and get its size if [ -f "packages/openapi/skills/openapi/SKILL.md" ]; then wc -l packages/openapi/skills/openapi/SKILL.md else echo "File not found, searching for simil...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/openapi/skills/openapi/SKILL.md b/packages/openapi/skills/openapi/SKILL.md new file mode 100644 index 00000000000..3eb7ced8c0b --- /dev/null +++ b/packages/openapi/skills/openapi/SKILL.md @@ -0,0 +1,300 @@ +--- +name: openapi +description: > + Generate OpenAPI 3.1 spec from a tRPC router with @tr...
[ "packages/openapi/skills/openapi/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n# First, check if the file exists and get its size\nif [ -f \"packages/openapi/skills/openapi/SKILL.md\" ]; then\n wc -l packages/openapi/skills/openapi/SKILL.md\nelse\n echo ...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟡 Minor_ **Clarify the “Correct” alternatives to avoid configuring both links at once.** The snippet currently shows `httpBatchLink` and `httpLink` together under “Correct”, which can be read as “use both.” Split into explicit Option A / Option B snippets. <details> <summary>Proposed doc fi...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/server/skills/adapter-aws-lambda/SKILL.md b/packages/server/skills/adapter-aws-lambda/SKILL.md new file mode 100644 index 00000000000..a4808e6a62c --- /dev/null +++ b/packages/server/skills/adapter-aws-lambda/SKILL.md @@ -0,0 +1,188 @@ +--- +name: adapter-aws-lambda +description: > + Deploy tRPC ...
[ "packages/server/skills/adapter-aws-lambda/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Clarify the “Correct” alternatives to avoid configuring both links at once.**\n\nThe snippet currently shows `httpBatchLink` and `httpLink` together under “Correct”, which can be read as “use both.” Split into explicit Option A / Option B snippets.\n\n\n<deta...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟡 Minor_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell #!/bin/bash # Verify whether SKILL.md is a repo-wide convention and whether docs/tooling require it. # 1) Find all SKILL.md files to confirm pattern usage fd -HI '^SKILL\.md$' # 2) Search for references to...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/server/skills/adapter-fetch/SKILL.md b/packages/server/skills/adapter-fetch/SKILL.md new file mode 100644 index 00000000000..523240d194a --- /dev/null +++ b/packages/server/skills/adapter-fetch/SKILL.md @@ -0,0 +1,177 @@ +--- +name: adapter-fetch +description: > + Deploy tRPC on WinterCG-complian...
[ "packages/server/skills/adapter-fetch/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Verify whether SKILL.md is a repo-wide convention and whether docs/tooling require it.\n\n# 1) Find all SKILL.md files to confirm pattern usage\nfd -HI '^SKILL\\....
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟡 Minor_ **Rename `SKILL.md` to a camelCase filename to match repo rule.** This file naming does not follow the configured camelCase convention for `.md` files. As per coding guidelines: "`**/*.{ts,tsx,md,mdx}`: Use camelCase for file names (with exceptions like TRPC/RPC/HTTP/JSON acronym...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/server/skills/trpc-router/SKILL.md b/packages/server/skills/trpc-router/SKILL.md new file mode 100644 index 00000000000..71e5c911cbb --- /dev/null +++ b/packages/server/skills/trpc-router/SKILL.md @@ -0,0 +1,151 @@ +--- +name: trpc-router +description: > + Entry point for all tRPC skills. Decisio...
[ "packages/server/skills/trpc-router/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Rename `SKILL.md` to a camelCase filename to match repo rule.**\n\nThis file naming does not follow the configured camelCase convention for `.md` files.\n\n \n\nAs per coding guidelines: \"`**/*.{ts,tsx,md,mdx}`: Use camelCase for file names (with exceptions ...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟡 Minor_ **Replace placeholder CLI option text with the exact prompt string.** `Migrate Hooks to xxxOptions API` reads like a placeholder and may not match what users see in the CLI. Please use the exact option label from `npx `@trpc/upgrade`` output. <details> <summary>🤖 Prompt for AI Agen...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/tanstack-react-query/skills/react-query-classic-migration/SKILL.md b/packages/tanstack-react-query/skills/react-query-classic-migration/SKILL.md new file mode 100644 index 00000000000..587de7488f8 --- /dev/null +++ b/packages/tanstack-react-query/skills/react-query-classic-migration/SKILL.md @@ -0...
[ "packages/tanstack-react-query/skills/react-query-classic-migration/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Replace placeholder CLI option text with the exact prompt string.**\n\n`Migrate Hooks to xxxOptions API` reads like a placeholder and may not match what users see in the CLI. Please use the exact option label from `npx `@trpc/upgrade`` output.\n\n<details>\n<...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟠 Major_ <details> <summary>🧩 Analysis chain</summary> 🌐 Web query: `In `@trpc/tanstack-react-query` v11, what is the canonical provider setup with createTRPCContext, and what variable name/type is passed to TRPCProvider's trpcClient prop?` 💡 Result: ```ts // utils/trpc.ts import { crea...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/tanstack-react-query/skills/react-query-classic-migration/SKILL.md b/packages/tanstack-react-query/skills/react-query-classic-migration/SKILL.md new file mode 100644 index 00000000000..587de7488f8 --- /dev/null +++ b/packages/tanstack-react-query/skills/react-query-classic-migration/SKILL.md @@ -0...
[ "packages/tanstack-react-query/skills/react-query-classic-migration/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🌐 Web query:\n\n`In `@trpc/tanstack-react-query` v11, what is the canonical provider setup with createTRPCContext, and what variable name/type is passed to TRPCProvider's trpcClient prop?`\n\n💡 Result:\n\n```...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟠 Major_ <details> <summary>🧩 Analysis chain</summary> 🌐 Web query: `For `@trpc/tanstack-react-query` v11, what is the signature/usage pattern of `mutationOptions` compared to `queryOptions`?` 💡 Result: In `@trpc/tanstack-react-query` v11, both helpers return **native TanStack Query opt...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/tanstack-react-query/skills/react-query-classic-migration/SKILL.md b/packages/tanstack-react-query/skills/react-query-classic-migration/SKILL.md new file mode 100644 index 00000000000..587de7488f8 --- /dev/null +++ b/packages/tanstack-react-query/skills/react-query-classic-migration/SKILL.md @@ -0...
[ "packages/tanstack-react-query/skills/react-query-classic-migration/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🌐 Web query:\n\n`For `@trpc/tanstack-react-query` v11, what is the signature/usage pattern of `mutationOptions` compared to `queryOptions`?`\n\n💡 Result:\n\nIn `@trpc/tanstack-react-query` v11, both helpers r...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟡 Minor_ **`SKILL.md` filename breaks the md/mdx camelCase naming rule.** Please rename this file to a camelCase markdown filename, or explicitly add `SKILL.md` to guideline exceptions if required by tooling. As per coding guidelines `**/*.{ts,tsx,md,mdx}`: Use camelCase for file names (w...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/tanstack-react-query/skills/react-query-setup/SKILL.md b/packages/tanstack-react-query/skills/react-query-setup/SKILL.md new file mode 100644 index 00000000000..ec9e3898657 --- /dev/null +++ b/packages/tanstack-react-query/skills/react-query-setup/SKILL.md @@ -0,0 +1,347 @@ +--- +name: react-query...
[ "packages/tanstack-react-query/skills/react-query-setup/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**`SKILL.md` filename breaks the md/mdx camelCase naming rule.**\n\nPlease rename this file to a camelCase markdown filename, or explicitly add `SKILL.md` to guideline exceptions if required by tooling. \n\n\nAs per coding guidelines `**/*.{ts,tsx,md,mdx}`: Us...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟡 Minor_ **Add a language to the fenced code block (MD040).** Line 32 opens a fence without a language specifier, which trips markdownlint and reduces editor tooling support. <details> <summary>Suggested fix</summary> ```diff -``` +```text . ├── app │ ├── api/trpc/[trpc] │ │ └──...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/next/skills/nextjs-app-router/SKILL.md b/packages/next/skills/nextjs-app-router/SKILL.md new file mode 100644 index 00000000000..7db1386e6e2 --- /dev/null +++ b/packages/next/skills/nextjs-app-router/SKILL.md @@ -0,0 +1,429 @@ +--- +name: nextjs-app-router +description: > + Full end-to-end tRPC s...
[ "packages/next/skills/nextjs-app-router/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Add a language to the fenced code block (MD040).**\n\nLine 32 opens a fence without a language specifier, which trips markdownlint and reduces editor tooling support.\n\n\n\n<details>\n<summary>Suggested fix</summary>\n\n```diff\n-```\n+```text\n .\n ├── app\...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟠 Major_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell #!/bin/bash # Description: Check for caller factory pattern usage in examples echo "=== Searching for createCallerFactory usage ===" rg -n -C5 "createCallerFactory" echo -e "\n=== Searching for direct crea...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/next/skills/nextjs-app-router/SKILL.md b/packages/next/skills/nextjs-app-router/SKILL.md new file mode 100644 index 00000000000..7db1386e6e2 --- /dev/null +++ b/packages/next/skills/nextjs-app-router/SKILL.md @@ -0,0 +1,429 @@ +--- +name: nextjs-app-router +description: > + Full end-to-end tRPC s...
[ "packages/next/skills/nextjs-app-router/SKILL.md" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Description: Check for caller factory pattern usage in examples\n\necho \"=== Searching for createCallerFactory usage ===\"\nrg -n -C5 \"createCallerFactory\"\n\n...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
`bin.intent` points to `./bin/intent.js`, but there is no `packages/client/bin/` in the repo (and no `intent.js` anywhere). Publishing this will generate a broken `intent` shim when installing `@trpc/client`.
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/client/package.json b/packages/client/package.json index 1fae648eaf9..bfd4afe5ca4 100644 --- a/packages/client/package.json +++ b/packages/client/package.json @@ -109,13 +109,17 @@ "links", "unstable-internals", "!**/*.test.*", - "!**/__tests__" + "!**/__tests__", + "skills...
[ "packages/client/package.json" ]
[ { "comment": "`bin.intent` points to `./bin/intent.js`, but there is no `packages/client/bin/` in the repo (and no `intent.js` anywhere). Publishing this will generate a broken `intent` shim when installing `@trpc/client`.", "path": "packages/client/package.json", "hunk": "@@ -134,5 +137,11 @@\n },\n ...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
`bin.intent` points to `./bin/intent.js`, but there is no `packages/next/bin/` directory in this PR. As-is, installing `@trpc/next` will create a broken `intent` executable.
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/next/package.json b/packages/next/package.json index bdf36f5c1d6..6942604e82f 100644 --- a/packages/next/package.json +++ b/packages/next/package.json @@ -100,7 +100,10 @@ "app-dir", "ssrPrepass", "!**/*.test.*", - "!**/__tests__" + "!**/__tests__", + "skills", + "!skill...
[ "packages/next/package.json" ]
[ { "comment": "`bin.intent` points to `./bin/intent.js`, but there is no `packages/next/bin/` directory in this PR. As-is, installing `@trpc/next` will create a broken `intent` executable.\n", "path": "packages/next/package.json", "hunk": "@@ -144,5 +147,11 @@\n },\n \"funding\": [\n \"https://tr...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
`bin.intent` points to `./bin/intent.js`, but there is no `packages/openapi/bin/intent.js` in the repo. This will break installs by adding a non-functional `intent` shim alongside `trpc-openapi`.
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/openapi/package.json b/packages/openapi/package.json index 1ffe92e6860..f8406a34b96 100644 --- a/packages/openapi/package.json +++ b/packages/openapi/package.json @@ -7,7 +7,8 @@ "author": "KATT", "license": "MIT", "bin": { - "trpc-openapi": "./dist/cli.js" + "trpc-openapi": "./dist...
[ "packages/openapi/package.json" ]
[ { "comment": "`bin.intent` points to `./bin/intent.js`, but there is no `packages/openapi/bin/intent.js` in the repo. This will break installs by adding a non-functional `intent` shim alongside `trpc-openapi`.\n", "path": "packages/openapi/package.json", "hunk": "@@ -7,7 +7,8 @@\n \"author\": \"KATT\"...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
`bin.intent` points to `./bin/intent.js`, but `packages/tanstack-react-query/bin/` is not present in this PR. Publishing this package will create a broken `intent` executable on install.
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/tanstack-react-query/package.json b/packages/tanstack-react-query/package.json index 090979c49dd..d59e6ce9a9d 100644 --- a/packages/tanstack-react-query/package.json +++ b/packages/tanstack-react-query/package.json @@ -39,7 +39,10 @@ "README.md", "package.json", "!**/*.test.*", - ...
[ "packages/tanstack-react-query/package.json" ]
[ { "comment": "`bin.intent` points to `./bin/intent.js`, but `packages/tanstack-react-query/bin/` is not present in this PR. Publishing this package will create a broken `intent` executable on install.", "path": "packages/tanstack-react-query/package.json", "hunk": "@@ -80,5 +83,11 @@\n },\n \"fundin...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
The header comment says `skills/_artifacts/skill_tree.yaml`, but this file is actually at `_artifacts/skill_tree.yaml`. Either move the file to match the comment or update the comment to avoid confusing consumers/scripts that rely on paths.
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/_artifacts/skill_tree.yaml b/_artifacts/skill_tree.yaml new file mode 100644 index 00000000000..a53e9690b9c --- /dev/null +++ b/_artifacts/skill_tree.yaml @@ -0,0 +1,485 @@ +# _artifacts/skill_tree.yaml +library: + name: '@trpc/server' + version: '11.14.0' + repository: 'https://github.com/trpc/trpc' + ...
[ "_artifacts/skill_tree.yaml" ]
[ { "comment": "The header comment says `skills/_artifacts/skill_tree.yaml`, but this file is actually at `_artifacts/skill_tree.yaml`. Either move the file to match the comment or update the comment to avoid confusing consumers/scripts that rely on paths.", "path": "_artifacts/skill_tree.yaml", "hunk": "...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
`bin.intent` points to `./bin/intent.js`, but `packages/server/bin/` doesn't exist in this PR. This will make `@trpc/server` installs fail (npm/yarn will create a broken shim). Also note multiple @trpc/* packages in this PR declare the same `intent` binary name, which will conflict/overwrite when users install more tha...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/server/package.json b/packages/server/package.json index 373f0003788..58f27aa6ce4 100644 --- a/packages/server/package.json +++ b/packages/server/package.json @@ -187,7 +187,10 @@ "shared", "unstable-core-do-not-import", "!**/*.test.*", - "!**/__tests__" + "!**/__tests__", + ...
[ "packages/server/package.json" ]
[ { "comment": "`bin.intent` points to `./bin/intent.js`, but `packages/server/bin/` doesn't exist in this PR. This will make `@trpc/server` installs fail (npm/yarn will create a broken shim). Also note multiple @trpc/* packages in this PR declare the same `intent` binary name, which will conflict/overwrite when ...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟠 Major_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell # Check the workflow file at the specified lines cat -n .github/workflows/check-skills.yml | sed -n '35,42p' ``` Repository: trpc/trpc Length of output: 273 --- 🏁 Script executed: ```shell # Check the ...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/.github/workflows/check-skills.yml b/.github/workflows/check-skills.yml new file mode 100644 index 00000000000..9435aead66c --- /dev/null +++ b/.github/workflows/check-skills.yml @@ -0,0 +1,143 @@ +# check-skills.yml — Drop this into your library repo's .github/workflows/ +# +# Checks for stale intent skil...
[ ".github/workflows/check-skills.yml" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n# Check the workflow file at the specified lines\ncat -n .github/workflows/check-skills.yml | sed -n '35,42p'\n```\n\nRepository: trpc/trpc\n\nLength of output: 273\n\n---\n\n🏁...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟠 Major_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell git ls-files | grep -E "(workflow|check-skills)" | head -20 ``` Repository: trpc/trpc Length of output: 624 --- 🏁 Script executed: ```shell cat -n .github/workflows/check-skills.yml | head -100 ``` Re...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/.github/workflows/check-skills.yml b/.github/workflows/check-skills.yml new file mode 100644 index 00000000000..9435aead66c --- /dev/null +++ b/.github/workflows/check-skills.yml @@ -0,0 +1,143 @@ +# check-skills.yml — Drop this into your library repo's .github/workflows/ +# +# Checks for stale intent skil...
[ ".github/workflows/check-skills.yml" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\ngit ls-files | grep -E \"(workflow|check-skills)\" | head -20\n```\n\nRepository: trpc/trpc\n\nLength of output: 624\n\n---\n\n🏁 Script executed:\n\n```shell\ncat -n .github/wo...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟠 Major_ **Use a unique, sanitized branch name for reruns.** Line 113 reuses `skills/review-manual` for every manual run and `skills/review-<tag>` for every rerun of the same release. Once that branch or PR exists, `git push`/`gh pr create` will collide, and raw tag names can also produce inv...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/.github/workflows/check-skills.yml b/.github/workflows/check-skills.yml new file mode 100644 index 00000000000..9435aead66c --- /dev/null +++ b/.github/workflows/check-skills.yml @@ -0,0 +1,143 @@ +# check-skills.yml — Drop this into your library repo's .github/workflows/ +# +# Checks for stale intent skil...
[ ".github/workflows/check-skills.yml" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**Use a unique, sanitized branch name for reruns.**\n\nLine 113 reuses `skills/review-manual` for every manual run and `skills/review-<tag>` for every rerun of the same release. Once that branch or PR exists, `git push`/`gh pr create` will collide, and raw tag ...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟠 Major_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell find . -type f -name "validate-skills.yml" | head -5 ``` Repository: trpc/trpc Length of output: 92 --- 🏁 Script executed: ```shell find . -type f -name "package.json" | head -5 ``` Repository: trpc/t...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/.github/workflows/validate-skills.yml b/.github/workflows/validate-skills.yml new file mode 100644 index 00000000000..8f39716aa98 --- /dev/null +++ b/.github/workflows/validate-skills.yml @@ -0,0 +1,52 @@ +# validate-skills.yml — Drop this into your library repo's .github/workflows/ +# +# Validates skill f...
[ ".github/workflows/validate-skills.yml" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\nfind . -type f -name \"validate-skills.yml\" | head -5\n```\n\nRepository: trpc/trpc\n\nLength of output: 92\n\n---\n\n🏁 Script executed:\n\n```shell\nfind . -type f -name \"pa...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_⚠️ Potential issue_ | _🟠 Major_ **Missing `bin/intent.js` shim and `@tanstack/intent` devDependency.** The pipeline failure indicates that `bin/intent.js` doesn't exist and `@tanstack/intent` is not in devDependencies. The bin entry will fail at runtime since it points to a non-existent file. Run the suggested com...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/openapi/package.json b/packages/openapi/package.json index 1ffe92e6860..f8406a34b96 100644 --- a/packages/openapi/package.json +++ b/packages/openapi/package.json @@ -7,7 +7,8 @@ "author": "KATT", "license": "MIT", "bin": { - "trpc-openapi": "./dist/cli.js" + "trpc-openapi": "./dist...
[ "packages/openapi/package.json" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**Missing `bin/intent.js` shim and `@tanstack/intent` devDependency.**\n\nThe pipeline failure indicates that `bin/intent.js` doesn't exist and `@tanstack/intent` is not in devDependencies. The bin entry will fail at runtime since it points to a non-existent fi...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
The package declares `"bin": { "intent": "./bin/intent.js" }` but `bin/` is not included in the `files` allowlist, so the published tarball will omit the script and the binary will be broken for consumers. Add `bin` to `files` (or ensure publishing includes it). Also, exporting a generic `intent` binary from multiple @...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/next/package.json b/packages/next/package.json index bdf36f5c1d6..6942604e82f 100644 --- a/packages/next/package.json +++ b/packages/next/package.json @@ -100,7 +100,10 @@ "app-dir", "ssrPrepass", "!**/*.test.*", - "!**/__tests__" + "!**/__tests__", + "skills", + "!skill...
[ "packages/next/package.json" ]
[ { "comment": "The package declares `\"bin\": { \"intent\": \"./bin/intent.js\" }` but `bin/` is not included in the `files` allowlist, so the published tarball will omit the script and the binary will be broken for consumers. Add `bin` to `files` (or ensure publishing includes it). Also, exporting a generic `in...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
The package exports an `intent` binary but `bin/` is not included in the `files` allowlist, meaning `./bin/intent.js` won’t be published and the binary will be broken for consumers. Add `bin` to `files` (or ensure the file is otherwise included). Additionally, using the same `intent` binary name across multiple @trpc/*...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/tanstack-react-query/package.json b/packages/tanstack-react-query/package.json index 090979c49dd..d59e6ce9a9d 100644 --- a/packages/tanstack-react-query/package.json +++ b/packages/tanstack-react-query/package.json @@ -39,7 +39,10 @@ "README.md", "package.json", "!**/*.test.*", - ...
[ "packages/tanstack-react-query/package.json" ]
[ { "comment": "The package exports an `intent` binary but `bin/` is not included in the `files` allowlist, meaning `./bin/intent.js` won’t be published and the binary will be broken for consumers. Add `bin` to `files` (or ensure the file is otherwise included). Additionally, using the same `intent` binary name a...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
This package adds an `intent` binary. Since other @trpc/* packages in this PR also export a binary named `intent`, projects that install multiple `@trpc` packages will get a `node_modules/.bin/intent` name collision (whichever package is linked last wins). Consider using a unique binary name (e.g. `trpc-intent`) or exp...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/openapi/package.json b/packages/openapi/package.json index 1ffe92e6860..f8406a34b96 100644 --- a/packages/openapi/package.json +++ b/packages/openapi/package.json @@ -7,7 +7,8 @@ "author": "KATT", "license": "MIT", "bin": { - "trpc-openapi": "./dist/cli.js" + "trpc-openapi": "./dist...
[ "packages/openapi/package.json" ]
[ { "comment": "This package adds an `intent` binary. Since other @trpc/* packages in this PR also export a binary named `intent`, projects that install multiple `@trpc` packages will get a `node_modules/.bin/intent` name collision (whichever package is linked last wins). Consider using a unique binary name (e.g....
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
The workflow path filter uses `packages/www/docs/**`, but this repo’s docs live under `www/docs/**` (e.g. `www/docs/server/...`). As written, doc changes won’t trigger this workflow. Update the docs path pattern to the correct location so skill-review dispatch runs when docs change.
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/.github/workflows/notify-intent.yml b/.github/workflows/notify-intent.yml new file mode 100644 index 00000000000..eaa638a7561 --- /dev/null +++ b/.github/workflows/notify-intent.yml @@ -0,0 +1,55 @@ +# notify-intent.yml — Drop this into your library repo's .github/workflows/ +# +# Fires a repository_dispat...
[ ".github/workflows/notify-intent.yml" ]
[ { "comment": "The workflow path filter uses `packages/www/docs/**`, but this repo’s docs live under `www/docs/**` (e.g. `www/docs/server/...`). As written, doc changes won’t trigger this workflow. Update the docs path pattern to the correct location so skill-review dispatch runs when docs change.", "path": ...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
The package defines a `bin` entry (`./bin/intent.js`), but `bin/` is not included in the `files` allowlist. With the current `files` array, the published package will omit `bin/intent.js`, causing installs to ship a broken binary. Add `bin` to `files` (and ensure the path exists in the published tarball). Also, exporti...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/server/package.json b/packages/server/package.json index 373f0003788..58f27aa6ce4 100644 --- a/packages/server/package.json +++ b/packages/server/package.json @@ -187,7 +187,10 @@ "shared", "unstable-core-do-not-import", "!**/*.test.*", - "!**/__tests__" + "!**/__tests__", + ...
[ "packages/server/package.json" ]
[ { "comment": "The package defines a `bin` entry (`./bin/intent.js`), but `bin/` is not included in the `files` allowlist. With the current `files` array, the published package will omit `bin/intent.js`, causing installs to ship a broken binary. Add `bin` to `files` (and ensure the path exists in the published t...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
The package now exposes an `intent` binary, but `bin/` is not part of the `files` allowlist. As-is, `./bin/intent.js` will not be published, breaking the `bin` entry for consumers. Add `bin` to `files` (or otherwise ensure it’s published). Also note that multiple @trpc/* packages now export the same `intent` binary nam...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/client/package.json b/packages/client/package.json index 1fae648eaf9..bfd4afe5ca4 100644 --- a/packages/client/package.json +++ b/packages/client/package.json @@ -109,13 +109,17 @@ "links", "unstable-internals", "!**/*.test.*", - "!**/__tests__" + "!**/__tests__", + "skills...
[ "packages/client/package.json" ]
[ { "comment": "The package now exposes an `intent` binary, but `bin/` is not part of the `files` allowlist. As-is, `./bin/intent.js` will not be published, breaking the `bin` entry for consumers. Add `bin` to `files` (or otherwise ensure it’s published). Also note that multiple @trpc/* packages now export the sa...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
This package now exposes a `bin` named `intent`. Multiple @trpc/* packages in this PR expose the same bin name, which can conflict in `node_modules/.bin` when users install more than one `@trpc` package. Consider using a package-unique bin name or exposing the shim from only a single package. ```suggestion "trpc-op...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/openapi/package.json b/packages/openapi/package.json index 1ffe92e6860..f8406a34b96 100644 --- a/packages/openapi/package.json +++ b/packages/openapi/package.json @@ -7,7 +7,8 @@ "author": "KATT", "license": "MIT", "bin": { - "trpc-openapi": "./dist/cli.js" + "trpc-openapi": "./dist...
[ "packages/openapi/package.json" ]
[ { "comment": "This package now exposes a `bin` named `intent`. Multiple @trpc/* packages in this PR expose the same bin name, which can conflict in `node_modules/.bin` when users install more than one `@trpc` package. Consider using a package-unique bin name or exposing the shim from only a single package.\n```...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
`_artifacts/skill_tree.yaml` declares `@trpc/server` version `11.13.4`, but this PR’s skills frontmatter and package versions are `11.14.0`. This mismatch makes the generated artifact inconsistent with the release it’s shipped alongside; update the artifact’s library version (or regenerate) to match the actual package ...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/_artifacts/skill_tree.yaml b/_artifacts/skill_tree.yaml new file mode 100644 index 00000000000..a53e9690b9c --- /dev/null +++ b/_artifacts/skill_tree.yaml @@ -0,0 +1,485 @@ +# _artifacts/skill_tree.yaml +library: + name: '@trpc/server' + version: '11.14.0' + repository: 'https://github.com/trpc/trpc' + ...
[ "_artifacts/skill_tree.yaml" ]
[ { "comment": "`_artifacts/skill_tree.yaml` declares `@trpc/server` version `11.13.4`, but this PR’s skills frontmatter and package versions are `11.14.0`. This mismatch makes the generated artifact inconsistent with the release it’s shipped alongside; update the artifact’s library version (or regenerate) to mat...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
`paths` includes `packages/www/docs/**`, but this repo’s docs live under `www/docs/**` (no `packages/www`). As written, doc changes won’t trigger this workflow; update the path filter to match the actual docs directory.
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/.github/workflows/notify-intent.yml b/.github/workflows/notify-intent.yml new file mode 100644 index 00000000000..eaa638a7561 --- /dev/null +++ b/.github/workflows/notify-intent.yml @@ -0,0 +1,55 @@ +# notify-intent.yml — Drop this into your library repo's .github/workflows/ +# +# Fires a repository_dispat...
[ ".github/workflows/notify-intent.yml" ]
[ { "comment": "`paths` includes `packages/www/docs/**`, but this repo’s docs live under `www/docs/**` (no `packages/www`). As written, doc changes won’t trigger this workflow; update the path filter to match the actual docs directory.", "path": ".github/workflows/notify-intent.yml", "hunk": "@@ -0,0 +1,5...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
This package publishes a `bin` entry that requires `@tanstack/intent` to be installed, but the package doesn’t declare it as a dependency/peerDependency. That means `intent` may be present in consumers’ PATH but fail at runtime. Consider declaring `@tanstack/intent` as an (optional) peer dependency or removing the wrap...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/server/package.json b/packages/server/package.json index 373f0003788..58f27aa6ce4 100644 --- a/packages/server/package.json +++ b/packages/server/package.json @@ -187,7 +187,10 @@ "shared", "unstable-core-do-not-import", "!**/*.test.*", - "!**/__tests__" + "!**/__tests__", + ...
[ "packages/server/package.json" ]
[ { "comment": "This package publishes a `bin` entry that requires `@tanstack/intent` to be installed, but the package doesn’t declare it as a dependency/peerDependency. That means `intent` may be present in consumers’ PATH but fail at runtime. Consider declaring `@tanstack/intent` as an (optional) peer dependenc...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
This package publishes a `bin` entry that requires `@tanstack/intent` to be installed, but the package doesn’t declare it as a dependency/peerDependency. That can leave consumers with an `intent` executable that fails at runtime. Consider declaring `@tanstack/intent` as an (optional) peer dependency or removing the wra...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/client/package.json b/packages/client/package.json index 1fae648eaf9..bfd4afe5ca4 100644 --- a/packages/client/package.json +++ b/packages/client/package.json @@ -109,13 +109,17 @@ "links", "unstable-internals", "!**/*.test.*", - "!**/__tests__" + "!**/__tests__", + "skills...
[ "packages/client/package.json" ]
[ { "comment": "This package publishes a `bin` entry that requires `@tanstack/intent` to be installed, but the package doesn’t declare it as a dependency/peerDependency. That can leave consumers with an `intent` executable that fails at runtime. Consider declaring `@tanstack/intent` as an (optional) peer dependen...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
Exposing a generic `intent` binary from this package is likely to cause `node_modules/.bin/intent` collisions for users who install multiple `@trpc/*` packages (and it can also shadow the real `intent` binary from `@tanstack/intent`). Consider using a namespaced binary name or avoiding re-exporting the binary from each...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/next/package.json b/packages/next/package.json index bdf36f5c1d6..6942604e82f 100644 --- a/packages/next/package.json +++ b/packages/next/package.json @@ -100,7 +100,10 @@ "app-dir", "ssrPrepass", "!**/*.test.*", - "!**/__tests__" + "!**/__tests__", + "skills", + "!skill...
[ "packages/next/package.json" ]
[ { "comment": "Exposing a generic `intent` binary from this package is likely to cause `node_modules/.bin/intent` collisions for users who install multiple `@trpc/*` packages (and it can also shadow the real `intent` binary from `@tanstack/intent`). Consider using a namespaced binary name or avoiding re-exportin...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
This package publishes a `bin` entry that requires `@tanstack/intent` at runtime, but it isn’t declared as a dependency/peerDependency. That can leave consumers with an `intent` executable that fails unless they separately install `@tanstack/intent`. Consider adding an (optional) peer dependency on `@tanstack/intent` o...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/openapi/package.json b/packages/openapi/package.json index 1ffe92e6860..f8406a34b96 100644 --- a/packages/openapi/package.json +++ b/packages/openapi/package.json @@ -7,7 +7,8 @@ "author": "KATT", "license": "MIT", "bin": { - "trpc-openapi": "./dist/cli.js" + "trpc-openapi": "./dist...
[ "packages/openapi/package.json" ]
[ { "comment": "This package publishes a `bin` entry that requires `@tanstack/intent` at runtime, but it isn’t declared as a dependency/peerDependency. That can leave consumers with an `intent` executable that fails unless they separately install `@tanstack/intent`. Consider adding an (optional) peer dependency o...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
The header comment says `# skills/_artifacts/skill_tree.yaml`, but this file is located at `_artifacts/skill_tree.yaml`. If this path is meant to be authoritative for consumers, it should reflect the actual location to avoid confusion. ```suggestion # _artifacts/skill_tree.yaml ```
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/_artifacts/skill_tree.yaml b/_artifacts/skill_tree.yaml new file mode 100644 index 00000000000..a53e9690b9c --- /dev/null +++ b/_artifacts/skill_tree.yaml @@ -0,0 +1,485 @@ +# _artifacts/skill_tree.yaml +library: + name: '@trpc/server' + version: '11.14.0' + repository: 'https://github.com/trpc/trpc' + ...
[ "_artifacts/skill_tree.yaml" ]
[ { "comment": "The header comment says `# skills/_artifacts/skill_tree.yaml`, but this file is located at `_artifacts/skill_tree.yaml`. If this path is meant to be authoritative for consumers, it should reflect the actual location to avoid confusion.\n```suggestion\n# _artifacts/skill_tree.yaml\n```", "path"...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
Exposing a generic `intent` binary from this package is likely to cause `node_modules/.bin/intent` collisions for users who install multiple `@trpc/*` packages (and it can also shadow the real `intent` binary from `@tanstack/intent`). Consider using a namespaced binary name (e.g. `trpc-intent`) or avoiding re-exporting...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/server/package.json b/packages/server/package.json index 373f0003788..58f27aa6ce4 100644 --- a/packages/server/package.json +++ b/packages/server/package.json @@ -187,7 +187,10 @@ "shared", "unstable-core-do-not-import", "!**/*.test.*", - "!**/__tests__" + "!**/__tests__", + ...
[ "packages/server/package.json" ]
[ { "comment": "Exposing a generic `intent` binary from this package is likely to cause `node_modules/.bin/intent` collisions for users who install multiple `@trpc/*` packages (and it can also shadow the real `intent` binary from `@tanstack/intent`). Consider using a namespaced binary name (e.g. `trpc-intent`) or...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
Exposing a generic `intent` binary from this package is likely to cause `node_modules/.bin/intent` collisions for users who install multiple `@trpc/*` packages (and it can also shadow the real `intent` binary from `@tanstack/intent`). Consider using a namespaced binary name or avoiding re-exporting the binary from each...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/client/package.json b/packages/client/package.json index 1fae648eaf9..bfd4afe5ca4 100644 --- a/packages/client/package.json +++ b/packages/client/package.json @@ -109,13 +109,17 @@ "links", "unstable-internals", "!**/*.test.*", - "!**/__tests__" + "!**/__tests__", + "skills...
[ "packages/client/package.json" ]
[ { "comment": "Exposing a generic `intent` binary from this package is likely to cause `node_modules/.bin/intent` collisions for users who install multiple `@trpc/*` packages (and it can also shadow the real `intent` binary from `@tanstack/intent`). Consider using a namespaced binary name or avoiding re-exportin...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
This package publishes a `bin` entry that requires `@tanstack/intent` to be installed, but the package doesn’t declare it as a dependency/peerDependency. That can leave consumers with an `intent` executable that fails at runtime. Consider declaring `@tanstack/intent` as an (optional) peer dependency or removing the wra...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/next/package.json b/packages/next/package.json index bdf36f5c1d6..6942604e82f 100644 --- a/packages/next/package.json +++ b/packages/next/package.json @@ -100,7 +100,10 @@ "app-dir", "ssrPrepass", "!**/*.test.*", - "!**/__tests__" + "!**/__tests__", + "skills", + "!skill...
[ "packages/next/package.json" ]
[ { "comment": "This package publishes a `bin` entry that requires `@tanstack/intent` to be installed, but the package doesn’t declare it as a dependency/peerDependency. That can leave consumers with an `intent` executable that fails at runtime. Consider declaring `@tanstack/intent` as an (optional) peer dependen...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
Adding an `intent` binary here is likely to create `node_modules/.bin/intent` collisions for consumers (especially if they install multiple `@trpc/*` packages or also install `@tanstack/intent`). Consider using a namespaced binary name or not re-exporting the `intent` binary from each package. ```suggestion "trpc-o...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/openapi/package.json b/packages/openapi/package.json index 1ffe92e6860..f8406a34b96 100644 --- a/packages/openapi/package.json +++ b/packages/openapi/package.json @@ -7,7 +7,8 @@ "author": "KATT", "license": "MIT", "bin": { - "trpc-openapi": "./dist/cli.js" + "trpc-openapi": "./dist...
[ "packages/openapi/package.json" ]
[ { "comment": "Adding an `intent` binary here is likely to create `node_modules/.bin/intent` collisions for consumers (especially if they install multiple `@trpc/*` packages or also install `@tanstack/intent`). Consider using a namespaced binary name or not re-exporting the `intent` binary from each package.\n``...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
Exposing a generic `intent` binary from this package is likely to cause `node_modules/.bin/intent` collisions for users who install multiple `@trpc/*` packages (and it can also shadow the real `intent` binary from `@tanstack/intent`). Consider using a namespaced binary name or avoiding re-exporting the binary from each...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/tanstack-react-query/package.json b/packages/tanstack-react-query/package.json index 090979c49dd..d59e6ce9a9d 100644 --- a/packages/tanstack-react-query/package.json +++ b/packages/tanstack-react-query/package.json @@ -39,7 +39,10 @@ "README.md", "package.json", "!**/*.test.*", - ...
[ "packages/tanstack-react-query/package.json" ]
[ { "comment": "Exposing a generic `intent` binary from this package is likely to cause `node_modules/.bin/intent` collisions for users who install multiple `@trpc/*` packages (and it can also shadow the real `intent` binary from `@tanstack/intent`). Consider using a namespaced binary name or avoiding re-exportin...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
This package publishes a `bin` entry that requires `@tanstack/intent` to be installed, but it isn’t declared as a dependency/peerDependency. That can leave consumers with an `intent` executable that fails at runtime. Consider declaring `@tanstack/intent` as an (optional) peer dependency or removing the wrapper binary.
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/tanstack-react-query/package.json b/packages/tanstack-react-query/package.json index 090979c49dd..d59e6ce9a9d 100644 --- a/packages/tanstack-react-query/package.json +++ b/packages/tanstack-react-query/package.json @@ -39,7 +39,10 @@ "README.md", "package.json", "!**/*.test.*", - ...
[ "packages/tanstack-react-query/package.json" ]
[ { "comment": "This package publishes a `bin` entry that requires `@tanstack/intent` to be installed, but it isn’t declared as a dependency/peerDependency. That can leave consumers with an `intent` executable that fails at runtime. Consider declaring `@tanstack/intent` as an (optional) peer dependency or removin...
true
trpc/trpc
7,274
issue_to_patch
fix(deps): update dependency @tanstack/intent to ^0.0.23
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [@tanstack/intent](https://redirect.github.com/tanstack/intent) | [`^0.0.20` → `^0.0.23`](https://renovatebot.com/diffs...
e896259af491fc4b1c9e8fc320817e2222bae869
053391497c8e6a3476c0993e627d8ee6d0d2f96e
diff --git a/package.json b/package.json index 47af70eadac..9bc25c538d2 100644 --- a/package.json +++ b/package.json @@ -42,7 +42,7 @@ "@eslint/compat": "^2.0.0", "@ianvs/prettier-plugin-sort-imports": "^4.4.0", "@manypkg/cli": "^0.22.0", - "@tanstack/intent": "^0.0.20", + "@tanstack/intent": "^0.0...
[ "package.json", "packages/client/package.json", "packages/next/package.json", "packages/openapi/package.json", "packages/server/package.json", "packages/tanstack-react-query/package.json", "pnpm-lock.yaml" ]
[]
true
trpc/trpc
7,276
issue_to_patch
chore(deps): update actions/checkout action to v6
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/checkout](https://redirect.github.com/actions/checkout) | action | major | `v4` → `v6` | --- ### Release Notes <details> <summary>actions/checkout (actions/checkout)</summary> ### [`v6`](https://redirect.githu...
88f9f622edeb213a1ec565dcf908ab92b9a983d6
6a4753f546a36cb8013711f1c9fc3a3bec216edf
diff --git a/.github/workflows/check-skills.yml b/.github/workflows/check-skills.yml index 9435aead66c..2573999b116 100644 --- a/.github/workflows/check-skills.yml +++ b/.github/workflows/check-skills.yml @@ -26,7 +26,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/chec...
[ ".github/workflows/check-skills.yml", ".github/workflows/notify-intent.yml", ".github/workflows/validate-skills.yml" ]
[]
true
trpc/trpc
7,267
issue_to_patch
fix(deps): update dependency effect to v3.21.0
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [effect](https://effect.website) ([source](https://redirect.github.com/Effect-TS/effect/tree/HEAD/packages/effect)) | [...
8ad36a06aefba092f00a36f6220d028ae115c4f9
335a4676fda921a2374c06dabc8e0b735322fd8f
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 0d655483345..edc509dda83 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -2210,8 +2210,8 @@ importers: specifier: ^5.0.0 version: 5.6.3 effect: - specifier: 3.20.0 - version: 3.20.0 + specifier: 3.21.0 + version:...
[ "packages/tests/package.json", "pnpm-lock.yaml", "www/package.json" ]
[]
diff --git a/packages/tests/package.json b/packages/tests/package.json index aeb5f5ea849..4640de75bd5 100644 --- a/packages/tests/package.json +++ b/packages/tests/package.json @@ -16,7 +16,7 @@ "arktype": "^2.0.1", "dataloader": "^2.2.2", "devalue": "^5.0.0", - "effect": "3.20.0", + "effect": "3.2...
true
trpc/trpc
7,265
issue_to_patch
fix(deps): update dependency valibot to v1.3.1
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [valibot](https://valibot.dev) ([source](https://redirect.github.com/open-circle/valibot)) | [`1.3.0` → `1.3.1`](https:...
ec32cdd9da013ca2bc493cfc7ac7f51db0c55557
6550adeb113c1755c979fb38b7749145520d9e64
diff --git a/packages/server/package.json b/packages/server/package.json index 16cdd6dd0d6..4c5af06b85b 100644 --- a/packages/server/package.json +++ b/packages/server/package.json @@ -217,7 +217,7 @@ "superstruct": "^2.0.0", "tsdown": "0.12.7", "typescript": "^5.9.2", - "valibot": "1.3.0", + "vali...
[ "packages/server/package.json", "packages/tests/package.json", "pnpm-lock.yaml", "www/package.json" ]
[]
diff --git a/packages/tests/package.json b/packages/tests/package.json index 5f763dd3189..aeb5f5ea849 100644 --- a/packages/tests/package.json +++ b/packages/tests/package.json @@ -32,7 +32,7 @@ "tupleson": "0.23.1", "typescript": "^5.9.2", "undici": "^7.0.0", - "valibot": "1.3.0", + "valibot": "1....
true
trpc/trpc
7,262
issue_to_patch
fix(server): use correct call index in batch stream error handling
Closes # ## 🎯 Changes Fix hardcoded `info.calls[0]` in the streaming batch response handler (`resolveResponse.ts`). When a batch request contains multiple calls and the 2nd+ call errors, the error shape incorrectly uses the first call's `path`, `input`, and `type`. The non-streaming batch handler in the same file c...
346868cca36c26c4d12ad5ba30dbcf6ed9dc96c5
85a1bbd670f9b531da6266878d5f9c7a03c4a30c
diff --git a/packages/client/src/internals/types.ts b/packages/client/src/internals/types.ts index 294abd7f217..5171a4ba62a 100644 --- a/packages/client/src/internals/types.ts +++ b/packages/client/src/internals/types.ts @@ -72,6 +72,7 @@ export type NodeJSReadableStreamEsque = { * @see Response from lib.dom.d.ts *...
[ "packages/client/src/internals/types.ts", "packages/client/src/links/httpBatchStreamLink.ts", "packages/server/src/unstable-core-do-not-import/http/resolveResponse.ts", "packages/tests/server/batching.test.ts" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Rename file to camelCase to satisfy lint rule.**\n\nStatic analysis reports `unicorn/filename-case`; please rename this file to `batchStreamErrorCallIndex.test.ts`.\n\n<details>\n<summary>🧰 Tools</summary>\n\n<details>\n<summary>🪛 ESLint</summary>\n\n[error...
diff --git a/packages/tests/server/batching.test.ts b/packages/tests/server/batching.test.ts index 035a537efd7..3262c1a0bd0 100644 --- a/packages/tests/server/batching.test.ts +++ b/packages/tests/server/batching.test.ts @@ -1,90 +1,197 @@ import { testServerAndClientResource } from '@trpc/client/__tests__/testClientR...
true
trpc/trpc
7,262
comment_to_fix
fix(server): use correct call index in batch stream error handling
In the non-2xx fallback path, the response JSON is parsed but not run through the configured transformer output deserializer. This means servers using a non-identity transformer could return an error shape with serialized fields (e.g. custom errorFormatter data) that remain serialized when propagated via TRPCClientErro...
346868cca36c26c4d12ad5ba30dbcf6ed9dc96c5
85a1bbd670f9b531da6266878d5f9c7a03c4a30c
diff --git a/packages/client/src/links/httpBatchStreamLink.ts b/packages/client/src/links/httpBatchStreamLink.ts index 719a0b0430c..adcbae1f0b4 100644 --- a/packages/client/src/links/httpBatchStreamLink.ts +++ b/packages/client/src/links/httpBatchStreamLink.ts @@ -99,6 +99,29 @@ export function httpBatchStreamLink<TRou...
[ "packages/client/src/links/httpBatchStreamLink.ts" ]
[ { "comment": "In the non-2xx fallback path, the response JSON is parsed but not run through the configured transformer output deserializer. This means servers using a non-identity transformer could return an error shape with serialized fields (e.g. custom errorFormatter data) that remain serialized when propaga...
true
trpc/trpc
7,260
issue_to_patch
chore(deps): update pnpm/action-setup action to v5
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pnpm/action-setup](https://redirect.github.com/pnpm/action-setup) | action | major | `v4` → `v5` | --- ### Release Notes <details> <summary>pnpm/action-setup (pnpm/action-setup)</summary> ### [`v5`](https://redirect.g...
67cdcee810cb95a78456d6c2dba8144a5c239fd3
49e6ecbdc7cfe1c25812a184b7a8732b463ed931
diff --git a/.github/setup/action.yml b/.github/setup/action.yml index dc04e89f02f..1d94977ceec 100644 --- a/.github/setup/action.yml +++ b/.github/setup/action.yml @@ -3,7 +3,7 @@ description: Composite action that sets up pnpm runs: using: 'composite' steps: - - uses: pnpm/action-setup@v4 + - uses: pnpm/...
[ ".github/setup/action.yml", ".github/workflows/subtree.yml" ]
[]
true
trpc/trpc
7,259
issue_to_patch
fix(deps): update dependency valibot to v1.3.0
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [valibot](https://valibot.dev) ([source](https://redirect.github.com/open-circle/valibot)) | [`1.2.0` → `1.3.0`](https:...
a9fe48f15fb826aa4d5079c8901994063d0e9bfa
4418ac533b0441e6067f33316487cae9981ade4c
diff --git a/packages/server/package.json b/packages/server/package.json index 51ac7ff73ed..16cdd6dd0d6 100644 --- a/packages/server/package.json +++ b/packages/server/package.json @@ -217,7 +217,7 @@ "superstruct": "^2.0.0", "tsdown": "0.12.7", "typescript": "^5.9.2", - "valibot": "1.2.0", + "vali...
[ "packages/server/package.json", "packages/tests/package.json", "pnpm-lock.yaml", "www/package.json" ]
[]
diff --git a/packages/tests/package.json b/packages/tests/package.json index 67beb80542f..5f763dd3189 100644 --- a/packages/tests/package.json +++ b/packages/tests/package.json @@ -32,7 +32,7 @@ "tupleson": "0.23.1", "typescript": "^5.9.2", "undici": "^7.0.0", - "valibot": "1.2.0", + "valibot": "1....
true
trpc/trpc
7,257
issue_to_patch
fix(deps): update dependency effect to v3.20.0
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [effect](https://effect.website) ([source](https://redirect.github.com/Effect-TS/effect/tree/HEAD/packages/effect)) | [...
a698cd5ee8adb70f6b0decddb85ebfe6dfee18d2
63122b2bbb84c57c4b2cac1a882452e67029d10a
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 84b85ca06bb..464a838a254 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -2210,8 +2210,8 @@ importers: specifier: ^5.0.0 version: 5.6.3 effect: - specifier: 3.19.19 - version: 3.19.19 + specifier: 3.20.0 + versio...
[ "packages/tests/package.json", "pnpm-lock.yaml", "www/package.json" ]
[]
diff --git a/packages/tests/package.json b/packages/tests/package.json index 779b346cba5..67beb80542f 100644 --- a/packages/tests/package.json +++ b/packages/tests/package.json @@ -16,7 +16,7 @@ "arktype": "^2.0.1", "dataloader": "^2.2.2", "devalue": "^5.0.0", - "effect": "3.19.19", + "effect": "3....
true
trpc/trpc
7,256
issue_to_patch
fix(deps): update dependency srvx to v0.11.12
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [srvx](https://srvx.h3.dev) ([source](https://redirect.github.com/h3js/srvx)) | [`0.11.11` → `0.11.12`](https://renovat...
4f6fdfefe67f1b720b3ef9bd781fd07df7565981
cba51612b7a3103fda017143dfa3ddefafe98202
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 8cc7df700aa..84b85ca06bb 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -2237,8 +2237,8 @@ importers: specifier: ^0.13.0 version: 0.13.0 srvx: - specifier: 0.11.11 - version: 0.11.11 + specifier: 0.11.12 + versi...
[ "packages/tests/package.json", "pnpm-lock.yaml" ]
[]
diff --git a/packages/tests/package.json b/packages/tests/package.json index 634f8f1c552..779b346cba5 100644 --- a/packages/tests/package.json +++ b/packages/tests/package.json @@ -25,7 +25,7 @@ "node-fetch": "^3.3.0", "runtypes": "^7.0.0", "scale-codec": "^0.13.0", - "srvx": "0.11.11", + "srvx": "...
true
trpc/trpc
7,254
issue_to_patch
Add todo
Closes # ## 🎯 Changes What changes are made in this PR? Is it a feature or a bug fix? <!-- Note: once you create a Pull request, we will automatically fix auto-fixable lint issues in your branch --> ## ✅ Checklist - [ ] I have followed the steps listed in the [Contributing guide](https://github.com/tr...
929561d92dc802ef6ae4469faa54bf7a36162ddc
30285bff2124ae0902aa1f3a8e82939011e4177b
diff --git a/packages/openapi/README.md b/packages/openapi/README.md index 0edba7008c6..05f79707ab4 100644 --- a/packages/openapi/README.md +++ b/packages/openapi/README.md @@ -45,6 +45,7 @@ Full documentation is available at [trpc.io/docs/openapi](https://trpc.io/docs/o - [ ] Improved handling of recursive/self-refer...
[ "packages/openapi/README.md" ]
[ { "comment": "PR description still contains placeholder text (e.g. \"Closes #\" without an issue/PR number and the template questions). Please update the PR description to reference the actual issue (or remove the closing statement) and briefly describe the change.", "path": "packages/openapi/README.md", ...
true
trpc/trpc
7,255
issue_to_patch
fix(deps): update dependency srvx to v0.11.11
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [srvx](https://srvx.h3.dev) ([source](https://redirect.github.com/h3js/srvx)) | [`0.11.9` → `0.11.11`](https://renovate...
3e3f27c350b4064ccc6018423df682185b6480c6
e892213b5eefe3b16ca4083e5151b9fb405d570f
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 827d91ce835..8cc7df700aa 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -2237,8 +2237,8 @@ importers: specifier: ^0.13.0 version: 0.13.0 srvx: - specifier: 0.11.9 - version: 0.11.9 + specifier: 0.11.11 + version...
[ "packages/tests/package.json", "pnpm-lock.yaml" ]
[]
diff --git a/packages/tests/package.json b/packages/tests/package.json index c2d87d6781c..634f8f1c552 100644 --- a/packages/tests/package.json +++ b/packages/tests/package.json @@ -25,7 +25,7 @@ "node-fetch": "^3.3.0", "runtypes": "^7.0.0", "scale-codec": "^0.13.0", - "srvx": "0.11.9", + "srvx": "0...
true
trpc/trpc
7,251
issue_to_patch
chore: Consolidate release workflows
Closes # ## 🎯 Changes What changes are made in this PR? Is it a feature or a bug fix? <!-- Note: once you create a Pull request, we will automatically fix auto-fixable lint issues in your branch --> ## ✅ Checklist - [ ] I have followed the steps listed in the [Contributing guide](https://github.com/tr...
de6dc93268ffb551e86ad46b560722b8de2e5413
4c46603b3bcbcef82ae828f43ef866cb0ea636d2
diff --git a/.github/workflows/release-canary.yml b/.github/workflows/release-canary.yml deleted file mode 100644 index a885674a9b9..00000000000 --- a/.github/workflows/release-canary.yml +++ /dev/null @@ -1,44 +0,0 @@ -name: Release "@canary"-tagged packages - -on: - workflow_dispatch: - push: - branches: - ...
[ ".github/workflows/release-canary.yml", ".github/workflows/release-manual.yml", ".github/workflows/release-tmp.yml" ]
[ { "comment": "`version_bump` is marked `required: true`, but the `publish-canary` path ignores it entirely (it always runs `lerna publish --canary`). This makes `workflow_dispatch` for `dist_tag: canary` unnecessarily require/ask for an unused value. Consider making `version_bump` non-required with a default, o...
true
trpc/trpc
7,251
comment_to_fix
chore: Consolidate release workflows
`version_bump` is marked `required: true`, but the `publish-canary` path ignores it entirely (it always runs `lerna publish --canary`). This makes `workflow_dispatch` for `dist_tag: canary` unnecessarily require/ask for an unused value. Consider making `version_bump` non-required with a default, or splitting the dispat...
de6dc93268ffb551e86ad46b560722b8de2e5413
4c46603b3bcbcef82ae828f43ef866cb0ea636d2
diff --git a/.github/workflows/release-manual.yml b/.github/workflows/release-manual.yml index 2d8f1484cc1..75b372abc8f 100644 --- a/.github/workflows/release-manual.yml +++ b/.github/workflows/release-manual.yml @@ -1,8 +1,26 @@ -name: Release packages (manual) +name: Release Packages + +env: + TURBO_TOKEN: ${{ secre...
[ ".github/workflows/release-manual.yml" ]
[ { "comment": "`version_bump` is marked `required: true`, but the `publish-canary` path ignores it entirely (it always runs `lerna publish --canary`). This makes `workflow_dispatch` for `dist_tag: canary` unnecessarily require/ask for an unused value. Consider making `version_bump` non-required with a default, o...
true
tsenart/vegeta
655
issue_to_patch
build(deps): bump github.com/google/go-cmp from 0.5.9 to 0.6.0
Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.9 to 0.6.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/google/go-cmp/releases">github.com/google/go-cmp's releases</a>.</em></p> <blockquote> <h2>v0.6.0</h2> <p>New API:</p> <ul> <li>(<a href="htt...
acd3f0a295569fbe7391a448be1c4c42ea843c8a
e0e8365ba681cd4d445b0f5ed06973fdfc4bec9e
diff --git a/go.mod b/go.mod index 86617ac3..97f1dc54 100644 --- a/go.mod +++ b/go.mod @@ -8,7 +8,7 @@ require ( github.com/c2h5oh/datasize v0.0.0-20220606134207-859f65c6625b github.com/dgryski/go-gk v0.0.0-20200319235926-a69029f61654 github.com/dgryski/go-lttb v0.0.0-20230207170358-f8fc36cdbff1 - github.com/goog...
[ "go.mod", "go.sum" ]
[]
true
tsenart/vegeta
650
issue_to_patch
build(deps): bump github.com/prometheus/client_golang from 1.16.0 to 1.17.0
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.16.0 to 1.17.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/prometheus/client_golang/releases">github.com/prometheus/client_golang's releases</a>.</em></p> <blockquote> <h2>v1.1...
9267395052f52ae814f00989d3ca2de0c0171e08
5d597832db6df83cfbadb14e4432ddce9c4799d1
diff --git a/go.mod b/go.mod index add6ed70..86617ac3 100644 --- a/go.mod +++ b/go.mod @@ -12,7 +12,7 @@ require ( github.com/influxdata/tdigest v0.0.1 github.com/mailru/easyjson v0.7.7 github.com/miekg/dns v1.1.56 - github.com/prometheus/client_golang v1.16.0 + github.com/prometheus/client_golang v1.17.0 githu...
[ "go.mod", "go.sum" ]
[]
true
tsenart/vegeta
656
issue_to_patch
build(deps): bump github.com/prometheus/prometheus from 0.47.0 to 0.47.2
Bumps [github.com/prometheus/prometheus](https://github.com/prometheus/prometheus) from 0.47.0 to 0.47.2. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/prometheus/prometheus/commit/3f3172cde1ee37f1c7b3a5f3d9b031190509b3ad"><code>3f3172c</code></a> Merge pull request <a href="https://redirect...
6fbe391628eeeae1adf39522a55078797e6e7f2e
0376a281ca9d975353049666804cdb3609bc9271
diff --git a/go.mod b/go.mod index 36e16862..add6ed70 100644 --- a/go.mod +++ b/go.mod @@ -13,7 +13,7 @@ require ( github.com/mailru/easyjson v0.7.7 github.com/miekg/dns v1.1.56 github.com/prometheus/client_golang v1.16.0 - github.com/prometheus/prometheus v0.47.0 + github.com/prometheus/prometheus v0.47.2 gith...
[ "go.mod", "go.sum" ]
[]
true
tsenart/vegeta
645
issue_to_patch
build(deps): bump github.com/prometheus/prometheus from 0.46.0 to 0.47.0
[//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [github.com/prometheus/prometheus](ht...
dfd484ab521d98f4543f7eaa5409f6278420e0e5
a06c57be49fa024aaa67882edf3fe6dfe935474a
diff --git a/go.mod b/go.mod index 3fa97b58..36e16862 100644 --- a/go.mod +++ b/go.mod @@ -13,7 +13,7 @@ require ( github.com/mailru/easyjson v0.7.7 github.com/miekg/dns v1.1.56 github.com/prometheus/client_golang v1.16.0 - github.com/prometheus/prometheus v0.46.0 + github.com/prometheus/prometheus v0.47.0 gith...
[ "go.mod", "go.sum" ]
[]
true
tsenart/vegeta
648
issue_to_patch
build(deps): bump github.com/miekg/dns from 1.1.55 to 1.1.56
Bumps [github.com/miekg/dns](https://github.com/miekg/dns) from 1.1.55 to 1.1.56. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/miekg/dns/commit/dfe986726a5791b77c58009e3a88314829132316"><code>dfe9867</code></a> Release 1.1.56</li> <li><a href="https://github.com/miekg/dns/commit/a9ed73ac221...
712ff2e55f42d6c70ca311eafde55731cf3a08dc
49ecc78cb5806c25a92954b5134132b52d5a459e
diff --git a/go.mod b/go.mod index d609a05c..3fa97b58 100644 --- a/go.mod +++ b/go.mod @@ -11,13 +11,13 @@ require ( github.com/google/go-cmp v0.5.9 github.com/influxdata/tdigest v0.0.1 github.com/mailru/easyjson v0.7.7 - github.com/miekg/dns v1.1.55 + github.com/miekg/dns v1.1.56 github.com/prometheus/client_g...
[ "go.mod", "go.sum" ]
[]
true
tsenart/vegeta
642
issue_to_patch
build(deps): bump github.com/prometheus/prometheus from 0.45.0 to 0.46.0
Bumps [github.com/prometheus/prometheus](https://github.com/prometheus/prometheus) from 0.45.0 to 0.46.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/prometheus/prometheus/commit/cbb69e51423565ec40f46e74f4ff2dbb3b7fb4f0"><code>cbb69e5</code></a> Merge pull request <a href="https://redirect...
b4b20af16e4f0cca73c8b49807de3a7a7906642a
af608edb0ba4ab799b4fb10deeb7d89e1ca3228e
diff --git a/go.mod b/go.mod index 81c150bb..d609a05c 100644 --- a/go.mod +++ b/go.mod @@ -13,7 +13,7 @@ require ( github.com/mailru/easyjson v0.7.7 github.com/miekg/dns v1.1.55 github.com/prometheus/client_golang v1.16.0 - github.com/prometheus/prometheus v0.45.0 + github.com/prometheus/prometheus v0.46.0 gith...
[ "go.mod", "go.sum" ]
[]
true
tsenart/vegeta
641
issue_to_patch
build(deps): bump pgregory.net/rapid from 1.0.0 to 1.1.0
Bumps [pgregory.net/rapid](https://github.com/flyingmutant/rapid) from 1.0.0 to 1.1.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/flyingmutant/rapid/releases">pgregory.net/rapid's releases</a>.</em></p> <blockquote> <h2>v1.1.0</h2> <p><strong>Full Changelog</strong>: <a h...
018e8a8d709ca3a13d41904eff11072bbb3bc821
89bc3339f895f75186248b1402efba5cd2a6be06
diff --git a/go.mod b/go.mod index b6cebdb0..81c150bb 100644 --- a/go.mod +++ b/go.mod @@ -18,7 +18,7 @@ require ( github.com/streadway/quantile v0.0.0-20220407130108-4246515d968d github.com/tsenart/go-tsz v0.0.0-20180814235614-0bd30b3df1c3 golang.org/x/net v0.14.0 - pgregory.net/rapid v1.0.0 + pgregory.net/rapid...
[ "go.mod", "go.sum" ]
[]
true
tsenart/vegeta
640
issue_to_patch
build(deps): bump golang.org/x/net from 0.12.0 to 0.14.0
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.12.0 to 0.14.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golang/net/commit/c8c0290b421c479315f66c7b68b617ef6e73c668"><code>c8c0290</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="https://github.com/gola...
e49c367a014978b5b7228d0e2d6bed6c0555e1e3
512a906c8e02dacd75c6e207838fa879526c8b20
diff --git a/go.mod b/go.mod index eee42379..b6cebdb0 100644 --- a/go.mod +++ b/go.mod @@ -13,10 +13,11 @@ require ( github.com/mailru/easyjson v0.7.7 github.com/miekg/dns v1.1.55 github.com/prometheus/client_golang v1.16.0 + github.com/prometheus/prometheus v0.45.0 github.com/rs/dnscache v0.0.0-20211102005908-...
[ "go.mod", "go.sum" ]
[]
true
tsenart/vegeta
632
issue_to_patch
DNS caching
This commit introduces DNS caching with the -dns-ttl flag. Supersedes #576
556bf611c53a6c512432362fecd25297efc0c627
964456d07288897e182cac2a0ca383795d236ba7
diff --git a/attack.go b/attack.go index 63c8d55a..47276e95 100644 --- a/attack.go +++ b/attack.go @@ -56,6 +56,7 @@ func attackCmd() command { fs.Var(&opts.laddr, "laddr", "Local IP address") fs.BoolVar(&opts.keepalive, "keepalive", true, "Use persistent connections") fs.StringVar(&opts.unixSocket, "unix-socket"...
[ "attack.go", "flags.go", "go.mod", "go.sum", "lib/attack.go", "lib/attack_test.go" ]
[ { "comment": "If seqmu protects only seq uint64, why not use e.g. [sync/atomic.Uint64](https://pkg.go.dev/sync/atomic#Uint64)?", "path": "lib/attack.go", "hunk": "@@ -263,6 +261,119 @@ func ProxyHeader(h http.Header) func(*Attacker) {\n \t}\n }\n \n+// DNSCaching returns a functional option that enables...
diff --git a/lib/attack_test.go b/lib/attack_test.go index 29f9a498..3495bc6b 100644 --- a/lib/attack_test.go +++ b/lib/attack_test.go @@ -82,7 +82,7 @@ func TestRedirects(t *testing.T) { redirects := 2 atk := NewAttacker(Redirects(redirects)) tr := NewStaticTargeter(Target{Method: "GET", URL: server.URL}) - res ...
true
tsenart/vegeta
630
issue_to_patch
build(deps): bump github.com/miekg/dns from 1.1.25 to 1.1.55
Bumps [github.com/miekg/dns](https://github.com/miekg/dns) from 1.1.25 to 1.1.55. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/miekg/dns/commit/48f38ebef989eedc6b57f1869ae849ccc8f5fe29"><code>48f38eb</code></a> Release 1.1.55</li> <li><a href="https://github.com/miekg/dns/commit/8b8cf1431cb...
9151f61820ebd02ec13141da86496c401990f32a
c749c7c9d10d0a95127dc5e67b23264f4aa1b669
diff --git a/go.mod b/go.mod index 8e7fcb64..d570c454 100644 --- a/go.mod +++ b/go.mod @@ -11,7 +11,7 @@ require ( github.com/google/go-cmp v0.5.9 github.com/influxdata/tdigest v0.0.1 github.com/mailru/easyjson v0.7.7 - github.com/miekg/dns v1.1.25 + github.com/miekg/dns v1.1.55 github.com/streadway/quantile v0...
[ "go.mod", "go.sum" ]
[]
true
tsenart/vegeta
629
issue_to_patch
ci: build more targets
1067657842bc695ecc5daeb34339a7f9b82f5aba
823bcc29387fd03050afe5e5a8a5c93c3748de45
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 19280d12..3fcba05d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -38,8 +38,21 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - goos: ['windows', 'linux', 'darwin'] - goarch: ['amd64', 'arm6...
[ ".github/workflows/ci.yml" ]
[]
true
tsenart/vegeta
518
issue_to_patch
Add max-connections option to README
#### Background The `max-connections` option was added in #475 . I added a description of that option to README.md. #### Checklist - [x] Git commit messages conform to [community standards](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html). - [x] Each Git commit represents meaningful mi...
da4c11f87452778591079baaa83672b6c4164361
7e2a090be53ef75a0390186909c351b4d0957bcc
diff --git a/README.md b/README.md index 9ad51a12..ff0b1715 100644 --- a/README.md +++ b/README.md @@ -88,6 +88,8 @@ attack command: Read targets lazily -max-body value Maximum number of bytes to capture from response bodies. [-1 = no limit] (default -1) + -max-connections int + Max connections per...
[ "README.md" ]
[]
true
tsenart/vegeta
616
issue_to_patch
Update default -timeout value in README
#### Background The default value of the `-timeout` flag in the README differs from the actual value of `30s`. #### Checklist - [x] Git commit messages conform to [community standards](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html). - [x] Each Git commit represents meaningful milestones...
27f553fe091151234f899866bc8ee0072be0c9b5
d4c303bcf5f134f8620b82ef30e0e55e1664abf5
diff --git a/README.md b/README.md index ede23b7c..6a7ae033 100644 --- a/README.md +++ b/README.md @@ -358,8 +358,7 @@ See the [`-format`](#-format) section to learn about the different target format #### `-timeout` -Specifies the timeout for each request. The default is 0 which disables -timeouts. +Specifies the ...
[ "README.md" ]
[ { "comment": "Note: I didn't repeat the default value on this line because it's clearly documented in [Usage manual](https://github.com/tsenart/vegeta#usage-manual) already.", "path": "README.md", "hunk": "@@ -358,8 +358,7 @@ See the [`-format`](#-format) section to learn about the different target form...
true
tsenart/vegeta
613
issue_to_patch
build(deps): bump github.com/miekg/dns from 1.1.17 to 1.1.25
Bumps [github.com/miekg/dns](https://github.com/miekg/dns) from 1.1.17 to 1.1.25. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/miekg/dns/commit/aae7df65e6178e7937664e9c3036f62fc2098d7c"><code>aae7df6</code></a> Release 1.1.25</li> <li><a href="https://github.com/miekg/dns/commit/8ebf2e419df...
c03ddd996567ed2e9cf1996ffdc223b6987f1b16
a8885fefdad04c5d67df200e15f36759915f9b6a
diff --git a/go.mod b/go.mod index eeb4380b..8e7fcb64 100644 --- a/go.mod +++ b/go.mod @@ -11,7 +11,7 @@ require ( github.com/google/go-cmp v0.5.9 github.com/influxdata/tdigest v0.0.1 github.com/mailru/easyjson v0.7.7 - github.com/miekg/dns v1.1.17 + github.com/miekg/dns v1.1.25 github.com/streadway/quantile v0...
[ "go.mod", "go.sum" ]
[]
true
tsenart/vegeta
627
issue_to_patch
README: Fix install from source instructions
Supersedes #625
3b6d36f56090a6a647db533a8c9ebc25c5bc678c
dbf01b46edd052bdc74f155150b0fb5645551b84
diff --git a/README.md b/README.md index ede23b7c..88edfe8d 100644 --- a/README.md +++ b/README.md @@ -22,11 +22,11 @@ $ brew update && brew install vegeta ### Source -You need `go` installed and `GOBIN` in your `PATH`. Once that is done, run the -command: - ```shell -$ go install github.com/tsenart/vegeta@latest...
[ "README.md" ]
[]
true
tsenart/vegeta
626
issue_to_patch
all: Fix build, upgrade deps and automate release
27f553fe091151234f899866bc8ee0072be0c9b5
567aa323713130d0e600dbcf99d050a9d882f9a3
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 987fb840..19280d12 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,20 +1,134 @@ -on: [push, pull_request] name: CI +on: + push: + tags: + - 'v*.*.*' + branches: + - master + pull_request: + types: [op...
[ ".github/workflows/ci.yml", "Makefile", "encode.go", "go.mod", "go.sum", "lib/histogram_test.go", "lib/lttb/lttb_test.go", "lib/metrics_test.go", "lib/plot/assets_vfsdata.go", "lib/plot/testdata/TestPlot.golden.html", "lib/results_easyjson.go", "lib/results_test.go", "lib/target.schema.json"...
[]
diff --git a/lib/histogram_test.go b/lib/histogram_test.go index 8bdd366f..677544f5 100644 --- a/lib/histogram_test.go +++ b/lib/histogram_test.go @@ -45,8 +45,8 @@ func TestBuckets_UnmarshalText(t *testing.T) { "": "bad buckets: ", " ": "bad buckets: ", "{0, 2}": "bad buckets: {0, 2}", - "[]": ...
true
tsenart/vegeta
612
issue_to_patch
go 1.18 compatibility: import latest `github.com/streadway/quantile` commit <!-- ⚠️ If you do not respect this template your issue will be closed. --> <!-- ⚠️ Make sure to browse the opened and closed issues before submit your issue. --> #### Proposal I would like to ask to update this repository by importing t...
fix issue#595
#### Background fix [#595](https://github.com/tsenart/vegeta/issues/595) relate PR: https://github.com/streadway/quantile/pull/8 <!-- Required background information to understand the PR. Link here any related issues. --> #### Checklist - [x] Git commit messages conform to [community standards](http://t...
ead49901f855741f69a31fc6c06fb5c96b54ff7f
f7b562bdc8ca1f8071a82cd3e38b6140bf56a203
diff --git a/go.mod b/go.mod index d1edc42f..d2ca6ac2 100644 --- a/go.mod +++ b/go.mod @@ -21,7 +21,7 @@ require ( github.com/influxdata/tdigest v0.0.0-20180711151920-a7d76c6f093a github.com/mailru/easyjson v0.7.0 github.com/miekg/dns v1.1.17 - github.com/streadway/quantile v0.0.0-20150917103942-b0c588724d25 + gi...
[ "go.mod", "go.sum" ]
[]
true
tsenart/vegeta
609
issue_to_patch
README: change go get to go install
#### Background <!-- Required background information to understand the PR. Link here any related issues. --> #### Checklist - [x] Git commit messages conform to [community standards](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html). - [x] Each Git commit represents meaningful milestones o...
d73edf2bc2663d83848da2a97a8401a7ed1440bc
857e3a81738fb64ca3f0235bd343c89376592561
diff --git a/README.md b/README.md index 1cb05667..ede23b7c 100644 --- a/README.md +++ b/README.md @@ -26,7 +26,7 @@ You need `go` installed and `GOBIN` in your `PATH`. Once that is done, run the command: ```shell -$ go get -u github.com/tsenart/vegeta +$ go install github.com/tsenart/vegeta@latest ``` ## Versi...
[ "README.md" ]
[]
true
tsenart/vegeta
420
issue_to_patch
metrics: Add Throughput to Metrics
This commit adds a `Throughput` field to the `Metrics` struct which represents the rate of successful requests per second. It is calculated by dividing the number of successful requests by the time span in seconds starting from the beginning of the earliest request in the result set and ending in the time the very ...
28707121bb7840461a563aabcb510a9636e5c5a1
ca44a2b7254ff7518eb196de39da60cf1525be1b
diff --git a/README.md b/README.md index fe9146a4..b401d6c8 100644 --- a/README.md +++ b/README.md @@ -380,7 +380,7 @@ Examples: #### `report -type=text` ```console -Requests [total, rate] 1200, 120.00 +Requests [total, rate, throughput] 1200, 120.00, 65.87 Duration [total, attack, wait]...
[ "README.md", "internal/cmd/echosrv/main.go", "lib/metrics.go", "lib/metrics_test.go", "lib/reporters.go" ]
[ { "comment": "Error return value of `http.ListenAndServe` is not checked (from `errcheck`)", "path": "internal/cmd/echosrv/main.go", "hunk": "@@ -20,8 +24,10 @@ func main() {\n \t\t}\n \t}(time.Now())\n \n-\thttp.ListenAndServe(os.Args[1], http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {\...
diff --git a/lib/metrics_test.go b/lib/metrics_test.go index 4a49b564..d80002cd 100644 --- a/lib/metrics_test.go +++ b/lib/metrics_test.go @@ -57,6 +57,7 @@ func TestMetrics_Add(t *testing.T) { Wait: duration("10ms"), Requests: 10000, Rate: 1.000100010001, + Throughput: 0.6667660098349737, ...
true
tsenart/vegeta
456
issue_to_patch
Setup Github Actions based CI
83a3ce91dbff282c3e2dec57a69434563a101a13
55d894af6ca6777af84ffd771de13348ffb0f94e
diff --git a/.deepsource.toml b/.deepsource.toml index 89cad58c..4ab01bce 100644 --- a/.deepsource.toml +++ b/.deepsource.toml @@ -3,4 +3,13 @@ version = 1 [[analyzers]] name = "python" enabled = true -runtime_version = "3.x.x" \ No newline at end of file + + [analyzers.meta] + runtime_version = "3.x.x" + +[[analy...
[ ".deepsource.toml", ".github/workflows/ci.yml", ".goreleaser.yml", ".travis.yml", "README.md", "fuzzit.sh", "lib/results_test.go" ]
[]
diff --git a/lib/results_test.go b/lib/results_test.go index 27e61342..eac00bb6 100644 --- a/lib/results_test.go +++ b/lib/results_test.go @@ -53,6 +53,8 @@ func TestResultDecoding(t *testing.T) { } func TestResultEncoding(t *testing.T) { + t.Parallel() + newStdJSONEncoder := func(w io.Writer) Encoder { enc :=...
true
tsenart/vegeta
532
issue_to_patch
Wrong data in report -type hist #### Version and Runtime ``` Version: 12.8.3 Commit: Runtime: go1.14.1 linux/amd64 Date: '2020-03-27T03:13:26Z+0000' ``` #### Steps to Reproduce Just take whatever HTTP server you find handy, make it handle one URL. I took `mkdir /tmp/ttt; cd /tmp/ttt; touch foo; python...
Added default first hist bucket if needed
#### Background Fixes #522 When reporting `hist` with buckets that doesn't start with 0, any requests that won't fit the first bucket will fall into the *last* bucket, skewing the results. Please see discussion in issue #522 . This PR will check if the first bucket starts with 0. If not, it will create a defa...
d9b795aec8585a0fb435072f68d842d596c332de
313a60af5a658c7b4be172018b60b2fcc5a65aef
diff --git a/lib/histogram.go b/lib/histogram.go index f8fd8446..acb546f1 100644 --- a/lib/histogram.go +++ b/lib/histogram.go @@ -68,11 +68,15 @@ func (bs *Buckets) UnmarshalText(value []byte) error { if len(value) < 2 || value[0] != '[' || value[len(value)-1] != ']' { return fmt.Errorf("bad buckets: %s", value) ...
[ "lib/histogram.go", "lib/histogram_test.go" ]
[]
diff --git a/lib/histogram_test.go b/lib/histogram_test.go index 68b28154..8bdd366f 100644 --- a/lib/histogram_test.go +++ b/lib/histogram_test.go @@ -57,6 +57,7 @@ func TestBuckets_UnmarshalText(t *testing.T) { "[0,5ms]": {0, 5 * time.Millisecond}, "[0, 5ms]": {0, 5 * time.Millisecond}, ...
true
tsenart/vegeta
300
issue_to_patch
JSON targets format
#### Background The original targets format closely resembles plain HTTP/1.x messages. It was meant to be used by humans writing those targets directly on their terminals. With its lack of support for in-line body definitions, this ill-defined legacy format made Vegeta hard to integrate with other programs generatin...
fc5ca537bf4f01de94b0458729f455289351397e
6de2156a2d9638a937b4cbf2078686910eafa573
diff --git a/Gopkg.lock b/Gopkg.lock index 42009909..fac24eab 100644 --- a/Gopkg.lock +++ b/Gopkg.lock @@ -1,6 +1,12 @@ # This file is autogenerated, do not edit; changes may be undone by the next 'dep ensure'. +[[projects]] + branch = "master" + name = "github.com/alecthomas/jsonschema" + packages = ["."] + r...
[ "Gopkg.lock", "Makefile", "README.md", "attack.go", "internal/cmd/jsonschema/main.go", "lib/target.schema.json", "lib/targets.go", "lib/targets_test.go" ]
[ { "comment": "string `json` has 3 occurrences, make it a constant", "path": "attack.go", "hunk": "@@ -111,10 +113,20 @@ func attack(opts *attackOpts) (err error) {\n \t\tsrc = files[opts.targetsf]\n \t\thdr = opts.headers.Header\n \t)\n-\tif opts.lazy {\n-\t\ttr = vegeta.NewLazyTargeter(src, body, hdr)\...
diff --git a/lib/targets_test.go b/lib/targets_test.go index c645661f..60ca9875 100644 --- a/lib/targets_test.go +++ b/lib/targets_test.go @@ -58,15 +58,101 @@ func TestTargetRequest(t *testing.T) { } } -func TestNewEagerTargeter(t *testing.T) { +func TestJSONTargeter(t *testing.T) { + for _, tc := range []struct ...
true
tsenart/vegeta
507
issue_to_patch
results: Fix Headers encoding
This PR reverts #506 because its JSON string escaping logic taken from github.com/valyala/quicktemplate isn't complete and is incompatible with `encoding/json`. The performance gains do not justify this short coming (at least for Vegeta). We fix the #505 by re-generating the easyjson encoders.
3629602dcd773a4db3d41d1addf10e3706a2a6ba
7434ce4fcbf820f0fecb32207a10667152429375
diff --git a/.gitignore b/.gitignore index 295f2d43..d0c0e875 100644 --- a/.gitignore +++ b/.gitignore @@ -32,4 +32,3 @@ vendor *.lz .DS_Store -.idea diff --git a/go.mod b/go.mod index 86de5473..d1edc42f 100644 --- a/go.mod +++ b/go.mod @@ -23,6 +23,6 @@ require ( github.com/miekg/dns v1.1.17 github.com/streadw...
[ ".gitignore", "go.mod", "go.sum", "lib/results.go", "lib/results_easyjson.go", "lib/results_json.go", "lib/results_test.go" ]
[]
diff --git a/lib/results_test.go b/lib/results_test.go index 8df292be..27e61342 100644 --- a/lib/results_test.go +++ b/lib/results_test.go @@ -9,8 +9,9 @@ import ( "net/http" "reflect" "testing" - "testing/quick" "time" + + "pgregory.net/rapid" ) func TestResultDecoding(t *testing.T) { @@ -80,20 +81,35 @@ f...
true
tsenart/vegeta
506
issue_to_patch
HTTP headers in results produce invalid JSON <!-- ⚠️ If you do not respect this template your bug report issue will be closed. --> #### Version and Runtime ``` Version: 12.8.1 Commit: 19b7458 Runtime: go1.14 darwin/amd64 Date: 2020-03-18T23:14:26Z ``` #### Expected Behaviour I expected to be able to u...
results: Faster JSON encoding and decoding
This commit improves the performance of JSON encoding and decoding of `Results`. Additionally, it fixes a regression introduced in #474 that didn't produce valid JSON for HTTP headers. A test is added that validates the JSON encoding matches the one produced by the `encoding/json`. ![Screenshot from 2020-03-24 1...
19b74586217105bbde8ded6077c70095e97146bf
f3963afd870386623a008e6b2a348a19df4c48b0
diff --git a/.gitignore b/.gitignore index d0c0e875..295f2d43 100644 --- a/.gitignore +++ b/.gitignore @@ -32,3 +32,4 @@ vendor *.lz .DS_Store +.idea diff --git a/go.mod b/go.mod index cf7036e2..86de5473 100644 --- a/go.mod +++ b/go.mod @@ -23,5 +23,6 @@ require ( github.com/miekg/dns v1.1.17 github.com/streadw...
[ ".gitignore", "go.mod", "go.sum", "lib/results.go", "lib/results_easyjson.go", "lib/results_json.go", "lib/results_test.go" ]
[ { "comment": "func `b2s` is unused (from `unused`)", "path": "lib/results_json.go", "hunk": "@@ -0,0 +1,268 @@\n+package vegeta\n+\n+import (\n+\t\"bufio\"\n+\t\"encoding/base64\"\n+\t\"io\"\n+\t\"net/http\"\n+\t\"reflect\"\n+\t\"strconv\"\n+\t\"strings\"\n+\t\"time\"\n+\t\"unsafe\"\n+\n+\t\"github.com/...
diff --git a/lib/results_test.go b/lib/results_test.go index d035d3f8..8df292be 100644 --- a/lib/results_test.go +++ b/lib/results_test.go @@ -2,7 +2,9 @@ package vegeta import ( "bytes" + "encoding/json" "io" + "io/ioutil" "math/rand" "net/http" "reflect" @@ -50,6 +52,16 @@ func TestResultDecoding(t *test...
true
tsenart/vegeta
501
issue_to_patch
fix: fix module import path for Go module
#### Background https://github.com/tsenart/vegeta/issues/497 #### Checklist - [x] Git commit messages conform to [community standards](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html). - [x] Each Git commit represents meaningful milestones or atomic units of work. - [x] Changed or added ...
e516e0bac62f308ca4ca1b6a9ed1965a55842596
55257546588449a6289f6cbb09f1fc3aa81f380b
diff --git a/README.md b/README.md index cdedf5f8..88f58a35 100644 --- a/README.md +++ b/README.md @@ -762,7 +762,7 @@ import ( "fmt" "time" - vegeta "github.com/tsenart/vegeta/lib" + vegeta "github.com/tsenart/vegeta/v12/lib" ) func main() { diff --git a/attack.go b/attack.go index 302c8deb..58ea54f8 100...
[ "README.md", "attack.go", "encode.go", "file.go", "flags.go", "go.mod", "internal/cmd/jsonschema/main.go", "lib/plot/assets_gen.go", "lib/plot/plot.go", "lib/plot/plot_test.go", "lib/plot/timeseries.go", "plot.go", "report.go" ]
[]
diff --git a/lib/plot/plot_test.go b/lib/plot/plot_test.go index 60dcf4a2..8ae9d7b7 100644 --- a/lib/plot/plot_test.go +++ b/lib/plot/plot_test.go @@ -11,8 +11,8 @@ import ( "time" "github.com/google/go-cmp/cmp" - vegeta "github.com/tsenart/vegeta/lib" - "github.com/tsenart/vegeta/lib/lttb" + vegeta "github.com/t...
true
tsenart/vegeta
495
issue_to_patch
Make rate calculation of the instantaneous rate of attack exportable <!-- ⚠️ If you do not respect this template your issue will be closed. --> <!-- ⚠️ Make sure to browse the opened and closed issues before submit your issue. --> #### Proposal I wish I could get the instantaneous rate of attack. It means make ...
pacer: Extend interface with Rate method
This commit extends the Pacer interface with a Rate method that returns the instantaneous hit rate (per second) at a given point in time. Fixes #476
7232e921ca2001e87fb39c3df6934e951faf59fa
ab617d75a631c42dc113fa4e49ba79b9d33ba3c4
diff --git a/lib/pacer.go b/lib/pacer.go index 97c8310b..4c04d637 100644 --- a/lib/pacer.go +++ b/lib/pacer.go @@ -6,12 +6,17 @@ import ( "time" ) -// A Pacer defines the rate of hits during an Attack by -// returning the duration an Attacker should wait until -// hitting the next Target. If the second return valu...
[ "lib/pacer.go", "lib/pacer_test.go" ]
[]
diff --git a/lib/pacer_test.go b/lib/pacer_test.go index 7e029e23..837532e7 100644 --- a/lib/pacer_test.go +++ b/lib/pacer_test.go @@ -65,6 +65,38 @@ func TestConstantPacer(t *testing.T) { } } +func TestConstantPacer_Rate(t *testing.T) { + t.Parallel() + + for _, tc := range []struct { + freq int + per time.Dur...
true
tsenart/vegeta
470
issue_to_patch
Add header to target containing the sequence number
#### Background <!-- Required background information to understand the PR. Link here any related issues. --> Following up the discussion here https://github.com/tsenart/vegeta/issues/462 This adds the res.Seq to the target headers with the name "X-Vegeta-Seq". This also add a new unit test to check that the h...
85244b4acb411f39075b7f47533ec04ac438201b
826a8b5a7ec7f72326d62fb9ee3ee92eaf0d519c
diff --git a/lib/attack.go b/lib/attack.go index b44fa94f..8436858f 100644 --- a/lib/attack.go +++ b/lib/attack.go @@ -13,6 +13,8 @@ import ( "sync" "time" + "strconv" + "golang.org/x/net/http2" ) @@ -331,7 +333,7 @@ func (a *Attacker) attack(tr Targeter, name string, workers *sync.WaitGroup, tic func (a *A...
[ "lib/attack.go", "lib/attack_test.go" ]
[ { "comment": "Here I'm looping to ensure that we are not only testing `res.Seq == 0`. I can remove it if you prefer.", "path": "lib/attack_test.go", "hunk": "@@ -358,3 +359,21 @@ func TestClient(t *testing.T) {\n \t\tt.Errorf(\"Expected timeout error\")\n \t}\n }\n+\n+func TestSeqHeader(t *testing.T) {\...
diff --git a/lib/attack_test.go b/lib/attack_test.go index e8b97fcf..8dc9397c 100644 --- a/lib/attack_test.go +++ b/lib/attack_test.go @@ -13,6 +13,7 @@ import ( "os" "path/filepath" "reflect" + "strconv" "strings" "testing" "time" @@ -358,3 +359,21 @@ func TestClient(t *testing.T) { t.Errorf("Expected t...
true
tsenart/vegeta
470
comment_to_fix
Add header to target containing the sequence number
Here I'm looping to ensure that we are not only testing `res.Seq == 0`. I can remove it if you prefer.
85244b4acb411f39075b7f47533ec04ac438201b
826a8b5a7ec7f72326d62fb9ee3ee92eaf0d519c
diff --git a/lib/attack_test.go b/lib/attack_test.go index e8b97fcf..8dc9397c 100644 --- a/lib/attack_test.go +++ b/lib/attack_test.go @@ -13,6 +13,7 @@ import ( "os" "path/filepath" "reflect" + "strconv" "strings" "testing" "time" @@ -358,3 +359,21 @@ func TestClient(t *testing.T) { t.Errorf("Expected t...
[ "lib/attack_test.go" ]
[ { "comment": "Here I'm looping to ensure that we are not only testing `res.Seq == 0`. I can remove it if you prefer.", "path": "lib/attack_test.go", "hunk": "@@ -358,3 +359,21 @@ func TestClient(t *testing.T) {\n \t\tt.Errorf(\"Expected timeout error\")\n \t}\n }\n+\n+func TestSeqHeader(t *testing.T) {\...
true
tsenart/vegeta
470
comment_to_fix
Add header to target containing the sequence number
Please run goimports to automatically group packages in blocks
85244b4acb411f39075b7f47533ec04ac438201b
826a8b5a7ec7f72326d62fb9ee3ee92eaf0d519c
diff --git a/lib/attack.go b/lib/attack.go index b44fa94f..8436858f 100644 --- a/lib/attack.go +++ b/lib/attack.go @@ -13,6 +13,8 @@ import ( "sync" "time" + "strconv" + "golang.org/x/net/http2" ) @@ -331,7 +333,7 @@ func (a *Attacker) attack(tr Targeter, name string, workers *sync.WaitGroup, tic func (a *A...
[ "lib/attack.go" ]
[ { "comment": "Please run goimports to automatically group packages in blocks", "path": "lib/attack.go", "hunk": "@@ -13,6 +13,8 @@ import (\n \t\"sync\"\n \t\"time\"\n \n+\t\"strconv\"\n+\n \t\"golang.org/x/net/http2\"", "resolving_sha": "826a8b5a7ec7f72326d62fb9ee3ee92eaf0d519c", "resolving_dif...
true
tsenart/vegeta
470
comment_to_fix
Add header to target containing the sequence number
I don’t think users should be able to over-ride this header unintentionally, so we should set it after the target is read, which also ensures there’s an http.Header (so we don’t need the allocation).
85244b4acb411f39075b7f47533ec04ac438201b
826a8b5a7ec7f72326d62fb9ee3ee92eaf0d519c
diff --git a/lib/attack.go b/lib/attack.go index b44fa94f..8436858f 100644 --- a/lib/attack.go +++ b/lib/attack.go @@ -13,6 +13,8 @@ import ( "sync" "time" + "strconv" + "golang.org/x/net/http2" ) @@ -331,7 +333,7 @@ func (a *Attacker) attack(tr Targeter, name string, workers *sync.WaitGroup, tic func (a *A...
[ "lib/attack.go" ]
[ { "comment": "I don’t think users should be able to over-ride this header unintentionally, so we should set it after the target is read, which also ensures there’s an http.Header (so we don’t need the allocation).", "path": "lib/attack.go", "hunk": "@@ -348,6 +350,8 @@ func (a *Attacker) hit(tr Targeter...
true
tsenart/vegeta
474
issue_to_patch
Capture HTTP response header in vegeta.Result #### Proposal Extend `vegeta.Result` with a `Header` field that captures the response header of each performed HTTP request (hit). #### Background In addition to capturing response bodies, it can be useful to capture response headers for debugging purposes, dynami...
Capture HTTP headers in results
Headers are written in wire format. CSV output uses base64 to encode headers. Fixes #303
85244b4acb411f39075b7f47533ec04ac438201b
0c84d712cdb0cc35bc3e8dbc3e1c62f4393ca69c
diff --git a/encode.go b/encode.go index e3997f5c..b2becf66 100644 --- a/encode.go +++ b/encode.go @@ -26,15 +26,18 @@ automatically. The CSV encoder doesn't write a header. The columns written by it are: - 1. Unix timestamp in nanoseconds since epoch - 2. HTTP status code - 3. Request latency in nanoseconds - ...
[ "encode.go", "lib/attack.go", "lib/results.go", "lib/results_easyjson.go", "lib/results_test.go" ]
[ { "comment": "Error return value of `r.Header.Write` is not checked (from `errcheck`)", "path": "lib/attack.go", "hunk": "@@ -392,5 +393,9 @@ func (a *Attacker) hit(tr Targeter, name string) *Result {\n \t\tres.Error = r.Status\n \t}\n \n+\tvar hdr bytes.Buffer\n+\tr.Header.Write(&hdr)", "resolving_...
diff --git a/lib/results_test.go b/lib/results_test.go index b53838f8..d035d3f8 100644 --- a/lib/results_test.go +++ b/lib/results_test.go @@ -4,6 +4,7 @@ import ( "bytes" "io" "math/rand" + "net/http" "reflect" "testing" "testing/quick" @@ -76,6 +77,7 @@ func TestResultEncoding(t *testing.T) { BytesO...
true