Datasets:
PotatoHD
/
github-pr-resolve

Dataset card Data Studio Files
xet
 Community
repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
vercel/turborepo
13,069
issue_to_patch
fix: Deliver Ctrl-C to ConPTY children during graceful shutdown on Windows
### Why On Windows with the TUI, quitting turbo never gracefully stops task scripts. Tasks run under ConPTY in TUI mode, so they are attached to a pseudoconsole rather than turbo's console — the `CTRL_C_EVENT` the TUI generates never reaches them. The Windows graceful shutdown path sent nothing at all to children, so ...
b62a04b34d9be479e3f2b70039c929ccc1634145
bf722300ad8b4849cf64a756ef6165a1d1c25b01
diff --git a/crates/turborepo-process/src/child/handle.rs b/crates/turborepo-process/src/child/handle.rs index eb0383d6de42c..17201492e52d5 100644 --- a/crates/turborepo-process/src/child/handle.rs +++ b/crates/turborepo-process/src/child/handle.rs @@ -24,6 +24,38 @@ pub(super) struct ChildHandle { pty_controller_...
[ "crates/turborepo-process/src/child/handle.rs", "crates/turborepo-process/src/child/shutdown.rs", "crates/turborepo-process/src/lib.rs" ]
[]
true
vercel/turborepo
13,070
issue_to_patch
ci: Add PR workflow timeouts
## Why PR checks should fail sooner when a job hangs or runs unexpectedly long, reducing wasted CI time and improving feedback loops. ## What Sets PR-capable GitHub Actions jobs to a 15 minute timeout. ## How Updated timeout-minutes values in pull_request workflows and added a missing job-level timeout for JS package...
b62a04b34d9be479e3f2b70039c929ccc1634145
8dfb57be538e9c065cf45caab3eb0d7ff8c2f004
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index 70be79573dbab..098617c29bc0b 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -15,7 +15,7 @@ permissions: jobs: docs-quality: runs-on: ubuntu-latest - timeout-minutes: 30 + timeout-minutes: 15 steps...
[ ".github/workflows/docs.yml", ".github/workflows/lint-pr-title.yml", ".github/workflows/lint.yml", ".github/workflows/pr-clean-caches.yml", ".github/workflows/test-js-packages.yml", ".github/workflows/turborepo-test.yml" ]
[]
true
vercel/turborepo
13,068
issue_to_patch
release(turborepo): 2.9.19-canary.2
## Release v2.9.19-canary.2 > [!CAUTION] > Versioned docs aliasing FAILED. [View logs](https://github.com/vercel/turborepo/actions/runs/27372826463) ### Changes - release(turborepo): 2.9.19-canary.1 (#13065) (`689d579`) - fix: Stop shim from killing local turbo on Windows Ctrl+C (#13067) (`0a341ae`)
0a341ae18461359425aae75165de32018f56218d
19751ad9aa826d31251003f12e92d0fcd33babed
diff --git a/packages/create-turbo/package.json b/packages/create-turbo/package.json index 5926ca398873e..bbe370f8846dd 100644 --- a/packages/create-turbo/package.json +++ b/packages/create-turbo/package.json @@ -1,6 +1,6 @@ { "name": "create-turbo", - "version": "2.9.19-canary.1", + "version": "2.9.19-canary.2",...
[ "packages/create-turbo/package.json", "packages/eslint-config-turbo/package.json", "packages/eslint-plugin-turbo/package.json", "packages/turbo-codemod/package.json", "packages/turbo-gen/package.json", "packages/turbo-ignore/package.json", "packages/turbo-types/package.json", "packages/turbo-workspace...
[]
true
vercel/turborepo
13,067
issue_to_patch
fix: Stop shim from killing local turbo on Windows Ctrl+C
## Why Follow-up to #12651. On Windows, graceful shutdown worked with `--skip-infer` but not without it. Without `--skip-infer`, the global `turbo` binary spawns the repo-local `turbo` as a child process, and the shim's Ctrl+C handler called `TerminateProcess` on that child immediately. The local turbo also receives t...
689d5797d755df1d9cb3c52cdf84d2a425328c49
4490384e7f0967a821c5ceff6f9572f3dec8ae4d
diff --git a/crates/turborepo-lib/src/child.rs b/crates/turborepo-lib/src/child.rs index ace7545fad38d..69baf78904d8b 100644 --- a/crates/turborepo-lib/src/child.rs +++ b/crates/turborepo-lib/src/child.rs @@ -5,13 +5,17 @@ use shared_child::SharedChild; /// Spawns a child in a way where SIGINT is correctly forwarded t...
[ "crates/turborepo-lib/src/child.rs" ]
[]
true
vercel/turborepo
13,065
issue_to_patch
release(turborepo): 2.9.19-canary.1
## Release v2.9.19-canary.1 > [!CAUTION] > Versioned docs aliasing FAILED. [View logs](https://github.com/vercel/turborepo/actions/runs/27313807565) ### Changes - release(turborepo): 2.9.17-canary.7 (#13046) (`7981598`) - fix: Send Ctrl+C to Windows PTY tasks (#13041) (`e62661a`) - release(turborepo): 2.9.17 (#13047...
0afbf1ed87d273cf242586583ecc6d762b4a23a9
1180a69dd4f2a48985f71c951855842e18d08e1f
diff --git a/packages/create-turbo/package.json b/packages/create-turbo/package.json index 699a32bc425fe..5926ca398873e 100644 --- a/packages/create-turbo/package.json +++ b/packages/create-turbo/package.json @@ -1,6 +1,6 @@ { "name": "create-turbo", - "version": "2.9.18", + "version": "2.9.19-canary.1", "desc...
[ "packages/create-turbo/package.json", "packages/eslint-config-turbo/package.json", "packages/eslint-plugin-turbo/package.json", "packages/turbo-codemod/package.json", "packages/turbo-gen/package.json", "packages/turbo-ignore/package.json", "packages/turbo-types/package.json", "packages/turbo-workspace...
[]
true
vercel/turborepo
13,064
issue_to_patch
fix: Re-authenticate when stored token loses access to linked team
## Why Users on SAML-enforced teams get stuck in a login loop. Their token stays active at the user level after the SAML session expires, so team-scoped requests 403 while `turbo login` keeps saying "Using existing login" and never re-authenticates. Previously `--force` was the escape hatch, but it is now a no-op for ...
912e7ebf50d1ff95f841ba141e76c4f7a813c63c
d186a6ae29fde54380624cfe480886511198fb7e
diff --git a/crates/turborepo-auth/src/auth/login.rs b/crates/turborepo-auth/src/auth/login.rs index 7ad51caa777e1..46dd821552858 100644 --- a/crates/turborepo-auth/src/auth/login.rs +++ b/crates/turborepo-auth/src/auth/login.rs @@ -6,7 +6,7 @@ use std::{ pub use error::Error; use tracing::warn; -use turborepo_api_...
[ "crates/turborepo-auth/src/auth/login.rs", "crates/turborepo-auth/src/auth/mod.rs", "crates/turborepo-auth/src/auth/sso.rs", "crates/turborepo-auth/src/lib.rs", "crates/turborepo-lib/src/commands/login/mod.rs" ]
[]
true
vercel/turborepo
13,062
issue_to_patch
release(turborepo): 2.9.18
## Release v2.9.18 > [!CAUTION] > Versioned docs aliasing FAILED. [View logs](https://github.com/vercel/turborepo/actions/runs/27311683638) ### Changes - release(turborepo): 2.9.17 (#13047) (`7dd54b7`) - ci: Fetch version.txt via API in docs alias failure notification (#13050) (`7d361a4`) - fix: Harden cache archive...
2a76556b9457c514fa597a09fef23da2e1250c8c
68e68daab1fe9ef1dbd6fb9f8d2fb34d6f2cdc65
diff --git a/packages/create-turbo/package.json b/packages/create-turbo/package.json index 2dd836504cec0..699a32bc425fe 100644 --- a/packages/create-turbo/package.json +++ b/packages/create-turbo/package.json @@ -1,6 +1,6 @@ { "name": "create-turbo", - "version": "2.9.17", + "version": "2.9.18", "description":...
[ "packages/create-turbo/package.json", "packages/eslint-config-turbo/package.json", "packages/eslint-plugin-turbo/package.json", "packages/turbo-codemod/package.json", "packages/turbo-gen/package.json", "packages/turbo-ignore/package.json", "packages/turbo-types/package.json", "packages/turbo-workspace...
[]
true
vercel/turborepo
13,061
issue_to_patch
fix: Block self-hosted login URLs from attempting to use Vercel's SSO
## Why Repository-controlled `remoteCache.loginUrl` can redirect `turbo login` and `turbo login --sso-team` to an attacker-controlled origin. That exposes the CSRF state in the opened URL and can lead to credential phishing or token injection through the localhost callback. This intentionally changes self-hosted logi...
da8e3487acce10039425180c42875d7ccc484ed5
84369b5eb1fb0ca7c772a007c494f6b87007a615
diff --git a/crates/turborepo-auth/src/auth/login.rs b/crates/turborepo-auth/src/auth/login.rs index 93d4848cae4c8..7ad51caa777e1 100644 --- a/crates/turborepo-auth/src/auth/login.rs +++ b/crates/turborepo-auth/src/auth/login.rs @@ -14,9 +14,9 @@ use url::Url; use crate::{ LoginOptions, Token, auth::{ - ...
[ "crates/turborepo-auth/src/auth/login.rs", "crates/turborepo-auth/src/auth/mod.rs", "crates/turborepo-auth/src/auth/sso.rs", "crates/turborepo-auth/src/error.rs", "crates/turborepo-config/src/env.rs", "crates/turborepo-config/src/lib.rs", "crates/turborepo-lib/src/commands/login/manual.rs", "crates/tu...
[ { "comment": "```suggestion\n // `Url::host_str` returns IPv6 addresses wrapped in brackets (e.g. `[::1]`),\n // so match both the bracketed and bare forms to be safe.\n matches!(host, \"localhost\" | \"127.0.0.1\" | \"::1\" | \"[::1]\")\n```\n\nThe `is_localhost` check compares against the bare `\"::1...
true
vercel/turborepo
13,061
comment_to_fix
fix: Block self-hosted login URLs from attempting to use Vercel's SSO
```suggestion // `Url::host_str` returns IPv6 addresses wrapped in brackets (e.g. `[::1]`), // so match both the bracketed and bare forms to be safe. matches!(host, "localhost" | "127.0.0.1" | "::1" | "[::1]") ``` The `is_localhost` check compares against the bare `"::1"`\, but `Url::host_str()` returns IP...
da8e3487acce10039425180c42875d7ccc484ed5
84369b5eb1fb0ca7c772a007c494f6b87007a615
diff --git a/crates/turborepo-auth/src/auth/mod.rs b/crates/turborepo-auth/src/auth/mod.rs index c2aac927346b3..3127ec83b1c94 100644 --- a/crates/turborepo-auth/src/auth/mod.rs +++ b/crates/turborepo-auth/src/auth/mod.rs @@ -11,7 +11,7 @@ use turbopath::AbsoluteSystemPath; #[cfg(test)] use turbopath::AbsoluteSystemPa...
[ "crates/turborepo-auth/src/auth/mod.rs" ]
[ { "comment": "```suggestion\n // `Url::host_str` returns IPv6 addresses wrapped in brackets (e.g. `[::1]`),\n // so match both the bracketed and bare forms to be safe.\n matches!(host, \"localhost\" | \"127.0.0.1\" | \"::1\" | \"[::1]\")\n```\n\nThe `is_localhost` check compares against the bare `\"::1...
true
vercel/turborepo
13,060
issue_to_patch
fix: Validate OidHash hex buffers
## Why VULN-11602 reports that `OidHash::from_hex_buf` accepted arbitrary bytes even though `OidHash` later exposes the buffer through unchecked UTF-8 conversions. Invalid bytes could therefore create invalid `str`/`String` values through safe code. ## What Enforce the ASCII-hex invariant in the safe `OidHash` const...
3018717c28fc8f1ecffa2c92e3260be0dc0165aa
7d2ec35a6f8c2c159624c8c9b6fce7dd65f26c3e
diff --git a/crates/turborepo-hash/src/oid_hash.rs b/crates/turborepo-hash/src/oid_hash.rs index 91dbf8ac628fa..3da507ddeb5b3 100644 --- a/crates/turborepo-hash/src/oid_hash.rs +++ b/crates/turborepo-hash/src/oid_hash.rs @@ -8,20 +8,30 @@ pub struct OidHash([u8; 40]); impl OidHash { /// Create from a pre-filled...
[ "crates/turborepo-hash/src/oid_hash.rs", "crates/turborepo-scm/src/repo_index.rs", "crates/turborepo-scm/src/status.rs" ]
[]
true
vercel/turborepo
13,059
issue_to_patch
fix: Separate artifact signature fields
## Why Artifact signatures should use a canonical HMAC input so distinct logical fields cannot serialize to the same byte sequence. This closes VULN-11599, where a prefix relationship between team IDs could make one signed artifact validate for another team sharing the same signing key. ## What Updates artifac...
34514e278822ccbe3a083730b7032709ef16f85c
cad3e107bdec6e80881e202346a796b7d40e784a
diff --git a/crates/turborepo-cache/src/signature_authentication.rs b/crates/turborepo-cache/src/signature_authentication.rs index f369dddb3f02b..3f1fff4998c28 100644 --- a/crates/turborepo-cache/src/signature_authentication.rs +++ b/crates/turborepo-cache/src/signature_authentication.rs @@ -9,6 +9,7 @@ use thiserror::...
[ "crates/turborepo-cache/src/signature_authentication.rs" ]
[]
true
vercel/turborepo
13,058
issue_to_patch
fix: Preserve vt100 cell byte counts
## Why `turborepo-vt100` could store more than 15 UTF-8 bytes in a cell while reading the byte count through a 4-bit mask, allowing `Cell::contents()` to slice in the middle of a multi-byte codepoint. ## What Preserve the full stored byte count for cell contents and replace unchecked UTF-8 conversion with chec...
16dc881cabf5c13d02c27a5d7cfdfeb60736206c
8963d5fe30066cac0e8eac7b8c825651629461f3
diff --git a/crates/turborepo-vt100/src/cell.rs b/crates/turborepo-vt100/src/cell.rs index 815d85bac8c3f..dee9a87298e63 100644 --- a/crates/turborepo-vt100/src/cell.rs +++ b/crates/turborepo-vt100/src/cell.rs @@ -47,7 +47,7 @@ impl Cell { #[inline] fn num_bytes(&self) -> usize { - usize::from(self.nu...
[ "crates/turborepo-vt100/src/cell.rs", "crates/turborepo-vt100/tests/basic.rs" ]
[]
diff --git a/crates/turborepo-vt100/tests/basic.rs b/crates/turborepo-vt100/tests/basic.rs index 67360bb08f53e..5d08cef35dd2b 100644 --- a/crates/turborepo-vt100/tests/basic.rs +++ b/crates/turborepo-vt100/tests/basic.rs @@ -94,6 +94,15 @@ fn cell_contents() { assert_eq!(parser.screen().cell(0, 6).unwrap().content...
true
vercel/turborepo
13,020
issue_to_patch
fix(turborepo): Normalize Windows daemon path hash
### Description Normalize Windows daemon repo hashes by uppercasing the drive letter before hashing. This keeps the LSP and daemon on the same socket when VS Code sends `file:///c:/...` and the CLI resolves `C:\...`. ### Testing Instructions - `cargo fmt --check` - `cargo test -p turborepo-daemon --lib`
cb93407f557c30388ac73649e28e1c3fe57d8057
a25e663725996d997d529ec6b75c2e2bec49c051
diff --git a/crates/turborepo-daemon/src/lib.rs b/crates/turborepo-daemon/src/lib.rs index 22104d978311e..003010633395b 100644 --- a/crates/turborepo-daemon/src/lib.rs +++ b/crates/turborepo-daemon/src/lib.rs @@ -91,10 +91,28 @@ pub struct Paths { fn repo_hash(repo_root: &AbsoluteSystemPath) -> String { let mut...
[ "crates/turborepo-daemon/src/lib.rs" ]
[ { "comment": "On Windows drive-letter paths, this always allocates a new `String` via `format!`, even when the drive letter is already uppercase. Consider returning `path` unchanged when `drive.is_ascii_uppercase()` to avoid the extra allocation on the common case.", "path": "crates/turborepo-daemon/src/lib...
true
vercel/turborepo
13,020
comment_to_fix
fix(turborepo): Normalize Windows daemon path hash
On Windows drive-letter paths, this always allocates a new `String` via `format!`, even when the drive letter is already uppercase. Consider returning `path` unchanged when `drive.is_ascii_uppercase()` to avoid the extra allocation on the common case.
cb93407f557c30388ac73649e28e1c3fe57d8057
a25e663725996d997d529ec6b75c2e2bec49c051
diff --git a/crates/turborepo-daemon/src/lib.rs b/crates/turborepo-daemon/src/lib.rs index 22104d978311e..003010633395b 100644 --- a/crates/turborepo-daemon/src/lib.rs +++ b/crates/turborepo-daemon/src/lib.rs @@ -91,10 +91,28 @@ pub struct Paths { fn repo_hash(repo_root: &AbsoluteSystemPath) -> String { let mut...
[ "crates/turborepo-daemon/src/lib.rs" ]
[ { "comment": "On Windows drive-letter paths, this always allocates a new `String` via `format!`, even when the drive letter is already uppercase. Consider returning `path` unchanged when `drive.is_ascii_uppercase()` to avoid the extra allocation on the common case.", "path": "crates/turborepo-daemon/src/lib...
true
vercel/turborepo
13,020
comment_to_fix
fix(turborepo): Normalize Windows daemon path hash
The implementation uses `#[cfg(windows)]`, but the added test uses `#[cfg(target_os = \"windows\")]`. These are equivalent in practice, but using the same `cfg` form for both improves consistency and reduces confusion during future edits.
cb93407f557c30388ac73649e28e1c3fe57d8057
a25e663725996d997d529ec6b75c2e2bec49c051
diff --git a/crates/turborepo-daemon/src/lib.rs b/crates/turborepo-daemon/src/lib.rs index 22104d978311e..003010633395b 100644 --- a/crates/turborepo-daemon/src/lib.rs +++ b/crates/turborepo-daemon/src/lib.rs @@ -91,10 +91,28 @@ pub struct Paths { fn repo_hash(repo_root: &AbsoluteSystemPath) -> String { let mut...
[ "crates/turborepo-daemon/src/lib.rs" ]
[ { "comment": "The implementation uses `#[cfg(windows)]`, but the added test uses `#[cfg(target_os = \\\"windows\\\")]`. These are equivalent in practice, but using the same `cfg` form for both improves consistency and reduces confusion during future edits.", "path": "crates/turborepo-daemon/src/lib.rs", ...
true
vercel/turborepo
13,057
issue_to_patch
fix: Contain incremental cache outputs
## Why Incremental cache output collection must enforce the same repository containment invariant as the normal cache upload path. Without that guard, traversal-style output globs can produce archive entries outside the repository root. ## What Reject incremental cache output matches that resolve outside `repo...
92e1f8e5365ea5a95e47c3698deb2f7adaa55eba
a2b0931428849012496c01a8508d1c55dca60a9d
diff --git a/crates/turborepo-run-cache/src/incremental.rs b/crates/turborepo-run-cache/src/incremental.rs index 9d09abea86d00..afa32479594a2 100644 --- a/crates/turborepo-run-cache/src/incremental.rs +++ b/crates/turborepo-run-cache/src/incremental.rs @@ -489,6 +489,12 @@ fn collect_partition_files( let files =...
[ "crates/turborepo-run-cache/src/incremental.rs" ]
[]
true
vercel/turborepo
13,056
issue_to_patch
fix: Strip special mode bits from cache restore
## Why Remote cache archives are untrusted input unless signature verification is enabled. Restoring setuid, setgid, or sticky bits from tar metadata can create surprising and unsafe filesystem permissions, especially when Turbo runs in privileged CI contexts. ## What Sanitize restored Unix modes to normal permission ...
f46f896ef414823582131304c9749e9be011fe37
430ee4432a97a0d953215fedc6a43a57f346fdcd
diff --git a/crates/turborepo-cache/src/cache_archive/restore.rs b/crates/turborepo-cache/src/cache_archive/restore.rs index 03d41f80ccab1..01b7dde4940ee 100644 --- a/crates/turborepo-cache/src/cache_archive/restore.rs +++ b/crates/turborepo-cache/src/cache_archive/restore.rs @@ -219,9 +219,18 @@ mod tests { ...
[ "crates/turborepo-cache/src/cache_archive/restore.rs", "crates/turborepo-cache/src/cache_archive/restore_directory.rs", "crates/turborepo-cache/src/cache_archive/restore_manifest.rs", "crates/turborepo-cache/src/cache_archive/restore_regular.rs" ]
[]
true
vercel/turborepo
13,055
issue_to_patch
fix: Prevent git argument injection in SCM refs
## Why VULN-11531 reports that externally supplied GraphQL refs can be interpreted as git options, allowing flags like `--output=<path>` to truncate local files before git rejects the command. ## What Reject SCM refs that begin with `-` before spawning git, and terminate git option parsing before ref operands in the...
7f353ca3a6f28fbbcce931aeab7be0efe718c466
6051e01e123b02878c53776c6997081cccd11ec5
diff --git a/crates/turborepo-scm/src/git.rs b/crates/turborepo-scm/src/git.rs index e13f9bd53bc81..1e3f9c7797bf4 100644 --- a/crates/turborepo-scm/src/git.rs +++ b/crates/turborepo-scm/src/git.rs @@ -205,6 +205,14 @@ impl GitRepo { Ok(output.trim().to_owned()) } + fn validate_git_ref(git_ref: &str) ...
[ "crates/turborepo-scm/src/git.rs", "crates/turborepo-scm/src/lib.rs" ]
[]
true
vercel/turborepo
13,054
issue_to_patch
fix: Confine prune patch paths
## Why Patch paths from lockfile/package manager `patchedDependencies` are attacker-controlled repo input. `turbo prune` must not let those paths escape the repository when reading patches or escape the prune output when writing them. ## What Adds source and destination confinement checks for patch files copied by `...
2a2bc5c6bcf4b288dea882e74f775cdbb5cdbd05
8311f44dae43057710470846875cf86b952e10bd
diff --git a/crates/turborepo-lib/src/commands/prune.rs b/crates/turborepo-lib/src/commands/prune.rs index e84d5f8a17fca..b695337c898d6 100644 --- a/crates/turborepo-lib/src/commands/prune.rs +++ b/crates/turborepo-lib/src/commands/prune.rs @@ -10,8 +10,8 @@ use globwalk::{ValidatedGlob, WalkType}; use miette::Diagnos...
[ "crates/turborepo-lib/src/commands/prune.rs", "crates/turborepo/tests/prune_test.rs" ]
[]
diff --git a/crates/turborepo/tests/prune_test.rs b/crates/turborepo/tests/prune_test.rs index 802b158f6a9fd..391f13dc094ee 100644 --- a/crates/turborepo/tests/prune_test.rs +++ b/crates/turborepo/tests/prune_test.rs @@ -4,7 +4,7 @@ mod common; use std::{fs, path::Path}; -use common::{run_turbo, setup}; +use commo...
true
vercel/turborepo
13,053
issue_to_patch
fix: Harden query server file access
## Why The local query server should only expose repository-scoped file data to trusted localhost requests. Binding to loopback is not enough when browsers can reach localhost services. ## What Restricts the query server to localhost Host headers, removes permissive CORS, and canonicalizes GraphQL file paths before ...
8cff6d519696c05349751c916960a93152ed011b
61be77c47b60173e3e7d1bc33b116ed9429c86d1
diff --git a/Cargo.lock b/Cargo.lock index d0ffda774df71..18711f4288e2e 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -5506,7 +5506,7 @@ dependencies = [ "tokio-rustls", "tokio-util", "tower 0.5.2", - "tower-http 0.6.8", + "tower-http", "tower-service", "url", "wasm-bindgen", @@ -6990,22 +6990,6 @@ dependenci...
[ "Cargo.lock", "crates/turborepo-query/Cargo.toml", "crates/turborepo-query/src/file.rs", "crates/turborepo-query/src/lib.rs", "crates/turborepo-query/src/server.rs", "crates/turborepo/ARCHITECTURE.md" ]
[]
true
vercel/turborepo
13,052
issue_to_patch
chore: Remove web UI mode
## Why The web UI mode was unreleased and should not remain as a hidden CLI/config path. Removing it reduces unused surface area in the run UI and query layers. ## What - Removes the `web` UI mode from CLI/config parsing. - Deletes the web UI sender, subscriber, event state, and run startup path. - Keeps `turbo quer...
403a3558e01407ad3b86e0ceff5fdc8d77171a3b
baa0408bcc43ac91cb22b51a11745f202b68ce30
diff --git a/Cargo.lock b/Cargo.lock index 609fcded11deb..d0ffda774df71 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -8076,7 +8076,6 @@ dependencies = [ "turborepo-task-id", "turborepo-turbo-json", "turborepo-types", - "turborepo-ui", "wax", "webbrowser", ] @@ -8096,7 +8095,6 @@ dependencies = [ "turborepo-...
[ "Cargo.lock", "crates/turborepo-lib/src/cli/snapshots/turborepo_lib__cli__test__turbo_long_help.snap", "crates/turborepo-lib/src/cli/snapshots/turborepo_lib__cli__test__turbo_short_help.snap", "crates/turborepo-lib/src/commands/run.rs", "crates/turborepo-lib/src/lib.rs", "crates/turborepo-lib/src/run/mod....
[]
diff --git a/crates/turborepo-lib/src/cli/snapshots/turborepo_lib__cli__test__turbo_long_help.snap b/crates/turborepo-lib/src/cli/snapshots/turborepo_lib__cli__test__turbo_long_help.snap index 02df5e4ccf4ed..86a44c6216d96 100644 --- a/crates/turborepo-lib/src/cli/snapshots/turborepo_lib__cli__test__turbo_long_help.snap...
true
vercel/turborepo
13,051
issue_to_patch
fix: Harden cache archive symlink restore
## Why Cache artifacts should not be able to restore files outside the repository root. This is a defense-in-depth hardening for cache archive extraction. ## What Harden cache archive restore so symlink validation checks real resolved prefixes instead of relying only on lexically cleaned paths. This prevents c...
7d361a46e11eca52da0b7e3f1e08fd844b6d71dc
b276e218075be6cd775f2e4d18332fadcbec4b5c
diff --git a/crates/turborepo-cache/src/cache_archive/restore.rs b/crates/turborepo-cache/src/cache_archive/restore.rs index 676fc8270cd9a..03d41f80ccab1 100644 --- a/crates/turborepo-cache/src/cache_archive/restore.rs +++ b/crates/turborepo-cache/src/cache_archive/restore.rs @@ -661,6 +661,43 @@ mod tests { O...
[ "crates/turborepo-cache/src/cache_archive/restore.rs", "crates/turborepo-cache/src/cache_archive/restore_directory.rs", "crates/turborepo-cache/src/cache_archive/restore_symlink.rs" ]
[]
true
vercel/turborepo
13,050
issue_to_patch
ci: Fetch version.txt via API in docs alias failure notification
### Why Security audit (VULN-10701) flagged this workflow for checking out `github.event.workflow_run.head_branch` in a `workflow_run` context. The finding is not exploitable — the triggering "Release" workflow is `workflow_dispatch`-only, so `head_branch` is always a maintainer-created branch — but the checkout is un...
7dd54b7df7fa64800ebee4ee753a7297669afe27
361c3dd2b800225467296c2153156e2fe8bbfbb3
diff --git a/.github/workflows/docs-alias-failure-notification.yml b/.github/workflows/docs-alias-failure-notification.yml index 4c045e54fac6e..59df382760093 100644 --- a/.github/workflows/docs-alias-failure-notification.yml +++ b/.github/workflows/docs-alias-failure-notification.yml @@ -19,18 +19,19 @@ jobs: runs...
[ ".github/workflows/docs-alias-failure-notification.yml" ]
[]
true
vercel/turborepo
13,047
issue_to_patch
release(turborepo): 2.9.17
## Release v2.9.17 > [!CAUTION] > Versioned docs aliasing FAILED. [View logs](https://github.com/vercel/turborepo/actions/runs/27218228460) ### Changes - fix: Keep non-PTY stdin alive for persistent tasks (#12972) (`26ae68b`) - release(turborepo): 2.9.16 (#12970) (`fac2b75`) - release(turborepo): 2.9.17-canary.1 (#1...
e62661ad2910a429a57d7d40bf93398c6f19f8ac
395b05f1d77f50b45f3baef6cb9279f4ac879495
diff --git a/packages/create-turbo/package.json b/packages/create-turbo/package.json index a1b3a22890dbe..2dd836504cec0 100644 --- a/packages/create-turbo/package.json +++ b/packages/create-turbo/package.json @@ -1,6 +1,6 @@ { "name": "create-turbo", - "version": "2.9.17-canary.7", + "version": "2.9.17", "desc...
[ "packages/create-turbo/package.json", "packages/eslint-config-turbo/package.json", "packages/eslint-plugin-turbo/package.json", "packages/turbo-codemod/package.json", "packages/turbo-gen/package.json", "packages/turbo-ignore/package.json", "packages/turbo-types/package.json", "packages/turbo-workspace...
[]
true
vercel/turborepo
13,041
issue_to_patch
fix: Send Ctrl+C to Windows PTY tasks
## Why Windows TUI runs use a PTY, and non-interactive tasks do not keep a task stdin writer exposed to the UI. That meant Ctrl+C could start Turbo shutdown while the task itself never received the interrupt needed to run graceful cleanup. This fixes the Windows `--ui=tui` graceful shutdown regression reported in...
1e6516ef727f146b6cb6445998d3046a39ab9a59
e5749d7e0e602fcd88f8692033a022ac820c56a1
diff --git a/crates/turborepo-process/src/child/handle.rs b/crates/turborepo-process/src/child/handle.rs index 5510c4d4ce7df..eb0383d6de42c 100644 --- a/crates/turborepo-process/src/child/handle.rs +++ b/crates/turborepo-process/src/child/handle.rs @@ -288,9 +288,12 @@ impl ChildHandle { #[cfg(unix)] ...
[ "crates/turborepo-process/src/child/handle.rs", "crates/turborepo-process/src/child/test.rs" ]
[]
true
vercel/turborepo
13,046
issue_to_patch
release(turborepo): 2.9.17-canary.7
## Release v2.9.17-canary.7 > [!CAUTION] > Versioned docs aliasing FAILED. [View logs](https://github.com/vercel/turborepo/actions/runs/27205603949) ### Changes - fix: Defer hashes for JIT task dependents (#13045) (`2332886`) - release(turborepo): 2.9.17-canary.6 (#13044) (`5550ced`)
5550ced7f3bc50a8f583db45837916273d6da34a
96eccc2036b165e8d1cf9d52f860c2721587db34
diff --git a/packages/create-turbo/package.json b/packages/create-turbo/package.json index 5f5ba6e8208cf..a1b3a22890dbe 100644 --- a/packages/create-turbo/package.json +++ b/packages/create-turbo/package.json @@ -1,6 +1,6 @@ { "name": "create-turbo", - "version": "2.9.17-canary.6", + "version": "2.9.17-canary.7",...
[ "packages/create-turbo/package.json", "packages/eslint-config-turbo/package.json", "packages/eslint-plugin-turbo/package.json", "packages/turbo-codemod/package.json", "packages/turbo-gen/package.json", "packages/turbo-ignore/package.json", "packages/turbo-types/package.json", "packages/turbo-workspace...
[]
true
vercel/turborepo
13,044
issue_to_patch
release(turborepo): 2.9.17-canary.6
## Release v2.9.17-canary.6 > [!CAUTION] > Versioned docs aliasing FAILED. [View logs](https://github.com/vercel/turborepo/actions/runs/27172871045) ### Changes - release(turborepo): 2.9.17-canary.5 (#13038) (`d5bd26c`) - docs: Remove ESM warning from gen page (#13039) (`1745bed`) - fix: Bypass npm command shim on W...
026b3da4abe01ced2a9ca3c4c814c44c47e9e634
484d2700d27a79502eeff88ba29b29021f0e2a32
diff --git a/packages/create-turbo/package.json b/packages/create-turbo/package.json index 40e9e21d2ce1e..5f5ba6e8208cf 100644 --- a/packages/create-turbo/package.json +++ b/packages/create-turbo/package.json @@ -1,6 +1,6 @@ { "name": "create-turbo", - "version": "2.9.17-canary.5", + "version": "2.9.17-canary.6",...
[ "packages/create-turbo/package.json", "packages/eslint-config-turbo/package.json", "packages/eslint-plugin-turbo/package.json", "packages/turbo-codemod/package.json", "packages/turbo-gen/package.json", "packages/turbo-ignore/package.json", "packages/turbo-types/package.json", "packages/turbo-workspace...
[]
true
vercel/turborepo
13,045
issue_to_patch
fix: Defer hashes for JIT task dependents
## Why Tasks that use `$TURBO_JIT$` defer final hash calculation until dispatch, after dependency outputs can exist. Dependents of those tasks also need to wait; otherwise precompute can try to read a dependency hash that has intentionally not been produced yet. ## What Defers hash calculation for tasks whose depend...
026b3da4abe01ced2a9ca3c4c814c44c47e9e634
e4bb68506f9a3d0d3649bec949959ed38ecfd151
diff --git a/crates/turborepo-lib/src/task_graph/visitor/mod.rs b/crates/turborepo-lib/src/task_graph/visitor/mod.rs index 293c6d47b2ff0..052f3f7fb83d8 100644 --- a/crates/turborepo-lib/src/task_graph/visitor/mod.rs +++ b/crates/turborepo-lib/src/task_graph/visitor/mod.rs @@ -288,7 +288,24 @@ impl<'a> Visitor<'a> { ...
[ "crates/turborepo-lib/src/task_graph/visitor/mod.rs", "crates/turborepo/ARCHITECTURE.md", "crates/turborepo/tests/run_caching.rs" ]
[]
diff --git a/crates/turborepo/tests/run_caching.rs b/crates/turborepo/tests/run_caching.rs index 34d9554b6e4dd..26716ee37523f 100644 --- a/crates/turborepo/tests/run_caching.rs +++ b/crates/turborepo/tests/run_caching.rs @@ -301,6 +301,72 @@ fn test_jit_inputs_hash_after_dependencies_complete() { assert!(stdout.co...
true
vercel/turborepo
13,043
issue_to_patch
feat: Add JIT task input hashing
## Why Tasks that consume generated files can currently hash inputs before their dependencies create or restore those files. That can require an extra run before cache behavior stabilizes. ## What Adds pre-release `$` task inputs that defer selected file hashing until after `dependsOn` tasks complete, then use the...
1e6516ef727f146b6cb6445998d3046a39ab9a59
85a1455508b627659a3a8f2f85be2ac290e3260a
diff --git a/apps/docs/content/docs/reference/configuration.mdx b/apps/docs/content/docs/reference/configuration.mdx index 3203b8abdf15b..0cbf7916d7de4 100644 --- a/apps/docs/content/docs/reference/configuration.mdx +++ b/apps/docs/content/docs/reference/configuration.mdx @@ -197,7 +197,6 @@ Accepts a human-readable du...
[ "apps/docs/content/docs/reference/configuration.mdx", "crates/turborepo-engine/src/affected.rs", "crates/turborepo-engine/src/task_definition.rs", "crates/turborepo-lib/src/run/mod.rs", "crates/turborepo-lib/src/run/task_filter.rs", "crates/turborepo-lib/src/task_graph/visitor/mod.rs", "crates/turborepo...
[]
diff --git a/crates/turborepo/tests/run_caching.rs b/crates/turborepo/tests/run_caching.rs index f577ada0322ef..34d9554b6e4dd 100644 --- a/crates/turborepo/tests/run_caching.rs +++ b/crates/turborepo/tests/run_caching.rs @@ -221,6 +221,86 @@ fn test_excluded_inputs() { assert!(stdout.contains("FULL TURBO")); } ...
true
vercel/turborepo
13,040
issue_to_patch
fix: Bypass npm command shim on Windows
## Why Addresses a follow-up in #12651. Windows npm installs expose `npm.cmd`, which runs through `cmd.exe`. When Turbo sends Ctrl+C for graceful shutdown, that batch layer can emit `Terminate batch job (Y/N)?` even though the underlying Node task is shutting down correctly. ## What For Windows npm task exe...
1745bedc0f1ce4267edb840b100e48530e0c2ff2
f142b2c342ccbbc47e167b5405d95e4c8819cdce
diff --git a/crates/turborepo-task-executor/src/command.rs b/crates/turborepo-task-executor/src/command.rs index 0b7b09e1f5ed5..e69af82e51089 100644 --- a/crates/turborepo-task-executor/src/command.rs +++ b/crates/turborepo-task-executor/src/command.rs @@ -3,7 +3,11 @@ //! This module provides the trait and factory fo...
[ "crates/turborepo-task-executor/src/command.rs" ]
[]
true
vercel/turborepo
13,039
issue_to_patch
docs: Remove ESM warning from gen page
### Description These have worked for awhile now.
d5bd26c1e3ac030be4632d9d748d9b09c5581862
4235c7db613002137577232f14c54c1125e2aada
diff --git a/apps/docs/content/docs/guides/generating-code.mdx b/apps/docs/content/docs/guides/generating-code.mdx index 189a1a4a1fc45..72596088bc0ae 100644 --- a/apps/docs/content/docs/guides/generating-code.mdx +++ b/apps/docs/content/docs/guides/generating-code.mdx @@ -67,10 +67,6 @@ generators within a repo configu...
[ "apps/docs/content/docs/guides/generating-code.mdx" ]
[]
true
vercel/turborepo
13,038
issue_to_patch
release(turborepo): 2.9.17-canary.5
## Release v2.9.17-canary.5 > [!CAUTION] > Versioned docs aliasing FAILED. [View logs](https://github.com/vercel/turborepo/actions/runs/27105622737) ### Changes - release(turborepo): 2.9.17-canary.4 (#13032) (`0881aa4`) - fix: Preserve pnpm override-resolved prune deps (#13031) (`8c61dd1`) - fix: Keep PTY stdin open...
40844e9244cb06f0d5c2609a35d40e357a5a072c
93f2a50b3c8291dc7abb713d54df7d525208de18
diff --git a/packages/create-turbo/package.json b/packages/create-turbo/package.json index 2fc921b133bb3..40e9e21d2ce1e 100644 --- a/packages/create-turbo/package.json +++ b/packages/create-turbo/package.json @@ -1,6 +1,6 @@ { "name": "create-turbo", - "version": "2.9.17-canary.4", + "version": "2.9.17-canary.5",...
[ "packages/create-turbo/package.json", "packages/eslint-config-turbo/package.json", "packages/eslint-plugin-turbo/package.json", "packages/turbo-codemod/package.json", "packages/turbo-gen/package.json", "packages/turbo-ignore/package.json", "packages/turbo-types/package.json", "packages/turbo-workspace...
[]
true
vercel/turborepo
13,037
issue_to_patch
chore: Restore aarch64 musl release builds
## Why The release workflow is failing for the aarch64 musl binary after adding aws-lc-rs for P-521 certificate verification. The new C objects reference glibc C23 symbol names, but the final binary is statically linked against musl. ## What Teach the aarch64 musl release and LSP Rust builds to alias the glibc C23 s...
03359d9d539d0e67814781444be496df3e6de61e
894ce36e201ded9c00f7831c067bbd7ec1b2db0c
diff --git a/.github/workflows/lsp.yml b/.github/workflows/lsp.yml index 4e4f6207d9508..d58f81b6ce46f 100644 --- a/.github/workflows/lsp.yml +++ b/.github/workflows/lsp.yml @@ -58,7 +58,9 @@ jobs: setup: "sudo apt-get install -y build-essential" - host: ubuntu-latest target: "aarch6...
[ ".github/workflows/lsp.yml", ".github/workflows/turborepo-release.yml" ]
[]
true
vercel/turborepo
13,036
issue_to_patch
turbo rustls http client rejects p-521 ecdsa issuer certificates signed with sha-256 ### Verify canary release - [x] I verified that the issue exists in the latest Turborepo canary release. ### Link to code that reproduces this issue https://github.com/vaishnav-mk/turbo-rustls-p521-repro ### Which canary version w...
fix(api-client): Support P-521 ECDSA certificate chains over rustls
## What Fixes #13035. turbo's rustls remote-cache HTTP client rejects any TLS certificate chain containing a **P-521 (`secp521r1`) ECDSA** issuer, failing during connection setup with: ``` InvalidCertificate(UnsupportedSignatureAlgorithmForPublicKeyContext { signature_algorithm_id: [6, 8, 42, 134, 72, 206, 61, 4, ...
08a42f26ed6b1a081c4c5229a1e0cec37ebc1c48
911a4c7729b7e6a79cb16ec1643087b654970837
diff --git a/Cargo.lock b/Cargo.lock index 1d2736f3ca2b5..609fcded11deb 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -369,6 +369,28 @@ version = "1.1.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "d468802bab17cbc0cc575e9b053f41e72aa36bfa6b7f55e3529ffa43161b97fa" +[[package]] +name = ...
[ "Cargo.lock", "crates/turborepo-api-client/Cargo.toml", "crates/turborepo-api-client/src/lib.rs", "crates/turborepo-api-client/src/tls.rs" ]
[]
true
vercel/turborepo
13,034
issue_to_patch
Lack of whitespace after the TUI task output left border causes "stuck pipe character" in links opened from VSCode Terminal ### Verify canary release - [x] I verified that the issue exists in the latest Turborepo canary release. ### Link to code that reproduces this issue - Repository: [paulpe-rr/bug-repro-turbor...
fix: Add TUI pane padding before logs
## Why Fixes https://github.com/vercel/turborepo/issues/12791. VS Code's terminal local link detector can include the TUI task-list border in file links when task output starts immediately after the border, producing targets like `│apps/app-a/repro.js:2`. That target doesn't resolve, so clicking file links in TUI...
fb28d8a0429613b468cf369b74c77d9aead9aa80
5dcf6109f61222279f8a17a56da22b561f47169d
diff --git a/crates/turborepo-ui/src/tui/app.rs b/crates/turborepo-ui/src/tui/app.rs index d6f9dc97a3032..303706c2c75c6 100644 --- a/crates/turborepo-ui/src/tui/app.rs +++ b/crates/turborepo-ui/src/tui/app.rs @@ -659,19 +659,23 @@ impl<W> App<W> { pub fn handle_mouse(&mut self, mut event: crossterm::event::Mouse...
[ "crates/turborepo-ui/src/tui/app.rs", "crates/turborepo-ui/src/tui/mod.rs", "crates/turborepo-ui/src/tui/pane.rs", "crates/turborepo-ui/src/tui/size.rs" ]
[]
true
vercel/turborepo
13,033
issue_to_patch
astro build fails with turbo, but not pnpm/bun ### Verify canary release - [x] I verified that the issue exists in the latest Turborepo canary release. ### Link to code that reproduces this issue https://github.com/jahands/turbo-astro-bug ### Which canary version will you have in your reproduction? 2.9.17-canary....
fix: Keep PTY stdin open for tasks
## Why Closes #13021 When Turbo runs tasks in a terminal, it attaches task output to a PTY. For non-interactive tasks, Turbo closed the PTY stdin side immediately. Some tools interpret PTY stdin EOF as the terminal/session ending, which can prematurely shut down internal servers used during a build. This caused A...
8c61dd175febc509f848a3740bc0609bda9a4f7a
828b37d76616c4a14c267bac400c8738427c762d
diff --git a/crates/turborepo-process/src/child/test.rs b/crates/turborepo-process/src/child/test.rs index f975aff8fc76a..65d6b9426638f 100644 --- a/crates/turborepo-process/src/child/test.rs +++ b/crates/turborepo-process/src/child/test.rs @@ -941,6 +941,39 @@ async fn test_held_stdin_keeps_persistent_child_alive() { ...
[ "crates/turborepo-process/src/child/test.rs", "crates/turborepo-task-executor/src/exec.rs" ]
[]
true
vercel/turborepo
13,031
issue_to_patch
`turbo prune --docker` drops pnpm v9 lockfile nodes required by overrides and exact-version peer specs — pruned lockfile fails `pnpm install --frozen-lockfile` ### Verify canary release - [x] I verified that the issue exists in the latest Turborepo canary release — reproduced on `2.9.10`, `2.9.16`, and `2.9.17-canary...
fix: Preserve pnpm override-resolved prune deps
## Why pnpm 11 frozen installs can reject `turbo prune --docker` output when pnpm rewrites importer specifiers because of workspace overrides. The pruned lockfile kept the importer entries but dropped their package nodes, producing missing dependency errors. The same reproduction also covers pruned workspace patch c...
40e3e2b50feb10a81195ae30e638ff45bc654593
8ba4ff1e785421eccf65262663e4f7da0e4aad1e
diff --git a/crates/turborepo-lockfiles/src/pnpm/data.rs b/crates/turborepo-lockfiles/src/pnpm/data.rs index 27116361dbd47..09d401654c9d2 100644 --- a/crates/turborepo-lockfiles/src/pnpm/data.rs +++ b/crates/turborepo-lockfiles/src/pnpm/data.rs @@ -464,6 +464,12 @@ impl PnpmLockfile { if resolved_specifier =...
[ "crates/turborepo-lockfiles/src/pnpm/data.rs", "lockfile-tests/fixtures/pnpm-11-flat-patch/meta.json", "lockfile-tests/fixtures/pnpm-11-flat-patch/packages/b/package.json", "lockfile-tests/fixtures/pnpm-11-flat-patch/pnpm-lock.yaml", "lockfile-tests/fixtures/pnpm-override-and-patches/apps/web-inrange/packag...
[]
true
vercel/turborepo
13,032
issue_to_patch
release(turborepo): 2.9.17-canary.4
## Release v2.9.17-canary.4 > [!CAUTION] > Versioned docs aliasing FAILED. [View logs](https://github.com/vercel/turborepo/actions/runs/27041297146) ### Changes - docs: Exclude Next dev output from cache examples (#13019) (`25349a4`) - release(turborepo): 2.9.17-canary.3 (#13017) (`cb93407`) - fix: Highlight active ...
40e3e2b50feb10a81195ae30e638ff45bc654593
679e7f8eee555f1ccd6c56c0f0905df0431ff16e
diff --git a/packages/create-turbo/package.json b/packages/create-turbo/package.json index 81767f2ca4d0a..2fc921b133bb3 100644 --- a/packages/create-turbo/package.json +++ b/packages/create-turbo/package.json @@ -1,6 +1,6 @@ { "name": "create-turbo", - "version": "2.9.17-canary.3", + "version": "2.9.17-canary.4",...
[ "packages/create-turbo/package.json", "packages/eslint-config-turbo/package.json", "packages/eslint-plugin-turbo/package.json", "packages/turbo-codemod/package.json", "packages/turbo-gen/package.json", "packages/turbo-ignore/package.json", "packages/turbo-types/package.json", "packages/turbo-workspace...
[]
true
vercel/turborepo
13,025
issue_to_patch
fix: Ignore peer dependencies in package graph
## Why Turborepo should not treat `peerDependencies` as package graph inputs. Peers are supplied by consumers and should not create workspace build-order edges, participate in cycle detection, or influence package graph external dependency metadata. This fixes a regression where pure peer back-edges could make otherw...
4e88ddd22728317d3828bd21a1b1fad4bb2d5b99
13234e37a019b98be2e599bced1ea4b1a005252e
diff --git a/crates/turborepo-lib/src/commands/prune.rs b/crates/turborepo-lib/src/commands/prune.rs index e8899291a04d7..e84d5f8a17fca 100644 --- a/crates/turborepo-lib/src/commands/prune.rs +++ b/crates/turborepo-lib/src/commands/prune.rs @@ -1,7 +1,7 @@ #[cfg(unix)] use std::os::unix::fs::PermissionsExt; use std:...
[ "crates/turborepo-lib/src/commands/prune.rs", "crates/turborepo-repository/src/package_graph/builder.rs", "crates/turborepo-repository/src/package_json.rs" ]
[ { "comment": "`turbo prune` omits workspaces referenced only via `peerDependencies` because dropping internal peer edges in `Dependencies::new` also removes them from the prune transitive\\-closure\\, producing a pruned monorepo whose `package.json` references a missing workspace\\.\n\n<!-- VADE-CATEGORY: logic...
true
vercel/turborepo
13,025
comment_to_fix
fix: Ignore peer dependencies in package graph
`turbo prune` omits workspaces referenced only via `peerDependencies` because dropping internal peer edges in `Dependencies::new` also removes them from the prune transitive\-closure\, producing a pruned monorepo whose `package.json` references a missing workspace\. <!-- VADE-CATEGORY: logic --> <!-- VADE-GITHUB-SUGGE...
4e88ddd22728317d3828bd21a1b1fad4bb2d5b99
13234e37a019b98be2e599bced1ea4b1a005252e
diff --git a/crates/turborepo-repository/src/package_graph/builder.rs b/crates/turborepo-repository/src/package_graph/builder.rs index ae71cb230c5d9..5ee780d57df5b 100644 --- a/crates/turborepo-repository/src/package_graph/builder.rs +++ b/crates/turborepo-repository/src/package_graph/builder.rs @@ -17,7 +17,7 @@ use c...
[ "crates/turborepo-repository/src/package_graph/builder.rs" ]
[ { "comment": "`turbo prune` omits workspaces referenced only via `peerDependencies` because dropping internal peer edges in `Dependencies::new` also removes them from the prune transitive\\-closure\\, producing a pruned monorepo whose `package.json` references a missing workspace\\.\n\n<!-- VADE-CATEGORY: logic...
true
vercel/turborepo
13,023
issue_to_patch
fix: Highlight active docs sidebar item
## Why Docs sidebar entries were not showing the active page state because the custom sidebar renderer did not pass Fumadocs' active state into the sidebar primitives. ## What Restores active-page highlighting for docs sidebar items and folder index links. ## How Computes active state from the current pathname and...
cb93407f557c30388ac73649e28e1c3fe57d8057
1f14306ec0eeea5feaabdfbb2df0faeff68da572
diff --git a/apps/docs/components/geistdocs/sidebar.tsx b/apps/docs/components/geistdocs/sidebar.tsx index a8a86f98a11be..6db7eb27f90b0 100644 --- a/apps/docs/components/geistdocs/sidebar.tsx +++ b/apps/docs/components/geistdocs/sidebar.tsx @@ -17,6 +17,7 @@ import { SidebarSeparator } from "fumadocs-ui/components/...
[ "apps/docs/components/geistdocs/sidebar.tsx" ]
[]
true
vercel/turborepo
13,010
issue_to_patch
Fix typo in .gitignore comment
c1cf87a8b6a4a8b9473ef8e206bcbbd726b0b080
0df074913834accd4a23a10d9be42cb34ee60f60
diff --git a/examples/basic/apps/web/.gitignore b/examples/basic/apps/web/.gitignore index f886745c52166..ce1f6254ae97d 100644 --- a/examples/basic/apps/web/.gitignore +++ b/examples/basic/apps/web/.gitignore @@ -25,7 +25,7 @@ npm-debug.log* yarn-debug.log* yarn-error.log* -# env files (can opt-in for commiting if ...
[ "examples/basic/apps/web/.gitignore" ]
[]
true
vercel/turborepo
13,017
issue_to_patch
release(turborepo): 2.9.17-canary.3
## Release v2.9.17-canary.3 > [!CAUTION] > Versioned docs aliasing FAILED. [View logs](https://github.com/vercel/turborepo/actions/runs/26888263514) ### Changes - release(turborepo): 2.9.17-canary.2 (#12980) (`14720cc`) - test: Skip installs for JSON output fixtures (#12981) (`882c19f`) - feat: Add Rsbuild examples ...
4db438633b3bc0b445c20f25642270b30a410316
e818013d77e2597ed10ad09a1cf2ddb137528a27
diff --git a/packages/create-turbo/package.json b/packages/create-turbo/package.json index 07acdb6755849..81767f2ca4d0a 100644 --- a/packages/create-turbo/package.json +++ b/packages/create-turbo/package.json @@ -1,6 +1,6 @@ { "name": "create-turbo", - "version": "2.9.17-canary.2", + "version": "2.9.17-canary.3",...
[ "packages/create-turbo/package.json", "packages/eslint-config-turbo/package.json", "packages/eslint-plugin-turbo/package.json", "packages/turbo-codemod/package.json", "packages/turbo-gen/package.json", "packages/turbo-ignore/package.json", "packages/turbo-types/package.json", "packages/turbo-workspace...
[]
true
vercel/turborepo
13,019
issue_to_patch
📚 Docs: example for nextjs build task includes dev server ### What is the improvement or update you wish to see? [This example](https://turborepo.dev/docs/crafting-your-repository/configuring-tasks#specifying-outputs) for specifying outputs in a task includes the `.next/dev` folder ### Is there any context that mig...
docs: Exclude Next.js dev server output from cache examples
## Why Next.js writes development server output to `.next/dev`, which can unnecessarily inflate Turborepo cache artifacts when examples cache `.next/**`. Excluding it keeps current Next.js output recommendations aligned with Next.js behavior and fixes #13018. ## What Adds `!.next/dev/**` to current Next.js `outputs`...
4db438633b3bc0b445c20f25642270b30a410316
2c6873fa7d7fb09d05d5bf124b9f958596261342
diff --git a/apps/docs/content/docs/crafting-your-repository/configuring-tasks.mdx b/apps/docs/content/docs/crafting-your-repository/configuring-tasks.mdx index 6c74ca3bd3828..2aafa60c56472 100644 --- a/apps/docs/content/docs/crafting-your-repository/configuring-tasks.mdx +++ b/apps/docs/content/docs/crafting-your-repo...
[ "apps/docs/content/docs/crafting-your-repository/configuring-tasks.mdx", "apps/docs/content/docs/crafting-your-repository/creating-an-internal-package.mdx", "apps/docs/content/docs/getting-started/add-to-existing-repository.mdx", "apps/docs/content/docs/guides/ci-vendors/buildkite.mdx", "apps/docs/content/d...
[]
true
vercel/turborepo
13,016
issue_to_patch
turbo prune with certain deps fails to install on bun ### Verify canary release - [x] I verified that the issue exists in the latest Turborepo canary release. ### Link to code that reproduces this issue https://github.com/JRoy/turbo-repro ### Which canary version will you have in your reproduction? 2.9.16 ### En...
fix: Preserve Bun nested dependency versions
## Why Bun can require a nested package entry even when a top-level package with the same name exists. If the top-level version does not satisfy the dependency range, turbo prune --docker can emit a pruned bun.lock that Bun rewrites, causing bun install --frozen-lockfile to fail. Fixes #13003. ## What Prese...
f4f0abdd97282bdfe849258268ce6675e796956c
123a642c1d9a7788dd429d2155fa103dc31326b2
diff --git a/crates/turborepo-lockfiles/src/bun/resolve.rs b/crates/turborepo-lockfiles/src/bun/resolve.rs index e140c7cf24387..238a9dd82ad23 100644 --- a/crates/turborepo-lockfiles/src/bun/resolve.rs +++ b/crates/turborepo-lockfiles/src/bun/resolve.rs @@ -50,7 +50,7 @@ impl BunLockfile { /// /// Returns true...
[ "crates/turborepo-lockfiles/src/bun/resolve.rs", "crates/turborepo-lockfiles/src/bun/subgraph.rs", "lockfile-tests/fixtures/bun-v1-issue-13003/apps/app-a/package.json", "lockfile-tests/fixtures/bun-v1-issue-13003/apps/app-target/package.json", "lockfile-tests/fixtures/bun-v1-issue-13003/bun.lock", "lockfi...
[]
true
vercel/turborepo
13,012
issue_to_patch
refactor: Split Bun lockfile module
## Why The Bun lockfile implementation was one of the largest Rust files in the repo. Splitting it into cohesive modules makes the lockfile code easier to review and easier to load into focused context windows without changing behavior. ## What Moves Bun lockfile data types, parsing, lockfile trait behavior, emissio...
c1cf87a8b6a4a8b9473ef8e206bcbbd726b0b080
af505ae5aa1a3a7401e1016f61c42b5149f9086f
diff --git a/crates/turborepo-lockfiles/src/bun/data.rs b/crates/turborepo-lockfiles/src/bun/data.rs new file mode 100644 index 0000000000000..bfc85f0660196 --- /dev/null +++ b/crates/turborepo-lockfiles/src/bun/data.rs @@ -0,0 +1,273 @@ +use std::collections::HashMap; + +use serde::{Deserialize, Deserializer, Serializ...
[ "crates/turborepo-lockfiles/src/bun/data.rs", "crates/turborepo-lockfiles/src/bun/emit.rs", "crates/turborepo-lockfiles/src/bun/global_change.rs", "crates/turborepo-lockfiles/src/bun/lockfile.rs", "crates/turborepo-lockfiles/src/bun/mod.rs", "crates/turborepo-lockfiles/src/bun/parse.rs", "crates/turbore...
[]
true
vercel/turborepo
13,013
issue_to_patch
refactor: Split CLI module
## Why The CLI module had grown large enough to make command parsing and execution flow hard to review in one file. Splitting type definitions and tests away from the runtime flow keeps the entrypoint focused. ## What Moves clap argument and command type definitions into `cli/args.rs`, moves CLI tests into `cli/test...
c1cf87a8b6a4a8b9473ef8e206bcbbd726b0b080
5de3b6d8c34a9f829a642d86aaabf9029f2be64a
diff --git a/crates/turborepo-lib/src/cli/args.rs b/crates/turborepo-lib/src/cli/args.rs new file mode 100644 index 0000000000000..7aac41c1ef264 --- /dev/null +++ b/crates/turborepo-lib/src/cli/args.rs @@ -0,0 +1,1220 @@ +use std::{env, ffi::OsString, fmt}; + +use camino::{Utf8Path, Utf8PathBuf}; +use clap::{ArgAction,...
[ "crates/turborepo-lib/src/cli/args.rs", "crates/turborepo-lib/src/cli/mod.rs", "crates/turborepo-lib/src/cli/test.rs" ]
[]
true
vercel/turborepo
13,014
issue_to_patch
refactor: Split process child module
## Why The process child module mixed public process management, platform-specific handle internals, IO, shutdown semantics, and tests in one large file. Splitting those responsibilities reduces context needed to review future process changes. ## What Moves child handle internals, IO helpers, shutdown types and proc...
c1cf87a8b6a4a8b9473ef8e206bcbbd726b0b080
020b00173e42f219083835233fcee12097fdd805
diff --git a/crates/turborepo-process/src/child.rs b/crates/turborepo-process/src/child.rs index 41cb057865720..9eb51c3f19fd5 100644 --- a/crates/turborepo-process/src/child.rs +++ b/crates/turborepo-process/src/child.rs @@ -15,2987 +15,234 @@ //! running these processes to completion, forwarding signals, and closing ...
[ "crates/turborepo-process/src/child.rs", "crates/turborepo-process/src/child/handle.rs", "crates/turborepo-process/src/child/io.rs", "crates/turborepo-process/src/child/shutdown.rs", "crates/turborepo-process/src/child/state.rs", "crates/turborepo-process/src/child/test.rs", "crates/turborepo-process/sr...
[]
diff --git a/crates/turborepo-process/src/child/test_guard.rs b/crates/turborepo-process/src/child/test_guard.rs new file mode 100644 index 0000000000000..37135792a7aaf --- /dev/null +++ b/crates/turborepo-process/src/child/test_guard.rs @@ -0,0 +1,80 @@ +use std::{ + io, + sync::atomic::{AtomicBool, Ordering}, +...
true
vesoft-inc/nebula
6,152
issue_to_patch
fix #6150: A deadlock risk when space creation happens concurrently with leader balance in NebulaGraph
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [x] bug - [ ] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: Issue(s) number: https://github.com/vesoft-in...
c1d657d3811892b716e2bbb76f86690186129335
eac6eb3144a2840edfc33556922bc20ca7fc836b
diff --git a/src/kvstore/NebulaStore.cpp b/src/kvstore/NebulaStore.cpp index 5fc947b9ac8..09f33db965c 100644 --- a/src/kvstore/NebulaStore.cpp +++ b/src/kvstore/NebulaStore.cpp @@ -354,27 +354,32 @@ void NebulaStore::stop() { folly::Future<std::pair<GraphSpaceID, std::unique_ptr<KVEngine>>> NebulaStore::newEngineAsync...
[ "src/kvstore/NebulaStore.cpp", "src/kvstore/NebulaStore.h" ]
[]
true
vesoft-inc/nebula
6,128
issue_to_patch
fix relational expression rewriting
5d43e44b43ae5239400897f664e68b034a0d46e5
ed9fcc4a343c0e58a74e9061a64fc37c274d4a21
diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 901cb9b572d..e944d415c4a 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -19,7 +19,16 @@ jobs: lint: name: lint if: ${{ contains(github.event.pull_request.labels.*.name, 'r...
[ ".github/workflows/pull_request.yml", "src/graph/util/ExpressionUtils.cpp", "src/graph/util/ExpressionUtils.h", "src/graph/util/test/ExpressionUtilsTest.cpp" ]
[]
diff --git a/src/graph/util/test/ExpressionUtilsTest.cpp b/src/graph/util/test/ExpressionUtilsTest.cpp index e376c48e9de..fd7fc8afd5a 100644 --- a/src/graph/util/test/ExpressionUtilsTest.cpp +++ b/src/graph/util/test/ExpressionUtilsTest.cpp @@ -827,5 +827,62 @@ TEST_F(ExpressionUtilsTest, simplifyLogicalExpr) { } }...
true
vesoft-inc/nebula
4,804
issue_to_patch
Support user-defined functions https://github.com/vesoft-inc/nebula/discussions/4793
UDF based on existing function infra
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [ ] bug - [x] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: https://github.com/vesoft-inc/nebula/discussi...
a6d31b30e53e81cd4524b71c5d6aae320a682263
2df15591a6021a60f2cb65dfa438d923c859cc60
diff --git a/conf/nebula-graphd.conf.default b/conf/nebula-graphd.conf.default index a528daa5195..c937b665ac6 100644 --- a/conf/nebula-graphd.conf.default +++ b/conf/nebula-graphd.conf.default @@ -97,6 +97,12 @@ # if use balance data feature, only work if enable_experimental_feature is true --enable_data_balance=true...
[ "conf/nebula-graphd.conf.default", "src/common/function/CMakeLists.txt", "src/common/function/FunctionManager.cpp", "src/common/function/FunctionManager.h", "src/common/function/FunctionUdfManager.cpp", "src/common/function/FunctionUdfManager.h", "src/common/function/GraphFunction.h", "src/graph/servi...
[]
true
vesoft-inc/nebula
4,444
issue_to_patch
Could report error even if there is no task
## What type of PR is this? - [X] bug - [ ] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: #### Description: Follow up of #4442, if a job failed before generating job, the job error code will be SUCCEEDED, but status is FAILED, which is weird. For example, download fr...
9ef861a916c862d6ec156c8a085574b691966a1f
fe932f512bcdbbded9fc92ca2acbe6e327df8cc7
diff --git a/src/meta/processors/job/BalanceJobExecutor.cpp b/src/meta/processors/job/BalanceJobExecutor.cpp index 331541a01bb..bba41615d32 100644 --- a/src/meta/processors/job/BalanceJobExecutor.cpp +++ b/src/meta/processors/job/BalanceJobExecutor.cpp @@ -19,8 +19,8 @@ BalanceJobExecutor::BalanceJobExecutor(GraphSpace...
[ "src/meta/processors/job/BalanceJobExecutor.cpp", "src/meta/processors/job/BalanceJobExecutor.h", "src/meta/processors/job/DownloadJobExecutor.cpp", "src/meta/processors/job/DownloadJobExecutor.h", "src/meta/processors/job/IngestJobExecutor.cpp", "src/meta/processors/job/IngestJobExecutor.h", "src/meta/...
[]
diff --git a/src/meta/test/GetStatsTest.cpp b/src/meta/test/GetStatsTest.cpp index d1b00497ff1..59bfdc1ebab 100644 --- a/src/meta/test/GetStatsTest.cpp +++ b/src/meta/test/GetStatsTest.cpp @@ -187,7 +187,7 @@ TEST_F(GetStatsTest, StatsJob) { // Update stats data to finished or failed status in finish function of ...
true
vesoft-inc/nebula
5,751
issue_to_patch
fix noloop path limit
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [x] bug - [ ] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: close https://github.com/vesoft-inc/nebula-en...
38b3e9d88e527b53fe9677013777957af0500088
cd566115f6e7bf8d8f4eb8f50dbd3165f83d47d4
diff --git a/src/graph/executor/algo/AllPathsExecutor.cpp b/src/graph/executor/algo/AllPathsExecutor.cpp index 0dd2cfba7ff..d5f1f9d5439 100644 --- a/src/graph/executor/algo/AllPathsExecutor.cpp +++ b/src/graph/executor/algo/AllPathsExecutor.cpp @@ -273,6 +273,12 @@ folly::Future<Status> AllPathsExecutor::buildPathMulti...
[ "src/graph/executor/algo/AllPathsExecutor.cpp", "src/parser/scanner.lex", "tests/tck/features/path/AllPath.IntVid.feature", "tests/tck/features/path/AllPath.feature" ]
[]
diff --git a/tests/tck/features/path/AllPath.IntVid.feature b/tests/tck/features/path/AllPath.IntVid.feature index 18ac5bc4d1c..4787c7b802b 100644 --- a/tests/tck/features/path/AllPath.IntVid.feature +++ b/tests/tck/features/path/AllPath.IntVid.feature @@ -125,6 +125,16 @@ Feature: Integer Vid All Path | <("Tony...
true
vesoft-inc/nebula
4,283
issue_to_patch
Move input rows of Join based on lifetime analysis **Introduction** <!-- concise introduction to problem, motivation, and overview of proposed solution --> In current hash Join implementation, we have probe row and hash row(in hash table), probe row only probe once in the whole executing, so we could move it to resu...
Move probe rows of Join.
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [ ] bug - [ ] feature - [x] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: Close #4186 #### Description: ## How...
2b35538eb7a17635420bfe27257607ec84690159
bda279758690e6cef82955da38af8c571ba88d20
diff --git a/src/graph/executor/Executor.h b/src/graph/executor/Executor.h index a2ba45888ac..04c71db40b6 100644 --- a/src/graph/executor/Executor.h +++ b/src/graph/executor/Executor.h @@ -97,6 +97,9 @@ class Executor : private boost::noncopyable, private cpp::NonMovable { // Check whether the variable is movable, i...
[ "src/graph/executor/Executor.h", "src/graph/executor/query/InnerJoinExecutor.cpp", "src/graph/executor/query/InnerJoinExecutor.h", "src/graph/executor/query/JoinExecutor.cpp", "src/graph/executor/query/JoinExecutor.h", "src/graph/executor/query/LeftJoinExecutor.cpp", "src/graph/executor/query/LeftJoinEx...
[]
true
vesoft-inc/nebula
5,619
issue_to_patch
fix traverse build path memory tracker
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [x] bug - [ ] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: https://github.com/vesoft-inc/nebula/issues/5...
c113ffaf78c697a07035f59547c588817b1d6680
e6957fb4767db3f98f939cfa74c1f8bbb2b9742c
diff --git a/src/graph/executor/query/TraverseExecutor.cpp b/src/graph/executor/query/TraverseExecutor.cpp index 723e7f7988c..95ad17e27ed 100644 --- a/src/graph/executor/query/TraverseExecutor.cpp +++ b/src/graph/executor/query/TraverseExecutor.cpp @@ -478,6 +478,7 @@ folly::Future<Status> TraverseExecutor::buildPathMu...
[ "src/graph/executor/query/TraverseExecutor.cpp" ]
[]
true
vesoft-inc/nebula
4,893
issue_to_patch
fix Nan & Infinity comparison And Value's operator/ & operator%
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [x] bug - [ ] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: #4894 #### Description: ## How do ...
aaa0431798f3535856cb1b5a6ed43276e81e759d
2f5f1ede75045c4b96ee755baddfdc3147398e3f
diff --git a/src/common/datatypes/Value.cpp b/src/common/datatypes/Value.cpp index 916f7847c91..7de3ece5103 100644 --- a/src/common/datatypes/Value.cpp +++ b/src/common/datatypes/Value.cpp @@ -2487,12 +2487,7 @@ Value operator/(const Value& lhs, const Value& rhs) { return lVal / denom; } ca...
[ "src/common/datatypes/Value.cpp", "src/common/datatypes/Value.h", "src/common/datatypes/test/ValueTest.cpp", "src/common/expression/RelationalExpression.cpp", "src/common/expression/test/ArithmeticExpressionTest.cpp", "src/common/expression/test/TestBase.h", "src/common/function/FunctionManager.cpp", ...
[]
diff --git a/src/common/datatypes/test/ValueTest.cpp b/src/common/datatypes/test/ValueTest.cpp index e04ae18564a..73abce84640 100644 --- a/src/common/datatypes/test/ValueTest.cpp +++ b/src/common/datatypes/test/ValueTest.cpp @@ -6,6 +6,8 @@ #include <robin_hood.h> #include <thrift/lib/cpp2/protocol/Serializer.h> +#...
true
vesoft-inc/nebula
4,471
issue_to_patch
fix wrong image path for architecture
the original image path "https://github.com/vesoft-inc/nebula-docs/raw/master/images/Nebula%20Arch.png" is outdated and cannot be loaded by browsers. https://github.com/vesoft-inc/nebula/blob/master/README-CN.md <img width="811" alt="image" src="https://user-images.githubusercontent.com/5738175/181442923-2a99ac00-d39...
21ee515dc370dcf8b9cf64e61f87ccca47757015
54f08a986d417917ebf735e2fa67a9ba5cc98985
diff --git a/README-CN.md b/README-CN.md index 7c7d1061d1b..815ab7ef649 100644 --- a/README-CN.md +++ b/README-CN.md @@ -77,7 +77,7 @@ Nebula Graph 1.x 后续不再进行功能的更新，请升级到2.0版本中。 ## Nebula Graph 产品架构图 -![image](https://github.com/vesoft-inc/nebula-docs/raw/master/images/Nebula%20Arch.png) +![image](https://docs-cdn.n...
[ "README-CN.md" ]
[]
true
vesoft-inc/nebula
2,779
issue_to_patch
format fetchedges
1、refactor fetch edges 2、support FETCH PROP ON edgeName "A"->"B" YIELD edge AS e, src(edge), dst(edge), rank(edge), type(edge)
7239e5ff63222608ad27f4451d7f55df52c61f39
619005b30e8f5110e3a5f6d245e7c922224e4bd4
diff --git a/src/graph/context/ast/QueryAstContext.h b/src/graph/context/ast/QueryAstContext.h index bae72322b7e..6215d0da783 100644 --- a/src/graph/context/ast/QueryAstContext.h +++ b/src/graph/context/ast/QueryAstContext.h @@ -141,6 +141,20 @@ struct FetchVerticesContext final : public AstContext { std::string inp...
[ "src/graph/context/ast/QueryAstContext.h", "src/graph/planner/CMakeLists.txt", "src/graph/planner/PlannersRegister.cpp", "src/graph/planner/ngql/FetchEdgesPlanner.cpp", "src/graph/planner/ngql/FetchEdgesPlanner.h", "src/graph/validator/FetchEdgesValidator.cpp", "src/graph/validator/FetchEdgesValidator.h...
[ { "comment": "Why add this?", "path": "tests/tck/features/delete/DeleteTag.IntVid.feature", "hunk": "@@ -2,6 +2,7 @@\n #\n # This source code is licensed under Apache 2.0 License,\n # attached with Common Clause Condition 1.0, found in the LICENSES directory.\n+@jmq", "resolving_sha": "619005b30e8f5...
diff --git a/src/graph/validator/test/FetchEdgesTest.cpp b/src/graph/validator/test/FetchEdgesTest.cpp index 136f07b941e..f1140206540 100644 --- a/src/graph/validator/test/FetchEdgesTest.cpp +++ b/src/graph/validator/test/FetchEdgesTest.cpp @@ -21,10 +21,10 @@ class FetchEdgesValidatorTest : public ValidatorTestBase { ...
true
vesoft-inc/nebula
2,779
comment_to_fix
format fetchedges
Don't modify the origin case if it's compatible.
7239e5ff63222608ad27f4451d7f55df52c61f39
619005b30e8f5110e3a5f6d245e7c922224e4bd4
diff --git a/tests/tck/features/fetch/FetchEdges.intVid.feature b/tests/tck/features/fetch/FetchEdges.intVid.feature index 35739a185cc..e4b6723291c 100644 --- a/tests/tck/features/fetch/FetchEdges.intVid.feature +++ b/tests/tck/features/fetch/FetchEdges.intVid.feature @@ -71,8 +71,8 @@ Feature: Fetch Int Vid Edges S...
[ "tests/tck/features/fetch/FetchEdges.intVid.feature" ]
[ { "comment": "Don't modify the origin case if it's compatible.", "path": "tests/tck/features/fetch/FetchEdges.intVid.feature", "hunk": "@@ -22,17 +22,17 @@ Feature: Fetch Int Vid Edges\n # Fetch prop on an edge without yield\n When executing query:\n \"\"\"\n- FETCH PROP ON serve hash...
true
vesoft-inc/nebula
2,779
comment_to_fix
format fetchedges
Could we yield `properties(edge) as props` in fetch clause?
7239e5ff63222608ad27f4451d7f55df52c61f39
619005b30e8f5110e3a5f6d245e7c922224e4bd4
diff --git a/tests/tck/features/fetch/FetchEdges.strVid.feature b/tests/tck/features/fetch/FetchEdges.strVid.feature index e4d07424188..6067ef44191 100644 --- a/tests/tck/features/fetch/FetchEdges.strVid.feature +++ b/tests/tck/features/fetch/FetchEdges.strVid.feature @@ -84,7 +84,8 @@ Feature: Fetch String Vid Edges ...
[ "tests/tck/features/fetch/FetchEdges.strVid.feature" ]
[ { "comment": "Could we yield `properties(edge) as props` in fetch clause?", "path": "tests/tck/features/fetch/FetchEdges.strVid.feature", "hunk": "@@ -249,3 +256,64 @@ Feature: Fetch String Vid Edges\n FETCH PROP ON serve 'Boris Diaw'->'Hawks' YIELD serve.not_exist_prop\n \"\"\"\n Then a...
true
vesoft-inc/nebula
2,779
comment_to_fix
format fetchedges
Why need a filter here? Could do this same thing in GetEdges executor?
7239e5ff63222608ad27f4451d7f55df52c61f39
619005b30e8f5110e3a5f6d245e7c922224e4bd4
diff --git a/src/graph/planner/ngql/FetchEdgesPlanner.cpp b/src/graph/planner/ngql/FetchEdgesPlanner.cpp new file mode 100644 index 00000000000..bdb1af6c67e --- /dev/null +++ b/src/graph/planner/ngql/FetchEdgesPlanner.cpp @@ -0,0 +1,68 @@ +/* Copyright (c) 2021 vesoft inc. All rights reserved. + * + * This source code ...
[ "src/graph/planner/ngql/FetchEdgesPlanner.cpp" ]
[ { "comment": "Why need a filter here? Could do this same thing in GetEdges executor?", "path": "src/graph/planner/ngql/FetchEdgesPlanner.cpp", "hunk": "@@ -0,0 +1,68 @@\n+/* Copyright (c) 2021 vesoft inc. All rights reserved.\n+ *\n+ * This source code is licensed under Apache 2.0 License,\n+ * attached...
true
vesoft-inc/nebula
2,779
comment_to_fix
format fetchedges
return `const std::string&`
7239e5ff63222608ad27f4451d7f55df52c61f39
619005b30e8f5110e3a5f6d245e7c922224e4bd4
diff --git a/src/parser/TraverseSentences.h b/src/parser/TraverseSentences.h index 5dcfd2d5a38..2829d82def7 100644 --- a/src/parser/TraverseSentences.h +++ b/src/parser/TraverseSentences.h @@ -289,7 +289,7 @@ class FetchEdgesSentence final : public Sentence { YieldClause* yieldClause() const { return yieldClause_....
[ "src/parser/TraverseSentences.h" ]
[ { "comment": "return `const std::string&`", "path": "src/parser/TraverseSentences.h", "hunk": "@@ -289,7 +289,7 @@ class FetchEdgesSentence final : public Sentence {\n \n YieldClause* yieldClause() const { return yieldClause_.get(); }\n \n- const std::string* edge() const { return edge_->front(); }\n...
true
vesoft-inc/nebula
2,779
comment_to_fix
format fetchedges
Why change this?
7239e5ff63222608ad27f4451d7f55df52c61f39
619005b30e8f5110e3a5f6d245e7c922224e4bd4
diff --git a/tests/tck/features/fetch/FetchEdges.intVid.feature b/tests/tck/features/fetch/FetchEdges.intVid.feature index 35739a185cc..e4b6723291c 100644 --- a/tests/tck/features/fetch/FetchEdges.intVid.feature +++ b/tests/tck/features/fetch/FetchEdges.intVid.feature @@ -71,8 +71,8 @@ Feature: Fetch Int Vid Edges S...
[ "tests/tck/features/fetch/FetchEdges.intVid.feature" ]
[ { "comment": "Why change this?", "path": "tests/tck/features/fetch/FetchEdges.intVid.feature", "hunk": "@@ -176,45 +176,45 @@ Feature: Fetch Int Vid Edges\n | serve._src | serve._dst | serve._rank | serve.start_year |\n When executing query:\n \"\"\"\n- GO FROM hash(\"NON EXIST VERT...
true
vesoft-inc/nebula
2,779
comment_to_fix
format fetchedges
Don't modify the unrelated code.
7239e5ff63222608ad27f4451d7f55df52c61f39
619005b30e8f5110e3a5f6d245e7c922224e4bd4
diff --git a/tests/tck/features/fetch/FetchEdges.intVid.feature b/tests/tck/features/fetch/FetchEdges.intVid.feature index 35739a185cc..e4b6723291c 100644 --- a/tests/tck/features/fetch/FetchEdges.intVid.feature +++ b/tests/tck/features/fetch/FetchEdges.intVid.feature @@ -71,8 +71,8 @@ Feature: Fetch Int Vid Edges S...
[ "tests/tck/features/fetch/FetchEdges.intVid.feature" ]
[ { "comment": "Don't modify the unrelated code.", "path": "tests/tck/features/fetch/FetchEdges.intVid.feature", "hunk": "@@ -71,8 +71,8 @@ Feature: Fetch Int Vid Edges\n Scenario: Fetch prop works with pipeline\n When executing query:\n \"\"\"\n- GO FROM hash('Boris Diaw') OVER serve YIE...
true
vesoft-inc/nebula
2,779
comment_to_fix
format fetchedges
Add source property and dst property case.
7239e5ff63222608ad27f4451d7f55df52c61f39
619005b30e8f5110e3a5f6d245e7c922224e4bd4
diff --git a/src/graph/validator/test/FetchEdgesTest.cpp b/src/graph/validator/test/FetchEdgesTest.cpp index 136f07b941e..f1140206540 100644 --- a/src/graph/validator/test/FetchEdgesTest.cpp +++ b/src/graph/validator/test/FetchEdgesTest.cpp @@ -21,10 +21,10 @@ class FetchEdgesValidatorTest : public ValidatorTestBase { ...
[ "src/graph/validator/test/FetchEdgesTest.cpp" ]
[ { "comment": "Add source property and dst property case.", "path": "src/graph/validator/test/FetchEdgesTest.cpp", "hunk": "@@ -359,6 +318,12 @@ TEST_F(FetchEdgesValidatorTest, FetchEdgesPropFailed) {\n // mismatched tag\n ASSERT_FALSE(validate(\"FETCH PROP ON edge1 \\\"1\\\"->\\\"2\\\" YIELD edge2.p...
true
vesoft-inc/nebula
3,397
issue_to_patch
disable agg function in unwind clause
#### What type of PR is this? - [x] bug - [ ] feature - [ ] enhancement #### What does this PR do? refer to https://discuss.nebula-graph.com.cn/t/topic/6742/8 #### Which issue(s)/PR(s) this PR relates to? #### Special notes for your reviewer, ex. impact of this fix, etc: #### Additional context:...
67bb6ffdb1c744966794fee2a676790b5f6ec35b
7cb24f99747b0ef3d0b0b4db196035ea5b70fc2b
diff --git a/src/graph/validator/MatchValidator.cpp b/src/graph/validator/MatchValidator.cpp index 0327cd3411e..05995643d0e 100644 --- a/src/graph/validator/MatchValidator.cpp +++ b/src/graph/validator/MatchValidator.cpp @@ -503,6 +503,10 @@ Status MatchValidator::validateUnwind(const UnwindClause *unwindClause, } ...
[ "src/graph/validator/MatchValidator.cpp", "tests/tck/features/match/Unwind.feature", "tests/tck/features/match/With.feature" ]
[]
diff --git a/tests/tck/features/match/Unwind.feature b/tests/tck/features/match/Unwind.feature index 718a18199ac..44e1c30852b 100644 --- a/tests/tck/features/match/Unwind.feature +++ b/tests/tck/features/match/Unwind.feature @@ -131,3 +131,26 @@ Feature: Unwind clause | <("Tim Duncan" :bachelor{name: "Tim Duncan...
true
vesoft-inc/nebula
3,427
issue_to_patch
Scan cursor has unreasonable config this issue appear after https://github.com/vesoft-inc/nebula/pull/3262. 1. The `scan` request requires the client to explicitly set the `has_next` in the request `ScanCursor` to true, which is unreasonable. The value of `has_next` should not allow the client to parameterize. ...
Remove extra field.
#### What type of PR is this? - [ ] bug - [ ] feature - [x] enhancement #### What does this PR do? #### Which issue(s)/PR(s) this PR relates to? Close https://github.com/vesoft-inc/nebula/issues/3421 Close #3467 #### Special notes for your reviewer, ex. impact of this fix, etc: #### Additional c...
9fbe1647e99f745626b5d75c62c725be10ef7535
10b6f6f62ad0e13f0a2427e1e24d7e8733523f1d
diff --git a/src/clients/storage/StorageClientBase-inl.h b/src/clients/storage/StorageClientBase-inl.h index 79435d2252a..dd319fcc9f6 100644 --- a/src/clients/storage/StorageClientBase-inl.h +++ b/src/clients/storage/StorageClientBase-inl.h @@ -357,7 +357,6 @@ StorageClientBase<ClientType>::getHostPartsWithCursor(Graph...
[ "src/clients/storage/StorageClientBase-inl.h", "src/interface/storage.thrift", "src/storage/exec/ScanNode.h", "src/storage/query/ScanEdgeProcessor.cpp", "src/storage/query/ScanVertexProcessor.cpp", "src/storage/test/ScanEdgeTest.cpp", "src/storage/test/ScanVertexTest.cpp" ]
[ { "comment": "how client knows the scan has get to end？", "path": "src/interface/storage.thrift", "hunk": "@@ -561,9 +561,8 @@ struct LookupAndTraverseRequest {\n */\n \n struct ScanCursor {\n- 3: bool has_next,\n // next start key of scan, only valid when has_nex...
diff --git a/src/storage/test/ScanEdgeTest.cpp b/src/storage/test/ScanEdgeTest.cpp index 320361726e9..3b6b30cd6d0 100644 --- a/src/storage/test/ScanEdgeTest.cpp +++ b/src/storage/test/ScanEdgeTest.cpp @@ -28,8 +28,9 @@ cpp2::ScanEdgeRequest buildRequest( CHECK_EQ(partIds.size(), cursors.size()); std::unordered_ma...
true
vesoft-inc/nebula
6,110
issue_to_patch
Ann search for tag finished
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [ ] bug - [x] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: Design and implement a dedicated statement fo...
773c6bdd65bb8d1c780308fbfdc110447047b81f
0e0a91eb61d3f6f02167d1448b81349d75ea6756
diff --git a/src/common/expression/AttributeExpression.cpp b/src/common/expression/AttributeExpression.cpp index 81b58315999..16c7522276e 100644 --- a/src/common/expression/AttributeExpression.cpp +++ b/src/common/expression/AttributeExpression.cpp @@ -18,7 +18,11 @@ const Value &AttributeExpression::eval(ExpressionCon...
[ "src/common/expression/AttributeExpression.cpp", "src/common/expression/FunctionCallExpression.cpp", "src/common/utils/NebulaKeyUtils.h", "src/common/vectorIndex/HNSWIndex.cpp", "src/common/vectorIndex/IVFIndex.cpp", "src/common/vectorIndex/IVFIndex.h", "src/graph/context/ast/CypherAstContext.h", "src...
[ { "comment": "Also need test other DMLs", "path": "tests/tck/features/vector/AnnSearch.feature", "hunk": "@@ -0,0 +1,190 @@\n+Feature: Ann Search Tests\n+\n+ Background:\n+ Given an empty graph\n+ And create a space with following options:\n+ | partition_num | 1 |\n+ | r...
diff --git a/tests/tck/features/vector/AnnIndex.feature b/tests/tck/features/vector/AnnIndex.feature index 47e4a32222a..fc7d05bb92f 100644 --- a/tests/tck/features/vector/AnnIndex.feature +++ b/tests/tck/features/vector/AnnIndex.feature @@ -337,7 +337,7 @@ Feature: Ann Index Tests SHOW EDGE ANNINDEXES; ""...
true
vesoft-inc/nebula
6,104
issue_to_patch
Ann search
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [ ] bug - [x] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: Design and implement a dedicated statement fo...
17f3bd532a44e5d6417ea14bc53ad818e778b562
d7e282157064ac066cc91b95de73c66871ab5160
diff --git a/src/clients/meta/MetaClient.cpp b/src/clients/meta/MetaClient.cpp index b43369fe740..03ffa218f31 100644 --- a/src/clients/meta/MetaClient.cpp +++ b/src/clients/meta/MetaClient.cpp @@ -2751,6 +2751,56 @@ StatusOr<std::vector<std::shared_ptr<cpp2::IndexItem>>> MetaClient::getEdgeIndex } } +StatusOr<std...
[ "src/clients/meta/MetaClient.cpp", "src/clients/meta/MetaClient.h", "src/clients/storage/StorageClient.cpp", "src/clients/storage/StorageClient.h", "src/common/base/Base.h", "src/common/expression/ApproximateLimitExpression.cpp", "src/common/expression/ApproximateLimitExpression.h", "src/common/expres...
[ { "comment": "Why implement the approx limit clause in the form of expression?", "path": "src/common/expression/ApproximateLimitExpression.h", "hunk": "@@ -0,0 +1,76 @@\n+/* Copyright (c) 2025 vesoft inc. All rights reserved.\n+ *\n+ * This source code is licensed under Apache 2.0 License.\n+ */\n+\n+#i...
diff --git a/src/common/function/test/CMakeLists.txt b/src/common/function/test/CMakeLists.txt index c0410a30c22..855baf18522 100644 --- a/src/common/function/test/CMakeLists.txt +++ b/src/common/function/test/CMakeLists.txt @@ -57,3 +57,41 @@ nebula_add_test( ${PROXYGEN_LIBRARIES} ) +nebula_add_test( + ...
true
vesoft-inc/nebula
6,099
issue_to_patch
Create Ann Index Fix
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [ ] bug - [x] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: DDL for Vector Index #6095 #### Description:...
aa1dbcc002315710af453ef07c1626b798c55837
3e753d9f79d623e6edd4087c1fa47c2d529e03ae
diff --git a/conf/nebula-storaged-listener.conf.default b/conf/nebula-storaged-listener.conf.default index 35e39c53a94..df5ffa7e236 100644 --- a/conf/nebula-storaged-listener.conf.default +++ b/conf/nebula-storaged-listener.conf.default @@ -47,6 +47,7 @@ --listener_path=data/listener # This parameter can be ignored f...
[ "conf/nebula-storaged-listener.conf.default", "conf/nebula-storaged.conf.default", "src/clients/meta/MetaClient.cpp", "src/clients/meta/MetaClient.h", "src/common/utils/NebulaKeyUtils.h", "src/daemons/StorageDaemon.cpp", "src/graph/executor/CMakeLists.txt", "src/graph/executor/Executor.cpp", "src/gr...
[]
diff --git a/src/parser/test/ParserTest.cpp b/src/parser/test/ParserTest.cpp index 4c7cd03d981..2339f12bd35 100644 --- a/src/parser/test/ParserTest.cpp +++ b/src/parser/test/ParserTest.cpp @@ -62,7 +62,7 @@ TEST_F(ParserTest, AnnIndexOperation) { { std::string query = "Create TAG ANNINDEX tag5_idx ON t...
true
vesoft-inc/nebula
6,096
issue_to_patch
Create Ann Index
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [ ] bug - [x] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: DDL for Vector Index #6095 #### Description:...
c4b111bddc11879eb55aa6815b572609605ead59
4bfaa26f93f7902255a80b3d39a2015448db476b
diff --git a/cmake/nebula/ThirdPartyConfig.cmake b/cmake/nebula/ThirdPartyConfig.cmake index a98b230e464..e2e3eb1b4ab 100644 --- a/cmake/nebula/ThirdPartyConfig.cmake +++ b/cmake/nebula/ThirdPartyConfig.cmake @@ -160,6 +160,9 @@ if (LIBLZMA_FOUND) list(APPEND COMPRESSION_LIBRARIES ${LIBLZMA_LIBRARIES}) endif() ...
[ "cmake/nebula/ThirdPartyConfig.cmake", "conf/nebula-storaged.conf.default", "src/clients/meta/MetaClient.cpp", "src/clients/meta/MetaClient.h", "src/codec/RowReaderWrapper.cpp", "src/codec/RowReaderWrapper.h", "src/common/meta/IndexManager.h", "src/common/meta/ServerBasedIndexManager.cpp", "src/comm...
[ { "comment": "Do not use Chinese annotations\r\n", "path": "src/storage/admin/BuildTagVectorIndexTask.cpp", "hunk": "@@ -0,0 +1,269 @@\n+/* Copyright (c) 2020 vesoft inc. All rights reserved.\n+ *\n+ * This source code is licensed under Apache 2.0 License.\n+ */\n+\n+#include \"storage/admin/BuildTagVec...
diff --git a/src/common/vectorIndex/test/ANNBenchmark.cpp b/src/common/vectorIndex/test/ANNBenchmark.cpp index 0c53e418c84..17ba99cf758 100644 --- a/src/common/vectorIndex/test/ANNBenchmark.cpp +++ b/src/common/vectorIndex/test/ANNBenchmark.cpp @@ -360,7 +360,7 @@ class ANNBenchmarkTest : public ::testing::Test { ...
true
vesoft-inc/nebula
5,754
issue_to_patch
Reduce the blocking time of the write lock when deleting space
## What type of PR is this? - [ ] bug - [ ] feature - [x] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: #5755 #### Description: When the number of parts of a space is relatively large and the amount of data written is also large, it will block for a long time in the removeSpa...
8dfb58764bf1d0c857f935e0c27e02ad345f243a
aab0dc62daf2e54f405aaa1d1a592b7e88bb763f
diff --git a/src/kvstore/NebulaStore.cpp b/src/kvstore/NebulaStore.cpp index 218062413e3..5fc947b9ac8 100644 --- a/src/kvstore/NebulaStore.cpp +++ b/src/kvstore/NebulaStore.cpp @@ -516,13 +516,17 @@ std::shared_ptr<Part> NebulaStore::newPart(GraphSpaceID spaceId, } void NebulaStore::removeSpace(GraphSpaceID spaceId...
[ "src/kvstore/NebulaStore.cpp" ]
[ { "comment": "See line 527 ? Remove redundent if sentance~ (or merge them into one", "path": "src/kvstore/NebulaStore.cpp", "hunk": "@@ -516,36 +516,43 @@ std::shared_ptr<Part> NebulaStore::newPart(GraphSpaceID spaceId,\n }\n \n void NebulaStore::removeSpace(GraphSpaceID spaceId) {\n- folly::RWSpinLo...
true
vesoft-inc/nebula
5,754
comment_to_fix
Reduce the blocking time of the write lock when deleting space
See line 527 ? Remove redundent if sentance~ (or merge them into one
8dfb58764bf1d0c857f935e0c27e02ad345f243a
aab0dc62daf2e54f405aaa1d1a592b7e88bb763f
diff --git a/src/kvstore/NebulaStore.cpp b/src/kvstore/NebulaStore.cpp index 218062413e3..5fc947b9ac8 100644 --- a/src/kvstore/NebulaStore.cpp +++ b/src/kvstore/NebulaStore.cpp @@ -516,13 +516,17 @@ std::shared_ptr<Part> NebulaStore::newPart(GraphSpaceID spaceId, } void NebulaStore::removeSpace(GraphSpaceID spaceId...
[ "src/kvstore/NebulaStore.cpp" ]
[ { "comment": "See line 527 ? Remove redundent if sentance~ (or merge them into one", "path": "src/kvstore/NebulaStore.cpp", "hunk": "@@ -516,36 +516,43 @@ std::shared_ptr<Part> NebulaStore::newPart(GraphSpaceID spaceId,\n }\n \n void NebulaStore::removeSpace(GraphSpaceID spaceId) {\n- folly::RWSpinLo...
true
vesoft-inc/nebula
5,700
issue_to_patch
fix innerjoin bug
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [x] bug - [ ] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: close https://github.com/vesoft-inc/nebula-en...
f798099f46d5fb0346971c631f0039c4a902802e
781a02947f4c14ec1235ad6903c26854b7fe76da
diff --git a/src/graph/validator/YieldValidator.cpp b/src/graph/validator/YieldValidator.cpp index b09b859970c..0e6856d11e9 100644 --- a/src/graph/validator/YieldValidator.cpp +++ b/src/graph/validator/YieldValidator.cpp @@ -218,10 +218,14 @@ Status YieldValidator::validateJoin(const JoinClause *join) { } auto ...
[ "src/graph/validator/YieldValidator.cpp", "tests/tck/features/yield/join.feature" ]
[]
diff --git a/tests/tck/features/yield/join.feature b/tests/tck/features/yield/join.feature index 2ff3ec392e3..d5be0b67053 100644 --- a/tests/tck/features/yield/join.feature +++ b/tests/tck/features/yield/join.feature @@ -70,6 +70,18 @@ Feature: join | YIELD $a.vid AS id, $-.e2 AS e FROM $a INNER JOIN $- ON $a.vi...
true
vesoft-inc/nebula
6,090
issue_to_patch
Vector index Interface
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [ ] bug - [x] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: Vector Index Interface #6089 #### Descript...
b7b841c73d924009fd7ad59afd31e09f9e3acd1e
8991052081fe43babf9bc1c4677417907ff3e60a
diff --git a/cmake/nebula/ThirdPartyConfig.cmake b/cmake/nebula/ThirdPartyConfig.cmake index 03f5c58a956..a98b230e464 100644 --- a/cmake/nebula/ThirdPartyConfig.cmake +++ b/cmake/nebula/ThirdPartyConfig.cmake @@ -119,6 +119,7 @@ find_package(FLEX REQUIRED) find_package(LibLZMA REQUIRED) find_package(Fizz REQUIRED) f...
[ "cmake/nebula/ThirdPartyConfig.cmake", "src/codec/RowReaderV2.cpp", "src/codec/RowReaderWrapper.cpp", "src/codec/RowReaderWrapper.h", "src/codec/RowWriterV2.cpp", "src/common/CMakeLists.txt", "src/common/meta/NebulaSchemaProvider.h", "src/common/thrift/ThriftTypes.h", "src/common/utils/NebulaKeyUtil...
[]
diff --git a/src/common/vectorIndex/test/ANNBenchmark.cpp b/src/common/vectorIndex/test/ANNBenchmark.cpp new file mode 100644 index 00000000000..0c53e418c84 --- /dev/null +++ b/src/common/vectorIndex/test/ANNBenchmark.cpp @@ -0,0 +1,721 @@ +/* Copyright (c) 2025 vesoft inc. All rights reserved. + * + * This source code...
true
vesoft-inc/nebula
6,087
issue_to_patch
Implement DML statement and process for vector type
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [ ] bug - [x] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: Support DML for vector type #6032 (Stage 2) ...
d7626b6ad65b0da5e9ff02947af75423ed67b236
eeff7dc4bc910d9f3dd7ce3b566f3101b32357a4
diff --git a/src/clients/meta/MetaClient.cpp b/src/clients/meta/MetaClient.cpp index df4e3dc91f4..ecd0b6db340 100644 --- a/src/clients/meta/MetaClient.cpp +++ b/src/clients/meta/MetaClient.cpp @@ -432,7 +432,11 @@ TagSchemas MetaClient::buildTagSchemas(std::vector<cpp2::TagItem> tagItemVec) { // meta will return t...
[ "src/clients/meta/MetaClient.cpp", "src/clients/meta/MetaClient.h", "src/codec/RowReaderV2.cpp", "src/codec/RowReaderV2.h", "src/codec/RowReaderWrapper.cpp", "src/codec/RowReaderWrapper.h", "src/codec/RowWriterV2.cpp", "src/codec/RowWriterV2.h", "src/codec/test/RowWriterV2Test.cpp", "src/common/me...
[ { "comment": "remove this", "path": "vesoft-third-party-vecotr-3.3-x86_64-libc-2.31-gcc-9.4.0-abi-11.sh", "hunk": "", "resolving_sha": "eeff7dc4bc910d9f3dd7ce3b566f3101b32357a4", "resolving_diff": "diff --git a/vesoft-third-party-vecotr-3.3-x86_64-libc-2.31-gcc-9.4.0-abi-11.sh b/vesoft-third-par...
diff --git a/src/codec/test/RowWriterV2Test.cpp b/src/codec/test/RowWriterV2Test.cpp index 03e4eec79c6..cc91f694e97 100644 --- a/src/codec/test/RowWriterV2Test.cpp +++ b/src/codec/test/RowWriterV2Test.cpp @@ -44,6 +44,113 @@ const Geography geogPolygon = Polygon( ...
true
vesoft-inc/nebula
6,076
issue_to_patch
Implement CREATE TAG statement for vector type
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [ ] bug - [x] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: Create tag with vector type properties #6...
c4bb75514631478122e7417b9c8df7a9ef88a8ff
f7bfc135f54ca6e7dc52b6d84db4aef0569abbce
diff --git a/src/common/datatypes/Value.cpp b/src/common/datatypes/Value.cpp index 33e1fbbbb05..3a943c841ec 100644 --- a/src/common/datatypes/Value.cpp +++ b/src/common/datatypes/Value.cpp @@ -1954,7 +1954,6 @@ Value Value::lessThan(const Value& v) const { // e.g. What is the result of `duration('P1M') < duratio...
[ "src/common/datatypes/Value.cpp", "src/common/datatypes/Vector.cpp", "src/common/datatypes/Vector.h", "src/common/datatypes/VectorOps-inl.h", "src/common/datatypes/test/ValueTest.cpp", "src/common/meta/NebulaSchemaProvider.cpp", "src/common/meta/NebulaSchemaProvider.h", "src/graph/util/SchemaUtil.cpp"...
[ { "comment": "2018 -> 2025", "path": "src/kvstore/test/RocksEngineMultiCFTest.cpp", "hunk": "@@ -0,0 +1,566 @@\n+/* Copyright (c) 2018 vesoft inc. All rights reserved.", "resolving_sha": "f7bfc135f54ca6e7dc52b6d84db4aef0569abbce", "resolving_diff": "diff --git a/src/kvstore/test/RocksEngineMulti...
diff --git a/src/common/datatypes/test/ValueTest.cpp b/src/common/datatypes/test/ValueTest.cpp index c6983d2201b..c2491f8806b 100644 --- a/src/common/datatypes/test/ValueTest.cpp +++ b/src/common/datatypes/test/ValueTest.cpp @@ -1572,7 +1572,30 @@ TEST(Value, typeName) { } using serializer = apache::thrift::Compact...
true
vesoft-inc/nebula
6,076
comment_to_fix
Implement CREATE TAG statement for vector type
2018 -> 2025
c4bb75514631478122e7417b9c8df7a9ef88a8ff
f7bfc135f54ca6e7dc52b6d84db4aef0569abbce
diff --git a/src/kvstore/test/RocksEngineMultiCFTest.cpp b/src/kvstore/test/RocksEngineMultiCFTest.cpp index b69923941cd..a54979a06c4 100644 --- a/src/kvstore/test/RocksEngineMultiCFTest.cpp +++ b/src/kvstore/test/RocksEngineMultiCFTest.cpp @@ -1,4 +1,4 @@ -/* Copyright (c) 2018 vesoft inc. All rights reserved. +/* Cop...
[ "src/kvstore/test/RocksEngineMultiCFTest.cpp" ]
[ { "comment": "2018 -> 2025", "path": "src/kvstore/test/RocksEngineMultiCFTest.cpp", "hunk": "@@ -0,0 +1,566 @@\n+/* Copyright (c) 2018 vesoft inc. All rights reserved.", "resolving_sha": "f7bfc135f54ca6e7dc52b6d84db4aef0569abbce", "resolving_diff": "diff --git a/src/kvstore/test/RocksEngineMulti...
true
vesoft-inc/nebula
6,076
comment_to_fix
Implement CREATE TAG statement for vector type
add more test cases: - default value - nullable - primary key check - comment - ...
c4bb75514631478122e7417b9c8df7a9ef88a8ff
f7bfc135f54ca6e7dc52b6d84db4aef0569abbce
diff --git a/tests/tck/features/vector/Schema.feature b/tests/tck/features/vector/Schema.feature new file mode 100644 index 00000000000..6c1d4ae96c9 --- /dev/null +++ b/tests/tck/features/vector/Schema.feature @@ -0,0 +1,168 @@ +# Copyright (c) 2025 vesoft inc. All rights reserved. +# +# This source code is licensed un...
[ "tests/tck/features/vector/Schema.feature" ]
[ { "comment": "add more test cases:\r\n- default value\r\n- nullable \r\n- primary key check\r\n- comment\r\n- ...\r\n\r\n", "path": "tests/tck/features/vector/Schema.feature", "hunk": "@@ -0,0 +1,38 @@\n+# Copyright (c) 2025 vesoft inc. All rights reserved.\n+#\n+# This source code is licensed under Apa...
true
vesoft-inc/nebula
6,076
comment_to_fix
Implement CREATE TAG statement for vector type
const & and &&
c4bb75514631478122e7417b9c8df7a9ef88a8ff
f7bfc135f54ca6e7dc52b6d84db4aef0569abbce
diff --git a/src/common/datatypes/Vector.h b/src/common/datatypes/Vector.h index f00158fab97..a1053d32841 100644 --- a/src/common/datatypes/Vector.h +++ b/src/common/datatypes/Vector.h @@ -23,7 +23,8 @@ struct Vector { Vector() = default; Vector(const Vector& rhs) = default; Vector(Vector&& rhs) noexcept = def...
[ "src/common/datatypes/Vector.h" ]
[ { "comment": "\r\nconst & and &&\r\n", "path": "src/common/datatypes/Vector.h", "hunk": "@@ -24,6 +24,12 @@ struct Vector {\n Vector(const Vector& rhs) = default;\n Vector(Vector&& rhs) noexcept = default;\n explicit Vector(std::vector<float> vals) : values(std::move(vals)) {}\n+ explicit Vector(...
true
vesoft-inc/nebula
6,076
comment_to_fix
Implement CREATE TAG statement for vector type
Why cant use float?
c4bb75514631478122e7417b9c8df7a9ef88a8ff
f7bfc135f54ca6e7dc52b6d84db4aef0569abbce
diff --git a/src/common/datatypes/VectorOps-inl.h b/src/common/datatypes/VectorOps-inl.h index ce4535e27f0..5e75eb0b111 100644 --- a/src/common/datatypes/VectorOps-inl.h +++ b/src/common/datatypes/VectorOps-inl.h @@ -45,8 +45,14 @@ uint32_t Cpp2Ops<nebula::Vector>::write(Protocol* proto, nebula::Vector const* o xfer...
[ "src/common/datatypes/VectorOps-inl.h" ]
[ { "comment": "Why cant use float?", "path": "src/common/datatypes/VectorOps-inl.h", "hunk": "@@ -67,9 +73,15 @@ void Cpp2Ops<nebula::Vector>::read(Protocol* proto, nebula::Vector* obj) {\n }\n \n _readField_values : {\n- obj->values = std::vector<float>();\n+ // Read as double vector and convert to ...
true
vesoft-inc/nebula
6,076
comment_to_fix
Implement CREATE TAG statement for vector type
revert this
c4bb75514631478122e7417b9c8df7a9ef88a8ff
f7bfc135f54ca6e7dc52b6d84db4aef0569abbce
diff --git a/src/kvstore/test/RocksEngineMultiCFTest.cpp b/src/kvstore/test/RocksEngineMultiCFTest.cpp index b69923941cd..a54979a06c4 100644 --- a/src/kvstore/test/RocksEngineMultiCFTest.cpp +++ b/src/kvstore/test/RocksEngineMultiCFTest.cpp @@ -1,4 +1,4 @@ -/* Copyright (c) 2018 vesoft inc. All rights reserved. +/* Cop...
[ "src/kvstore/test/RocksEngineMultiCFTest.cpp" ]
[ { "comment": "revert this", "path": "src/kvstore/test/RocksEngineMultiCFTest.cpp", "hunk": "@@ -1,4 +1,4 @@\n-/* Copyright (c) 2018 vesoft inc. All rights reserved.\n+/* Copyright (c) 2025 vesoft inc. All rights reserved.", "resolving_sha": "f7bfc135f54ca6e7dc52b6d84db4aef0569abbce", "resolving_...
true
vesoft-inc/nebula
6,074
issue_to_patch
Implement the multiple column family RocksDB
## What type of PR is this? - [ ] bug - [x] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: Implement the multiple column family RocksDB #6073 #### Description: **Feature Request: Implement the multiple column family RocksDB** 1. Vector storage is separated ...
8a1ccf9b249a20cde45d9576ab5b02b0a0c6989d
02b3f32843449d4d08ac4a221b9137bf7464b6a0
diff --git a/src/codec/RowReaderV2.cpp b/src/codec/RowReaderV2.cpp index 47101dd9239..15d7531c5ff 100644 --- a/src/codec/RowReaderV2.cpp +++ b/src/codec/RowReaderV2.cpp @@ -301,6 +301,9 @@ Value RowReaderV2::getValueByIndex(const int64_t index) const { return nebula::extractIntOrFloat<int32_t, Set>(data_, offset...
[ "src/codec/RowReaderV2.cpp", "src/common/datatypes/Value.cpp", "src/common/meta/NebulaSchemaProvider.cpp", "src/common/utils/IndexKeyUtils.h", "src/common/utils/NebulaKeyUtils.cpp", "src/common/utils/NebulaKeyUtils.h", "src/graph/util/SchemaUtil.cpp", "src/interface/common.thrift", "src/kvstore/KVEn...
[]
diff --git a/src/kvstore/test/CMakeLists.txt b/src/kvstore/test/CMakeLists.txt index 129995acbfb..9098c83f0a3 100644 --- a/src/kvstore/test/CMakeLists.txt +++ b/src/kvstore/test/CMakeLists.txt @@ -98,6 +98,23 @@ nebula_add_test( curl ) + +nebula_add_test( + NAME + rocks_engine_multicf_test + SO...
true
vesoft-inc/nebula
6,083
issue_to_patch
Implement the key for vector type
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [ ] bug - [x] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: Support DML for vector type #6032 （Stage ...
5d43e44b43ae5239400897f664e68b034a0d46e5
3cb47de1c0072fdd783b1ba29d63335fffc97106
diff --git a/src/common/thrift/ThriftTypes.h b/src/common/thrift/ThriftTypes.h index e297739ea4e..ff3f1d49cda 100644 --- a/src/common/thrift/ThriftTypes.h +++ b/src/common/thrift/ThriftTypes.h @@ -27,6 +27,7 @@ using Port = int32_t; // be appended to the end using VertexID = std::string; using TagID = int32_t; +usin...
[ "src/common/thrift/ThriftTypes.h", "src/common/utils/NebulaKeyUtils.cpp", "src/common/utils/NebulaKeyUtils.h", "src/common/utils/Types.h", "src/common/utils/test/NebulaKeyUtilsTest.cpp" ]
[]
diff --git a/src/common/utils/test/NebulaKeyUtilsTest.cpp b/src/common/utils/test/NebulaKeyUtilsTest.cpp index 206d756daab..67e9af3d967 100644 --- a/src/common/utils/test/NebulaKeyUtilsTest.cpp +++ b/src/common/utils/test/NebulaKeyUtilsTest.cpp @@ -55,6 +55,52 @@ class KeyUtilsTestBase : public ::testing::Test { A...
true
vesoft-inc/nebula
6,068
issue_to_patch
Implement vector value type
## What type of PR is this? - [ ] bug - [x] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: Support vector value type and data type #6042 Implement the vector value type and serialization and deserialization for it #6067 #### Description: **Feature Request: Add Data...
5d43e44b43ae5239400897f664e68b034a0d46e5
95bcbd0224abdb1b51915662768072e508efe307
diff --git a/src/common/datatypes/CMakeLists.txt b/src/common/datatypes/CMakeLists.txt index 61827f75791..07f3095de32 100644 --- a/src/common/datatypes/CMakeLists.txt +++ b/src/common/datatypes/CMakeLists.txt @@ -15,6 +15,7 @@ nebula_add_library( Set.cpp Geography.cpp Duration.cpp + Vector.cpp ) n...
[ "src/common/datatypes/CMakeLists.txt", "src/common/datatypes/CommonCpp2Ops.h", "src/common/datatypes/Value.cpp", "src/common/datatypes/Value.h", "src/common/datatypes/ValueOps-inl.h", "src/common/datatypes/Vector.cpp", "src/common/datatypes/Vector.h", "src/common/datatypes/VectorOps-inl.h", "src/com...
[ { "comment": "Why we need this runtime error value?", "path": "src/common/datatypes/Value.cpp", "hunk": "@@ -32,6 +33,7 @@ const Value Value::kNullOverflow(NullType::ERR_OVERFLOW);\n const Value Value::kNullUnknownProp(NullType::UNKNOWN_PROP);\n const Value Value::kNullDivByZero(NullType::DIV_BY_ZERO);\...
diff --git a/src/common/datatypes/test/CMakeLists.txt b/src/common/datatypes/test/CMakeLists.txt index 557f51edf56..01eed2e9af7 100644 --- a/src/common/datatypes/test/CMakeLists.txt +++ b/src/common/datatypes/test/CMakeLists.txt @@ -103,6 +103,19 @@ nebula_add_test( gtest ) +nebula_add_test( + NAME + ...
true
vesoft-inc/nebula
3,806
issue_to_patch
fix memory increase
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> #### What type of PR is this? - [ ] bug - [ ] feature - [ ] enhancement #### What problem(s) does this PR solve? Issue(s) number: cherry pick https://github.com/vesoft-inc/ne...
e80c45aa259cfc547650266ee37edbf4955a4c35
0aad12ad14fb48667a9718e65a5f1befb56e5823
diff --git a/src/clients/meta/MetaClient.cpp b/src/clients/meta/MetaClient.cpp index 6660db4bb7e..df1dac4f89f 100644 --- a/src/clients/meta/MetaClient.cpp +++ b/src/clients/meta/MetaClient.cpp @@ -340,32 +340,20 @@ bool MetaClient::loadSchemas(GraphSpaceID spaceId, EdgeSchemas edgeSchemas; TagID lastTagId = -1; ...
[ "src/clients/meta/MetaClient.cpp", "src/clients/meta/MetaClient.h", "src/codec/RowWriterV2.cpp", "src/codec/test/ResultSchemaProvider.cpp", "src/codec/test/ResultSchemaProvider.h", "src/codec/test/SchemaWriter.cpp", "src/common/meta/NebulaSchemaProvider.cpp", "src/common/meta/NebulaSchemaProvider.h", ...
[]
diff --git a/src/codec/test/ResultSchemaProvider.cpp b/src/codec/test/ResultSchemaProvider.cpp index d4cebcee974..d3f0b6a5214 100644 --- a/src/codec/test/ResultSchemaProvider.cpp +++ b/src/codec/test/ResultSchemaProvider.cpp @@ -22,7 +22,7 @@ ResultSchemaProvider::ResultSchemaField::ResultSchemaField(std::string name, ...
true
vesoft-inc/nebula
6,015
issue_to_patch
[auto-pick-to-release-3.8]Switch to non-root container user
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [ ] bug - [ ] feature - [x] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: #### Description: ## How do you solve ...
4f106fb146482502c07816c68dbb91eea6d78b62
da6195846fb95627e128ab9fc46b571f77a2efb7
diff --git a/docker/Dockerfile b/docker/Dockerfile index ea2e33ae9a8..adb1588b186 100644 --- a/docker/Dockerfile +++ b/docker/Dockerfile @@ -10,6 +10,8 @@ RUN cd /home/nebula/BUILD/package \ FROM centos:7 as graphd +RUN groupadd -r nebula && useradd -r -g nebula -d /usr/local/nebula nebula + COPY --from=builder...
[ "docker/Dockerfile", "docker/Dockerfile.graphd", "docker/Dockerfile.metad", "docker/Dockerfile.storaged", "docker/Dockerfile.tools" ]
[]
true
vesoft-inc/nebula
5,936
issue_to_patch
Fixed vulnerability issues
* Fixed a security bug involving shell injection * Fixed a security bug involving authentication bypass
cdeab593e39416959f254ab18085ca17ac96ad19
cd6c5976ccfe817b2e0a2d46227cd361bfefb45c
diff --git a/src/common/network/NetworkUtils.cpp b/src/common/network/NetworkUtils.cpp index 43d67d892be..1e302a9dc90 100644 --- a/src/common/network/NetworkUtils.cpp +++ b/src/common/network/NetworkUtils.cpp @@ -307,6 +307,18 @@ std::string NetworkUtils::toHostsStr(const std::vector<HostAddr>& hosts) { return hosts...
[ "src/common/network/NetworkUtils.cpp", "src/common/network/NetworkUtils.h", "src/meta/processors/job/DownloadJobExecutor.cpp", "src/webservice/SetFlagsHandler.cpp" ]
[]
true
vesoft-inc/nebula
6,012
issue_to_patch
Switch to non-root container user
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [ ] bug - [ ] feature - [x] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: #### Description: ## How do you solve ...
1f3c6b2c2287cf5c4ba6b8d4c057a2a045326c4b
a29b8cffbc474c610c18b1197d3eb7db1b20b1c2
diff --git a/docker/Dockerfile b/docker/Dockerfile index ea2e33ae9a8..adb1588b186 100644 --- a/docker/Dockerfile +++ b/docker/Dockerfile @@ -10,6 +10,8 @@ RUN cd /home/nebula/BUILD/package \ FROM centos:7 as graphd +RUN groupadd -r nebula && useradd -r -g nebula -d /usr/local/nebula nebula + COPY --from=builder...
[ "docker/Dockerfile", "docker/Dockerfile.graphd", "docker/Dockerfile.metad", "docker/Dockerfile.storaged", "docker/Dockerfile.tools" ]
[]
true
vesoft-inc/nebula
5,977
issue_to_patch
Update `how-to-contribute.md` reference
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [x] bug - [ ] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: #### Description: Small PR - fixes the `ho...
6e0f646328b2d37f394c6c580382bae98af8d49f
6ee6d94346c414c21b06288d377196713565df2c
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e673e6dc229..a7c116d41d5 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,1 +1,1 @@ -See [How to contribute](https://github.com/vesoft-inc/nebula-community/blob/master/Contributors/how-to-contribute.md) for details about how to contribute to **NebulaGraph**. ...
[ "CONTRIBUTING.md" ]
[]
true
vesoft-inc/nebula
5,944
issue_to_patch
fix IndexScan with label containing parameters
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [x] bug - [ ] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number:#5939 #### Description: ## How do you s...
6c59b79f3a5318ea592bdae60556e4a49ec6c682
8f19722b5992ccac43e2dd059902a8be0d64c3fa
diff --git a/src/common/expression/VariableExpression.h b/src/common/expression/VariableExpression.h index 52e6a3907f0..d989e145215 100644 --- a/src/common/expression/VariableExpression.h +++ b/src/common/expression/VariableExpression.h @@ -30,6 +30,10 @@ class VariableExpression final : public Expression { return...
[ "src/common/expression/VariableExpression.h", "src/graph/util/ExpressionUtils.cpp", "tests/tck/features/bugfix/ParameterQuery.feature", "tests/tck/features/match/Path.feature", "tests/tck/features/yield/parameter.feature" ]
[]
diff --git a/tests/tck/features/bugfix/ParameterQuery.feature b/tests/tck/features/bugfix/ParameterQuery.feature new file mode 100644 index 00000000000..7c4a0cb1cc3 --- /dev/null +++ b/tests/tck/features/bugfix/ParameterQuery.feature @@ -0,0 +1,21 @@ +Feature: Test excute index scan with label which contains parameters...
true
vesoft-inc/nebula
5,967
issue_to_patch
fix round(5) crash, check type error
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [ ] bug - [ ] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: #### Description: return round(5) crash ...
b4f83ebc9c4cbf9ad9d7452797aeb45eea39edf4
70edf1613cd38784a1cdaabedd70d329e255f227
diff --git a/src/common/function/FunctionManager.cpp b/src/common/function/FunctionManager.cpp index ca159d75dee..061a41113d0 100644 --- a/src/common/function/FunctionManager.cpp +++ b/src/common/function/FunctionManager.cpp @@ -659,7 +659,12 @@ FunctionManager::FunctionManager() { return Value::kNullBad...
[ "src/common/function/FunctionManager.cpp" ]
[]
true
vesoft-inc/nebula
5,953
issue_to_patch
Enable MULTIUPDATE and LOOKUP | UPDATE
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [ ] bug - [x] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: #5934 #### Description: - Added MULTIUPDATE...
6c09e832d7caa7b3480bad2079f102bcb2d23b71
3f6637e2689670e8e48ba1b5c72dccff9a7629b8
diff --git a/src/graph/executor/mutate/DeleteExecutor.cpp b/src/graph/executor/mutate/DeleteExecutor.cpp index 15ef49a36b8..d7cdb849ee8 100644 --- a/src/graph/executor/mutate/DeleteExecutor.cpp +++ b/src/graph/executor/mutate/DeleteExecutor.cpp @@ -45,9 +45,9 @@ folly::Future<Status> DeleteVerticesExecutor::deleteVerti...
[ "src/graph/executor/mutate/DeleteExecutor.cpp", "src/graph/executor/mutate/UpdateExecutor.cpp", "src/graph/executor/mutate/UpdateExecutor.h", "src/graph/planner/plan/Mutate.cpp", "src/graph/planner/plan/Mutate.h", "src/graph/service/PermissionCheck.cpp", "src/graph/validator/MutateValidator.cpp", "src...
[ { "comment": "这里可能存在很多冗余的RPC操作。我们可以修改通信协议，并使StorageD支持Batch Update的操作。对同一个StroageD所更新的Vertex或Edge仅发送一次RPC。如果您评估这可能需要很大的工作量，您可以之后的PR中再修改他。", "path": "src/graph/executor/mutate/UpdateExecutor.cpp", "hunk": "@@ -85,6 +86,225 @@ folly::Future<Status> UpdateVertexExecutor::execute() {\n });\n }\n \n+St...
diff --git a/src/graph/validator/test/MutateValidatorTest.cpp b/src/graph/validator/test/MutateValidatorTest.cpp index a90290bc4cc..4a9d5334c25 100644 --- a/src/graph/validator/test/MutateValidatorTest.cpp +++ b/src/graph/validator/test/MutateValidatorTest.cpp @@ -186,7 +186,7 @@ TEST_F(MutateValidatorTest, UpdateVerte...
true
vesoft-inc/nebula
5,953
comment_to_fix
Enable MULTIUPDATE and LOOKUP | UPDATE
这里可能存在很多冗余的RPC操作。我们可以修改通信协议，并使StorageD支持Batch Update的操作。对同一个StroageD所更新的Vertex或Edge仅发送一次RPC。如果您评估这可能需要很大的工作量，您可以之后的PR中再修改他。
6c09e832d7caa7b3480bad2079f102bcb2d23b71
3f6637e2689670e8e48ba1b5c72dccff9a7629b8
diff --git a/src/graph/executor/mutate/UpdateExecutor.cpp b/src/graph/executor/mutate/UpdateExecutor.cpp index 3b820ac471a..9111b10ec76 100644 --- a/src/graph/executor/mutate/UpdateExecutor.cpp +++ b/src/graph/executor/mutate/UpdateExecutor.cpp @@ -13,7 +13,7 @@ using nebula::storage::StorageClient; namespace nebula {...
[ "src/graph/executor/mutate/UpdateExecutor.cpp" ]
[ { "comment": "这里可能存在很多冗余的RPC操作。我们可以修改通信协议，并使StorageD支持Batch Update的操作。对同一个StroageD所更新的Vertex或Edge仅发送一次RPC。如果您评估这可能需要很大的工作量，您可以之后的PR中再修改他。", "path": "src/graph/executor/mutate/UpdateExecutor.cpp", "hunk": "@@ -85,6 +86,225 @@ folly::Future<Status> UpdateVertexExecutor::execute() {\n });\n }\n \n+St...
true
vesoft-inc/nebula
5,953
comment_to_fix
Enable MULTIUPDATE and LOOKUP | UPDATE
直接修改即可
6c09e832d7caa7b3480bad2079f102bcb2d23b71
3f6637e2689670e8e48ba1b5c72dccff9a7629b8
diff --git a/src/graph/executor/mutate/DeleteExecutor.cpp b/src/graph/executor/mutate/DeleteExecutor.cpp index 15ef49a36b8..d7cdb849ee8 100644 --- a/src/graph/executor/mutate/DeleteExecutor.cpp +++ b/src/graph/executor/mutate/DeleteExecutor.cpp @@ -45,9 +45,9 @@ folly::Future<Status> DeleteVerticesExecutor::deleteVerti...
[ "src/graph/executor/mutate/DeleteExecutor.cpp" ]
[ { "comment": "直接修改即可", "path": "src/graph/executor/mutate/DeleteExecutor.cpp", "hunk": "@@ -147,7 +147,7 @@ folly::Future<Status> DeleteEdgesExecutor::deleteEdges() {\n DCHECK(!inputVar.empty());\n auto& inputResult = ectx_->getResult(inputVar);\n auto iter = inputResult.iter();\n- edgeKeys.reser...
true
vesoft-inc/nebula
5,953
comment_to_fix
Enable MULTIUPDATE and LOOKUP | UPDATE
删除无效的代码
6c09e832d7caa7b3480bad2079f102bcb2d23b71
3f6637e2689670e8e48ba1b5c72dccff9a7629b8
diff --git a/src/graph/executor/mutate/UpdateExecutor.cpp b/src/graph/executor/mutate/UpdateExecutor.cpp index 3b820ac471a..9111b10ec76 100644 --- a/src/graph/executor/mutate/UpdateExecutor.cpp +++ b/src/graph/executor/mutate/UpdateExecutor.cpp @@ -13,7 +13,7 @@ using nebula::storage::StorageClient; namespace nebula {...
[ "src/graph/executor/mutate/UpdateExecutor.cpp" ]
[ { "comment": "删除无效的代码", "path": "src/graph/executor/mutate/UpdateExecutor.cpp", "hunk": "@@ -38,6 +39,7 @@ StatusOr<DataSet> UpdateBaseExecutor::handleResult(DataSet &&data) {\n return result;\n }\n \n+/*", "resolving_sha": "3f6637e2689670e8e48ba1b5c72dccff9a7629b8", "resolving_diff": "diff --...
true
vesoft-inc/nebula
5,953
comment_to_fix
Enable MULTIUPDATE and LOOKUP | UPDATE
删除
6c09e832d7caa7b3480bad2079f102bcb2d23b71
3f6637e2689670e8e48ba1b5c72dccff9a7629b8
diff --git a/src/graph/executor/mutate/UpdateExecutor.cpp b/src/graph/executor/mutate/UpdateExecutor.cpp index 3b820ac471a..9111b10ec76 100644 --- a/src/graph/executor/mutate/UpdateExecutor.cpp +++ b/src/graph/executor/mutate/UpdateExecutor.cpp @@ -13,7 +13,7 @@ using nebula::storage::StorageClient; namespace nebula {...
[ "src/graph/executor/mutate/UpdateExecutor.cpp" ]
[ { "comment": "删除", "path": "src/graph/executor/mutate/UpdateExecutor.cpp", "hunk": "@@ -84,57 +87,298 @@ folly::Future<Status> UpdateVertexExecutor::execute() {\n return Status::OK();\n });\n }\n+*/\n+\n+Status UpdateBaseExecutor::handleMultiResult(DataSet &result, DataSet &&data) {\n+ ...
true
vesoft-inc/nebula
5,953
comment_to_fix
Enable MULTIUPDATE and LOOKUP | UPDATE
默认日志级别，非异常情况下，数据链路上，不能出现和qps成正比/相同数量级的日志。请删除。
6c09e832d7caa7b3480bad2079f102bcb2d23b71
3f6637e2689670e8e48ba1b5c72dccff9a7629b8
diff --git a/src/graph/executor/mutate/UpdateExecutor.cpp b/src/graph/executor/mutate/UpdateExecutor.cpp index 3b820ac471a..9111b10ec76 100644 --- a/src/graph/executor/mutate/UpdateExecutor.cpp +++ b/src/graph/executor/mutate/UpdateExecutor.cpp @@ -13,7 +13,7 @@ using nebula::storage::StorageClient; namespace nebula {...
[ "src/graph/executor/mutate/UpdateExecutor.cpp" ]
[ { "comment": "默认日志级别，非异常情况下，数据链路上，不能出现和qps成正比/相同数量级的日志。请删除。", "path": "src/graph/executor/mutate/UpdateExecutor.cpp", "hunk": "@@ -84,57 +87,298 @@ folly::Future<Status> UpdateVertexExecutor::execute() {\n return Status::OK();\n });\n }\n+*/\n+\n+Status UpdateBaseExecutor::handleMultiResul...
true
vesoft-inc/nebula
5,953
comment_to_fix
Enable MULTIUPDATE and LOOKUP | UPDATE
什么情况下inputVar会是empty？
6c09e832d7caa7b3480bad2079f102bcb2d23b71
3f6637e2689670e8e48ba1b5c72dccff9a7629b8
diff --git a/src/graph/executor/mutate/UpdateExecutor.cpp b/src/graph/executor/mutate/UpdateExecutor.cpp index 3b820ac471a..9111b10ec76 100644 --- a/src/graph/executor/mutate/UpdateExecutor.cpp +++ b/src/graph/executor/mutate/UpdateExecutor.cpp @@ -13,7 +13,7 @@ using nebula::storage::StorageClient; namespace nebula {...
[ "src/graph/executor/mutate/UpdateExecutor.cpp" ]
[ { "comment": "什么情况下inputVar会是empty？", "path": "src/graph/executor/mutate/UpdateExecutor.cpp", "hunk": "@@ -84,57 +87,298 @@ folly::Future<Status> UpdateVertexExecutor::execute() {\n return Status::OK();\n });\n }\n+*/\n+\n+Status UpdateBaseExecutor::handleMultiResult(DataSet &result, DataS...
true
vesoft-inc/nebula
5,953
comment_to_fix
Enable MULTIUPDATE and LOOKUP | UPDATE
我注意到我们的upsert vertex已经完全修改为了新语法，而upsert edge却还保留了原来的语法？这是出于什么考虑，我理解在graphd似乎只需要加一个标记就是判断是update还是upsert了
6c09e832d7caa7b3480bad2079f102bcb2d23b71
3f6637e2689670e8e48ba1b5c72dccff9a7629b8
diff --git a/src/parser/parser.yy b/src/parser/parser.yy index c54370886a3..e038b0c23af 100644 --- a/src/parser/parser.yy +++ b/src/parser/parser.yy @@ -393,7 +393,8 @@ using namespace nebula; %type <sentence> mutate_sentence %type <sentence> insert_vertex_sentence insert_edge_sentence %type <sentence> delete_vertex...
[ "src/parser/parser.yy" ]
[ { "comment": "我注意到我们的upsert vertex已经完全修改为了新语法，而upsert edge却还保留了原来的语法？这是出于什么考虑，我理解在graphd似乎只需要加一个标记就是判断是update还是upsert了", "path": "src/parser/parser.yy", "hunk": "@@ -3271,8 +3298,19 @@ update_edge_sentence\n auto sentence = new UpdateEdgeSentence($5, $7, $9, $4, $11, $12, $13, true);\n $...
true