repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
wallabag/wallabag | 8,847 | issue_to_patch | build(deps-dev): bump sass-loader from 16.0.8 to 17.0.0 | Bumps [sass-loader](https://github.com/webpack/sass-loader) from 16.0.8 to 17.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/webpack/sass-loader/releases">sass-loader's releases</a>.</em></p>
<blockquote>
<h2>v17.0.0</h2>
<h3>Major Changes</h3>
<ul>
<li>
<p>Add <code>&qu... | d2db8cadea8297fd1e6ce2c59936dd80d07a4289 | 0a18e90a91346ee9012c4deee09248f24081cc32 | diff --git a/package.json b/package.json
index 370f26ca6e..93d511f80c 100644
--- a/package.json
+++ b/package.json
@@ -68,7 +68,7 @@
"postcss-scss": "^4.0.9",
"regenerator-runtime": "^0.14.1",
"sass-embedded": "^1.100.0",
- "sass-loader": "^16.0.8",
+ "sass-loader": "^17.0.0",
"style-loader": ... | [
"package.json",
"yarn.lock"
] | [] | true | ||
wallabag/wallabag | 8,845 | issue_to_patch | Translations update from Hosted Weblate | Translations update from [Hosted Weblate](https://hosted.weblate.org) for [wallabag/Messages (web)](https://hosted.weblate.org/projects/wallabag/messages/).
Current translation status:
 | 327d1292d8ee8302875a8b3254ab3f044cc04bc4 | 232312fbd691b84ac1e61f1b3d890c2a65718bd4 | diff --git a/translations/CraueConfigBundle.nb.yml b/translations/CraueConfigBundle.nb.yml
index 8c823994d3..b53c128e74 100644
--- a/translations/CraueConfigBundle.nb.yml
+++ b/translations/CraueConfigBundle.nb.yml
@@ -35,3 +35,4 @@ shaarli_share_origin_url: Skru på deling av opprinnelsesnettadresse til Shaarli
matomo... | [
"translations/CraueConfigBundle.nb.yml"
] | [] | true | ||
wallabag/wallabag | 8,851 | issue_to_patch | build(deps-dev): bump postcss from 8.5.14 to 8.5.15 | Bumps [postcss](https://github.com/postcss/postcss) from 8.5.14 to 8.5.15.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/postcss/postcss/releases">postcss's releases</a>.</em></p>
<blockquote>
<h2>8.5.15</h2>
<ul>
<li>Fixed declaration parsing performance (by <a href="https:... | d2db8cadea8297fd1e6ce2c59936dd80d07a4289 | e1dcc1aa6236ae0bea3921f641c657bc0d597b05 | diff --git a/package.json b/package.json
index 370f26ca6e..2c088b735e 100644
--- a/package.json
+++ b/package.json
@@ -63,7 +63,7 @@
"file-loader": "^6.2.0",
"lato-font": "^3.0.0",
"mini-css-extract-plugin": "^2.10.2",
- "postcss": "^8.5.14",
+ "postcss": "^8.5.15",
"postcss-loader": "^8.2.1",... | [
"package.json",
"yarn.lock"
] | [] | true | ||
wallabag/wallabag | 8,850 | issue_to_patch | build(deps-dev): bump webpack from 5.106.2 to 5.107.1 | Bumps [webpack](https://github.com/webpack/webpack) from 5.106.2 to 5.107.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/webpack/webpack/releases">webpack's releases</a>.</em></p>
<blockquote>
<h2>v5.107.1</h2>
<h3>Patch Changes</h3>
<ul>
<li>
<p>Align the experimental HTM... | ef0a7f6f84a2bf9344b935234b13f27fb9461eac | 04eb6377782f89fe68ed40d47b115356c641a6a8 | diff --git a/package.json b/package.json
index a2766f572c..2bd58fef5d 100644
--- a/package.json
+++ b/package.json
@@ -76,7 +76,7 @@
"stylelint-scss": "^5.3.2",
"terser-webpack-plugin": "^5.6.0",
"url-loader": "^4.1.1",
- "webpack": "^5.106.2",
+ "webpack": "^5.107.1",
"webpack-cli": "^6.0.1",... | [
"package.json",
"yarn.lock"
] | [] | true | ||
wallabag/wallabag | 8,848 | issue_to_patch | build(deps-dev): bump sass-embedded from 1.99.0 to 1.100.0 | Bumps [sass-embedded](https://github.com/sass/embedded-host-node) from 1.99.0 to 1.100.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/sass/embedded-host-node/blob/main/CHANGELOG.md">sass-embedded's changelog</a>.</em></p>
<blockquote>
<h2>1.100.0</h2>
<ul>
<li>
<p>Writing two ... | ef0a7f6f84a2bf9344b935234b13f27fb9461eac | c2e81f2f15143f03c007ccfdc01343569b7c673f | diff --git a/package.json b/package.json
index a2766f572c..370f26ca6e 100644
--- a/package.json
+++ b/package.json
@@ -67,7 +67,7 @@
"postcss-loader": "^8.2.1",
"postcss-scss": "^4.0.9",
"regenerator-runtime": "^0.14.1",
- "sass-embedded": "^1.99.0",
+ "sass-embedded": "^1.100.0",
"sass-loader... | [
"package.json",
"yarn.lock"
] | [] | true | ||
wallabag/wallabag | 8,843 | issue_to_patch | build(deps): bump twig/twig from 3.25.0 to 3.26.0 | Bumps [twig/twig](https://github.com/twigphp/Twig) from 3.25.0 to 3.26.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/twigphp/Twig/releases">twig/twig's releases</a>.</em></p>
<blockquote>
<h2>v3.26.0</h2>
<p><strong>Changelog</strong> (<a href="https://github.com/twigphp/... | 5a1f8bcfa6b339484fa6d6f7c21ac3d635d14ece | 5913a6c620aaf01c249870591c24ce4d8366b133 | diff --git a/composer.lock b/composer.lock
index e75ff0d501..273087a6c6 100644
--- a/composer.lock
+++ b/composer.lock
@@ -14097,16 +14097,16 @@
},
{
"name": "twig/twig",
- "version": "v3.25.0",
+ "version": "v3.26.0",
"source": {
"type"... | [
"composer.lock"
] | [] | true | ||
wallabag/wallabag | 8,840 | issue_to_patch | Update vulnerability reporting method | We prefer the builtin tool from GitHub, it's easier for triage. | 15851a79d65d081f77640ba4cf0d18867c173139 | 4d7040f1cbed72ca446f1653154f51b9390e53a4 | diff --git a/SECURITY.md b/SECURITY.md
index ad88c11d11..8a9306ab22 100644
--- a/SECURITY.md
+++ b/SECURITY.md
@@ -2,4 +2,4 @@
## Reporting a Vulnerability
-Please report security issues to `hello@wallabag.org`
+Please report security issues using the [Security Advisories of GitHub](https://github.com/wallabag/wal... | [
"SECURITY.md"
] | [] | true | ||
wallabag/wallabag | 8,838 | issue_to_patch | Translations update from Hosted Weblate | Translations update from [Hosted Weblate](https://hosted.weblate.org) for [wallabag/Messages (web)](https://hosted.weblate.org/projects/wallabag/messages/).
Current translation status:
 | 19968e8b6a754f0605b6ce9b69a4cf85e0dd130c | 1248f3cd324f6c612e13f854c68fd1310054d5e6 | diff --git a/translations/messages.hr.yml b/translations/messages.hr.yml
index 270632f701..32c7f3cf86 100644
--- a/translations/messages.hr.yml
+++ b/translations/messages.hr.yml
@@ -173,8 +173,8 @@ config:
not_equal_to: Nije jednako …
and: Jedno pravilo I jedno drugo
... | [
"translations/messages.hr.yml"
] | [] | true | ||
wallabag/wallabag | 8,835 | issue_to_patch | build(deps): bump twig/twig from 3.24.0 to 3.25.0 in the twig-dependencies group | Bumps the twig-dependencies group with 1 update: [twig/twig](https://github.com/twigphp/Twig).
Updates `twig/twig` from 3.24.0 to 3.25.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/twigphp/Twig/releases">twig/twig's releases</a>.</em></p>
<blockquote>
<h2>v3.25.0</h2>
<p>... | cbe19fb683cc1dc1201680f097c56a7cd6352bf5 | 32702af6dae1140cce89b48494c0277d3cbd2e03 | diff --git a/composer.lock b/composer.lock
index e29c7b26c1..4aa136e139 100644
--- a/composer.lock
+++ b/composer.lock
@@ -14097,16 +14097,16 @@
},
{
"name": "twig/twig",
- "version": "v3.24.0",
+ "version": "v3.25.0",
"source": {
"type"... | [
"composer.lock"
] | [] | true | ||
wallabag/wallabag | 8,836 | issue_to_patch | build(deps-dev): bump friendsofphp/php-cs-fixer from 3.95.1 to 3.95.2 | Bumps [friendsofphp/php-cs-fixer](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer) from 3.95.1 to 3.95.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/releases">friendsofphp/php-cs-fixer's releases</a>.</em></p>
<blockquote>
<h2>v3.95.2 Adalbertus</h2... | cbe19fb683cc1dc1201680f097c56a7cd6352bf5 | 282b8e6d5c9cade39bb01e3ac7e387f4707ef991 | diff --git a/composer.lock b/composer.lock
index e29c7b26c1..b82827561e 100644
--- a/composer.lock
+++ b/composer.lock
@@ -11519,7 +11519,7 @@
},
{
"name": "symfony/polyfill-php84",
- "version": "v1.34.0",
+ "version": "v1.37.0",
"source": {
... | [
"composer.lock"
] | [] | true | ||
wallabag/wallabag | 8,837 | issue_to_patch | build(deps-dev): bump ergebnis/composer-normalize from 2.51.0 to 2.52.0 | Bumps [ergebnis/composer-normalize](https://github.com/ergebnis/composer-normalize) from 2.51.0 to 2.52.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ergebnis/composer-normalize/releases">ergebnis/composer-normalize's releases</a>.</em></p>
<blockquote>
<h2>2.52.0</h2>
<!... | cbe19fb683cc1dc1201680f097c56a7cd6352bf5 | aba41dff92e26d6d96c011dbd8e32db25782f951 | diff --git a/composer.lock b/composer.lock
index e29c7b26c1..25be81659b 100644
--- a/composer.lock
+++ b/composer.lock
@@ -15427,16 +15427,16 @@
},
{
"name": "ergebnis/composer-normalize",
- "version": "2.51.0",
+ "version": "2.52.0",
"source": {
... | [
"composer.lock"
] | [] | true | ||
wallabag/wallabag | 8,823 | issue_to_patch | Translations update from Hosted Weblate | Translations update from [Hosted Weblate](https://hosted.weblate.org) for [wallabag/Messages (web)](https://hosted.weblate.org/projects/wallabag/messages/).
Current translation status:
 | 535e57376f6c33a76113cfd54a5f2c4dedd9e780 | 3c17643f1231aa665fbaf9a7634301e8c5451d35 | diff --git a/translations/messages.ja.yml b/translations/messages.ja.yml
index d0c5f0c481..91ef7de91b 100644
--- a/translations/messages.ja.yml
+++ b/translations/messages.ja.yml
@@ -430,7 +430,7 @@ quickstart:
configure:
title: アプリケーションを構成します
description: あなたに合ったアプリケーションにするために wallabag の構成をご覧くださ... | [
"translations/messages.ja.yml",
"translations/messages.pl.yml"
] | [] | true | ||
wallabag/wallabag | 8,827 | issue_to_patch | build(deps): bump symfony/deprecation-contracts from 3.6.0 to 3.7.0 in the symfony-dependencies group across 1 directory | Bumps the symfony-dependencies group with 1 update in the / directory: [symfony/deprecation-contracts](https://github.com/symfony/deprecation-contracts).
Updates `symfony/deprecation-contracts` from 3.6.0 to 3.7.0
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/symfony/deprecation-contracts/c... | 437ae0e2121ae8e429676216f90084f08f1403ff | 9b19665745a47a8270d33e216a785907073e2a5b | diff --git a/composer.lock b/composer.lock
index 740a76d7fd..e29c7b26c1 100644
--- a/composer.lock
+++ b/composer.lock
@@ -9082,16 +9082,16 @@
},
{
"name": "symfony/deprecation-contracts",
- "version": "v3.6.0",
+ "version": "v3.7.0",
"source": {
... | [
"composer.lock"
] | [] | true | ||
wallabag/wallabag | 8,830 | issue_to_patch | build(deps-dev): bump sass-loader from 16.0.7 to 16.0.8 | Bumps [sass-loader](https://github.com/webpack/sass-loader) from 16.0.7 to 16.0.8.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/webpack/sass-loader/releases">sass-loader's releases</a>.</em></p>
<blockquote>
<h2>v16.0.8</h2>
<h3><a href="https://github.com/webpack/sass-load... | e035bffebdb8907844b2048c2dd58566b4dbeef9 | e68cb02e8d7bdee211b6af3183c85fa83f815fd7 | diff --git a/package.json b/package.json
index b99b55e61d..50ba876546 100644
--- a/package.json
+++ b/package.json
@@ -68,7 +68,7 @@
"postcss-scss": "^4.0.9",
"regenerator-runtime": "^0.14.1",
"sass-embedded": "^1.99.0",
- "sass-loader": "^16.0.7",
+ "sass-loader": "^16.0.8",
"style-loader": "... | [
"package.json",
"yarn.lock"
] | [] | true | ||
wallabag/wallabag | 8,829 | issue_to_patch | build(deps-dev): bump postcss from 8.5.13 to 8.5.14 | Bumps [postcss](https://github.com/postcss/postcss) from 8.5.13 to 8.5.14.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/postcss/postcss/releases">postcss's releases</a>.</em></p>
<blockquote>
<h2>8.5.14</h2>
<ul>
<li>Fixed custom syntax regression (by <a href="https://githu... | e035bffebdb8907844b2048c2dd58566b4dbeef9 | 329c1ff31723752c1ccce84936c08a11bd7180ea | diff --git a/package.json b/package.json
index b99b55e61d..5c116a0a9b 100644
--- a/package.json
+++ b/package.json
@@ -63,7 +63,7 @@
"file-loader": "^6.2.0",
"lato-font": "^3.0.0",
"mini-css-extract-plugin": "^2.10.2",
- "postcss": "^8.5.13",
+ "postcss": "^8.5.14",
"postcss-loader": "^8.2.1",... | [
"package.json",
"yarn.lock"
] | [] | true | ||
wallabag/wallabag | 8,831 | issue_to_patch | build(deps-dev): bump terser-webpack-plugin from 5.5.0 to 5.6.0 | Bumps [terser-webpack-plugin](https://github.com/webpack/minimizer-webpack-plugin) from 5.5.0 to 5.6.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/webpack/minimizer-webpack-plugin/releases">terser-webpack-plugin's releases</a>.</em></p>
<blockquote>
<h2>v5.6.0</h2>
<h3>Mi... | e035bffebdb8907844b2048c2dd58566b4dbeef9 | b2cc0bb16a0aae7931ec59b60eb36be7eff27923 | diff --git a/package.json b/package.json
index b99b55e61d..5450d131ea 100644
--- a/package.json
+++ b/package.json
@@ -74,7 +74,7 @@
"stylelint-config-standard": "^34.0.0",
"stylelint-config-standard-scss": "^11.1.0",
"stylelint-scss": "^5.3.2",
- "terser-webpack-plugin": "^5.5.0",
+ "terser-webpac... | [
"package.json",
"yarn.lock"
] | [] | true | ||
wallabag/wallabag | 8,828 | issue_to_patch | build(deps-dev): bump @babel/preset-env from 7.29.3 to 7.29.5 in the babel-dependencies group | Bumps the babel-dependencies group with 1 update: [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env).
Updates `@babel/preset-env` from 7.29.3 to 7.29.5
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/babel/babel/releases">@babel/preset-en... | e035bffebdb8907844b2048c2dd58566b4dbeef9 | 3b8d578781289962c8c588f0262f10d7f1a5fb84 | diff --git a/package.json b/package.json
index b99b55e61d..c623fddb39 100644
--- a/package.json
+++ b/package.json
@@ -49,7 +49,7 @@
"devDependencies": {
"@babel/core": "^7.29.0",
"@babel/eslint-parser": "^7.28.6",
- "@babel/preset-env": "^7.29.3",
+ "@babel/preset-env": "^7.29.5",
"@codecov/web... | [
"package.json",
"yarn.lock"
] | [] | true | ||
wallabag/wallabag | 8,825 | issue_to_patch | build(deps): bump @babel/plugin-transform-modules-systemjs from 7.29.0 to 7.29.4 | Bumps [@babel/plugin-transform-modules-systemjs](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-modules-systemjs) from 7.29.0 to 7.29.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/babel/babel/releases">@babel/plugin-transform-modules-systemjs's ... | 836a672405527fd3a0c8110472362e824901edea | 2b42cd31fc758b10520f5949418a0c854b43cf63 | diff --git a/yarn.lock b/yarn.lock
index 0372d7da79..21a8dc3554 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -535,9 +535,9 @@
"@babel/helper-plugin-utils" "^7.28.6"
"@babel/plugin-transform-modules-systemjs@^7.29.0":
- version "7.29.0"
- resolved "https://registry.yarnpkg.com/@babel/plugin-transform-modules-syst... | [
"yarn.lock"
] | [] | true | ||
wallabag/wallabag | 8,824 | issue_to_patch | build(deps): bump fast-uri from 3.1.0 to 3.1.2 | Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.0 to 3.1.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/fastify/fast-uri/releases">fast-uri's releases</a>.</em></p>
<blockquote>
<h2>v3.1.2</h2>
<h2>⚠️ Security Release</h2>
<ul>
<li>Fix for <a href="https://g... | 5c9e7b4ae95a5640f8fb31b6950b2022469d76a2 | a9e93aa04a7ecd3a2bb8a7f21025f050ceb08158 | diff --git a/yarn.lock b/yarn.lock
index a7f958ecd9..0372d7da79 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -2824,9 +2824,9 @@ fast-levenshtein@^2.0.6:
integrity sha512-DCXu6Ifhqcks7TZKY3Hxp3y6qphY5SJZmrWMDrKcERSOXWQdMhU9Ig/PYrzyw/ul9jOIyh0N4M0tbC5hodg8dw==
fast-uri@^3.0.1:
- version "3.1.0"
- resolved "https://r... | [
"yarn.lock"
] | [] | true | ||
wallabag/wallabag | 8,820 | issue_to_patch | build(deps): bump phpseclib/phpseclib from 3.0.51 to 3.0.52 | Bumps [phpseclib/phpseclib](https://github.com/phpseclib/phpseclib) from 3.0.51 to 3.0.52.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/phpseclib/phpseclib/releases">phpseclib/phpseclib's releases</a>.</em></p>
<blockquote>
<h2>3.0.52</h2>
<ul>
<li>ASN1: more stringent OID ... | d957bceb6f2d5134b9938cf99e3cfce4e02f5a80 | 0aed06fc6924156f6fb78ef8c70222f1664a8106 | diff --git a/composer.lock b/composer.lock
index 6f73f3d3b3..740a76d7fd 100644
--- a/composer.lock
+++ b/composer.lock
@@ -6563,16 +6563,16 @@
},
{
"name": "phpseclib/phpseclib",
- "version": "3.0.51",
+ "version": "3.0.52",
"source": {
... | [
"composer.lock"
] | [] | true | ||
wallabag/wallabag | 8,812 | issue_to_patch | Update development Dockerfile | | Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? |
| Documentation | no
| Translation | no
| CHANGELOG.md | no
| License | MIT
- Update php 8.2 base image to debian trixie
- Update nodejs from 20 to 24
... | 0a95ed9925d3e9365ad4f37f78ebebfa70805a32 | 71c9201fd7d21dc1ce81c834440ad80b80cd6ab5 | diff --git a/docker/php/Dockerfile b/docker/php/Dockerfile
index 7f05633087..ecf7cc0758 100644
--- a/docker/php/Dockerfile
+++ b/docker/php/Dockerfile
@@ -1,16 +1,16 @@
-FROM golang as envsubst
+FROM golang AS envsubst
-ARG ENVSUBST_VERSION=v1.3.0
+ARG ENVSUBST_VERSION=v1.4.3
# envsubst from gettext can not replac... | [
"docker/php/Dockerfile"
] | [
{
"comment": "I'd not update this. I think the dev env should be aligned with the minimum supported version, and as of now it's 8.2.\nWe can of course maybe reopen the discussion to bump the minimum version to 8.4 😁",
"path": "docker/php/Dockerfile",
"hunk": "@@ -1,25 +1,24 @@\n-FROM golang as envsubst... | true | ||
wallabag/wallabag | 8,812 | comment_to_fix | Update development Dockerfile | I'd not update this. I think the dev env should be aligned with the minimum supported version, and as of now it's 8.2.
We can of course maybe reopen the discussion to bump the minimum version to 8.4 😁 | 0a95ed9925d3e9365ad4f37f78ebebfa70805a32 | 71c9201fd7d21dc1ce81c834440ad80b80cd6ab5 | diff --git a/docker/php/Dockerfile b/docker/php/Dockerfile
index 7f05633087..ecf7cc0758 100644
--- a/docker/php/Dockerfile
+++ b/docker/php/Dockerfile
@@ -1,16 +1,16 @@
-FROM golang as envsubst
+FROM golang AS envsubst
-ARG ENVSUBST_VERSION=v1.3.0
+ARG ENVSUBST_VERSION=v1.4.3
# envsubst from gettext can not replac... | [
"docker/php/Dockerfile"
] | [
{
"comment": "I'd not update this. I think the dev env should be aligned with the minimum supported version, and as of now it's 8.2.\nWe can of course maybe reopen the discussion to bump the minimum version to 8.4 😁",
"path": "docker/php/Dockerfile",
"hunk": "@@ -1,25 +1,24 @@\n-FROM golang as envsubst... | true | ||
wallabag/wallabag | 8,812 | comment_to_fix | Update development Dockerfile | have you checked those new versions are OK with php 8.2? if yes then fine for me | 0a95ed9925d3e9365ad4f37f78ebebfa70805a32 | 71c9201fd7d21dc1ce81c834440ad80b80cd6ab5 | diff --git a/docker/php/Dockerfile b/docker/php/Dockerfile
index 7f05633087..ecf7cc0758 100644
--- a/docker/php/Dockerfile
+++ b/docker/php/Dockerfile
@@ -1,16 +1,16 @@
-FROM golang as envsubst
+FROM golang AS envsubst
-ARG ENVSUBST_VERSION=v1.3.0
+ARG ENVSUBST_VERSION=v1.4.3
# envsubst from gettext can not replac... | [
"docker/php/Dockerfile"
] | [
{
"comment": "have you checked those new versions are OK with php 8.2? if yes then fine for me",
"path": "docker/php/Dockerfile",
"hunk": "@@ -59,9 +58,9 @@ RUN docker-php-ext-install -j \"$(nproc)\" \\\n tidy \\\n zip\n \n-RUN pecl install redis-6.1.0 \\\n- && pecl install imagick-3.... | true | ||
wallabag/wallabag | 8,790 | issue_to_patch | Show tags in EPUBs and PDFs
**Is your feature request related to a problem? Please describe.**
I read articles with KOReader on my Kobo (and was even [featured on your blog](https://wallabag.it/en/blog/2025/06/04/reading-blogs-on-my-kobo-e-reader-via-wallabag-by-jan-ouwens/) 😄)
When I save an article I always add a t... | Add tags to EPUB and PDF exports | | Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Documentation | no
| Translation | no
| CHANGELOG.md | no
| License | MIT
Fixes #8789
It adds 1 string to the list of messages. Since the text a... | 181c455de253829c7280e8aa3407ac9d8413ff66 | c672c86d9fc1500dc79e5f5affdfa2e5a69770b0 | diff --git a/src/Helper/EntriesExport.php b/src/Helper/EntriesExport.php
index b30f085eaf..1cf478737c 100644
--- a/src/Helper/EntriesExport.php
+++ b/src/Helper/EntriesExport.php
@@ -207,6 +207,8 @@ private function produceEpub(): Response
$readingTime = round($entry->getReadingTime() / $user->getConfig(... | [
"src/Helper/EntriesExport.php",
"translations/messages.be.yml",
"translations/messages.cs.yml",
"translations/messages.de.yml",
"translations/messages.el.yml",
"translations/messages.en.yml",
"translations/messages.es.yml",
"translations/messages.fr.yml",
"translations/messages.gl.yml",
"translati... | [] | true | |
wallabag/wallabag | 8,814 | issue_to_patch | build(deps-dev): bump postcss from 8.5.12 to 8.5.13 | Bumps [postcss](https://github.com/postcss/postcss) from 8.5.12 to 8.5.13.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/postcss/postcss/releases">postcss's releases</a>.</em></p>
<blockquote>
<h2>8.5.13</h2>
<ul>
<li>Fixed <code>postcss-scss</code> commend regression.</li>
... | 4a8d09fb267d7107d611ec3de881a5a90f7d1758 | 00d6c795ce0ced774f461cce6314b981c1fbcd15 | diff --git a/package.json b/package.json
index 92c1278bab..a9c889756b 100644
--- a/package.json
+++ b/package.json
@@ -63,7 +63,7 @@
"file-loader": "^6.2.0",
"lato-font": "^3.0.0",
"mini-css-extract-plugin": "^2.10.2",
- "postcss": "^8.5.12",
+ "postcss": "^8.5.13",
"postcss-loader": "^8.2.1",... | [
"package.json",
"yarn.lock"
] | [] | true | ||
wallabag/wallabag | 8,816 | issue_to_patch | build(deps): bump j0k3r/graby-site-config from 1.0.210 to 1.0.211 | Bumps [j0k3r/graby-site-config](https://github.com/j0k3r/graby-site-config) from 1.0.210 to 1.0.211.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/j0k3r/graby-site-config/commit/5931e37710ddef43fa5c67198b6f77359cbd6027"><code>5931e37</code></a> Merge remote-tracking branch 'upstream/master'<... | 4a8d09fb267d7107d611ec3de881a5a90f7d1758 | 91c000317304316e2556aae7fb354d0684d255ad | diff --git a/composer.lock b/composer.lock
index d2e406e0fc..6f73f3d3b3 100644
--- a/composer.lock
+++ b/composer.lock
@@ -4105,16 +4105,16 @@
},
{
"name": "j0k3r/graby-site-config",
- "version": "1.0.210",
+ "version": "1.0.211",
"source": {
... | [
"composer.lock"
] | [] | true | ||
wallabag/wallabag | 8,815 | issue_to_patch | build(deps): bump mathjax from 4.1.1 to 4.1.2 | Bumps [mathjax](https://github.com/mathjax/MathJax) from 4.1.1 to 4.1.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/mathjax/MathJax/releases">mathjax's releases</a>.</em></p>
<blockquote>
<h2>MathJax v4.1.2</h2>
<p>This is mainly a bug fix release that resolves a number o... | 4a8d09fb267d7107d611ec3de881a5a90f7d1758 | f7cf2d7d4adf30e26adcf154c4d135f8967b5649 | diff --git a/package.json b/package.json
index 92c1278bab..9dd73cefaa 100644
--- a/package.json
+++ b/package.json
@@ -96,7 +96,7 @@
"icomoon-free-npm": "^0.0.0",
"jr-qrcode": "^1.2.1",
"material-design-icons-iconfont": "^6.7.0",
- "mathjax": "^4.1.1",
+ "mathjax": "^4.1.2",
"mousetrap": "^1.6... | [
"package.json",
"yarn.lock"
] | [] | true | ||
wallabag/wallabag | 8,813 | issue_to_patch | build(deps-dev): bump @babel/preset-env from 7.29.2 to 7.29.3 in the babel-dependencies group | Bumps the babel-dependencies group with 1 update: [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env).
Updates `@babel/preset-env` from 7.29.2 to 7.29.3
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/babel/babel/releases">@babel/preset-en... | 4a8d09fb267d7107d611ec3de881a5a90f7d1758 | c88dc54c5fdeff33628c639a1729c61de1d7eedd | diff --git a/package.json b/package.json
index 92c1278bab..6cd2519abe 100644
--- a/package.json
+++ b/package.json
@@ -49,7 +49,7 @@
"devDependencies": {
"@babel/core": "^7.29.0",
"@babel/eslint-parser": "^7.28.6",
- "@babel/preset-env": "^7.29.2",
+ "@babel/preset-env": "^7.29.3",
"@codecov/web... | [
"package.json",
"yarn.lock"
] | [] | true | ||
wallabag/wallabag | 8,804 | issue_to_patch | Bump to Node 24 | Bump `@symfony/webpack-encore` & `webpack-cli` as well.
Remove `webpack-manifest-plugin` because we don't use directly.
This will also fix some Dependabot alerts. | 0abc85369e1760f7766ec5807713716e7cfa9e6c | 4ac3ac45f6a4928b803f75f93ebfed1b557dee74 | diff --git a/.nvmrc b/.nvmrc
index 209e3ef4b6..a45fd52cc5 100644
--- a/.nvmrc
+++ b/.nvmrc
@@ -1,1 +1,1 @@
-20
+24
diff --git a/package.json b/package.json
index 938febd088..9aaaf80b78 100644
--- a/package.json
+++ b/package.json
@@ -7,7 +7,7 @@
"doc": "docs"
},
"engines": {
- "node": ">=20"
+ "node": ... | [
".nvmrc",
"package.json",
"yarn.lock"
] | [] | true | ||
wasm3/wasm3 | 492 | issue_to_patch | zig build: updated to v0.13.0 | https://ziglang.org/download/0.13.0/release-notes.html
changes:
- update zig version
- switch between build libwasm3 only or wasm3+libwasm3 (since v0.11.0, help zig-pkg manager [a.k.a zon-file])
e.g.: https://github.com/kassane/wasm3-d/blob/main/build.zig.zon
close #454
cc: @vshymanskyy | 139076a98b8321b67f850a844f558b5e91b5ac83 | 3e99a4d867d42b0716965b38d4c7a80c1d475431 | diff --git a/.gitignore b/.gitignore
index cc890e17..e88fdf77 100644
--- a/.gitignore
+++ b/.gitignore
@@ -11,3 +11,4 @@ __pycache__/
.settings
.vscode
.DS_Store
+*zig-*/
\ No newline at end of file
diff --git a/build.zig b/build.zig
index 6679f06a..d7740766 100644
--- a/build.zig
+++ b/build.zig
@@ -1,39 +1,84 @@
... | [
".gitignore",
"build.zig"
] | [] | true | ||
wasm3/wasm3 | 496 | issue_to_patch | [WASM Proposal] Custom page size | f37749cb4ca67f995ec9e2745bf86e72c04e3420 | 92a4b035b4c029707cf056e44c0d27fdf905caec | diff --git a/source/m3_core.h b/source/m3_core.h
index c470c3bd..daf37cc6 100644
--- a/source/m3_core.h
+++ b/source/m3_core.h
@@ -157,7 +157,7 @@ M3CodePageHeader;
#define d_m3CodePageFreeLinesThreshold 4+2 // max is: select _sss & CallIndirect + 2 for bridge
-#define d_m3MemPageSize ... | [
"source/m3_core.h",
"source/m3_env.c",
"source/m3_env.h",
"source/m3_info.c",
"source/m3_parse.c"
] | [] | true | |||
wasm3/wasm3 | 503 | issue_to_patch | readme: add wasm3-d | url: https://github.com/kassane/wasm3-d | 35b5e2fb53c5cbc1ff3d7e42c381cd7cfa14f308 | b4a3a9a629efbea904c5a0ae9097367d9f5474af | diff --git a/README.md b/README.md
index 6a60f36d..6b558802 100644
--- a/README.md
+++ b/README.md
@@ -27,6 +27,7 @@ Wasm3 can also be used as a library for:
[<img src="https://cdn.jsdelivr.net/gh/simple-icons/simple-icons@develop/icons/python.svg" width="18" height="18" /> Python3](https://github.com/wasm3/pywasm3) │... | [
"README.md"
] | [] | true | ||
wasm3/wasm3 | 502 | issue_to_patch | Update Cookbook.md | Replace obsolete calls with `local.get`. | 35b5e2fb53c5cbc1ff3d7e42c381cd7cfa14f308 | 9a4356fe931b974d62411a18345d3de992317b89 | diff --git a/docs/Cookbook.md b/docs/Cookbook.md
index ba53fa6c..a1e9c582 100644
--- a/docs/Cookbook.md
+++ b/docs/Cookbook.md
@@ -262,8 +262,8 @@ Create `swap.wat`:
```wat
(module
(func (export "swap") (param i32 i32) (result i32 i32)
- (get_local 1)
- (get_local 0)
+ (local.get 1)
+ (local.get 0)
... | [
"docs/Cookbook.md"
] | [] | true | ||
wasm3/wasm3 | 498 | issue_to_patch | Unexpected behavior on the instruction `memory.grow`
## Description
### Current State
Output 1 and there is zero page in the memory.
### Expected State
Output 0xffffffff and there is one page in the memory.
## Environment
- Code Version: git commit id 772f8f4648fcba75f77f894a6050db121e7651a2
- Hardwar... | fix: memory.grow by a negative number is an error | This is to comply with e.g. wasmtime. The spec does not make it explicit what growing by a negative number should mean. It's likely a mistake, so let's fail.
Closes #442. | 256cd37bbd654c6b3dc1f7523ebc651ee4a87989 | dfb374b1d43046d3b4d56eb655c17ce19b4eef8b | diff --git a/source/m3_exec.h b/source/m3_exec.h
index 0d556763..7fa7f461 100644
--- a/source/m3_exec.h
+++ b/source/m3_exec.h
@@ -708,18 +708,24 @@ d_m3Op (MemGrow)
IM3Runtime runtime = m3MemRuntime(_mem);
IM3Memory memory = & runtime->memory;
- u32 numPagesToGrow = (u32) _r0;
- ... | [
"source/m3_exec.h",
"test/regression/github-442.wasm",
"test/regression/github-442.wat"
] | [] | diff --git a/test/regression/github-442.wasm b/test/regression/github-442.wasm
new file mode 100644
index 00000000..c055a0a5
Binary files /dev/null and b/test/regression/github-442.wasm differ
diff --git a/test/regression/github-442.wat b/test/regression/github-442.wat
new file mode 100644
index 00000000..fdce5d5b
--- ... | true |
wasm3/wasm3 | 489 | issue_to_patch | [Security] Out-of-Bound Memory Write on "op_CopySlot_64" Function
### Environment
```shell
OS : Linux 5.15.146.1-microsoft-standard-WSL2 #1 SMP Thu Jan 11 04:09:03 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Commit : 139076a98b8321b67f850a844f558b5e91b5ac83
Version : 0.5.0
Clang Ver... | fix: Makes CopyStackSlotsR use numSlots. | Closes #471. | 139076a98b8321b67f850a844f558b5e91b5ac83 | 7ebf4947886387a0916f3798e3ef15b36196e8b4 | diff --git a/source/m3_compile.c b/source/m3_compile.c
index 9d879374..953e8bf5 100644
--- a/source/m3_compile.c
+++ b/source/m3_compile.c
@@ -1039,7 +1039,7 @@ _ (CopyStackIndexToSlot (o, targetSlot, i_stackIndex));
}
-_ (CopyStackSlotsR (o, i_targetSlotStackIndex + 1, i_stackIndex + 1, i_... | [
"source/m3_compile.c",
"test/regression/github-471.wasm",
"test/regression/github-471.wat"
] | [] | diff --git a/test/regression/github-471.wasm b/test/regression/github-471.wasm
new file mode 100644
index 00000000..ef18700e
Binary files /dev/null and b/test/regression/github-471.wasm differ
diff --git a/test/regression/github-471.wat b/test/regression/github-471.wat
new file mode 100644
index 00000000..002c2326
--- ... | true |
wasm3/wasm3 | 491 | issue_to_patch | Segmentation fault due to illegal write access
## Describe the Bug
While executing a specific WebAssembly file using `wasm3` with the _main function specified, a segmentation fault is encountered, leading to an abrupt termination of the program. Possibly stems from `op_CopySlot_32`
`wasm3 --version`:
iWasm3 v0... | fix: Adjust number of values when handling f32 in block results. | Fixes #465. | 139076a98b8321b67f850a844f558b5e91b5ac83 | de728d9c4b46f663f2d92bcfc93ef6213b1c07ba | diff --git a/source/m3_compile.c b/source/m3_compile.c
index 9d879374..c93f8234 100644
--- a/source/m3_compile.c
+++ b/source/m3_compile.c
@@ -1078,18 +1078,21 @@ M3Result ResolveBlockResults (IM3Compilation o, IM3CompilationScope i_targetBl
if (numValues)
{
u16 endIndex = GetStackTopIndex (o) + 1;... | [
"source/m3_compile.c",
"test/regression/github-465.wasm",
"test/regression/github-465.wat"
] | [] | diff --git a/test/regression/github-465.wasm b/test/regression/github-465.wasm
new file mode 100644
index 00000000..aa2d7464
Binary files /dev/null and b/test/regression/github-465.wasm differ
diff --git a/test/regression/github-465.wat b/test/regression/github-465.wat
new file mode 100644
index 00000000..2472280c
--- ... | true |
wasm3/wasm3 | 490 | issue_to_patch | memory leaks in Read_utf8
## Version
139076a98b8321b67f850a844f558b5e91b5ac83
## Build
```
cmake -DCMAKE_C_COMPILER="gcc" -DCMAKE_C_FLAGS="-g -fsanitize=address -fno-omit-frame-pointer" -DCMAKE_EXE_LINKER_FLAGS="-g -fsanitize=address -fno-omit-frame-pointer" .
make
```
## ASAN log
```
Error: [Fatal] rep... | fix: Releases M3Module.memoryImport. | Fixes #462 | 139076a98b8321b67f850a844f558b5e91b5ac83 | 10ea64470542c133c6c9d502135a9a250d4aaa90 | diff --git a/source/m3_module.c b/source/m3_module.c
index 5742db65..507981df 100644
--- a/source/m3_module.c
+++ b/source/m3_module.c
@@ -40,6 +40,7 @@ void m3_FreeModule (IM3Module i_module)
FreeImportInfo(&(i_module->globals[i].import));
}
m3_Free (i_module->globals);
+ FreeIm... | [
"source/m3_module.c",
"test/regression/github-462.wasm",
"test/regression/github-462.wat"
] | [] | diff --git a/test/regression/github-462.wasm b/test/regression/github-462.wasm
new file mode 100644
index 00000000..00389a61
Binary files /dev/null and b/test/regression/github-462.wasm differ
diff --git a/test/regression/github-462.wat b/test/regression/github-462.wat
new file mode 100644
index 00000000..a188e051
--- ... | true |
wasm3/wasm3 | 450 | issue_to_patch | bugfix: use gcc/clang compatible overflow builtins for integer arithmetic | [as the spec states](https://webassembly.github.io/spec/core/exec/numerics.html#op-iadd) integer add, sub, and mul should wrap on overflow.
the current implementation adds two signed integers, which is undefined behavior on overflow per the C standard (in my case, this triggered an `illegal execution`). this bugfix ... | d28e14f3521f58ab836ce8a4609427ef5384cdf4 | 52d6a0c6dee0f6385beb49bc32bf1b8db3a1bd56 | diff --git a/source/m3_exec.h b/source/m3_exec.h
index 1b84a449..0d556763 100644
--- a/source/m3_exec.h
+++ b/source/m3_exec.h
@@ -152,8 +152,8 @@ d_m3CommutativeOpMacro(RES, REG, TYPE,NAME, OP, ##__VA_ARGS__)
#define d_m3CommutativeOpMacro_f(TYPE, NAME, MACRO, ...) d_m3CommutativeOpMacro (_fp0, _fp0, TYPE, NAME, ... | [
"source/m3_exec.h"
] | [] | true | ||
wasm3/wasm3 | 417 | issue_to_patch | `m3_SetGlobal()` affects constant exports
1. Convert the following to binary, and save the result as `const_global.wasm`:
```
(module
(global $g5 (export "global-const-i32") i32 (i32.const 255))
)
```
2. Save the following as `demo.c`:
```
#include <stdio.h>
#include <assert.h>
#include "source/wasm3.h"
... | Check global mutability | Fix to check the global mutability before setting new value.
resolve #319
| c53a34315d38a6fc94ab17711a4e91f8ea73e9d8 | 33de650bca9dbf56dbbaca5f3efc49f11159bf08 | diff --git a/source/m3_env.c b/source/m3_env.c
index 231ab298..0d3362bc 100644
--- a/source/m3_env.c
+++ b/source/m3_env.c
@@ -666,8 +666,7 @@ M3Result m3_SetGlobal (IM3Global i_global,
const IM3TaggedValue i_value)
{
if (not i_global) return m3Err_globalLookupFail... | [
"source/m3_env.c"
] | [] | true | |
wasm3/wasm3 | 449 | issue_to_patch | Allow for retrieval of "memory" type import / export name | Adds a `module->memoryImport` (for import module/field names), and `module->memoryExportName` (for exported name) fields to the `M3Module` struct, and populates those values when appropriate during `m3_ParseModule()`.
Somewhat related to #110 and #137. | 772f8f4648fcba75f77f894a6050db121e7651a2 | 67a1e830c3f403f4e6c4ccdc127171a8c29ef0ac | diff --git a/source/m3_env.h b/source/m3_env.h
index 61839987..ff11f515 100644
--- a/source/m3_env.h
+++ b/source/m3_env.h
@@ -110,9 +110,12 @@ typedef struct M3Module
IM3Function * table0;
u32 table0Size;
+ const char* table0ExportName;
M3MemoryInfo ... | [
"source/m3_env.h",
"source/m3_parse.c"
] | [] | true | ||
wasm3/wasm3 | 448 | issue_to_patch | Allow invoking functions by their TableIndex
When passing Wasm function to the host as a callback, it's passed as an index in the table.
Wasm3 needs to provide an API to call such functions. | Add `m3_GetTableFunction` to allow calling functions by index | Resolves #101.
Rather than directly invoking functions by their index, this just allows `IM3Function` instances to be obtained by index, so they can then be called with the standard call functions. | 772f8f4648fcba75f77f894a6050db121e7651a2 | 46be94c96ad73ac63d8c623315d706a6456c664e | diff --git a/source/m3_env.c b/source/m3_env.c
index 231ab298..9e2ea1af 100644
--- a/source/m3_env.c
+++ b/source/m3_env.c
@@ -751,6 +751,33 @@ _ (CompileFunction (function))
return result;
}
+
+M3Result m3_GetTableFunction (IM3Function * o_function, IM3Module i_module, uint32_t i_index)
+{
+ M3R... | [
"source/m3_env.c",
"source/wasm3.h"
] | [] | true | |
wasm3/wasm3 | 436 | issue_to_patch | Fix the issue of incorrectly freeing the stack address when unwinding local functions. | The statement [`runtime->stack = stack_backup;`](https://github.com/wasm3/wasm3/blob/772f8f4648fcba75f77f894a6050db121e7651a2/source/m3_exec.h#L651) during local function unwinding may not be executed.
This ultimately leads to using the wrong address when freeing the stack. | 772f8f4648fcba75f77f894a6050db121e7651a2 | 8911eba9c72e4e94285bc431d83849619d217256 | diff --git a/source/m3_env.c b/source/m3_env.c
index 231ab298..23238609 100644
--- a/source/m3_env.c
+++ b/source/m3_env.c
@@ -181,11 +181,12 @@ IM3Runtime m3_NewRuntime (IM3Environment i_environment, u32 i_stackSizeInBytes
runtime->environment = i_environment;
runtime->userdata = i_userdata;
- ... | [
"source/m3_env.c",
"source/m3_env.h"
] | [] | true | ||
wasm3/wasm3 | 434 | issue_to_patch | Disable tail calls on emscripten | Tail call support for browsers seems experimental. I could only find it implemented in chrome. Firefox still has an open issue https://bugzilla.mozilla.org/show_bug.cgi?id=1571996
This PR disables it by default unless you define `M3_HAS_TAIL_CALL 1` manually | 772f8f4648fcba75f77f894a6050db121e7651a2 | 712b7aefea6abca7de85d1e7c6d3ff6165c96182 | diff --git a/source/m3_config_platforms.h b/source/m3_config_platforms.h
index 50b86ac8..bd66630d 100644
--- a/source/m3_config_platforms.h
+++ b/source/m3_config_platforms.h
@@ -82,7 +82,15 @@
# endif
# endif
-# if M3_COMPILER_HAS_ATTRIBUTE(musttail)
+# if !defined(M3_HAS_TAIL_CALL)
+# if defined(__EMSCRIPTEN__)... | [
"source/m3_config_platforms.h"
] | [] | true | ||
wasm3/wasm3 | 439 | issue_to_patch | Fix resource leaks | (I have no experience with this code base so someone should probably review this before merging.) | 772f8f4648fcba75f77f894a6050db121e7651a2 | ff4591c1fe5d0d280ece9c170ed1f496dd61d4a1 | diff --git a/platforms/app/main.c b/platforms/app/main.c
index eb18aa5e..5048a655 100644
--- a/platforms/app/main.c
+++ b/platforms/app/main.c
@@ -198,8 +198,10 @@ M3Result repl_load_hex (u32 fsize)
hex_idx = 0;
}
}
- if (!fgets(hex, 3, stdin)) // Consume a newline
+ ... | [
"platforms/app/main.c"
] | [] | true | ||
wasm3/wasm3 | 435 | issue_to_patch | modify cpp sdk inorder to match ISOstd:latest | 772f8f4648fcba75f77f894a6050db121e7651a2 | fcb0a83e5bf0c1fc9e63b3bc98da6fa19381e9ec | diff --git a/platforms/cpp/wasm3_cpp/include/wasm3_cpp.h b/platforms/cpp/wasm3_cpp/include/wasm3_cpp.h
index 7ef016f8..2c511d4c 100644
--- a/platforms/cpp/wasm3_cpp/include/wasm3_cpp.h
+++ b/platforms/cpp/wasm3_cpp/include/wasm3_cpp.h
@@ -11,7 +11,11 @@
#include <iterator>
#include <cassert>
+extern "C"
+{
#includ... | [
"platforms/cpp/wasm3_cpp/include/wasm3_cpp.h"
] | [] | true | |||
wasm3/wasm3 | 412 | issue_to_patch | Fix functions with musttail attribute | When `OpProfiling` or `OpTracing` is enabled, wasm3 fails to build with clang-16 because the signature of the function with `__attribute__(musttail)` are incompatible with the calling function. For instance, the funciton `profileOp` has 6 parameters, but its caller function `RunCode` only has 5. Therefore, to satisfy ... | 045040a97345e636b8be4f3086e6db59cdcc785f | 1416c598e89c2e571b1da03cd6ffc1087b7b5e21 | diff --git a/source/m3_env.c b/source/m3_env.c
index 231ab298..cdb7579f 100644
--- a/source/m3_env.c
+++ b/source/m3_env.c
@@ -297,8 +297,12 @@ M3Result EvaluateExpression (IM3Module i_module, void * o_expressed, u8 i_type
if (not result)
{
+# if (d_m3EnableOpProfiling || d_m3EnableOpTracing)
+ ... | [
"source/m3_env.c",
"source/m3_exec.h",
"source/m3_exec_defs.h"
] | [] | true | ||
wasm3/wasm3 | 415 | issue_to_patch | update to uvwasi 0.0.14 | This bumps the uvwasi dependency version
from 0.0.12 (Nov 2021) to 0.0.14 (Dec 2022). | 045040a97345e636b8be4f3086e6db59cdcc785f | 612f62b17036f3cbed9300fce1c976988a85b06f | diff --git a/CMakeLists.txt b/CMakeLists.txt
index 2334652a..b2488a42 100755
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -199,7 +199,7 @@ elseif(BUILD_WASI MATCHES "uvwasi")
FetchContent_Declare(
uvwasi
GIT_REPOSITORY https://github.com/nodejs/uvwasi.git
- GIT_TAG b599542f7ce001e04cdff9db82b05fee96bb33... | [
"CMakeLists.txt"
] | [] | true | ||
wasm3/wasm3 | 410 | issue_to_patch | Fix build.zig file for Zig 0.10 | `addIncludeDir()` was renamed to `addIncludePath()`. | 011597ecea739399daa36f1a138b9b5e18672d6d | 4002e5d7cb8f53f579381861318073e12cef6cc8 | diff --git a/build.zig b/build.zig
index fe962e97..6679f06a 100644
--- a/build.zig
+++ b/build.zig
@@ -14,7 +14,7 @@ pub fn build(b: *std.build.Builder) !void {
wasm3.linkSystemLibrary("wasi-emulated-process-clocks");
}
- wasm3.addIncludeDir("source");
+ wasm3.addIncludePath("source");
wasm3.... | [
"build.zig"
] | [] | true | ||
wasm3/wasm3 | 403 | issue_to_patch | Bump up some default limits to align with mainstream wasm implementations | This commit bumps up some default limit values to align with some mainstream implementations, and allows wasm3 to execute some larger wasm32 modules that it would previously report errors like "too many functions" and such. There are specialized m3_core.h for more restricted platforms, and this commit doesn't touch tho... | fa18e9ece4dd45371deac69ded32838470a55c1b | 95767add8580bbeee7e0e3394e10e7aca85f22cf | diff --git a/source/m3_core.h b/source/m3_core.h
index 802a265e..c470c3bd 100644
--- a/source/m3_core.h
+++ b/source/m3_core.h
@@ -162,14 +162,14 @@ M3CodePageHeader;
#define d_m3Reg0SlotAlias 60000
#define d_m3Fp0SlotAlias (d_m3Reg0SlotAlias + 2)
-#define d_m3MaxSaneTypesCount ... | [
"source/m3_core.h"
] | [] | true | ||
wasm3/wasm3 | 388 | issue_to_patch | Added Nim Bindings to readme | fa18e9ece4dd45371deac69ded32838470a55c1b | 15ceda4e79f3d6f8902e7745d14d8df35a12da4e | diff --git a/README.md b/README.md
index 454d8028..d28f7892 100644
--- a/README.md
+++ b/README.md
@@ -39,8 +39,8 @@ Wasm3 can also be used as a library for:
[<img src="https://cdn.jsdelivr.net/gh/simple-icons/simple-icons@develop/icons/perl.svg" width="18" height="18" /> Perl](https://metacpan.org/pod/Wasm::Wasm3)
... | [
"README.md"
] | [] | true | |||
wasm3/wasm3 | 391 | issue_to_patch | fix consts limit bug | Reserve numConstantSlots should make sure less than d_m3MaxConstantTableSize. Or it will fail in `PushConst`:
```c
d_m3Assert(constTableIndex < d_m3MaxConstantTableSize);
``` | fa18e9ece4dd45371deac69ded32838470a55c1b | 93657d2c6ee15760a6286ea2ea4fe56c1a63760c | diff --git a/source/m3_compile.c b/source/m3_compile.c
index 246e0643..9d879374 100644
--- a/source/m3_compile.c
+++ b/source/m3_compile.c
@@ -2806,14 +2806,17 @@ M3Result ReserveConstants (IM3Compilation o)
while (wa < o->wasmEnd)
{
u8 code = * wa++;
+ u16 addSlots = 0;
if (code ... | [
"source/m3_compile.c"
] | [] | true | ||
wasm3/wasm3 | 393 | issue_to_patch | Remove alignment attributes defined as vectorcall. The compiler inte… | …rprets this as an alignment requirement on the pointer itself, not what it points to, which is probably not what was intended. | fa18e9ece4dd45371deac69ded32838470a55c1b | 5049049a98d3b3c2383f520a6d9668e94f17de43 | diff --git a/source/m3_config_platforms.h b/source/m3_config_platforms.h
index 43de54ba..50b86ac8 100644
--- a/source/m3_config_platforms.h
+++ b/source/m3_config_platforms.h
@@ -127,9 +127,9 @@ typedef int8_t i8;
# if defined (M3_COMPILER_MSVC)
# define vectorcall // For MSVC, better not to specify any ... | [
"source/m3_config_platforms.h"
] | [] | true | ||
wasm3/wasm3 | 397 | issue_to_patch | Fix: typos | Fix: typos | fa18e9ece4dd45371deac69ded32838470a55c1b | 42beb9aa191fec455d149350111c2a5a89a0b84b | diff --git a/docs/Interpreter.md b/docs/Interpreter.md
index 67f2688a..e3ffe43a 100644
--- a/docs/Interpreter.md
+++ b/docs/Interpreter.md
@@ -62,7 +62,7 @@ This rough information might not be immediately intelligible without referencing
* Bytecode/opcodes are translated into more efficient "operations" during a com... | [
"docs/Interpreter.md"
] | [] | true | ||
wasm3/wasm3 | 402 | issue_to_patch | op_Entry and op_Load instructions cannot get tail-call optimized in certain cases.
The op_Entry and op_Load instructions call `memcpy` with a pointer argument to local variables.
If the compiler cannot analyze memcpy source code, it must expect that a pointer to stack memory "escaped" into global context.
The recurs... | Fix operations preventing tail-call-elimination: | If the compiler cannot analyze memcpy, it must expect that pointer arguments may be stored as static data and must live for recursive calls. In such cases, op_Store and op_Load operations will not get tail-call optimized. By enclosing the local variables in a block before the recursive call, the storage duration does n... | fa18e9ece4dd45371deac69ded32838470a55c1b | ea049bc084876973f07d4b3848b1c83e37e91f40 | diff --git a/source/m3_exec.h b/source/m3_exec.h
index 817c5638..47258eb5 100644
--- a/source/m3_exec.h
+++ b/source/m3_exec.h
@@ -1302,12 +1302,14 @@ d_m3Op(DEST_TYPE##_Load_##SRC_TYPE##_r) \
if (m3MemCheck( \
operand + sizeof (SRC_TYPE) <= _mem->length... | [
"source/m3_exec.h"
] | [] | true | |
wasm3/wasm3 | 385 | issue_to_patch | feat: add support for multi return value for raw functions | This PR adds support for multi return value for raw functions.
This ticks the box mentioned in this issue: https://github.com/wasm3/wasm3/issues/23 | 9a2894387d8cc77c81cbc6e56dcec71451d11f98 | 29bcfa49e5d220b02af8cff6e6b3187c3d6198e5 | diff --git a/source/wasm3.h b/source/wasm3.h
index 0733176b..0d8554fe 100644
--- a/source/wasm3.h
+++ b/source/wasm3.h
@@ -331,17 +331,19 @@ d_m3ErrorConst (trapStackOverflow, "[trap] stack overflow")
# define m3ApiOffsetToPtr(offset) (void*)((uint8_t*)_mem + (uint32_t)(offset))
# define m3ApiPtrToOffs... | [
"source/wasm3.h"
] | [] | true | ||
wasm3/wasm3 | 305 | issue_to_patch | C++ platform: zero-size array & compiler warnings | Fixed a few things to let it compile with compiler warnings enabled:
- removed non-standard zero-size array with compile time check
- inconsistent types / implicit type down-casts
- marked necessary but unused arguments | 8f3986a66c390e1125493531648b828099fab982 | 91600592118fe84137babfdce924b7e7591d0924 | diff --git a/platforms/cpp/README.md b/platforms/cpp/README.md
index 7751ff30..55cb45ee 100644
--- a/platforms/cpp/README.md
+++ b/platforms/cpp/README.md
@@ -14,7 +14,7 @@ All the classes are located in `wasm3` namespace.
`environment::environment()` — create a new WASM3 environment. Runtimes, modules are owned by ... | [
"platforms/cpp/README.md",
"platforms/cpp/wasm3_cpp/include/wasm3_cpp.h"
] | [] | true | ||
wasm3/wasm3 | 336 | issue_to_patch | Allow C++ enum classes to be marshalled as integers when possible. | With C++ enum classes, the size of an enum object can vary depending
on the compiler generation mechanism (choosing the most optimal storage size
to contain all the variants) or a user-defined storage type. In wasm, we
can only send int32_t and int64_t. That means, the enums using this
integer width for storage mus... | 8523770b80ea1f78afcac21d837f9dfd50f0bed6 | 25ebf3c9ab2c43f0fea8e779f32f299e795c57e6 | diff --git a/platforms/cpp/wasm3_cpp/include/wasm3_cpp.h b/platforms/cpp/wasm3_cpp/include/wasm3_cpp.h
index c12a1277..1f8d1d2e 100644
--- a/platforms/cpp/wasm3_cpp/include/wasm3_cpp.h
+++ b/platforms/cpp/wasm3_cpp/include/wasm3_cpp.h
@@ -44,7 +44,18 @@ namespace wasm3 {
struct m3_sig {
static con... | [
"platforms/cpp/wasm3_cpp/include/wasm3_cpp.h"
] | [] | true | ||
wasm3/wasm3 | 364 | issue_to_patch | m3_Call*-functions fix | Issue: https://github.com/wasm3/wasm3/issues/363 | 9dcfce271c2fac86823725fc9ec0f75309d820e4 | 0a0ec4188190233f6a7dabecfb1110e53a85e407 | diff --git a/source/m3_env.c b/source/m3_env.c
index 2bb86573..946406a2 100644
--- a/source/m3_env.c
+++ b/source/m3_env.c
@@ -835,6 +835,7 @@ M3Result m3_CallVL (IM3Function i_function, va_list i_args)
IM3Runtime runtime = i_function->module->runtime;
IM3FuncType ftype = i_function->funcType;
M3Result... | [
"source/m3_env.c"
] | [] | true | ||
wasm3/wasm3 | 328 | issue_to_patch | m3_env.c: prefer export name in searching function | Since https://reviews.llvm.org/D81689, wasm-ld has started wrapping
all exported functions including "_start" with surrounding ctor/dtor
calls. The wrapper function "_start.command_export" is exposed as
"_start".
wasm3 searched the entry function by looking up names indiscriminately.
However, it sometimes found th... | 839e57a220547738dc2c1fd2249c8fe8627c7337 | 02f92fc9b46895bd0be93ccee5a2d45b40efc436 | diff --git a/source/m3_env.c b/source/m3_env.c
index 2bb86573..f288e5a6 100644
--- a/source/m3_env.c
+++ b/source/m3_env.c
@@ -690,6 +690,16 @@ M3ValueType m3_GetGlobalType (IM3Global i_global)
void * v_FindFunction (IM3Module i_module, const char * const i_name)
{
+
+ // Prefer exported functions
+... | [
"source/m3_env.c",
"source/m3_function.h",
"source/m3_parse.c"
] | [] | true | ||
wasm3/wasm3 | 310 | issue_to_patch | Support standalone clang with GCC frontend | Improved the if case for detecting MSVC frontend that only triggers on clang-cl/msvc.
The wasm3 excecutable has some linking issues but the library can be built & used. | 20f747ead552533aaee149fb5d66d22f2f0bc0c7 | e26c2d3c32e53217150ffe51cc764cbcb4a91d49 | diff --git a/CMakeLists.txt b/CMakeLists.txt
index 9f6faefb..34c8df09 100755
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -128,7 +128,7 @@ elseif(WASIENV)
#-flto -Wl,--lto-O3
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -Wl,-z,stack-size=8388608")
-elseif(WIN32 AND NOT MINGW)
+elseif(MSVC OR CMAKE_C_CO... | [
"CMakeLists.txt"
] | [] | true | ||
wasm3/wasm3 | 301 | issue_to_patch | Fix memory safety issues found by OSS-Fuzz | This PR attempts to fix all the open security-relevant issues found by OSS-Fuzz:
- https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=33457: There was an integer overflow when computing `pageSize`. Fixed in c71d965fe9790f635e08c64b5528c6a16fad91ac
- https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=33554: wasm... | 4436c7c525ffb76d48a00e44771d5cf4aa12b9b1 | 01e55ccadfd6366d9b4ec61006908373023c898d | diff --git a/source/m3_code.c b/source/m3_code.c
index a5dd5d3f..b399b825 100644
--- a/source/m3_code.c
+++ b/source/m3_code.c
@@ -5,6 +5,7 @@
// Copyright © 2019 Steven Massey. All rights reserved.
//
+#include <limits.h>
#include "m3_code.h"
#include "m3_env.h"
@@ -15,9 +16,23 @@ IM3CodePage NewCodePage (I... | [
"source/m3_code.c",
"source/m3_compile.c"
] | [] | true | ||
wasm3/wasm3 | 371 | issue_to_patch | Replace C array with std::array to handle zero length | This change is to address #368. Standard C++ does not allow zero length arrays, this only works with compiler extensions. This change replaces the use a C array with an std:array which can be of length zero, but is still statically sized at compile time (e.g. `.size()` is `constexpr`). | 9dcfce271c2fac86823725fc9ec0f75309d820e4 | 41194eba44071d753513c2e00d1f4f75810f291d | diff --git a/platforms/cpp/wasm3_cpp/include/wasm3_cpp.h b/platforms/cpp/wasm3_cpp/include/wasm3_cpp.h
index c12a1277..2bdf51a8 100644
--- a/platforms/cpp/wasm3_cpp/include/wasm3_cpp.h
+++ b/platforms/cpp/wasm3_cpp/include/wasm3_cpp.h
@@ -5,6 +5,7 @@
#include <type_traits>
#include <iostream>
#include <vector>
+#inc... | [
"platforms/cpp/wasm3_cpp/include/wasm3_cpp.h"
] | [] | true | ||
wasm3/wasm3 | 322 | issue_to_patch | Fix parsing of i32 constant globals on big-endian systems. | Issue #321: This replaces `intValue` in the global value union with
separate `i32Value` and `i64Value`. A CI test is added against s390x. | ce423d1861d34542f18f40ece2f2e049e99d4d35 | 2b47ce6230e4e005805bde64b6a23ff9752ad0d1 | diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 70d2e8fb..ece670ef 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -76,6 +76,16 @@ jobs:
- name: Test WASI apps
run: cd test && python3 run-wasi-test.py
+ big-endian-i32-constant:
+ runs-on: ubun... | [
".github/workflows/tests.yml",
"source/m3_compile.c",
"source/m3_env.c",
"source/m3_env.h"
] | [] | true | ||
wasm3/wasm3 | 315 | issue_to_patch | Check for if slot == c_slotUnused in PushConst | I recently ported wasm3 to my kernel, [chariot](https://github.com/ChariotOS/chariot), and tried to run the coremark test. I'm not sure if this is a problem with any part of my libc, or a problem with wasm3's compiler, but this little change fixed the segfault/assertion failure on line 743. I'm not even sure if this is... | 20d50de8ecc58674e3860cbb6c0d05f20f8d8401 | 199a83d9168b12eb27a00853e97db79103821b9f | diff --git a/source/m3_compile.c b/source/m3_compile.c
index 34181743..8a93330b 100644
--- a/source/m3_compile.c
+++ b/source/m3_compile.c
@@ -722,7 +722,7 @@ _ (Push (o, i_type, slot));
u16 slot = c_slotUnused;
result = AllocateConstantSlots (o, & slot, i_type);
- if (resul... | [
"source/m3_compile.c"
] | [] | true | ||
wasm3/wasm3 | 330 | issue_to_patch | Fix Cygwin compatibility | This PR makes a few trivial changes to confer Cygwin compatibility. A CI job is added to prevent regressions. | ce423d1861d34542f18f40ece2f2e049e99d4d35 | 96131f58be89fc8561f8844973e558405e9f9898 | diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 70d2e8fb..2935b1de 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -154,6 +154,19 @@ jobs:
cd test
python run-wasi-test.py
+ cygwin-build:
+ runs-on: windows-latest
+
+ steps:
+ - u... | [
".github/workflows/tests.yml",
"source/m3_api_wasi.c",
"source/m3_config_platforms.h"
] | [] | true | ||
wasm3/wasm3 | 204 | issue_to_patch | Memory leak in Runtime or Environment
In our project we have [updated](https://github.com/wasmx/fizzy/pull/739) from 0.4.7 to 11f813d7ed659ed7c5b3faf6df0ff6e8f715f4e5 and seeing memory leaks now.
See the [CI log here](https://app.circleci.com/pipelines/github/wasmx/fizzy/6285/workflows/28be9728-da05-470e-a7d1-1b74... | Remove memory leak caused by dangling retFuncTypes in M3Environment | I think this fixes #203. At least it does on our CI. | 11f813d7ed659ed7c5b3faf6df0ff6e8f715f4e5 | 5edbcb6065a23aff9974a39342304a49fae1bdfb | diff --git a/source/m3_env.c b/source/m3_env.c
index e170242e..3dc04030 100644
--- a/source/m3_env.c
+++ b/source/m3_env.c
@@ -177,6 +177,8 @@ IM3Environment m3_NewEnvironment ()
// create FuncTypes for all simple block return ValueTypes
for (int t = c_m3Type_none; t <= c_m3Type_f64; t++)
{
+ d_... | [
"source/m3_env.c",
"source/m3_env.h"
] | [] | true | |
wasm3/wasm3 | 326 | issue_to_patch | Add mention of Perl embedding | 839e57a220547738dc2c1fd2249c8fe8627c7337 | 37a439acfc0bbea315a36d3ce034a1c4882d8a8e | diff --git a/README.md b/README.md
index 41b67545..f88cc41c 100644
--- a/README.md
+++ b/README.md
@@ -35,12 +35,12 @@ Wasm3 can also be used as a library for:
[<img src="https://cdn.rawgit.com/simple-icons/simple-icons/develop/icons/rust.svg" width="18" height="18" /> Rust](https://github.com/Veykril/wasm3-rs) │
[<... | [
"README.md"
] | [] | true | |||
wasm3/wasm3 | 324 | issue_to_patch | fix WASI API read/write pread/pwrite buffer overflow | this is for issue https://github.com/wasm3/wasm3/issues/323 | 839e57a220547738dc2c1fd2249c8fe8627c7337 | b8921b341d0d4a18f72f4d42caa9be839021c0b4 | diff --git a/source/m3_api_meta_wasi.c b/source/m3_api_meta_wasi.c
index 611f0357..3f1ac54c 100644
--- a/source/m3_api_meta_wasi.c
+++ b/source/m3_api_meta_wasi.c
@@ -37,13 +37,15 @@ static m3_wasi_context_t* wasi_context;
typedef size_t __wasi_size_t;
static inline
-void copy_iov_to_host(void* _mem, __wasi_iovec_t... | [
"source/m3_api_meta_wasi.c",
"source/m3_api_uvwasi.c",
"source/m3_api_wasi.c"
] | [] | true | ||
wasm3/wasm3 | 316 | issue_to_patch | fix some typos | 20d50de8ecc58674e3860cbb6c0d05f20f8d8401 | d551e067ae5300d762b1a1e3601b553e6d66edf6 | diff --git a/source/m3_env.c b/source/m3_env.c
index 6b043cc9..2bb86573 100644
--- a/source/m3_env.c
+++ b/source/m3_env.c
@@ -411,7 +411,7 @@ M3Result InitGlobals (IM3Module io_module)
if (io_module->numGlobals)
{
// placing the globals in their structs isn't good for cache locality, but i don't r... | [
"source/m3_env.c",
"source/m3_parse.c"
] | [] | true | |||
wasm3/wasm3 | 303 | issue_to_patch | C++ platform: Fix ambiguous call to "call" | When compiling the C++ example `platforms/cpp/main.cpp`, i got an error that the `call` template function is ambiguous.
I've change it into a single template using a compile-time if, and added examples. | 4436c7c525ffb76d48a00e44771d5cf4aa12b9b1 | c215b63811e84197fe7a75d07d598da7e6ffbcfe | diff --git a/platforms/cpp/README.md b/platforms/cpp/README.md
index 1e3d4c7e..7751ff30 100644
--- a/platforms/cpp/README.md
+++ b/platforms/cpp/README.md
@@ -52,9 +52,30 @@ If the module doesn't reference an imported function named `func`, an exception
`function` object can be obtained from a `runtime`, looking up ... | [
"platforms/cpp/README.md",
"platforms/cpp/main.cpp",
"platforms/cpp/wasm/test_prog.c",
"platforms/cpp/wasm/test_prog.wasm",
"platforms/cpp/wasm/test_prog.wasm.h",
"platforms/cpp/wasm3_cpp/include/wasm3_cpp.h"
] | [] | diff --git a/platforms/cpp/wasm/test_prog.c b/platforms/cpp/wasm/test_prog.c
index a2250c81..c11c8d99 100644
--- a/platforms/cpp/wasm/test_prog.c
+++ b/platforms/cpp/wasm/test_prog.c
@@ -4,6 +4,8 @@
extern int sum(int, int);
extern int ext_memcpy(void*, const void*, size_t);
+int32_t counter = 0;
+
#define WASM_EX... | true | |
wasm3/wasm3 | 304 | issue_to_patch | w3_defs.h: Ensure that endian.h or stdint.h is included before using uint | This is an addendum to my previous patch as it missed to ensure inclusion of
some header that provides uint*. It worked for me only because of local flags
to add this include | 00091461776b2e5aa9f2da209f830654cd4b2898 | 213bcd32ebb19e0bd475bbbd0adc5dc37c63d5a2 | diff --git a/source/wasm3_defs.h b/source/wasm3_defs.h
index a31e994b..b699b521 100644
--- a/source/wasm3_defs.h
+++ b/source/wasm3_defs.h
@@ -233,6 +233,8 @@
# else
# ifdef __linux__
# include <endian.h>
+# else
+# include <stdint.h>
# endif
# if defined(__bswap_16)
# define m3_bswap16(x) __... | [
"source/wasm3_defs.h"
] | [] | true | ||
wasm3/wasm3 | 302 | issue_to_patch | Don't include endian.h unconditionally | The branch for gcc < 4.8 includes endian.h unconditionally. Unfortunately endian.h is non-standard and is limited to linux according to the docs.
This breaks compilation for OSX PPC | 4436c7c525ffb76d48a00e44771d5cf4aa12b9b1 | c7c41081a5c071365823d0cf00d3e7492b7b436d | diff --git a/source/wasm3_defs.h b/source/wasm3_defs.h
index e9274e79..a31e994b 100644
--- a/source/wasm3_defs.h
+++ b/source/wasm3_defs.h
@@ -231,7 +231,9 @@
# define m3_bswap32(x) __builtin_bswap32((x))
# define m3_bswap64(x) __builtin_bswap64((x))
# else
-# include <endian.h>
+# ifdef __linux__
+... | [
"source/wasm3_defs.h"
] | [] | true | ||
wasm3/wasm3 | 298 | issue_to_patch | Add Zig C-code WASI app | c7cd9d8be644e674ad646ac0be17e8e53729940c | c9c14cbff2a312e2e6c50b45f03812d902cdc621 | diff --git a/docs/Cookbook.md b/docs/Cookbook.md
index 4986d7ed..eeba9870 100644
--- a/docs/Cookbook.md
+++ b/docs/Cookbook.md
@@ -100,6 +100,26 @@ $ wasm3 hello.wasm
Hello, world!
```
+### Zig C-code WASI app
+
+Create `hello.c`:
+```c
+#include <stdio.h>
+
+int main() {
+ printf("Hello, %s!\n", "world");
+ re... | [
"docs/Cookbook.md"
] | [] | true | |||
wasm3/wasm3 | 296 | issue_to_patch | on cpp platform. wasm3_cpp.h can not be include.
`
duplicate symbol 'wasm3::runtime::load(wasm3::module&)'
duplicate symbol 'wasm3::environment::parse_module(std::__1::basic_istream<char, std::__1::char_traits<char> >&)'
duplicate symbol 'wasm3::detail::check_error(char const*)'
duplicate symbol 'wasm3::runtime::f... | platforms/cpp: make the functions implemented in the header inline | Closes https://github.com/wasm3/wasm3/issues/295 | c7cd9d8be644e674ad646ac0be17e8e53729940c | b025a3925c9d163d2353013d1ca7b3b0f9cbbcfe | diff --git a/platforms/cpp/wasm3_cpp/include/wasm3_cpp.h b/platforms/cpp/wasm3_cpp/include/wasm3_cpp.h
index 2ea3810e..f33f4fac 100644
--- a/platforms/cpp/wasm3_cpp/include/wasm3_cpp.h
+++ b/platforms/cpp/wasm3_cpp/include/wasm3_cpp.h
@@ -139,7 +139,7 @@ namespace wasm3 {
/** @cond */
namespace detail {
- ... | [
"platforms/cpp/wasm3_cpp/include/wasm3_cpp.h"
] | [] | true | |
wasm3/wasm3 | 292 | issue_to_patch | Make error constants const | Rust bindgen which automatically generates bindings can now identify this as const static data and produce a signature with the correct mutability.
eg.
```rust
extern "C" {
pub static m3Err_mallocFailed: M3Result;
}
```
vs
```rust
extern "C" {
pub static mut m3Err_mallocFailed: M3Result;
}
`... | b10a0bc7e2d2bd0fb19e15739aa83bc239251801 | a0cb80a7a1470e38c948db1cf62b86a238495302 | diff --git a/source/wasm3.h b/source/wasm3.h
index 1cab94a0..38670613 100644
--- a/source/wasm3.h
+++ b/source/wasm3.h
@@ -110,9 +110,9 @@ M3ImportContext, * IM3ImportContext;
// -------------------------------------------------------------------------------------------------------------------------------
# if defi... | [
"source/wasm3.h"
] | [] | true | ||
wasm3/wasm3 | 289 | issue_to_patch | Moved static local varible from `NewCodePage`-function to `M3Runtime`-structure | **In this pull request I moved `static local s_sequence` varible from `NewCodePage`-function to `M3Runtime`-structure.**
Rationale
Investigated multithreading (case1) and multimodule (case 2) usage of wasm3.
- Case 1:
```cpp
thread_1:
auto wasm1 = new wasm3_instance(wasm_module);
wasm1->execute_some_func... | b76fe31fb3504fd6051866b9818c46f86b59af8a | e12efe3b0b0ca3193affeec75b884a7f3e36c2fa | diff --git a/source/m3_code.c b/source/m3_code.c
index bb784795..a5dd5d3f 100644
--- a/source/m3_code.c
+++ b/source/m3_code.c
@@ -6,15 +6,13 @@
//
#include "m3_code.h"
-
+#include "m3_env.h"
//-----------------------------------------------------------------------------------------------------------------------... | [
"source/m3_code.c",
"source/m3_code.h",
"source/m3_env.c",
"source/m3_env.h"
] | [] | true | ||
wasm3/wasm3 | 283 | issue_to_patch | Fix for issue281 version 2 | Second version of possible fix for https://github.com/wasm3/wasm3/issues/281 | 516ea997b053d000b824ffaea5426cbcebed93cd | 3b461aeca07840e7a2c37fd60b065f24e534ae4a | diff --git a/source/m3_env.c b/source/m3_env.c
index efb3fc7b..b3d465a6 100644
--- a/source/m3_env.c
+++ b/source/m3_env.c
@@ -543,6 +543,7 @@ M3Result m3_RunStart (IM3Module io_module)
#endif
M3Result result = m3Err_none;
+ i32 startFunctionTmp = -1;
if (io_module and io_module->startFunction >= 0)... | [
"source/m3_env.c"
] | [] | true | ||
wasm3/wasm3 | 273 | issue_to_patch | Allow passing custom UVWASI init options | Expose a public API for clients who want to set their own UVWASI options.
No change for existing `m3_LinkWASI` callers, keeping the original default init options. | 8850f91c46510ca44097e8b1d55441bc4de544e5 | f045d11dbf6a4d9b6c6332c6ca60017ed5a6ebc8 | diff --git a/source/m3_api_uvwasi.c b/source/m3_api_uvwasi.c
index 7ba1e554..876b2048 100644
--- a/source/m3_api_uvwasi.c
+++ b/source/m3_api_uvwasi.c
@@ -17,8 +17,6 @@
#include <stdio.h>
#include <string.h>
-#include "uvwasi.h"
-
#ifndef d_m3EnableWasiTracing
# define d_m3EnableWasiTracing 0
#endif
@@ -926... | [
"source/m3_api_uvwasi.c",
"source/m3_api_wasi.h"
] | [] | true | ||
wasm3/wasm3 | 275 | issue_to_patch | Fix mistake in Readme | 8850f91c46510ca44097e8b1d55441bc4de544e5 | ae16c879d532bb2ddc5bc30c238071643abdcd2d | diff --git a/platforms/cpp/README.md b/platforms/cpp/README.md
index 3ab4ecc0..1e3d4c7e 100644
--- a/platforms/cpp/README.md
+++ b/platforms/cpp/README.md
@@ -32,7 +32,7 @@ All the classes are located in `wasm3` namespace.
Before loading a module, you may need to link some external functions to it:
-`template <Fun... | [
"platforms/cpp/README.md"
] | [] | true | |||
wasmerio/wasmer | 6,682 | issue_to_patch | fix(NAPI): correct embedding of V8 on Windows | Right now, let's not enable NAPI on the Windows. | d24a2580de25c10c6fe6a49c9e293eed9c759a59 | cf02eda43a2d9abdd2d7a875d31639ba9c5d7dc1 | diff --git a/Makefile b/Makefile
index 97d717968dab..89b9a0ae1bd3 100644
--- a/Makefile
+++ b/Makefile
@@ -288,8 +288,10 @@ compilers_engines := $(strip $(compilers_engines))
#####
build_wasmer_extra_features :=
-ifneq (,$(filter 1 true,$(ENABLE_NAPI_V8)))
- build_wasmer_extra_features += napi-v8
+ifneq ($(IS... | [
"Makefile"
] | [] | true | ||
wasmerio/wasmer | 6,700 | issue_to_patch | chore: address cargo warnings + adjust .vscode/settings.json | The `settings.json` allows editing `lib/wasix/tests/wasm_tests/mod.rs` without Rust Analyzer complaining about invalid features. | 2e636c0e99e32d31cdb3e46fe21945e7a33b0a0c | f5418b1428bc6d783a3aaee70c953e2aad864cf6 | diff --git a/.vscode/settings.json b/.vscode/settings.json
index e5373fedd811..cfff613195b0 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -1,12 +1,18 @@
{
"rust-analyzer.cargo.features": [
- "llvm",
- "cranelift",
- "singlepass",
- "v8",
- "wasmer-artifact-cr... | [
".vscode/settings.json",
"lib/wasix/src/bin_factory/binary_package.rs",
"lib/wasix/tests/wasm_tests/mod.rs"
] | [] | diff --git a/lib/wasix/tests/wasm_tests/mod.rs b/lib/wasix/tests/wasm_tests/mod.rs
index 9391bcfe719a..4744e23f3149 100644
--- a/lib/wasix/tests/wasm_tests/mod.rs
+++ b/lib/wasix/tests/wasm_tests/mod.rs
@@ -1238,7 +1238,6 @@ fn collect_tests(tests: &mut Vec<Trial>) -> Result<()> {
.filter_map(Result::ok)
... | true | |
wasmerio/wasmer | 6,705 | issue_to_patch | fix(wasix): Child exit code race on cleanup | Wasix could sometimes report a spawned child as exiting with 0 even when the child actually exited nonzero. The root cause was a cleanup race: `Sigquit` was broadcast before the real process exit code was recorded, and because task status is effectively first-write-wins, waiters could observe the synthetic success stat... | 3afc5a1ce9b6f93173f2ef710ad30ad06e17790b | b4279eee4dfe05529972c3a3ea5cf206932db765 | diff --git a/lib/wasix/src/state/env.rs b/lib/wasix/src/state/env.rs
index f4180b076fdf..8ce4f7d0161e 100644
--- a/lib/wasix/src/state/env.rs
+++ b/lib/wasix/src/state/env.rs
@@ -1305,11 +1305,11 @@ impl WasiEnv {
}
}
- // Now send a signal that the thr... | [
"lib/wasix/src/state/env.rs",
"lib/wasix/tests/wasm_tests/process_tests/spawn-exec-nonzero-exit-loop/build.sh",
"lib/wasix/tests/wasm_tests/process_tests/spawn-exec-nonzero-exit-loop/main.c"
] | [] | diff --git a/lib/wasix/tests/wasm_tests/process_tests/spawn-exec-nonzero-exit-loop/build.sh b/lib/wasix/tests/wasm_tests/process_tests/spawn-exec-nonzero-exit-loop/build.sh
new file mode 100644
index 000000000000..28f4db912732
--- /dev/null
+++ b/lib/wasix/tests/wasm_tests/process_tests/spawn-exec-nonzero-exit-loop/bui... | true | |
wasmerio/wasmer | 6,703 | issue_to_patch | chore(V8): small clean-up | Addressing 2 smaller issues I noticed while I was working on the V8 Engine. | 2e636c0e99e32d31cdb3e46fe21945e7a33b0a0c | b0d3d948b2f63bb194de362d3a606fb94b5633e7 | diff --git a/lib/api/src/backend/v8/entities/module.rs b/lib/api/src/backend/v8/entities/module.rs
index 4860930f06d7..8ccc0930119e 100644
--- a/lib/api/src/backend/v8/entities/module.rs
+++ b/lib/api/src/backend/v8/entities/module.rs
@@ -116,7 +116,7 @@ impl ModuleHandle {
let bytes = unsafe {
... | [
"lib/api/src/backend/v8/entities/module.rs",
"lib/api/src/backend/v8/utils/convert.rs",
"lib/api/src/backend/v8/vm/mod.rs",
"tests/ignores.txt"
] | [] | diff --git a/tests/ignores.txt b/tests/ignores.txt
index 649be1b6e921..321f0741f399 100644
--- a/tests/ignores.txt
+++ b/tests/ignores.txt
@@ -149,9 +149,6 @@ spec::instance
# TODO: #5816
cranelift+riscv64 spec::skip_stack_guard_page
-# FIXME - re-enable once the path resolution failures in WasiFs have been worked ... | true | |
wasmerio/wasmer | 6,697 | issue_to_patch | fix(macos): test-capi-v8 | Right now, the build runs with `--features v8-default,wasi`, where `wasi` pulls in `wasmer-wasix` crate with enabled `sys` feature. However, without a selected compiler, the following error gets triggered:
```
error: the `sys` feature requires enabling at least one compiler backend: `singlepass`, `cranelift`, `llvm`,... | 2e636c0e99e32d31cdb3e46fe21945e7a33b0a0c | 15d0c77cfc947dc0b85f39aa2d7716d7d32d722b | diff --git a/lib/compiler/src/engine/inner.rs b/lib/compiler/src/engine/inner.rs
index 780714de704d..4453cd2b97c7 100644
--- a/lib/compiler/src/engine/inner.rs
+++ b/lib/compiler/src/engine/inner.rs
@@ -5,7 +5,6 @@ use crate::engine::builder::EngineBuilder;
#[cfg(feature = "compiler")]
use crate::{Compiler, CompilerC... | [
"lib/compiler/src/engine/inner.rs",
"lib/wasix/Cargo.toml"
] | [
{
"comment": "`compile_with_progress` is compiled on `wasm32` when `feature != \"compiler\"`, but it returns `Arc<Artifact>` and touches `self.tunables`, both of which are only available for non-wasm32 builds. This will fail to compile for `wasm32` targets. Also, delegating to `compile()` keeps the error messag... | true | ||
wasmerio/wasmer | 6,697 | comment_to_fix | fix(macos): test-capi-v8 | `compile_with_progress` is compiled on `wasm32` when `feature != "compiler"`, but it returns `Arc<Artifact>` and touches `self.tunables`, both of which are only available for non-wasm32 builds. This will fail to compile for `wasm32` targets. Also, delegating to `compile()` keeps the error message consistent with the ex... | 2e636c0e99e32d31cdb3e46fe21945e7a33b0a0c | 15d0c77cfc947dc0b85f39aa2d7716d7d32d722b | diff --git a/lib/compiler/src/engine/inner.rs b/lib/compiler/src/engine/inner.rs
index 780714de704d..4453cd2b97c7 100644
--- a/lib/compiler/src/engine/inner.rs
+++ b/lib/compiler/src/engine/inner.rs
@@ -5,7 +5,6 @@ use crate::engine::builder::EngineBuilder;
#[cfg(feature = "compiler")]
use crate::{Compiler, CompilerC... | [
"lib/compiler/src/engine/inner.rs"
] | [
{
"comment": "`compile_with_progress` is compiled on `wasm32` when `feature != \"compiler\"`, but it returns `Arc<Artifact>` and touches `self.tunables`, both of which are only available for non-wasm32 builds. This will fail to compile for `wasm32` targets. Also, delegating to `compile()` keeps the error messag... | true | ||
wasmerio/wasmer | 6,697 | comment_to_fix | fix(macos): test-capi-v8 | The comment says a "compiler" must be enabled, but the feature being enabled here is `wasmer/headless`, which is explicitly a *no-compiler* mode. Rewording avoids confusion for future maintainers. | 2e636c0e99e32d31cdb3e46fe21945e7a33b0a0c | 15d0c77cfc947dc0b85f39aa2d7716d7d32d722b | diff --git a/lib/wasix/Cargo.toml b/lib/wasix/Cargo.toml
index 31b608d1cce7..0728ce88dc4f 100644
--- a/lib/wasix/Cargo.toml
+++ b/lib/wasix/Cargo.toml
@@ -228,6 +228,8 @@ sys = [
"wasmer/wat",
"wasmer/js-serializable-module",
"wasmer/sys",
+ # We must ensure at least one compiler backend (or `headless`) is en... | [
"lib/wasix/Cargo.toml"
] | [
{
"comment": "The comment says a \"compiler\" must be enabled, but the feature being enabled here is `wasmer/headless`, which is explicitly a *no-compiler* mode. Rewording avoids confusion for future maintainers.",
"path": "lib/wasix/Cargo.toml",
"hunk": "@@ -226,6 +226,8 @@ sys = [\n \"wasmer/wat\",\... | true | ||
wasmerio/wasmer | 6,704 | issue_to_patch | `wasm/dynamic_library_tests/dl-concurrent-open-and-spawn` deadlocks occasionally
Noticed the test times out occasionally in CI, but I managed to reproduce it locally as well:
```
$ cd lib/wasix
$ cargo nextest run cranelift
$ gdb (...)
(gdb) bt
#0 0x00007f7d4211af9d in syscall () from /usr/lib/libc.so.6
#1 0x0000562... | Fix a possible linker deadlock scenario where one thread going to… | … sleep in AsyncifyPoller at the same time as another thread delivered SIGWAKEUP would lead to the signal getting lost
Fixes #6654 | 2e636c0e99e32d31cdb3e46fe21945e7a33b0a0c | 58ab7a7df7897853238eff61845a4dd4977d894c | diff --git a/lib/wasix/src/syscalls/mod.rs b/lib/wasix/src/syscalls/mod.rs
index 18e794cc4128..f8a973d8f139 100644
--- a/lib/wasix/src/syscalls/mod.rs
+++ b/lib/wasix/src/syscalls/mod.rs
@@ -381,7 +381,9 @@ where
return Poll::Ready(Ok(res));
}
- WasiEnv::do_pending_link_operations(self.ct... | [
"lib/wasix/src/syscalls/mod.rs"
] | [] | true | |
wasmerio/wasmer | 6,683 | issue_to_patch | feat(vm): baremetal trap-handler backend | Adds a `baremetal` Cargo feature to `wasmer-vm` (forwarded through `wasmer-compiler` and `wasmer`) that replaces the OS signal/coroutine trap handler with a minimal backend for targets without signal infrastructure — embedded systems, ZK virtual machines, and similar environments.
The new backend mirrors the public ... | 2e636c0e99e32d31cdb3e46fe21945e7a33b0a0c | 27541729c0fdf74af4a70cbd00d47448845aab64 | diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
index e862bc05a83b..2e5b0024aa65 100644
--- a/.github/workflows/test.yaml
+++ b/.github/workflows/test.yaml
@@ -572,6 +572,8 @@ jobs:
make: "test-all"
- description: "Compilers (std only)"
make: "check-compilers-... | [
".github/workflows/test.yaml",
"Makefile",
"lib/api/Cargo.toml",
"lib/compiler/Cargo.toml",
"lib/vm/Cargo.toml",
"lib/vm/src/trap/mod.rs",
"lib/vm/src/trap/trap.rs",
"lib/vm/src/trap/traphandlers.rs",
"lib/vm/src/trap/traphandlers_baremetal.rs"
] | [
{
"comment": "This introduces conflicting module declarations for `traphandlers`: the unconditional `mod traphandlers;` is still present, so you’ll end up defining the same module name multiple times depending on cfg evaluation (and likely hit a duplicate-definition compile error). Remove the unconditional decl... | true | ||
wasmerio/wasmer | 6,683 | comment_to_fix | feat(vm): baremetal trap-handler backend | This introduces conflicting module declarations for `traphandlers`: the unconditional `mod traphandlers;` is still present, so you’ll end up defining the same module name multiple times depending on cfg evaluation (and likely hit a duplicate-definition compile error). Remove the unconditional declaration and keep only ... | 2e636c0e99e32d31cdb3e46fe21945e7a33b0a0c | 27541729c0fdf74af4a70cbd00d47448845aab64 | diff --git a/lib/vm/src/trap/mod.rs b/lib/vm/src/trap/mod.rs
index 70bfa5b18f4a..94cfbc5a06cf 100644
--- a/lib/vm/src/trap/mod.rs
+++ b/lib/vm/src/trap/mod.rs
@@ -4,14 +4,51 @@
//! This is the module that facilitates the usage of Traps
//! in Wasmer Runtime
+use crate::vmcontext::{VMFunctionContext, VMTrampoline};
... | [
"lib/vm/src/trap/mod.rs"
] | [
{
"comment": "This introduces conflicting module declarations for `traphandlers`: the unconditional `mod traphandlers;` is still present, so you’ll end up defining the same module name multiple times depending on cfg evaluation (and likely hit a duplicate-definition compile error). Remove the unconditional decl... | true | ||
wasmerio/wasmer | 6,683 | comment_to_fix | feat(vm): baremetal trap-handler backend | `UNWINDING` is set to `true` and never reset. If `unwind_with` panics (e.g., no unwinder installed, or re-entrancy detected) and that panic is caught by a higher-level `catch_unwind`, the thread-local will remain `true` and future traps on that thread will be misclassified as re-entrant. Use an RAII guard that resets `... | 2e636c0e99e32d31cdb3e46fe21945e7a33b0a0c | 27541729c0fdf74af4a70cbd00d47448845aab64 | diff --git a/lib/vm/src/trap/traphandlers_baremetal.rs b/lib/vm/src/trap/traphandlers_baremetal.rs
new file mode 100644
index 000000000000..28f20508344d
--- /dev/null
+++ b/lib/vm/src/trap/traphandlers_baremetal.rs
@@ -0,0 +1,166 @@
+//! Signal-free trap handling (`baremetal` feature).
+//!
+//! Mirrors the `traphandle... | [
"lib/vm/src/trap/traphandlers_baremetal.rs"
] | [
{
"comment": "`UNWINDING` is set to `true` and never reset. If `unwind_with` panics (e.g., no unwinder installed, or re-entrancy detected) and that panic is caught by a higher-level `catch_unwind`, the thread-local will remain `true` and future traps on that thread will be misclassified as re-entrant. Use an RA... | true | ||
wasmerio/wasmer | 6,683 | comment_to_fix | feat(vm): baremetal trap-handler backend | This transmutes an `unsafe extern \"C\" fn` into a *safe* `extern \"C\" fn` and then calls it without an `unsafe` call-site, which weakens the API’s safety boundary and makes it easier to accidentally call with invalid pointers in future refactors. Prefer to transmute to `unsafe extern \"C\" fn(VMFunctionContext, *cons... | 2e636c0e99e32d31cdb3e46fe21945e7a33b0a0c | 27541729c0fdf74af4a70cbd00d47448845aab64 | diff --git a/lib/vm/src/trap/traphandlers_baremetal.rs b/lib/vm/src/trap/traphandlers_baremetal.rs
new file mode 100644
index 000000000000..28f20508344d
--- /dev/null
+++ b/lib/vm/src/trap/traphandlers_baremetal.rs
@@ -0,0 +1,166 @@
+//! Signal-free trap handling (`baremetal` feature).
+//!
+//! Mirrors the `traphandle... | [
"lib/vm/src/trap/traphandlers_baremetal.rs"
] | [
{
"comment": "This transmutes an `unsafe extern \\\"C\\\" fn` into a *safe* `extern \\\"C\\\" fn` and then calls it without an `unsafe` call-site, which weakens the API’s safety boundary and makes it easier to accidentally call with invalid pointers in future refactors. Prefer to transmute to `unsafe extern \\\... | true | ||
wasmerio/wasmer | 6,683 | comment_to_fix | feat(vm): baremetal trap-handler backend | The module docs describe \"bare-metal targets (e.g. embedded systems)\" and \"no OS infrastructure\", but the implementation relies on `std::sync::{Mutex, Arc}`. That’s fine if `wasmer-vm` still requires `std`, but it’s inconsistent with the typical meaning of bare-metal/no-OS and may mislead users into expecting `no_s... | 2e636c0e99e32d31cdb3e46fe21945e7a33b0a0c | 27541729c0fdf74af4a70cbd00d47448845aab64 | diff --git a/lib/vm/src/trap/traphandlers_baremetal.rs b/lib/vm/src/trap/traphandlers_baremetal.rs
new file mode 100644
index 000000000000..28f20508344d
--- /dev/null
+++ b/lib/vm/src/trap/traphandlers_baremetal.rs
@@ -0,0 +1,166 @@
+//! Signal-free trap handling (`baremetal` feature).
+//!
+//! Mirrors the `traphandle... | [
"lib/vm/src/trap/traphandlers_baremetal.rs"
] | [
{
"comment": "The module docs describe \\\"bare-metal targets (e.g. embedded systems)\\\" and \\\"no OS infrastructure\\\", but the implementation relies on `std::sync::{Mutex, Arc}`. That’s fine if `wasmer-vm` still requires `std`, but it’s inconsistent with the typical meaning of bare-metal/no-OS and may misl... | true | ||
wasmerio/wasmer | 6,683 | comment_to_fix | feat(vm): baremetal trap-handler backend | Can we move this type to a file commonly shared with `traphandlers.rs`? | 2e636c0e99e32d31cdb3e46fe21945e7a33b0a0c | 27541729c0fdf74af4a70cbd00d47448845aab64 | diff --git a/lib/vm/src/trap/traphandlers_baremetal.rs b/lib/vm/src/trap/traphandlers_baremetal.rs
new file mode 100644
index 000000000000..28f20508344d
--- /dev/null
+++ b/lib/vm/src/trap/traphandlers_baremetal.rs
@@ -0,0 +1,166 @@
+//! Signal-free trap handling (`baremetal` feature).
+//!
+//! Mirrors the `traphandle... | [
"lib/vm/src/trap/traphandlers_baremetal.rs"
] | [
{
"comment": "Can we move this type to a file commonly shared with `traphandlers.rs`?",
"path": "lib/vm/src/trap/traphandlers_baremetal.rs",
"hunk": "@@ -0,0 +1,353 @@\n+//! Trap handling for targets without OS signal infrastructure.\n+//!\n+//! On conventional operating systems, Wasmer's trap handler u... | true | ||
wasmerio/wasmer | 6,683 | comment_to_fix | feat(vm): baremetal trap-handler backend | `UnwindReason::WasmTrap { .. }` is constructed from `traphandlers.rs`, but the struct-variant fields here are private, so sibling modules can’t construct it (this should fail to compile at the call site that builds `UnwindReason::WasmTrap`). Make these fields visible within the crate/module (or provide a constructor) s... | 2e636c0e99e32d31cdb3e46fe21945e7a33b0a0c | 27541729c0fdf74af4a70cbd00d47448845aab64 | diff --git a/lib/vm/src/trap/trap.rs b/lib/vm/src/trap/trap.rs
index 9d7117d1ffac..cde0fd16af63 100644
--- a/lib/vm/src/trap/trap.rs
+++ b/lib/vm/src/trap/trap.rs
@@ -1,4 +1,5 @@
use backtrace::Backtrace;
+use std::any::Any;
use std::error::Error;
use std::fmt;
use wasmer_types::TrapCode;
@@ -169,3 +170,43 @@ impl ... | [
"lib/vm/src/trap/trap.rs"
] | [
{
"comment": "`UnwindReason::WasmTrap { .. }` is constructed from `traphandlers.rs`, but the struct-variant fields here are private, so sibling modules can’t construct it (this should fail to compile at the call site that builds `UnwindReason::WasmTrap`). Make these fields visible within the crate/module (or pr... | true | ||
wasmerio/wasmer | 6,683 | comment_to_fix | feat(vm): baremetal trap-handler backend | This `panic!` uses `{reason}` (Display formatting), but `UnwindReason` only derives `Debug` and doesn’t implement `Display`, so this won’t compile. Use `{:?}` (or implement `Display` for `UnwindReason`). | 2e636c0e99e32d31cdb3e46fe21945e7a33b0a0c | 27541729c0fdf74af4a70cbd00d47448845aab64 | diff --git a/lib/vm/src/trap/traphandlers_baremetal.rs b/lib/vm/src/trap/traphandlers_baremetal.rs
new file mode 100644
index 000000000000..28f20508344d
--- /dev/null
+++ b/lib/vm/src/trap/traphandlers_baremetal.rs
@@ -0,0 +1,166 @@
+//! Signal-free trap handling (`baremetal` feature).
+//!
+//! Mirrors the `traphandle... | [
"lib/vm/src/trap/traphandlers_baremetal.rs"
] | [
{
"comment": "This `panic!` uses `{reason}` (Display formatting), but `UnwindReason` only derives `Debug` and doesn’t implement `Display`, so this won’t compile. Use `{:?}` (or implement `Display` for `UnwindReason`).",
"path": "lib/vm/src/trap/traphandlers_baremetal.rs",
"hunk": "@@ -0,0 +1,162 @@\n+//... | true | ||
wasmerio/wasmer | 6,683 | comment_to_fix | feat(vm): baremetal trap-handler backend | This `panic!` uses `{reason}` (Display formatting), but `UnwindReason` only derives `Debug` and doesn’t implement `Display`, so this won’t compile. Use `{:?}` (or implement `Display` for `UnwindReason`). | 2e636c0e99e32d31cdb3e46fe21945e7a33b0a0c | 27541729c0fdf74af4a70cbd00d47448845aab64 | diff --git a/lib/vm/src/trap/traphandlers_baremetal.rs b/lib/vm/src/trap/traphandlers_baremetal.rs
new file mode 100644
index 000000000000..28f20508344d
--- /dev/null
+++ b/lib/vm/src/trap/traphandlers_baremetal.rs
@@ -0,0 +1,166 @@
+//! Signal-free trap handling (`baremetal` feature).
+//!
+//! Mirrors the `traphandle... | [
"lib/vm/src/trap/traphandlers_baremetal.rs"
] | [
{
"comment": "This `panic!` uses `{reason}` (Display formatting), but `UnwindReason` only derives `Debug` and doesn’t implement `Display`, so this won’t compile. Use `{:?}` (or implement `Display` for `UnwindReason`).",
"path": "lib/vm/src/trap/traphandlers_baremetal.rs",
"hunk": "@@ -0,0 +1,162 @@\n+//... | true | ||
wasmerio/wasmer | 6,683 | comment_to_fix | feat(vm): baremetal trap-handler backend | `unwind_with` holds the `UNWINDER` mutex while calling the host unwinder callback. Because the callback is explicitly expected to perform a non-local exit (e.g. `longjmp`) that skips Rust destructors, the `MutexGuard` will not be dropped/unlocked, which can permanently deadlock future `unwind_with`/`install_unwinder` c... | 2e636c0e99e32d31cdb3e46fe21945e7a33b0a0c | 27541729c0fdf74af4a70cbd00d47448845aab64 | diff --git a/lib/vm/src/trap/traphandlers_baremetal.rs b/lib/vm/src/trap/traphandlers_baremetal.rs
new file mode 100644
index 000000000000..28f20508344d
--- /dev/null
+++ b/lib/vm/src/trap/traphandlers_baremetal.rs
@@ -0,0 +1,166 @@
+//! Signal-free trap handling (`baremetal` feature).
+//!
+//! Mirrors the `traphandle... | [
"lib/vm/src/trap/traphandlers_baremetal.rs"
] | [
{
"comment": "`unwind_with` holds the `UNWINDER` mutex while calling the host unwinder callback. Because the callback is explicitly expected to perform a non-local exit (e.g. `longjmp`) that skips Rust destructors, the `MutexGuard` will not be dropped/unlocked, which can permanently deadlock future `unwind_with... | true | ||
wasmerio/wasmer | 6,648 | issue_to_patch | `wasitests` can be ported to the new `wasm_tests` harness
The tests under `tests/wasi-wast/src/wasitests.rs` can be ported to the new test harness, where can removed the existing `.wasm`/`.wat` files and generate them on fly.
Should be pretty close to wasmerio/wasmer#6566 | test(wasix): port wasi-wast tests to wasm harness | This ports the old `tests/wasi-wast` coverage into the current WASIX wasm test harness under `lib/wasix/tests/wasm_tests/wasi_wast`.
The old generator and checked-in generated `.wasm` / `.wast` fixtures are removed, and `make test-wasi` now runs the ported `wasi_wast` cases through the WASIX harness. The WASI exampl... | 713d1ed39e0f29c6b6b2fdcc8629540859ef0666 | b72b0263cf97318de2ceb6c346cf0b81b1029154 | diff --git a/Cargo.lock b/Cargo.lock
index b601396cd2e7..452efc8d0f04 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2336,26 +2336,6 @@ dependencies = [
"tungstenite",
]
-[[package]]
-name = "gumdrop"
-version = "0.8.1"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "5bc700f989d2f6f024... | [
"Cargo.lock",
"Cargo.toml",
"Makefile",
"build.rs",
"examples/wasi.rs",
"examples/wasi_manual_setup.rs",
"examples/wasi_pipes.rs",
"lib/wasix/Cargo.toml",
"lib/wasix/tests/wasm_tests/mod.rs",
"lib/wasix/tests/wasm_tests/runner.rs",
"lib/wasix/tests/wasm_tests/wasi_wast/close_preopen_fd.rs",
"l... | [
{
"comment": "The previous `test-wasi` invocation passed `$(compiler_features)` so the test was exercised across the configured compiler backends. The new command hard-codes `--features sys` and drops `$(compiler_features)`, which changes (and likely reduces) test coverage. Please confirm this is intentional, o... | diff --git a/lib/wasix/tests/wasm_tests/mod.rs b/lib/wasix/tests/wasm_tests/mod.rs
index a7c78da7c35e..e88827e4863c 100644
--- a/lib/wasix/tests/wasm_tests/mod.rs
+++ b/lib/wasix/tests/wasm_tests/mod.rs
@@ -61,6 +61,10 @@
//! `ProgramName:{name}` overrides argv[0].
//!
//! `DefaultMappedDirectories:{bool}` controls ... | true |
wasmerio/wasmer | 6,648 | comment_to_fix | test(wasix): port wasi-wast tests to wasm harness | The previous `test-wasi` invocation passed `$(compiler_features)` so the test was exercised across the configured compiler backends. The new command hard-codes `--features sys` and drops `$(compiler_features)`, which changes (and likely reduces) test coverage. Please confirm this is intentional, or restore the compiler... | 713d1ed39e0f29c6b6b2fdcc8629540859ef0666 | b72b0263cf97318de2ceb6c346cf0b81b1029154 | diff --git a/Makefile b/Makefile
index 1fad24bd5858..cca8697f90cb 100644
--- a/Makefile
+++ b/Makefile
@@ -663,12 +663,6 @@ test-capi-integration-%:
# Test the Wasmer C API examples
cd lib/c-api/examples; WASMER_CAPI_CONFIG=$(shell echo $@ | sed -e s/test-capi-integration-//) WASMER_DIR=`pwd`/../../../package make ... | [
"Makefile"
] | [
{
"comment": "The previous `test-wasi` invocation passed `$(compiler_features)` so the test was exercised across the configured compiler backends. The new command hard-codes `--features sys` and drops `$(compiler_features)`, which changes (and likely reduces) test coverage. Please confirm this is intentional, o... | true | ||
wasmerio/wasmer | 6,648 | comment_to_fix | test(wasix): port wasi-wast tests to wasm harness | That's one aspect of the port that I overlooked - can we please add similar functionality to the `wasm_tests` and with a new directive, list use file systems? | 713d1ed39e0f29c6b6b2fdcc8629540859ef0666 | b72b0263cf97318de2ceb6c346cf0b81b1029154 | diff --git a/tests/lib/wast/src/wasi_wast.rs b/tests/lib/wast/src/wasi_wast.rs
deleted file mode 100644
index 49333dde97e7..000000000000
--- a/tests/lib/wast/src/wasi_wast.rs
+++ /dev/null
@@ -1,765 +0,0 @@
-use std::{
- fs::{self, File, OpenOptions, ReadDir, read_dir},
- future::Future,
- io::{self, Read, See... | [
"tests/lib/wast/src/wasi_wast.rs"
] | [
{
"comment": "That's one aspect of the port that I overlooked - can we please add similar functionality to the `wasm_tests` and with a new directive, list use file systems?",
"path": "tests/lib/wast/src/wasi_wast.rs",
"hunk": "@@ -1,765 +0,0 @@\n-use std::{\n- fs::{self, File, OpenOptions, ReadDir, r... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.