repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
zaproxy/zaproxy | 9,281 | issue_to_patch | Add generic HTTPS Config issue alert | db844c0296a31f6fe4604e615e55ef214ee0545e | c3fdcbb7ebee5e7b97675d9b37c75b3d9ae43d39 | diff --git a/docs/scanners.md b/docs/scanners.md
index 3ebc438ffec..e80cee4e775 100644
--- a/docs/scanners.md
+++ b/docs/scanners.md
@@ -113,6 +113,7 @@ Scan rules:
10202 Absence of Anti-CSRF Tokens
10203 Freak (via HTTPS Info Extension) [Deprecated]
10204 Robot (via HTTPS Info Extension) [Deprecated]
+10205 ... | [
"docs/scanners.md"
] | [] | true | |||
zaproxy/zaproxy | 9,275 | issue_to_patch | Add refs for Alert on HTTP Response Code Errors script rule
The "Alert on HTTP Response Code Errors" script scan rule raises different alerts with exactly the same alert reference.
It should be changed to use unique references.
Note that this rule is defined in 2 places:
* https://github.com/zaproxy/community-scripts/... | Use alert refs in HTTP Response Code Errors script | Fixes #9273
The "Alert on HTTP Response Code Errors" script raised alerts with identical references.
This change adds a reference based on the HTTP response code so each alert has a unique reference. | 3fd83a31bef71bde0aeadde0244e561a1b15257b | f6f3ebe6de5e34d043732e92be5c6410b29b6a36 | diff --git a/docker/CHANGELOG.md b/docker/CHANGELOG.md
index 2af08fccb2e..df977bfedb2 100644
--- a/docker/CHANGELOG.md
+++ b/docker/CHANGELOG.md
@@ -1,6 +1,9 @@
# Changelog
All notable changes to the docker containers will be documented in this file.
+### 2026-03-10
+- Use alert references in "Alert on HTTP Respons... | [
"docker/CHANGELOG.md",
"docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js"
] | [
{
"comment": "This is not the correct fix.\nThe alerts should be updated with `.setAlertRef(getId() + \"-\" + x);` where x is 1, 2, etc",
"path": "docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js",
"hunk": "@@ -82,6 +82,7 @@ function responseReceived(msg, initiator, helper) {\n \t... | true | |
zaproxy/zaproxy | 9,275 | comment_to_fix | Use alert refs in HTTP Response Code Errors script | This is not the correct fix.
The alerts should be updated with `.setAlertRef(getId() + "-" + x);` where x is 1, 2, etc | 3fd83a31bef71bde0aeadde0244e561a1b15257b | f6f3ebe6de5e34d043732e92be5c6410b29b6a36 | diff --git a/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js b/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js
index 10594bd1e01..d421b38ffb5 100644
--- a/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js
+++ b/docker/scripts/scripts/httpsender/Alert... | [
"docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js"
] | [
{
"comment": "This is not the correct fix.\nThe alerts should be updated with `.setAlertRef(getId() + \"-\" + x);` where x is 1, 2, etc",
"path": "docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js",
"hunk": "@@ -82,6 +82,7 @@ function responseReceived(msg, initiator, helper) {\n \t... | true | ||
zaproxy/zaproxy | 9,275 | comment_to_fix | Use alert refs in HTTP Response Code Errors script | The codes must start from 1 and be sequencial, so 1 and 2 | 3fd83a31bef71bde0aeadde0244e561a1b15257b | f6f3ebe6de5e34d043732e92be5c6410b29b6a36 | diff --git a/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js b/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js
index 10594bd1e01..d421b38ffb5 100644
--- a/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js
+++ b/docker/scripts/scripts/httpsender/Alert... | [
"docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js"
] | [
{
"comment": "The codes must start from 1 and be sequencial, so 1 and 2",
"path": "docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js",
"hunk": "@@ -82,6 +82,7 @@ function responseReceived(msg, initiator, helper) {\n \t\t\t\t\"This may indicate that the application is failing to han... | true | ||
zaproxy/zaproxy | 9,275 | comment_to_fix | Use alert refs in HTTP Response Code Errors script | `- Use alert references … ` also add issue to end of the entry `(Issue 9273).` | 3fd83a31bef71bde0aeadde0244e561a1b15257b | f6f3ebe6de5e34d043732e92be5c6410b29b6a36 | diff --git a/docker/CHANGELOG.md b/docker/CHANGELOG.md
index 2af08fccb2e..df977bfedb2 100644
--- a/docker/CHANGELOG.md
+++ b/docker/CHANGELOG.md
@@ -1,6 +1,9 @@
# Changelog
All notable changes to the docker containers will be documented in this file.
+### 2026-03-10
+- Use alert references in "Alert on HTTP Respons... | [
"docker/CHANGELOG.md"
] | [
{
"comment": "`- Use alert references … ` also add issue to end of the entry `(Issue 9273).`",
"path": "docker/CHANGELOG.md",
"hunk": "@@ -1,6 +1,9 @@\n # Changelog\n All notable changes to the docker containers will be documented in this file.\n \n+### 2026-03-09\n+- Fix duplicate alert references in \... | true | ||
zaproxy/zaproxy | 9,275 | comment_to_fix | Use alert refs in HTTP Response Code Errors script | Add to the existing condition. | 3fd83a31bef71bde0aeadde0244e561a1b15257b | f6f3ebe6de5e34d043732e92be5c6410b29b6a36 | diff --git a/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js b/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js
index 10594bd1e01..d421b38ffb5 100644
--- a/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js
+++ b/docker/scripts/scripts/httpsender/Alert... | [
"docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js"
] | [
{
"comment": "Add to the existing condition.",
"path": "docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js",
"hunk": "@@ -82,6 +82,12 @@ function responseReceived(msg, initiator, helper) {\n \t\t\t\t\"This may indicate that the application is failing to handle unexpected input corre... | true | ||
zaproxy/zaproxy | 9,275 | comment_to_fix | Use alert refs in HTTP Response Code Errors script | Please remove the blank lines you've added | 3fd83a31bef71bde0aeadde0244e561a1b15257b | f6f3ebe6de5e34d043732e92be5c6410b29b6a36 | diff --git a/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js b/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js
index 10594bd1e01..d421b38ffb5 100644
--- a/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js
+++ b/docker/scripts/scripts/httpsender/Alert... | [
"docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js"
] | [
{
"comment": "Please remove the blank lines you've added",
"path": "docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js",
"hunk": "@@ -29,12 +29,16 @@ function responseReceived(msg, initiator, helper) {\n \t\t\t// Do nothing\n \t\t} else {\n \t\t\tvar risk = 0\t// Info\n+\t\t\tvar al... | true | ||
zaproxy/zaproxy | 9,279 | issue_to_patch | Allow Site Tree refresh in any mode | Mark the Refresh Sites Tree popup menu safe.
Found this accidentally the other day, when working on the GUI/Theme issue. | 6603ca5ec7d15c50a972ac92072b9c1b8df6f40c | e943c3ba681075af543eb6e5f0267191793d8377 | diff --git a/zap/src/main/java/org/zaproxy/zap/extension/siterefresh/PopupMenuSitesRefresh.java b/zap/src/main/java/org/zaproxy/zap/extension/siterefresh/PopupMenuSitesRefresh.java
index 72b36eb3073..c32edc984ef 100644
--- a/zap/src/main/java/org/zaproxy/zap/extension/siterefresh/PopupMenuSitesRefresh.java
+++ b/zap/sr... | [
"zap/src/main/java/org/zaproxy/zap/extension/siterefresh/PopupMenuSitesRefresh.java"
] | [] | true | ||
zaproxy/zaproxy | 9,271 | issue_to_patch | Text Hidden When Switching Look and Feel in Site Details
### Describe the bug:
In ZAP, under Site Details, selecting certain options in “Dynamically switch the look and feel” causes the text to become invisible. This occurs for both options selected from the dropdown, making it hard to see which option is active.
##... | Address UI trees not updating fully on theme switch | Tested on both macOS and Windows.
Discussed via slack.
Fixes zaproxy/zaproxy#9107 | 255a7b8e9cc923506a61367f935ae5aa7afdd811 | 5888d4acf46ddcaf34de499113a88deb1cd0916d | diff --git a/zap/src/main/java/org/parosproxy/paros/extension/option/OptionsParamView.java b/zap/src/main/java/org/parosproxy/paros/extension/option/OptionsParamView.java
index b1dc110f2b7..4262a11fda3 100644
--- a/zap/src/main/java/org/parosproxy/paros/extension/option/OptionsParamView.java
+++ b/zap/src/main/java/org... | [
"zap/src/main/java/org/parosproxy/paros/extension/option/OptionsParamView.java"
] | [] | true | |
zaproxy/zaproxy | 9,268 | issue_to_patch | Correctly use log levels from config file | Do not set null log level (i.e. no command line arg set) to use the log levels from the configuration file. | 2e4ba5a238a692f9a7b36c11bbd4f3de85c19b53 | 2437ffd8dcfa4cd3c4a64045ece972f52e8e8e22 | diff --git a/zap/src/main/java/org/zaproxy/zap/ZapBootstrap.java b/zap/src/main/java/org/zaproxy/zap/ZapBootstrap.java
index 0b506195122..8b9357ba582 100644
--- a/zap/src/main/java/org/zaproxy/zap/ZapBootstrap.java
+++ b/zap/src/main/java/org/zaproxy/zap/ZapBootstrap.java
@@ -88,7 +88,11 @@ protected static void disabl... | [
"zap/src/main/java/org/zaproxy/zap/ZapBootstrap.java",
"zap/src/test/java/org/zaproxy/zap/ZapBootstrapUnitTest.java"
] | [
{
"comment": "This would have failed before the change?",
"path": "zap/src/test/java/org/zaproxy/zap/ZapBootstrapUnitTest.java",
"hunk": "@@ -0,0 +1,106 @@\n+/*\n+ * Zed Attack Proxy (ZAP) and its related class files.\n+ *\n+ * ZAP is an HTTP/HTTPS proxy for assessing web application security.\n+ *\n+ *... | diff --git a/zap/src/test/java/org/zaproxy/zap/ZapBootstrapUnitTest.java b/zap/src/test/java/org/zaproxy/zap/ZapBootstrapUnitTest.java
new file mode 100644
index 00000000000..f3d4b16700f
--- /dev/null
+++ b/zap/src/test/java/org/zaproxy/zap/ZapBootstrapUnitTest.java
@@ -0,0 +1,106 @@
+/*
+ * Zed Attack Proxy (ZAP) and ... | true | |
zaproxy/zaproxy | 9,268 | comment_to_fix | Correctly use log levels from config file | This would have failed before the change? | 2e4ba5a238a692f9a7b36c11bbd4f3de85c19b53 | 2437ffd8dcfa4cd3c4a64045ece972f52e8e8e22 | diff --git a/zap/src/test/java/org/zaproxy/zap/ZapBootstrapUnitTest.java b/zap/src/test/java/org/zaproxy/zap/ZapBootstrapUnitTest.java
new file mode 100644
index 00000000000..f3d4b16700f
--- /dev/null
+++ b/zap/src/test/java/org/zaproxy/zap/ZapBootstrapUnitTest.java
@@ -0,0 +1,106 @@
+/*
+ * Zed Attack Proxy (ZAP) and ... | [
"zap/src/test/java/org/zaproxy/zap/ZapBootstrapUnitTest.java"
] | [
{
"comment": "This would have failed before the change?",
"path": "zap/src/test/java/org/zaproxy/zap/ZapBootstrapUnitTest.java",
"hunk": "@@ -0,0 +1,106 @@\n+/*\n+ * Zed Attack Proxy (ZAP) and its related class files.\n+ *\n+ * ZAP is an HTTP/HTTPS proxy for assessing web application security.\n+ *\n+ *... | true | ||
zaproxy/zaproxy | 9,268 | comment_to_fix | Correctly use log levels from config file | Move to JUnit 5.7 and use EnumSource? (Or is that a bigger headache because of deprecations?) | 2e4ba5a238a692f9a7b36c11bbd4f3de85c19b53 | 2437ffd8dcfa4cd3c4a64045ece972f52e8e8e22 | diff --git a/zap/src/test/java/org/zaproxy/zap/ZapBootstrapUnitTest.java b/zap/src/test/java/org/zaproxy/zap/ZapBootstrapUnitTest.java
new file mode 100644
index 00000000000..f3d4b16700f
--- /dev/null
+++ b/zap/src/test/java/org/zaproxy/zap/ZapBootstrapUnitTest.java
@@ -0,0 +1,106 @@
+/*
+ * Zed Attack Proxy (ZAP) and ... | [
"zap/src/test/java/org/zaproxy/zap/ZapBootstrapUnitTest.java"
] | [
{
"comment": "Move to JUnit 5.7 and use EnumSource? (Or is that a bigger headache because of deprecations?)",
"path": "zap/src/test/java/org/zaproxy/zap/ZapBootstrapUnitTest.java",
"hunk": "@@ -0,0 +1,106 @@\n+/*\n+ * Zed Attack Proxy (ZAP) and its related class files.\n+ *\n+ * ZAP is an HTTP/HTTPS pro... | true | ||
zaproxy/zaproxy | 9,267 | issue_to_patch | Reduce EDT accesses in headless | Use the utility class to execute in the EDT when needed, which prevents the EDT from being spawn when in headless mode. | e8d08ab9dc7f7c7e9daebfd3c9c969b5ab9a9108 | 65256f24b6bf0779886010a2a90c9d8b7068a605 | diff --git a/zap/src/main/java/org/zaproxy/zap/extension/alert/ExtensionAlert.java b/zap/src/main/java/org/zaproxy/zap/extension/alert/ExtensionAlert.java
index 69a1aea2b24..6e9ea3fa282 100644
--- a/zap/src/main/java/org/zaproxy/zap/extension/alert/ExtensionAlert.java
+++ b/zap/src/main/java/org/zaproxy/zap/extension/a... | [
"zap/src/main/java/org/zaproxy/zap/extension/alert/ExtensionAlert.java",
"zap/src/main/java/org/zaproxy/zap/extension/ascan/ExtensionActiveScan.java",
"zap/src/main/java/org/zaproxy/zap/extension/brk/ExtensionBreak.java",
"zap/src/main/java/org/zaproxy/zap/extension/params/ExtensionParams.java"
] | [] | true | ||
zaproxy/zaproxy | 9,264 | issue_to_patch | Bump the gha group with 2 updates | Bumps the gha group with 2 updates: [gradle/actions](https://github.com/gradle/actions) and [docker/build-push-action](https://github.com/docker/build-push-action).
Updates `gradle/actions` from 5.0.1 to 5.0.2
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/gradle/actions/rel... | 85446f0c1f6d8488fa7ef7432ebba111988078be | 81a9319581bbf31a6c8dfdc7119ccc6b0bf0c87e | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 4b439a6f0dd..5ca9d22994a 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -24,6 +24,6 @@ jobs:
with:
distribution: 'temurin'
java-version: ${{ matrix.java }}
- - uses: gradle/actions/setup-g... | [
".github/workflows/ci.yml",
".github/workflows/release-live-docker.yml",
".github/workflows/release-main-docker.yml",
".github/workflows/release-weekly-docker.yml",
".github/workflows/run-integration-tests.yml"
] | [] | true | ||
zaproxy/zaproxy | 9,260 | issue_to_patch | Docker: Update weekly image to debian:trixie and JDK 21 | Part of https://github.com/zaproxy/zaproxy/issues/9258 | 6dd25f97598d4ae3925dcc6a62e21fb64e82c764 | 25884f54747daf5a5a4fcac2cfc779b8d9e40710 | diff --git a/docker/CHANGELOG.md b/docker/CHANGELOG.md
index 91ad8a7b3db..2af08fccb2e 100644
--- a/docker/CHANGELOG.md
+++ b/docker/CHANGELOG.md
@@ -1,6 +1,9 @@
# Changelog
All notable changes to the docker containers will be documented in this file.
+### 2026-02-26
+- Updated weekly image to debian:trixie and JDK ... | [
"docker/CHANGELOG.md",
"docker/Dockerfile-weekly"
] | [] | true | ||
zaproxy/zaproxy | 9,259 | issue_to_patch | Docker: Update live image to debian:trixie and JDK 21 | Part of https://github.com/zaproxy/zaproxy/issues/9258 | 116bda27c78dce96e58797c59508684d4d5f12c8 | 8788099fac996a10663558684089b48635134380 | diff --git a/docker/CHANGELOG.md b/docker/CHANGELOG.md
index e9eeffcf243..91ad8a7b3db 100644
--- a/docker/CHANGELOG.md
+++ b/docker/CHANGELOG.md
@@ -1,6 +1,9 @@
# Changelog
All notable changes to the docker containers will be documented in this file.
+### 2026-02-25
+- Updated live image to debian:trixie and JDK 21... | [
"docker/CHANGELOG.md",
"docker/Dockerfile-live"
] | [] | true | ||
zaproxy/zaproxy | 9,253 | issue_to_patch | Update scanners.md to add id for Web Cache Deception | Add specific id to scanners.md for active rule scanner of Web Cache Deception | 7fc1d3723574fd4f3d034a5cd65767cf7bdd12ff | 4fd075516f0d5e321dc82b6f50d275971f0491ce | diff --git a/docs/scanners.md b/docs/scanners.md
index aed6da1e10c..3ebc438ffec 100644
--- a/docs/scanners.md
+++ b/docs/scanners.md
@@ -272,6 +272,7 @@ Scan rules:
100043 Swagger Secret Disclosure and Vulnerable Version [Script]
100044 Suspicious Input Transformation [Script]
100045 Open MCP Server Detection [Sc... | [
"docs/scanners.md"
] | [
{
"comment": "Could you move it to the hundred thousands with the other script rules?\n\n> 100046 Web Cache Deception [Script]",
"path": "docs/scanners.md",
"hunk": "@@ -88,7 +88,7 @@ Scan rules:\n 10097 Hash Disclosure\n 10098 Cross-Domain Misconfiguration\n 10099 Source Code Disclosure\n-\n+101... | true | ||
zaproxy/zaproxy | 9,253 | comment_to_fix | Update scanners.md to add id for Web Cache Deception | Could you move it to the hundred thousands with the other script rules?
> 100046 Web Cache Deception [Script] | 7fc1d3723574fd4f3d034a5cd65767cf7bdd12ff | 4fd075516f0d5e321dc82b6f50d275971f0491ce | diff --git a/docs/scanners.md b/docs/scanners.md
index aed6da1e10c..3ebc438ffec 100644
--- a/docs/scanners.md
+++ b/docs/scanners.md
@@ -272,6 +272,7 @@ Scan rules:
100043 Swagger Secret Disclosure and Vulnerable Version [Script]
100044 Suspicious Input Transformation [Script]
100045 Open MCP Server Detection [Sc... | [
"docs/scanners.md"
] | [
{
"comment": "Could you move it to the hundred thousands with the other script rules?\n\n> 100046 Web Cache Deception [Script]",
"path": "docs/scanners.md",
"hunk": "@@ -88,7 +88,7 @@ Scan rules:\n 10097 Hash Disclosure\n 10098 Cross-Domain Misconfiguration\n 10099 Source Code Disclosure\n-\n+101... | true | ||
zaproxy/zaproxy | 9,248 | issue_to_patch | Added initial PTK alerts | fca4e7076f0df1f0b7f335dc1f850c78933f10e8 | 9902f9fcffe431eaa031d38587fa0e993c3a4e00 | diff --git a/docs/scanners.md b/docs/scanners.md
index 125a6c40080..aed6da1e10c 100644
--- a/docs/scanners.md
+++ b/docs/scanners.md
@@ -288,6 +288,34 @@ Scan rules:
120001 Information Disclosure - Sensitive Information in Browser Storage
120002 Information Disclosure - JWT in Browser Storage
+200000 PTK - DAST ... | [
"docs/scanners.md"
] | [] | true | |||
zaproxy/zaproxy | 9,252 | issue_to_patch | ITests: always use seconds for pollUnits | fca4e7076f0df1f0b7f335dc1f850c78933f10e8 | 5a8885a580cc7ceb9cd5bf0fa3ab74af68409ef8 | diff --git a/docker/integration_tests/configs/plans/jigsaw-basic-user.yaml.disabled b/docker/integration_tests/configs/plans/jigsaw-basic-user.yaml.disabled
index 13a26a1c5c3..6dd57503583 100644
--- a/docker/integration_tests/configs/plans/jigsaw-basic-user.yaml.disabled
+++ b/docker/integration_tests/configs/plans/jig... | [
"docker/integration_tests/configs/plans/jigsaw-basic-user.yaml.disabled",
"docker/integration_tests/configs/plans/petstore-openapi.yaml",
"docker/integration_tests/configs/plans/testfire-form-user.yaml"
] | [] | true | |||
zaproxy/zaproxy | 9,244 | issue_to_patch | Docker: baseline support delay via AF | 423d42f2b1700df87becc7fffcba9b5d7a7ba16d | ec641f8adada142f59c53df56d6b867cadacdcc5 | diff --git a/docker/CHANGELOG.md b/docker/CHANGELOG.md
index 0d9c4ea7561..e9eeffcf243 100644
--- a/docker/CHANGELOG.md
+++ b/docker/CHANGELOG.md
@@ -1,6 +1,9 @@
# Changelog
All notable changes to the docker containers will be documented in this file.
+### 2026-02-09
+- Added support for the delay job in the baselin... | [
"docker/CHANGELOG.md",
"docker/tests/fixtures/baseline_plan_param_uc_d.yaml",
"docker/tests/test_zap_baseline_plan.py",
"docker/zap-baseline.py",
"docker/zap_common.py"
] | [
{
"comment": "I think this can just be removed?",
"path": "docker/tests/fixtures/baseline_plan_param_uc_d.yaml",
"hunk": "@@ -0,0 +1,29 @@\n+env:\n+ contexts:\n+ - name: baseline\n+ urls:\n+ - https://example.com/\n+ excludePaths: []",
"resolving_sha": "ec641f8adada142f59c53df56d6b867cada... | diff --git a/docker/tests/fixtures/baseline_plan_param_uc_d.yaml b/docker/tests/fixtures/baseline_plan_param_uc_d.yaml
new file mode 100644
index 00000000000..c7d1a08e0f8
--- /dev/null
+++ b/docker/tests/fixtures/baseline_plan_param_uc_d.yaml
@@ -0,0 +1,29 @@
+env:
+ contexts:
+ - name: baseline
+ urls:
+ - htt... | true | ||
zaproxy/zaproxy | 9,239 | issue_to_patch | Docker: more baseline tests | 4f55335ce6e961bd0b63ab3759e366d2e31a922b | 29bfc7583c3529979d69e5d228337414fdd8cbeb | [
"docker/tests/fixtures/baseline_plan_param_lc_a.yaml",
"docker/tests/fixtures/baseline_plan_param_lc_c.yaml",
"docker/tests/fixtures/baseline_plan_param_lc_d.yaml",
"docker/tests/fixtures/baseline_plan_param_lc_j.yaml",
"docker/tests/fixtures/baseline_plan_param_lc_m.yaml",
"docker/tests/fixtures/baseline... | [] | diff --git a/docker/tests/fixtures/baseline_plan_param_lc_a.yaml b/docker/tests/fixtures/baseline_plan_param_lc_a.yaml
new file mode 100644
index 00000000000..427c62848e5
--- /dev/null
+++ b/docker/tests/fixtures/baseline_plan_param_lc_a.yaml
@@ -0,0 +1,26 @@
+env:
+ contexts:
+ - name: baseline
+ urls:
+ - htt... | true | |||
zaproxy/zaproxy | 9,241 | issue_to_patch | Remove deprecated "httputils" | The classes were deprecated in 2.12.0 and migrated to an add-on. | 305d0fa827d7d00d1656f2cc1bbc4444f8d5b924 | 9dfdceffebb591b81f9c67a0a8a60d2448fc18c2 | diff --git a/zap/gradle/japicmp.yaml b/zap/gradle/japicmp.yaml
index 673557a0aea..ea21a2cffbb 100644
--- a/zap/gradle/japicmp.yaml
+++ b/zap/gradle/japicmp.yaml
@@ -12,6 +12,8 @@ packageExcludes:
- "org.zaproxy.zap.spider.parser"
fieldExcludes: []
classExcludes:
+ - "org.zaproxy.zap.httputils.HtmlContext"
+ - "org.... | [
"zap/gradle/japicmp.yaml",
"zap/src/main/java/org/zaproxy/zap/httputils/HtmlContext.java",
"zap/src/main/java/org/zaproxy/zap/httputils/HtmlContextAnalyser.java"
] | [] | true | ||
zaproxy/zaproxy | 9,240 | issue_to_patch | Fix exceptions with auto-detect auth | Check that the authentication method has credentials to prevent NPEs when managing users.
---
e.g.
```
[AWT-EventQueue-0] ERROR org.zaproxy.zap.ZAP.UncaughtExceptionLogger - Exception in thread "AWT-EventQueue-0"
java.lang.NullPointerException: Cannot invoke "org.zaproxy.zap.authentication.AbstractCredentialsOpt... | 305d0fa827d7d00d1656f2cc1bbc4444f8d5b924 | a6cec896b5dbdfa4c786a354d99eb37110fee497 | diff --git a/zap/src/main/java/org/zaproxy/zap/extension/users/DialogAddUser.java b/zap/src/main/java/org/zaproxy/zap/extension/users/DialogAddUser.java
index d60c251b604..cf6e6b66b1e 100644
--- a/zap/src/main/java/org/zaproxy/zap/extension/users/DialogAddUser.java
+++ b/zap/src/main/java/org/zaproxy/zap/extension/user... | [
"zap/src/main/java/org/zaproxy/zap/extension/users/DialogAddUser.java"
] | [] | true | ||
zellij-org/zellij | 5,241 | issue_to_patch | Mobile layout | <img width="200" height="400" alt="mobile-web-3" src="https://github.com/user-attachments/assets/6c2b6909-bb55-49b8-a043-1e5e4b720f1e" />
<img width="200" height="400" alt="mobile-web-2" src="https://github.com/user-attachments/assets/b1316d37-d438-4cab-9c52-c5ddd244f4d0" />
<img width="200" height="400" alt="mobile-... | e9173cba163506491becbeacad162315d6e8f726 | ecccab6c291256407d82ce1eafe91dbd3cef1d45 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index f0dd1fad52..2698a73020 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
## [Unreleased]
* feat: allow tabs to have different sizes if clients aren't focused on the same one (https... | [
"CHANGELOG.md",
"Cargo.lock",
"Cargo.toml",
"default-plugins/mobile/.cargo/config.toml",
"default-plugins/mobile/.gitignore",
"default-plugins/mobile/Cargo.toml",
"default-plugins/mobile/src/ansi.rs",
"default-plugins/mobile/src/click.rs",
"default-plugins/mobile/src/components/mod.rs",
"default-p... | [] | diff --git a/zellij-utils/src/ipc/tests/roundtrip_tests.rs b/zellij-utils/src/ipc/tests/roundtrip_tests.rs
index 4847b67947..280805abe3 100644
--- a/zellij-utils/src/ipc/tests/roundtrip_tests.rs
+++ b/zellij-utils/src/ipc/tests/roundtrip_tests.rs
@@ -13,9 +13,10 @@ use crate::input::layout::{
TiledPaneLayout,
};
... | true | |
zellij-org/zellij | 4,545 | issue_to_patch | Zellij Clipboard Functionality: Limitations for Integrating Neovim Registers
I am a user of **Neovim** and heavily use its registers. It is convenient to press `y` to copy some text from **Neovim** running on the remote host in Zellij to my local laptop's system clipboard.
When I used **tmux**, it had integrated `t... | feat(zellij-server): report OSC 52 clipboard support over DA1 | As Zellij always handles OSC 52 from inner programs and then forwards it appropriately (`copy_command`, `copy_clipboard`), I think it makes sense to unconditionally report OSC 52 support.
This makes clipboard support work in `neovim` running inside of `zellij` without any configuration changes.
Fixes https://gith... | 7c8945fbf3a682bab1ac8abcc20e077e73564eed | 60acd439985339e518f090821c0e4eb366ce6014 | diff --git a/zellij-server/src/panes/grid.rs b/zellij-server/src/panes/grid.rs
index 77329f2b7d..d08cb6a265 100644
--- a/zellij-server/src/panes/grid.rs
+++ b/zellij-server/src/panes/grid.rs
@@ -3271,8 +3271,8 @@ impl Perform for Grid {
// https://vt100.net/docs/vt510-rm/DA1.html
match interme... | [
"zellij-server/src/panes/grid.rs",
"zellij-server/src/panes/unit/snapshots/zellij_server__panes__grid__grid_tests__terminal_reports.snap"
] | [] | true | |
zellij-org/zellij | 5,184 | issue_to_patch | Adding PWA support for zellij web
Hi,
Thought it would be nice if PWA support was added for the zellij web client, so you can launch it in its own window and have it look more native.
At minimum would need:
- A logo/icon served at /<icon-subpath>
- A manifest served at /manifest.webmanifest containing at minimum https... | feat: PWA support for the web client | ## Summary
Closes #5094.
Adds Progressive Web App support to the Zellij web client so the page can be installed as a standalone app via the browser's "Install" / "Add to Home Screen" affordance. Implementation is intentionally minimal — manifest + a single 192×192 icon + iOS `apple-touch-icon` link, no service wo... | b558b31ed192652f75ecc35d6753a7d5d0046023 | 9b0124d362e5ae35c36d167501778590923684d5 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 343e34fe24..f0dd1fad52 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
## [Unreleased]
* feat: allow tabs to have different sizes if clients aren't focused on the same one (htt... | [
"CHANGELOG.md",
"zellij-client/assets/icon-192.png",
"zellij-client/assets/index.html",
"zellij-client/assets/manifest.webmanifest",
"zellij-client/src/web_client/unit/web_client_tests.rs",
"zellij-client/src/web_client/utils.rs"
] | [] | true | |
zellij-org/zellij | 5,163 | issue_to_patch | fix: stale grid after forwarding host reply | This is a continuation of the recent fix for wedged bytes in the host reply. The only thing that was missing there is that in certain cases there's a race in which the underlying program sends bytes to be processed after the scheduled render, and so clients end up seeing a stale state.
To fix this we add an explicit... | 42496fa3248398b555f6d20a59e863a46d46f68d | 4c1475b0139ea1a2261d58bc1770266b94279664 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 768e2be7a9..390ec3d061 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,7 +8,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* feat: allow tabs to have different sizes if clients aren't focused on the same one (https://github.com/zel... | [
"CHANGELOG.md",
"zellij-server/src/screen.rs"
] | [] | true | ||
zellij-org/zellij | 5,161 | issue_to_patch | fix: clear bell when focusing with mouse | Fixes a minor issue where changing pane focus with the mouse would not clear a bell notification in the target pane (which was cleared when changing focus with the keyboard). | fc6c5942a12d7314f606be390de9d05497f20bd3 | 95bab42c9181089cb5652921c73871e703233436 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index f5b32609d8..768e2be7a9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -13,6 +13,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* fix: close session-manager instead of hiding to avoid confusion (https://github.com/zellij-org/zellij/pu... | [
"CHANGELOG.md",
"zellij-server/src/screen.rs",
"zellij-server/src/unit/screen_tests.rs"
] | [] | true | ||
zellij-org/zellij | 5,160 | issue_to_patch | Pressing <DEL> on a session in Welcome Screen doesn't visibly do anything
I can see session is being killed if check `zellij ls` in another terminal, but with a longer list of sessions and multiple deletions there is no way to keep track of list
I would expect them to be removed from the session list after being dele... | Welcome screen del fix | Fixes: https://github.com/zellij-org/zellij/issues/5151
The reason this was happening is that in the last version I changed the session update plugin event to a polling mechanism to avoid idle resource utilization. Since the welcome screen and session manager were using these update their session lists, these were n... | 90d890f2b6987b00c8980e4f9425a639af753551 | fe349b7687b7210e2cf97e55116bb757a6f27180 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index ccb83c9e0d..f5b32609d8 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* fix: regression with ESC+mouse hold (https://github.com/zellij-org/zellij/pull/5157)
* fix: close sessi... | [
"CHANGELOG.md",
"default-plugins/session-manager/src/main.rs",
"default-plugins/session-manager/src/resurrectable_sessions.rs",
"default-plugins/session-manager/src/session_list.rs",
"default-plugins/session-manager/src/single_screen.rs",
"zellij-server/src/plugins/zellij_exports.rs",
"zellij-tile/src/s... | [] | true | |
zellij-org/zellij | 5,143 | issue_to_patch | fix(plugin): require specific permissions for new tab panes | ## Summary
This PR tightens plugin permission checks for pane-opening commands that create privileged resources inside a new tab:
- `OpenCommandPaneInNewTab` now requires `RunCommands`
- `OpenEditorPaneInNewTab` now requires `OpenFiles`
## Threat model / impact
Before this change, `OpenCommandPaneInNewTab` was guar... | de1e0f7560d03ce6b5514e22eef7e7852c9385e8 | 152d94bb493c2453791c32beb06ba3a408ff6757 | diff --git a/zellij-server/src/plugins/zellij_exports.rs b/zellij-server/src/plugins/zellij_exports.rs
index 1a94102612..2f96c96ecc 100644
--- a/zellij-server/src/plugins/zellij_exports.rs
+++ b/zellij-server/src/plugins/zellij_exports.rs
@@ -5376,9 +5376,8 @@ fn check_command_permission(
PluginCommand::GetSes... | [
"zellij-server/src/plugins/zellij_exports.rs"
] | [] | true | ||
zellij-org/zellij | 5,149 | issue_to_patch | OSC 10/11 query replies leak into shell stdin in 0.45.0 (regression from #5105)
## Issue description
OSC 10/11 query replies emitted by an application inside a pane are
delivered into that pane's stdin instead of being consumed by the
application that asked. In a cooked-mode shell (zsh, bash) the reply
shows up at th... | fix: occasional stall when querying host terminal (introduced in 0.44.1) | This fixes a regression from 0.44.1 where occasionally starting applications or even printing new prompts would stall for ~500ms in certain environments and conditions.
### What was happening?
In #5105 and #5113, the behavior of OSC10/11 and some other queries was changed. Before, Zellij would query the host termin... | cc86e31b840cfd1993f256513047dfe980408398 | 74245703993f5b4498bc5db32d2cc5a95518acae | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 058c29c7fc..7455a21db0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
## [Unreleased]
* feat: allow tabs to have different sizes if clients aren't focused on the same one (https... | [
"CHANGELOG.md",
"zellij-client/src/stdin_ansi_parser_tests.rs",
"zellij-utils/src/vendored/termwiz/input.rs"
] | [] | true | |
zellij-org/zellij | 5,055 | issue_to_patch | Session manager focuses tab that last ran it
# 2. Issues with the Zellij UI / behavior / crash
<!-- Please find a minimal reproduction.
If you have a complex setup that causes an issue, try to troubleshoot and narrow the problem down to as minimal a reproduction as possible. Remove as many parts of the equation a... | Fix session-manager and tab issue | Fix #3834.
| 0d8ebaa234885ad298962a7b702cbc00bba16521 | 729e7b2b89b8acffc336003cf8a9c3a5dc6666f5 | diff --git a/default-plugins/session-manager/src/main.rs b/default-plugins/session-manager/src/main.rs
index afade742ed..849ae26370 100644
--- a/default-plugins/session-manager/src/main.rs
+++ b/default-plugins/session-manager/src/main.rs
@@ -607,7 +607,7 @@ impl State {
self.reset_selected_ind... | [
"default-plugins/session-manager/src/main.rs"
] | [
{
"comment": "This change fixes Esc in a few screens, but the session manager still calls `hide_self()` in several other “exit” paths (eg when a session is selected / switched in `handle_selection`, and when Ctrl-C is pressed with an empty search term). Those paths will also leave a hidden plugin instance attac... | true | |
zellij-org/zellij | 5,055 | comment_to_fix | Fix session-manager and tab issue | This change fixes Esc in a few screens, but the session manager still calls `hide_self()` in several other “exit” paths (eg when a session is selected / switched in `handle_selection`, and when Ctrl-C is pressed with an empty search term). Those paths will also leave a hidden plugin instance attached to the original ta... | 0d8ebaa234885ad298962a7b702cbc00bba16521 | 729e7b2b89b8acffc336003cf8a9c3a5dc6666f5 | diff --git a/default-plugins/session-manager/src/main.rs b/default-plugins/session-manager/src/main.rs
index afade742ed..849ae26370 100644
--- a/default-plugins/session-manager/src/main.rs
+++ b/default-plugins/session-manager/src/main.rs
@@ -607,7 +607,7 @@ impl State {
self.reset_selected_ind... | [
"default-plugins/session-manager/src/main.rs"
] | [
{
"comment": "This change fixes Esc in a few screens, but the session manager still calls `hide_self()` in several other “exit” paths (eg when a session is selected / switched in `handle_selection`, and when Ctrl-C is pressed with an empty search term). Those paths will also leave a hidden plugin instance attac... | true | ||
zellij-org/zellij | 5,157 | issue_to_patch | Pressing ESCAPE while moving the mouse changes the layout
## Issue description
Pressing ESCAPE while moving the mouse will trigger the `Alt+[` keybinding, doing a layout swap.
## Minimal reproduction
Run zellij with no configuration, and while the mouse is moving, press Escape.
## Other relevant information
Runnin... | Fix esc mouse | Fixes https://github.com/zellij-org/zellij/issues/5026
This was a regression caused by some housekeeping I performed around our STDIN parser. Sorry for the inconvenience, it's now fixed. | 0f6cf0664e05feab497778fbdddbf80492c252f2 | e5ceb1662482153dbec79b1b6a3af6fd46de4535 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 74028afc12..37ae0abbe1 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* fix(windows): bump windows-sys to 0.59 to align manifest with code, fixing source builds via `cargo instal... | [
"CHANGELOG.md",
"zellij-utils/src/vendored/termwiz/input.rs"
] | [] | true | |
zellij-org/zellij | 5,156 | issue_to_patch | fix(webclient): handle host query responses for pixel dimensions and colors | Fixes an issue brought up in https://github.com/zellij-org/zellij/pull/5149#issuecomment-4410052762
While the issue is not the same issue as the original one, since we now forward host queries to the host terminal, we also need to handle them when they're forwarded to the web server.
This has been implemented her... | 24f2173fbce61ca6234f4fe4b6ca83833bf3ae64 | 0e63b0a34fbe1aaa0f864369afbab281228bf343 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6df75ab306..74028afc12 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,7 +8,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* feat: allow tabs to have different sizes if clients aren't focused on the same one (https://github.com/zel... | [
"CHANGELOG.md",
"zellij-client/assets/websockets.js",
"zellij-client/src/unit/terminal_loop_tests.rs",
"zellij-client/src/web_client/control_message.rs",
"zellij-client/src/web_client/host_query_seed.rs",
"zellij-client/src/web_client/mod.rs",
"zellij-client/src/web_client/server_listener.rs",
"zellij... | [] | true | ||
zellij-org/zellij | 5,152 | issue_to_patch | Zellij freezes when pressing Ctrl-G while a floating pane is opened with --block-until-exit
# 2. Issues with the Zellij UI / behavior / crash
## Summary
Zellij freezes when pressing `Ctrl-G` while a floating pane is opened with `--block-until-exit`.
This was originally observed through `fzf --popup`, but it can be ... | fix: deadlock with blocking panes | This fixes a regression in 0.44.2 where if we would open a pane with `--blocking` and then change-mode (among some other actions) the session would get stuck.
This was happening because of a deadlock in the route.rs thread. I fixed it by removing some unnecessary state the thread was holding, thus freeing it from th... | e927b2b659296c19e421bc36d1b702f2c8d24fd3 | b16d544817deeb2f732503ff0ff856b6a9650bbd | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7455a21db0..6df75ab306 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
## [Unreleased]
* feat: allow tabs to have different sizes if clients aren't focused on the same one (https... | [
"CHANGELOG.md",
"zellij-server/src/lib.rs",
"zellij-server/src/plugins/mod.rs",
"zellij-server/src/plugins/pinned_executor.rs",
"zellij-server/src/plugins/plugin_loader.rs",
"zellij-server/src/plugins/plugin_map.rs",
"zellij-server/src/plugins/unit/plugin_tests.rs",
"zellij-server/src/plugins/unit/sna... | [] | true | |
zellij-org/zellij | 5,139 | issue_to_patch | Can't update with Cargo on Windows
Trying to update zellij to the latest version on Windows using `cargo binstall zellij`, but while compiling zellij-server, I get an error:
```
error[E0432]: unresolved import `windows_sys::Win32::Storage::FileSystem::WriteFile`
--> C:\Users\edvinas.steponaviciu\.cargo\registry\src\... | fix(windows): bump windows-sys to 0.59 | The workspace `windows-sys` constraint was pinned to 0.52 while the Windows source uses APIs and namespaces from 0.59 (e.g. WriteFile in Win32::Storage::FileSystem). CI built fine because Cargo.lock pinned 0.59, but downstream `cargo install`/`cargo binstall` did fresh resolution and selected 0.52, breaking the build f... | 5ef8176c431e0b1a4c5a5362d05926ead7661b6d | 0eabec0dd506ab505492e5eb90e6f832a75e7462 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index cd712cdefa..058c29c7fc 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
## [Unreleased]
* feat: allow tabs to have different sizes if clients aren't focused on the same one (htt... | [
"CHANGELOG.md",
"Cargo.lock",
"Cargo.toml",
"zellij-client/src/stdin_handler_windows.rs",
"zellij-server/src/os_input_output_windows.rs",
"zellij-utils/src/sessions.rs"
] | [] | true | |
zellij-org/zellij | 5,133 | issue_to_patch | Independent tab sizes | This allows different tabs in the same session to have different sizes. In effect making it possible for one attached client's screen size not to affect the other's so long as they are on different tabs. | f2e02cf1af1e158875736d939fec34ea11fb36e5 | af928eb8760084c524af1c6d87757b016db60263 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index ce261a51b4..cd712cdefa 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,7 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
## [Unreleased]
+* feat: allow tabs ... | [
"CHANGELOG.md",
"zellij-server/src/lib.rs",
"zellij-server/src/route.rs",
"zellij-server/src/screen.rs",
"zellij-server/src/tab/mod.rs",
"zellij-server/src/unit/screen_tests.rs",
"zellij-utils/src/errors.rs"
] | [] | true | ||
zellij-org/zellij | 4,617 | issue_to_patch | EditScrollback and DumpScreen `--raw` or `--ansi` please?
Currently, there is no way to recover the ansi codes used for the current buffer/pane or window.
Use case:
You would like to share your terminal snippet that does not have markdown highlighting support on Discord. Discord now supports the `ansi` code block.... | Add optional support for raw scrollback with ansi | fixes https://github.com/zellij-org/zellij/issues/3937#issuecomment-3768482297
The current approach follows the minimum required changes to make it work. Next follow-ups or options could be:
- Give also support for `edit_scrollback_for_pane_with_id` (not sure if practically need it)
- Instead of duplicate codepa... | 36fa696c1a71b236e27d62bac26e4f0ee136cde4 | 58b0d159a1cc40480b8bfd06b39ea87cf6cfd6e0 | diff --git a/zellij-server/src/panes/grid.rs b/zellij-server/src/panes/grid.rs
index 58b10cdeff..262c5040c1 100644
--- a/zellij-server/src/panes/grid.rs
+++ b/zellij-server/src/panes/grid.rs
@@ -288,6 +288,45 @@ macro_rules! dump_screen {
}};
}
+macro_rules! dump_screen_with_ansi {
+ ($lines:expr) => {{
+ ... | [
"zellij-server/src/panes/grid.rs",
"zellij-server/src/panes/terminal_pane.rs",
"zellij-server/src/route.rs",
"zellij-server/src/screen.rs",
"zellij-server/src/tab/mod.rs",
"zellij-utils/src/input/actions.rs",
"zellij-utils/src/ipc/protobuf_conversion.rs",
"zellij-utils/src/kdl/mod.rs",
"zellij-utils... | [
{
"comment": "So, here we want the last space character that doesn't have styles (otherwise we will truncate space characters with backgrounds - a real world example is `delta`'s git diff). I recently fixed this bug in our own rendering engine if you'd like to see how it's done: https://github.com/zellij-org/ze... | true | |
zellij-org/zellij | 5,127 | issue_to_patch | fix: when publishing, publish current branch rather than hardcoded main | Small fix to our release process, in preparation to working with release branches. | b5e39d54246a845bc293cf1521d367b39f476772 | 5d8ac0239916f33f2c0f946c6a7ffbf15b94e5ad | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 042cf5cce5..61181d277c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -13,6 +13,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* feat: support `CSI 2031` + dark/light mode theme switching (https://github.com/zellij-org/zellij/pull/51... | [
"CHANGELOG.md",
"xtask/src/pipelines.rs"
] | [] | true | ||
zellij-org/zellij | 5,117 | issue_to_patch | Fullscreen resize fixes | This fixes two bugs:
1. When changing a pane to fullscreen, then resizing the terminal (or changing the font size), then bringing it back, the layout would get messed up. Fixed with some bookkeeping during resize.
2. When resizing a pane to fullscreen, editing its scrollback, bringing it back to its normal size and t... | 914953758357024d3c1aeaa496bfe8df906f8416 | f79353632270de51aa26793e17d26bdf4ec2d8e8 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 04a2fffbbb..042cf5cce5 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* fix: prevent occasional duplicate characters in the web client due to IME (https://github.com/zellij-org... | [
"CHANGELOG.md",
"zellij-server/src/panes/tiled_panes/mod.rs",
"zellij-server/src/tab/mod.rs",
"zellij-server/src/tab/unit/tab_tests.rs"
] | [] | true | ||
zellij-org/zellij | 5,113 | issue_to_patch | fix: buffer pty processing while waiting for host query reply | Continuing the work in https://github.com/zellij-org/zellij/pull/5105 - this makes sure to block (buffer) pty processing while waiting for a host query reply (eg. to OSC10/11). | 71e388a2e2bb2bfa9239a669c450130a81699489 | dace2549ae8dcc6482ea6a3b2724252afe121ab3 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 87dfd44981..04a2fffbbb 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,7 +10,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* fix: restore kitty keyboard mode on error, handle DECRPM 2026 state 3, clean up client terminal teardown... | [
"CHANGELOG.md",
"zellij-server/src/panes/terminal_pane.rs",
"zellij-server/src/screen.rs",
"zellij-server/src/tab/mod.rs",
"zellij-server/src/unit/screen_tests.rs",
"zellij-utils/src/errors.rs"
] | [] | true | ||
zellij-org/zellij | 5,105 | issue_to_patch | Allow automatic light/dark mode detection from applications running within zellij (CSI 2031)
Several terminal emulators now allow for automatic switching between light and dark themes, and allow applications running within the terminal to subscribe to theme changes. Automatic switching off all applications together is... | Support CSI2031 (dark/light theme switching) + remove STDIN cache to avoid stale color queries | ### Dark/Light theme auto and manual switching
The main user-facing addition in this PR is support for light/dark theme switches, both through the [CSI2031 protocol](https://github.com/contour-terminal/contour/blob/master/docs/vt-extensions/color-palette-update-notifications.md) and manually through 3 new actions: `ze... | 5ab8b6870ccb475ec06fedd7ca3f891ef7bf51ff | d8c469f1843b7b96cc7da274880dc101dbe25aec | diff --git a/CHANGELOG.md b/CHANGELOG.md
index ea17ec2607..aa583406cf 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* fix: occasional dropped characters in web client (https://github.com/zellij-org/zellij/pull/5080)
* fix: ... | [
"CHANGELOG.md",
"zellij-client/Cargo.toml",
"zellij-client/src/input_handler.rs",
"zellij-client/src/keyboard_parser.rs",
"zellij-client/src/lib.rs",
"zellij-client/src/stdin_ansi_parser.rs",
"zellij-client/src/stdin_ansi_parser_tests.rs",
"zellij-client/src/stdin_handler.rs",
"zellij-client/src/web... | [] | diff --git a/zellij-utils/src/ipc/tests/roundtrip_tests.rs b/zellij-utils/src/ipc/tests/roundtrip_tests.rs
index 23b8c4ac7c..4847b67947 100644
--- a/zellij-utils/src/ipc/tests/roundtrip_tests.rs
+++ b/zellij-utils/src/ipc/tests/roundtrip_tests.rs
@@ -1,8 +1,8 @@
use super::test_framework::*;
use crate::data::{
- B... | true |
zellij-org/zellij | 5,082 | issue_to_patch | fix(windows): reuse of terminal pane ids breaks new panes from opening | Hello,
I have no idea how this code works so I used AI to fix a critical issue I was having (described below). to be clear this code change does fix my issue, but this is **not necessarily intended to be accepted** verbatim. It is to provide insight to a real dev who knows what they're doing to make a real fix.
b... | 0126a19f4804659a7472421a6d5d1ccd7b562717 | 81b4072925bd8a391bbadef7c417bea26d6bead1 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 1c20fdfdbb..87dfd44981 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,6 +8,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* fix: idle CPU + disk i/o, CommandChanged plugin Event, GetSessionList plugin command (https://github.com/z... | [
"CHANGELOG.md",
"zellij-server/src/os_input_output_windows.rs"
] | [] | true | ||
zellij-org/zellij | 5,110 | issue_to_patch | fix: incorrect interpretation of unicode keys | Reopen #4833
@imsnif | 79c0e2088786fe72050eb4dadf41da1c1ac4afad | cdfca71c9579eca9da3016f39f54f7248f15a0e5 | diff --git a/zellij-client/src/keyboard_parser.rs b/zellij-client/src/keyboard_parser.rs
index 86c29b6dd8..a5cbe1cda7 100644
--- a/zellij-client/src/keyboard_parser.rs
+++ b/zellij-client/src/keyboard_parser.rs
@@ -436,6 +436,24 @@ pub fn can_parse_bare_keys() {
Some(KeyWithModifier::new(BareKey::F(4))),
... | [
"zellij-client/src/keyboard_parser.rs",
"zellij-utils/src/data.rs"
] | [] | true | ||
zellij-org/zellij | 5,111 | issue_to_patch | Implement DECQRM for CSI2031 | Continuing the work from https://github.com/zellij-org/zellij/pull/5105 - this implements DECQRM handling for CSI2031 (I forgot to add it in the previous PR!) | 227142dd567ee72bcc137c116bc1ce2b818975e7 | d41ad739602ff77c2a8a41fa1e8c644cef20b290 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index aa583406cf..05c6080e2e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,7 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* fix: occasional dropped characters in web client (https://github.com/zellij-org/zellij/pull/5080)
* fix: ... | [
"CHANGELOG.md",
"zellij-server/src/panes/grid.rs",
"zellij-server/src/panes/unit/grid_tests.rs"
] | [] | true | ||
zellij-org/zellij | 5,106 | issue_to_patch | upgrade rustls-webpki | This upgrades the rustls-webpki transitive dependency (bumping it 2 patch versions). This is to avoid https://rustsec.org/advisories/RUSTSEC-2026-0104.html
For the removal of doubt: **Zellij is not affected by this vulnerability**.
The only reason I'm issuing the update is because security scanners would often fl... | 5ab8b6870ccb475ec06fedd7ca3f891ef7bf51ff | 5a949f1e81b5f85c8090a81b59201c4b58dc6797 | diff --git a/Cargo.lock b/Cargo.lock
index a250d7910b..8d5522841b 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2915,9 +2915,9 @@ dependencies = [
[[package]]
name = "rustls-webpki"
-version = "0.103.10"
+version = "0.103.13"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "df33b2b81ac5... | [
"Cargo.lock"
] | [] | true | ||
zellij-org/zellij | 4,975 | issue_to_patch | Web client: IME input causes text to repeat N times for N-character composition
## Bug
When using the web client with IME (Chinese input method, tested on Chrome browser), composing a multi-character string causes the entire string to be written N times, where N is the number of characters in the composed string.
- ... | fix(web-client): prevent IME input text repetition | ## Summary
Fixes #4974
Fix bug where composing multi-character strings via IME (e.g. Chinese input method) causes the entire string to be written N times for N characters.
## Changes
Previously, `parse_stdin` sent the entire input buffer as `raw_bytes` for each `KeyEvent` parsed from that buffer. When IME composes ... | 2897ab4898f7be1c233231ef074504ebd411c292 | e33204e86f226518d0ec8efb35dd41b5820d941a | diff --git a/zellij-client/src/web_client/message_handlers.rs b/zellij-client/src/web_client/message_handlers.rs
index 4e554f81e7..0f2c7b5431 100644
--- a/zellij-client/src/web_client/message_handlers.rs
+++ b/zellij-client/src/web_client/message_handlers.rs
@@ -112,13 +112,29 @@ pub fn parse_stdin(
maybe_more... | [
"zellij-client/src/web_client/message_handlers.rs"
] | [
{
"comment": "In the multi-event path, `KeyCode::Char(c)` is re-encoded with `encode_utf8`, but this ignores `key_event.modifiers`. For example, termwiz represents Ctrl+C as `KeyCode::Char('c')` + CTRL with raw bytes `0x03`; re-encoding the char would send `b\"c\"` instead of `0x03` if Ctrl+C ever appears along... | true | |
zellij-org/zellij | 5,080 | issue_to_patch | fix: lost web characters | When typing fast in the web client, on platforms that support IME, we would occasionally lose characters. This is because xterm.js doesn't seem to handle (unless I missed something) IME composition of normal characters (the "I didn't actually need IME" path).
To bypass this, we're sending the character directly if w... | 7d647f7b78992c22b0fb5af4746622b1a2552b73 | 9c089572186f8715f991d746aaf582c1ae501fcc | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6c364bcf04..6ca41673ec 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
## [Unreleased]
* fix: idle CPU + disk i/o, CommandChanged plugin Event, GetSessionList plugin command (h... | [
"CHANGELOG.md",
"zellij-client/assets/input.js"
] | [] | true | ||
zellij-org/zellij | 5,058 | issue_to_patch | fix: kitty keyboard restore on error path + 2026 DECRPM state 3 handling | stdin_ansi_parser.rs: synchronized_output_from_bytes now treats DECRPM state 3 (permanently set) as enabled, matching states 1 and 2. State 3 is a valid "supported and on" response that was previously falling through to None (treated as unsupported).
lib.rs: Unified all three client terminal teardown paths (handle_e... | aa29cbaf6631af0afca6aae427a97b3e478393b3 | 4a06f777c9678943124afb0f80ce20083f0a8c2c | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8290e4be10..6c364bcf04 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
## [Unreleased]
* fix: idle CPU + disk i/o, CommandChanged plugin Event, GetSessionList plugin command (h... | [
"CHANGELOG.md",
"zellij-client/src/lib.rs",
"zellij-client/src/stdin_ansi_parser.rs"
] | [] | true | ||
zellij-org/zellij | 5,063 | issue_to_patch | Some idle CPU and disk/io fixes, new CommandChanged plugin Event | This PR aimed to fix some issues with idle CPU utilization occasionally reaching single-digit percentages in some scenarios. Due to the nature of the fixes, I also found myself adding the following features:
1. `OSC7` support to read directory changes in panes
2. A new `CommandChanged` plugin `Event` that fires (wi... | 0d8ebaa234885ad298962a7b702cbc00bba16521 | 2f9a6d1c24d3ad5f782a6b29dc8a92bd9621f0de | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 276e7ba76b..8290e4be10 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,7 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
## [Unreleased]
+* fix: idle CPU + d... | [
"CHANGELOG.md",
"default-plugins/session-manager/src/main.rs",
"default-plugins/session-manager/src/resurrectable_sessions.rs",
"src/commands.rs",
"zellij-client/src/input_handler.rs",
"zellij-server/src/background_jobs.rs",
"zellij-server/src/lib.rs",
"zellij-server/src/panes/grid.rs",
"zellij-serv... | [] | true | ||
zellij-org/zellij | 5,014 | issue_to_patch | fix(windows): skip modifier re-encoding for Char keys in cast_crossterm_key | PR #4967 added VT modifier encoding for non-Char keys but the guard condition also matched Char keys, re-encoding Ctrl+C from [0x03] to CSI u sequence \x1b[3;5u which shells don't understand. Skip the encoding block for Char keys since they already handle modifiers. | 442cb1572480509a2b229972052aad293d6fd11f | 8e4e8c7925f12e7674302889018f998e1ee47a8b | diff --git a/zellij-server/src/unit/screen_tests.rs b/zellij-server/src/unit/screen_tests.rs
index a93c63bf97..44f0d31abf 100644
--- a/zellij-server/src/unit/screen_tests.rs
+++ b/zellij-server/src/unit/screen_tests.rs
@@ -2267,6 +2267,74 @@ pub fn send_cli_send_keys_action_to_screen() {
assert_snapshot!(format!("... | [
"zellij-server/src/unit/screen_tests.rs",
"zellij-server/src/unit/snapshots/zellij_server__screen__screen_tests__send_cli_ctrl_c_reaches_pty_writer.snap",
"zellij-server/src/unit/snapshots/zellij_server__screen__screen_tests__send_cli_ctrl_w_reaches_pty_writer.snap",
"zellij-utils/src/input/mod.rs"
] | [] | true | ||
zellij-org/zellij | 4,913 | issue_to_patch | ci: add riscv64 to release binaries | ## What does this PR do?
Adds `riscv64gc-unknown-linux-gnu` to the release workflow matrix so that each release includes pre-built riscv64 binaries (both normal and no-web variants).
## Why
Since #3349 switched from Wasmer to Wasmtime, zellij runs on riscv64. However, users on RISC-V boards must build from source. A... | e7fbd985cbbf52cc569ec2c0250b51f0c67c2eff | b7504a72ec82302f6a06d12e8f0c1d218a24527e | diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 9a2f1f458b..db5cddf7dd 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -33,6 +33,7 @@ jobs:
build:
- linux musl x64
- linux musl aarch64
+ - linux musl riscv64
... | [
".github/workflows/release.yml"
] | [] | true | ||
zellij-org/zellij | 5,012 | issue_to_patch | fix(ci): pin WiX CLI to v6.0.2 to avoid v7 OSMF EULA gate | WiX v7 introduced a mandatory EULA acceptance that breaks unattended CI builds. Pin the dotnet tool install to 6.0.2 to match the extension. | f2af4fe5e35a553aa9b0494ca86d85b73c625c66 | 0e0f912bfeee0dfe1761297db119a64c13228566 | diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index db5cddf7dd..1c01bbf3da 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -169,7 +169,7 @@ jobs:
# ===== Windows MSI installer =====
- name: Install WiX v6
if: runner.os == 'Windows'
- ... | [
".github/workflows/release.yml"
] | [] | true | ||
zellij-org/zellij | 5,011 | issue_to_patch | Minor fix before patch version | This bumps the patch version to 0.44.1, and also contains a minor fix to row background coloring as part of some of the patch fixes. | 985cca716ed5ff130dbe72694f4135602389d613 | 32b9edc71b95d92be6567f8ed0673cca63dacb9f | diff --git a/CHANGELOG.md b/CHANGELOG.md
index dc7693d1c0..7bd30fee65 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -19,7 +19,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* fix: scrollback with partial scroll region (eg. Codex bug) (https://github.com/zellij-org/zellij/pull/49... | [
"CHANGELOG.md",
"Cargo.lock",
"Cargo.toml",
"zellij-server/src/panes/grid.rs"
] | [] | true | ||
zellij-org/zellij | 5,010 | issue_to_patch | Fix pty race when opening new panes | This fixes an occasional race condition when starting new panes: if the command is extremely short lived (eg. `echo hello`) and is run directly and not in the context of a shell (eg. through `zellij run`), we would sometimes have cases where the command bytes and the `HoldPane` directive would arrive before the `NewPan... | 060b7f41a04dc2ff760df2f81c5f007cf0af95f7 | fda929a64f0b0409ada0bf4f17a3438a194bfa3a | diff --git a/CHANGELOG.md b/CHANGELOG.md
index a5ce02e873..382682965a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -25,6 +25,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* fix: encode modifiers in raw bytes for non-Char keys in windows (https://github.com/zellij-org/zellij/pu... | [
"CHANGELOG.md",
"zellij-server/src/screen.rs",
"zellij-server/src/unit/screen_tests.rs"
] | [] | true | ||
zellij-org/zellij | 4,962 | issue_to_patch | Ansi code for resetting bold should not reset underline
<!-- Please choose the relevant section, follow the instructions and delete the other sections:
1. Graphical issue inside a terminal pane (eg. something does not look as it should or as it looks outside of Zellij)
2. Issues with the Zellij UI / behavior / crash
... | fix(ansi): reset bold should not entail reset underline | Fixes: https://github.com/zellij-org/zellij/issues/4961
According to [ANSI Escape Sequences cheatsheet](https://gist.github.com/ConnerWill/d4b6c776b509add763e17f9f113fd25b#colors--graphics-mode):
- the escape code for reset bold is `ESC[22m` and shouldn't entail `ESC[24m` reset underline
- my change fixes that b... | 00c6b0f549bd25ce82b73da8138d3c63599525f7 | 5fd4b2e9f4a34abfa89976a05545e326b9f32591 | diff --git a/zellij-server/src/panes/terminal_character.rs b/zellij-server/src/panes/terminal_character.rs
index 2db884ae04..12463af88e 100644
--- a/zellij-server/src/panes/terminal_character.rs
+++ b/zellij-server/src/panes/terminal_character.rs
@@ -693,16 +693,11 @@ impl Display for CharacterStyles {
... | [
"zellij-server/src/panes/terminal_character.rs"
] | [] | true | |
zellij-org/zellij | 4,979 | issue_to_patch | Name flag and name option does not work on windows
## Issue description name pane does not run a pane with the given name
## Minimal reproduction
On windows 11 run a clean instance of zellij and the use the following command
```bash
zellij action new-pane --name flame -f
```
The pane will not be renamed, it will sho... | fix: respect --name flag when creating new panes | The user-provided pane name (`--name`) was being discarded for default shell panes because `use_terminal_title` was set to true, which caused `pane_title` to be set to `None`. The name was also never passed as `pane_name` to `TerminalPane` — it was always hardcoded to empty string.
Three issues fixed:
1. Pane cre... | 6542afabd80e44ab730413b92e3456a15a5f0a2f | fd3680be8958c13c57b71e0a12f453ea8bea6a4a | diff --git a/zellij-server/src/pty.rs b/zellij-server/src/pty.rs
index bb9c800cbb..0fdcddc45d 100644
--- a/zellij-server/src/pty.rs
+++ b/zellij-server/src/pty.rs
@@ -226,10 +226,14 @@ pub(crate) fn pty_thread_main(mut pty: Pty, layout: Box<Layout>) -> Result<()> {
Some(TerminalAction::RunComma... | [
"zellij-server/src/pty.rs",
"zellij-server/src/route.rs",
"zellij-server/src/screen.rs",
"zellij-server/src/tab/mod.rs",
"zellij-server/src/tab/unit/tab_tests.rs",
"zellij-server/src/unit/screen_tests.rs",
"zellij-utils/src/errors.rs",
"zellij-utils/src/input/actions.rs",
"zellij-utils/src/ipc/proto... | [] | diff --git a/zellij-utils/src/ipc/tests/roundtrip_tests.rs b/zellij-utils/src/ipc/tests/roundtrip_tests.rs
index 7ef7ac89a0..23b8c4ac7c 100644
--- a/zellij-utils/src/ipc/tests/roundtrip_tests.rs
+++ b/zellij-utils/src/ipc/tests/roundtrip_tests.rs
@@ -1480,6 +1480,24 @@ fn test_client_messages() {
client_id: So... | true |
zellij-org/zellij | 4,918 | issue_to_patch | fix: performance regression when switching tabs | This fixes an issue reported in https://github.com/zellij-org/zellij/issues/4903 where in some systems switching tabs would lag in 0.44.0 compared to 0.43.1.
This was caused by the migration to wasmi from wasmtime exposing a long-standing performance issue where we would serialize an excessive amount of data in an o... | 15485aea7dc972f67588783b290fd399b2fba856 | 699cac6a334ddf14ad1cbe3bbde874b1aae292a7 | diff --git a/default-plugins/compact-bar/src/main.rs b/default-plugins/compact-bar/src/main.rs
index 074e5181a6..3a8446a518 100644
--- a/default-plugins/compact-bar/src/main.rs
+++ b/default-plugins/compact-bar/src/main.rs
@@ -60,6 +60,9 @@ struct State {
is_first_run: bool,
own_tab_index: Option<usize>,
... | [
"default-plugins/compact-bar/src/main.rs",
"default-plugins/fixture-plugin-for-tests/src/main.rs",
"default-plugins/status-bar/src/main.rs",
"default-plugins/tab-bar/src/main.rs",
"src/tests/e2e/cases.rs",
"src/tests/e2e/snapshots/zellij__tests__e2e__cases__scrolling_inside_a_pane.snap",
"zellij-server/... | [] | diff --git a/src/tests/e2e/cases.rs b/src/tests/e2e/cases.rs
index 4def098157..72ce01846e 100644
--- a/src/tests/e2e/cases.rs
+++ b/src/tests/e2e/cases.rs
@@ -1148,7 +1148,9 @@ pub fn detach_and_attach_session() {
name: "Wait for session to be attached",
instruction: |remote_terminal: RemoteTe... | true | |
zellij-org/zellij | 4,951 | issue_to_patch | fix: position host cursor for CJK IME even when app hides cursor | ## Summary
When apps like Claude Code (which uses the ink/React library) run inside Zellij,
IME composition candidates appear at the wrong position. This makes CJK input
(Japanese, Chinese, Korean) effectively broken in these apps.
The same apps work correctly in a bare terminal or under tmux.
## Root cause
... | 0532949bbdcee5116e91807ddb45a85d78a2aafc | c2b729f0ab7a84e5ecc037673e02450647cd5e78 | diff --git a/zellij-server/src/panes/grid.rs b/zellij-server/src/panes/grid.rs
index 79a9a7b4d4..ddb462cd8d 100644
--- a/zellij-server/src/panes/grid.rs
+++ b/zellij-server/src/panes/grid.rs
@@ -1574,11 +1574,15 @@ impl Grid {
sixel_image_chunks,
)));
}
- pub fn cursor_coordinates(&self) -... | [
"src/tests/e2e/remote_runner.rs",
"zellij-server/src/panes/grid.rs",
"zellij-server/src/panes/plugin_pane.rs",
"zellij-server/src/panes/terminal_pane.rs",
"zellij-server/src/panes/tiled_panes/unit/stacked_panes_tests.rs",
"zellij-server/src/panes/unit/grid_tests.rs",
"zellij-server/src/tab/mod.rs",
"z... | [] | diff --git a/src/tests/e2e/remote_runner.rs b/src/tests/e2e/remote_runner.rs
index 20f4e0c3de..958b8f1e97 100644
--- a/src/tests/e2e/remote_runner.rs
+++ b/src/tests/e2e/remote_runner.rs
@@ -337,8 +337,10 @@ fn read_from_channel(
Ok(0) => {
let current_snapshot = ta... | true | |
zellij-org/zellij | 4,967 | issue_to_patch | [Windows] Even when in 'locked' mode modifier keys aren't making it to downstream apps
## Issue Description
Modifier Keys i.e. 'alt', 'shift', etc aren't being passed to downstream applications, even when zellij is in locked mode. This issue only occurs on Windows. ( I verified it didn't happen on Linux with Ghostty a... | fix(windows): encode modifiers in raw bytes for non-Char keys | On the native console input path, crossterm captures modifier flags from INPUT_RECORD but the raw bytes written to the PTY don't include them. This causes inner applications to never see ALT, SHIFT, or CTRL modifiers for keys like Enter, Tab, Backspace, arrows, and function keys.
Encode modifiers using standard VT c... | 22ace8e54fbdadd08973854ae7178535a62065b1 | 135f0e9e8affac5035ce45e2b53698498b2515e1 | diff --git a/zellij-utils/src/input/mod.rs b/zellij-utils/src/input/mod.rs
index fecc958fdb..c8ac1e9116 100644
--- a/zellij-utils/src/input/mod.rs
+++ b/zellij-utils/src/input/mod.rs
@@ -402,6 +402,57 @@ mod not_wasm {
_ => return None,
};
+ // Encode modifiers in VT raw bytes for non-Cha... | [
"zellij-utils/src/input/mod.rs"
] | [] | true | |
zellij-org/zellij | 4,981 | issue_to_patch | Web client: session switch ignores base_url behind reverse proxy
When switching sessions via the session manager, the web client redirects to `/{session_name}` instead of `{base_url}/{session_name}`, ignoring the configured `base_url`.
**Steps to reproduce:**
1. Configure `base_url = "/zellij/"` in `web_client` confi... | fix(web-client): use base URL when switching sessions | ## Summary
Fixes #4980
When switching sessions via the session manager, the web client redirects to `/{session_name}`, ignoring the configured `base_url`. This breaks all reverse proxy setups that serve zellij under a subpath.
## Changes
Use `getBaseUrl()` to construct the redirect URL in `websockets.js`, consisten... | 1411b2d9adf2d08a6e14f3262493ca9e6d26b219 | 07ba27cc531310540e6e865ca9fd917a812f5b53 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 62edea0a0f..221b19b944 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -20,6 +20,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* fix: remote attach issues on macOS (https://github.com/zellij-org/zellij/pull/4972)
* test: improve e2e... | [
"CHANGELOG.md",
"zellij-client/assets/websockets.js"
] | [
{
"comment": "just a small thing, should use `${encodeURIComponent(new_session_name)`.\nhref and pathname behave a bit differently and we could have problems if the session name contains special characters",
"path": "zellij-client/assets/websockets.js",
"hunk": "@@ -241,7 +241,8 @@ function startWsContr... | true | |
zellij-org/zellij | 4,992 | issue_to_patch | Fix bce and other issues | Some minor fixes for long standing issues, recently exposed, in our ANSI interpreter regarding background colors. Namely, we now make sure to pad (on render for trailing characters, as part of the grid for internal padding operations) using the style of the row's default background color (given to it in turn by the cur... | 6542afabd80e44ab730413b92e3456a15a5f0a2f | 73c494647da98785953a1bc2621f0f74dadf8c8a | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7a507a9d8b..62edea0a0f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -19,6 +19,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* fix: scrollback with partial scroll region (eg. Codex bug) (https://github.com/zellij-org/zellij/pull/49... | [
"CHANGELOG.md",
"zellij-server/src/output/mod.rs",
"zellij-server/src/panes/grid.rs",
"zellij-server/src/panes/unit/grid_tests.rs"
] | [] | true | ||
zellij-org/zellij | 4,941 | issue_to_patch | Preserve scrollback for partial scroll regions starting at top | When a partial scroll region starts at row 0 (the top of the viewport), lines scrolled off the top were silently discarded via viewport.remove(0) instead of being transferred to lines_above (the scrollback buffer). This affected both add_canonical_line and rotate_scroll_region_down.
Applications like Codex CLI use p... | 22ace8e54fbdadd08973854ae7178535a62065b1 | e39435ab95c7191f5bbde564525c71546b88259f | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6ec77b24f5..38b152f40b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -16,6 +16,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* fix: compilation warnings in windows (https://github.com/zellij-org/zellij/pull/4890)
* feat: add --lay... | [
"CHANGELOG.md",
"zellij-server/src/panes/grid.rs",
"zellij-server/src/panes/unit/grid_tests.rs"
] | [] | true | ||
zellij-org/zellij | 4,952 | issue_to_patch | fix(e2e): stabilize tests and support Apple Silicon local dev | Tried to run e2e tests locally on macOS, and ran into some problems due to the amd64 docker emulation being slow.
- cross-compile musl binary on macOS via cargo-zigbuild, with arch-independent symlink so snapshots are stable across x86_64 and aarch64
- kill_running_sessions() now calls stop_zellij() instead of star... | 7c68623580342940d7cd53bc8bce1926841feb47 | 07cc583d9e5bfa590d22a67850bc8e8cf5110707 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6ba6b22a65..7a507a9d8b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -18,6 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* fix: proper error on socket paths that are too long (https://github.com/zellij-org/zellij/pull/4957)
* ... | [
"CHANGELOG.md",
"CONTRIBUTING.md",
"src/tests/e2e/cases.rs",
"src/tests/e2e/remote_runner.rs",
"src/tests/e2e/snapshots/zellij__tests__e2e__cases__override_layout_from_default_to_compact.snap",
"src/tests/e2e/snapshots/zellij__tests__e2e__cases__send_blocking_command_through_the_cli.snap",
"src/tests/e2... | [] | diff --git a/src/tests/e2e/cases.rs b/src/tests/e2e/cases.rs
index 72ce01846e..854e1c9398 100644
--- a/src/tests/e2e/cases.rs
+++ b/src/tests/e2e/cases.rs
@@ -296,6 +296,7 @@ pub fn scrolling_inside_a_pane() {
let mut step_is_complete = false;
if remote_terminal.cursor_position... | true | |
zellij-org/zellij | 4,972 | issue_to_patch | remote terminal attach didn't work
Latest version 0.44.0.
Tried to attach to remote terminal and got different error on MacOS and Ubuntu.
MacOS:
```
$ zellij attach https://10.10.0.1/fascinating-mountain --token #### --ca-cert localhost+3-jb-ca.pem
Connection failed: TLS error: native-tls error: bad protocol version
... | Move from native-tls to rustls in the remote client (mirrors the web server) | This should fix https://github.com/zellij-org/zellij/issues/4955
Essentially, we were using native-tls, which on macOS (apparently) only supports tls1.2, while our webserver requires tls1.3. To solve this, I moved our https client from native-tls to rustls (we have it as a dependency for our web server anyway). | 50c029afaf3f1b412583f7cfe7aa9f0ee984ffa8 | cea51035b382f836de6ae13b6f8d8df21fd02d3f | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 38b152f40b..6ba6b22a65 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -17,6 +17,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* feat: add --layout-string to allow for in-line layouts, add --tab-id to all new-pane CLI commands (https... | [
"CHANGELOG.md",
"Cargo.lock",
"zellij-client/Cargo.toml",
"zellij-client/src/remote_attach/mod.rs",
"zellij-client/src/remote_attach/unit/remote_attach_tests.rs",
"zellij-client/src/remote_attach/websockets.rs",
"zellij-client/src/unit/terminal_loop_tests.rs",
"zellij-utils/src/remote_session_tokens.r... | [] | true | |
zellij-org/zellij | 4,958 | issue_to_patch | Proper error when providing layout name with a tab | Provide a proper error when providing a `name` (and similar) properties on the `layout` node if we already have one or more `tab` nodes. | 00c6b0f549bd25ce82b73da8138d3c63599525f7 | 4ead2d97727c36b72d34314118571eccb8738470 | diff --git a/zellij-utils/src/kdl/kdl_layout_parser.rs b/zellij-utils/src/kdl/kdl_layout_parser.rs
index ff7fcfe371..579a4b1402 100644
--- a/zellij-utils/src/kdl/kdl_layout_parser.rs
+++ b/zellij-utils/src/kdl/kdl_layout_parser.rs
@@ -2505,9 +2505,23 @@ impl<'a> KdlLayoutParser<'a> {
let layout_has_hide_fl... | [
"zellij-utils/src/input/unit/layout_test.rs",
"zellij-utils/src/kdl/kdl_layout_parser.rs"
] | [] | diff --git a/zellij-utils/src/input/unit/layout_test.rs b/zellij-utils/src/input/unit/layout_test.rs
index 4ba33c12ea..52b716133f 100644
--- a/zellij-utils/src/input/unit/layout_test.rs
+++ b/zellij-utils/src/input/unit/layout_test.rs
@@ -2341,7 +2341,7 @@ fn layout_node_with_multiple_tab_properties() {
}
#[test]
-... | true | |
zellij-org/zellij | 4,957 | issue_to_patch | Error on socket paths that are too long | Previously, if we generated a session name that would exceed the system socket file length - the session would silently hang. This changes it (and related paths) so that we provide a proper error as well as a way to mitigate this. | 8ce05f0bbd58acbbca95f95ae14fdc4e866f7391 | bafaf8632b6cccd6edc3feb5443a2c383f8519db | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 76ad03df04..6ec77b24f5 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -15,6 +15,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* fix: normalize temp socket paths in windows (https://github.com/zellij-org/zellij/pull/4923)
* fix: com... | [
"CHANGELOG.md",
"zellij-client/src/cli_client.rs",
"zellij-client/src/lib.rs",
"zellij-client/src/web_client/session_management.rs",
"zellij-utils/src/consts.rs"
] | [] | true | ||
zellij-org/zellij | 4,956 | issue_to_patch | Layout string flag | This adds two things:
1. The various `--layout` receiving CLI commands now also have a `--layout-string` flag, allowing us to in-line a layout if we so wish (eg. `zellij action new-tab --layout-string "layout { pane; pane command=\"htop\"; }; "`). I think this will make some scripting scenarios much easier. This was... | 16beceaa0afcdb559316909ed87b84d487356fa6 | 94a1d9f754b6a39c75207ead5e046114fe14e630 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index ad47444ad9..76ad03df04 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -14,6 +14,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* feat: support and forward OSC-99 desktop notifications (https://github.com/zellij-org/zellij/pull/4931)
... | [
"CHANGELOG.md",
"default-plugins/compact-bar/src/keybind_utils.rs",
"default-plugins/status-bar/src/one_line_ui.rs",
"default-plugins/status-bar/src/second_line.rs",
"src/main.rs",
"zellij-client/src/lib.rs",
"zellij-server/src/plugins/wasm_bridge.rs",
"zellij-server/src/plugins/zellij_exports.rs",
... | [] | diff --git a/zellij-utils/src/ipc/tests/roundtrip_tests.rs b/zellij-utils/src/ipc/tests/roundtrip_tests.rs
index cfe882a1ac..7ef7ac89a0 100644
--- a/zellij-utils/src/ipc/tests/roundtrip_tests.rs
+++ b/zellij-utils/src/ipc/tests/roundtrip_tests.rs
@@ -1,8 +1,8 @@
use super::test_framework::*;
use crate::data::{
B... | true | |
zellij-org/zellij | 4,923 | issue_to_patch | [windows] : unstable over openning same session over ssh and wezterm
```
WARN |zellij_server::route | 2026-03-19 03:39:06.169 [server_router] [zellij-server\src\route.rs:2134]: Server not ready, trying to place instruction in retry queue...
WARN |zellij_server::route | 2026-03-19 03:39:06.169 [server_route... | fix(windows): normalize temp socket paths | ## Summary
- Normalize Windows temp/socket paths so named pipes match across login contexts.
Fix #4870 | 9014486ae70fa10ad8083d37837a4f17570f2ee8 | 94f85e6e3947ea12c333ad6c21ed6b66872fc6df | diff --git a/Cargo.lock b/Cargo.lock
index 8fc53c96a2..42b0873634 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -4960,6 +4960,7 @@ dependencies = [
"crossterm",
"curl-sys",
"directories",
+ "dunce",
"expect-test",
"humantime",
"include_dir",
diff --git a/zellij-utils/Cargo.toml b/zellij-utils/Cargo.toml
index... | [
"Cargo.lock",
"zellij-utils/Cargo.toml",
"zellij-utils/src/consts.rs"
] | [] | true | |
zellij-org/zellij | 4,890 | issue_to_patch | fix: resolve Windows compilation warnings | - Consume unused `CompilationResult` from `embed_resource::compile` in `build.rs`
- Gate `std::io::prelude` import with `#[cfg(unix)]` since it's only used by `daemonize_web_server` which is unix-only | e7fbd985cbbf52cc569ec2c0250b51f0c67c2eff | 1d6f67013c1d4af34d320053f4e7d853f90a459e | diff --git a/src/build.rs b/src/build.rs
index 613c948308..ef173e3a59 100644
--- a/src/build.rs
+++ b/src/build.rs
@@ -9,5 +9,5 @@ fn main() {
// Embed the application icon into the Windows executable.
#[cfg(target_os = "windows")]
- embed_resource::compile("assets/zellij.rc", embed_resource::NONE);
+ ... | [
"src/build.rs",
"zellij-client/src/web_client/mod.rs"
] | [] | true | ||
zellij-org/zellij | 4,931 | issue_to_patch | Support OSC-99 desktop notifications | This adds support for OSC99, which means Zellij will now forward desktop notifications that arrive from applications running inside panes.
Furthermore, when notifications are clicked, Zellij will also focus the relevant pane that sent the notification. If the pane requested a response, Zellij will also forward the r... | 802c96f5fca9de479af7c249130a7928bc441349 | 65fa7b6588545faf555f5c0bca302d4603f7664f | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 90401de9a9..b309db5a9a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* fix: performance regression when switching tabs (https://github.com/zellij-org/zellij/pull/4918)
* feat... | [
"CHANGELOG.md",
"zellij-client/src/input_handler.rs",
"zellij-client/src/lib.rs",
"zellij-client/src/stdin_handler.rs",
"zellij-server/src/panes/grid.rs",
"zellij-server/src/panes/terminal_pane.rs",
"zellij-server/src/route.rs",
"zellij-server/src/screen.rs",
"zellij-server/src/tab/mod.rs",
"zelli... | [] | true | ||
zellij-org/zellij | 4,926 | issue_to_patch | CLI focus-pane-id and are-floating-panes-visible actions | This adds two CLI actions that I forgot to add in the recent CLI overhaul. Namely:
1. `zellij action focus-pane-id terminal_1` -> change the focus of the most-recently-active user to the specified pane
2. `zellij action are-floating-panes-visible` -> returns true (exit 0) if floating panes are visible in the active t... | 2134deb5d565f308a2ce27909a8d611116d58be2 | 8602e100a5c2df8237573cbb5093bc37c8d5fb49 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index eb59ec9346..90401de9a9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* fix: theme folder not being picked up on startup (https://github.com/zellij-org/zellij/pull/4892)
* fix: ... | [
"CHANGELOG.md",
"zellij-server/src/plugins/unit/snapshots/zellij_server__plugins__plugin_tests__break_panes_to_new_tab_plugin_command.snap",
"zellij-server/src/plugins/unit/snapshots/zellij_server__plugins__plugin_tests__break_panes_to_tab_with_index_plugin_command.snap",
"zellij-server/src/plugins/unit/snaps... | [] | diff --git a/zellij-utils/src/ipc/tests/roundtrip_tests.rs b/zellij-utils/src/ipc/tests/roundtrip_tests.rs
index 78e68f524f..cfe882a1ac 100644
--- a/zellij-utils/src/ipc/tests/roundtrip_tests.rs
+++ b/zellij-utils/src/ipc/tests/roundtrip_tests.rs
@@ -3295,6 +3295,14 @@ fn test_client_messages() {
client_id: So... | true | |
zellij-org/zellij | 4,919 | issue_to_patch | fix: do not reset layout selection in layout manager | This is a fix for https://github.com/zellij-org/zellij/issues/4891 | e220f1bd11d088d17b393398b1adcf912c852827 | 56e071977076c1fc82f4b3f2da1c2f8e6d2e2d44 | diff --git a/default-plugins/session-manager/src/main.rs b/default-plugins/session-manager/src/main.rs
index c4ad26fb1f..afade742ed 100644
--- a/default-plugins/session-manager/src/main.rs
+++ b/default-plugins/session-manager/src/main.rs
@@ -152,8 +152,19 @@ impl ZellijPlugin for State {
&self... | [
"default-plugins/session-manager/src/main.rs"
] | [] | true | ||
zen-browser/desktop | 14,113 | issue_to_patch | Bookmarks bar is showing duplicate bookmarks
### Preliminary Checks
- [x] I have read and understood the important section above.
- [x] I have searched existing issues and avoided creating duplicates.
- [x] I am not filing an enhancement request.
- [x] I have checked that this issue cannot be reproduced on Mozilla Fi... | gh-9540: duplicated bookmarks on macOS window reopen | ## Summary
After closing the last browser window on macOS (which keeps the app alive in the dock) and reopening a window from the dock, the bookmarks toolbar would render its items twice (e.g. `A B C D` becomes `A B C D A B C D`).
## Steps to reproduce
1. On macOS, open Zen with the bookmarks toolbar visible a... | d5cbe55d2b16a599e59b2a25ae9df37270bb5bc4 | 1a3210e8243270b64dd3809129b6bdd255c3f7e7 | diff --git a/src/zen/common/modules/ZenStartup.mjs b/src/zen/common/modules/ZenStartup.mjs
index 93e549f5634..307fa0dbfbc 100644
--- a/src/zen/common/modules/ZenStartup.mjs
+++ b/src/zen/common/modules/ZenStartup.mjs
@@ -100,7 +100,16 @@ class ZenStartup {
delete this.promiseInitializedResolve;
setTimeo... | [
"src/zen/common/modules/ZenStartup.mjs"
] | [
{
"comment": "I think it would be better to just call `.then()` + linter doesnt allow async functions inside setTimeout",
"path": "src/zen/common/modules/ZenStartup.mjs",
"hunk": "@@ -99,7 +99,9 @@ class ZenStartup {\n this.promiseInitializedResolve();\n delete this.promiseInitializedResolve... | true | |
zen-browser/desktop | 14,113 | comment_to_fix | gh-9540: duplicated bookmarks on macOS window reopen | I think it would be better to just call `.then()` + linter doesnt allow async functions inside setTimeout | d5cbe55d2b16a599e59b2a25ae9df37270bb5bc4 | 1a3210e8243270b64dd3809129b6bdd255c3f7e7 | diff --git a/src/zen/common/modules/ZenStartup.mjs b/src/zen/common/modules/ZenStartup.mjs
index 93e549f5634..307fa0dbfbc 100644
--- a/src/zen/common/modules/ZenStartup.mjs
+++ b/src/zen/common/modules/ZenStartup.mjs
@@ -100,7 +100,16 @@ class ZenStartup {
delete this.promiseInitializedResolve;
setTimeo... | [
"src/zen/common/modules/ZenStartup.mjs"
] | [
{
"comment": "I think it would be better to just call `.then()` + linter doesnt allow async functions inside setTimeout",
"path": "src/zen/common/modules/ZenStartup.mjs",
"hunk": "@@ -99,7 +99,9 @@ class ZenStartup {\n this.promiseInitializedResolve();\n delete this.promiseInitializedResolve... | true | ||
zen-browser/desktop | 14,113 | comment_to_fix | gh-9540: duplicated bookmarks on macOS window reopen | No need for `Promise.resolve` here? promiseRebuilt already returns a promise. | d5cbe55d2b16a599e59b2a25ae9df37270bb5bc4 | 1a3210e8243270b64dd3809129b6bdd255c3f7e7 | diff --git a/src/zen/common/modules/ZenStartup.mjs b/src/zen/common/modules/ZenStartup.mjs
index 93e549f5634..307fa0dbfbc 100644
--- a/src/zen/common/modules/ZenStartup.mjs
+++ b/src/zen/common/modules/ZenStartup.mjs
@@ -100,7 +100,16 @@ class ZenStartup {
delete this.promiseInitializedResolve;
setTimeo... | [
"src/zen/common/modules/ZenStartup.mjs"
] | [
{
"comment": "No need for `Promise.resolve` here? promiseRebuilt already returns a promise.",
"path": "src/zen/common/modules/ZenStartup.mjs",
"hunk": "@@ -100,7 +100,12 @@ class ZenStartup {\n delete this.promiseInitializedResolve;\n \n setTimeout(() => {\n- gZenWorkspaces._invalidat... | true | ||
zen-browser/desktop | 14,113 | comment_to_fix | gh-9540: duplicated bookmarks on macOS window reopen | ```suggestion
document.getElementById("PlacesToolbar")._placesView?.promiseRebuilt()
``` | d5cbe55d2b16a599e59b2a25ae9df37270bb5bc4 | 1a3210e8243270b64dd3809129b6bdd255c3f7e7 | diff --git a/src/zen/common/modules/ZenStartup.mjs b/src/zen/common/modules/ZenStartup.mjs
index 93e549f5634..307fa0dbfbc 100644
--- a/src/zen/common/modules/ZenStartup.mjs
+++ b/src/zen/common/modules/ZenStartup.mjs
@@ -100,7 +100,16 @@ class ZenStartup {
delete this.promiseInitializedResolve;
setTimeo... | [
"src/zen/common/modules/ZenStartup.mjs"
] | [
{
"comment": "```suggestion\n document.getElementById(\"PlacesToolbar\")._placesView?.promiseRebuilt()\n```",
"path": "src/zen/common/modules/ZenStartup.mjs",
"hunk": "@@ -100,7 +100,12 @@ class ZenStartup {\n delete this.promiseInitializedResolve;\n \n setTimeout(() => {\n- ... | true | ||
zen-browser/desktop | 14,113 | comment_to_fix | gh-9540: duplicated bookmarks on macOS window reopen | I'd just store it in a variable and check if its undefined, this looks hacky. Also, please run `npm run lint:fix` | d5cbe55d2b16a599e59b2a25ae9df37270bb5bc4 | 1a3210e8243270b64dd3809129b6bdd255c3f7e7 | diff --git a/src/zen/common/modules/ZenStartup.mjs b/src/zen/common/modules/ZenStartup.mjs
index 93e549f5634..307fa0dbfbc 100644
--- a/src/zen/common/modules/ZenStartup.mjs
+++ b/src/zen/common/modules/ZenStartup.mjs
@@ -100,7 +100,16 @@ class ZenStartup {
delete this.promiseInitializedResolve;
setTimeo... | [
"src/zen/common/modules/ZenStartup.mjs"
] | [
{
"comment": "I'd just store it in a variable and check if its undefined, this looks hacky. Also, please run `npm run lint:fix`",
"path": "src/zen/common/modules/ZenStartup.mjs",
"hunk": "@@ -100,7 +100,12 @@ class ZenStartup {\n delete this.promiseInitializedResolve;\n \n setTimeout(() => {... | true | ||
zen-browser/desktop | 14,113 | comment_to_fix | gh-9540: duplicated bookmarks on macOS window reopen | `_placesView?.promiseRebuilt()` only guards against a missing `_placesView`, but will still throw if `_placesView.promiseRebuilt` is undefined/not a function (e.g. across Firefox versions or in alternative Places views). If the goal is to be defensive and treat “no rebuild waiter available” as “no rebuild in flight”, u... | d5cbe55d2b16a599e59b2a25ae9df37270bb5bc4 | 1a3210e8243270b64dd3809129b6bdd255c3f7e7 | diff --git a/src/zen/common/modules/ZenStartup.mjs b/src/zen/common/modules/ZenStartup.mjs
index 93e549f5634..307fa0dbfbc 100644
--- a/src/zen/common/modules/ZenStartup.mjs
+++ b/src/zen/common/modules/ZenStartup.mjs
@@ -100,7 +100,16 @@ class ZenStartup {
delete this.promiseInitializedResolve;
setTimeo... | [
"src/zen/common/modules/ZenStartup.mjs"
] | [
{
"comment": "`_placesView?.promiseRebuilt()` only guards against a missing `_placesView`, but will still throw if `_placesView.promiseRebuilt` is undefined/not a function (e.g. across Firefox versions or in alternative Places views). If the goal is to be defensive and treat “no rebuild waiter available” as “no... | true | ||
zen-browser/desktop | 14,164 | issue_to_patch | Holding ⌥ on Mac to select the text inside a link is broken
### Captchas
- [x] I have read the instructions.
- [x] I have searched existing issues and avoided creating duplicates.
- [x] I am not filing an enhancement request.
- [x] I have checked that this issue cannot be reproduced on Mozilla Firefox.
- [x] I have c... | gh-8391: Prevent opening glance when selecting text in link (gh-14164) | Fixes #8391
This PR fixes the issue where selecting text inside a link (e.g., holding `Option` and dragging) unintentionally triggers the "Glance" preview.
Solution:
- Track the mouse coordinate on `mousedown`.
- Measure the movement delta (in pixels) on `click`.
- Introduce a standard drag threshold (`CLICK_D... | 4313bc8aa4880f4e6bf2414b48722a62073ffb67 | 0769759f5403afe387355321c8dd16d5a8750519 | diff --git a/src/zen/glance/actors/ZenGlanceChild.sys.mjs b/src/zen/glance/actors/ZenGlanceChild.sys.mjs
index 10d9fff1408..f31b83e6115 100644
--- a/src/zen/glance/actors/ZenGlanceChild.sys.mjs
+++ b/src/zen/glance/actors/ZenGlanceChild.sys.mjs
@@ -17,8 +17,14 @@ XPCOMUtils.defineLazyPreferenceGetter(
true
);
+//... | [
"src/zen/glance/actors/ZenGlanceChild.sys.mjs"
] | [
{
"comment": "This introduces new input-handling behavior (drag threshold gating Glance on click). Since there are existing browser tests under src/zen/tests/glance/, consider adding a test that simulates Option/Alt-drag text selection on a link and asserts that Glance does not open and the link is not activate... | true | |
zen-browser/desktop | 14,164 | comment_to_fix | gh-8391: Prevent opening glance when selecting text in link (gh-14164) | This introduces new input-handling behavior (drag threshold gating Glance on click). Since there are existing browser tests under src/zen/tests/glance/, consider adding a test that simulates Option/Alt-drag text selection on a link and asserts that Glance does not open and the link is not activated (regression coverage... | 4313bc8aa4880f4e6bf2414b48722a62073ffb67 | 0769759f5403afe387355321c8dd16d5a8750519 | diff --git a/src/zen/glance/actors/ZenGlanceChild.sys.mjs b/src/zen/glance/actors/ZenGlanceChild.sys.mjs
index 10d9fff1408..f31b83e6115 100644
--- a/src/zen/glance/actors/ZenGlanceChild.sys.mjs
+++ b/src/zen/glance/actors/ZenGlanceChild.sys.mjs
@@ -17,8 +17,14 @@ XPCOMUtils.defineLazyPreferenceGetter(
true
);
+//... | [
"src/zen/glance/actors/ZenGlanceChild.sys.mjs"
] | [
{
"comment": "This introduces new input-handling behavior (drag threshold gating Glance on click). Since there are existing browser tests under src/zen/tests/glance/, consider adding a test that simulates Option/Alt-drag text selection on a link and asserts that Glance does not open and the link is not activate... | true | ||
zen-browser/desktop | 14,164 | comment_to_fix | gh-8391: Prevent opening glance when selecting text in link (gh-14164) | When movement exceeds the drag threshold this returns before calling preventDefault/stopPropagation, so the underlying anchor click can still fire (e.g., navigation or alt-click download) even though the user was dragging to select. Also, if a mousedown doesn't produce a click (released outside / cancelled), the stored... | 4313bc8aa4880f4e6bf2414b48722a62073ffb67 | 0769759f5403afe387355321c8dd16d5a8750519 | diff --git a/src/zen/glance/actors/ZenGlanceChild.sys.mjs b/src/zen/glance/actors/ZenGlanceChild.sys.mjs
index 10d9fff1408..f31b83e6115 100644
--- a/src/zen/glance/actors/ZenGlanceChild.sys.mjs
+++ b/src/zen/glance/actors/ZenGlanceChild.sys.mjs
@@ -17,8 +17,14 @@ XPCOMUtils.defineLazyPreferenceGetter(
true
);
+//... | [
"src/zen/glance/actors/ZenGlanceChild.sys.mjs"
] | [
{
"comment": "When movement exceeds the drag threshold this returns before calling preventDefault/stopPropagation, so the underlying anchor click can still fire (e.g., navigation or alt-click download) even though the user was dragging to select. Also, if a mousedown doesn't produce a click (released outside / ... | true | ||
zen-browser/desktop | 14,153 | issue_to_patch | Search bar : switching engine clears the input
### Preliminary Checks
- [x] I have read and understood the important section above.
- [x] I have searched existing issues and avoided creating duplicates.
- [x] I am not filing an enhancement request.
- [x] I have checked that this issue cannot be reproduced on Mozilla ... | gh-14127: Fix search bar emptied after search engine selection | fix #14127 | 8b0aab15b5d279b30daf1eb974e8fe09ec8289f6 | a80244472da2ae2089f377d4557d5f4673ae1145 | diff --git a/src/browser/components/urlbar/content/UrlbarInput-mjs.patch b/src/browser/components/urlbar/content/UrlbarInput-mjs.patch
index 43314bcc02f..1b36d9852fd 100644
--- a/src/browser/components/urlbar/content/UrlbarInput-mjs.patch
+++ b/src/browser/components/urlbar/content/UrlbarInput-mjs.patch
@@ -138,7 +138,... | [
"src/browser/components/urlbar/content/UrlbarInput-mjs.patch"
] | [
{
"comment": "This logic change fixes a regression scenario (search-mode changes should not force a revert/clear for non-addressbar inputs), but there’s no automated test covering the reported behavior (#14127). Consider adding a browser test that types a query, switches the selected search engine (e.g. via one... | true | |
zen-browser/desktop | 14,153 | comment_to_fix | gh-14127: Fix search bar emptied after search engine selection | This logic change fixes a regression scenario (search-mode changes should not force a revert/clear for non-addressbar inputs), but there’s no automated test covering the reported behavior (#14127). Consider adding a browser test that types a query, switches the selected search engine (e.g. via one-off buttons/search mo... | 8b0aab15b5d279b30daf1eb974e8fe09ec8289f6 | a80244472da2ae2089f377d4557d5f4673ae1145 | diff --git a/src/browser/components/urlbar/content/UrlbarInput-mjs.patch b/src/browser/components/urlbar/content/UrlbarInput-mjs.patch
index 43314bcc02f..1b36d9852fd 100644
--- a/src/browser/components/urlbar/content/UrlbarInput-mjs.patch
+++ b/src/browser/components/urlbar/content/UrlbarInput-mjs.patch
@@ -138,7 +138,... | [
"src/browser/components/urlbar/content/UrlbarInput-mjs.patch"
] | [
{
"comment": "This logic change fixes a regression scenario (search-mode changes should not force a revert/clear for non-addressbar inputs), but there’s no automated test covering the reported behavior (#14127). Consider adding a browser test that types a query, switches the selected search engine (e.g. via one... | true | ||
zen-browser/desktop | 14,156 | issue_to_patch | when boost window is open, than system style is switched from light to dark, window stays in light style
### Preliminary Checks
- [x] I have read and understood the important section above.
- [x] I have searched existing issues and avoided creating duplicates.
- [x] I am not filing an enhancement request.
- [x] I hav... | gh-14020: dynamically switch boosts window theme | fixes: #14020 | 8b0aab15b5d279b30daf1eb974e8fe09ec8289f6 | ca8a3928e00bee5a3ba81114ff271f27b142b0a7 | diff --git a/src/zen/boosts/ZenBoostsEditor.mjs b/src/zen/boosts/ZenBoostsEditor.mjs
index b120ef25e58..f67ad0fa336 100644
--- a/src/zen/boosts/ZenBoostsEditor.mjs
+++ b/src/zen/boosts/ZenBoostsEditor.mjs
@@ -18,6 +18,7 @@ export class nsZenBoostEditor {
"zap-state-update",
"selector-picker-state-update",
... | [
"src/zen/boosts/ZenBoostsEditor.mjs",
"src/zen/spaces/ZenGradientGenerator.mjs"
] | [] | true | |
zen-browser/desktop | 14,147 | issue_to_patch | Size not work in Boost when set Size only at first time.
### Preliminary Checks
- [x] I have read and understood the important section above.
- [x] I have searched existing issues and avoided creating duplicates.
- [x] I am not filing an enhancement request.
- [x] I have checked that this issue cannot be reproduced o... | gh-14145: fix boosts size and case overrides not working on first time press | Fixes: https://github.com/zen-browser/desktop/issues/14145 | 6bc560c8766a64197695c54a9789acee92c76f4e | 2f544afaf1b8a7b81eca4642efdcfced72edbec9 | diff --git a/src/zen/boosts/ZenBoostsEditor.mjs b/src/zen/boosts/ZenBoostsEditor.mjs
index b74964fca48..b120ef25e58 100644
--- a/src/zen/boosts/ZenBoostsEditor.mjs
+++ b/src/zen/boosts/ZenBoostsEditor.mjs
@@ -630,6 +630,7 @@ ${cssSelector} {
this.currentBoostData.textCaseOverride = "uppercase";
}
+ thi... | [
"src/zen/boosts/ZenBoostsEditor.mjs"
] | [] | true | |
zen-browser/desktop | 14,136 | issue_to_patch | Intermitent build errors
```
error[E0282]: type annotations needed
--> /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-runtime-1.7.4/src/auth/sigv4.rs:278:22
|
278 | .send(Box::new(SigV4MessageSigner::new(
| ^^^^ cannot infer type of the type p... | gh-14135: Fixed intermitent build errors for macos | 7bf236fcf417aeaa4f65e42b48d063a27cabf2c6 | 842a6734ca3336f932a43ca8879734a90ecc546e | diff --git a/.github/workflows/macos-universal-release-build.yml b/.github/workflows/macos-universal-release-build.yml
index b4fea39a012..762a92a6d8b 100644
--- a/.github/workflows/macos-universal-release-build.yml
+++ b/.github/workflows/macos-universal-release-build.yml
@@ -60,7 +60,7 @@ jobs:
brew insta... | [
".github/workflows/macos-universal-release-build.yml"
] | [] | true | ||
zen-browser/desktop | 14,128 | issue_to_patch | Routed tabs keep the cookies of the previous Workspaces
### Preliminary Checks
- [x] I have read and understood the important section above.
- [x] I have searched existing issues and avoided creating duplicates.
- [x] I am not filing an enhancement request.
- [x] I have checked that this issue cannot be reproduced on... | gh-14117: Fixed incorrect tab routing container checks | 4797717353c4c220f303ca8492cf3d282f2268b9 | 8f92c59fdbc10306b61a34175d78132821cbcd16 | diff --git a/src/browser/components/tabbrowser/content/tabbrowser-js.patch b/src/browser/components/tabbrowser/content/tabbrowser-js.patch
index 0edeeb8d73e..7c8a6bf531d 100644
--- a/src/browser/components/tabbrowser/content/tabbrowser-js.patch
+++ b/src/browser/components/tabbrowser/content/tabbrowser-js.patch
@@ -1,5... | [
"src/browser/components/tabbrowser/content/tabbrowser-js.patch",
"src/zen/spaces/ZenSpaceManager.mjs"
] | [
{
"comment": "The inline comment has trailing whitespace and awkward punctuation/capitalization (e.g., \"Just in case, Let's...\") which makes it harder to read and may violate linting/formatting rules. Consider rewriting it as a single, grammatically correct sentence.",
"path": "src/zen/spaces/ZenSpaceMana... | true | ||
zen-browser/desktop | 14,128 | comment_to_fix | gh-14117: Fixed incorrect tab routing container checks | The inline comment has trailing whitespace and awkward punctuation/capitalization (e.g., "Just in case, Let's...") which makes it harder to read and may violate linting/formatting rules. Consider rewriting it as a single, grammatically correct sentence. | 4797717353c4c220f303ca8492cf3d282f2268b9 | 8f92c59fdbc10306b61a34175d78132821cbcd16 | diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs
index 5f2f403f1ee..928d634dcba 100644
--- a/src/zen/spaces/ZenSpaceManager.mjs
+++ b/src/zen/spaces/ZenSpaceManager.mjs
@@ -2290,6 +2290,11 @@ class nsZenWorkspaces {
}
onBeforeTabSelect(aTab) {
+ if (this.#inChangingWorkspa... | [
"src/zen/spaces/ZenSpaceManager.mjs"
] | [
{
"comment": "The inline comment has trailing whitespace and awkward punctuation/capitalization (e.g., \"Just in case, Let's...\") which makes it harder to read and may violate linting/formatting rules. Consider rewriting it as a single, grammatically correct sentence.",
"path": "src/zen/spaces/ZenSpaceMana... | true | ||
zen-browser/desktop | 14,124 | issue_to_patch | [Space Routing Settings] The browser freezes when I look up a domain on google.com that is routed to a different workspace
### Preliminary Checks
- [x] I have read and understood the important section above.
- [x] I have searched existing issues and avoided creating duplicates.
- [x] I am not filing an enhancement re... | gh-14110: Fixed tab freezing when switching spaces | 88b294364f7b478bd595942835d97c23efee1884 | 7804021f094892dc2e189b0cef06279043580203 | diff --git a/src/browser/components/tabbrowser/content/tabbrowser-js.patch b/src/browser/components/tabbrowser/content/tabbrowser-js.patch
index 90ad2574e1a..0edeeb8d73e 100644
--- a/src/browser/components/tabbrowser/content/tabbrowser-js.patch
+++ b/src/browser/components/tabbrowser/content/tabbrowser-js.patch
@@ -1,5... | [
"src/browser/components/tabbrowser/content/tabbrowser-js.patch",
"src/zen/spaces/ZenSpaceManager.mjs",
"src/zen/urlbar/ZenSiteDataPanel.sys.mjs",
"surfer.json"
] | [
{
"comment": "`onBeforeTabSelect` now blocks the tab switch and schedules `gBrowser.selectedTab = aTab` later. As written, it (1) assumes `changeWorkspaceWithID` always returns a Promise (tests/mocks override it with sync fns), (2) uses `.catch(...).then(...)` so selection can still be attempted after a failure... | true | ||
zen-browser/desktop | 14,124 | comment_to_fix | gh-14110: Fixed tab freezing when switching spaces | `onBeforeTabSelect` now blocks the tab switch and schedules `gBrowser.selectedTab = aTab` later. As written, it (1) assumes `changeWorkspaceWithID` always returns a Promise (tests/mocks override it with sync fns), (2) uses `.catch(...).then(...)` so selection can still be attempted after a failure, and (3) can get stuc... | 88b294364f7b478bd595942835d97c23efee1884 | 7804021f094892dc2e189b0cef06279043580203 | diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs
index cfb60c004ca..5f2f403f1ee 100644
--- a/src/zen/spaces/ZenSpaceManager.mjs
+++ b/src/zen/spaces/ZenSpaceManager.mjs
@@ -2297,8 +2297,14 @@ class nsZenWorkspaces {
!aTab.hasAttribute("zen-empty-tab") &&
!aTab.hasAttrib... | [
"src/zen/spaces/ZenSpaceManager.mjs"
] | [
{
"comment": "`onBeforeTabSelect` now blocks the tab switch and schedules `gBrowser.selectedTab = aTab` later. As written, it (1) assumes `changeWorkspaceWithID` always returns a Promise (tests/mocks override it with sync fns), (2) uses `.catch(...).then(...)` so selection can still be attempted after a failure... | true | ||
zen-browser/desktop | 14,102 | issue_to_patch | Extension-opened container tabs no longer switch to the container's assigned space (regression in 1.20.2b, PR #14001)
Disclaimer: I've researched the issue and submitted this ticket with Claude's help. I've verified all of its claims and the issue draft following:
### Preliminary Checks
- [x] I have read and underst... | gh-14100: restore workspace routing for extension-opened tabs with explicit containers | The previous fix for the Grammarly sign-in issue (which bypassed container coercion for tabs opened by WebExtensions) broke extensions that explicitly target specific containers (such as 'Open external links in a container'). Those tabs opened in the active workspace instead of the workspace associated with the contain... | ccefb761689bef5b2ed432e5032447a50d24487a | 1eb5e49f24973d340835c47f1fa0aa140ca2ae3d | diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs
index caeee405fc0..cfb60c004ca 100644
--- a/src/zen/spaces/ZenSpaceManager.mjs
+++ b/src/zen/spaces/ZenSpaceManager.mjs
@@ -3005,7 +3005,8 @@ class nsZenWorkspaces {
if (
triggeringPrincipal &&
- triggeringPrincipal.... | [
"src/zen/spaces/ZenSpaceManager.mjs"
] | [] | true | |
zen-browser/desktop | 14,098 | issue_to_patch | boosts code editor force theming issue
### Preliminary Checks
- [x] I have read and understood the important section above.
- [x] I have searched existing issues and avoided creating duplicates.
- [x] I am not filing an enhancement request.
- [x] I have checked that this issue cannot be reproduced on Mozilla Firefox.... | gh-14099: fix boosts code editor force theming issue | Fixes #14099 | ccefb761689bef5b2ed432e5032447a50d24487a | aabdf574fa797fca712769b9f65d7294f15b1099 | diff --git a/src/zen/boosts/ZenBoostsEditor.mjs b/src/zen/boosts/ZenBoostsEditor.mjs
index 2b224690c82..b74964fca48 100644
--- a/src/zen/boosts/ZenBoostsEditor.mjs
+++ b/src/zen/boosts/ZenBoostsEditor.mjs
@@ -59,6 +59,18 @@ export class nsZenBoostEditor {
this.loadBoost(domain);
}
+ /**
+ * Returns the Zen... | [
"src/zen/boosts/ZenBoostsEditor.mjs"
] | [
{
"comment": "`editorEl.className = \"theme-\" + this.isDarkMode ? \"dark\" : \"light\";` is parsed as `( \"theme-\" + this.isDarkMode ) ? \"dark\" : \"light\"` due to operator precedence. Since the left side is always a non-empty string, this always sets the class to just \"dark\" (never \"theme-dark\"/\"theme... | true | |
zen-browser/desktop | 14,098 | comment_to_fix | gh-14099: fix boosts code editor force theming issue | `editorEl.className = "theme-" + this.isDarkMode ? "dark" : "light";` is parsed as `( "theme-" + this.isDarkMode ) ? "dark" : "light"` due to operator precedence. Since the left side is always a non-empty string, this always sets the class to just "dark" (never "theme-dark"/"theme-light"), so the editor theme won’t swi... | ccefb761689bef5b2ed432e5032447a50d24487a | aabdf574fa797fca712769b9f65d7294f15b1099 | diff --git a/src/zen/boosts/ZenBoostsEditor.mjs b/src/zen/boosts/ZenBoostsEditor.mjs
index 2b224690c82..b74964fca48 100644
--- a/src/zen/boosts/ZenBoostsEditor.mjs
+++ b/src/zen/boosts/ZenBoostsEditor.mjs
@@ -59,6 +59,18 @@ export class nsZenBoostEditor {
this.loadBoost(domain);
}
+ /**
+ * Returns the Zen... | [
"src/zen/boosts/ZenBoostsEditor.mjs"
] | [
{
"comment": "`editorEl.className = \"theme-\" + this.isDarkMode ? \"dark\" : \"light\";` is parsed as `( \"theme-\" + this.isDarkMode ) ? \"dark\" : \"light\"` due to operator precedence. Since the left side is always a non-empty string, this always sets the class to just \"dark\" (never \"theme-dark\"/\"theme... | true | ||
zen-browser/desktop | 14,001 | issue_to_patch | no-bug: bypass workspace container coercion for extension-opened tabs (gh-14001) | When a WebExtension (e.g. Grammarly) opens a tab via browser.tabs.create() without specifying a cookieStoreId, it expects the tab to open in the default (No Container) context. Zen's workspace container logic was overriding this, forcing the tab into the active workspace's container. This broke extension sign-in flows ... | bf365f804355a7db4ee0369289bc48530626c644 | 32ebd08ba79c8983824cca8db2c144d1af3fe0ed | diff --git a/configs/windows/mozconfig b/configs/windows/mozconfig
index 065ed1291d1..83f4283a47d 100644
--- a/configs/windows/mozconfig
+++ b/configs/windows/mozconfig
@@ -9,6 +9,12 @@ if test "$ZEN_CROSS_COMPILING"; then
export WINE="$(echo ~)/win-cross/wine/bin/wine"
export WINEDEBUG=-all
+ # Force Wine to ... | [
"configs/windows/mozconfig",
"src/browser/components/tabbrowser/content/tabbrowser-js.patch",
"src/zen/spaces/ZenSpaceManager.mjs"
] | [] | true | ||
zen-browser/desktop | 14,091 | issue_to_patch | size override doesnt reset zoom to default after disabling it
### Preliminary Checks
- [x] I have read and understood the important section above.
- [x] I have searched existing issues and avoided creating duplicates.
- [x] I am not filing an enhancement request.
- [x] I have checked that this issue cannot be reprodu... | gh-13982: fix boosts size override not resetting zoom to default after disabling it | Fixes #13982
About: `const linkedBrowser = this.openerWindow.gBrowser.selectedTab.linkedBrowser;`
This is how its being used in every other place, so I kept it like this. | bd3adba05edc4c8c2e0b9ff594f2b19de9aac796 | c0877391da7a4cdbea7963bcd358e5e17e437eb0 | diff --git a/src/zen/boosts/ZenBoostsEditor.mjs b/src/zen/boosts/ZenBoostsEditor.mjs
index 7254ac3fdad..2b224690c82 100644
--- a/src/zen/boosts/ZenBoostsEditor.mjs
+++ b/src/zen/boosts/ZenBoostsEditor.mjs
@@ -638,7 +638,7 @@ ${cssSelector} {
/**
* Handles the size toggle button press, cycling through size overri... | [
"src/zen/boosts/ZenBoostsEditor.mjs",
"src/zen/boosts/actors/ZenBoostsChild.sys.mjs"
] | [
{
"comment": "`await actor.sendQuery(...)` can throw/reject (e.g. tab closed/crashed or actor unavailable). Because this is inside the click handler, a rejection would prevent `updateSizeButtonVisuals()`/`updateCurrentBoost()` from running and can surface as an unhandled promise rejection. Consider making this ... | true | |
zen-browser/desktop | 14,091 | comment_to_fix | gh-13982: fix boosts size override not resetting zoom to default after disabling it | `await actor.sendQuery(...)` can throw/reject (e.g. tab closed/crashed or actor unavailable). Because this is inside the click handler, a rejection would prevent `updateSizeButtonVisuals()`/`updateCurrentBoost()` from running and can surface as an unhandled promise rejection. Consider making this fire-and-forget with a... | bd3adba05edc4c8c2e0b9ff594f2b19de9aac796 | c0877391da7a4cdbea7963bcd358e5e17e437eb0 | diff --git a/src/zen/boosts/ZenBoostsEditor.mjs b/src/zen/boosts/ZenBoostsEditor.mjs
index 7254ac3fdad..2b224690c82 100644
--- a/src/zen/boosts/ZenBoostsEditor.mjs
+++ b/src/zen/boosts/ZenBoostsEditor.mjs
@@ -638,7 +638,7 @@ ${cssSelector} {
/**
* Handles the size toggle button press, cycling through size overri... | [
"src/zen/boosts/ZenBoostsEditor.mjs"
] | [
{
"comment": "`await actor.sendQuery(...)` can throw/reject (e.g. tab closed/crashed or actor unavailable). Because this is inside the click handler, a rejection would prevent `updateSizeButtonVisuals()`/`updateCurrentBoost()` from running and can surface as an unhandled promise rejection. Consider making this ... | true | ||
zen-browser/desktop | 14,077 | issue_to_patch | Space icons overflow inaccessible unless sidebar is made wider than necessary
### Preliminary Checks
- [x] I have read and understood the important section above.
- [x] I have searched existing issues and avoided creating duplicates.
- [x] I am not filing an enhancement request.
- [x] I have checked that this issue c... | gh-13747: Fixed space icons overflow being inaccessible | Fixes #13747
## The root cause
It was the `justify-content: center`.
I mean, It worked fine, but whenever the icons overflowed the flexbox was pushing the leftmost items into a negative position. Since the `scrollLeft` bottoms out at 0, those icons get trapped, you simply couldn't reach any icon with a position ... | 11a977e5334393e4f77dce6b732821cb92ff5275 | c7f5634bd1c899b65209d06db4deefab0b8f2de5 | diff --git a/src/zen/spaces/ZenSpaceIcons.mjs b/src/zen/spaces/ZenSpaceIcons.mjs
index a15bcc083eb..b8bfb67440e 100644
--- a/src/zen/spaces/ZenSpaceIcons.mjs
+++ b/src/zen/spaces/ZenSpaceIcons.mjs
@@ -15,12 +15,12 @@ class nsZenWorkspaceIcons extends MozXULElement {
this.initDragAndDrop();
this.addEventList... | [
"src/zen/spaces/ZenSpaceIcons.mjs",
"src/zen/spaces/zen-workspaces.css"
] | [
{
"comment": "What does this change exactly?",
"path": "src/zen/spaces/zen-workspaces.css",
"hunk": "@@ -41,6 +41,7 @@\n fill-opacity: 0.6;\n -moz-context-properties: fill-opacity, fill;\n fill: currentColor;\n+ scroll-margin: 0 20px;",
"resolving_sha": "c7f5634bd1c899b65209d06db4deef... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.