| { |
| "number": 10062, |
| "title": "fix: Update method call to use router_store for merchant connector account updates", |
| "description": "## Type of Change\r\n<!-- Put an `x` in the boxes that apply -->\r\n\r\n- [x] Bugfix\r\n- [ ] New feature\r\n- [ ] Enhancement\r\n- [ ] Refactoring\r\n- [ ] Dependency updates\r\n- [ ] Documentation\r\n- [ ] CI/CD\r\n\r\n## Description\r\n<!-- Describe your changes in detail -->\r\nThe v2 feature-gated implementation of `update_merchant_connector_account` has a recursive call to itself instead of delegating to `router_store`, causing an infinite loop and stack overflow when updating merchant connector accounts.\r\n\r\n### Additional Changes\r\n\r\n- [ ] This PR modifies the API contract\r\n- [ ] This PR modifies the database schema\r\n- [ ] This PR modifies application configuration/environment variables\r\n\r\n<!--\r\nProvide links to the files with corresponding changes.\r\n\r\nFollowing are the paths where you can find config files:\r\n1. `config`\r\n2. `crates/router/src/configs`\r\n3. `loadtest/config`\r\n-->\r\n\r\n\r\n## Motivation and Context\r\n<!--\r\nWhy is this change required? What problem does it solve?\r\nIf it fixes an open issue, please link to the issue here.\r\n\r\nIf you don't have an issue, we'd recommend starting with one first so the PR\r\ncan focus on the implementation (unless it is an obvious bug or documentation fix\r\nthat will have little conversation).\r\n-->\r\ncloses #10060 \r\n\r\n## How did you test it?\r\n<!--\r\nDid you write an integration/unit/API test to verify the code changes?\r\nOr did you test this change manually (provide relevant screenshots)?\r\n-->\r\nRequest:\r\n```\r\ncurl --location --request PUT 'http://localhost:8080/v2/connector-accounts/mca_eVd8ctUOCoDMEN1VbwXf' \\\r\n--header 'Content-Type: application/json' \\\r\n--header 'Accept: application/json' \\\r\n--header 'Authorization: admin-api-key=test_admin' \\\r\n--header 'x-merchant-id: cloth_seller_15VARslGd45UVxEPFepA' \\\r\n--header 'api-key: test_admin' \\\r\n--data '{\r\n \"connector_type\": \"payment_processor\",\r\n \"merchant_id\": \"cloth_seller_15VARslGd45UVxEPFepA\"\r\n}'\r\n```\r\nResponse:\r\n```\r\n{\r\n \"connector_type\": \"payment_processor\",\r\n \"connector_name\": \"stripe\",\r\n \"connector_label\": \"stripe_business2\",\r\n \"id\": \"mca_eVd8ctUOCoDMEN1VbwXf\",\r\n \"profile_id\": \"pro_fMujwybUlgBE9IXBqrMe\",\r\n \"connector_account_details\": {\r\n \"auth_type\": \"HeaderKey\",\r\n \"api_key\": \"sk*******************************************************************************************************0r\"\r\n },\r\n \"payment_methods_enabled\": null,\r\n \"connector_webhook_details\": {\r\n \"merchant_secret\": \"\",\r\n \"additional_secret\": null\r\n },\r\n \"metadata\": null,\r\n \"disabled\": false,\r\n \"frm_configs\": null,\r\n \"applepay_verified_domains\": null,\r\n \"pm_auth_config\": null,\r\n \"status\": \"active\",\r\n \"additional_merchant_data\": null,\r\n \"connector_wallets_details\": null,\r\n \"feature_metadata\": null\r\n}\r\n```\r\n\r\n## Checklist\r\n<!-- Put an `x` in the boxes that apply -->\r\n\r\n- [x] I formatted the code `cargo +nightly fmt --all`\r\n- [x] I addressed lints thrown by `cargo clippy`\r\n- [x] I reviewed the submitted code\r\n- [ ] I added unit tests for my changes where possible\r\n", |
| "author": "ayush22667", |
| "created_at": "2025-10-30T09:55:45+00:00", |
| "merged_at": "2025-11-04T09:12:46+00:00", |
| "base_branch": "main", |
| "labels": [ |
| "A-framework", |
| "C-bug", |
| "T-Core" |
| ], |
| "url": "https://github.com/juspay/hyperswitch/pull/10062", |
| "commits": [ |
| { |
| "sha": "00a2bb49bb8edf9d78cd42433df6c217b9a53fbd", |
| "message": "fix: Update method call to use router_store for merchant connector account updates", |
| "author": "Ayush", |
| "date": "2025-10-30T09:46:57+00:00", |
| "url": "https://github.com/juspay/hyperswitch/commit/00a2bb49bb8edf9d78cd42433df6c217b9a53fbd" |
| } |
| ] |
| } |
