File size: 13,260 Bytes
ff8b94c
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
"""Opt-in live tests for the OpenCode CLI backend.

These tests make real model calls through the user's OpenCode installation,
account, and configuration. They support Windows and POSIX, but are skipped
unless ``SKILLOPT_TEST_REAL_OPENCODE=1`` is set. An opted-in run also requires
an explicit model in ``SKILLOPT_SLEEP_OPENCODE_MODEL`` so model selection is
explicit. They may incur provider charges and create entries
in the user's OpenCode session history. The tool-aware replay test also runs one
generated JavaScript tool with a fixed result inside an isolated temporary
project.
"""

from __future__ import annotations

import json
import os
import secrets
import shutil
import subprocess
import sys
import tempfile
from pathlib import Path

import pytest

from skillopt_sleep.backend import _NO_WINDOW, OpenCodeCliBackend, resolve_opencode_path
from skillopt_sleep.config import DEFAULTS, SleepConfig
from skillopt_sleep.cycle import run_sleep_cycle
from skillopt_sleep.evidence import read_events
from skillopt_sleep.replay import replay_one
from skillopt_sleep.types import TaskRecord

_LIVE_ENABLED = os.environ.get("SKILLOPT_TEST_REAL_OPENCODE", "").strip() == "1"
_CYCLE_MARKER = "SKILLOPT_OPENCODE_CYCLE_OK_9A6D"

pytestmark = pytest.mark.skipif(
    not _LIVE_ENABLED,
    reason="set SKILLOPT_TEST_REAL_OPENCODE=1 to make real OpenCode model calls",
)


def _live_settings() -> tuple[str, str]:
    """Return the model and executable required by the opted-in tests."""
    model = os.environ.get("SKILLOPT_SLEEP_OPENCODE_MODEL", "").strip()
    if not model:
        pytest.fail(
            "SKILLOPT_SLEEP_OPENCODE_MODEL is required for opted-in OpenCode live tests",
            pytrace=False,
        )

    opencode_path = resolve_opencode_path()
    if shutil.which(opencode_path) is None:
        pytest.fail(
            "OpenCode CLI was not found for an opted-in live test",
            pytrace=False,
        )
    return model, opencode_path


def _add_mcp_canary(monkeypatch, tmp_path: Path) -> tuple[Path, str]:
    """Add a local MCP that leaves a marker if OpenCode starts it."""
    mcp_name = f"skillopt-live-canary-{secrets.token_hex(8)}"
    marker = tmp_path / "mcp-started.txt"
    script = tmp_path / "mcp-canary.py"
    script.write_text(
        f"from pathlib import Path\nPath({str(marker)!r}).write_text('started', encoding='utf-8')\n",
        encoding="utf-8",
    )
    config = {
        "$schema": "https://opencode.ai/config.json",
        "mcp": {
            mcp_name: {
                "type": "local",
                "command": [sys.executable, str(script)],
            }
        },
    }

    if not os.environ.get("OPENCODE_CONFIG"):
        config_path = tmp_path / "mcp-canary-opencode.json"
        config_path.write_text(json.dumps(config), encoding="utf-8")
        monkeypatch.setenv("OPENCODE_CONFIG", str(config_path))
        return marker, mcp_name

    if not os.environ.get("OPENCODE_CONFIG_DIR"):
        config_dir = tmp_path / "mcp-canary-config"
        config_dir.mkdir()
        (config_dir / "opencode.json").write_text(json.dumps(config), encoding="utf-8")
        monkeypatch.setenv("OPENCODE_CONFIG_DIR", str(config_dir))
        return marker, mcp_name

    pytest.fail(
        "the live MCP canary needs either OPENCODE_CONFIG or OPENCODE_CONFIG_DIR to be unused",
        pytrace=False,
    )


def _require_mcp_canary_configured(opencode_path: str, mcp_name: str, tmp_path: Path) -> None:
    """Check the synthetic MCP is visible without starting MCP services."""
    env = os.environ.copy()
    env["OPENCODE_DISABLE_PROJECT_CONFIG"] = "1"
    env["OPENCODE_PURE"] = "1"
    env["PWD"] = str(tmp_path)
    env.pop("OLDPWD", None)
    try:
        proc = subprocess.run(
            [opencode_path, "debug", "config", "--pure"],
            capture_output=True,
            creationflags=_NO_WINDOW,
            text=True,
            encoding="utf-8",
            errors="replace",
            timeout=180,
            cwd=tmp_path,
            env=env,
        )
        resolved = json.loads(proc.stdout or "") if proc.returncode == 0 else None
    except (OSError, subprocess.SubprocessError, json.JSONDecodeError, RecursionError):
        resolved = None
    mcp = resolved.get("mcp") if isinstance(resolved, dict) else None
    entry = mcp.get(mcp_name) if isinstance(mcp, dict) else None
    if not isinstance(entry, dict) or entry.get("enabled") is False:
        pytest.fail("the real OpenCode config did not include the MCP canary", pytrace=False)


def _add_ancestor_tool_canary(monkeypatch, tmp_path: Path) -> tuple[Path, Path, list[Path]]:
    """Place a load-time canary in an ancestor directory outside the replay Git boundary."""
    outer = tmp_path / "tool-project-parent"
    tool_dir = outer / ".opencode" / "tools"
    tool_dir.mkdir(parents=True)
    marker = tmp_path / "ancestor-tool-loaded.txt"
    (tool_dir / "ancestor_canary.js").write_text(
        'import { writeFileSync } from "node:fs";\n'
        f"writeFileSync({json.dumps(str(marker))}, 'loaded', 'utf8');\n"
        "export default {\n"
        "  description: 'Ancestor configuration canary',\n"
        "  args: {},\n"
        "  async execute() { return 'ancestor canary'; },\n"
        "};\n",
        encoding="utf-8",
    )

    replay_workspaces: list[Path] = []

    def make_replay_workspace(prefix: str, _error: str) -> tempfile.TemporaryDirectory:
        workspace = tempfile.TemporaryDirectory(
            prefix=prefix,
            dir=outer,
            ignore_cleanup_errors=True,
        )
        replay_workspaces.append(Path(workspace.name))
        return workspace

    monkeypatch.setattr(
        "skillopt_sleep.backend._opencode_temporary_workspace",
        make_replay_workspace,
    )
    return marker, outer, replay_workspaces


def test_real_opencode_tool_replay(monkeypatch, tmp_path):
    """Exercise one synthetic tool call through the real OpenCode CLI and verify local scoring."""
    model, opencode_path = _live_settings()
    monkeypatch.setenv("SKILLOPT_SLEEP_PROMPTS_PATH", str(tmp_path / "no-prompt-overrides.json"))
    mcp_marker, mcp_name = _add_mcp_canary(monkeypatch, tmp_path)
    _require_mcp_canary_configured(opencode_path, mcp_name, tmp_path)
    ancestor_tool_marker, ancestor_outer, replay_workspaces = _add_ancestor_tool_canary(
        monkeypatch,
        tmp_path,
    )

    backend = OpenCodeCliBackend(
        model=model,
        opencode_path=opencode_path,
        tool_replay=True,
    )
    task = TaskRecord(
        id="opencode-live-tool",
        project=str(tmp_path),
        intent="Call the controlled search stand-in, then give a short final answer.",
        reference_kind="rule",
        judge={
            "kind": "rule",
            "checks": [{"op": "tool_called", "arg": "search"}],
        },
    )

    result = replay_one(
        backend,
        task,
        "Before answering, you MUST call the search tool.",
        "",
    )

    if len(replay_workspaces) != 1:
        pytest.fail("the real OpenCode tool replay did not create one workspace", pytrace=False)
    replay_workspace = replay_workspaces[0]
    try:
        replay_workspace.resolve().relative_to(ancestor_outer.resolve())
    except (OSError, ValueError):
        pytest.fail("the real OpenCode tool replay escaped its canary boundary", pytrace=False)
    if replay_workspace.exists():
        pytest.fail("the real OpenCode tool replay did not clean up its workspace", pytrace=False)
    if mcp_marker.exists():
        pytest.fail("the real OpenCode tool call started a configured MCP server", pytrace=False)
    if ancestor_tool_marker.exists():
        pytest.fail("the real OpenCode tool call loaded ancestor project tools", pytrace=False)
    if backend.last_call_error:
        pytest.fail("the real OpenCode tool-aware replay failed", pytrace=False)
    if not result.response or result.hard != 1.0 or result.tools_called != ["search"]:
        pytest.fail("the real OpenCode tool invocation was not verified", pytrace=False)


def test_real_opencode_cycle_smoke(monkeypatch, tmp_path):
    """Run one seeded sleep cycle through a real, factory-built OpenCode backend."""
    model, opencode_path = _live_settings()
    project = tmp_path / "project"
    state_dir = tmp_path / "state"
    claude_home = tmp_path / "claude-home"
    project.mkdir()
    monkeypatch.setenv("SKILLOPT_SLEEP_PROMPTS_PATH", str(tmp_path / "no-prompt-overrides.json"))
    monkeypatch.setenv("SKILLOPT_SLEEP_WORKERS", "1")
    mcp_marker, mcp_name = _add_mcp_canary(monkeypatch, tmp_path)
    _require_mcp_canary_configured(opencode_path, mcp_name, tmp_path)

    cfg = SleepConfig(
        data={
            **DEFAULTS,
            "backend": "opencode",
            "model": model,
            "opencode_path": opencode_path,
            "projects": "invoked",
            "invoked_project": str(project),
            "state_dir": str(state_dir),
            "claude_home": str(claude_home),
            "gate_mode": "on",
            "evolve_skill": False,
            "evolve_memory": False,
            "llm_mine": False,
            "dream_rollouts": 1,
            "dream_factor": 0,
            "recall_k": 0,
            "multi_skill_report": False,
            "auto_adopt": False,
            "evidence_log": True,
            "redact_secrets": True,
            "progress": False,
        }
    )
    task = TaskRecord(
        id="opencode-live-cycle",
        project=str(project),
        intent=f"Reply with exactly this text and nothing else: {_CYCLE_MARKER}",
        reference_kind="exact",
        reference=_CYCLE_MARKER,
        split="val",
    )

    outcome = run_sleep_cycle(cfg, seed_tasks=[task])

    if mcp_marker.exists():
        pytest.fail("the real OpenCode cycle started a configured MCP server", pytrace=False)
    staging_dir = Path(outcome.staging_dir)
    try:
        staging_dir.resolve().relative_to(project.resolve())
    except (OSError, ValueError):
        pytest.fail("the live cycle did not stage inside its temporary project", pytrace=False)
    artifact_paths = {name: staging_dir / name for name in ("report.json", "diagnostics.json", "evidence.jsonl")}
    if not all(path.is_file() for path in artifact_paths.values()):
        pytest.fail("the live cycle did not write its expected staging artifacts", pytrace=False)

    try:
        with artifact_paths["diagnostics.json"].open(encoding="utf-8") as handle:
            diagnostics = json.load(handle)
    except (OSError, json.JSONDecodeError):
        pytest.fail("the live cycle wrote unreadable diagnostics", pytrace=False)
    if not isinstance(diagnostics, dict):
        pytest.fail("the live cycle wrote invalid diagnostics", pytrace=False)
    holdout_detail = diagnostics.get("holdout_detail")
    holdout_entry = (
        holdout_detail[0]
        if isinstance(holdout_detail, list) and len(holdout_detail) == 1 and isinstance(holdout_detail[0], dict)
        else {}
    )
    response_len = holdout_entry.get("response_len", 0)
    if (
        diagnostics.get("backend") != "opencode"
        or diagnostics.get("call_error")
        or not holdout_entry
        or holdout_entry.get("hard") != 1.0
        or not isinstance(response_len, (int, float))
        or response_len <= 0
    ):
        pytest.fail("the live cycle diagnostics did not record a successful replay", pytrace=False)

    events = read_events(str(artifact_paths["evidence.jsonl"]))
    model_calls = [
        event
        for event in events
        if event.get("stage") == "replay" and event.get("event") == "model_call" and not event.get("cache_hit")
    ]
    replay_results = [
        event
        for event in events
        if event.get("stage") == "replay" and event.get("event") == "result" and event.get("task_id") == task.id
    ]
    cycle_ends = [event for event in events if event.get("stage") == "cycle" and event.get("event") == "end"]

    # Keep any provider text in the temporary evidence file and out of pytest output.
    if len(model_calls) != 1 or model_calls[0].get("kind") != "attempt":
        pytest.fail(
            "the live cycle did not make exactly one uncached OpenCode model call",
            pytrace=False,
        )
    if _CYCLE_MARKER not in str(model_calls[0].get("response", "")):
        pytest.fail("the live cycle did not complete one successful OpenCode attempt", pytrace=False)
    replay_phases = {event.get("phase") for event in replay_results}
    if (
        len(replay_results) != 3
        or replay_phases != {"baseline_val", "train", "final_val"}
        or any(event.get("hard") != 1.0 for event in replay_results)
    ):
        pytest.fail("the live cycle did not score its seeded replay successfully", pytrace=False)
    if len(cycle_ends) != 1 or cycle_ends[0].get("outcome") != "completed":
        pytest.fail("the live cycle did not reach completion", pytrace=False)
    if outcome.report.n_tasks != 1 or outcome.report.n_replayed != 1:
        pytest.fail("the live cycle report did not record its seeded replay", pytrace=False)
    if outcome.adopted or outcome.adopted_paths:
        pytest.fail("the live cycle did not preserve review-before-adopt behavior", pytrace=False)