File size: 13,445 Bytes
3fbbaab 21ff762 3fbbaab 21ff762 3fbbaab e965652 3fbbaab 21ff762 3fbbaab 21ff762 3fbbaab e965652 3fbbaab | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 | """
test_config.py -- Tests for the ctx_config.Config system.
Covers:
- ctx_config.Config: attribute types, path expansion, reload, deep merge,
all_skill_dirs()
"""
import sys
import tempfile
from pathlib import Path
from typing import Any
import pytest
# ---------------------------------------------------------------------------
# sys.path is already patched by conftest.py, but guard here too so the module
# can be run in isolation (e.g. `python -m pytest tests/test_config.py`).
# ---------------------------------------------------------------------------
_PROJECT_ROOT = Path(__file__).resolve().parent.parent
if str(_PROJECT_ROOT) not in sys.path:
sys.path.insert(0, str(_PROJECT_ROOT))
import ctx_config # noqa: E402
from ctx_config import Config, _deep_merge # noqa: E402
# ===========================================================================
# Helper
# ===========================================================================
def _minimal_raw(overrides: dict[str, Any] | None = None) -> dict[str, Any]:
"""Return a minimal raw-config dict sufficient to construct a Config."""
raw: dict[str, Any] = {
"paths": {
"claude_dir": "~/.claude",
"wiki_dir": "~/.claude/skill-wiki",
"skills_dir": "~/.claude/skills",
"agents_dir": "~/.claude/agents",
"skill_manifest": "~/.claude/skill-manifest.json",
"intent_log": "~/.claude/intent-log.jsonl",
"pending_skills": "~/.claude/pending-skills.json",
"skill_registry": "~/.claude/skill-registry.json",
"stack_profile_tmp": "~/.claude/skill-stack-profile.json",
"catalog": "~/.claude/skill-wiki/catalog.md",
},
"resolver": {},
"context_monitor": {},
"usage_tracker": {},
"skill_transformer": {},
"skill_router": {},
"extra_skill_dirs": [],
"babysitter": {},
}
if overrides:
_deep_merge(raw, overrides)
return raw
# ===========================================================================
# Config tests
# ===========================================================================
class TestConfigLoadsDefaults:
"""test_config_loads_defaults -- expected attributes exist with correct defaults."""
def test_has_wiki_dir(self) -> None:
cfg = Config(_minimal_raw())
assert hasattr(cfg, "wiki_dir")
def test_has_skills_dir(self) -> None:
cfg = Config(_minimal_raw())
assert hasattr(cfg, "skills_dir")
def test_line_threshold_default(self) -> None:
cfg = Config(_minimal_raw())
assert cfg.line_threshold == 180
def test_line_threshold_accepts_user_value(self) -> None:
cfg = Config(_minimal_raw({"skill_transformer": {"line_threshold": 240}}))
assert cfg.line_threshold == 240
@pytest.mark.parametrize("value", [0, -1, "not-an-int", "240", True, False, 1.5])
def test_line_threshold_rejects_invalid_values(self, value: object) -> None:
with pytest.raises(ValueError, match="skill_transformer.line_threshold"):
Config(_minimal_raw({"skill_transformer": {"line_threshold": value}}))
def test_max_stage_lines_default(self) -> None:
cfg = Config(_minimal_raw())
assert cfg.max_stage_lines == 40
def test_max_skills_default(self) -> None:
cfg = Config(_minimal_raw())
assert cfg.max_skills == 15
def test_stage_count_default(self) -> None:
cfg = Config(_minimal_raw())
assert cfg.stage_count == 5
class TestConfigPathsArePathlib:
"""test_config_paths_are_pathlib -- all path attributes are Path objects."""
PATH_ATTRS = [
"claude_dir",
"wiki_dir",
"skills_dir",
"agents_dir",
"skill_manifest",
"intent_log",
"pending_skills",
"skill_registry",
"stack_profile_tmp",
"catalog",
]
@pytest.mark.parametrize("attr", PATH_ATTRS)
def test_attr_is_path(
self,
attr: str,
tmp_path: Path,
monkeypatch: pytest.MonkeyPatch,
) -> None:
cfg = Config(_minimal_raw())
assert isinstance(getattr(cfg, attr), Path), (
f"cfg.{attr} should be a Path, got {type(getattr(cfg, attr))}"
)
if attr == "stack_profile_tmp":
raw = _minimal_raw()
del raw["paths"]["stack_profile_tmp"]
monkeypatch.setattr(tempfile, "gettempdir", lambda: str(tmp_path))
cfg = Config(raw)
assert cfg.stack_profile_tmp == tmp_path / "skill-stack-profile.json"
class TestConfigExpandTilde:
"""test_config_expand_tilde -- paths with ~ are expanded to absolute paths."""
def test_wiki_dir_is_absolute(self) -> None:
cfg = Config(_minimal_raw())
assert cfg.wiki_dir.is_absolute(), (
f"wiki_dir should be absolute after ~ expansion, got: {cfg.wiki_dir}"
)
def test_skills_dir_is_absolute(self) -> None:
cfg = Config(_minimal_raw())
assert cfg.skills_dir.is_absolute()
def test_claude_dir_is_absolute(self) -> None:
cfg = Config(_minimal_raw())
assert cfg.claude_dir.is_absolute()
def test_custom_tilde_path_expanded(self) -> None:
raw = _minimal_raw({"paths": {"wiki_dir": "~/custom-wiki"}})
cfg = Config(raw)
assert "~" not in str(cfg.wiki_dir)
assert cfg.wiki_dir.is_absolute()
class TestConfigReload:
"""test_config_reload -- reload() picks up changes to the raw config."""
def test_reload_updates_singleton(self, tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> None:
# Write a temporary default config with a custom line_threshold
custom_config = tmp_path / "config.json"
import json
custom_config.write_text(
json.dumps({"skill_transformer": {"line_threshold": 999}}),
encoding="utf-8",
)
# Patch the module-level constants so _load_raw reads our file
monkeypatch.setattr(ctx_config, "_DEFAULT_CONFIG", custom_config)
# Also suppress user config so it doesn't bleed in
monkeypatch.setattr(ctx_config, "_USER_CONFIG", tmp_path / "nonexistent.json")
ctx_config.reload()
assert ctx_config.cfg.line_threshold == 999
def test_reload_restores_after_monkeypatch(
self, tmp_path: Path, monkeypatch: pytest.MonkeyPatch
) -> None:
"""After reload with empty config the attribute still exists (defaults apply)."""
empty_config = tmp_path / "empty.json"
empty_config.write_text("{}", encoding="utf-8")
monkeypatch.setattr(ctx_config, "_DEFAULT_CONFIG", empty_config)
monkeypatch.setattr(ctx_config, "_USER_CONFIG", tmp_path / "nonexistent.json")
ctx_config.reload()
# line_threshold should fall back to the packaged default 180
assert ctx_config.cfg.line_threshold == 180
class TestConfigAllSkillDirs:
"""test_config_all_skill_dirs -- all_skill_dirs() returns a list of existing dirs."""
def test_returns_list(self) -> None:
cfg = Config(_minimal_raw())
result = cfg.all_skill_dirs()
assert isinstance(result, list)
def test_contains_only_existing_dirs(self) -> None:
cfg = Config(_minimal_raw())
for d in cfg.all_skill_dirs():
assert d.exists() and d.is_dir(), f"{d} does not exist or is not a directory"
def test_extra_dirs_included_when_they_exist(self, tmp_path: Path) -> None:
extra = tmp_path / "extra-skills"
extra.mkdir()
raw = _minimal_raw({"extra_skill_dirs": [str(extra)]})
cfg = Config(raw)
assert extra in cfg.all_skill_dirs()
def test_nonexistent_extra_dirs_excluded(self, tmp_path: Path) -> None:
ghost = tmp_path / "ghost-skills"
# intentionally do NOT create it
raw = _minimal_raw({"extra_skill_dirs": [str(ghost)]})
cfg = Config(raw)
assert ghost not in cfg.all_skill_dirs()
class TestConfigDeepMerge:
"""test_config_deep_merge -- nested dicts merge correctly and override wins."""
def test_override_scalar_wins(self) -> None:
base: dict[str, Any] = {"a": 1, "b": 2}
override: dict[str, Any] = {"b": 99}
_deep_merge(base, override)
assert base["b"] == 99
assert base["a"] == 1 # untouched
def test_nested_dict_merged_not_replaced(self) -> None:
base: dict[str, Any] = {"paths": {"wiki_dir": "~/wiki", "skills_dir": "~/skills"}}
override: dict[str, Any] = {"paths": {"wiki_dir": "~/custom-wiki"}}
_deep_merge(base, override)
# wiki_dir is overridden
assert base["paths"]["wiki_dir"] == "~/custom-wiki"
# skills_dir is preserved from base
assert base["paths"]["skills_dir"] == "~/skills"
def test_new_key_added(self) -> None:
base: dict[str, Any] = {"x": 1}
override: dict[str, Any] = {"y": 2}
_deep_merge(base, override)
assert base["y"] == 2
def test_deeply_nested_override(self) -> None:
base: dict[str, Any] = {"a": {"b": {"c": 10, "d": 20}}}
override: dict[str, Any] = {"a": {"b": {"c": 99}}}
_deep_merge(base, override)
assert base["a"]["b"]["c"] == 99
assert base["a"]["b"]["d"] == 20
def test_override_replaces_non_dict_with_scalar(self) -> None:
base: dict[str, Any] = {"a": {"nested": True}}
override: dict[str, Any] = {"a": "flat"}
_deep_merge(base, override)
assert base["a"] == "flat"
class TestConfigIntake:
"""test_config_intake -- intake gate section is exposed with defaults."""
def test_intake_defaults(self) -> None:
cfg = Config(_minimal_raw())
assert cfg.intake_enabled is True
assert cfg.intake_dup_threshold == pytest.approx(0.93)
assert cfg.intake_near_dup_threshold == pytest.approx(0.80)
assert cfg.intake_min_neighbors == 0
assert cfg.intake_min_neighbor_score == pytest.approx(0.30)
assert cfg.intake_min_body_chars == 120
assert cfg.intake_backend == "sentence-transformers"
assert cfg.intake_model is None
assert cfg.intake_base_url is None
assert cfg.intake_allow_remote is False
assert isinstance(cfg.intake_cache_root, Path)
assert cfg.intake_cache_root.is_absolute()
def test_intake_overrides_applied(self) -> None:
raw = _minimal_raw({
"intake": {
"enabled": False,
"dup_threshold": 0.95,
"near_dup_threshold": 0.80,
"min_neighbors": 2,
"min_neighbor_score": 0.50,
"min_body_chars": 200,
"embedding": {
"backend": "ollama",
"model": "nomic-embed-text",
"allow_remote": True,
},
},
})
cfg = Config(raw)
assert cfg.intake_enabled is False
assert cfg.intake_dup_threshold == pytest.approx(0.95)
assert cfg.intake_near_dup_threshold == pytest.approx(0.80)
assert cfg.intake_min_neighbors == 2
assert cfg.intake_min_neighbor_score == pytest.approx(0.50)
assert cfg.intake_min_body_chars == 200
assert cfg.intake_backend == "ollama"
assert cfg.intake_model == "nomic-embed-text"
assert cfg.intake_allow_remote is True
def test_build_intake_config_returns_dataclass(self) -> None:
from intake_gate import IntakeConfig
cfg = Config(_minimal_raw())
ic = cfg.build_intake_config()
assert isinstance(ic, IntakeConfig)
assert ic.dup_threshold == pytest.approx(0.93)
assert ic.near_dup_threshold == pytest.approx(0.80)
assert ic.min_body_chars == 120
def test_build_intake_config_honours_overrides(self) -> None:
raw = _minimal_raw({
"intake": {"dup_threshold": 0.91, "near_dup_threshold": 0.75},
})
cfg = Config(raw)
ic = cfg.build_intake_config()
assert ic.dup_threshold == pytest.approx(0.91)
assert ic.near_dup_threshold == pytest.approx(0.75)
def test_build_intake_embedder_returns_sentence_transformer(self) -> None:
from embedding_backend import SentenceTransformerEmbedder
cfg = Config(_minimal_raw())
emb = cfg.build_intake_embedder()
assert isinstance(emb, SentenceTransformerEmbedder)
def test_build_intake_embedder_ollama_selection(self) -> None:
from embedding_backend import OllamaEmbedder
raw = _minimal_raw({
"intake": {"embedding": {"backend": "ollama"}},
})
cfg = Config(raw)
emb = cfg.build_intake_embedder()
assert isinstance(emb, OllamaEmbedder)
def test_non_string_model_falls_back_to_none(self) -> None:
raw = _minimal_raw({
"intake": {"embedding": {"model": 42}}, # wrong type
})
cfg = Config(raw)
assert cfg.intake_model is None
|