File size: 13,257 Bytes
3fbbaab 21ff762 3fbbaab 1bbe168 3fbbaab 0bcc198 3fbbaab 7609903 3fbbaab 1b56ed2 3fbbaab 21ff762 3fbbaab 7609903 3fbbaab 0bcc198 1bbe168 424e16a 0bcc198 424e16a 0bcc198 424e16a 0bcc198 424e16a 0bcc198 424e16a 0bcc198 1bbe168 0bcc198 1bbe168 0bcc198 424e16a 3fbbaab 7609903 3fbbaab 21ff762 3fbbaab 21ff762 3fbbaab 1bbe168 3fbbaab 1bbe168 3fbbaab 1bbe168 3fbbaab 1bbe168 3fbbaab | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 | """Browser-driven security coverage for ctx-monitor."""
from __future__ import annotations
import json
import os
import threading
import time
from dataclasses import dataclass
from pathlib import Path
from typing import Any, Iterator
import networkx as nx
import pytest
import ctx_monitor as cm
playwright_sync: Any = pytest.importorskip("playwright.sync_api")
pytestmark = pytest.mark.browser
@dataclass
class MonitorHarness:
base_url: str
port: int
calls: list[tuple[str, str]]
server: Any
thread: threading.Thread
def close(self) -> None:
self.server.shutdown()
self.server.server_close()
self.thread.join(timeout=2)
@pytest.fixture()
def fake_claude(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> Path:
claude = tmp_path / ".claude"
(claude / "skill-quality").mkdir(parents=True)
monkeypatch.setattr(cm, "_claude_dir", lambda: claude)
monkeypatch.setattr(cm, "_dashboard_graph_index_archives", lambda: [])
return claude
@pytest.fixture()
def page() -> Iterator[Any]:
with playwright_sync.sync_playwright() as playwright:
try:
browser = playwright.chromium.launch(headless=True)
except Exception as exc: # noqa: BLE001
if os.environ.get("CI"):
pytest.fail(f"Playwright Chromium is not available in CI: {exc}")
pytest.skip(f"Playwright Chromium is not available: {exc}")
try:
page = browser.new_page()
yield page
finally:
browser.close()
def _start_monitor(
monkeypatch: pytest.MonkeyPatch,
*,
fake_load: bool,
) -> MonitorHarness:
monkeypatch.setattr(cm, "_MONITOR_TOKEN", "browser-token")
calls: list[tuple[str, str]] = []
if fake_load:
def perform_load(slug: str, entity_type: str = "skill") -> tuple[bool, str]:
calls.append((slug, entity_type))
return True, "loaded"
monkeypatch.setattr(cm, "_perform_load", perform_load)
server = cm._make_monitor_server("127.0.0.1", 0)
thread = threading.Thread(target=server.serve_forever, daemon=True)
thread.start()
port = int(server.server_port)
return MonitorHarness(
base_url=f"http://127.0.0.1:{port}",
port=port,
calls=calls,
server=server,
thread=thread,
)
def _write_wiki_entity(root: Path, entity_type: str, slug: str, body: str) -> None:
sub = {
"skill": "skills",
"agent": "agents",
"mcp-server": "mcp-servers/g",
"harness": "harnesses",
}[entity_type]
path = root / "skill-wiki" / "entities" / sub / f"{slug}.md"
path.parent.mkdir(parents=True, exist_ok=True)
path.write_text(body, encoding="utf-8")
def _wait_for_browser_state(page: Any, expression: str, *, timeout: float = 5.0) -> None:
deadline = time.monotonic() + timeout
while time.monotonic() < deadline:
if page.evaluate(expression):
return
time.sleep(0.05)
raise AssertionError(f"timed out waiting for browser state: {expression}")
def test_graph_page_uses_builtin_svg_renderer(
fake_claude: Path,
monkeypatch: pytest.MonkeyPatch,
page: Any,
) -> None:
G = nx.Graph()
G.add_node("skill:python-patterns", label="python-patterns", type="skill", tags=["python"])
G.add_node(
"agent:code-reviewer",
label="code-reviewer",
type="agent",
tags=["review"],
quality_score=0.95,
usage_score=0.8,
)
G.add_node(
"mcp-server:github-mcp-server",
label="github-mcp-server",
type="mcp-server",
tags=["github"],
quality_score=0.1,
usage_score=0.0,
)
G.add_node("harness:langgraph", label="langgraph", type="harness", tags=["agent"])
G.add_edge("skill:python-patterns", "agent:code-reviewer", weight=0.9, shared_tags=["review"])
G.add_edge("skill:python-patterns", "mcp-server:github-mcp-server", weight=0.8, shared_tags=["github"])
G.add_edge("skill:python-patterns", "harness:langgraph", weight=0.7, shared_tags=["agent"])
monkeypatch.setattr(cm, "_load_dashboard_graph", lambda: G)
_write_wiki_entity(fake_claude, "skill", "python-patterns", "# python-patterns\n")
_write_wiki_entity(fake_claude, "agent", "code-reviewer", "# code-reviewer\n")
harness = _start_monitor(monkeypatch, fake_load=False)
try:
page.goto(f"{harness.base_url}/graph?slug=python-patterns&type=skill")
page.wait_for_selector("[data-testid='graph-renderer']", timeout=5000)
assert "4 nodes" in page.locator("#msg").inner_text()
assert page.locator("[data-testid='graph-svg-node']").count() == 4
assert page.locator("[data-testid='graph-fallback-node']").count() == 4
assert "Graph renderer unavailable" not in page.locator("#cy").inner_text()
reviewer_radius = float(page.locator(
"[data-3d-node-id='agent:code-reviewer'] [data-testid='graph-svg-node']",
).get_attribute("r") or "0")
mcp_radius = float(page.locator(
"[data-3d-node-id='mcp-server:github-mcp-server'] [data-testid='graph-svg-node']",
).get_attribute("r") or "0")
assert reviewer_radius > mcp_radius
page.fill("#tag-filter", "review")
_wait_for_browser_state(
page,
"() => document.getElementById('graph-match-count').textContent === '2 visible'",
timeout=5.0,
)
page.locator("[data-testid='graph-fallback-node'][data-slug='code-reviewer']").click()
page.wait_for_url("**/wiki/code-reviewer?type=agent", timeout=5000)
assert "code-reviewer" in page.locator("h1").inner_text()
finally:
harness.close()
def test_events_page_shows_backlog_and_appends_live_events(
fake_claude: Path,
monkeypatch: pytest.MonkeyPatch,
page: Any,
) -> None:
audit_path = fake_claude / "ctx-audit.jsonl"
audit_path.write_text(
json.dumps({
"ts": "2026-04-28T00:00:00Z",
"event": "skill.loaded",
"subject": "python-patterns",
"session_id": "events-page-backlog",
}) + "\n",
encoding="utf-8",
)
harness = _start_monitor(monkeypatch, fake_load=False)
try:
page.goto(f"{harness.base_url}/events")
page.wait_for_selector("#stream", timeout=5000)
assert "Showing last 1 audit events" in page.locator("body").inner_text()
assert "events-page-backlog" in page.locator("#stream").inner_text()
with audit_path.open("a", encoding="utf-8") as fh:
fh.write(json.dumps({
"ts": "2026-04-28T00:00:01Z",
"event": "agent.loaded",
"subject": "repo-reviewer",
"session_id": "events-page-live",
}) + "\n")
_wait_for_browser_state(
page,
"() => document.getElementById('stream').textContent.includes('events-page-live')",
timeout=5.0,
)
status_text = page.locator("#stream-status").inner_text()
assert status_text in {"connected; waiting for new events", "live"}
finally:
harness.close()
def test_loaded_page_token_controls_browser_mutations(
fake_claude: Path,
monkeypatch: pytest.MonkeyPatch,
page: Any,
) -> None:
(fake_claude / "skill-manifest.json").write_text(
json.dumps({"load": [], "unload": [], "warnings": []}),
encoding="utf-8",
)
harness = _start_monitor(monkeypatch, fake_load=True)
try:
page.goto(f"{harness.base_url}/loaded")
page.wait_for_load_state("networkidle")
missing_token = page.evaluate("""
async () => {
const r = await fetch('/api/load', {
method: 'POST',
headers: {'Content-Type': 'application/json'},
body: JSON.stringify({slug: 'python-patterns'})
});
return {status: r.status, body: await r.json()};
}
""")
assert missing_token["status"] == 403
assert "token" in missing_token["body"]["detail"]
assert harness.calls == []
with_token = page.evaluate("""
async () => {
const r = await fetch('/api/load', {
method: 'POST',
headers: {
'Content-Type': 'application/json',
'X-CTX-Monitor-Token': CTX_MONITOR_TOKEN
},
body: JSON.stringify({slug: 'python-patterns'})
});
return {status: r.status, body: await r.json()};
}
""")
assert with_token == {"status": 200, "body": {"ok": True, "detail": "loaded"}}
assert harness.calls == [("python-patterns", "skill")]
finally:
harness.close()
def test_cross_origin_browser_post_cannot_mutate(
fake_claude: Path,
monkeypatch: pytest.MonkeyPatch,
page: Any,
) -> None:
harness = _start_monitor(monkeypatch, fake_load=True)
try:
page.goto("data:text/html,<html><body>cross-origin</body></html>")
result = page.evaluate(
"""
async (url) => {
try {
await fetch(url, {
method: 'POST',
headers: {'Content-Type': 'text/plain'},
body: JSON.stringify({slug: 'cross-origin'})
});
} catch (_) {
return false;
}
return true;
}
""",
f"{harness.base_url}/api/load",
)
assert result is False
assert harness.calls == []
finally:
harness.close()
def test_browser_load_rejects_traversal_slug(
fake_claude: Path,
monkeypatch: pytest.MonkeyPatch,
page: Any,
) -> None:
harness = _start_monitor(monkeypatch, fake_load=False)
try:
page.goto(f"{harness.base_url}/loaded")
page.wait_for_load_state("networkidle")
result = page.evaluate("""
async () => {
const r = await fetch('/api/load', {
method: 'POST',
headers: {
'Content-Type': 'application/json',
'X-CTX-Monitor-Token': CTX_MONITOR_TOKEN
},
body: JSON.stringify({slug: '../secret'})
});
return {status: r.status, body: await r.json()};
}
""")
assert result["status"] == 400
assert "invalid slug" in result["body"]["detail"]
finally:
harness.close()
def test_browser_sse_streams_do_not_block_json_requests(
fake_claude: Path,
monkeypatch: pytest.MonkeyPatch,
page: Any,
) -> None:
harness = _start_monitor(monkeypatch, fake_load=False)
try:
audit_path = fake_claude / "ctx-audit.jsonl"
audit_path.write_text("", encoding="utf-8")
page.goto(f"{harness.base_url}/loaded")
page.wait_for_load_state("networkidle")
page.evaluate("""
() => {
window.__ctxEvents = [];
window.__ctxOpenCount = 0;
window.__ctxSourceA = new EventSource('/api/events.stream');
window.__ctxSourceB = new EventSource('/api/events.stream');
window.__ctxSourceA.onopen = () => { window.__ctxOpenCount += 1; };
window.__ctxSourceB.onopen = () => { window.__ctxOpenCount += 1; };
window.__ctxSourceA.onmessage = (event) => window.__ctxEvents.push(['a', event.data]);
window.__ctxSourceB.onmessage = (event) => window.__ctxEvents.push(['b', event.data]);
}
""")
_wait_for_browser_state(
page,
"() => window.__ctxOpenCount && window.__ctxOpenCount >= 2",
timeout=5.0,
)
audit_path.write_text(
json.dumps({
"ts": "2026-04-28T00:00:00Z",
"event": "skill.loaded",
"subject": "python-patterns",
"session_id": "browser-sse",
}) + "\n",
encoding="utf-8",
)
_wait_for_browser_state(
page,
"() => window.__ctxEvents && window.__ctxEvents.length >= 2",
timeout=5.0,
)
events = page.evaluate("() => window.__ctxEvents")
assert {row[0] for row in events} == {"a", "b"}
assert all("browser-sse" in row[1] for row in events)
status = page.evaluate("""
async () => {
const r = await fetch('/api/sessions.json');
await r.json();
return r.status;
}
""")
assert status == 200
page.evaluate("() => { window.__ctxSourceA.close(); window.__ctxSourceB.close(); }")
finally:
harness.close()
|