ctx / src /tests /test_ci_preflight.py
Stevesolun's picture
Sync ctx 7eed91d (part 3)
a0830a1 verified
Raw
History Blame Contribute Delete
12.3 kB
from __future__ import annotations
import hashlib
import json
import shlex
from pathlib import Path
import yaml # type: ignore[import-untyped]
from scripts import ci_preflight
from scripts import local_fast_gate
from scripts.ci_preflight import _run_no_test_policy_for_files
from scripts.ci_preflight import Check
from scripts.ci_preflight import PUBLIC_DOCS_TRACKER_TESTS
from scripts.ci_preflight import select_checks
def _checks_for(files: list[str], *, profile: str = "pr") -> list[Check]:
checks, _notes = select_checks(
base_ref="origin/main",
files=files,
profile=profile,
python="python",
)
return checks
def _names_for(files: list[str], *, profile: str = "pr") -> list[str]:
checks = _checks_for(files, profile=profile)
return [check.name for check in checks]
def _workflow_docs_tracker_tests() -> tuple[str, ...]:
workflow = yaml.safe_load(Path(".github/workflows/test.yml").read_text(encoding="utf-8"))
steps = workflow["jobs"]["docs-check"]["steps"]
run = next(
step["run"] for step in steps if step.get("name") == "Run public docs tracker checks"
)
command = " ".join(line.rstrip("\\").strip() for line in run.splitlines() if line.strip())
argv = shlex.split(command)
assert argv[:5] == ["python", "-m", "pytest", "-q", "--no-cov"]
return tuple(argv[5:])
def test_pr_docs_workflow_tracker_tests_match_preflight() -> None:
assert _workflow_docs_tracker_tests() == PUBLIC_DOCS_TRACKER_TESTS
def test_preflight_runs_docs_gate_for_docs_changes() -> None:
names = _names_for(["docs/index.md"])
tracker_checks = _checks_for(["qa/bug_smoke_status.csv"])
tracker_names = [check.name for check in tracker_checks]
public_docs_tracker = next(
check for check in tracker_checks if check.name == "public docs tracker"
)
assert "repo stats" in names
assert "docs strict build" in names
assert "no-test policy" not in names
assert "unit-linux equivalent" not in names
assert "docs strict build" in tracker_names
assert "unit-linux equivalent" not in tracker_names
assert "src/tests/test_bug_smoke_tracker.py" in public_docs_tracker.argv
assert "src/tests/test_dashboard_user_story_tracker.py" in public_docs_tracker.argv
def test_preflight_runs_source_gates_for_source_changes() -> None:
names = _names_for(["src/ctx/adapters/generic/loop.py"])
assert "no-test policy" in names
assert "ruff format" in names
assert "ruff" in names
assert "mypy" in names
assert "unit-linux equivalent" in names
assert "A-Z canary" in names
assert "clean host contract" in names
def test_preflight_runs_graph_validation_for_graph_artifacts() -> None:
names = _names_for(["graph/wiki-graph.tar.gz"])
lanes = local_fast_gate.group_checks(_checks_for(["graph/wiki-graph.tar.gz"]))
graph_lane = next(lane for lane in lanes if lane.name == "graph")
graph_names = [check.name for check in graph_lane.checks]
assert names.index("hydrate graph LFS") < names.index("graph artifact validation")
assert "graph artifact validation" in names
assert "no-test policy" not in names
assert "unit-linux equivalent" not in names
assert graph_names == ["hydrate graph LFS", "graph artifact validation"]
assert graph_lane.checks[0].argv[1] == "scripts/ci_preflight.py"
def test_local_fast_whitespace_check_runs_against_base() -> None:
whitespace = next(
check for check in _checks_for(["src/ctx/cli/run.py"]) if check.name == "whitespace"
)
lanes = local_fast_gate.group_checks([whitespace])
assert lanes[0].name == "cheap"
assert lanes[0].checks[0].argv == (
"python",
"scripts/ci_preflight.py",
"--base",
"origin/main",
"--internal-whitespace",
)
def test_local_fast_lane_filters_are_composable() -> None:
lanes = local_fast_gate.group_checks(_checks_for([".github/workflows/test.yml"]))
filtered = local_fast_gate.filter_lanes(
lanes,
include=("static", "unit", "feature"),
skip=("feature",),
)
assert [lane.name for lane in filtered] == ["static", "unit"]
def test_local_fast_main_accepts_repeated_lane_args(monkeypatch, capsys) -> None:
checks = [
Check("ruff", ("python", "-m", "ruff", "check", "src")),
Check("unit-linux equivalent", ("python", "-m", "pytest", "-q")),
Check("build wheel", ("python", "-m", "build")),
]
monkeypatch.setattr(local_fast_gate.shutil, "which", lambda _name: "/usr/bin/git")
monkeypatch.setattr(local_fast_gate, "changed_files", lambda _base: ["src/ctx/cli/run.py"])
monkeypatch.setattr(
local_fast_gate,
"select_checks",
lambda **_kwargs: (checks, []),
)
assert local_fast_gate.main(["--dry-run", "--lane", "static", "--lane", "unit"]) == 0
out = capsys.readouterr().out
assert "[lane] static" in out
assert "[lane] unit" in out
assert "[lane] package" not in out
def test_local_fast_summary_json_records_lane_timings(tmp_path: Path) -> None:
summary_path = tmp_path / "gate" / "summary.json"
result = local_fast_gate.GateResult(
returncode=0,
elapsed=1.2345,
worker_count=2,
lanes=(
local_fast_gate.LaneResult(
name="cheap",
returncode=0,
elapsed=0.4567,
check_count=3,
),
),
)
local_fast_gate.write_summary_json(summary_path, result)
payload = json.loads(summary_path.read_text(encoding="utf-8"))
assert payload == {
"elapsed_seconds": 1.234,
"lanes": [
{
"check_count": 3,
"elapsed_seconds": 0.457,
"name": "cheap",
"returncode": 0,
"worktree": None,
}
],
"returncode": 0,
"worker_count": 2,
}
def test_local_fast_omits_deleted_worktree_paths(monkeypatch, tmp_path: Path) -> None:
worktree = tmp_path / "cheap"
removed: list[Path] = []
lane = local_fast_gate.Lane(
name="cheap",
checks=(Check("whitespace", ("python", "-V")),),
)
monkeypatch.setattr(local_fast_gate, "_create_worktree", lambda _name: worktree)
monkeypatch.setattr(local_fast_gate, "_remove_worktree", removed.append)
monkeypatch.setattr(local_fast_gate, "_run_check", lambda *args, **_kwargs: 0)
result = local_fast_gate.run_lane(lane, keep_worktrees=False)
assert result.worktree is None
assert removed == [worktree]
def test_local_fast_kept_worktree_paths_remain_in_summary(monkeypatch, tmp_path: Path) -> None:
worktree = tmp_path / "cheap"
removed: list[Path] = []
lane = local_fast_gate.Lane(
name="cheap",
checks=(Check("whitespace", ("python", "-V")),),
)
monkeypatch.setattr(local_fast_gate, "_create_worktree", lambda _name: worktree)
monkeypatch.setattr(local_fast_gate, "_remove_worktree", removed.append)
monkeypatch.setattr(local_fast_gate, "_run_check", lambda *args, **_kwargs: 0)
result = local_fast_gate.run_lane(lane, keep_worktrees=True)
assert result.worktree == worktree
assert removed == []
def test_preflight_graph_lfs_pointer_verification(tmp_path: Path, monkeypatch) -> None:
monkeypatch.setattr(ci_preflight, "REPO_ROOT", tmp_path)
artifact = tmp_path / "graph" / "wiki-graph.tar.gz"
artifact.parent.mkdir()
payload = b"hydrated graph payload"
expected_sha256 = hashlib.sha256(payload).hexdigest()
artifact.write_text(
"version https://git-lfs.github.com/spec/v1\n"
f"oid sha256:{expected_sha256}\n"
f"size {len(payload)}\n",
encoding="utf-8",
)
pointer = ci_preflight._read_lfs_pointer(artifact)
assert pointer == ci_preflight.LfsPointer(
"graph/wiki-graph.tar.gz",
expected_sha256,
len(payload),
)
artifact.write_bytes(payload)
ci_preflight._verify_hydrated_lfs_pointer(pointer)
def test_preflight_graph_lfs_pull_uses_per_command_filters(
tmp_path: Path,
monkeypatch,
) -> None:
monkeypatch.setattr(ci_preflight, "REPO_ROOT", tmp_path)
monkeypatch.setattr(ci_preflight.shutil, "which", lambda _name: "/usr/bin/git")
artifact = tmp_path / "graph" / "wiki-graph.tar.gz"
artifact.parent.mkdir()
artifact.write_text(
f"version https://git-lfs.github.com/spec/v1\noid sha256:{'a' * 64}\nsize 1\n",
encoding="utf-8",
)
calls: list[list[str]] = []
class Result:
returncode = 0
def fake_run(argv: list[str], **_kwargs) -> Result:
calls.append(argv)
return Result()
verified: list[ci_preflight.LfsPointer] = []
monkeypatch.setattr(ci_preflight.subprocess, "run", fake_run)
monkeypatch.setattr(ci_preflight, "_verify_hydrated_lfs_pointer", verified.append)
assert ci_preflight.hydrate_graph_lfs_artifacts() == 0
assert len(calls) == 1
argv = calls[0]
lfs_index = argv.index("lfs")
assert argv[:lfs_index] == ["git", *ci_preflight.GIT_LFS_FILTER_CONFIG]
assert argv[lfs_index:] == [
"lfs",
"pull",
"--include",
"graph/wiki-graph.tar.gz",
"--exclude",
"",
]
assert verified == [
ci_preflight.LfsPointer("graph/wiki-graph.tar.gz", "a" * 64, 1),
]
def test_preflight_no_test_policy_invocation_uses_current_dirty_file_set() -> None:
checks, _notes = select_checks(
base_ref="origin/main",
files=["scripts/ci_preflight.py"],
profile="pr",
python="python",
)
policy = next(check for check in checks if check.name == "no-test policy")
assert policy.argv[0] == "python"
assert Path(policy.argv[1]).name == "ci_preflight.py"
assert policy.argv[2:] == ("--base", "origin/main", "--internal-no-test-policy")
def test_internal_no_test_policy_fails_dirty_contract_without_tests() -> None:
assert _run_no_test_policy_for_files(["src/ctx/adapters/generic/loop.py"]) == 1
def test_internal_no_test_policy_accepts_dirty_contract_with_tests() -> None:
assert (
_run_no_test_policy_for_files(
[
"src/ctx/adapters/generic/loop.py",
"src/tests/test_harness_loop.py",
]
)
== 0
)
def test_internal_no_test_policy_rejects_metadata_without_diff_context() -> None:
assert _run_no_test_policy_for_files(["pyproject.toml"], diffs_by_file={}) == 1
def test_preflight_pr_profile_runs_package_build_for_source_prs() -> None:
checks, _notes = select_checks(
base_ref="origin/main",
files=["pyproject.toml"],
profile="pr",
python="python",
)
assert "build wheel" in [check.name for check in checks]
assert "twine check" in [check.name for check in checks]
def test_preflight_full_profile_forces_source_gates_for_docs_changes() -> None:
names = _names_for(["docs/index.md"], profile="full")
assert "unit-linux equivalent" in names
assert "build wheel" in names
def test_preflight_runs_browser_and_similarity_when_classified() -> None:
names = _names_for([".github/workflows/test.yml"])
lanes = local_fast_gate.group_checks(_checks_for([".github/workflows/test.yml"]))
lane_names = [lane.name for lane in lanes]
workflow = yaml.safe_load(Path(".github/workflows/test.yml").read_text(encoding="utf-8"))
graph_steps = workflow["jobs"]["graph-check"]["steps"]
graph_resolver_script = next(
step["run"]
for step in graph_steps
if step.get("name") == "Resolve graph artifacts from release assets or targeted LFS"
)
assert "browser monitor security" in names
assert "similarity precision/recall" in names
assert "cheap" in lane_names
assert "static" in lane_names
assert "unit" in lane_names
assert "feature" in lane_names
assert "package" in lane_names
assert "release_asset_wait_seconds = 300" in graph_resolver_script
assert 'os.environ.get("GITHUB_EVENT_NAME") == "pull_request"' in graph_resolver_script
assert "release_asset_wait_seconds = 0" in graph_resolver_script
assert 'env.setdefault("GIT_LFS_CONCURRENTTRANSFERS", "1")' in graph_resolver_script